{"action":"created","comment":{"url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/comments/171325320","pull_request_review_id":100158152,"id":171325320,"diff_hunk":"@@ -0,0 +1,223 @@\n+import React from 'react'\n+import PropTypes from 'prop-types'\n+import { Link } from 'react-router'\n+\n+import { InputBlock, CountrySelect, StateSelect } from 'GiraffeUI/petition'\n+import { Button } from 'GiraffeUI/button'\n+\n+const SignatureAddForm = ({\n+  submit,\n+  creator,\n+  petition,\n+  user,\n+  volunteer,\n+  onClickVolunteer,\n+  thirdPartyOptin,\n+  setThirdPartyOptin,\n+  country,\n+  onChangeCountry,\n+  showOptinWarning,\n+  showOptinCheckbox,\n+  showAddressFields,\n+  requireAddressFields,\n+  onUnrecognize,\n+  updateStateFromValue,\n+  getValueFromState: getValue,\n+  validationError\n+}) => (\n+  <form onSubmit={submit} className='sign-form'>\n+    <h4>SIGN THIS PETITION</h4>\n+    {user.signonId ? (\n+      // Recognized\n+      // TODO: Needs design\n+      <div>\n+        <strong>Welcome back {user.given_name}!</strong>\n+        <div>\n+          (Not {user.given_name}? <a onClick={onUnrecognize}>Click here.</a>)\n+        </div>\n+      </div>\n+    ) : (\n+      // Anonymous\n+      <div>","path":"src/components/theme-giraffe/signature-add-form.js","position":41,"original_position":41,"commit_id":"9a3af348bd334569543f23f1cdfee8af6f0b78e6","original_commit_id":"7beb9bf05705b2c5d389b2a928e3a38e141dd807","user":{"login":"jparkrr","id":872456,"avatar_url":"https://avatars3.githubusercontent.com/u/872456?v=4","gravatar_id":"","url":"https://api.github.com/users/jparkrr","html_url":"https://github.com/jparkrr","followers_url":"https://api.github.com/users/jparkrr/followers","following_url":"https://api.github.com/users/jparkrr/following{/other_user}","gists_url":"https://api.github.com/users/jparkrr/gists{/gist_id}","starred_url":"https://api.github.com/users/jparkrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparkrr/subscriptions","organizations_url":"https://api.github.com/users/jparkrr/orgs","repos_url":"https://api.github.com/users/jparkrr/repos","events_url":"https://api.github.com/users/jparkrr/events{/privacy}","received_events_url":"https://api.github.com/users/jparkrr/received_events","type":"User","site_admin":false},"body":"I fixed this in https://github.com/MoveOnOrg/giraffe/pull/31, which wasn't merged before, but is now.\r\n\r\nEven though it looks ok now, do you know a good way of removing the divs? I guess we could make all of the inputs into an array, but then you have to specify keys and it looks ugly IMO. Thoughts?","created_at":"2018-02-28T17:38:12Z","updated_at":"2018-02-28T17:38:12Z","html_url":"https://github.com/MoveOnOrg/mop-frontend/pull/305#discussion_r171325320","pull_request_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/comments/171325320"},"html":{"href":"https://github.com/MoveOnOrg/mop-frontend/pull/305#discussion_r171325320"},"pull_request":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305"}},"in_reply_to_id":171102786},"pull_request":{"url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305","id":171264438,"html_url":"https://github.com/MoveOnOrg/mop-frontend/pull/305","diff_url":"https://github.com/MoveOnOrg/mop-frontend/pull/305.diff","patch_url":"https://github.com/MoveOnOrg/mop-frontend/pull/305.patch","issue_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/305","number":305,"state":"open","locked":false,"title":"Giraffe sign petition (part 1)","user":{"login":"jparkrr","id":872456,"avatar_url":"https://avatars3.githubusercontent.com/u/872456?v=4","gravatar_id":"","url":"https://api.github.com/users/jparkrr","html_url":"https://github.com/jparkrr","followers_url":"https://api.github.com/users/jparkrr/followers","following_url":"https://api.github.com/users/jparkrr/following{/other_user}","gists_url":"https://api.github.com/users/jparkrr/gists{/gist_id}","starred_url":"https://api.github.com/users/jparkrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparkrr/subscriptions","organizations_url":"https://api.github.com/users/jparkrr/orgs","repos_url":"https://api.github.com/users/jparkrr/repos","events_url":"https://api.github.com/users/jparkrr/events{/privacy}","received_events_url":"https://api.github.com/users/jparkrr/received_events","type":"User","site_admin":false},"body":"Trying to divide into multiple PRs.\r\n\r\nThis one contains the petition card (the blue box). It was a little unclear from the design, so I just put the petition summary here. These parts of the petition can easily be moved around.\r\n\r\nIt also contains the petition details under the card contains the full text of the petition as well as the author and some share buttons that aren't hooked up yet.\r\n\r\nIt also contains the signature add form that actually works pretty well, thanks to the logic that already existed. (Small design changes needed). I was able to edit all of the existing tests for this component to apply equally to both the legacy and giraffe versions.\r\n\r\nIn this PR I introduce a new way of including certain SVGs: we include the sprite sheet in index.html with 'html-webpack-inline-svg-plugin' and reference them using `<use>` tags. This was necessary to make them work without CSS changes. Still the facebook svg isn't rendering for some reason...\r\n\r\nStill todo:\r\n- Design updates for the signature list\r\n- Add the mobile sign button and modal form\r\n- Figure out what to do with the share buttons and implement\r\n- updates to the design of validation errors and petition messages.","created_at":"2018-02-26T01:20:53Z","updated_at":"2018-02-28T17:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2828b298aa43b5e3fab0cee07fafe25de4b9573a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":843225814,"url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/labels/redesign","name":"redesign","color":"0a7084","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305/commits","review_comments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305/comments","review_comment_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/305/comments","statuses_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/statuses/9a3af348bd334569543f23f1cdfee8af6f0b78e6","head":{"label":"MoveOnOrg:giraffe-sign","ref":"giraffe-sign","sha":"9a3af348bd334569543f23f1cdfee8af6f0b78e6","user":{"login":"MoveOnOrg","id":15254795,"avatar_url":"https://avatars3.githubusercontent.com/u/15254795?v=4","gravatar_id":"","url":"https://api.github.com/users/MoveOnOrg","html_url":"https://github.com/MoveOnOrg","followers_url":"https://api.github.com/users/MoveOnOrg/followers","following_url":"https://api.github.com/users/MoveOnOrg/following{/other_user}","gists_url":"https://api.github.com/users/MoveOnOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/MoveOnOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoveOnOrg/subscriptions","organizations_url":"https://api.github.com/users/MoveOnOrg/orgs","repos_url":"https://api.github.com/users/MoveOnOrg/repos","events_url":"https://api.github.com/users/MoveOnOrg/events{/privacy}","received_events_url":"https://api.github.com/users/MoveOnOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":76693752,"name":"mop-frontend","full_name":"MoveOnOrg/mop-frontend","owner":{"login":"MoveOnOrg","id":15254795,"avatar_url":"https://avatars3.githubusercontent.com/u/15254795?v=4","gravatar_id":"","url":"https://api.github.com/users/MoveOnOrg","html_url":"https://github.com/MoveOnOrg","followers_url":"https://api.github.com/users/MoveOnOrg/followers","following_url":"https://api.github.com/users/MoveOnOrg/following{/other_user}","gists_url":"https://api.github.com/users/MoveOnOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/MoveOnOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoveOnOrg/subscriptions","organizations_url":"https://api.github.com/users/MoveOnOrg/orgs","repos_url":"https://api.github.com/users/MoveOnOrg/repos","events_url":"https://api.github.com/users/MoveOnOrg/events{/privacy}","received_events_url":"https://api.github.com/users/MoveOnOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MoveOnOrg/mop-frontend","description":"The new React interface for MoveOn Petitions","fork":false,"url":"https://api.github.com/repos/MoveOnOrg/mop-frontend","forks_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/forks","keys_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/teams","hooks_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/hooks","issue_events_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/events","assignees_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/tags","blobs_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/languages","stargazers_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/stargazers","contributors_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/contributors","subscribers_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/subscribers","subscription_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/subscription","commits_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/merges","archive_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/downloads","issues_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/labels{/name}","releases_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/deployments","created_at":"2016-12-16T23:58:36Z","updated_at":"2018-02-14T17:18:40Z","pushed_at":"2018-02-28T17:35:25Z","git_url":"git://github.com/MoveOnOrg/mop-frontend.git","ssh_url":"git@github.com:MoveOnOrg/mop-frontend.git","clone_url":"https://github.com/MoveOnOrg/mop-frontend.git","svn_url":"https://github.com/MoveOnOrg/mop-frontend","homepage":"https://petitions.moveon.org","size":847,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":60,"watchers":3,"default_branch":"main"}},"base":{"label":"MoveOnOrg:282-giraffe-footer","ref":"282-giraffe-footer","sha":"179ec7cc0e1039c98ef98001b9495910bc48a96f","user":{"login":"MoveOnOrg","id":15254795,"avatar_url":"https://avatars3.githubusercontent.com/u/15254795?v=4","gravatar_id":"","url":"https://api.github.com/users/MoveOnOrg","html_url":"https://github.com/MoveOnOrg","followers_url":"https://api.github.com/users/MoveOnOrg/followers","following_url":"https://api.github.com/users/MoveOnOrg/following{/other_user}","gists_url":"https://api.github.com/users/MoveOnOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/MoveOnOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoveOnOrg/subscriptions","organizations_url":"https://api.github.com/users/MoveOnOrg/orgs","repos_url":"https://api.github.com/users/MoveOnOrg/repos","events_url":"https://api.github.com/users/MoveOnOrg/events{/privacy}","received_events_url":"https://api.github.com/users/MoveOnOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":76693752,"name":"mop-frontend","full_name":"MoveOnOrg/mop-frontend","owner":{"login":"MoveOnOrg","id":15254795,"avatar_url":"https://avatars3.githubusercontent.com/u/15254795?v=4","gravatar_id":"","url":"https://api.github.com/users/MoveOnOrg","html_url":"https://github.com/MoveOnOrg","followers_url":"https://api.github.com/users/MoveOnOrg/followers","following_url":"https://api.github.com/users/MoveOnOrg/following{/other_user}","gists_url":"https://api.github.com/users/MoveOnOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/MoveOnOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoveOnOrg/subscriptions","organizations_url":"https://api.github.com/users/MoveOnOrg/orgs","repos_url":"https://api.github.com/users/MoveOnOrg/repos","events_url":"https://api.github.com/users/MoveOnOrg/events{/privacy}","received_events_url":"https://api.github.com/users/MoveOnOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MoveOnOrg/mop-frontend","description":"The new React interface for MoveOn Petitions","fork":false,"url":"https://api.github.com/repos/MoveOnOrg/mop-frontend","forks_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/forks","keys_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/teams","hooks_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/hooks","issue_events_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/events","assignees_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/tags","blobs_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/languages","stargazers_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/stargazers","contributors_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/contributors","subscribers_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/subscribers","subscription_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/subscription","commits_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/merges","archive_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/downloads","issues_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/labels{/name}","releases_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/MoveOnOrg/mop-frontend/deployments","created_at":"2016-12-16T23:58:36Z","updated_at":"2018-02-14T17:18:40Z","pushed_at":"2018-02-28T17:35:25Z","git_url":"git://github.com/MoveOnOrg/mop-frontend.git","ssh_url":"git@github.com:MoveOnOrg/mop-frontend.git","clone_url":"https://github.com/MoveOnOrg/mop-frontend.git","svn_url":"https://github.com/MoveOnOrg/mop-frontend","homepage":"https://petitions.moveon.org","size":847,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":60,"watchers":3,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305"},"html":{"href":"https://github.com/MoveOnOrg/mop-frontend/pull/305"},"issue":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/305"},"comments":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/MoveOnOrg/mop-frontend/statuses/9a3af348bd334569543f23f1cdfee8af6f0b78e6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jparkrr"}}