{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dub/pulls/comments/243733267","pull_request_review_id":187588231,"id":243733267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzczMzI2Nw==","diff_hunk":"@@ -130,6 +130,39 @@ Json jsonFromFile(NativePath file, bool silent_fail = false) {\n \treturn parseJsonString(text, file.toNativeString());\n }\n \n+/**\n+\tRead package info file content from archive.\n+\tFile needs to be in root folder or in first\n+\tsub folder.\n+\n+\tParams:\n+\t\tzip = path to archive file\n+\t\tfileName = Package file name\n+\tReturns:\n+\t\tpackage file content.\n+*/\n+string packageInfoFileFromZip(NativePath zip, out string fileName) {\n+\timport std.zip : ZipArchive, ArchiveMember;\n+\timport dub.package_ : packageInfoFiles;\n+\n+\tauto f = openFile(zip, FileMode.read);\n+\tubyte[] b = new ubyte[cast(size_t)f.size];\n+\tf.rawRead(b);\n+\tf.close();\n+\tauto archive = new ZipArchive(b);\n+\talias PSegment = typeof (NativePath.init.head);\n+\touter: foreach (ArchiveMember am; archive.directory) {","path":"source/dub/internal/utils.d","position":34,"original_position":34,"commit_id":"c2e2693383566dc02330713e3cb6b06ee9583337","original_commit_id":"c2e2693383566dc02330713e3cb6b06ee9583337","user":{"login":"andre2007","id":1451047,"node_id":"MDQ6VXNlcjE0NTEwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1451047?v=4","gravatar_id":"","url":"https://api.github.com/users/andre2007","html_url":"https://github.com/andre2007","followers_url":"https://api.github.com/users/andre2007/followers","following_url":"https://api.github.com/users/andre2007/following{/other_user}","gists_url":"https://api.github.com/users/andre2007/gists{/gist_id}","starred_url":"https://api.github.com/users/andre2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre2007/subscriptions","organizations_url":"https://api.github.com/users/andre2007/orgs","repos_url":"https://api.github.com/users/andre2007/repos","events_url":"https://api.github.com/users/andre2007/events{/privacy}","received_events_url":"https://api.github.com/users/andre2007/received_events","type":"User","site_admin":false},"body":"Good catch:)\r\nIt is superfluous and was needed in a previous implementation, I will remove it.","created_at":"2018-12-22T10:40:19Z","updated_at":"2018-12-22T10:40:20Z","html_url":"https://github.com/dlang/dub/pull/1616#discussion_r243733267","pull_request_url":"https://api.github.com/repos/dlang/dub/pulls/1616","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/dub/pulls/comments/243733267"},"html":{"href":"https://github.com/dlang/dub/pull/1616#discussion_r243733267"},"pull_request":{"href":"https://api.github.com/repos/dlang/dub/pulls/1616"}},"in_reply_to_id":243733076},"pull_request":{"url":"https://api.github.com/repos/dlang/dub/pulls/1616","id":237454052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDU0MDUy","html_url":"https://github.com/dlang/dub/pull/1616","diff_url":"https://github.com/dlang/dub/pull/1616.diff","patch_url":"https://github.com/dlang/dub/pull/1616.patch","issue_url":"https://api.github.com/repos/dlang/dub/issues/1616","number":1616,"state":"open","locked":false,"title":"Filesystem package supplier updated","user":{"login":"andre2007","id":1451047,"node_id":"MDQ6VXNlcjE0NTEwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1451047?v=4","gravatar_id":"","url":"https://api.github.com/users/andre2007","html_url":"https://github.com/andre2007","followers_url":"https://api.github.com/users/andre2007/followers","following_url":"https://api.github.com/users/andre2007/following{/other_user}","gists_url":"https://api.github.com/users/andre2007/gists{/gist_id}","starred_url":"https://api.github.com/users/andre2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre2007/subscriptions","organizations_url":"https://api.github.com/users/andre2007/orgs","repos_url":"https://api.github.com/users/andre2007/repos","events_url":"https://api.github.com/users/andre2007/events{/privacy}","received_events_url":"https://api.github.com/users/andre2007/received_events","type":"User","site_admin":false},"body":"There was a filesystem supplier available but not registered. Also some minor additions were missing to get it working with json/sdl package descriptors.\r\n\r\nExample `dub fetch mypackage --registry=file:///etc/dub/packages/` \r\n\r\nThe file system supplier will also ease writing dub tests. You do not longer need to start a http server to test functionality like the add command (https://github.com/dlang/dub/blob/master/test/issue1574-addcommand.sh)","created_at":"2018-12-10T20:22:45Z","updated_at":"2018-12-22T10:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ef6cc6489cf4857716557ecc6e67b84e8337d27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dub/pulls/1616/commits","review_comments_url":"https://api.github.com/repos/dlang/dub/pulls/1616/comments","review_comment_url":"https://api.github.com/repos/dlang/dub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dub/issues/1616/comments","statuses_url":"https://api.github.com/repos/dlang/dub/statuses/c2e2693383566dc02330713e3cb6b06ee9583337","head":{"label":"andre2007:fix_issue_1401","ref":"fix_issue_1401","sha":"c2e2693383566dc02330713e3cb6b06ee9583337","user":{"login":"andre2007","id":1451047,"node_id":"MDQ6VXNlcjE0NTEwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1451047?v=4","gravatar_id":"","url":"https://api.github.com/users/andre2007","html_url":"https://github.com/andre2007","followers_url":"https://api.github.com/users/andre2007/followers","following_url":"https://api.github.com/users/andre2007/following{/other_user}","gists_url":"https://api.github.com/users/andre2007/gists{/gist_id}","starred_url":"https://api.github.com/users/andre2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre2007/subscriptions","organizations_url":"https://api.github.com/users/andre2007/orgs","repos_url":"https://api.github.com/users/andre2007/repos","events_url":"https://api.github.com/users/andre2007/events{/privacy}","received_events_url":"https://api.github.com/users/andre2007/received_events","type":"User","site_admin":false},"repo":{"id":136653943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NTM5NDM=","name":"dub","full_name":"andre2007/dub","private":false,"owner":{"login":"andre2007","id":1451047,"node_id":"MDQ6VXNlcjE0NTEwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1451047?v=4","gravatar_id":"","url":"https://api.github.com/users/andre2007","html_url":"https://github.com/andre2007","followers_url":"https://api.github.com/users/andre2007/followers","following_url":"https://api.github.com/users/andre2007/following{/other_user}","gists_url":"https://api.github.com/users/andre2007/gists{/gist_id}","starred_url":"https://api.github.com/users/andre2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre2007/subscriptions","organizations_url":"https://api.github.com/users/andre2007/orgs","repos_url":"https://api.github.com/users/andre2007/repos","events_url":"https://api.github.com/users/andre2007/events{/privacy}","received_events_url":"https://api.github.com/users/andre2007/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andre2007/dub","description":"Package and build management system for D","fork":true,"url":"https://api.github.com/repos/andre2007/dub","forks_url":"https://api.github.com/repos/andre2007/dub/forks","keys_url":"https://api.github.com/repos/andre2007/dub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andre2007/dub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andre2007/dub/teams","hooks_url":"https://api.github.com/repos/andre2007/dub/hooks","issue_events_url":"https://api.github.com/repos/andre2007/dub/issues/events{/number}","events_url":"https://api.github.com/repos/andre2007/dub/events","assignees_url":"https://api.github.com/repos/andre2007/dub/assignees{/user}","branches_url":"https://api.github.com/repos/andre2007/dub/branches{/branch}","tags_url":"https://api.github.com/repos/andre2007/dub/tags","blobs_url":"https://api.github.com/repos/andre2007/dub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andre2007/dub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andre2007/dub/git/refs{/sha}","trees_url":"https://api.github.com/repos/andre2007/dub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andre2007/dub/statuses/{sha}","languages_url":"https://api.github.com/repos/andre2007/dub/languages","stargazers_url":"https://api.github.com/repos/andre2007/dub/stargazers","contributors_url":"https://api.github.com/repos/andre2007/dub/contributors","subscribers_url":"https://api.github.com/repos/andre2007/dub/subscribers","subscription_url":"https://api.github.com/repos/andre2007/dub/subscription","commits_url":"https://api.github.com/repos/andre2007/dub/commits{/sha}","git_commits_url":"https://api.github.com/repos/andre2007/dub/git/commits{/sha}","comments_url":"https://api.github.com/repos/andre2007/dub/comments{/number}","issue_comment_url":"https://api.github.com/repos/andre2007/dub/issues/comments{/number}","contents_url":"https://api.github.com/repos/andre2007/dub/contents/{+path}","compare_url":"https://api.github.com/repos/andre2007/dub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andre2007/dub/merges","archive_url":"https://api.github.com/repos/andre2007/dub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andre2007/dub/downloads","issues_url":"https://api.github.com/repos/andre2007/dub/issues{/number}","pulls_url":"https://api.github.com/repos/andre2007/dub/pulls{/number}","milestones_url":"https://api.github.com/repos/andre2007/dub/milestones{/number}","notifications_url":"https://api.github.com/repos/andre2007/dub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andre2007/dub/labels{/name}","releases_url":"https://api.github.com/repos/andre2007/dub/releases{/id}","deployments_url":"https://api.github.com/repos/andre2007/dub/deployments","created_at":"2018-06-08T18:36:05Z","updated_at":"2018-12-10T20:15:40Z","pushed_at":"2018-12-17T19:48:38Z","git_url":"git://github.com/andre2007/dub.git","ssh_url":"git@github.com:andre2007/dub.git","clone_url":"https://github.com/andre2007/dub.git","svn_url":"https://github.com/andre2007/dub","homepage":null,"size":5616,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"9e5d1e9f24231ca9c0ed2f314be49679099d94d7","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":6470655,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwNjU1","name":"dub","full_name":"dlang/dub","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/dub","description":"Package and build management system for D","fork":false,"url":"https://api.github.com/repos/dlang/dub","forks_url":"https://api.github.com/repos/dlang/dub/forks","keys_url":"https://api.github.com/repos/dlang/dub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dub/teams","hooks_url":"https://api.github.com/repos/dlang/dub/hooks","issue_events_url":"https://api.github.com/repos/dlang/dub/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dub/events","assignees_url":"https://api.github.com/repos/dlang/dub/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dub/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dub/tags","blobs_url":"https://api.github.com/repos/dlang/dub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dub/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dub/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dub/languages","stargazers_url":"https://api.github.com/repos/dlang/dub/stargazers","contributors_url":"https://api.github.com/repos/dlang/dub/contributors","subscribers_url":"https://api.github.com/repos/dlang/dub/subscribers","subscription_url":"https://api.github.com/repos/dlang/dub/subscription","commits_url":"https://api.github.com/repos/dlang/dub/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dub/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dub/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dub/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dub/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dub/merges","archive_url":"https://api.github.com/repos/dlang/dub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dub/downloads","issues_url":"https://api.github.com/repos/dlang/dub/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dub/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dub/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dub/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dub/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dub/deployments","created_at":"2012-10-31T08:10:47Z","updated_at":"2018-12-21T11:19:09Z","pushed_at":"2018-12-21T11:19:00Z","git_url":"git://github.com/dlang/dub.git","ssh_url":"git@github.com:dlang/dub.git","clone_url":"https://github.com/dlang/dub.git","svn_url":"https://github.com/dlang/dub","homepage":null,"size":5622,"stargazers_count":444,"watchers_count":444,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":446,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":167,"open_issues":446,"watchers":444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dub/pulls/1616"},"html":{"href":"https://github.com/dlang/dub/pull/1616"},"issue":{"href":"https://api.github.com/repos/dlang/dub/issues/1616"},"comments":{"href":"https://api.github.com/repos/dlang/dub/issues/1616/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dub/pulls/1616/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dub/pulls/1616/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dub/statuses/c2e2693383566dc02330713e3cb6b06ee9583337"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andre2007"}}