{"action":"opened","number":2670,"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670","id":178129045,"html_url":"https://github.com/webdriverio/webdriverio/pull/2670","diff_url":"https://github.com/webdriverio/webdriverio/pull/2670.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/2670.patch","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/2670","number":2670,"state":"open","locked":false,"title":"added ability to pass in interval to waitFor commands","user":{"login":"seadb","id":5834292,"avatar_url":"https://avatars3.githubusercontent.com/u/5834292?v=4","gravatar_id":"","url":"https://api.github.com/users/seadb","html_url":"https://github.com/seadb","followers_url":"https://api.github.com/users/seadb/followers","following_url":"https://api.github.com/users/seadb/following{/other_user}","gists_url":"https://api.github.com/users/seadb/gists{/gist_id}","starred_url":"https://api.github.com/users/seadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seadb/subscriptions","organizations_url":"https://api.github.com/users/seadb/orgs","repos_url":"https://api.github.com/users/seadb/repos","events_url":"https://api.github.com/users/seadb/events{/privacy}","received_events_url":"https://api.github.com/users/seadb/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\n[//]: # (Creates the ability to pass in an optional interval for 'wait for' commands.  All these commands use waitUntil which already has an \"interval\" parameter implemented, so this just expands the functionality of the waitFor commands. )\r\n\r\n## Types of changes\r\n\r\n[//]: # (What types of changes does your code introduce to WebdriverIO?)\r\n[//]: # (_Put an `x` in the boxes that apply_)\r\n\r\n- [ ] Bugfix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n[//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._)\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\n[//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...)\r\n\r\n### Reviewers: @christian-bromann\r\n","created_at":"2018-03-28T18:47:35Z","updated_at":"2018-03-28T18:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670/commits","review_comments_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670/comments","review_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/2670/comments","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/ab6fba97f46bb8131544922c1fbd6c0b276823a0","head":{"label":"seadb:waitForInterval","ref":"waitForInterval","sha":"ab6fba97f46bb8131544922c1fbd6c0b276823a0","user":{"login":"seadb","id":5834292,"avatar_url":"https://avatars3.githubusercontent.com/u/5834292?v=4","gravatar_id":"","url":"https://api.github.com/users/seadb","html_url":"https://github.com/seadb","followers_url":"https://api.github.com/users/seadb/followers","following_url":"https://api.github.com/users/seadb/following{/other_user}","gists_url":"https://api.github.com/users/seadb/gists{/gist_id}","starred_url":"https://api.github.com/users/seadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seadb/subscriptions","organizations_url":"https://api.github.com/users/seadb/orgs","repos_url":"https://api.github.com/users/seadb/repos","events_url":"https://api.github.com/users/seadb/events{/privacy}","received_events_url":"https://api.github.com/users/seadb/received_events","type":"User","site_admin":false},"repo":{"id":124575676,"name":"webdriverio","full_name":"seadb/webdriverio","owner":{"login":"seadb","id":5834292,"avatar_url":"https://avatars3.githubusercontent.com/u/5834292?v=4","gravatar_id":"","url":"https://api.github.com/users/seadb","html_url":"https://github.com/seadb","followers_url":"https://api.github.com/users/seadb/followers","following_url":"https://api.github.com/users/seadb/following{/other_user}","gists_url":"https://api.github.com/users/seadb/gists{/gist_id}","starred_url":"https://api.github.com/users/seadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seadb/subscriptions","organizations_url":"https://api.github.com/users/seadb/orgs","repos_url":"https://api.github.com/users/seadb/repos","events_url":"https://api.github.com/users/seadb/events{/privacy}","received_events_url":"https://api.github.com/users/seadb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seadb/webdriverio","description":"A Node.js bindings implementation for the W3C WebDriver protocol","fork":true,"url":"https://api.github.com/repos/seadb/webdriverio","forks_url":"https://api.github.com/repos/seadb/webdriverio/forks","keys_url":"https://api.github.com/repos/seadb/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seadb/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seadb/webdriverio/teams","hooks_url":"https://api.github.com/repos/seadb/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/seadb/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/seadb/webdriverio/events","assignees_url":"https://api.github.com/repos/seadb/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/seadb/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/seadb/webdriverio/tags","blobs_url":"https://api.github.com/repos/seadb/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seadb/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seadb/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/seadb/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seadb/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/seadb/webdriverio/languages","stargazers_url":"https://api.github.com/repos/seadb/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/seadb/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/seadb/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/seadb/webdriverio/subscription","commits_url":"https://api.github.com/repos/seadb/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/seadb/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/seadb/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/seadb/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/seadb/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/seadb/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seadb/webdriverio/merges","archive_url":"https://api.github.com/repos/seadb/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seadb/webdriverio/downloads","issues_url":"https://api.github.com/repos/seadb/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/seadb/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/seadb/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/seadb/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seadb/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/seadb/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/seadb/webdriverio/deployments","created_at":"2018-03-09T18:01:47Z","updated_at":"2018-03-09T18:01:50Z","pushed_at":"2018-03-28T18:40:15Z","git_url":"git://github.com/seadb/webdriverio.git","ssh_url":"git@github.com:seadb/webdriverio.git","clone_url":"https://github.com/seadb/webdriverio.git","svn_url":"https://github.com/seadb/webdriverio","homepage":"http://webdriver.io","size":127037,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webdriverio:master","ref":"master","sha":"27c87141d686466ccdad57339fa3373251377cc6","user":{"login":"webdriverio","id":6512473,"avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"repo":{"id":2296970,"name":"webdriverio","full_name":"webdriverio/webdriverio","owner":{"login":"webdriverio","id":6512473,"avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webdriverio/webdriverio","description":"A Node.js bindings implementation for the W3C WebDriver protocol","fork":false,"url":"https://api.github.com/repos/webdriverio/webdriverio","forks_url":"https://api.github.com/repos/webdriverio/webdriverio/forks","keys_url":"https://api.github.com/repos/webdriverio/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio/webdriverio/teams","hooks_url":"https://api.github.com/repos/webdriverio/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio/webdriverio/events","assignees_url":"https://api.github.com/repos/webdriverio/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio/webdriverio/tags","blobs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio/webdriverio/languages","stargazers_url":"https://api.github.com/repos/webdriverio/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/webdriverio/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/webdriverio/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/webdriverio/webdriverio/subscription","commits_url":"https://api.github.com/repos/webdriverio/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio/webdriverio/merges","archive_url":"https://api.github.com/repos/webdriverio/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio/webdriverio/downloads","issues_url":"https://api.github.com/repos/webdriverio/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio/webdriverio/deployments","created_at":"2011-08-30T19:02:35Z","updated_at":"2018-03-28T14:36:31Z","pushed_at":"2018-03-27T22:10:40Z","git_url":"git://github.com/webdriverio/webdriverio.git","ssh_url":"git@github.com:webdriverio/webdriverio.git","clone_url":"https://github.com/webdriverio/webdriverio.git","svn_url":"https://github.com/webdriverio/webdriverio","homepage":"http://webdriver.io","size":127027,"stargazers_count":3855,"watchers_count":3855,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1031,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1031,"open_issues":116,"watchers":3855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670"},"html":{"href":"https://github.com/webdriverio/webdriverio/pull/2670"},"issue":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/2670"},"comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/2670/comments"},"review_comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670/comments"},"review_comment":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/2670/commits"},"statuses":{"href":"https://api.github.com/repos/webdriverio/webdriverio/statuses/ab6fba97f46bb8131544922c1fbd6c0b276823a0"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":126,"deletions":18,"changed_files":7}}
{"actor":{"display_login":"seadb"}}