{"action":"created","comment":{"url":"https://api.github.com/repos/swaywm/sway/pulls/comments/189262092","pull_request_review_id":121410824,"id":189262092,"diff_hunk":"@@ -0,0 +1,206 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>","path":"protocols/xdg-output-unstable-v1.xml","position":1,"original_position":1,"commit_id":"f82df6bc6c8ab223d292292b37f687ee1dac26d7","original_commit_id":"f82df6bc6c8ab223d292292b37f687ee1dac26d7","user":{"login":"emersion","id":506932,"avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"body":"Please don't embed the protocol in Sway, use the XML file from wayland-protocols instead.","created_at":"2018-05-18T13:08:08Z","updated_at":"2018-05-18T13:08:08Z","html_url":"https://github.com/swaywm/sway/pull/1821#discussion_r189262092","pull_request_url":"https://api.github.com/repos/swaywm/sway/pulls/1821","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/swaywm/sway/pulls/comments/189262092"},"html":{"href":"https://github.com/swaywm/sway/pull/1821#discussion_r189262092"},"pull_request":{"href":"https://api.github.com/repos/swaywm/sway/pulls/1821"}}},"pull_request":{"url":"https://api.github.com/repos/swaywm/sway/pulls/1821","id":182424944,"html_url":"https://github.com/swaywm/sway/pull/1821","diff_url":"https://github.com/swaywm/sway/pull/1821.diff","patch_url":"https://github.com/swaywm/sway/pull/1821.patch","issue_url":"https://api.github.com/repos/swaywm/sway/issues/1821","number":1821,"state":"open","locked":false,"title":"Swaylock: Allow per-output images","user":{"login":"RyanDwyer","id":2436833,"avatar_url":"https://avatars3.githubusercontent.com/u/2436833?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanDwyer","html_url":"https://github.com/RyanDwyer","followers_url":"https://api.github.com/users/RyanDwyer/followers","following_url":"https://api.github.com/users/RyanDwyer/following{/other_user}","gists_url":"https://api.github.com/users/RyanDwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanDwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanDwyer/subscriptions","organizations_url":"https://api.github.com/users/RyanDwyer/orgs","repos_url":"https://api.github.com/users/RyanDwyer/repos","events_url":"https://api.github.com/users/RyanDwyer/events{/privacy}","received_events_url":"https://api.github.com/users/RyanDwyer/received_events","type":"User","site_admin":false},"body":"This implements the output part of the `[<output>:]<path>` syntax for the `-i` argument.\r\n\r\nThe previous implementation of this PR used IPC, but that implementation has been replaced with one which uses the xdg-output protocol.\r\n\r\nTests:\r\n\r\n* Specifying no image arguments should show blank on all outputs\r\n* Specifying `-i ~/default.png` should show default.png on all outputs\r\n* Specifying `-i HDMI-A-1:~/a.png` should show a.png on that output, and all others blank\r\n* Specifying `-i HDMI-A-1:~/a.png -i ~/default.png` should show default.png on all other outputs\r\n\r\nUnusual scenario tests:\r\n\r\n* Specifying the same output (or lack of output) multiple times should pick one of them\r\n* Specifying an image that is unreadable should log an error and behave as though you didn't pass that argument","created_at":"2018-04-18T09:52:31Z","updated_at":"2018-05-18T13:08:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33d17788ea42b139e9fe02e63616354219b9dc94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaywm/sway/pulls/1821/commits","review_comments_url":"https://api.github.com/repos/swaywm/sway/pulls/1821/comments","review_comment_url":"https://api.github.com/repos/swaywm/sway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaywm/sway/issues/1821/comments","statuses_url":"https://api.github.com/repos/swaywm/sway/statuses/f82df6bc6c8ab223d292292b37f687ee1dac26d7","head":{"label":"RyanDwyer:swaylock-multiple-images","ref":"swaylock-multiple-images","sha":"f82df6bc6c8ab223d292292b37f687ee1dac26d7","user":{"login":"RyanDwyer","id":2436833,"avatar_url":"https://avatars3.githubusercontent.com/u/2436833?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanDwyer","html_url":"https://github.com/RyanDwyer","followers_url":"https://api.github.com/users/RyanDwyer/followers","following_url":"https://api.github.com/users/RyanDwyer/following{/other_user}","gists_url":"https://api.github.com/users/RyanDwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanDwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanDwyer/subscriptions","organizations_url":"https://api.github.com/users/RyanDwyer/orgs","repos_url":"https://api.github.com/users/RyanDwyer/repos","events_url":"https://api.github.com/users/RyanDwyer/events{/privacy}","received_events_url":"https://api.github.com/users/RyanDwyer/received_events","type":"User","site_admin":false},"repo":{"id":68437977,"name":"sway","full_name":"RyanDwyer/sway","owner":{"login":"RyanDwyer","id":2436833,"avatar_url":"https://avatars3.githubusercontent.com/u/2436833?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanDwyer","html_url":"https://github.com/RyanDwyer","followers_url":"https://api.github.com/users/RyanDwyer/followers","following_url":"https://api.github.com/users/RyanDwyer/following{/other_user}","gists_url":"https://api.github.com/users/RyanDwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanDwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanDwyer/subscriptions","organizations_url":"https://api.github.com/users/RyanDwyer/orgs","repos_url":"https://api.github.com/users/RyanDwyer/repos","events_url":"https://api.github.com/users/RyanDwyer/events{/privacy}","received_events_url":"https://api.github.com/users/RyanDwyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyanDwyer/sway","description":"i3-compatible Wayland compositor","fork":true,"url":"https://api.github.com/repos/RyanDwyer/sway","forks_url":"https://api.github.com/repos/RyanDwyer/sway/forks","keys_url":"https://api.github.com/repos/RyanDwyer/sway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyanDwyer/sway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyanDwyer/sway/teams","hooks_url":"https://api.github.com/repos/RyanDwyer/sway/hooks","issue_events_url":"https://api.github.com/repos/RyanDwyer/sway/issues/events{/number}","events_url":"https://api.github.com/repos/RyanDwyer/sway/events","assignees_url":"https://api.github.com/repos/RyanDwyer/sway/assignees{/user}","branches_url":"https://api.github.com/repos/RyanDwyer/sway/branches{/branch}","tags_url":"https://api.github.com/repos/RyanDwyer/sway/tags","blobs_url":"https://api.github.com/repos/RyanDwyer/sway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyanDwyer/sway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyanDwyer/sway/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyanDwyer/sway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyanDwyer/sway/statuses/{sha}","languages_url":"https://api.github.com/repos/RyanDwyer/sway/languages","stargazers_url":"https://api.github.com/repos/RyanDwyer/sway/stargazers","contributors_url":"https://api.github.com/repos/RyanDwyer/sway/contributors","subscribers_url":"https://api.github.com/repos/RyanDwyer/sway/subscribers","subscription_url":"https://api.github.com/repos/RyanDwyer/sway/subscription","commits_url":"https://api.github.com/repos/RyanDwyer/sway/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyanDwyer/sway/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyanDwyer/sway/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyanDwyer/sway/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyanDwyer/sway/contents/{+path}","compare_url":"https://api.github.com/repos/RyanDwyer/sway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyanDwyer/sway/merges","archive_url":"https://api.github.com/repos/RyanDwyer/sway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyanDwyer/sway/downloads","issues_url":"https://api.github.com/repos/RyanDwyer/sway/issues{/number}","pulls_url":"https://api.github.com/repos/RyanDwyer/sway/pulls{/number}","milestones_url":"https://api.github.com/repos/RyanDwyer/sway/milestones{/number}","notifications_url":"https://api.github.com/repos/RyanDwyer/sway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyanDwyer/sway/labels{/name}","releases_url":"https://api.github.com/repos/RyanDwyer/sway/releases{/id}","deployments_url":"https://api.github.com/repos/RyanDwyer/sway/deployments","created_at":"2016-09-17T07:19:41Z","updated_at":"2018-05-16T22:29:16Z","pushed_at":"2018-05-18T12:56:14Z","git_url":"git://github.com/RyanDwyer/sway.git","ssh_url":"git@github.com:RyanDwyer/sway.git","clone_url":"https://github.com/RyanDwyer/sway.git","svn_url":"https://github.com/RyanDwyer/sway","homepage":"http://swaywm.org/","size":22797,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swaywm:master","ref":"master","sha":"c2c5a3f5f6bdc061acae4e0583c4fd85c7ed21ac","user":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"repo":{"id":40217904,"name":"sway","full_name":"swaywm/sway","owner":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swaywm/sway","description":"i3-compatible Wayland compositor","fork":false,"url":"https://api.github.com/repos/swaywm/sway","forks_url":"https://api.github.com/repos/swaywm/sway/forks","keys_url":"https://api.github.com/repos/swaywm/sway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaywm/sway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaywm/sway/teams","hooks_url":"https://api.github.com/repos/swaywm/sway/hooks","issue_events_url":"https://api.github.com/repos/swaywm/sway/issues/events{/number}","events_url":"https://api.github.com/repos/swaywm/sway/events","assignees_url":"https://api.github.com/repos/swaywm/sway/assignees{/user}","branches_url":"https://api.github.com/repos/swaywm/sway/branches{/branch}","tags_url":"https://api.github.com/repos/swaywm/sway/tags","blobs_url":"https://api.github.com/repos/swaywm/sway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaywm/sway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaywm/sway/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaywm/sway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaywm/sway/statuses/{sha}","languages_url":"https://api.github.com/repos/swaywm/sway/languages","stargazers_url":"https://api.github.com/repos/swaywm/sway/stargazers","contributors_url":"https://api.github.com/repos/swaywm/sway/contributors","subscribers_url":"https://api.github.com/repos/swaywm/sway/subscribers","subscription_url":"https://api.github.com/repos/swaywm/sway/subscription","commits_url":"https://api.github.com/repos/swaywm/sway/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaywm/sway/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaywm/sway/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaywm/sway/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaywm/sway/contents/{+path}","compare_url":"https://api.github.com/repos/swaywm/sway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaywm/sway/merges","archive_url":"https://api.github.com/repos/swaywm/sway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaywm/sway/downloads","issues_url":"https://api.github.com/repos/swaywm/sway/issues{/number}","pulls_url":"https://api.github.com/repos/swaywm/sway/pulls{/number}","milestones_url":"https://api.github.com/repos/swaywm/sway/milestones{/number}","notifications_url":"https://api.github.com/repos/swaywm/sway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaywm/sway/labels{/name}","releases_url":"https://api.github.com/repos/swaywm/sway/releases{/id}","deployments_url":"https://api.github.com/repos/swaywm/sway/deployments","created_at":"2015-08-05T01:31:45Z","updated_at":"2018-05-18T11:35:43Z","pushed_at":"2018-05-18T12:56:16Z","git_url":"git://github.com/swaywm/sway.git","ssh_url":"git@github.com:swaywm/sway.git","clone_url":"https://github.com/swaywm/sway.git","svn_url":"https://github.com/swaywm/sway","homepage":"http://swaywm.org/","size":23090,"stargazers_count":3901,"watchers_count":3901,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":246,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":246,"open_issues":221,"watchers":3901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaywm/sway/pulls/1821"},"html":{"href":"https://github.com/swaywm/sway/pull/1821"},"issue":{"href":"https://api.github.com/repos/swaywm/sway/issues/1821"},"comments":{"href":"https://api.github.com/repos/swaywm/sway/issues/1821/comments"},"review_comments":{"href":"https://api.github.com/repos/swaywm/sway/pulls/1821/comments"},"review_comment":{"href":"https://api.github.com/repos/swaywm/sway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaywm/sway/pulls/1821/commits"},"statuses":{"href":"https://api.github.com/repos/swaywm/sway/statuses/f82df6bc6c8ab223d292292b37f687ee1dac26d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"emersion"}}