{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/reaction/pulls/comments/206866570","pull_request_review_id":142360904,"id":206866570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjg2NjU3MA==","diff_hunk":"@@ -1,6 +1,9 @@\n import { color, space } from \"@artsy/palette\"\n+import * as Schema from \"Analytics/Schema\"\n+import { getEditorialHref } from \"Components/Publishing/Constants\"\n import { get, omit } from \"lodash\"\n import React from \"react\"\n+import track from \"react-tracking\"","path":"src/Components/Publishing/Layouts/StandardLayout.tsx","position":6,"original_position":6,"commit_id":"58e96e9b925b0be7f04a150ecc5821baca8f442c","original_commit_id":"58e96e9b925b0be7f04a150ecc5821baca8f442c","user":{"login":"eessex","id":1497424,"node_id":"MDQ6VXNlcjE0OTc0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"body":"Oh cool- didn’t realize that was a thing, had remembered you said to use library rather than removed utils version, but sounds like that was only for untyped calls.  Will update!","created_at":"2018-08-01T12:54:19Z","updated_at":"2018-08-01T12:54:19Z","html_url":"https://github.com/artsy/reaction/pull/1040#discussion_r206866570","pull_request_url":"https://api.github.com/repos/artsy/reaction/pulls/1040","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments/206866570"},"html":{"href":"https://github.com/artsy/reaction/pull/1040#discussion_r206866570"},"pull_request":{"href":"https://api.github.com/repos/artsy/reaction/pulls/1040"}},"in_reply_to_id":206860826},"pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/1040","id":203827617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODI3NjE3","html_url":"https://github.com/artsy/reaction/pull/1040","diff_url":"https://github.com/artsy/reaction/pull/1040.diff","patch_url":"https://github.com/artsy/reaction/pull/1040.patch","issue_url":"https://api.github.com/repos/artsy/reaction/issues/1040","number":1040,"state":"open","locked":false,"title":"@alloy => Infinite analytics in new typed schema","user":{"login":"eessex","id":1497424,"node_id":"MDQ6VXNlcjE0OTc0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"body":"Starts mapping new typed analytics schema to analytics events related to infinite scroll a/b test.\r\n\r\nUpdates editorial constants `getEditorialHref` and `getFullEditorialHref`, which were returning incorrectly for \"feature\" and \"standard\" layouts, and adds some tests for them. \r\n\r\nAlso adds a new `storiesOfPublishing` function, which wraps stories in tracking so that react-tracking events will be logged in the console.\r\n\r\nUpdates have been made based on conversation with @anipetrov","created_at":"2018-07-25T12:55:04Z","updated_at":"2018-08-01T12:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8136b9f08b65a6fe40c3cd6c59e5f8b7da441e6b","assignee":{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cavvia","id":64404,"node_id":"MDQ6VXNlcjY0NDA0","avatar_url":"https://avatars1.githubusercontent.com/u/64404?v=4","gravatar_id":"","url":"https://api.github.com/users/cavvia","html_url":"https://github.com/cavvia","followers_url":"https://api.github.com/users/cavvia/followers","following_url":"https://api.github.com/users/cavvia/following{/other_user}","gists_url":"https://api.github.com/users/cavvia/gists{/gist_id}","starred_url":"https://api.github.com/users/cavvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavvia/subscriptions","organizations_url":"https://api.github.com/users/cavvia/orgs","repos_url":"https://api.github.com/users/cavvia/repos","events_url":"https://api.github.com/users/cavvia/events{/privacy}","received_events_url":"https://api.github.com/users/cavvia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/reaction/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/artsy/reaction/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/1040/comments","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/58e96e9b925b0be7f04a150ecc5821baca8f442c","head":{"label":"eessex:infinite-analytics","ref":"infinite-analytics","sha":"58e96e9b925b0be7f04a150ecc5821baca8f442c","user":{"login":"eessex","id":1497424,"node_id":"MDQ6VXNlcjE0OTc0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"repo":{"id":94907425,"node_id":"MDEwOlJlcG9zaXRvcnk5NDkwNzQyNQ==","name":"reaction","full_name":"eessex/reaction","owner":{"login":"eessex","id":1497424,"node_id":"MDQ6VXNlcjE0OTc0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eessex/reaction","description":"Artsy's React Components","fork":true,"url":"https://api.github.com/repos/eessex/reaction","forks_url":"https://api.github.com/repos/eessex/reaction/forks","keys_url":"https://api.github.com/repos/eessex/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eessex/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eessex/reaction/teams","hooks_url":"https://api.github.com/repos/eessex/reaction/hooks","issue_events_url":"https://api.github.com/repos/eessex/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/eessex/reaction/events","assignees_url":"https://api.github.com/repos/eessex/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/eessex/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/eessex/reaction/tags","blobs_url":"https://api.github.com/repos/eessex/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eessex/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eessex/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/eessex/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eessex/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/eessex/reaction/languages","stargazers_url":"https://api.github.com/repos/eessex/reaction/stargazers","contributors_url":"https://api.github.com/repos/eessex/reaction/contributors","subscribers_url":"https://api.github.com/repos/eessex/reaction/subscribers","subscription_url":"https://api.github.com/repos/eessex/reaction/subscription","commits_url":"https://api.github.com/repos/eessex/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/eessex/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/eessex/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/eessex/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/eessex/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/eessex/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eessex/reaction/merges","archive_url":"https://api.github.com/repos/eessex/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eessex/reaction/downloads","issues_url":"https://api.github.com/repos/eessex/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/eessex/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/eessex/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/eessex/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eessex/reaction/labels{/name}","releases_url":"https://api.github.com/repos/eessex/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/eessex/reaction/deployments","created_at":"2017-06-20T15:35:46Z","updated_at":"2018-07-31T18:44:00Z","pushed_at":"2018-07-31T21:02:44Z","git_url":"git://github.com/eessex/reaction.git","ssh_url":"git@github.com:eessex/reaction.git","clone_url":"https://github.com/eessex/reaction.git","svn_url":"https://github.com/eessex/reaction","homepage":"https://artsy.github.io/reaction","size":11362,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"7fd78aacd1f139ac29ef9a52fe0dc1b3317ae3af","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"node_id":"MDEwOlJlcG9zaXRvcnk4MTI1MzczNQ==","name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2018-08-01T00:50:30Z","pushed_at":"2018-08-01T10:49:08Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":18348,"stargazers_count":143,"watchers_count":143,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":31,"open_issues":24,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/1040"},"html":{"href":"https://github.com/artsy/reaction/pull/1040"},"issue":{"href":"https://api.github.com/repos/artsy/reaction/issues/1040"},"comments":{"href":"https://api.github.com/repos/artsy/reaction/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/reaction/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/reaction/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/reaction/statuses/58e96e9b925b0be7f04a150ecc5821baca8f442c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eessex"}}