{"action":"created","issue":{"url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/68","repository_url":"https://api.github.com/repos/jakobehn/GitFlow.VS","labels_url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/68/comments","events_url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/68/events","html_url":"https://github.com/jakobehn/GitFlow.VS/issues/68","id":267778928,"node_id":"MDU6SXNzdWUyNjc3Nzg5Mjg=","number":68,"title":"Want to be able to change \"finish\" commands default behavior to \"Create a Pull Request\"","user":{"login":"ycamargo","id":22969792,"node_id":"MDQ6VXNlcjIyOTY5Nzky","avatar_url":"https://avatars3.githubusercontent.com/u/22969792?v=4","gravatar_id":"","url":"https://api.github.com/users/ycamargo","html_url":"https://github.com/ycamargo","followers_url":"https://api.github.com/users/ycamargo/followers","following_url":"https://api.github.com/users/ycamargo/following{/other_user}","gists_url":"https://api.github.com/users/ycamargo/gists{/gist_id}","starred_url":"https://api.github.com/users/ycamargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycamargo/subscriptions","organizations_url":"https://api.github.com/users/ycamargo/orgs","repos_url":"https://api.github.com/users/ycamargo/repos","events_url":"https://api.github.com/users/ycamargo/events{/privacy}","received_events_url":"https://api.github.com/users/ycamargo/received_events","type":"User","site_admin":false},"labels":[{"id":167749561,"node_id":"MDU6TGFiZWwxNjc3NDk1NjE=","url":"https://api.github.com/repos/jakobehn/GitFlow.VS/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jakobehn/GitFlow.VS/milestones/4","html_url":"https://github.com/jakobehn/GitFlow.VS/milestone/4","labels_url":"https://api.github.com/repos/jakobehn/GitFlow.VS/milestones/4/labels","id":1669511,"node_id":"MDk6TWlsZXN0b25lMTY2OTUxMQ==","number":4,"title":"1.2","description":"","creator":{"login":"jakobehn","id":847244,"node_id":"MDQ6VXNlcjg0NzI0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/847244?v=4","gravatar_id":"","url":"https://api.github.com/users/jakobehn","html_url":"https://github.com/jakobehn","followers_url":"https://api.github.com/users/jakobehn/followers","following_url":"https://api.github.com/users/jakobehn/following{/other_user}","gists_url":"https://api.github.com/users/jakobehn/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobehn/subscriptions","organizations_url":"https://api.github.com/users/jakobehn/orgs","repos_url":"https://api.github.com/users/jakobehn/repos","events_url":"https://api.github.com/users/jakobehn/events{/privacy}","received_events_url":"https://api.github.com/users/jakobehn/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2016-03-28T16:28:19Z","updated_at":"2018-03-07T17:51:17Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2017-10-23T18:56:16Z","updated_at":"2018-11-17T07:09:11Z","closed_at":null,"author_association":"NONE","body":"I'm looking for a good set of tools to support our team in using Git Flow branching strategy integrated with our TFS (and soon VSTS) branch policies enforcements. \r\n\r\nToday, we're doing it manually. Using basic git tools for create, fetch, pull, push, etc our feature/release/hotfix branches based on develop or master. And we're using policies on our develop and master branches that enforces the code review and approval before merging. Those policies also requires the creation of \"Pull Requests\" to update those branches.\r\n\r\nWe would love to simplify the process (and make it less error prone) using one of the GitFlow tools implementation. Since we all use Visual Studio 2017, your extension would be the perfect choice. The only problem at our sight is with \"feature/release/hotfix finish\" commands. In our strategy, this command should never be used since we need to create a new pull request instead of local merging. This article explains a similar scenario: [http://www.clemensreijnen.nl/post/2015/07/22/Gitflow-and-VSO-branch-policies-use-them-together](url)\r\n\r\nWould be very interesting if we could config the extension to: commit last changes, push them and open the web browser at the Create Pull Request page (as the TeamExplorer extension does) when developer choose the \"finish command\".\r\nOther alternative could be, at least, the ability to disable those commands in the extension, forcing developers to not finish their branches, avoiding local merges to develop/master.\r\n"},"comment":{"url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/comments/439594548","html_url":"https://github.com/jakobehn/GitFlow.VS/issues/68#issuecomment-439594548","issue_url":"https://api.github.com/repos/jakobehn/GitFlow.VS/issues/68","id":439594548,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU5NDU0OA==","user":{"login":"schnitty","id":6099451,"node_id":"MDQ6VXNlcjYwOTk0NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6099451?v=4","gravatar_id":"","url":"https://api.github.com/users/schnitty","html_url":"https://github.com/schnitty","followers_url":"https://api.github.com/users/schnitty/followers","following_url":"https://api.github.com/users/schnitty/following{/other_user}","gists_url":"https://api.github.com/users/schnitty/gists{/gist_id}","starred_url":"https://api.github.com/users/schnitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnitty/subscriptions","organizations_url":"https://api.github.com/users/schnitty/orgs","repos_url":"https://api.github.com/users/schnitty/repos","events_url":"https://api.github.com/users/schnitty/events{/privacy}","received_events_url":"https://api.github.com/users/schnitty/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T07:09:11Z","updated_at":"2018-11-17T07:09:11Z","author_association":"NONE","body":"Before heading down a particular path I'd like to propose a few options for the implementation and get some feedback.\r\n\r\nOption 1: Config option to disable finish commands\r\nHave GitFlow with AzureDevOps PR config option.  When enabled would simply make the finish commands unavailable which removes the biggest danger.\r\nYou could then use the PR features from team explorer/web portal to do what you need to do manually.\r\n\r\n**Advantages**\r\n\r\n- Team Explorer already has the create PR\r\n- Quick and easy to implement\r\n\r\n**Disadvantages**\r\n\r\n- Have to perform some steps manually (creating multiple PRs for release and hotfix could be bothersome)\r\n- Have to remember to delete local branches\r\n\r\n\r\nOption 2: New PR command to occur before finish command\r\nIntroduce a PR/publish command that would create pull request(s) accordingly.\r\nModify finish command so it can only be done when the attached PR is completed / abandoned.\r\nFinish command would then simply clean up branches (merge would be done by PR)\r\n\r\n**Advantages**\r\n\r\n- All in one solution\r\n\r\n**Disadvantages**\r\n\r\n- Take longer to implement, test and get right\r\n\r\n\r\nAt this stage i'm thinking it would be at least a good idea to do option one so that the finish commands are disabled.\r\n\r\nThen could extend that option as a separate PR to see if we can get the full round trip working from the extension.\r\n\r\nI think I prefer the introduction of a new command (gitflow PR) instead of re-purposing the finish command.  The feature/release/hotfix isn't finished until the PR is complete.\r\n\r\n\r\nThoughts?\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"schnitty"}}