{"action":"created","comment":{"url":"https://api.github.com/repos/windmilleng/tilt/pulls/comments/223494039","pull_request_review_id":162635480,"id":223494039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQ5NDAzOQ==","diff_hunk":"@@ -81,10 +61,16 @@ func (r repoIgnoreTester) Matches(f string, isDir bool) (bool, error) {\n \treturn r.gitIgnoreTester.Matches(f, isDir)\n }\n \n-func NewRepoIgnoreTester(ctx context.Context, repoRoot string) (model.PathMatcher, error) {\n-\tg, err := NewGitIgnoreTester(ctx, repoRoot)\n+func NewRepoIgnoreTester(ctx context.Context, repoRoot string, gitignoreContents string) (*repoIgnoreTester, error) {\n+\tg, err := NewGitIgnoreTesterFromContents(ctx, repoRoot, gitignoreContents)\n \tif err != nil {\n \t\treturn nil, err\n \t}\n \treturn &repoIgnoreTester{repoRoot, g}, nil\n }\n+\n+type nothingMatcher struct{}","path":"internal/git/gitignore.go","position":82,"original_position":82,"commit_id":"5110859848378eef140b0fa7a17e09d018dd9f5d","original_commit_id":"51eacc01678a76caecf5bdf6c977352f24b98d9f","user":{"login":"jazzdan","id":452453,"node_id":"MDQ6VXNlcjQ1MjQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/452453?v=4","gravatar_id":"","url":"https://api.github.com/users/jazzdan","html_url":"https://github.com/jazzdan","followers_url":"https://api.github.com/users/jazzdan/followers","following_url":"https://api.github.com/users/jazzdan/following{/other_user}","gists_url":"https://api.github.com/users/jazzdan/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzdan/subscriptions","organizations_url":"https://api.github.com/users/jazzdan/orgs","repos_url":"https://api.github.com/users/jazzdan/repos","events_url":"https://api.github.com/users/jazzdan/events{/privacy}","received_events_url":"https://api.github.com/users/jazzdan/received_events","type":"User","site_admin":false},"body":"After talking with @nicks I'm going to reorganize the model package so that it doesn't depend on the gitignore or dockerignore packages in a separate PR.","created_at":"2018-10-08T20:52:48Z","updated_at":"2018-10-08T20:52:49Z","html_url":"https://github.com/windmilleng/tilt/pull/488#discussion_r223494039","pull_request_url":"https://api.github.com/repos/windmilleng/tilt/pulls/488","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/comments/223494039"},"html":{"href":"https://github.com/windmilleng/tilt/pull/488#discussion_r223494039"},"pull_request":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/488"}},"in_reply_to_id":223436598},"pull_request":{"url":"https://api.github.com/repos/windmilleng/tilt/pulls/488","id":221181842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTgxODQy","html_url":"https://github.com/windmilleng/tilt/pull/488","diff_url":"https://github.com/windmilleng/tilt/pull/488.diff","patch_url":"https://github.com/windmilleng/tilt/pull/488.patch","issue_url":"https://api.github.com/repos/windmilleng/tilt/issues/488","number":488,"state":"open","locked":false,"title":"tiltfile: don't parse ignore files at runtime","user":{"login":"jazzdan","id":452453,"node_id":"MDQ6VXNlcjQ1MjQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/452453?v=4","gravatar_id":"","url":"https://api.github.com/users/jazzdan","html_url":"https://github.com/jazzdan","followers_url":"https://api.github.com/users/jazzdan/followers","following_url":"https://api.github.com/users/jazzdan/following{/other_user}","gists_url":"https://api.github.com/users/jazzdan/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzdan/subscriptions","organizations_url":"https://api.github.com/users/jazzdan/orgs","repos_url":"https://api.github.com/users/jazzdan/repos","events_url":"https://api.github.com/users/jazzdan/events{/privacy}","received_events_url":"https://api.github.com/users/jazzdan/received_events","type":"User","site_admin":false},"body":"Instead just pass the contents of the ignore files along so they can be\r\nparsed later. This is important so that we can end up with a manifest\r\nthat consists entirely of comparable fields.","created_at":"2018-10-08T16:51:59Z","updated_at":"2018-10-08T20:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73e24924f94c1964b65a3bdd85dc94c2dc8c47b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"landism","id":7453991,"node_id":"MDQ6VXNlcjc0NTM5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7453991?v=4","gravatar_id":"","url":"https://api.github.com/users/landism","html_url":"https://github.com/landism","followers_url":"https://api.github.com/users/landism/followers","following_url":"https://api.github.com/users/landism/following{/other_user}","gists_url":"https://api.github.com/users/landism/gists{/gist_id}","starred_url":"https://api.github.com/users/landism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landism/subscriptions","organizations_url":"https://api.github.com/users/landism/orgs","repos_url":"https://api.github.com/users/landism/repos","events_url":"https://api.github.com/users/landism/events{/privacy}","received_events_url":"https://api.github.com/users/landism/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/windmilleng/tilt/pulls/488/commits","review_comments_url":"https://api.github.com/repos/windmilleng/tilt/pulls/488/comments","review_comment_url":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windmilleng/tilt/issues/488/comments","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/5110859848378eef140b0fa7a17e09d018dd9f5d","head":{"label":"windmilleng:dmiller/parse_ignores_later","ref":"dmiller/parse_ignores_later","sha":"5110859848378eef140b0fa7a17e09d018dd9f5d","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"kubernetes development for the impatient","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2018-10-08T20:51:52Z","pushed_at":"2018-10-08T20:51:52Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"","size":11192,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"windmilleng:master","ref":"master","sha":"d44f779226dc681bd2c9781a9534193ae44e3c8f","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"kubernetes development for the impatient","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2018-10-08T20:51:52Z","pushed_at":"2018-10-08T20:51:52Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"","size":11192,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/488"},"html":{"href":"https://github.com/windmilleng/tilt/pull/488"},"issue":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/488"},"comments":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/windmilleng/tilt/statuses/5110859848378eef140b0fa7a17e09d018dd9f5d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jazzdan"}}