{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3439","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3439/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3439/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3439/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3439","id":298759777,"number":3439,"title":"Use new dialog-user feature for custom buttons for more object types","user":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars1.githubusercontent.com/u/164557?v=4","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"labels":[{"id":534299194,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/automation/automate","name":"automation/automate","color":"5319e7","default":false},{"id":505074431,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-20T21:43:20Z","updated_at":"2018-02-21T14:51:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3439","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3439","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3439.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3439.patch"},"body":"Related to #2671, this just adds a few more object types that will use the new dialog runner and changes some of the mixin logic these object types go through to handle the extra dialog locals that are getting passed down.\r\n\r\nObject types that will use the new dialog-user ui-component after this PR:\r\n`CloudNetwork`\r\n`CloudObjectStoreContainer`\r\n`CloudSubnet`\r\n`MiqGroup`\r\n`Tenant`\r\n`User`\r\n\r\n/cc @gmcculloug\r\n@d-m-u @syncrou Can you review, please?\r\n@himdel Can you also review or tag someone to review, please?\r\n\r\nIf anyone has any good ideas on how to best extract/simplify the big case statement within `#determine_api_endpoints` I'm all ears. Right now it's really simple to add to it, but it is definitely pretty ugly. The main problem I see is that for some of the object types the collection name and the cancel endpoint are predictable, but for others they aren't. Ultimately maybe it isn't even worth it to refactor right now.\r\n\r\n@miq-bot assign @h-kataria\r\n@miq-bot add_label enhancement, automation/automate"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/367350732","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3439#issuecomment-367350732","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3439","id":367350732,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T14:51:42Z","updated_at":"2018-02-21T14:51:42Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/eclarizio/manageiq-ui-classic/commit/a64c119f5403d8a7a0ee4071cfe459ee7a31d920 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0\n4 files checked, 1 offense detected\n\n**app/controllers/mixins/custom_button_dialog_form_mixin.rb**\n- [ ] :exclamation: - [Line 3](https://github.com/eclarizio/manageiq-ui-classic/blob/a64c119f5403d8a7a0ee4071cfe459ee7a31d920/app/controllers/mixins/custom_button_dialog_form_mixin.rb#L3), Col 9 - [Naming/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.52.0/RuboCop/Cop/Naming/AccessorMethodName) - Do not prefix writer method names with `set_`.\n"}}
{"actor":{"display_login":"miq-bot"}}