{"action":"created","issue":{"url":"https://api.github.com/repos/mdbs99/james/issues/85","repository_url":"https://api.github.com/repos/mdbs99/james","labels_url":"https://api.github.com/repos/mdbs99/james/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/mdbs99/james/issues/85/comments","events_url":"https://api.github.com/repos/mdbs99/james/issues/85/events","html_url":"https://github.com/mdbs99/james/issues/85","id":326657394,"node_id":"MDU6SXNzdWUzMjY2NTczOTQ=","number":85,"title":"Only one Add() in TDataParams","user":{"login":"fabriciofx","id":1964562,"node_id":"MDQ6VXNlcjE5NjQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1964562?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriciofx","html_url":"https://github.com/fabriciofx","followers_url":"https://api.github.com/users/fabriciofx/followers","following_url":"https://api.github.com/users/fabriciofx/following{/other_user}","gists_url":"https://api.github.com/users/fabriciofx/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriciofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriciofx/subscriptions","organizations_url":"https://api.github.com/users/fabriciofx/orgs","repos_url":"https://api.github.com/users/fabriciofx/repos","events_url":"https://api.github.com/users/fabriciofx/events{/privacy}","received_events_url":"https://api.github.com/users/fabriciofx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mdbs99/james/milestones/2","html_url":"https://github.com/mdbs99/james/milestone/2","labels_url":"https://api.github.com/repos/mdbs99/james/milestones/2/labels","id":3381476,"node_id":"MDk6TWlsZXN0b25lMzM4MTQ3Ng==","number":2,"title":"1.0.0","description":"","creator":{"login":"mdbs99","id":1459306,"node_id":"MDQ6VXNlcjE0NTkzMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1459306?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbs99","html_url":"https://github.com/mdbs99","followers_url":"https://api.github.com/users/mdbs99/followers","following_url":"https://api.github.com/users/mdbs99/following{/other_user}","gists_url":"https://api.github.com/users/mdbs99/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbs99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbs99/subscriptions","organizations_url":"https://api.github.com/users/mdbs99/orgs","repos_url":"https://api.github.com/users/mdbs99/repos","events_url":"https://api.github.com/users/mdbs99/events{/privacy}","received_events_url":"https://api.github.com/users/mdbs99/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2018-05-28T16:08:38Z","updated_at":"2018-06-03T21:11:05Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-05-25T20:40:03Z","updated_at":"2018-06-03T21:11:05Z","closed_at":"2018-06-03T21:11:05Z","author_association":"CONTRIBUTOR","body":"Nowadays, `IDataParams` has 3 `Add()` methods:\r\n```\r\nfunction Add(const ParamName: string; DataType: TFieldType; Value: Variant): IDataParams; overload;\r\nfunction Add(const AParam: IDataParam): IDataParams; overload;\r\nfunction Add(const AParams: IDataParams): IDataParams; overload;\r\n```\r\nSo, my suggestion is to have only one `Add()` method, like this:\r\n```\r\nfunction Add(const AParam: IDataParam): IDataParams; overload;\r\n```\r\nWhen we want to save to a file, we can do something like it:\r\n```\r\nIDataParams ds = TDataParams.New();\r\nds.Add(TDataParam.New(...));\r\n```\r\nAnd, to allow add a `IDataParams` to a `IDataParams`, `IDataParams` show extends `IDataParam`.\r\n\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/mdbs99/james/issues/comments/394191631","html_url":"https://github.com/mdbs99/james/issues/85#issuecomment-394191631","issue_url":"https://api.github.com/repos/mdbs99/james/issues/85","id":394191631,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDE5MTYzMQ==","user":{"login":"mdbs99","id":1459306,"node_id":"MDQ6VXNlcjE0NTkzMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1459306?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbs99","html_url":"https://github.com/mdbs99","followers_url":"https://api.github.com/users/mdbs99/followers","following_url":"https://api.github.com/users/mdbs99/following{/other_user}","gists_url":"https://api.github.com/users/mdbs99/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbs99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbs99/subscriptions","organizations_url":"https://api.github.com/users/mdbs99/orgs","repos_url":"https://api.github.com/users/mdbs99/repos","events_url":"https://api.github.com/users/mdbs99/events{/privacy}","received_events_url":"https://api.github.com/users/mdbs99/received_events","type":"User","site_admin":false},"created_at":"2018-06-03T21:11:05Z","updated_at":"2018-06-03T21:11:05Z","author_association":"OWNER","body":"I've just removed the first one. The last, I cannot, because the algorithm should need to execute a loop in all items."}}
{"actor":{"display_login":"mdbs99"}}