{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/15751","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/15751/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/15751/comments","events_url":"https://api.github.com/repos/electron/electron/issues/15751/events","html_url":"https://github.com/electron/electron/pull/15751","id":382062315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODU3Mzk2","number":15751,"title":"docs: mention the limits of nativeWindowOpen (4-0-x)","user":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"labels":[{"id":969709864,"node_id":"MDU6TGFiZWw5Njk3MDk4NjQ=","url":"https://api.github.com/repos/electron/electron/labels/target/3-0-x","name":"target/3-0-x","color":"f22fa2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-19T05:27:26Z","updated_at":"2018-11-19T14:22:27Z","closed_at":"2018-11-19T14:22:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/15751","html_url":"https://github.com/electron/electron/pull/15751","diff_url":"https://github.com/electron/electron/pull/15751.diff","patch_url":"https://github.com/electron/electron/pull/15751.patch"},"body":"#### Description of Change\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nMention the limits of `nativeWindowOpen`  in documentation, close #15666.\r\n\r\nNote that from 5.x there will be new limitations for `nativeWindowOpen` (that `nodeIntegration` will always be `false`) and it has already been documented in `master` branch. This PR just explicitly documents existing limits of `nativeWindowOpen` in 4.x and does not make any change.\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n\r\n\r\n#### Release Notes\r\n<!-- Used to describe release notes for future release versions. Use `no-notes` to indicate no user-facing changes. -->\r\n\r\nNotes: Update limitations of `nativeWindowOpen` option in documentation."},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/439908873","html_url":"https://github.com/electron/electron/pull/15751#issuecomment-439908873","issue_url":"https://api.github.com/repos/electron/electron/issues/15751","id":439908873,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkwODg3Mw==","user":{"login":"release-clerk[bot]","id":42386326,"node_id":"MDM6Qm90NDIzODYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/in/16104?v=4","gravatar_id":"","url":"https://api.github.com/users/release-clerk%5Bbot%5D","html_url":"https://github.com/apps/release-clerk","followers_url":"https://api.github.com/users/release-clerk%5Bbot%5D/followers","following_url":"https://api.github.com/users/release-clerk%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/release-clerk%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/release-clerk%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-clerk%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/release-clerk%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/release-clerk%5Bbot%5D/repos","events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/release-clerk%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-19T14:22:27Z","updated_at":"2018-11-19T14:22:27Z","author_association":"NONE","body":"**Release Notes Persisted**\n\n > Update limitations of `nativeWindowOpen` option in documentation."}}
{"actor":{"display_login":"release-clerk"}}