{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/169411759","pull_request_review_id":97934196,"id":169411759,"diff_hunk":"@@ -124,6 +141,7 @@ impl GlobalScope {\n         timer_event_chan: IpcSender<TimerEvent>,\n         origin: MutableOrigin,\n         microtask_queue: Rc<MicrotaskQueue>,\n+        list_auto_close_worker: DomRefCell<Vec<AutoCloseWorker>>,","path":"components/script/dom/globalscope.rs","position":42,"original_position":42,"commit_id":"7fa1f09efea9f774fae1a6e1b1d1388ec82cda6c","original_commit_id":"7fa1f09efea9f774fae1a6e1b1d1388ec82cda6c","user":{"login":"jdm","id":27658,"avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"We don't need to pass this in as an argument. We can simply initialize it with a default value instead.","created_at":"2018-02-20T18:19:28Z","updated_at":"2018-02-20T18:20:17Z","html_url":"https://github.com/servo/servo/pull/20068#discussion_r169411759","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/20068","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/169411759"},"html":{"href":"https://github.com/servo/servo/pull/20068#discussion_r169411759"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/20068"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/20068","id":169848336,"html_url":"https://github.com/servo/servo/pull/20068","diff_url":"https://github.com/servo/servo/pull/20068.diff","patch_url":"https://github.com/servo/servo/pull/20068.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/20068","number":20068,"state":"open","locked":false,"title":"WIP : added AutoCloseWorker for closing related workers when a page/another worker is closed.","user":{"login":"nupurbaghel","id":20029578,"avatar_url":"https://avatars0.githubusercontent.com/u/20029578?v=4","gravatar_id":"","url":"https://api.github.com/users/nupurbaghel","html_url":"https://github.com/nupurbaghel","followers_url":"https://api.github.com/users/nupurbaghel/followers","following_url":"https://api.github.com/users/nupurbaghel/following{/other_user}","gists_url":"https://api.github.com/users/nupurbaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/nupurbaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupurbaghel/subscriptions","organizations_url":"https://api.github.com/users/nupurbaghel/orgs","repos_url":"https://api.github.com/users/nupurbaghel/repos","events_url":"https://api.github.com/users/nupurbaghel/events{/privacy}","received_events_url":"https://api.github.com/users/nupurbaghel/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\nFollowed steps as suggested in issue. \r\nError is not yet resolved!\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #17977 (https://github.com/servo/servo/issues/17977?).\r\n\r\n<!-- Either: -->\r\n- [ ] These changes do not require tests because it will have manual test case.\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/20068)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-02-18T20:31:21Z","updated_at":"2018-02-20T18:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3560604b08d1821c11b306cfecb923b0c694eb","assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/20068/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/20068/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/20068/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/7fa1f09efea9f774fae1a6e1b1d1388ec82cda6c","head":{"label":"paavininanda:autocloseworker","ref":"autocloseworker","sha":"7fa1f09efea9f774fae1a6e1b1d1388ec82cda6c","user":{"login":"paavininanda","id":24737071,"avatar_url":"https://avatars0.githubusercontent.com/u/24737071?v=4","gravatar_id":"","url":"https://api.github.com/users/paavininanda","html_url":"https://github.com/paavininanda","followers_url":"https://api.github.com/users/paavininanda/followers","following_url":"https://api.github.com/users/paavininanda/following{/other_user}","gists_url":"https://api.github.com/users/paavininanda/gists{/gist_id}","starred_url":"https://api.github.com/users/paavininanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paavininanda/subscriptions","organizations_url":"https://api.github.com/users/paavininanda/orgs","repos_url":"https://api.github.com/users/paavininanda/repos","events_url":"https://api.github.com/users/paavininanda/events{/privacy}","received_events_url":"https://api.github.com/users/paavininanda/received_events","type":"User","site_admin":false},"repo":{"id":119984464,"name":"servo","full_name":"paavininanda/servo","owner":{"login":"paavininanda","id":24737071,"avatar_url":"https://avatars0.githubusercontent.com/u/24737071?v=4","gravatar_id":"","url":"https://api.github.com/users/paavininanda","html_url":"https://github.com/paavininanda","followers_url":"https://api.github.com/users/paavininanda/followers","following_url":"https://api.github.com/users/paavininanda/following{/other_user}","gists_url":"https://api.github.com/users/paavininanda/gists{/gist_id}","starred_url":"https://api.github.com/users/paavininanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paavininanda/subscriptions","organizations_url":"https://api.github.com/users/paavininanda/orgs","repos_url":"https://api.github.com/users/paavininanda/repos","events_url":"https://api.github.com/users/paavininanda/events{/privacy}","received_events_url":"https://api.github.com/users/paavininanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paavininanda/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/paavininanda/servo","forks_url":"https://api.github.com/repos/paavininanda/servo/forks","keys_url":"https://api.github.com/repos/paavininanda/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paavininanda/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paavininanda/servo/teams","hooks_url":"https://api.github.com/repos/paavininanda/servo/hooks","issue_events_url":"https://api.github.com/repos/paavininanda/servo/issues/events{/number}","events_url":"https://api.github.com/repos/paavininanda/servo/events","assignees_url":"https://api.github.com/repos/paavininanda/servo/assignees{/user}","branches_url":"https://api.github.com/repos/paavininanda/servo/branches{/branch}","tags_url":"https://api.github.com/repos/paavininanda/servo/tags","blobs_url":"https://api.github.com/repos/paavininanda/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paavininanda/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paavininanda/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/paavininanda/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paavininanda/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/paavininanda/servo/languages","stargazers_url":"https://api.github.com/repos/paavininanda/servo/stargazers","contributors_url":"https://api.github.com/repos/paavininanda/servo/contributors","subscribers_url":"https://api.github.com/repos/paavininanda/servo/subscribers","subscription_url":"https://api.github.com/repos/paavininanda/servo/subscription","commits_url":"https://api.github.com/repos/paavininanda/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/paavininanda/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/paavininanda/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/paavininanda/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/paavininanda/servo/contents/{+path}","compare_url":"https://api.github.com/repos/paavininanda/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paavininanda/servo/merges","archive_url":"https://api.github.com/repos/paavininanda/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paavininanda/servo/downloads","issues_url":"https://api.github.com/repos/paavininanda/servo/issues{/number}","pulls_url":"https://api.github.com/repos/paavininanda/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/paavininanda/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/paavininanda/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paavininanda/servo/labels{/name}","releases_url":"https://api.github.com/repos/paavininanda/servo/releases{/id}","deployments_url":"https://api.github.com/repos/paavininanda/servo/deployments","created_at":"2018-02-02T13:23:52Z","updated_at":"2018-02-02T13:24:07Z","pushed_at":"2018-02-20T09:39:39Z","git_url":"git://github.com/paavininanda/servo.git","ssh_url":"git@github.com:paavininanda/servo.git","clone_url":"https://github.com/paavininanda/servo.git","svn_url":"https://github.com/paavininanda/servo","homepage":"https://servo.org/","size":352366,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"d423e54d58d6cced950896eed1957ee2989f4eee","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-02-20T15:50:48Z","pushed_at":"2018-02-20T18:05:21Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":438508,"stargazers_count":11219,"watchers_count":11219,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1847,"mirror_url":null,"archived":false,"open_issues_count":2030,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1847,"open_issues":2030,"watchers":11219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/20068"},"html":{"href":"https://github.com/servo/servo/pull/20068"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/20068"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/20068/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/20068/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/20068/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/7fa1f09efea9f774fae1a6e1b1d1388ec82cda6c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdm"}}