{"action":"created","issue":{"url":"https://api.github.com/repos/src-d/gitbase/issues/318","repository_url":"https://api.github.com/repos/src-d/gitbase","labels_url":"https://api.github.com/repos/src-d/gitbase/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/src-d/gitbase/issues/318/comments","events_url":"https://api.github.com/repos/src-d/gitbase/issues/318/events","html_url":"https://github.com/src-d/gitbase/issues/318","id":333649791,"node_id":"MDU6SXNzdWUzMzM2NDk3OTE=","number":318,"title":"Use indexes in squashed tables","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"labels":[{"id":445238582,"node_id":"MDU6TGFiZWw0NDUyMzg1ODI=","url":"https://api.github.com/repos/src-d/gitbase/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":879800359,"node_id":"MDU6TGFiZWw4Nzk4MDAzNTk=","url":"https://api.github.com/repos/src-d/gitbase/labels/perf","name":"perf","color":"4af74f","default":false}],"state":"open","locked":false,"assignee":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"assignees":[{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-19T12:30:42Z","updated_at":"2018-06-19T14:32:53Z","closed_at":null,"author_association":"MEMBER","body":"Related to: https://github.com/src-d/go-mysql-server/issues/187"},"comment":{"url":"https://api.github.com/repos/src-d/gitbase/issues/comments/398420815","html_url":"https://github.com/src-d/gitbase/issues/318#issuecomment-398420815","issue_url":"https://api.github.com/repos/src-d/gitbase/issues/318","id":398420815,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQyMDgxNQ==","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T14:32:53Z","updated_at":"2018-06-19T14:32:53Z","author_association":"MEMBER","body":"In the middle of this I found a problem trying to fit together this two things:\r\n\r\n- Indexes do not work per-repo, they just return stuff however they want\r\n- The squash iterators are `RowRepoIter`s, which means they do this iteration per repository\r\n\r\nThis means we can't mix together this as it is. There would be two options for this:\r\n\r\n- Make indexes work per repo (which we can't do).\r\n- Make squash iterators not be `RowRepoIter`s (which we can do but it's a huge task). The downsides to this is that pool repo iteration will be repeated in every iterator that is a starting point (can't have parents) and all iterators would need to be modified to pass down the instance of the repository as well as be refactored to take into account the fact that they will not work per-repo.\r\n\r\nWDYT? @ajnavarro "}}
{"actor":{"display_login":"erizocosmico"}}