{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/110","repository_url":"https://api.github.com/repos/serilog/serilog-settings-configuration","labels_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/110/comments","events_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/110/events","html_url":"https://github.com/serilog/serilog-settings-configuration/pull/110","id":320603463,"number":110,"title":"Destructure support","user":{"login":"MV10","id":794270,"avatar_url":"https://avatars2.githubusercontent.com/u/794270?v=4","gravatar_id":"","url":"https://api.github.com/users/MV10","html_url":"https://github.com/MV10","followers_url":"https://api.github.com/users/MV10/followers","following_url":"https://api.github.com/users/MV10/following{/other_user}","gists_url":"https://api.github.com/users/MV10/gists{/gist_id}","starred_url":"https://api.github.com/users/MV10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MV10/subscriptions","organizations_url":"https://api.github.com/users/MV10/orgs","repos_url":"https://api.github.com/users/MV10/repos","events_url":"https://api.github.com/users/MV10/events{/privacy}","received_events_url":"https://api.github.com/users/MV10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-06T15:45:17Z","updated_at":"2018-05-07T13:05:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/110","html_url":"https://github.com/serilog/serilog-settings-configuration/pull/110","diff_url":"https://github.com/serilog/serilog-settings-configuration/pull/110.diff","patch_url":"https://github.com/serilog/serilog-settings-configuration/pull/110.patch"},"body":"Added support for destructure `With` and max-limit settings, also opening up destructuring features to additional configuration through extension methods in other packages, as discussed in #106.\r\n\r\n- ConfigurationReader:\r\n  - add ApplyDestructuring\r\n  - add FindDestructureConfigurationMethods\r\n  - added surrogates for several destructure config methods\r\n  - add comments explaining method-level surrogates\r\n  - renamed FindConfigurationMethods to FindConfigurationExtensions\r\n- three unit tests modeled on Serilog's own destructure tests\r\n- README updated with a few lines of JSON demonstrating the settings\r\n- changes to sample program\r\n  - config for Destructure max string length and max collection depth\r\n  - log events to demonstrate Destructure config\r\n  - comment explaining Filter syntax is from S.F.Expressions package\r\n"},"comment":{"url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/comments/387058012","html_url":"https://github.com/serilog/serilog-settings-configuration/pull/110#issuecomment-387058012","issue_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/110","id":387058012,"user":{"login":"MV10","id":794270,"avatar_url":"https://avatars2.githubusercontent.com/u/794270?v=4","gravatar_id":"","url":"https://api.github.com/users/MV10","html_url":"https://github.com/MV10","followers_url":"https://api.github.com/users/MV10/followers","following_url":"https://api.github.com/users/MV10/following{/other_user}","gists_url":"https://api.github.com/users/MV10/gists{/gist_id}","starred_url":"https://api.github.com/users/MV10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MV10/subscriptions","organizations_url":"https://api.github.com/users/MV10/orgs","repos_url":"https://api.github.com/users/MV10/repos","events_url":"https://api.github.com/users/MV10/events{/privacy}","received_events_url":"https://api.github.com/users/MV10/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T13:05:28Z","updated_at":"2018-05-07T13:05:28Z","author_association":"CONTRIBUTOR","body":"@tsimbalar Since you referenced the _AppSettings_ thread, for anyone doing work there I'll add this to illustrate how the destructuring section looks for this _Configuration_ package. (This is in this PR's README but it's more discoverable here while this PR is in-flight.)\r\n\r\nWithin the Serilog section:\r\n\r\n```json\r\n    \"Destructure\": [\r\n      { \"Name\": \"With\", \"Args\": { \"policy\": \"Sample.CustomPolicy, Sample\" } },\r\n      { \"Name\": \"ToMaximumDepth\", \"Args\": { \"maximumDestructuringDepth\": 4 } },\r\n      { \"Name\": \"ToMaximumStringLength\", \"Args\": { \"maximumStringLength\": 100 } },\r\n      { \"Name\": \"ToMaximumCollectionCount\", \"Args\": { \"maximumCollectionCount\": 10 } }\r\n    ],\r\n```"}}
{"actor":{"display_login":"MV10"}}