{"action":"closed","number":2315,"pull_request":{"url":"https://api.github.com/repos/c3js/c3/pulls/2315","id":176723607,"html_url":"https://github.com/c3js/c3/pull/2315","diff_url":"https://github.com/c3js/c3/pull/2315.diff","patch_url":"https://github.com/c3js/c3/pull/2315.patch","issue_url":"https://api.github.com/repos/c3js/c3/issues/2315","number":2315,"state":"closed","locked":false,"title":"Fix hovering state when target contains special characters","user":{"login":"panthony","id":230462,"avatar_url":"https://avatars1.githubusercontent.com/u/230462?v=4","gravatar_id":"","url":"https://api.github.com/users/panthony","html_url":"https://github.com/panthony","followers_url":"https://api.github.com/users/panthony/followers","following_url":"https://api.github.com/users/panthony/following{/other_user}","gists_url":"https://api.github.com/users/panthony/gists{/gist_id}","starred_url":"https://api.github.com/users/panthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panthony/subscriptions","organizations_url":"https://api.github.com/users/panthony/orgs","repos_url":"https://api.github.com/users/panthony/repos","events_url":"https://api.github.com/users/panthony/events{/privacy}","received_events_url":"https://api.github.com/users/panthony/received_events","type":"User","site_admin":false},"body":"This PRs fixes the following issue:\r\n\r\n- #1794\r\n- #1687\r\n- #1083 (probably)\r\n\r\nCSS class names are NOT allowed spaces but every other characters is fine (https://www.w3.org/TR/CSS21/syndata.html#characters).\r\n\r\nSince they are all prefixed by `c3-targets-` we do not have to care about the first character.\r\n\r\nWe simply need to escape in `querySelector` or in CSS if any.\r\n\r\nI don't know if `c3-target-XXX`  is considered public or private api but this PR will break css/js based on this css class when target contains special characters.\r\n\r\n---\r\nclose #1687","created_at":"2018-03-22T09:50:36Z","updated_at":"2018-03-25T03:04:28Z","closed_at":"2018-03-25T03:04:28Z","merged_at":"2018-03-25T03:04:28Z","merge_commit_sha":"a3d129afa69ffad25d8c9bd5b9a9434ae4dfda17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/c3js/c3/pulls/2315/commits","review_comments_url":"https://api.github.com/repos/c3js/c3/pulls/2315/comments","review_comment_url":"https://api.github.com/repos/c3js/c3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c3js/c3/issues/2315/comments","statuses_url":"https://api.github.com/repos/c3js/c3/statuses/4393ab1eeddb07a374f05e9857bcfea80006dc9f","head":{"label":"cogniteev:fix/highlight","ref":"fix/highlight","sha":"4393ab1eeddb07a374f05e9857bcfea80006dc9f","user":{"login":"cogniteev","id":4540090,"avatar_url":"https://avatars1.githubusercontent.com/u/4540090?v=4","gravatar_id":"","url":"https://api.github.com/users/cogniteev","html_url":"https://github.com/cogniteev","followers_url":"https://api.github.com/users/cogniteev/followers","following_url":"https://api.github.com/users/cogniteev/following{/other_user}","gists_url":"https://api.github.com/users/cogniteev/gists{/gist_id}","starred_url":"https://api.github.com/users/cogniteev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogniteev/subscriptions","organizations_url":"https://api.github.com/users/cogniteev/orgs","repos_url":"https://api.github.com/users/cogniteev/repos","events_url":"https://api.github.com/users/cogniteev/events{/privacy}","received_events_url":"https://api.github.com/users/cogniteev/received_events","type":"Organization","site_admin":false},"repo":{"id":59283247,"name":"c3","full_name":"cogniteev/c3","owner":{"login":"cogniteev","id":4540090,"avatar_url":"https://avatars1.githubusercontent.com/u/4540090?v=4","gravatar_id":"","url":"https://api.github.com/users/cogniteev","html_url":"https://github.com/cogniteev","followers_url":"https://api.github.com/users/cogniteev/followers","following_url":"https://api.github.com/users/cogniteev/following{/other_user}","gists_url":"https://api.github.com/users/cogniteev/gists{/gist_id}","starred_url":"https://api.github.com/users/cogniteev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogniteev/subscriptions","organizations_url":"https://api.github.com/users/cogniteev/orgs","repos_url":"https://api.github.com/users/cogniteev/repos","events_url":"https://api.github.com/users/cogniteev/events{/privacy}","received_events_url":"https://api.github.com/users/cogniteev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cogniteev/c3","description":"A D3-based reusable chart library","fork":true,"url":"https://api.github.com/repos/cogniteev/c3","forks_url":"https://api.github.com/repos/cogniteev/c3/forks","keys_url":"https://api.github.com/repos/cogniteev/c3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cogniteev/c3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cogniteev/c3/teams","hooks_url":"https://api.github.com/repos/cogniteev/c3/hooks","issue_events_url":"https://api.github.com/repos/cogniteev/c3/issues/events{/number}","events_url":"https://api.github.com/repos/cogniteev/c3/events","assignees_url":"https://api.github.com/repos/cogniteev/c3/assignees{/user}","branches_url":"https://api.github.com/repos/cogniteev/c3/branches{/branch}","tags_url":"https://api.github.com/repos/cogniteev/c3/tags","blobs_url":"https://api.github.com/repos/cogniteev/c3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cogniteev/c3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cogniteev/c3/git/refs{/sha}","trees_url":"https://api.github.com/repos/cogniteev/c3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cogniteev/c3/statuses/{sha}","languages_url":"https://api.github.com/repos/cogniteev/c3/languages","stargazers_url":"https://api.github.com/repos/cogniteev/c3/stargazers","contributors_url":"https://api.github.com/repos/cogniteev/c3/contributors","subscribers_url":"https://api.github.com/repos/cogniteev/c3/subscribers","subscription_url":"https://api.github.com/repos/cogniteev/c3/subscription","commits_url":"https://api.github.com/repos/cogniteev/c3/commits{/sha}","git_commits_url":"https://api.github.com/repos/cogniteev/c3/git/commits{/sha}","comments_url":"https://api.github.com/repos/cogniteev/c3/comments{/number}","issue_comment_url":"https://api.github.com/repos/cogniteev/c3/issues/comments{/number}","contents_url":"https://api.github.com/repos/cogniteev/c3/contents/{+path}","compare_url":"https://api.github.com/repos/cogniteev/c3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cogniteev/c3/merges","archive_url":"https://api.github.com/repos/cogniteev/c3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cogniteev/c3/downloads","issues_url":"https://api.github.com/repos/cogniteev/c3/issues{/number}","pulls_url":"https://api.github.com/repos/cogniteev/c3/pulls{/number}","milestones_url":"https://api.github.com/repos/cogniteev/c3/milestones{/number}","notifications_url":"https://api.github.com/repos/cogniteev/c3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cogniteev/c3/labels{/name}","releases_url":"https://api.github.com/repos/cogniteev/c3/releases{/id}","deployments_url":"https://api.github.com/repos/cogniteev/c3/deployments","created_at":"2016-05-20T09:43:31Z","updated_at":"2018-03-22T08:06:12Z","pushed_at":"2018-03-22T12:50:36Z","git_url":"git://github.com/cogniteev/c3.git","ssh_url":"git@github.com:cogniteev/c3.git","clone_url":"https://github.com/cogniteev/c3.git","svn_url":"https://github.com/cogniteev/c3","homepage":"c3js.org","size":7307,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"c3js:master","ref":"master","sha":"208b8eca3b4647bd7eccf42e7f92a6720faa9594","user":{"login":"c3js","id":9966497,"avatar_url":"https://avatars2.githubusercontent.com/u/9966497?v=4","gravatar_id":"","url":"https://api.github.com/users/c3js","html_url":"https://github.com/c3js","followers_url":"https://api.github.com/users/c3js/followers","following_url":"https://api.github.com/users/c3js/following{/other_user}","gists_url":"https://api.github.com/users/c3js/gists{/gist_id}","starred_url":"https://api.github.com/users/c3js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3js/subscriptions","organizations_url":"https://api.github.com/users/c3js/orgs","repos_url":"https://api.github.com/users/c3js/repos","events_url":"https://api.github.com/users/c3js/events{/privacy}","received_events_url":"https://api.github.com/users/c3js/received_events","type":"Organization","site_admin":false},"repo":{"id":11496279,"name":"c3","full_name":"c3js/c3","owner":{"login":"c3js","id":9966497,"avatar_url":"https://avatars2.githubusercontent.com/u/9966497?v=4","gravatar_id":"","url":"https://api.github.com/users/c3js","html_url":"https://github.com/c3js","followers_url":"https://api.github.com/users/c3js/followers","following_url":"https://api.github.com/users/c3js/following{/other_user}","gists_url":"https://api.github.com/users/c3js/gists{/gist_id}","starred_url":"https://api.github.com/users/c3js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3js/subscriptions","organizations_url":"https://api.github.com/users/c3js/orgs","repos_url":"https://api.github.com/users/c3js/repos","events_url":"https://api.github.com/users/c3js/events{/privacy}","received_events_url":"https://api.github.com/users/c3js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/c3js/c3","description":"A D3-based reusable chart library","fork":false,"url":"https://api.github.com/repos/c3js/c3","forks_url":"https://api.github.com/repos/c3js/c3/forks","keys_url":"https://api.github.com/repos/c3js/c3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c3js/c3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c3js/c3/teams","hooks_url":"https://api.github.com/repos/c3js/c3/hooks","issue_events_url":"https://api.github.com/repos/c3js/c3/issues/events{/number}","events_url":"https://api.github.com/repos/c3js/c3/events","assignees_url":"https://api.github.com/repos/c3js/c3/assignees{/user}","branches_url":"https://api.github.com/repos/c3js/c3/branches{/branch}","tags_url":"https://api.github.com/repos/c3js/c3/tags","blobs_url":"https://api.github.com/repos/c3js/c3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c3js/c3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c3js/c3/git/refs{/sha}","trees_url":"https://api.github.com/repos/c3js/c3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c3js/c3/statuses/{sha}","languages_url":"https://api.github.com/repos/c3js/c3/languages","stargazers_url":"https://api.github.com/repos/c3js/c3/stargazers","contributors_url":"https://api.github.com/repos/c3js/c3/contributors","subscribers_url":"https://api.github.com/repos/c3js/c3/subscribers","subscription_url":"https://api.github.com/repos/c3js/c3/subscription","commits_url":"https://api.github.com/repos/c3js/c3/commits{/sha}","git_commits_url":"https://api.github.com/repos/c3js/c3/git/commits{/sha}","comments_url":"https://api.github.com/repos/c3js/c3/comments{/number}","issue_comment_url":"https://api.github.com/repos/c3js/c3/issues/comments{/number}","contents_url":"https://api.github.com/repos/c3js/c3/contents/{+path}","compare_url":"https://api.github.com/repos/c3js/c3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c3js/c3/merges","archive_url":"https://api.github.com/repos/c3js/c3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c3js/c3/downloads","issues_url":"https://api.github.com/repos/c3js/c3/issues{/number}","pulls_url":"https://api.github.com/repos/c3js/c3/pulls{/number}","milestones_url":"https://api.github.com/repos/c3js/c3/milestones{/number}","notifications_url":"https://api.github.com/repos/c3js/c3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c3js/c3/labels{/name}","releases_url":"https://api.github.com/repos/c3js/c3/releases{/id}","deployments_url":"https://api.github.com/repos/c3js/c3/deployments","created_at":"2013-07-18T06:51:40Z","updated_at":"2018-03-24T23:19:49Z","pushed_at":"2018-03-25T03:04:28Z","git_url":"git://github.com/c3js/c3.git","ssh_url":"git@github.com:c3js/c3.git","clone_url":"https://github.com/c3js/c3.git","svn_url":"https://github.com/c3js/c3","homepage":"c3js.org","size":8087,"stargazers_count":7578,"watchers_count":7578,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1254,"mirror_url":null,"archived":false,"open_issues_count":804,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1254,"open_issues":804,"watchers":7578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c3js/c3/pulls/2315"},"html":{"href":"https://github.com/c3js/c3/pull/2315"},"issue":{"href":"https://api.github.com/repos/c3js/c3/issues/2315"},"comments":{"href":"https://api.github.com/repos/c3js/c3/issues/2315/comments"},"review_comments":{"href":"https://api.github.com/repos/c3js/c3/pulls/2315/comments"},"review_comment":{"href":"https://api.github.com/repos/c3js/c3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c3js/c3/pulls/2315/commits"},"statuses":{"href":"https://api.github.com/repos/c3js/c3/statuses/4393ab1eeddb07a374f05e9857bcfea80006dc9f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kt3k","id":613956,"avatar_url":"https://avatars0.githubusercontent.com/u/613956?v=4","gravatar_id":"","url":"https://api.github.com/users/kt3k","html_url":"https://github.com/kt3k","followers_url":"https://api.github.com/users/kt3k/followers","following_url":"https://api.github.com/users/kt3k/following{/other_user}","gists_url":"https://api.github.com/users/kt3k/gists{/gist_id}","starred_url":"https://api.github.com/users/kt3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kt3k/subscriptions","organizations_url":"https://api.github.com/users/kt3k/orgs","repos_url":"https://api.github.com/users/kt3k/repos","events_url":"https://api.github.com/users/kt3k/events{/privacy}","received_events_url":"https://api.github.com/users/kt3k/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"kt3k"}}