{"action":"created","comment":{"url":"https://api.github.com/repos/google/keytransparency/pulls/comments/225711214","pull_request_review_id":165372172,"id":225711214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTcxMTIxNA==","diff_hunk":"@@ -77,9 +77,18 @@ type LogsReader interface {\n \tReadLog(ctx context.Context, domainID string, logID, low, high int64) ([]*mutator.LogMessage, error)\n }\n \n+// Batcher writes batch definitions to storage.\n+type Batcher interface {\n+\t// WriteBatchSources saves the (low, high] boundaries used for each log in making this revision.\n+\tWriteBatchSources(ctx context.Context, domainID string, revision int64, sources map[int64]*spb.MapMetadata_SourceSlice) error","path":"core/sequencer/server.go","position":7,"original_position":7,"commit_id":"da9e8a9eb877b1e0fe78138505fcdfcfeb315ab6","original_commit_id":"da9e8a9eb877b1e0fe78138505fcdfcfeb315ab6","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"line is 126 characters","created_at":"2018-10-16T21:18:06Z","updated_at":"2018-10-16T21:18:07Z","html_url":"https://github.com/google/keytransparency/pull/1069#discussion_r225711214","pull_request_url":"https://api.github.com/repos/google/keytransparency/pulls/1069","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments/225711214"},"html":{"href":"https://github.com/google/keytransparency/pull/1069#discussion_r225711214"},"pull_request":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1069"}}},"pull_request":{"url":"https://api.github.com/repos/google/keytransparency/pulls/1069","id":223398917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzk4OTE3","html_url":"https://github.com/google/keytransparency/pull/1069","diff_url":"https://github.com/google/keytransparency/pull/1069.diff","patch_url":"https://github.com/google/keytransparency/pull/1069.patch","issue_url":"https://api.github.com/repos/google/keytransparency/issues/1069","number":1069,"state":"open","locked":false,"title":"Write batch definitions to storage","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"Create a batches table to preserve the source metadata behind each map revision.\r\n\r\nThe map root metadata is not sufficient for this purpose because we need to commit the metadata to disk before we start creating each map revision.\r\n","created_at":"2018-10-16T21:16:23Z","updated_at":"2018-10-16T21:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52533b3342afe7ed73e8b9d872a32495675f8c54","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daviddrysdale","id":457208,"node_id":"MDQ6VXNlcjQ1NzIwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/457208?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/keytransparency/pulls/1069/commits","review_comments_url":"https://api.github.com/repos/google/keytransparency/pulls/1069/comments","review_comment_url":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/keytransparency/issues/1069/comments","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/da9e8a9eb877b1e0fe78138505fcdfcfeb315ab6","head":{"label":"gdbelvin:write_batch","ref":"write_batch","sha":"da9e8a9eb877b1e0fe78138505fcdfcfeb315ab6","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79116210,"node_id":"MDEwOlJlcG9zaXRvcnk3OTExNjIxMA==","name":"keytransparency","full_name":"gdbelvin/keytransparency","private":false,"owner":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gdbelvin/keytransparency","description":"A transparent and secure way to look up public keys.","fork":true,"url":"https://api.github.com/repos/gdbelvin/keytransparency","forks_url":"https://api.github.com/repos/gdbelvin/keytransparency/forks","keys_url":"https://api.github.com/repos/gdbelvin/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/keytransparency/teams","hooks_url":"https://api.github.com/repos/gdbelvin/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/keytransparency/events","assignees_url":"https://api.github.com/repos/gdbelvin/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/tags","blobs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/keytransparency/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscription","commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/keytransparency/merges","archive_url":"https://api.github.com/repos/gdbelvin/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/keytransparency/downloads","issues_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/keytransparency/deployments","created_at":"2017-01-16T12:28:44Z","updated_at":"2018-10-15T15:44:06Z","pushed_at":"2018-10-16T21:14:04Z","git_url":"git://github.com/gdbelvin/keytransparency.git","ssh_url":"git@github.com:gdbelvin/keytransparency.git","clone_url":"https://github.com/gdbelvin/keytransparency.git","svn_url":"https://github.com/gdbelvin/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":25184,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"f8c1fbee079758625f4a4697e5a712e80cf3d882","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37165115,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2NTExNQ==","name":"keytransparency","full_name":"google/keytransparency","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/keytransparency","description":"A transparent and secure way to look up public keys.","fork":false,"url":"https://api.github.com/repos/google/keytransparency","forks_url":"https://api.github.com/repos/google/keytransparency/forks","keys_url":"https://api.github.com/repos/google/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/keytransparency/teams","hooks_url":"https://api.github.com/repos/google/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/google/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/keytransparency/events","assignees_url":"https://api.github.com/repos/google/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/keytransparency/tags","blobs_url":"https://api.github.com/repos/google/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/keytransparency/languages","stargazers_url":"https://api.github.com/repos/google/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/google/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/google/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/google/keytransparency/subscription","commits_url":"https://api.github.com/repos/google/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/keytransparency/merges","archive_url":"https://api.github.com/repos/google/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/keytransparency/downloads","issues_url":"https://api.github.com/repos/google/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/google/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/keytransparency/deployments","created_at":"2015-06-09T23:55:20Z","updated_at":"2018-10-16T14:59:31Z","pushed_at":"2018-10-16T21:16:23Z","git_url":"git://github.com/google/keytransparency.git","ssh_url":"git@github.com:google/keytransparency.git","clone_url":"https://github.com/google/keytransparency.git","svn_url":"https://github.com/google/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":23596,"stargazers_count":1321,"watchers_count":1321,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":107,"open_issues":55,"watchers":1321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1069"},"html":{"href":"https://github.com/google/keytransparency/pull/1069"},"issue":{"href":"https://api.github.com/repos/google/keytransparency/issues/1069"},"comments":{"href":"https://api.github.com/repos/google/keytransparency/issues/1069/comments"},"review_comments":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1069/comments"},"review_comment":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1069/commits"},"statuses":{"href":"https://api.github.com/repos/google/keytransparency/statuses/da9e8a9eb877b1e0fe78138505fcdfcfeb315ab6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"golangcibot"}}