{"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments/167537113","pull_request_review_id":95768955,"id":167537113,"diff_hunk":"@@ -75,7 +75,7 @@ class EditPaymentReconciliationController extends EditController {\n     const data = req.form.values\n \n     // convert pounds to pence","path":"src/apps/omis/apps/edit/controllers/payment-reconciliation.js","position":3,"original_position":3,"commit_id":"3b0a11300e153558bcaa33176f918418f55ef843","original_commit_id":"3b0a11300e153558bcaa33176f918418f55ef843","user":{"login":"yeahfro","id":1150417,"avatar_url":"https://avatars0.githubusercontent.com/u/1150417?v=4","gravatar_id":"","url":"https://api.github.com/users/yeahfro","html_url":"https://github.com/yeahfro","followers_url":"https://api.github.com/users/yeahfro/followers","following_url":"https://api.github.com/users/yeahfro/following{/other_user}","gists_url":"https://api.github.com/users/yeahfro/gists{/gist_id}","starred_url":"https://api.github.com/users/yeahfro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeahfro/subscriptions","organizations_url":"https://api.github.com/users/yeahfro/orgs","repos_url":"https://api.github.com/users/yeahfro/repos","events_url":"https://api.github.com/users/yeahfro/events{/privacy}","received_events_url":"https://api.github.com/users/yeahfro/received_events","type":"User","site_admin":false},"body":"To me this comment is a smell and the line of code below could be self documenting","created_at":"2018-02-12T12:10:00Z","updated_at":"2018-02-12T12:10:00Z","html_url":"https://github.com/uktrade/data-hub-frontend/pull/1251#discussion_r167537113","pull_request_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments/167537113"},"html":{"href":"https://github.com/uktrade/data-hub-frontend/pull/1251#discussion_r167537113"},"pull_request":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251"}}},"pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251","id":168561269,"html_url":"https://github.com/uktrade/data-hub-frontend/pull/1251","diff_url":"https://github.com/uktrade/data-hub-frontend/pull/1251.diff","patch_url":"https://github.com/uktrade/data-hub-frontend/pull/1251.patch","issue_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1251","number":1251,"state":"open","locked":false,"title":"Fix rounding errors during OMIS reconciliation","user":{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false},"body":"It appears the previous fix hadn't caught all possibilities.\r\n\r\nIt was using `parseInt` which would round down rather than to the\r\nnearest whole number.\r\n\r\nThis caused the API to return a possible value mismatch on the\r\ntotal cost of the order.\r\n\r\nUsing `Math.round` ensures it will round to the closest integer and\r\navoid the API returning a mismatch in values.\r\n\r\n<!--- Add Jira ticket number this work relates to at the beginning of the Title -->\r\n","created_at":"2018-02-12T12:02:08Z","updated_at":"2018-02-12T12:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da22ab11fc9a08d7b712d60e1e1276ca1fefd74a","assignee":{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false},"assignees":[{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ztolley","id":56056,"avatar_url":"https://avatars1.githubusercontent.com/u/56056?v=4","gravatar_id":"","url":"https://api.github.com/users/ztolley","html_url":"https://github.com/ztolley","followers_url":"https://api.github.com/users/ztolley/followers","following_url":"https://api.github.com/users/ztolley/following{/other_user}","gists_url":"https://api.github.com/users/ztolley/gists{/gist_id}","starred_url":"https://api.github.com/users/ztolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztolley/subscriptions","organizations_url":"https://api.github.com/users/ztolley/orgs","repos_url":"https://api.github.com/users/ztolley/repos","events_url":"https://api.github.com/users/ztolley/events{/privacy}","received_events_url":"https://api.github.com/users/ztolley/received_events","type":"User","site_admin":false},{"login":"feedmypixel","id":2305016,"avatar_url":"https://avatars0.githubusercontent.com/u/2305016?v=4","gravatar_id":"","url":"https://api.github.com/users/feedmypixel","html_url":"https://github.com/feedmypixel","followers_url":"https://api.github.com/users/feedmypixel/followers","following_url":"https://api.github.com/users/feedmypixel/following{/other_user}","gists_url":"https://api.github.com/users/feedmypixel/gists{/gist_id}","starred_url":"https://api.github.com/users/feedmypixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedmypixel/subscriptions","organizations_url":"https://api.github.com/users/feedmypixel/orgs","repos_url":"https://api.github.com/users/feedmypixel/repos","events_url":"https://api.github.com/users/feedmypixel/events{/privacy}","received_events_url":"https://api.github.com/users/feedmypixel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":670004617,"url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels/OMIS","name":"OMIS","color":"1d76db","default":false},{"id":552540748,"url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1251/comments","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/3b0a11300e153558bcaa33176f918418f55ef843","head":{"label":"uktrade:patch/omis/reconciliation-rounding","ref":"patch/omis/reconciliation-rounding","sha":"3b0a11300e153558bcaa33176f918418f55ef843","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-12-06T11:06:00Z","pushed_at":"2018-02-12T12:02:09Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":4931,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":31,"watchers":0,"default_branch":"develop"}},"base":{"label":"uktrade:develop","ref":"develop","sha":"fa4ab450e18a9b4cc85663ab277fc7914d282265","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-12-06T11:06:00Z","pushed_at":"2018-02-12T12:02:09Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":4931,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":31,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251"},"html":{"href":"https://github.com/uktrade/data-hub-frontend/pull/1251"},"issue":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1251"},"comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/3b0a11300e153558bcaa33176f918418f55ef843"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yeahfro"}}