{"action":"closed","issue":{"url":"https://api.github.com/repos/sabotage-linux/gettext-tiny/issues/26","repository_url":"https://api.github.com/repos/sabotage-linux/gettext-tiny","labels_url":"https://api.github.com/repos/sabotage-linux/gettext-tiny/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/sabotage-linux/gettext-tiny/issues/26/comments","events_url":"https://api.github.com/repos/sabotage-linux/gettext-tiny/issues/26/events","html_url":"https://github.com/sabotage-linux/gettext-tiny/issues/26","id":334340633,"node_id":"MDU6SXNzdWUzMzQzNDA2MzM=","number":26,"title":"`msgmerge --version` confuses CMake","user":{"login":"awilfox","id":303838,"node_id":"MDQ6VXNlcjMwMzgzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/303838?v=4","gravatar_id":"","url":"https://api.github.com/users/awilfox","html_url":"https://github.com/awilfox","followers_url":"https://api.github.com/users/awilfox/followers","following_url":"https://api.github.com/users/awilfox/following{/other_user}","gists_url":"https://api.github.com/users/awilfox/gists{/gist_id}","starred_url":"https://api.github.com/users/awilfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awilfox/subscriptions","organizations_url":"https://api.github.com/users/awilfox/orgs","repos_url":"https://api.github.com/users/awilfox/repos","events_url":"https://api.github.com/users/awilfox/events{/privacy}","received_events_url":"https://api.github.com/users/awilfox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-06-21T05:11:09Z","updated_at":"2018-08-31T20:58:37Z","closed_at":"2018-08-31T20:58:37Z","author_association":"CONTRIBUTOR","body":"[CMake expects `msgmerge --version` to match the following regular expression](https://gitlab.kitware.com/cmake/cmake/blob/v3.11.4/Modules/FindGettext.cmake#L64):\r\n\r\n```\r\n^msgmerge \\(.*\\) ([^0-9.]+)\r\n```\r\n\r\nAs it stands, that is not the case.  This causes CMake to fail its own test suite (`GETTEXT_VERSION_STRING` is not defined despite `GETTEXT_FOUND`); if that test failure is ignored, it still won't set `GETTEXT_VERSION_STRING` correctly, which some packages use.\r\n\r\nI've written a very silly patch (that I will happily submit as a PR, if that would be easier for you) that fixes this:\r\n\r\n```patch\r\n--- gettext-tiny-0.3.0_pre1/src/msgmerge.c.old  2018-06-20 23:47:19.927932643 -0500\r\n+++ gettext-tiny-0.3.0_pre1/src/msgmerge.c      2018-06-20 23:55:12.997464272 -0500\r\n@@ -18,7 +18,7 @@\r\n __attribute__((noreturn))\r\n static void version(void) {\r\n        fprintf(stdout,\r\n-               \"these are not (GNU gettext-tools) 99.9999.9999\\n\");\r\n+               \"msgmerge (GNU gettext-tools; compatible) 0.19 (gettext-tiny) 0.3.0\\n\");\r\n        exit(0);\r\n }\r\n \r\n```\r\n\r\nHowever, I'm not sure if any other package looks for the exact string \"(GNU gettext-tools)\"... so I'm not sure if this is mergable as-is.\r\n\r\nFurther direction would be welcome and I'll be happy to build and test against whatever changes necessary.  If you would like to test yourself, from a built CMake tree run:\r\n\r\n```\r\nbin/ctest -R CMakeOnly.AllFindModules\r\n```"}}
{"actor":{"display_login":"rofl0r"}}