{"action":"opened","number":6339,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6339","id":201591305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTkxMzA1","html_url":"https://github.com/apache/flink/pull/6339","diff_url":"https://github.com/apache/flink/pull/6339.diff","patch_url":"https://github.com/apache/flink/pull/6339.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6339","number":6339,"state":"open","locked":false,"title":"[FLINK-9859][Runtime] Distinguish TM akka config with JM config","user":{"login":"tison1","id":18818196,"node_id":"MDQ6VXNlcjE4ODE4MTk2","avatar_url":"https://avatars0.githubusercontent.com/u/18818196?v=4","gravatar_id":"","url":"https://api.github.com/users/tison1","html_url":"https://github.com/tison1","followers_url":"https://api.github.com/users/tison1/followers","following_url":"https://api.github.com/users/tison1/following{/other_user}","gists_url":"https://api.github.com/users/tison1/gists{/gist_id}","starred_url":"https://api.github.com/users/tison1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tison1/subscriptions","organizations_url":"https://api.github.com/users/tison1/orgs","repos_url":"https://api.github.com/users/tison1/repos","events_url":"https://api.github.com/users/tison1/events{/privacy}","received_events_url":"https://api.github.com/users/tison1/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\n Distinguish TM akka config with JM config.\r\n\r\n 1. increase the number of akka threads on JM, to improve its performance\r\n 2. decrease the number of akka threads on TM, to save resource.\r\n\r\n\r\n## Brief change log\r\n  - `AkkaUtils`\r\n    - add a method `getTaskExecutorAkkaConfig` to distinguish TM's config with JM's\r\n    - also the config details\r\n  - `TaskManagerRunner` && `AkkaRpcServiceUtils` && `AkkaOptions`\r\n    - add a method `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor`\r\n    - add a config option `AkkaOptions#AKKA_PORT_BIND_TIMEOUT`, which defines the timeout of binding retry. This is used in `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor`\r\n    - `TaskManagerRunner#createRpcService` now uses `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor` to create RpcService\r\n  - add a test `AkkaRpcServiceUtilsTest` to see createRpcService works after changes above\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - Unit test. Locally create rpc service using customized config, to see whether we could createRpcService properly.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no, it is internal)\r\n","created_at":"2018-07-16T10:09:30Z","updated_at":"2018-07-16T10:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6339/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6339/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6339/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/019c018dfa994b6ef755823658adf613166659c8","head":{"label":"tison1:akka-improve","ref":"akka-improve","sha":"019c018dfa994b6ef755823658adf613166659c8","user":{"login":"tison1","id":18818196,"node_id":"MDQ6VXNlcjE4ODE4MTk2","avatar_url":"https://avatars0.githubusercontent.com/u/18818196?v=4","gravatar_id":"","url":"https://api.github.com/users/tison1","html_url":"https://github.com/tison1","followers_url":"https://api.github.com/users/tison1/followers","following_url":"https://api.github.com/users/tison1/following{/other_user}","gists_url":"https://api.github.com/users/tison1/gists{/gist_id}","starred_url":"https://api.github.com/users/tison1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tison1/subscriptions","organizations_url":"https://api.github.com/users/tison1/orgs","repos_url":"https://api.github.com/users/tison1/repos","events_url":"https://api.github.com/users/tison1/events{/privacy}","received_events_url":"https://api.github.com/users/tison1/received_events","type":"User","site_admin":false},"repo":{"id":131227051,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyMjcwNTE=","name":"flink","full_name":"tison1/flink","owner":{"login":"tison1","id":18818196,"node_id":"MDQ6VXNlcjE4ODE4MTk2","avatar_url":"https://avatars0.githubusercontent.com/u/18818196?v=4","gravatar_id":"","url":"https://api.github.com/users/tison1","html_url":"https://github.com/tison1","followers_url":"https://api.github.com/users/tison1/followers","following_url":"https://api.github.com/users/tison1/following{/other_user}","gists_url":"https://api.github.com/users/tison1/gists{/gist_id}","starred_url":"https://api.github.com/users/tison1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tison1/subscriptions","organizations_url":"https://api.github.com/users/tison1/orgs","repos_url":"https://api.github.com/users/tison1/repos","events_url":"https://api.github.com/users/tison1/events{/privacy}","received_events_url":"https://api.github.com/users/tison1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tison1/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tison1/flink","forks_url":"https://api.github.com/repos/tison1/flink/forks","keys_url":"https://api.github.com/repos/tison1/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tison1/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tison1/flink/teams","hooks_url":"https://api.github.com/repos/tison1/flink/hooks","issue_events_url":"https://api.github.com/repos/tison1/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tison1/flink/events","assignees_url":"https://api.github.com/repos/tison1/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tison1/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tison1/flink/tags","blobs_url":"https://api.github.com/repos/tison1/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tison1/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tison1/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tison1/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tison1/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tison1/flink/languages","stargazers_url":"https://api.github.com/repos/tison1/flink/stargazers","contributors_url":"https://api.github.com/repos/tison1/flink/contributors","subscribers_url":"https://api.github.com/repos/tison1/flink/subscribers","subscription_url":"https://api.github.com/repos/tison1/flink/subscription","commits_url":"https://api.github.com/repos/tison1/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tison1/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tison1/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tison1/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tison1/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tison1/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tison1/flink/merges","archive_url":"https://api.github.com/repos/tison1/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tison1/flink/downloads","issues_url":"https://api.github.com/repos/tison1/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tison1/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tison1/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tison1/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tison1/flink/labels{/name}","releases_url":"https://api.github.com/repos/tison1/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tison1/flink/deployments","created_at":"2018-04-27T01:04:42Z","updated_at":"2018-07-16T07:28:37Z","pushed_at":"2018-07-16T09:49:15Z","git_url":"git://github.com/tison1/flink.git","ssh_url":"git@github.com:tison1/flink.git","clone_url":"https://github.com/tison1/flink.git","svn_url":"https://github.com/tison1/flink","homepage":null,"size":159204,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5be27a23d3244430314e5ef6165cf82867173695","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-07-16T09:19:06Z","pushed_at":"2018-07-16T09:55:48Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":159936,"stargazers_count":3967,"watchers_count":3967,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2673,"mirror_url":null,"archived":false,"open_issues_count":352,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2673,"open_issues":352,"watchers":3967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6339"},"html":{"href":"https://github.com/apache/flink/pull/6339"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6339"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6339/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6339/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6339/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/019c018dfa994b6ef755823658adf613166659c8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":242,"deletions":12,"changed_files":5}}
{"actor":{"display_login":"tison1"}}