{"action":"opened","number":99,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99","id":170342243,"html_url":"https://github.com/jenkinsci/copyartifact-plugin/pull/99","diff_url":"https://github.com/jenkinsci/copyartifact-plugin/pull/99.diff","patch_url":"https://github.com/jenkinsci/copyartifact-plugin/pull/99.patch","issue_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/99","number":99,"state":"open","locked":false,"title":"[JENKINS-22637] ArtifactManager support","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"[JENKINS-22637](https://issues.jenkins-ci.org/browse/JENKINS-22637): supporting custom `ArtifactManager`s via `VirtualFile`. Unlike #71 the goal here is to make just this change with as little impact on existing installations as possible.\r\n\r\n- [X] basic refactoring\r\n- [ ] restore support for explicit excludes (might require core changes, TBD)\r\n- [ ] restore support for default excludes (ditto)\r\n- [ ] restore support for symlinks (TBD if core changes are required, though really if you care about platform-specific stuff like this you should create a tarball and archive that instead, since you cannot guarantee that the Jenkins master will preserve these nuances)\r\n- [ ] restore support for file mode handling (ditto)\r\n- [ ] integration test with the `compress-artifacts` plugin\r\n\r\nI also plan to\r\n\r\n- [ ] support direct download as per https://github.com/jenkinsci/jenkins/pull/3302\r\n\r\nbut this will certainly require a new core baseline and might better be filed as an add-on PR.\r\n\r\nNote that I am dropping the `Copier` extension point here. In practice I doubt this would be incompatible for anyone:\r\n* There are [no known external implementations](https://jenkins.io/doc/developer/extensions/copyartifact/).\r\n* This never really behaved like a regular extension point to begin with: the user cannot select an implementation! In fact `FilePathCopyMethod` was dead code—even as of 3cf80e567c8171428be377ddb2ec6855a7570dc3, it was always overridden by `FingerprintingCopyMethod`. And that one was rather misnamed as of #11—it may or may not do fingerprinting!\r\n* [JENKINS-7753](https://issues.jenkins-ci.org/browse/JENKINS-7753) claimed as justification\r\n  > I would like to implement a plug-in which provides CopyArtifact with rsync capabilities when copying workspaces between jobs. This will decrease load on the master and most likely increase IO-throughput.\r\n  \r\n  which is sensible enough but better handled via `ArtifactManager`, especially as of [JENKINS-49635](https://issues.jenkins-ci.org/browse/JENKINS-49635).\r\n\r\nI am also making an API change to `BuildSelector`. In this case there [_are_ two known external implementations](https://jenkins.io/doc/developer/extensions/copyartifact/) but neither override the `getSourceDirectory` method. In fact, other than `WorkspaceSelector`, it is hard to imagine any other useful override. I am making a cursory effort to retain compatibility with any external overrides just in case.\r\n\r\nSubsumes #98.\r\n\r\n@reviewbybees","created_at":"2018-02-20T23:54:34Z","updated_at":"2018-02-20T23:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":843310338,"url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/labels/work-in-progress","name":"work-in-progress","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/99/comments","statuses_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/statuses/6333853568ff8fc8565c06d2d2aa09149f0b4e6e","head":{"label":"jglick:VirtualFile-JENKINS-22637","ref":"VirtualFile-JENKINS-22637","sha":"6333853568ff8fc8565c06d2d2aa09149f0b4e6e","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":18770796,"name":"copyartifact-plugin","full_name":"jglick/copyartifact-plugin","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/copyartifact-plugin","description":"Jenkins copyartifact plugin","fork":true,"url":"https://api.github.com/repos/jglick/copyartifact-plugin","forks_url":"https://api.github.com/repos/jglick/copyartifact-plugin/forks","keys_url":"https://api.github.com/repos/jglick/copyartifact-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/copyartifact-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/copyartifact-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/copyartifact-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/copyartifact-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/copyartifact-plugin/events","assignees_url":"https://api.github.com/repos/jglick/copyartifact-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/copyartifact-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/copyartifact-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/copyartifact-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/copyartifact-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/copyartifact-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/copyartifact-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/copyartifact-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/copyartifact-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/copyartifact-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/copyartifact-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/copyartifact-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/copyartifact-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/copyartifact-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/copyartifact-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/copyartifact-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/copyartifact-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/copyartifact-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/copyartifact-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/copyartifact-plugin/merges","archive_url":"https://api.github.com/repos/jglick/copyartifact-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/copyartifact-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/copyartifact-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/copyartifact-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/copyartifact-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/copyartifact-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/copyartifact-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/copyartifact-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/copyartifact-plugin/deployments","created_at":"2014-04-14T18:03:29Z","updated_at":"2014-05-12T21:42:57Z","pushed_at":"2018-02-20T23:39:18Z","git_url":"git://github.com/jglick/copyartifact-plugin.git","ssh_url":"git@github.com:jglick/copyartifact-plugin.git","clone_url":"https://github.com/jglick/copyartifact-plugin.git","svn_url":"https://github.com/jglick/copyartifact-plugin","homepage":"http://jenkins-ci.org/","size":342,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"fcdad15925f17194f4769dbf6918001a67807471","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163489,"name":"copyartifact-plugin","full_name":"jenkinsci/copyartifact-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/copyartifact-plugin","description":"Jenkins copyartifact plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin","forks_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/deployments","created_at":"2010-12-13T05:29:41Z","updated_at":"2017-12-12T12:41:44Z","pushed_at":"2018-02-20T23:23:56Z","git_url":"git://github.com/jenkinsci/copyartifact-plugin.git","ssh_url":"git@github.com:jenkinsci/copyartifact-plugin.git","clone_url":"https://github.com/jenkinsci/copyartifact-plugin.git","svn_url":"https://github.com/jenkinsci/copyartifact-plugin","homepage":"http://jenkins-ci.org/","size":792,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":81,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99"},"html":{"href":"https://github.com/jenkinsci/copyartifact-plugin/pull/99"},"issue":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/99"},"comments":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/copyartifact-plugin/statuses/6333853568ff8fc8565c06d2d2aa09149f0b4e6e"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":155,"deletions":172,"changed_files":9}}
{"actor":{"display_login":"jglick"}}