{"action":"created","comment":{"url":"https://api.github.com/repos/CKI-project/skt/pulls/comments/238281897","pull_request_review_id":180782490,"id":238281897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODI4MTg5Nw==","diff_hunk":"@@ -443,11 +445,19 @@ def cmd_run(cfg):\n     run_report_path = join_with_slash(cfg.get('output_dir'), 'run.report')\n \n     runner = skt.runner.getrunner(*cfg.get('runner'))\n-    retcode, report_string = runner.run(cfg.get('buildurl'),\n-                                        cfg.get('max_aborted_count'),\n-                                        cfg.get('krelease'),\n-                                        cfg.get('wait'),\n-                                        arch=cfg.get(\"kernel_arch\"))\n+\n+    atexit.register(runner.cleanup_handler)\n+    signal.signal(signal.SIGINT, runner.signal_handler)","path":"skt/executable.py","position":20,"original_position":20,"commit_id":"84f6a87e836cab9e54d145610b2b3597ca7c9ff3","original_commit_id":"84f6a87e836cab9e54d145610b2b3597ca7c9ff3","user":{"login":"veruu","id":8031381,"node_id":"MDQ6VXNlcjgwMzEzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8031381?v=4","gravatar_id":"","url":"https://api.github.com/users/veruu","html_url":"https://github.com/veruu","followers_url":"https://api.github.com/users/veruu/followers","following_url":"https://api.github.com/users/veruu/following{/other_user}","gists_url":"https://api.github.com/users/veruu/gists{/gist_id}","starred_url":"https://api.github.com/users/veruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veruu/subscriptions","organizations_url":"https://api.github.com/users/veruu/orgs","repos_url":"https://api.github.com/users/veruu/repos","events_url":"https://api.github.com/users/veruu/events{/privacy}","received_events_url":"https://api.github.com/users/veruu/received_events","type":"User","site_admin":false},"body":"Right, forgot about that detail for a while. Real fun will be if that's what GitLab/UpShift use :D","created_at":"2018-12-03T14:11:56Z","updated_at":"2018-12-03T14:11:56Z","html_url":"https://github.com/CKI-project/skt/pull/400#discussion_r238281897","pull_request_url":"https://api.github.com/repos/CKI-project/skt/pulls/400","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/comments/238281897"},"html":{"href":"https://github.com/CKI-project/skt/pull/400#discussion_r238281897"},"pull_request":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/400"}},"in_reply_to_id":238270426},"pull_request":{"url":"https://api.github.com/repos/CKI-project/skt/pulls/400","id":235434810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDM0ODEw","html_url":"https://github.com/CKI-project/skt/pull/400","diff_url":"https://github.com/CKI-project/skt/pull/400.diff","patch_url":"https://github.com/CKI-project/skt/pull/400.patch","issue_url":"https://api.github.com/repos/CKI-project/skt/issues/400","number":400,"state":"open","locked":false,"title":"Always cancel beaker jobs on exit","user":{"login":"wizardofoz123","id":37542414,"node_id":"MDQ6VXNlcjM3NTQyNDE0","avatar_url":"https://avatars0.githubusercontent.com/u/37542414?v=4","gravatar_id":"","url":"https://api.github.com/users/wizardofoz123","html_url":"https://github.com/wizardofoz123","followers_url":"https://api.github.com/users/wizardofoz123/followers","following_url":"https://api.github.com/users/wizardofoz123/following{/other_user}","gists_url":"https://api.github.com/users/wizardofoz123/gists{/gist_id}","starred_url":"https://api.github.com/users/wizardofoz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizardofoz123/subscriptions","organizations_url":"https://api.github.com/users/wizardofoz123/orgs","repos_url":"https://api.github.com/users/wizardofoz123/repos","events_url":"https://api.github.com/users/wizardofoz123/events{/privacy}","received_events_url":"https://api.github.com/users/wizardofoz123/received_events","type":"User","site_admin":false},"body":"This implements FASTMOVING-357.\r\n\r\nAt the moment, if skt is terminated, it doesn't always cancel its Beaker\r\njobs.\r\n\r\nThis patch wraps runner.run() with cleanup handler using atexit and\r\nsignal. When skt terminates, runner's cancel_pending_jobs() is called.\r\n\r\nSigned-off-by: Jakub Racek <jracek@redhat.com>","created_at":"2018-12-03T12:46:30Z","updated_at":"2018-12-03T14:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"880c472f2a2ef7f20063dd000fa7c2efe241c588","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CKI-project/skt/pulls/400/commits","review_comments_url":"https://api.github.com/repos/CKI-project/skt/pulls/400/comments","review_comment_url":"https://api.github.com/repos/CKI-project/skt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CKI-project/skt/issues/400/comments","statuses_url":"https://api.github.com/repos/CKI-project/skt/statuses/84f6a87e836cab9e54d145610b2b3597ca7c9ff3","head":{"label":"wizardofoz123:master","ref":"master","sha":"84f6a87e836cab9e54d145610b2b3597ca7c9ff3","user":{"login":"wizardofoz123","id":37542414,"node_id":"MDQ6VXNlcjM3NTQyNDE0","avatar_url":"https://avatars0.githubusercontent.com/u/37542414?v=4","gravatar_id":"","url":"https://api.github.com/users/wizardofoz123","html_url":"https://github.com/wizardofoz123","followers_url":"https://api.github.com/users/wizardofoz123/followers","following_url":"https://api.github.com/users/wizardofoz123/following{/other_user}","gists_url":"https://api.github.com/users/wizardofoz123/gists{/gist_id}","starred_url":"https://api.github.com/users/wizardofoz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizardofoz123/subscriptions","organizations_url":"https://api.github.com/users/wizardofoz123/orgs","repos_url":"https://api.github.com/users/wizardofoz123/repos","events_url":"https://api.github.com/users/wizardofoz123/events{/privacy}","received_events_url":"https://api.github.com/users/wizardofoz123/received_events","type":"User","site_admin":false},"repo":{"id":160188373,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAxODgzNzM=","name":"skt","full_name":"wizardofoz123/skt","private":false,"owner":{"login":"wizardofoz123","id":37542414,"node_id":"MDQ6VXNlcjM3NTQyNDE0","avatar_url":"https://avatars0.githubusercontent.com/u/37542414?v=4","gravatar_id":"","url":"https://api.github.com/users/wizardofoz123","html_url":"https://github.com/wizardofoz123","followers_url":"https://api.github.com/users/wizardofoz123/followers","following_url":"https://api.github.com/users/wizardofoz123/following{/other_user}","gists_url":"https://api.github.com/users/wizardofoz123/gists{/gist_id}","starred_url":"https://api.github.com/users/wizardofoz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizardofoz123/subscriptions","organizations_url":"https://api.github.com/users/wizardofoz123/orgs","repos_url":"https://api.github.com/users/wizardofoz123/repos","events_url":"https://api.github.com/users/wizardofoz123/events{/privacy}","received_events_url":"https://api.github.com/users/wizardofoz123/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wizardofoz123/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":true,"url":"https://api.github.com/repos/wizardofoz123/skt","forks_url":"https://api.github.com/repos/wizardofoz123/skt/forks","keys_url":"https://api.github.com/repos/wizardofoz123/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wizardofoz123/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wizardofoz123/skt/teams","hooks_url":"https://api.github.com/repos/wizardofoz123/skt/hooks","issue_events_url":"https://api.github.com/repos/wizardofoz123/skt/issues/events{/number}","events_url":"https://api.github.com/repos/wizardofoz123/skt/events","assignees_url":"https://api.github.com/repos/wizardofoz123/skt/assignees{/user}","branches_url":"https://api.github.com/repos/wizardofoz123/skt/branches{/branch}","tags_url":"https://api.github.com/repos/wizardofoz123/skt/tags","blobs_url":"https://api.github.com/repos/wizardofoz123/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wizardofoz123/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wizardofoz123/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/wizardofoz123/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wizardofoz123/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/wizardofoz123/skt/languages","stargazers_url":"https://api.github.com/repos/wizardofoz123/skt/stargazers","contributors_url":"https://api.github.com/repos/wizardofoz123/skt/contributors","subscribers_url":"https://api.github.com/repos/wizardofoz123/skt/subscribers","subscription_url":"https://api.github.com/repos/wizardofoz123/skt/subscription","commits_url":"https://api.github.com/repos/wizardofoz123/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/wizardofoz123/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/wizardofoz123/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/wizardofoz123/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/wizardofoz123/skt/contents/{+path}","compare_url":"https://api.github.com/repos/wizardofoz123/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wizardofoz123/skt/merges","archive_url":"https://api.github.com/repos/wizardofoz123/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wizardofoz123/skt/downloads","issues_url":"https://api.github.com/repos/wizardofoz123/skt/issues{/number}","pulls_url":"https://api.github.com/repos/wizardofoz123/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/wizardofoz123/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/wizardofoz123/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wizardofoz123/skt/labels{/name}","releases_url":"https://api.github.com/repos/wizardofoz123/skt/releases{/id}","deployments_url":"https://api.github.com/repos/wizardofoz123/skt/deployments","created_at":"2018-12-03T12:35:39Z","updated_at":"2018-12-03T12:45:15Z","pushed_at":"2018-12-03T14:11:56Z","git_url":"git://github.com/wizardofoz123/skt.git","ssh_url":"git@github.com:wizardofoz123/skt.git","clone_url":"https://github.com/wizardofoz123/skt.git","svn_url":"https://github.com/wizardofoz123/skt","homepage":null,"size":703,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CKI-project:master","ref":"master","sha":"d495c32475dd4057a128ae0fbdc66533a38fa3ac","user":{"login":"CKI-project","id":36988735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTg4NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/CKI-project","html_url":"https://github.com/CKI-project","followers_url":"https://api.github.com/users/CKI-project/followers","following_url":"https://api.github.com/users/CKI-project/following{/other_user}","gists_url":"https://api.github.com/users/CKI-project/gists{/gist_id}","starred_url":"https://api.github.com/users/CKI-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CKI-project/subscriptions","organizations_url":"https://api.github.com/users/CKI-project/orgs","repos_url":"https://api.github.com/users/CKI-project/repos","events_url":"https://api.github.com/users/CKI-project/events{/privacy}","received_events_url":"https://api.github.com/users/CKI-project/received_events","type":"Organization","site_admin":false},"repo":{"id":123569786,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Njk3ODY=","name":"skt","full_name":"CKI-project/skt","private":false,"owner":{"login":"CKI-project","id":36988735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTg4NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/CKI-project","html_url":"https://github.com/CKI-project","followers_url":"https://api.github.com/users/CKI-project/followers","following_url":"https://api.github.com/users/CKI-project/following{/other_user}","gists_url":"https://api.github.com/users/CKI-project/gists{/gist_id}","starred_url":"https://api.github.com/users/CKI-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CKI-project/subscriptions","organizations_url":"https://api.github.com/users/CKI-project/orgs","repos_url":"https://api.github.com/users/CKI-project/repos","events_url":"https://api.github.com/users/CKI-project/events{/privacy}","received_events_url":"https://api.github.com/users/CKI-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CKI-project/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":false,"url":"https://api.github.com/repos/CKI-project/skt","forks_url":"https://api.github.com/repos/CKI-project/skt/forks","keys_url":"https://api.github.com/repos/CKI-project/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CKI-project/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CKI-project/skt/teams","hooks_url":"https://api.github.com/repos/CKI-project/skt/hooks","issue_events_url":"https://api.github.com/repos/CKI-project/skt/issues/events{/number}","events_url":"https://api.github.com/repos/CKI-project/skt/events","assignees_url":"https://api.github.com/repos/CKI-project/skt/assignees{/user}","branches_url":"https://api.github.com/repos/CKI-project/skt/branches{/branch}","tags_url":"https://api.github.com/repos/CKI-project/skt/tags","blobs_url":"https://api.github.com/repos/CKI-project/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CKI-project/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CKI-project/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/CKI-project/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CKI-project/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/CKI-project/skt/languages","stargazers_url":"https://api.github.com/repos/CKI-project/skt/stargazers","contributors_url":"https://api.github.com/repos/CKI-project/skt/contributors","subscribers_url":"https://api.github.com/repos/CKI-project/skt/subscribers","subscription_url":"https://api.github.com/repos/CKI-project/skt/subscription","commits_url":"https://api.github.com/repos/CKI-project/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/CKI-project/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/CKI-project/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/CKI-project/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/CKI-project/skt/contents/{+path}","compare_url":"https://api.github.com/repos/CKI-project/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CKI-project/skt/merges","archive_url":"https://api.github.com/repos/CKI-project/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CKI-project/skt/downloads","issues_url":"https://api.github.com/repos/CKI-project/skt/issues{/number}","pulls_url":"https://api.github.com/repos/CKI-project/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/CKI-project/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/CKI-project/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CKI-project/skt/labels{/name}","releases_url":"https://api.github.com/repos/CKI-project/skt/releases{/id}","deployments_url":"https://api.github.com/repos/CKI-project/skt/deployments","created_at":"2018-03-02T11:09:58Z","updated_at":"2018-11-27T17:02:48Z","pushed_at":"2018-12-03T12:46:31Z","git_url":"git://github.com/CKI-project/skt.git","ssh_url":"git@github.com:CKI-project/skt.git","clone_url":"https://github.com/CKI-project/skt.git","svn_url":"https://github.com/CKI-project/skt","homepage":null,"size":695,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":11,"open_issues":29,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/400"},"html":{"href":"https://github.com/CKI-project/skt/pull/400"},"issue":{"href":"https://api.github.com/repos/CKI-project/skt/issues/400"},"comments":{"href":"https://api.github.com/repos/CKI-project/skt/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CKI-project/skt/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/CKI-project/skt/statuses/84f6a87e836cab9e54d145610b2b3597ca7c9ff3"}},"author_association":"NONE"}}
{"actor":{"display_login":"veruu"}}