{"action":"created","comment":{"url":"https://api.github.com/repos/AugurProject/augur.js/pulls/comments/187471154","pull_request_review_id":119261175,"id":187471154,"diff_hunk":"@@ -221,33 +253,37 @@ function redeemContractFees(p, payload, successfulTransactions, failedTransactio\n }\n \n /**\n- * TODO: Add updated JSDoc info for input/returned values.\n- *\n  * Claims all reporting fees for a user as follows:\n  *\n- * If the forked market is finalized:\n- *   Call `Market.migrateThroughOneFork` for all non-forked, non-finalized non-migrated markets in the same universe as the forked market.\n- * Else:\n- *   Call `Market.disavowCrowdsourcers` for all non-forked, non-finalized, non-disavowed markets in the same universe as the forked market.\n+ * If a forked market exists in the current universe:\n+ *   For all non-finalized markets in current universe where the user has unclaimed fees in the reporting participants:\n+ *     Call `Market.disavowCrowdsourcers`\n  *\n- * Once the above transactions are finished:\n- *   Call `FeeWindow.redeem` on all specified FeeWindows\n- *   For each DisputeCrowdsourcer the user unredeemed staked in:\n- *     If its market is forked and `DisputeCrowdsourcer.fork` has not been called:\n- *       Call `DisputeCrowdsourcer.forkAndRedeem`\n- *     Else:\n- *       Call `DisputeCrowdsourcer.redeem`\n- *   For each InitialReporter the user has unredeemed stake in:\n- *     If its market is forked and `InitialReporter.fork` has not been called:\n- *       Call `InitialReporter.forkAndRedeem`\n+ * Once the above has been completed:\n+ *   Call `FeeWindow.redeem` on all fee windows in the current universe where the user has unclaimed participation tokens\n+ *   For each market participant of the forked market in which the user has unclaimed fees:\n+ *     If `DisputeCrowdsourcer.fork`/`InitialReporter.fork` has not been called:\n+ *       Call `DisputeCrowdsourcer.forkAndRedeem`/`InitialReporter.forkAndRedeem`\n  *     Else:\n- *       Call `InitialReporter.redeem`\n+ *       Call `DisputeCrowdsourcer.redeem`/`InitialReporter.redeem`\n+ *   For all other market participants:\n+ *     Call `DisputeCrowdsourcer.redeem`/`InitialReporter.redeem`","path":"src/reporting/claim-reporting-fees.js","position":null,"original_position":166,"commit_id":"07484efe76b77623869b0c5e9ee4a7fe51c32eaf","original_commit_id":"8044dd5b144e4cc0d04ee2bba1598d7ab0e98f69","user":{"login":"epheph","id":361654,"avatar_url":"https://avatars1.githubusercontent.com/u/361654?v=4","gravatar_id":"","url":"https://api.github.com/users/epheph","html_url":"https://github.com/epheph","followers_url":"https://api.github.com/users/epheph/followers","following_url":"https://api.github.com/users/epheph/following{/other_user}","gists_url":"https://api.github.com/users/epheph/gists{/gist_id}","starred_url":"https://api.github.com/users/epheph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epheph/subscriptions","organizations_url":"https://api.github.com/users/epheph/orgs","repos_url":"https://api.github.com/users/epheph/repos","events_url":"https://api.github.com/users/epheph/events{/privacy}","received_events_url":"https://api.github.com/users/epheph/received_events","type":"User","site_admin":false},"body":"When i hear \"non-forking-market\" i've been thinking that it implies a fork is going on","created_at":"2018-05-10T21:54:02Z","updated_at":"2018-05-10T21:54:02Z","html_url":"https://github.com/AugurProject/augur.js/pull/365#discussion_r187471154","pull_request_url":"https://api.github.com/repos/AugurProject/augur.js/pulls/365","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/comments/187471154"},"html":{"href":"https://github.com/AugurProject/augur.js/pull/365#discussion_r187471154"},"pull_request":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/365"}},"in_reply_to_id":187435820},"pull_request":{"url":"https://api.github.com/repos/AugurProject/augur.js/pulls/365","id":186808780,"html_url":"https://github.com/AugurProject/augur.js/pull/365","diff_url":"https://github.com/AugurProject/augur.js/pull/365.diff","patch_url":"https://github.com/AugurProject/augur.js/pull/365.patch","issue_url":"https://api.github.com/repos/AugurProject/augur.js/issues/365","number":365,"state":"open","locked":false,"title":"Update `augur.reporting.claimReportingFees` property names to match those returned by `augur.reporting.getReportingFees`","user":{"login":"adrake33","id":11491365,"avatar_url":"https://avatars0.githubusercontent.com/u/11491365?v=4","gravatar_id":"","url":"https://api.github.com/users/adrake33","html_url":"https://github.com/adrake33","followers_url":"https://api.github.com/users/adrake33/followers","following_url":"https://api.github.com/users/adrake33/following{/other_user}","gists_url":"https://api.github.com/users/adrake33/gists{/gist_id}","starred_url":"https://api.github.com/users/adrake33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrake33/subscriptions","organizations_url":"https://api.github.com/users/adrake33/orgs","repos_url":"https://api.github.com/users/adrake33/repos","events_url":"https://api.github.com/users/adrake33/events{/privacy}","received_events_url":"https://api.github.com/users/adrake33/received_events","type":"User","site_admin":false},"body":"Name changes & unit test fixes","created_at":"2018-05-09T03:29:20Z","updated_at":"2018-05-10T21:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"752ba5da223fff26439a3c2987c01c7f1b60dc26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nuevoalex","id":3839700,"avatar_url":"https://avatars2.githubusercontent.com/u/3839700?v=4","gravatar_id":"","url":"https://api.github.com/users/nuevoalex","html_url":"https://github.com/nuevoalex","followers_url":"https://api.github.com/users/nuevoalex/followers","following_url":"https://api.github.com/users/nuevoalex/following{/other_user}","gists_url":"https://api.github.com/users/nuevoalex/gists{/gist_id}","starred_url":"https://api.github.com/users/nuevoalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuevoalex/subscriptions","organizations_url":"https://api.github.com/users/nuevoalex/orgs","repos_url":"https://api.github.com/users/nuevoalex/repos","events_url":"https://api.github.com/users/nuevoalex/events{/privacy}","received_events_url":"https://api.github.com/users/nuevoalex/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AugurProject/augur.js/pulls/365/commits","review_comments_url":"https://api.github.com/repos/AugurProject/augur.js/pulls/365/comments","review_comment_url":"https://api.github.com/repos/AugurProject/augur.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AugurProject/augur.js/issues/365/comments","statuses_url":"https://api.github.com/repos/AugurProject/augur.js/statuses/07484efe76b77623869b0c5e9ee4a7fe51c32eaf","head":{"label":"AugurProject:adrake/ch9993/update-claimreportingfees-code-in-augur-js","ref":"adrake/ch9993/update-claimreportingfees-code-in-augur-js","sha":"07484efe76b77623869b0c5e9ee4a7fe51c32eaf","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":33982609,"name":"augur.js","full_name":"AugurProject/augur.js","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur.js","description":"Augur JavaScript API","fork":false,"url":"https://api.github.com/repos/AugurProject/augur.js","forks_url":"https://api.github.com/repos/AugurProject/augur.js/forks","keys_url":"https://api.github.com/repos/AugurProject/augur.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur.js/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur.js/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur.js/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur.js/events","assignees_url":"https://api.github.com/repos/AugurProject/augur.js/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur.js/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur.js/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur.js/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur.js/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur.js/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur.js/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur.js/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur.js/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur.js/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur.js/merges","archive_url":"https://api.github.com/repos/AugurProject/augur.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur.js/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur.js/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur.js/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur.js/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur.js/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur.js/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur.js/deployments","created_at":"2015-04-15T08:35:27Z","updated_at":"2018-05-10T19:07:31Z","pushed_at":"2018-05-10T19:34:46Z","git_url":"git://github.com/AugurProject/augur.js.git","ssh_url":"git@github.com:AugurProject/augur.js.git","clone_url":"https://github.com/AugurProject/augur.js.git","svn_url":"https://github.com/AugurProject/augur.js","homepage":"","size":72288,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":1,"watchers":108,"default_branch":"master"}},"base":{"label":"AugurProject:master","ref":"master","sha":"5338049a793edec5cc2221e089974b170c89a2d1","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":33982609,"name":"augur.js","full_name":"AugurProject/augur.js","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur.js","description":"Augur JavaScript API","fork":false,"url":"https://api.github.com/repos/AugurProject/augur.js","forks_url":"https://api.github.com/repos/AugurProject/augur.js/forks","keys_url":"https://api.github.com/repos/AugurProject/augur.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur.js/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur.js/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur.js/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur.js/events","assignees_url":"https://api.github.com/repos/AugurProject/augur.js/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur.js/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur.js/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur.js/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur.js/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur.js/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur.js/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur.js/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur.js/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur.js/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur.js/merges","archive_url":"https://api.github.com/repos/AugurProject/augur.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur.js/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur.js/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur.js/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur.js/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur.js/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur.js/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur.js/deployments","created_at":"2015-04-15T08:35:27Z","updated_at":"2018-05-10T19:07:31Z","pushed_at":"2018-05-10T19:34:46Z","git_url":"git://github.com/AugurProject/augur.js.git","ssh_url":"git@github.com:AugurProject/augur.js.git","clone_url":"https://github.com/AugurProject/augur.js.git","svn_url":"https://github.com/AugurProject/augur.js","homepage":"","size":72288,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":1,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/365"},"html":{"href":"https://github.com/AugurProject/augur.js/pull/365"},"issue":{"href":"https://api.github.com/repos/AugurProject/augur.js/issues/365"},"comments":{"href":"https://api.github.com/repos/AugurProject/augur.js/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AugurProject/augur.js/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/AugurProject/augur.js/statuses/07484efe76b77623869b0c5e9ee4a7fe51c32eaf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"epheph"}}