{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/212560919","pull_request_review_id":149221443,"id":212560919,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU2MDkxOQ==","diff_hunk":"@@ -26,20 +21,26 @@ function getPagedItems(state, config) {\n \n export function mapStateToProps(state, ownProps, cmfProps) {\n \tconst props = {};\n-\tconst config = {\n+\tlet filteredItems;\n+\tconst collectionItems = getCollectionItems(state, ownProps.collectionId);\n+\n+\tprops.config = {\n \t\tcollectionId: ownProps.collectionId,\n-\t\titems: ownProps.items,\n+\t\titems: collectionItems || ownProps.items || new List(),\n \t};\n \tif (ownProps.list) {\n-\t\tconfig.columns = ownProps.list.columns;\n+\t\tprops.config.columns = ownProps.list.columns;\n+\t}\n+\tif (ownProps.defaultSaga !== false) {","path":"packages/containers/src/List/List.connect.js","position":null,"original_position":40,"commit_id":"684746c296e989dd710df3b5ad3fe43dbab35971","original_commit_id":"14aa20062cff5251f7dc344d25a5a0e3366fea3f","user":{"login":"ybaskaran","id":34709414,"node_id":"MDQ6VXNlcjM0NzA5NDE0","avatar_url":"https://avatars2.githubusercontent.com/u/34709414?v=4","gravatar_id":"","url":"https://api.github.com/users/ybaskaran","html_url":"https://github.com/ybaskaran","followers_url":"https://api.github.com/users/ybaskaran/followers","following_url":"https://api.github.com/users/ybaskaran/following{/other_user}","gists_url":"https://api.github.com/users/ybaskaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ybaskaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybaskaran/subscriptions","organizations_url":"https://api.github.com/users/ybaskaran/orgs","repos_url":"https://api.github.com/users/ybaskaran/repos","events_url":"https://api.github.com/users/ybaskaran/events{/privacy}","received_events_url":"https://api.github.com/users/ybaskaran/received_events","type":"User","site_admin":false},"body":"fixed, enabled saga under default props and disabled filter and sorting conditionally if the target app needs to override the default list operations ","created_at":"2018-08-24T08:46:17Z","updated_at":"2018-08-24T08:46:17Z","html_url":"https://github.com/Talend/ui/pull/1590#discussion_r212560919","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/1590","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/212560919"},"html":{"href":"https://github.com/Talend/ui/pull/1590#discussion_r212560919"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/1590"}},"in_reply_to_id":211527385},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1590","id":206339234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzM5MjM0","html_url":"https://github.com/Talend/ui/pull/1590","diff_url":"https://github.com/Talend/ui/pull/1590.diff","patch_url":"https://github.com/Talend/ui/pull/1590.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/1590","number":1590,"state":"open","locked":false,"title":"feat(containers/List): default saga for filters and sorting","user":{"login":"ybaskaran","id":34709414,"node_id":"MDQ6VXNlcjM0NzA5NDE0","avatar_url":"https://avatars2.githubusercontent.com/u/34709414?v=4","gravatar_id":"","url":"https://api.github.com/users/ybaskaran","html_url":"https://github.com/ybaskaran","followers_url":"https://api.github.com/users/ybaskaran/followers","following_url":"https://api.github.com/users/ybaskaran/following{/other_user}","gists_url":"https://api.github.com/users/ybaskaran/gists{/gist_id}","starred_url":"https://api.github.com/users/ybaskaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybaskaran/subscriptions","organizations_url":"https://api.github.com/users/ybaskaran/orgs","repos_url":"https://api.github.com/users/ybaskaran/repos","events_url":"https://api.github.com/users/ybaskaran/events{/privacy}","received_events_url":"https://api.github.com/users/ybaskaran/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\nCustom functions support not available for filter and sorting in case required for server side filter or sorting with pagination.\r\n\r\n**What is the chosen solution to this problem?**\r\nAdded default saga for onToggle, onFilter and onSorting for ListContainer.\r\nThe custom saga can be defined in the application that will override the default action defined in the ListContainer.\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n* [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n* [x] Tests for the changes have been added (for bug fixes / features) And [non reg](./screenshots.md) done before need review\r\n* [ ] Docs have been added / updated (for bug fixes / features)\r\n* [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- if the PR introduces a breaking change, add the description here. So when you merge this PR, add this description into the [breaking change wiki](https://github.com/Talend/ui/wiki/BREAKING-CHANGE) in the next version -->\r\n\r\n<!-- **Original Template** -->\r\n\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n","created_at":"2018-08-06T09:27:41Z","updated_at":"2018-08-24T08:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54ca52c2f7feef725d36fd5517b6489c61b694d6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmfrancois","id":19857479,"node_id":"MDQ6VXNlcjE5ODU3NDc5","avatar_url":"https://avatars2.githubusercontent.com/u/19857479?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":530809343,"node_id":"MDU6TGFiZWw1MzA4MDkzNDM=","url":"https://api.github.com/repos/Talend/ui/labels/easy%20review","name":"easy review","color":"ff69b4","default":false},{"id":521021722,"node_id":"MDU6TGFiZWw1MjEwMjE3MjI=","url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/1590/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/1590/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1590/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/684746c296e989dd710df3b5ad3fe43dbab35971","head":{"label":"Talend:yatheesh/feat/containers/list_custom_filters","ref":"yatheesh/feat/containers/list_custom_filters","sha":"684746c296e989dd710df3b5ad3fe43dbab35971","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM0Mzk0Ng==","name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-08-23T15:40:17Z","pushed_at":"2018-08-24T08:43:09Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":31260,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":52,"watchers":60,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"3cbb3c1d057a6a2a73631d21be6ed36b83a0f7a1","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM0Mzk0Ng==","name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-08-23T15:40:17Z","pushed_at":"2018-08-24T08:43:09Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":31260,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":52,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/1590"},"html":{"href":"https://github.com/Talend/ui/pull/1590"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/1590"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/1590/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/1590/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/1590/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/684746c296e989dd710df3b5ad3fe43dbab35971"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ybaskaran"}}