{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/221259089","pull_request_review_id":159867587,"id":221259089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI1OTA4OQ==","diff_hunk":"@@ -23,11 +30,32 @@ impl Context {\n         logger: Arc<Mutex<Logger>>,\n         persister: Arc<Mutex<Persister>>,\n     ) -> Context {\n+        let (tx_action, _) = sync_channel(100);\n+        let (tx_observer, _) = sync_channel(100);","path":"core/src/context.rs","position":30,"original_position":30,"commit_id":"65c0a17ca117a80002d164e0a85e05f9642849ef","original_commit_id":"65c0a17ca117a80002d164e0a85e05f9642849ef","user":{"login":"ddd-mtl","id":34140573,"node_id":"MDQ6VXNlcjM0MTQwNTcz","avatar_url":"https://avatars3.githubusercontent.com/u/34140573?v=4","gravatar_id":"","url":"https://api.github.com/users/ddd-mtl","html_url":"https://github.com/ddd-mtl","followers_url":"https://api.github.com/users/ddd-mtl/followers","following_url":"https://api.github.com/users/ddd-mtl/following{/other_user}","gists_url":"https://api.github.com/users/ddd-mtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ddd-mtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddd-mtl/subscriptions","organizations_url":"https://api.github.com/users/ddd-mtl/orgs","repos_url":"https://api.github.com/users/ddd-mtl/repos","events_url":"https://api.github.com/users/ddd-mtl/events{/privacy}","received_events_url":"https://api.github.com/users/ddd-mtl/received_events","type":"User","site_admin":false},"body":"Magic number: Please use a global/struct const instead and possibly add a comment explaining the rationale behind that number.","created_at":"2018-09-28T13:49:55Z","updated_at":"2018-09-28T13:57:32Z","html_url":"https://github.com/holochain/holochain-rust/pull/390#discussion_r221259089","pull_request_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/390","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/221259089"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/390#discussion_r221259089"},"pull_request":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/390","id":218801645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODAxNjQ1","html_url":"https://github.com/holochain/holochain-rust/pull/390","diff_url":"https://github.com/holochain/holochain-rust/pull/390.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/390.patch","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/390","number":390,"state":"open","locked":false,"title":"[REFACTOR] Channels: now sync and in context","user":{"login":"lucksus","id":311749,"node_id":"MDQ6VXNlcjMxMTc0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311749?v=4","gravatar_id":"","url":"https://api.github.com/users/lucksus","html_url":"https://github.com/lucksus","followers_url":"https://api.github.com/users/lucksus/followers","following_url":"https://api.github.com/users/lucksus/following{/other_user}","gists_url":"https://api.github.com/users/lucksus/gists{/gist_id}","starred_url":"https://api.github.com/users/lucksus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucksus/subscriptions","organizations_url":"https://api.github.com/users/lucksus/orgs","repos_url":"https://api.github.com/users/lucksus/repos","events_url":"https://api.github.com/users/lucksus/events{/privacy}","received_events_url":"https://api.github.com/users/lucksus/received_events","type":"User","site_admin":false},"body":"preparation for #350 (pure reducer refactoring)\r\n\r\nSync channels (https://doc.rust-lang.org/std/sync/mpsc/fn.sync_channel.html) can easily be passed around between threads (which I need for #350).\r\nSince I had to touch every line that mentions channels (or their `Senders`) to change to `SyncSender` and since we have the `context` object holding the state and being passed to everything, I've put those channels into the context.","created_at":"2018-09-27T22:02:41Z","updated_at":"2018-09-28T13:57:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"902e8b3b754c6b7713eb1c7d853308932690eb81","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thedavidmeister","id":629710,"node_id":"MDQ6VXNlcjYyOTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/629710?v=4","gravatar_id":"","url":"https://api.github.com/users/thedavidmeister","html_url":"https://github.com/thedavidmeister","followers_url":"https://api.github.com/users/thedavidmeister/followers","following_url":"https://api.github.com/users/thedavidmeister/following{/other_user}","gists_url":"https://api.github.com/users/thedavidmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/thedavidmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedavidmeister/subscriptions","organizations_url":"https://api.github.com/users/thedavidmeister/orgs","repos_url":"https://api.github.com/users/thedavidmeister/repos","events_url":"https://api.github.com/users/thedavidmeister/events{/privacy}","received_events_url":"https://api.github.com/users/thedavidmeister/received_events","type":"User","site_admin":false},{"login":"AshantiMutinta","id":25762920,"node_id":"MDQ6VXNlcjI1NzYyOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/25762920?v=4","gravatar_id":"","url":"https://api.github.com/users/AshantiMutinta","html_url":"https://github.com/AshantiMutinta","followers_url":"https://api.github.com/users/AshantiMutinta/followers","following_url":"https://api.github.com/users/AshantiMutinta/following{/other_user}","gists_url":"https://api.github.com/users/AshantiMutinta/gists{/gist_id}","starred_url":"https://api.github.com/users/AshantiMutinta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshantiMutinta/subscriptions","organizations_url":"https://api.github.com/users/AshantiMutinta/orgs","repos_url":"https://api.github.com/users/AshantiMutinta/repos","events_url":"https://api.github.com/users/AshantiMutinta/events{/privacy}","received_events_url":"https://api.github.com/users/AshantiMutinta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937673517,"node_id":"MDU6TGFiZWw5Mzc2NzM1MTc=","url":"https://api.github.com/repos/holochain/holochain-rust/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/390/commits","review_comments_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/390/comments","review_comment_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/390/comments","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/65c0a17ca117a80002d164e0a85e05f9642849ef","head":{"label":"holochain:pre-350-channels-in-context","ref":"pre-350-channels-in-context","sha":"65c0a17ca117a80002d164e0a85e05f9642849ef","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"Holochain 2nd iteration in Rust with a Redux-like architecture and a WebAssembly Ribosome.","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-09-28T06:29:14Z","pushed_at":"2018-09-28T13:54:58Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":null,"size":3798,"stargazers_count":133,"watchers_count":133,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":167,"watchers":133,"default_branch":"develop"}},"base":{"label":"holochain:develop","ref":"develop","sha":"e32401b4e2fb0ba0cdb2e2fed6a0198c4877b92a","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"Holochain 2nd iteration in Rust with a Redux-like architecture and a WebAssembly Ribosome.","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-09-28T06:29:14Z","pushed_at":"2018-09-28T13:54:58Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":null,"size":3798,"stargazers_count":133,"watchers_count":133,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":167,"watchers":133,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/390"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/390"},"issue":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/390"},"comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/holochain-rust/statuses/65c0a17ca117a80002d164e0a85e05f9642849ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ddd-mtl"}}