{"action":"created","issue":{"url":"https://api.github.com/repos/open-company/open-company-web/issues/637","repository_url":"https://api.github.com/repos/open-company/open-company-web","labels_url":"https://api.github.com/repos/open-company/open-company-web/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/open-company/open-company-web/issues/637/comments","events_url":"https://api.github.com/repos/open-company/open-company-web/issues/637/events","html_url":"https://github.com/open-company/open-company-web/pull/637","id":361784736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjY3MjI3","number":637,"title":"New section cmail","user":{"login":"thepug","id":55220,"node_id":"MDQ6VXNlcjU1MjIw","avatar_url":"https://avatars3.githubusercontent.com/u/55220?v=4","gravatar_id":"","url":"https://api.github.com/users/thepug","html_url":"https://github.com/thepug","followers_url":"https://api.github.com/users/thepug/followers","following_url":"https://api.github.com/users/thepug/following{/other_user}","gists_url":"https://api.github.com/users/thepug/gists{/gist_id}","starred_url":"https://api.github.com/users/thepug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepug/subscriptions","organizations_url":"https://api.github.com/users/thepug/orgs","repos_url":"https://api.github.com/users/thepug/repos","events_url":"https://api.github.com/users/thepug/events{/privacy}","received_events_url":"https://api.github.com/users/thepug/received_events","type":"User","site_admin":false},"labels":[{"id":766670113,"node_id":"MDU6TGFiZWw3NjY2NzAxMTM=","url":"https://api.github.com/repos/open-company/open-company-web/labels/ready%20for%20review","name":"ready for review","color":"0e8749","default":false}],"state":"open","locked":false,"assignee":{"login":"thepug","id":55220,"node_id":"MDQ6VXNlcjU1MjIw","avatar_url":"https://avatars3.githubusercontent.com/u/55220?v=4","gravatar_id":"","url":"https://api.github.com/users/thepug","html_url":"https://github.com/thepug","followers_url":"https://api.github.com/users/thepug/followers","following_url":"https://api.github.com/users/thepug/following{/other_user}","gists_url":"https://api.github.com/users/thepug/gists{/gist_id}","starred_url":"https://api.github.com/users/thepug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepug/subscriptions","organizations_url":"https://api.github.com/users/thepug/orgs","repos_url":"https://api.github.com/users/thepug/repos","events_url":"https://api.github.com/users/thepug/events{/privacy}","received_events_url":"https://api.github.com/users/thepug/received_events","type":"User","site_admin":false},"assignees":[{"login":"thepug","id":55220,"node_id":"MDQ6VXNlcjU1MjIw","avatar_url":"https://avatars3.githubusercontent.com/u/55220?v=4","gravatar_id":"","url":"https://api.github.com/users/thepug","html_url":"https://github.com/thepug","followers_url":"https://api.github.com/users/thepug/followers","following_url":"https://api.github.com/users/thepug/following{/other_user}","gists_url":"https://api.github.com/users/thepug/gists{/gist_id}","starred_url":"https://api.github.com/users/thepug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thepug/subscriptions","organizations_url":"https://api.github.com/users/thepug/orgs","repos_url":"https://api.github.com/users/thepug/repos","events_url":"https://api.github.com/users/thepug/events{/privacy}","received_events_url":"https://api.github.com/users/thepug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-19T14:46:49Z","updated_at":"2018-09-19T20:48:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/open-company/open-company-web/pulls/637","html_url":"https://github.com/open-company/open-company-web/pull/637","diff_url":"https://github.com/open-company/open-company-web/pull/637.diff","patch_url":"https://github.com/open-company/open-company-web/pull/637.patch"},"body":"Needs https://github.com/open-company/open-company-storage/pull/148\r\n\r\nTest steps:\r\n\r\n- click new\r\n- before adding any other data change the section\r\n- click add new section and add a new one\r\n- [x] after adding the new section the post should auto save\r\n- [x] can you add a header or body and it correctly save?\r\n\r\n- click new\r\n- use an existing section\r\n- add a header\r\n- [x] does the post auto save correctly?"},"comment":{"url":"https://api.github.com/repos/open-company/open-company-web/issues/comments/422953136","html_url":"https://github.com/open-company/open-company-web/pull/637#issuecomment-422953136","issue_url":"https://api.github.com/repos/open-company/open-company-web/issues/637","id":422953136,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjk1MzEzNg==","user":{"login":"bago2k4","id":642704,"node_id":"MDQ6VXNlcjY0MjcwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/642704?v=4","gravatar_id":"","url":"https://api.github.com/users/bago2k4","html_url":"https://github.com/bago2k4","followers_url":"https://api.github.com/users/bago2k4/followers","following_url":"https://api.github.com/users/bago2k4/following{/other_user}","gists_url":"https://api.github.com/users/bago2k4/gists{/gist_id}","starred_url":"https://api.github.com/users/bago2k4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago2k4/subscriptions","organizations_url":"https://api.github.com/users/bago2k4/orgs","repos_url":"https://api.github.com/users/bago2k4/repos","events_url":"https://api.github.com/users/bago2k4/events{/privacy}","received_events_url":"https://api.github.com/users/bago2k4/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T20:48:43Z","updated_at":"2018-09-19T20:48:43Z","author_association":"MEMBER","body":"@thepug  you PRs checks out, i thought about some potential race condition though and i pushed 3 commits\r\n\r\none is very simple and is needed to show the Saving… label also when we are saving and not only when we are waiting to save (not only when has-changes is true but also when auto-saving is true)\r\n\r\nanother is to avoid saving the auto-saving flag in the local cookie, if we do save it and we pick up the entry from there autosave won’t never run because that is always true (we turn that off at the end of autosave)\r\n\r\nlast one is to avoid overriding user edits with the autosave return value, right now i do this:\r\nwhen autosave starts i remove has-changes and add auto-saving flags to avoid another autosave for the same data, when autosave finishes if it failed i put back auto-saving false and has-changes true, this way autosave will be retried next time. If autosave succeeded i simply remove auto-saving and don’t touch anything else (to avoid overriding user edits)\r\n\r\nwaiting for your check to merge this"}}
{"actor":{"display_login":"bago2k4"}}