{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/235041638","pull_request_review_id":176814548,"id":235041638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTA0MTYzOA==","diff_hunk":"@@ -93,60 +91,65 @@ test:\n \t${CONTAINER_ENGINE} build -t $(IMAGE_NAME)-candidate .\n \tIMAGE_NAME=$(IMAGE_NAME)-candidate test/run\n ----\n-====\n \n [[basic-testing-workflow]]\n \n == Basic Testing Workflow\n The *_test_* script assumes you have already built the image you want to\n-test. If required, first build the S2I image using:\n+test. If required, first build the S2I image. Run one of the following commands:\n \n-****\n-`$ podman build -t _<BUILDER_IMAGE_NAME>_`\n-or\n-`$ docker build -t _<BUILDER_IMAGE_NAME>_`\n-****\n+* If you use CRI-O, run the following command:\n++\n+----\n+$ podman build -t _<BUILDER_IMAGE_NAME>_\n+----\n+* If you use Docker, run the following command:\n++\n+----\n+$ docker build -t _<BUILDER_IMAGE_NAME>_\n+----\n \n The following steps describe the default workflow to test S2I image builders:\n \n . Verify the *_usage_* script is working:\n +\n-====\n-\n-****\n-`$ podman run _<BUILDER_IMAGE_NAME>_ .`\n-or\n-`$ docker run _<BUILDER_IMAGE_NAME>_ .`\n-****\n-====\n+* If you use CRI-O, run the following command:","path":"creating_images/s2i_testing.adoc","position":72,"original_position":72,"commit_id":"f21b46b81816de01b022c5650577882ce52987cb","original_commit_id":"f21b46b81816de01b022c5650577882ce52987cb","user":{"login":"rhatdan","id":2000835,"node_id":"MDQ6VXNlcjIwMDA4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2000835?v=4","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"s/CRI-O/podman/g","created_at":"2018-11-20T15:12:26Z","updated_at":"2018-11-20T15:13:09Z","html_url":"https://github.com/openshift/openshift-docs/pull/12904#discussion_r235041638","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/235041638"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/12904#discussion_r235041638"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904","id":232034800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDM0ODAw","html_url":"https://github.com/openshift/openshift-docs/pull/12904","diff_url":"https://github.com/openshift/openshift-docs/pull/12904.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/12904.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/12904","number":12904,"state":"open","locked":false,"title":"updating formatting","user":{"login":"kalexand-rh","id":37149781,"node_id":"MDQ6VXNlcjM3MTQ5Nzgx","avatar_url":"https://avatars1.githubusercontent.com/u/37149781?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexand-rh","html_url":"https://github.com/kalexand-rh","followers_url":"https://api.github.com/users/kalexand-rh/followers","following_url":"https://api.github.com/users/kalexand-rh/following{/other_user}","gists_url":"https://api.github.com/users/kalexand-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexand-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexand-rh/subscriptions","organizations_url":"https://api.github.com/users/kalexand-rh/orgs","repos_url":"https://api.github.com/users/kalexand-rh/repos","events_url":"https://api.github.com/users/kalexand-rh/events{/privacy}","received_events_url":"https://api.github.com/users/kalexand-rh/received_events","type":"User","site_admin":false},"body":"Follow up to https://github.com/openshift/openshift-docs/pull/12889 to update some code block formatting.\r\n\r\n@rhatdan, does this sound ok to you? ","created_at":"2018-11-19T16:27:38Z","updated_at":"2018-11-20T15:13:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e073d6deda153b140d14b79067100facfc858ecc","assignee":{"login":"kalexand-rh","id":37149781,"node_id":"MDQ6VXNlcjM3MTQ5Nzgx","avatar_url":"https://avatars1.githubusercontent.com/u/37149781?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexand-rh","html_url":"https://github.com/kalexand-rh","followers_url":"https://api.github.com/users/kalexand-rh/followers","following_url":"https://api.github.com/users/kalexand-rh/following{/other_user}","gists_url":"https://api.github.com/users/kalexand-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexand-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexand-rh/subscriptions","organizations_url":"https://api.github.com/users/kalexand-rh/orgs","repos_url":"https://api.github.com/users/kalexand-rh/repos","events_url":"https://api.github.com/users/kalexand-rh/events{/privacy}","received_events_url":"https://api.github.com/users/kalexand-rh/received_events","type":"User","site_admin":false},"assignees":[{"login":"kalexand-rh","id":37149781,"node_id":"MDQ6VXNlcjM3MTQ5Nzgx","avatar_url":"https://avatars1.githubusercontent.com/u/37149781?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexand-rh","html_url":"https://github.com/kalexand-rh","followers_url":"https://api.github.com/users/kalexand-rh/followers","following_url":"https://api.github.com/users/kalexand-rh/following{/other_user}","gists_url":"https://api.github.com/users/kalexand-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexand-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexand-rh/subscriptions","organizations_url":"https://api.github.com/users/kalexand-rh/orgs","repos_url":"https://api.github.com/users/kalexand-rh/repos","events_url":"https://api.github.com/users/kalexand-rh/events{/privacy}","received_events_url":"https://api.github.com/users/kalexand-rh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":896790383,"node_id":"MDU6TGFiZWw4OTY3OTAzODM=","url":"https://api.github.com/repos/openshift/openshift-docs/labels/branch/enterprise-3.11","name":"branch/enterprise-3.11","color":"eadf48","default":false},{"id":751705746,"node_id":"MDU6TGFiZWw3NTE3MDU3NDY=","url":"https://api.github.com/repos/openshift/openshift-docs/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":{"url":"https://api.github.com/repos/openshift/openshift-docs/milestones/7","html_url":"https://github.com/openshift/openshift-docs/milestone/7","labels_url":"https://api.github.com/repos/openshift/openshift-docs/milestones/7/labels","id":1436371,"node_id":"MDk6TWlsZXN0b25lMTQzNjM3MQ==","number":7,"title":"Next Release","description":"Content that can be cherrypicked to the noted branches (e.g., the branch/enterprise-3.1 or branch/enterprise-3.0 labels), which triggers new builds of the respective docs on the Customer Portal and docs.openshift.com. Aims for a weekly release cadence.","creator":{"login":"tpoitras","id":8109928,"node_id":"MDQ6VXNlcjgxMDk5Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8109928?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoitras","html_url":"https://github.com/tpoitras","followers_url":"https://api.github.com/users/tpoitras/followers","following_url":"https://api.github.com/users/tpoitras/following{/other_user}","gists_url":"https://api.github.com/users/tpoitras/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoitras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoitras/subscriptions","organizations_url":"https://api.github.com/users/tpoitras/orgs","repos_url":"https://api.github.com/users/tpoitras/repos","events_url":"https://api.github.com/users/tpoitras/events{/privacy}","received_events_url":"https://api.github.com/users/tpoitras/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":802,"state":"open","created_at":"2015-12-01T00:42:06Z","updated_at":"2018-11-20T01:07:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/12904/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/f21b46b81816de01b022c5650577882ce52987cb","head":{"label":"kalexand-rh:PR12889","ref":"PR12889","sha":"f21b46b81816de01b022c5650577882ce52987cb","user":{"login":"kalexand-rh","id":37149781,"node_id":"MDQ6VXNlcjM3MTQ5Nzgx","avatar_url":"https://avatars1.githubusercontent.com/u/37149781?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexand-rh","html_url":"https://github.com/kalexand-rh","followers_url":"https://api.github.com/users/kalexand-rh/followers","following_url":"https://api.github.com/users/kalexand-rh/following{/other_user}","gists_url":"https://api.github.com/users/kalexand-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexand-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexand-rh/subscriptions","organizations_url":"https://api.github.com/users/kalexand-rh/orgs","repos_url":"https://api.github.com/users/kalexand-rh/repos","events_url":"https://api.github.com/users/kalexand-rh/events{/privacy}","received_events_url":"https://api.github.com/users/kalexand-rh/received_events","type":"User","site_admin":false},"repo":{"id":124298857,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyOTg4NTc=","name":"openshift-docs","full_name":"kalexand-rh/openshift-docs","private":false,"owner":{"login":"kalexand-rh","id":37149781,"node_id":"MDQ6VXNlcjM3MTQ5Nzgx","avatar_url":"https://avatars1.githubusercontent.com/u/37149781?v=4","gravatar_id":"","url":"https://api.github.com/users/kalexand-rh","html_url":"https://github.com/kalexand-rh","followers_url":"https://api.github.com/users/kalexand-rh/followers","following_url":"https://api.github.com/users/kalexand-rh/following{/other_user}","gists_url":"https://api.github.com/users/kalexand-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/kalexand-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalexand-rh/subscriptions","organizations_url":"https://api.github.com/users/kalexand-rh/orgs","repos_url":"https://api.github.com/users/kalexand-rh/repos","events_url":"https://api.github.com/users/kalexand-rh/events{/privacy}","received_events_url":"https://api.github.com/users/kalexand-rh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kalexand-rh/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/kalexand-rh/openshift-docs","forks_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/forks","keys_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/teams","hooks_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/events","assignees_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/tags","blobs_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/subscription","commits_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/merges","archive_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/downloads","issues_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/kalexand-rh/openshift-docs/deployments","created_at":"2018-03-07T21:51:35Z","updated_at":"2018-10-12T15:17:10Z","pushed_at":"2018-11-19T20:33:54Z","git_url":"git://github.com/kalexand-rh/openshift-docs.git","ssh_url":"git@github.com:kalexand-rh/openshift-docs.git","clone_url":"https://github.com/kalexand-rh/openshift-docs.git","svn_url":"https://github.com/kalexand-rh/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":86195,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e154628a35d3d1921dd57de5e84fb41d8331bbcd","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MDg0NA==","name":"openshift-docs","full_name":"openshift/openshift-docs","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2018-11-20T09:43:23Z","pushed_at":"2018-11-20T15:02:35Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":86286,"stargazers_count":221,"watchers_count":221,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":618,"mirror_url":null,"archived":false,"open_issues_count":216,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":618,"open_issues":216,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/12904"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/12904"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/12904/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/12904/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/f21b46b81816de01b022c5650577882ce52987cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rhatdan"}}