{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1578","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1578/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1578/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1578/events","html_url":"https://github.com/kubevirt/kubevirt/pull/1578","id":366400675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDgzNjYx","number":1578,"title":"VMI configuration test: add retrying to make sure LimitRange cached","user":{"login":"lkpdn","id":17020294,"node_id":"MDQ6VXNlcjE3MDIwMjk0","avatar_url":"https://avatars3.githubusercontent.com/u/17020294?v=4","gravatar_id":"","url":"https://api.github.com/users/lkpdn","html_url":"https://github.com/lkpdn","followers_url":"https://api.github.com/users/lkpdn/followers","following_url":"https://api.github.com/users/lkpdn/following{/other_user}","gists_url":"https://api.github.com/users/lkpdn/gists{/gist_id}","starred_url":"https://api.github.com/users/lkpdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkpdn/subscriptions","organizations_url":"https://api.github.com/users/lkpdn/orgs","repos_url":"https://api.github.com/users/lkpdn/repos","events_url":"https://api.github.com/users/lkpdn/events{/privacy}","received_events_url":"https://api.github.com/users/lkpdn/received_events","type":"User","site_admin":false},"labels":[{"id":971140815,"node_id":"MDU6TGFiZWw5NzExNDA4MTU=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":583175065,"node_id":"MDU6TGFiZWw1ODMxNzUwNjU=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-03T15:35:52Z","updated_at":"2018-10-08T12:18:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1578","html_url":"https://github.com/kubevirt/kubevirt/pull/1578","diff_url":"https://github.com/kubevirt/kubevirt/pull/1578.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1578.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nVMI creation often succeeds just after the request to set LimitRange when it's not yet cached in virt-api side. Retrying 5 times ~~with its interval set to 1 second~~ should be enough. (c.f. https://github.com/kubevirt/kubevirt/pull/1567#issuecomment-426186191)\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nTested on my local cluster.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/427811224","html_url":"https://github.com/kubevirt/kubevirt/pull/1578#issuecomment-427811224","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1578","id":427811224,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzgxMTIyNA==","user":{"login":"lkpdn","id":17020294,"node_id":"MDQ6VXNlcjE3MDIwMjk0","avatar_url":"https://avatars3.githubusercontent.com/u/17020294?v=4","gravatar_id":"","url":"https://api.github.com/users/lkpdn","html_url":"https://github.com/lkpdn","followers_url":"https://api.github.com/users/lkpdn/followers","following_url":"https://api.github.com/users/lkpdn/following{/other_user}","gists_url":"https://api.github.com/users/lkpdn/gists{/gist_id}","starred_url":"https://api.github.com/users/lkpdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkpdn/subscriptions","organizations_url":"https://api.github.com/users/lkpdn/orgs","repos_url":"https://api.github.com/users/lkpdn/repos","events_url":"https://api.github.com/users/lkpdn/events{/privacy}","received_events_url":"https://api.github.com/users/lkpdn/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T12:18:30Z","updated_at":"2018-10-08T12:18:30Z","author_association":"NONE","body":"The point I was to trying to make is that our admission webhook is properly returning 422 error, which is caused by cached LimitRange, however the virtClient fails to decode the error (*1). Therefore https://github.com/kubevirt/kubevirt/commit/12a85cfa0396e9d277dd2efd07ceca1a6d937415 are unable to inspect the error to judge whether or not it was caused by the LimitRange and end up with the obscure error message e.g. https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2106/testReport/(root)/Tests%20Suite/Invoking_jobs___check_patch_k8s_1_11_0_dev_el7_x86_64___Configurations_VirtualMachineInstance_definition_with_namespace_memory_limits_above_VMI_required_memory_should_failed_to_start_the_VMI/\r\n\r\n(*1): at this part:\r\nhttps://github.com/kubevirt/kubevirt/blob/133570e055e4e863ed21e7051270baae5574dd21/vendor/k8s.io/client-go/rest/request.go#L1096-L1098"}}
{"actor":{"display_login":"lkpdn"}}