{"action":"created","issue":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/546","repository_url":"https://api.github.com/repos/OpenModelica/OMSimulator","labels_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/546/comments","events_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/546/events","html_url":"https://github.com/OpenModelica/OMSimulator/pull/546","id":396160887,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDM3NDk1","number":546,"title":"Misc warning fixes","user":{"login":"atrosinenko","id":9654772,"node_id":"MDQ6VXNlcjk2NTQ3NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/9654772?v=4","gravatar_id":"","url":"https://api.github.com/users/atrosinenko","html_url":"https://github.com/atrosinenko","followers_url":"https://api.github.com/users/atrosinenko/followers","following_url":"https://api.github.com/users/atrosinenko/following{/other_user}","gists_url":"https://api.github.com/users/atrosinenko/gists{/gist_id}","starred_url":"https://api.github.com/users/atrosinenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrosinenko/subscriptions","organizations_url":"https://api.github.com/users/atrosinenko/orgs","repos_url":"https://api.github.com/users/atrosinenko/repos","events_url":"https://api.github.com/users/atrosinenko/events{/privacy}","received_events_url":"https://api.github.com/users/atrosinenko/received_events","type":"User","site_admin":false},"labels":[{"id":1038996532,"node_id":"MDU6TGFiZWwxMDM4OTk2NTMy","url":"https://api.github.com/repos/OpenModelica/OMSimulator/labels/bug-fix","name":"bug-fix","color":"ee0701","default":false},{"id":929740224,"node_id":"MDU6TGFiZWw5Mjk3NDAyMjQ=","url":"https://api.github.com/repos/OpenModelica/OMSimulator/labels/refactoring","name":"refactoring","color":"48cadb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-01-05T12:18:31Z","updated_at":"2019-01-05T13:16:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/546","html_url":"https://github.com/OpenModelica/OMSimulator/pull/546","diff_url":"https://github.com/OpenModelica/OMSimulator/pull/546.diff","patch_url":"https://github.com/OpenModelica/OMSimulator/pull/546.patch"},"body":"### Related Issues\r\n\r\nMisc compiler warnings, most of them seem to be real issues, but review is required.\r\n\r\n### Purpose\r\n\r\n* To make easier to find one's own warnings introduced :)\r\n* To fix some errors that seems to be \"sleeping\" bugs\r\n\r\n### Approach\r\n\r\nMake code behave as intended as far as I understand it. I touched only seemingly obvious places. \r\n\r\nWhen comparing strings with `\"\"` I used slow-but-explicit approach with converting them to `std::string` as in other places in the code base. These particular cases can be optimized as `(str)[0] != 0` but this will probably make it harder to read.\r\n\r\n### Type of Change\r\n\r\n- Code refactoring (non-breaking change which improves maintainability)\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n### Checklist\r\n\r\n- I have performed a self-review of my own code\r\n\r\n### Open Questions and Pre-Merge TODOs\r\n\r\nReview is required to assert that these code snippets were really intended by their authors.\r\n"},"comment":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/comments/451654537","html_url":"https://github.com/OpenModelica/OMSimulator/pull/546#issuecomment-451654537","issue_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/546","id":451654537,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY1NDUzNw==","user":{"login":"atrosinenko","id":9654772,"node_id":"MDQ6VXNlcjk2NTQ3NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/9654772?v=4","gravatar_id":"","url":"https://api.github.com/users/atrosinenko","html_url":"https://github.com/atrosinenko","followers_url":"https://api.github.com/users/atrosinenko/followers","following_url":"https://api.github.com/users/atrosinenko/following{/other_user}","gists_url":"https://api.github.com/users/atrosinenko/gists{/gist_id}","starred_url":"https://api.github.com/users/atrosinenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrosinenko/subscriptions","organizations_url":"https://api.github.com/users/atrosinenko/orgs","repos_url":"https://api.github.com/users/atrosinenko/repos","events_url":"https://api.github.com/users/atrosinenko/events{/privacy}","received_events_url":"https://api.github.com/users/atrosinenko/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T13:16:24Z","updated_at":"2019-01-05T13:16:24Z","author_association":"CONTRIBUTOR","body":"Hmm... Maybe some of arguments to newly added `std::string(...)` constructors are `NULL`?"}}
{"actor":{"display_login":"atrosinenko"}}