{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/244417959","pull_request_review_id":188377546,"id":244417959,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQxNzk1OQ==","diff_hunk":"@@ -303,6 +304,9 @@ func (s *fsSource) Start() (chan resource.Event, error) {\n \n // New returns a File System implementation of runtime.Source.\n func New(root string, config *converter.Config) (runtime.Source, error) {\n+\tif config.ConvertK8SService {","path":"galley/pkg/fs/fssource.go","position":12,"original_position":12,"commit_id":"116c5066393b3e3e1da64aff3f90636c7865c3ce","original_commit_id":"116c5066393b3e3e1da64aff3f90636c7865c3ce","user":{"login":"qfel","id":1597796,"node_id":"MDQ6VXNlcjE1OTc3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1597796?v=4","gravatar_id":"","url":"https://api.github.com/users/qfel","html_url":"https://github.com/qfel","followers_url":"https://api.github.com/users/qfel/followers","following_url":"https://api.github.com/users/qfel/following{/other_user}","gists_url":"https://api.github.com/users/qfel/gists{/gist_id}","starred_url":"https://api.github.com/users/qfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qfel/subscriptions","organizations_url":"https://api.github.com/users/qfel/orgs","repos_url":"https://api.github.com/users/qfel/repos","events_url":"https://api.github.com/users/qfel/events{/privacy}","received_events_url":"https://api.github.com/users/qfel/received_events","type":"User","site_admin":false},"body":"Do you mean to pass []kube.ResourceSpec in converter.Config or as a separate argument? The latter might work, but the former would create an import cycle between kube and kube/converter","created_at":"2018-12-28T22:15:13Z","updated_at":"2018-12-28T22:15:14Z","html_url":"https://github.com/istio/istio/pull/10427#discussion_r244417959","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/10427","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/244417959"},"html":{"href":"https://github.com/istio/istio/pull/10427#discussion_r244417959"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/10427"}},"in_reply_to_id":244409608},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/10427","id":238135867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTM1ODY3","html_url":"https://github.com/istio/istio/pull/10427","diff_url":"https://github.com/istio/istio/pull/10427.diff","patch_url":"https://github.com/istio/istio/pull/10427.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/10427","number":10427,"state":"open","locked":false,"title":"Convert k8s services to Istio service entries in Galley","user":{"login":"qfel","id":1597796,"node_id":"MDQ6VXNlcjE1OTc3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1597796?v=4","gravatar_id":"","url":"https://api.github.com/users/qfel","html_url":"https://github.com/qfel","followers_url":"https://api.github.com/users/qfel/followers","following_url":"https://api.github.com/users/qfel/following{/other_user}","gists_url":"https://api.github.com/users/qfel/gists{/gist_id}","starred_url":"https://api.github.com/users/qfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qfel/subscriptions","organizations_url":"https://api.github.com/users/qfel/orgs","repos_url":"https://api.github.com/users/qfel/repos","events_url":"https://api.github.com/users/qfel/events{/privacy}","received_events_url":"https://api.github.com/users/qfel/received_events","type":"User","site_admin":false},"body":"For the moment ignore endpoint information. Since we're not doing incremental at the moment, constructing ServiceEntry from both endpoints and service resources would require interaction with k8s client (so when acting on service change we can get endpoints and vice versa).\r\n\r\nTreat TODOs as question to whoever knows this code, I do not intend to submit them.\r\n\r\ncc @ayj @ozevren @andraxylia ","created_at":"2018-12-12T18:21:15Z","updated_at":"2018-12-28T22:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a51e43749a81558cfddf3b6dd0ebcb9913ea63da","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},{"login":"Nino-K","id":10409174,"node_id":"MDQ6VXNlcjEwNDA5MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10409174?v=4","gravatar_id":"","url":"https://api.github.com/users/Nino-K","html_url":"https://github.com/Nino-K","followers_url":"https://api.github.com/users/Nino-K/followers","following_url":"https://api.github.com/users/Nino-K/following{/other_user}","gists_url":"https://api.github.com/users/Nino-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Nino-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nino-K/subscriptions","organizations_url":"https://api.github.com/users/Nino-K/orgs","repos_url":"https://api.github.com/users/Nino-K/repos","events_url":"https://api.github.com/users/Nino-K/events{/privacy}","received_events_url":"https://api.github.com/users/Nino-K/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":1116210980,"node_id":"MDU6TGFiZWwxMTE2MjEwOTgw","url":"https://api.github.com/repos/istio/istio/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/10427/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/10427/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/10427/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/116c5066393b3e3e1da64aff3f90636c7865c3ce","head":{"label":"qfel:master","ref":"master","sha":"116c5066393b3e3e1da64aff3f90636c7865c3ce","user":{"login":"qfel","id":1597796,"node_id":"MDQ6VXNlcjE1OTc3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1597796?v=4","gravatar_id":"","url":"https://api.github.com/users/qfel","html_url":"https://github.com/qfel","followers_url":"https://api.github.com/users/qfel/followers","following_url":"https://api.github.com/users/qfel/following{/other_user}","gists_url":"https://api.github.com/users/qfel/gists{/gist_id}","starred_url":"https://api.github.com/users/qfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qfel/subscriptions","organizations_url":"https://api.github.com/users/qfel/orgs","repos_url":"https://api.github.com/users/qfel/repos","events_url":"https://api.github.com/users/qfel/events{/privacy}","received_events_url":"https://api.github.com/users/qfel/received_events","type":"User","site_admin":false},"repo":{"id":156918013,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5MTgwMTM=","name":"istio","full_name":"qfel/istio","private":false,"owner":{"login":"qfel","id":1597796,"node_id":"MDQ6VXNlcjE1OTc3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1597796?v=4","gravatar_id":"","url":"https://api.github.com/users/qfel","html_url":"https://github.com/qfel","followers_url":"https://api.github.com/users/qfel/followers","following_url":"https://api.github.com/users/qfel/following{/other_user}","gists_url":"https://api.github.com/users/qfel/gists{/gist_id}","starred_url":"https://api.github.com/users/qfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qfel/subscriptions","organizations_url":"https://api.github.com/users/qfel/orgs","repos_url":"https://api.github.com/users/qfel/repos","events_url":"https://api.github.com/users/qfel/events{/privacy}","received_events_url":"https://api.github.com/users/qfel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qfel/istio","description":"Connect, secure, control, and observe services.","fork":true,"url":"https://api.github.com/repos/qfel/istio","forks_url":"https://api.github.com/repos/qfel/istio/forks","keys_url":"https://api.github.com/repos/qfel/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qfel/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qfel/istio/teams","hooks_url":"https://api.github.com/repos/qfel/istio/hooks","issue_events_url":"https://api.github.com/repos/qfel/istio/issues/events{/number}","events_url":"https://api.github.com/repos/qfel/istio/events","assignees_url":"https://api.github.com/repos/qfel/istio/assignees{/user}","branches_url":"https://api.github.com/repos/qfel/istio/branches{/branch}","tags_url":"https://api.github.com/repos/qfel/istio/tags","blobs_url":"https://api.github.com/repos/qfel/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qfel/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qfel/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/qfel/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qfel/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/qfel/istio/languages","stargazers_url":"https://api.github.com/repos/qfel/istio/stargazers","contributors_url":"https://api.github.com/repos/qfel/istio/contributors","subscribers_url":"https://api.github.com/repos/qfel/istio/subscribers","subscription_url":"https://api.github.com/repos/qfel/istio/subscription","commits_url":"https://api.github.com/repos/qfel/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/qfel/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/qfel/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/qfel/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/qfel/istio/contents/{+path}","compare_url":"https://api.github.com/repos/qfel/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qfel/istio/merges","archive_url":"https://api.github.com/repos/qfel/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qfel/istio/downloads","issues_url":"https://api.github.com/repos/qfel/istio/issues{/number}","pulls_url":"https://api.github.com/repos/qfel/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/qfel/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/qfel/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qfel/istio/labels{/name}","releases_url":"https://api.github.com/repos/qfel/istio/releases{/id}","deployments_url":"https://api.github.com/repos/qfel/istio/deployments","created_at":"2018-11-09T21:05:17Z","updated_at":"2018-12-28T20:44:54Z","pushed_at":"2018-12-28T20:44:51Z","git_url":"git://github.com/qfel/istio.git","ssh_url":"git@github.com:qfel/istio.git","clone_url":"https://github.com/qfel/istio.git","svn_url":"https://github.com/qfel/istio","homepage":"https://istio.io","size":55648,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.1","ref":"release-1.1","sha":"13dc08ac451985b9b022d011cf8a058597d6765e","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-12-28T15:22:21Z","pushed_at":"2018-12-28T22:05:18Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":55833,"stargazers_count":14127,"watchers_count":14127,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2194,"mirror_url":null,"archived":false,"open_issues_count":950,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2194,"open_issues":950,"watchers":14127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/10427"},"html":{"href":"https://github.com/istio/istio/pull/10427"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/10427"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/10427/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/10427/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/10427/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/116c5066393b3e3e1da64aff3f90636c7865c3ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"qfel"}}