{"action":"created","comment":{"url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/comments/173244495","pull_request_review_id":102402671,"id":173244495,"diff_hunk":"@@ -61,21 +80,10 @@ export default class MapController extends React.Component {\n   }\n \n   // Support functions\n-  \n-  hasValidData(symbol, props = this.props) {\n-    var dataLocation = symbol === 'variable' ? 'meta' : 'comparandMeta';\n-\n-    return !_.isUndefined(props[dataLocation]) &&\n-      props[dataLocation].length > 0;\n-  }\n-\n-  hasComparand() {\n-    return this.hasValidData('comparand');\n-  }\n \n   // TODO: https://github.com/pacificclimate/climate-explorer-frontend/issues/118\n-  currentDataset() {\n-    // Return encoding of currently selected dataset\n+  currentInstance() {","path":"src/components/MapController/DualMapController/DualMapController.js","position":85,"original_position":85,"commit_id":"ae2c83d9d33ba575713a7e5724e7869f18daa7ec","original_commit_id":"ae2c83d9d33ba575713a7e5724e7869f18daa7ec","user":{"login":"corviday","id":4512605,"avatar_url":"https://avatars1.githubusercontent.com/u/4512605?v=4","gravatar_id":"","url":"https://api.github.com/users/corviday","html_url":"https://github.com/corviday","followers_url":"https://api.github.com/users/corviday/followers","following_url":"https://api.github.com/users/corviday/following{/other_user}","gists_url":"https://api.github.com/users/corviday/gists{/gist_id}","starred_url":"https://api.github.com/users/corviday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corviday/subscriptions","organizations_url":"https://api.github.com/users/corviday/orgs","repos_url":"https://api.github.com/users/corviday/repos","events_url":"https://api.github.com/users/corviday/events{/privacy}","received_events_url":"https://api.github.com/users/corviday/received_events","type":"User","site_admin":false},"body":"I think datasetSpec would be confusing, since in the context of of ce frontend, \"dataset\" means \"a single file with data in it\" and this specification doesn't uniquely describe a single file. It uniquely describes a single - I don't know what to call it, which is sort of how it got called instance - chunk of model output, either a single run or a single run and climatology period, but there can be multiple files representing different views of that output and the specification describes all of them.\r\n\r\nHow do you feel about just dataSpec?\r\n\r\nAlternately, we could call single files datafiles and \"set of files representing a specific data chunk and / or the parameters that uniquely describe that chunk\" datasets, they'd be a set of files.","created_at":"2018-03-08T18:16:48Z","updated_at":"2018-03-08T18:16:48Z","html_url":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141#discussion_r173244495","pull_request_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/comments/173244495"},"html":{"href":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141#discussion_r173244495"},"pull_request":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141"}},"in_reply_to_id":172959507},"pull_request":{"url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141","id":172634420,"html_url":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141","diff_url":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141.diff","patch_url":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141.patch","issue_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/141","number":141,"state":"open","locked":false,"title":"Extreme Precipitation Portal","user":{"login":"corviday","id":4512605,"avatar_url":"https://avatars1.githubusercontent.com/u/4512605?v=4","gravatar_id":"","url":"https://api.github.com/users/corviday","html_url":"https://github.com/corviday","followers_url":"https://api.github.com/users/corviday/followers","following_url":"https://api.github.com/users/corviday/following{/other_user}","gists_url":"https://api.github.com/users/corviday/gists{/gist_id}","starred_url":"https://api.github.com/users/corviday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corviday/subscriptions","organizations_url":"https://api.github.com/users/corviday/orgs","repos_url":"https://api.github.com/users/corviday/repos","events_url":"https://api.github.com/users/corviday/events{/privacy}","received_events_url":"https://api.github.com/users/corviday/received_events","type":"User","site_admin":false},"body":"Adds a new portal for understanding precipitation extremes, `PrecipitationController`. This portal uses the existing `DualDataController`, but one of the two variables is always precipitation. Adds a variable response graph to `DualDataController`. Adds a new precipitation-centric map controller, `PrecipMapController`, which always renders logarithmically scaled color mappings, and shows precipitation as annotated isolines.\r\n\r\nChanges made in support of the new functionality that affect the whole codebase:\r\n1. Annual Cycle graphs will now display any combination of resolutions; previously they explicitly required at least one monthly dataset.\r\n2. Emissions scenarios are converted to a standard format when processing the multimeta query, and un-standardized when passed to the backend via queries.\r\n3. ` MapController` was split into three components: `SingleMapController`,` DualMapController`, and `PrecipMapController`. Common data-handling functionality was encapsulated in map-helpers.js, but there's still a lot of repeated code for wiring things up. More work will need to be done to really get the `MapControllers` into as nice a shape as the graphs are now. See #126 \r\n4. The Variable Response Graph is available to all comparison portals; it's part of `DualDataController`.\r\n-----------------------------------------------\r\nI finally completed the `dataset `/ `instance` split. Once upon a time, the parameters input by the user (variable, experiment, emissions scenario, start date, end date, and run) always uniquely described a single file containing all the data they were interested in, which we called a dataset. \r\n\r\nWhen we began separating different resolutions in different netCDF files (monthly, seasonal, annual), in accordance with the CF Standard, the two concepts \"the set of parameters a user has selected\" and \"a file that contains data the user wants\" no longer had a 1 to 1 relationship. This led to lots of variables and functions named `datasetWhatever` that might, confusingly, refer to either either \"a specific file with data in it\" or \"a set of parameters uniquely describing the data a user would like to see, but the data may be spread across up to three files.\"\r\n\r\nWe've been slowing converting every time the word \"dataset\" means \"a set of parameters describing the data a user wants\" to the word \"instance\" instead, as we work on each file affected. The only place that confusion was left was in MapController and its children, and I think I got it all cleaned up while splitting MapController into three components.\r\n\r\n**Instance** = the set of parameters describing the data a user is exploring (variable, period, run, model, and emissions scenario)\r\n**Dataset** = a specific file with data in it\r\n\r\nWe still have some really kludgy handling around the way instances work - they're frequently serialized and passed between components as strings the way filename strings used to be - but that's for another PR. See https://github.com/pacificclimate/climate-explorer-frontend/issues/118 or https://github.com/pacificclimate/climate-explorer-frontend/issues/74 , but the variable names should be less confusing.\r\n\r\n-----------------------------------------------\r\nThere is a test docker [here](http://docker2.pcic.uvic.ca:30302/#/precipitation/test_precipitation), but I hope to have a better ensemble with more variables for it soon. It is currently running against an ncWMS instance that only serves precipitation data, so if you look at non-precipitation portals, you won't see any maps. Should still be possible to evaluate the new Variable Response Graph, though.\r\n\r\nThe test ensemble also does not contain any annual climdex data for the rcp85 scenario. This is not a frontend bug.","created_at":"2018-03-03T00:09:21Z","updated_at":"2018-03-08T18:16:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad8d764cf343a6de3909d96c13da3b1440a08d5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141/commits","review_comments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141/comments","review_comment_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/141/comments","statuses_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/statuses/ae2c83d9d33ba575713a7e5724e7869f18daa7ec","head":{"label":"pacificclimate:feature/134","ref":"feature/134","sha":"ae2c83d9d33ba575713a7e5724e7869f18daa7ec","user":{"login":"pacificclimate","id":7443397,"avatar_url":"https://avatars0.githubusercontent.com/u/7443397?v=4","gravatar_id":"","url":"https://api.github.com/users/pacificclimate","html_url":"https://github.com/pacificclimate","followers_url":"https://api.github.com/users/pacificclimate/followers","following_url":"https://api.github.com/users/pacificclimate/following{/other_user}","gists_url":"https://api.github.com/users/pacificclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/pacificclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacificclimate/subscriptions","organizations_url":"https://api.github.com/users/pacificclimate/orgs","repos_url":"https://api.github.com/users/pacificclimate/repos","events_url":"https://api.github.com/users/pacificclimate/events{/privacy}","received_events_url":"https://api.github.com/users/pacificclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":47588182,"name":"climate-explorer-frontend","full_name":"pacificclimate/climate-explorer-frontend","owner":{"login":"pacificclimate","id":7443397,"avatar_url":"https://avatars0.githubusercontent.com/u/7443397?v=4","gravatar_id":"","url":"https://api.github.com/users/pacificclimate","html_url":"https://github.com/pacificclimate","followers_url":"https://api.github.com/users/pacificclimate/followers","following_url":"https://api.github.com/users/pacificclimate/following{/other_user}","gists_url":"https://api.github.com/users/pacificclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/pacificclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacificclimate/subscriptions","organizations_url":"https://api.github.com/users/pacificclimate/orgs","repos_url":"https://api.github.com/users/pacificclimate/repos","events_url":"https://api.github.com/users/pacificclimate/events{/privacy}","received_events_url":"https://api.github.com/users/pacificclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pacificclimate/climate-explorer-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend","forks_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/forks","keys_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/teams","hooks_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/hooks","issue_events_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/events","assignees_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/tags","blobs_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/languages","stargazers_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/stargazers","contributors_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/contributors","subscribers_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/subscribers","subscription_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/subscription","commits_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/merges","archive_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/downloads","issues_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/labels{/name}","releases_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/deployments","created_at":"2015-12-08T00:31:18Z","updated_at":"2017-05-18T02:16:37Z","pushed_at":"2018-03-07T17:47:42Z","git_url":"git://github.com/pacificclimate/climate-explorer-frontend.git","ssh_url":"git@github.com:pacificclimate/climate-explorer-frontend.git","clone_url":"https://github.com/pacificclimate/climate-explorer-frontend.git","svn_url":"https://github.com/pacificclimate/climate-explorer-frontend","homepage":null,"size":1014,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":1,"default_branch":"master"}},"base":{"label":"pacificclimate:master","ref":"master","sha":"9d95c5a024911af474feb9e02d6516f49662b293","user":{"login":"pacificclimate","id":7443397,"avatar_url":"https://avatars0.githubusercontent.com/u/7443397?v=4","gravatar_id":"","url":"https://api.github.com/users/pacificclimate","html_url":"https://github.com/pacificclimate","followers_url":"https://api.github.com/users/pacificclimate/followers","following_url":"https://api.github.com/users/pacificclimate/following{/other_user}","gists_url":"https://api.github.com/users/pacificclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/pacificclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacificclimate/subscriptions","organizations_url":"https://api.github.com/users/pacificclimate/orgs","repos_url":"https://api.github.com/users/pacificclimate/repos","events_url":"https://api.github.com/users/pacificclimate/events{/privacy}","received_events_url":"https://api.github.com/users/pacificclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":47588182,"name":"climate-explorer-frontend","full_name":"pacificclimate/climate-explorer-frontend","owner":{"login":"pacificclimate","id":7443397,"avatar_url":"https://avatars0.githubusercontent.com/u/7443397?v=4","gravatar_id":"","url":"https://api.github.com/users/pacificclimate","html_url":"https://github.com/pacificclimate","followers_url":"https://api.github.com/users/pacificclimate/followers","following_url":"https://api.github.com/users/pacificclimate/following{/other_user}","gists_url":"https://api.github.com/users/pacificclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/pacificclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacificclimate/subscriptions","organizations_url":"https://api.github.com/users/pacificclimate/orgs","repos_url":"https://api.github.com/users/pacificclimate/repos","events_url":"https://api.github.com/users/pacificclimate/events{/privacy}","received_events_url":"https://api.github.com/users/pacificclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pacificclimate/climate-explorer-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend","forks_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/forks","keys_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/teams","hooks_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/hooks","issue_events_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/events","assignees_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/tags","blobs_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/languages","stargazers_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/stargazers","contributors_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/contributors","subscribers_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/subscribers","subscription_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/subscription","commits_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/merges","archive_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/downloads","issues_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/labels{/name}","releases_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/deployments","created_at":"2015-12-08T00:31:18Z","updated_at":"2017-05-18T02:16:37Z","pushed_at":"2018-03-07T17:47:42Z","git_url":"git://github.com/pacificclimate/climate-explorer-frontend.git","ssh_url":"git@github.com:pacificclimate/climate-explorer-frontend.git","clone_url":"https://github.com/pacificclimate/climate-explorer-frontend.git","svn_url":"https://github.com/pacificclimate/climate-explorer-frontend","homepage":null,"size":1014,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141"},"html":{"href":"https://github.com/pacificclimate/climate-explorer-frontend/pull/141"},"issue":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/141"},"comments":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/pacificclimate/climate-explorer-frontend/statuses/ae2c83d9d33ba575713a7e5724e7869f18daa7ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"corviday"}}