{"action":"created","issue":{"url":"https://api.github.com/repos/cutelyst/cutelyst/issues/169","repository_url":"https://api.github.com/repos/cutelyst/cutelyst","labels_url":"https://api.github.com/repos/cutelyst/cutelyst/issues/169/labels{/name}","comments_url":"https://api.github.com/repos/cutelyst/cutelyst/issues/169/comments","events_url":"https://api.github.com/repos/cutelyst/cutelyst/issues/169/events","html_url":"https://github.com/cutelyst/cutelyst/issues/169","id":394865725,"node_id":"MDU6SXNzdWUzOTQ4NjU3MjU=","number":169,"title":"CSRF tag does not support XHTML","user":{"login":"sibbi77","id":1971630,"node_id":"MDQ6VXNlcjE5NzE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1971630?v=4","gravatar_id":"","url":"https://api.github.com/users/sibbi77","html_url":"https://github.com/sibbi77","followers_url":"https://api.github.com/users/sibbi77/followers","following_url":"https://api.github.com/users/sibbi77/following{/other_user}","gists_url":"https://api.github.com/users/sibbi77/gists{/gist_id}","starred_url":"https://api.github.com/users/sibbi77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibbi77/subscriptions","organizations_url":"https://api.github.com/users/sibbi77/orgs","repos_url":"https://api.github.com/users/sibbi77/repos","events_url":"https://api.github.com/users/sibbi77/events{/privacy}","received_events_url":"https://api.github.com/users/sibbi77/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-30T11:45:43Z","updated_at":"2018-12-30T22:12:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The function CSRFProtection::getTokenFormField() creates an unclosed input element, which is invalid in XHTML. The Grantlee view uses this function to generate content for the {% c_csrf_token %} tag.\r\nMy current solution is to avoid the nice tag and to code the complete input element using the csrf token from the stash. That's cumbersome.\r\nIt would be nice, if\r\n- there would be another tag e.g. {% c_xcsrf_token %}\r\nor\r\n- there would be a possibility to indicate XHTML usage either in Context or in CSRFProtection\r\n\r\nI can prepare a pull request, for one solution, if desired."},"comment":{"url":"https://api.github.com/repos/cutelyst/cutelyst/issues/comments/450590283","html_url":"https://github.com/cutelyst/cutelyst/issues/169#issuecomment-450590283","issue_url":"https://api.github.com/repos/cutelyst/cutelyst/issues/169","id":450590283,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU5MDI4Mw==","user":{"login":"sibbi77","id":1971630,"node_id":"MDQ6VXNlcjE5NzE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1971630?v=4","gravatar_id":"","url":"https://api.github.com/users/sibbi77","html_url":"https://github.com/sibbi77","followers_url":"https://api.github.com/users/sibbi77/followers","following_url":"https://api.github.com/users/sibbi77/following{/other_user}","gists_url":"https://api.github.com/users/sibbi77/gists{/gist_id}","starred_url":"https://api.github.com/users/sibbi77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibbi77/subscriptions","organizations_url":"https://api.github.com/users/sibbi77/orgs","repos_url":"https://api.github.com/users/sibbi77/repos","events_url":"https://api.github.com/users/sibbi77/events{/privacy}","received_events_url":"https://api.github.com/users/sibbi77/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T22:12:55Z","updated_at":"2018-12-30T22:12:55Z","author_association":"CONTRIBUTOR","body":"I'm not sure if it is a good idea to unconditionally self close the input element. There seem to be different opinions about how browsers should react or do react on such elements, if they find them in standard html 4.01 code... (see stackoverflow for such discussions)\r\nI would like to have completely valid html code from the framework, let it be html 4.01, 5 or xhtml5"}}
{"actor":{"display_login":"sibbi77"}}