{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/221412214","pull_request_review_id":160062254,"id":221412214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQxMjIxNA==","diff_hunk":"@@ -967,4 +967,23 @@ END_PROC(jitDecompileOnReturnJ)\n \n })\tdnl ASM_J9VM_ENV_DATA64\n \n+START_PROC(jitReadBarrier)\n+\tSWITCH_TO_C_STACK\n+\tSAVE_ALL_REGS\n+\n+\tdnl currentThread->javaVM->memoryManagerFunctions->J9ReadBarrier(currentThread, (fj9object_t*)currentThread->floatTemp1);\n+\n+\tmov    rax,QWORD PTR [rbp+J9TR_VMThread_javaVM]\n+\tmov    rsi,QWORD PTR [rbp+J9TR_VMThread_floatTemp1]\n+\tdnl javaVM->memoryManagerFunctions\n+\tmov    rax,QWORD PTR [rax+0x140]\n+\tmov    rdi, rbp\n+\tdnl memoryManagerFunctions->J9ReadBarrier\n+\tcall   QWORD PTR [rax+0x1f8]\n+\n+\tRESTORE_ALL_REGS\n+\tSWITCH_TO_JAVA_STACK\n+\tret","path":"runtime/codert_vm/xnathelp.m4","position":20,"original_position":20,"commit_id":"be1d5ae4bdc7899f1f98feb2032d28130b6be70b","original_commit_id":"be1d5ae4bdc7899f1f98feb2032d28130b6be70b","user":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"body":"Yes , it would be nice to use consistent spacing and capitalization, as well as using the const[reg] format rather than [reg+const]. Also, \"uword ptr\" is preferred for pointer-sized operations (not that I think this code will ever be used on 32-bit), and the _reg syntax for fullword registers.\r\n\r\nAlso, should this new code be under the 64-bit ifdef?","created_at":"2018-09-29T02:12:37Z","updated_at":"2018-09-29T02:12:37Z","html_url":"https://github.com/eclipse/openj9/pull/3075#discussion_r221412214","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/3075","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/221412214"},"html":{"href":"https://github.com/eclipse/openj9/pull/3075#discussion_r221412214"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3075"}},"in_reply_to_id":221410466},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3075","id":219096925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDk2OTI1","html_url":"https://github.com/eclipse/openj9/pull/3075","diff_url":"https://github.com/eclipse/openj9/pull/3075.diff","patch_url":"https://github.com/eclipse/openj9/pull/3075.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3075","number":3075,"state":"open","locked":false,"title":"WIP: Concurrent Scavenger Read Barrier evaluator on X86-64","user":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"body":"X86-64 compressedrefs now supports read barriers for Concurrent Scavenger.\r\n\r\nPart of #3054\r\n\r\nSigned-off-by: Victor Ding <dvictor@ca.ibm.com>","created_at":"2018-09-28T22:05:45Z","updated_at":"2018-09-29T02:12:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8879ba0070c8bd1672d0348a5793ad456563df90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3075/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3075/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3075/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/be1d5ae4bdc7899f1f98feb2032d28130b6be70b","head":{"label":"0dvictor:csrdbar","ref":"csrdbar","sha":"be1d5ae4bdc7899f1f98feb2032d28130b6be70b","user":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"repo":{"id":103417105,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0MTcxMDU=","name":"openj9","full_name":"0dvictor/openj9","private":false,"owner":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/0dvictor/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/0dvictor/openj9","forks_url":"https://api.github.com/repos/0dvictor/openj9/forks","keys_url":"https://api.github.com/repos/0dvictor/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0dvictor/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0dvictor/openj9/teams","hooks_url":"https://api.github.com/repos/0dvictor/openj9/hooks","issue_events_url":"https://api.github.com/repos/0dvictor/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/0dvictor/openj9/events","assignees_url":"https://api.github.com/repos/0dvictor/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/0dvictor/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/0dvictor/openj9/tags","blobs_url":"https://api.github.com/repos/0dvictor/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0dvictor/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0dvictor/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/0dvictor/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0dvictor/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/0dvictor/openj9/languages","stargazers_url":"https://api.github.com/repos/0dvictor/openj9/stargazers","contributors_url":"https://api.github.com/repos/0dvictor/openj9/contributors","subscribers_url":"https://api.github.com/repos/0dvictor/openj9/subscribers","subscription_url":"https://api.github.com/repos/0dvictor/openj9/subscription","commits_url":"https://api.github.com/repos/0dvictor/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/0dvictor/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/0dvictor/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/0dvictor/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/0dvictor/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/0dvictor/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0dvictor/openj9/merges","archive_url":"https://api.github.com/repos/0dvictor/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0dvictor/openj9/downloads","issues_url":"https://api.github.com/repos/0dvictor/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/0dvictor/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/0dvictor/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/0dvictor/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0dvictor/openj9/labels{/name}","releases_url":"https://api.github.com/repos/0dvictor/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/0dvictor/openj9/deployments","created_at":"2017-09-13T15:26:58Z","updated_at":"2018-09-28T20:17:20Z","pushed_at":"2018-09-29T02:04:58Z","git_url":"git://github.com/0dvictor/openj9.git","ssh_url":"git@github.com:0dvictor/openj9.git","clone_url":"https://github.com/0dvictor/openj9.git","svn_url":"https://github.com/0dvictor/openj9","homepage":null,"size":34750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d6ae8cf2c12e07b643b86182c343c0e2d7cd3a40","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-09-29T00:11:23Z","pushed_at":"2018-09-29T02:05:00Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":34733,"stargazers_count":1427,"watchers_count":1427,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":474,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":280,"open_issues":474,"watchers":1427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3075"},"html":{"href":"https://github.com/eclipse/openj9/pull/3075"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3075"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3075/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3075/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3075/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/be1d5ae4bdc7899f1f98feb2032d28130b6be70b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gacholio"}}