{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments/205879120","pull_request_review_id":141243580,"id":205879120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg3OTEyMA==","diff_hunk":"@@ -0,0 +1,1122 @@\n+{\n+  \"source\": \"telemetry-cohorts\",\n+  \"filters\": {\n+    \"docType\": [\n+      \"main\"\n+    ],\n+    \"appName\": [\n+      \"Firefox\"\n+    ],\n+    \"experimentId\": [\n+      \"pref-flip-savant-1457226-de-existing-users\",\n+      \"pref-flip-savant-1457226-de-new-users\",\n+      \"pref-flip-savant-1457226-en-existing-users\",\n+      \"pref-flip-savant-1457226-en-new-users\"\n+    ]\n+  },\n+  \"eventGroups\": [\n+    {\n+      \"eventGroupName\": \"SAVANT\",\n+      \"events\": [\n+        {\n+          \"name\": \"open bookmark\",\n+          \"description\": \"client opens a bookmark\",\n+          \"amplitudeProperties\": {\n+            \"meta-cat-1\": \"'navigate'\",\n+            \"meta-cat-2\": \"'bookmark'\"\n+          },\n+          \"schema\": {\n+            \"$schema\": \"http://json-schema.org/schema#\",\n+            \"type\": \"object\",\n+            \"properties\": {\n+              \"timestamp\": {\n+                \"type\": \"number\",\n+                \"minimum\": 0\n+              },\n+              \"category\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"savant\"\n+                ]\n+              },\n+              \"method\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"follow_bookmark\"\n+                ]\n+              }\n+            },\n+            \"required\": [\n+              \"timestamp\",\n+              \"category\",\n+              \"method\"\n+            ]\n+          }\n+        },\n+        {\n+          \"name\": \"save bookmark\",\n+          \"description\": \"client saves a bookmark\",\n+          \"amplitudeProperties\": {\n+            \"meta-cat-1\": \"'feature'\",\n+            \"meta-cat-2\": \"'bookmark'\"\n+          },\n+          \"schema\": {\n+            \"$schema\": \"http://json-schema.org/schema#\",\n+            \"type\": \"object\",\n+            \"properties\": {\n+              \"timestamp\": {\n+                \"type\": \"number\",\n+                \"minimum\": 0\n+              },\n+              \"category\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"savant\"\n+                ]\n+              },\n+              \"method\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"bookmark\"\n+                ]\n+              },\n+              \"object\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"save\"\n+                ]\n+              }\n+            },\n+            \"required\": [\n+              \"timestamp\",\n+              \"category\",\n+              \"method\",\n+              \"object\"\n+            ]\n+          }\n+        },\n+        {\n+          \"name\": \"remove bookmark\",\n+          \"description\": \"client removes a bookmark\",\n+          \"amplitudeProperties\": {\n+            \"meta-cat-1\": \"'feature'\",\n+            \"meta-cat-2\": \"'bookmark'\"\n+          },\n+          \"schema\": {\n+            \"$schema\": \"http://json-schema.org/schema#\",\n+            \"type\": \"object\",\n+            \"properties\": {\n+              \"timestamp\": {\n+                \"type\": \"number\",\n+                \"minimum\": 0\n+              },\n+              \"category\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"savant\"\n+                ]\n+              },\n+              \"method\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"bookmark\"\n+                ]\n+              },\n+              \"object\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"remove\"\n+                ]\n+              }\n+            },\n+            \"required\": [\n+              \"timestamp\",\n+              \"category\",\n+              \"method\",\n+              \"object\"\n+            ]\n+          }\n+        },\n+        {\n+          \"name\": \"open hamburger menu\",\n+          \"description\": \"client opens the hamburger menu\",\n+          \"amplitudeProperties\": {\n+            \"meta-cat-1\": \"'feature'\"\n+          },\n+          \"schema\": {\n+            \"$schema\": \"http://json-schema.org/schema#\",\n+            \"type\": \"object\",\n+            \"properties\": {\n+              \"timestamp\": {\n+                \"type\": \"number\",\n+                \"minimum\": 0\n+              },\n+              \"category\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"savant\"\n+                ]\n+              },\n+              \"method\": {\n+                \"type\": \"string\",\n+                \"enum\": [\n+                  \"hamburger_menu\"\n+                ]\n+              }\n+            },\n+            \"required\": [\n+              \"timestamp\",\n+              \"category\",\n+              \"method\"","path":"configs/desktop_savant_events_schemas.json","position":52,"original_position":170,"commit_id":"30ac1447e1184b6cfa0768e73c5d1613323a708c","original_commit_id":"30ac1447e1184b6cfa0768e73c5d1613323a708c","user":{"login":"sunahsuh","id":953153,"node_id":"MDQ6VXNlcjk1MzE1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/953153?v=4","gravatar_id":"","url":"https://api.github.com/users/sunahsuh","html_url":"https://github.com/sunahsuh","followers_url":"https://api.github.com/users/sunahsuh/followers","following_url":"https://api.github.com/users/sunahsuh/following{/other_user}","gists_url":"https://api.github.com/users/sunahsuh/gists{/gist_id}","starred_url":"https://api.github.com/users/sunahsuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunahsuh/subscriptions","organizations_url":"https://api.github.com/users/sunahsuh/orgs","repos_url":"https://api.github.com/users/sunahsuh/repos","events_url":"https://api.github.com/users/sunahsuh/events{/privacy}","received_events_url":"https://api.github.com/users/sunahsuh/received_events","type":"User","site_admin":false},"body":"There aren't *now*, but the definitions could change under us – I see no disadvantage to being explicit, and an advantage of some safety","created_at":"2018-07-27T19:38:26Z","updated_at":"2018-07-27T19:38:26Z","html_url":"https://github.com/mozilla/telemetry-streaming/pull/160#discussion_r205879120","pull_request_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments/205879120"},"html":{"href":"https://github.com/mozilla/telemetry-streaming/pull/160#discussion_r205879120"},"pull_request":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160"}},"in_reply_to_id":205863518},"pull_request":{"url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160","id":204240549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjQwNTQ5","html_url":"https://github.com/mozilla/telemetry-streaming/pull/160","diff_url":"https://github.com/mozilla/telemetry-streaming/pull/160.diff","patch_url":"https://github.com/mozilla/telemetry-streaming/pull/160.patch","issue_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/160","number":160,"state":"open","locked":false,"title":"Bug 1474987 Add pipeline for Savant events to Amplitude","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"This adds the JSON file to support Savant event mappings and adds a few new features to support those mappings.\r\n\r\nFirst, we now support literal fields. Values enclosed in single quotes will output the literal value rather than looking up the property in the event.\r\n\r\nSecond, we now support dataset sources other than \"telemetry\".","created_at":"2018-07-26T19:16:53Z","updated_at":"2018-07-27T19:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4fc0df8b9c1e73ed3f792f22c6f77b503c04fb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160/commits","review_comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160/comments","review_comment_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/160/comments","statuses_url":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/30ac1447e1184b6cfa0768e73c5d1613323a708c","head":{"label":"jklukas:savant-amplitude","ref":"savant-amplitude","sha":"30ac1447e1184b6cfa0768e73c5d1613323a708c","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"repo":{"id":137925083,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MjUwODM=","name":"telemetry-streaming","full_name":"jklukas/telemetry-streaming","owner":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklukas/telemetry-streaming","description":"Spark Streaming ETL jobs for Mozilla Telemetry","fork":true,"url":"https://api.github.com/repos/jklukas/telemetry-streaming","forks_url":"https://api.github.com/repos/jklukas/telemetry-streaming/forks","keys_url":"https://api.github.com/repos/jklukas/telemetry-streaming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklukas/telemetry-streaming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklukas/telemetry-streaming/teams","hooks_url":"https://api.github.com/repos/jklukas/telemetry-streaming/hooks","issue_events_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues/events{/number}","events_url":"https://api.github.com/repos/jklukas/telemetry-streaming/events","assignees_url":"https://api.github.com/repos/jklukas/telemetry-streaming/assignees{/user}","branches_url":"https://api.github.com/repos/jklukas/telemetry-streaming/branches{/branch}","tags_url":"https://api.github.com/repos/jklukas/telemetry-streaming/tags","blobs_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklukas/telemetry-streaming/statuses/{sha}","languages_url":"https://api.github.com/repos/jklukas/telemetry-streaming/languages","stargazers_url":"https://api.github.com/repos/jklukas/telemetry-streaming/stargazers","contributors_url":"https://api.github.com/repos/jklukas/telemetry-streaming/contributors","subscribers_url":"https://api.github.com/repos/jklukas/telemetry-streaming/subscribers","subscription_url":"https://api.github.com/repos/jklukas/telemetry-streaming/subscription","commits_url":"https://api.github.com/repos/jklukas/telemetry-streaming/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklukas/telemetry-streaming/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklukas/telemetry-streaming/contents/{+path}","compare_url":"https://api.github.com/repos/jklukas/telemetry-streaming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklukas/telemetry-streaming/merges","archive_url":"https://api.github.com/repos/jklukas/telemetry-streaming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklukas/telemetry-streaming/downloads","issues_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues{/number}","pulls_url":"https://api.github.com/repos/jklukas/telemetry-streaming/pulls{/number}","milestones_url":"https://api.github.com/repos/jklukas/telemetry-streaming/milestones{/number}","notifications_url":"https://api.github.com/repos/jklukas/telemetry-streaming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklukas/telemetry-streaming/labels{/name}","releases_url":"https://api.github.com/repos/jklukas/telemetry-streaming/releases{/id}","deployments_url":"https://api.github.com/repos/jklukas/telemetry-streaming/deployments","created_at":"2018-06-19T17:39:59Z","updated_at":"2018-06-19T20:06:12Z","pushed_at":"2018-07-27T18:05:33Z","git_url":"git://github.com/jklukas/telemetry-streaming.git","ssh_url":"git@github.com:jklukas/telemetry-streaming.git","clone_url":"https://github.com/jklukas/telemetry-streaming.git","svn_url":"https://github.com/jklukas/telemetry-streaming","homepage":"","size":417,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"1ed39379966b70fc8c636e5ac2f92df87f6a759a","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":78219155,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIxOTE1NQ==","name":"telemetry-streaming","full_name":"mozilla/telemetry-streaming","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/telemetry-streaming","description":"Spark Streaming ETL jobs for Mozilla Telemetry","fork":false,"url":"https://api.github.com/repos/mozilla/telemetry-streaming","forks_url":"https://api.github.com/repos/mozilla/telemetry-streaming/forks","keys_url":"https://api.github.com/repos/mozilla/telemetry-streaming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/telemetry-streaming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/telemetry-streaming/teams","hooks_url":"https://api.github.com/repos/mozilla/telemetry-streaming/hooks","issue_events_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/telemetry-streaming/events","assignees_url":"https://api.github.com/repos/mozilla/telemetry-streaming/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/telemetry-streaming/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/telemetry-streaming/tags","blobs_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/telemetry-streaming/languages","stargazers_url":"https://api.github.com/repos/mozilla/telemetry-streaming/stargazers","contributors_url":"https://api.github.com/repos/mozilla/telemetry-streaming/contributors","subscribers_url":"https://api.github.com/repos/mozilla/telemetry-streaming/subscribers","subscription_url":"https://api.github.com/repos/mozilla/telemetry-streaming/subscription","commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/telemetry-streaming/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/telemetry-streaming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/telemetry-streaming/merges","archive_url":"https://api.github.com/repos/mozilla/telemetry-streaming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/telemetry-streaming/downloads","issues_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/telemetry-streaming/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/telemetry-streaming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/telemetry-streaming/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/telemetry-streaming/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/deployments","created_at":"2017-01-06T16:05:58Z","updated_at":"2018-07-24T18:42:41Z","pushed_at":"2018-07-27T18:05:35Z","git_url":"git://github.com/mozilla/telemetry-streaming.git","ssh_url":"git@github.com:mozilla/telemetry-streaming.git","clone_url":"https://github.com/mozilla/telemetry-streaming.git","svn_url":"https://github.com/mozilla/telemetry-streaming","homepage":"","size":497,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":9,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160"},"html":{"href":"https://github.com/mozilla/telemetry-streaming/pull/160"},"issue":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/160"},"comments":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/30ac1447e1184b6cfa0768e73c5d1613323a708c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sunahsuh"}}