{"action":"created","issue":{"url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/311","repository_url":"https://api.github.com/repos/stepancheg/rust-protobuf","labels_url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/311/labels{/name}","comments_url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/311/comments","events_url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/311/events","html_url":"https://github.com/stepancheg/rust-protobuf/issues/311","id":335374396,"node_id":"MDU6SXNzdWUzMzUzNzQzOTY=","number":311,"title":"Implement serde::Serialize for well known types","user":{"login":"marcelbuesing","id":5637837,"node_id":"MDQ6VXNlcjU2Mzc4Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5637837?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelbuesing","html_url":"https://github.com/marcelbuesing","followers_url":"https://api.github.com/users/marcelbuesing/followers","following_url":"https://api.github.com/users/marcelbuesing/following{/other_user}","gists_url":"https://api.github.com/users/marcelbuesing/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelbuesing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelbuesing/subscriptions","organizations_url":"https://api.github.com/users/marcelbuesing/orgs","repos_url":"https://api.github.com/users/marcelbuesing/repos","events_url":"https://api.github.com/users/marcelbuesing/events{/privacy}","received_events_url":"https://api.github.com/users/marcelbuesing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-25T11:54:04Z","updated_at":"2018-07-11T00:30:16Z","closed_at":null,"author_association":"NONE","body":"Proto\r\n```\r\nsyntax = \"proto3\";\r\n\r\nimport \"google/protobuf/timestamp.proto\";\r\n\r\nmessage Xyz {\r\n    google.protobuf.Timestamp timestamp = 1;\r\n    string abc = 2;\r\n}\r\n```\r\n\r\n\r\n```\r\nerror[E0277]: the trait bound `protobuf::well_known_types::Timestamp: serde::Serialize` is not satisfied\r\n  --> src/test/main.rs:5:1\r\n   |\r\n27 |     #[serde(serialize_with = \"::protobuf_serde::serialize_singular_ptr_field\")]\r\n   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `serde::Serialize` is not implemented for `protobuf::well_known_types::Timestamp\r\n```"},"comment":{"url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/comments/404007254","html_url":"https://github.com/stepancheg/rust-protobuf/issues/311#issuecomment-404007254","issue_url":"https://api.github.com/repos/stepancheg/rust-protobuf/issues/311","id":404007254,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDAwNzI1NA==","user":{"login":"stepancheg","id":28969,"node_id":"MDQ6VXNlcjI4OTY5","avatar_url":"https://avatars2.githubusercontent.com/u/28969?v=4","gravatar_id":"","url":"https://api.github.com/users/stepancheg","html_url":"https://github.com/stepancheg","followers_url":"https://api.github.com/users/stepancheg/followers","following_url":"https://api.github.com/users/stepancheg/following{/other_user}","gists_url":"https://api.github.com/users/stepancheg/gists{/gist_id}","starred_url":"https://api.github.com/users/stepancheg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepancheg/subscriptions","organizations_url":"https://api.github.com/users/stepancheg/orgs","repos_url":"https://api.github.com/users/stepancheg/repos","events_url":"https://api.github.com/users/stepancheg/events{/privacy}","received_events_url":"https://api.github.com/users/stepancheg/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T00:30:16Z","updated_at":"2018-07-11T00:30:16Z","author_association":"OWNER","body":"I don't want for rust-protobuf to depend on serde unconditionally.\r\n\r\nSo my plan is either:\r\n* have a \"feature\" `serde` for rust-protobuf\r\n* implement special codegen for proto files bundled with protobuf which will delegate serialization to `protobuf-serde` crate\r\n\r\nThank you for pointing to the issue!"}}
{"actor":{"display_login":"stepancheg"}}