{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/anthill/pulls/comments/244791957","pull_request_review_id":188749965,"id":244791957,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc5MTk1Nw==","diff_hunk":"@@ -48,6 +52,21 @@ func main() {\n \t\tos.Exit(1)\n \t}\n \n+\t// Become the leader before proceeding\n+\terr = leader.Become(context.TODO(), \"anthill-lock\")","path":"cmd/manager/main.go","position":57,"original_position":57,"commit_id":"166ddaf1bfe65c380b390183d086d0fba57dd75d","original_commit_id":"166ddaf1bfe65c380b390183d086d0fba57dd75d","user":{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false},"body":"It could, but I'd like to leave it since it's verbatim from the latest SDK scaffolding. Changing standard template stuff makes upgrading the sdk version considerably harder.","created_at":"2019-01-02T16:57:01Z","updated_at":"2019-01-02T16:57:01Z","html_url":"https://github.com/gluster/anthill/pull/50#discussion_r244791957","pull_request_url":"https://api.github.com/repos/gluster/anthill/pulls/50","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gluster/anthill/pulls/comments/244791957"},"html":{"href":"https://github.com/gluster/anthill/pull/50#discussion_r244791957"},"pull_request":{"href":"https://api.github.com/repos/gluster/anthill/pulls/50"}},"in_reply_to_id":243775456},"pull_request":{"url":"https://api.github.com/repos/gluster/anthill/pulls/50","id":240580138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTgwMTM4","html_url":"https://github.com/gluster/anthill/pull/50","diff_url":"https://github.com/gluster/anthill/pull/50.diff","patch_url":"https://github.com/gluster/anthill/pull/50.patch","issue_url":"https://api.github.com/repos/gluster/anthill/issues/50","number":50,"state":"open","locked":false,"title":"e2e scaffold","user":{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false},"body":"**Describe what this PR does**\r\nThis adds some scaffolding (mostly boilerplate code) in `test/e2e` to support automated e2e testing for the operator. This is based on the sdk documentation, and currently the only test that's there starts the operator, waits for it to be running, then exits.\r\n\r\n**Is there anything that requires special attention?**\r\nAlso included in this PR is an upgrade to SDK 0.3.0. This was to get the `--up-local` cli so the operator can run locally during e2e. The move to 0.3.0 resulted in changes not only to deps but also some of the source files. See 689b83e.\r\n\r\nTo support the testing options of the sdk, role and rolebinding had to be split again as that's what the sdk expects when it applies them to the cluster. See f06823e.\r\n\r\n**Related issues:**\r\nN/A\r\n","created_at":"2018-12-21T21:21:09Z","updated_at":"2019-01-02T16:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff05e7722334ee03312273b64425e1e8b4b7a1ee","assignee":{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false},"assignees":[{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sac","id":414248,"node_id":"MDQ6VXNlcjQxNDI0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/414248?v=4","gravatar_id":"","url":"https://api.github.com/users/sac","html_url":"https://github.com/sac","followers_url":"https://api.github.com/users/sac/followers","following_url":"https://api.github.com/users/sac/following{/other_user}","gists_url":"https://api.github.com/users/sac/gists{/gist_id}","starred_url":"https://api.github.com/users/sac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sac/subscriptions","organizations_url":"https://api.github.com/users/sac/orgs","repos_url":"https://api.github.com/users/sac/repos","events_url":"https://api.github.com/users/sac/events{/privacy}","received_events_url":"https://api.github.com/users/sac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1059855433,"node_id":"MDU6TGFiZWwxMDU5ODU1NDMz","url":"https://api.github.com/repos/gluster/anthill/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/anthill/pulls/50/commits","review_comments_url":"https://api.github.com/repos/gluster/anthill/pulls/50/comments","review_comment_url":"https://api.github.com/repos/gluster/anthill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/anthill/issues/50/comments","statuses_url":"https://api.github.com/repos/gluster/anthill/statuses/166ddaf1bfe65c380b390183d086d0fba57dd75d","head":{"label":"JohnStrunk:e2e-scaffold","ref":"e2e-scaffold","sha":"166ddaf1bfe65c380b390183d086d0fba57dd75d","user":{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false},"repo":{"id":138331779,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMzE3Nzk=","name":"anthill","full_name":"JohnStrunk/anthill","private":false,"owner":{"login":"JohnStrunk","id":6456608,"node_id":"MDQ6VXNlcjY0NTY2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/6456608?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnStrunk","html_url":"https://github.com/JohnStrunk","followers_url":"https://api.github.com/users/JohnStrunk/followers","following_url":"https://api.github.com/users/JohnStrunk/following{/other_user}","gists_url":"https://api.github.com/users/JohnStrunk/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnStrunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnStrunk/subscriptions","organizations_url":"https://api.github.com/users/JohnStrunk/orgs","repos_url":"https://api.github.com/users/JohnStrunk/repos","events_url":"https://api.github.com/users/JohnStrunk/events{/privacy}","received_events_url":"https://api.github.com/users/JohnStrunk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JohnStrunk/anthill","description":"A Kubernetes/OpenShift operator to manage Gluster","fork":true,"url":"https://api.github.com/repos/JohnStrunk/anthill","forks_url":"https://api.github.com/repos/JohnStrunk/anthill/forks","keys_url":"https://api.github.com/repos/JohnStrunk/anthill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnStrunk/anthill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnStrunk/anthill/teams","hooks_url":"https://api.github.com/repos/JohnStrunk/anthill/hooks","issue_events_url":"https://api.github.com/repos/JohnStrunk/anthill/issues/events{/number}","events_url":"https://api.github.com/repos/JohnStrunk/anthill/events","assignees_url":"https://api.github.com/repos/JohnStrunk/anthill/assignees{/user}","branches_url":"https://api.github.com/repos/JohnStrunk/anthill/branches{/branch}","tags_url":"https://api.github.com/repos/JohnStrunk/anthill/tags","blobs_url":"https://api.github.com/repos/JohnStrunk/anthill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnStrunk/anthill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnStrunk/anthill/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnStrunk/anthill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnStrunk/anthill/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnStrunk/anthill/languages","stargazers_url":"https://api.github.com/repos/JohnStrunk/anthill/stargazers","contributors_url":"https://api.github.com/repos/JohnStrunk/anthill/contributors","subscribers_url":"https://api.github.com/repos/JohnStrunk/anthill/subscribers","subscription_url":"https://api.github.com/repos/JohnStrunk/anthill/subscription","commits_url":"https://api.github.com/repos/JohnStrunk/anthill/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnStrunk/anthill/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnStrunk/anthill/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnStrunk/anthill/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnStrunk/anthill/contents/{+path}","compare_url":"https://api.github.com/repos/JohnStrunk/anthill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnStrunk/anthill/merges","archive_url":"https://api.github.com/repos/JohnStrunk/anthill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnStrunk/anthill/downloads","issues_url":"https://api.github.com/repos/JohnStrunk/anthill/issues{/number}","pulls_url":"https://api.github.com/repos/JohnStrunk/anthill/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnStrunk/anthill/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnStrunk/anthill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnStrunk/anthill/labels{/name}","releases_url":"https://api.github.com/repos/JohnStrunk/anthill/releases{/id}","deployments_url":"https://api.github.com/repos/JohnStrunk/anthill/deployments","created_at":"2018-06-22T17:46:25Z","updated_at":"2018-12-05T21:20:24Z","pushed_at":"2019-01-02T16:53:41Z","git_url":"git://github.com/JohnStrunk/anthill.git","ssh_url":"git@github.com:JohnStrunk/anthill.git","clone_url":"https://github.com/JohnStrunk/anthill.git","svn_url":"https://github.com/JohnStrunk/anthill","homepage":"","size":197,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"e3e294bcd30faa911701c9495f36254d8152d5fc","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":117634154,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MzQxNTQ=","name":"anthill","full_name":"gluster/anthill","private":false,"owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gluster/anthill","description":"A Kubernetes/OpenShift operator to manage Gluster clusters","fork":false,"url":"https://api.github.com/repos/gluster/anthill","forks_url":"https://api.github.com/repos/gluster/anthill/forks","keys_url":"https://api.github.com/repos/gluster/anthill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/anthill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/anthill/teams","hooks_url":"https://api.github.com/repos/gluster/anthill/hooks","issue_events_url":"https://api.github.com/repos/gluster/anthill/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/anthill/events","assignees_url":"https://api.github.com/repos/gluster/anthill/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/anthill/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/anthill/tags","blobs_url":"https://api.github.com/repos/gluster/anthill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/anthill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/anthill/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/anthill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/anthill/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/anthill/languages","stargazers_url":"https://api.github.com/repos/gluster/anthill/stargazers","contributors_url":"https://api.github.com/repos/gluster/anthill/contributors","subscribers_url":"https://api.github.com/repos/gluster/anthill/subscribers","subscription_url":"https://api.github.com/repos/gluster/anthill/subscription","commits_url":"https://api.github.com/repos/gluster/anthill/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/anthill/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/anthill/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/anthill/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/anthill/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/anthill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/anthill/merges","archive_url":"https://api.github.com/repos/gluster/anthill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/anthill/downloads","issues_url":"https://api.github.com/repos/gluster/anthill/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/anthill/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/anthill/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/anthill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/anthill/labels{/name}","releases_url":"https://api.github.com/repos/gluster/anthill/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/anthill/deployments","created_at":"2018-01-16T05:10:19Z","updated_at":"2018-12-23T20:55:46Z","pushed_at":"2018-12-23T20:55:44Z","git_url":"git://github.com/gluster/anthill.git","ssh_url":"git@github.com:gluster/anthill.git","clone_url":"https://github.com/gluster/anthill.git","svn_url":"https://github.com/gluster/anthill","homepage":"http://gluster-anthill.readthedocs.io/","size":147,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":33,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/anthill/pulls/50"},"html":{"href":"https://github.com/gluster/anthill/pull/50"},"issue":{"href":"https://api.github.com/repos/gluster/anthill/issues/50"},"comments":{"href":"https://api.github.com/repos/gluster/anthill/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/anthill/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/anthill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/anthill/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/anthill/statuses/166ddaf1bfe65c380b390183d086d0fba57dd75d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JohnStrunk"}}