{"action":"created","issue":{"url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1391","repository_url":"https://api.github.com/repos/xtermjs/xterm.js","labels_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1391/labels{/name}","comments_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1391/comments","events_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1391/events","html_url":"https://github.com/xtermjs/xterm.js/pull/1391","id":314999020,"number":1391,"title":"Separate bright and bold","user":{"login":"LinusU","id":189580,"avatar_url":"https://avatars0.githubusercontent.com/u/189580?v=4","gravatar_id":"","url":"https://api.github.com/users/LinusU","html_url":"https://github.com/LinusU","followers_url":"https://api.github.com/users/LinusU/followers","following_url":"https://api.github.com/users/LinusU/following{/other_user}","gists_url":"https://api.github.com/users/LinusU/gists{/gist_id}","starred_url":"https://api.github.com/users/LinusU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinusU/subscriptions","organizations_url":"https://api.github.com/users/LinusU/orgs","repos_url":"https://api.github.com/users/LinusU/repos","events_url":"https://api.github.com/users/LinusU/events{/privacy}","received_events_url":"https://api.github.com/users/LinusU/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-17T10:28:34Z","updated_at":"2018-04-18T07:39:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xtermjs/xterm.js/pulls/1391","html_url":"https://github.com/xtermjs/xterm.js/pull/1391","diff_url":"https://github.com/xtermjs/xterm.js/pull/1391.diff","patch_url":"https://github.com/xtermjs/xterm.js/pull/1391.patch"},"body":"Previously all bright colors were always rendered bold, and all bold text was always rendered using the bright colors. This patch separates that so that bold and bright can be controlled individually.\r\n\r\nThis is probably going to affect people who relied on this previously, so I'm working on an option that re-enables the old behavior. I will push that as a separate commit to this same branch.\r\n\r\nFeedback appreciated! 🙌 \r\n\r\nFixes zeit/hyper#2836"},"comment":{"url":"https://api.github.com/repos/xtermjs/xterm.js/issues/comments/382293834","html_url":"https://github.com/xtermjs/xterm.js/pull/1391#issuecomment-382293834","issue_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1391","id":382293834,"user":{"login":"mofux","id":2785983,"avatar_url":"https://avatars1.githubusercontent.com/u/2785983?v=4","gravatar_id":"","url":"https://api.github.com/users/mofux","html_url":"https://github.com/mofux","followers_url":"https://api.github.com/users/mofux/followers","following_url":"https://api.github.com/users/mofux/following{/other_user}","gists_url":"https://api.github.com/users/mofux/gists{/gist_id}","starred_url":"https://api.github.com/users/mofux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mofux/subscriptions","organizations_url":"https://api.github.com/users/mofux/orgs","repos_url":"https://api.github.com/users/mofux/repos","events_url":"https://api.github.com/users/mofux/events{/privacy}","received_events_url":"https://api.github.com/users/mofux/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T07:39:39Z","updated_at":"2018-04-18T07:39:39Z","author_association":"CONTRIBUTOR","body":"I don't think that drawing bright text as bold would make sense. Most terminals offer two options:\r\n- enable / disable drawing bold text as bright (the text may still be bold)\r\n- enable / disable drawing bold text as bold (the text may still be bright)\r\n\r\nSo we might end up with something like `drawBoldTextBright` and `drawBoldTextBold` that can be combined to get the desired flavour 😁"}}
{"actor":{"display_login":"mofux"}}