{"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75","id":170366521,"html_url":"https://github.com/BTCPrivate/BitcoinPrivate/pull/75","diff_url":"https://github.com/BTCPrivate/BitcoinPrivate/pull/75.diff","patch_url":"https://github.com/BTCPrivate/BitcoinPrivate/pull/75.patch","issue_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/75","number":75,"state":"closed","locked":false,"title":"base58prefixes modified for btcp","user":{"login":"ch4ot1c","id":2287825,"avatar_url":"https://avatars2.githubusercontent.com/u/2287825?v=4","gravatar_id":"","url":"https://api.github.com/users/ch4ot1c","html_url":"https://github.com/ch4ot1c","followers_url":"https://api.github.com/users/ch4ot1c/followers","following_url":"https://api.github.com/users/ch4ot1c/following{/other_user}","gists_url":"https://api.github.com/users/ch4ot1c/gists{/gist_id}","starred_url":"https://api.github.com/users/ch4ot1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch4ot1c/subscriptions","organizations_url":"https://api.github.com/users/ch4ot1c/orgs","repos_url":"https://api.github.com/users/ch4ot1c/repos","events_url":"https://api.github.com/users/ch4ot1c/events{/privacy}","received_events_url":"https://api.github.com/users/ch4ot1c/received_events","type":"User","site_admin":false},"body":"Proposed base58 prefixes -\r\n\r\n**mainnet prefixes -**\r\nb1 is 0x13 0x25 - mainnet pubkey [transparent] (\"be one\")\r\nbx is 0x13 0xAF - i like this one for script / multisig (\"be 'x'\")\r\n\r\nzk is 0x16 0xA8\r\n\r\n**testnet prefixes -** \r\n\r\nn1 is 0x19 0x58 - testnet pubkey [transparent]\r\nnx is 0x19 0xE0 - script / multisig\r\n\r\nzz is 0x16 0xC0\r\n\r\nI dont think we need to change 'SK', the spending key prefix, but we can.\r\n\r\nUsed https://github.com/ch4ot1c/base58prefixes for testing against 'golden' values in https://github.com/FiloSottile/zcash-mini/blob/9330b716ef4c2f2f7dd808d1edbd267f56e65bb3/zcash/address_test.go","created_at":"2018-02-21T03:08:39Z","updated_at":"2018-02-23T16:41:54Z","closed_at":"2018-02-23T16:41:54Z","merged_at":"2018-02-23T16:41:54Z","merge_commit_sha":"097ecd61a4af3dcaa37370fb186afe4dd2b4ffd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75/commits","review_comments_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75/comments","review_comment_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/75/comments","statuses_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/statuses/5c102e0975b1b8522d1e4e2351de7000a3ed67db","head":{"label":"ch4ot1c:base58prefixes","ref":"base58prefixes","sha":"5c102e0975b1b8522d1e4e2351de7000a3ed67db","user":{"login":"ch4ot1c","id":2287825,"avatar_url":"https://avatars2.githubusercontent.com/u/2287825?v=4","gravatar_id":"","url":"https://api.github.com/users/ch4ot1c","html_url":"https://github.com/ch4ot1c","followers_url":"https://api.github.com/users/ch4ot1c/followers","following_url":"https://api.github.com/users/ch4ot1c/following{/other_user}","gists_url":"https://api.github.com/users/ch4ot1c/gists{/gist_id}","starred_url":"https://api.github.com/users/ch4ot1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch4ot1c/subscriptions","organizations_url":"https://api.github.com/users/ch4ot1c/orgs","repos_url":"https://api.github.com/users/ch4ot1c/repos","events_url":"https://api.github.com/users/ch4ot1c/events{/privacy}","received_events_url":"https://api.github.com/users/ch4ot1c/received_events","type":"User","site_admin":false},"repo":{"id":115567436,"name":"BitcoinPrivate","full_name":"ch4ot1c/BitcoinPrivate","owner":{"login":"ch4ot1c","id":2287825,"avatar_url":"https://avatars2.githubusercontent.com/u/2287825?v=4","gravatar_id":"","url":"https://api.github.com/users/ch4ot1c","html_url":"https://github.com/ch4ot1c","followers_url":"https://api.github.com/users/ch4ot1c/followers","following_url":"https://api.github.com/users/ch4ot1c/following{/other_user}","gists_url":"https://api.github.com/users/ch4ot1c/gists{/gist_id}","starred_url":"https://api.github.com/users/ch4ot1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch4ot1c/subscriptions","organizations_url":"https://api.github.com/users/ch4ot1c/orgs","repos_url":"https://api.github.com/users/ch4ot1c/repos","events_url":"https://api.github.com/users/ch4ot1c/events{/privacy}","received_events_url":"https://api.github.com/users/ch4ot1c/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ch4ot1c/BitcoinPrivate","description":"Bitcoin Private is a Bitcoin and Zclassic fork which uses ZK-SNARK technology for privacy and fungibility.","fork":true,"url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate","forks_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/forks","keys_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/teams","hooks_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/hooks","issue_events_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/issues/events{/number}","events_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/events","assignees_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/assignees{/user}","branches_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/branches{/branch}","tags_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/tags","blobs_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/statuses/{sha}","languages_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/languages","stargazers_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/stargazers","contributors_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/contributors","subscribers_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/subscribers","subscription_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/subscription","commits_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/contents/{+path}","compare_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/merges","archive_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/downloads","issues_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/issues{/number}","pulls_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/pulls{/number}","milestones_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/milestones{/number}","notifications_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/labels{/name}","releases_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/releases{/id}","deployments_url":"https://api.github.com/repos/ch4ot1c/BitcoinPrivate/deployments","created_at":"2017-12-28T00:11:18Z","updated_at":"2017-12-28T00:11:22Z","pushed_at":"2018-02-21T02:59:06Z","git_url":"git://github.com/ch4ot1c/BitcoinPrivate.git","ssh_url":"git@github.com:ch4ot1c/BitcoinPrivate.git","clone_url":"https://github.com/ch4ot1c/BitcoinPrivate.git","svn_url":"https://github.com/ch4ot1c/BitcoinPrivate","homepage":null,"size":47416,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BTCPrivate:master","ref":"master","sha":"d6dc745a5fdc9a8ec33ee83e838b9008dd5fad93","user":{"login":"BTCPrivate","id":34813369,"avatar_url":"https://avatars3.githubusercontent.com/u/34813369?v=4","gravatar_id":"","url":"https://api.github.com/users/BTCPrivate","html_url":"https://github.com/BTCPrivate","followers_url":"https://api.github.com/users/BTCPrivate/followers","following_url":"https://api.github.com/users/BTCPrivate/following{/other_user}","gists_url":"https://api.github.com/users/BTCPrivate/gists{/gist_id}","starred_url":"https://api.github.com/users/BTCPrivate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTCPrivate/subscriptions","organizations_url":"https://api.github.com/users/BTCPrivate/orgs","repos_url":"https://api.github.com/users/BTCPrivate/repos","events_url":"https://api.github.com/users/BTCPrivate/events{/privacy}","received_events_url":"https://api.github.com/users/BTCPrivate/received_events","type":"Organization","site_admin":false},"repo":{"id":115267536,"name":"BitcoinPrivate","full_name":"BTCPrivate/BitcoinPrivate","owner":{"login":"BTCPrivate","id":34813369,"avatar_url":"https://avatars3.githubusercontent.com/u/34813369?v=4","gravatar_id":"","url":"https://api.github.com/users/BTCPrivate","html_url":"https://github.com/BTCPrivate","followers_url":"https://api.github.com/users/BTCPrivate/followers","following_url":"https://api.github.com/users/BTCPrivate/following{/other_user}","gists_url":"https://api.github.com/users/BTCPrivate/gists{/gist_id}","starred_url":"https://api.github.com/users/BTCPrivate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTCPrivate/subscriptions","organizations_url":"https://api.github.com/users/BTCPrivate/orgs","repos_url":"https://api.github.com/users/BTCPrivate/repos","events_url":"https://api.github.com/users/BTCPrivate/events{/privacy}","received_events_url":"https://api.github.com/users/BTCPrivate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BTCPrivate/BitcoinPrivate","description":"Bitcoin Private is a Bitcoin and Zclassic fork which uses ZK-SNARK technology for privacy and fungibility.","fork":false,"url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate","forks_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/forks","keys_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/teams","hooks_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/hooks","issue_events_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/events{/number}","events_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/events","assignees_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/assignees{/user}","branches_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/branches{/branch}","tags_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/tags","blobs_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/git/refs{/sha}","trees_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/statuses/{sha}","languages_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/languages","stargazers_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/stargazers","contributors_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/contributors","subscribers_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/subscribers","subscription_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/subscription","commits_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/commits{/sha}","git_commits_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/git/commits{/sha}","comments_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/comments{/number}","issue_comment_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/comments{/number}","contents_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/contents/{+path}","compare_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/merges","archive_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/downloads","issues_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues{/number}","pulls_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls{/number}","milestones_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/milestones{/number}","notifications_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/labels{/name}","releases_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/releases{/id}","deployments_url":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/deployments","created_at":"2017-12-24T14:19:12Z","updated_at":"2018-02-21T12:14:11Z","pushed_at":"2018-02-23T16:41:54Z","git_url":"git://github.com/BTCPrivate/BitcoinPrivate.git","ssh_url":"git@github.com:BTCPrivate/BitcoinPrivate.git","clone_url":"https://github.com/BTCPrivate/BitcoinPrivate.git","svn_url":"https://github.com/BTCPrivate/BitcoinPrivate","homepage":null,"size":47593,"stargazers_count":173,"watchers_count":173,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":48,"open_issues":9,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75"},"html":{"href":"https://github.com/BTCPrivate/BitcoinPrivate/pull/75"},"issue":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/75"},"comments":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/BTCPrivate/BitcoinPrivate/statuses/5c102e0975b1b8522d1e4e2351de7000a3ed67db"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ch4ot1c","id":2287825,"avatar_url":"https://avatars2.githubusercontent.com/u/2287825?v=4","gravatar_id":"","url":"https://api.github.com/users/ch4ot1c","html_url":"https://github.com/ch4ot1c","followers_url":"https://api.github.com/users/ch4ot1c/followers","following_url":"https://api.github.com/users/ch4ot1c/following{/other_user}","gists_url":"https://api.github.com/users/ch4ot1c/gists{/gist_id}","starred_url":"https://api.github.com/users/ch4ot1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch4ot1c/subscriptions","organizations_url":"https://api.github.com/users/ch4ot1c/orgs","repos_url":"https://api.github.com/users/ch4ot1c/repos","events_url":"https://api.github.com/users/ch4ot1c/events{/privacy}","received_events_url":"https://api.github.com/users/ch4ot1c/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"ch4ot1c"}}