{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58816","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58816/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58816/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58816/events","html_url":"https://github.com/kubernetes/kubernetes/pull/58816","id":291619504,"number":58816,"title":"StorageOS configurable device directory and mount options","user":{"login":"croomes","id":211994,"avatar_url":"https://avatars0.githubusercontent.com/u/211994?v=4","gravatar_id":"","url":"https://api.github.com/users/croomes","html_url":"https://github.com/croomes","followers_url":"https://api.github.com/users/croomes/followers","following_url":"https://api.github.com/users/croomes/following{/other_user}","gists_url":"https://api.github.com/users/croomes/gists{/gist_id}","starred_url":"https://api.github.com/users/croomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croomes/subscriptions","organizations_url":"https://api.github.com/users/croomes/orgs","repos_url":"https://api.github.com/users/croomes/repos","events_url":"https://api.github.com/users/croomes/events{/privacy}","received_events_url":"https://api.github.com/users/croomes/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-01-25T15:55:30Z","updated_at":"2018-02-15T15:09:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58816","html_url":"https://github.com/kubernetes/kubernetes/pull/58816","diff_url":"https://github.com/kubernetes/kubernetes/pull/58816.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58816.patch"},"body":"**What this PR does / why we need it**:\r\nThis allows StorageOS volumes to be mounted when the kubelet is running in a container and we are unable to use the default device location (/var/lib/storageos/volumes).  With this PR, the node's device location is requested via the StorageOS api, falling back to the current behaviour if not configured.  The node's device location can be supplied as an environment variable (DEVICE_DIR) to the StorageOS container.  This is backwards-compatible and no changes are needed to existing deployments.\r\n\r\nThe PR also allows Mount options to be set for StorageOS volumes in the same way they're enabled for other volume plugins.\r\n\r\nThe StorageOS API dependency was updated to the latest version, but no functionality changes besides adding the DeviceDir property to the Controller object.\r\n\r\nThere is also a small refactor of the loopback device handling code in storageos_utils.go to capture stderr output.\r\n\r\n**Release note**:\r\n```release-note\r\nStorageOS volume plugin updated to support mount options and environments where the kubelet runs in a container and the device location should be specified.\r\n```\r\n\r\nNot sure why godep changed the comments of unrelated packages in Godeps.json...\r\n\r\n/sig storage"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/365955391","html_url":"https://github.com/kubernetes/kubernetes/pull/58816#issuecomment-365955391","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58816","id":365955391,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T15:09:01Z","updated_at":"2018-02-15T15:09:01Z","author_association":"COLLABORATOR","body":"@croomes: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kubeadm-gce-canary | 1a91403e435f4b8e425e864890653747528bf8d8 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58816/pull-kubernetes-e2e-kubeadm-gce-canary/128/) | `/test pull-kubernetes-e2e-kubeadm-gce-canary`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/58816). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/croomes). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}