{"action":"opened","number":56,"pull_request":{"url":"https://api.github.com/repos/pda/flip/pulls/56","id":223765616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzY1NjE2","html_url":"https://github.com/pda/flip/pull/56","diff_url":"https://github.com/pda/flip/pull/56.diff","patch_url":"https://github.com/pda/flip/pull/56.patch","issue_url":"https://api.github.com/repos/pda/flip/issues/56","number":56,"state":"open","locked":false,"title":"Consistant trinary strategies","user":{"login":"Kache","id":133218,"node_id":"MDQ6VXNlcjEzMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/133218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kache","html_url":"https://github.com/Kache","followers_url":"https://api.github.com/users/Kache/followers","following_url":"https://api.github.com/users/Kache/following{/other_user}","gists_url":"https://api.github.com/users/Kache/gists{/gist_id}","starred_url":"https://api.github.com/users/Kache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kache/subscriptions","organizations_url":"https://api.github.com/users/Kache/orgs","repos_url":"https://api.github.com/users/Kache/repos","events_url":"https://api.github.com/users/Kache/events{/privacy}","received_events_url":"https://api.github.com/users/Kache/received_events","type":"User","site_admin":false},"body":"`Flip::DatabaseStrategy` has a consistency/race condition problem -- it double-queries the database to resolve `strategy.on?(feature) if strategy.knows?(feature)`.\r\n\r\nThis PR fixes the inconsistency by changing the internal API of strategies to be trinary, returning `nil` for \"unknown\", thereby allowing the strategy to respond in a single consistent db query.\r\n\r\nThis is also a prerequisite for thread-safety, should that ever be a goal.","created_at":"2018-10-17T21:54:40Z","updated_at":"2018-10-17T21:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pda/flip/pulls/56/commits","review_comments_url":"https://api.github.com/repos/pda/flip/pulls/56/comments","review_comment_url":"https://api.github.com/repos/pda/flip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pda/flip/issues/56/comments","statuses_url":"https://api.github.com/repos/pda/flip/statuses/a983c250baf98e63ae227455d5015649d9f648d4","head":{"label":"Kache:consistant-trinary-strategies","ref":"consistant-trinary-strategies","sha":"a983c250baf98e63ae227455d5015649d9f648d4","user":{"login":"Kache","id":133218,"node_id":"MDQ6VXNlcjEzMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/133218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kache","html_url":"https://github.com/Kache","followers_url":"https://api.github.com/users/Kache/followers","following_url":"https://api.github.com/users/Kache/following{/other_user}","gists_url":"https://api.github.com/users/Kache/gists{/gist_id}","starred_url":"https://api.github.com/users/Kache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kache/subscriptions","organizations_url":"https://api.github.com/users/Kache/orgs","repos_url":"https://api.github.com/users/Kache/repos","events_url":"https://api.github.com/users/Kache/events{/privacy}","received_events_url":"https://api.github.com/users/Kache/received_events","type":"User","site_admin":false},"repo":{"id":153502083,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MDIwODM=","name":"flip","full_name":"Kache/flip","private":false,"owner":{"login":"Kache","id":133218,"node_id":"MDQ6VXNlcjEzMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/133218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kache","html_url":"https://github.com/Kache","followers_url":"https://api.github.com/users/Kache/followers","following_url":"https://api.github.com/users/Kache/following{/other_user}","gists_url":"https://api.github.com/users/Kache/gists{/gist_id}","starred_url":"https://api.github.com/users/Kache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kache/subscriptions","organizations_url":"https://api.github.com/users/Kache/orgs","repos_url":"https://api.github.com/users/Kache/repos","events_url":"https://api.github.com/users/Kache/events{/privacy}","received_events_url":"https://api.github.com/users/Kache/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kache/flip","description":"Flip lets you declare and manage feature flags, backed by cookies (private testing) and database (site-wide).","fork":true,"url":"https://api.github.com/repos/Kache/flip","forks_url":"https://api.github.com/repos/Kache/flip/forks","keys_url":"https://api.github.com/repos/Kache/flip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kache/flip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kache/flip/teams","hooks_url":"https://api.github.com/repos/Kache/flip/hooks","issue_events_url":"https://api.github.com/repos/Kache/flip/issues/events{/number}","events_url":"https://api.github.com/repos/Kache/flip/events","assignees_url":"https://api.github.com/repos/Kache/flip/assignees{/user}","branches_url":"https://api.github.com/repos/Kache/flip/branches{/branch}","tags_url":"https://api.github.com/repos/Kache/flip/tags","blobs_url":"https://api.github.com/repos/Kache/flip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kache/flip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kache/flip/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kache/flip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kache/flip/statuses/{sha}","languages_url":"https://api.github.com/repos/Kache/flip/languages","stargazers_url":"https://api.github.com/repos/Kache/flip/stargazers","contributors_url":"https://api.github.com/repos/Kache/flip/contributors","subscribers_url":"https://api.github.com/repos/Kache/flip/subscribers","subscription_url":"https://api.github.com/repos/Kache/flip/subscription","commits_url":"https://api.github.com/repos/Kache/flip/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kache/flip/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kache/flip/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kache/flip/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kache/flip/contents/{+path}","compare_url":"https://api.github.com/repos/Kache/flip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kache/flip/merges","archive_url":"https://api.github.com/repos/Kache/flip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kache/flip/downloads","issues_url":"https://api.github.com/repos/Kache/flip/issues{/number}","pulls_url":"https://api.github.com/repos/Kache/flip/pulls{/number}","milestones_url":"https://api.github.com/repos/Kache/flip/milestones{/number}","notifications_url":"https://api.github.com/repos/Kache/flip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kache/flip/labels{/name}","releases_url":"https://api.github.com/repos/Kache/flip/releases{/id}","deployments_url":"https://api.github.com/repos/Kache/flip/deployments","created_at":"2018-10-17T18:07:36Z","updated_at":"2018-10-17T18:07:38Z","pushed_at":"2018-10-17T21:45:57Z","git_url":"git://github.com/Kache/flip.git","ssh_url":"git@github.com:Kache/flip.git","clone_url":"https://github.com/Kache/flip.git","svn_url":"https://github.com/Kache/flip","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pda:master","ref":"master","sha":"6ac78b3161d1b8c3aca2dc0725df05b75afee4dc","user":{"login":"pda","id":15759,"node_id":"MDQ6VXNlcjE1NzU5","avatar_url":"https://avatars1.githubusercontent.com/u/15759?v=4","gravatar_id":"","url":"https://api.github.com/users/pda","html_url":"https://github.com/pda","followers_url":"https://api.github.com/users/pda/followers","following_url":"https://api.github.com/users/pda/following{/other_user}","gists_url":"https://api.github.com/users/pda/gists{/gist_id}","starred_url":"https://api.github.com/users/pda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pda/subscriptions","organizations_url":"https://api.github.com/users/pda/orgs","repos_url":"https://api.github.com/users/pda/repos","events_url":"https://api.github.com/users/pda/events{/privacy}","received_events_url":"https://api.github.com/users/pda/received_events","type":"User","site_admin":false},"repo":{"id":1788164,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg4MTY0","name":"flip","full_name":"pda/flip","private":false,"owner":{"login":"pda","id":15759,"node_id":"MDQ6VXNlcjE1NzU5","avatar_url":"https://avatars1.githubusercontent.com/u/15759?v=4","gravatar_id":"","url":"https://api.github.com/users/pda","html_url":"https://github.com/pda","followers_url":"https://api.github.com/users/pda/followers","following_url":"https://api.github.com/users/pda/following{/other_user}","gists_url":"https://api.github.com/users/pda/gists{/gist_id}","starred_url":"https://api.github.com/users/pda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pda/subscriptions","organizations_url":"https://api.github.com/users/pda/orgs","repos_url":"https://api.github.com/users/pda/repos","events_url":"https://api.github.com/users/pda/events{/privacy}","received_events_url":"https://api.github.com/users/pda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pda/flip","description":"Flip lets you declare and manage feature flags, backed by cookies (private testing) and database (site-wide).","fork":false,"url":"https://api.github.com/repos/pda/flip","forks_url":"https://api.github.com/repos/pda/flip/forks","keys_url":"https://api.github.com/repos/pda/flip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pda/flip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pda/flip/teams","hooks_url":"https://api.github.com/repos/pda/flip/hooks","issue_events_url":"https://api.github.com/repos/pda/flip/issues/events{/number}","events_url":"https://api.github.com/repos/pda/flip/events","assignees_url":"https://api.github.com/repos/pda/flip/assignees{/user}","branches_url":"https://api.github.com/repos/pda/flip/branches{/branch}","tags_url":"https://api.github.com/repos/pda/flip/tags","blobs_url":"https://api.github.com/repos/pda/flip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pda/flip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pda/flip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pda/flip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pda/flip/statuses/{sha}","languages_url":"https://api.github.com/repos/pda/flip/languages","stargazers_url":"https://api.github.com/repos/pda/flip/stargazers","contributors_url":"https://api.github.com/repos/pda/flip/contributors","subscribers_url":"https://api.github.com/repos/pda/flip/subscribers","subscription_url":"https://api.github.com/repos/pda/flip/subscription","commits_url":"https://api.github.com/repos/pda/flip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pda/flip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pda/flip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pda/flip/issues/comments{/number}","contents_url":"https://api.github.com/repos/pda/flip/contents/{+path}","compare_url":"https://api.github.com/repos/pda/flip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pda/flip/merges","archive_url":"https://api.github.com/repos/pda/flip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pda/flip/downloads","issues_url":"https://api.github.com/repos/pda/flip/issues{/number}","pulls_url":"https://api.github.com/repos/pda/flip/pulls{/number}","milestones_url":"https://api.github.com/repos/pda/flip/milestones{/number}","notifications_url":"https://api.github.com/repos/pda/flip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pda/flip/labels{/name}","releases_url":"https://api.github.com/repos/pda/flip/releases{/id}","deployments_url":"https://api.github.com/repos/pda/flip/deployments","created_at":"2011-05-23T13:56:55Z","updated_at":"2018-07-15T19:24:55Z","pushed_at":"2018-08-09T20:20:39Z","git_url":"git://github.com/pda/flip.git","ssh_url":"git@github.com:pda/flip.git","clone_url":"https://github.com/pda/flip.git","svn_url":"https://github.com/pda/flip","homepage":null,"size":336,"stargazers_count":369,"watchers_count":369,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":64,"open_issues":21,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pda/flip/pulls/56"},"html":{"href":"https://github.com/pda/flip/pull/56"},"issue":{"href":"https://api.github.com/repos/pda/flip/issues/56"},"comments":{"href":"https://api.github.com/repos/pda/flip/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/pda/flip/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/pda/flip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pda/flip/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/pda/flip/statuses/a983c250baf98e63ae227455d5015649d9f648d4"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":109,"deletions":150,"changed_files":10}}
{"actor":{"display_login":"Kache"}}