{"action":"created","comment":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/176407091","pull_request_review_id":106101437,"id":176407091,"diff_hunk":"@@ -896,7 +887,9 @@ export class Map extends React.Component {\n               options.rotation = rotation;\n               const sprite = new SpriteStyle(options);\n               const style = new Style({image: sprite});\n-              this.map.on('postcompose', onPostCompose, sprite);\n+              this.map.on('postcompose', (e) => {","path":"src/components/map.js","position":166,"original_position":166,"commit_id":"e15ed4c8475d85ff7230882a89cfdcbb97bfbeb1","original_commit_id":"e15ed4c8475d85ff7230882a89cfdcbb97bfbeb1","user":{"login":"boundlessgeoadmin","id":25821592,"avatar_url":"https://avatars2.githubusercontent.com/u/25821592?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeoadmin","html_url":"https://github.com/boundlessgeoadmin","followers_url":"https://api.github.com/users/boundlessgeoadmin/followers","following_url":"https://api.github.com/users/boundlessgeoadmin/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeoadmin/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeoadmin/orgs","repos_url":"https://api.github.com/users/boundlessgeoadmin/repos","events_url":"https://api.github.com/users/boundlessgeoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeoadmin/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Define this function outside of a loop. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sq.boundlessgeo.io/coding_rules#rule_key=javascript%3AFunctionDefinitionInsideLoop)\n","created_at":"2018-03-22T12:49:04Z","updated_at":"2018-03-22T12:49:05Z","html_url":"https://github.com/boundlessgeo/sdk/pull/861#discussion_r176407091","pull_request_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/176407091"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/861#discussion_r176407091"},"pull_request":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861","id":176469529,"html_url":"https://github.com/boundlessgeo/sdk/pull/861","diff_url":"https://github.com/boundlessgeo/sdk/pull/861.diff","patch_url":"https://github.com/boundlessgeo/sdk/pull/861.patch","issue_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/861","number":861,"state":"open","locked":false,"title":"[WIP] Upgrade to ol5","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars3.githubusercontent.com/u/319678?v=4","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"This will also need ```ol-mapbox-style``` and ```mapbox-to-ol-style``` to get upgraded as well","created_at":"2018-03-21T13:06:23Z","updated_at":"2018-03-22T12:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12ec2e7ec563e4cb74ff4a13b294d6ae3a467353","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861/commits","review_comments_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861/comments","review_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/861/comments","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/e15ed4c8475d85ff7230882a89cfdcbb97bfbeb1","head":{"label":"bartvde:ol-5-upgrade","ref":"ol-5-upgrade","sha":"e15ed4c8475d85ff7230882a89cfdcbb97bfbeb1","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars3.githubusercontent.com/u/319678?v=4","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"repo":{"id":96313142,"name":"sdk","full_name":"bartvde/sdk","owner":{"login":"bartvde","id":319678,"avatar_url":"https://avatars3.githubusercontent.com/u/319678?v=4","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartvde/sdk","description":"New javascript SDK based on React and Flux","fork":true,"url":"https://api.github.com/repos/bartvde/sdk","forks_url":"https://api.github.com/repos/bartvde/sdk/forks","keys_url":"https://api.github.com/repos/bartvde/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartvde/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartvde/sdk/teams","hooks_url":"https://api.github.com/repos/bartvde/sdk/hooks","issue_events_url":"https://api.github.com/repos/bartvde/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bartvde/sdk/events","assignees_url":"https://api.github.com/repos/bartvde/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bartvde/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bartvde/sdk/tags","blobs_url":"https://api.github.com/repos/bartvde/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartvde/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartvde/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartvde/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartvde/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bartvde/sdk/languages","stargazers_url":"https://api.github.com/repos/bartvde/sdk/stargazers","contributors_url":"https://api.github.com/repos/bartvde/sdk/contributors","subscribers_url":"https://api.github.com/repos/bartvde/sdk/subscribers","subscription_url":"https://api.github.com/repos/bartvde/sdk/subscription","commits_url":"https://api.github.com/repos/bartvde/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartvde/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartvde/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartvde/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartvde/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bartvde/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartvde/sdk/merges","archive_url":"https://api.github.com/repos/bartvde/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartvde/sdk/downloads","issues_url":"https://api.github.com/repos/bartvde/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bartvde/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bartvde/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bartvde/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartvde/sdk/labels{/name}","releases_url":"https://api.github.com/repos/bartvde/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bartvde/sdk/deployments","created_at":"2017-07-05T11:43:36Z","updated_at":"2017-07-05T11:43:38Z","pushed_at":"2018-03-22T12:45:57Z","git_url":"git://github.com/bartvde/sdk.git","ssh_url":"git@github.com:bartvde/sdk.git","clone_url":"https://github.com/bartvde/sdk.git","svn_url":"https://github.com/bartvde/sdk","homepage":"","size":72685,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boundlessgeo:master","ref":"master","sha":"97474ecd46559ea905b81825ad366b77e08af9cd","user":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":36792837,"name":"sdk","full_name":"boundlessgeo/sdk","owner":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boundlessgeo/sdk","description":"Javascript SDK based on React, Redux and OpenLayers","fork":false,"url":"https://api.github.com/repos/boundlessgeo/sdk","forks_url":"https://api.github.com/repos/boundlessgeo/sdk/forks","keys_url":"https://api.github.com/repos/boundlessgeo/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boundlessgeo/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boundlessgeo/sdk/teams","hooks_url":"https://api.github.com/repos/boundlessgeo/sdk/hooks","issue_events_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/boundlessgeo/sdk/events","assignees_url":"https://api.github.com/repos/boundlessgeo/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/boundlessgeo/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/boundlessgeo/sdk/tags","blobs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boundlessgeo/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/boundlessgeo/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/boundlessgeo/sdk/languages","stargazers_url":"https://api.github.com/repos/boundlessgeo/sdk/stargazers","contributors_url":"https://api.github.com/repos/boundlessgeo/sdk/contributors","subscribers_url":"https://api.github.com/repos/boundlessgeo/sdk/subscribers","subscription_url":"https://api.github.com/repos/boundlessgeo/sdk/subscription","commits_url":"https://api.github.com/repos/boundlessgeo/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/boundlessgeo/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/boundlessgeo/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/boundlessgeo/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boundlessgeo/sdk/merges","archive_url":"https://api.github.com/repos/boundlessgeo/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boundlessgeo/sdk/downloads","issues_url":"https://api.github.com/repos/boundlessgeo/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/boundlessgeo/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/boundlessgeo/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boundlessgeo/sdk/labels{/name}","releases_url":"https://api.github.com/repos/boundlessgeo/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/boundlessgeo/sdk/deployments","created_at":"2015-06-03T09:13:14Z","updated_at":"2018-03-22T10:59:26Z","pushed_at":"2018-03-22T12:45:58Z","git_url":"git://github.com/boundlessgeo/sdk.git","ssh_url":"git@github.com:boundlessgeo/sdk.git","clone_url":"https://github.com/boundlessgeo/sdk.git","svn_url":"https://github.com/boundlessgeo/sdk","homepage":"","size":70918,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":33,"open_issues":10,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/861"},"issue":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/861"},"comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/boundlessgeo/sdk/statuses/e15ed4c8475d85ff7230882a89cfdcbb97bfbeb1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"boundlessgeoadmin"}}