{"action":"created","comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/241452410","pull_request_review_id":184728446,"id":241452410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ1MjQxMA==","diff_hunk":"@@ -33,7 +33,7 @@ if(build)\n         set(VTK_IO_TARGET_LINK_LIBRARIES vtkCommon vtkWidgets vtkIO vtkImaging)\n     endif()\n \n-    include_directories(\"${CMAKE_CURRENT_SOURCE_DIR}/include\" ${VTK_INCLUDE_DIRECTORIES})\n+    include_directories(\"${CMAKE_CURRENT_SOURCE_DIR}/include\")","path":"2d/CMakeLists.txt","position":5,"original_position":5,"commit_id":"2aab14818ad85eaf9a84a63c0b32efb982b84858","original_commit_id":"2aab14818ad85eaf9a84a63c0b32efb982b84858","user":{"login":"taketwo","id":1241736,"node_id":"MDQ6VXNlcjEyNDE3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1241736?v=4","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"body":"I see. Can we remove this (and similar change in `io`) for now? If somebody (or you) have time in future to confirm that this is not necessary anymore, it would be nice to merge a single PR that fixes all PCL modules, not just one or two.","created_at":"2018-12-13T15:47:56Z","updated_at":"2018-12-13T15:47:56Z","html_url":"https://github.com/PointCloudLibrary/pcl/pull/2712#discussion_r241452410","pull_request_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/241452410"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/2712#discussion_r241452410"},"pull_request":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712"}},"in_reply_to_id":241432517},"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712","id":238411177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDExMTc3","html_url":"https://github.com/PointCloudLibrary/pcl/pull/2712","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/2712.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/2712.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2712","number":2712,"state":"open","locked":false,"title":"Fix MSVC compile issues in CloudComposer","user":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"body":"Fix MSVC compile issues in CloudComposer. This required to build pcl_cc_tool_interface as static library, because current PCL_EXPORTS macro doesn't work with classes using Q_OBJECT (see #2708).\r\n\r\ncloud_composer is now using pcl_cc_tool_interface to prevent some cpps need to be compiled for both.","created_at":"2018-12-13T14:34:56Z","updated_at":"2018-12-13T15:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5df334bb849dc9124036865cbce153b6a8ee61c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":881030349,"node_id":"MDU6TGFiZWw4ODEwMzAzNDk=","url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels/module:%20apps","name":"module: apps","color":"bfe5bf","default":false},{"id":638009621,"node_id":"MDU6TGFiZWw2MzgwMDk2MjE=","url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels/platform:%20windows","name":"platform: windows","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2712/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/2aab14818ad85eaf9a84a63c0b32efb982b84858","head":{"label":"SunBlack:fix_cloud_composer_msvc_compiler_issues","ref":"fix_cloud_composer_msvc_compiler_issues","sha":"2aab14818ad85eaf9a84a63c0b32efb982b84858","user":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"repo":{"id":157413444,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MTM0NDQ=","name":"pcl","full_name":"SunBlack/pcl","private":false,"owner":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SunBlack/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/SunBlack/pcl","forks_url":"https://api.github.com/repos/SunBlack/pcl/forks","keys_url":"https://api.github.com/repos/SunBlack/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SunBlack/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SunBlack/pcl/teams","hooks_url":"https://api.github.com/repos/SunBlack/pcl/hooks","issue_events_url":"https://api.github.com/repos/SunBlack/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/SunBlack/pcl/events","assignees_url":"https://api.github.com/repos/SunBlack/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/SunBlack/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/SunBlack/pcl/tags","blobs_url":"https://api.github.com/repos/SunBlack/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SunBlack/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SunBlack/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SunBlack/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SunBlack/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/SunBlack/pcl/languages","stargazers_url":"https://api.github.com/repos/SunBlack/pcl/stargazers","contributors_url":"https://api.github.com/repos/SunBlack/pcl/contributors","subscribers_url":"https://api.github.com/repos/SunBlack/pcl/subscribers","subscription_url":"https://api.github.com/repos/SunBlack/pcl/subscription","commits_url":"https://api.github.com/repos/SunBlack/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SunBlack/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SunBlack/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SunBlack/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SunBlack/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/SunBlack/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SunBlack/pcl/merges","archive_url":"https://api.github.com/repos/SunBlack/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SunBlack/pcl/downloads","issues_url":"https://api.github.com/repos/SunBlack/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/SunBlack/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/SunBlack/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/SunBlack/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SunBlack/pcl/labels{/name}","releases_url":"https://api.github.com/repos/SunBlack/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/SunBlack/pcl/deployments","created_at":"2018-11-13T16:44:53Z","updated_at":"2018-11-13T16:45:06Z","pushed_at":"2018-12-13T14:31:42Z","git_url":"git://github.com/SunBlack/pcl.git","ssh_url":"git@github.com:SunBlack/pcl.git","clone_url":"https://github.com/SunBlack/pcl.git","svn_url":"https://github.com/SunBlack/pcl","homepage":"http://www.pointclouds.org","size":224778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"9e05c4e7c5dd816aa0393799ea4612770400c45c","user":{"login":"PointCloudLibrary","id":2059451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTk0NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"node_id":"MDEwOlJlcG9zaXRvcnk4MTYyNjE1","name":"pcl","full_name":"PointCloudLibrary/pcl","private":false,"owner":{"login":"PointCloudLibrary","id":2059451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTk0NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/deployments","created_at":"2013-02-12T16:40:25Z","updated_at":"2018-12-13T15:07:03Z","pushed_at":"2018-12-13T15:06:50Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":224728,"stargazers_count":3193,"watchers_count":3193,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2463,"mirror_url":null,"archived":false,"open_issues_count":393,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2463,"open_issues":393,"watchers":3193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/2712"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2712"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2712/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2712/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/2aab14818ad85eaf9a84a63c0b32efb982b84858"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"taketwo"}}