{"action":"created","comment":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/201014491","pull_request_review_id":135431899,"id":201014491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTAxNDQ5MQ==","diff_hunk":"@@ -476,6 +476,12 @@ function loadPageStepData($localPaths, $runCompleted, $testInfo = null) {\n           }\r\n         }\r\n       }\r\n+\r\n+      foreach (['firstPaintedHero', 'LastPaintedHero'] as $metric) {\r","path":"www/page_data.inc","position":5,"original_position":5,"commit_id":"149adfda37017de4c4a2dbdc44b86f190bebd4cc","original_commit_id":"149adfda37017de4c4a2dbdc44b86f190bebd4cc","user":{"login":"pmeenan","id":444165,"node_id":"MDQ6VXNlcjQ0NDE2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/444165?v=4","gravatar_id":"","url":"https://api.github.com/users/pmeenan","html_url":"https://github.com/pmeenan","followers_url":"https://api.github.com/users/pmeenan/followers","following_url":"https://api.github.com/users/pmeenan/following{/other_user}","gists_url":"https://api.github.com/users/pmeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeenan/subscriptions","organizations_url":"https://api.github.com/users/pmeenan/orgs","repos_url":"https://api.github.com/users/pmeenan/repos","events_url":"https://api.github.com/users/pmeenan/events{/privacy}","received_events_url":"https://api.github.com/users/pmeenan/received_events","type":"User","site_admin":false},"body":"FirstPaintedHero Needs to be capitalized.","created_at":"2018-07-09T14:05:51Z","updated_at":"2018-07-09T14:13:32Z","html_url":"https://github.com/WPO-Foundation/webpagetest/pull/1158#discussion_r201014491","pull_request_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/201014491"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/1158#discussion_r201014491"},"pull_request":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158"}}},"pull_request":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158","id":199980405,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTgwNDA1","html_url":"https://github.com/WPO-Foundation/webpagetest/pull/1158","diff_url":"https://github.com/WPO-Foundation/webpagetest/pull/1158.diff","patch_url":"https://github.com/WPO-Foundation/webpagetest/pull/1158.patch","issue_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/1158","number":1158,"state":"open","locked":false,"title":"Expose hero times in UI","user":{"login":"wildlyinaccurate","id":794263,"node_id":"MDQ6VXNlcjc5NDI2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/794263?v=4","gravatar_id":"","url":"https://api.github.com/users/wildlyinaccurate","html_url":"https://github.com/wildlyinaccurate","followers_url":"https://api.github.com/users/wildlyinaccurate/followers","following_url":"https://api.github.com/users/wildlyinaccurate/following{/other_user}","gists_url":"https://api.github.com/users/wildlyinaccurate/gists{/gist_id}","starred_url":"https://api.github.com/users/wildlyinaccurate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildlyinaccurate/subscriptions","organizations_url":"https://api.github.com/users/wildlyinaccurate/orgs","repos_url":"https://api.github.com/users/wildlyinaccurate/repos","events_url":"https://api.github.com/users/wildlyinaccurate/events{/privacy}","received_events_url":"https://api.github.com/users/wildlyinaccurate/received_events","type":"User","site_admin":false},"body":"I've split this out info separate commits so feel free to cherry-pick. I've exposed the hero times in a few places in the UI:\r\n\r\n## Metrics chart in the filmstrip view (LPH)\r\n\r\n![screenshot_2018-07-09 webpagetest - visual comparison](https://user-images.githubusercontent.com/794263/42428532-2e0292ba-8388-11e8-9ed0-c0ff8bcf9e69.png)\r\n\r\n## Test result summary table (LPH)\r\n\r\n![screenshot_2018-07-09 webpagetest test result - joseph s xps 13 www bbc com news - 07 09 18 14 14 35](https://user-images.githubusercontent.com/794263/42428533-2e34019c-8388-11e8-892b-4add2ebb249b.png)\r\n\r\n## Screen shot page (all hero elements)\r\n\r\n![screenshot_2018-07-09 webpagetest screen shots - joseph s xps 13 www bbc com news - 07 09 18 14 14 35](https://user-images.githubusercontent.com/794263/42428534-2e668018-8388-11e8-85e5-7906a660b8c9.png)\r\n","created_at":"2018-07-09T02:56:36Z","updated_at":"2018-07-09T14:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dacdd8a95ca37e4b3c696d767f198775ad9790af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/1158/comments","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/149adfda37017de4c4a2dbdc44b86f190bebd4cc","head":{"label":"wildlyinaccurate:expose-hero-times-in-ui","ref":"expose-hero-times-in-ui","sha":"149adfda37017de4c4a2dbdc44b86f190bebd4cc","user":{"login":"wildlyinaccurate","id":794263,"node_id":"MDQ6VXNlcjc5NDI2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/794263?v=4","gravatar_id":"","url":"https://api.github.com/users/wildlyinaccurate","html_url":"https://github.com/wildlyinaccurate","followers_url":"https://api.github.com/users/wildlyinaccurate/followers","following_url":"https://api.github.com/users/wildlyinaccurate/following{/other_user}","gists_url":"https://api.github.com/users/wildlyinaccurate/gists{/gist_id}","starred_url":"https://api.github.com/users/wildlyinaccurate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildlyinaccurate/subscriptions","organizations_url":"https://api.github.com/users/wildlyinaccurate/orgs","repos_url":"https://api.github.com/users/wildlyinaccurate/repos","events_url":"https://api.github.com/users/wildlyinaccurate/events{/privacy}","received_events_url":"https://api.github.com/users/wildlyinaccurate/received_events","type":"User","site_admin":false},"repo":{"id":138799133,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3OTkxMzM=","name":"webpagetest","full_name":"wildlyinaccurate/webpagetest","owner":{"login":"wildlyinaccurate","id":794263,"node_id":"MDQ6VXNlcjc5NDI2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/794263?v=4","gravatar_id":"","url":"https://api.github.com/users/wildlyinaccurate","html_url":"https://github.com/wildlyinaccurate","followers_url":"https://api.github.com/users/wildlyinaccurate/followers","following_url":"https://api.github.com/users/wildlyinaccurate/following{/other_user}","gists_url":"https://api.github.com/users/wildlyinaccurate/gists{/gist_id}","starred_url":"https://api.github.com/users/wildlyinaccurate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildlyinaccurate/subscriptions","organizations_url":"https://api.github.com/users/wildlyinaccurate/orgs","repos_url":"https://api.github.com/users/wildlyinaccurate/repos","events_url":"https://api.github.com/users/wildlyinaccurate/events{/privacy}","received_events_url":"https://api.github.com/users/wildlyinaccurate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wildlyinaccurate/webpagetest","description":"Official repository for WebPagetest","fork":true,"url":"https://api.github.com/repos/wildlyinaccurate/webpagetest","forks_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/forks","keys_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/teams","hooks_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/events","assignees_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/tags","blobs_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/languages","stargazers_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/subscription","commits_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/merges","archive_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/downloads","issues_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/releases{/id}","deployments_url":"https://api.github.com/repos/wildlyinaccurate/webpagetest/deployments","created_at":"2018-06-26T22:11:03Z","updated_at":"2018-07-08T22:22:55Z","pushed_at":"2018-07-09T03:02:11Z","git_url":"git://github.com/wildlyinaccurate/webpagetest.git","ssh_url":"git@github.com:wildlyinaccurate/webpagetest.git","clone_url":"https://github.com/wildlyinaccurate/webpagetest.git","svn_url":"https://github.com/wildlyinaccurate/webpagetest","homepage":null,"size":642918,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WPO-Foundation:master","ref":"master","sha":"a3b5bd972804017a58aaad968d9a71cf8e1e47ae","user":{"login":"WPO-Foundation","id":4622875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4622875?v=4","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":11029192,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAyOTE5Mg==","name":"webpagetest","full_name":"WPO-Foundation/webpagetest","owner":{"login":"WPO-Foundation","id":4622875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MjI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4622875?v=4","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WPO-Foundation/webpagetest","description":"Official repository for WebPagetest","fork":false,"url":"https://api.github.com/repos/WPO-Foundation/webpagetest","forks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/forks","keys_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/teams","hooks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/events","assignees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/tags","blobs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/languages","stargazers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscription","commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/merges","archive_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/downloads","issues_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/releases{/id}","deployments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/deployments","created_at":"2013-06-28T14:54:54Z","updated_at":"2018-07-09T09:02:23Z","pushed_at":"2018-07-09T03:02:13Z","git_url":"git://github.com/WPO-Foundation/webpagetest.git","ssh_url":"git@github.com:WPO-Foundation/webpagetest.git","clone_url":"https://github.com/WPO-Foundation/webpagetest.git","svn_url":"https://github.com/WPO-Foundation/webpagetest","homepage":null,"size":642893,"stargazers_count":1875,"watchers_count":1875,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"archived":false,"open_issues_count":341,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":503,"open_issues":341,"watchers":1875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/1158"},"issue":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/1158"},"comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/149adfda37017de4c4a2dbdc44b86f190bebd4cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pmeenan"}}