{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/comments/219289171","pull_request_review_id":157430024,"id":219289171,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTI4OTE3MQ==","diff_hunk":"@@ -60,41 +60,46 @@ class DcrAssembleCoaddConfig(CompareWarpAssembleCoaddConfig):\n             \"If not set, skips calculating convergence and runs for ``maxNumIter`` iterations\",\n         default=True,\n     )\n+    useProgressiveGain = pexConfig.Field(\n+        dtype=bool,\n+        doc=\"Allow the relative weight of the new model solution to increase with each iteration?\",\n+        default=True,\n+    )\n     doAirmassWeight = pexConfig.Field(\n         dtype=bool,\n         doc=\"Weight exposures by airmass? Useful if there are relatively few high-airmass observations.\",\n         default=True,\n     )\n     modelClampFactor = pexConfig.Field(\n         dtype=float,\n-        doc=\"Maximum relative change of the model allowed between iterations.\",\n+        doc=\"Maximum relative change of the model allowed between iterations. Set to zero to disable.\",\n         default=2.,\n     )\n-    regularizeSigma = pexConfig.Field(\n+    modelClampSigma = pexConfig.Field(\n         dtype=float,\n-        doc=\"Threshold to exclude noise-like pixels from regularization.\",\n-        default=3.,\n-    )\n-    clampFrequency = pexConfig.Field(\n-        dtype=float,\n-        doc=\"Maximum relative change of the model allowed between subfilters.\",\n+        doc=\"Threshold to exclude noise-like pixels from regularization between iterations.\",\n         default=2.,\n     )\n-    maxGain = pexConfig.Field(\n+    frequencyClampSigma = pexConfig.Field(\n         dtype=float,\n-        doc=\"Maximum convergence-weighted gain to apply between forward modeling iterations.\",\n-        default=2.,\n+        doc=\"Threshold to exclude noise-like pixels from regularization across subfilters.\",","path":"python/lsst/pipe/tasks/dcrAssembleCoadd.py","position":37,"original_position":37,"commit_id":"55d188c21b18dc693257fc25d2061fef22b1d326","original_commit_id":"55d188c21b18dc693257fc25d2061fef22b1d326","user":{"login":"natelust","id":6371766,"node_id":"MDQ6VXNlcjYzNzE3NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6371766?v=4","gravatar_id":"","url":"https://api.github.com/users/natelust","html_url":"https://github.com/natelust","followers_url":"https://api.github.com/users/natelust/followers","following_url":"https://api.github.com/users/natelust/following{/other_user}","gists_url":"https://api.github.com/users/natelust/gists{/gist_id}","starred_url":"https://api.github.com/users/natelust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natelust/subscriptions","organizations_url":"https://api.github.com/users/natelust/orgs","repos_url":"https://api.github.com/users/natelust/repos","events_url":"https://api.github.com/users/natelust/events{/privacy}","received_events_url":"https://api.github.com/users/natelust/received_events","type":"User","site_admin":false},"body":"same as above","created_at":"2018-09-20T19:26:50Z","updated_at":"2018-09-20T19:46:27Z","html_url":"https://github.com/lsst/pipe_tasks/pull/221#discussion_r219289171","pull_request_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/comments/219289171"},"html":{"href":"https://github.com/lsst/pipe_tasks/pull/221#discussion_r219289171"},"pull_request":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221","id":216151712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTUxNzEy","html_url":"https://github.com/lsst/pipe_tasks/pull/221","diff_url":"https://github.com/lsst/pipe_tasks/pull/221.diff","patch_url":"https://github.com/lsst/pipe_tasks/pull/221.patch","issue_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/221","number":221,"state":"open","locked":false,"title":"Tickets/dm-15636: Improve DcrModel regularization","user":{"login":"isullivan","id":3092083,"node_id":"MDQ6VXNlcjMwOTIwODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3092083?v=4","gravatar_id":"","url":"https://api.github.com/users/isullivan","html_url":"https://github.com/isullivan","followers_url":"https://api.github.com/users/isullivan/followers","following_url":"https://api.github.com/users/isullivan/following{/other_user}","gists_url":"https://api.github.com/users/isullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/isullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isullivan/subscriptions","organizations_url":"https://api.github.com/users/isullivan/orgs","repos_url":"https://api.github.com/users/isullivan/repos","events_url":"https://api.github.com/users/isullivan/events{/privacy}","received_events_url":"https://api.github.com/users/isullivan/received_events","type":"User","site_admin":false},"body":"These changes provide greater flexibility in applying regularization to DcrModels between iterations and between frequencies, and reduce artifacts in the final images. ","created_at":"2018-09-18T00:31:25Z","updated_at":"2018-09-20T19:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d039a289a029b16f4beb4ffd80b7603fcbedb903","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221/commits","review_comments_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221/comments","review_comment_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/221/comments","statuses_url":"https://api.github.com/repos/lsst/pipe_tasks/statuses/55d188c21b18dc693257fc25d2061fef22b1d326","head":{"label":"lsst:tickets/DM-15636","ref":"tickets/DM-15636","sha":"55d188c21b18dc693257fc25d2061fef22b1d326","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013457,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzQ1Nw==","name":"pipe_tasks","full_name":"lsst/pipe_tasks","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/pipe_tasks","description":"LSST Data Management: astronomical data processing tasks","fork":false,"url":"https://api.github.com/repos/lsst/pipe_tasks","forks_url":"https://api.github.com/repos/lsst/pipe_tasks/forks","keys_url":"https://api.github.com/repos/lsst/pipe_tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/pipe_tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/pipe_tasks/teams","hooks_url":"https://api.github.com/repos/lsst/pipe_tasks/hooks","issue_events_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/pipe_tasks/events","assignees_url":"https://api.github.com/repos/lsst/pipe_tasks/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/pipe_tasks/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/pipe_tasks/tags","blobs_url":"https://api.github.com/repos/lsst/pipe_tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/pipe_tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/pipe_tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/pipe_tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/pipe_tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/pipe_tasks/languages","stargazers_url":"https://api.github.com/repos/lsst/pipe_tasks/stargazers","contributors_url":"https://api.github.com/repos/lsst/pipe_tasks/contributors","subscribers_url":"https://api.github.com/repos/lsst/pipe_tasks/subscribers","subscription_url":"https://api.github.com/repos/lsst/pipe_tasks/subscription","commits_url":"https://api.github.com/repos/lsst/pipe_tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/pipe_tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/pipe_tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/pipe_tasks/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/pipe_tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/pipe_tasks/merges","archive_url":"https://api.github.com/repos/lsst/pipe_tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/pipe_tasks/downloads","issues_url":"https://api.github.com/repos/lsst/pipe_tasks/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/pipe_tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/pipe_tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/pipe_tasks/labels{/name}","releases_url":"https://api.github.com/repos/lsst/pipe_tasks/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/pipe_tasks/deployments","created_at":"2014-08-16T07:50:15Z","updated_at":"2018-09-19T06:00:44Z","pushed_at":"2018-09-19T20:57:56Z","git_url":"git://github.com/lsst/pipe_tasks.git","ssh_url":"git@github.com:lsst/pipe_tasks.git","clone_url":"https://github.com/lsst/pipe_tasks.git","svn_url":"https://github.com/lsst/pipe_tasks","homepage":"http://dm.lsst.org/","size":14866,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":10,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"7ce568daed85ed42f2bb41015cc9688516020769","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013457,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzQ1Nw==","name":"pipe_tasks","full_name":"lsst/pipe_tasks","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/pipe_tasks","description":"LSST Data Management: astronomical data processing tasks","fork":false,"url":"https://api.github.com/repos/lsst/pipe_tasks","forks_url":"https://api.github.com/repos/lsst/pipe_tasks/forks","keys_url":"https://api.github.com/repos/lsst/pipe_tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/pipe_tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/pipe_tasks/teams","hooks_url":"https://api.github.com/repos/lsst/pipe_tasks/hooks","issue_events_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/pipe_tasks/events","assignees_url":"https://api.github.com/repos/lsst/pipe_tasks/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/pipe_tasks/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/pipe_tasks/tags","blobs_url":"https://api.github.com/repos/lsst/pipe_tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/pipe_tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/pipe_tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/pipe_tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/pipe_tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/pipe_tasks/languages","stargazers_url":"https://api.github.com/repos/lsst/pipe_tasks/stargazers","contributors_url":"https://api.github.com/repos/lsst/pipe_tasks/contributors","subscribers_url":"https://api.github.com/repos/lsst/pipe_tasks/subscribers","subscription_url":"https://api.github.com/repos/lsst/pipe_tasks/subscription","commits_url":"https://api.github.com/repos/lsst/pipe_tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/pipe_tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/pipe_tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/pipe_tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/pipe_tasks/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/pipe_tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/pipe_tasks/merges","archive_url":"https://api.github.com/repos/lsst/pipe_tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/pipe_tasks/downloads","issues_url":"https://api.github.com/repos/lsst/pipe_tasks/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/pipe_tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/pipe_tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/pipe_tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/pipe_tasks/labels{/name}","releases_url":"https://api.github.com/repos/lsst/pipe_tasks/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/pipe_tasks/deployments","created_at":"2014-08-16T07:50:15Z","updated_at":"2018-09-19T06:00:44Z","pushed_at":"2018-09-19T20:57:56Z","git_url":"git://github.com/lsst/pipe_tasks.git","ssh_url":"git@github.com:lsst/pipe_tasks.git","clone_url":"https://github.com/lsst/pipe_tasks.git","svn_url":"https://github.com/lsst/pipe_tasks","homepage":"http://dm.lsst.org/","size":14866,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":10,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221"},"html":{"href":"https://github.com/lsst/pipe_tasks/pull/221"},"issue":{"href":"https://api.github.com/repos/lsst/pipe_tasks/issues/221"},"comments":{"href":"https://api.github.com/repos/lsst/pipe_tasks/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/pipe_tasks/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/pipe_tasks/statuses/55d188c21b18dc693257fc25d2061fef22b1d326"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"natelust"}}