{"action":"closed","number":177,"pull_request":{"url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177","id":216960997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTYwOTk3","html_url":"https://github.com/guardian/dotcom-rendering/pull/177","diff_url":"https://github.com/guardian/dotcom-rendering/pull/177.diff","patch_url":"https://github.com/guardian/dotcom-rendering/pull/177.patch","issue_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/177","number":177,"state":"closed","locked":false,"title":"Share Count updates","user":{"login":"GHaberis","id":1590704,"node_id":"MDQ6VXNlcjE1OTA3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1590704?v=4","gravatar_id":"","url":"https://api.github.com/users/GHaberis","html_url":"https://github.com/GHaberis","followers_url":"https://api.github.com/users/GHaberis/followers","following_url":"https://api.github.com/users/GHaberis/following{/other_user}","gists_url":"https://api.github.com/users/GHaberis/gists{/gist_id}","starred_url":"https://api.github.com/users/GHaberis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GHaberis/subscriptions","organizations_url":"https://api.github.com/users/GHaberis/orgs","repos_url":"https://api.github.com/users/GHaberis/repos","events_url":"https://api.github.com/users/GHaberis/events{/privacy}","received_events_url":"https://api.github.com/users/GHaberis/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\n\r\n1. ShareCount component now fetches the correct share count for an article\r\n\r\n2. Fixes various style issues:\r\n\r\n**Old (note incorrect margins on meta container)**\r\n![screen shot 2018-09-20 at 13 49 57](https://user-images.githubusercontent.com/1590704/45819399-21c22a00-bcdc-11e8-8441-fae4fe32c379.png)\r\n\r\n**New**\r\n![screen shot 2018-09-20 at 13 48 58](https://user-images.githubusercontent.com/1590704/45819451-3bfc0800-bcdc-11e8-82db-3327e2f58817.png)\r\n\r\n**Old (share count icon wrong colour and position)**\r\n![screen shot 2018-09-20 at 13 47 04](https://user-images.githubusercontent.com/1590704/45819466-474f3380-bcdc-11e8-9f37-4c062f213ccd.png)\r\n\r\n**New**\r\n![screen shot 2018-09-20 at 13 47 16](https://user-images.githubusercontent.com/1590704/45819483-5209c880-bcdc-11e8-8a2c-2e9ed3a5780b.png)\r\n\r\n**Old (share count icon wrong colour and position)**\r\n![screen shot 2018-09-20 at 13 46 51](https://user-images.githubusercontent.com/1590704/45819503-5cc45d80-bcdc-11e8-9be2-51f24361e3f0.png)\r\n\r\n**New**\r\n![screen shot 2018-09-20 at 13 46 43](https://user-images.githubusercontent.com/1590704/45819535-71085a80-bcdc-11e8-91e1-0b1a27a98a24.png)\r\n\r\n**Old (share count icon wrong colour and position)**\r\n![screen shot 2018-09-20 at 13 46 11](https://user-images.githubusercontent.com/1590704/45819547-76fe3b80-bcdc-11e8-986b-828dad3b3a9e.png)\r\n\r\n**New**\r\n![screen shot 2018-09-20 at 13 46 27](https://user-images.githubusercontent.com/1590704/45819558-83829400-bcdc-11e8-8b48-d4b28b6405be.png)\r\n\r\n## Why?\r\n\r\nVisual parity\r\n","created_at":"2018-09-20T12:53:32Z","updated_at":"2018-09-24T15:36:44Z","closed_at":"2018-09-24T15:36:44Z","merged_at":"2018-09-24T15:36:44Z","merge_commit_sha":"a9d2cd91b5f31390f55c1062b2b84e68cafcf5ff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nicl","id":858402,"node_id":"MDQ6VXNlcjg1ODQwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/858402?v=4","gravatar_id":"","url":"https://api.github.com/users/nicl","html_url":"https://github.com/nicl","followers_url":"https://api.github.com/users/nicl/followers","following_url":"https://api.github.com/users/nicl/following{/other_user}","gists_url":"https://api.github.com/users/nicl/gists{/gist_id}","starred_url":"https://api.github.com/users/nicl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicl/subscriptions","organizations_url":"https://api.github.com/users/nicl/orgs","repos_url":"https://api.github.com/users/nicl/repos","events_url":"https://api.github.com/users/nicl/events{/privacy}","received_events_url":"https://api.github.com/users/nicl/received_events","type":"User","site_admin":false},{"login":"sndrs","id":867233,"node_id":"MDQ6VXNlcjg2NzIzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/867233?v=4","gravatar_id":"","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177/commits","review_comments_url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177/comments","review_comment_url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/177/comments","statuses_url":"https://api.github.com/repos/guardian/dotcom-rendering/statuses/b1607fbb947bf1119f23865f65f36d8e6363ee33","head":{"label":"guardian:gh-sharing-icons","ref":"gh-sharing-icons","sha":"b1607fbb947bf1119f23865f65f36d8e6363ee33","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":107111499,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTE0OTk=","name":"dotcom-rendering","full_name":"guardian/dotcom-rendering","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/dotcom-rendering","description":"⍺⁴𝙻","fork":false,"url":"https://api.github.com/repos/guardian/dotcom-rendering","forks_url":"https://api.github.com/repos/guardian/dotcom-rendering/forks","keys_url":"https://api.github.com/repos/guardian/dotcom-rendering/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/dotcom-rendering/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/dotcom-rendering/teams","hooks_url":"https://api.github.com/repos/guardian/dotcom-rendering/hooks","issue_events_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/dotcom-rendering/events","assignees_url":"https://api.github.com/repos/guardian/dotcom-rendering/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/dotcom-rendering/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/dotcom-rendering/tags","blobs_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/dotcom-rendering/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/dotcom-rendering/languages","stargazers_url":"https://api.github.com/repos/guardian/dotcom-rendering/stargazers","contributors_url":"https://api.github.com/repos/guardian/dotcom-rendering/contributors","subscribers_url":"https://api.github.com/repos/guardian/dotcom-rendering/subscribers","subscription_url":"https://api.github.com/repos/guardian/dotcom-rendering/subscription","commits_url":"https://api.github.com/repos/guardian/dotcom-rendering/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/dotcom-rendering/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/dotcom-rendering/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/dotcom-rendering/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/dotcom-rendering/merges","archive_url":"https://api.github.com/repos/guardian/dotcom-rendering/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/dotcom-rendering/downloads","issues_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/dotcom-rendering/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/dotcom-rendering/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/dotcom-rendering/labels{/name}","releases_url":"https://api.github.com/repos/guardian/dotcom-rendering/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/dotcom-rendering/deployments","created_at":"2017-10-16T10:13:32Z","updated_at":"2018-09-24T12:32:32Z","pushed_at":"2018-09-24T15:36:44Z","git_url":"git://github.com/guardian/dotcom-rendering.git","ssh_url":"git@github.com:guardian/dotcom-rendering.git","clone_url":"https://github.com/guardian/dotcom-rendering.git","svn_url":"https://github.com/guardian/dotcom-rendering","homepage":"","size":12825,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"20e119d6bbd61338398cc6bad5d59821bbaa4c50","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":107111499,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTE0OTk=","name":"dotcom-rendering","full_name":"guardian/dotcom-rendering","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/dotcom-rendering","description":"⍺⁴𝙻","fork":false,"url":"https://api.github.com/repos/guardian/dotcom-rendering","forks_url":"https://api.github.com/repos/guardian/dotcom-rendering/forks","keys_url":"https://api.github.com/repos/guardian/dotcom-rendering/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/dotcom-rendering/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/dotcom-rendering/teams","hooks_url":"https://api.github.com/repos/guardian/dotcom-rendering/hooks","issue_events_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/dotcom-rendering/events","assignees_url":"https://api.github.com/repos/guardian/dotcom-rendering/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/dotcom-rendering/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/dotcom-rendering/tags","blobs_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/dotcom-rendering/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/dotcom-rendering/languages","stargazers_url":"https://api.github.com/repos/guardian/dotcom-rendering/stargazers","contributors_url":"https://api.github.com/repos/guardian/dotcom-rendering/contributors","subscribers_url":"https://api.github.com/repos/guardian/dotcom-rendering/subscribers","subscription_url":"https://api.github.com/repos/guardian/dotcom-rendering/subscription","commits_url":"https://api.github.com/repos/guardian/dotcom-rendering/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/dotcom-rendering/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/dotcom-rendering/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/dotcom-rendering/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/dotcom-rendering/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/dotcom-rendering/merges","archive_url":"https://api.github.com/repos/guardian/dotcom-rendering/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/dotcom-rendering/downloads","issues_url":"https://api.github.com/repos/guardian/dotcom-rendering/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/dotcom-rendering/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/dotcom-rendering/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/dotcom-rendering/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/dotcom-rendering/labels{/name}","releases_url":"https://api.github.com/repos/guardian/dotcom-rendering/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/dotcom-rendering/deployments","created_at":"2017-10-16T10:13:32Z","updated_at":"2018-09-24T12:32:32Z","pushed_at":"2018-09-24T15:36:44Z","git_url":"git://github.com/guardian/dotcom-rendering.git","ssh_url":"git@github.com:guardian/dotcom-rendering.git","clone_url":"https://github.com/guardian/dotcom-rendering.git","svn_url":"https://github.com/guardian/dotcom-rendering","homepage":"","size":12825,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177"},"html":{"href":"https://github.com/guardian/dotcom-rendering/pull/177"},"issue":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/issues/177"},"comments":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/dotcom-rendering/statuses/b1607fbb947bf1119f23865f65f36d8e6363ee33"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"GHaberis","id":1590704,"node_id":"MDQ6VXNlcjE1OTA3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1590704?v=4","gravatar_id":"","url":"https://api.github.com/users/GHaberis","html_url":"https://github.com/GHaberis","followers_url":"https://api.github.com/users/GHaberis/followers","following_url":"https://api.github.com/users/GHaberis/following{/other_user}","gists_url":"https://api.github.com/users/GHaberis/gists{/gist_id}","starred_url":"https://api.github.com/users/GHaberis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GHaberis/subscriptions","organizations_url":"https://api.github.com/users/GHaberis/orgs","repos_url":"https://api.github.com/users/GHaberis/repos","events_url":"https://api.github.com/users/GHaberis/events{/privacy}","received_events_url":"https://api.github.com/users/GHaberis/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":240,"deletions":57,"changed_files":8}}
{"actor":{"display_login":"GHaberis"}}