{"action":"created","comment":{"url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/comments/243548349","pull_request_review_id":187348674,"id":243548349,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU0ODM0OQ==","diff_hunk":"@@ -0,0 +1,389 @@\n+=head1 LICENSE\n+\n+Copyright [1999-2015] Wellcome Trust Sanger Institute and the EMBL-European Bioinformatics Institute","path":"modules/Bio/EnsEMBL/Xref/Mapper/ChecksumMapper.pm","position":3,"original_position":3,"commit_id":"47f200359118c075f81e17b7dfc333548c333294","original_commit_id":"47f200359118c075f81e17b7dfc333548c333294","user":{"login":"avullo","id":6085263,"node_id":"MDQ6VXNlcjYwODUyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/6085263?v=4","gravatar_id":"","url":"https://api.github.com/users/avullo","html_url":"https://github.com/avullo","followers_url":"https://api.github.com/users/avullo/followers","following_url":"https://api.github.com/users/avullo/following{/other_user}","gists_url":"https://api.github.com/users/avullo/gists{/gist_id}","starred_url":"https://api.github.com/users/avullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avullo/subscriptions","organizations_url":"https://api.github.com/users/avullo/orgs","repos_url":"https://api.github.com/users/avullo/repos","events_url":"https://api.github.com/users/avullo/events{/privacy}","received_events_url":"https://api.github.com/users/avullo/received_events","type":"User","site_admin":false},"body":"This is the old copyright format.","created_at":"2018-12-21T10:45:54Z","updated_at":"2018-12-21T10:59:22Z","html_url":"https://github.com/Ensembl/ensembl-xref/pull/49#discussion_r243548349","pull_request_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/comments/243548349"},"html":{"href":"https://github.com/Ensembl/ensembl-xref/pull/49#discussion_r243548349"},"pull_request":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49","id":240250019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjUwMDE5","html_url":"https://github.com/Ensembl/ensembl-xref/pull/49","diff_url":"https://github.com/Ensembl/ensembl-xref/pull/49.diff","patch_url":"https://github.com/Ensembl/ensembl-xref/pull/49.patch","issue_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/49","number":49,"state":"open","locked":false,"title":"An attempt at harmonising the ChecksumMapper into a single package","user":{"login":"nerdstrike","id":5434501,"node_id":"MDQ6VXNlcjU0MzQ1MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5434501?v=4","gravatar_id":"","url":"https://api.github.com/users/nerdstrike","html_url":"https://github.com/nerdstrike","followers_url":"https://api.github.com/users/nerdstrike/followers","following_url":"https://api.github.com/users/nerdstrike/following{/other_user}","gists_url":"https://api.github.com/users/nerdstrike/gists{/gist_id}","starred_url":"https://api.github.com/users/nerdstrike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerdstrike/subscriptions","organizations_url":"https://api.github.com/users/nerdstrike/orgs","repos_url":"https://api.github.com/users/nerdstrike/repos","events_url":"https://api.github.com/users/nerdstrike/events{/privacy}","received_events_url":"https://api.github.com/users/nerdstrike/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nChecksumMapper was previously five files with more flexibility than it needs for current day usage. This reconciles all the logic into a single configurable and testable class.\r\n\r\nFeel free to not merge this. It could be adopted without test coverage, but that brings risks.\r\n\r\n## Use case\r\n\r\nChecksum Xref generation\r\n\r\n## Benefits\r\n\r\nGreatly reduced complexity\r\n\r\n## Possible Drawbacks\r\n\r\nTest coverage is poor at this stage. Was developed without direct reference to the latest pipeline code. There is a little bit of divergence.\r\n\r\n## Testing\r\n\r\nBasic getters and setters and a few utility functions are tested. process() is not due to time constraints.\r\n","created_at":"2018-12-20T17:39:20Z","updated_at":"2018-12-21T10:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a4e809d0991e52e229331130530e42c871f3e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49/commits","review_comments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49/comments","review_comment_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/49/comments","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-xref/statuses/47f200359118c075f81e17b7dfc333548c333294","head":{"label":"Ensembl:feature/checksum_mapper","ref":"feature/checksum_mapper","sha":"47f200359118c075f81e17b7dfc333548c333294","user":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"repo":{"id":154531202,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MzEyMDI=","name":"ensembl-xref","full_name":"Ensembl/ensembl-xref","private":false,"owner":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ensembl/ensembl-xref","description":"Pipeline to generate links to external references in Ensembl","fork":false,"url":"https://api.github.com/repos/Ensembl/ensembl-xref","forks_url":"https://api.github.com/repos/Ensembl/ensembl-xref/forks","keys_url":"https://api.github.com/repos/Ensembl/ensembl-xref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembl/ensembl-xref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembl/ensembl-xref/teams","hooks_url":"https://api.github.com/repos/Ensembl/ensembl-xref/hooks","issue_events_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembl/ensembl-xref/events","assignees_url":"https://api.github.com/repos/Ensembl/ensembl-xref/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembl/ensembl-xref/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembl/ensembl-xref/tags","blobs_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-xref/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembl/ensembl-xref/languages","stargazers_url":"https://api.github.com/repos/Ensembl/ensembl-xref/stargazers","contributors_url":"https://api.github.com/repos/Ensembl/ensembl-xref/contributors","subscribers_url":"https://api.github.com/repos/Ensembl/ensembl-xref/subscribers","subscription_url":"https://api.github.com/repos/Ensembl/ensembl-xref/subscription","commits_url":"https://api.github.com/repos/Ensembl/ensembl-xref/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembl/ensembl-xref/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembl/ensembl-xref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembl/ensembl-xref/merges","archive_url":"https://api.github.com/repos/Ensembl/ensembl-xref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembl/ensembl-xref/downloads","issues_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembl/ensembl-xref/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembl/ensembl-xref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembl/ensembl-xref/labels{/name}","releases_url":"https://api.github.com/repos/Ensembl/ensembl-xref/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/deployments","created_at":"2018-10-24T16:12:02Z","updated_at":"2018-12-20T09:18:17Z","pushed_at":"2018-12-21T06:57:17Z","git_url":"git://github.com/Ensembl/ensembl-xref.git","ssh_url":"git@github.com:Ensembl/ensembl-xref.git","clone_url":"https://github.com/Ensembl/ensembl-xref.git","svn_url":"https://github.com/Ensembl/ensembl-xref","homepage":"","size":2031,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"Ensembl:master","ref":"master","sha":"35751620ed3d9ece5447022d5d8d21ab025a736d","user":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"repo":{"id":154531202,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MzEyMDI=","name":"ensembl-xref","full_name":"Ensembl/ensembl-xref","private":false,"owner":{"login":"Ensembl","id":5832463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MzI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/5832463?v=4","gravatar_id":"","url":"https://api.github.com/users/Ensembl","html_url":"https://github.com/Ensembl","followers_url":"https://api.github.com/users/Ensembl/followers","following_url":"https://api.github.com/users/Ensembl/following{/other_user}","gists_url":"https://api.github.com/users/Ensembl/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembl/subscriptions","organizations_url":"https://api.github.com/users/Ensembl/orgs","repos_url":"https://api.github.com/users/Ensembl/repos","events_url":"https://api.github.com/users/Ensembl/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ensembl/ensembl-xref","description":"Pipeline to generate links to external references in Ensembl","fork":false,"url":"https://api.github.com/repos/Ensembl/ensembl-xref","forks_url":"https://api.github.com/repos/Ensembl/ensembl-xref/forks","keys_url":"https://api.github.com/repos/Ensembl/ensembl-xref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembl/ensembl-xref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembl/ensembl-xref/teams","hooks_url":"https://api.github.com/repos/Ensembl/ensembl-xref/hooks","issue_events_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembl/ensembl-xref/events","assignees_url":"https://api.github.com/repos/Ensembl/ensembl-xref/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembl/ensembl-xref/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembl/ensembl-xref/tags","blobs_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembl/ensembl-xref/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembl/ensembl-xref/languages","stargazers_url":"https://api.github.com/repos/Ensembl/ensembl-xref/stargazers","contributors_url":"https://api.github.com/repos/Ensembl/ensembl-xref/contributors","subscribers_url":"https://api.github.com/repos/Ensembl/ensembl-xref/subscribers","subscription_url":"https://api.github.com/repos/Ensembl/ensembl-xref/subscription","commits_url":"https://api.github.com/repos/Ensembl/ensembl-xref/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembl/ensembl-xref/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembl/ensembl-xref/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembl/ensembl-xref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembl/ensembl-xref/merges","archive_url":"https://api.github.com/repos/Ensembl/ensembl-xref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembl/ensembl-xref/downloads","issues_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembl/ensembl-xref/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembl/ensembl-xref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembl/ensembl-xref/labels{/name}","releases_url":"https://api.github.com/repos/Ensembl/ensembl-xref/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/deployments","created_at":"2018-10-24T16:12:02Z","updated_at":"2018-12-20T09:18:17Z","pushed_at":"2018-12-21T06:57:17Z","git_url":"git://github.com/Ensembl/ensembl-xref.git","ssh_url":"git@github.com:Ensembl/ensembl-xref.git","clone_url":"https://github.com/Ensembl/ensembl-xref.git","svn_url":"https://github.com/Ensembl/ensembl-xref","homepage":"","size":2031,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49"},"html":{"href":"https://github.com/Ensembl/ensembl-xref/pull/49"},"issue":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/49"},"comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/Ensembl/ensembl-xref/statuses/47f200359118c075f81e17b7dfc333548c333294"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"avullo"}}