{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/comments/233911893","pull_request_review_id":175435821,"id":233911893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzkxMTg5Mw==","diff_hunk":"@@ -92,6 +92,8 @@ func (s *Server) PullImage(ctx context.Context, req *pb.PullImageRequest) (resp\n \t\t\t\tbreak\n \t\t\t}\n \t\t\tlogrus.Debugf(\"image in store has different ID, re-pulling %s\", img)\n+\t\t} else {\n+\t\t\treturn nil, err","path":"server/image_pull.go","position":5,"original_position":5,"commit_id":"ba44e435463b84541cd25cbd21835c335949a98e","original_commit_id":"ba44e435463b84541cd25cbd21835c335949a98e","user":{"login":"QiWang19","id":23665824,"node_id":"MDQ6VXNlcjIzNjY1ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/23665824?v=4","gravatar_id":"","url":"https://api.github.com/users/QiWang19","html_url":"https://github.com/QiWang19","followers_url":"https://api.github.com/users/QiWang19/followers","following_url":"https://api.github.com/users/QiWang19/following{/other_user}","gists_url":"https://api.github.com/users/QiWang19/gists{/gist_id}","starred_url":"https://api.github.com/users/QiWang19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiWang19/subscriptions","organizations_url":"https://api.github.com/users/QiWang19/orgs","repos_url":"https://api.github.com/users/QiWang19/repos","events_url":"https://api.github.com/users/QiWang19/events{/privacy}","received_events_url":"https://api.github.com/users/QiWang19/received_events","type":"User","site_admin":false},"body":"maybe #1548 can be closed, did not find other swallow errors mentioned in this issue.","created_at":"2018-11-15T16:21:05Z","updated_at":"2018-11-15T16:21:05Z","html_url":"https://github.com/kubernetes-sigs/cri-o/pull/1911#discussion_r233911893","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/comments/233911893"},"html":{"href":"https://github.com/kubernetes-sigs/cri-o/pull/1911#discussion_r233911893"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911"}},"in_reply_to_id":233905982},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911","id":231246352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjQ2MzUy","html_url":"https://github.com/kubernetes-sigs/cri-o/pull/1911","diff_url":"https://github.com/kubernetes-sigs/cri-o/pull/1911.diff","patch_url":"https://github.com/kubernetes-sigs/cri-o/pull/1911.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1911","number":1911,"state":"closed","locked":false,"title":"Return an error in image pull","user":{"login":"QiWang19","id":23665824,"node_id":"MDQ6VXNlcjIzNjY1ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/23665824?v=4","gravatar_id":"","url":"https://api.github.com/users/QiWang19","html_url":"https://github.com/QiWang19","followers_url":"https://api.github.com/users/QiWang19/followers","following_url":"https://api.github.com/users/QiWang19/following{/other_user}","gists_url":"https://api.github.com/users/QiWang19/gists{/gist_id}","starred_url":"https://api.github.com/users/QiWang19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiWang19/subscriptions","organizations_url":"https://api.github.com/users/QiWang19/orgs","repos_url":"https://api.github.com/users/QiWang19/repos","events_url":"https://api.github.com/users/QiWang19/events{/privacy}","received_events_url":"https://api.github.com/users/QiWang19/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Qi Wang <qiwan@redhat.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/kubernetes-sigs/cri-o/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nfixes #1548 \r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n","created_at":"2018-11-15T15:59:45Z","updated_at":"2018-11-15T16:21:05Z","closed_at":"2018-11-15T16:17:22Z","merged_at":null,"merge_commit_sha":"4cb6dc21858f007d9beb4c482dbe0128ea6dd4a6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrunalp","id":53798,"node_id":"MDQ6VXNlcjUzNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},{"login":"giuseppe","id":67430,"node_id":"MDQ6VXNlcjY3NDMw","avatar_url":"https://avatars0.githubusercontent.com/u/67430?v=4","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484626496,"node_id":"MDU6TGFiZWw0ODQ2MjY0OTY=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":699272716,"node_id":"MDU6TGFiZWw2OTkyNzI3MTY=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676022323,"node_id":"MDU6TGFiZWw2NzYwMjIzMjM=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1911/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/statuses/ba44e435463b84541cd25cbd21835c335949a98e","head":{"label":"QiWang19:issue1547","ref":"issue1547","sha":"ba44e435463b84541cd25cbd21835c335949a98e","user":{"login":"QiWang19","id":23665824,"node_id":"MDQ6VXNlcjIzNjY1ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/23665824?v=4","gravatar_id":"","url":"https://api.github.com/users/QiWang19","html_url":"https://github.com/QiWang19","followers_url":"https://api.github.com/users/QiWang19/followers","following_url":"https://api.github.com/users/QiWang19/following{/other_user}","gists_url":"https://api.github.com/users/QiWang19/gists{/gist_id}","starred_url":"https://api.github.com/users/QiWang19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiWang19/subscriptions","organizations_url":"https://api.github.com/users/QiWang19/orgs","repos_url":"https://api.github.com/users/QiWang19/repos","events_url":"https://api.github.com/users/QiWang19/events{/privacy}","received_events_url":"https://api.github.com/users/QiWang19/received_events","type":"User","site_admin":false},"repo":{"id":153175337,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxNzUzMzc=","name":"cri-o","full_name":"QiWang19/cri-o","private":false,"owner":{"login":"QiWang19","id":23665824,"node_id":"MDQ6VXNlcjIzNjY1ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/23665824?v=4","gravatar_id":"","url":"https://api.github.com/users/QiWang19","html_url":"https://github.com/QiWang19","followers_url":"https://api.github.com/users/QiWang19/followers","following_url":"https://api.github.com/users/QiWang19/following{/other_user}","gists_url":"https://api.github.com/users/QiWang19/gists{/gist_id}","starred_url":"https://api.github.com/users/QiWang19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiWang19/subscriptions","organizations_url":"https://api.github.com/users/QiWang19/orgs","repos_url":"https://api.github.com/users/QiWang19/repos","events_url":"https://api.github.com/users/QiWang19/events{/privacy}","received_events_url":"https://api.github.com/users/QiWang19/received_events","type":"User","site_admin":false},"html_url":"https://github.com/QiWang19/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/QiWang19/cri-o","forks_url":"https://api.github.com/repos/QiWang19/cri-o/forks","keys_url":"https://api.github.com/repos/QiWang19/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QiWang19/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QiWang19/cri-o/teams","hooks_url":"https://api.github.com/repos/QiWang19/cri-o/hooks","issue_events_url":"https://api.github.com/repos/QiWang19/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/QiWang19/cri-o/events","assignees_url":"https://api.github.com/repos/QiWang19/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/QiWang19/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/QiWang19/cri-o/tags","blobs_url":"https://api.github.com/repos/QiWang19/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QiWang19/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QiWang19/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/QiWang19/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QiWang19/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/QiWang19/cri-o/languages","stargazers_url":"https://api.github.com/repos/QiWang19/cri-o/stargazers","contributors_url":"https://api.github.com/repos/QiWang19/cri-o/contributors","subscribers_url":"https://api.github.com/repos/QiWang19/cri-o/subscribers","subscription_url":"https://api.github.com/repos/QiWang19/cri-o/subscription","commits_url":"https://api.github.com/repos/QiWang19/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/QiWang19/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/QiWang19/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/QiWang19/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/QiWang19/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/QiWang19/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QiWang19/cri-o/merges","archive_url":"https://api.github.com/repos/QiWang19/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QiWang19/cri-o/downloads","issues_url":"https://api.github.com/repos/QiWang19/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/QiWang19/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/QiWang19/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/QiWang19/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QiWang19/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/QiWang19/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/QiWang19/cri-o/deployments","created_at":"2018-10-15T20:12:22Z","updated_at":"2018-11-14T20:19:00Z","pushed_at":"2018-11-15T16:04:53Z","git_url":"git://github.com/QiWang19/cri-o.git","ssh_url":"git@github.com:QiWang19/cri-o.git","clone_url":"https://github.com/QiWang19/cri-o.git","svn_url":"https://github.com/QiWang19/cri-o","homepage":"","size":45147,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"4a360891ebce7d920ca79d42720622ace66d8799","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":67828134,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgyODEzNA==","name":"cri-o","full_name":"kubernetes-sigs/cri-o","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/cri-o","forks_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/deployments","created_at":"2016-09-09T19:56:31Z","updated_at":"2018-11-14T16:56:05Z","pushed_at":"2018-11-15T16:15:07Z","git_url":"git://github.com/kubernetes-sigs/cri-o.git","ssh_url":"git@github.com:kubernetes-sigs/cri-o.git","clone_url":"https://github.com/kubernetes-sigs/cri-o.git","svn_url":"https://github.com/kubernetes-sigs/cri-o","homepage":"","size":45173,"stargazers_count":1383,"watchers_count":1383,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":250,"open_issues":125,"watchers":1383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911"},"html":{"href":"https://github.com/kubernetes-sigs/cri-o/pull/1911"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1911"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1911/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1911/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/cri-o/statuses/ba44e435463b84541cd25cbd21835c335949a98e"}},"author_association":"NONE"}}
{"actor":{"display_login":"QiWang19"}}