{"action":"created","comment":{"url":"https://api.github.com/repos/criteo-forks/mesos/pulls/comments/211605191","pull_request_review_id":148059080,"id":211605191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTYwNTE5MQ==","diff_hunk":"@@ -111,6 +111,7 @@ class Flags : public virtual logging::Flags\n   // Optional IP discover script that will set the Master IP.\n   // If set, its output is expected to be a valid parseable IP string.\n   Option<std::string> ip_discovery_command;\n+  bool enable_network_bandwidth_enforcement;","path":"src/master/flags.hpp","position":4,"original_position":4,"commit_id":"104936839dfbb9c912177b2bbc0ada310d1e1730","original_commit_id":"91d109c568381a876bc99176b45bc86142ceb410","user":{"login":"fboismenu","id":8854654,"node_id":"MDQ6VXNlcjg4NTQ2NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8854654?v=4","gravatar_id":"","url":"https://api.github.com/users/fboismenu","html_url":"https://github.com/fboismenu","followers_url":"https://api.github.com/users/fboismenu/followers","following_url":"https://api.github.com/users/fboismenu/following{/other_user}","gists_url":"https://api.github.com/users/fboismenu/gists{/gist_id}","starred_url":"https://api.github.com/users/fboismenu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fboismenu/subscriptions","organizations_url":"https://api.github.com/users/fboismenu/orgs","repos_url":"https://api.github.com/users/fboismenu/repos","events_url":"https://api.github.com/users/fboismenu/events{/privacy}","received_events_url":"https://api.github.com/users/fboismenu/received_events","type":"User","site_admin":false},"body":"not important but line placement is a bit wierd, seems to create a paragraph with the line of code/comments above... \r\n","created_at":"2018-08-21T13:30:38Z","updated_at":"2018-08-21T13:36:55Z","html_url":"https://github.com/criteo-forks/mesos/pull/3#discussion_r211605191","pull_request_url":"https://api.github.com/repos/criteo-forks/mesos/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/comments/211605191"},"html":{"href":"https://github.com/criteo-forks/mesos/pull/3#discussion_r211605191"},"pull_request":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/criteo-forks/mesos/pulls/3","id":209570463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTcwNDYz","html_url":"https://github.com/criteo-forks/mesos/pull/3","diff_url":"https://github.com/criteo-forks/mesos/pull/3.diff","patch_url":"https://github.com/criteo-forks/mesos/pull/3.patch","issue_url":"https://api.github.com/repos/criteo-forks/mesos/issues/3","number":3,"state":"open","locked":false,"title":"Additional fixes for network bandwidth","user":{"login":"clems4ever","id":3193257,"node_id":"MDQ6VXNlcjMxOTMyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3193257?v=4","gravatar_id":"","url":"https://api.github.com/users/clems4ever","html_url":"https://github.com/clems4ever","followers_url":"https://api.github.com/users/clems4ever/followers","following_url":"https://api.github.com/users/clems4ever/following{/other_user}","gists_url":"https://api.github.com/users/clems4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/clems4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clems4ever/subscriptions","organizations_url":"https://api.github.com/users/clems4ever/orgs","repos_url":"https://api.github.com/users/clems4ever/repos","events_url":"https://api.github.com/users/clems4ever/events{/privacy}","received_events_url":"https://api.github.com/users/clems4ever/received_events","type":"User","site_admin":false},"body":"Add flag to enable network bandwidth enforcement and fix unit tests.\r\n\r\nPlease note that for building the RPM, we need to regenerate Makefile.in files with automake and append the changes from this file to the patch in the RPM. Otherwise, the builder will try to use automake 1.15 to regenerate Makefile.in but this version is not on the builders.","created_at":"2018-08-20T16:06:22Z","updated_at":"2018-08-21T13:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d90f1436e63f6b6df94b8989210f045578d2cb9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"komuta","id":120297,"node_id":"MDQ6VXNlcjEyMDI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/120297?v=4","gravatar_id":"","url":"https://api.github.com/users/komuta","html_url":"https://github.com/komuta","followers_url":"https://api.github.com/users/komuta/followers","following_url":"https://api.github.com/users/komuta/following{/other_user}","gists_url":"https://api.github.com/users/komuta/gists{/gist_id}","starred_url":"https://api.github.com/users/komuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komuta/subscriptions","organizations_url":"https://api.github.com/users/komuta/orgs","repos_url":"https://api.github.com/users/komuta/repos","events_url":"https://api.github.com/users/komuta/events{/privacy}","received_events_url":"https://api.github.com/users/komuta/received_events","type":"User","site_admin":false},{"login":"kamaradclimber","id":503537,"node_id":"MDQ6VXNlcjUwMzUzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/503537?v=4","gravatar_id":"","url":"https://api.github.com/users/kamaradclimber","html_url":"https://github.com/kamaradclimber","followers_url":"https://api.github.com/users/kamaradclimber/followers","following_url":"https://api.github.com/users/kamaradclimber/following{/other_user}","gists_url":"https://api.github.com/users/kamaradclimber/gists{/gist_id}","starred_url":"https://api.github.com/users/kamaradclimber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamaradclimber/subscriptions","organizations_url":"https://api.github.com/users/kamaradclimber/orgs","repos_url":"https://api.github.com/users/kamaradclimber/repos","events_url":"https://api.github.com/users/kamaradclimber/events{/privacy}","received_events_url":"https://api.github.com/users/kamaradclimber/received_events","type":"User","site_admin":false},{"login":"dlukman","id":2423120,"node_id":"MDQ6VXNlcjI0MjMxMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2423120?v=4","gravatar_id":"","url":"https://api.github.com/users/dlukman","html_url":"https://github.com/dlukman","followers_url":"https://api.github.com/users/dlukman/followers","following_url":"https://api.github.com/users/dlukman/following{/other_user}","gists_url":"https://api.github.com/users/dlukman/gists{/gist_id}","starred_url":"https://api.github.com/users/dlukman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlukman/subscriptions","organizations_url":"https://api.github.com/users/dlukman/orgs","repos_url":"https://api.github.com/users/dlukman/repos","events_url":"https://api.github.com/users/dlukman/events{/privacy}","received_events_url":"https://api.github.com/users/dlukman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/criteo-forks/mesos/pulls/3/commits","review_comments_url":"https://api.github.com/repos/criteo-forks/mesos/pulls/3/comments","review_comment_url":"https://api.github.com/repos/criteo-forks/mesos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/criteo-forks/mesos/issues/3/comments","statuses_url":"https://api.github.com/repos/criteo-forks/mesos/statuses/104936839dfbb9c912177b2bbc0ada310d1e1730","head":{"label":"criteo-forks:network-bandwidth","ref":"network-bandwidth","sha":"104936839dfbb9c912177b2bbc0ada310d1e1730","user":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":119405109,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDUxMDk=","name":"mesos","full_name":"criteo-forks/mesos","owner":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-forks/mesos","description":"Mirror of Apache Mesos","fork":true,"url":"https://api.github.com/repos/criteo-forks/mesos","forks_url":"https://api.github.com/repos/criteo-forks/mesos/forks","keys_url":"https://api.github.com/repos/criteo-forks/mesos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-forks/mesos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-forks/mesos/teams","hooks_url":"https://api.github.com/repos/criteo-forks/mesos/hooks","issue_events_url":"https://api.github.com/repos/criteo-forks/mesos/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-forks/mesos/events","assignees_url":"https://api.github.com/repos/criteo-forks/mesos/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-forks/mesos/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-forks/mesos/tags","blobs_url":"https://api.github.com/repos/criteo-forks/mesos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-forks/mesos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-forks/mesos/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-forks/mesos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-forks/mesos/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-forks/mesos/languages","stargazers_url":"https://api.github.com/repos/criteo-forks/mesos/stargazers","contributors_url":"https://api.github.com/repos/criteo-forks/mesos/contributors","subscribers_url":"https://api.github.com/repos/criteo-forks/mesos/subscribers","subscription_url":"https://api.github.com/repos/criteo-forks/mesos/subscription","commits_url":"https://api.github.com/repos/criteo-forks/mesos/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-forks/mesos/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-forks/mesos/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-forks/mesos/issues/comments{/number}","contents_url":"https://api.github.com/repos/criteo-forks/mesos/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-forks/mesos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-forks/mesos/merges","archive_url":"https://api.github.com/repos/criteo-forks/mesos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-forks/mesos/downloads","issues_url":"https://api.github.com/repos/criteo-forks/mesos/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-forks/mesos/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-forks/mesos/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-forks/mesos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-forks/mesos/labels{/name}","releases_url":"https://api.github.com/repos/criteo-forks/mesos/releases{/id}","deployments_url":"https://api.github.com/repos/criteo-forks/mesos/deployments","created_at":"2018-01-29T15:59:12Z","updated_at":"2018-05-14T12:40:51Z","pushed_at":"2018-08-21T13:32:52Z","git_url":"git://github.com/criteo-forks/mesos.git","ssh_url":"git@github.com:criteo-forks/mesos.git","clone_url":"https://github.com/criteo-forks/mesos.git","svn_url":"https://github.com/criteo-forks/mesos","homepage":null,"size":368389,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"criteo-forks:criteo/1.4.0","ref":"criteo/1.4.0","sha":"39c2575c3f5281f270ce34b990322a3a762c8bd3","user":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":119405109,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDUxMDk=","name":"mesos","full_name":"criteo-forks/mesos","owner":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-forks/mesos","description":"Mirror of Apache Mesos","fork":true,"url":"https://api.github.com/repos/criteo-forks/mesos","forks_url":"https://api.github.com/repos/criteo-forks/mesos/forks","keys_url":"https://api.github.com/repos/criteo-forks/mesos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-forks/mesos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-forks/mesos/teams","hooks_url":"https://api.github.com/repos/criteo-forks/mesos/hooks","issue_events_url":"https://api.github.com/repos/criteo-forks/mesos/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-forks/mesos/events","assignees_url":"https://api.github.com/repos/criteo-forks/mesos/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-forks/mesos/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-forks/mesos/tags","blobs_url":"https://api.github.com/repos/criteo-forks/mesos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-forks/mesos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-forks/mesos/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-forks/mesos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-forks/mesos/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-forks/mesos/languages","stargazers_url":"https://api.github.com/repos/criteo-forks/mesos/stargazers","contributors_url":"https://api.github.com/repos/criteo-forks/mesos/contributors","subscribers_url":"https://api.github.com/repos/criteo-forks/mesos/subscribers","subscription_url":"https://api.github.com/repos/criteo-forks/mesos/subscription","commits_url":"https://api.github.com/repos/criteo-forks/mesos/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-forks/mesos/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-forks/mesos/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-forks/mesos/issues/comments{/number}","contents_url":"https://api.github.com/repos/criteo-forks/mesos/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-forks/mesos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-forks/mesos/merges","archive_url":"https://api.github.com/repos/criteo-forks/mesos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-forks/mesos/downloads","issues_url":"https://api.github.com/repos/criteo-forks/mesos/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-forks/mesos/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-forks/mesos/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-forks/mesos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-forks/mesos/labels{/name}","releases_url":"https://api.github.com/repos/criteo-forks/mesos/releases{/id}","deployments_url":"https://api.github.com/repos/criteo-forks/mesos/deployments","created_at":"2018-01-29T15:59:12Z","updated_at":"2018-05-14T12:40:51Z","pushed_at":"2018-08-21T13:32:52Z","git_url":"git://github.com/criteo-forks/mesos.git","ssh_url":"git@github.com:criteo-forks/mesos.git","clone_url":"https://github.com/criteo-forks/mesos.git","svn_url":"https://github.com/criteo-forks/mesos","homepage":null,"size":368389,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/3"},"html":{"href":"https://github.com/criteo-forks/mesos/pull/3"},"issue":{"href":"https://api.github.com/repos/criteo-forks/mesos/issues/3"},"comments":{"href":"https://api.github.com/repos/criteo-forks/mesos/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/criteo-forks/mesos/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/criteo-forks/mesos/statuses/104936839dfbb9c912177b2bbc0ada310d1e1730"}},"author_association":"NONE"}}
{"actor":{"display_login":"fboismenu"}}