{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1252","repository_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1252/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1252/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1252/events","html_url":"https://github.com/kubernetes-incubator/kube-aws/issues/1252","id":316848210,"number":1252,"title":"Enable EBS-optimized flag on nodes","user":{"login":"kiich","id":4416324,"avatar_url":"https://avatars1.githubusercontent.com/u/4416324?v=4","gravatar_id":"","url":"https://api.github.com/users/kiich","html_url":"https://github.com/kiich","followers_url":"https://api.github.com/users/kiich/followers","following_url":"https://api.github.com/users/kiich/following{/other_user}","gists_url":"https://api.github.com/users/kiich/gists{/gist_id}","starred_url":"https://api.github.com/users/kiich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiich/subscriptions","organizations_url":"https://api.github.com/users/kiich/orgs","repos_url":"https://api.github.com/users/kiich/repos","events_url":"https://api.github.com/users/kiich/events{/privacy}","received_events_url":"https://api.github.com/users/kiich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-23T14:52:14Z","updated_at":"2018-05-01T03:33:05Z","closed_at":null,"author_association":"NONE","body":"We created a node pool specifically to take advantage of [EBS-optimise](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSOptimized.html) so they are of instance type that has it on by default.\r\n\r\nHowever when we spin up a cluster, the AWS console shows the volume with no optimisation. Looking further into it, it looks like the Launch Configuration that creates the instances do not have the EBS optimised flag enabled and hence the instances created from the LC do not have it enabled neither.\r\n\r\nIf I just spin the instance via ec2 console, ebs is indeed enabled."},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/comments/385591265","html_url":"https://github.com/kubernetes-incubator/kube-aws/issues/1252#issuecomment-385591265","issue_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1252","id":385591265,"user":{"login":"mumoshu","id":22009,"avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T03:33:05Z","updated_at":"2018-05-01T03:33:05Z","author_association":"COLLABORATOR","body":"@kiich Thanks for the good catch! I do remember the last time I have literally seen the flag, but somehow overlooked to consider it for kube-aws...\r\n\r\nThis should be addresseds .\r\n\r\nProbably:\r\n\r\n- Adding a helper go func named like `EbsOptimized(instanceType string) bool` to return true when and only when the instance type is greater than `t2`, `m3`, and `c3` series.\r\n- And use the helper func inside stack-template.json for etcd, controller, worker nodes\r\n\r\nat minimum would work.\r\n"}}
{"actor":{"display_login":"mumoshu"}}