{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1356","repository_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1356/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1356/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1356/events","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1356","id":330211692,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjc0MDg4","number":1356,"title":"Promote compute reservation options [Small] ","user":{"login":"tyrannasaurusbanks","id":2912093,"node_id":"MDQ6VXNlcjI5MTIwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2912093?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannasaurusbanks","html_url":"https://github.com/tyrannasaurusbanks","followers_url":"https://api.github.com/users/tyrannasaurusbanks/followers","following_url":"https://api.github.com/users/tyrannasaurusbanks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannasaurusbanks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannasaurusbanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannasaurusbanks/subscriptions","organizations_url":"https://api.github.com/users/tyrannasaurusbanks/orgs","repos_url":"https://api.github.com/users/tyrannasaurusbanks/repos","events_url":"https://api.github.com/users/tyrannasaurusbanks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannasaurusbanks/received_events","type":"User","site_admin":false},"labels":[{"id":561748249,"node_id":"MDU6TGFiZWw1NjE3NDgyNDk=","url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":676074114,"node_id":"MDU6TGFiZWw2NzYwNzQxMTQ=","url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/size/M","name":"size/M","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/milestones/65","html_url":"https://github.com/kubernetes-incubator/kube-aws/milestone/65","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/milestones/65/labels","id":3336517,"node_id":"MDk6TWlsZXN0b25lMzMzNjUxNw==","number":65,"title":"v0.11.0","description":"","creator":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":43,"state":"open","created_at":"2018-05-10T16:36:51Z","updated_at":"2018-06-11T05:54:57Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-07T10:28:15Z","updated_at":"2018-06-11T08:37:22Z","closed_at":"2018-06-11T05:54:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1356","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1356","diff_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1356.diff","patch_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1356.patch"},"body":"### What\r\nI decided to PR back support to [reserve resources](https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/) to kube-aws.\r\nIf you want more background, the author of a related Kops PR does a fantastic job of documenting his journey/struggle with very similar issues to ours:\r\nhttps://github.com/kubernetes/kops/pull/2982\r\n\r\nI realise this is already been possible with $KUBELET_OPTS but believe the config options important enough to warrant being promoted to first class citizens to give them more visibility alongside the other kubelet config options.\r\n\r\n### Why\r\nWe’ve had problems with Docker daemons locking with loads of orphaned/dead containers lying around not being cleaned up - this is most definitely a docker daemon problem caused by our usage of old AMIs. \r\nDuring these investigations we noticed that some of our apps appear badly sized and doing some weird things on the hosts - things that are interfering with kube daemons and OS daemons, and could be mitigated by reserving resources.\r\n\r\n### Notes\r\n#### Defaults\r\nI thought I’d check Kops to see if they have any idea about sensible defaults but it appears they just took the values in the documentation (source: the author of the kops PR) - as such, I’ve chosen to\r\nnot set any default values, outside of just mentioning the kubernetes docs ones in the cluster.yaml comments.\r\nPlease shout if you feel like kube-aws should enforce some minimal ones.\r\n\r\n#### cgroups & enforcement\r\nI haven’t included —kube-reserved-cgroup or —system-reserved-cgroup options since I’m unsure if they apply right now to the way kube-aws's systemd units are structure. I’ve also left out —enforce-node-allocatable as that relies on the cgroup options being set.\r\nPlease shout If you’d like me to add them. "},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/comments/396165963","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1356#issuecomment-396165963","issue_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1356","id":396165963,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjE2NTk2Mw==","user":{"login":"tyrannasaurusbanks","id":2912093,"node_id":"MDQ6VXNlcjI5MTIwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2912093?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannasaurusbanks","html_url":"https://github.com/tyrannasaurusbanks","followers_url":"https://api.github.com/users/tyrannasaurusbanks/followers","following_url":"https://api.github.com/users/tyrannasaurusbanks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannasaurusbanks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannasaurusbanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannasaurusbanks/subscriptions","organizations_url":"https://api.github.com/users/tyrannasaurusbanks/orgs","repos_url":"https://api.github.com/users/tyrannasaurusbanks/repos","events_url":"https://api.github.com/users/tyrannasaurusbanks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannasaurusbanks/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T08:37:22Z","updated_at":"2018-06-11T08:37:22Z","author_association":"CONTRIBUTOR","body":"> > We’ve had problems with Docker daemons locking with loads of orphaned/dead containers lying around not being cleaned up\r\n\r\n> \r\n> Would some parts of this relate to what @c-knowles has been seeing for months #1300, by any chance? Just trying to understand and think of all the possibilities.\r\n\r\nJust read #1300 - I don't think so. Our kubelet issues present like [this node-flapping issue](https://github.com/kubernetes/kubernetes/issues/45419) and are only seen on workers when, over a prolonged period, either:\r\n - _A)_ a badly-sized pod constantly loops OOM\r\n - _B)_ a CronJob fires on one worker repeatedly. \r\n\r\nWe're not worried about either of these going forwards because:\r\n\r\n- occurrences of _A_ have all but stopped with newer CoreOS versions (1688.5.3+) and kube 1.9+ in our lab environments - we'll be rolling this out to a prod environments shortly.\r\n- our usage of Jobs in Kube is minimal and the current ones are deprecated. That said, we're watching [this issue](https://github.com/kubernetes/kubernetes/issues/64137) with interest as a link to _B_.\r\n\r\n> I greatly appreciate your detailed explanation about the feature.\r\n\r\nI greatly appreciate the fine work you're doing steering this project! \r\n"}}
{"actor":{"display_login":"tyrannasaurusbanks"}}