{"action":"created","comment":{"url":"https://api.github.com/repos/containernetworking/plugins/pulls/comments/217113858","pull_request_review_id":154751310,"id":217113858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzExMzg1OA==","diff_hunk":"@@ -0,0 +1,209 @@\n+// Copyright 2017 CNI authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package main\n+\n+import (\n+\t\"encoding/json\"\n+\t\"fmt\"\n+\t\"log\"\n+\t\"runtime\"\n+\t\"strings\"\n+\n+\t\"github.com/juju/errors\"\n+\n+\t\"github.com/Microsoft/hcsshim\"\n+\t\"github.com/containernetworking/cni/pkg/skel\"\n+\t\"github.com/containernetworking/cni/pkg/types\"\n+\t\"github.com/containernetworking/cni/pkg/types/current\"\n+\t\"github.com/containernetworking/cni/pkg/version\"\n+\t\"github.com/containernetworking/plugins/pkg/hns\"\n+\t\"github.com/containernetworking/plugins/pkg/ipam\"\n+)\n+\n+type NetConf struct {\n+\thns.NetConf\n+\n+\tIPMasq            bool   `json:\"ipMasq\"`\n+\tEndpointMacPrefix string `json:\"endpointMacPrefix,omitempty\"`","path":"plugins/main/windows/overlay/overlay_windows.go","position":39,"original_position":39,"commit_id":"ea2c3b6ca12766bbbb7dfddbbc304c495b0325aa","original_commit_id":"ea2c3b6ca12766bbbb7dfddbbc304c495b0325aa","user":{"login":"dineshgovindasamy","id":13801705,"node_id":"MDQ6VXNlcjEzODAxNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/13801705?v=4","gravatar_id":"","url":"https://api.github.com/users/dineshgovindasamy","html_url":"https://github.com/dineshgovindasamy","followers_url":"https://api.github.com/users/dineshgovindasamy/followers","following_url":"https://api.github.com/users/dineshgovindasamy/following{/other_user}","gists_url":"https://api.github.com/users/dineshgovindasamy/gists{/gist_id}","starred_url":"https://api.github.com/users/dineshgovindasamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dineshgovindasamy/subscriptions","organizations_url":"https://api.github.com/users/dineshgovindasamy/orgs","repos_url":"https://api.github.com/users/dineshgovindasamy/repos","events_url":"https://api.github.com/users/dineshgovindasamy/events{/privacy}","received_events_url":"https://api.github.com/users/dineshgovindasamy/received_events","type":"User","site_admin":false},"body":"Unfortunately in Windows our data plane doesn't support CA Learning i.e. inner MAC learning. So we have ARP interceptor that intercepts ARP and resolves them. so we communicate the Mapping using control plane.","created_at":"2018-09-12T17:04:50Z","updated_at":"2018-09-12T17:04:50Z","html_url":"https://github.com/containernetworking/plugins/pull/193#discussion_r217113858","pull_request_url":"https://api.github.com/repos/containernetworking/plugins/pulls/193","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/comments/217113858"},"html":{"href":"https://github.com/containernetworking/plugins/pull/193#discussion_r217113858"},"pull_request":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/193"}},"in_reply_to_id":217092009},"pull_request":{"url":"https://api.github.com/repos/containernetworking/plugins/pulls/193","id":210344739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzQ0NzM5","html_url":"https://github.com/containernetworking/plugins/pull/193","diff_url":"https://github.com/containernetworking/plugins/pull/193.diff","patch_url":"https://github.com/containernetworking/plugins/pull/193.patch","issue_url":"https://api.github.com/repos/containernetworking/plugins/issues/193","number":193,"state":"open","locked":false,"title":"Windows CNI support","user":{"login":"thxCode","id":3394724,"node_id":"MDQ6VXNlcjMzOTQ3MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"body":"A patch PR for https://github.com/containernetworking/plugins/pull/85 ","created_at":"2018-08-23T06:37:36Z","updated_at":"2018-09-12T17:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d95beed658a8b64ce1fd0eda34da51cd57f4f0a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/containernetworking/plugins/pulls/193/commits","review_comments_url":"https://api.github.com/repos/containernetworking/plugins/pulls/193/comments","review_comment_url":"https://api.github.com/repos/containernetworking/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containernetworking/plugins/issues/193/comments","statuses_url":"https://api.github.com/repos/containernetworking/plugins/statuses/ea2c3b6ca12766bbbb7dfddbbc304c495b0325aa","head":{"label":"thxCode:windows_cni","ref":"windows_cni","sha":"ea2c3b6ca12766bbbb7dfddbbc304c495b0325aa","user":{"login":"thxCode","id":3394724,"node_id":"MDQ6VXNlcjMzOTQ3MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"repo":{"id":144664109,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NjQxMDk=","name":"containernetworking-plugins","full_name":"thxCode/containernetworking-plugins","owner":{"login":"thxCode","id":3394724,"node_id":"MDQ6VXNlcjMzOTQ3MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thxCode/containernetworking-plugins","description":"Some standard networking plugins, maintained by the CNI team.","fork":true,"url":"https://api.github.com/repos/thxCode/containernetworking-plugins","forks_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/forks","keys_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/teams","hooks_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/hooks","issue_events_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/events","assignees_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/tags","blobs_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/languages","stargazers_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/stargazers","contributors_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/contributors","subscribers_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/subscribers","subscription_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/subscription","commits_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/merges","archive_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/downloads","issues_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/labels{/name}","releases_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/thxCode/containernetworking-plugins/deployments","created_at":"2018-08-14T03:33:39Z","updated_at":"2018-08-14T03:34:19Z","pushed_at":"2018-09-09T08:56:13Z","git_url":"git://github.com/thxCode/containernetworking-plugins.git","ssh_url":"git@github.com:thxCode/containernetworking-plugins.git","clone_url":"https://github.com/thxCode/containernetworking-plugins.git","svn_url":"https://github.com/thxCode/containernetworking-plugins","homepage":"","size":2886,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containernetworking:master","ref":"master","sha":"6a12a375cd1f27a6a5b5253fdb275658a60c3a5d","user":{"login":"containernetworking","id":18357459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzU3NDU5","avatar_url":"https://avatars2.githubusercontent.com/u/18357459?v=4","gravatar_id":"","url":"https://api.github.com/users/containernetworking","html_url":"https://github.com/containernetworking","followers_url":"https://api.github.com/users/containernetworking/followers","following_url":"https://api.github.com/users/containernetworking/following{/other_user}","gists_url":"https://api.github.com/users/containernetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/containernetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containernetworking/subscriptions","organizations_url":"https://api.github.com/users/containernetworking/orgs","repos_url":"https://api.github.com/users/containernetworking/repos","events_url":"https://api.github.com/users/containernetworking/events{/privacy}","received_events_url":"https://api.github.com/users/containernetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":84575398,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU3NTM5OA==","name":"plugins","full_name":"containernetworking/plugins","owner":{"login":"containernetworking","id":18357459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzU3NDU5","avatar_url":"https://avatars2.githubusercontent.com/u/18357459?v=4","gravatar_id":"","url":"https://api.github.com/users/containernetworking","html_url":"https://github.com/containernetworking","followers_url":"https://api.github.com/users/containernetworking/followers","following_url":"https://api.github.com/users/containernetworking/following{/other_user}","gists_url":"https://api.github.com/users/containernetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/containernetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containernetworking/subscriptions","organizations_url":"https://api.github.com/users/containernetworking/orgs","repos_url":"https://api.github.com/users/containernetworking/repos","events_url":"https://api.github.com/users/containernetworking/events{/privacy}","received_events_url":"https://api.github.com/users/containernetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containernetworking/plugins","description":"Some standard networking plugins, maintained by the CNI team.","fork":false,"url":"https://api.github.com/repos/containernetworking/plugins","forks_url":"https://api.github.com/repos/containernetworking/plugins/forks","keys_url":"https://api.github.com/repos/containernetworking/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containernetworking/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containernetworking/plugins/teams","hooks_url":"https://api.github.com/repos/containernetworking/plugins/hooks","issue_events_url":"https://api.github.com/repos/containernetworking/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/containernetworking/plugins/events","assignees_url":"https://api.github.com/repos/containernetworking/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/containernetworking/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/containernetworking/plugins/tags","blobs_url":"https://api.github.com/repos/containernetworking/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containernetworking/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containernetworking/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/containernetworking/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containernetworking/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/containernetworking/plugins/languages","stargazers_url":"https://api.github.com/repos/containernetworking/plugins/stargazers","contributors_url":"https://api.github.com/repos/containernetworking/plugins/contributors","subscribers_url":"https://api.github.com/repos/containernetworking/plugins/subscribers","subscription_url":"https://api.github.com/repos/containernetworking/plugins/subscription","commits_url":"https://api.github.com/repos/containernetworking/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/containernetworking/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/containernetworking/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/containernetworking/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/containernetworking/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/containernetworking/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containernetworking/plugins/merges","archive_url":"https://api.github.com/repos/containernetworking/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containernetworking/plugins/downloads","issues_url":"https://api.github.com/repos/containernetworking/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/containernetworking/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/containernetworking/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/containernetworking/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containernetworking/plugins/labels{/name}","releases_url":"https://api.github.com/repos/containernetworking/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/containernetworking/plugins/deployments","created_at":"2017-03-10T15:46:52Z","updated_at":"2018-09-12T16:51:57Z","pushed_at":"2018-09-12T16:50:05Z","git_url":"git://github.com/containernetworking/plugins.git","ssh_url":"git@github.com:containernetworking/plugins.git","clone_url":"https://github.com/containernetworking/plugins.git","svn_url":"https://github.com/containernetworking/plugins","homepage":"","size":2171,"stargazers_count":256,"watchers_count":256,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":152,"open_issues":52,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/193"},"html":{"href":"https://github.com/containernetworking/plugins/pull/193"},"issue":{"href":"https://api.github.com/repos/containernetworking/plugins/issues/193"},"comments":{"href":"https://api.github.com/repos/containernetworking/plugins/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containernetworking/plugins/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/containernetworking/plugins/statuses/ea2c3b6ca12766bbbb7dfddbbc304c495b0325aa"}},"author_association":"NONE"}}
{"actor":{"display_login":"dineshgovindasamy"}}