{"action":"created","comment":{"url":"https://api.github.com/repos/groupby/storefront-query/pulls/comments/222457834","pull_request_review_id":161302114,"id":222457834,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ1NzgzNA==","diff_hunk":"@@ -147,6 +148,17 @@ suite('SearchBox', ({ expect, spy, stub, itShouldConsumeAlias, itShouldProvideAl\n           expect(emit).to.be.calledWithExactly('sayt:show_recommendations');\n           expect(event.preventUpdate).to.be.true;\n         });\n+        it('should set preventUpdate and should not emit sayt:show_recommendations if is a value that is not an empty string', () => {\n+          const value = 'hula hoop';\n+          const event: any = { target: { value } };\n+          const emit = spy();\n+          searchBox.flux = <any>{ emit };\n+\n+          searchBox.state.onClick(event);\n+\n+          expect(emit).to.not.be.calledWithExactly('sayt:show_recommendations');","path":"test/unit/search-box.ts","position":24,"original_position":24,"commit_id":"94005a0fbf9d2486dff52cc61fe4d136aef68ed2","original_commit_id":"94005a0fbf9d2486dff52cc61fe4d136aef68ed2","user":{"login":"jmbtutor","id":16546385,"node_id":"MDQ6VXNlcjE2NTQ2Mzg1","avatar_url":"https://avatars3.githubusercontent.com/u/16546385?v=4","gravatar_id":"","url":"https://api.github.com/users/jmbtutor","html_url":"https://github.com/jmbtutor","followers_url":"https://api.github.com/users/jmbtutor/followers","following_url":"https://api.github.com/users/jmbtutor/following{/other_user}","gists_url":"https://api.github.com/users/jmbtutor/gists{/gist_id}","starred_url":"https://api.github.com/users/jmbtutor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmbtutor/subscriptions","organizations_url":"https://api.github.com/users/jmbtutor/orgs","repos_url":"https://api.github.com/users/jmbtutor/repos","events_url":"https://api.github.com/users/jmbtutor/events{/privacy}","received_events_url":"https://api.github.com/users/jmbtutor/received_events","type":"User","site_admin":false},"body":"You should expect that it isn't called at all:\r\n```js\r\nexpect(emit).not.to.be.called;\r\n```","created_at":"2018-10-03T20:34:00Z","updated_at":"2018-10-03T20:39:14Z","html_url":"https://github.com/groupby/storefront-query/pull/46#discussion_r222457834","pull_request_url":"https://api.github.com/repos/groupby/storefront-query/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/comments/222457834"},"html":{"href":"https://github.com/groupby/storefront-query/pull/46#discussion_r222457834"},"pull_request":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/groupby/storefront-query/pulls/46","id":219792096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzkyMDk2","html_url":"https://github.com/groupby/storefront-query/pull/46","diff_url":"https://github.com/groupby/storefront-query/pull/46.diff","patch_url":"https://github.com/groupby/storefront-query/pull/46.patch","issue_url":"https://api.github.com/repos/groupby/storefront-query/issues/46","number":46,"state":"open","locked":false,"title":"SF-1119 Updating searchBox to register itself onBeforeMount when the prop showSayt is true.","user":{"login":"JoeyDeol","id":35696810,"node_id":"MDQ6VXNlcjM1Njk2ODEw","avatar_url":"https://avatars3.githubusercontent.com/u/35696810?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeyDeol","html_url":"https://github.com/JoeyDeol","followers_url":"https://api.github.com/users/JoeyDeol/followers","following_url":"https://api.github.com/users/JoeyDeol/following{/other_user}","gists_url":"https://api.github.com/users/JoeyDeol/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeyDeol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeyDeol/subscriptions","organizations_url":"https://api.github.com/users/JoeyDeol/orgs","repos_url":"https://api.github.com/users/JoeyDeol/repos","events_url":"https://api.github.com/users/JoeyDeol/events{/privacy}","received_events_url":"https://api.github.com/users/JoeyDeol/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T17:56:28Z","updated_at":"2018-10-03T20:39:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5af24facce78f97481adefd35eace2e8b7dfb17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/groupby/storefront-query/pulls/46/commits","review_comments_url":"https://api.github.com/repos/groupby/storefront-query/pulls/46/comments","review_comment_url":"https://api.github.com/repos/groupby/storefront-query/pulls/comments{/number}","comments_url":"https://api.github.com/repos/groupby/storefront-query/issues/46/comments","statuses_url":"https://api.github.com/repos/groupby/storefront-query/statuses/94005a0fbf9d2486dff52cc61fe4d136aef68ed2","head":{"label":"groupby:SF-1119","ref":"SF-1119","sha":"94005a0fbf9d2486dff52cc61fe4d136aef68ed2","user":{"login":"groupby","id":2799385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTkzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2799385?v=4","gravatar_id":"","url":"https://api.github.com/users/groupby","html_url":"https://github.com/groupby","followers_url":"https://api.github.com/users/groupby/followers","following_url":"https://api.github.com/users/groupby/following{/other_user}","gists_url":"https://api.github.com/users/groupby/gists{/gist_id}","starred_url":"https://api.github.com/users/groupby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupby/subscriptions","organizations_url":"https://api.github.com/users/groupby/orgs","repos_url":"https://api.github.com/users/groupby/repos","events_url":"https://api.github.com/users/groupby/events{/privacy}","received_events_url":"https://api.github.com/users/groupby/received_events","type":"Organization","site_admin":false},"repo":{"id":91026512,"node_id":"MDEwOlJlcG9zaXRvcnk5MTAyNjUxMg==","name":"storefront-query","full_name":"groupby/storefront-query","private":false,"owner":{"login":"groupby","id":2799385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTkzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2799385?v=4","gravatar_id":"","url":"https://api.github.com/users/groupby","html_url":"https://github.com/groupby","followers_url":"https://api.github.com/users/groupby/followers","following_url":"https://api.github.com/users/groupby/following{/other_user}","gists_url":"https://api.github.com/users/groupby/gists{/gist_id}","starred_url":"https://api.github.com/users/groupby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupby/subscriptions","organizations_url":"https://api.github.com/users/groupby/orgs","repos_url":"https://api.github.com/users/groupby/repos","events_url":"https://api.github.com/users/groupby/events{/privacy}","received_events_url":"https://api.github.com/users/groupby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/groupby/storefront-query","description":"StoreFront query component","fork":false,"url":"https://api.github.com/repos/groupby/storefront-query","forks_url":"https://api.github.com/repos/groupby/storefront-query/forks","keys_url":"https://api.github.com/repos/groupby/storefront-query/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupby/storefront-query/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupby/storefront-query/teams","hooks_url":"https://api.github.com/repos/groupby/storefront-query/hooks","issue_events_url":"https://api.github.com/repos/groupby/storefront-query/issues/events{/number}","events_url":"https://api.github.com/repos/groupby/storefront-query/events","assignees_url":"https://api.github.com/repos/groupby/storefront-query/assignees{/user}","branches_url":"https://api.github.com/repos/groupby/storefront-query/branches{/branch}","tags_url":"https://api.github.com/repos/groupby/storefront-query/tags","blobs_url":"https://api.github.com/repos/groupby/storefront-query/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupby/storefront-query/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupby/storefront-query/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupby/storefront-query/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupby/storefront-query/statuses/{sha}","languages_url":"https://api.github.com/repos/groupby/storefront-query/languages","stargazers_url":"https://api.github.com/repos/groupby/storefront-query/stargazers","contributors_url":"https://api.github.com/repos/groupby/storefront-query/contributors","subscribers_url":"https://api.github.com/repos/groupby/storefront-query/subscribers","subscription_url":"https://api.github.com/repos/groupby/storefront-query/subscription","commits_url":"https://api.github.com/repos/groupby/storefront-query/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupby/storefront-query/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupby/storefront-query/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupby/storefront-query/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupby/storefront-query/contents/{+path}","compare_url":"https://api.github.com/repos/groupby/storefront-query/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupby/storefront-query/merges","archive_url":"https://api.github.com/repos/groupby/storefront-query/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupby/storefront-query/downloads","issues_url":"https://api.github.com/repos/groupby/storefront-query/issues{/number}","pulls_url":"https://api.github.com/repos/groupby/storefront-query/pulls{/number}","milestones_url":"https://api.github.com/repos/groupby/storefront-query/milestones{/number}","notifications_url":"https://api.github.com/repos/groupby/storefront-query/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupby/storefront-query/labels{/name}","releases_url":"https://api.github.com/repos/groupby/storefront-query/releases{/id}","deployments_url":"https://api.github.com/repos/groupby/storefront-query/deployments","created_at":"2017-05-11T21:51:47Z","updated_at":"2018-09-18T15:43:27Z","pushed_at":"2018-10-03T17:07:30Z","git_url":"git://github.com/groupby/storefront-query.git","ssh_url":"git@github.com:groupby/storefront-query.git","clone_url":"https://github.com/groupby/storefront-query.git","svn_url":"https://github.com/groupby/storefront-query","homepage":null,"size":466,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"groupby:master","ref":"master","sha":"3174190bfb723d6b096898fb206c9e1496f7944a","user":{"login":"groupby","id":2799385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTkzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2799385?v=4","gravatar_id":"","url":"https://api.github.com/users/groupby","html_url":"https://github.com/groupby","followers_url":"https://api.github.com/users/groupby/followers","following_url":"https://api.github.com/users/groupby/following{/other_user}","gists_url":"https://api.github.com/users/groupby/gists{/gist_id}","starred_url":"https://api.github.com/users/groupby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupby/subscriptions","organizations_url":"https://api.github.com/users/groupby/orgs","repos_url":"https://api.github.com/users/groupby/repos","events_url":"https://api.github.com/users/groupby/events{/privacy}","received_events_url":"https://api.github.com/users/groupby/received_events","type":"Organization","site_admin":false},"repo":{"id":91026512,"node_id":"MDEwOlJlcG9zaXRvcnk5MTAyNjUxMg==","name":"storefront-query","full_name":"groupby/storefront-query","private":false,"owner":{"login":"groupby","id":2799385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTkzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2799385?v=4","gravatar_id":"","url":"https://api.github.com/users/groupby","html_url":"https://github.com/groupby","followers_url":"https://api.github.com/users/groupby/followers","following_url":"https://api.github.com/users/groupby/following{/other_user}","gists_url":"https://api.github.com/users/groupby/gists{/gist_id}","starred_url":"https://api.github.com/users/groupby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupby/subscriptions","organizations_url":"https://api.github.com/users/groupby/orgs","repos_url":"https://api.github.com/users/groupby/repos","events_url":"https://api.github.com/users/groupby/events{/privacy}","received_events_url":"https://api.github.com/users/groupby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/groupby/storefront-query","description":"StoreFront query component","fork":false,"url":"https://api.github.com/repos/groupby/storefront-query","forks_url":"https://api.github.com/repos/groupby/storefront-query/forks","keys_url":"https://api.github.com/repos/groupby/storefront-query/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupby/storefront-query/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupby/storefront-query/teams","hooks_url":"https://api.github.com/repos/groupby/storefront-query/hooks","issue_events_url":"https://api.github.com/repos/groupby/storefront-query/issues/events{/number}","events_url":"https://api.github.com/repos/groupby/storefront-query/events","assignees_url":"https://api.github.com/repos/groupby/storefront-query/assignees{/user}","branches_url":"https://api.github.com/repos/groupby/storefront-query/branches{/branch}","tags_url":"https://api.github.com/repos/groupby/storefront-query/tags","blobs_url":"https://api.github.com/repos/groupby/storefront-query/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupby/storefront-query/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupby/storefront-query/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupby/storefront-query/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupby/storefront-query/statuses/{sha}","languages_url":"https://api.github.com/repos/groupby/storefront-query/languages","stargazers_url":"https://api.github.com/repos/groupby/storefront-query/stargazers","contributors_url":"https://api.github.com/repos/groupby/storefront-query/contributors","subscribers_url":"https://api.github.com/repos/groupby/storefront-query/subscribers","subscription_url":"https://api.github.com/repos/groupby/storefront-query/subscription","commits_url":"https://api.github.com/repos/groupby/storefront-query/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupby/storefront-query/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupby/storefront-query/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupby/storefront-query/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupby/storefront-query/contents/{+path}","compare_url":"https://api.github.com/repos/groupby/storefront-query/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupby/storefront-query/merges","archive_url":"https://api.github.com/repos/groupby/storefront-query/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupby/storefront-query/downloads","issues_url":"https://api.github.com/repos/groupby/storefront-query/issues{/number}","pulls_url":"https://api.github.com/repos/groupby/storefront-query/pulls{/number}","milestones_url":"https://api.github.com/repos/groupby/storefront-query/milestones{/number}","notifications_url":"https://api.github.com/repos/groupby/storefront-query/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupby/storefront-query/labels{/name}","releases_url":"https://api.github.com/repos/groupby/storefront-query/releases{/id}","deployments_url":"https://api.github.com/repos/groupby/storefront-query/deployments","created_at":"2017-05-11T21:51:47Z","updated_at":"2018-09-18T15:43:27Z","pushed_at":"2018-10-03T17:07:30Z","git_url":"git://github.com/groupby/storefront-query.git","ssh_url":"git@github.com:groupby/storefront-query.git","clone_url":"https://github.com/groupby/storefront-query.git","svn_url":"https://github.com/groupby/storefront-query","homepage":null,"size":466,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/46"},"html":{"href":"https://github.com/groupby/storefront-query/pull/46"},"issue":{"href":"https://api.github.com/repos/groupby/storefront-query/issues/46"},"comments":{"href":"https://api.github.com/repos/groupby/storefront-query/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/groupby/storefront-query/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/groupby/storefront-query/statuses/94005a0fbf9d2486dff52cc61fe4d136aef68ed2"}},"author_association":"NONE"}}
{"actor":{"display_login":"jmbtutor"}}