{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/helium/gateway-config/pulls/2","id":231820483,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODIwNDgz","html_url":"https://github.com/helium/gateway-config/pull/2","diff_url":"https://github.com/helium/gateway-config/pull/2.diff","patch_url":"https://github.com/helium/gateway-config/pull/2.patch","issue_url":"https://api.github.com/repos/helium/gateway-config/issues/2","number":2,"state":"closed","locked":false,"title":"Add remaining GATT characteristics","user":{"login":"fvasquez","id":905410,"node_id":"MDQ6VXNlcjkwNTQxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/905410?v=4","gravatar_id":"","url":"https://api.github.com/users/fvasquez","html_url":"https://github.com/fvasquez","followers_url":"https://api.github.com/users/fvasquez/followers","following_url":"https://api.github.com/users/fvasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvasquez/subscriptions","organizations_url":"https://api.github.com/users/fvasquez/orgs","repos_url":"https://api.github.com/users/fvasquez/repos","events_url":"https://api.github.com/users/fvasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvasquez/received_events","type":"User","site_admin":false},"body":"Verified their visibility on BBB Wireless pseudo hotspot using `gatttool`.\r\n\r\n```\r\nfrank@telescope:~$ sudo gatttool -b 40:BD:32:87:1B:98 -I\r\n[40:BD:32:87:1B:98][LE]> connect\r\nAttempting to connect to 40:BD:32:87:1B:98\r\nConnection successful\r\n[40:BD:32:87:1B:98][LE]> primary\r\nattr handle: 0x0001, end grp handle: 0x0005 uuid: 00001800-0000-1000-8000-00805f9b34fb\r\nattr handle: 0x0006, end grp handle: 0x0009 uuid: 00001801-0000-1000-8000-00805f9b34fb\r\nattr handle: 0x000a, end grp handle: 0x0020 uuid: 0fda92b2-44a2-4af2-84f5-fa682baa2b8d\r\n[40:BD:32:87:1B:98][LE]> char-desc\r\nhandle: 0x0001, uuid: 00002800-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0002, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0003, uuid: 00002a00-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0004, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0005, uuid: 00002a01-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0006, uuid: 00002800-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0007, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0008, uuid: 00002a05-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0009, uuid: 00002902-0000-1000-8000-00805f9b34fb\r\nhandle: 0x000a, uuid: 00002800-0000-1000-8000-00805f9b34fb\r\nhandle: 0x000b, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x000c, uuid: 0b551e81-0803-4eb9-8642-df7e463d23d4\r\nhandle: 0x000d, uuid: 00002902-0000-1000-8000-00805f9b34fb\r\nhandle: 0x000e, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\nhandle: 0x000f, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0010, uuid: 7731de63-bc6a-4100-8ab1-89b2356b038b\r\nhandle: 0x0011, uuid: 00002902-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0012, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0013, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0014, uuid: fae053d1-fa80-4355-a8c0-722ae64f5255\r\nhandle: 0x0015, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0016, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0017, uuid: c94f3fc2-c27f-4342-818a-4fe9982d0d5a\r\nhandle: 0x0018, uuid: 00002902-0000-1000-8000-00805f9b34fb\r\nhandle: 0x0019, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\nhandle: 0x001a, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x001b, uuid: b95aadc6-a951-425c-882b-bea7daa396d1\r\nhandle: 0x001c, uuid: 00002902-0000-1000-8000-00805f9b34fb\r\nhandle: 0x001d, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\nhandle: 0x001e, uuid: 00002803-0000-1000-8000-00805f9b34fb\r\nhandle: 0x001f, uuid: 784df6fa-37c4-4e6d-b1c4-cfb47333bc03\r\nhandle: 0x0020, uuid: 00002901-0000-1000-8000-00805f9b34fb\r\n[40:BD:32:87:1B:98][LE]> char-read-hnd 0x0017\r\nCharacteristic value/descriptor: 75 6e 6b 6e 6f 77 6e \r\n[40:BD:32:87:1B:98][LE]> char-read-hnd 0x001b\r\nCharacteristic value/descriptor: 70 61 73 73 \r\n[40:BD:32:87:1B:98][LE]> char-read-hnd 0x001f\r\nError: Characteristic value/descriptor read failed: Attribute can't be read\r\n```\r\n\r\n`UUID_GATEWAY_GATT_CHAR_QR_CODE` is write-only just like `UUID_GATEWAY_GATT_CHAR_WIFI_PASS`.\r\n\r\n`UUID_GATEWAY_GATT_CHAR_LED_MATCH_STATUS` defaults to \"pass\" so LED challenge is disabled.","created_at":"2018-11-18T22:53:40Z","updated_at":"2018-11-20T20:17:28Z","closed_at":"2018-11-20T20:17:28Z","merged_at":"2018-11-20T20:17:27Z","merge_commit_sha":"2916427be1bb97cee1a3dc541238d4f270c912b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/helium/gateway-config/pulls/2/commits","review_comments_url":"https://api.github.com/repos/helium/gateway-config/pulls/2/comments","review_comment_url":"https://api.github.com/repos/helium/gateway-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helium/gateway-config/issues/2/comments","statuses_url":"https://api.github.com/repos/helium/gateway-config/statuses/b16209f37c141cae35882324f8aae53edadf960b","head":{"label":"helium:release","ref":"release","sha":"b16209f37c141cae35882324f8aae53edadf960b","user":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":152754579,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NTQ1Nzk=","name":"gateway-config","full_name":"helium/gateway-config","private":false,"owner":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helium/gateway-config","description":"The Helium configuration application. Enables configuring the Helium Hotspot over Bluetooth","fork":false,"url":"https://api.github.com/repos/helium/gateway-config","forks_url":"https://api.github.com/repos/helium/gateway-config/forks","keys_url":"https://api.github.com/repos/helium/gateway-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/gateway-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/gateway-config/teams","hooks_url":"https://api.github.com/repos/helium/gateway-config/hooks","issue_events_url":"https://api.github.com/repos/helium/gateway-config/issues/events{/number}","events_url":"https://api.github.com/repos/helium/gateway-config/events","assignees_url":"https://api.github.com/repos/helium/gateway-config/assignees{/user}","branches_url":"https://api.github.com/repos/helium/gateway-config/branches{/branch}","tags_url":"https://api.github.com/repos/helium/gateway-config/tags","blobs_url":"https://api.github.com/repos/helium/gateway-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/gateway-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/gateway-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/gateway-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/gateway-config/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/gateway-config/languages","stargazers_url":"https://api.github.com/repos/helium/gateway-config/stargazers","contributors_url":"https://api.github.com/repos/helium/gateway-config/contributors","subscribers_url":"https://api.github.com/repos/helium/gateway-config/subscribers","subscription_url":"https://api.github.com/repos/helium/gateway-config/subscription","commits_url":"https://api.github.com/repos/helium/gateway-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/gateway-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/gateway-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/gateway-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/gateway-config/contents/{+path}","compare_url":"https://api.github.com/repos/helium/gateway-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/gateway-config/merges","archive_url":"https://api.github.com/repos/helium/gateway-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/gateway-config/downloads","issues_url":"https://api.github.com/repos/helium/gateway-config/issues{/number}","pulls_url":"https://api.github.com/repos/helium/gateway-config/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/gateway-config/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/gateway-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/gateway-config/labels{/name}","releases_url":"https://api.github.com/repos/helium/gateway-config/releases{/id}","deployments_url":"https://api.github.com/repos/helium/gateway-config/deployments","created_at":"2018-10-12T13:27:39Z","updated_at":"2018-11-19T22:38:24Z","pushed_at":"2018-11-20T20:17:27Z","git_url":"git://github.com/helium/gateway-config.git","ssh_url":"git@github.com:helium/gateway-config.git","clone_url":"https://github.com/helium/gateway-config.git","svn_url":"https://github.com/helium/gateway-config","homepage":null,"size":706,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"helium:master","ref":"master","sha":"c759fa3f948329124096c116a5d9c7d919953ae1","user":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":152754579,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NTQ1Nzk=","name":"gateway-config","full_name":"helium/gateway-config","private":false,"owner":{"login":"helium","id":6635330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzUzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helium/gateway-config","description":"The Helium configuration application. Enables configuring the Helium Hotspot over Bluetooth","fork":false,"url":"https://api.github.com/repos/helium/gateway-config","forks_url":"https://api.github.com/repos/helium/gateway-config/forks","keys_url":"https://api.github.com/repos/helium/gateway-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/gateway-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/gateway-config/teams","hooks_url":"https://api.github.com/repos/helium/gateway-config/hooks","issue_events_url":"https://api.github.com/repos/helium/gateway-config/issues/events{/number}","events_url":"https://api.github.com/repos/helium/gateway-config/events","assignees_url":"https://api.github.com/repos/helium/gateway-config/assignees{/user}","branches_url":"https://api.github.com/repos/helium/gateway-config/branches{/branch}","tags_url":"https://api.github.com/repos/helium/gateway-config/tags","blobs_url":"https://api.github.com/repos/helium/gateway-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/gateway-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/gateway-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/gateway-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/gateway-config/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/gateway-config/languages","stargazers_url":"https://api.github.com/repos/helium/gateway-config/stargazers","contributors_url":"https://api.github.com/repos/helium/gateway-config/contributors","subscribers_url":"https://api.github.com/repos/helium/gateway-config/subscribers","subscription_url":"https://api.github.com/repos/helium/gateway-config/subscription","commits_url":"https://api.github.com/repos/helium/gateway-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/gateway-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/gateway-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/gateway-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/gateway-config/contents/{+path}","compare_url":"https://api.github.com/repos/helium/gateway-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/gateway-config/merges","archive_url":"https://api.github.com/repos/helium/gateway-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/gateway-config/downloads","issues_url":"https://api.github.com/repos/helium/gateway-config/issues{/number}","pulls_url":"https://api.github.com/repos/helium/gateway-config/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/gateway-config/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/gateway-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/gateway-config/labels{/name}","releases_url":"https://api.github.com/repos/helium/gateway-config/releases{/id}","deployments_url":"https://api.github.com/repos/helium/gateway-config/deployments","created_at":"2018-10-12T13:27:39Z","updated_at":"2018-11-19T22:38:24Z","pushed_at":"2018-11-20T20:17:27Z","git_url":"git://github.com/helium/gateway-config.git","ssh_url":"git@github.com:helium/gateway-config.git","clone_url":"https://github.com/helium/gateway-config.git","svn_url":"https://github.com/helium/gateway-config","homepage":null,"size":706,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helium/gateway-config/pulls/2"},"html":{"href":"https://github.com/helium/gateway-config/pull/2"},"issue":{"href":"https://api.github.com/repos/helium/gateway-config/issues/2"},"comments":{"href":"https://api.github.com/repos/helium/gateway-config/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/helium/gateway-config/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/helium/gateway-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helium/gateway-config/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/helium/gateway-config/statuses/b16209f37c141cae35882324f8aae53edadf960b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"madninja","id":11398,"node_id":"MDQ6VXNlcjExMzk4","avatar_url":"https://avatars3.githubusercontent.com/u/11398?v=4","gravatar_id":"","url":"https://api.github.com/users/madninja","html_url":"https://github.com/madninja","followers_url":"https://api.github.com/users/madninja/followers","following_url":"https://api.github.com/users/madninja/following{/other_user}","gists_url":"https://api.github.com/users/madninja/gists{/gist_id}","starred_url":"https://api.github.com/users/madninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madninja/subscriptions","organizations_url":"https://api.github.com/users/madninja/orgs","repos_url":"https://api.github.com/users/madninja/repos","events_url":"https://api.github.com/users/madninja/events{/privacy}","received_events_url":"https://api.github.com/users/madninja/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":12,"additions":159,"deletions":2,"changed_files":7}}
{"actor":{"display_login":"madninja"}}