{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/10334","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10334/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10334/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10334/events","html_url":"https://github.com/mozilla/pdf.js/pull/10334","id":387917692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzAwODU5","number":10334,"title":"[api-minor] Add support for OpenAction destinations (issue 10332)","user":{"login":"Snuffleupagus","id":2692120,"node_id":"MDQ6VXNlcjI2OTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"labels":[{"id":164428,"node_id":"MDU6TGFiZWwxNjQ0Mjg=","url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-core","name":"1-core","color":"DDDDDD","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-05T19:49:45Z","updated_at":"2018-12-18T22:49:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10334","html_url":"https://github.com/mozilla/pdf.js/pull/10334","diff_url":"https://github.com/mozilla/pdf.js/pull/10334.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/10334.patch"},"body":"Note that the OpenAction dictionary may contain other information besides just a destination array, e.g. instructions for auto-printing[1].\r\nGiven first of all that an arbitrary `Dict` cannot be sent from the Worker (since cloning would fail), and second of all that the data obviously needs to be validated, this patch purposely only adds support for fetching a destination from the OpenAction entry[2].\r\n\r\n~~For the time being support for this isn't added to the default viewer, since it's really not clear to me if that's desired functionality. Furthermore, actually implementing this will require (some kind of) re-factoring of the `PDFHistory` initialization to prevent odd initial history state.~~\r\n\r\n---\r\n[1] This information is, currently in PDF.js, being included through the `getJavaScript` API method.\r\n\r\n[2] This significantly reduces the complexity of the implementation, which seems fine for now. If there's ever need for other kinds of OpenAction to be fetched, additional API methods could/should be implemented as necessary (could e.g. follow the `getOpenActionWhatever` naming scheme)."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/448401103","html_url":"https://github.com/mozilla/pdf.js/pull/10334#issuecomment-448401103","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10334","id":448401103,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQwMTEwMw==","user":{"login":"pdfjsbot","id":1036361,"node_id":"MDQ6VXNlcjEwMzYzNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1036361?v=4","gravatar_id":"","url":"https://api.github.com/users/pdfjsbot","html_url":"https://github.com/pdfjsbot","followers_url":"https://api.github.com/users/pdfjsbot/followers","following_url":"https://api.github.com/users/pdfjsbot/following{/other_user}","gists_url":"https://api.github.com/users/pdfjsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pdfjsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdfjsbot/subscriptions","organizations_url":"https://api.github.com/users/pdfjsbot/orgs","repos_url":"https://api.github.com/users/pdfjsbot/repos","events_url":"https://api.github.com/users/pdfjsbot/events{/privacy}","received_events_url":"https://api.github.com/users/pdfjsbot/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T22:49:01Z","updated_at":"2018-12-18T22:49:01Z","author_association":"COLLABORATOR","body":"#### From: Bot.io (Linux m4)\n\n----\n\n# Success\n\nFull output at http://54.67.70.0:8877/c13c694cc901d58/output.txt\n\nTotal script time: 17.82 mins\n\n+ **Font tests:** Passed\n+ **Unit tests:** Passed\n+ **Regression tests:** Passed"}}
{"actor":{"display_login":"pdfjsbot"}}