{"action":"created","comment":{"url":"https://api.github.com/repos/bobthecow/psysh/pulls/comments/186273925","pull_request_review_id":117826592,"id":186273925,"diff_hunk":"@@ -0,0 +1,86 @@\n+.DEFAULT_GOAL := help\n+\n+PSYSH_SRC = bin src box.json.dist composer.json composer.lock build/stub\n+\n+.PHONY: help\n+help:\n+\t@fgrep -h \"##\" $(MAKEFILE_LIST) | fgrep -v fgrep | sed -e 's/\\\\$$//' | sed -e 's/##//'\n+\n+\n+##\n+## Commands\n+##---------------------------------------------------------------------------\n+\n+clean: \t ## Clean all created artifacts\n+.PHONY: clean\n+clean:\n+\trm -rf build/\n+\n+\n+build: ## Compile the application into the PHAR\n+.PHONY: build\n+build: build/psysh.phar build/psysh-compat.phar build/psysh-php54.phar build/psysh-php54-compat.phar","path":"Makefile","position":22,"original_position":22,"commit_id":"4e2eb01e4cf0647ce1d2e73c072c0f35317113ca","original_commit_id":"ae751463e7f3ce78b25ce535cff1ccd907a169ef","user":{"login":"bobthecow","id":53660,"avatar_url":"https://avatars1.githubusercontent.com/u/53660?v=4","gravatar_id":"","url":"https://api.github.com/users/bobthecow","html_url":"https://github.com/bobthecow","followers_url":"https://api.github.com/users/bobthecow/followers","following_url":"https://api.github.com/users/bobthecow/following{/other_user}","gists_url":"https://api.github.com/users/bobthecow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobthecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobthecow/subscriptions","organizations_url":"https://api.github.com/users/bobthecow/orgs","repos_url":"https://api.github.com/users/bobthecow/repos","events_url":"https://api.github.com/users/bobthecow/events{/privacy}","received_events_url":"https://api.github.com/users/bobthecow/received_events","type":"User","site_admin":false},"body":"I think I tried building on 7.2, 7.1 and 7.0, and the one that worked most consistently across PHP versions was 7.0. Let's keep that, for now, and possibly bump it later.","created_at":"2018-05-05T22:40:12Z","updated_at":"2018-05-05T22:40:12Z","html_url":"https://github.com/bobthecow/psysh/pull/488#discussion_r186273925","pull_request_url":"https://api.github.com/repos/bobthecow/psysh/pulls/488","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/comments/186273925"},"html":{"href":"https://github.com/bobthecow/psysh/pull/488#discussion_r186273925"},"pull_request":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/488"}},"in_reply_to_id":186261860},"pull_request":{"url":"https://api.github.com/repos/bobthecow/psysh/pulls/488","id":184257033,"html_url":"https://github.com/bobthecow/psysh/pull/488","diff_url":"https://github.com/bobthecow/psysh/pull/488.diff","patch_url":"https://github.com/bobthecow/psysh/pull/488.patch","issue_url":"https://api.github.com/repos/bobthecow/psysh/issues/488","number":488,"state":"open","locked":false,"title":"Switch to Box","user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"body":"As promised somewhere, here's the PR to switch to [Box](https://github.com/humbug/box/issues/19) to build the PHAR.\r\n\r\nI used a `Makefile` here because I would like to propose it as a new tool instead of the bash files. Indeed in think it has a few advantages:\r\n\r\n- There is a better discoverability of the available commands\r\n- It is easier to declare dependencies and achieve that `make smth` and it will just work experience, all the necessary stuff will be installed for you.\r\n\r\nAs an example, clone the project and type `make build` and it will just work: no need to concern yourself with installing the dependencies & co.\r\n\r\nThere is still stuff to improve in this PR (or can be done in another):\r\n\r\n- [x] Build all the PHARs: I see that you have a dedicated compat and PHP 5.4 files, those are still missing\r\n- [ ] Add an e2e tests for the PHARs, eventually via Docker for the old PHP versions. Building a PHAR is not a trivial process the code may easily break in it\r\n- [ ] Isolate the PHAR, to be done in another PR I think\r\n\r\nFor reference the PHAR you are publishing is 1.4MB (from the last release). The one built with Box is `649.59KB` so it's a nice improvement 😄 \r\n\r\nI'm also not sure to understand why we are using the local autoload when inside the PsySH project?","created_at":"2018-04-26T08:06:06Z","updated_at":"2018-05-05T22:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3ef8adc9c999ff390ba91d8d0de384fbd0d2683","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bobthecow/psysh/pulls/488/commits","review_comments_url":"https://api.github.com/repos/bobthecow/psysh/pulls/488/comments","review_comment_url":"https://api.github.com/repos/bobthecow/psysh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bobthecow/psysh/issues/488/comments","statuses_url":"https://api.github.com/repos/bobthecow/psysh/statuses/4e2eb01e4cf0647ce1d2e73c072c0f35317113ca","head":{"label":"theofidry:feature/box","ref":"feature/box","sha":"4e2eb01e4cf0647ce1d2e73c072c0f35317113ca","user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"repo":{"id":131118683,"name":"psysh","full_name":"theofidry/psysh","owner":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theofidry/psysh","description":"A REPL for PHP","fork":true,"url":"https://api.github.com/repos/theofidry/psysh","forks_url":"https://api.github.com/repos/theofidry/psysh/forks","keys_url":"https://api.github.com/repos/theofidry/psysh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theofidry/psysh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theofidry/psysh/teams","hooks_url":"https://api.github.com/repos/theofidry/psysh/hooks","issue_events_url":"https://api.github.com/repos/theofidry/psysh/issues/events{/number}","events_url":"https://api.github.com/repos/theofidry/psysh/events","assignees_url":"https://api.github.com/repos/theofidry/psysh/assignees{/user}","branches_url":"https://api.github.com/repos/theofidry/psysh/branches{/branch}","tags_url":"https://api.github.com/repos/theofidry/psysh/tags","blobs_url":"https://api.github.com/repos/theofidry/psysh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theofidry/psysh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theofidry/psysh/git/refs{/sha}","trees_url":"https://api.github.com/repos/theofidry/psysh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theofidry/psysh/statuses/{sha}","languages_url":"https://api.github.com/repos/theofidry/psysh/languages","stargazers_url":"https://api.github.com/repos/theofidry/psysh/stargazers","contributors_url":"https://api.github.com/repos/theofidry/psysh/contributors","subscribers_url":"https://api.github.com/repos/theofidry/psysh/subscribers","subscription_url":"https://api.github.com/repos/theofidry/psysh/subscription","commits_url":"https://api.github.com/repos/theofidry/psysh/commits{/sha}","git_commits_url":"https://api.github.com/repos/theofidry/psysh/git/commits{/sha}","comments_url":"https://api.github.com/repos/theofidry/psysh/comments{/number}","issue_comment_url":"https://api.github.com/repos/theofidry/psysh/issues/comments{/number}","contents_url":"https://api.github.com/repos/theofidry/psysh/contents/{+path}","compare_url":"https://api.github.com/repos/theofidry/psysh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theofidry/psysh/merges","archive_url":"https://api.github.com/repos/theofidry/psysh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theofidry/psysh/downloads","issues_url":"https://api.github.com/repos/theofidry/psysh/issues{/number}","pulls_url":"https://api.github.com/repos/theofidry/psysh/pulls{/number}","milestones_url":"https://api.github.com/repos/theofidry/psysh/milestones{/number}","notifications_url":"https://api.github.com/repos/theofidry/psysh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theofidry/psysh/labels{/name}","releases_url":"https://api.github.com/repos/theofidry/psysh/releases{/id}","deployments_url":"https://api.github.com/repos/theofidry/psysh/deployments","created_at":"2018-04-26T07:41:22Z","updated_at":"2018-04-26T07:41:24Z","pushed_at":"2018-05-05T13:09:47Z","git_url":"git://github.com/theofidry/psysh.git","ssh_url":"git@github.com:theofidry/psysh.git","clone_url":"https://github.com/theofidry/psysh.git","svn_url":"https://github.com/theofidry/psysh","homepage":"http://psysh.org","size":274445,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bobthecow:master","ref":"master","sha":"7181738495f8e00a2b28298e5ecde98d5921bbfc","user":{"login":"bobthecow","id":53660,"avatar_url":"https://avatars1.githubusercontent.com/u/53660?v=4","gravatar_id":"","url":"https://api.github.com/users/bobthecow","html_url":"https://github.com/bobthecow","followers_url":"https://api.github.com/users/bobthecow/followers","following_url":"https://api.github.com/users/bobthecow/following{/other_user}","gists_url":"https://api.github.com/users/bobthecow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobthecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobthecow/subscriptions","organizations_url":"https://api.github.com/users/bobthecow/orgs","repos_url":"https://api.github.com/users/bobthecow/repos","events_url":"https://api.github.com/users/bobthecow/events{/privacy}","received_events_url":"https://api.github.com/users/bobthecow/received_events","type":"User","site_admin":false},"repo":{"id":4549925,"name":"psysh","full_name":"bobthecow/psysh","owner":{"login":"bobthecow","id":53660,"avatar_url":"https://avatars1.githubusercontent.com/u/53660?v=4","gravatar_id":"","url":"https://api.github.com/users/bobthecow","html_url":"https://github.com/bobthecow","followers_url":"https://api.github.com/users/bobthecow/followers","following_url":"https://api.github.com/users/bobthecow/following{/other_user}","gists_url":"https://api.github.com/users/bobthecow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobthecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobthecow/subscriptions","organizations_url":"https://api.github.com/users/bobthecow/orgs","repos_url":"https://api.github.com/users/bobthecow/repos","events_url":"https://api.github.com/users/bobthecow/events{/privacy}","received_events_url":"https://api.github.com/users/bobthecow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobthecow/psysh","description":"A REPL for PHP","fork":false,"url":"https://api.github.com/repos/bobthecow/psysh","forks_url":"https://api.github.com/repos/bobthecow/psysh/forks","keys_url":"https://api.github.com/repos/bobthecow/psysh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobthecow/psysh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobthecow/psysh/teams","hooks_url":"https://api.github.com/repos/bobthecow/psysh/hooks","issue_events_url":"https://api.github.com/repos/bobthecow/psysh/issues/events{/number}","events_url":"https://api.github.com/repos/bobthecow/psysh/events","assignees_url":"https://api.github.com/repos/bobthecow/psysh/assignees{/user}","branches_url":"https://api.github.com/repos/bobthecow/psysh/branches{/branch}","tags_url":"https://api.github.com/repos/bobthecow/psysh/tags","blobs_url":"https://api.github.com/repos/bobthecow/psysh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobthecow/psysh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobthecow/psysh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobthecow/psysh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobthecow/psysh/statuses/{sha}","languages_url":"https://api.github.com/repos/bobthecow/psysh/languages","stargazers_url":"https://api.github.com/repos/bobthecow/psysh/stargazers","contributors_url":"https://api.github.com/repos/bobthecow/psysh/contributors","subscribers_url":"https://api.github.com/repos/bobthecow/psysh/subscribers","subscription_url":"https://api.github.com/repos/bobthecow/psysh/subscription","commits_url":"https://api.github.com/repos/bobthecow/psysh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobthecow/psysh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobthecow/psysh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobthecow/psysh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobthecow/psysh/contents/{+path}","compare_url":"https://api.github.com/repos/bobthecow/psysh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobthecow/psysh/merges","archive_url":"https://api.github.com/repos/bobthecow/psysh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobthecow/psysh/downloads","issues_url":"https://api.github.com/repos/bobthecow/psysh/issues{/number}","pulls_url":"https://api.github.com/repos/bobthecow/psysh/pulls{/number}","milestones_url":"https://api.github.com/repos/bobthecow/psysh/milestones{/number}","notifications_url":"https://api.github.com/repos/bobthecow/psysh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobthecow/psysh/labels{/name}","releases_url":"https://api.github.com/repos/bobthecow/psysh/releases{/id}","deployments_url":"https://api.github.com/repos/bobthecow/psysh/deployments","created_at":"2012-06-04T17:15:35Z","updated_at":"2018-05-05T21:33:19Z","pushed_at":"2018-05-05T13:09:49Z","git_url":"git://github.com/bobthecow/psysh.git","ssh_url":"git@github.com:bobthecow/psysh.git","clone_url":"https://github.com/bobthecow/psysh.git","svn_url":"https://github.com/bobthecow/psysh","homepage":"http://psysh.org","size":274447,"stargazers_count":4881,"watchers_count":4881,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":187,"open_issues":67,"watchers":4881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/488"},"html":{"href":"https://github.com/bobthecow/psysh/pull/488"},"issue":{"href":"https://api.github.com/repos/bobthecow/psysh/issues/488"},"comments":{"href":"https://api.github.com/repos/bobthecow/psysh/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bobthecow/psysh/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/bobthecow/psysh/statuses/4e2eb01e4cf0647ce1d2e73c072c0f35317113ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bobthecow"}}