{"action":"created","issue":{"url":"https://api.github.com/repos/18F/identity-idp/issues/2105","repository_url":"https://api.github.com/repos/18F/identity-idp","labels_url":"https://api.github.com/repos/18F/identity-idp/issues/2105/labels{/name}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/2105/comments","events_url":"https://api.github.com/repos/18F/identity-idp/issues/2105/events","html_url":"https://github.com/18F/identity-idp/pull/2105","id":314735866,"number":2105,"title":"Force SSL in the Rails prod config","user":{"login":"monfresh","id":811150,"avatar_url":"https://avatars1.githubusercontent.com/u/811150?v=4","gravatar_id":"","url":"https://api.github.com/users/monfresh","html_url":"https://github.com/monfresh","followers_url":"https://api.github.com/users/monfresh/followers","following_url":"https://api.github.com/users/monfresh/following{/other_user}","gists_url":"https://api.github.com/users/monfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/monfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monfresh/subscriptions","organizations_url":"https://api.github.com/users/monfresh/orgs","repos_url":"https://api.github.com/users/monfresh/repos","events_url":"https://api.github.com/users/monfresh/events{/privacy}","received_events_url":"https://api.github.com/users/monfresh/received_events","type":"User","site_admin":false},"labels":[{"id":355011342,"url":"https://api.github.com/repos/18F/identity-idp/labels/status%20-%20ready%20for%20review","name":"status - ready for review","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-16T16:46:05Z","updated_at":"2018-04-16T21:55:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/2105","html_url":"https://github.com/18F/identity-idp/pull/2105","diff_url":"https://github.com/18F/identity-idp/pull/2105.diff","patch_url":"https://github.com/18F/identity-idp/pull/2105.patch"},"body":"**Why**: There's no reason I'm aware of we want to allow non-HTTPS calls\r\n\r\nHi! Before submitting your PR for review, and/or before merging it, please\r\ngo through the following checklist:\r\n\r\n- [ ] For DB changes, check for missing indexes, check to see if the changes\r\naffect other apps (such as the dashboard), make sure the DB columns in the\r\nvarious environments are properly populated, coordinate with devops, plan\r\nmigrations in separate steps.\r\n\r\n- [ ] For route changes, make sure GET requests don't change state or result in\r\ndestructive behavior. GET requests should only result in information being\r\nread, not written.\r\n\r\n- [ ] For encryption changes, make sure it is compatible with data that was\r\nencrypted with the old code.\r\n\r\n- [ ] For secrets changes, [make sure to update the S3 secrets bucket](https://github.com/18F/identity-private/wiki/Secrets-S3-buckets) with the \r\nnew configs in **all** environments. \r\n\r\n- [ ] Do not disable Rubocop or Reek offenses unless you are absolutely sure\r\nthey are false positives. If you're not sure how to fix the offense, please\r\nask a teammate.\r\n\r\n- [ ] When reading data, write tests for nil values, empty strings,\r\nand invalid formats.\r\n\r\n- [ ] When calling `redirect_to` in a controller, use `_url`, not `_path`.\r\n\r\n- [ ] When adding user data to the session, use the `user_session` helper\r\ninstead of the `session` helper so the data does not persist beyond the user's\r\nsession.\r\n\r\n- [ ] When adding a new controller that requires the user to be fully\r\nauthenticated, make sure to add `before_action :confirm_two_factor_authenticated`.\r\n"},"comment":{"url":"https://api.github.com/repos/18F/identity-idp/issues/comments/381762808","html_url":"https://github.com/18F/identity-idp/pull/2105#issuecomment-381762808","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/2105","id":381762808,"user":{"login":"konklone","id":4592,"avatar_url":"https://avatars0.githubusercontent.com/u/4592?v=4","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T21:55:22Z","updated_at":"2018-04-16T21:55:22Z","author_association":"OWNER","body":"No issues on my end. By every indication I've seen, we already enforce TLS for all inbound connections."}}
{"actor":{"display_login":"konklone"}}