{"action":"created","issue":{"url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/1053","repository_url":"https://api.github.com/repos/liip/LiipImagineBundle","labels_url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/1053/labels{/name}","comments_url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/1053/comments","events_url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/1053/events","html_url":"https://github.com/liip/LiipImagineBundle/pull/1053","id":297350364,"number":1053,"title":"Update imagine.xml","user":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars1.githubusercontent.com/u/2891702?v=4","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"labels":[{"id":43955433,"url":"https://api.github.com/repos/liip/LiipImagineBundle/labels/stat:%20rejected","name":"stat: rejected","color":"41688e","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-15T07:23:33Z","updated_at":"2018-02-15T21:42:54Z","closed_at":"2018-02-15T21:42:54Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/liip/LiipImagineBundle/pulls/1053","html_url":"https://github.com/liip/LiipImagineBundle/pull/1053","diff_url":"https://github.com/liip/LiipImagineBundle/pull/1053.diff","patch_url":"https://github.com/liip/LiipImagineBundle/pull/1053.patch"},"body":"| Q | A\r\n| --- | ---\r\n| Branch? | 1.0\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | hope so\r\n| License | MIT\r\n\r\nwe are in the process to upgrade to symfony to 3.4 (and later on to 4.0).\r\nwe stumbled upon a few deprecations with this bundle. services are by default now `non-public`\r\nthis PR makes all \"not already explicitly defined\" services public. \r\n\r\n\r\nedit: it also fixes ProcessBuilder deprecation, for the sake of it, as it is not a really big deal, i just added the processbuilder locally, instead of a heavy refactor"},"comment":{"url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/comments/366071205","html_url":"https://github.com/liip/LiipImagineBundle/pull/1053#issuecomment-366071205","issue_url":"https://api.github.com/repos/liip/LiipImagineBundle/issues/1053","id":366071205,"user":{"login":"robfrawley","id":3967713,"avatar_url":"https://avatars0.githubusercontent.com/u/3967713?v=4","gravatar_id":"","url":"https://api.github.com/users/robfrawley","html_url":"https://github.com/robfrawley","followers_url":"https://api.github.com/users/robfrawley/followers","following_url":"https://api.github.com/users/robfrawley/following{/other_user}","gists_url":"https://api.github.com/users/robfrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/robfrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfrawley/subscriptions","organizations_url":"https://api.github.com/users/robfrawley/orgs","repos_url":"https://api.github.com/users/robfrawley/repos","events_url":"https://api.github.com/users/robfrawley/events{/privacy}","received_events_url":"https://api.github.com/users/robfrawley/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T21:42:54Z","updated_at":"2018-02-15T21:42:54Z","author_association":"COLLABORATOR","body":"@hjanuschka I appreciate the drive to work on this bundle and if you would like to submit changed to the `2.0` branch that further support for Symfony `4.x` we would gratefully include it. As for this contribution, we don't want to support Symfony `4.x` on the `1.x` branch."}}
{"actor":{"display_login":"robfrawley"}}