{"action":"created","issue":{"url":"https://api.github.com/repos/weewx/weewx/issues/248","repository_url":"https://api.github.com/repos/weewx/weewx","labels_url":"https://api.github.com/repos/weewx/weewx/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/weewx/weewx/issues/248/comments","events_url":"https://api.github.com/repos/weewx/weewx/issues/248/events","html_url":"https://github.com/weewx/weewx/issues/248","id":218020037,"node_id":"MDU6SXNzdWUyMTgwMjAwMzc=","number":248,"title":"how to merge newskin into weewx master","user":{"login":"matthewwall","id":6115213,"node_id":"MDQ6VXNlcjYxMTUyMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6115213?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewwall","html_url":"https://github.com/matthewwall","followers_url":"https://api.github.com/users/matthewwall/followers","following_url":"https://api.github.com/users/matthewwall/following{/other_user}","gists_url":"https://api.github.com/users/matthewwall/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewwall/subscriptions","organizations_url":"https://api.github.com/users/matthewwall/orgs","repos_url":"https://api.github.com/users/matthewwall/repos","events_url":"https://api.github.com/users/matthewwall/events{/privacy}","received_events_url":"https://api.github.com/users/matthewwall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2017-03-29T21:50:33Z","updated_at":"2018-10-10T15:28:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"what else does the newskin branch need before we merge it into master?\r\n\r\nthis is what it does as of 29mar17 (see the newskin branch):\r\n\r\n* Standard is replaced by an entirely new skin\r\n* the mobile and smartphone skins have been split out into separate skins\r\n* defaults for all skins can be specified in [StdReports]\r\n\r\nthe branch includes the changes for taking advantage of the defaults in StdReports.  for example, when you set units using wee_config, those units apply to *all* reports.  then you can customize per-report if desired.\r\n\r\ni see at least these issues:\r\n\r\n1) how to incorporate the new standard skin.  should it be installed in every upgrade?  if so, then using what name (so it does not clobber StandardReport)?  or should users get the new skins only if they do a clean install?\r\n\r\n2) what other features/functionality are necessary in the new standard skin before it is ready for release?\r\n\r\n3) what to call the new standard skin?\r\n"},"comment":{"url":"https://api.github.com/repos/weewx/weewx/issues/comments/428618059","html_url":"https://github.com/weewx/weewx/issues/248#issuecomment-428618059","issue_url":"https://api.github.com/repos/weewx/weewx/issues/248","id":428618059,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODYxODA1OQ==","user":{"login":"matthewwall","id":6115213,"node_id":"MDQ6VXNlcjYxMTUyMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6115213?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewwall","html_url":"https://github.com/matthewwall","followers_url":"https://api.github.com/users/matthewwall/followers","following_url":"https://api.github.com/users/matthewwall/following{/other_user}","gists_url":"https://api.github.com/users/matthewwall/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewwall/subscriptions","organizations_url":"https://api.github.com/users/matthewwall/orgs","repos_url":"https://api.github.com/users/matthewwall/repos","events_url":"https://api.github.com/users/matthewwall/events{/privacy}","received_events_url":"https://api.github.com/users/matthewwall/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T15:28:44Z","updated_at":"2018-10-10T15:28:44Z","author_association":"CONTRIBUTOR","body":"> By contrast, the semantics of [[defaults]] is that it unilaterally overrides whatever\r\n> value an individual skin might provide.\r\n\r\njust to be clear: items in the [[defaults]] section would override anything in skin.conf, but anything in [StdReport][[Standard]] would override anything in [[defaults]]\r\n\r\nthere is still a hierarchic precedence of settings\r\n\r\nthe only differences between [StdReport] and [StdRESTful] are:\r\n\r\n1 StdReport needs to have non-scalar items in its config defaults\r\n\r\n2 the reports have a skin.conf file in addition to weewx.conf, but StdRESTful services do not\r\n\r\n(i may not be using 'override' and 'default' in the same way that you are...)\r\n"}}
{"actor":{"display_login":"matthewwall"}}