{"action":"created","comment":{"url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/comments/237114965","pull_request_review_id":179331518,"id":237114965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzExNDk2NQ==","diff_hunk":"@@ -294,19 +297,18 @@ module.exports = (factory) => {\n \n         disconnect() {\n             debug(`Closing connection to \"${this._connection.remoteAddress}\"`);\n-            // this._lastDisconnectedAddress = this._connection.remoteAddress;\n-            // this._lastDisconnectionTime = Date.now()\n-            this._connection.close();\n+            this._cleanup();\n+            this._lastDisconnectedAddress = this._connection.remoteAddress;\n+            this._lastDisconnectionTime = Date.now()\n \n-            //this.emit('disconnect', this);\n+            this._connection.close();\n+            this._connection = undefined;\n+            this.emit('disconnect', this);\n         }\n \n         _cleanup() {\n-            this._lastDisconnectedAddress = this._connection.remoteAddress;\n-            this._lastDisconnectionTime = Date.now()\n             this._bInbound = false;\n             this.loadDone = true;","path":"network/peer.js","position":185,"original_position":31,"commit_id":"7b8ebb49b941074bdc039bbdd3478571a7c63b2c","original_commit_id":"7b8ebb49b941074bdc039bbdd3478571a7c63b2c","user":{"login":"trueshura","id":8685683,"node_id":"MDQ6VXNlcjg2ODU2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8685683?v=4","gravatar_id":"","url":"https://api.github.com/users/trueshura","html_url":"https://github.com/trueshura","followers_url":"https://api.github.com/users/trueshura/followers","following_url":"https://api.github.com/users/trueshura/following{/other_user}","gists_url":"https://api.github.com/users/trueshura/gists{/gist_id}","starred_url":"https://api.github.com/users/trueshura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueshura/subscriptions","organizations_url":"https://api.github.com/users/trueshura/orgs","repos_url":"https://api.github.com/users/trueshura/repos","events_url":"https://api.github.com/users/trueshura/events{/privacy}","received_events_url":"https://api.github.com/users/trueshura/received_events","type":"User","site_admin":false},"body":"Есть у меня сомнения по этой строчке.\r\nРаньше логика была такая, что дисконнект это тоже своего рода признак, что мы закончили с пиром.\r\nЯ понимаю, как она здесь оказалась, но надо подумать: место ли ей тут.","created_at":"2018-11-28T14:51:45Z","updated_at":"2018-11-28T14:58:44Z","html_url":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7#discussion_r237114965","pull_request_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/comments/237114965"},"html":{"href":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7#discussion_r237114965"},"pull_request":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7","id":230798152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzk4MTUy","html_url":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7","diff_url":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7.diff","patch_url":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7.patch","issue_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/7","number":7,"state":"open","locked":false,"title":"Node&Peer","user":{"login":"bottlebo","id":41428036,"node_id":"MDQ6VXNlcjQxNDI4MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/41428036?v=4","gravatar_id":"","url":"https://api.github.com/users/bottlebo","html_url":"https://github.com/bottlebo","followers_url":"https://api.github.com/users/bottlebo/followers","following_url":"https://api.github.com/users/bottlebo/following{/other_user}","gists_url":"https://api.github.com/users/bottlebo/gists{/gist_id}","starred_url":"https://api.github.com/users/bottlebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bottlebo/subscriptions","organizations_url":"https://api.github.com/users/bottlebo/orgs","repos_url":"https://api.github.com/users/bottlebo/repos","events_url":"https://api.github.com/users/bottlebo/events{/privacy}","received_events_url":"https://api.github.com/users/bottlebo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-14T11:17:34Z","updated_at":"2018-11-28T14:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"446f66dbfb74c1fa1b3d4b35849b58cf9c3c6760","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7/commits","review_comments_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7/comments","review_comment_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/7/comments","statuses_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/statuses/7b8ebb49b941074bdc039bbdd3478571a7c63b2c","head":{"label":"bottlebo:Node&Peer","ref":"Node&Peer","sha":"7b8ebb49b941074bdc039bbdd3478571a7c63b2c","user":{"login":"bottlebo","id":41428036,"node_id":"MDQ6VXNlcjQxNDI4MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/41428036?v=4","gravatar_id":"","url":"https://api.github.com/users/bottlebo","html_url":"https://github.com/bottlebo","followers_url":"https://api.github.com/users/bottlebo/followers","following_url":"https://api.github.com/users/bottlebo/following{/other_user}","gists_url":"https://api.github.com/users/bottlebo/gists{/gist_id}","starred_url":"https://api.github.com/users/bottlebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bottlebo/subscriptions","organizations_url":"https://api.github.com/users/bottlebo/orgs","repos_url":"https://api.github.com/users/bottlebo/repos","events_url":"https://api.github.com/users/bottlebo/events{/privacy}","received_events_url":"https://api.github.com/users/bottlebo/received_events","type":"User","site_admin":false},"repo":{"id":154509559,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MDk1NTk=","name":"Cil-core","full_name":"bottlebo/Cil-core","private":false,"owner":{"login":"bottlebo","id":41428036,"node_id":"MDQ6VXNlcjQxNDI4MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/41428036?v=4","gravatar_id":"","url":"https://api.github.com/users/bottlebo","html_url":"https://github.com/bottlebo","followers_url":"https://api.github.com/users/bottlebo/followers","following_url":"https://api.github.com/users/bottlebo/following{/other_user}","gists_url":"https://api.github.com/users/bottlebo/gists{/gist_id}","starred_url":"https://api.github.com/users/bottlebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bottlebo/subscriptions","organizations_url":"https://api.github.com/users/bottlebo/orgs","repos_url":"https://api.github.com/users/bottlebo/repos","events_url":"https://api.github.com/users/bottlebo/events{/privacy}","received_events_url":"https://api.github.com/users/bottlebo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bottlebo/Cil-core","description":"Network repository.","fork":true,"url":"https://api.github.com/repos/bottlebo/Cil-core","forks_url":"https://api.github.com/repos/bottlebo/Cil-core/forks","keys_url":"https://api.github.com/repos/bottlebo/Cil-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bottlebo/Cil-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bottlebo/Cil-core/teams","hooks_url":"https://api.github.com/repos/bottlebo/Cil-core/hooks","issue_events_url":"https://api.github.com/repos/bottlebo/Cil-core/issues/events{/number}","events_url":"https://api.github.com/repos/bottlebo/Cil-core/events","assignees_url":"https://api.github.com/repos/bottlebo/Cil-core/assignees{/user}","branches_url":"https://api.github.com/repos/bottlebo/Cil-core/branches{/branch}","tags_url":"https://api.github.com/repos/bottlebo/Cil-core/tags","blobs_url":"https://api.github.com/repos/bottlebo/Cil-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bottlebo/Cil-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bottlebo/Cil-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bottlebo/Cil-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bottlebo/Cil-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bottlebo/Cil-core/languages","stargazers_url":"https://api.github.com/repos/bottlebo/Cil-core/stargazers","contributors_url":"https://api.github.com/repos/bottlebo/Cil-core/contributors","subscribers_url":"https://api.github.com/repos/bottlebo/Cil-core/subscribers","subscription_url":"https://api.github.com/repos/bottlebo/Cil-core/subscription","commits_url":"https://api.github.com/repos/bottlebo/Cil-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bottlebo/Cil-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bottlebo/Cil-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bottlebo/Cil-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bottlebo/Cil-core/contents/{+path}","compare_url":"https://api.github.com/repos/bottlebo/Cil-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bottlebo/Cil-core/merges","archive_url":"https://api.github.com/repos/bottlebo/Cil-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bottlebo/Cil-core/downloads","issues_url":"https://api.github.com/repos/bottlebo/Cil-core/issues{/number}","pulls_url":"https://api.github.com/repos/bottlebo/Cil-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bottlebo/Cil-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bottlebo/Cil-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bottlebo/Cil-core/labels{/name}","releases_url":"https://api.github.com/repos/bottlebo/Cil-core/releases{/id}","deployments_url":"https://api.github.com/repos/bottlebo/Cil-core/deployments","created_at":"2018-10-24T13:51:06Z","updated_at":"2018-11-12T06:08:26Z","pushed_at":"2018-11-27T08:50:34Z","git_url":"git://github.com/bottlebo/Cil-core.git","ssh_url":"git@github.com:bottlebo/Cil-core.git","clone_url":"https://github.com/bottlebo/Cil-core.git","svn_url":"https://github.com/bottlebo/Cil-core","homepage":"","size":482,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SilentNotaryEcosystem:master","ref":"master","sha":"2a38c97f6f40a5a374025472d4d1e93f1c773c12","user":{"login":"SilentNotaryEcosystem","id":43272562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcyNTYy","avatar_url":"https://avatars1.githubusercontent.com/u/43272562?v=4","gravatar_id":"","url":"https://api.github.com/users/SilentNotaryEcosystem","html_url":"https://github.com/SilentNotaryEcosystem","followers_url":"https://api.github.com/users/SilentNotaryEcosystem/followers","following_url":"https://api.github.com/users/SilentNotaryEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/SilentNotaryEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/SilentNotaryEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilentNotaryEcosystem/subscriptions","organizations_url":"https://api.github.com/users/SilentNotaryEcosystem/orgs","repos_url":"https://api.github.com/users/SilentNotaryEcosystem/repos","events_url":"https://api.github.com/users/SilentNotaryEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/SilentNotaryEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":148794832,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3OTQ4MzI=","name":"Cil-core","full_name":"SilentNotaryEcosystem/Cil-core","private":false,"owner":{"login":"SilentNotaryEcosystem","id":43272562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcyNTYy","avatar_url":"https://avatars1.githubusercontent.com/u/43272562?v=4","gravatar_id":"","url":"https://api.github.com/users/SilentNotaryEcosystem","html_url":"https://github.com/SilentNotaryEcosystem","followers_url":"https://api.github.com/users/SilentNotaryEcosystem/followers","following_url":"https://api.github.com/users/SilentNotaryEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/SilentNotaryEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/SilentNotaryEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilentNotaryEcosystem/subscriptions","organizations_url":"https://api.github.com/users/SilentNotaryEcosystem/orgs","repos_url":"https://api.github.com/users/SilentNotaryEcosystem/repos","events_url":"https://api.github.com/users/SilentNotaryEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/SilentNotaryEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SilentNotaryEcosystem/Cil-core","description":"Network repository.","fork":false,"url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core","forks_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/forks","keys_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/teams","hooks_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/hooks","issue_events_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/events{/number}","events_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/events","assignees_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/assignees{/user}","branches_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/branches{/branch}","tags_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/tags","blobs_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/statuses/{sha}","languages_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/languages","stargazers_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/stargazers","contributors_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/contributors","subscribers_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/subscribers","subscription_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/subscription","commits_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/contents/{+path}","compare_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/merges","archive_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/downloads","issues_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues{/number}","pulls_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls{/number}","milestones_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/milestones{/number}","notifications_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/labels{/name}","releases_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/releases{/id}","deployments_url":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/deployments","created_at":"2018-09-14T13:47:15Z","updated_at":"2018-11-21T09:53:44Z","pushed_at":"2018-11-27T08:50:35Z","git_url":"git://github.com/SilentNotaryEcosystem/Cil-core.git","ssh_url":"git@github.com:SilentNotaryEcosystem/Cil-core.git","clone_url":"https://github.com/SilentNotaryEcosystem/Cil-core.git","svn_url":"https://github.com/SilentNotaryEcosystem/Cil-core","homepage":"","size":334,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7"},"html":{"href":"https://github.com/SilentNotaryEcosystem/Cil-core/pull/7"},"issue":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/7"},"comments":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/SilentNotaryEcosystem/Cil-core/statuses/7b8ebb49b941074bdc039bbdd3478571a7c63b2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"trueshura"}}