{"action":"created","issue":{"url":"https://api.github.com/repos/iupickmx/iupick-node/issues/2","repository_url":"https://api.github.com/repos/iupickmx/iupick-node","labels_url":"https://api.github.com/repos/iupickmx/iupick-node/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/iupickmx/iupick-node/issues/2/comments","events_url":"https://api.github.com/repos/iupickmx/iupick-node/issues/2/events","html_url":"https://github.com/iupickmx/iupick-node/pull/2","id":310201301,"number":2,"title":"Added tests and fixed global var dependence","user":{"login":"diego-d5000","id":10999609,"avatar_url":"https://avatars2.githubusercontent.com/u/10999609?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-d5000","html_url":"https://github.com/diego-d5000","followers_url":"https://api.github.com/users/diego-d5000/followers","following_url":"https://api.github.com/users/diego-d5000/following{/other_user}","gists_url":"https://api.github.com/users/diego-d5000/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-d5000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-d5000/subscriptions","organizations_url":"https://api.github.com/users/diego-d5000/orgs","repos_url":"https://api.github.com/users/diego-d5000/repos","events_url":"https://api.github.com/users/diego-d5000/events{/privacy}","received_events_url":"https://api.github.com/users/diego-d5000/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-31T01:19:30Z","updated_at":"2018-03-31T17:13:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/iupickmx/iupick-node/pulls/2","html_url":"https://github.com/iupickmx/iupick-node/pull/2","diff_url":"https://github.com/iupickmx/iupick-node/pull/2.diff","patch_url":"https://github.com/iupickmx/iupick-node/pull/2.patch"},"body":"This PR:\r\n- Add some test following examples in ./examples.\r\n- Modify resources (shipments and waypoints) classes to return a closure function, avoiding the dependence to a global var \"iupick\", this allow use of multiple instances of this iupick client lib to add more flexibility of use. (based on closed issue #1 'Module depends on global var')"},"comment":{"url":"https://api.github.com/repos/iupickmx/iupick-node/issues/comments/377708485","html_url":"https://github.com/iupickmx/iupick-node/pull/2#issuecomment-377708485","issue_url":"https://api.github.com/repos/iupickmx/iupick-node/issues/2","id":377708485,"user":{"login":"Vanclief","id":13844339,"avatar_url":"https://avatars2.githubusercontent.com/u/13844339?v=4","gravatar_id":"","url":"https://api.github.com/users/Vanclief","html_url":"https://github.com/Vanclief","followers_url":"https://api.github.com/users/Vanclief/followers","following_url":"https://api.github.com/users/Vanclief/following{/other_user}","gists_url":"https://api.github.com/users/Vanclief/gists{/gist_id}","starred_url":"https://api.github.com/users/Vanclief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vanclief/subscriptions","organizations_url":"https://api.github.com/users/Vanclief/orgs","repos_url":"https://api.github.com/users/Vanclief/repos","events_url":"https://api.github.com/users/Vanclief/events{/privacy}","received_events_url":"https://api.github.com/users/Vanclief/received_events","type":"User","site_admin":false},"created_at":"2018-03-31T17:13:50Z","updated_at":"2018-03-31T17:13:50Z","author_association":"COLLABORATOR","body":"Hello Diego,\r\n\r\n I see the point of managing like this the modules, and adding tests was a very nice addition. When checking the PR, not all tests passed, I am adding the output of running the tests. As I said previously, I don't longer maintain this library (I checked the PR out of curiosity), so I do not feel I should merge this without @davicin-pola @nogalpi approval. But it looks good.\r\n\r\nBest\r\n\r\n**npm test**\r\n```\r\n2 failing\r\n\r\n  1) Waybill\r\n       Waybill process\r\n         should pass through a waybill process successful:\r\n     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n\r\n\r\n  2) Waybill\r\n       track\r\n         return a tracking code status:\r\n     Uncaught AssertionError: expected { Object (shipper_address, recipient_address) } to be a string\r\n```"}}
{"actor":{"display_login":"Vanclief"}}