{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/691","repository_url":"https://api.github.com/repos/amethyst/amethyst","labels_url":"https://api.github.com/repos/amethyst/amethyst/issues/691/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/691/comments","events_url":"https://api.github.com/repos/amethyst/amethyst/issues/691/events","html_url":"https://github.com/amethyst/amethyst/pull/691","id":319282520,"number":691,"title":"[WIP] refactor: Make game data pluggable","user":{"login":"Rhuagh","id":1011884,"avatar_url":"https://avatars0.githubusercontent.com/u/1011884?v=4","gravatar_id":"","url":"https://api.github.com/users/Rhuagh","html_url":"https://github.com/Rhuagh","followers_url":"https://api.github.com/users/Rhuagh/followers","following_url":"https://api.github.com/users/Rhuagh/following{/other_user}","gists_url":"https://api.github.com/users/Rhuagh/gists{/gist_id}","starred_url":"https://api.github.com/users/Rhuagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rhuagh/subscriptions","organizations_url":"https://api.github.com/users/Rhuagh/orgs","repos_url":"https://api.github.com/users/Rhuagh/repos","events_url":"https://api.github.com/users/Rhuagh/events{/privacy}","received_events_url":"https://api.github.com/users/Rhuagh/received_events","type":"User","site_admin":false},"labels":[{"id":311016840,"url":"https://api.github.com/repos/amethyst/amethyst/labels/diff:%20hard","name":"diff: hard","color":"fef2c0","default":false},{"id":311017802,"url":"https://api.github.com/repos/amethyst/amethyst/labels/pri:%20important","name":"pri: important","color":"f7c6c7","default":false},{"id":693782627,"url":"https://api.github.com/repos/amethyst/amethyst/labels/project:%20main%20crate","name":"project: main crate","color":"0e8a16","default":false},{"id":662998062,"url":"https://api.github.com/repos/amethyst/amethyst/labels/status:%20working","name":"status: working","color":"bfe5bf","default":false},{"id":302199478,"url":"https://api.github.com/repos/amethyst/amethyst/labels/type:%20improvement","name":"type: improvement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-05-01T18:29:07Z","updated_at":"2018-05-04T16:41:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/691","html_url":"https://github.com/amethyst/amethyst/pull/691","diff_url":"https://github.com/amethyst/amethyst/pull/691.diff","patch_url":"https://github.com/amethyst/amethyst/pull/691.patch"},"body":"Remove Dispatcher from Application, and add a pluggable generic type.\r\nAdd a direct replacement for the old game data, featuring only a Dispatcher.\r\nMake the states take a new StateData type, containing references to World and pluggable game data.\r\nMove responsibility for doing system dispatch to the states.\r\n\r\nOpening this early to get feedback.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/amethyst/amethyst/691)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/comments/386659080","html_url":"https://github.com/amethyst/amethyst/pull/691#issuecomment-386659080","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/691","id":386659080,"user":{"login":"jojolepro","id":4755185,"avatar_url":"https://avatars2.githubusercontent.com/u/4755185?v=4","gravatar_id":"","url":"https://api.github.com/users/jojolepro","html_url":"https://github.com/jojolepro","followers_url":"https://api.github.com/users/jojolepro/followers","following_url":"https://api.github.com/users/jojolepro/following{/other_user}","gists_url":"https://api.github.com/users/jojolepro/gists{/gist_id}","starred_url":"https://api.github.com/users/jojolepro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojolepro/subscriptions","organizations_url":"https://api.github.com/users/jojolepro/orgs","repos_url":"https://api.github.com/users/jojolepro/repos","events_url":"https://api.github.com/users/jojolepro/events{/privacy}","received_events_url":"https://api.github.com/users/jojolepro/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T16:41:42Z","updated_at":"2018-05-04T16:41:42Z","author_association":"COLLABORATOR","body":"1) What would be the use case for that?\r\n2) Is it worth the added complexity?"}}
{"actor":{"display_login":"jojolepro"}}