{"action":"created","comment":{"url":"https://api.github.com/repos/tikv/tikv/pulls/comments/210851464","pull_request_review_id":147153556,"id":210851464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg1MTQ2NA==","diff_hunk":"@@ -108,6 +108,7 @@ impl ScalarFunc {\n             | ScalarFuncSig::RegexpBinarySig\n             | ScalarFuncSig::LeftShift\n             | ScalarFuncSig::RightShift\n+            | ScalarFuncSig::Pow","path":"src/coprocessor/dag/expr/scalar_function.rs","position":4,"original_position":4,"commit_id":"117e43cd7e89df9d1d324dbb8a5a67172b7e1bef","original_commit_id":"117e43cd7e89df9d1d324dbb8a5a67172b7e1bef","user":{"login":"AndreMouche","id":1085697,"node_id":"MDQ6VXNlcjEwODU2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1085697?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreMouche","html_url":"https://github.com/AndreMouche","followers_url":"https://api.github.com/users/AndreMouche/followers","following_url":"https://api.github.com/users/AndreMouche/following{/other_user}","gists_url":"https://api.github.com/users/AndreMouche/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreMouche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreMouche/subscriptions","organizations_url":"https://api.github.com/users/AndreMouche/orgs","repos_url":"https://api.github.com/users/AndreMouche/repos","events_url":"https://api.github.com/users/AndreMouche/events{/privacy}","received_events_url":"https://api.github.com/users/AndreMouche/received_events","type":"User","site_admin":false},"body":"You may need update `test_check_args` too","created_at":"2018-08-17T09:17:53Z","updated_at":"2018-08-17T09:17:54Z","html_url":"https://github.com/tikv/tikv/pull/3475#discussion_r210851464","pull_request_url":"https://api.github.com/repos/tikv/tikv/pulls/3475","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments/210851464"},"html":{"href":"https://github.com/tikv/tikv/pull/3475#discussion_r210851464"},"pull_request":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3475"}}},"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3475","id":209076521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDc2NTIx","html_url":"https://github.com/tikv/tikv/pull/3475","diff_url":"https://github.com/tikv/tikv/pull/3475.diff","patch_url":"https://github.com/tikv/tikv/pull/3475.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3475","number":3475,"state":"open","locked":false,"title":"coprocessor/dag/expr: add some un-pushed builtin UDF(Pow) #3411","user":{"login":"smallyard","id":5810729,"node_id":"MDQ6VXNlcjU4MTA3Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/5810729?v=4","gravatar_id":"","url":"https://api.github.com/users/smallyard","html_url":"https://github.com/smallyard","followers_url":"https://api.github.com/users/smallyard/followers","following_url":"https://api.github.com/users/smallyard/following{/other_user}","gists_url":"https://api.github.com/users/smallyard/gists{/gist_id}","starred_url":"https://api.github.com/users/smallyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallyard/subscriptions","organizations_url":"https://api.github.com/users/smallyard/orgs","repos_url":"https://api.github.com/users/smallyard/repos","events_url":"https://api.github.com/users/smallyard/events{/privacy}","received_events_url":"https://api.github.com/users/smallyard/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nimplement builtin function: Pow in coprocessor.\r\nThis is for #3275\r\nfix DCO from PR https://github.com/tikv/tikv/pull/3411\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\nImprovement\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nunittest\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nno\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nno\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\n#3275\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n","created_at":"2018-08-17T08:17:32Z","updated_at":"2018-08-17T09:17:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77876a81642011c2690899ab0f3bd9ff487d9007","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":526233180,"node_id":"MDU6TGFiZWw1MjYyMzMxODA=","url":"https://api.github.com/repos/tikv/tikv/labels/C:%20Copr","name":"C: Copr","color":"9df9d7","default":false},{"id":1013338313,"node_id":"MDU6TGFiZWwxMDEzMzM4MzEz","url":"https://api.github.com/repos/tikv/tikv/labels/T:%20Contributor","name":"T: Contributor","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3475/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3475/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3475/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/117e43cd7e89df9d1d324dbb8a5a67172b7e1bef","head":{"label":"smallyard:master","ref":"master","sha":"117e43cd7e89df9d1d324dbb8a5a67172b7e1bef","user":{"login":"smallyard","id":5810729,"node_id":"MDQ6VXNlcjU4MTA3Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/5810729?v=4","gravatar_id":"","url":"https://api.github.com/users/smallyard","html_url":"https://github.com/smallyard","followers_url":"https://api.github.com/users/smallyard/followers","following_url":"https://api.github.com/users/smallyard/following{/other_user}","gists_url":"https://api.github.com/users/smallyard/gists{/gist_id}","starred_url":"https://api.github.com/users/smallyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallyard/subscriptions","organizations_url":"https://api.github.com/users/smallyard/orgs","repos_url":"https://api.github.com/users/smallyard/repos","events_url":"https://api.github.com/users/smallyard/events{/privacy}","received_events_url":"https://api.github.com/users/smallyard/received_events","type":"User","site_admin":false},"repo":{"id":145089296,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwODkyOTY=","name":"tikv","full_name":"smallyard/tikv","owner":{"login":"smallyard","id":5810729,"node_id":"MDQ6VXNlcjU4MTA3Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/5810729?v=4","gravatar_id":"","url":"https://api.github.com/users/smallyard","html_url":"https://github.com/smallyard","followers_url":"https://api.github.com/users/smallyard/followers","following_url":"https://api.github.com/users/smallyard/following{/other_user}","gists_url":"https://api.github.com/users/smallyard/gists{/gist_id}","starred_url":"https://api.github.com/users/smallyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallyard/subscriptions","organizations_url":"https://api.github.com/users/smallyard/orgs","repos_url":"https://api.github.com/users/smallyard/repos","events_url":"https://api.github.com/users/smallyard/events{/privacy}","received_events_url":"https://api.github.com/users/smallyard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smallyard/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/smallyard/tikv","forks_url":"https://api.github.com/repos/smallyard/tikv/forks","keys_url":"https://api.github.com/repos/smallyard/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smallyard/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smallyard/tikv/teams","hooks_url":"https://api.github.com/repos/smallyard/tikv/hooks","issue_events_url":"https://api.github.com/repos/smallyard/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/smallyard/tikv/events","assignees_url":"https://api.github.com/repos/smallyard/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/smallyard/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/smallyard/tikv/tags","blobs_url":"https://api.github.com/repos/smallyard/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smallyard/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smallyard/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/smallyard/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smallyard/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/smallyard/tikv/languages","stargazers_url":"https://api.github.com/repos/smallyard/tikv/stargazers","contributors_url":"https://api.github.com/repos/smallyard/tikv/contributors","subscribers_url":"https://api.github.com/repos/smallyard/tikv/subscribers","subscription_url":"https://api.github.com/repos/smallyard/tikv/subscription","commits_url":"https://api.github.com/repos/smallyard/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/smallyard/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/smallyard/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/smallyard/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/smallyard/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/smallyard/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smallyard/tikv/merges","archive_url":"https://api.github.com/repos/smallyard/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smallyard/tikv/downloads","issues_url":"https://api.github.com/repos/smallyard/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/smallyard/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/smallyard/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/smallyard/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smallyard/tikv/labels{/name}","releases_url":"https://api.github.com/repos/smallyard/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/smallyard/tikv/deployments","created_at":"2018-08-17T07:47:04Z","updated_at":"2018-08-17T08:15:43Z","pushed_at":"2018-08-17T08:15:41Z","git_url":"git://github.com/smallyard/tikv.git","ssh_url":"git@github.com:smallyard/tikv.git","clone_url":"https://github.com/smallyard/tikv.git","svn_url":"https://github.com/smallyard/tikv","homepage":"https://pingcap.com","size":15281,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"51e935dac483dd897a06cdd019b7d2be69e7821b","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-08-17T08:59:19Z","pushed_at":"2018-08-17T08:59:10Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"https://pingcap.com","size":15279,"stargazers_count":3505,"watchers_count":3505,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":470,"open_issues":249,"watchers":3505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3475"},"html":{"href":"https://github.com/tikv/tikv/pull/3475"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3475"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3475/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3475/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3475/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/117e43cd7e89df9d1d324dbb8a5a67172b7e1bef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AndreMouche"}}