{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/175124139","pull_request_review_id":104583232,"id":175124139,"diff_hunk":"@@ -0,0 +1,278 @@\n+// ============================================================================\n+//                 SeqAn - The Library for Sequence Analysis\n+// ============================================================================\n+//\n+// Copyright (c) 2006-2018, Knut Reinert & Freie Universitaet Berlin\n+// Copyright (c) 2016-2018, Knut Reinert & MPI Molekulare Genetik\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are met:\n+//\n+//     * Redistributions of source code must retain the above copyright\n+//       notice, this list of conditions and the following disclaimer.\n+//     * Redistributions in binary form must reproduce the above copyright\n+//       notice, this list of conditions and the following disclaimer in the\n+//       documentation and/or other materials provided with the distribution.\n+//     * Neither the name of Knut Reinert or the FU Berlin nor the names of\n+//       its contributors may be used to endorse or promote products derived\n+//       from this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+// ARE DISCLAIMED. IN NO EVENT SHALL KNUT REINERT OR THE FU BERLIN BE LIABLE\n+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY\n+// OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH\n+// DAMAGE.\n+//\n+// ============================================================================\n+\n+#include <list>\n+#include <vector>\n+\n+#include <gtest/gtest.h>\n+\n+#include <meta/meta.hpp>\n+\n+#include <range/v3/view/iota.hpp>\n+#include <range/v3/view/take_exactly.hpp>\n+\n+\n+#include <seqan3/core/metafunction/all.hpp>\n+#include <seqan3/range/detail/random_access_iterator.hpp>\n+\n+using namespace seqan3;\n+\n+// TODO for most tests: also add something with proxy reference type\n+\n+TEST(range_and_iterator, iterator_)\n+{\n+    EXPECT_TRUE((std::is_same_v<iterator_t<std::vector<int>>,\n+                                typename std::vector<int>::iterator>));\n+    EXPECT_TRUE((std::is_same_v<iterator_t<std::vector<int> const>,\n+                                typename std::vector<int>::const_iterator>));\n+\n+    auto v = ranges::view::ints(1);\n+    EXPECT_TRUE((std::is_same_v<iterator_t<decltype(v)>,\n+                                decltype(ranges::begin(v))>));\n+    EXPECT_FALSE((std::is_same_v<iterator_t<decltype(v)>,\n+                                 decltype(ranges::end(v))>));\n+}\n+\n+TEST(range_and_iterator, sentinel_)\n+{\n+    EXPECT_TRUE((std::is_same_v<sentinel_t<std::vector<int>>,\n+                                typename std::vector<int>::iterator>));\n+    EXPECT_TRUE((std::is_same_v<sentinel_t<std::vector<int> const>,\n+                                typename std::vector<int>::const_iterator>));\n+    EXPECT_TRUE((std::is_same_v<sentinel_t<std::vector<int>>,\n+                                iterator_t<std::vector<int>>>));\n+\n+    auto v = ranges::view::ints(1);\n+    EXPECT_FALSE((std::is_same_v<sentinel_t<decltype(v)>,\n+                                decltype(ranges::begin(v))>));\n+    EXPECT_TRUE((std::is_same_v<sentinel_t<decltype(v)>,\n+                                decltype(ranges::end(v))>));\n+}\n+\n+template <typename list1, typename list2, size_t pos = 0>\n+void assert_same_types()","path":"test/unit/core/metafunction/range_iterator_test.cpp","position":84,"original_position":84,"commit_id":"bc1865d4026fd7b22f2bae7b438ad3e2a1b00269","original_commit_id":"bc1865d4026fd7b22f2bae7b438ad3e2a1b00269","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars1.githubusercontent.com/u/103778?v=4","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"body":"expect_same_types","created_at":"2018-03-16T15:21:05Z","updated_at":"2018-03-16T15:40:24Z","html_url":"https://github.com/seqan/seqan3/pull/212#discussion_r175124139","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/212","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/175124139"},"html":{"href":"https://github.com/seqan/seqan3/pull/212#discussion_r175124139"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/212","id":175402532,"html_url":"https://github.com/seqan/seqan3/pull/212","diff_url":"https://github.com/seqan/seqan3/pull/212.diff","patch_url":"https://github.com/seqan/seqan3/pull/212.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/212","number":212,"state":"open","locked":false,"title":"Range and iterator metafunctions","user":{"login":"h-2","id":2996863,"avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"body":"this is a first part of #159 \r\n\r\na second part will have to add `range/free_function.hpp` with \r\n* size()\r\n* begin(), end(), cbegin(), cend()\r\n* empty()\r\n\r\nAnd later possibly also the stuff from http://en.cppreference.com/w/cpp/experimental/ranges#Algorithms\r\n\r\nThis PR on purpose does not yet change anything in the library. The places that use the metafunctions will have to be adapted at a later point in time.","created_at":"2018-03-15T23:10:13Z","updated_at":"2018-03-16T15:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5e284944ef9a69926afb7030ecac05c2c0a4e95","assignee":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"assignees":[{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/212/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/212/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/212/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/bc1865d4026fd7b22f2bae7b438ad3e2a1b00269","head":{"label":"h-2:range_import","ref":"range_import","sha":"bc1865d4026fd7b22f2bae7b438ad3e2a1b00269","user":{"login":"h-2","id":2996863,"avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"repo":{"id":86586114,"name":"seqan3","full_name":"h-2/seqan3","owner":{"login":"h-2","id":2996863,"avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-2/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/h-2/seqan3","forks_url":"https://api.github.com/repos/h-2/seqan3/forks","keys_url":"https://api.github.com/repos/h-2/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-2/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-2/seqan3/teams","hooks_url":"https://api.github.com/repos/h-2/seqan3/hooks","issue_events_url":"https://api.github.com/repos/h-2/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/h-2/seqan3/events","assignees_url":"https://api.github.com/repos/h-2/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/h-2/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/h-2/seqan3/tags","blobs_url":"https://api.github.com/repos/h-2/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-2/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-2/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-2/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-2/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/h-2/seqan3/languages","stargazers_url":"https://api.github.com/repos/h-2/seqan3/stargazers","contributors_url":"https://api.github.com/repos/h-2/seqan3/contributors","subscribers_url":"https://api.github.com/repos/h-2/seqan3/subscribers","subscription_url":"https://api.github.com/repos/h-2/seqan3/subscription","commits_url":"https://api.github.com/repos/h-2/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-2/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-2/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-2/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-2/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/h-2/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-2/seqan3/merges","archive_url":"https://api.github.com/repos/h-2/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-2/seqan3/downloads","issues_url":"https://api.github.com/repos/h-2/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/h-2/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/h-2/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/h-2/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-2/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/h-2/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/h-2/seqan3/deployments","created_at":"2017-03-29T13:34:49Z","updated_at":"2018-03-13T14:46:59Z","pushed_at":"2018-03-16T14:45:35Z","git_url":"git://github.com/h-2/seqan3.git","ssh_url":"git@github.com:h-2/seqan3.git","clone_url":"https://github.com/h-2/seqan3.git","svn_url":"https://github.com/h-2/seqan3","homepage":"http://www.seqan.de","size":732,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"ab9d0a8fbd3a7e49d6bcc0b7c3ed6f0fdc29c023","user":{"login":"seqan","id":1752144,"avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"name":"seqan3","full_name":"seqan/seqan3","owner":{"login":"seqan","id":1752144,"avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2018-03-16T12:44:53Z","pushed_at":"2018-03-16T14:58:51Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":653,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":22,"open_issues":68,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/212"},"html":{"href":"https://github.com/seqan/seqan3/pull/212"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/212"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/bc1865d4026fd7b22f2bae7b438ad3e2a1b00269"}},"author_association":"OWNER"}}
{"actor":{"display_login":"marehr"}}