{"action":"created","issue":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/748","repository_url":"https://api.github.com/repos/oVirt/ovirt-web-ui","labels_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/748/labels{/name}","comments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/748/comments","events_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/748/events","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/748","id":354674276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzc5MDI4","number":748,"title":"added global react exception handler","user":{"login":"kozloffsky","id":2392818,"node_id":"MDQ6VXNlcjIzOTI4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2392818?v=4","gravatar_id":"","url":"https://api.github.com/users/kozloffsky","html_url":"https://github.com/kozloffsky","followers_url":"https://api.github.com/users/kozloffsky/followers","following_url":"https://api.github.com/users/kozloffsky/following{/other_user}","gists_url":"https://api.github.com/users/kozloffsky/gists{/gist_id}","starred_url":"https://api.github.com/users/kozloffsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozloffsky/subscriptions","organizations_url":"https://api.github.com/users/kozloffsky/orgs","repos_url":"https://api.github.com/users/kozloffsky/repos","events_url":"https://api.github.com/users/kozloffsky/events{/privacy}","received_events_url":"https://api.github.com/users/kozloffsky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-28T10:46:25Z","updated_at":"2018-08-30T03:04:55Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/748","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/748","diff_url":"https://github.com/oVirt/ovirt-web-ui/pull/748.diff","patch_url":"https://github.com/oVirt/ovirt-web-ui/pull/748.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/comments/417174602","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/748#issuecomment-417174602","issue_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/748","id":417174602,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzE3NDYwMg==","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T03:04:55Z","updated_at":"2018-08-30T03:04:55Z","author_association":"MEMBER","body":"Looking at https://reactjs.org/docs/error-boundaries.html is fairly interesting.\r\n\r\nMay be cleaner to create a single `GlobalErrorBoundary` component (in src/GlobalErrorBoundary.js) mirroring the example component on the react docs, and make it the root element for the entire app.  So instead of:\r\nhttps://github.com/oVirt/ovirt-web-ui/blob/a49fc4f3043cd18842ec953621565b0e5e5ae5d0/src/index.js#L48-L57\r\n\r\nIt could look like:\r\n````js\r\nfunction renderApp (store: Object) {\r\n  ReactDOM.render(\r\n    <GlobalErrorBoundary>\r\n      <Provider store={store}>\r\n        <IntlProvider locale={locale} messages={getSelectedMessages()}>\r\n          <App history={store.history} />\r\n        </IntlProvider>\r\n      </Provider>\r\n    </GlobalErrorBoundary>,\r\n    (document.getElementById('root'): any)\r\n  )\r\n}\r\n````\r\n\r\nThat would allow it to capture render errors everywhere.\r\n\r\n@kozloffsky, @bond95, @gregsheremeta - Thoughts?\r\n"}}
{"actor":{"display_login":"sjd78"}}