{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/223726931","pull_request_review_id":162922959,"id":223726931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzcyNjkzMQ==","diff_hunk":"@@ -163,6 +163,10 @@ def __init__(self, input_fname, montage, eog=None, misc=None,\n             warn(\"Stimulus channel will not be annotated. Both 'annot' and \"\n                  \"'annotmap' must be specified.\")\n \n+        if bool(annot) or bool(annotmap):","path":"mne/io/edf/edf.py","position":4,"original_position":4,"commit_id":"0ecf26640d03fc7409d500f51115f1bbad1a1f82","original_commit_id":"0ecf26640d03fc7409d500f51115f1bbad1a1f82","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"body":"doing `bool(...)` should have no effect here, it's implicitly done by the logical operations","created_at":"2018-10-09T14:32:30Z","updated_at":"2018-10-09T14:35:13Z","html_url":"https://github.com/mne-tools/mne-python/pull/5580#discussion_r223726931","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/223726931"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5580#discussion_r223726931"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580","id":220425548,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDI1NTQ4","html_url":"https://github.com/mne-tools/mne-python/pull/5580","diff_url":"https://github.com/mne-tools/mne-python/pull/5580.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5580.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5580","number":5580,"state":"open","locked":false,"title":"[MRG] fix _read_annot + dreprecate it","user":{"login":"massich","id":7044835,"node_id":"MDQ6VXNlcjcwNDQ4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7044835?v=4","gravatar_id":"","url":"https://api.github.com/users/massich","html_url":"https://github.com/massich","followers_url":"https://api.github.com/users/massich/followers","following_url":"https://api.github.com/users/massich/following{/other_user}","gists_url":"https://api.github.com/users/massich/gists{/gist_id}","starred_url":"https://api.github.com/users/massich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massich/subscriptions","organizations_url":"https://api.github.com/users/massich/orgs","repos_url":"https://api.github.com/users/massich/repos","events_url":"https://api.github.com/users/massich/events{/privacy}","received_events_url":"https://api.github.com/users/massich/received_events","type":"User","site_admin":false},"body":"I'm working on creating events from annotations for EDF files in #5574.\r\n\r\nI'm trying to read annotations, and I had troubles with different things. Anyway, covering `_read_annot` might help. \r\n\r\nCan anyone see what am I doing wrong on this test? Sure the problem is that the regex does not pick up anything. But what I'm not sure is if the problem is the code or the test.\r\n\r\nThx.\r\n\r\nping (based on blame): @teonbrooks, @larsoner, @agramfort","created_at":"2018-10-04T15:40:56Z","updated_at":"2018-10-09T14:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4230bb70e5dbc91c69e2bac98fa9e553e4162813","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5580/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/0ecf26640d03fc7409d500f51115f1bbad1a1f82","head":{"label":"massich:_read_annot","ref":"_read_annot","sha":"0ecf26640d03fc7409d500f51115f1bbad1a1f82","user":{"login":"massich","id":7044835,"node_id":"MDQ6VXNlcjcwNDQ4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7044835?v=4","gravatar_id":"","url":"https://api.github.com/users/massich","html_url":"https://github.com/massich","followers_url":"https://api.github.com/users/massich/followers","following_url":"https://api.github.com/users/massich/following{/other_user}","gists_url":"https://api.github.com/users/massich/gists{/gist_id}","starred_url":"https://api.github.com/users/massich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massich/subscriptions","organizations_url":"https://api.github.com/users/massich/orgs","repos_url":"https://api.github.com/users/massich/repos","events_url":"https://api.github.com/users/massich/events{/privacy}","received_events_url":"https://api.github.com/users/massich/received_events","type":"User","site_admin":false},"repo":{"id":97946362,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzk0NjM2Mg==","name":"mne-python","full_name":"massich/mne-python","private":false,"owner":{"login":"massich","id":7044835,"node_id":"MDQ6VXNlcjcwNDQ4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7044835?v=4","gravatar_id":"","url":"https://api.github.com/users/massich","html_url":"https://github.com/massich","followers_url":"https://api.github.com/users/massich/followers","following_url":"https://api.github.com/users/massich/following{/other_user}","gists_url":"https://api.github.com/users/massich/gists{/gist_id}","starred_url":"https://api.github.com/users/massich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massich/subscriptions","organizations_url":"https://api.github.com/users/massich/orgs","repos_url":"https://api.github.com/users/massich/repos","events_url":"https://api.github.com/users/massich/events{/privacy}","received_events_url":"https://api.github.com/users/massich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/massich/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/massich/mne-python","forks_url":"https://api.github.com/repos/massich/mne-python/forks","keys_url":"https://api.github.com/repos/massich/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massich/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massich/mne-python/teams","hooks_url":"https://api.github.com/repos/massich/mne-python/hooks","issue_events_url":"https://api.github.com/repos/massich/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/massich/mne-python/events","assignees_url":"https://api.github.com/repos/massich/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/massich/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/massich/mne-python/tags","blobs_url":"https://api.github.com/repos/massich/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massich/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massich/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/massich/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massich/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/massich/mne-python/languages","stargazers_url":"https://api.github.com/repos/massich/mne-python/stargazers","contributors_url":"https://api.github.com/repos/massich/mne-python/contributors","subscribers_url":"https://api.github.com/repos/massich/mne-python/subscribers","subscription_url":"https://api.github.com/repos/massich/mne-python/subscription","commits_url":"https://api.github.com/repos/massich/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/massich/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/massich/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/massich/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/massich/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/massich/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massich/mne-python/merges","archive_url":"https://api.github.com/repos/massich/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massich/mne-python/downloads","issues_url":"https://api.github.com/repos/massich/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/massich/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/massich/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/massich/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massich/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/massich/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/massich/mne-python/deployments","created_at":"2017-07-21T12:41:17Z","updated_at":"2018-10-08T15:55:14Z","pushed_at":"2018-10-09T08:03:45Z","git_url":"git://github.com/massich/mne-python.git","ssh_url":"git@github.com:massich/mne-python.git","clone_url":"https://github.com/massich/mne-python.git","svn_url":"https://github.com/massich/mne-python","homepage":"http://martinos.org/mne/","size":101848,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"fa119971035fb8cf0f92acc98c846645d5f410d2","user":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxNTg0","name":"mne-python","full_name":"mne-tools/mne-python","private":false,"owner":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2018-10-09T07:43:29Z","pushed_at":"2018-10-09T14:30:47Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":102032,"stargazers_count":614,"watchers_count":614,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":449,"mirror_url":null,"archived":false,"open_issues_count":270,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":449,"open_issues":270,"watchers":614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5580"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5580"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5580/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5580/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/0ecf26640d03fc7409d500f51115f1bbad1a1f82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"larsoner"}}