{"action":"created","comment":{"url":"https://api.github.com/repos/dogtagpki/jss/pulls/comments/237108660","pull_request_review_id":179326783,"id":237108660,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzEwODY2MA==","diff_hunk":"@@ -202,6 +209,30 @@ macro(jss_tests)\n     )\n endmacro()\n \n+macro(jss_tests_compile)\n+    jss_tests_compile_c(\"${PROJECT_SOURCE_DIR}/org/mozilla/jss/tests/TestBufferPRFD.c\" \"${BIN_OUTPUT_DIR}/TestBufferPRFD\" \"TestBufferPRFD\")\n+endmacro()\n+\n+macro(jss_tests_compile_c C_FILE C_OUTPUT C_TARGET)\n+    # Generate the target executable from C_FILE\n+\n+    add_custom_command(\n+        OUTPUT \"${C_OUTPUT}\"\n+        COMMAND ${CMAKE_C_COMPILER} ${JSS_C_FLAGS} -o ${C_OUTPUT} ${C_FILE} ${JSS_LD_FLAGS}","path":"cmake/JSSTests.cmake","position":34,"original_position":34,"commit_id":"4f150939be99188d6c945fefaaeddede4ead36eb","original_commit_id":"4f150939be99188d6c945fefaaeddede4ead36eb","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"body":"Ubuntu was using an older GCC compiler, which strictly requires linker flags to be at the end.","created_at":"2018-11-28T14:36:57Z","updated_at":"2018-11-28T14:36:58Z","html_url":"https://github.com/dogtagpki/jss/pull/93#discussion_r237108660","pull_request_url":"https://api.github.com/repos/dogtagpki/jss/pulls/93","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/comments/237108660"},"html":{"href":"https://github.com/dogtagpki/jss/pull/93#discussion_r237108660"},"pull_request":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/dogtagpki/jss/pulls/93","id":234023432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDIzNDMy","html_url":"https://github.com/dogtagpki/jss/pull/93","diff_url":"https://github.com/dogtagpki/jss/pull/93.diff","patch_url":"https://github.com/dogtagpki/jss/pull/93.patch","issue_url":"https://api.github.com/repos/dogtagpki/jss/issues/93","number":93,"state":"open","locked":false,"title":"[WIP] Implement a NSPR PRFileDesc using buffers","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"body":"This PR is blocked on #92 and includes commits from it; it will be rebased when merged.\r\n\r\nIn order to support the `javax.net.ssl.SSLEngine` interface, we need to implement SSL-over-buffers instead of SSL over Sockets. This is the first step towards that: implementing a `PRFileDesc` which NSS can wrap with SSL to provide read/write methods. This can then be used in Java and then used to implement SSLEngine.\r\n\r\nThere are two commits here:\r\n\r\n- Add the `PRFileDesc` implementation as a new header\r\n- Use this new header in a test to ensure that it provides the requisite features.\r\n\r\nMuch of this code was previewed in [`cipherboy/testbed/c-prfd`](https://github.com/cipherboy/testbed/tree/master/c-prfd) before being cleaned up and introduced to JSS. ","created_at":"2018-11-27T18:56:07Z","updated_at":"2018-11-28T14:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"002cd51f227bd3bd76798151e0e3f72b84d260d9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"edewata","id":25089672,"node_id":"MDQ6VXNlcjI1MDg5Njcy","avatar_url":"https://avatars0.githubusercontent.com/u/25089672?v=4","gravatar_id":"","url":"https://api.github.com/users/edewata","html_url":"https://github.com/edewata","followers_url":"https://api.github.com/users/edewata/followers","following_url":"https://api.github.com/users/edewata/following{/other_user}","gists_url":"https://api.github.com/users/edewata/gists{/gist_id}","starred_url":"https://api.github.com/users/edewata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edewata/subscriptions","organizations_url":"https://api.github.com/users/edewata/orgs","repos_url":"https://api.github.com/users/edewata/repos","events_url":"https://api.github.com/users/edewata/events{/privacy}","received_events_url":"https://api.github.com/users/edewata/received_events","type":"User","site_admin":false},{"login":"jmagne","id":25108658,"node_id":"MDQ6VXNlcjI1MTA4NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25108658?v=4","gravatar_id":"","url":"https://api.github.com/users/jmagne","html_url":"https://github.com/jmagne","followers_url":"https://api.github.com/users/jmagne/followers","following_url":"https://api.github.com/users/jmagne/following{/other_user}","gists_url":"https://api.github.com/users/jmagne/gists{/gist_id}","starred_url":"https://api.github.com/users/jmagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmagne/subscriptions","organizations_url":"https://api.github.com/users/jmagne/orgs","repos_url":"https://api.github.com/users/jmagne/repos","events_url":"https://api.github.com/users/jmagne/events{/privacy}","received_events_url":"https://api.github.com/users/jmagne/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1094613011,"node_id":"MDU6TGFiZWwxMDk0NjEzMDEx","url":"https://api.github.com/repos/dogtagpki/jss/labels/blocked","name":"blocked","color":"992211","default":false},{"id":1134620626,"node_id":"MDU6TGFiZWwxMTM0NjIwNjI2","url":"https://api.github.com/repos/dogtagpki/jss/labels/javax","name":"javax","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/dogtagpki/jss/milestones/5","html_url":"https://github.com/dogtagpki/jss/milestone/5","labels_url":"https://api.github.com/repos/dogtagpki/jss/milestones/5/labels","id":3852691,"node_id":"MDk6TWlsZXN0b25lMzg1MjY5MQ==","number":5,"title":"4.5.2","description":"Changes related to JSS release 4.5.2.","creator":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-11-27T20:06:19Z","updated_at":"2018-11-27T20:06:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dogtagpki/jss/pulls/93/commits","review_comments_url":"https://api.github.com/repos/dogtagpki/jss/pulls/93/comments","review_comment_url":"https://api.github.com/repos/dogtagpki/jss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dogtagpki/jss/issues/93/comments","statuses_url":"https://api.github.com/repos/dogtagpki/jss/statuses/4f150939be99188d6c945fefaaeddede4ead36eb","head":{"label":"cipherboy:buffer-prfd","ref":"buffer-prfd","sha":"4f150939be99188d6c945fefaaeddede4ead36eb","user":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"repo":{"id":135578842,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1Nzg4NDI=","name":"jss","full_name":"cipherboy/jss","private":false,"owner":{"login":"cipherboy","id":914030,"node_id":"MDQ6VXNlcjkxNDAzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/914030?v=4","gravatar_id":"","url":"https://api.github.com/users/cipherboy","html_url":"https://github.com/cipherboy","followers_url":"https://api.github.com/users/cipherboy/followers","following_url":"https://api.github.com/users/cipherboy/following{/other_user}","gists_url":"https://api.github.com/users/cipherboy/gists{/gist_id}","starred_url":"https://api.github.com/users/cipherboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipherboy/subscriptions","organizations_url":"https://api.github.com/users/cipherboy/orgs","repos_url":"https://api.github.com/users/cipherboy/repos","events_url":"https://api.github.com/users/cipherboy/events{/privacy}","received_events_url":"https://api.github.com/users/cipherboy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cipherboy/jss","description":null,"fork":true,"url":"https://api.github.com/repos/cipherboy/jss","forks_url":"https://api.github.com/repos/cipherboy/jss/forks","keys_url":"https://api.github.com/repos/cipherboy/jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cipherboy/jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cipherboy/jss/teams","hooks_url":"https://api.github.com/repos/cipherboy/jss/hooks","issue_events_url":"https://api.github.com/repos/cipherboy/jss/issues/events{/number}","events_url":"https://api.github.com/repos/cipherboy/jss/events","assignees_url":"https://api.github.com/repos/cipherboy/jss/assignees{/user}","branches_url":"https://api.github.com/repos/cipherboy/jss/branches{/branch}","tags_url":"https://api.github.com/repos/cipherboy/jss/tags","blobs_url":"https://api.github.com/repos/cipherboy/jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cipherboy/jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cipherboy/jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/cipherboy/jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cipherboy/jss/statuses/{sha}","languages_url":"https://api.github.com/repos/cipherboy/jss/languages","stargazers_url":"https://api.github.com/repos/cipherboy/jss/stargazers","contributors_url":"https://api.github.com/repos/cipherboy/jss/contributors","subscribers_url":"https://api.github.com/repos/cipherboy/jss/subscribers","subscription_url":"https://api.github.com/repos/cipherboy/jss/subscription","commits_url":"https://api.github.com/repos/cipherboy/jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/cipherboy/jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/cipherboy/jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/cipherboy/jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/cipherboy/jss/contents/{+path}","compare_url":"https://api.github.com/repos/cipherboy/jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cipherboy/jss/merges","archive_url":"https://api.github.com/repos/cipherboy/jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cipherboy/jss/downloads","issues_url":"https://api.github.com/repos/cipherboy/jss/issues{/number}","pulls_url":"https://api.github.com/repos/cipherboy/jss/pulls{/number}","milestones_url":"https://api.github.com/repos/cipherboy/jss/milestones{/number}","notifications_url":"https://api.github.com/repos/cipherboy/jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cipherboy/jss/labels{/name}","releases_url":"https://api.github.com/repos/cipherboy/jss/releases{/id}","deployments_url":"https://api.github.com/repos/cipherboy/jss/deployments","created_at":"2018-05-31T12:10:37Z","updated_at":"2018-11-27T19:49:14Z","pushed_at":"2018-11-27T21:23:07Z","git_url":"git://github.com/cipherboy/jss.git","ssh_url":"git@github.com:cipherboy/jss.git","clone_url":"https://github.com/cipherboy/jss.git","svn_url":"https://github.com/cipherboy/jss","homepage":null,"size":4833,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dogtagpki:master","ref":"master","sha":"96b116192c468b834f00bc71b7f96ab8bb099337","user":{"login":"dogtagpki","id":25308299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzA4Mjk5","avatar_url":"https://avatars3.githubusercontent.com/u/25308299?v=4","gravatar_id":"","url":"https://api.github.com/users/dogtagpki","html_url":"https://github.com/dogtagpki","followers_url":"https://api.github.com/users/dogtagpki/followers","following_url":"https://api.github.com/users/dogtagpki/following{/other_user}","gists_url":"https://api.github.com/users/dogtagpki/gists{/gist_id}","starred_url":"https://api.github.com/users/dogtagpki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogtagpki/subscriptions","organizations_url":"https://api.github.com/users/dogtagpki/orgs","repos_url":"https://api.github.com/users/dogtagpki/repos","events_url":"https://api.github.com/users/dogtagpki/events{/privacy}","received_events_url":"https://api.github.com/users/dogtagpki/received_events","type":"Organization","site_admin":false},"repo":{"id":128414640,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MTQ2NDA=","name":"jss","full_name":"dogtagpki/jss","private":false,"owner":{"login":"dogtagpki","id":25308299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzA4Mjk5","avatar_url":"https://avatars3.githubusercontent.com/u/25308299?v=4","gravatar_id":"","url":"https://api.github.com/users/dogtagpki","html_url":"https://github.com/dogtagpki","followers_url":"https://api.github.com/users/dogtagpki/followers","following_url":"https://api.github.com/users/dogtagpki/following{/other_user}","gists_url":"https://api.github.com/users/dogtagpki/gists{/gist_id}","starred_url":"https://api.github.com/users/dogtagpki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogtagpki/subscriptions","organizations_url":"https://api.github.com/users/dogtagpki/orgs","repos_url":"https://api.github.com/users/dogtagpki/repos","events_url":"https://api.github.com/users/dogtagpki/events{/privacy}","received_events_url":"https://api.github.com/users/dogtagpki/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dogtagpki/jss","description":"JSS issues should be reported to the JSS Pagure Issues site ","fork":false,"url":"https://api.github.com/repos/dogtagpki/jss","forks_url":"https://api.github.com/repos/dogtagpki/jss/forks","keys_url":"https://api.github.com/repos/dogtagpki/jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dogtagpki/jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dogtagpki/jss/teams","hooks_url":"https://api.github.com/repos/dogtagpki/jss/hooks","issue_events_url":"https://api.github.com/repos/dogtagpki/jss/issues/events{/number}","events_url":"https://api.github.com/repos/dogtagpki/jss/events","assignees_url":"https://api.github.com/repos/dogtagpki/jss/assignees{/user}","branches_url":"https://api.github.com/repos/dogtagpki/jss/branches{/branch}","tags_url":"https://api.github.com/repos/dogtagpki/jss/tags","blobs_url":"https://api.github.com/repos/dogtagpki/jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dogtagpki/jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dogtagpki/jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/dogtagpki/jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dogtagpki/jss/statuses/{sha}","languages_url":"https://api.github.com/repos/dogtagpki/jss/languages","stargazers_url":"https://api.github.com/repos/dogtagpki/jss/stargazers","contributors_url":"https://api.github.com/repos/dogtagpki/jss/contributors","subscribers_url":"https://api.github.com/repos/dogtagpki/jss/subscribers","subscription_url":"https://api.github.com/repos/dogtagpki/jss/subscription","commits_url":"https://api.github.com/repos/dogtagpki/jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/dogtagpki/jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/dogtagpki/jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/dogtagpki/jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/dogtagpki/jss/contents/{+path}","compare_url":"https://api.github.com/repos/dogtagpki/jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dogtagpki/jss/merges","archive_url":"https://api.github.com/repos/dogtagpki/jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dogtagpki/jss/downloads","issues_url":"https://api.github.com/repos/dogtagpki/jss/issues{/number}","pulls_url":"https://api.github.com/repos/dogtagpki/jss/pulls{/number}","milestones_url":"https://api.github.com/repos/dogtagpki/jss/milestones{/number}","notifications_url":"https://api.github.com/repos/dogtagpki/jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dogtagpki/jss/labels{/name}","releases_url":"https://api.github.com/repos/dogtagpki/jss/releases{/id}","deployments_url":"https://api.github.com/repos/dogtagpki/jss/deployments","created_at":"2018-04-06T15:45:25Z","updated_at":"2018-11-28T14:31:46Z","pushed_at":"2018-11-28T14:31:44Z","git_url":"git://github.com/dogtagpki/jss.git","ssh_url":"git@github.com:dogtagpki/jss.git","clone_url":"https://github.com/dogtagpki/jss.git","svn_url":"https://github.com/dogtagpki/jss","homepage":"https://pagure.io/jss/issues","size":5008,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/93"},"html":{"href":"https://github.com/dogtagpki/jss/pull/93"},"issue":{"href":"https://api.github.com/repos/dogtagpki/jss/issues/93"},"comments":{"href":"https://api.github.com/repos/dogtagpki/jss/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dogtagpki/jss/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/dogtagpki/jss/statuses/4f150939be99188d6c945fefaaeddede4ead36eb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cipherboy"}}