{"action":"created","comment":{"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/comments/229352497","pull_request_review_id":169832842,"id":229352497,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTM1MjQ5Nw==","diff_hunk":"@@ -183,16 +155,17 @@ else\n     ovn_sb=\"$PROTOCOL://$MASTER1:6642\"\n fi\n \n+TOKEN=`sudo cat /vagrant/token`","path":"vagrant/provisioning/setup-minion.sh","position":122,"original_position":122,"commit_id":"ca66bc5c09f0a5284948b1912954b31df0e5ea18","original_commit_id":"ca66bc5c09f0a5284948b1912954b31df0e5ea18","user":{"login":"shettyg","id":4305021,"node_id":"MDQ6VXNlcjQzMDUwMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4305021?v=4","gravatar_id":"","url":"https://api.github.com/users/shettyg","html_url":"https://github.com/shettyg","followers_url":"https://api.github.com/users/shettyg/followers","following_url":"https://api.github.com/users/shettyg/following{/other_user}","gists_url":"https://api.github.com/users/shettyg/gists{/gist_id}","starred_url":"https://api.github.com/users/shettyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shettyg/subscriptions","organizations_url":"https://api.github.com/users/shettyg/orgs","repos_url":"https://api.github.com/users/shettyg/repos","events_url":"https://api.github.com/users/shettyg/events{/privacy}","received_events_url":"https://api.github.com/users/shettyg/received_events","type":"User","site_admin":false},"body":"The documentation for vagrant asks to start master first. So I think we are okay here.","created_at":"2018-10-30T15:19:59Z","updated_at":"2018-10-30T15:19:59Z","html_url":"https://github.com/openvswitch/ovn-kubernetes/pull/461#discussion_r229352497","pull_request_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/comments/229352497"},"html":{"href":"https://github.com/openvswitch/ovn-kubernetes/pull/461#discussion_r229352497"},"pull_request":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461"}},"in_reply_to_id":229171699},"pull_request":{"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461","id":225521562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTIxNTYy","html_url":"https://github.com/openvswitch/ovn-kubernetes/pull/461","diff_url":"https://github.com/openvswitch/ovn-kubernetes/pull/461.diff","patch_url":"https://github.com/openvswitch/ovn-kubernetes/pull/461.patch","issue_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/461","number":461,"state":"open","locked":false,"title":"Vagrant: Use kubeadm to start k8s components.","user":{"login":"shettyg","id":4305021,"node_id":"MDQ6VXNlcjQzMDUwMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4305021?v=4","gravatar_id":"","url":"https://api.github.com/users/shettyg","html_url":"https://github.com/shettyg","followers_url":"https://api.github.com/users/shettyg/followers","following_url":"https://api.github.com/users/shettyg/following{/other_user}","gists_url":"https://api.github.com/users/shettyg/gists{/gist_id}","starred_url":"https://api.github.com/users/shettyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shettyg/subscriptions","organizations_url":"https://api.github.com/users/shettyg/orgs","repos_url":"https://api.github.com/users/shettyg/repos","events_url":"https://api.github.com/users/shettyg/events{/privacy}","received_events_url":"https://api.github.com/users/shettyg/received_events","type":"User","site_admin":false},"body":"The goal is to run OVN daemonsets. This commit\r\ndoes not achieve it. But OVN daemonsets\r\nneed tokens and certificates. To make it easy,\r\ntransition vagrant to first use kubeadm.\r\nOnce this is done, we can have an option to\r\nuse daemonsets.\r\n\r\nSigned-off-by: Gurucharan Shetty <guru@ovn.org>","created_at":"2018-10-24T19:25:06Z","updated_at":"2018-10-30T15:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92666fa2c440fb28cd8c5d6f8fe722ba2620f55c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461/commits","review_comments_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461/comments","review_comment_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/461/comments","statuses_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/statuses/ca66bc5c09f0a5284948b1912954b31df0e5ea18","head":{"label":"shettyg:vagrant","ref":"vagrant","sha":"ca66bc5c09f0a5284948b1912954b31df0e5ea18","user":{"login":"shettyg","id":4305021,"node_id":"MDQ6VXNlcjQzMDUwMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4305021?v=4","gravatar_id":"","url":"https://api.github.com/users/shettyg","html_url":"https://github.com/shettyg","followers_url":"https://api.github.com/users/shettyg/followers","following_url":"https://api.github.com/users/shettyg/following{/other_user}","gists_url":"https://api.github.com/users/shettyg/gists{/gist_id}","starred_url":"https://api.github.com/users/shettyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shettyg/subscriptions","organizations_url":"https://api.github.com/users/shettyg/orgs","repos_url":"https://api.github.com/users/shettyg/repos","events_url":"https://api.github.com/users/shettyg/events{/privacy}","received_events_url":"https://api.github.com/users/shettyg/received_events","type":"User","site_admin":false},"repo":{"id":65769846,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc2OTg0Ng==","name":"ovn-kubernetes","full_name":"shettyg/ovn-kubernetes","private":false,"owner":{"login":"shettyg","id":4305021,"node_id":"MDQ6VXNlcjQzMDUwMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4305021?v=4","gravatar_id":"","url":"https://api.github.com/users/shettyg","html_url":"https://github.com/shettyg","followers_url":"https://api.github.com/users/shettyg/followers","following_url":"https://api.github.com/users/shettyg/following{/other_user}","gists_url":"https://api.github.com/users/shettyg/gists{/gist_id}","starred_url":"https://api.github.com/users/shettyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shettyg/subscriptions","organizations_url":"https://api.github.com/users/shettyg/orgs","repos_url":"https://api.github.com/users/shettyg/repos","events_url":"https://api.github.com/users/shettyg/events{/privacy}","received_events_url":"https://api.github.com/users/shettyg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shettyg/ovn-kubernetes","description":"Kubernetes integration for OVN","fork":true,"url":"https://api.github.com/repos/shettyg/ovn-kubernetes","forks_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/forks","keys_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/teams","hooks_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/events","assignees_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/tags","blobs_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/languages","stargazers_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/subscription","commits_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/merges","archive_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/downloads","issues_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/shettyg/ovn-kubernetes/deployments","created_at":"2016-08-15T22:42:15Z","updated_at":"2018-04-11T01:43:07Z","pushed_at":"2018-10-30T03:39:29Z","git_url":"git://github.com/shettyg/ovn-kubernetes.git","ssh_url":"git@github.com:shettyg/ovn-kubernetes.git","clone_url":"https://github.com/shettyg/ovn-kubernetes.git","svn_url":"https://github.com/shettyg/ovn-kubernetes","homepage":null,"size":15760,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"openvswitch:master","ref":"master","sha":"281e08b613be189d69415037bcb4b4ff9142a8ce","user":{"login":"openvswitch","id":7143863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7143863?v=4","gravatar_id":"","url":"https://api.github.com/users/openvswitch","html_url":"https://github.com/openvswitch","followers_url":"https://api.github.com/users/openvswitch/followers","following_url":"https://api.github.com/users/openvswitch/following{/other_user}","gists_url":"https://api.github.com/users/openvswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/openvswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvswitch/subscriptions","organizations_url":"https://api.github.com/users/openvswitch/orgs","repos_url":"https://api.github.com/users/openvswitch/repos","events_url":"https://api.github.com/users/openvswitch/events{/privacy}","received_events_url":"https://api.github.com/users/openvswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":65489927,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQ4OTkyNw==","name":"ovn-kubernetes","full_name":"openvswitch/ovn-kubernetes","private":false,"owner":{"login":"openvswitch","id":7143863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDM4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7143863?v=4","gravatar_id":"","url":"https://api.github.com/users/openvswitch","html_url":"https://github.com/openvswitch","followers_url":"https://api.github.com/users/openvswitch/followers","following_url":"https://api.github.com/users/openvswitch/following{/other_user}","gists_url":"https://api.github.com/users/openvswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/openvswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvswitch/subscriptions","organizations_url":"https://api.github.com/users/openvswitch/orgs","repos_url":"https://api.github.com/users/openvswitch/repos","events_url":"https://api.github.com/users/openvswitch/events{/privacy}","received_events_url":"https://api.github.com/users/openvswitch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openvswitch/ovn-kubernetes","description":"Kubernetes integration for OVN","fork":false,"url":"https://api.github.com/repos/openvswitch/ovn-kubernetes","forks_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/forks","keys_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/teams","hooks_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/events","assignees_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/tags","blobs_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/languages","stargazers_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/subscription","commits_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/merges","archive_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/downloads","issues_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/openvswitch/ovn-kubernetes/deployments","created_at":"2016-08-11T17:51:02Z","updated_at":"2018-10-30T04:20:19Z","pushed_at":"2018-10-30T04:20:15Z","git_url":"git://github.com/openvswitch/ovn-kubernetes.git","ssh_url":"git@github.com:openvswitch/ovn-kubernetes.git","clone_url":"https://github.com/openvswitch/ovn-kubernetes.git","svn_url":"https://github.com/openvswitch/ovn-kubernetes","homepage":null,"size":15713,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":95,"open_issues":32,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461"},"html":{"href":"https://github.com/openvswitch/ovn-kubernetes/pull/461"},"issue":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/461"},"comments":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/openvswitch/ovn-kubernetes/statuses/ca66bc5c09f0a5284948b1912954b31df0e5ea18"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shettyg"}}