{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/respec/pulls/comments/173617321","pull_request_review_id":102846037,"id":173617321,"diff_hunk":"@@ -160,6 +160,32 @@ describe(\"Core — Issues and Notes\", function() {\n     );\n   });\n \n+  it(\"removes closed issues from spec\", async () => {\n+    const githubConfig = {\n+      github: \"https://github.com/mock-company/mock-repository\",\n+      githubAPI: `${window.location.origin}/tests/data/mock-github-api-v3-response.json`","path":"tests/spec/core/issues-notes-spec.js","position":7,"original_position":7,"commit_id":"97d8237aaf77fc9135fa06891a61f95ffa56c48b","original_commit_id":"97d8237aaf77fc9135fa06891a61f95ffa56c48b","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"this may end up being incompatible with:\r\nhttps://github.com/w3c/respec/pull/1560/files#diff-0cfbbabe5bc2a8772222d1152309dd3eR144\r\n\r\nHere we probably want: `${window.location.origin}/tests/data/`\r\n\r\nAnd we should resolve to: `${window.location.origin}/tests/data/issues/1540`\r\n\r\n\"1540\" should just be a the json file. Alternatively, you might be able to just add \"?testing=\", which should also work: \r\n\r\n```js\r\n${window.location.origin}/tests/data/mock-github-api-v3-issue-response.json?testing=\r\n``` \r\n","created_at":"2018-03-10T09:40:38Z","updated_at":"2018-03-10T09:50:23Z","html_url":"https://github.com/w3c/respec/pull/1506#discussion_r173617321","pull_request_url":"https://api.github.com/repos/w3c/respec/pulls/1506","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/w3c/respec/pulls/comments/173617321"},"html":{"href":"https://github.com/w3c/respec/pull/1506#discussion_r173617321"},"pull_request":{"href":"https://api.github.com/repos/w3c/respec/pulls/1506"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/respec/pulls/1506","id":169083478,"html_url":"https://github.com/w3c/respec/pull/1506","diff_url":"https://github.com/w3c/respec/pull/1506.diff","patch_url":"https://github.com/w3c/respec/pull/1506.patch","issue_url":"https://api.github.com/repos/w3c/respec/issues/1506","number":1506,"state":"open","locked":false,"title":"Closed issues are now removed from the spec","user":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"body":"fixes: #670 \r\nI tried writing tests but when I was logging inside the test console I found out the changes made in `issue-notes.js` were not reflecting somehow inside the test written for the same file inside `issue-notes-spec.js`. Please tell me how to move about with the test","created_at":"2018-02-14T11:20:39Z","updated_at":"2018-03-10T09:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4103bbb6646581523ab4439a8f53bbb74148907","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/respec/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/w3c/respec/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/w3c/respec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/respec/issues/1506/comments","statuses_url":"https://api.github.com/repos/w3c/respec/statuses/97d8237aaf77fc9135fa06891a61f95ffa56c48b","head":{"label":"himanish-star:closed-issues","ref":"closed-issues","sha":"97d8237aaf77fc9135fa06891a61f95ffa56c48b","user":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"repo":{"id":120054641,"name":"respec","full_name":"himanish-star/respec","owner":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/himanish-star/respec","description":"A tool for creating technical documents and web standards","fork":true,"url":"https://api.github.com/repos/himanish-star/respec","forks_url":"https://api.github.com/repos/himanish-star/respec/forks","keys_url":"https://api.github.com/repos/himanish-star/respec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himanish-star/respec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himanish-star/respec/teams","hooks_url":"https://api.github.com/repos/himanish-star/respec/hooks","issue_events_url":"https://api.github.com/repos/himanish-star/respec/issues/events{/number}","events_url":"https://api.github.com/repos/himanish-star/respec/events","assignees_url":"https://api.github.com/repos/himanish-star/respec/assignees{/user}","branches_url":"https://api.github.com/repos/himanish-star/respec/branches{/branch}","tags_url":"https://api.github.com/repos/himanish-star/respec/tags","blobs_url":"https://api.github.com/repos/himanish-star/respec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himanish-star/respec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himanish-star/respec/git/refs{/sha}","trees_url":"https://api.github.com/repos/himanish-star/respec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himanish-star/respec/statuses/{sha}","languages_url":"https://api.github.com/repos/himanish-star/respec/languages","stargazers_url":"https://api.github.com/repos/himanish-star/respec/stargazers","contributors_url":"https://api.github.com/repos/himanish-star/respec/contributors","subscribers_url":"https://api.github.com/repos/himanish-star/respec/subscribers","subscription_url":"https://api.github.com/repos/himanish-star/respec/subscription","commits_url":"https://api.github.com/repos/himanish-star/respec/commits{/sha}","git_commits_url":"https://api.github.com/repos/himanish-star/respec/git/commits{/sha}","comments_url":"https://api.github.com/repos/himanish-star/respec/comments{/number}","issue_comment_url":"https://api.github.com/repos/himanish-star/respec/issues/comments{/number}","contents_url":"https://api.github.com/repos/himanish-star/respec/contents/{+path}","compare_url":"https://api.github.com/repos/himanish-star/respec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himanish-star/respec/merges","archive_url":"https://api.github.com/repos/himanish-star/respec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himanish-star/respec/downloads","issues_url":"https://api.github.com/repos/himanish-star/respec/issues{/number}","pulls_url":"https://api.github.com/repos/himanish-star/respec/pulls{/number}","milestones_url":"https://api.github.com/repos/himanish-star/respec/milestones{/number}","notifications_url":"https://api.github.com/repos/himanish-star/respec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himanish-star/respec/labels{/name}","releases_url":"https://api.github.com/repos/himanish-star/respec/releases{/id}","deployments_url":"https://api.github.com/repos/himanish-star/respec/deployments","created_at":"2018-02-03T03:05:16Z","updated_at":"2018-02-03T03:05:19Z","pushed_at":"2018-03-10T04:18:21Z","git_url":"git://github.com/himanish-star/respec.git","ssh_url":"git@github.com:himanish-star/respec.git","clone_url":"https://github.com/himanish-star/respec.git","svn_url":"https://github.com/himanish-star/respec","homepage":"","size":35898,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"w3c:develop","ref":"develop","sha":"ac55e11a148a198548964c9b0691caca9c61cdb8","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":4287066,"name":"respec","full_name":"w3c/respec","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/respec","description":"A tool for creating technical documents and web standards","fork":false,"url":"https://api.github.com/repos/w3c/respec","forks_url":"https://api.github.com/repos/w3c/respec/forks","keys_url":"https://api.github.com/repos/w3c/respec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/respec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/respec/teams","hooks_url":"https://api.github.com/repos/w3c/respec/hooks","issue_events_url":"https://api.github.com/repos/w3c/respec/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/respec/events","assignees_url":"https://api.github.com/repos/w3c/respec/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/respec/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/respec/tags","blobs_url":"https://api.github.com/repos/w3c/respec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/respec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/respec/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/respec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/respec/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/respec/languages","stargazers_url":"https://api.github.com/repos/w3c/respec/stargazers","contributors_url":"https://api.github.com/repos/w3c/respec/contributors","subscribers_url":"https://api.github.com/repos/w3c/respec/subscribers","subscription_url":"https://api.github.com/repos/w3c/respec/subscription","commits_url":"https://api.github.com/repos/w3c/respec/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/respec/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/respec/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/respec/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/respec/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/respec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/respec/merges","archive_url":"https://api.github.com/repos/w3c/respec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/respec/downloads","issues_url":"https://api.github.com/repos/w3c/respec/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/respec/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/respec/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/respec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/respec/labels{/name}","releases_url":"https://api.github.com/repos/w3c/respec/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/respec/deployments","created_at":"2012-05-10T16:39:37Z","updated_at":"2018-03-09T14:29:32Z","pushed_at":"2018-03-10T09:46:37Z","git_url":"git://github.com/w3c/respec.git","ssh_url":"git@github.com:w3c/respec.git","clone_url":"https://github.com/w3c/respec.git","svn_url":"https://github.com/w3c/respec","homepage":"","size":36095,"stargazers_count":223,"watchers_count":223,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":179,"open_issues":137,"watchers":223,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/respec/pulls/1506"},"html":{"href":"https://github.com/w3c/respec/pull/1506"},"issue":{"href":"https://api.github.com/repos/w3c/respec/issues/1506"},"comments":{"href":"https://api.github.com/repos/w3c/respec/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/respec/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/respec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/respec/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/respec/statuses/97d8237aaf77fc9135fa06891a61f95ffa56c48b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marcoscaceres"}}