{"action":"closed","number":82,"pull_request":{"url":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82","id":185381291,"html_url":"https://github.com/thecodingmachine/tdbm/pull/82","diff_url":"https://github.com/thecodingmachine/tdbm/pull/82.diff","patch_url":"https://github.com/thecodingmachine/tdbm/pull/82.patch","issue_url":"https://api.github.com/repos/thecodingmachine/tdbm/issues/82","number":82,"state":"closed","locked":false,"title":"Weakref issue: the garbage collector can be triggered between \"has\" and \"get\"","user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars1.githubusercontent.com/u/1290952?v=4","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"body":"See #80.\r\n\r\nThis PR solves the problem by removing the \"has\" method from the StorageInterface and removing all calls to $weakRef->valid() if they can be replaced by a $weakRef->get() + a check on a null return value.","created_at":"2018-05-02T09:25:42Z","updated_at":"2018-05-02T10:13:44Z","closed_at":"2018-05-02T10:13:44Z","merged_at":"2018-05-02T10:13:44Z","merge_commit_sha":"9b92585a57d88746748419caed8319f706fc4a13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82/commits","review_comments_url":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82/comments","review_comment_url":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thecodingmachine/tdbm/issues/82/comments","statuses_url":"https://api.github.com/repos/thecodingmachine/tdbm/statuses/1c82f3960706d4aebb77556d09cee109bb0338e4","head":{"label":"moufmouf:fix_weakref_garbagecollector_valid","ref":"fix_weakref_garbagecollector_valid","sha":"1c82f3960706d4aebb77556d09cee109bb0338e4","user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars1.githubusercontent.com/u/1290952?v=4","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"repo":{"id":91340346,"name":"tdbm","full_name":"moufmouf/tdbm","owner":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars1.githubusercontent.com/u/1290952?v=4","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moufmouf/tdbm","description":"The Database Machine is a PHP ORM that requires no configuration. The object model is deduced from the database model.","fork":true,"url":"https://api.github.com/repos/moufmouf/tdbm","forks_url":"https://api.github.com/repos/moufmouf/tdbm/forks","keys_url":"https://api.github.com/repos/moufmouf/tdbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moufmouf/tdbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moufmouf/tdbm/teams","hooks_url":"https://api.github.com/repos/moufmouf/tdbm/hooks","issue_events_url":"https://api.github.com/repos/moufmouf/tdbm/issues/events{/number}","events_url":"https://api.github.com/repos/moufmouf/tdbm/events","assignees_url":"https://api.github.com/repos/moufmouf/tdbm/assignees{/user}","branches_url":"https://api.github.com/repos/moufmouf/tdbm/branches{/branch}","tags_url":"https://api.github.com/repos/moufmouf/tdbm/tags","blobs_url":"https://api.github.com/repos/moufmouf/tdbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moufmouf/tdbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moufmouf/tdbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/moufmouf/tdbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moufmouf/tdbm/statuses/{sha}","languages_url":"https://api.github.com/repos/moufmouf/tdbm/languages","stargazers_url":"https://api.github.com/repos/moufmouf/tdbm/stargazers","contributors_url":"https://api.github.com/repos/moufmouf/tdbm/contributors","subscribers_url":"https://api.github.com/repos/moufmouf/tdbm/subscribers","subscription_url":"https://api.github.com/repos/moufmouf/tdbm/subscription","commits_url":"https://api.github.com/repos/moufmouf/tdbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/moufmouf/tdbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/moufmouf/tdbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/moufmouf/tdbm/issues/comments{/number}","contents_url":"https://api.github.com/repos/moufmouf/tdbm/contents/{+path}","compare_url":"https://api.github.com/repos/moufmouf/tdbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moufmouf/tdbm/merges","archive_url":"https://api.github.com/repos/moufmouf/tdbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moufmouf/tdbm/downloads","issues_url":"https://api.github.com/repos/moufmouf/tdbm/issues{/number}","pulls_url":"https://api.github.com/repos/moufmouf/tdbm/pulls{/number}","milestones_url":"https://api.github.com/repos/moufmouf/tdbm/milestones{/number}","notifications_url":"https://api.github.com/repos/moufmouf/tdbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moufmouf/tdbm/labels{/name}","releases_url":"https://api.github.com/repos/moufmouf/tdbm/releases{/id}","deployments_url":"https://api.github.com/repos/moufmouf/tdbm/deployments","created_at":"2017-05-15T13:21:10Z","updated_at":"2017-05-15T13:21:12Z","pushed_at":"2018-05-02T09:53:46Z","git_url":"git://github.com/moufmouf/tdbm.git","ssh_url":"git@github.com:moufmouf/tdbm.git","clone_url":"https://github.com/moufmouf/tdbm.git","svn_url":"https://github.com/moufmouf/tdbm","homepage":null,"size":2669,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.x"}},"base":{"label":"thecodingmachine:master","ref":"master","sha":"c3aac13cda535ad301b61f4ea959ba5cc7ce23b0","user":{"login":"thecodingmachine","id":1847918,"avatar_url":"https://avatars1.githubusercontent.com/u/1847918?v=4","gravatar_id":"","url":"https://api.github.com/users/thecodingmachine","html_url":"https://github.com/thecodingmachine","followers_url":"https://api.github.com/users/thecodingmachine/followers","following_url":"https://api.github.com/users/thecodingmachine/following{/other_user}","gists_url":"https://api.github.com/users/thecodingmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/thecodingmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecodingmachine/subscriptions","organizations_url":"https://api.github.com/users/thecodingmachine/orgs","repos_url":"https://api.github.com/users/thecodingmachine/repos","events_url":"https://api.github.com/users/thecodingmachine/events{/privacy}","received_events_url":"https://api.github.com/users/thecodingmachine/received_events","type":"Organization","site_admin":false},"repo":{"id":90133769,"name":"tdbm","full_name":"thecodingmachine/tdbm","owner":{"login":"thecodingmachine","id":1847918,"avatar_url":"https://avatars1.githubusercontent.com/u/1847918?v=4","gravatar_id":"","url":"https://api.github.com/users/thecodingmachine","html_url":"https://github.com/thecodingmachine","followers_url":"https://api.github.com/users/thecodingmachine/followers","following_url":"https://api.github.com/users/thecodingmachine/following{/other_user}","gists_url":"https://api.github.com/users/thecodingmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/thecodingmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecodingmachine/subscriptions","organizations_url":"https://api.github.com/users/thecodingmachine/orgs","repos_url":"https://api.github.com/users/thecodingmachine/repos","events_url":"https://api.github.com/users/thecodingmachine/events{/privacy}","received_events_url":"https://api.github.com/users/thecodingmachine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thecodingmachine/tdbm","description":"The Database Machine is a PHP ORM that requires no configuration. The object model is deduced from the database model.","fork":false,"url":"https://api.github.com/repos/thecodingmachine/tdbm","forks_url":"https://api.github.com/repos/thecodingmachine/tdbm/forks","keys_url":"https://api.github.com/repos/thecodingmachine/tdbm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thecodingmachine/tdbm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thecodingmachine/tdbm/teams","hooks_url":"https://api.github.com/repos/thecodingmachine/tdbm/hooks","issue_events_url":"https://api.github.com/repos/thecodingmachine/tdbm/issues/events{/number}","events_url":"https://api.github.com/repos/thecodingmachine/tdbm/events","assignees_url":"https://api.github.com/repos/thecodingmachine/tdbm/assignees{/user}","branches_url":"https://api.github.com/repos/thecodingmachine/tdbm/branches{/branch}","tags_url":"https://api.github.com/repos/thecodingmachine/tdbm/tags","blobs_url":"https://api.github.com/repos/thecodingmachine/tdbm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thecodingmachine/tdbm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thecodingmachine/tdbm/git/refs{/sha}","trees_url":"https://api.github.com/repos/thecodingmachine/tdbm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thecodingmachine/tdbm/statuses/{sha}","languages_url":"https://api.github.com/repos/thecodingmachine/tdbm/languages","stargazers_url":"https://api.github.com/repos/thecodingmachine/tdbm/stargazers","contributors_url":"https://api.github.com/repos/thecodingmachine/tdbm/contributors","subscribers_url":"https://api.github.com/repos/thecodingmachine/tdbm/subscribers","subscription_url":"https://api.github.com/repos/thecodingmachine/tdbm/subscription","commits_url":"https://api.github.com/repos/thecodingmachine/tdbm/commits{/sha}","git_commits_url":"https://api.github.com/repos/thecodingmachine/tdbm/git/commits{/sha}","comments_url":"https://api.github.com/repos/thecodingmachine/tdbm/comments{/number}","issue_comment_url":"https://api.github.com/repos/thecodingmachine/tdbm/issues/comments{/number}","contents_url":"https://api.github.com/repos/thecodingmachine/tdbm/contents/{+path}","compare_url":"https://api.github.com/repos/thecodingmachine/tdbm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thecodingmachine/tdbm/merges","archive_url":"https://api.github.com/repos/thecodingmachine/tdbm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thecodingmachine/tdbm/downloads","issues_url":"https://api.github.com/repos/thecodingmachine/tdbm/issues{/number}","pulls_url":"https://api.github.com/repos/thecodingmachine/tdbm/pulls{/number}","milestones_url":"https://api.github.com/repos/thecodingmachine/tdbm/milestones{/number}","notifications_url":"https://api.github.com/repos/thecodingmachine/tdbm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thecodingmachine/tdbm/labels{/name}","releases_url":"https://api.github.com/repos/thecodingmachine/tdbm/releases{/id}","deployments_url":"https://api.github.com/repos/thecodingmachine/tdbm/deployments","created_at":"2017-05-03T09:49:14Z","updated_at":"2018-04-25T20:20:05Z","pushed_at":"2018-05-02T10:13:44Z","git_url":"git://github.com/thecodingmachine/tdbm.git","ssh_url":"git@github.com:thecodingmachine/tdbm.git","clone_url":"https://github.com/thecodingmachine/tdbm.git","svn_url":"https://github.com/thecodingmachine/tdbm","homepage":"https://thecodingmachine.github.io/tdbm/","size":4110,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":10,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82"},"html":{"href":"https://github.com/thecodingmachine/tdbm/pull/82"},"issue":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/issues/82"},"comments":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/thecodingmachine/tdbm/statuses/1c82f3960706d4aebb77556d09cee109bb0338e4"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars1.githubusercontent.com/u/1290952?v=4","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":63,"deletions":90,"changed_files":8}}
{"actor":{"display_login":"moufmouf"}}