{"action":"created","comment":{"url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/comments/183737680","pull_request_review_id":114791767,"id":183737680,"diff_hunk":"@@ -5,7 +5,7 @@ software = {\n     stable : {\n         main : {\n             images: ({\n-                filename = \"core-image-pelux-minimal-raspberrypi3.ext3.gz\";\n+                filename = \"PELUX_IMAGE\";","path":"recipes-extended/images/pelux-image-update/raspberrypi3/sw-description","position":5,"original_position":5,"commit_id":"086ff615f2eebfeba0e9c74a25adeaaedcad0f06","original_commit_id":"086ff615f2eebfeba0e9c74a25adeaaedcad0f06","user":{"login":"FlorentRevest","id":908424,"avatar_url":"https://avatars0.githubusercontent.com/u/908424?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorentRevest","html_url":"https://github.com/FlorentRevest","followers_url":"https://api.github.com/users/FlorentRevest/followers","following_url":"https://api.github.com/users/FlorentRevest/following{/other_user}","gists_url":"https://api.github.com/users/FlorentRevest/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentRevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentRevest/subscriptions","organizations_url":"https://api.github.com/users/FlorentRevest/orgs","repos_url":"https://api.github.com/users/FlorentRevest/repos","events_url":"https://api.github.com/users/FlorentRevest/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentRevest/received_events","type":"User","site_admin":false},"body":"I'm not saying this is a beautiful solution I am proud of but I couldn't find anything better given the constraints of meta-swupdate :smiley:  ","created_at":"2018-04-24T13:52:07Z","updated_at":"2018-04-24T13:52:07Z","html_url":"https://github.com/Pelagicore/meta-pelux/pull/113#discussion_r183737680","pull_request_url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/comments/183737680"},"html":{"href":"https://github.com/Pelagicore/meta-pelux/pull/113#discussion_r183737680"},"pull_request":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113"}},"in_reply_to_id":183718681},"pull_request":{"url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113","id":183702309,"html_url":"https://github.com/Pelagicore/meta-pelux/pull/113","diff_url":"https://github.com/Pelagicore/meta-pelux/pull/113.diff","patch_url":"https://github.com/Pelagicore/meta-pelux/pull/113.patch","issue_url":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/113","number":113,"state":"open","locked":false,"title":"Generify SWUpdate artifacts targets","user":{"login":"FlorentRevest","id":908424,"avatar_url":"https://avatars0.githubusercontent.com/u/908424?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorentRevest","html_url":"https://github.com/FlorentRevest","followers_url":"https://api.github.com/users/FlorentRevest/followers","following_url":"https://api.github.com/users/FlorentRevest/following{/other_user}","gists_url":"https://api.github.com/users/FlorentRevest/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentRevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentRevest/subscriptions","organizations_url":"https://api.github.com/users/FlorentRevest/orgs","repos_url":"https://api.github.com/users/FlorentRevest/repos","events_url":"https://api.github.com/users/FlorentRevest/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentRevest/received_events","type":"User","site_admin":false},"body":"We rely on the meta-swupdate's swupdate.bbclass to generate .swu update\r\nartifacts for a given image. However, this bbclass requires to have one\r\nrecipe per artifact. Since we have four different targets, we need to\r\nfactorize the work between those four recipes.\r\n\r\nThis patch introduces a common pelux-image-update.inc file that can be\r\nincluded by all the artifacts recipes to generate appropriate artifacts\r\nfrom a set of generic config files.\r\n\r\nThis inc file finds sw-descriptor and scripts in MACHINE-specific\r\nsubdirectories of the pelux-image-update/ directory. In order to be kept\r\ngeneric, those sw-desciptors can refer to the \"PELUX_IMAGE\" token that\r\nwill be replaced by the name of the necessary PELUX image dynamically.\r\n\r\nSigned-off-by: Florent Revest <revestflo@gmail.com>","created_at":"2018-04-24T11:19:30Z","updated_at":"2018-04-24T13:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"869cc7684027223dd45b628d878bc0d2e1043cfe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DunderRoffe","id":5956077,"avatar_url":"https://avatars3.githubusercontent.com/u/5956077?v=4","gravatar_id":"","url":"https://api.github.com/users/DunderRoffe","html_url":"https://github.com/DunderRoffe","followers_url":"https://api.github.com/users/DunderRoffe/followers","following_url":"https://api.github.com/users/DunderRoffe/following{/other_user}","gists_url":"https://api.github.com/users/DunderRoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/DunderRoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DunderRoffe/subscriptions","organizations_url":"https://api.github.com/users/DunderRoffe/orgs","repos_url":"https://api.github.com/users/DunderRoffe/repos","events_url":"https://api.github.com/users/DunderRoffe/events{/privacy}","received_events_url":"https://api.github.com/users/DunderRoffe/received_events","type":"User","site_admin":false},{"login":"rpannek","id":8579375,"avatar_url":"https://avatars1.githubusercontent.com/u/8579375?v=4","gravatar_id":"","url":"https://api.github.com/users/rpannek","html_url":"https://github.com/rpannek","followers_url":"https://api.github.com/users/rpannek/followers","following_url":"https://api.github.com/users/rpannek/following{/other_user}","gists_url":"https://api.github.com/users/rpannek/gists{/gist_id}","starred_url":"https://api.github.com/users/rpannek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpannek/subscriptions","organizations_url":"https://api.github.com/users/rpannek/orgs","repos_url":"https://api.github.com/users/rpannek/repos","events_url":"https://api.github.com/users/rpannek/events{/privacy}","received_events_url":"https://api.github.com/users/rpannek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113/commits","review_comments_url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113/comments","review_comment_url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/113/comments","statuses_url":"https://api.github.com/repos/Pelagicore/meta-pelux/statuses/086ff615f2eebfeba0e9c74a25adeaaedcad0f06","head":{"label":"FlorentRevest:generic-swupdate-artifacts","ref":"generic-swupdate-artifacts","sha":"086ff615f2eebfeba0e9c74a25adeaaedcad0f06","user":{"login":"FlorentRevest","id":908424,"avatar_url":"https://avatars0.githubusercontent.com/u/908424?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorentRevest","html_url":"https://github.com/FlorentRevest","followers_url":"https://api.github.com/users/FlorentRevest/followers","following_url":"https://api.github.com/users/FlorentRevest/following{/other_user}","gists_url":"https://api.github.com/users/FlorentRevest/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentRevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentRevest/subscriptions","organizations_url":"https://api.github.com/users/FlorentRevest/orgs","repos_url":"https://api.github.com/users/FlorentRevest/repos","events_url":"https://api.github.com/users/FlorentRevest/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentRevest/received_events","type":"User","site_admin":false},"repo":{"id":119258575,"name":"meta-pelux","full_name":"FlorentRevest/meta-pelux","owner":{"login":"FlorentRevest","id":908424,"avatar_url":"https://avatars0.githubusercontent.com/u/908424?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorentRevest","html_url":"https://github.com/FlorentRevest","followers_url":"https://api.github.com/users/FlorentRevest/followers","following_url":"https://api.github.com/users/FlorentRevest/following{/other_user}","gists_url":"https://api.github.com/users/FlorentRevest/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorentRevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorentRevest/subscriptions","organizations_url":"https://api.github.com/users/FlorentRevest/orgs","repos_url":"https://api.github.com/users/FlorentRevest/repos","events_url":"https://api.github.com/users/FlorentRevest/events{/privacy}","received_events_url":"https://api.github.com/users/FlorentRevest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FlorentRevest/meta-pelux","description":"PELUX is an open source, GENIVI compliant platform that supports Qt Automotive Suite","fork":true,"url":"https://api.github.com/repos/FlorentRevest/meta-pelux","forks_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/forks","keys_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/teams","hooks_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/hooks","issue_events_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/issues/events{/number}","events_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/events","assignees_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/assignees{/user}","branches_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/branches{/branch}","tags_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/tags","blobs_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/statuses/{sha}","languages_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/languages","stargazers_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/stargazers","contributors_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/contributors","subscribers_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/subscribers","subscription_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/subscription","commits_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/issues/comments{/number}","contents_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/contents/{+path}","compare_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/merges","archive_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/downloads","issues_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/issues{/number}","pulls_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/pulls{/number}","milestones_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/milestones{/number}","notifications_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/labels{/name}","releases_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/releases{/id}","deployments_url":"https://api.github.com/repos/FlorentRevest/meta-pelux/deployments","created_at":"2018-01-28T13:01:35Z","updated_at":"2018-01-28T13:01:37Z","pushed_at":"2018-04-24T11:19:06Z","git_url":"git://github.com/FlorentRevest/meta-pelux.git","ssh_url":"git@github.com:FlorentRevest/meta-pelux.git","clone_url":"https://github.com/FlorentRevest/meta-pelux.git","svn_url":"https://github.com/FlorentRevest/meta-pelux","homepage":"","size":124,"stargazers_count":0,"watchers_count":0,"language":"BitBake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pelagicore:master","ref":"master","sha":"5e6d3281fd6b119285dafc3371644c44a70e075c","user":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars3.githubusercontent.com/u/4661080?v=4","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"repo":{"id":76042681,"name":"meta-pelux","full_name":"Pelagicore/meta-pelux","owner":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars3.githubusercontent.com/u/4661080?v=4","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pelagicore/meta-pelux","description":"PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite","fork":false,"url":"https://api.github.com/repos/Pelagicore/meta-pelux","forks_url":"https://api.github.com/repos/Pelagicore/meta-pelux/forks","keys_url":"https://api.github.com/repos/Pelagicore/meta-pelux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pelagicore/meta-pelux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pelagicore/meta-pelux/teams","hooks_url":"https://api.github.com/repos/Pelagicore/meta-pelux/hooks","issue_events_url":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/events{/number}","events_url":"https://api.github.com/repos/Pelagicore/meta-pelux/events","assignees_url":"https://api.github.com/repos/Pelagicore/meta-pelux/assignees{/user}","branches_url":"https://api.github.com/repos/Pelagicore/meta-pelux/branches{/branch}","tags_url":"https://api.github.com/repos/Pelagicore/meta-pelux/tags","blobs_url":"https://api.github.com/repos/Pelagicore/meta-pelux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pelagicore/meta-pelux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pelagicore/meta-pelux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pelagicore/meta-pelux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pelagicore/meta-pelux/statuses/{sha}","languages_url":"https://api.github.com/repos/Pelagicore/meta-pelux/languages","stargazers_url":"https://api.github.com/repos/Pelagicore/meta-pelux/stargazers","contributors_url":"https://api.github.com/repos/Pelagicore/meta-pelux/contributors","subscribers_url":"https://api.github.com/repos/Pelagicore/meta-pelux/subscribers","subscription_url":"https://api.github.com/repos/Pelagicore/meta-pelux/subscription","commits_url":"https://api.github.com/repos/Pelagicore/meta-pelux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pelagicore/meta-pelux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pelagicore/meta-pelux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pelagicore/meta-pelux/contents/{+path}","compare_url":"https://api.github.com/repos/Pelagicore/meta-pelux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pelagicore/meta-pelux/merges","archive_url":"https://api.github.com/repos/Pelagicore/meta-pelux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pelagicore/meta-pelux/downloads","issues_url":"https://api.github.com/repos/Pelagicore/meta-pelux/issues{/number}","pulls_url":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls{/number}","milestones_url":"https://api.github.com/repos/Pelagicore/meta-pelux/milestones{/number}","notifications_url":"https://api.github.com/repos/Pelagicore/meta-pelux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pelagicore/meta-pelux/labels{/name}","releases_url":"https://api.github.com/repos/Pelagicore/meta-pelux/releases{/id}","deployments_url":"https://api.github.com/repos/Pelagicore/meta-pelux/deployments","created_at":"2016-12-09T14:33:36Z","updated_at":"2018-04-24T08:05:18Z","pushed_at":"2018-04-24T11:19:31Z","git_url":"git://github.com/Pelagicore/meta-pelux.git","ssh_url":"git@github.com:Pelagicore/meta-pelux.git","clone_url":"https://github.com/Pelagicore/meta-pelux.git","svn_url":"https://github.com/Pelagicore/meta-pelux","homepage":"https://pelux.io","size":127,"stargazers_count":15,"watchers_count":15,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113"},"html":{"href":"https://github.com/Pelagicore/meta-pelux/pull/113"},"issue":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/113"},"comments":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/Pelagicore/meta-pelux/statuses/086ff615f2eebfeba0e9c74a25adeaaedcad0f06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FlorentRevest"}}