{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/194568338","pull_request_review_id":127766304,"id":194568338,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU2ODMzOA==","diff_hunk":"@@ -61,15 +61,45 @@ export const BuildsDetails: React.SFC<BuildsDetailsProps> = ({obj: build}) => {\n   </div>;\n };\n \n-const envPath = ['spec', 'strategy', 'sourceStrategy'];\n-const environmentComponent = (props) => <EnvironmentPage\n-  obj={props.obj}\n-  rawEnvData={props.obj.spec.strategy.sourceStrategy}\n-  envPath={envPath}\n-  readOnly={true}\n-/>;\n-\n-const pages = [navFactory.details(BuildsDetails), navFactory.editYaml(), navFactory.envEditor(environmentComponent), navFactory.logs(BuildLogs)];\n+export const getStrategyType = (strategy) => {\n+  switch (strategy.type) {\n+    case 'Docker':\n+      return 'dockerStrategy';\n+    case 'Custom':\n+      return 'customStrategy';\n+    case 'JenkinsPipeline':\n+      return 'jenkinsPipelineStrategy';\n+    case 'Source':\n+      return 'sourceStrategy';\n+    default:\n+      return null;\n+  }\n+};\n+\n+export const getEnvPath = (props) => {\n+  const strategyType = getStrategyType(props.obj.spec.strategy);\n+  return strategyType ? ['spec', 'strategy', strategyType] : null;\n+};\n+\n+export const BuildEnvironmentComponent = (props) => {","path":"frontend/public/components/build.tsx","position":33,"original_position":33,"commit_id":"d4cb3b5785b8e9585adfc1b6aae80d2b2a77aea1","original_commit_id":"d4cb3b5785b8e9585adfc1b6aae80d2b2a77aea1","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Since this is a minor nit, I tagged it for merge anyway :)","created_at":"2018-06-11T22:34:21Z","updated_at":"2018-06-11T22:34:21Z","html_url":"https://github.com/openshift/console/pull/111#discussion_r194568338","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/194568338"},"html":{"href":"https://github.com/openshift/console/pull/111#discussion_r194568338"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/111"}},"in_reply_to_id":194568095},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/111","id":193680484,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjgwNDg0","html_url":"https://github.com/openshift/console/pull/111","diff_url":"https://github.com/openshift/console/pull/111.diff","patch_url":"https://github.com/openshift/console/pull/111.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/111","number":111,"state":"open","locked":false,"title":"Add build strategy support in env editor","user":{"login":"jcaianirh","id":35978579,"node_id":"MDQ6VXNlcjM1OTc4NTc5","avatar_url":"https://avatars2.githubusercontent.com/u/35978579?v=4","gravatar_id":"","url":"https://api.github.com/users/jcaianirh","html_url":"https://github.com/jcaianirh","followers_url":"https://api.github.com/users/jcaianirh/followers","following_url":"https://api.github.com/users/jcaianirh/following{/other_user}","gists_url":"https://api.github.com/users/jcaianirh/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaianirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaianirh/subscriptions","organizations_url":"https://api.github.com/users/jcaianirh/orgs","repos_url":"https://api.github.com/users/jcaianirh/repos","events_url":"https://api.github.com/users/jcaianirh/events{/privacy}","received_events_url":"https://api.github.com/users/jcaianirh/received_events","type":"User","site_admin":false},"body":"Add support for the following strategies in the env editor for builds and build configs:\r\n\r\n- dockerStrategy\r\n\r\n- sourceStrategy\r\n\r\n- customStrategy\r\n\r\n- jenkinsPipelineStrategy","created_at":"2018-06-08T17:44:00Z","updated_at":"2018-06-11T22:34:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9e5794029b974a7c4a0bdf8415ee8cbf0b3a693","assignee":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"assignees":[{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926926095,"node_id":"MDU6TGFiZWw5MjY5MjYwOTU=","url":"https://api.github.com/repos/openshift/console/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":926923478,"node_id":"MDU6TGFiZWw5MjY5MjM0Nzg=","url":"https://api.github.com/repos/openshift/console/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/111/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/111/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/111/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/d4cb3b5785b8e9585adfc1b6aae80d2b2a77aea1","head":{"label":"jcaianirh:env-strategy","ref":"env-strategy","sha":"d4cb3b5785b8e9585adfc1b6aae80d2b2a77aea1","user":{"login":"jcaianirh","id":35978579,"node_id":"MDQ6VXNlcjM1OTc4NTc5","avatar_url":"https://avatars2.githubusercontent.com/u/35978579?v=4","gravatar_id":"","url":"https://api.github.com/users/jcaianirh","html_url":"https://github.com/jcaianirh","followers_url":"https://api.github.com/users/jcaianirh/followers","following_url":"https://api.github.com/users/jcaianirh/following{/other_user}","gists_url":"https://api.github.com/users/jcaianirh/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaianirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaianirh/subscriptions","organizations_url":"https://api.github.com/users/jcaianirh/orgs","repos_url":"https://api.github.com/users/jcaianirh/repos","events_url":"https://api.github.com/users/jcaianirh/events{/privacy}","received_events_url":"https://api.github.com/users/jcaianirh/received_events","type":"User","site_admin":false},"repo":{"id":133171268,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNzEyNjg=","name":"console","full_name":"jcaianirh/console","owner":{"login":"jcaianirh","id":35978579,"node_id":"MDQ6VXNlcjM1OTc4NTc5","avatar_url":"https://avatars2.githubusercontent.com/u/35978579?v=4","gravatar_id":"","url":"https://api.github.com/users/jcaianirh","html_url":"https://github.com/jcaianirh","followers_url":"https://api.github.com/users/jcaianirh/followers","following_url":"https://api.github.com/users/jcaianirh/following{/other_user}","gists_url":"https://api.github.com/users/jcaianirh/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaianirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaianirh/subscriptions","organizations_url":"https://api.github.com/users/jcaianirh/orgs","repos_url":"https://api.github.com/users/jcaianirh/repos","events_url":"https://api.github.com/users/jcaianirh/events{/privacy}","received_events_url":"https://api.github.com/users/jcaianirh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcaianirh/console","description":"Tectonic Console UI","fork":true,"url":"https://api.github.com/repos/jcaianirh/console","forks_url":"https://api.github.com/repos/jcaianirh/console/forks","keys_url":"https://api.github.com/repos/jcaianirh/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcaianirh/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcaianirh/console/teams","hooks_url":"https://api.github.com/repos/jcaianirh/console/hooks","issue_events_url":"https://api.github.com/repos/jcaianirh/console/issues/events{/number}","events_url":"https://api.github.com/repos/jcaianirh/console/events","assignees_url":"https://api.github.com/repos/jcaianirh/console/assignees{/user}","branches_url":"https://api.github.com/repos/jcaianirh/console/branches{/branch}","tags_url":"https://api.github.com/repos/jcaianirh/console/tags","blobs_url":"https://api.github.com/repos/jcaianirh/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcaianirh/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcaianirh/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcaianirh/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcaianirh/console/statuses/{sha}","languages_url":"https://api.github.com/repos/jcaianirh/console/languages","stargazers_url":"https://api.github.com/repos/jcaianirh/console/stargazers","contributors_url":"https://api.github.com/repos/jcaianirh/console/contributors","subscribers_url":"https://api.github.com/repos/jcaianirh/console/subscribers","subscription_url":"https://api.github.com/repos/jcaianirh/console/subscription","commits_url":"https://api.github.com/repos/jcaianirh/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcaianirh/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcaianirh/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcaianirh/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcaianirh/console/contents/{+path}","compare_url":"https://api.github.com/repos/jcaianirh/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcaianirh/console/merges","archive_url":"https://api.github.com/repos/jcaianirh/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcaianirh/console/downloads","issues_url":"https://api.github.com/repos/jcaianirh/console/issues{/number}","pulls_url":"https://api.github.com/repos/jcaianirh/console/pulls{/number}","milestones_url":"https://api.github.com/repos/jcaianirh/console/milestones{/number}","notifications_url":"https://api.github.com/repos/jcaianirh/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcaianirh/console/labels{/name}","releases_url":"https://api.github.com/repos/jcaianirh/console/releases{/id}","deployments_url":"https://api.github.com/repos/jcaianirh/console/deployments","created_at":"2018-05-12T18:02:32Z","updated_at":"2018-06-07T14:33:13Z","pushed_at":"2018-06-11T22:18:59Z","git_url":"git://github.com/jcaianirh/console.git","ssh_url":"git@github.com:jcaianirh/console.git","clone_url":"https://github.com/jcaianirh/console.git","svn_url":"https://github.com/jcaianirh/console","homepage":null,"size":86468,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e39cd7fc3b279e6db01a44c33a31daf31432ddb9","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-06-11T20:10:38Z","pushed_at":"2018-06-11T22:19:02Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":86452,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":26,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/111"},"html":{"href":"https://github.com/openshift/console/pull/111"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/111"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/d4cb3b5785b8e9585adfc1b6aae80d2b2a77aea1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spadgett"}}