{"action":"opened","issue":{"url":"https://api.github.com/repos/aatxe/irc/issues/167","repository_url":"https://api.github.com/repos/aatxe/irc","labels_url":"https://api.github.com/repos/aatxe/irc/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/aatxe/irc/issues/167/comments","events_url":"https://api.github.com/repos/aatxe/irc/issues/167/events","html_url":"https://github.com/aatxe/irc/issues/167","id":390773491,"node_id":"MDU6SXNzdWUzOTA3NzM0OTE=","number":167,"title":"irc 0.13.6 may panic on ping timeout","user":{"login":"kpcyrd","id":7763184,"node_id":"MDQ6VXNlcjc3NjMxODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7763184?v=4","gravatar_id":"","url":"https://api.github.com/users/kpcyrd","html_url":"https://github.com/kpcyrd","followers_url":"https://api.github.com/users/kpcyrd/followers","following_url":"https://api.github.com/users/kpcyrd/following{/other_user}","gists_url":"https://api.github.com/users/kpcyrd/gists{/gist_id}","starred_url":"https://api.github.com/users/kpcyrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpcyrd/subscriptions","organizations_url":"https://api.github.com/users/kpcyrd/orgs","repos_url":"https://api.github.com/users/kpcyrd/repos","events_url":"https://api.github.com/users/kpcyrd/events{/privacy}","received_events_url":"https://api.github.com/users/kpcyrd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T17:05:04Z","updated_at":"2018-12-13T17:05:04Z","closed_at":null,"author_association":"NONE","body":"I just noticed I still had a project running that was connected using the irc crate and apparently a thread panic'ed while switching networks during the day:\r\n```\r\nthread '<unnamed>' panicked at 'connection reset: no ping response', /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/irc-0.13.6/src/client/mod.rs:707:41\r\nnote: Run with `RUST_BACKTRACE=1` for a backtrace.\r\nthread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: PingTimeout', libcore/result.rs:1009:5\r\n```\r\n\r\nThe relevant code seems to be:\r\n```rust\r\nlet outgoing_future = sink.send_all(rx_outgoing.map_err::<error::IrcError, _>(|_| {\r\n    unreachable!(\"futures::sync::mpsc::Receiver should never return Err\");\r\n})).map(|_| ()).map_err(|e| panic!(\"{}\", e));\r\n\r\n```"}}
{"actor":{"display_login":"kpcyrd"}}