{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/438","repository_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node","labels_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/438/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/438/events","html_url":"https://github.com/Microsoft/vscode-languageserver-node/issues/438","id":390155447,"node_id":"MDU6SXNzdWUzOTAxNTU0NDc=","number":438,"title":"VS Code is sending us incorrect completionItem/resolve data in CompletionItem.kind","user":{"login":"sean-mcmanus","id":19859882,"node_id":"MDQ6VXNlcjE5ODU5ODgy","avatar_url":"https://avatars0.githubusercontent.com/u/19859882?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-mcmanus","html_url":"https://github.com/sean-mcmanus","followers_url":"https://api.github.com/users/sean-mcmanus/followers","following_url":"https://api.github.com/users/sean-mcmanus/following{/other_user}","gists_url":"https://api.github.com/users/sean-mcmanus/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-mcmanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-mcmanus/subscriptions","organizations_url":"https://api.github.com/users/sean-mcmanus/orgs","repos_url":"https://api.github.com/users/sean-mcmanus/repos","events_url":"https://api.github.com/users/sean-mcmanus/events{/privacy}","received_events_url":"https://api.github.com/users/sean-mcmanus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-12T03:42:42Z","updated_at":"2018-12-13T08:42:35Z","closed_at":"2018-12-13T08:42:35Z","author_association":"NONE","body":"Our C/C++ extension is adding completionItem_resolve support, but even though the initial textDocument_completion we send to VS Code has the correct CompletionItem.kind data, the data we get back in the completionItem_resolve has the incorrect type, which causes all the icons to become incorrect as the user scrolls through the completion list. We're using the 3.5.1 vscode-languageclient.\r\n\r\n![image](https://user-images.githubusercontent.com/19859882/49845540-f3ecfe80-fd7b-11e8-8472-639b6c4f0b83.png)\r\n\r\nThe data we send has a \"kind\" value of 21, but we get back a \"kind\" value of 1:\r\n```\r\n{\r\n    \"jsonrpc\": \"2.0\",\r\n    \"id\": 37,\r\n    \"result\": {\r\n        \"isIncomplete\": false,\r\n        \"items\": [\r\n            {\r\n                \"label\": \"macro1\",\r\n                \"kind\": 21,\r\n                \"detail\": \"#define macro1 \",\r\n                \"sortText\": \"1macro1\",\r\n                \"textEdit\": {\r\n                    \"range\": {\r\n                        \"start\": {\r\n                            \"line\": 5,\r\n                            \"character\": 4\r\n                        },\r\n                        \"end\": {\r\n                            \"line\": 5,\r\n                            \"character\": 10\r\n                        }\r\n                    },\r\n                    \"newText\": \"macro1\"\r\n                },\r\n                \"data\": {\r\n                    \"file\": \"...\",\r\n                    \"symbolPosition\": {\r\n                        \"line\": 3,\r\n                        \"character\": 12\r\n                    }\r\n                }\r\n            },\r\n```\r\n```\r\n{\r\n    \"jsonrpc\": \"2.0\",\r\n    \"id\": 38,\r\n    \"method\": \"completionItem/resolve\",\r\n    \"params\": {\r\n        \"label\": \"macro1\",\r\n        \"detail\": \"#define macro1 \",\r\n        \"insertTextFormat\": 1,\r\n        \"textEdit\": {\r\n            \"newText\": \"macro1\",\r\n            \"range\": {\r\n                \"start\": {\r\n                    \"line\": 5,\r\n                    \"character\": 4\r\n                },\r\n                \"end\": {\r\n                    \"line\": 5,\r\n                    \"character\": 10\r\n                }\r\n            }\r\n        },\r\n        \"kind\": 1,\r\n        \"sortText\": \"1macro1\",\r\n        \"data\": {\r\n            \"file\": \"...\",\r\n            \"symbolPosition\": {\r\n                \"line\": 3,\r\n                \"character\": 12\r\n            }\r\n        }\r\n    }\r\n}\r\n```\r\n\r\nThis bug only repros with the \"new\" CompletionItemKind values of 19-25: Folder, EnumMember, Constant, Struct, Event, Operator, and TypeParameter."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/comments/446886789","html_url":"https://github.com/Microsoft/vscode-languageserver-node/issues/438#issuecomment-446886789","issue_url":"https://api.github.com/repos/Microsoft/vscode-languageserver-node/issues/438","id":446886789,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njg4Njc4OQ==","user":{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T08:42:35Z","updated_at":"2018-12-13T08:42:35Z","author_association":"MEMBER","body":"This is how it works in the latest release. The spec for 3.5.2 only allowed the listed items. We relaxed that in a new version and if clients support this then they agreed to preserve the kind even if it is unknown to them.\r\n\r\n@sean-mcmanus I would highly recommend that you move to a newer version. We will very likely not do any fixing on 3.x versions. Why couldn't you upgrade?"}}
{"actor":{"display_login":"dbaeumer"}}