{"action":"created","comment":{"url":"https://api.github.com/repos/grafana/grafana/pulls/comments/184370952","pull_request_review_id":115552044,"id":184370952,"diff_hunk":"@@ -2,38 +2,6 @@ package migrations\n \n import . \"github.com/grafana/grafana/pkg/services/sqlstore/migrator\"\n \n-func addStatsMigrations(mg *Migrator) {","path":"pkg/services/sqlstore/migrations/stats_mig.go","position":4,"original_position":4,"commit_id":"d0cab456c44edeeac9206ebf77aed14c37d3ca36","original_commit_id":"d0cab456c44edeeac9206ebf77aed14c37d3ca36","user":{"login":"bergquist","id":618863,"avatar_url":"https://avatars0.githubusercontent.com/u/618863?v=4","gravatar_id":"","url":"https://api.github.com/users/bergquist","html_url":"https://github.com/bergquist","followers_url":"https://api.github.com/users/bergquist/followers","following_url":"https://api.github.com/users/bergquist/following{/other_user}","gists_url":"https://api.github.com/users/bergquist/gists{/gist_id}","starred_url":"https://api.github.com/users/bergquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergquist/subscriptions","organizations_url":"https://api.github.com/users/bergquist/orgs","repos_url":"https://api.github.com/users/bergquist/repos","events_url":"https://api.github.com/users/bergquist/events{/privacy}","received_events_url":"https://api.github.com/users/bergquist/received_events","type":"User","site_admin":false},"body":"please comment this code instead of deleting. ","created_at":"2018-04-26T12:31:57Z","updated_at":"2018-04-26T12:31:58Z","html_url":"https://github.com/grafana/grafana/pull/11713#discussion_r184370952","pull_request_url":"https://api.github.com/repos/grafana/grafana/pulls/11713","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments/184370952"},"html":{"href":"https://github.com/grafana/grafana/pull/11713#discussion_r184370952"},"pull_request":{"href":"https://api.github.com/repos/grafana/grafana/pulls/11713"}}},"pull_request":{"url":"https://api.github.com/repos/grafana/grafana/pulls/11713","id":183803188,"html_url":"https://github.com/grafana/grafana/pull/11713","diff_url":"https://github.com/grafana/grafana/pull/11713.diff","patch_url":"https://github.com/grafana/grafana/pull/11713.patch","issue_url":"https://api.github.com/repos/grafana/grafana/issues/11713","number":11713,"state":"open","locked":false,"title":"Fix deadcode issues","user":{"login":"mjtrangoni","id":261502,"avatar_url":"https://avatars1.githubusercontent.com/u/261502?v=4","gravatar_id":"","url":"https://api.github.com/users/mjtrangoni","html_url":"https://github.com/mjtrangoni","followers_url":"https://api.github.com/users/mjtrangoni/followers","following_url":"https://api.github.com/users/mjtrangoni/following{/other_user}","gists_url":"https://api.github.com/users/mjtrangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtrangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtrangoni/subscriptions","organizations_url":"https://api.github.com/users/mjtrangoni/orgs","repos_url":"https://api.github.com/users/mjtrangoni/repos","events_url":"https://api.github.com/users/mjtrangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mjtrangoni/received_events","type":"User","site_admin":false},"body":"Hi @bergquist,\r\n\r\nRelated to #10381, I fixed all [deadcode](https://github.com/tsenart/deadcode) issues and added this check to CircleCI. See,\r\n\r\n```\r\nbuild.go:26:1:warning: versionRe is unused (deadcode)\r\nbuild.go:47:1:warning: minGoVersion is unused (deadcode)\r\nbuild.go:329:1:warning: verifyGitRepoIsClean is unused (deadcode)\r\nbuild.go:355:1:warning: ChangeWorkingDir is unused (deadcode)\r\nbuild.go:495:1:warning: buildArch is unused (deadcode)\r\nbuild.go:503:1:warning: run is unused (deadcode)\r\npkg/api/annotations.go:298:1:warning: canSaveByRegionID is unused (deadcode)\r\npkg/middleware/render_auth.go:34:1:warning: renderContextFunc is unused (deadcode)\r\npkg/services/sqlstore/migrations/stats_mig.go:5:1:warning: addStatsMigrations is unused (deadcode)\r\n```\r\n\r\nTell me if I should restore some code and just comment it out instead.","created_at":"2018-04-24T17:02:18Z","updated_at":"2018-04-26T12:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"906fde7da5ebca3d834a7e3f8e3406d11f5bc96e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grafana/grafana/pulls/11713/commits","review_comments_url":"https://api.github.com/repos/grafana/grafana/pulls/11713/comments","review_comment_url":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/11713/comments","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/d0cab456c44edeeac9206ebf77aed14c37d3ca36","head":{"label":"mjtrangoni:fix-deadcode-issues","ref":"fix-deadcode-issues","sha":"d0cab456c44edeeac9206ebf77aed14c37d3ca36","user":{"login":"mjtrangoni","id":261502,"avatar_url":"https://avatars1.githubusercontent.com/u/261502?v=4","gravatar_id":"","url":"https://api.github.com/users/mjtrangoni","html_url":"https://github.com/mjtrangoni","followers_url":"https://api.github.com/users/mjtrangoni/followers","following_url":"https://api.github.com/users/mjtrangoni/following{/other_user}","gists_url":"https://api.github.com/users/mjtrangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtrangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtrangoni/subscriptions","organizations_url":"https://api.github.com/users/mjtrangoni/orgs","repos_url":"https://api.github.com/users/mjtrangoni/repos","events_url":"https://api.github.com/users/mjtrangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mjtrangoni/received_events","type":"User","site_admin":false},"repo":{"id":129437593,"name":"grafana","full_name":"mjtrangoni/grafana","owner":{"login":"mjtrangoni","id":261502,"avatar_url":"https://avatars1.githubusercontent.com/u/261502?v=4","gravatar_id":"","url":"https://api.github.com/users/mjtrangoni","html_url":"https://github.com/mjtrangoni","followers_url":"https://api.github.com/users/mjtrangoni/followers","following_url":"https://api.github.com/users/mjtrangoni/following{/other_user}","gists_url":"https://api.github.com/users/mjtrangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtrangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtrangoni/subscriptions","organizations_url":"https://api.github.com/users/mjtrangoni/orgs","repos_url":"https://api.github.com/users/mjtrangoni/repos","events_url":"https://api.github.com/users/mjtrangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mjtrangoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjtrangoni/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":true,"url":"https://api.github.com/repos/mjtrangoni/grafana","forks_url":"https://api.github.com/repos/mjtrangoni/grafana/forks","keys_url":"https://api.github.com/repos/mjtrangoni/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjtrangoni/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjtrangoni/grafana/teams","hooks_url":"https://api.github.com/repos/mjtrangoni/grafana/hooks","issue_events_url":"https://api.github.com/repos/mjtrangoni/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/mjtrangoni/grafana/events","assignees_url":"https://api.github.com/repos/mjtrangoni/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/mjtrangoni/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/mjtrangoni/grafana/tags","blobs_url":"https://api.github.com/repos/mjtrangoni/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjtrangoni/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjtrangoni/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjtrangoni/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjtrangoni/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/mjtrangoni/grafana/languages","stargazers_url":"https://api.github.com/repos/mjtrangoni/grafana/stargazers","contributors_url":"https://api.github.com/repos/mjtrangoni/grafana/contributors","subscribers_url":"https://api.github.com/repos/mjtrangoni/grafana/subscribers","subscription_url":"https://api.github.com/repos/mjtrangoni/grafana/subscription","commits_url":"https://api.github.com/repos/mjtrangoni/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjtrangoni/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjtrangoni/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjtrangoni/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjtrangoni/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/mjtrangoni/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjtrangoni/grafana/merges","archive_url":"https://api.github.com/repos/mjtrangoni/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjtrangoni/grafana/downloads","issues_url":"https://api.github.com/repos/mjtrangoni/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/mjtrangoni/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/mjtrangoni/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/mjtrangoni/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjtrangoni/grafana/labels{/name}","releases_url":"https://api.github.com/repos/mjtrangoni/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/mjtrangoni/grafana/deployments","created_at":"2018-04-13T18:07:25Z","updated_at":"2018-04-13T18:07:32Z","pushed_at":"2018-04-24T16:57:28Z","git_url":"git://github.com/mjtrangoni/grafana.git","ssh_url":"git@github.com:mjtrangoni/grafana.git","clone_url":"https://github.com/mjtrangoni/grafana.git","svn_url":"https://github.com/mjtrangoni/grafana","homepage":"https://grafana.com","size":179645,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grafana:master","ref":"master","sha":"d36efddcf7c00e561c2fb0db1f4ab24a31441885","user":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":15111821,"name":"grafana","full_name":"grafana/grafana","owner":{"login":"grafana","id":7195757,"avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grafana/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":false,"url":"https://api.github.com/repos/grafana/grafana","forks_url":"https://api.github.com/repos/grafana/grafana/forks","keys_url":"https://api.github.com/repos/grafana/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana/teams","hooks_url":"https://api.github.com/repos/grafana/grafana/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana/events","assignees_url":"https://api.github.com/repos/grafana/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana/tags","blobs_url":"https://api.github.com/repos/grafana/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana/subscription","commits_url":"https://api.github.com/repos/grafana/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana/merges","archive_url":"https://api.github.com/repos/grafana/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana/downloads","issues_url":"https://api.github.com/repos/grafana/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana/deployments","created_at":"2013-12-11T15:59:56Z","updated_at":"2018-04-26T09:57:51Z","pushed_at":"2018-04-26T12:28:01Z","git_url":"git://github.com/grafana/grafana.git","ssh_url":"git@github.com:grafana/grafana.git","clone_url":"https://github.com/grafana/grafana.git","svn_url":"https://github.com/grafana/grafana","homepage":"https://grafana.com","size":179768,"stargazers_count":21370,"watchers_count":21370,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3794,"mirror_url":null,"archived":false,"open_issues_count":1381,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3794,"open_issues":1381,"watchers":21370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/11713"},"html":{"href":"https://github.com/grafana/grafana/pull/11713"},"issue":{"href":"https://api.github.com/repos/grafana/grafana/issues/11713"},"comments":{"href":"https://api.github.com/repos/grafana/grafana/issues/11713/comments"},"review_comments":{"href":"https://api.github.com/repos/grafana/grafana/pulls/11713/comments"},"review_comment":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grafana/grafana/pulls/11713/commits"},"statuses":{"href":"https://api.github.com/repos/grafana/grafana/statuses/d0cab456c44edeeac9206ebf77aed14c37d3ca36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bergquist"}}