{"action":"created","comment":{"url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/comments/172019806","pull_request_review_id":100977919,"id":172019806,"diff_hunk":"@@ -0,0 +1,29 @@\n+package competition.subsystems.offboard.commands;\n+\n+import com.google.inject.Inject;\n+\n+import xbot.common.command.BaseCommandGroup;\n+\n+public class IdentifyAndPurePursuitToVisibleCubeCommand extends BaseCommandGroup {\n+    private final IdentifyTargetCubeCommand identifyCommand;\n+    \n+    @Inject\n+    public IdentifyAndPurePursuitToVisibleCubeCommand(\n+            StopRumbleCommand stopRumble,\n+            IdentifyTargetCubeCommand identify,\n+            RumbleIfNoTargetAvailableCommand rumble,\n+            PurePursuitToVisibleCubeCommand pursue) {\n+        this.identifyCommand = identify;\n+        pursue.setTargetCubeSupplier(() -> identify.getChosenTarget());\n+        \n+        // TODO: Don't rumble in auto","path":"Competition2018/src/main/java/competition/subsystems/offboard/commands/IdentifyAndPurePursuitToVisibleCubeCommand.java","position":19,"original_position":19,"commit_id":"7b2ca8b01d013cbf8f276ece2d37f6534351e567","original_commit_id":"7b2ca8b01d013cbf8f276ece2d37f6534351e567","user":{"login":"JohnGilb","id":3423606,"avatar_url":"https://avatars3.githubusercontent.com/u/3423606?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnGilb","html_url":"https://github.com/JohnGilb","followers_url":"https://api.github.com/users/JohnGilb/followers","following_url":"https://api.github.com/users/JohnGilb/following{/other_user}","gists_url":"https://api.github.com/users/JohnGilb/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnGilb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnGilb/subscriptions","organizations_url":"https://api.github.com/users/JohnGilb/orgs","repos_url":"https://api.github.com/users/JohnGilb/repos","events_url":"https://api.github.com/users/JohnGilb/events{/privacy}","received_events_url":"https://api.github.com/users/JohnGilb/received_events","type":"User","site_admin":false},"body":"=]","created_at":"2018-03-03T15:24:40Z","updated_at":"2018-03-03T15:24:40Z","html_url":"https://github.com/Team488/TeamXbot2018/pull/142#discussion_r172019806","pull_request_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/comments/172019806"},"html":{"href":"https://github.com/Team488/TeamXbot2018/pull/142#discussion_r172019806"},"pull_request":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142","id":172659440,"html_url":"https://github.com/Team488/TeamXbot2018/pull/142","diff_url":"https://github.com/Team488/TeamXbot2018/pull/142.diff","patch_url":"https://github.com/Team488/TeamXbot2018/pull/142.patch","issue_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/142","number":142,"state":"open","locked":false,"title":"Rumble when no cube","user":{"login":"WasabiFan","id":3310349,"avatar_url":"https://avatars0.githubusercontent.com/u/3310349?v=4","gravatar_id":"","url":"https://api.github.com/users/WasabiFan","html_url":"https://github.com/WasabiFan","followers_url":"https://api.github.com/users/WasabiFan/followers","following_url":"https://api.github.com/users/WasabiFan/following{/other_user}","gists_url":"https://api.github.com/users/WasabiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WasabiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WasabiFan/subscriptions","organizations_url":"https://api.github.com/users/WasabiFan/orgs","repos_url":"https://api.github.com/users/WasabiFan/repos","events_url":"https://api.github.com/users/WasabiFan/events{/privacy}","received_events_url":"https://api.github.com/users/WasabiFan/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/Team488/TeamXbot2018/pull/141 (diff for just the new changes is at https://github.com/Team488/TeamXbot2018/commit/7b2ca8b01d013cbf8f276ece2d37f6534351e567).\r\n\r\nDepends on https://github.com/Team488/SeriouslyCommonLib/pull/157\r\n\r\n---\r\n\r\nI created a `RumbleManager` because I want to be able to initiate rumble from within a command group; doing this as a blocking command would mean that the requirements of all other commands in the group are held until the rumble ends (in this case, no driving until the rumble ends).","created_at":"2018-03-03T09:40:56Z","updated_at":"2018-03-03T15:24:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bc8a96a5ee90163cf3e0073e15a41fe57ca9ab2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142/commits","review_comments_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142/comments","review_comment_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/142/comments","statuses_url":"https://api.github.com/repos/Team488/TeamXbot2018/statuses/7b2ca8b01d013cbf8f276ece2d37f6534351e567","head":{"label":"Team488:rumble-when-no-cube","ref":"rumble-when-no-cube","sha":"7b2ca8b01d013cbf8f276ece2d37f6534351e567","user":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"repo":{"id":116896266,"name":"TeamXbot2018","full_name":"Team488/TeamXbot2018","owner":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team488/TeamXbot2018","description":"Competition code for the 2018 Power Up Season","fork":false,"url":"https://api.github.com/repos/Team488/TeamXbot2018","forks_url":"https://api.github.com/repos/Team488/TeamXbot2018/forks","keys_url":"https://api.github.com/repos/Team488/TeamXbot2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team488/TeamXbot2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team488/TeamXbot2018/teams","hooks_url":"https://api.github.com/repos/Team488/TeamXbot2018/hooks","issue_events_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/events{/number}","events_url":"https://api.github.com/repos/Team488/TeamXbot2018/events","assignees_url":"https://api.github.com/repos/Team488/TeamXbot2018/assignees{/user}","branches_url":"https://api.github.com/repos/Team488/TeamXbot2018/branches{/branch}","tags_url":"https://api.github.com/repos/Team488/TeamXbot2018/tags","blobs_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team488/TeamXbot2018/statuses/{sha}","languages_url":"https://api.github.com/repos/Team488/TeamXbot2018/languages","stargazers_url":"https://api.github.com/repos/Team488/TeamXbot2018/stargazers","contributors_url":"https://api.github.com/repos/Team488/TeamXbot2018/contributors","subscribers_url":"https://api.github.com/repos/Team488/TeamXbot2018/subscribers","subscription_url":"https://api.github.com/repos/Team488/TeamXbot2018/subscription","commits_url":"https://api.github.com/repos/Team488/TeamXbot2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team488/TeamXbot2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team488/TeamXbot2018/contents/{+path}","compare_url":"https://api.github.com/repos/Team488/TeamXbot2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team488/TeamXbot2018/merges","archive_url":"https://api.github.com/repos/Team488/TeamXbot2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team488/TeamXbot2018/downloads","issues_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues{/number}","pulls_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls{/number}","milestones_url":"https://api.github.com/repos/Team488/TeamXbot2018/milestones{/number}","notifications_url":"https://api.github.com/repos/Team488/TeamXbot2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team488/TeamXbot2018/labels{/name}","releases_url":"https://api.github.com/repos/Team488/TeamXbot2018/releases{/id}","deployments_url":"https://api.github.com/repos/Team488/TeamXbot2018/deployments","created_at":"2018-01-10T02:19:18Z","updated_at":"2018-02-17T06:49:47Z","pushed_at":"2018-03-03T09:40:57Z","git_url":"git://github.com/Team488/TeamXbot2018.git","ssh_url":"git@github.com:Team488/TeamXbot2018.git","clone_url":"https://github.com/Team488/TeamXbot2018.git","svn_url":"https://github.com/Team488/TeamXbot2018","homepage":null,"size":1125,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"Team488:master","ref":"master","sha":"e510eeb48e12d08af272b7e90ad7b1571cbfbd6c","user":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"repo":{"id":116896266,"name":"TeamXbot2018","full_name":"Team488/TeamXbot2018","owner":{"login":"Team488","id":3441816,"avatar_url":"https://avatars0.githubusercontent.com/u/3441816?v=4","gravatar_id":"","url":"https://api.github.com/users/Team488","html_url":"https://github.com/Team488","followers_url":"https://api.github.com/users/Team488/followers","following_url":"https://api.github.com/users/Team488/following{/other_user}","gists_url":"https://api.github.com/users/Team488/gists{/gist_id}","starred_url":"https://api.github.com/users/Team488/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team488/subscriptions","organizations_url":"https://api.github.com/users/Team488/orgs","repos_url":"https://api.github.com/users/Team488/repos","events_url":"https://api.github.com/users/Team488/events{/privacy}","received_events_url":"https://api.github.com/users/Team488/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team488/TeamXbot2018","description":"Competition code for the 2018 Power Up Season","fork":false,"url":"https://api.github.com/repos/Team488/TeamXbot2018","forks_url":"https://api.github.com/repos/Team488/TeamXbot2018/forks","keys_url":"https://api.github.com/repos/Team488/TeamXbot2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team488/TeamXbot2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team488/TeamXbot2018/teams","hooks_url":"https://api.github.com/repos/Team488/TeamXbot2018/hooks","issue_events_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/events{/number}","events_url":"https://api.github.com/repos/Team488/TeamXbot2018/events","assignees_url":"https://api.github.com/repos/Team488/TeamXbot2018/assignees{/user}","branches_url":"https://api.github.com/repos/Team488/TeamXbot2018/branches{/branch}","tags_url":"https://api.github.com/repos/Team488/TeamXbot2018/tags","blobs_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team488/TeamXbot2018/statuses/{sha}","languages_url":"https://api.github.com/repos/Team488/TeamXbot2018/languages","stargazers_url":"https://api.github.com/repos/Team488/TeamXbot2018/stargazers","contributors_url":"https://api.github.com/repos/Team488/TeamXbot2018/contributors","subscribers_url":"https://api.github.com/repos/Team488/TeamXbot2018/subscribers","subscription_url":"https://api.github.com/repos/Team488/TeamXbot2018/subscription","commits_url":"https://api.github.com/repos/Team488/TeamXbot2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team488/TeamXbot2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team488/TeamXbot2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team488/TeamXbot2018/contents/{+path}","compare_url":"https://api.github.com/repos/Team488/TeamXbot2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team488/TeamXbot2018/merges","archive_url":"https://api.github.com/repos/Team488/TeamXbot2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team488/TeamXbot2018/downloads","issues_url":"https://api.github.com/repos/Team488/TeamXbot2018/issues{/number}","pulls_url":"https://api.github.com/repos/Team488/TeamXbot2018/pulls{/number}","milestones_url":"https://api.github.com/repos/Team488/TeamXbot2018/milestones{/number}","notifications_url":"https://api.github.com/repos/Team488/TeamXbot2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team488/TeamXbot2018/labels{/name}","releases_url":"https://api.github.com/repos/Team488/TeamXbot2018/releases{/id}","deployments_url":"https://api.github.com/repos/Team488/TeamXbot2018/deployments","created_at":"2018-01-10T02:19:18Z","updated_at":"2018-02-17T06:49:47Z","pushed_at":"2018-03-03T09:40:57Z","git_url":"git://github.com/Team488/TeamXbot2018.git","ssh_url":"git@github.com:Team488/TeamXbot2018.git","clone_url":"https://github.com/Team488/TeamXbot2018.git","svn_url":"https://github.com/Team488/TeamXbot2018","homepage":null,"size":1125,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142"},"html":{"href":"https://github.com/Team488/TeamXbot2018/pull/142"},"issue":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/issues/142"},"comments":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/Team488/TeamXbot2018/statuses/7b2ca8b01d013cbf8f276ece2d37f6534351e567"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JohnGilb"}}