{"action":"created","issue":{"url":"https://api.github.com/repos/sot/eng_archive/issues/146","repository_url":"https://api.github.com/repos/sot/eng_archive","labels_url":"https://api.github.com/repos/sot/eng_archive/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/sot/eng_archive/issues/146/comments","events_url":"https://api.github.com/repos/sot/eng_archive/issues/146/events","html_url":"https://github.com/sot/eng_archive/pull/146","id":330014565,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTI2NTgy","number":146,"title":"Set fetched bads array to be writeable, needed for remote access","user":{"login":"taldcroft","id":348089,"node_id":"MDQ6VXNlcjM0ODA4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/348089?v=4","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-06T20:10:20Z","updated_at":"2018-06-07T00:06:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sot/eng_archive/pulls/146","html_url":"https://github.com/sot/eng_archive/pull/146","diff_url":"https://github.com/sot/eng_archive/pull/146.diff","patch_url":"https://github.com/sot/eng_archive/pull/146.patch"},"body":"## Rationale\r\nFixes #145.\r\n\r\nI do not understand why the `bads` array is set with `WRITEABLE=False` for remote access, while the `vals` array fetched in the same context is not.  Nevertheless, this does fix the problem in my testing.\r\n\r\n## Testing\r\n### Functional (using Mac laptop)\r\n- Get onto OCC VPN\r\n- Get into the `ska` environment in the `~/anaconda` installation (not my current default `~/anaconda3`).\r\n- Do the following for functional test (this fails without the patch):\r\n```\r\n>>> import Ska.engarchive.remote_access\r\n>>> Ska.engarchive.remote_access.access_remotely = True\r\n>>> import Ska.engarchive.fetch_eng as fetch\r\n   ...: \r\nEnter hostname (or IP) of Ska server (enter to cancel):131.142.---.---\r\nEnter your login username [aldcroft]: <user>\r\nEnter your password: <pass>\r\nEstablishing connection to 131.142.---.---...\r\n\r\n>>> from Ska.engarchive.tests.test_fetch import test_ctu_dwell_telem\r\nSka/engarchive/fetch.py\r\n>>> test_ctu_dwell_telem()\r\n>>> # pass\r\n```\r\nFor reference this relies on having the remote key file `ska_remote_access.json` in `~/anaconda/envs/ska`.  One can also do the following prior to importing `fetch`:\r\n```\r\n>>> Ska.engarchive.remote_access.client_key_file = '<path>/ska_remote_access.json'\r\n```\r\n\r\n### Regression testing\r\nPassed unit regression tests on HEAD Ska and Ska3\r\n\r\n### Interface impact\r\nNone\r\n\r\n### Review\r\n\r\n- [ ] Jean Connelly\r\n- [ ] Mark Baski\r\n\r\n### Installation\r\nInstall to HEAD Ska flight, Ska3 flight and GRETA test after approval and when convenient (maybe along with another more impacting patch).  Mark B has indicated that this is not required for the pending Matlab tools release so no need for immediate install to GRETA dev.\r\n\r\n### Back-out\r\nReverting to 3.43.1 is straightforward."},"comment":{"url":"https://api.github.com/repos/sot/eng_archive/issues/comments/395251562","html_url":"https://github.com/sot/eng_archive/pull/146#issuecomment-395251562","issue_url":"https://api.github.com/repos/sot/eng_archive/issues/146","id":395251562,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTI1MTU2Mg==","user":{"login":"mbaski","id":3877545,"node_id":"MDQ6VXNlcjM4Nzc1NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3877545?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaski","html_url":"https://github.com/mbaski","followers_url":"https://api.github.com/users/mbaski/followers","following_url":"https://api.github.com/users/mbaski/following{/other_user}","gists_url":"https://api.github.com/users/mbaski/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaski/subscriptions","organizations_url":"https://api.github.com/users/mbaski/orgs","repos_url":"https://api.github.com/users/mbaski/repos","events_url":"https://api.github.com/users/mbaski/events{/privacy}","received_events_url":"https://api.github.com/users/mbaski/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T00:06:31Z","updated_at":"2018-06-07T00:06:31Z","author_association":"CONTRIBUTOR","body":"The code changes look good and the regression test now runs to completion on Windows.  I also tested data retrieval from MCC by overlaying Ska EngArchive data on the thermal models and it looked good.  Overall I'm good with the fix - thanks Tom."}}
{"actor":{"display_login":"mbaski"}}