{"action":"created","issue":{"url":"https://api.github.com/repos/Fourdee/DietPi/issues/1846","repository_url":"https://api.github.com/repos/Fourdee/DietPi","labels_url":"https://api.github.com/repos/Fourdee/DietPi/issues/1846/labels{/name}","comments_url":"https://api.github.com/repos/Fourdee/DietPi/issues/1846/comments","events_url":"https://api.github.com/repos/Fourdee/DietPi/issues/1846/events","html_url":"https://github.com/Fourdee/DietPi/issues/1846","id":331749080,"node_id":"MDU6SXNzdWUzMzE3NDkwODA=","number":1846,"title":"DietPi-Drive_Manager | Disallow moving dietpi_userdata to filesystem without permissions support","user":{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false},"labels":[{"id":292966281,"node_id":"MDU6TGFiZWwyOTI5NjYyODE=","url":"https://api.github.com/repos/Fourdee/DietPi/labels/Feature%20Request%20:factory:","name":"Feature Request :factory:","color":"fbca04","default":false},{"id":187191723,"node_id":"MDU6TGFiZWwxODcxOTE3MjM=","url":"https://api.github.com/repos/Fourdee/DietPi/labels/enhancement%20:dash:","name":"enhancement :dash:","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Fourdee/DietPi/milestones/74","html_url":"https://github.com/Fourdee/DietPi/milestone/74","labels_url":"https://api.github.com/repos/Fourdee/DietPi/milestones/74/labels","id":3396210,"node_id":"MDk6TWlsZXN0b25lMzM5NjIxMA==","number":74,"title":"v6.10","description":null,"creator":{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":5,"state":"open","created_at":"2018-06-03T10:37:41Z","updated_at":"2018-06-13T01:44:36Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-06-12T20:52:09Z","updated_at":"2018-06-13T02:49:24Z","closed_at":null,"author_association":"COLLABORATOR","body":"## Creating a feature request:\r\n\r\n\r\n#### Is your feature request related to a problem? Please describe:\r\n<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->\r\n- When moving `dietpi_userdata` to another drive via `dietpi-drive_manager`, it is possible to move it to a file system without user permissions support, which breaks several of our software installations.\r\n- `dietpi-drive_manager` checks for `vfat`, which does not support permissions, throws a hint in case but allows to go on: https://github.com/Fourdee/DietPi/blob/master/dietpi/dietpi-drive_manager#L1118-L1134\r\n- `dietpi-set_userdata` tests (again) permission support directly, but just preserves them on copy process in case, otherwise goes on without preserving permissions: https://github.com/Fourdee/DietPi/blob/master/dietpi/func/dietpi-set_userdata#L72-L79\r\n\r\n#### Describe the solution you'd like:\r\n<!-- A clear and concise description of what you want to happen.-->\r\n- On the one hand, as `dietpi-set_userdata` is a standalone script, it should do all these checks by itself, thus those can be skipped within `dietpi-drive_manager`. Only if we wan't to have a cleaned menu there, we would need to check first, based on all file systems we support and then tell set_userdata to skip additional tests, as this was already done.\r\n- On the other hand, we should definitely not allow to move userdata, if the check fails, as described above this breaks expected DietPi usage and leads to possible data loss when user is doing wrong steps as reaction.\r\n\r\n#### Describe alternatives you've considered:\r\n<!-- A clear and concise description of any alternative solutions or features you've considered.-->\r\n- It would be possible as well, if we wan't to allow user full flexibility, to give a clear warning, if the check fails, but then on all known file systems that do not support permissions, or after direct write/read test.\r\n\r\n#### Additional context:\r\n<!-- Add any other context or screenshots about the feature request here.-->\r\n- This issue was already found before, but forgotten again. Now recovered it due to user report, although it may not be related: https://dietpi.com/phpbb/viewtopic.php?f=11&t=3888&p=12951#p12951"},"comment":{"url":"https://api.github.com/repos/Fourdee/DietPi/issues/comments/396796856","html_url":"https://github.com/Fourdee/DietPi/issues/1846#issuecomment-396796856","issue_url":"https://api.github.com/repos/Fourdee/DietPi/issues/1846","id":396796856,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njc5Njg1Ng==","user":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T02:49:24Z","updated_at":"2018-06-13T02:49:24Z","author_association":"OWNER","body":"![image](https://user-images.githubusercontent.com/7077026/41327801-c19fdb12-6ebc-11e8-91b5-fa7041b9d7bc.png)\r\n"}}
{"actor":{"display_login":"Fourdee"}}