{"action":"closed","number":127,"pull_request":{"url":"https://api.github.com/repos/r03ert0/microdraw/pulls/127","id":194926635,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTI2NjM1","html_url":"https://github.com/r03ert0/microdraw/pull/127","diff_url":"https://github.com/r03ert0/microdraw/pull/127.diff","patch_url":"https://github.com/r03ert0/microdraw/pull/127.patch","issue_url":"https://api.github.com/repos/r03ert0/microdraw/issues/127","number":127,"state":"closed","locked":false,"title":"fixing paperjs osd desync, added style to index option, removed requi…","user":{"login":"xgui3783","id":19381783,"node_id":"MDQ6VXNlcjE5MzgxNzgz","avatar_url":"https://avatars0.githubusercontent.com/u/19381783?v=4","gravatar_id":"","url":"https://api.github.com/users/xgui3783","html_url":"https://github.com/xgui3783","followers_url":"https://api.github.com/users/xgui3783/followers","following_url":"https://api.github.com/users/xgui3783/following{/other_user}","gists_url":"https://api.github.com/users/xgui3783/gists{/gist_id}","starred_url":"https://api.github.com/users/xgui3783/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgui3783/subscriptions","organizations_url":"https://api.github.com/users/xgui3783/orgs","repos_url":"https://api.github.com/users/xgui3783/repos","events_url":"https://api.github.com/users/xgui3783/events{/privacy}","received_events_url":"https://api.github.com/users/xgui3783/received_events","type":"User","site_admin":false},"body":"…re async in usr controller, as it was not included in the dependency in package.json\r\n\r\n<!-- Thank you so much for your contribution to MicroDraw! <3 -->\r\n\r\n<!-- Please find a short title for your pull request and describe your changes on the following line: -->\r\n\r\nstyled option `index.mustache`:\r\n![screenshot from 2018-06-14 17-05-58_cropped](https://user-images.githubusercontent.com/19381783/41420866-b86066d6-6ff5-11e8-8eea-059e4096b41d.png)\r\n\r\npaperjs now bound properly inside osd + fixed desync issue:\r\n![screenshot from 2018-06-14 17-05-04](https://user-images.githubusercontent.com/19381783/41420906-d14dca94-6ff5-11e8-8aa7-93a9d38cbb2c.png)\r\n\r\n\r\n---\r\n<!-- Please go through our check list and replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `screenshot_test_walk` generates the same test pictures as there were and does not show any errors\r\n- [x] These changes fix #125  (github issue number if applicable).\r\n- [x] All MicroDraw tools behave as expected:\r\n    * **GESTURES**\r\n        - [ ] zoom in and out with two finger drag works\r\n    * **KEYS**\r\n        * right and up arrow key or left and down arrow key\r\n            - [ ] jump to next or previous slice respectively\r\n            - [ ] update the slider accordingly\r\n            - [ ] update the slice number accordingly\r\n        * cmd z undoes\r\n            - [ ] any step back that you have done in their chronological order including\r\n            - [ ] translation of region\r\n            - [ ] drawing region\r\n            - [ ] adding point\r\n            - [ ] deleting point\r\n        to be completed (maybe it is implemented and working for all functions, so we can delete the single step checks)\r\n    * **TOOL BUTTONS**\r\n        * red rectangle in navigation window\r\n            - [ ] corresponds to tissue piece selected in viewer\r\n            - [ ] can be navigated upon mouse down drag\r\n        * navigation tool\r\n            - [ ] navigates the slice inside the viewer upon mouse down drag\r\n        * home button\r\n            - [ ] zooms out to view the data in full screen size view\r\n        * zoomIn tool\r\n            - [ ] zooms one step in upon click\r\n        * zoomOut tool\r\n            - [ ] zooms one step out upon click\r\n        * left arrow\r\n            - [ ] jumps to the previous slice\r\n        * right arrow\r\n            - [ ] jumps to the next slice\r\n        * select tool\r\n            - [ ] selects a region upon click\r\n        * draw tool\r\n            - [ ] draws a new region as bezier curve\r\n        * drawPolygon tool\r\n            - [ ] draws a new region as a polygon path\r\n        * simplify tool\r\n            - [ ] decreases the number of points in the region path while aiming at conserving the shape\r\n        * addPoint tool\r\n            - [ ] adds a point to the path upon click at position of mouse click\r\n        * deletePoint tool\r\n            - [ ] deletes a point from the path upon mouse click\r\n        * addRegion tool\r\n            - [ ] unifies two overlapping regions into one\r\n        * deleteRegion tool\r\n            - [ ] deletes a region upon click\r\n        * splitRegion tool\r\n            - [ ] splits one region at the intersection path with a second region\r\n        * rotate tool\r\n            - [ ] rotates a region around the point of mouse click\r\n        * flip tool\r\n            - [ ] flips a region around its vertical axis\r\n        * toPolygon tool\r\n            - [ ] converts the region path from bezier curve to polygon path\r\n        * toBezier\r\n            - [ ] converts the region path from polygon path to bezier curve\r\n        * copy tool\r\n            - [ ] copies a region\r\n        * paste tool\r\n            - [ ] pastes the copied region\r\n        * save tool\r\n            - [ ] saves the set of drawn regions to the database\r\n        * screenshot tool\r\n            - [ ] creates a screenshot of the data layer (not of the annotations yet) at a chosen resolution\r\n        * delete tool\r\n            - [ ] deletes the selected region\r\n        * closeMenu tool\r\n            - [ ] hides the menu bar upon click\r\n        * openMenu tool\r\n            - [ ] shows the menu bar upon click\r\n        * undo tool\r\n            - [ ] undoes the user's actions in reverse chronological order\r\n\r\n\r\n<!-- Either: -->\r\n- [ ] I implemented tests for these changes OR\r\n- [x] These changes do not require tests because mainly ui changes\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Again, many many thanks for your work! \\ö/ -->\r\n\r\n","created_at":"2018-06-14T15:10:28Z","updated_at":"2018-06-15T14:13:37Z","closed_at":"2018-06-15T14:13:37Z","merged_at":"2018-06-15T14:13:36Z","merge_commit_sha":"5becc57d8c93d3caa1b2b3b056d261b1758d2754","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/r03ert0/microdraw/pulls/127/commits","review_comments_url":"https://api.github.com/repos/r03ert0/microdraw/pulls/127/comments","review_comment_url":"https://api.github.com/repos/r03ert0/microdraw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r03ert0/microdraw/issues/127/comments","statuses_url":"https://api.github.com/repos/r03ert0/microdraw/statuses/f9dc11e85b4d37ee4bb49376d5b020376055f58e","head":{"label":"r03ert0:paperjs_osd_desync","ref":"paperjs_osd_desync","sha":"f9dc11e85b4d37ee4bb49376d5b020376055f58e","user":{"login":"r03ert0","id":2310732,"node_id":"MDQ6VXNlcjIzMTA3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2310732?v=4","gravatar_id":"","url":"https://api.github.com/users/r03ert0","html_url":"https://github.com/r03ert0","followers_url":"https://api.github.com/users/r03ert0/followers","following_url":"https://api.github.com/users/r03ert0/following{/other_user}","gists_url":"https://api.github.com/users/r03ert0/gists{/gist_id}","starred_url":"https://api.github.com/users/r03ert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r03ert0/subscriptions","organizations_url":"https://api.github.com/users/r03ert0/orgs","repos_url":"https://api.github.com/users/r03ert0/repos","events_url":"https://api.github.com/users/r03ert0/events{/privacy}","received_events_url":"https://api.github.com/users/r03ert0/received_events","type":"User","site_admin":false},"repo":{"id":33068458,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA2ODQ1OA==","name":"microdraw","full_name":"r03ert0/microdraw","owner":{"login":"r03ert0","id":2310732,"node_id":"MDQ6VXNlcjIzMTA3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2310732?v=4","gravatar_id":"","url":"https://api.github.com/users/r03ert0","html_url":"https://github.com/r03ert0","followers_url":"https://api.github.com/users/r03ert0/followers","following_url":"https://api.github.com/users/r03ert0/following{/other_user}","gists_url":"https://api.github.com/users/r03ert0/gists{/gist_id}","starred_url":"https://api.github.com/users/r03ert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r03ert0/subscriptions","organizations_url":"https://api.github.com/users/r03ert0/orgs","repos_url":"https://api.github.com/users/r03ert0/repos","events_url":"https://api.github.com/users/r03ert0/events{/privacy}","received_events_url":"https://api.github.com/users/r03ert0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r03ert0/microdraw","description":"Collaborative vectorial annotation tool for ultra high resolution data.","fork":false,"url":"https://api.github.com/repos/r03ert0/microdraw","forks_url":"https://api.github.com/repos/r03ert0/microdraw/forks","keys_url":"https://api.github.com/repos/r03ert0/microdraw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r03ert0/microdraw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r03ert0/microdraw/teams","hooks_url":"https://api.github.com/repos/r03ert0/microdraw/hooks","issue_events_url":"https://api.github.com/repos/r03ert0/microdraw/issues/events{/number}","events_url":"https://api.github.com/repos/r03ert0/microdraw/events","assignees_url":"https://api.github.com/repos/r03ert0/microdraw/assignees{/user}","branches_url":"https://api.github.com/repos/r03ert0/microdraw/branches{/branch}","tags_url":"https://api.github.com/repos/r03ert0/microdraw/tags","blobs_url":"https://api.github.com/repos/r03ert0/microdraw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r03ert0/microdraw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r03ert0/microdraw/git/refs{/sha}","trees_url":"https://api.github.com/repos/r03ert0/microdraw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r03ert0/microdraw/statuses/{sha}","languages_url":"https://api.github.com/repos/r03ert0/microdraw/languages","stargazers_url":"https://api.github.com/repos/r03ert0/microdraw/stargazers","contributors_url":"https://api.github.com/repos/r03ert0/microdraw/contributors","subscribers_url":"https://api.github.com/repos/r03ert0/microdraw/subscribers","subscription_url":"https://api.github.com/repos/r03ert0/microdraw/subscription","commits_url":"https://api.github.com/repos/r03ert0/microdraw/commits{/sha}","git_commits_url":"https://api.github.com/repos/r03ert0/microdraw/git/commits{/sha}","comments_url":"https://api.github.com/repos/r03ert0/microdraw/comments{/number}","issue_comment_url":"https://api.github.com/repos/r03ert0/microdraw/issues/comments{/number}","contents_url":"https://api.github.com/repos/r03ert0/microdraw/contents/{+path}","compare_url":"https://api.github.com/repos/r03ert0/microdraw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r03ert0/microdraw/merges","archive_url":"https://api.github.com/repos/r03ert0/microdraw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r03ert0/microdraw/downloads","issues_url":"https://api.github.com/repos/r03ert0/microdraw/issues{/number}","pulls_url":"https://api.github.com/repos/r03ert0/microdraw/pulls{/number}","milestones_url":"https://api.github.com/repos/r03ert0/microdraw/milestones{/number}","notifications_url":"https://api.github.com/repos/r03ert0/microdraw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r03ert0/microdraw/labels{/name}","releases_url":"https://api.github.com/repos/r03ert0/microdraw/releases{/id}","deployments_url":"https://api.github.com/repos/r03ert0/microdraw/deployments","created_at":"2015-03-29T10:03:49Z","updated_at":"2018-06-15T14:13:07Z","pushed_at":"2018-06-15T14:13:36Z","git_url":"git://github.com/r03ert0/microdraw.git","ssh_url":"git@github.com:r03ert0/microdraw.git","clone_url":"https://github.com/r03ert0/microdraw.git","svn_url":"https://github.com/r03ert0/microdraw","homepage":"http://microdraw.pasteur.fr","size":69150,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":21,"watchers":12,"default_branch":"master"}},"base":{"label":"r03ert0:master","ref":"master","sha":"b26d1ed8153d70c80bbf3856cabc6ea9370cbd50","user":{"login":"r03ert0","id":2310732,"node_id":"MDQ6VXNlcjIzMTA3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2310732?v=4","gravatar_id":"","url":"https://api.github.com/users/r03ert0","html_url":"https://github.com/r03ert0","followers_url":"https://api.github.com/users/r03ert0/followers","following_url":"https://api.github.com/users/r03ert0/following{/other_user}","gists_url":"https://api.github.com/users/r03ert0/gists{/gist_id}","starred_url":"https://api.github.com/users/r03ert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r03ert0/subscriptions","organizations_url":"https://api.github.com/users/r03ert0/orgs","repos_url":"https://api.github.com/users/r03ert0/repos","events_url":"https://api.github.com/users/r03ert0/events{/privacy}","received_events_url":"https://api.github.com/users/r03ert0/received_events","type":"User","site_admin":false},"repo":{"id":33068458,"node_id":"MDEwOlJlcG9zaXRvcnkzMzA2ODQ1OA==","name":"microdraw","full_name":"r03ert0/microdraw","owner":{"login":"r03ert0","id":2310732,"node_id":"MDQ6VXNlcjIzMTA3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2310732?v=4","gravatar_id":"","url":"https://api.github.com/users/r03ert0","html_url":"https://github.com/r03ert0","followers_url":"https://api.github.com/users/r03ert0/followers","following_url":"https://api.github.com/users/r03ert0/following{/other_user}","gists_url":"https://api.github.com/users/r03ert0/gists{/gist_id}","starred_url":"https://api.github.com/users/r03ert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r03ert0/subscriptions","organizations_url":"https://api.github.com/users/r03ert0/orgs","repos_url":"https://api.github.com/users/r03ert0/repos","events_url":"https://api.github.com/users/r03ert0/events{/privacy}","received_events_url":"https://api.github.com/users/r03ert0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r03ert0/microdraw","description":"Collaborative vectorial annotation tool for ultra high resolution data.","fork":false,"url":"https://api.github.com/repos/r03ert0/microdraw","forks_url":"https://api.github.com/repos/r03ert0/microdraw/forks","keys_url":"https://api.github.com/repos/r03ert0/microdraw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r03ert0/microdraw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r03ert0/microdraw/teams","hooks_url":"https://api.github.com/repos/r03ert0/microdraw/hooks","issue_events_url":"https://api.github.com/repos/r03ert0/microdraw/issues/events{/number}","events_url":"https://api.github.com/repos/r03ert0/microdraw/events","assignees_url":"https://api.github.com/repos/r03ert0/microdraw/assignees{/user}","branches_url":"https://api.github.com/repos/r03ert0/microdraw/branches{/branch}","tags_url":"https://api.github.com/repos/r03ert0/microdraw/tags","blobs_url":"https://api.github.com/repos/r03ert0/microdraw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r03ert0/microdraw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r03ert0/microdraw/git/refs{/sha}","trees_url":"https://api.github.com/repos/r03ert0/microdraw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r03ert0/microdraw/statuses/{sha}","languages_url":"https://api.github.com/repos/r03ert0/microdraw/languages","stargazers_url":"https://api.github.com/repos/r03ert0/microdraw/stargazers","contributors_url":"https://api.github.com/repos/r03ert0/microdraw/contributors","subscribers_url":"https://api.github.com/repos/r03ert0/microdraw/subscribers","subscription_url":"https://api.github.com/repos/r03ert0/microdraw/subscription","commits_url":"https://api.github.com/repos/r03ert0/microdraw/commits{/sha}","git_commits_url":"https://api.github.com/repos/r03ert0/microdraw/git/commits{/sha}","comments_url":"https://api.github.com/repos/r03ert0/microdraw/comments{/number}","issue_comment_url":"https://api.github.com/repos/r03ert0/microdraw/issues/comments{/number}","contents_url":"https://api.github.com/repos/r03ert0/microdraw/contents/{+path}","compare_url":"https://api.github.com/repos/r03ert0/microdraw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r03ert0/microdraw/merges","archive_url":"https://api.github.com/repos/r03ert0/microdraw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r03ert0/microdraw/downloads","issues_url":"https://api.github.com/repos/r03ert0/microdraw/issues{/number}","pulls_url":"https://api.github.com/repos/r03ert0/microdraw/pulls{/number}","milestones_url":"https://api.github.com/repos/r03ert0/microdraw/milestones{/number}","notifications_url":"https://api.github.com/repos/r03ert0/microdraw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r03ert0/microdraw/labels{/name}","releases_url":"https://api.github.com/repos/r03ert0/microdraw/releases{/id}","deployments_url":"https://api.github.com/repos/r03ert0/microdraw/deployments","created_at":"2015-03-29T10:03:49Z","updated_at":"2018-06-15T14:13:07Z","pushed_at":"2018-06-15T14:13:36Z","git_url":"git://github.com/r03ert0/microdraw.git","ssh_url":"git@github.com:r03ert0/microdraw.git","clone_url":"https://github.com/r03ert0/microdraw.git","svn_url":"https://github.com/r03ert0/microdraw","homepage":"http://microdraw.pasteur.fr","size":69150,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":30,"open_issues":21,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r03ert0/microdraw/pulls/127"},"html":{"href":"https://github.com/r03ert0/microdraw/pull/127"},"issue":{"href":"https://api.github.com/repos/r03ert0/microdraw/issues/127"},"comments":{"href":"https://api.github.com/repos/r03ert0/microdraw/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/r03ert0/microdraw/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/r03ert0/microdraw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r03ert0/microdraw/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/r03ert0/microdraw/statuses/f9dc11e85b4d37ee4bb49376d5b020376055f58e"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"r03ert0","id":2310732,"node_id":"MDQ6VXNlcjIzMTA3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2310732?v=4","gravatar_id":"","url":"https://api.github.com/users/r03ert0","html_url":"https://github.com/r03ert0","followers_url":"https://api.github.com/users/r03ert0/followers","following_url":"https://api.github.com/users/r03ert0/following{/other_user}","gists_url":"https://api.github.com/users/r03ert0/gists{/gist_id}","starred_url":"https://api.github.com/users/r03ert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r03ert0/subscriptions","organizations_url":"https://api.github.com/users/r03ert0/orgs","repos_url":"https://api.github.com/users/r03ert0/repos","events_url":"https://api.github.com/users/r03ert0/events{/privacy}","received_events_url":"https://api.github.com/users/r03ert0/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":41,"deletions":6,"changed_files":5}}
{"actor":{"display_login":"r03ert0"}}