{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/pilosa/pulls/comments/245488432","pull_request_review_id":189608400,"id":245488432,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4ODQzMg==","diff_hunk":"@@ -319,23 +319,24 @@ func (sc *sliceContainers) Repair() {\n }\n \n type sliceIterator struct {\n-\te     *sliceContainers\n-\ti     int\n-\tkey   uint64\n-\tvalue *Container\n+\te *sliceContainers\n+\ti int\n }\n \n-func (si *sliceIterator) Next() bool {\n+func (si sliceIterator) Next() bool {\n \tif si.e == nil || si.i > len(si.e.keys)-1 {\n \t\treturn false\n \t}\n-\tsi.key = si.e.keys[si.i]\n-\tsi.value = si.e.containers[si.i]\n-\tsi.i++\n \n+\tsi.i++","path":"roaring/containers.go","position":30,"original_position":30,"commit_id":"a3b51219ee5ea59f620befc86880ba7ff6376ef5","original_commit_id":"a3b51219ee5ea59f620befc86880ba7ff6376ef5","user":{"login":"xichen2020","id":12239421,"node_id":"MDQ6VXNlcjEyMjM5NDIx","avatar_url":"https://avatars1.githubusercontent.com/u/12239421?v=4","gravatar_id":"","url":"https://api.github.com/users/xichen2020","html_url":"https://github.com/xichen2020","followers_url":"https://api.github.com/users/xichen2020/followers","following_url":"https://api.github.com/users/xichen2020/following{/other_user}","gists_url":"https://api.github.com/users/xichen2020/gists{/gist_id}","starred_url":"https://api.github.com/users/xichen2020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xichen2020/subscriptions","organizations_url":"https://api.github.com/users/xichen2020/orgs","repos_url":"https://api.github.com/users/xichen2020/repos","events_url":"https://api.github.com/users/xichen2020/events{/privacy}","received_events_url":"https://api.github.com/users/xichen2020/received_events","type":"User","site_admin":false},"body":"Not sure how this is intended to be used, but you probably need this to be a method on `*sliceIterator` for this to take effect?","created_at":"2019-01-05T20:56:21Z","updated_at":"2019-01-05T20:56:24Z","html_url":"https://github.com/m3db/pilosa/pull/2#discussion_r245488432","pull_request_url":"https://api.github.com/repos/m3db/pilosa/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/comments/245488432"},"html":{"href":"https://github.com/m3db/pilosa/pull/2#discussion_r245488432"},"pull_request":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/pilosa/pulls/2","id":242459966,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDU5OTY2","html_url":"https://github.com/m3db/pilosa/pull/2","diff_url":"https://github.com/m3db/pilosa/pull/2.diff","patch_url":"https://github.com/m3db/pilosa/pull/2.patch","issue_url":"https://api.github.com/repos/m3db/pilosa/issues/2","number":2,"state":"open","locked":false,"title":"Reduce size of sliceContainers iterator","user":{"login":"richardartoul","id":9171254,"node_id":"MDQ6VXNlcjkxNzEyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9171254?v=4","gravatar_id":"","url":"https://api.github.com/users/richardartoul","html_url":"https://github.com/richardartoul","followers_url":"https://api.github.com/users/richardartoul/followers","following_url":"https://api.github.com/users/richardartoul/following{/other_user}","gists_url":"https://api.github.com/users/richardartoul/gists{/gist_id}","starred_url":"https://api.github.com/users/richardartoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardartoul/subscriptions","organizations_url":"https://api.github.com/users/richardartoul/orgs","repos_url":"https://api.github.com/users/richardartoul/repos","events_url":"https://api.github.com/users/richardartoul/events{/privacy}","received_events_url":"https://api.github.com/users/richardartoul/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-01-05T20:50:53Z","updated_at":"2019-01-05T20:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7eb3d8ff73ce4d9f77ca0e2ef24a486456273c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/pilosa/pulls/2/commits","review_comments_url":"https://api.github.com/repos/m3db/pilosa/pulls/2/comments","review_comment_url":"https://api.github.com/repos/m3db/pilosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/pilosa/issues/2/comments","statuses_url":"https://api.github.com/repos/m3db/pilosa/statuses/a3b51219ee5ea59f620befc86880ba7ff6376ef5","head":{"label":"m3db:ra/iter-allocs","ref":"ra/iter-allocs","sha":"a3b51219ee5ea59f620befc86880ba7ff6376ef5","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":164247453,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQyNDc0NTM=","name":"pilosa","full_name":"m3db/pilosa","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/pilosa","description":"Temporary fork of pilosa/pilosa until we can merge performance improvements upstream","fork":false,"url":"https://api.github.com/repos/m3db/pilosa","forks_url":"https://api.github.com/repos/m3db/pilosa/forks","keys_url":"https://api.github.com/repos/m3db/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/pilosa/teams","hooks_url":"https://api.github.com/repos/m3db/pilosa/hooks","issue_events_url":"https://api.github.com/repos/m3db/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/pilosa/events","assignees_url":"https://api.github.com/repos/m3db/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/pilosa/tags","blobs_url":"https://api.github.com/repos/m3db/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/pilosa/languages","stargazers_url":"https://api.github.com/repos/m3db/pilosa/stargazers","contributors_url":"https://api.github.com/repos/m3db/pilosa/contributors","subscribers_url":"https://api.github.com/repos/m3db/pilosa/subscribers","subscription_url":"https://api.github.com/repos/m3db/pilosa/subscription","commits_url":"https://api.github.com/repos/m3db/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/pilosa/merges","archive_url":"https://api.github.com/repos/m3db/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/pilosa/downloads","issues_url":"https://api.github.com/repos/m3db/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/m3db/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/pilosa/deployments","created_at":"2019-01-05T20:08:52Z","updated_at":"2019-01-05T20:10:32Z","pushed_at":"2019-01-05T20:50:54Z","git_url":"git://github.com/m3db/pilosa.git","ssh_url":"git@github.com:m3db/pilosa.git","clone_url":"https://github.com/m3db/pilosa.git","svn_url":"https://github.com/m3db/pilosa","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"de225afa677b4f0f7d018e58acd5516125de288a","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":164247453,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQyNDc0NTM=","name":"pilosa","full_name":"m3db/pilosa","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/pilosa","description":"Temporary fork of pilosa/pilosa until we can merge performance improvements upstream","fork":false,"url":"https://api.github.com/repos/m3db/pilosa","forks_url":"https://api.github.com/repos/m3db/pilosa/forks","keys_url":"https://api.github.com/repos/m3db/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/pilosa/teams","hooks_url":"https://api.github.com/repos/m3db/pilosa/hooks","issue_events_url":"https://api.github.com/repos/m3db/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/pilosa/events","assignees_url":"https://api.github.com/repos/m3db/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/pilosa/tags","blobs_url":"https://api.github.com/repos/m3db/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/pilosa/languages","stargazers_url":"https://api.github.com/repos/m3db/pilosa/stargazers","contributors_url":"https://api.github.com/repos/m3db/pilosa/contributors","subscribers_url":"https://api.github.com/repos/m3db/pilosa/subscribers","subscription_url":"https://api.github.com/repos/m3db/pilosa/subscription","commits_url":"https://api.github.com/repos/m3db/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/pilosa/merges","archive_url":"https://api.github.com/repos/m3db/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/pilosa/downloads","issues_url":"https://api.github.com/repos/m3db/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/m3db/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/pilosa/deployments","created_at":"2019-01-05T20:08:52Z","updated_at":"2019-01-05T20:10:32Z","pushed_at":"2019-01-05T20:50:54Z","git_url":"git://github.com/m3db/pilosa.git","ssh_url":"git@github.com:m3db/pilosa.git","clone_url":"https://github.com/m3db/pilosa.git","svn_url":"https://github.com/m3db/pilosa","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/2"},"html":{"href":"https://github.com/m3db/pilosa/pull/2"},"issue":{"href":"https://api.github.com/repos/m3db/pilosa/issues/2"},"comments":{"href":"https://api.github.com/repos/m3db/pilosa/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/pilosa/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/pilosa/statuses/a3b51219ee5ea59f620befc86880ba7ff6376ef5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xichen2020"}}