{"action":"created","comment":{"url":"https://api.github.com/repos/api-platform/core/pulls/comments/241659161","pull_request_review_id":184987138,"id":241659161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY1OTE2MQ==","diff_hunk":"@@ -64,7 +67,12 @@ public function onKernelRequest(GetResponseEvent $event)\n \n         if (null === $filters = $request->attributes->get('_api_filters')) {\n             $queryString = RequestParser::getQueryString($request);\n-            $filters = $queryString ? RequestParser::parseRequestParams($queryString) : null;\n+            if ($queryString) {\n+                foreach (RequestParser::parseRequestParams($queryString) as $name => $value) {\n+                    $name = $this->nameConverter ? $this->nameConverter->denormalize($name) : $name;","path":"src/EventListener/ReadListener.php","position":33,"original_position":33,"commit_id":"850075372b912a33b097bfed8700e840ef2587dc","original_commit_id":"850075372b912a33b097bfed8700e840ef2587dc","user":{"login":"antograssiot","id":4977112,"node_id":"MDQ6VXNlcjQ5NzcxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4977112?v=4","gravatar_id":"","url":"https://api.github.com/users/antograssiot","html_url":"https://github.com/antograssiot","followers_url":"https://api.github.com/users/antograssiot/followers","following_url":"https://api.github.com/users/antograssiot/following{/other_user}","gists_url":"https://api.github.com/users/antograssiot/gists{/gist_id}","starred_url":"https://api.github.com/users/antograssiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antograssiot/subscriptions","organizations_url":"https://api.github.com/users/antograssiot/orgs","repos_url":"https://api.github.com/users/antograssiot/repos","events_url":"https://api.github.com/users/antograssiot/events{/privacy}","received_events_url":"https://api.github.com/users/antograssiot/received_events","type":"User","site_admin":false},"body":"Wouldn't this apply to every parameters like `itemsPerPage` or custom PropertyFilter / GroupFilter parameter name, and thus create an unexpected app behavior change and/or add more discrepencies between the app and the Swagger documentation ?","created_at":"2018-12-14T07:02:37Z","updated_at":"2018-12-14T07:02:37Z","html_url":"https://github.com/api-platform/core/pull/2377#discussion_r241659161","pull_request_url":"https://api.github.com/repos/api-platform/core/pulls/2377","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments/241659161"},"html":{"href":"https://github.com/api-platform/core/pull/2377#discussion_r241659161"},"pull_request":{"href":"https://api.github.com/repos/api-platform/core/pulls/2377"}}},"pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/2377","id":238059973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDU5OTcz","html_url":"https://github.com/api-platform/core/pull/2377","diff_url":"https://github.com/api-platform/core/pull/2377.diff","patch_url":"https://github.com/api-platform/core/pull/2377.patch","issue_url":"https://api.github.com/repos/api-platform/core/issues/2377","number":2377,"state":"open","locked":false,"title":"Use the name converter for filters","user":{"login":"Soullivaneuh","id":1698357,"node_id":"MDQ6VXNlcjE2OTgzNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1698357?v=4","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | yes (but not considered as [it's a bugfix](https://github.com/api-platform/core/issues/2090#issuecomment-435949533))\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #2090\r\n| License       | MIT\r\n| Doc PR        | N/A\r\n\r\nI found a simpler way than https://github.com/api-platform/core/issues/2090#issuecomment-436060295 by normalize names on documentation normalizer and denormalize them on the read listener.\r\n\r\nWDYT? cc @antograssiot","created_at":"2018-12-12T14:38:18Z","updated_at":"2018-12-14T07:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9fe29d462e0cbd4183856f880cc4079573fb34c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/api-platform/core/pulls/2377/commits","review_comments_url":"https://api.github.com/repos/api-platform/core/pulls/2377/comments","review_comment_url":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/api-platform/core/issues/2377/comments","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/850075372b912a33b097bfed8700e840ef2587dc","head":{"label":"Soullivaneuh:filter-name-converter","ref":"filter-name-converter","sha":"850075372b912a33b097bfed8700e840ef2587dc","user":{"login":"Soullivaneuh","id":1698357,"node_id":"MDQ6VXNlcjE2OTgzNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1698357?v=4","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"repo":{"id":157230612,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyMzA2MTI=","name":"core","full_name":"Soullivaneuh/core","private":false,"owner":{"login":"Soullivaneuh","id":1698357,"node_id":"MDQ6VXNlcjE2OTgzNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1698357?v=4","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Soullivaneuh/core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":true,"url":"https://api.github.com/repos/Soullivaneuh/core","forks_url":"https://api.github.com/repos/Soullivaneuh/core/forks","keys_url":"https://api.github.com/repos/Soullivaneuh/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Soullivaneuh/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Soullivaneuh/core/teams","hooks_url":"https://api.github.com/repos/Soullivaneuh/core/hooks","issue_events_url":"https://api.github.com/repos/Soullivaneuh/core/issues/events{/number}","events_url":"https://api.github.com/repos/Soullivaneuh/core/events","assignees_url":"https://api.github.com/repos/Soullivaneuh/core/assignees{/user}","branches_url":"https://api.github.com/repos/Soullivaneuh/core/branches{/branch}","tags_url":"https://api.github.com/repos/Soullivaneuh/core/tags","blobs_url":"https://api.github.com/repos/Soullivaneuh/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Soullivaneuh/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Soullivaneuh/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Soullivaneuh/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Soullivaneuh/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Soullivaneuh/core/languages","stargazers_url":"https://api.github.com/repos/Soullivaneuh/core/stargazers","contributors_url":"https://api.github.com/repos/Soullivaneuh/core/contributors","subscribers_url":"https://api.github.com/repos/Soullivaneuh/core/subscribers","subscription_url":"https://api.github.com/repos/Soullivaneuh/core/subscription","commits_url":"https://api.github.com/repos/Soullivaneuh/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Soullivaneuh/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Soullivaneuh/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Soullivaneuh/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Soullivaneuh/core/contents/{+path}","compare_url":"https://api.github.com/repos/Soullivaneuh/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Soullivaneuh/core/merges","archive_url":"https://api.github.com/repos/Soullivaneuh/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Soullivaneuh/core/downloads","issues_url":"https://api.github.com/repos/Soullivaneuh/core/issues{/number}","pulls_url":"https://api.github.com/repos/Soullivaneuh/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Soullivaneuh/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Soullivaneuh/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Soullivaneuh/core/labels{/name}","releases_url":"https://api.github.com/repos/Soullivaneuh/core/releases{/id}","deployments_url":"https://api.github.com/repos/Soullivaneuh/core/deployments","created_at":"2018-11-12T15:01:05Z","updated_at":"2018-12-10T16:41:46Z","pushed_at":"2018-12-12T16:55:16Z","git_url":"git://github.com/Soullivaneuh/core.git","ssh_url":"git@github.com:Soullivaneuh/core.git","clone_url":"https://github.com/Soullivaneuh/core.git","svn_url":"https://github.com/Soullivaneuh/core","homepage":"https://api-platform.com","size":9522,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"api-platform:2.3","ref":"2.3","sha":"88ed3c6831534d50ef7dd0969cf6a51fe8618ea1","user":{"login":"api-platform","id":13420081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDgx","avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":29501260,"node_id":"MDEwOlJlcG9zaXRvcnkyOTUwMTI2MA==","name":"core","full_name":"api-platform/core","private":false,"owner":{"login":"api-platform","id":13420081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDgx","avatar_url":"https://avatars3.githubusercontent.com/u/13420081?v=4","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/api-platform/core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":false,"url":"https://api.github.com/repos/api-platform/core","forks_url":"https://api.github.com/repos/api-platform/core/forks","keys_url":"https://api.github.com/repos/api-platform/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/api-platform/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/api-platform/core/teams","hooks_url":"https://api.github.com/repos/api-platform/core/hooks","issue_events_url":"https://api.github.com/repos/api-platform/core/issues/events{/number}","events_url":"https://api.github.com/repos/api-platform/core/events","assignees_url":"https://api.github.com/repos/api-platform/core/assignees{/user}","branches_url":"https://api.github.com/repos/api-platform/core/branches{/branch}","tags_url":"https://api.github.com/repos/api-platform/core/tags","blobs_url":"https://api.github.com/repos/api-platform/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/api-platform/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/api-platform/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/api-platform/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/{sha}","languages_url":"https://api.github.com/repos/api-platform/core/languages","stargazers_url":"https://api.github.com/repos/api-platform/core/stargazers","contributors_url":"https://api.github.com/repos/api-platform/core/contributors","subscribers_url":"https://api.github.com/repos/api-platform/core/subscribers","subscription_url":"https://api.github.com/repos/api-platform/core/subscription","commits_url":"https://api.github.com/repos/api-platform/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/api-platform/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/api-platform/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/api-platform/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/api-platform/core/contents/{+path}","compare_url":"https://api.github.com/repos/api-platform/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/api-platform/core/merges","archive_url":"https://api.github.com/repos/api-platform/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/api-platform/core/downloads","issues_url":"https://api.github.com/repos/api-platform/core/issues{/number}","pulls_url":"https://api.github.com/repos/api-platform/core/pulls{/number}","milestones_url":"https://api.github.com/repos/api-platform/core/milestones{/number}","notifications_url":"https://api.github.com/repos/api-platform/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/api-platform/core/labels{/name}","releases_url":"https://api.github.com/repos/api-platform/core/releases{/id}","deployments_url":"https://api.github.com/repos/api-platform/core/deployments","created_at":"2015-01-19T23:05:56Z","updated_at":"2018-12-13T18:49:24Z","pushed_at":"2018-12-13T16:46:49Z","git_url":"git://github.com/api-platform/core.git","ssh_url":"git@github.com:api-platform/core.git","clone_url":"https://github.com/api-platform/core.git","svn_url":"https://github.com/api-platform/core","homepage":"https://api-platform.com","size":9524,"stargazers_count":900,"watchers_count":900,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":297,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":306,"open_issues":297,"watchers":900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/2377"},"html":{"href":"https://github.com/api-platform/core/pull/2377"},"issue":{"href":"https://api.github.com/repos/api-platform/core/issues/2377"},"comments":{"href":"https://api.github.com/repos/api-platform/core/issues/2377/comments"},"review_comments":{"href":"https://api.github.com/repos/api-platform/core/pulls/2377/comments"},"review_comment":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/api-platform/core/pulls/2377/commits"},"statuses":{"href":"https://api.github.com/repos/api-platform/core/statuses/850075372b912a33b097bfed8700e840ef2587dc"}},"author_association":"NONE"}}
{"actor":{"display_login":"antograssiot"}}