{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/28581","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/28581/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28581/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/28581/events","html_url":"https://github.com/symfony/symfony/pull/28581","id":363105150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjI0NDY5","number":28581,"title":"[DomCrawler] Return `null` on `text` and `html` methods when empty instead of an exception","user":{"login":"respinoza","id":189891,"node_id":"MDQ6VXNlcjE4OTg5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/189891?v=4","gravatar_id":"","url":"https://api.github.com/users/respinoza","html_url":"https://github.com/respinoza","followers_url":"https://api.github.com/users/respinoza/followers","following_url":"https://api.github.com/users/respinoza/following{/other_user}","gists_url":"https://api.github.com/users/respinoza/gists{/gist_id}","starred_url":"https://api.github.com/users/respinoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/respinoza/subscriptions","organizations_url":"https://api.github.com/users/respinoza/orgs","repos_url":"https://api.github.com/users/respinoza/repos","events_url":"https://api.github.com/users/respinoza/events{/privacy}","received_events_url":"https://api.github.com/users/respinoza/received_events","type":"User","site_admin":false},"labels":[{"id":231677,"node_id":"MDU6TGFiZWwyMzE2Nzc=","url":"https://api.github.com/repos/symfony/symfony/labels/BC%20Break","name":"BC Break","color":"e10c02","default":false},{"id":149840,"node_id":"MDU6TGFiZWwxNDk4NDA=","url":"https://api.github.com/repos/symfony/symfony/labels/DomCrawler","name":"DomCrawler","color":"DDDDDD","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":149,"closed_issues":261,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-09-25T08:26:05Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-09-24T11:24:45Z","updated_at":"2018-09-25T09:30:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28581","html_url":"https://github.com/symfony/symfony/pull/28581","diff_url":"https://github.com/symfony/symfony/pull/28581.diff","patch_url":"https://github.com/symfony/symfony/pull/28581.patch"},"body":"…stead of an exception\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #28313\r\n| License       | MIT\r\n| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->\r\n\r\nThis changes the behavior when using text and html methods from the Crawler by returning null instead of throwing an exception."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/424271634","html_url":"https://github.com/symfony/symfony/pull/28581#issuecomment-424271634","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28581","id":424271634,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDI3MTYzNA==","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T09:30:08Z","updated_at":"2018-09-25T09:30:08Z","author_association":"MEMBER","body":"> Currently there is no way to inject a DomCrawler instance\r\n\r\nso let's allow it via a new constructor arg to BrowserKit's Client?\r\nshould be in the same PR to make it complete (including the DI configuration)"}}
{"actor":{"display_login":"nicolas-grekas"}}