{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/188227337","pull_request_review_id":120159149,"id":188227337,"diff_hunk":"@@ -26,28 +26,28 @@ if meson.is_subproject()\n   endif\n endif\n \n-# Get version_commit\n-version_commit = run_command(git_exe, '-C', repo, 'rev-list', '--all', '--count')\n-if version_commit.returncode() != 0\n-  version_commit = 0\n-else\n-  version_commit = version_commit.stdout().strip()\n-endif\n-\n-# Get gittap\n-gittap  = run_command(git_exe, '-C', repo, 'describe', '--tags', '--match', '[0-9]*')\n-if gittap.returncode() != 0\n-  gittap = ''\n-else\n-  gittap = gittap.stdout().strip()\n-endif\n-\n-# Get gittip\n-gittip  = run_command(git_exe, '-C', repo, 'rev-parse', 'HEAD')\n-if gittip.returncode() != 0\n-  gittip = 'unknown'\n+if git_exe.found()\n+  # Get version_commit\n+  git_rev_list = run_command(git_exe, '-C', repo, 'rev-list', '--all', '--count')\n+  if git_rev_list.returncode() == 0\n+    version_commit = git_rev_list.stdout().strip()","path":"meson.build","position":37,"original_position":37,"commit_id":"60096187cee3a37379060a5c6fbed924bbc6171c","original_commit_id":"60096187cee3a37379060a5c6fbed924bbc6171c","user":{"login":"pelijah","id":16493991,"avatar_url":"https://avatars1.githubusercontent.com/u/16493991?v=4","gravatar_id":"","url":"https://api.github.com/users/pelijah","html_url":"https://github.com/pelijah","followers_url":"https://api.github.com/users/pelijah/followers","following_url":"https://api.github.com/users/pelijah/following{/other_user}","gists_url":"https://api.github.com/users/pelijah/gists{/gist_id}","starred_url":"https://api.github.com/users/pelijah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelijah/subscriptions","organizations_url":"https://api.github.com/users/pelijah/orgs","repos_url":"https://api.github.com/users/pelijah/repos","events_url":"https://api.github.com/users/pelijah/events{/privacy}","received_events_url":"https://api.github.com/users/pelijah/received_events","type":"User","site_admin":false},"body":"No default value. Will fail if there is no `.git` directory.","created_at":"2018-05-15T09:47:28Z","updated_at":"2018-05-15T09:48:08Z","html_url":"https://github.com/radare/radare2/pull/10092#discussion_r188227337","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/10092","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/188227337"},"html":{"href":"https://github.com/radare/radare2/pull/10092#discussion_r188227337"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/10092"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/10092","id":187877047,"html_url":"https://github.com/radare/radare2/pull/10092","diff_url":"https://github.com/radare/radare2/pull/10092.diff","patch_url":"https://github.com/radare/radare2/pull/10092.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/10092","number":10092,"state":"open","locked":false,"title":"meson: make git executable optional","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"This is useful in downstream packaging from a tarball","created_at":"2018-05-14T16:06:42Z","updated_at":"2018-05-15T09:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ad096800dbfd214c92b649d4979d0939424a65c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/10092/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/10092/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/10092/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/60096187cee3a37379060a5c6fbed924bbc6171c","head":{"label":"Mic92:optional-git","ref":"optional-git","sha":"60096187cee3a37379060a5c6fbed924bbc6171c","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"repo":{"id":133388064,"name":"radare2","full_name":"Mic92/radare2","owner":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mic92/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":true,"url":"https://api.github.com/repos/Mic92/radare2","forks_url":"https://api.github.com/repos/Mic92/radare2/forks","keys_url":"https://api.github.com/repos/Mic92/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mic92/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mic92/radare2/teams","hooks_url":"https://api.github.com/repos/Mic92/radare2/hooks","issue_events_url":"https://api.github.com/repos/Mic92/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/Mic92/radare2/events","assignees_url":"https://api.github.com/repos/Mic92/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/Mic92/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/Mic92/radare2/tags","blobs_url":"https://api.github.com/repos/Mic92/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mic92/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mic92/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mic92/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mic92/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/Mic92/radare2/languages","stargazers_url":"https://api.github.com/repos/Mic92/radare2/stargazers","contributors_url":"https://api.github.com/repos/Mic92/radare2/contributors","subscribers_url":"https://api.github.com/repos/Mic92/radare2/subscribers","subscription_url":"https://api.github.com/repos/Mic92/radare2/subscription","commits_url":"https://api.github.com/repos/Mic92/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mic92/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mic92/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mic92/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mic92/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/Mic92/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mic92/radare2/merges","archive_url":"https://api.github.com/repos/Mic92/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mic92/radare2/downloads","issues_url":"https://api.github.com/repos/Mic92/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/Mic92/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/Mic92/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/Mic92/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mic92/radare2/labels{/name}","releases_url":"https://api.github.com/repos/Mic92/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/Mic92/radare2/deployments","created_at":"2018-05-14T16:06:14Z","updated_at":"2018-05-14T16:06:23Z","pushed_at":"2018-05-15T08:52:33Z","git_url":"git://github.com/Mic92/radare2.git","ssh_url":"git@github.com:Mic92/radare2.git","clone_url":"https://github.com/Mic92/radare2.git","svn_url":"https://github.com/Mic92/radare2","homepage":"http://www.radare.org/","size":83948,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"6107339580c883a458b7a2a57ca04cc861cd3086","user":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-05-15T09:03:59Z","pushed_at":"2018-05-15T09:20:41Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":83950,"stargazers_count":7343,"watchers_count":7343,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1454,"mirror_url":null,"archived":false,"open_issues_count":884,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":1454,"open_issues":884,"watchers":7343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/10092"},"html":{"href":"https://github.com/radare/radare2/pull/10092"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/10092"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/10092/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/10092/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/10092/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/60096187cee3a37379060a5c6fbed924bbc6171c"}},"author_association":"NONE"}}
{"actor":{"display_login":"pelijah"}}