{"action":"created","issue":{"url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/28","repository_url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel","labels_url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/28/comments","events_url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/28/events","html_url":"https://github.com/goatchurchprime/jupyter_micropython_kernel/pull/28","id":308738603,"number":28,"title":"%sendtofile clean folder uploads","user":{"login":"andrewleech","id":3318786,"avatar_url":"https://avatars0.githubusercontent.com/u/3318786?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewleech","html_url":"https://github.com/andrewleech","followers_url":"https://api.github.com/users/andrewleech/followers","following_url":"https://api.github.com/users/andrewleech/following{/other_user}","gists_url":"https://api.github.com/users/andrewleech/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewleech/subscriptions","organizations_url":"https://api.github.com/users/andrewleech/orgs","repos_url":"https://api.github.com/users/andrewleech/repos","events_url":"https://api.github.com/users/andrewleech/events{/privacy}","received_events_url":"https://api.github.com/users/andrewleech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-26T21:16:42Z","updated_at":"2018-04-24T01:52:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/pulls/28","html_url":"https://github.com/goatchurchprime/jupyter_micropython_kernel/pull/28","diff_url":"https://github.com/goatchurchprime/jupyter_micropython_kernel/pull/28.diff","patch_url":"https://github.com/goatchurchprime/jupyter_micropython_kernel/pull/28.patch"},"body":"When uploading an entire folder to the device, if --mkdir is specified, then delete any existing copy of the folder before uploading new copy.\r\n\r\nI think it feels natural that when uploading a folder, it will replace any existing copy of that folder, just like a file upload replaces the existing file.\r\nThe previous implementation just copies files up, essentially merging the folders together. \r\nThere was no existing means of deleting files that already existed in the folder.\r\n\r\nClean copies of the folder upload is far more useful in my opinion."},"comment":{"url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/comments/383777437","html_url":"https://github.com/goatchurchprime/jupyter_micropython_kernel/pull/28#issuecomment-383777437","issue_url":"https://api.github.com/repos/goatchurchprime/jupyter_micropython_kernel/issues/28","id":383777437,"user":{"login":"andrewleech","id":3318786,"avatar_url":"https://avatars0.githubusercontent.com/u/3318786?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewleech","html_url":"https://github.com/andrewleech","followers_url":"https://api.github.com/users/andrewleech/followers","following_url":"https://api.github.com/users/andrewleech/following{/other_user}","gists_url":"https://api.github.com/users/andrewleech/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewleech/subscriptions","organizations_url":"https://api.github.com/users/andrewleech/orgs","repos_url":"https://api.github.com/users/andrewleech/repos","events_url":"https://api.github.com/users/andrewleech/events{/privacy}","received_events_url":"https://api.github.com/users/andrewleech/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T01:52:52Z","updated_at":"2018-04-24T01:52:52Z","author_association":"NONE","body":"Nice work!\r\nYes I feel you're probably right, this could be done cleaner & faster following rsync's lead.\r\n\r\nThe directory traversal stuff seems to be specific to the official rsync application, but at least following the format and conventions of it's source/dest args (trailing slashes etc) would make a lot of sense.\r\n\r\nThere are a few pure python implementations of rsync (like) hashed file sending:\r\nhttp://code.activestate.com/recipes/577518-rsync-algorithm/\r\nhttps://blog.liw.fi/posts/rsync-in-python/\r\nhttps://github.com/skorokithakis/omnisync"}}
{"actor":{"display_login":"andrewleech"}}