{"action":"created","issue":{"url":"https://api.github.com/repos/apache/metron/issues/1247","repository_url":"https://api.github.com/repos/apache/metron","labels_url":"https://api.github.com/repos/apache/metron/issues/1247/labels{/name}","comments_url":"https://api.github.com/repos/apache/metron/issues/1247/comments","events_url":"https://api.github.com/repos/apache/metron/issues/1247/events","html_url":"https://github.com/apache/metron/pull/1247","id":374088657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODY5OTI0","number":1247,"title":"METRON-1845 Correct Test Data Load in Elasticsearch Integration Tests","user":{"login":"nickwallen","id":2475409,"node_id":"MDQ6VXNlcjI0NzU0MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2475409?v=4","gravatar_id":"","url":"https://api.github.com/users/nickwallen","html_url":"https://github.com/nickwallen","followers_url":"https://api.github.com/users/nickwallen/followers","following_url":"https://api.github.com/users/nickwallen/following{/other_user}","gists_url":"https://api.github.com/users/nickwallen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickwallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickwallen/subscriptions","organizations_url":"https://api.github.com/users/nickwallen/orgs","repos_url":"https://api.github.com/users/nickwallen/repos","events_url":"https://api.github.com/users/nickwallen/events{/privacy}","received_events_url":"https://api.github.com/users/nickwallen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-25T19:04:44Z","updated_at":"2018-11-16T15:39:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/1247","html_url":"https://github.com/apache/metron/pull/1247","diff_url":"https://github.com/apache/metron/pull/1247.diff","patch_url":"https://github.com/apache/metron/pull/1247.patch"},"body":"The Elasticsearch integration tests use the Elasticsearch API to load the test data before running the tests.  Loading the test data like this does not accurately reflect how the indices will appear in a production environment.\r\n\r\nThis should be changed to use our existing `ElasticsearchUpdateDao` to write the test data.  This ensures that any changes made to the 'write' portion of our Elasticsearch code will function correctly with the 'read' portion. Said in a different way, this ensures that telemetry written into Elasticsearch by 'Indexing' can be read correctly by the Alerts UI.\r\n\r\n- [x] Do not merge until after #1242.  This change is dependent on #1242.  Take a look at the last commit to view the changes specific to this PR.\r\n\r\n## Testing\r\n\r\nThis only changes the integration tests.  If the integration tests pass, we're golden.\r\n\r\n## Pull Request Checklist\r\n\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).\r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [ ] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n"},"comment":{"url":"https://api.github.com/repos/apache/metron/issues/comments/439432511","html_url":"https://github.com/apache/metron/pull/1247#issuecomment-439432511","issue_url":"https://api.github.com/repos/apache/metron/issues/1247","id":439432511,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTQzMjUxMQ==","user":{"login":"nickwallen","id":2475409,"node_id":"MDQ6VXNlcjI0NzU0MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2475409?v=4","gravatar_id":"","url":"https://api.github.com/users/nickwallen","html_url":"https://github.com/nickwallen","followers_url":"https://api.github.com/users/nickwallen/followers","following_url":"https://api.github.com/users/nickwallen/following{/other_user}","gists_url":"https://api.github.com/users/nickwallen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickwallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickwallen/subscriptions","organizations_url":"https://api.github.com/users/nickwallen/orgs","repos_url":"https://api.github.com/users/nickwallen/repos","events_url":"https://api.github.com/users/nickwallen/events{/privacy}","received_events_url":"https://api.github.com/users/nickwallen/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T15:39:46Z","updated_at":"2018-11-16T15:39:46Z","author_association":"CONTRIBUTOR","body":"I have merged this with master to pull in the changes from #1242.  This is ready for review."}}
{"actor":{"display_login":"nickwallen"}}