{"action":"created","issue":{"url":"https://api.github.com/repos/internetarchive/openlibrary/issues/1248","repository_url":"https://api.github.com/repos/internetarchive/openlibrary","labels_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/1248/labels{/name}","comments_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/1248/comments","events_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/1248/events","html_url":"https://github.com/internetarchive/openlibrary/issues/1248","id":366391643,"node_id":"MDU6SXNzdWUzNjYzOTE2NDM=","number":1248,"title":"Make sign up page v2","user":{"login":"jdlrobson","id":148752,"node_id":"MDQ6VXNlcjE0ODc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/148752?v=4","gravatar_id":"","url":"https://api.github.com/users/jdlrobson","html_url":"https://github.com/jdlrobson","followers_url":"https://api.github.com/users/jdlrobson/followers","following_url":"https://api.github.com/users/jdlrobson/following{/other_user}","gists_url":"https://api.github.com/users/jdlrobson/gists{/gist_id}","starred_url":"https://api.github.com/users/jdlrobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdlrobson/subscriptions","organizations_url":"https://api.github.com/users/jdlrobson/orgs","repos_url":"https://api.github.com/users/jdlrobson/repos","events_url":"https://api.github.com/users/jdlrobson/events{/privacy}","received_events_url":"https://api.github.com/users/jdlrobson/received_events","type":"User","site_admin":false},"labels":[{"id":737876240,"node_id":"MDU6TGFiZWw3Mzc4NzYyNDA=","url":"https://api.github.com/repos/internetarchive/openlibrary/labels/good%20first%20issue","name":"good first issue","color":"471396","default":true},{"id":730006944,"node_id":"MDU6TGFiZWw3MzAwMDY5NDQ=","url":"https://api.github.com/repos/internetarchive/openlibrary/labels/mobile%20&%20responsive","name":"mobile & responsive","color":"bfd339","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-03T15:16:30Z","updated_at":"2018-10-13T00:55:28Z","closed_at":null,"author_association":"COLLABORATOR","body":"We currently maintain 2 versions of a page.  We are trying to get to one by making all our pages \"v2\". The  sign up page at https://openlibrary.org/account/create should be converted\r\n\r\nThe more modern version 2 (v2) gets\r\n* more modern JS\r\n* JS is not render blocking (so page loads faster)\r\n* page is mobile friendly\r\n\r\nTo migrate a page do the following\r\n- [ ] Set v2 on the page object passed to any templates (e.g. 8d79b57)\r\n- [ ] confirm #test-body-mobile is present in the HTML\r\n- [ ] Load the page and view source. Identify all script tags in the page\r\n- [ ] Ensure the inline scripts in the page are wrapped in a window.q handler\r\n- [ ] Test the page - is everything working as before?\r\n- [ ] Open the page in a mobile browser - is everything working as before. Do any components need optimising for mobile?\r\n\r\n### Using the window.q handler\r\ne.g.\r\n```\r\n$( function () {\r\n  doSomething();\r\n} )\r\n```\r\n\r\nbecomes:\r\n```\r\nwindow.q.push( function () {\r\n  doSomething();\r\n} )\r\n```\r\nHere's an example for the subject page: 0abff2f\r\n\r\n### Optimising the page for mobile\r\nDo not change any CSS, instead move any problematic styles on mobile into a media query scoped to desktop. Problematic style properties tend to be float, width and problems relating to the box-sizing model.\r\n\r\nAny inline styles should be moved into a component or the legacy.less file.\r\n\r\nHere's an example for the subject page:\r\n0fd34b5\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/internetarchive/openlibrary/issues/comments/429498067","html_url":"https://github.com/internetarchive/openlibrary/issues/1248#issuecomment-429498067","issue_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/1248","id":429498067,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ5ODA2Nw==","user":{"login":"jdlrobson","id":148752,"node_id":"MDQ6VXNlcjE0ODc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/148752?v=4","gravatar_id":"","url":"https://api.github.com/users/jdlrobson","html_url":"https://github.com/jdlrobson","followers_url":"https://api.github.com/users/jdlrobson/followers","following_url":"https://api.github.com/users/jdlrobson/following{/other_user}","gists_url":"https://api.github.com/users/jdlrobson/gists{/gist_id}","starred_url":"https://api.github.com/users/jdlrobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdlrobson/subscriptions","organizations_url":"https://api.github.com/users/jdlrobson/orgs","repos_url":"https://api.github.com/users/jdlrobson/repos","events_url":"https://api.github.com/users/jdlrobson/events{/privacy}","received_events_url":"https://api.github.com/users/jdlrobson/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T00:55:28Z","updated_at":"2018-10-13T00:55:28Z","author_association":"COLLABORATOR","body":"Im away for the weekend but will have a look when i get back. Thank you for contributing! Cant wait to check it out!"}}
{"actor":{"display_login":"jdlrobson"}}