{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/ui/pulls/comments/238865254","pull_request_review_id":181498672,"id":238865254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODg2NTI1NA==","diff_hunk":"@@ -0,0 +1,667 @@\n+{{#accordion-list showExpandAll=false as |al expandFn|}}\n+{{#if (eq step 1)}}\n+  {{#accordion-list-item\n+    title=(t 'clusterNew.huaweicce.access.title')\n+    detail=(t 'clusterNew.huaweicce.access.detail')\n+    expandOnInit=true\n+    expandAll=al.expandAll\n+    expand=(action expandFn)\n+  }}\n+    <div class=\"row\">\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">\n+          {{t 'clusterNew.huaweicce.zone.label'}}\n+        </label>\n+        {{searchable-select\n+          class=\"form-control\"\n+          content=zones\n+          value=config.zone\n+          allowCustom=true\n+        }}\n+        <p class=\"text-info text-small m-0\">{{t 'clusterNew.huaweicce.zone.helpText' htmlSafe=true}}</p>\n+      </div>\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">{{t 'clusterNew.huaweicce.projectId.label'}}{{field-required}}</label>\n+        {{input type=\"text\"\n+                value=config.projectId\n+                classNames=\"form-control\"\n+                placeholder=(t 'clusterNew.huaweicce.projectId.placeholder')}}\n+        <p class=\"text-info text-small m-0\">{{t 'clusterNew.huaweicce.projectId.help' htmlSafe=true}}</p>\n+      </div>\n+    </div>\n+    {{#unless authConfigred}}\n+      <div class=\"row\">\n+        <div class=\"col span-6 mb-0\">\n+          <label class=\"acc-label\">\n+            {{t 'clusterNew.huaweicce.accessKey.label'}}{{field-required}}\n+          </label>\n+          {{input type=\"text\"\n+                  value=config.accessKey\n+                  classNames=\"form-control\"\n+                  placeholder=(t 'clusterNew.huaweicce.accessKey.placeholder')}}\n+          <p class=\"text-info text-small m-0\">{{t 'clusterNew.huaweicce.accessKey.help' htmlSafe=true}}</p>\n+        </div>\n+        <div class=\"col span-6 mb-0\">\n+          <label class=\"acc-label\">{{t 'clusterNew.huaweicce.secretKey.label'}}{{field-required}}</label>\n+          {{input type=\"password\"\n+                  value=config.secretKey\n+                  classNames=\"form-control\"\n+                  placeholder=(t 'clusterNew.huaweicce.secretKey.placeholder')}}\n+        </div>\n+      </div>\n+    {{/unless}}\n+  {{/accordion-list-item}}\n+{{/if}}\n+\n+{{#if (or (eq step 2) (eq step 3))}}\n+  {{#accordion-list-item\n+    title=(t 'clusterNew.huaweicce.access.title')\n+    detail=(t 'clusterNew.huaweicce.access.detail')\n+    expandOnInit=false\n+    expandAll=al.expandAll\n+    expand=(action expandFn)\n+  }}\n+    <div class=\"row\">\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">\n+          {{t 'clusterNew.huaweicce.zone.label'}}\n+        </label>\n+        <div>{{config.zone}}</div>\n+      </div>\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">{{t 'clusterNew.huaweicce.projectId.label'}}</label>\n+        <div>{{config.projectId}}</div>\n+      </div>\n+    </div>\n+    {{#unless authConfigred}}\n+    <div class=\"row\">\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">\n+          {{t 'clusterNew.huaweicce.accessKey.label'}}\n+        </label>\n+        <div>{{config.accessKey}}</div>\n+      </div>\n+      <div class=\"col span-6 mb-0\">\n+        <label class=\"acc-label\">{{t 'clusterNew.huaweicce.secretKey.label'}}</label>\n+        <div>**************</div>","path":"lib/shared/addon/components/cluster-driver/driver-huaweicce/template.hbs","position":86,"original_position":86,"commit_id":"afec0de41f45946dba9a22fd99507af730ed65bd","original_commit_id":"afec0de41f45946dba9a22fd99507af730ed65bd","user":{"login":"westlywright","id":858614,"node_id":"MDQ6VXNlcjg1ODYxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/858614?v=4","gravatar_id":"","url":"https://api.github.com/users/westlywright","html_url":"https://github.com/westlywright","followers_url":"https://api.github.com/users/westlywright/followers","following_url":"https://api.github.com/users/westlywright/following{/other_user}","gists_url":"https://api.github.com/users/westlywright/gists{/gist_id}","starred_url":"https://api.github.com/users/westlywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westlywright/subscriptions","organizations_url":"https://api.github.com/users/westlywright/orgs","repos_url":"https://api.github.com/users/westlywright/repos","events_url":"https://api.github.com/users/westlywright/events{/privacy}","received_events_url":"https://api.github.com/users/westlywright/received_events","type":"User","site_admin":false},"body":"Use the same ui that exists for amazon eks password fields.","created_at":"2018-12-04T22:31:01Z","updated_at":"2018-12-04T22:52:37Z","html_url":"https://github.com/rancher/ui/pull/2456#discussion_r238865254","pull_request_url":"https://api.github.com/repos/rancher/ui/pulls/2456","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rancher/ui/pulls/comments/238865254"},"html":{"href":"https://github.com/rancher/ui/pull/2456#discussion_r238865254"},"pull_request":{"href":"https://api.github.com/repos/rancher/ui/pulls/2456"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/ui/pulls/2456","id":235203771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjAzNzcx","html_url":"https://github.com/rancher/ui/pull/2456","diff_url":"https://github.com/rancher/ui/pull/2456.diff","patch_url":"https://github.com/rancher/ui/pull/2456.patch","issue_url":"https://api.github.com/repos/rancher/ui/issues/2456","number":2456,"state":"open","locked":false,"title":"Support Aliyun/Tencent/Huawe hosted k8s","user":{"login":"loganhz","id":21168270,"node_id":"MDQ6VXNlcjIxMTY4Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/21168270?v=4","gravatar_id":"","url":"https://api.github.com/users/loganhz","html_url":"https://github.com/loganhz","followers_url":"https://api.github.com/users/loganhz/followers","following_url":"https://api.github.com/users/loganhz/following{/other_user}","gists_url":"https://api.github.com/users/loganhz/gists{/gist_id}","starred_url":"https://api.github.com/users/loganhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganhz/subscriptions","organizations_url":"https://api.github.com/users/loganhz/orgs","repos_url":"https://api.github.com/users/loganhz/repos","events_url":"https://api.github.com/users/loganhz/events{/privacy}","received_events_url":"https://api.github.com/users/loganhz/received_events","type":"User","site_admin":false},"body":"<!-- HTML Comments can be left in place or removed, dealers choice. They are present simply to guide you on your pull-request journey. --> \r\nProposed changes\r\n======\r\nSupport Aliyun/Tencent/Huawe hosted k8s\r\n<!-- \r\n\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n\r\n-->\r\n\r\nTypes of changes\r\n======\r\n- New feature (non-breaking change which adds functionality)\r\n<!-- \r\n\r\nWhat types of changes does your code introduce to Rancher?\r\n- Bugfix (non-breaking change which fixes an issue)\r\n- New feature (non-breaking change which adds functionality)\r\n- Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n-->\r\n\r\nLinked Issues\r\n======\r\nhttps://github.com/rancher/rancher/issues/16809\r\n<!--\r\n\r\nLink any related issues, pull-requests, or commit hashes that are relavent to this pull-request.\r\n\r\nIf you are opening a PR without a corresponding issue create an issue before you do. This will help QA massively. PR's opened without linked issues will not be merged until an issue is created and linked here. \r\n\r\n--> \r\n\r\nFurther comments\r\n======\r\n<!-- \r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... \r\n\r\n-->\r\n","created_at":"2018-12-01T16:50:22Z","updated_at":"2018-12-04T22:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a694a07e8e0116a1bd62757754386e1c57b39c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1025318600,"node_id":"MDU6TGFiZWwxMDI1MzE4NjAw","url":"https://api.github.com/repos/rancher/ui/labels/status/ready-for-review","name":"status/ready-for-review","color":"54ea89","default":false},{"id":1025315477,"node_id":"MDU6TGFiZWwxMDI1MzE1NDc3","url":"https://api.github.com/repos/rancher/ui/labels/status/waiting-backend-changes","name":"status/waiting-backend-changes","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/ui/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/rancher/ui/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/rancher/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/ui/issues/2456/comments","statuses_url":"https://api.github.com/repos/rancher/ui/statuses/afec0de41f45946dba9a22fd99507af730ed65bd","head":{"label":"loganhz:k8s","ref":"k8s","sha":"afec0de41f45946dba9a22fd99507af730ed65bd","user":{"login":"loganhz","id":21168270,"node_id":"MDQ6VXNlcjIxMTY4Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/21168270?v=4","gravatar_id":"","url":"https://api.github.com/users/loganhz","html_url":"https://github.com/loganhz","followers_url":"https://api.github.com/users/loganhz/followers","following_url":"https://api.github.com/users/loganhz/following{/other_user}","gists_url":"https://api.github.com/users/loganhz/gists{/gist_id}","starred_url":"https://api.github.com/users/loganhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganhz/subscriptions","organizations_url":"https://api.github.com/users/loganhz/orgs","repos_url":"https://api.github.com/users/loganhz/repos","events_url":"https://api.github.com/users/loganhz/events{/privacy}","received_events_url":"https://api.github.com/users/loganhz/received_events","type":"User","site_admin":false},"repo":{"id":103224590,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMyMjQ1OTA=","name":"ui","full_name":"loganhz/ui","private":false,"owner":{"login":"loganhz","id":21168270,"node_id":"MDQ6VXNlcjIxMTY4Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/21168270?v=4","gravatar_id":"","url":"https://api.github.com/users/loganhz","html_url":"https://github.com/loganhz","followers_url":"https://api.github.com/users/loganhz/followers","following_url":"https://api.github.com/users/loganhz/following{/other_user}","gists_url":"https://api.github.com/users/loganhz/gists{/gist_id}","starred_url":"https://api.github.com/users/loganhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganhz/subscriptions","organizations_url":"https://api.github.com/users/loganhz/orgs","repos_url":"https://api.github.com/users/loganhz/repos","events_url":"https://api.github.com/users/loganhz/events{/privacy}","received_events_url":"https://api.github.com/users/loganhz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/loganhz/ui","description":"Rancher UI","fork":true,"url":"https://api.github.com/repos/loganhz/ui","forks_url":"https://api.github.com/repos/loganhz/ui/forks","keys_url":"https://api.github.com/repos/loganhz/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loganhz/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loganhz/ui/teams","hooks_url":"https://api.github.com/repos/loganhz/ui/hooks","issue_events_url":"https://api.github.com/repos/loganhz/ui/issues/events{/number}","events_url":"https://api.github.com/repos/loganhz/ui/events","assignees_url":"https://api.github.com/repos/loganhz/ui/assignees{/user}","branches_url":"https://api.github.com/repos/loganhz/ui/branches{/branch}","tags_url":"https://api.github.com/repos/loganhz/ui/tags","blobs_url":"https://api.github.com/repos/loganhz/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loganhz/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loganhz/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/loganhz/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loganhz/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/loganhz/ui/languages","stargazers_url":"https://api.github.com/repos/loganhz/ui/stargazers","contributors_url":"https://api.github.com/repos/loganhz/ui/contributors","subscribers_url":"https://api.github.com/repos/loganhz/ui/subscribers","subscription_url":"https://api.github.com/repos/loganhz/ui/subscription","commits_url":"https://api.github.com/repos/loganhz/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/loganhz/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/loganhz/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/loganhz/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/loganhz/ui/contents/{+path}","compare_url":"https://api.github.com/repos/loganhz/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loganhz/ui/merges","archive_url":"https://api.github.com/repos/loganhz/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loganhz/ui/downloads","issues_url":"https://api.github.com/repos/loganhz/ui/issues{/number}","pulls_url":"https://api.github.com/repos/loganhz/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/loganhz/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/loganhz/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loganhz/ui/labels{/name}","releases_url":"https://api.github.com/repos/loganhz/ui/releases{/id}","deployments_url":"https://api.github.com/repos/loganhz/ui/deployments","created_at":"2017-09-12T05:04:16Z","updated_at":"2017-09-12T05:04:19Z","pushed_at":"2018-12-04T10:50:51Z","git_url":"git://github.com/loganhz/ui.git","ssh_url":"git@github.com:loganhz/ui.git","clone_url":"https://github.com/loganhz/ui.git","svn_url":"https://github.com/loganhz/ui","homepage":"http://rancher.com","size":45974,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"895ba034bb8ef251f930e0db75d04c978ce9061a","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":28155823,"node_id":"MDEwOlJlcG9zaXRvcnkyODE1NTgyMw==","name":"ui","full_name":"rancher/ui","private":false,"owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rancher/ui","description":"Rancher UI","fork":false,"url":"https://api.github.com/repos/rancher/ui","forks_url":"https://api.github.com/repos/rancher/ui/forks","keys_url":"https://api.github.com/repos/rancher/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/ui/teams","hooks_url":"https://api.github.com/repos/rancher/ui/hooks","issue_events_url":"https://api.github.com/repos/rancher/ui/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/ui/events","assignees_url":"https://api.github.com/repos/rancher/ui/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/ui/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/ui/tags","blobs_url":"https://api.github.com/repos/rancher/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/ui/languages","stargazers_url":"https://api.github.com/repos/rancher/ui/stargazers","contributors_url":"https://api.github.com/repos/rancher/ui/contributors","subscribers_url":"https://api.github.com/repos/rancher/ui/subscribers","subscription_url":"https://api.github.com/repos/rancher/ui/subscription","commits_url":"https://api.github.com/repos/rancher/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/ui/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/ui/merges","archive_url":"https://api.github.com/repos/rancher/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/ui/downloads","issues_url":"https://api.github.com/repos/rancher/ui/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/ui/labels{/name}","releases_url":"https://api.github.com/repos/rancher/ui/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/ui/deployments","created_at":"2014-12-17T21:13:03Z","updated_at":"2018-12-04T14:26:27Z","pushed_at":"2018-12-04T15:13:11Z","git_url":"git://github.com/rancher/ui.git","ssh_url":"git@github.com:rancher/ui.git","clone_url":"https://github.com/rancher/ui.git","svn_url":"https://github.com/rancher/ui","homepage":"http://rancher.com","size":45106,"stargazers_count":284,"watchers_count":284,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":248,"open_issues":8,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/ui/pulls/2456"},"html":{"href":"https://github.com/rancher/ui/pull/2456"},"issue":{"href":"https://api.github.com/repos/rancher/ui/issues/2456"},"comments":{"href":"https://api.github.com/repos/rancher/ui/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/ui/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/ui/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/ui/statuses/afec0de41f45946dba9a22fd99507af730ed65bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"westlywright"}}