{"action":"created","issue":{"url":"https://api.github.com/repos/ooni/probe-android/issues/97","repository_url":"https://api.github.com/repos/ooni/probe-android","labels_url":"https://api.github.com/repos/ooni/probe-android/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/ooni/probe-android/issues/97/comments","events_url":"https://api.github.com/repos/ooni/probe-android/issues/97/events","html_url":"https://github.com/ooni/probe-android/issues/97","id":244976076,"node_id":"MDU6SXNzdWUyNDQ5NzYwNzY=","number":97,"title":"Settings seem to persist app deletion","user":{"login":"bassosimone","id":337298,"node_id":"MDQ6VXNlcjMzNzI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"labels":[{"id":188483060,"node_id":"MDU6TGFiZWwxODg0ODMwNjA=","url":"https://api.github.com/repos/ooni/probe-android/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-07-24T05:33:04Z","updated_at":"2018-10-19T08:33:39Z","closed_at":"2018-10-18T17:03:48Z","author_association":"CONTRIBUTOR","body":"I deleted the app on my device. Then, installed another version of the app from Android Studio. I was not presented the on-boarding procedure and settings where already set. This led us to understand that the actual default for `probe_asn` was not correct (see: 22731da).\r\n\r\nThis issue with settings persisting is also the reason why I dismantled the copying of resources as it was implemented before and replaced it with the current checks on file existence."},"comment":{"url":"https://api.github.com/repos/ooni/probe-android/issues/comments/431287885","html_url":"https://github.com/ooni/probe-android/issues/97#issuecomment-431287885","issue_url":"https://api.github.com/repos/ooni/probe-android/issues/97","id":431287885,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTI4Nzg4NQ==","user":{"login":"hellais","id":424620,"node_id":"MDQ6VXNlcjQyNDYyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/424620?v=4","gravatar_id":"","url":"https://api.github.com/users/hellais","html_url":"https://github.com/hellais","followers_url":"https://api.github.com/users/hellais/followers","following_url":"https://api.github.com/users/hellais/following{/other_user}","gists_url":"https://api.github.com/users/hellais/gists{/gist_id}","starred_url":"https://api.github.com/users/hellais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellais/subscriptions","organizations_url":"https://api.github.com/users/hellais/orgs","repos_url":"https://api.github.com/users/hellais/repos","events_url":"https://api.github.com/users/hellais/events{/privacy}","received_events_url":"https://api.github.com/users/hellais/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T08:33:39Z","updated_at":"2018-10-19T08:33:39Z","author_association":"MEMBER","body":"I am also not sure we want to disable the backup of settings, especially in light of the fact that the new app will have many more settings, that can take the user some amount of time to configure.\r\n\r\nI would suggest setting `allowBackup=true` and if the user wants to disable them, they can do it from the system settings.\r\n\r\n@elioqoshi what do you think?"}}
{"actor":{"display_login":"hellais"}}