{"action":"created","issue":{"url":"https://api.github.com/repos/internetarchive/warc/issues/26","repository_url":"https://api.github.com/repos/internetarchive/warc","labels_url":"https://api.github.com/repos/internetarchive/warc/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/internetarchive/warc/issues/26/comments","events_url":"https://api.github.com/repos/internetarchive/warc/issues/26/events","html_url":"https://github.com/internetarchive/warc/pull/26","id":186986291,"node_id":"MDExOlB1bGxSZXF1ZXN0OTIxMDE1MjU=","number":26,"title":"Changes to make library compatible with Python3.","user":{"login":"baali","id":451188,"node_id":"MDQ6VXNlcjQ1MTE4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/451188?v=4","gravatar_id":"","url":"https://api.github.com/users/baali","html_url":"https://github.com/baali","followers_url":"https://api.github.com/users/baali/followers","following_url":"https://api.github.com/users/baali/following{/other_user}","gists_url":"https://api.github.com/users/baali/gists{/gist_id}","starred_url":"https://api.github.com/users/baali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baali/subscriptions","organizations_url":"https://api.github.com/users/baali/orgs","repos_url":"https://api.github.com/users/baali/repos","events_url":"https://api.github.com/users/baali/events{/privacy}","received_events_url":"https://api.github.com/users/baali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-03T06:23:52Z","updated_at":"2018-08-14T07:31:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/internetarchive/warc/pulls/26","html_url":"https://github.com/internetarchive/warc/pull/26","diff_url":"https://github.com/internetarchive/warc/pull/26.diff","patch_url":"https://github.com/internetarchive/warc/pull/26.patch"},"body":"Hello,\r\n\r\nI have been working on to make the library work with Py3. Changes include:\r\n\r\n* Fixing StringIO import and its usage.\r\n* Fixing obsolete __builitin__ import.\r\n* Fixed obsolete DictMixin import for base class and corresponding changes in arguments.\r\n* Specific cases of handling str and bytes type to make sure things are working.\r\n* There are changes in GZipFile, fixed read_member function of GzipFile to return _buffer element for py3.\r\n\r\nExisting tests are working fine with this PR but I think they need to be extended to make sure handling of bytes and str types are working in all possible scenarios. Do let me know your comments and reviews and I will fix and update the PR accordingly.\r\n"},"comment":{"url":"https://api.github.com/repos/internetarchive/warc/issues/comments/412780999","html_url":"https://github.com/internetarchive/warc/pull/26#issuecomment-412780999","issue_url":"https://api.github.com/repos/internetarchive/warc/issues/26","id":412780999,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc4MDk5OQ==","user":{"login":"baali","id":451188,"node_id":"MDQ6VXNlcjQ1MTE4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/451188?v=4","gravatar_id":"","url":"https://api.github.com/users/baali","html_url":"https://github.com/baali","followers_url":"https://api.github.com/users/baali/followers","following_url":"https://api.github.com/users/baali/following{/other_user}","gists_url":"https://api.github.com/users/baali/gists{/gist_id}","starred_url":"https://api.github.com/users/baali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baali/subscriptions","organizations_url":"https://api.github.com/users/baali/orgs","repos_url":"https://api.github.com/users/baali/repos","events_url":"https://api.github.com/users/baali/events{/privacy}","received_events_url":"https://api.github.com/users/baali/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T07:31:40Z","updated_at":"2018-08-14T07:31:40Z","author_association":"NONE","body":"I haven't worked again with this from quite some time, do let me know if you have noticed any bugs and I would be happy to update my PR with fixes... :pray: "}}
{"actor":{"display_login":"baali"}}