{"action":"closed","number":2155,"pull_request":{"url":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155","id":169486270,"html_url":"https://github.com/prebid/Prebid.js/pull/2155","diff_url":"https://github.com/prebid/Prebid.js/pull/2155.diff","patch_url":"https://github.com/prebid/Prebid.js/pull/2155.patch","issue_url":"https://api.github.com/repos/prebid/Prebid.js/issues/2155","number":2155,"state":"closed","locked":false,"title":"Auctionmanager spec refactor pr","user":{"login":"kitwestneat","id":214729,"avatar_url":"https://avatars3.githubusercontent.com/u/214729?v=4","gravatar_id":"","url":"https://api.github.com/users/kitwestneat","html_url":"https://github.com/kitwestneat","followers_url":"https://api.github.com/users/kitwestneat/followers","following_url":"https://api.github.com/users/kitwestneat/following{/other_user}","gists_url":"https://api.github.com/users/kitwestneat/gists{/gist_id}","starred_url":"https://api.github.com/users/kitwestneat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitwestneat/subscriptions","organizations_url":"https://api.github.com/users/kitwestneat/orgs","repos_url":"https://api.github.com/users/kitwestneat/repos","events_url":"https://api.github.com/users/kitwestneat/events{/privacy}","received_events_url":"https://api.github.com/users/kitwestneat/received_events","type":"User","site_admin":false},"body":"## Type of change\r\n- [ x ] Refactoring (no functional changes, no api changes)\r\n\r\n## Description of change\r\nThis pull request refactors auctionmanager_spec.js and readds the timeout test that was removed in #2067. By consolidating a lot of duplicated code, I think it's easier to read and modify. \r\n","created_at":"2018-02-15T21:11:57Z","updated_at":"2018-03-02T21:39:16Z","closed_at":"2018-03-02T21:39:16Z","merged_at":"2018-03-02T21:39:16Z","merge_commit_sha":"c92a5909008ac069b432b9c3fab2be51c261f654","assignee":{"login":"snapwich","id":551085,"avatar_url":"https://avatars3.githubusercontent.com/u/551085?v=4","gravatar_id":"","url":"https://api.github.com/users/snapwich","html_url":"https://github.com/snapwich","followers_url":"https://api.github.com/users/snapwich/followers","following_url":"https://api.github.com/users/snapwich/following{/other_user}","gists_url":"https://api.github.com/users/snapwich/gists{/gist_id}","starred_url":"https://api.github.com/users/snapwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapwich/subscriptions","organizations_url":"https://api.github.com/users/snapwich/orgs","repos_url":"https://api.github.com/users/snapwich/repos","events_url":"https://api.github.com/users/snapwich/events{/privacy}","received_events_url":"https://api.github.com/users/snapwich/received_events","type":"User","site_admin":false},"assignees":[{"login":"snapwich","id":551085,"avatar_url":"https://avatars3.githubusercontent.com/u/551085?v=4","gravatar_id":"","url":"https://api.github.com/users/snapwich","html_url":"https://github.com/snapwich","followers_url":"https://api.github.com/users/snapwich/followers","following_url":"https://api.github.com/users/snapwich/following{/other_user}","gists_url":"https://api.github.com/users/snapwich/gists{/gist_id}","starred_url":"https://api.github.com/users/snapwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapwich/subscriptions","organizations_url":"https://api.github.com/users/snapwich/orgs","repos_url":"https://api.github.com/users/snapwich/repos","events_url":"https://api.github.com/users/snapwich/events{/privacy}","received_events_url":"https://api.github.com/users/snapwich/received_events","type":"User","site_admin":false},{"login":"ndhimehta","id":26911109,"avatar_url":"https://avatars2.githubusercontent.com/u/26911109?v=4","gravatar_id":"","url":"https://api.github.com/users/ndhimehta","html_url":"https://github.com/ndhimehta","followers_url":"https://api.github.com/users/ndhimehta/followers","following_url":"https://api.github.com/users/ndhimehta/following{/other_user}","gists_url":"https://api.github.com/users/ndhimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhimehta/subscriptions","organizations_url":"https://api.github.com/users/ndhimehta/orgs","repos_url":"https://api.github.com/users/ndhimehta/repos","events_url":"https://api.github.com/users/ndhimehta/events{/privacy}","received_events_url":"https://api.github.com/users/ndhimehta/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":492006392,"url":"https://api.github.com/repos/prebid/Prebid.js/labels/LGTM","name":"LGTM","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/prebid/Prebid.js/milestones/14","html_url":"https://github.com/prebid/Prebid.js/milestone/14","labels_url":"https://api.github.com/repos/prebid/Prebid.js/milestones/14/labels","id":3140116,"number":14,"title":"Prebid 1.5.0","description":"","creator":{"login":"mkendall07","id":1870166,"avatar_url":"https://avatars3.githubusercontent.com/u/1870166?v=4","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":8,"state":"open","created_at":"2018-02-23T21:22:02Z","updated_at":"2018-03-02T21:39:16Z","due_on":"2018-03-06T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155/commits","review_comments_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155/comments","review_comment_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/issues/2155/comments","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/91a1036f9d9f33860daa46b55dc718285a1d6ed1","head":{"label":"kitwestneat:auctionmanager_spec-refactor-pr","ref":"auctionmanager_spec-refactor-pr","sha":"91a1036f9d9f33860daa46b55dc718285a1d6ed1","user":{"login":"kitwestneat","id":214729,"avatar_url":"https://avatars3.githubusercontent.com/u/214729?v=4","gravatar_id":"","url":"https://api.github.com/users/kitwestneat","html_url":"https://github.com/kitwestneat","followers_url":"https://api.github.com/users/kitwestneat/followers","following_url":"https://api.github.com/users/kitwestneat/following{/other_user}","gists_url":"https://api.github.com/users/kitwestneat/gists{/gist_id}","starred_url":"https://api.github.com/users/kitwestneat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitwestneat/subscriptions","organizations_url":"https://api.github.com/users/kitwestneat/orgs","repos_url":"https://api.github.com/users/kitwestneat/repos","events_url":"https://api.github.com/users/kitwestneat/events{/privacy}","received_events_url":"https://api.github.com/users/kitwestneat/received_events","type":"User","site_admin":false},"repo":{"id":59241007,"name":"Prebid.js","full_name":"kitwestneat/Prebid.js","owner":{"login":"kitwestneat","id":214729,"avatar_url":"https://avatars3.githubusercontent.com/u/214729?v=4","gravatar_id":"","url":"https://api.github.com/users/kitwestneat","html_url":"https://github.com/kitwestneat","followers_url":"https://api.github.com/users/kitwestneat/followers","following_url":"https://api.github.com/users/kitwestneat/following{/other_user}","gists_url":"https://api.github.com/users/kitwestneat/gists{/gist_id}","starred_url":"https://api.github.com/users/kitwestneat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitwestneat/subscriptions","organizations_url":"https://api.github.com/users/kitwestneat/orgs","repos_url":"https://api.github.com/users/kitwestneat/repos","events_url":"https://api.github.com/users/kitwestneat/events{/privacy}","received_events_url":"https://api.github.com/users/kitwestneat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitwestneat/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":true,"url":"https://api.github.com/repos/kitwestneat/Prebid.js","forks_url":"https://api.github.com/repos/kitwestneat/Prebid.js/forks","keys_url":"https://api.github.com/repos/kitwestneat/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitwestneat/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitwestneat/Prebid.js/teams","hooks_url":"https://api.github.com/repos/kitwestneat/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/kitwestneat/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/kitwestneat/Prebid.js/events","assignees_url":"https://api.github.com/repos/kitwestneat/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/kitwestneat/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/kitwestneat/Prebid.js/tags","blobs_url":"https://api.github.com/repos/kitwestneat/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitwestneat/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitwestneat/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitwestneat/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitwestneat/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kitwestneat/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/kitwestneat/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/kitwestneat/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/kitwestneat/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/kitwestneat/Prebid.js/subscription","commits_url":"https://api.github.com/repos/kitwestneat/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitwestneat/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitwestneat/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitwestneat/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitwestneat/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/kitwestneat/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitwestneat/Prebid.js/merges","archive_url":"https://api.github.com/repos/kitwestneat/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitwestneat/Prebid.js/downloads","issues_url":"https://api.github.com/repos/kitwestneat/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/kitwestneat/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kitwestneat/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kitwestneat/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitwestneat/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/kitwestneat/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/kitwestneat/Prebid.js/deployments","created_at":"2016-05-19T20:36:53Z","updated_at":"2016-05-19T20:36:54Z","pushed_at":"2018-02-15T20:19:32Z","git_url":"git://github.com/kitwestneat/Prebid.js.git","ssh_url":"git@github.com:kitwestneat/Prebid.js.git","clone_url":"https://github.com/kitwestneat/Prebid.js.git","svn_url":"https://github.com/kitwestneat/Prebid.js","homepage":"http://prebid.org","size":4945,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"178955eeaa9e23813526f67eeccb841d01a48d38","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":39321023,"name":"Prebid.js","full_name":"prebid/Prebid.js","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":false,"url":"https://api.github.com/repos/prebid/Prebid.js","forks_url":"https://api.github.com/repos/prebid/Prebid.js/forks","keys_url":"https://api.github.com/repos/prebid/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/Prebid.js/teams","hooks_url":"https://api.github.com/repos/prebid/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/prebid/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/Prebid.js/events","assignees_url":"https://api.github.com/repos/prebid/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/Prebid.js/tags","blobs_url":"https://api.github.com/repos/prebid/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/prebid/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/prebid/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/prebid/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/prebid/Prebid.js/subscription","commits_url":"https://api.github.com/repos/prebid/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/Prebid.js/merges","archive_url":"https://api.github.com/repos/prebid/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/Prebid.js/downloads","issues_url":"https://api.github.com/repos/prebid/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/prebid/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/Prebid.js/deployments","created_at":"2015-07-19T03:26:23Z","updated_at":"2018-02-27T20:52:38Z","pushed_at":"2018-03-02T21:39:16Z","git_url":"git://github.com/prebid/Prebid.js.git","ssh_url":"git@github.com:prebid/Prebid.js.git","clone_url":"https://github.com/prebid/Prebid.js.git","svn_url":"https://github.com/prebid/Prebid.js","homepage":"http://prebid.org","size":5557,"stargazers_count":608,"watchers_count":608,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":614,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":614,"open_issues":87,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155"},"html":{"href":"https://github.com/prebid/Prebid.js/pull/2155"},"issue":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/2155"},"comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/2155/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/2155/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/Prebid.js/statuses/91a1036f9d9f33860daa46b55dc718285a1d6ed1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"snapwich","id":551085,"avatar_url":"https://avatars3.githubusercontent.com/u/551085?v=4","gravatar_id":"","url":"https://api.github.com/users/snapwich","html_url":"https://github.com/snapwich","followers_url":"https://api.github.com/users/snapwich/followers","following_url":"https://api.github.com/users/snapwich/following{/other_user}","gists_url":"https://api.github.com/users/snapwich/gists{/gist_id}","starred_url":"https://api.github.com/users/snapwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapwich/subscriptions","organizations_url":"https://api.github.com/users/snapwich/orgs","repos_url":"https://api.github.com/users/snapwich/repos","events_url":"https://api.github.com/users/snapwich/events{/privacy}","received_events_url":"https://api.github.com/users/snapwich/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":268,"deletions":341,"changed_files":2}}
{"actor":{"display_login":"snapwich"}}