{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-amplify/pulls/comments/200503926","pull_request_review_id":134834806,"id":200503926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDUwMzkyNg==","diff_hunk":"@@ -452,7 +452,7 @@ export default class APIClass {\n                 const cred = Auth.essentialCredentials(credentials);\n                 logger.debug('set credentials for api', cred);","path":"packages/aws-amplify/src/API/API.ts","position":2,"original_position":2,"commit_id":"f8b7b3b7956dc0ca946f110bc7bf757480b72b14","original_commit_id":"f8b7b3b7956dc0ca946f110bc7bf757480b72b14","user":{"login":"jordanranz","id":3868826,"node_id":"MDQ6VXNlcjM4Njg4MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3868826?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanranz","html_url":"https://github.com/jordanranz","followers_url":"https://api.github.com/users/jordanranz/followers","following_url":"https://api.github.com/users/jordanranz/following{/other_user}","gists_url":"https://api.github.com/users/jordanranz/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanranz/subscriptions","organizations_url":"https://api.github.com/users/jordanranz/orgs","repos_url":"https://api.github.com/users/jordanranz/repos","events_url":"https://api.github.com/users/jordanranz/events{/privacy}","received_events_url":"https://api.github.com/users/jordanranz/received_events","type":"User","site_admin":false},"body":"I'm confused with what the cred variable and call to Auth.essentialCredentials is doing. Is this setting credentials for api or just ensuring the credentials are returned properly? Is this call needed here?","created_at":"2018-07-05T22:11:54Z","updated_at":"2018-07-05T22:12:07Z","html_url":"https://github.com/aws/aws-amplify/pull/1024#discussion_r200503926","pull_request_url":"https://api.github.com/repos/aws/aws-amplify/pulls/1024","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/comments/200503926"},"html":{"href":"https://github.com/aws/aws-amplify/pull/1024#discussion_r200503926"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-amplify/pulls/1024","id":194736937,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzM2OTM3","html_url":"https://github.com/aws/aws-amplify/pull/1024","diff_url":"https://github.com/aws/aws-amplify/pull/1024.diff","patch_url":"https://github.com/aws/aws-amplify/pull/1024.patch","issue_url":"https://api.github.com/repos/aws/aws-amplify/issues/1024","number":1024,"state":"open","locked":false,"title":"Amplify Auth typescript enhancement","user":{"login":"powerful23","id":11042868,"node_id":"MDQ6VXNlcjExMDQyODY4","avatar_url":"https://avatars1.githubusercontent.com/u/11042868?v=4","gravatar_id":"","url":"https://api.github.com/users/powerful23","html_url":"https://github.com/powerful23","followers_url":"https://api.github.com/users/powerful23/followers","following_url":"https://api.github.com/users/powerful23/following{/other_user}","gists_url":"https://api.github.com/users/powerful23/gists{/gist_id}","starred_url":"https://api.github.com/users/powerful23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerful23/subscriptions","organizations_url":"https://api.github.com/users/powerful23/orgs","repos_url":"https://api.github.com/users/powerful23/repos","events_url":"https://api.github.com/users/powerful23/events{/privacy}","received_events_url":"https://api.github.com/users/powerful23/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\nAdd typescript definition to Auth module\r\n*Description of changes:*\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-06-13T22:51:12Z","updated_at":"2018-07-05T22:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"779835974ac0a0304439babc14c05dc0f8c8b4e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mlabieniec","id":1417045,"node_id":"MDQ6VXNlcjE0MTcwNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1417045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlabieniec","html_url":"https://github.com/mlabieniec","followers_url":"https://api.github.com/users/mlabieniec/followers","following_url":"https://api.github.com/users/mlabieniec/following{/other_user}","gists_url":"https://api.github.com/users/mlabieniec/gists{/gist_id}","starred_url":"https://api.github.com/users/mlabieniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlabieniec/subscriptions","organizations_url":"https://api.github.com/users/mlabieniec/orgs","repos_url":"https://api.github.com/users/mlabieniec/repos","events_url":"https://api.github.com/users/mlabieniec/events{/privacy}","received_events_url":"https://api.github.com/users/mlabieniec/received_events","type":"User","site_admin":false},{"login":"UnleashedMind","id":6025263,"node_id":"MDQ6VXNlcjYwMjUyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6025263?v=4","gravatar_id":"","url":"https://api.github.com/users/UnleashedMind","html_url":"https://github.com/UnleashedMind","followers_url":"https://api.github.com/users/UnleashedMind/followers","following_url":"https://api.github.com/users/UnleashedMind/following{/other_user}","gists_url":"https://api.github.com/users/UnleashedMind/gists{/gist_id}","starred_url":"https://api.github.com/users/UnleashedMind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnleashedMind/subscriptions","organizations_url":"https://api.github.com/users/UnleashedMind/orgs","repos_url":"https://api.github.com/users/UnleashedMind/repos","events_url":"https://api.github.com/users/UnleashedMind/events{/privacy}","received_events_url":"https://api.github.com/users/UnleashedMind/received_events","type":"User","site_admin":false},{"login":"elorzafe","id":28815678,"node_id":"MDQ6VXNlcjI4ODE1Njc4","avatar_url":"https://avatars2.githubusercontent.com/u/28815678?v=4","gravatar_id":"","url":"https://api.github.com/users/elorzafe","html_url":"https://github.com/elorzafe","followers_url":"https://api.github.com/users/elorzafe/followers","following_url":"https://api.github.com/users/elorzafe/following{/other_user}","gists_url":"https://api.github.com/users/elorzafe/gists{/gist_id}","starred_url":"https://api.github.com/users/elorzafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elorzafe/subscriptions","organizations_url":"https://api.github.com/users/elorzafe/orgs","repos_url":"https://api.github.com/users/elorzafe/repos","events_url":"https://api.github.com/users/elorzafe/events{/privacy}","received_events_url":"https://api.github.com/users/elorzafe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-amplify/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/aws/aws-amplify/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/aws/aws-amplify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-amplify/issues/1024/comments","statuses_url":"https://api.github.com/repos/aws/aws-amplify/statuses/f8b7b3b7956dc0ca946f110bc7bf757480b72b14","head":{"label":"powerful23:amplify-typescript-enhancement","ref":"amplify-typescript-enhancement","sha":"f8b7b3b7956dc0ca946f110bc7bf757480b72b14","user":{"login":"powerful23","id":11042868,"node_id":"MDQ6VXNlcjExMDQyODY4","avatar_url":"https://avatars1.githubusercontent.com/u/11042868?v=4","gravatar_id":"","url":"https://api.github.com/users/powerful23","html_url":"https://github.com/powerful23","followers_url":"https://api.github.com/users/powerful23/followers","following_url":"https://api.github.com/users/powerful23/following{/other_user}","gists_url":"https://api.github.com/users/powerful23/gists{/gist_id}","starred_url":"https://api.github.com/users/powerful23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerful23/subscriptions","organizations_url":"https://api.github.com/users/powerful23/orgs","repos_url":"https://api.github.com/users/powerful23/repos","events_url":"https://api.github.com/users/powerful23/events{/privacy}","received_events_url":"https://api.github.com/users/powerful23/received_events","type":"User","site_admin":false},"repo":{"id":113354554,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNTQ1NTQ=","name":"aws-amplify","full_name":"powerful23/aws-amplify","owner":{"login":"powerful23","id":11042868,"node_id":"MDQ6VXNlcjExMDQyODY4","avatar_url":"https://avatars1.githubusercontent.com/u/11042868?v=4","gravatar_id":"","url":"https://api.github.com/users/powerful23","html_url":"https://github.com/powerful23","followers_url":"https://api.github.com/users/powerful23/followers","following_url":"https://api.github.com/users/powerful23/following{/other_user}","gists_url":"https://api.github.com/users/powerful23/gists{/gist_id}","starred_url":"https://api.github.com/users/powerful23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerful23/subscriptions","organizations_url":"https://api.github.com/users/powerful23/orgs","repos_url":"https://api.github.com/users/powerful23/repos","events_url":"https://api.github.com/users/powerful23/events{/privacy}","received_events_url":"https://api.github.com/users/powerful23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/powerful23/aws-amplify","description":"A declarative library for application development using Cloud services with JavaScript","fork":true,"url":"https://api.github.com/repos/powerful23/aws-amplify","forks_url":"https://api.github.com/repos/powerful23/aws-amplify/forks","keys_url":"https://api.github.com/repos/powerful23/aws-amplify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/powerful23/aws-amplify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/powerful23/aws-amplify/teams","hooks_url":"https://api.github.com/repos/powerful23/aws-amplify/hooks","issue_events_url":"https://api.github.com/repos/powerful23/aws-amplify/issues/events{/number}","events_url":"https://api.github.com/repos/powerful23/aws-amplify/events","assignees_url":"https://api.github.com/repos/powerful23/aws-amplify/assignees{/user}","branches_url":"https://api.github.com/repos/powerful23/aws-amplify/branches{/branch}","tags_url":"https://api.github.com/repos/powerful23/aws-amplify/tags","blobs_url":"https://api.github.com/repos/powerful23/aws-amplify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/powerful23/aws-amplify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/powerful23/aws-amplify/git/refs{/sha}","trees_url":"https://api.github.com/repos/powerful23/aws-amplify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/powerful23/aws-amplify/statuses/{sha}","languages_url":"https://api.github.com/repos/powerful23/aws-amplify/languages","stargazers_url":"https://api.github.com/repos/powerful23/aws-amplify/stargazers","contributors_url":"https://api.github.com/repos/powerful23/aws-amplify/contributors","subscribers_url":"https://api.github.com/repos/powerful23/aws-amplify/subscribers","subscription_url":"https://api.github.com/repos/powerful23/aws-amplify/subscription","commits_url":"https://api.github.com/repos/powerful23/aws-amplify/commits{/sha}","git_commits_url":"https://api.github.com/repos/powerful23/aws-amplify/git/commits{/sha}","comments_url":"https://api.github.com/repos/powerful23/aws-amplify/comments{/number}","issue_comment_url":"https://api.github.com/repos/powerful23/aws-amplify/issues/comments{/number}","contents_url":"https://api.github.com/repos/powerful23/aws-amplify/contents/{+path}","compare_url":"https://api.github.com/repos/powerful23/aws-amplify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/powerful23/aws-amplify/merges","archive_url":"https://api.github.com/repos/powerful23/aws-amplify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/powerful23/aws-amplify/downloads","issues_url":"https://api.github.com/repos/powerful23/aws-amplify/issues{/number}","pulls_url":"https://api.github.com/repos/powerful23/aws-amplify/pulls{/number}","milestones_url":"https://api.github.com/repos/powerful23/aws-amplify/milestones{/number}","notifications_url":"https://api.github.com/repos/powerful23/aws-amplify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/powerful23/aws-amplify/labels{/name}","releases_url":"https://api.github.com/repos/powerful23/aws-amplify/releases{/id}","deployments_url":"https://api.github.com/repos/powerful23/aws-amplify/deployments","created_at":"2017-12-06T18:46:40Z","updated_at":"2018-05-17T19:17:21Z","pushed_at":"2018-07-05T20:28:47Z","git_url":"git://github.com/powerful23/aws-amplify.git","ssh_url":"git@github.com:powerful23/aws-amplify.git","clone_url":"https://github.com/powerful23/aws-amplify.git","svn_url":"https://github.com/powerful23/aws-amplify","homepage":"","size":92284,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"fa9a88b4e5557f3021cf6cf9c3cfd08041bd27aa","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":105590837,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTA4Mzc=","name":"aws-amplify","full_name":"aws/aws-amplify","owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-amplify","description":"A declarative JavaScript library for application development using cloud services.","fork":false,"url":"https://api.github.com/repos/aws/aws-amplify","forks_url":"https://api.github.com/repos/aws/aws-amplify/forks","keys_url":"https://api.github.com/repos/aws/aws-amplify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-amplify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-amplify/teams","hooks_url":"https://api.github.com/repos/aws/aws-amplify/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-amplify/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-amplify/events","assignees_url":"https://api.github.com/repos/aws/aws-amplify/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-amplify/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-amplify/tags","blobs_url":"https://api.github.com/repos/aws/aws-amplify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-amplify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-amplify/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-amplify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-amplify/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-amplify/languages","stargazers_url":"https://api.github.com/repos/aws/aws-amplify/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-amplify/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-amplify/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-amplify/subscription","commits_url":"https://api.github.com/repos/aws/aws-amplify/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-amplify/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-amplify/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-amplify/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-amplify/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-amplify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-amplify/merges","archive_url":"https://api.github.com/repos/aws/aws-amplify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-amplify/downloads","issues_url":"https://api.github.com/repos/aws/aws-amplify/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-amplify/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-amplify/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-amplify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-amplify/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-amplify/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-amplify/deployments","created_at":"2017-10-02T22:17:14Z","updated_at":"2018-07-05T19:30:11Z","pushed_at":"2018-07-05T21:15:23Z","git_url":"git://github.com/aws/aws-amplify.git","ssh_url":"git@github.com:aws/aws-amplify.git","clone_url":"https://github.com/aws/aws-amplify.git","svn_url":"https://github.com/aws/aws-amplify","homepage":"https://aws.github.io/aws-amplify","size":91586,"stargazers_count":3142,"watchers_count":3142,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":357,"mirror_url":null,"archived":false,"open_issues_count":259,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":357,"open_issues":259,"watchers":3142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/1024"},"html":{"href":"https://github.com/aws/aws-amplify/pull/1024"},"issue":{"href":"https://api.github.com/repos/aws/aws-amplify/issues/1024"},"comments":{"href":"https://api.github.com/repos/aws/aws-amplify/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-amplify/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-amplify/statuses/f8b7b3b7956dc0ca946f110bc7bf757480b72b14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jordanranz"}}