{"action":"created","issue":{"url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/7","repository_url":"https://api.github.com/repos/kelvintaywl/dentist.js","labels_url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/7/comments","events_url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/7/events","html_url":"https://github.com/kelvintaywl/dentist.js/pull/7","id":356209151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTUwNjIx","number":7,"title":"[feat] rewrite for NPM publish","user":{"login":"kelvintaywl","id":2164346,"node_id":"MDQ6VXNlcjIxNjQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2164346?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvintaywl","html_url":"https://github.com/kelvintaywl","followers_url":"https://api.github.com/users/kelvintaywl/followers","following_url":"https://api.github.com/users/kelvintaywl/following{/other_user}","gists_url":"https://api.github.com/users/kelvintaywl/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvintaywl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvintaywl/subscriptions","organizations_url":"https://api.github.com/users/kelvintaywl/orgs","repos_url":"https://api.github.com/users/kelvintaywl/repos","events_url":"https://api.github.com/users/kelvintaywl/events{/privacy}","received_events_url":"https://api.github.com/users/kelvintaywl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-01T15:04:42Z","updated_at":"2018-09-14T02:37:54Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/kelvintaywl/dentist.js/pulls/7","html_url":"https://github.com/kelvintaywl/dentist.js/pull/7","diff_url":"https://github.com/kelvintaywl/dentist.js/pull/7.diff","patch_url":"https://github.com/kelvintaywl/dentist.js/pull/7.patch"},"body":"a lot of changes to the setup surrounding the source code.\r\n\r\nresolves #6 \r\n\r\n#### changes\r\n\r\n- rewrite JS in source code with es2015 instead\r\n- use circleCI to auto publish to NPM on successful merge to master\r\n\r\n\r\n#### notes\r\n\r\nbreaking change here would be that, instead of mounting onto String.prototype, i expose the `extract` function simply as-is.\r\n\r\nThe diff below shows the difference between old and new (or, before and after this PR):\r\n\r\n```diff\r\n+ const { extract } = require('dentist');\r\nconst opts = { limit: 1 };\r\n- \"http://example.com?a=1\".extract(opts);\r\n+ extract(\"http://example.com?a=1\", opts);\r\n```"},"comment":{"url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/comments/421212467","html_url":"https://github.com/kelvintaywl/dentist.js/pull/7#issuecomment-421212467","issue_url":"https://api.github.com/repos/kelvintaywl/dentist.js/issues/7","id":421212467,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTIxMjQ2Nw==","user":{"login":"kelvintaywl","id":2164346,"node_id":"MDQ6VXNlcjIxNjQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2164346?v=4","gravatar_id":"","url":"https://api.github.com/users/kelvintaywl","html_url":"https://github.com/kelvintaywl","followers_url":"https://api.github.com/users/kelvintaywl/followers","following_url":"https://api.github.com/users/kelvintaywl/following{/other_user}","gists_url":"https://api.github.com/users/kelvintaywl/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvintaywl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvintaywl/subscriptions","organizations_url":"https://api.github.com/users/kelvintaywl/orgs","repos_url":"https://api.github.com/users/kelvintaywl/repos","events_url":"https://api.github.com/users/kelvintaywl/events{/privacy}","received_events_url":"https://api.github.com/users/kelvintaywl/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T02:37:54Z","updated_at":"2018-09-14T02:37:54Z","author_association":"OWNER","body":"@matthewnitschke I'm working on an automated CI/CD pipeline with CircleCI to push to NPM automatically on merged PRs.\r\n\r\nas part of the migration to NPM, i kinda rewrote the scripts with a more modern JS flavor, as well as changing test framework (jest).\r\n\r\nI chose to stop applying the old `String.prototype.extract`, let me know what you think 🙇 "}}
{"actor":{"display_login":"kelvintaywl"}}