{"action":"closed","number":1058,"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058","id":204558090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTU4MDkw","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1058","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/1058.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/1058.patch","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1058","number":1058,"state":"closed","locked":false,"title":"Firestore: in tests, silence the verbose warning about old timestamp behavior","user":{"login":"var-const","id":8216808,"node_id":"MDQ6VXNlcjgyMTY4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8216808?v=4","gravatar_id":"","url":"https://api.github.com/users/var-const","html_url":"https://github.com/var-const","followers_url":"https://api.github.com/users/var-const/followers","following_url":"https://api.github.com/users/var-const/following{/other_user}","gists_url":"https://api.github.com/users/var-const/gists{/gist_id}","starred_url":"https://api.github.com/users/var-const/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/var-const/subscriptions","organizations_url":"https://api.github.com/users/var-const/orgs","repos_url":"https://api.github.com/users/var-const/repos","events_url":"https://api.github.com/users/var-const/events{/privacy}","received_events_url":"https://api.github.com/users/var-const/received_events","type":"User","site_admin":false},"body":"This cleans up the few leftover places where the warning was still being outputted in tests. Running locally, I get a clean log.","created_at":"2018-07-27T23:04:57Z","updated_at":"2018-07-29T21:32:45Z","closed_at":"2018-07-29T21:32:45Z","merged_at":"2018-07-29T21:32:45Z","merge_commit_sha":"d9e432eb6405144ea0daaf1fa293a578182754ad","assignee":{"login":"var-const","id":8216808,"node_id":"MDQ6VXNlcjgyMTY4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8216808?v=4","gravatar_id":"","url":"https://api.github.com/users/var-const","html_url":"https://github.com/var-const","followers_url":"https://api.github.com/users/var-const/followers","following_url":"https://api.github.com/users/var-const/following{/other_user}","gists_url":"https://api.github.com/users/var-const/gists{/gist_id}","starred_url":"https://api.github.com/users/var-const/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/var-const/subscriptions","organizations_url":"https://api.github.com/users/var-const/orgs","repos_url":"https://api.github.com/users/var-const/repos","events_url":"https://api.github.com/users/var-const/events{/privacy}","received_events_url":"https://api.github.com/users/var-const/received_events","type":"User","site_admin":false},"assignees":[{"login":"var-const","id":8216808,"node_id":"MDQ6VXNlcjgyMTY4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8216808?v=4","gravatar_id":"","url":"https://api.github.com/users/var-const","html_url":"https://github.com/var-const","followers_url":"https://api.github.com/users/var-const/followers","following_url":"https://api.github.com/users/var-const/following{/other_user}","gists_url":"https://api.github.com/users/var-const/gists{/gist_id}","starred_url":"https://api.github.com/users/var-const/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/var-const/subscriptions","organizations_url":"https://api.github.com/users/var-const/orgs","repos_url":"https://api.github.com/users/var-const/repos","events_url":"https://api.github.com/users/var-const/events{/privacy}","received_events_url":"https://api.github.com/users/var-const/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false},{"login":"schmidt-sebastian","id":19397744,"node_id":"MDQ6VXNlcjE5Mzk3NzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/19397744?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidt-sebastian","html_url":"https://github.com/schmidt-sebastian","followers_url":"https://api.github.com/users/schmidt-sebastian/followers","following_url":"https://api.github.com/users/schmidt-sebastian/following{/other_user}","gists_url":"https://api.github.com/users/schmidt-sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidt-sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidt-sebastian/subscriptions","organizations_url":"https://api.github.com/users/schmidt-sebastian/orgs","repos_url":"https://api.github.com/users/schmidt-sebastian/repos","events_url":"https://api.github.com/users/schmidt-sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/schmidt-sebastian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":710626490,"node_id":"MDU6TGFiZWw3MTA2MjY0OTA=","url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels/Component-Firestore","name":"Component-Firestore","color":"e881d1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1058/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/6dd16488085658a13cd69078a881de08826d9b0b","head":{"label":"firebase:varconst/silence-timestamp-warning-in-tests","ref":"varconst/silence-timestamp-warning-in-tests","sha":"6dd16488085658a13cd69078a881de08826d9b0b","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI5MDQ4Mw==","name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-07-28T20:08:27Z","pushed_at":"2018-07-29T21:32:45Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":16024,"stargazers_count":1271,"watchers_count":1271,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":146,"watchers":1271,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"718953e7a6f78577deaa440972178fbd2651b1b3","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI5MDQ4Mw==","name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-07-28T20:08:27Z","pushed_at":"2018-07-29T21:32:45Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":16024,"stargazers_count":1271,"watchers_count":1271,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":146,"watchers":1271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/1058"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1058"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1058/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1058/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/6dd16488085658a13cd69078a881de08826d9b0b"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"var-const","id":8216808,"node_id":"MDQ6VXNlcjgyMTY4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8216808?v=4","gravatar_id":"","url":"https://api.github.com/users/var-const","html_url":"https://github.com/var-const","followers_url":"https://api.github.com/users/var-const/followers","following_url":"https://api.github.com/users/var-const/following{/other_user}","gists_url":"https://api.github.com/users/var-const/gists{/gist_id}","starred_url":"https://api.github.com/users/var-const/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/var-const/subscriptions","organizations_url":"https://api.github.com/users/var-const/orgs","repos_url":"https://api.github.com/users/var-const/repos","events_url":"https://api.github.com/users/var-const/events{/privacy}","received_events_url":"https://api.github.com/users/var-const/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":19,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"var-const"}}