{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130","id":200841981,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODQxOTgx","html_url":"https://github.com/ProteoWizard/pwiz/pull/130","diff_url":"https://github.com/ProteoWizard/pwiz/pull/130.diff","patch_url":"https://github.com/ProteoWizard/pwiz/pull/130.patch","issue_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/130","number":130,"state":"closed","locked":false,"title":"Skyline/work/20180627 fix max retention time","user":{"login":"nickshulman","id":303203,"node_id":"MDQ6VXNlcjMwMzIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/303203?v=4","gravatar_id":"","url":"https://api.github.com/users/nickshulman","html_url":"https://github.com/nickshulman","followers_url":"https://api.github.com/users/nickshulman/followers","following_url":"https://api.github.com/users/nickshulman/following{/other_user}","gists_url":"https://api.github.com/users/nickshulman/gists{/gist_id}","starred_url":"https://api.github.com/users/nickshulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickshulman/subscriptions","organizations_url":"https://api.github.com/users/nickshulman/orgs","repos_url":"https://api.github.com/users/nickshulman/repos","events_url":"https://api.github.com/users/nickshulman/events{/privacy}","received_events_url":"https://api.github.com/users/nickshulman/received_events","type":"User","site_admin":false},"body":"Here is a new pull request for fixing the OverflowException which happens when extracting chromatograms from the command line.\r\nThe root cause of the problem (which I am not addressing in this change) is that when extracting chromatograms from the command line, Skyline does not know how long the chromatogram range is. This has something to do with the fact that the length of the run is stored in the ChromatogramLoadingStatus.\r\n\r\nThe old code would assume that the number of spectra would be 1200 times the length of the run in minutes. This came from the following numbers:\r\n        public const double TIME_MIN_DELTA = 0.2 / 60;\r\n        private const int SPILL_FILE_OVER_ESTIMATION_FACTOR = 4;\r\nMy new code just estimates this as the total number of spectra divided by 4.\r\n\r\nThis new code has two functions \"GetMaxSize\" and \"EstimateGroupSize\". The code makes sure that the total of GetMaxSize is less than 2GB, and tries to keep the total of EstimateGroupSize around 200MB.\r\n\r\nWhen I looked at the user's scenario, my new code ends up creating spill files that end up being 12MB in size. The old code (when running through the UI) would create spill files that were 65MB on disk.","created_at":"2018-07-11T22:24:05Z","updated_at":"2018-07-12T23:00:22Z","closed_at":"2018-07-12T23:00:22Z","merged_at":"2018-07-12T23:00:22Z","merge_commit_sha":"eac80445c7f16fca452a8ec318c67348a6a8c7a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brendanx67","id":11541328,"node_id":"MDQ6VXNlcjExNTQxMzI4","avatar_url":"https://avatars2.githubusercontent.com/u/11541328?v=4","gravatar_id":"","url":"https://api.github.com/users/brendanx67","html_url":"https://github.com/brendanx67","followers_url":"https://api.github.com/users/brendanx67/followers","following_url":"https://api.github.com/users/brendanx67/following{/other_user}","gists_url":"https://api.github.com/users/brendanx67/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanx67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanx67/subscriptions","organizations_url":"https://api.github.com/users/brendanx67/orgs","repos_url":"https://api.github.com/users/brendanx67/repos","events_url":"https://api.github.com/users/brendanx67/events{/privacy}","received_events_url":"https://api.github.com/users/brendanx67/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/130/comments","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/3059fd69c07ac9bd072ca8b7dc8281f8f1f382cf","head":{"label":"ProteoWizard:Skyline/work/20180627_FixMaxRetentionTime","ref":"Skyline/work/20180627_FixMaxRetentionTime","sha":"3059fd69c07ac9bd072ca8b7dc8281f8f1f382cf","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-07-12T20:35:01Z","pushed_at":"2018-07-12T23:00:22Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"git@github.com:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2803809,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"ProteoWizard:master","ref":"master","sha":"dc9cb6047be7d7351600cfffb417a5727fe9dd9d","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-07-12T20:35:01Z","pushed_at":"2018-07-12T23:00:22Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"git@github.com:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2803809,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130"},"html":{"href":"https://github.com/ProteoWizard/pwiz/pull/130"},"issue":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/130"},"comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/3059fd69c07ac9bd072ca8b7dc8281f8f1f382cf"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nickshulman","id":303203,"node_id":"MDQ6VXNlcjMwMzIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/303203?v=4","gravatar_id":"","url":"https://api.github.com/users/nickshulman","html_url":"https://github.com/nickshulman","followers_url":"https://api.github.com/users/nickshulman/followers","following_url":"https://api.github.com/users/nickshulman/following{/other_user}","gists_url":"https://api.github.com/users/nickshulman/gists{/gist_id}","starred_url":"https://api.github.com/users/nickshulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickshulman/subscriptions","organizations_url":"https://api.github.com/users/nickshulman/orgs","repos_url":"https://api.github.com/users/nickshulman/repos","events_url":"https://api.github.com/users/nickshulman/events{/privacy}","received_events_url":"https://api.github.com/users/nickshulman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":49,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"nickshulman"}}