{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/lagom/pulls/comments/202316647","pull_request_review_id":136994279,"id":202316647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjMxNjY0Nw==","diff_hunk":"@@ -142,88 +142,83 @@ object LagomReloadableDevServerStart {\n               // and https://github.com/playframework/playframework/pull/7644\n               //\n               // we should reconsider if still need to have our own reloadable server\n-              implicit val ec = ExecutionContext.global\n-              Await.result(scala.concurrent.Future {","path":"dev/reloadable-server/src/main/scala/play/core/server/LagomReloadableDevServerStart.scala","position":5,"original_position":5,"commit_id":"5767e0aa752153b70165b39053d22dc5b0075589","original_commit_id":"5767e0aa752153b70165b39053d22dc5b0075589","user":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"body":"The main change was to take out the `Future` spawn + `Await`. It's not obvious what the point of that was, but I believe that blocking on the global execution context (without signaling it using [`blocking`](https://www.scala-lang.org/api/current/scala/concurrent/index.html#blocking[T](body:=%3ET):T)) was causing the global execution context to run out of threads.\r\n\r\nBy default, the global execution context has max threads = #CPUs, making this more likely to occur in constrained environments such as Travis CI workers.","created_at":"2018-07-13T11:04:13Z","updated_at":"2018-07-13T11:04:13Z","html_url":"https://github.com/lagom/lagom/pull/1441#discussion_r202316647","pull_request_url":"https://api.github.com/repos/lagom/lagom/pulls/1441","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments/202316647"},"html":{"href":"https://github.com/lagom/lagom/pull/1441#discussion_r202316647"},"pull_request":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1441"}}},"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1441","id":201257894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjU3ODk0","html_url":"https://github.com/lagom/lagom/pull/1441","diff_url":"https://github.com/lagom/lagom/pull/1441.diff","patch_url":"https://github.com/lagom/lagom/pull/1441.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1441","number":1441,"state":"open","locked":false,"title":"Restore sbt 1.1.6","user":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"body":"This appears to fix the deadlock, but it's not clear whether there might be other undesirable consequences. We'll have to do some manual testing (including with the Netty server).\r\n\r\nReview with whitespace changes hidden.\r\n\r\n## References\r\n\r\n#1405 (Update Play to 2.7.0-M1)","created_at":"2018-07-13T11:00:00Z","updated_at":"2018-07-13T11:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e748ccfd133d0196890ce2159bdacc7c81d2973f","assignee":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"assignees":[{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"marcospereira","id":4576,"node_id":"MDQ6VXNlcjQ1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4576?v=4","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/lagom/lagom/milestones/19","html_url":"https://github.com/lagom/lagom/milestone/19","labels_url":"https://api.github.com/repos/lagom/lagom/milestones/19/labels","id":2672504,"node_id":"MDk6TWlsZXN0b25lMjY3MjUwNA==","number":19,"title":"Lagom 1.5.0","description":"","creator":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":13,"state":"open","created_at":"2017-07-31T22:53:14Z","updated_at":"2018-07-13T11:00:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1441/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1441/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1441/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/5767e0aa752153b70165b39053d22dc5b0075589","head":{"label":"TimMoore:sbt-1.1.6-compat","ref":"sbt-1.1.6-compat","sha":"5767e0aa752153b70165b39053d22dc5b0075589","user":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"repo":{"id":70356980,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM1Njk4MA==","name":"lagom","full_name":"TimMoore/lagom","owner":{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimMoore/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/TimMoore/lagom","forks_url":"https://api.github.com/repos/TimMoore/lagom/forks","keys_url":"https://api.github.com/repos/TimMoore/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimMoore/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimMoore/lagom/teams","hooks_url":"https://api.github.com/repos/TimMoore/lagom/hooks","issue_events_url":"https://api.github.com/repos/TimMoore/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/TimMoore/lagom/events","assignees_url":"https://api.github.com/repos/TimMoore/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/TimMoore/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/TimMoore/lagom/tags","blobs_url":"https://api.github.com/repos/TimMoore/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimMoore/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimMoore/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimMoore/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimMoore/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/TimMoore/lagom/languages","stargazers_url":"https://api.github.com/repos/TimMoore/lagom/stargazers","contributors_url":"https://api.github.com/repos/TimMoore/lagom/contributors","subscribers_url":"https://api.github.com/repos/TimMoore/lagom/subscribers","subscription_url":"https://api.github.com/repos/TimMoore/lagom/subscription","commits_url":"https://api.github.com/repos/TimMoore/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimMoore/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimMoore/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimMoore/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimMoore/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/TimMoore/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimMoore/lagom/merges","archive_url":"https://api.github.com/repos/TimMoore/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimMoore/lagom/downloads","issues_url":"https://api.github.com/repos/TimMoore/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/TimMoore/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/TimMoore/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/TimMoore/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimMoore/lagom/labels{/name}","releases_url":"https://api.github.com/repos/TimMoore/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/TimMoore/lagom/deployments","created_at":"2016-10-08T20:56:40Z","updated_at":"2018-07-11T06:53:36Z","pushed_at":"2018-07-13T10:43:21Z","git_url":"git://github.com/TimMoore/lagom.git","ssh_url":"git@github.com:TimMoore/lagom.git","clone_url":"https://github.com/TimMoore/lagom.git","svn_url":"https://github.com/TimMoore/lagom","homepage":"https://lightbend.com/lagom","size":7855,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"3f6f309373d332856d9d07727f57c9a98b06a526","user":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyMDk2Nw==","name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2018-07-13T10:21:35Z","pushed_at":"2018-07-13T11:00:01Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":7873,"stargazers_count":1928,"watchers_count":1928,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":414,"mirror_url":null,"archived":false,"open_issues_count":279,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":414,"open_issues":279,"watchers":1928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1441"},"html":{"href":"https://github.com/lagom/lagom/pull/1441"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1441"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1441/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1441/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1441/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/5767e0aa752153b70165b39053d22dc5b0075589"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TimMoore"}}