{"action":"created","comment":{"url":"https://api.github.com/repos/rollup/rollup/pulls/comments/183275665","pull_request_review_id":114242016,"id":183275665,"diff_hunk":"@@ -99,7 +99,12 @@ export default class ExternalModule {\n \t\t});\n \t}\n \n-\ttraceExport(name: string): Variable {\n+\ttraceExport(\n+\t\tname: string,\n+\t\t_options?: {\n+\t\t\tisExportAllSearch?: boolean;\n+\t\t}","path":"src/ExternalModule.ts","position":9,"original_position":9,"commit_id":"ffd1fd563006e1cc42a86b7dccee60690182be6d","original_commit_id":"ffd1fd563006e1cc42a86b7dccee60690182be6d","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"body":"I figured `module.traceExport(name, { isExportAllSearch: true });` would be more clear to the reader than, `module.traceExport(name, true);`, but I can change it if you want.","created_at":"2018-04-23T04:43:00Z","updated_at":"2018-04-23T04:43:00Z","html_url":"https://github.com/rollup/rollup/pull/2118#discussion_r183275665","pull_request_url":"https://api.github.com/repos/rollup/rollup/pulls/2118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rollup/rollup/pulls/comments/183275665"},"html":{"href":"https://github.com/rollup/rollup/pull/2118#discussion_r183275665"},"pull_request":{"href":"https://api.github.com/repos/rollup/rollup/pulls/2118"}},"in_reply_to_id":183232133},"pull_request":{"url":"https://api.github.com/repos/rollup/rollup/pulls/2118","id":180783156,"html_url":"https://github.com/rollup/rollup/pull/2118","diff_url":"https://github.com/rollup/rollup/pull/2118.diff","patch_url":"https://github.com/rollup/rollup/pull/2118.patch","issue_url":"https://api.github.com/repos/rollup/rollup/issues/2118","number":2118,"state":"open","locked":false,"title":"handle missing exports in chunked mode","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"body":"Revived from #1986\r\n\r\nFrom https://github.com/rollup/rollup/pull/1986#issuecomment-372232259\r\n\r\n@guybedford Turns out I only needed to do # 1, and I got the desired outcome.\r\n\r\n> Perhaps we could support the handleMissingExport hook returning true or false to determine whether to create a variable or to throw?\r\n\r\nI added that in a previous feature, which is partly why this feature is so small!","created_at":"2018-04-11T03:46:05Z","updated_at":"2018-04-23T04:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e002aa002c5f4b0d255af83b04c92a1e9f646c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rollup/rollup/pulls/2118/commits","review_comments_url":"https://api.github.com/repos/rollup/rollup/pulls/2118/comments","review_comment_url":"https://api.github.com/repos/rollup/rollup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rollup/rollup/issues/2118/comments","statuses_url":"https://api.github.com/repos/rollup/rollup/statuses/ffd1fd563006e1cc42a86b7dccee60690182be6d","head":{"label":"kellyselden:chunked-missing-export-3","ref":"chunked-missing-export-3","sha":"ffd1fd563006e1cc42a86b7dccee60690182be6d","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"repo":{"id":112862333,"name":"rollup","full_name":"kellyselden/rollup","owner":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellyselden/rollup","description":"Next-generation ES6 module bundler","fork":true,"url":"https://api.github.com/repos/kellyselden/rollup","forks_url":"https://api.github.com/repos/kellyselden/rollup/forks","keys_url":"https://api.github.com/repos/kellyselden/rollup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellyselden/rollup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellyselden/rollup/teams","hooks_url":"https://api.github.com/repos/kellyselden/rollup/hooks","issue_events_url":"https://api.github.com/repos/kellyselden/rollup/issues/events{/number}","events_url":"https://api.github.com/repos/kellyselden/rollup/events","assignees_url":"https://api.github.com/repos/kellyselden/rollup/assignees{/user}","branches_url":"https://api.github.com/repos/kellyselden/rollup/branches{/branch}","tags_url":"https://api.github.com/repos/kellyselden/rollup/tags","blobs_url":"https://api.github.com/repos/kellyselden/rollup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellyselden/rollup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellyselden/rollup/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellyselden/rollup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellyselden/rollup/statuses/{sha}","languages_url":"https://api.github.com/repos/kellyselden/rollup/languages","stargazers_url":"https://api.github.com/repos/kellyselden/rollup/stargazers","contributors_url":"https://api.github.com/repos/kellyselden/rollup/contributors","subscribers_url":"https://api.github.com/repos/kellyselden/rollup/subscribers","subscription_url":"https://api.github.com/repos/kellyselden/rollup/subscription","commits_url":"https://api.github.com/repos/kellyselden/rollup/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellyselden/rollup/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellyselden/rollup/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellyselden/rollup/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellyselden/rollup/contents/{+path}","compare_url":"https://api.github.com/repos/kellyselden/rollup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellyselden/rollup/merges","archive_url":"https://api.github.com/repos/kellyselden/rollup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellyselden/rollup/downloads","issues_url":"https://api.github.com/repos/kellyselden/rollup/issues{/number}","pulls_url":"https://api.github.com/repos/kellyselden/rollup/pulls{/number}","milestones_url":"https://api.github.com/repos/kellyselden/rollup/milestones{/number}","notifications_url":"https://api.github.com/repos/kellyselden/rollup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellyselden/rollup/labels{/name}","releases_url":"https://api.github.com/repos/kellyselden/rollup/releases{/id}","deployments_url":"https://api.github.com/repos/kellyselden/rollup/deployments","created_at":"2017-12-02T17:30:38Z","updated_at":"2017-12-02T17:30:41Z","pushed_at":"2018-04-23T04:40:07Z","git_url":"git://github.com/kellyselden/rollup.git","ssh_url":"git@github.com:kellyselden/rollup.git","clone_url":"https://github.com/kellyselden/rollup.git","svn_url":"https://github.com/kellyselden/rollup","homepage":"http://rollupjs.org","size":6805,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"rollup:master","ref":"master","sha":"481c47f278cd772d43f2a103ccf4a0cd5d5d9037","user":{"login":"rollup","id":12554859,"avatar_url":"https://avatars2.githubusercontent.com/u/12554859?v=4","gravatar_id":"","url":"https://api.github.com/users/rollup","html_url":"https://github.com/rollup","followers_url":"https://api.github.com/users/rollup/followers","following_url":"https://api.github.com/users/rollup/following{/other_user}","gists_url":"https://api.github.com/users/rollup/gists{/gist_id}","starred_url":"https://api.github.com/users/rollup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollup/subscriptions","organizations_url":"https://api.github.com/users/rollup/orgs","repos_url":"https://api.github.com/users/rollup/repos","events_url":"https://api.github.com/users/rollup/events{/privacy}","received_events_url":"https://api.github.com/users/rollup/received_events","type":"Organization","site_admin":false},"repo":{"id":35640229,"name":"rollup","full_name":"rollup/rollup","owner":{"login":"rollup","id":12554859,"avatar_url":"https://avatars2.githubusercontent.com/u/12554859?v=4","gravatar_id":"","url":"https://api.github.com/users/rollup","html_url":"https://github.com/rollup","followers_url":"https://api.github.com/users/rollup/followers","following_url":"https://api.github.com/users/rollup/following{/other_user}","gists_url":"https://api.github.com/users/rollup/gists{/gist_id}","starred_url":"https://api.github.com/users/rollup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollup/subscriptions","organizations_url":"https://api.github.com/users/rollup/orgs","repos_url":"https://api.github.com/users/rollup/repos","events_url":"https://api.github.com/users/rollup/events{/privacy}","received_events_url":"https://api.github.com/users/rollup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rollup/rollup","description":"Next-generation ES6 module bundler","fork":false,"url":"https://api.github.com/repos/rollup/rollup","forks_url":"https://api.github.com/repos/rollup/rollup/forks","keys_url":"https://api.github.com/repos/rollup/rollup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollup/rollup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollup/rollup/teams","hooks_url":"https://api.github.com/repos/rollup/rollup/hooks","issue_events_url":"https://api.github.com/repos/rollup/rollup/issues/events{/number}","events_url":"https://api.github.com/repos/rollup/rollup/events","assignees_url":"https://api.github.com/repos/rollup/rollup/assignees{/user}","branches_url":"https://api.github.com/repos/rollup/rollup/branches{/branch}","tags_url":"https://api.github.com/repos/rollup/rollup/tags","blobs_url":"https://api.github.com/repos/rollup/rollup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollup/rollup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollup/rollup/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollup/rollup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollup/rollup/statuses/{sha}","languages_url":"https://api.github.com/repos/rollup/rollup/languages","stargazers_url":"https://api.github.com/repos/rollup/rollup/stargazers","contributors_url":"https://api.github.com/repos/rollup/rollup/contributors","subscribers_url":"https://api.github.com/repos/rollup/rollup/subscribers","subscription_url":"https://api.github.com/repos/rollup/rollup/subscription","commits_url":"https://api.github.com/repos/rollup/rollup/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollup/rollup/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollup/rollup/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollup/rollup/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollup/rollup/contents/{+path}","compare_url":"https://api.github.com/repos/rollup/rollup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollup/rollup/merges","archive_url":"https://api.github.com/repos/rollup/rollup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollup/rollup/downloads","issues_url":"https://api.github.com/repos/rollup/rollup/issues{/number}","pulls_url":"https://api.github.com/repos/rollup/rollup/pulls{/number}","milestones_url":"https://api.github.com/repos/rollup/rollup/milestones{/number}","notifications_url":"https://api.github.com/repos/rollup/rollup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollup/rollup/labels{/name}","releases_url":"https://api.github.com/repos/rollup/rollup/releases{/id}","deployments_url":"https://api.github.com/repos/rollup/rollup/deployments","created_at":"2015-05-14T22:26:28Z","updated_at":"2018-04-23T03:31:38Z","pushed_at":"2018-04-23T04:36:19Z","git_url":"git://github.com/rollup/rollup.git","ssh_url":"git@github.com:rollup/rollup.git","clone_url":"https://github.com/rollup/rollup.git","svn_url":"https://github.com/rollup/rollup","homepage":"http://rollupjs.org","size":5722,"stargazers_count":12436,"watchers_count":12436,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":541,"mirror_url":null,"archived":false,"open_issues_count":198,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":541,"open_issues":198,"watchers":12436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rollup/rollup/pulls/2118"},"html":{"href":"https://github.com/rollup/rollup/pull/2118"},"issue":{"href":"https://api.github.com/repos/rollup/rollup/issues/2118"},"comments":{"href":"https://api.github.com/repos/rollup/rollup/issues/2118/comments"},"review_comments":{"href":"https://api.github.com/repos/rollup/rollup/pulls/2118/comments"},"review_comment":{"href":"https://api.github.com/repos/rollup/rollup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rollup/rollup/pulls/2118/commits"},"statuses":{"href":"https://api.github.com/repos/rollup/rollup/statuses/ffd1fd563006e1cc42a86b7dccee60690182be6d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kellyselden"}}