{"action":"created","issue":{"url":"https://api.github.com/repos/contiamo/operational-ui/issues/599","repository_url":"https://api.github.com/repos/contiamo/operational-ui","labels_url":"https://api.github.com/repos/contiamo/operational-ui/issues/599/labels{/name}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/issues/599/comments","events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/599/events","html_url":"https://github.com/contiamo/operational-ui/issues/599","id":341895433,"node_id":"MDU6SXNzdWUzNDE4OTU0MzM=","number":599,"title":"PageContents cannot be stacked","user":{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-17T12:21:29Z","updated_at":"2018-07-18T07:13:00Z","closed_at":null,"author_association":"MEMBER","body":"In order to support the case below, we need two `PageContent`s:\r\n![image](https://user-images.githubusercontent.com/9947422/42816736-1747db26-89cc-11e8-94b4-a113909cc607.png)\r\n\r\nWould require JSX along the lines of \r\n\r\n```jsx\r\n<PageContent areas=\"main side\">\r\n    <Card title={`Job: ${data.name}`}>hi</Card>\r\n    <Card title=\"Job Executions\">I am not gay</Card>\r\n  </PageContent>\r\n<PageContent>\r\n  <Card title=\"Bundle Events\">Hi</Card>\r\n</PageContent>\r\n```\r\n\r\nExcept currently, `PageContent` assumes it will be the _only_ `PageContent` and takes the entire height of its container, rendering the second `PageContent` below the fold, under the page, out of immediate sight.\r\n\r\n**Reproduction**\r\n![image](https://user-images.githubusercontent.com/9947422/42816997-fa2d23a6-89cc-11e8-8813-d65d8211cba4.png)\r\n\r\nHow can we solve this? @fabien0102 @peterszerzo "},"comment":{"url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments/405833131","html_url":"https://github.com/contiamo/operational-ui/issues/599#issuecomment-405833131","issue_url":"https://api.github.com/repos/contiamo/operational-ui/issues/599","id":405833131,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTgzMzEzMQ==","user":{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T07:13:00Z","updated_at":"2018-07-18T07:13:00Z","author_association":"CONTRIBUTOR","body":"I will love to have a compile-time error for this, and I will try to implement this kind of type safety for sure. \r\n\r\nBut I'm not really agree with your argument about runtime warnings and new developers. React for example, have a lot of runtime warnings, same for redux and many other libraries. Sometime it's just easier to add a runtime warning :wink:\r\n\r\nIdea for the compile-time safety: https://codesandbox.io/s/3v6pmjzj8p\r\n\r\n"}}
{"actor":{"display_login":"fabien0102"}}