{"action":"created","comment":{"url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments/214146473","pull_request_review_id":151138868,"id":214146473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE0NjQ3Mw==","diff_hunk":"@@ -0,0 +1,14 @@\n+from packet import auth, app\n+from packet.utils import before_request\n+from packet.packet import sign\n+\n+\n+@app.route(\"/api/v1/<member_username>/sign/<packet_username>\")\n+@auth.oidc_auth\n+@before_request\n+def sign(member_username, packet_username, uid):","path":"packet/routes/api.py","position":9,"original_position":9,"commit_id":"a2031b38bd8fece301234fcd89fd11b66f24ce36","original_commit_id":"b219e3f3143d9180566cabe6800963ad34ae0209","user":{"login":"csssuf","id":1261595,"node_id":"MDQ6VXNlcjEyNjE1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1261595?v=4","gravatar_id":"","url":"https://api.github.com/users/csssuf","html_url":"https://github.com/csssuf","followers_url":"https://api.github.com/users/csssuf/followers","following_url":"https://api.github.com/users/csssuf/following{/other_user}","gists_url":"https://api.github.com/users/csssuf/gists{/gist_id}","starred_url":"https://api.github.com/users/csssuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csssuf/subscriptions","organizations_url":"https://api.github.com/users/csssuf/orgs","repos_url":"https://api.github.com/users/csssuf/repos","events_url":"https://api.github.com/users/csssuf/events{/privacy}","received_events_url":"https://api.github.com/users/csssuf/received_events","type":"User","site_admin":false},"body":"It's also fine if that's not intended; I just don't see a reason to duplicate the signing member's username in the API call if it's always going to be the authenticated user.","created_at":"2018-08-30T19:03:38Z","updated_at":"2018-08-30T19:03:38Z","html_url":"https://github.com/ComputerScienceHouse/packet/pull/11#discussion_r214146473","pull_request_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments/214146473"},"html":{"href":"https://github.com/ComputerScienceHouse/packet/pull/11#discussion_r214146473"},"pull_request":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11"}},"in_reply_to_id":214048396},"pull_request":{"url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11","id":211959788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTU5Nzg4","html_url":"https://github.com/ComputerScienceHouse/packet/pull/11","diff_url":"https://github.com/ComputerScienceHouse/packet/pull/11.diff","patch_url":"https://github.com/ComputerScienceHouse/packet/pull/11.patch","issue_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/11","number":11,"state":"open","locked":false,"title":"Merge SQL Middleman and Packet Backend ","user":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"body":"SQL -> Route middleman, provides necessary data from sql queries\r\nPacket backend functions to relay pertinent information without exposing unnecessary data\r\nAPI route for packet signatures","created_at":"2018-08-30T05:31:04Z","updated_at":"2018-08-30T19:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53108ff50d292bef23ca3ed4992b337a9d41c82a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/11/comments","statuses_url":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/a2031b38bd8fece301234fcd89fd11b66f24ce36","head":{"label":"zedoax:master","ref":"master","sha":"a2031b38bd8fece301234fcd89fd11b66f24ce36","user":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"repo":{"id":146299878,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyOTk4Nzg=","name":"packet","full_name":"zedoax/packet","owner":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zedoax/packet","description":"Web packet written in Python for Computer Science House","fork":true,"url":"https://api.github.com/repos/zedoax/packet","forks_url":"https://api.github.com/repos/zedoax/packet/forks","keys_url":"https://api.github.com/repos/zedoax/packet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zedoax/packet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zedoax/packet/teams","hooks_url":"https://api.github.com/repos/zedoax/packet/hooks","issue_events_url":"https://api.github.com/repos/zedoax/packet/issues/events{/number}","events_url":"https://api.github.com/repos/zedoax/packet/events","assignees_url":"https://api.github.com/repos/zedoax/packet/assignees{/user}","branches_url":"https://api.github.com/repos/zedoax/packet/branches{/branch}","tags_url":"https://api.github.com/repos/zedoax/packet/tags","blobs_url":"https://api.github.com/repos/zedoax/packet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zedoax/packet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zedoax/packet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zedoax/packet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zedoax/packet/statuses/{sha}","languages_url":"https://api.github.com/repos/zedoax/packet/languages","stargazers_url":"https://api.github.com/repos/zedoax/packet/stargazers","contributors_url":"https://api.github.com/repos/zedoax/packet/contributors","subscribers_url":"https://api.github.com/repos/zedoax/packet/subscribers","subscription_url":"https://api.github.com/repos/zedoax/packet/subscription","commits_url":"https://api.github.com/repos/zedoax/packet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zedoax/packet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zedoax/packet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zedoax/packet/issues/comments{/number}","contents_url":"https://api.github.com/repos/zedoax/packet/contents/{+path}","compare_url":"https://api.github.com/repos/zedoax/packet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zedoax/packet/merges","archive_url":"https://api.github.com/repos/zedoax/packet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zedoax/packet/downloads","issues_url":"https://api.github.com/repos/zedoax/packet/issues{/number}","pulls_url":"https://api.github.com/repos/zedoax/packet/pulls{/number}","milestones_url":"https://api.github.com/repos/zedoax/packet/milestones{/number}","notifications_url":"https://api.github.com/repos/zedoax/packet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zedoax/packet/labels{/name}","releases_url":"https://api.github.com/repos/zedoax/packet/releases{/id}","deployments_url":"https://api.github.com/repos/zedoax/packet/deployments","created_at":"2018-08-27T13:17:03Z","updated_at":"2018-08-30T17:38:51Z","pushed_at":"2018-08-30T17:38:49Z","git_url":"git://github.com/zedoax/packet.git","ssh_url":"git@github.com:zedoax/packet.git","clone_url":"https://github.com/zedoax/packet.git","svn_url":"https://github.com/zedoax/packet","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ComputerScienceHouse:master","ref":"master","sha":"b92da8ca40ba2a701238e52112cc056589a3fb12","user":{"login":"ComputerScienceHouse","id":318130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODEzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/318130?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputerScienceHouse","html_url":"https://github.com/ComputerScienceHouse","followers_url":"https://api.github.com/users/ComputerScienceHouse/followers","following_url":"https://api.github.com/users/ComputerScienceHouse/following{/other_user}","gists_url":"https://api.github.com/users/ComputerScienceHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputerScienceHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputerScienceHouse/subscriptions","organizations_url":"https://api.github.com/users/ComputerScienceHouse/orgs","repos_url":"https://api.github.com/users/ComputerScienceHouse/repos","events_url":"https://api.github.com/users/ComputerScienceHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ComputerScienceHouse/received_events","type":"Organization","site_admin":false},"repo":{"id":101905179,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MDUxNzk=","name":"packet","full_name":"ComputerScienceHouse/packet","owner":{"login":"ComputerScienceHouse","id":318130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODEzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/318130?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputerScienceHouse","html_url":"https://github.com/ComputerScienceHouse","followers_url":"https://api.github.com/users/ComputerScienceHouse/followers","following_url":"https://api.github.com/users/ComputerScienceHouse/following{/other_user}","gists_url":"https://api.github.com/users/ComputerScienceHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputerScienceHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputerScienceHouse/subscriptions","organizations_url":"https://api.github.com/users/ComputerScienceHouse/orgs","repos_url":"https://api.github.com/users/ComputerScienceHouse/repos","events_url":"https://api.github.com/users/ComputerScienceHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ComputerScienceHouse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputerScienceHouse/packet","description":"Web packet written in Python for Computer Science House","fork":false,"url":"https://api.github.com/repos/ComputerScienceHouse/packet","forks_url":"https://api.github.com/repos/ComputerScienceHouse/packet/forks","keys_url":"https://api.github.com/repos/ComputerScienceHouse/packet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputerScienceHouse/packet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputerScienceHouse/packet/teams","hooks_url":"https://api.github.com/repos/ComputerScienceHouse/packet/hooks","issue_events_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/events{/number}","events_url":"https://api.github.com/repos/ComputerScienceHouse/packet/events","assignees_url":"https://api.github.com/repos/ComputerScienceHouse/packet/assignees{/user}","branches_url":"https://api.github.com/repos/ComputerScienceHouse/packet/branches{/branch}","tags_url":"https://api.github.com/repos/ComputerScienceHouse/packet/tags","blobs_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputerScienceHouse/packet/languages","stargazers_url":"https://api.github.com/repos/ComputerScienceHouse/packet/stargazers","contributors_url":"https://api.github.com/repos/ComputerScienceHouse/packet/contributors","subscribers_url":"https://api.github.com/repos/ComputerScienceHouse/packet/subscribers","subscription_url":"https://api.github.com/repos/ComputerScienceHouse/packet/subscription","commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputerScienceHouse/packet/contents/{+path}","compare_url":"https://api.github.com/repos/ComputerScienceHouse/packet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputerScienceHouse/packet/merges","archive_url":"https://api.github.com/repos/ComputerScienceHouse/packet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputerScienceHouse/packet/downloads","issues_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues{/number}","pulls_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputerScienceHouse/packet/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputerScienceHouse/packet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputerScienceHouse/packet/labels{/name}","releases_url":"https://api.github.com/repos/ComputerScienceHouse/packet/releases{/id}","deployments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/deployments","created_at":"2017-08-30T16:38:00Z","updated_at":"2018-08-29T23:15:11Z","pushed_at":"2018-08-30T17:38:51Z","git_url":"git://github.com/ComputerScienceHouse/packet.git","ssh_url":"git@github.com:ComputerScienceHouse/packet.git","clone_url":"https://github.com/ComputerScienceHouse/packet.git","svn_url":"https://github.com/ComputerScienceHouse/packet","homepage":null,"size":90,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11"},"html":{"href":"https://github.com/ComputerScienceHouse/packet/pull/11"},"issue":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/11"},"comments":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/a2031b38bd8fece301234fcd89fd11b66f24ce36"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"csssuf"}}