{"action":"closed","number":593,"pull_request":{"url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593","id":171228968,"html_url":"https://github.com/eclipse-ee4j/jaxrs-api/pull/593","diff_url":"https://github.com/eclipse-ee4j/jaxrs-api/pull/593.diff","patch_url":"https://github.com/eclipse-ee4j/jaxrs-api/pull/593.patch","issue_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/593","number":593,"state":"closed","locked":false,"title":"Cleanup EntityTag.equals() / hashcode() (#426)","user":{"login":"NiklasMehner","id":1682195,"avatar_url":"https://avatars1.githubusercontent.com/u/1682195?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMehner","html_url":"https://github.com/NiklasMehner","followers_url":"https://api.github.com/users/NiklasMehner/followers","following_url":"https://api.github.com/users/NiklasMehner/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMehner/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMehner/subscriptions","organizations_url":"https://api.github.com/users/NiklasMehner/orgs","repos_url":"https://api.github.com/users/NiklasMehner/repos","events_url":"https://api.github.com/users/NiklasMehner/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMehner/received_events","type":"User","site_admin":false},"body":"This PR fixes issue #426 and simplifies equals/hashcode in EntityTag.\r\n\r\nAs correctly stated in the ticket the call to super.equals() can never return true, since the super is a simple instance comparison.\r\n\r\nI have also used the Objects.equals()/hash() methods to simplify the code.\r\n\r\nI am not particulary happy with the test since it has the side effect of initializing the EntityType.HEADER_DELEGATE to null. But I do not see any way around this as long as the HEADER_DELEGATE field is is initialized on class initialization. Perhaps this field should be \"inlined\" in the toString() method (but I am not sure on the performance implications of this)\r\n\r\nThe test rule could later be extended to add more functionality (if needed in other tests)","created_at":"2018-02-25T12:57:49Z","updated_at":"2018-04-02T17:14:55Z","closed_at":"2018-04-02T17:14:54Z","merged_at":"2018-04-02T17:14:54Z","merge_commit_sha":"17d3aedaa0d94d058f682756dd2e2c3ded15c614","assignee":{"login":"mkarg","id":1701815,"avatar_url":"https://avatars2.githubusercontent.com/u/1701815?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarg","html_url":"https://github.com/mkarg","followers_url":"https://api.github.com/users/mkarg/followers","following_url":"https://api.github.com/users/mkarg/following{/other_user}","gists_url":"https://api.github.com/users/mkarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarg/subscriptions","organizations_url":"https://api.github.com/users/mkarg/orgs","repos_url":"https://api.github.com/users/mkarg/repos","events_url":"https://api.github.com/users/mkarg/events{/privacy}","received_events_url":"https://api.github.com/users/mkarg/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkarg","id":1701815,"avatar_url":"https://avatars2.githubusercontent.com/u/1701815?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarg","html_url":"https://github.com/mkarg","followers_url":"https://api.github.com/users/mkarg/followers","following_url":"https://api.github.com/users/mkarg/following{/other_user}","gists_url":"https://api.github.com/users/mkarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarg/subscriptions","organizations_url":"https://api.github.com/users/mkarg/orgs","repos_url":"https://api.github.com/users/mkarg/repos","events_url":"https://api.github.com/users/mkarg/events{/privacy}","received_events_url":"https://api.github.com/users/mkarg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":803224064,"url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/milestones/6","html_url":"https://github.com/eclipse-ee4j/jaxrs-api/milestone/6","labels_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/milestones/6/labels","id":3214896,"number":6,"title":"2.2","description":null,"creator":{"login":"mkarg","id":1701815,"avatar_url":"https://avatars2.githubusercontent.com/u/1701815?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarg","html_url":"https://github.com/mkarg","followers_url":"https://api.github.com/users/mkarg/followers","following_url":"https://api.github.com/users/mkarg/following{/other_user}","gists_url":"https://api.github.com/users/mkarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarg/subscriptions","organizations_url":"https://api.github.com/users/mkarg/orgs","repos_url":"https://api.github.com/users/mkarg/repos","events_url":"https://api.github.com/users/mkarg/events{/privacy}","received_events_url":"https://api.github.com/users/mkarg/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":16,"state":"open","created_at":"2018-03-25T10:42:48Z","updated_at":"2018-04-02T17:14:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593/commits","review_comments_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593/comments","review_comment_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/593/comments","statuses_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/statuses/b3b655109894657b7c5fd1a2eda04d5822e85379","head":{"label":"NiklasMehner:issue426","ref":"issue426","sha":"b3b655109894657b7c5fd1a2eda04d5822e85379","user":{"login":"NiklasMehner","id":1682195,"avatar_url":"https://avatars1.githubusercontent.com/u/1682195?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMehner","html_url":"https://github.com/NiklasMehner","followers_url":"https://api.github.com/users/NiklasMehner/followers","following_url":"https://api.github.com/users/NiklasMehner/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMehner/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMehner/subscriptions","organizations_url":"https://api.github.com/users/NiklasMehner/orgs","repos_url":"https://api.github.com/users/NiklasMehner/repos","events_url":"https://api.github.com/users/NiklasMehner/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMehner/received_events","type":"User","site_admin":false},"repo":{"id":121969900,"name":"jaxrs-api","full_name":"NiklasMehner/jaxrs-api","owner":{"login":"NiklasMehner","id":1682195,"avatar_url":"https://avatars1.githubusercontent.com/u/1682195?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMehner","html_url":"https://github.com/NiklasMehner","followers_url":"https://api.github.com/users/NiklasMehner/followers","following_url":"https://api.github.com/users/NiklasMehner/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMehner/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMehner/subscriptions","organizations_url":"https://api.github.com/users/NiklasMehner/orgs","repos_url":"https://api.github.com/users/NiklasMehner/repos","events_url":"https://api.github.com/users/NiklasMehner/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMehner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NiklasMehner/jaxrs-api","description":"Jaxrs","fork":true,"url":"https://api.github.com/repos/NiklasMehner/jaxrs-api","forks_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/forks","keys_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/teams","hooks_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/hooks","issue_events_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/issues/events{/number}","events_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/events","assignees_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/assignees{/user}","branches_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/branches{/branch}","tags_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/tags","blobs_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/statuses/{sha}","languages_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/languages","stargazers_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/stargazers","contributors_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/contributors","subscribers_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/subscribers","subscription_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/subscription","commits_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/contents/{+path}","compare_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/merges","archive_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/downloads","issues_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/issues{/number}","pulls_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/pulls{/number}","milestones_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/milestones{/number}","notifications_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/labels{/name}","releases_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/releases{/id}","deployments_url":"https://api.github.com/repos/NiklasMehner/jaxrs-api/deployments","created_at":"2018-02-18T16:44:11Z","updated_at":"2018-03-22T13:05:45Z","pushed_at":"2018-04-02T16:07:23Z","git_url":"git://github.com/NiklasMehner/jaxrs-api.git","ssh_url":"git@github.com:NiklasMehner/jaxrs-api.git","clone_url":"https://github.com/NiklasMehner/jaxrs-api.git","svn_url":"https://github.com/NiklasMehner/jaxrs-api","homepage":null,"size":260,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse-ee4j:master","ref":"master","sha":"4880f9ce2f41a2c70e91dd95edd3d7fbe7ee0535","user":{"login":"eclipse-ee4j","id":31900942,"avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"repo":{"id":117291995,"name":"jaxrs-api","full_name":"eclipse-ee4j/jaxrs-api","owner":{"login":"eclipse-ee4j","id":31900942,"avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse-ee4j/jaxrs-api","description":"Jaxrs","fork":false,"url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api","forks_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/forks","keys_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/teams","hooks_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/hooks","issue_events_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/events","assignees_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/tags","blobs_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/languages","stargazers_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/stargazers","contributors_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/contributors","subscribers_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/subscribers","subscription_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/subscription","commits_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/merges","archive_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/downloads","issues_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/labels{/name}","releases_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/deployments","created_at":"2018-01-12T22:00:41Z","updated_at":"2018-04-02T07:54:05Z","pushed_at":"2018-04-02T17:14:54Z","git_url":"git://github.com/eclipse-ee4j/jaxrs-api.git","ssh_url":"git@github.com:eclipse-ee4j/jaxrs-api.git","clone_url":"https://github.com/eclipse-ee4j/jaxrs-api.git","svn_url":"https://github.com/eclipse-ee4j/jaxrs-api","homepage":null,"size":253,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":174,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593"},"html":{"href":"https://github.com/eclipse-ee4j/jaxrs-api/pull/593"},"issue":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/593"},"comments":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse-ee4j/jaxrs-api/statuses/b3b655109894657b7c5fd1a2eda04d5822e85379"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mkarg","id":1701815,"avatar_url":"https://avatars2.githubusercontent.com/u/1701815?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarg","html_url":"https://github.com/mkarg","followers_url":"https://api.github.com/users/mkarg/followers","following_url":"https://api.github.com/users/mkarg/following{/other_user}","gists_url":"https://api.github.com/users/mkarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarg/subscriptions","organizations_url":"https://api.github.com/users/mkarg/orgs","repos_url":"https://api.github.com/users/mkarg/repos","events_url":"https://api.github.com/users/mkarg/events{/privacy}","received_events_url":"https://api.github.com/users/mkarg/received_events","type":"User","site_admin":false},"comments":9,"review_comments":25,"maintainer_can_modify":false,"commits":4,"additions":85,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"mkarg"}}