{"action":"created","issue":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1324","repository_url":"https://api.github.com/repos/joel-costigliola/assertj-core","labels_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1324/labels{/name}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1324/comments","events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1324/events","html_url":"https://github.com/joel-costigliola/assertj-core/issues/1324","id":360591479,"node_id":"MDU6SXNzdWUzNjA1OTE0Nzk=","number":1324,"title":"Assertion error message sequencing","user":{"login":"ianbrandt","id":709570,"node_id":"MDQ6VXNlcjcwOTU3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/709570?v=4","gravatar_id":"","url":"https://api.github.com/users/ianbrandt","html_url":"https://github.com/ianbrandt","followers_url":"https://api.github.com/users/ianbrandt/followers","following_url":"https://api.github.com/users/ianbrandt/following{/other_user}","gists_url":"https://api.github.com/users/ianbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbrandt/subscriptions","organizations_url":"https://api.github.com/users/ianbrandt/orgs","repos_url":"https://api.github.com/users/ianbrandt/repos","events_url":"https://api.github.com/users/ianbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/ianbrandt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-16T01:29:50Z","updated_at":"2018-09-16T05:35:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I love AssertJ, but I find the sequencing of many of the error messages to be counterintuitive.\r\n\r\nTake for example:\r\n\r\n> Expecting: `<actual>` to be equal to: `<expected>` but was not.\r\n\r\n[Per Wikipedia](https://en.wikipedia.org/wiki/Colon_(punctuation)):\r\n\r\n> The most common use of the colon is to inform the reader that what follows the colon proves, explains, defines, describes, or lists elements of what preceded it.\r\n\r\nAccordingly, when I begin reading that assertion error message my mind is, well, _expecting_ to see \"Expecting: `<expected>`\", not \"Expecting: `<actual>`\".  It's only when I read the closing, \"but was not\" that I realize I've interpreted the whole error message backwards.\r\n\r\nI believe something like the following would be more intuitive and concise:\r\n\r\n> Expecting: `<expected>`, but was: `<actual>`.\r\n\r\nI realize this may be a matter of personal preference, or of locale, so I'm filing this issue mainly to see if others find the current message style counterintuitive as well.\r\n\r\nIf enough do, maybe the solution would be to just change it, or perhaps some sort of localization or message style facility could be introduced to make it configurable."},"comment":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/comments/421702092","html_url":"https://github.com/joel-costigliola/assertj-core/issues/1324#issuecomment-421702092","issue_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1324","id":421702092,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTcwMjA5Mg==","user":{"login":"ianbrandt","id":709570,"node_id":"MDQ6VXNlcjcwOTU3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/709570?v=4","gravatar_id":"","url":"https://api.github.com/users/ianbrandt","html_url":"https://github.com/ianbrandt","followers_url":"https://api.github.com/users/ianbrandt/followers","following_url":"https://api.github.com/users/ianbrandt/following{/other_user}","gists_url":"https://api.github.com/users/ianbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbrandt/subscriptions","organizations_url":"https://api.github.com/users/ianbrandt/orgs","repos_url":"https://api.github.com/users/ianbrandt/repos","events_url":"https://api.github.com/users/ianbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/ianbrandt/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T05:35:14Z","updated_at":"2018-09-16T05:35:14Z","author_association":"CONTRIBUTOR","body":"Some prior art for configurable reporting styles in Atrium:\r\n\r\nhttps://github.com/robstoll/atrium/blob/v0.7.0/README.md#reporterbuilder."}}
{"actor":{"display_login":"ianbrandt"}}