{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/comments/175044678","pull_request_review_id":104511469,"id":175044678,"diff_hunk":"@@ -984,10 +984,17 @@ The minority chain, mining under the old rules with only 20% of the hashing powe\n \n Hard forks are seen as risky because they force a minority to either upgrade or remain on a minority chain. The risk of splitting the entire system into two competing systems is seen by many as an unacceptable risk. As a result, many developers are reluctant to use the hard fork mechanism to implement upgrades to the consensus rules, unless there is near-unanimous support from the entire network. Any hard fork proposals that do not have near-unanimous support are considered too \"contentious\" to attempt without risking a partition of the system.\n \n-The issue of hard forks is highly controversial in the bitcoin development community, especially as it relates to any proposed changes to the consensus rules controlling the maximum block size limit. Some developers are opposed to any form of hard fork, seeing it as too risky. Others see the mechanism of hard fork as an essential tool for upgrading the consensus rules in a way that avoids \"technical debt\" and provides a clean break with the past. Finally, some developers see hard forks as a mechanism that should be used rarely, with a lot of advance planning and only under near-unanimous consensus.\n+The issue of hard forks is highly controversial in the bitcoin development community. Some developers are opposed to any form of hard fork, seeing it as too risky. Others see the mechanism of hard fork as an essential tool for upgrading the consensus rules in a way that avoids \"technical debt\" and provides a clean break with the past. Finally, some developers see hard forks as a mechanism that should be used rarely, with a lot of advance planning and only under near-unanimous consensus.","path":"ch10.asciidoc","position":14,"original_position":14,"commit_id":"a40d374cf74f8a07dded486734ca1fd261fe4b35","original_commit_id":"991f5b193c754137b0cb7b0de51b62fc61e0ac1e","user":{"login":"gaeshi","id":14256421,"avatar_url":"https://avatars0.githubusercontent.com/u/14256421?v=4","gravatar_id":"","url":"https://api.github.com/users/gaeshi","html_url":"https://github.com/gaeshi","followers_url":"https://api.github.com/users/gaeshi/followers","following_url":"https://api.github.com/users/gaeshi/following{/other_user}","gists_url":"https://api.github.com/users/gaeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/gaeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaeshi/subscriptions","organizations_url":"https://api.github.com/users/gaeshi/orgs","repos_url":"https://api.github.com/users/gaeshi/repos","events_url":"https://api.github.com/users/gaeshi/events{/privacy}","received_events_url":"https://api.github.com/users/gaeshi/received_events","type":"User","site_admin":false},"body":"why was the \"`, especially as it relates to any proposed changes to the consensus rules controlling the maximum block size limit.`\" part removed?","created_at":"2018-03-16T10:10:41Z","updated_at":"2018-03-16T10:10:41Z","html_url":"https://github.com/bitcoinbook/bitcoinbook/pull/522#discussion_r175044678","pull_request_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/comments/175044678"},"html":{"href":"https://github.com/bitcoinbook/bitcoinbook/pull/522#discussion_r175044678"},"pull_request":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522","id":173511548,"html_url":"https://github.com/bitcoinbook/bitcoinbook/pull/522","diff_url":"https://github.com/bitcoinbook/bitcoinbook/pull/522.diff","patch_url":"https://github.com/bitcoinbook/bitcoinbook/pull/522.patch","issue_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/522","number":522,"state":"open","locked":false,"title":"add a Bitcoin Cash note","user":{"login":"nicolasochem","id":93067,"avatar_url":"https://avatars3.githubusercontent.com/u/93067?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasochem","html_url":"https://github.com/nicolasochem","followers_url":"https://api.github.com/users/nicolasochem/followers","following_url":"https://api.github.com/users/nicolasochem/following{/other_user}","gists_url":"https://api.github.com/users/nicolasochem/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasochem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasochem/subscriptions","organizations_url":"https://api.github.com/users/nicolasochem/orgs","repos_url":"https://api.github.com/users/nicolasochem/repos","events_url":"https://api.github.com/users/nicolasochem/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasochem/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-07T16:53:27Z","updated_at":"2018-03-16T10:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b7b65836421da3b269aed665e34ee997c360471","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522/commits","review_comments_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522/comments","review_comment_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/522/comments","statuses_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/statuses/a40d374cf74f8a07dded486734ca1fd261fe4b35","head":{"label":"nicolasochem:bch","ref":"bch","sha":"a40d374cf74f8a07dded486734ca1fd261fe4b35","user":{"login":"nicolasochem","id":93067,"avatar_url":"https://avatars3.githubusercontent.com/u/93067?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasochem","html_url":"https://github.com/nicolasochem","followers_url":"https://api.github.com/users/nicolasochem/followers","following_url":"https://api.github.com/users/nicolasochem/following{/other_user}","gists_url":"https://api.github.com/users/nicolasochem/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasochem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasochem/subscriptions","organizations_url":"https://api.github.com/users/nicolasochem/orgs","repos_url":"https://api.github.com/users/nicolasochem/repos","events_url":"https://api.github.com/users/nicolasochem/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasochem/received_events","type":"User","site_admin":false},"repo":{"id":124265229,"name":"bitcoinbook","full_name":"nicolasochem/bitcoinbook","owner":{"login":"nicolasochem","id":93067,"avatar_url":"https://avatars3.githubusercontent.com/u/93067?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasochem","html_url":"https://github.com/nicolasochem","followers_url":"https://api.github.com/users/nicolasochem/followers","following_url":"https://api.github.com/users/nicolasochem/following{/other_user}","gists_url":"https://api.github.com/users/nicolasochem/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasochem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasochem/subscriptions","organizations_url":"https://api.github.com/users/nicolasochem/orgs","repos_url":"https://api.github.com/users/nicolasochem/repos","events_url":"https://api.github.com/users/nicolasochem/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasochem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolasochem/bitcoinbook","description":"Mastering Bitcoin 2nd Edition - Programming the Open Blockchain","fork":true,"url":"https://api.github.com/repos/nicolasochem/bitcoinbook","forks_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/forks","keys_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/teams","hooks_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/hooks","issue_events_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/issues/events{/number}","events_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/events","assignees_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/assignees{/user}","branches_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/branches{/branch}","tags_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/tags","blobs_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/languages","stargazers_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/stargazers","contributors_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/contributors","subscribers_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/subscribers","subscription_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/subscription","commits_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/contents/{+path}","compare_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/merges","archive_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/downloads","issues_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/issues{/number}","pulls_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/labels{/name}","releases_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/releases{/id}","deployments_url":"https://api.github.com/repos/nicolasochem/bitcoinbook/deployments","created_at":"2018-03-07T16:43:11Z","updated_at":"2018-03-07T16:43:13Z","pushed_at":"2018-03-07T16:56:37Z","git_url":"git://github.com/nicolasochem/bitcoinbook.git","ssh_url":"git@github.com:nicolasochem/bitcoinbook.git","clone_url":"https://github.com/nicolasochem/bitcoinbook.git","svn_url":"https://github.com/nicolasochem/bitcoinbook","homepage":"https://bitcoinbook.info/","size":43850,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bitcoinbook:develop","ref":"develop","sha":"7ec7303842ad1eee08eacdde95726acc96769966","user":{"login":"bitcoinbook","id":5091621,"avatar_url":"https://avatars1.githubusercontent.com/u/5091621?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinbook","html_url":"https://github.com/bitcoinbook","followers_url":"https://api.github.com/users/bitcoinbook/followers","following_url":"https://api.github.com/users/bitcoinbook/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinbook/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinbook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinbook/subscriptions","organizations_url":"https://api.github.com/users/bitcoinbook/orgs","repos_url":"https://api.github.com/users/bitcoinbook/repos","events_url":"https://api.github.com/users/bitcoinbook/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinbook/received_events","type":"Organization","site_admin":false},"repo":{"id":12044132,"name":"bitcoinbook","full_name":"bitcoinbook/bitcoinbook","owner":{"login":"bitcoinbook","id":5091621,"avatar_url":"https://avatars1.githubusercontent.com/u/5091621?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinbook","html_url":"https://github.com/bitcoinbook","followers_url":"https://api.github.com/users/bitcoinbook/followers","following_url":"https://api.github.com/users/bitcoinbook/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinbook/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinbook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinbook/subscriptions","organizations_url":"https://api.github.com/users/bitcoinbook/orgs","repos_url":"https://api.github.com/users/bitcoinbook/repos","events_url":"https://api.github.com/users/bitcoinbook/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinbook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinbook/bitcoinbook","description":"Mastering Bitcoin 2nd Edition - Programming the Open Blockchain","fork":false,"url":"https://api.github.com/repos/bitcoinbook/bitcoinbook","forks_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/forks","keys_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/teams","hooks_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/hooks","issue_events_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/events","assignees_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/tags","blobs_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/languages","stargazers_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/stargazers","contributors_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/contributors","subscribers_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/subscribers","subscription_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/subscription","commits_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/merges","archive_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/downloads","issues_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinbook/bitcoinbook/deployments","created_at":"2013-08-11T23:18:28Z","updated_at":"2018-03-16T10:07:22Z","pushed_at":"2018-03-14T20:01:19Z","git_url":"git://github.com/bitcoinbook/bitcoinbook.git","ssh_url":"git@github.com:bitcoinbook/bitcoinbook.git","clone_url":"https://github.com/bitcoinbook/bitcoinbook.git","svn_url":"https://github.com/bitcoinbook/bitcoinbook","homepage":"https://bitcoinbook.info/","size":43937,"stargazers_count":8518,"watchers_count":8518,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2255,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2255,"open_issues":26,"watchers":8518,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522"},"html":{"href":"https://github.com/bitcoinbook/bitcoinbook/pull/522"},"issue":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/522"},"comments":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinbook/bitcoinbook/statuses/a40d374cf74f8a07dded486734ca1fd261fe4b35"}},"author_association":"NONE"}}
{"actor":{"display_login":"gaeshi"}}