{"action":"created","issue":{"url":"https://api.github.com/repos/craffael/lehrfempp/issues/13","repository_url":"https://api.github.com/repos/craffael/lehrfempp","labels_url":"https://api.github.com/repos/craffael/lehrfempp/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/craffael/lehrfempp/issues/13/comments","events_url":"https://api.github.com/repos/craffael/lehrfempp/issues/13/events","html_url":"https://github.com/craffael/lehrfempp/issues/13","id":330950127,"node_id":"MDU6SXNzdWUzMzA5NTAxMjc=","number":13,"title":"MeshBuilder","user":{"login":"hiptmair","id":33900563,"node_id":"MDQ6VXNlcjMzOTAwNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/33900563?v=4","gravatar_id":"","url":"https://api.github.com/users/hiptmair","html_url":"https://github.com/hiptmair","followers_url":"https://api.github.com/users/hiptmair/followers","following_url":"https://api.github.com/users/hiptmair/following{/other_user}","gists_url":"https://api.github.com/users/hiptmair/gists{/gist_id}","starred_url":"https://api.github.com/users/hiptmair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiptmair/subscriptions","organizations_url":"https://api.github.com/users/hiptmair/orgs","repos_url":"https://api.github.com/users/hiptmair/repos","events_url":"https://api.github.com/users/hiptmair/events{/privacy}","received_events_url":"https://api.github.com/users/hiptmair/received_events","type":"User","site_admin":false},"labels":[{"id":948976635,"node_id":"MDU6TGFiZWw5NDg5NzY2MzU=","url":"https://api.github.com/repos/craffael/lehrfempp/labels/design","name":"design","color":"93ed9a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-10T08:19:27Z","updated_at":"2018-06-10T13:19:08Z","closed_at":null,"author_association":"COLLABORATOR","body":"Imagine the following use case, which is of practical relevance: The cells are affine, but the edge carry a parameterization that provides an exact description of the boundary. In this case just providing vertex coordinates and cell geometries is not enough.\r\n\r\nConversely, vertex positions can be deduced from cell geometries; hence, this piece of information is really redundant. \r\n"},"comment":{"url":"https://api.github.com/repos/craffael/lehrfempp/issues/comments/396048662","html_url":"https://github.com/craffael/lehrfempp/issues/13#issuecomment-396048662","issue_url":"https://api.github.com/repos/craffael/lehrfempp/issues/13","id":396048662,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA0ODY2Mg==","user":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T13:19:08Z","updated_at":"2018-06-10T13:19:08Z","author_association":"OWNER","body":"1. This is something I haven't considered yet. So far I have always assumed that geometrically speaking, a codim=n entity is always bounded by its codim=n+1 entities. But I know, this doesn't have to be the case, I've used such an approach myself in my master thesis. \r\n\r\n2. Yes you are of course correct, this could be deduced from the element geometries.\r\n\r\nA possible solution to both issues would be to replace the `AddPoint()` and `AddElement()` methods with the following method:\r\n```\r\n/**\r\n * @brief Insert a new entity explicitly into the mesh\r\n * @param ref_el The reference element of the entity\r\n * @param node_indices The zero based node-indices that make up this entity. \r\n                       If ref_el == RefEl::kPoint, this range should be empty.\r\n * @param geom  The geometric description of this entity. \r\n                If it is a nullptr, we try to deduce the geometric shape from entities with lower codimensions that have this entity as a sub-entity.\r\n                If this is not, the entity will not be equipped with a geometry and calling Entity::Geometry() on it will return an exception.\r\n * @returns The unique, zero-based consecutive index of the entity (after the mesh has been constructed).\r\n */\r\nsize_type AddEntity(RefEl ref_el, ForwardRange<size_type> node_indices, std::unique_ptr<Geometry> geom)` \r\n```"}}
{"actor":{"display_login":"craffael"}}