{"action":"closed","number":22093,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093","id":166822904,"html_url":"https://github.com/Automattic/wp-calypso/pull/22093","diff_url":"https://github.com/Automattic/wp-calypso/pull/22093.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/22093.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22093","number":22093,"state":"closed","locked":false,"title":"Signup: Fix: Prevent the G Suite upsell from showing twice.","user":{"login":"taggon","id":212034,"avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"body":"In some edge cases, the G Suite upsell shows twice in a domain purchase flow. This PR will check the domain registration context in the cart to solve the problem.\r\n\r\n## Test plan\r\n\r\n1. Set the `gsuiteUpsellV2` test to `show`.\r\n\r\n**The all below process should end within 30 mins to get the accurate test result.**\r\n\r\n2. Create a new website on the free plan.\r\n3. Move to `/domains/manage/YOUR_SITE_DOMAIN` and buy a new custom domain.\r\n4. When you complete the checkout transaction, the G Suite upsell should *NOT* show up.\r\n\r\ncc @fditrapani @klimeryk ","created_at":"2018-02-02T14:59:17Z","updated_at":"2018-02-02T15:15:47Z","closed_at":"2018-02-02T15:15:47Z","merged_at":"2018-02-02T15:15:47Z","merge_commit_sha":"3989b7ad6d3aaa13142a7e00e878ef3c645c9117","assignee":{"login":"taggon","id":212034,"avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"assignees":[{"login":"taggon","id":212034,"avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22093/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/f3eb8c15f49201c1335937f8a5eed3e73a2f63bc","head":{"label":"Automattic:fix/prevent-gsuite-upsell-from-showing-twice","ref":"fix/prevent-gsuite-upsell-from-showing-twice","sha":"f3eb8c15f49201c1335937f8a5eed3e73a2f63bc","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-02-02T14:35:42Z","pushed_at":"2018-02-02T15:15:47Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":76312,"stargazers_count":9676,"watchers_count":9676,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1338,"mirror_url":null,"archived":false,"open_issues_count":1471,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1338,"open_issues":1471,"watchers":9676,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"0b6000693a4095688b700914c6a316096a7ff5ca","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-02-02T14:35:42Z","pushed_at":"2018-02-02T15:15:47Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":76312,"stargazers_count":9676,"watchers_count":9676,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1338,"mirror_url":null,"archived":false,"open_issues_count":1471,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1338,"open_issues":1471,"watchers":9676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/22093"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/22093"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/22093/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22093/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/f3eb8c15f49201c1335937f8a5eed3e73a2f63bc"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taggon","id":212034,"avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"taggon"}}