{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/196902680","pull_request_review_id":130538494,"id":196902680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkwMjY4MA==","diff_hunk":"@@ -85,9 +89,16 @@\n   private QueryStreamWriter writer;\n   private ByteArrayOutputStream out;\n   private OutputNode.LimitHandler limitHandler;\n+  private ObjectMapper objectMapper;\n \n   @Before\n   public void setUp() {\n+\n+    objectMapper = new ObjectMapper();","path":"ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/resources/streaming/QueryStreamWriterTest.java","position":22,"original_position":22,"commit_id":"51a0cd3ffc60b0ae6dcb53f329e42037c24b33bb","original_commit_id":"51a0cd3ffc60b0ae6dcb53f329e42037c24b33bb","user":{"login":"big-andy-coates","id":8012398,"node_id":"MDQ6VXNlcjgwMTIzOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8012398?v=4","gravatar_id":"","url":"https://api.github.com/users/big-andy-coates","html_url":"https://github.com/big-andy-coates","followers_url":"https://api.github.com/users/big-andy-coates/followers","following_url":"https://api.github.com/users/big-andy-coates/following{/other_user}","gists_url":"https://api.github.com/users/big-andy-coates/gists{/gist_id}","starred_url":"https://api.github.com/users/big-andy-coates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-andy-coates/subscriptions","organizations_url":"https://api.github.com/users/big-andy-coates/orgs","repos_url":"https://api.github.com/users/big-andy-coates/repos","events_url":"https://api.github.com/users/big-andy-coates/events{/privacy}","received_events_url":"https://api.github.com/users/big-andy-coates/received_events","type":"User","site_admin":false},"body":"Another part that duplicates the initialization code. Also - objectMappers don't need creating each test.","created_at":"2018-06-20T18:45:58Z","updated_at":"2018-06-20T18:46:13Z","html_url":"https://github.com/confluentinc/ksql/pull/1453#discussion_r196902680","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1453","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/196902680"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1453#discussion_r196902680"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1453"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1453","id":195626773,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjI2Nzcz","html_url":"https://github.com/confluentinc/ksql/pull/1453","diff_url":"https://github.com/confluentinc/ksql/pull/1453.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1453.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1453","number":1453,"state":"open","locked":false,"title":"Struct end to end","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"### Description \r\nThis is the end-to-end struct feature. The PR includes two main commits:\r\n1. Struct rewrite where we rewrite the query to replace the dot notation with function calls\r\n2. Changes in code-gen and other parts to handle the rewritten query correctly.\r\n\r\nThis PR also includes `StructSerializationModule` which is used in serialization of struct fields for the REST API.\r\n\r\n### Testing done \r\nIncluded unit and integration tests.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-06-18T19:37:20Z","updated_at":"2018-06-20T18:46:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afa6bc522afe886a61db21089da2837374945ef5","assignee":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"assignees":[{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":450919827,"node_id":"MDU6TGFiZWw0NTA5MTk4Mjc=","url":"https://api.github.com/repos/confluentinc/ksql/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1453/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1453/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1453/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/51a0cd3ffc60b0ae6dcb53f329e42037c24b33bb","head":{"label":"hjafarpour:Struct-End-to-End","ref":"Struct-End-to-End","sha":"51a0cd3ffc60b0ae6dcb53f329e42037c24b33bb","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"repo":{"id":102027996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwMjc5OTY=","name":"ksql","full_name":"hjafarpour/ksql","owner":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjafarpour/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/hjafarpour/ksql","forks_url":"https://api.github.com/repos/hjafarpour/ksql/forks","keys_url":"https://api.github.com/repos/hjafarpour/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjafarpour/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjafarpour/ksql/teams","hooks_url":"https://api.github.com/repos/hjafarpour/ksql/hooks","issue_events_url":"https://api.github.com/repos/hjafarpour/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/hjafarpour/ksql/events","assignees_url":"https://api.github.com/repos/hjafarpour/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/hjafarpour/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/hjafarpour/ksql/tags","blobs_url":"https://api.github.com/repos/hjafarpour/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjafarpour/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjafarpour/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjafarpour/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjafarpour/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/hjafarpour/ksql/languages","stargazers_url":"https://api.github.com/repos/hjafarpour/ksql/stargazers","contributors_url":"https://api.github.com/repos/hjafarpour/ksql/contributors","subscribers_url":"https://api.github.com/repos/hjafarpour/ksql/subscribers","subscription_url":"https://api.github.com/repos/hjafarpour/ksql/subscription","commits_url":"https://api.github.com/repos/hjafarpour/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjafarpour/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjafarpour/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjafarpour/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjafarpour/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/hjafarpour/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjafarpour/ksql/merges","archive_url":"https://api.github.com/repos/hjafarpour/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjafarpour/ksql/downloads","issues_url":"https://api.github.com/repos/hjafarpour/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/hjafarpour/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/hjafarpour/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/hjafarpour/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjafarpour/ksql/labels{/name}","releases_url":"https://api.github.com/repos/hjafarpour/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/hjafarpour/ksql/deployments","created_at":"2017-08-31T17:43:25Z","updated_at":"2017-08-31T18:12:01Z","pushed_at":"2018-06-20T18:07:14Z","git_url":"git://github.com/hjafarpour/ksql.git","ssh_url":"git@github.com:hjafarpour/ksql.git","clone_url":"https://github.com/hjafarpour/ksql.git","svn_url":"https://github.com/hjafarpour/ksql","homepage":"","size":9144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:5.0.x","ref":"5.0.x","sha":"d86cea65b21783a560afd42667babdec1b357e2e","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-06-20T16:59:29Z","pushed_at":"2018-06-20T18:41:49Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":8128,"stargazers_count":1722,"watchers_count":1722,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":322,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":322,"open_issues":310,"watchers":1722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1453"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1453"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1453"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1453/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1453/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1453/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/51a0cd3ffc60b0ae6dcb53f329e42037c24b33bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"big-andy-coates"}}