{"action":"created","issue":{"url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1611","repository_url":"https://api.github.com/repos/getsentry/sentry-javascript","labels_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1611/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1611/comments","events_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1611/events","html_url":"https://github.com/getsentry/sentry-javascript/pull/1611","id":366280546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTkzNjA4","number":1611,"title":"feat: RewriteFrames pluggable integration for Node","user":{"login":"kamilogorek","id":1523305,"node_id":"MDQ6VXNlcjE1MjMzMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1523305?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilogorek","html_url":"https://github.com/kamilogorek","followers_url":"https://api.github.com/users/kamilogorek/followers","following_url":"https://api.github.com/users/kamilogorek/following{/other_user}","gists_url":"https://api.github.com/users/kamilogorek/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilogorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilogorek/subscriptions","organizations_url":"https://api.github.com/users/kamilogorek/orgs","repos_url":"https://api.github.com/users/kamilogorek/repos","events_url":"https://api.github.com/users/kamilogorek/events{/privacy}","received_events_url":"https://api.github.com/users/kamilogorek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-03T10:54:03Z","updated_at":"2018-10-03T11:48:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/getsentry/sentry-javascript/pulls/1611","html_url":"https://github.com/getsentry/sentry-javascript/pull/1611","diff_url":"https://github.com/getsentry/sentry-javascript/pull/1611.diff","patch_url":"https://github.com/getsentry/sentry-javascript/pull/1611.patch"},"body":"So that users don't have to write this nasty snippet anymore – https://docs.sentry.io/clients/node/sourcemaps/#updating-raven-configuration-to-support-source-maps\r\n\r\nConfigurable through:\r\n\r\n```js\r\ninit({\r\n  integrations: [new Sentry.Integrations.RewriteFrames({\r\n    iteratee(frame) {\r\n      // do whatever to frames. Integration extracts them and itterate over for you.\r\n    }\r\n  })]\r\n})\r\n```\r\n\r\nRef: https://github.com/getsentry/sentry/issues/2632#issuecomment-426213544"},"comment":{"url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/comments/426607634","html_url":"https://github.com/getsentry/sentry-javascript/pull/1611#issuecomment-426607634","issue_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1611","id":426607634,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjYwNzYzNA==","user":{"login":"sheerun","id":292365,"node_id":"MDQ6VXNlcjI5MjM2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/292365?v=4","gravatar_id":"","url":"https://api.github.com/users/sheerun","html_url":"https://github.com/sheerun","followers_url":"https://api.github.com/users/sheerun/followers","following_url":"https://api.github.com/users/sheerun/following{/other_user}","gists_url":"https://api.github.com/users/sheerun/gists{/gist_id}","starred_url":"https://api.github.com/users/sheerun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheerun/subscriptions","organizations_url":"https://api.github.com/users/sheerun/orgs","repos_url":"https://api.github.com/users/sheerun/repos","events_url":"https://api.github.com/users/sheerun/events{/privacy}","received_events_url":"https://api.github.com/users/sheerun/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T11:48:50Z","updated_at":"2018-10-03T11:48:50Z","author_association":"NONE","body":"I guess this method it's fine if RewriteFrames is not enabled by default. Maybe little verbose and requires to import path and still write a bunch of code when almost always you mean to rewrite all paths relative to some dir. Maybe something like this would be better:\r\n\r\n```javascript\r\ninit({\r\n  integrations: [new Sentry.Integrations.RewriteFrames({ root })]\r\n})\r\n```\r\n\r\n(of course iteratee could stay for advanced use cases)\r\n"}}
{"actor":{"display_login":"sheerun"}}