{"action":"created","comment":{"url":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments/181625294","pull_request_review_id":112282887,"id":181625294,"diff_hunk":"@@ -38,16 +35,58 @@ describe(`@sample/externals`, () => {\n     });\n \n     it(`should import '@angular/core'`, () => {\n-      expect(BUNDLE).to.contain(\"require('@angular/core')\")\n+      expect(BUNDLE).to.contain(\"require('@angular/core')\");\n+    });\n+\n+    it(`should import 'rxjs/Observable`, () => {\n+      expect(BUNDLE).to.contain(\"require('rxjs/Observable')\");\n+    });\n+\n+    it(`should not import 'lodash.template`, () => {\n+      expect(BUNDLE).to.not.contain(\"require('lodash.template')\");\n+    });\n+\n+    it(`should not import transitive dependency 'lodash.template`, () => {\n+      expect(BUNDLE).to.not.contain(\"require('lodash.templatesettings')\");\n     });\n \n-    it(`should embed 'createCommonjsModule' method`, () => {\n-      expect(BUNDLE).to.contain(\"function createCommonjsModule\")\n+    it(`should embed transitive 'templateSettings' object`, () => {\n+      expect(BUNDLE).to.contain('var templateSettings = {');\n     });\n \n-    it(`should embed 'fn.start' method`, () => {\n-      expect(BUNDLE).to.contain(\"n.start = function\")\n+    it(`should embed 'template' function`, () => {\n+      expect(BUNDLE).to.contain('template(string, options, guard)');\n     });\n   });\n+});\n \n+describe(`@sample/externals/testing`, () => {\n+  describe(`UMD Bundle`, () => {\n+    let BUNDLE;\n+    before(() => {\n+      BUNDLE = fs.readFileSync(path.resolve(__dirname, '../dist/bundles/sample-externals-testing.umd.js'), {\n+        encoding: 'utf-8'\n+      });\n+    });\n+\n+    it(`should import '@sample/externals'`, () => {\n+      expect(BUNDLE).to.contain(\"require('@sample/externals')\");\n+    });\n+\n+    it(`should not import 'lodash.template`, () => {\n+      expect(BUNDLE).to.not.contain(\"require('lodash.template')\");\n+    });\n+\n+    it(`should not import transitive dependency 'lodash.template`, () => {\n+      expect(BUNDLE).to.not.contain(\"require('lodash.templatesettings')\");\n+    });\n+\n+    it(`should embed transitive 'templateSettings' object`, () => {\n+      expect(BUNDLE).to.contain('var templateSettings = {');\n+    });\n+\n+    it(`should embed 'template' function`, () => {\n+      expect(BUNDLE).to.contain('template(string, options, guard)');\n+    });","path":"integration/samples/externals/specs/umd.ts","position":90,"original_position":90,"commit_id":"02cce7f26b3a497cd74da207a341f60547c21fe3","original_commit_id":"02cce7f26b3a497cd74da207a341f60547c21fe3","user":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"body":"Note: test specs for a bundled depency (prior \"embedded\")","created_at":"2018-04-16T05:31:34Z","updated_at":"2018-04-16T05:35:38Z","html_url":"https://github.com/dherges/ng-packagr/pull/738#discussion_r181625294","pull_request_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/738","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments/181625294"},"html":{"href":"https://github.com/dherges/ng-packagr/pull/738#discussion_r181625294"},"pull_request":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/738"}}},"pull_request":{"url":"https://api.github.com/repos/dherges/ng-packagr/pulls/738","id":178401830,"html_url":"https://github.com/dherges/ng-packagr/pull/738","diff_url":"https://github.com/dherges/ng-packagr/pull/738.diff","patch_url":"https://github.com/dherges/ng-packagr/pull/738.patch","issue_url":"https://api.github.com/repos/dherges/ng-packagr/issues/738","number":738,"state":"open","locked":false,"title":" feat: build libaries in Angular Package Format (APF) v6.0","user":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"body":"## I'm submitting a...\r\n\r\n```\r\n[ ] Bug Fix\r\n[x] Feature\r\n[ ] Other (Refactoring, Added tests, Documentation, ...)\r\n```\r\n\r\n## Checklist\r\n\r\n- [X] Commit Messages follow the [Conventional Commits](https://conventionalcommits.org/) pattern\r\n  - A feature commit message is prefixed \"feat:\"\r\n  - A bugfix commit message is prefixed \"fix:\"\r\n- [X] Tests for the changes have been added\r\n\r\n\r\n## Description\r\nThis commits brings `Angular Package Format` V6 in `ng-packagr`\r\n\r\nIn a nutshell these are the changes:\r\n- Remove the working directory\r\n- Ship `ESM5`, `ESM2015` modules\r\n- Remove most of `rollup` plugins\r\n- Remapping of `sourcemaps` is not a seperate transformation step\r\n- `tgz` file is created only once and not per entrypoint\r\n\r\nBREAKING CHANGES:\r\nThere were some important changes, mainly related to `rollup`, most of the options and functionality provided by `rollup` plugins have been removed, due to the fact this is not inline with `APF V6` as one will end up with different outputs in different modules.\r\n\r\n- `comments`  option from configuration has been removed\r\n- `licensePath` option from configuration has been removed\r\n- `embedded` was dropped as it increased the chance of having 2 copies of the same library. Only with Angular Package Format 6. This only worked with `UMD` bundles\r\n\r\nMore info: https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview\r\n\r\nCloses: #705\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n```\r\n[X] Yes\r\n[ ] No\r\n```\r\n","created_at":"2018-03-29T18:10:07Z","updated_at":"2018-04-16T05:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3acc12506c454ad5c3a4c89824caedb98cb6ddbc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/738/commits","review_comments_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/738/comments","review_comment_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/issues/738/comments","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/02cce7f26b3a497cd74da207a341f60547c21fe3","head":{"label":"alan-agius4:feature/apf-v6","ref":"feature/apf-v6","sha":"02cce7f26b3a497cd74da207a341f60547c21fe3","user":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"repo":{"id":112093113,"name":"ng-packagr","full_name":"alan-agius4/ng-packagr","owner":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alan-agius4/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":true,"url":"https://api.github.com/repos/alan-agius4/ng-packagr","forks_url":"https://api.github.com/repos/alan-agius4/ng-packagr/forks","keys_url":"https://api.github.com/repos/alan-agius4/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alan-agius4/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alan-agius4/ng-packagr/teams","hooks_url":"https://api.github.com/repos/alan-agius4/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/alan-agius4/ng-packagr/events","assignees_url":"https://api.github.com/repos/alan-agius4/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/alan-agius4/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/alan-agius4/ng-packagr/tags","blobs_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alan-agius4/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/alan-agius4/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/alan-agius4/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/alan-agius4/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/alan-agius4/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/alan-agius4/ng-packagr/subscription","commits_url":"https://api.github.com/repos/alan-agius4/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/alan-agius4/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/alan-agius4/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/alan-agius4/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alan-agius4/ng-packagr/merges","archive_url":"https://api.github.com/repos/alan-agius4/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alan-agius4/ng-packagr/downloads","issues_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/alan-agius4/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/alan-agius4/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/alan-agius4/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alan-agius4/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/alan-agius4/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/alan-agius4/ng-packagr/deployments","created_at":"2017-11-26T15:16:43Z","updated_at":"2018-03-25T10:54:26Z","pushed_at":"2018-04-10T11:50:24Z","git_url":"git://github.com/alan-agius4/ng-packagr.git","ssh_url":"git@github.com:alan-agius4/ng-packagr.git","clone_url":"https://github.com/alan-agius4/ng-packagr.git","svn_url":"https://github.com/alan-agius4/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":10339,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dherges:master","ref":"master","sha":"a60bd8810de5a08b17f57cae4096c077312d93c0","user":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"repo":{"id":91553810,"name":"ng-packagr","full_name":"dherges/ng-packagr","owner":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dherges/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":false,"url":"https://api.github.com/repos/dherges/ng-packagr","forks_url":"https://api.github.com/repos/dherges/ng-packagr/forks","keys_url":"https://api.github.com/repos/dherges/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dherges/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dherges/ng-packagr/teams","hooks_url":"https://api.github.com/repos/dherges/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/dherges/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/dherges/ng-packagr/events","assignees_url":"https://api.github.com/repos/dherges/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/dherges/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/dherges/ng-packagr/tags","blobs_url":"https://api.github.com/repos/dherges/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dherges/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dherges/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dherges/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/dherges/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/dherges/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/dherges/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/dherges/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/dherges/ng-packagr/subscription","commits_url":"https://api.github.com/repos/dherges/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dherges/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dherges/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dherges/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/dherges/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dherges/ng-packagr/merges","archive_url":"https://api.github.com/repos/dherges/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dherges/ng-packagr/downloads","issues_url":"https://api.github.com/repos/dherges/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/dherges/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/dherges/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/dherges/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dherges/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/dherges/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/dherges/ng-packagr/deployments","created_at":"2017-05-17T08:43:27Z","updated_at":"2018-04-15T20:55:19Z","pushed_at":"2018-04-10T11:50:44Z","git_url":"git://github.com/dherges/ng-packagr.git","ssh_url":"git@github.com:dherges/ng-packagr.git","clone_url":"https://github.com/dherges/ng-packagr.git","svn_url":"https://github.com/dherges/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":10571,"stargazers_count":801,"watchers_count":801,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":108,"open_issues":120,"watchers":801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/738"},"html":{"href":"https://github.com/dherges/ng-packagr/pull/738"},"issue":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/738"},"comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/738/comments"},"review_comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/738/comments"},"review_comment":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/738/commits"},"statuses":{"href":"https://api.github.com/repos/dherges/ng-packagr/statuses/02cce7f26b3a497cd74da207a341f60547c21fe3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dherges"}}