{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/212889310","pull_request_review_id":149608632,"id":212889310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjg4OTMxMA==","diff_hunk":"@@ -13,12 +13,12 @@\n       name: ansible_service_broker\n       tasks_from: install.yml\n     when:\n-    - openshift_enable_service_catalog | default(true) | bool\n+    - openshift_enable_ansible_service_broker | default(true) | bool\n   - import_role:\n       name: template_service_broker\n       tasks_from: upgrade.yml\n     when:\n-    - openshift_enable_service_catalog | default(true) | bool\n+    - openshift_enable_template_service_broker | default(true) | bool","path":"playbooks/common/openshift-cluster/upgrades/upgrade_components.yml","position":11,"original_position":11,"commit_id":"d99d689650d181acb07bf3b397b3873ec838a64a","original_commit_id":"d99d689650d181acb07bf3b397b3873ec838a64a","user":{"login":"vrutkovs","id":114501,"node_id":"MDQ6VXNlcjExNDUwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/114501?v=4","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"body":"Correct var is `template_service_broker_install`","created_at":"2018-08-27T07:36:20Z","updated_at":"2018-08-27T07:36:21Z","html_url":"https://github.com/openshift/openshift-ansible/pull/9770#discussion_r212889310","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/212889310"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9770#discussion_r212889310"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770","id":211027240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDI3MjQw","html_url":"https://github.com/openshift/openshift-ansible/pull/9770","diff_url":"https://github.com/openshift/openshift-ansible/pull/9770.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/9770.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9770","number":9770,"state":"open","locked":false,"title":"Fix Upgrade of Components during OpenShift Upgrade","user":{"login":"VincentS","id":998872,"node_id":"MDQ6VXNlcjk5ODg3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/998872?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentS","html_url":"https://github.com/VincentS","followers_url":"https://api.github.com/users/VincentS/followers","following_url":"https://api.github.com/users/VincentS/following{/other_user}","gists_url":"https://api.github.com/users/VincentS/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentS/subscriptions","organizations_url":"https://api.github.com/users/VincentS/orgs","repos_url":"https://api.github.com/users/VincentS/repos","events_url":"https://api.github.com/users/VincentS/events{/privacy}","received_events_url":"https://api.github.com/users/VincentS/received_events","type":"User","site_admin":false},"body":"Currently OpenShift Upgrades from 3.7 to 3.x fail when the Template Service Broker or Ansible Service Broker werent installed in the initial setup caused by a wrong check in the OpenShift Upgrade Playbook. \r\n\r\nThis PR replaces the wrong variables that were checked.\r\n\r\n@vrutkovs @sdodson \r\n","created_at":"2018-08-27T07:26:21Z","updated_at":"2018-08-27T07:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23d9c1e0febf944c8998d1cb26aa862de137e23f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdodson","id":48161,"node_id":"MDQ6VXNlcjQ4MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},{"login":"mtnbikenc","id":7808636,"node_id":"MDQ6VXNlcjc4MDg2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7808636?v=4","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":696742997,"node_id":"MDU6TGFiZWw2OTY3NDI5OTc=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":681664198,"node_id":"MDU6TGFiZWw2ODE2NjQxOTg=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9770/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d99d689650d181acb07bf3b397b3873ec838a64a","head":{"label":"VincentS:upgrade_config_fix","ref":"upgrade_config_fix","sha":"d99d689650d181acb07bf3b397b3873ec838a64a","user":{"login":"VincentS","id":998872,"node_id":"MDQ6VXNlcjk5ODg3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/998872?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentS","html_url":"https://github.com/VincentS","followers_url":"https://api.github.com/users/VincentS/followers","following_url":"https://api.github.com/users/VincentS/following{/other_user}","gists_url":"https://api.github.com/users/VincentS/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentS/subscriptions","organizations_url":"https://api.github.com/users/VincentS/orgs","repos_url":"https://api.github.com/users/VincentS/repos","events_url":"https://api.github.com/users/VincentS/events{/privacy}","received_events_url":"https://api.github.com/users/VincentS/received_events","type":"User","site_admin":false},"repo":{"id":90031704,"node_id":"MDEwOlJlcG9zaXRvcnk5MDAzMTcwNA==","name":"openshift-ansible","full_name":"VincentS/openshift-ansible","owner":{"login":"VincentS","id":998872,"node_id":"MDQ6VXNlcjk5ODg3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/998872?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentS","html_url":"https://github.com/VincentS","followers_url":"https://api.github.com/users/VincentS/followers","following_url":"https://api.github.com/users/VincentS/following{/other_user}","gists_url":"https://api.github.com/users/VincentS/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentS/subscriptions","organizations_url":"https://api.github.com/users/VincentS/orgs","repos_url":"https://api.github.com/users/VincentS/repos","events_url":"https://api.github.com/users/VincentS/events{/privacy}","received_events_url":"https://api.github.com/users/VincentS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VincentS/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":true,"url":"https://api.github.com/repos/VincentS/openshift-ansible","forks_url":"https://api.github.com/repos/VincentS/openshift-ansible/forks","keys_url":"https://api.github.com/repos/VincentS/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VincentS/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VincentS/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/VincentS/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/VincentS/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/VincentS/openshift-ansible/events","assignees_url":"https://api.github.com/repos/VincentS/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/VincentS/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/VincentS/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/VincentS/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VincentS/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VincentS/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/VincentS/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VincentS/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/VincentS/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/VincentS/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/VincentS/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/VincentS/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/VincentS/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/VincentS/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/VincentS/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/VincentS/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/VincentS/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/VincentS/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/VincentS/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VincentS/openshift-ansible/merges","archive_url":"https://api.github.com/repos/VincentS/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VincentS/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/VincentS/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/VincentS/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/VincentS/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/VincentS/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VincentS/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/VincentS/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/VincentS/openshift-ansible/deployments","created_at":"2017-05-02T12:36:51Z","updated_at":"2018-08-24T22:42:24Z","pushed_at":"2018-08-27T07:19:14Z","git_url":"git://github.com/VincentS/openshift-ansible.git","ssh_url":"git@github.com:VincentS/openshift-ansible.git","clone_url":"https://github.com/VincentS/openshift-ansible.git","svn_url":"https://github.com/VincentS/openshift-ansible","homepage":"https://install.openshift.com","size":32069,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"537573eeff745c725bbea5b7ea0cbfd545914a90","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwOTE5OQ==","name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2018-08-27T02:43:20Z","pushed_at":"2018-08-27T07:26:22Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":32139,"stargazers_count":1134,"watchers_count":1134,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1555,"mirror_url":null,"archived":false,"open_issues_count":1021,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1555,"open_issues":1021,"watchers":1134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9770"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9770"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9770/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9770/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d99d689650d181acb07bf3b397b3873ec838a64a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vrutkovs"}}