{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24893","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24893/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24893/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24893/events","html_url":"https://github.com/nodejs/node/pull/24893","id":388669213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODc5MTkw","number":24893,"title":"doc: simplify author ready","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-07T14:08:27Z","updated_at":"2018-12-13T19:12:08Z","closed_at":"2018-12-10T04:03:38Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24893","html_url":"https://github.com/nodejs/node/pull/24893","diff_url":"https://github.com/nodejs/node/pull/24893.diff","patch_url":"https://github.com/nodejs/node/pull/24893.patch"},"body":"The label should be applied early on. Otherwise there is little\r\nbenefit using this label at all.\r\n\r\nThe change to require two LGs does not imply that this is also required\r\nfor the `author ready` label.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/447085317","html_url":"https://github.com/nodejs/node/pull/24893#issuecomment-447085317","issue_url":"https://api.github.com/repos/nodejs/node/issues/24893","id":447085317,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA4NTMxNw==","user":{"login":"joyeecheung","id":4299420,"node_id":"MDQ6VXNlcjQyOTk0MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T19:12:08Z","updated_at":"2018-12-13T19:12:08Z","author_association":"MEMBER","body":"> The author bit was added after the label was created, since it confused some people; it is supposed to say that there are no more tasks left for the author of the PR (unless maybe they are also a collaborator).\r\n\r\nThe current description of the label does not seem to map to this accurately. If during the 7 day wait, another collaborator comes in and requested changes, then there are still tasks left for the author of the PR - to resolve the requested changes, in one way or another. And if the PR is semver-major,  at least two TSC approvals are needed, in the worst case, a vote may be called and the decision may be against the current approach in the PR so the author may still need to update it if they still plan to pursue it, or they may have to close it."}}
{"actor":{"display_login":"joyeecheung"}}