{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/194806374","pull_request_review_id":128047674,"id":194806374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgwNjM3NA==","diff_hunk":"@@ -61,19 +57,15 @@ public void onDisconnect(InternalDistributedSystem sys) {\n   public void serverRestartsAfterLocatorReconnects() throws Exception {\n     IgnoredException.addIgnoredException(\"org.apache.geode.ForcedDisconnectException: for testing\");\n \n-    Properties props = new Properties();\n-    props.setProperty(ConfigurationProperties.MAX_WAIT_TIME_RECONNECT, \"5000\");\n-    MemberVM locator0 = rule.startLocatorVM(0, props);\n+    MemberVM locator0 = rule.startLocatorVM(0);\n \n-    rule.startServerVM(1, props, locator0.getPort());\n-    MemberVM server2 = rule.startServerVM(2, props, locator0.getPort());\n+    rule.startServerVM(1, locator0.getPort());\n+    MemberVM server2 = rule.startServerVM(2, locator0.getPort());\n \n     addDisconnectListener(locator0);\n \n-    server2.invokeAsync(() -> MembershipManagerHelper\n-        .crashDistributedSystem(InternalDistributedSystem.getConnectedInstance()));\n-    locator0.invokeAsync(() -> MembershipManagerHelper\n-        .crashDistributedSystem(InternalDistributedSystem.getConnectedInstance()));\n+    server2.disConnectMember();","path":"geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigLocatorRestartDUnitTest.java","position":40,"original_position":40,"commit_id":"d5ff31efb80c7e835d231e5de6be4e5c4a1d7dfe","original_commit_id":"d5ff31efb80c7e835d231e5de6be4e5c4a1d7dfe","user":{"login":"balesh2","id":7718000,"node_id":"MDQ6VXNlcjc3MTgwMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7718000?v=4","gravatar_id":"","url":"https://api.github.com/users/balesh2","html_url":"https://github.com/balesh2","followers_url":"https://api.github.com/users/balesh2/followers","following_url":"https://api.github.com/users/balesh2/following{/other_user}","gists_url":"https://api.github.com/users/balesh2/gists{/gist_id}","starred_url":"https://api.github.com/users/balesh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balesh2/subscriptions","organizations_url":"https://api.github.com/users/balesh2/orgs","repos_url":"https://api.github.com/users/balesh2/repos","events_url":"https://api.github.com/users/balesh2/events{/privacy}","received_events_url":"https://api.github.com/users/balesh2/received_events","type":"User","site_admin":false},"body":"This disconnect doesn't crash it though, the server is still able to reconnect. Would `forceDisconnect` be better?","created_at":"2018-06-12T16:29:32Z","updated_at":"2018-06-12T16:29:32Z","html_url":"https://github.com/apache/geode/pull/2048#discussion_r194806374","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/2048","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/194806374"},"html":{"href":"https://github.com/apache/geode/pull/2048#discussion_r194806374"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/2048"}},"in_reply_to_id":194777788},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2048","id":194104255,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTA0MjU1","html_url":"https://github.com/apache/geode/pull/2048","diff_url":"https://github.com/apache/geode/pull/2048.diff","patch_url":"https://github.com/apache/geode/pull/2048.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2048","number":2048,"state":"open","locked":false,"title":"GEODE-5306: add crashVM and disconnectMember in ClusterStartupRule","user":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"body":"Co-authored-by: Helena Bales <hbales@pivotal.io>\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n- [ ] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2018-06-11T21:09:38Z","updated_at":"2018-06-12T16:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8bdd8f16658dc485bad60beaec053fdcd364e9b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jdeppe-pivotal","id":5313410,"node_id":"MDQ6VXNlcjUzMTM0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5313410?v=4","gravatar_id":"","url":"https://api.github.com/users/jdeppe-pivotal","html_url":"https://github.com/jdeppe-pivotal","followers_url":"https://api.github.com/users/jdeppe-pivotal/followers","following_url":"https://api.github.com/users/jdeppe-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/jdeppe-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/jdeppe-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdeppe-pivotal/subscriptions","organizations_url":"https://api.github.com/users/jdeppe-pivotal/orgs","repos_url":"https://api.github.com/users/jdeppe-pivotal/repos","events_url":"https://api.github.com/users/jdeppe-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/jdeppe-pivotal/received_events","type":"User","site_admin":false},{"login":"sboorlagadda","id":7171016,"node_id":"MDQ6VXNlcjcxNzEwMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/7171016?v=4","gravatar_id":"","url":"https://api.github.com/users/sboorlagadda","html_url":"https://github.com/sboorlagadda","followers_url":"https://api.github.com/users/sboorlagadda/followers","following_url":"https://api.github.com/users/sboorlagadda/following{/other_user}","gists_url":"https://api.github.com/users/sboorlagadda/gists{/gist_id}","starred_url":"https://api.github.com/users/sboorlagadda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboorlagadda/subscriptions","organizations_url":"https://api.github.com/users/sboorlagadda/orgs","repos_url":"https://api.github.com/users/sboorlagadda/repos","events_url":"https://api.github.com/users/sboorlagadda/events{/privacy}","received_events_url":"https://api.github.com/users/sboorlagadda/received_events","type":"User","site_admin":false},{"login":"PurelyApplied","id":7175687,"node_id":"MDQ6VXNlcjcxNzU2ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},{"login":"pdxrunner","id":16668768,"node_id":"MDQ6VXNlcjE2NjY4NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/16668768?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxrunner","html_url":"https://github.com/pdxrunner","followers_url":"https://api.github.com/users/pdxrunner/followers","following_url":"https://api.github.com/users/pdxrunner/following{/other_user}","gists_url":"https://api.github.com/users/pdxrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxrunner/subscriptions","organizations_url":"https://api.github.com/users/pdxrunner/orgs","repos_url":"https://api.github.com/users/pdxrunner/repos","events_url":"https://api.github.com/users/pdxrunner/events{/privacy}","received_events_url":"https://api.github.com/users/pdxrunner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2048/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2048/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2048/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/d5ff31efb80c7e835d231e5de6be4e5c4a1d7dfe","head":{"label":"jinmeiliao:rules","ref":"rules","sha":"d5ff31efb80c7e835d231e5de6be4e5c4a1d7dfe","user":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"repo":{"id":45697400,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY5NzQwMA==","name":"geode","full_name":"jinmeiliao/geode","owner":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jinmeiliao/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/jinmeiliao/geode","forks_url":"https://api.github.com/repos/jinmeiliao/geode/forks","keys_url":"https://api.github.com/repos/jinmeiliao/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jinmeiliao/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jinmeiliao/geode/teams","hooks_url":"https://api.github.com/repos/jinmeiliao/geode/hooks","issue_events_url":"https://api.github.com/repos/jinmeiliao/geode/issues/events{/number}","events_url":"https://api.github.com/repos/jinmeiliao/geode/events","assignees_url":"https://api.github.com/repos/jinmeiliao/geode/assignees{/user}","branches_url":"https://api.github.com/repos/jinmeiliao/geode/branches{/branch}","tags_url":"https://api.github.com/repos/jinmeiliao/geode/tags","blobs_url":"https://api.github.com/repos/jinmeiliao/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jinmeiliao/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jinmeiliao/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jinmeiliao/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jinmeiliao/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/jinmeiliao/geode/languages","stargazers_url":"https://api.github.com/repos/jinmeiliao/geode/stargazers","contributors_url":"https://api.github.com/repos/jinmeiliao/geode/contributors","subscribers_url":"https://api.github.com/repos/jinmeiliao/geode/subscribers","subscription_url":"https://api.github.com/repos/jinmeiliao/geode/subscription","commits_url":"https://api.github.com/repos/jinmeiliao/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jinmeiliao/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jinmeiliao/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jinmeiliao/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jinmeiliao/geode/contents/{+path}","compare_url":"https://api.github.com/repos/jinmeiliao/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jinmeiliao/geode/merges","archive_url":"https://api.github.com/repos/jinmeiliao/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jinmeiliao/geode/downloads","issues_url":"https://api.github.com/repos/jinmeiliao/geode/issues{/number}","pulls_url":"https://api.github.com/repos/jinmeiliao/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/jinmeiliao/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/jinmeiliao/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jinmeiliao/geode/labels{/name}","releases_url":"https://api.github.com/repos/jinmeiliao/geode/releases{/id}","deployments_url":"https://api.github.com/repos/jinmeiliao/geode/deployments","created_at":"2015-11-06T17:43:16Z","updated_at":"2016-12-06T16:17:21Z","pushed_at":"2018-06-11T21:08:21Z","git_url":"git://github.com/jinmeiliao/geode.git","ssh_url":"git@github.com:jinmeiliao/geode.git","clone_url":"https://github.com/jinmeiliao/geode.git","svn_url":"https://github.com/jinmeiliao/geode","homepage":"","size":128233,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"3ed33a162a11f7f2600f97db4983e820929dd9f3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-06-12T07:04:01Z","pushed_at":"2018-06-12T00:05:04Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":153161,"stargazers_count":1267,"watchers_count":1267,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":444,"open_issues":23,"watchers":1267,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2048"},"html":{"href":"https://github.com/apache/geode/pull/2048"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2048"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2048/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2048/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2048/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/d5ff31efb80c7e835d231e5de6be4e5c4a1d7dfe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"balesh2"}}