{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/235176308","pull_request_review_id":176983604,"id":235176308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE3NjMwOA==","diff_hunk":"@@ -1349,60 +1349,63 @@ cc_library(\n     name = \"all_kernels_statically_linked\",\n     visibility = [\"//visibility:private\"],\n     deps = [\n-        \"//tensorflow/core/kernels:array\",\n-        \"//tensorflow/core/kernels:audio\",\n-        \"//tensorflow/core/kernels:batch_kernels\",\n-        \"//tensorflow/core/kernels:bincount_op\",\n-        \"//tensorflow/core/kernels:boosted_trees_ops\",\n-        \"//tensorflow/core/kernels:candidate_sampler_ops\",\n-        \"//tensorflow/core/kernels:checkpoint_ops\",\n-        \"//tensorflow/core/kernels:collective_ops\",\n-        \"//tensorflow/core/kernels:control_flow_ops\",\n-        \"//tensorflow/core/kernels:ctc_ops\",\n-        \"//tensorflow/core/kernels:cudnn_rnn_kernels\",\n-        \"//tensorflow/core/kernels:data_flow\",\n-        \"//tensorflow/core/kernels:dataset_ops\",\n-        \"//tensorflow/core/kernels:decode_proto_op\",\n-        \"//tensorflow/core/kernels:encode_proto_op\",\n-        \"//tensorflow/core/kernels:fake_quant_ops\",\n-        \"//tensorflow/core/kernels:function_ops\",\n-        \"//tensorflow/core/kernels:functional_ops\",\n-        \"//tensorflow/core/kernels:grappler\",\n-        \"//tensorflow/core/kernels:histogram_op\",\n-        \"//tensorflow/core/kernels:image\",\n-        \"//tensorflow/core/kernels:io\",\n-        \"//tensorflow/core/kernels:linalg\",\n-        \"//tensorflow/core/kernels:list_kernels\",\n-        \"//tensorflow/core/kernels:lookup\",\n-        \"//tensorflow/core/kernels:logging\",\n-        \"//tensorflow/core/kernels:manip\",\n-        \"//tensorflow/core/kernels:math\",\n-        \"//tensorflow/core/kernels:multinomial_op\",\n-        \"//tensorflow/core/kernels:nn\",\n-        \"//tensorflow/core/kernels:parameterized_truncated_normal_op\",\n-        \"//tensorflow/core/kernels:parsing\",\n-        \"//tensorflow/core/kernels:partitioned_function_ops\",\n-        \"//tensorflow/core/kernels:ragged_ops\",\n-        \"//tensorflow/core/kernels:random_ops\",\n-        \"//tensorflow/core/kernels:random_poisson_op\",\n-        \"//tensorflow/core/kernels:remote_fused_graph_ops\",\n-        \"//tensorflow/core/kernels:required\",\n-        \"//tensorflow/core/kernels:resource_variable_ops\",\n-        \"//tensorflow/core/kernels:rpc_op\",\n-        \"//tensorflow/core/kernels:scoped_allocator_ops\",\n-        \"//tensorflow/core/kernels:sdca_ops\",\n-        \"//tensorflow/core/kernels:searchsorted_op\",\n-        \"//tensorflow/core/kernels:set_kernels\",\n-        \"//tensorflow/core/kernels:sparse\",\n-        \"//tensorflow/core/kernels:state\",\n-        \"//tensorflow/core/kernels:stateless_random_ops\",\n-        \"//tensorflow/core/kernels:string\",\n-        \"//tensorflow/core/kernels:summary_kernels\",\n-        \"//tensorflow/core/kernels:training_ops\",\n-        \"//tensorflow/core/kernels:word2vec_kernels\",\n-    ] + tf_additional_cloud_kernel_deps() + if_not_tx2_llvm_or_windows_cuda([\n-        \"//tensorflow/core/kernels:nccl_kernels\",\n-    ]) + if_not_windows([\n+               \"//tensorflow/core/kernels:array\",","path":"tensorflow/core/BUILD","position":58,"original_position":58,"commit_id":"6ee836b86245a8dc989a7e66bd39a96b2d5b26e4","original_commit_id":"b51ad2408b5050ee497a3af602d4bbd950f89973","user":{"login":"gunan","id":7946809,"node_id":"MDQ6VXNlcjc5NDY4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7946809?v=4","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"body":"Let's revert these lines. @yifeif to check why buildifier modified these lines, but nothing else (in case she knows anything about this)","created_at":"2018-11-20T21:31:40Z","updated_at":"2018-11-20T21:31:40Z","html_url":"https://github.com/tensorflow/tensorflow/pull/23808#discussion_r235176308","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/235176308"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/23808#discussion_r235176308"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808"}},"in_reply_to_id":234389341},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808","id":231676239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjc2MjM5","html_url":"https://github.com/tensorflow/tensorflow/pull/23808","diff_url":"https://github.com/tensorflow/tensorflow/pull/23808.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/23808.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/23808","number":23808,"state":"open","locked":false,"title":"Add option to disable nccl","user":{"login":"samikama","id":10539540,"node_id":"MDQ6VXNlcjEwNTM5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/10539540?v=4","gravatar_id":"","url":"https://api.github.com/users/samikama","html_url":"https://github.com/samikama","followers_url":"https://api.github.com/users/samikama/followers","following_url":"https://api.github.com/users/samikama/following{/other_user}","gists_url":"https://api.github.com/users/samikama/gists{/gist_id}","starred_url":"https://api.github.com/users/samikama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samikama/subscriptions","organizations_url":"https://api.github.com/users/samikama/orgs","repos_url":"https://api.github.com/users/samikama/repos","events_url":"https://api.github.com/users/samikama/events{/privacy}","received_events_url":"https://api.github.com/users/samikama/received_events","type":"User","site_admin":false},"body":"In platforms like embedded systems, nccl is not supported and doesn't make sense. This PR adds a bazel config flag to disable nccl portions of TF for such platforms.","created_at":"2018-11-16T22:45:12Z","updated_at":"2018-11-20T21:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b8c6e818440e9f0915599fd38d1e9cadc3568d1","assignee":{"login":"wt-huang","id":42785337,"node_id":"MDQ6VXNlcjQyNzg1MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/42785337?v=4","gravatar_id":"","url":"https://api.github.com/users/wt-huang","html_url":"https://github.com/wt-huang","followers_url":"https://api.github.com/users/wt-huang/followers","following_url":"https://api.github.com/users/wt-huang/following{/other_user}","gists_url":"https://api.github.com/users/wt-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/wt-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wt-huang/subscriptions","organizations_url":"https://api.github.com/users/wt-huang/orgs","repos_url":"https://api.github.com/users/wt-huang/repos","events_url":"https://api.github.com/users/wt-huang/events{/privacy}","received_events_url":"https://api.github.com/users/wt-huang/received_events","type":"User","site_admin":false},"assignees":[{"login":"wt-huang","id":42785337,"node_id":"MDQ6VXNlcjQyNzg1MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/42785337?v=4","gravatar_id":"","url":"https://api.github.com/users/wt-huang","html_url":"https://github.com/wt-huang","followers_url":"https://api.github.com/users/wt-huang/followers","following_url":"https://api.github.com/users/wt-huang/following{/other_user}","gists_url":"https://api.github.com/users/wt-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/wt-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wt-huang/subscriptions","organizations_url":"https://api.github.com/users/wt-huang/orgs","repos_url":"https://api.github.com/users/wt-huang/repos","events_url":"https://api.github.com/users/wt-huang/events{/privacy}","received_events_url":"https://api.github.com/users/wt-huang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/23808/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/6ee836b86245a8dc989a7e66bd39a96b2d5b26e4","head":{"label":"samikama:optional_nccl","ref":"optional_nccl","sha":"6ee836b86245a8dc989a7e66bd39a96b2d5b26e4","user":{"login":"samikama","id":10539540,"node_id":"MDQ6VXNlcjEwNTM5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/10539540?v=4","gravatar_id":"","url":"https://api.github.com/users/samikama","html_url":"https://github.com/samikama","followers_url":"https://api.github.com/users/samikama/followers","following_url":"https://api.github.com/users/samikama/following{/other_user}","gists_url":"https://api.github.com/users/samikama/gists{/gist_id}","starred_url":"https://api.github.com/users/samikama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samikama/subscriptions","organizations_url":"https://api.github.com/users/samikama/orgs","repos_url":"https://api.github.com/users/samikama/repos","events_url":"https://api.github.com/users/samikama/events{/privacy}","received_events_url":"https://api.github.com/users/samikama/received_events","type":"User","site_admin":false},"repo":{"id":56879599,"node_id":"MDEwOlJlcG9zaXRvcnk1Njg3OTU5OQ==","name":"tensorflow","full_name":"samikama/tensorflow","private":false,"owner":{"login":"samikama","id":10539540,"node_id":"MDQ6VXNlcjEwNTM5NTQw","avatar_url":"https://avatars0.githubusercontent.com/u/10539540?v=4","gravatar_id":"","url":"https://api.github.com/users/samikama","html_url":"https://github.com/samikama","followers_url":"https://api.github.com/users/samikama/followers","following_url":"https://api.github.com/users/samikama/following{/other_user}","gists_url":"https://api.github.com/users/samikama/gists{/gist_id}","starred_url":"https://api.github.com/users/samikama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samikama/subscriptions","organizations_url":"https://api.github.com/users/samikama/orgs","repos_url":"https://api.github.com/users/samikama/repos","events_url":"https://api.github.com/users/samikama/events{/privacy}","received_events_url":"https://api.github.com/users/samikama/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samikama/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/samikama/tensorflow","forks_url":"https://api.github.com/repos/samikama/tensorflow/forks","keys_url":"https://api.github.com/repos/samikama/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samikama/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samikama/tensorflow/teams","hooks_url":"https://api.github.com/repos/samikama/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/samikama/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/samikama/tensorflow/events","assignees_url":"https://api.github.com/repos/samikama/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/samikama/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/samikama/tensorflow/tags","blobs_url":"https://api.github.com/repos/samikama/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samikama/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samikama/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/samikama/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samikama/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/samikama/tensorflow/languages","stargazers_url":"https://api.github.com/repos/samikama/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/samikama/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/samikama/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/samikama/tensorflow/subscription","commits_url":"https://api.github.com/repos/samikama/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/samikama/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/samikama/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/samikama/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/samikama/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/samikama/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samikama/tensorflow/merges","archive_url":"https://api.github.com/repos/samikama/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samikama/tensorflow/downloads","issues_url":"https://api.github.com/repos/samikama/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/samikama/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/samikama/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/samikama/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samikama/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/samikama/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/samikama/tensorflow/deployments","created_at":"2016-04-22T19:17:04Z","updated_at":"2018-11-15T23:55:51Z","pushed_at":"2018-11-19T17:55:45Z","git_url":"git://github.com/samikama/tensorflow.git","ssh_url":"git@github.com:samikama/tensorflow.git","clone_url":"https://github.com/samikama/tensorflow.git","svn_url":"https://github.com/samikama/tensorflow","homepage":"http://tensorflow.org","size":278933,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"4bb3a95413b94791e4ee3ba8fd40d7a11b9824b1","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/tensorflow","description":"An Open Source Machine Learning Framework for Everyone","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-11-20T21:30:04Z","pushed_at":"2018-11-20T21:24:38Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":282298,"stargazers_count":114839,"watchers_count":114839,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69753,"mirror_url":null,"archived":false,"open_issues_count":1748,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69753,"open_issues":1748,"watchers":114839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/23808"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/23808"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/23808/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/23808/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/6ee836b86245a8dc989a7e66bd39a96b2d5b26e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gunan"}}