{"action":"created","comment":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments/214547255","pull_request_review_id":151627172,"id":214547255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDU0NzI1NQ==","diff_hunk":"@@ -0,0 +1,93 @@\n+$env:BOARD_NAME= 'ESP32_DEVKITC'","path":"install-tools.ps1","position":1,"original_position":1,"commit_id":"d4946e5264c6f82953aa8a9863363199e56361a3","original_commit_id":"d4946e5264c6f82953aa8a9863363199e56361a3","user":{"login":"josesimoes","id":1881520,"node_id":"MDQ6VXNlcjE4ODE1MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1881520?v=4","gravatar_id":"","url":"https://api.github.com/users/josesimoes","html_url":"https://github.com/josesimoes","followers_url":"https://api.github.com/users/josesimoes/followers","following_url":"https://api.github.com/users/josesimoes/following{/other_user}","gists_url":"https://api.github.com/users/josesimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/josesimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josesimoes/subscriptions","organizations_url":"https://api.github.com/users/josesimoes/orgs","repos_url":"https://api.github.com/users/josesimoes/repos","events_url":"https://api.github.com/users/josesimoes/events{/privacy}","received_events_url":"https://api.github.com/users/josesimoes/received_events","type":"User","site_admin":false},"body":"This should have esp32 on the make to make it absolutely clear that is meant specificaly for that target chip","created_at":"2018-09-02T17:01:35Z","updated_at":"2018-09-02T17:09:19Z","html_url":"https://github.com/nanoframework/nf-interpreter/pull/835#discussion_r214547255","pull_request_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments/214547255"},"html":{"href":"https://github.com/nanoframework/nf-interpreter/pull/835#discussion_r214547255"},"pull_request":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835"}}},"pull_request":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835","id":212600953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjAwOTUz","html_url":"https://github.com/nanoframework/nf-interpreter/pull/835","diff_url":"https://github.com/nanoframework/nf-interpreter/pull/835.diff","patch_url":"https://github.com/nanoframework/nf-interpreter/pull/835.patch","issue_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/835","number":835,"state":"open","locked":false,"title":"Update BUILD_ESP32.md and Automate install of tools for ESP32","user":{"login":"doingnz","id":5063598,"node_id":"MDQ6VXNlcjUwNjM1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5063598?v=4","gravatar_id":"","url":"https://api.github.com/users/doingnz","html_url":"https://github.com/doingnz","followers_url":"https://api.github.com/users/doingnz/followers","following_url":"https://api.github.com/users/doingnz/following{/other_user}","gists_url":"https://api.github.com/users/doingnz/gists{/gist_id}","starred_url":"https://api.github.com/users/doingnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doingnz/subscriptions","organizations_url":"https://api.github.com/users/doingnz/orgs","repos_url":"https://api.github.com/users/doingnz/repos","events_url":"https://api.github.com/users/doingnz/events{/privacy}","received_events_url":"https://api.github.com/users/doingnz/received_events","type":"User","site_admin":false},"body":"Create install-tools.ps1 which will install the ESP32 tools, library, IDF and openocd into default folders as used in AppVeyor CI tool. Add items to the Windows PATH and Environment to prepare VSCode to build nanoCLR. Update BUILD-ESP32.md to reflect changes and add information regarding JTAG setup (i.e. which pins to connect on ESP32 DevKitC to regular JTAG 20 pin header.\r\n\r\n## Description\r\nCreate PowerShell script `Install-tools.ps1` that emulates portions of the appveyor.yml setup process by calling the existing Install-*.ps1 scripts to download the libraries and tools for ESP32. Add new script to also fetch compiled OpenOCD for ESP. Placeholders appveyor.yml items for STM tools. \r\n\r\nNote that install-tools.ps1 sets the default paths the tools are installed at. Can edit these paths before running the script for a custom install. \r\n\r\nScript will copy templates to required files for VSCode. VSCode will raise errors if the paths are wrong. \r\n\r\nSet the default paths to openOCD in .vscode/launch.TEMPLATE-ESP32.json. Added note in BUILD_ESP32.md to edit these if required. User only needs to set path to nanoCLR.elf if they use the install script. \r\n\r\nAdded link to image of the ESP32 DevKitC pin out and 20 pin JTAG connector with wire colours on which pins to connect.\r\n\r\n## Motivation and Context\r\nThese changes will make it much easier for new users to setup the required environment to build the nanoCLR for the first time, including hook up of JTAG. \r\n\r\n## How Has This Been Tested?\r\nDelete repository. Delete environment variables. Checkout repository. Run install-tools.ps1. Launch VSCode and select the target and build all. Program flash. Debug, setp and then run code. Attach VS2017 to deploy example application. \r\n\r\n## Types of changes\r\n- [X] Improvement (non-breaking change that improves a feature, code or algorithm)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [X] Build environment change, no code change. \r\n\r\n## Checklist:\r\n- [ ] My code follows the code style of this project.\r\n- [X] My change requires a change to the documentation.\r\n- [X] I have updated the documentation accordingly.\r\n- [X] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\nSigned-off-by: doingnz <doingnz@gmail.com>\r\n","created_at":"2018-09-02T16:35:22Z","updated_at":"2018-09-02T17:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"025800c6f8ef1c16bde522bc9168f5d4b0d0e8e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835/commits","review_comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835/comments","review_comment_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/835/comments","statuses_url":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/d4946e5264c6f82953aa8a9863363199e56361a3","head":{"label":"doingnz:build-esp32","ref":"build-esp32","sha":"d4946e5264c6f82953aa8a9863363199e56361a3","user":{"login":"doingnz","id":5063598,"node_id":"MDQ6VXNlcjUwNjM1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5063598?v=4","gravatar_id":"","url":"https://api.github.com/users/doingnz","html_url":"https://github.com/doingnz","followers_url":"https://api.github.com/users/doingnz/followers","following_url":"https://api.github.com/users/doingnz/following{/other_user}","gists_url":"https://api.github.com/users/doingnz/gists{/gist_id}","starred_url":"https://api.github.com/users/doingnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doingnz/subscriptions","organizations_url":"https://api.github.com/users/doingnz/orgs","repos_url":"https://api.github.com/users/doingnz/repos","events_url":"https://api.github.com/users/doingnz/events{/privacy}","received_events_url":"https://api.github.com/users/doingnz/received_events","type":"User","site_admin":false},"repo":{"id":146085731,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwODU3MzE=","name":"nf-interpreter","full_name":"doingnz/nf-interpreter","owner":{"login":"doingnz","id":5063598,"node_id":"MDQ6VXNlcjUwNjM1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5063598?v=4","gravatar_id":"","url":"https://api.github.com/users/doingnz","html_url":"https://github.com/doingnz","followers_url":"https://api.github.com/users/doingnz/followers","following_url":"https://api.github.com/users/doingnz/following{/other_user}","gists_url":"https://api.github.com/users/doingnz/gists{/gist_id}","starred_url":"https://api.github.com/users/doingnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doingnz/subscriptions","organizations_url":"https://api.github.com/users/doingnz/orgs","repos_url":"https://api.github.com/users/doingnz/repos","events_url":"https://api.github.com/users/doingnz/events{/privacy}","received_events_url":"https://api.github.com/users/doingnz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doingnz/nf-interpreter","description":"nanoFramework Interpreter, CLR, HAL, PAL and reference target boards","fork":true,"url":"https://api.github.com/repos/doingnz/nf-interpreter","forks_url":"https://api.github.com/repos/doingnz/nf-interpreter/forks","keys_url":"https://api.github.com/repos/doingnz/nf-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doingnz/nf-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doingnz/nf-interpreter/teams","hooks_url":"https://api.github.com/repos/doingnz/nf-interpreter/hooks","issue_events_url":"https://api.github.com/repos/doingnz/nf-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/doingnz/nf-interpreter/events","assignees_url":"https://api.github.com/repos/doingnz/nf-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/doingnz/nf-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/doingnz/nf-interpreter/tags","blobs_url":"https://api.github.com/repos/doingnz/nf-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doingnz/nf-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doingnz/nf-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/doingnz/nf-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doingnz/nf-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/doingnz/nf-interpreter/languages","stargazers_url":"https://api.github.com/repos/doingnz/nf-interpreter/stargazers","contributors_url":"https://api.github.com/repos/doingnz/nf-interpreter/contributors","subscribers_url":"https://api.github.com/repos/doingnz/nf-interpreter/subscribers","subscription_url":"https://api.github.com/repos/doingnz/nf-interpreter/subscription","commits_url":"https://api.github.com/repos/doingnz/nf-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/doingnz/nf-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/doingnz/nf-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/doingnz/nf-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/doingnz/nf-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/doingnz/nf-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doingnz/nf-interpreter/merges","archive_url":"https://api.github.com/repos/doingnz/nf-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doingnz/nf-interpreter/downloads","issues_url":"https://api.github.com/repos/doingnz/nf-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/doingnz/nf-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/doingnz/nf-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/doingnz/nf-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doingnz/nf-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/doingnz/nf-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/doingnz/nf-interpreter/deployments","created_at":"2018-08-25T10:17:59Z","updated_at":"2018-09-02T10:38:00Z","pushed_at":"2018-09-02T16:12:55Z","git_url":"git://github.com/doingnz/nf-interpreter.git","ssh_url":"git@github.com:doingnz/nf-interpreter.git","clone_url":"https://github.com/doingnz/nf-interpreter.git","svn_url":"https://github.com/doingnz/nf-interpreter","homepage":"https://www.nanoframework.net","size":20186,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"nanoframework:develop","ref":"develop","sha":"9802d73201aba177983632466efb661a7ba4fa9a","user":{"login":"nanoframework","id":23728180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzI4MTgw","avatar_url":"https://avatars1.githubusercontent.com/u/23728180?v=4","gravatar_id":"","url":"https://api.github.com/users/nanoframework","html_url":"https://github.com/nanoframework","followers_url":"https://api.github.com/users/nanoframework/followers","following_url":"https://api.github.com/users/nanoframework/following{/other_user}","gists_url":"https://api.github.com/users/nanoframework/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoframework/subscriptions","organizations_url":"https://api.github.com/users/nanoframework/orgs","repos_url":"https://api.github.com/users/nanoframework/repos","events_url":"https://api.github.com/users/nanoframework/events{/privacy}","received_events_url":"https://api.github.com/users/nanoframework/received_events","type":"Organization","site_admin":false},"repo":{"id":74834622,"node_id":"MDEwOlJlcG9zaXRvcnk3NDgzNDYyMg==","name":"nf-interpreter","full_name":"nanoframework/nf-interpreter","owner":{"login":"nanoframework","id":23728180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzI4MTgw","avatar_url":"https://avatars1.githubusercontent.com/u/23728180?v=4","gravatar_id":"","url":"https://api.github.com/users/nanoframework","html_url":"https://github.com/nanoframework","followers_url":"https://api.github.com/users/nanoframework/followers","following_url":"https://api.github.com/users/nanoframework/following{/other_user}","gists_url":"https://api.github.com/users/nanoframework/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoframework/subscriptions","organizations_url":"https://api.github.com/users/nanoframework/orgs","repos_url":"https://api.github.com/users/nanoframework/repos","events_url":"https://api.github.com/users/nanoframework/events{/privacy}","received_events_url":"https://api.github.com/users/nanoframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nanoframework/nf-interpreter","description":"nanoFramework Interpreter, CLR, HAL, PAL and reference target boards","fork":false,"url":"https://api.github.com/repos/nanoframework/nf-interpreter","forks_url":"https://api.github.com/repos/nanoframework/nf-interpreter/forks","keys_url":"https://api.github.com/repos/nanoframework/nf-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanoframework/nf-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanoframework/nf-interpreter/teams","hooks_url":"https://api.github.com/repos/nanoframework/nf-interpreter/hooks","issue_events_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/nanoframework/nf-interpreter/events","assignees_url":"https://api.github.com/repos/nanoframework/nf-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/nanoframework/nf-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/nanoframework/nf-interpreter/tags","blobs_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/nanoframework/nf-interpreter/languages","stargazers_url":"https://api.github.com/repos/nanoframework/nf-interpreter/stargazers","contributors_url":"https://api.github.com/repos/nanoframework/nf-interpreter/contributors","subscribers_url":"https://api.github.com/repos/nanoframework/nf-interpreter/subscribers","subscription_url":"https://api.github.com/repos/nanoframework/nf-interpreter/subscription","commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanoframework/nf-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/nanoframework/nf-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanoframework/nf-interpreter/merges","archive_url":"https://api.github.com/repos/nanoframework/nf-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanoframework/nf-interpreter/downloads","issues_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/nanoframework/nf-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/nanoframework/nf-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/nanoframework/nf-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/deployments","created_at":"2016-11-26T15:45:06Z","updated_at":"2018-08-30T16:49:00Z","pushed_at":"2018-09-02T16:35:23Z","git_url":"git://github.com/nanoframework/nf-interpreter.git","ssh_url":"git@github.com:nanoframework/nf-interpreter.git","clone_url":"https://github.com/nanoframework/nf-interpreter.git","svn_url":"https://github.com/nanoframework/nf-interpreter","homepage":"https://www.nanoframework.net","size":20248,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":2,"watchers":34,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835"},"html":{"href":"https://github.com/nanoframework/nf-interpreter/pull/835"},"issue":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/835"},"comments":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/835/comments"},"review_comments":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835/comments"},"review_comment":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/835/commits"},"statuses":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/d4946e5264c6f82953aa8a9863363199e56361a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"josesimoes"}}