{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/239383617","pull_request_review_id":182150895,"id":239383617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM4MzYxNw==","diff_hunk":"@@ -622,11 +624,16 @@ class HibernateQueryCriteriaParser(val contractStateType: Class<out ContractStat\n         return emptySet()\n     }\n \n-    private fun parse(sorting: Sort) {\n-        log.trace { \"Parsing sorting specification: $sorting\" }\n+    private fun parse(sortingArg: Sort) {","path":"node/src/main/kotlin/net/corda/node/services/vault/HibernateQueryCriteriaParser.kt","position":24,"original_position":24,"commit_id":"e0ed31fa9100ccee69896d48a09d6efd8534258f","original_commit_id":"e0ed31fa9100ccee69896d48a09d6efd8534258f","user":{"login":"josecoll","id":23558646,"node_id":"MDQ6VXNlcjIzNTU4NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/23558646?v=4","gravatar_id":"","url":"https://api.github.com/users/josecoll","html_url":"https://github.com/josecoll","followers_url":"https://api.github.com/users/josecoll/followers","following_url":"https://api.github.com/users/josecoll/following{/other_user}","gists_url":"https://api.github.com/users/josecoll/gists{/gist_id}","starred_url":"https://api.github.com/users/josecoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josecoll/subscriptions","organizations_url":"https://api.github.com/users/josecoll/orgs","repos_url":"https://api.github.com/users/josecoll/repos","events_url":"https://api.github.com/users/josecoll/events{/privacy}","received_events_url":"https://api.github.com/users/josecoll/received_events","type":"User","site_admin":false},"body":"no need to rename this variable (use a different one in your new logic).","created_at":"2018-12-06T09:39:30Z","updated_at":"2018-12-06T09:40:55Z","html_url":"https://github.com/corda/corda/pull/4366#discussion_r239383617","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/4366","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/239383617"},"html":{"href":"https://github.com/corda/corda/pull/4366#discussion_r239383617"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/4366"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/4366","id":236265389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjY1Mzg5","html_url":"https://github.com/corda/corda/pull/4366","diff_url":"https://github.com/corda/corda/pull/4366.diff","patch_url":"https://github.com/corda/corda/pull/4366.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/4366","number":4366,"state":"open","locked":false,"title":"[CORDA-2247]: Fixed a bug causing Hibernate to produce cross joins.","user":{"login":"sollecitom","id":5455106,"node_id":"MDQ6VXNlcjU0NTUxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5455106?v=4","gravatar_id":"","url":"https://api.github.com/users/sollecitom","html_url":"https://github.com/sollecitom","followers_url":"https://api.github.com/users/sollecitom/followers","following_url":"https://api.github.com/users/sollecitom/following{/other_user}","gists_url":"https://api.github.com/users/sollecitom/gists{/gist_id}","starred_url":"https://api.github.com/users/sollecitom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sollecitom/subscriptions","organizations_url":"https://api.github.com/users/sollecitom/orgs","repos_url":"https://api.github.com/users/sollecitom/repos","events_url":"https://api.github.com/users/sollecitom/events{/privacy}","received_events_url":"https://api.github.com/users/sollecitom/received_events","type":"User","site_admin":false},"body":"https://r3-cev.atlassian.net/browse/CORDA-2247\r\n\r\nNotes:\r\n\r\n1. Fixed a problem that was preventing Hibernate from generating left joins instead of cross joins.\r\n2. Added an additional sort column on `stateRef` to avoid unstable sorts on fields with possible duplicate values. This is added only if no sort columns are based on `stateRef` already.","created_at":"2018-12-05T17:46:00Z","updated_at":"2018-12-06T09:40:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28d1df1c47afc48f68409fc74fb8fd5fbb154c3c","assignee":{"login":"sollecitom","id":5455106,"node_id":"MDQ6VXNlcjU0NTUxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5455106?v=4","gravatar_id":"","url":"https://api.github.com/users/sollecitom","html_url":"https://github.com/sollecitom","followers_url":"https://api.github.com/users/sollecitom/followers","following_url":"https://api.github.com/users/sollecitom/following{/other_user}","gists_url":"https://api.github.com/users/sollecitom/gists{/gist_id}","starred_url":"https://api.github.com/users/sollecitom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sollecitom/subscriptions","organizations_url":"https://api.github.com/users/sollecitom/orgs","repos_url":"https://api.github.com/users/sollecitom/repos","events_url":"https://api.github.com/users/sollecitom/events{/privacy}","received_events_url":"https://api.github.com/users/sollecitom/received_events","type":"User","site_admin":false},"assignees":[{"login":"sollecitom","id":5455106,"node_id":"MDQ6VXNlcjU0NTUxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5455106?v=4","gravatar_id":"","url":"https://api.github.com/users/sollecitom","html_url":"https://github.com/sollecitom","followers_url":"https://api.github.com/users/sollecitom/followers","following_url":"https://api.github.com/users/sollecitom/following{/other_user}","gists_url":"https://api.github.com/users/sollecitom/gists{/gist_id}","starred_url":"https://api.github.com/users/sollecitom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sollecitom/subscriptions","organizations_url":"https://api.github.com/users/sollecitom/orgs","repos_url":"https://api.github.com/users/sollecitom/repos","events_url":"https://api.github.com/users/sollecitom/events{/privacy}","received_events_url":"https://api.github.com/users/sollecitom/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/corda/corda/milestones/17","html_url":"https://github.com/corda/corda/milestone/17","labels_url":"https://api.github.com/repos/corda/corda/milestones/17/labels","id":3776607,"node_id":"MDk6TWlsZXN0b25lMzc3NjYwNw==","number":17,"title":"Corda 4.0","description":null,"creator":{"login":"sollecitom","id":5455106,"node_id":"MDQ6VXNlcjU0NTUxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5455106?v=4","gravatar_id":"","url":"https://api.github.com/users/sollecitom","html_url":"https://github.com/sollecitom","followers_url":"https://api.github.com/users/sollecitom/followers","following_url":"https://api.github.com/users/sollecitom/following{/other_user}","gists_url":"https://api.github.com/users/sollecitom/gists{/gist_id}","starred_url":"https://api.github.com/users/sollecitom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sollecitom/subscriptions","organizations_url":"https://api.github.com/users/sollecitom/orgs","repos_url":"https://api.github.com/users/sollecitom/repos","events_url":"https://api.github.com/users/sollecitom/events{/privacy}","received_events_url":"https://api.github.com/users/sollecitom/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":30,"state":"open","created_at":"2018-10-29T10:13:14Z","updated_at":"2018-12-05T17:46:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/corda/corda/pulls/4366/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/4366/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/4366/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/e0ed31fa9100ccee69896d48a09d6efd8534258f","head":{"label":"corda:bugfixes/CORDA-2247","ref":"bugfixes/CORDA-2247","sha":"e0ed31fa9100ccee69896d48a09d6efd8534258f","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-12-05T18:55:50Z","pushed_at":"2018-12-06T08:48:29Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":170192,"stargazers_count":2543,"watchers_count":2543,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":650,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":650,"open_issues":97,"watchers":2543,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"316dc4ab92941a0693394eec0e7771e41b50617a","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-12-05T18:55:50Z","pushed_at":"2018-12-06T08:48:29Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":170192,"stargazers_count":2543,"watchers_count":2543,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":650,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":650,"open_issues":97,"watchers":2543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/4366"},"html":{"href":"https://github.com/corda/corda/pull/4366"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/4366"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/4366/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/4366/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/4366/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/e0ed31fa9100ccee69896d48a09d6efd8534258f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"josecoll"}}