{"action":"created","issue":{"url":"https://api.github.com/repos/faylang/fay/issues/452","repository_url":"https://api.github.com/repos/faylang/fay","labels_url":"https://api.github.com/repos/faylang/fay/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/faylang/fay/issues/452/comments","events_url":"https://api.github.com/repos/faylang/fay/issues/452/events","html_url":"https://github.com/faylang/fay/pull/452","id":326279338,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDEwMjcx","number":452,"title":"Update fay to run with more recent haskell-src-exts","user":{"login":"henrylaxen","id":66570,"node_id":"MDQ6VXNlcjY2NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/66570?v=4","gravatar_id":"","url":"https://api.github.com/users/henrylaxen","html_url":"https://github.com/henrylaxen","followers_url":"https://api.github.com/users/henrylaxen/followers","following_url":"https://api.github.com/users/henrylaxen/following{/other_user}","gists_url":"https://api.github.com/users/henrylaxen/gists{/gist_id}","starred_url":"https://api.github.com/users/henrylaxen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrylaxen/subscriptions","organizations_url":"https://api.github.com/users/henrylaxen/orgs","repos_url":"https://api.github.com/users/henrylaxen/repos","events_url":"https://api.github.com/users/henrylaxen/events{/privacy}","received_events_url":"https://api.github.com/users/henrylaxen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-24T20:27:01Z","updated_at":"2018-06-09T15:07:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/faylang/fay/pulls/452","html_url":"https://github.com/faylang/fay/pull/452","diff_url":"https://github.com/faylang/fay/pull/452.diff","patch_url":"https://github.com/faylang/fay/pull/452.patch"},"body":"Hi Adam,\r\n\r\nI have quite of bit of code that depends on fay, so when it doesn't\r\ncompile with the version of ghc I'm using, I notice.  Well, I couldn't\r\ncompile fay with ghc 8.4.2 so I started looking into it.  I discovered\r\nthat the culprits where mainly two.  The new Semigroup class and some\r\nnew names introduced to haskell-src-exts.  So I added those changes to\r\nfay and found I still couldn't compile because of dependency on\r\ntesting-feat in language-ecmascript.  It turns out that testing-feat\r\nis not really required to compile the language, it is just need to run\r\nthe tests.  I modified the language-ecmascript.cabal file to pull out\r\nthe testing-feat dependency and put it into the test section of the\r\ncabal file and filed a pull request,\r\nhttps://github.com/jswebtools/language-ecmascript/pull/84, almost a\r\nmonth ago.  Sadly it has not yet been included in Hackage so I have to\r\nhave my own private version of language-ecmascript in order to compile\r\nfay.  I'm included the file fay-language-ecmascript.diff in this pull\r\nrequest so perhaps you can encourage Andrey\r\n(https://github.com/achudnov) to push it to hackage.  Anyway, after\r\nmaking all those changes, it now compiles and passes the tests with\r\nnightly-2018-05-13.  I was hoping an lts package that uses ghc 8.4.2\r\nbecomes available before I sent this, but so far it hasn't and I need\r\nto move on to other things.  I wish I understood the code you have\r\nwritten to implement fay better, but it is above my haskell pay grade\r\nat this point.  Anyway, I hope you find this effort helpful in keeping\r\nfay up to date.\r\n\r\nBest wishes,\r\nHenry Laxen\r\n\r\n\r\nPS\r\n\r\nI ran the fay.cabal file through cabal-bounds, which completely reformatted the fay.cabal file.  That is why the diff is the entire cabal file.  Sorry.  Also I compiled and ran fay-tests and all of the tests came back OK.\r\n"},"comment":{"url":"https://api.github.com/repos/faylang/fay/issues/comments/395976468","html_url":"https://github.com/faylang/fay/pull/452#issuecomment-395976468","issue_url":"https://api.github.com/repos/faylang/fay/issues/452","id":395976468,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk3NjQ2OA==","user":{"login":"mihaimaruseac","id":323199,"node_id":"MDQ6VXNlcjMyMzE5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/323199?v=4","gravatar_id":"","url":"https://api.github.com/users/mihaimaruseac","html_url":"https://github.com/mihaimaruseac","followers_url":"https://api.github.com/users/mihaimaruseac/followers","following_url":"https://api.github.com/users/mihaimaruseac/following{/other_user}","gists_url":"https://api.github.com/users/mihaimaruseac/gists{/gist_id}","starred_url":"https://api.github.com/users/mihaimaruseac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihaimaruseac/subscriptions","organizations_url":"https://api.github.com/users/mihaimaruseac/orgs","repos_url":"https://api.github.com/users/mihaimaruseac/repos","events_url":"https://api.github.com/users/mihaimaruseac/events{/privacy}","received_events_url":"https://api.github.com/users/mihaimaruseac/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T15:07:17Z","updated_at":"2018-06-09T15:07:17Z","author_association":"NONE","body":"Just merged commercialhaskell/stackage#3723 and got a full build to pass, so all deps will be in nightly in a few hours."}}
{"actor":{"display_login":"mihaimaruseac"}}