{"action":"opened","number":6227,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227","id":206548865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTQ4ODY1","html_url":"https://github.com/salesagility/SuiteCRM/pull/6227","diff_url":"https://github.com/salesagility/SuiteCRM/pull/6227.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/6227.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6227","number":6227,"state":"open","locked":false,"title":"Fix PipelineBySalesStage not converting currency","user":{"login":"AussieGuy0","id":14071738,"node_id":"MDQ6VXNlcjE0MDcxNzM4","avatar_url":"https://avatars3.githubusercontent.com/u/14071738?v=4","gravatar_id":"","url":"https://api.github.com/users/AussieGuy0","html_url":"https://github.com/AussieGuy0","followers_url":"https://api.github.com/users/AussieGuy0/followers","following_url":"https://api.github.com/users/AussieGuy0/following{/other_user}","gists_url":"https://api.github.com/users/AussieGuy0/gists{/gist_id}","starred_url":"https://api.github.com/users/AussieGuy0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AussieGuy0/subscriptions","organizations_url":"https://api.github.com/users/AussieGuy0/orgs","repos_url":"https://api.github.com/users/AussieGuy0/repos","events_url":"https://api.github.com/users/AussieGuy0/events{/privacy}","received_events_url":"https://api.github.com/users/AussieGuy0/received_events","type":"User","site_admin":false},"body":"The PipelineBySalesStageDashlet was not converting currency when determining amounts shown in the chart. However, it was changing the currency symbol to the user's selected currency. This is a bug as the user's currency could be the Japanese Yen, so it would show the Yen symbol (¥) next to US Dollar amounts.\r\n\r\n## Description\r\nJust adjusting the query that grabs the values for the chart so that the query converts the us_dollar amounts to the user's default currency. If user has no default currency, we use the system's default currency.\r\n\r\n### Steps to reproduce bug\r\nPrereqs: Have user default currency in USD\r\n1. Add the PipelineBySalesStageDashlet to dashboard\r\n2. Notice currency symbol and amounts\r\n3. Change default currency to something else\r\n4. Go back to dashboard\r\n5. Notice that the currency symbol has changed BUT the value amounts are still in US dollars\r\n\r\n## Motivation and Context\r\nTo show the correct currency conversion with the correct currency symbol in the PipelineBySalesStageDashlet.\r\n\r\n## How To Test This\r\nPrereqs: Have user default currency in USD\r\n1. Add the PipelineBySalesStageDashlet to dashboard\r\n2. Notice currency symbol and amounts\r\n3. Change default currency to something else\r\n4. Go back to dashboard\r\n5. Notice that the currency symbol and amounts have appropriately changed\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-08-07T00:18:38Z","updated_at":"2018-08-07T00:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6227/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/096966c660fb5673f2dde91fad3c794b57a449a6","head":{"label":"AussieGuy0:patch-1","ref":"patch-1","sha":"096966c660fb5673f2dde91fad3c794b57a449a6","user":{"login":"AussieGuy0","id":14071738,"node_id":"MDQ6VXNlcjE0MDcxNzM4","avatar_url":"https://avatars3.githubusercontent.com/u/14071738?v=4","gravatar_id":"","url":"https://api.github.com/users/AussieGuy0","html_url":"https://github.com/AussieGuy0","followers_url":"https://api.github.com/users/AussieGuy0/followers","following_url":"https://api.github.com/users/AussieGuy0/following{/other_user}","gists_url":"https://api.github.com/users/AussieGuy0/gists{/gist_id}","starred_url":"https://api.github.com/users/AussieGuy0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AussieGuy0/subscriptions","organizations_url":"https://api.github.com/users/AussieGuy0/orgs","repos_url":"https://api.github.com/users/AussieGuy0/repos","events_url":"https://api.github.com/users/AussieGuy0/events{/privacy}","received_events_url":"https://api.github.com/users/AussieGuy0/received_events","type":"User","site_admin":false},"repo":{"id":143795903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3OTU5MDM=","name":"SuiteCRM","full_name":"AussieGuy0/SuiteCRM","owner":{"login":"AussieGuy0","id":14071738,"node_id":"MDQ6VXNlcjE0MDcxNzM4","avatar_url":"https://avatars3.githubusercontent.com/u/14071738?v=4","gravatar_id":"","url":"https://api.github.com/users/AussieGuy0","html_url":"https://github.com/AussieGuy0","followers_url":"https://api.github.com/users/AussieGuy0/followers","following_url":"https://api.github.com/users/AussieGuy0/following{/other_user}","gists_url":"https://api.github.com/users/AussieGuy0/gists{/gist_id}","starred_url":"https://api.github.com/users/AussieGuy0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AussieGuy0/subscriptions","organizations_url":"https://api.github.com/users/AussieGuy0/orgs","repos_url":"https://api.github.com/users/AussieGuy0/repos","events_url":"https://api.github.com/users/AussieGuy0/events{/privacy}","received_events_url":"https://api.github.com/users/AussieGuy0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AussieGuy0/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/AussieGuy0/SuiteCRM","forks_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/forks","keys_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/events","assignees_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/merges","archive_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/AussieGuy0/SuiteCRM/deployments","created_at":"2018-08-06T23:58:42Z","updated_at":"2018-08-06T23:59:05Z","pushed_at":"2018-08-07T00:03:44Z","git_url":"git://github.com/AussieGuy0/SuiteCRM.git","ssh_url":"git@github.com:AussieGuy0/SuiteCRM.git","clone_url":"https://github.com/AussieGuy0/SuiteCRM.git","svn_url":"https://github.com/AussieGuy0/SuiteCRM","homepage":"https://www.suitecrm.com","size":100380,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:master","ref":"master","sha":"8b3082dd6de4e3a866d16111f400c6561a651bdb","user":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0NDYwMA==","name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-08-06T21:58:59Z","pushed_at":"2018-08-06T16:50:50Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"https://www.suitecrm.com","size":100380,"stargazers_count":1071,"watchers_count":1071,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":844,"mirror_url":null,"archived":false,"open_issues_count":1020,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":844,"open_issues":1020,"watchers":1071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/6227"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6227"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6227/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6227/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/096966c660fb5673f2dde91fad3c794b57a449a6"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"AussieGuy0"}}