{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/27660","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/27660/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/27660/comments","events_url":"https://api.github.com/repos/angular/angular/issues/27660/events","html_url":"https://github.com/angular/angular/pull/27660","id":390867917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTM4NTQx","number":27660,"title":"fix(upgrade): upgrade Directive facade should not return different instance from constructor","user":{"login":"petebacondarwin","id":15655,"node_id":"MDQ6VXNlcjE1NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15655?v=4","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":660621334,"node_id":"MDU6TGFiZWw2NjA2MjEzMzQ=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":799860804,"node_id":"MDU6TGFiZWw3OTk4NjA4MDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false},{"id":245057144,"node_id":"MDU6TGFiZWwyNDUwNTcxNDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20upgrade/dynamic","name":"comp: upgrade/dynamic","color":"c7def8","default":false},{"id":375496864,"node_id":"MDU6TGFiZWwzNzU0OTY4NjQ=","url":"https://api.github.com/repos/angular/angular/labels/freq1:%20low","name":"freq1: low","color":"fbca04","default":false},{"id":836688282,"node_id":"MDU6TGFiZWw4MzY2ODgyODI=","url":"https://api.github.com/repos/angular/angular/labels/risk:%20low","name":"risk: low","color":"ffe6ff","default":false},{"id":130606843,"node_id":"MDU6TGFiZWwxMzA2MDY4NDM=","url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":194,"closed_issues":1113,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-12-17T22:37:03Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-12-13T21:30:21Z","updated_at":"2018-12-17T22:47:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27660","html_url":"https://github.com/angular/angular/pull/27660","diff_url":"https://github.com/angular/angular/pull/27660.diff","patch_url":"https://github.com/angular/angular/pull/27660.patch"},"body":"In ngUpgrade (dynamic) we create a dynamic Angular `Directive` that wraps AngularJS components\r\nthat are being upgraded. The constructor of this `Directive` class returns a different instance\r\nthan `this`. It is this instance that actually contains the life-cycle hook handlers.\r\n\r\nThis would break in ivy, since the methods on the prototype of the original class are wired up,\r\nrather than the instance methods. This results in hooks like `ngOnInit` not being called.\r\n\r\nThis PR refactors the code to extend the inner class that was being returned so that the\r\nprototype chain is correct for both ViewEngine and ivy.\r\n\r\nThis change resolves a number of failing ivy tests, but also exposes other failures that were\r\nmasked by this issue. The tests have been updated accordingly."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/448028176","html_url":"https://github.com/angular/angular/pull/27660#issuecomment-448028176","issue_url":"https://api.github.com/repos/angular/angular/issues/27660","id":448028176,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODAyODE3Ng==","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T22:47:22Z","updated_at":"2018-12-17T22:47:22Z","author_association":"MEMBER","body":"http://test/OCL:225893715:BASE:225893959:1545086831857:24be1aa6"}}
{"actor":{"display_login":"mhevery"}}