{"action":"created","issue":{"url":"https://api.github.com/repos/schmittjoh/serializer/issues/899","repository_url":"https://api.github.com/repos/schmittjoh/serializer","labels_url":"https://api.github.com/repos/schmittjoh/serializer/issues/899/labels{/name}","comments_url":"https://api.github.com/repos/schmittjoh/serializer/issues/899/comments","events_url":"https://api.github.com/repos/schmittjoh/serializer/issues/899/events","html_url":"https://github.com/schmittjoh/serializer/pull/899","id":312763276,"number":899,"title":"Explicitly set serialization precision for tests","user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-10T03:48:12Z","updated_at":"2018-04-10T21:25:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/schmittjoh/serializer/pulls/899","html_url":"https://github.com/schmittjoh/serializer/pull/899","diff_url":"https://github.com/schmittjoh/serializer/pull/899.diff","patch_url":"https://github.com/schmittjoh/serializer/pull/899.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| Doc updated   | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n\r\nOn PHP 7.2 tests are failing with the following configuration:\r\n```\r\n$ php -i | grep precision\r\nprecision => 14 => 14\r\nserialize_precision => 17 => 17\r\n```\r\n\r\n```\r\nThere were 2 failures:\r\n\r\n1) JMS\\Serializer\\Tests\\Serializer\\JsonSerializationTest::testArrayFloats\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'[1.34,3,6.42]'\r\n+'[1.3400000000000001,3,6.4199999999999999]'\r\n\r\n/www/jms/serializer/tests/Serializer/BaseSerializationTest.php:437\r\n\r\n2) JMS\\Serializer\\Tests\\Serializer\\JsonSerializationTest::testCurrencyAwarePrice\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'{\"currency\":\"EUR\",\"amount\":2.34}'\r\n+'{\"currency\":\"EUR\",\"amount\":2.3399999999999999}'\r\n\r\n/www/jms/serializer/tests/Serializer/BaseSerializationTest.php:762\r\n```\r\n\r\nThis explicitly changes precision for tests to avoid surprises (hello float!)."},"comment":{"url":"https://api.github.com/repos/schmittjoh/serializer/issues/comments/380251918","html_url":"https://github.com/schmittjoh/serializer/pull/899#issuecomment-380251918","issue_url":"https://api.github.com/repos/schmittjoh/serializer/issues/899","id":380251918,"user":{"login":"goetas","id":776743,"avatar_url":"https://avatars0.githubusercontent.com/u/776743?v=4","gravatar_id":"","url":"https://api.github.com/users/goetas","html_url":"https://github.com/goetas","followers_url":"https://api.github.com/users/goetas/followers","following_url":"https://api.github.com/users/goetas/following{/other_user}","gists_url":"https://api.github.com/users/goetas/gists{/gist_id}","starred_url":"https://api.github.com/users/goetas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goetas/subscriptions","organizations_url":"https://api.github.com/users/goetas/orgs","repos_url":"https://api.github.com/users/goetas/repos","events_url":"https://api.github.com/users/goetas/events{/privacy}","received_events_url":"https://api.github.com/users/goetas/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T21:25:58Z","updated_at":"2018-04-10T21:25:58Z","author_association":"COLLABORATOR","body":"Looks good, thanks "}}
{"actor":{"display_login":"goetas"}}