{"action":"created","comment":{"url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/comments/228409822","pull_request_review_id":168676485,"id":228409822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODQwOTgyMg==","diff_hunk":"@@ -5,33 +5,32 @@ package testcase\n import (\n \t\"encoding/json\"\n \t\"fmt\"\n+\t\"github.com/magnusbaeck/logstash-filter-verifier/logging\"\n+\t\"github.com/magnusbaeck/logstash-filter-verifier/logstash\"\n+\t\"gopkg.in/yaml.v2\"","path":"testcase/testcase.go","position":6,"original_position":6,"commit_id":"30d9464f4264dcc1ed17bc909f79ab8ff9466d97","original_commit_id":"30d9464f4264dcc1ed17bc909f79ab8ff9466d97","user":{"login":"croesnick","id":307585,"node_id":"MDQ6VXNlcjMwNzU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/307585?v=4","gravatar_id":"","url":"https://api.github.com/users/croesnick","html_url":"https://github.com/croesnick","followers_url":"https://api.github.com/users/croesnick/followers","following_url":"https://api.github.com/users/croesnick/following{/other_user}","gists_url":"https://api.github.com/users/croesnick/gists{/gist_id}","starred_url":"https://api.github.com/users/croesnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croesnick/subscriptions","organizations_url":"https://api.github.com/users/croesnick/orgs","repos_url":"https://api.github.com/users/croesnick/repos","events_url":"https://api.github.com/users/croesnick/events{/privacy}","received_events_url":"https://api.github.com/users/croesnick/received_events","type":"User","site_admin":false},"body":"Thanks for noticing. :) I am aware of such rules in, say Python. However, I have to admit not having looked up the common style and formatting rules for Go yet. I'll reorder it today.","created_at":"2018-10-26T05:35:36Z","updated_at":"2018-10-26T05:35:36Z","html_url":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62#discussion_r228409822","pull_request_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/comments/228409822"},"html":{"href":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62#discussion_r228409822"},"pull_request":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62"}},"in_reply_to_id":227960894},"pull_request":{"url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62","id":223739590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzM5NTkw","html_url":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62","diff_url":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62.diff","patch_url":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62.patch","issue_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/62","number":62,"state":"open","locked":false,"title":"Known limitations -1: Add YAML support","user":{"login":"croesnick","id":307585,"node_id":"MDQ6VXNlcjMwNzU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/307585?v=4","gravatar_id":"","url":"https://api.github.com/users/croesnick","html_url":"https://github.com/croesnick","followers_url":"https://api.github.com/users/croesnick/followers","following_url":"https://api.github.com/users/croesnick/following{/other_user}","gists_url":"https://api.github.com/users/croesnick/gists{/gist_id}","starred_url":"https://api.github.com/users/croesnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croesnick/subscriptions","organizations_url":"https://api.github.com/users/croesnick/orgs","repos_url":"https://api.github.com/users/croesnick/repos","events_url":"https://api.github.com/users/croesnick/events{/privacy}","received_events_url":"https://api.github.com/users/croesnick/received_events","type":"User","site_admin":false},"body":"As already stated by @magnusbaeck in the _Known Limitations_, supporting YAML (superset of JSON) would be nice, especially to get around the need to always escape quotes in JSON input objects. This PR adds this support as well as a short section in the README how to convert already present testcases in JSON format to YAML. Enjoy. :)","created_at":"2018-10-17T20:16:17Z","updated_at":"2018-10-26T05:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58a95c7ce340c4619b0762490885a4af0c3177d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":289898427,"node_id":"MDU6TGFiZWwyODk4OTg0Mjc=","url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62/commits","review_comments_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62/comments","review_comment_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/62/comments","statuses_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/statuses/30d9464f4264dcc1ed17bc909f79ab8ff9466d97","head":{"label":"croesnick:feature/testcase_yaml_support","ref":"feature/testcase_yaml_support","sha":"30d9464f4264dcc1ed17bc909f79ab8ff9466d97","user":{"login":"croesnick","id":307585,"node_id":"MDQ6VXNlcjMwNzU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/307585?v=4","gravatar_id":"","url":"https://api.github.com/users/croesnick","html_url":"https://github.com/croesnick","followers_url":"https://api.github.com/users/croesnick/followers","following_url":"https://api.github.com/users/croesnick/following{/other_user}","gists_url":"https://api.github.com/users/croesnick/gists{/gist_id}","starred_url":"https://api.github.com/users/croesnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croesnick/subscriptions","organizations_url":"https://api.github.com/users/croesnick/orgs","repos_url":"https://api.github.com/users/croesnick/repos","events_url":"https://api.github.com/users/croesnick/events{/privacy}","received_events_url":"https://api.github.com/users/croesnick/received_events","type":"User","site_admin":false},"repo":{"id":152752837,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NTI4Mzc=","name":"logstash-filter-verifier","full_name":"croesnick/logstash-filter-verifier","private":false,"owner":{"login":"croesnick","id":307585,"node_id":"MDQ6VXNlcjMwNzU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/307585?v=4","gravatar_id":"","url":"https://api.github.com/users/croesnick","html_url":"https://github.com/croesnick","followers_url":"https://api.github.com/users/croesnick/followers","following_url":"https://api.github.com/users/croesnick/following{/other_user}","gists_url":"https://api.github.com/users/croesnick/gists{/gist_id}","starred_url":"https://api.github.com/users/croesnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croesnick/subscriptions","organizations_url":"https://api.github.com/users/croesnick/orgs","repos_url":"https://api.github.com/users/croesnick/repos","events_url":"https://api.github.com/users/croesnick/events{/privacy}","received_events_url":"https://api.github.com/users/croesnick/received_events","type":"User","site_admin":false},"html_url":"https://github.com/croesnick/logstash-filter-verifier","description":"A testing tool for logstash pipelines","fork":true,"url":"https://api.github.com/repos/croesnick/logstash-filter-verifier","forks_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/forks","keys_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/teams","hooks_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/hooks","issue_events_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/issues/events{/number}","events_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/events","assignees_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/assignees{/user}","branches_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/branches{/branch}","tags_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/tags","blobs_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/git/refs{/sha}","trees_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/statuses/{sha}","languages_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/languages","stargazers_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/stargazers","contributors_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/contributors","subscribers_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/subscribers","subscription_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/subscription","commits_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/commits{/sha}","git_commits_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/git/commits{/sha}","comments_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/comments{/number}","issue_comment_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/issues/comments{/number}","contents_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/contents/{+path}","compare_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/merges","archive_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/downloads","issues_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/issues{/number}","pulls_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/pulls{/number}","milestones_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/milestones{/number}","notifications_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/labels{/name}","releases_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/releases{/id}","deployments_url":"https://api.github.com/repos/croesnick/logstash-filter-verifier/deployments","created_at":"2018-10-12T13:14:08Z","updated_at":"2018-10-14T19:18:58Z","pushed_at":"2018-10-17T20:10:37Z","git_url":"git://github.com/croesnick/logstash-filter-verifier.git","ssh_url":"git@github.com:croesnick/logstash-filter-verifier.git","clone_url":"https://github.com/croesnick/logstash-filter-verifier.git","svn_url":"https://github.com/croesnick/logstash-filter-verifier","homepage":"","size":198,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magnusbaeck:master","ref":"master","sha":"0829bcd0f6065b383e44c882d53fb0c009c832ed","user":{"login":"magnusbaeck","id":9032797,"node_id":"MDQ6VXNlcjkwMzI3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9032797?v=4","gravatar_id":"","url":"https://api.github.com/users/magnusbaeck","html_url":"https://github.com/magnusbaeck","followers_url":"https://api.github.com/users/magnusbaeck/followers","following_url":"https://api.github.com/users/magnusbaeck/following{/other_user}","gists_url":"https://api.github.com/users/magnusbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/magnusbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnusbaeck/subscriptions","organizations_url":"https://api.github.com/users/magnusbaeck/orgs","repos_url":"https://api.github.com/users/magnusbaeck/repos","events_url":"https://api.github.com/users/magnusbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/magnusbaeck/received_events","type":"User","site_admin":false},"repo":{"id":46632418,"node_id":"MDEwOlJlcG9zaXRvcnk0NjYzMjQxOA==","name":"logstash-filter-verifier","full_name":"magnusbaeck/logstash-filter-verifier","private":false,"owner":{"login":"magnusbaeck","id":9032797,"node_id":"MDQ6VXNlcjkwMzI3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9032797?v=4","gravatar_id":"","url":"https://api.github.com/users/magnusbaeck","html_url":"https://github.com/magnusbaeck","followers_url":"https://api.github.com/users/magnusbaeck/followers","following_url":"https://api.github.com/users/magnusbaeck/following{/other_user}","gists_url":"https://api.github.com/users/magnusbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/magnusbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnusbaeck/subscriptions","organizations_url":"https://api.github.com/users/magnusbaeck/orgs","repos_url":"https://api.github.com/users/magnusbaeck/repos","events_url":"https://api.github.com/users/magnusbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/magnusbaeck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/magnusbaeck/logstash-filter-verifier","description":null,"fork":false,"url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier","forks_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/forks","keys_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/teams","hooks_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/hooks","issue_events_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/events{/number}","events_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/events","assignees_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/assignees{/user}","branches_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/branches{/branch}","tags_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/tags","blobs_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/git/refs{/sha}","trees_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/statuses/{sha}","languages_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/languages","stargazers_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/stargazers","contributors_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/contributors","subscribers_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/subscribers","subscription_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/subscription","commits_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/commits{/sha}","git_commits_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/git/commits{/sha}","comments_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/comments{/number}","issue_comment_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/comments{/number}","contents_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/contents/{+path}","compare_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/merges","archive_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/downloads","issues_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues{/number}","pulls_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls{/number}","milestones_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/milestones{/number}","notifications_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/labels{/name}","releases_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/releases{/id}","deployments_url":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/deployments","created_at":"2015-11-21T20:25:32Z","updated_at":"2018-10-24T11:11:26Z","pushed_at":"2018-10-17T20:16:18Z","git_url":"git://github.com/magnusbaeck/logstash-filter-verifier.git","ssh_url":"git@github.com:magnusbaeck/logstash-filter-verifier.git","clone_url":"https://github.com/magnusbaeck/logstash-filter-verifier.git","svn_url":"https://github.com/magnusbaeck/logstash-filter-verifier","homepage":null,"size":179,"stargazers_count":67,"watchers_count":67,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":15,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62"},"html":{"href":"https://github.com/magnusbaeck/logstash-filter-verifier/pull/62"},"issue":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/62"},"comments":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/magnusbaeck/logstash-filter-verifier/statuses/30d9464f4264dcc1ed17bc909f79ab8ff9466d97"}},"author_association":"NONE"}}
{"actor":{"display_login":"croesnick"}}