{"action":"created","issue":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3273","repository_url":"https://api.github.com/repos/mitmproxy/mitmproxy","labels_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3273/labels{/name}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3273/comments","events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3273/events","html_url":"https://github.com/mitmproxy/mitmproxy/issues/3273","id":346070228,"node_id":"MDU6SXNzdWUzNDYwNzAyMjg=","number":3273,"title":"Reduce certificate validity for Chrome >= 68","user":{"login":"muffl0n","id":927904,"node_id":"MDQ6VXNlcjkyNzkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/927904?v=4","gravatar_id":"","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-31T07:37:52Z","updated_at":"2018-07-31T07:48:18Z","closed_at":null,"author_association":"NONE","body":"##### Steps to reproduce the problem:\r\n\r\n1. Install Chrome 68\r\n2. Start mitmproxy, add mitmproxy-ca to your cert-store\r\n3. Open any site via https\r\n4. Chrome shows NET::ERR_CERT_VALIDITY_TOO_LONG error\r\n\r\n\r\n##### Any other comments? What have you tried so far?\r\nIn #815 the validity of the certificates was reduced to three years which was enough for Chrome's \"not valid longer than 39 month\". It seems like Chrome 68 changed this to a shorter value though I haven't found any evidence in the code yet.\r\nAfter tinkering around I found that the value \"71107200\" (around 27 month) for DEFAULT_EXP is the greatest value that is accepted by Chrome.\r\n\r\nI know that I'm not using the most recent version of mitmproxy but the value for DEFAULT_EXP is the same in the current version so I assume the problem is still the same.\r\n\r\nSuggesting to just reduce the validity to something really short, like Let's Encrypt's three month. Should not be a problem and saves us from further reduction in Chrome.\r\n\r\n##### System information\r\n-> % mitmproxy --version\r\nMitmproxy: 3.0.3 \r\nPython:    3.6.6\r\nOpenSSL:   OpenSSL 1.1.0h  27 Mar 2018\r\nPlatform:  Linux-4.17.8-1-ARCH-x86_64-with-arch"},"comment":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/comments/409128396","html_url":"https://github.com/mitmproxy/mitmproxy/issues/3273#issuecomment-409128396","issue_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3273","id":409128396,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTEyODM5Ng==","user":{"login":"muffl0n","id":927904,"node_id":"MDQ6VXNlcjkyNzkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/927904?v=4","gravatar_id":"","url":"https://api.github.com/users/muffl0n","html_url":"https://github.com/muffl0n","followers_url":"https://api.github.com/users/muffl0n/followers","following_url":"https://api.github.com/users/muffl0n/following{/other_user}","gists_url":"https://api.github.com/users/muffl0n/gists{/gist_id}","starred_url":"https://api.github.com/users/muffl0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffl0n/subscriptions","organizations_url":"https://api.github.com/users/muffl0n/orgs","repos_url":"https://api.github.com/users/muffl0n/repos","events_url":"https://api.github.com/users/muffl0n/events{/privacy}","received_events_url":"https://api.github.com/users/muffl0n/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T07:48:18Z","updated_at":"2018-07-31T07:48:18Z","author_association":"NONE","body":"Nevermind...it's this part: https://chromium.googlesource.com/chromium/src/+/68.0.3440.85/net/cert/cert_verify_proc.cc#898\r\n```\r\n  // For certificates issued after 1 March 2018: 825 days.\r\n  if (start >= time_2018_03_01 &&\r\n      validity_duration > base::TimeDelta::FromDays(825)) {\r\n    return true;\r\n  }\r\n```"}}
{"actor":{"display_login":"muffl0n"}}