{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/5978","repository_url":"https://api.github.com/repos/eclipse/smarthome","labels_url":"https://api.github.com/repos/eclipse/smarthome/issues/5978/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/5978/comments","events_url":"https://api.github.com/repos/eclipse/smarthome/issues/5978/events","html_url":"https://github.com/eclipse/smarthome/pull/5978","id":345433992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTg0OTMw","number":5978,"title":"[Homematic] Changes for Thing Types and Homegear prefix","user":{"login":"bredmich","id":15615102,"node_id":"MDQ6VXNlcjE1NjE1MTAy","avatar_url":"https://avatars1.githubusercontent.com/u/15615102?v=4","gravatar_id":"","url":"https://api.github.com/users/bredmich","html_url":"https://github.com/bredmich","followers_url":"https://api.github.com/users/bredmich/followers","following_url":"https://api.github.com/users/bredmich/following{/other_user}","gists_url":"https://api.github.com/users/bredmich/gists{/gist_id}","starred_url":"https://api.github.com/users/bredmich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bredmich/subscriptions","organizations_url":"https://api.github.com/users/bredmich/orgs","repos_url":"https://api.github.com/users/bredmich/repos","events_url":"https://api.github.com/users/bredmich/events{/privacy}","received_events_url":"https://api.github.com/users/bredmich/received_events","type":"User","site_admin":false},"labels":[{"id":965579573,"node_id":"MDU6TGFiZWw5NjU1Nzk1NzM=","url":"https://api.github.com/repos/eclipse/smarthome/labels/Binding-Homematic","name":"Binding-Homematic","color":"e8b399","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-28T09:11:17Z","updated_at":"2018-07-31T14:33:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/5978","html_url":"https://github.com/eclipse/smarthome/pull/5978","diff_url":"https://github.com/eclipse/smarthome/pull/5978.diff","patch_url":"https://github.com/eclipse/smarthome/pull/5978.patch"},"body":"- Added a more clear description when the `HG-` prefix for Homegear is needed\r\n- Added information that channel configs are optional\r\n- Changed the description from lowercase to uppercase for Thing Types\r\n-> See: https://community.openhab.org/t/solved-homematic-channel-type-couldn-t-be-resolved/47950/5\r\n\r\nWhen adding the Thing Type in lowercase the logviewer says:\r\n`Channel type homematic:HM-LC-Dim1T-Pl-2_1_level could not be resolved.`\r\nIt´s only working when the Thing Type is added in uppercase.\r\n\r\nI´m also not very sure if the information \"All channels have two configs\" is correct.\r\nAs you can see in my community post, i wasn´t able to get it working with channel configs for `LOWBAT` and `STATE`.\r\nIt was only working with one channel config for `STATE` as the channel `LOWBAT` can´t be configured for `delay`and `receiveDelay`.\r\nPlease check if it´s true that \"ALL\" channels can be configured.\r\n\r\nSigned-off-by: Michael Bredehorn <michael@bredehorn.nrw> (github: bredmich)"},"comment":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/comments/409242875","html_url":"https://github.com/eclipse/smarthome/pull/5978#issuecomment-409242875","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/5978","id":409242875,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI0Mjg3NQ==","user":{"login":"mdicke2s","id":1636603,"node_id":"MDQ6VXNlcjE2MzY2MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1636603?v=4","gravatar_id":"","url":"https://api.github.com/users/mdicke2s","html_url":"https://github.com/mdicke2s","followers_url":"https://api.github.com/users/mdicke2s/followers","following_url":"https://api.github.com/users/mdicke2s/following{/other_user}","gists_url":"https://api.github.com/users/mdicke2s/gists{/gist_id}","starred_url":"https://api.github.com/users/mdicke2s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdicke2s/subscriptions","organizations_url":"https://api.github.com/users/mdicke2s/orgs","repos_url":"https://api.github.com/users/mdicke2s/repos","events_url":"https://api.github.com/users/mdicke2s/events{/privacy}","received_events_url":"https://api.github.com/users/mdicke2s/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T14:33:30Z","updated_at":"2018-07-31T14:33:30Z","author_association":"CONTRIBUTOR","body":"Hi @bredmich,\r\nmeanwhile I also took a look. The changes that you made are correct and since you addressed @hsudbrock 's comments, the structure looks clear to me.\r\n\r\nThere is one thing which I still would like to clarify: Which case is to be used for the channels? After your change we would have one example uppercase, one example lowercase and the text telling to use lowercase.\r\n\r\nAs I commented on your previous commit (https://github.com/eclipse/smarthome/pull/5926#discussion_r203253038), the matching of the channel is case sensitive. But I'm not able to check this on any gateway type. AFAIK for CCU, it is required that the channel is written uppercase and due to your linked thread, uppercase is also required for homegear."}}
{"actor":{"display_login":"mdicke2s"}}