{"action":"created","comment":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/234246561","pull_request_review_id":175853169,"id":234246561,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDI0NjU2MQ==","diff_hunk":"@@ -231,5 +245,25 @@ public void setCreateAccountingDocumentReportService(\n     public void setParameterService(ParameterService parameterService) {\r\n         this.parameterService = parameterService;\r\n     }\r\n+    \r\n+    protected class CreateAccountingDocumentLogReport {\r\n+        private List<String> filesWithNonBusinessRuleFailures;\r\n+        private List<String> filesSuccessfullyProccessed;\r\n+        \r\n+        public CreateAccountingDocumentLogReport() {\r\n+            filesWithNonBusinessRuleFailures = new ArrayList<String>();\r\n+            filesSuccessfullyProccessed = new ArrayList<String>();\r\n+        }\r\n+\r\n+        public List<String> getFilesWithNonBusinessRuleFailures() {\r\n+            return filesWithNonBusinessRuleFailures;\r\n+        }\r\n+\r\n+        public List<String> getFilesSuccesssfullyProcessed() {\r","path":"src/main/java/edu/cornell/kfs/fp/batch/service/impl/CreateAccountingDocumentServiceImpl.java","position":83,"original_position":83,"commit_id":"709233ec3e78a6c749749a79508d32e69d95ada1","original_commit_id":"709233ec3e78a6c749749a79508d32e69d95ada1","user":{"login":"jhulslander","id":5121156,"node_id":"MDQ6VXNlcjUxMjExNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5121156?v=4","gravatar_id":"","url":"https://api.github.com/users/jhulslander","html_url":"https://github.com/jhulslander","followers_url":"https://api.github.com/users/jhulslander/followers","following_url":"https://api.github.com/users/jhulslander/following{/other_user}","gists_url":"https://api.github.com/users/jhulslander/gists{/gist_id}","starred_url":"https://api.github.com/users/jhulslander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhulslander/subscriptions","organizations_url":"https://api.github.com/users/jhulslander/orgs","repos_url":"https://api.github.com/users/jhulslander/repos","events_url":"https://api.github.com/users/jhulslander/events{/privacy}","received_events_url":"https://api.github.com/users/jhulslander/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-11-16T15:33:14Z","updated_at":"2018-11-16T15:33:14Z","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/682#discussion_r234246561","pull_request_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/234246561"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/682#discussion_r234246561"},"pull_request":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682"}},"in_reply_to_id":234243118},"pull_request":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682","id":230992574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTkyNTc0","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/682","diff_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/682.diff","patch_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/682.patch","issue_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/682","number":682,"state":"open","locked":false,"title":"KFSPTS-13518 modify create accounting document job so that it fails on non business rule failures","user":{"login":"jhulslander","id":5121156,"node_id":"MDQ6VXNlcjUxMjExNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5121156?v=4","gravatar_id":"","url":"https://api.github.com/users/jhulslander","html_url":"https://github.com/jhulslander","followers_url":"https://api.github.com/users/jhulslander/followers","following_url":"https://api.github.com/users/jhulslander/following{/other_user}","gists_url":"https://api.github.com/users/jhulslander/gists{/gist_id}","starred_url":"https://api.github.com/users/jhulslander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhulslander/subscriptions","organizations_url":"https://api.github.com/users/jhulslander/orgs","repos_url":"https://api.github.com/users/jhulslander/repos","events_url":"https://api.github.com/users/jhulslander/events{/privacy}","received_events_url":"https://api.github.com/users/jhulslander/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-14T21:46:07Z","updated_at":"2018-11-16T15:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa6f55c0688a05acfcda1a25e7e2e213e120f759","assignee":{"login":"cah292","id":5184901,"node_id":"MDQ6VXNlcjUxODQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5184901?v=4","gravatar_id":"","url":"https://api.github.com/users/cah292","html_url":"https://github.com/cah292","followers_url":"https://api.github.com/users/cah292/followers","following_url":"https://api.github.com/users/cah292/following{/other_user}","gists_url":"https://api.github.com/users/cah292/gists{/gist_id}","starred_url":"https://api.github.com/users/cah292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cah292/subscriptions","organizations_url":"https://api.github.com/users/cah292/orgs","repos_url":"https://api.github.com/users/cah292/repos","events_url":"https://api.github.com/users/cah292/events{/privacy}","received_events_url":"https://api.github.com/users/cah292/received_events","type":"User","site_admin":false},"assignees":[{"login":"cah292","id":5184901,"node_id":"MDQ6VXNlcjUxODQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5184901?v=4","gravatar_id":"","url":"https://api.github.com/users/cah292","html_url":"https://github.com/cah292","followers_url":"https://api.github.com/users/cah292/followers","following_url":"https://api.github.com/users/cah292/following{/other_user}","gists_url":"https://api.github.com/users/cah292/gists{/gist_id}","starred_url":"https://api.github.com/users/cah292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cah292/subscriptions","organizations_url":"https://api.github.com/users/cah292/orgs","repos_url":"https://api.github.com/users/cah292/repos","events_url":"https://api.github.com/users/cah292/events{/privacy}","received_events_url":"https://api.github.com/users/cah292/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682/commits","review_comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682/comments","review_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/682/comments","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/709233ec3e78a6c749749a79508d32e69d95ada1","head":{"label":"CU-CommunityApps:KFSPTS-13518","ref":"KFSPTS-13518","sha":"709233ec3e78a6c749749a79508d32e69d95ada1","user":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODgzNA==","name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","private":false,"owner":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2018-11-13T20:33:09Z","pushed_at":"2018-11-16T15:15:50Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"git@github.com:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":22487,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"CU-CommunityApps:develop","ref":"develop","sha":"8cf46c2998996b9626d019b2bf895779a404decb","user":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODgzNA==","name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","private":false,"owner":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2018-11-13T20:33:09Z","pushed_at":"2018-11-16T15:15:50Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"git@github.com:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":22487,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/682"},"issue":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/682"},"comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/709233ec3e78a6c749749a79508d32e69d95ada1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhulslander"}}