{"action":"created","comment":{"url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/comments/217799634","pull_request_review_id":155607038,"id":217799634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzc5OTYzNA==","diff_hunk":"@@ -1688,66 +1688,25 @@ void __fastcall StartSpell(int pnum, int d, int cx, int cy)\n \r\n void __fastcall FixPlrWalkTags(int pnum)\r\n {\r\n-\tint v1; // esi\r\n-\tint v2; // edx\r\n-\tint v3; // ecx\r\n-\tint v4; // eax\r\n-\tint v5; // esi\r\n-\tint v6; // edi\r\n-\tint v7; // ebx\r\n-\tint v8; // edi\r\n-\tbool v9; // zf\r\n-\tbool v10; // sf\r\n-\tunsigned char v11; // of\r\n-\tint v12; // eax\r\n-\tint v13; // [esp+8h] [ebp-Ch]\r\n-\tint v14; // [esp+Ch] [ebp-8h]\r\n-\tchar *v15; // [esp+10h] [ebp-4h]\r\n-\r\n-\tv1 = pnum;\r\n-\tif ( (unsigned int)pnum >= MAX_PLRS )\r\n+\tif ( (DWORD)pnum >= MAX_PLRS ) {\r\n \t\tTermMsg(\"FixPlrWalkTags: illegal player %d\", pnum);\r\n-\tv13 = v1 + 1;\r\n-\tv2 = -1 - v1;\r\n-\tv3 = plr[v1]._poldx;\r\n-\tv4 = plr[v1]._poldy;\r\n-\tv5 = v4 - 1;\r\n-\tif ( (unsigned char)(__OFSUB__(v4 - 1, v4 + 1) ^ 1) | (v4 - 1 == v4 + 1) )\r\n-\t{\r\n-\t\tv6 = v3 + 1;\r\n-\t\tdo\r\n-\t\t{\r\n-\t\t\tv7 = v3 - 1;\r\n-\t\t\tv14 = v3 - 1;\r\n-\t\t\tif ( v3 - 1 <= v6 )\r\n-\t\t\t{\r\n-\t\t\t\tv15 = &dPlayer[v7][v5];\r\n-\t\t\t\tdo\r\n-\t\t\t\t{\r\n-\t\t\t\t\tif ( v7 >= 0 && v7 < 112 && v5 >= 0 && v5 < 112 )\r\n-\t\t\t\t\t{\r\n-\t\t\t\t\t\tv8 = *v15;\r\n-\t\t\t\t\t\tif ( v8 == v13 || v8 == v2 )\r\n-\t\t\t\t\t\t\t*v15 = 0;\r\n-\t\t\t\t\t}\r\n-\t\t\t\t\tv15 += 112;\r\n-\t\t\t\t\tv7 = v14 + 1;\r\n-\t\t\t\t\tv6 = v3 + 1;\r\n-\t\t\t\t\tv11 = __OFSUB__(v14 + 1, v3 + 1);\r\n-\t\t\t\t\tv9 = v14 + 1 == v3 + 1;\r\n-\t\t\t\t\tv10 = v14++ - v3 < 0;\r\n-\t\t\t\t}\r\n-\t\t\t\twhile ( (unsigned char)(v10 ^ v11) | v9 );\r\n+\t}\r\n+\r\n+\tint pNext = pnum + 1;\r\n+\tint pPrev = -1 - pnum;\r","path":"Source/player.cpp","position":58,"original_position":58,"commit_id":"25762d9311e3f453ef01ba668db24739fe10e3ba","original_commit_id":"18aa3e3977741cfae28bb6705d39a591e65ecc1f","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"body":"It's a signed value, does ~ not flip the signed bit? ","created_at":"2018-09-14T18:15:55Z","updated_at":"2018-09-14T18:15:55Z","html_url":"https://github.com/diasurgical/devil-nightly/pull/137#discussion_r217799634","pull_request_url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/comments/217799634"},"html":{"href":"https://github.com/diasurgical/devil-nightly/pull/137#discussion_r217799634"},"pull_request":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137"}},"in_reply_to_id":217767141},"pull_request":{"url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137","id":215587933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTg3OTMz","html_url":"https://github.com/diasurgical/devil-nightly/pull/137","diff_url":"https://github.com/diasurgical/devil-nightly/pull/137.diff","patch_url":"https://github.com/diasurgical/devil-nightly/pull/137.patch","issue_url":"https://api.github.com/repos/diasurgical/devil-nightly/issues/137","number":137,"state":"open","locked":false,"title":"Clean up FixPlrWalkTags","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"body":"Bix exact","created_at":"2018-09-14T13:05:17Z","updated_at":"2018-09-14T18:15:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c95833795102779cc94a0ae7fa8ffa85356e86d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137/commits","review_comments_url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137/comments","review_comment_url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diasurgical/devil-nightly/issues/137/comments","statuses_url":"https://api.github.com/repos/diasurgical/devil-nightly/statuses/25762d9311e3f453ef01ba668db24739fe10e3ba","head":{"label":"AJenbo:FixPlrWalkTags","ref":"FixPlrWalkTags","sha":"25762d9311e3f453ef01ba668db24739fe10e3ba","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"repo":{"id":145381608,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzODE2MDg=","name":"devil-nightly","full_name":"AJenbo/devil-nightly","owner":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AJenbo/devil-nightly","description":"Nightly/experimental build of Devilution","fork":true,"url":"https://api.github.com/repos/AJenbo/devil-nightly","forks_url":"https://api.github.com/repos/AJenbo/devil-nightly/forks","keys_url":"https://api.github.com/repos/AJenbo/devil-nightly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AJenbo/devil-nightly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AJenbo/devil-nightly/teams","hooks_url":"https://api.github.com/repos/AJenbo/devil-nightly/hooks","issue_events_url":"https://api.github.com/repos/AJenbo/devil-nightly/issues/events{/number}","events_url":"https://api.github.com/repos/AJenbo/devil-nightly/events","assignees_url":"https://api.github.com/repos/AJenbo/devil-nightly/assignees{/user}","branches_url":"https://api.github.com/repos/AJenbo/devil-nightly/branches{/branch}","tags_url":"https://api.github.com/repos/AJenbo/devil-nightly/tags","blobs_url":"https://api.github.com/repos/AJenbo/devil-nightly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AJenbo/devil-nightly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AJenbo/devil-nightly/git/refs{/sha}","trees_url":"https://api.github.com/repos/AJenbo/devil-nightly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AJenbo/devil-nightly/statuses/{sha}","languages_url":"https://api.github.com/repos/AJenbo/devil-nightly/languages","stargazers_url":"https://api.github.com/repos/AJenbo/devil-nightly/stargazers","contributors_url":"https://api.github.com/repos/AJenbo/devil-nightly/contributors","subscribers_url":"https://api.github.com/repos/AJenbo/devil-nightly/subscribers","subscription_url":"https://api.github.com/repos/AJenbo/devil-nightly/subscription","commits_url":"https://api.github.com/repos/AJenbo/devil-nightly/commits{/sha}","git_commits_url":"https://api.github.com/repos/AJenbo/devil-nightly/git/commits{/sha}","comments_url":"https://api.github.com/repos/AJenbo/devil-nightly/comments{/number}","issue_comment_url":"https://api.github.com/repos/AJenbo/devil-nightly/issues/comments{/number}","contents_url":"https://api.github.com/repos/AJenbo/devil-nightly/contents/{+path}","compare_url":"https://api.github.com/repos/AJenbo/devil-nightly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AJenbo/devil-nightly/merges","archive_url":"https://api.github.com/repos/AJenbo/devil-nightly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AJenbo/devil-nightly/downloads","issues_url":"https://api.github.com/repos/AJenbo/devil-nightly/issues{/number}","pulls_url":"https://api.github.com/repos/AJenbo/devil-nightly/pulls{/number}","milestones_url":"https://api.github.com/repos/AJenbo/devil-nightly/milestones{/number}","notifications_url":"https://api.github.com/repos/AJenbo/devil-nightly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AJenbo/devil-nightly/labels{/name}","releases_url":"https://api.github.com/repos/AJenbo/devil-nightly/releases{/id}","deployments_url":"https://api.github.com/repos/AJenbo/devil-nightly/deployments","created_at":"2018-08-20T07:23:34Z","updated_at":"2018-09-10T02:54:13Z","pushed_at":"2018-09-14T17:25:14Z","git_url":"git://github.com/AJenbo/devil-nightly.git","ssh_url":"git@github.com:AJenbo/devil-nightly.git","clone_url":"https://github.com/AJenbo/devil-nightly.git","svn_url":"https://github.com/AJenbo/devil-nightly","homepage":null,"size":1675,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diasurgical:master","ref":"master","sha":"07844812c437757160779e4d3b77616c0d585250","user":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"repo":{"id":145343080,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzNDMwODA=","name":"devil-nightly","full_name":"diasurgical/devil-nightly","owner":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diasurgical/devil-nightly","description":"Nightly/experimental build of Devilution, mostly used for cleaning up and testing before merging into the main repo","fork":false,"url":"https://api.github.com/repos/diasurgical/devil-nightly","forks_url":"https://api.github.com/repos/diasurgical/devil-nightly/forks","keys_url":"https://api.github.com/repos/diasurgical/devil-nightly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diasurgical/devil-nightly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diasurgical/devil-nightly/teams","hooks_url":"https://api.github.com/repos/diasurgical/devil-nightly/hooks","issue_events_url":"https://api.github.com/repos/diasurgical/devil-nightly/issues/events{/number}","events_url":"https://api.github.com/repos/diasurgical/devil-nightly/events","assignees_url":"https://api.github.com/repos/diasurgical/devil-nightly/assignees{/user}","branches_url":"https://api.github.com/repos/diasurgical/devil-nightly/branches{/branch}","tags_url":"https://api.github.com/repos/diasurgical/devil-nightly/tags","blobs_url":"https://api.github.com/repos/diasurgical/devil-nightly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diasurgical/devil-nightly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diasurgical/devil-nightly/git/refs{/sha}","trees_url":"https://api.github.com/repos/diasurgical/devil-nightly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diasurgical/devil-nightly/statuses/{sha}","languages_url":"https://api.github.com/repos/diasurgical/devil-nightly/languages","stargazers_url":"https://api.github.com/repos/diasurgical/devil-nightly/stargazers","contributors_url":"https://api.github.com/repos/diasurgical/devil-nightly/contributors","subscribers_url":"https://api.github.com/repos/diasurgical/devil-nightly/subscribers","subscription_url":"https://api.github.com/repos/diasurgical/devil-nightly/subscription","commits_url":"https://api.github.com/repos/diasurgical/devil-nightly/commits{/sha}","git_commits_url":"https://api.github.com/repos/diasurgical/devil-nightly/git/commits{/sha}","comments_url":"https://api.github.com/repos/diasurgical/devil-nightly/comments{/number}","issue_comment_url":"https://api.github.com/repos/diasurgical/devil-nightly/issues/comments{/number}","contents_url":"https://api.github.com/repos/diasurgical/devil-nightly/contents/{+path}","compare_url":"https://api.github.com/repos/diasurgical/devil-nightly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diasurgical/devil-nightly/merges","archive_url":"https://api.github.com/repos/diasurgical/devil-nightly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diasurgical/devil-nightly/downloads","issues_url":"https://api.github.com/repos/diasurgical/devil-nightly/issues{/number}","pulls_url":"https://api.github.com/repos/diasurgical/devil-nightly/pulls{/number}","milestones_url":"https://api.github.com/repos/diasurgical/devil-nightly/milestones{/number}","notifications_url":"https://api.github.com/repos/diasurgical/devil-nightly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diasurgical/devil-nightly/labels{/name}","releases_url":"https://api.github.com/repos/diasurgical/devil-nightly/releases{/id}","deployments_url":"https://api.github.com/repos/diasurgical/devil-nightly/deployments","created_at":"2018-08-19T22:51:25Z","updated_at":"2018-09-14T00:34:03Z","pushed_at":"2018-09-14T17:25:15Z","git_url":"git://github.com/diasurgical/devil-nightly.git","ssh_url":"git@github.com:diasurgical/devil-nightly.git","clone_url":"https://github.com/diasurgical/devil-nightly.git","svn_url":"https://github.com/diasurgical/devil-nightly","homepage":"","size":1660,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":7,"open_issues":78,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137"},"html":{"href":"https://github.com/diasurgical/devil-nightly/pull/137"},"issue":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/issues/137"},"comments":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/diasurgical/devil-nightly/statuses/25762d9311e3f453ef01ba668db24739fe10e3ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AJenbo"}}