{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/4529","repository_url":"https://api.github.com/repos/facebook/osquery","labels_url":"https://api.github.com/repos/facebook/osquery/issues/4529/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/4529/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/4529/events","html_url":"https://github.com/facebook/osquery/pull/4529","id":331587559,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Mjc5Nzg0","number":4529,"title":"Fix up flaky fileops_tests","user":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"labels":[{"id":117911471,"node_id":"MDU6TGFiZWwxMTc5MTE0NzE=","url":"https://api.github.com/repos/facebook/osquery/labels/bug","name":"bug","color":"fc2929","default":true},{"id":118805248,"node_id":"MDU6TGFiZWwxMTg4MDUyNDg=","url":"https://api.github.com/repos/facebook/osquery/labels/build/test","name":"build/test","color":"bfd4f2","default":false},{"id":196858822,"node_id":"MDU6TGFiZWwxOTY4NTg4MjI=","url":"https://api.github.com/repos/facebook/osquery/labels/cla%20signed","name":"cla signed","color":"ededed","default":false},{"id":466935995,"node_id":"MDU6TGFiZWw0NjY5MzU5OTU=","url":"https://api.github.com/repos/facebook/osquery/labels/flaky%20test","name":"flaky test","color":"fef2c0","default":false},{"id":119503507,"node_id":"MDU6TGFiZWwxMTk1MDM1MDc=","url":"https://api.github.com/repos/facebook/osquery/labels/ready%20for%20review","name":"ready for review","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"assignees":[{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-12T13:27:53Z","updated_at":"2018-06-12T13:43:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/4529","html_url":"https://github.com/facebook/osquery/pull/4529","diff_url":"https://github.com/facebook/osquery/pull/4529.diff","patch_url":"https://github.com/facebook/osquery/pull/4529.patch"},"body":"There was used unsafe way to generate unique name for temporary file. It led for collisions sometimes, which make tests randomly failing. I have change mechanism of filename generating (used the one from the boost). And added check to make sure generated name is not exist.\r\n\r\n```\r\n$ ./build/darwin/osquery/osquery_tests --gtest_filter='FileOpsTests.*' \r\n...\r\n[==========] 14 tests from 1 test case ran. (164 ms total)\r\n[  PASSED  ] 13 tests.\r\n[  FAILED  ] 1 test, listed below:\r\n[  FAILED  ] FileOpsTests.test_append\r\n\r\n 1 FAILED TEST\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/396593770","html_url":"https://github.com/facebook/osquery/pull/4529#issuecomment-396593770","issue_url":"https://api.github.com/repos/facebook/osquery/issues/4529","id":396593770,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjU5Mzc3MA==","user":{"login":"muffins","id":1328916,"node_id":"MDQ6VXNlcjEzMjg5MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1328916?v=4","gravatar_id":"","url":"https://api.github.com/users/muffins","html_url":"https://github.com/muffins","followers_url":"https://api.github.com/users/muffins/followers","following_url":"https://api.github.com/users/muffins/following{/other_user}","gists_url":"https://api.github.com/users/muffins/gists{/gist_id}","starred_url":"https://api.github.com/users/muffins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffins/subscriptions","organizations_url":"https://api.github.com/users/muffins/orgs","repos_url":"https://api.github.com/users/muffins/repos","events_url":"https://api.github.com/users/muffins/events{/privacy}","received_events_url":"https://api.github.com/users/muffins/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T13:43:23Z","updated_at":"2018-06-12T13:43:23Z","author_association":"CONTRIBUTOR","body":"Ok to test"}}
{"actor":{"display_login":"muffins"}}