{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4700","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4700/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4700/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4700/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4700","id":292106285,"number":4700,"title":"Cleaner TileEntityItemStackRenderers","user":{"login":"Shadows-of-Fire","id":3682588,"avatar_url":"https://avatars3.githubusercontent.com/u/3682588?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadows-of-Fire","html_url":"https://github.com/Shadows-of-Fire","followers_url":"https://api.github.com/users/Shadows-of-Fire/followers","following_url":"https://api.github.com/users/Shadows-of-Fire/following{/other_user}","gists_url":"https://api.github.com/users/Shadows-of-Fire/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadows-of-Fire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadows-of-Fire/subscriptions","organizations_url":"https://api.github.com/users/Shadows-of-Fire/orgs","repos_url":"https://api.github.com/users/Shadows-of-Fire/repos","events_url":"https://api.github.com/users/Shadows-of-Fire/events{/privacy}","received_events_url":"https://api.github.com/users/Shadows-of-Fire/received_events","type":"User","site_admin":false},"labels":[{"id":507309489,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/1.12","name":"1.12","color":"c5def5","default":false},{"id":710172125,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Assigned","name":"Assigned","color":"000000","default":false},{"id":306653555,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Feature","name":"Feature","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"LexManos","id":702211,"avatar_url":"https://avatars3.githubusercontent.com/u/702211?v=4","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"assignees":[{"login":"LexManos","id":702211,"avatar_url":"https://avatars3.githubusercontent.com/u/702211?v=4","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-01-27T09:10:03Z","updated_at":"2018-03-27T20:20:21Z","closed_at":"2018-03-27T11:26:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4700","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4700","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4700.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4700.patch"},"body":"This PR seeks to clarify the current situation with `TileEntityItemStackRenderer`.  \r\n\r\nAs it stands, the current way to render a tile entity as an item like vanilla does, is a forge hook inside `TileEnitityItemStackRenderer` using a deprecated system within `ForgeHooksClient`.  As it is marked deprecated, and commented \"Will be removed as soon as possible,\" this PR will allow for its complete removal as a system in 1.13.  The only reason the PR does not remove it, is to allow it to be merged within 1.12.2's lifespan.  \r\n\r\nWhen the deprecated system is removed, the `Map<Item, TileEntityItemStackRenderer>` could be moved to `ForgeHooksClient` in its place.  Or it could be placed there now, but I felt it was better placed within `TileEntityItemStackRenderer` for now.  It can be moved if desired, but I would like to know where people would want it to be, if not where it is currently."},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/376661396","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4700#issuecomment-376661396","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4700","id":376661396,"user":{"login":"Shadows-of-Fire","id":3682588,"avatar_url":"https://avatars3.githubusercontent.com/u/3682588?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadows-of-Fire","html_url":"https://github.com/Shadows-of-Fire","followers_url":"https://api.github.com/users/Shadows-of-Fire/followers","following_url":"https://api.github.com/users/Shadows-of-Fire/following{/other_user}","gists_url":"https://api.github.com/users/Shadows-of-Fire/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadows-of-Fire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadows-of-Fire/subscriptions","organizations_url":"https://api.github.com/users/Shadows-of-Fire/orgs","repos_url":"https://api.github.com/users/Shadows-of-Fire/repos","events_url":"https://api.github.com/users/Shadows-of-Fire/events{/privacy}","received_events_url":"https://api.github.com/users/Shadows-of-Fire/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T20:20:20Z","updated_at":"2018-03-27T20:20:20Z","author_association":"CONTRIBUTOR","body":"I didn't even realize that was a thing.  My fault.  Does simply removing the null initializer resolve the crash?"}}
{"actor":{"display_login":"Shadows-of-Fire"}}