{"action":"created","comment":{"url":"https://api.github.com/repos/google/yapf/pulls/comments/244138896","pull_request_review_id":188071687,"id":244138896,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDEzODg5Ng==","diff_hunk":"@@ -29,38 +29,34 @@ fi\n ########## PIP VERSION #############\n # Verify that yapf is installed; if not, warn and exit.\n if ! command -v yapf >/dev/null; then\n-  echo 'yapf not on path; can not format. Please install yapf:'\n-  echo '    pip install yapf'\n+  printf 'yapf not on path; can not format. Please install yapf:\\n' \\\n+    '    pip install yapf'\n   exit 2\n fi\n ######### END PIP VERSION ##########\n \n ########## PIPENV VERSION ##########\n # if ! pipenv run yapf --version 2>/dev/null 2>&1; then\n-#   echo 'yapf not on path; can not format. Please install yapf:'\n-#   echo '    pipenv install yapf'\n+#   printf 'yapf not on path; can not format. Please install yapf:\\n' \\\n+#     '    pipenv install yapf'","path":"plugins/pre-commit.sh","position":36,"original_position":17,"commit_id":"81aede5a2e3ca5e3eaf7c92956c098217d3ea9b0","original_commit_id":"81aede5a2e3ca5e3eaf7c92956c098217d3ea9b0","user":{"login":"vapier","id":176950,"node_id":"MDQ6VXNlcjE3Njk1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/176950?v=4","gravatar_id":"","url":"https://api.github.com/users/vapier","html_url":"https://github.com/vapier","followers_url":"https://api.github.com/users/vapier/followers","following_url":"https://api.github.com/users/vapier/following{/other_user}","gists_url":"https://api.github.com/users/vapier/gists{/gist_id}","starred_url":"https://api.github.com/users/vapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapier/subscriptions","organizations_url":"https://api.github.com/users/vapier/orgs","repos_url":"https://api.github.com/users/vapier/repos","events_url":"https://api.github.com/users/vapier/events{/privacy}","received_events_url":"https://api.github.com/users/vapier/received_events","type":"User","site_admin":false},"body":"same here -- should just leave it as `echo`","created_at":"2018-12-27T11:53:09Z","updated_at":"2018-12-27T11:54:54Z","html_url":"https://github.com/google/yapf/pull/655#discussion_r244138896","pull_request_url":"https://api.github.com/repos/google/yapf/pulls/655","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/yapf/pulls/comments/244138896"},"html":{"href":"https://github.com/google/yapf/pull/655#discussion_r244138896"},"pull_request":{"href":"https://api.github.com/repos/google/yapf/pulls/655"}}},"pull_request":{"url":"https://api.github.com/repos/google/yapf/pulls/655","id":236155252,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTU1MjUy","html_url":"https://github.com/google/yapf/pull/655","diff_url":"https://github.com/google/yapf/pull/655.diff","patch_url":"https://github.com/google/yapf/pull/655.patch","issue_url":"https://api.github.com/repos/google/yapf/issues/655","number":655,"state":"open","locked":false,"title":"Updated `pre-commit` shell script","user":{"login":"mmphego","id":7910856,"node_id":"MDQ6VXNlcjc5MTA4NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7910856?v=4","gravatar_id":"","url":"https://api.github.com/users/mmphego","html_url":"https://github.com/mmphego","followers_url":"https://api.github.com/users/mmphego/followers","following_url":"https://api.github.com/users/mmphego/following{/other_user}","gists_url":"https://api.github.com/users/mmphego/gists{/gist_id}","starred_url":"https://api.github.com/users/mmphego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmphego/subscriptions","organizations_url":"https://api.github.com/users/mmphego/orgs","repos_url":"https://api.github.com/users/mmphego/repos","events_url":"https://api.github.com/users/mmphego/events{/privacy}","received_events_url":"https://api.github.com/users/mmphego/received_events","type":"User","site_admin":false},"body":"- Updated shebang from `#!/bin/bash` to `#!/usr/bin/env bash` for [portability](https://en.wikipedia.org/wiki/Shebang_%28Unix%29#Portability) related issues.\r\n- Double quote to prevent globbing and word splitting.\r\n- Using `command -v` instead of `which`: The reason to select the former over the latter is that it avoids a dependency on something that is outside your shell.\r\n\r\nSigned-off-by: Mpho Mphego <mpho112@gmail.com>","created_at":"2018-12-05T12:25:16Z","updated_at":"2018-12-27T11:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffeab4587ed298f620190490942af95cbccf5ca3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":192037365,"node_id":"MDU6TGFiZWwxOTIwMzczNjU=","url":"https://api.github.com/repos/google/yapf/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/yapf/pulls/655/commits","review_comments_url":"https://api.github.com/repos/google/yapf/pulls/655/comments","review_comment_url":"https://api.github.com/repos/google/yapf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/yapf/issues/655/comments","statuses_url":"https://api.github.com/repos/google/yapf/statuses/81aede5a2e3ca5e3eaf7c92956c098217d3ea9b0","head":{"label":"mmphego:master","ref":"master","sha":"81aede5a2e3ca5e3eaf7c92956c098217d3ea9b0","user":{"login":"mmphego","id":7910856,"node_id":"MDQ6VXNlcjc5MTA4NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7910856?v=4","gravatar_id":"","url":"https://api.github.com/users/mmphego","html_url":"https://github.com/mmphego","followers_url":"https://api.github.com/users/mmphego/followers","following_url":"https://api.github.com/users/mmphego/following{/other_user}","gists_url":"https://api.github.com/users/mmphego/gists{/gist_id}","starred_url":"https://api.github.com/users/mmphego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmphego/subscriptions","organizations_url":"https://api.github.com/users/mmphego/orgs","repos_url":"https://api.github.com/users/mmphego/repos","events_url":"https://api.github.com/users/mmphego/events{/privacy}","received_events_url":"https://api.github.com/users/mmphego/received_events","type":"User","site_admin":false},"repo":{"id":160511249,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MTEyNDk=","name":"yapf","full_name":"mmphego/yapf","private":false,"owner":{"login":"mmphego","id":7910856,"node_id":"MDQ6VXNlcjc5MTA4NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7910856?v=4","gravatar_id":"","url":"https://api.github.com/users/mmphego","html_url":"https://github.com/mmphego","followers_url":"https://api.github.com/users/mmphego/followers","following_url":"https://api.github.com/users/mmphego/following{/other_user}","gists_url":"https://api.github.com/users/mmphego/gists{/gist_id}","starred_url":"https://api.github.com/users/mmphego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmphego/subscriptions","organizations_url":"https://api.github.com/users/mmphego/orgs","repos_url":"https://api.github.com/users/mmphego/repos","events_url":"https://api.github.com/users/mmphego/events{/privacy}","received_events_url":"https://api.github.com/users/mmphego/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmphego/yapf","description":"A formatter for Python files","fork":true,"url":"https://api.github.com/repos/mmphego/yapf","forks_url":"https://api.github.com/repos/mmphego/yapf/forks","keys_url":"https://api.github.com/repos/mmphego/yapf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmphego/yapf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmphego/yapf/teams","hooks_url":"https://api.github.com/repos/mmphego/yapf/hooks","issue_events_url":"https://api.github.com/repos/mmphego/yapf/issues/events{/number}","events_url":"https://api.github.com/repos/mmphego/yapf/events","assignees_url":"https://api.github.com/repos/mmphego/yapf/assignees{/user}","branches_url":"https://api.github.com/repos/mmphego/yapf/branches{/branch}","tags_url":"https://api.github.com/repos/mmphego/yapf/tags","blobs_url":"https://api.github.com/repos/mmphego/yapf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmphego/yapf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmphego/yapf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmphego/yapf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmphego/yapf/statuses/{sha}","languages_url":"https://api.github.com/repos/mmphego/yapf/languages","stargazers_url":"https://api.github.com/repos/mmphego/yapf/stargazers","contributors_url":"https://api.github.com/repos/mmphego/yapf/contributors","subscribers_url":"https://api.github.com/repos/mmphego/yapf/subscribers","subscription_url":"https://api.github.com/repos/mmphego/yapf/subscription","commits_url":"https://api.github.com/repos/mmphego/yapf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmphego/yapf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmphego/yapf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmphego/yapf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmphego/yapf/contents/{+path}","compare_url":"https://api.github.com/repos/mmphego/yapf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmphego/yapf/merges","archive_url":"https://api.github.com/repos/mmphego/yapf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmphego/yapf/downloads","issues_url":"https://api.github.com/repos/mmphego/yapf/issues{/number}","pulls_url":"https://api.github.com/repos/mmphego/yapf/pulls{/number}","milestones_url":"https://api.github.com/repos/mmphego/yapf/milestones{/number}","notifications_url":"https://api.github.com/repos/mmphego/yapf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmphego/yapf/labels{/name}","releases_url":"https://api.github.com/repos/mmphego/yapf/releases{/id}","deployments_url":"https://api.github.com/repos/mmphego/yapf/deployments","created_at":"2018-12-05T11:55:38Z","updated_at":"2018-12-25T11:54:24Z","pushed_at":"2018-12-25T11:54:21Z","git_url":"git://github.com/mmphego/yapf.git","ssh_url":"git@github.com:mmphego/yapf.git","clone_url":"https://github.com/mmphego/yapf.git","svn_url":"https://github.com/mmphego/yapf","homepage":"","size":1915,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"f672d7b1073c29054cfcc9c32f344c948e8cf1bf","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":32476524,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ3NjUyNA==","name":"yapf","full_name":"google/yapf","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/yapf","description":"A formatter for Python files","fork":false,"url":"https://api.github.com/repos/google/yapf","forks_url":"https://api.github.com/repos/google/yapf/forks","keys_url":"https://api.github.com/repos/google/yapf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/yapf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/yapf/teams","hooks_url":"https://api.github.com/repos/google/yapf/hooks","issue_events_url":"https://api.github.com/repos/google/yapf/issues/events{/number}","events_url":"https://api.github.com/repos/google/yapf/events","assignees_url":"https://api.github.com/repos/google/yapf/assignees{/user}","branches_url":"https://api.github.com/repos/google/yapf/branches{/branch}","tags_url":"https://api.github.com/repos/google/yapf/tags","blobs_url":"https://api.github.com/repos/google/yapf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/yapf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/yapf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/yapf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/yapf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/yapf/languages","stargazers_url":"https://api.github.com/repos/google/yapf/stargazers","contributors_url":"https://api.github.com/repos/google/yapf/contributors","subscribers_url":"https://api.github.com/repos/google/yapf/subscribers","subscription_url":"https://api.github.com/repos/google/yapf/subscription","commits_url":"https://api.github.com/repos/google/yapf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/yapf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/yapf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/yapf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/yapf/contents/{+path}","compare_url":"https://api.github.com/repos/google/yapf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/yapf/merges","archive_url":"https://api.github.com/repos/google/yapf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/yapf/downloads","issues_url":"https://api.github.com/repos/google/yapf/issues{/number}","pulls_url":"https://api.github.com/repos/google/yapf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/yapf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/yapf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/yapf/labels{/name}","releases_url":"https://api.github.com/repos/google/yapf/releases{/id}","deployments_url":"https://api.github.com/repos/google/yapf/deployments","created_at":"2015-03-18T18:22:31Z","updated_at":"2018-12-27T11:11:42Z","pushed_at":"2018-12-25T11:54:22Z","git_url":"git://github.com/google/yapf.git","ssh_url":"git@github.com:google/yapf.git","clone_url":"https://github.com/google/yapf.git","svn_url":"https://github.com/google/yapf","homepage":"","size":1912,"stargazers_count":8398,"watchers_count":8398,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":207,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":569,"open_issues":207,"watchers":8398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/yapf/pulls/655"},"html":{"href":"https://github.com/google/yapf/pull/655"},"issue":{"href":"https://api.github.com/repos/google/yapf/issues/655"},"comments":{"href":"https://api.github.com/repos/google/yapf/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/google/yapf/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/google/yapf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/yapf/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/google/yapf/statuses/81aede5a2e3ca5e3eaf7c92956c098217d3ea9b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"vapier"}}