{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/965","repository_url":"https://api.github.com/repos/tensorflow/tensor2tensor","labels_url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/965/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/965/comments","events_url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/965/events","html_url":"https://github.com/tensorflow/tensor2tensor/pull/965","id":346579082,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDA4OTg5","number":965,"title":"changed beam decoder stopping condition","user":{"login":"mirkobronzi","id":7871968,"node_id":"MDQ6VXNlcjc4NzE5Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/7871968?v=4","gravatar_id":"","url":"https://api.github.com/users/mirkobronzi","html_url":"https://github.com/mirkobronzi","followers_url":"https://api.github.com/users/mirkobronzi/followers","following_url":"https://api.github.com/users/mirkobronzi/following{/other_user}","gists_url":"https://api.github.com/users/mirkobronzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mirkobronzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirkobronzi/subscriptions","organizations_url":"https://api.github.com/users/mirkobronzi/orgs","repos_url":"https://api.github.com/users/mirkobronzi/repos","events_url":"https://api.github.com/users/mirkobronzi/events{/privacy}","received_events_url":"https://api.github.com/users/mirkobronzi/received_events","type":"User","site_admin":false},"labels":[{"id":946016266,"node_id":"MDU6TGFiZWw5NDYwMTYyNjY=","url":"https://api.github.com/repos/tensorflow/tensor2tensor/labels/cla:%20yes","name":"cla: yes","color":"01c158","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-01T12:30:40Z","updated_at":"2018-11-15T22:00:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensor2tensor/pulls/965","html_url":"https://github.com/tensorflow/tensor2tensor/pull/965","diff_url":"https://github.com/tensorflow/tensor2tensor/pull/965.diff","patch_url":"https://github.com/tensorflow/tensor2tensor/pull/965.patch"},"body":"stopping condition of the beam decoder now works as follows:\r\n\r\n-- case return only the first beam (stop_early=True): it will stop when the first beam is 'unbeatable' by the other alive beams. (basically the previous behavior)\r\n\r\n-- case return all beams (stop_early=False): it will stop when all the first N beams are 'unbeatable' by the other alive beams.\r\nNote that checking that the last beam (in the top N) is unbeatable implies that all the top N beams are unbeatable as well.\r\n\r\nNote w.r.t. the test changes: I duplicated testNotGreedyBeamTwo so that there is now a version with stop_early=True and one with stop_early=False. The first checks only the first beam, the latter will check all the beams.\r\n\r\nOther two tests changed as well: they were checking the beam output length (checking it was equal to INPUT_LENGTH + decode_length) - disabled these checks given that this is not true anymore."},"comment":{"url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/comments/439205767","html_url":"https://github.com/tensorflow/tensor2tensor/pull/965#issuecomment-439205767","issue_url":"https://api.github.com/repos/tensorflow/tensor2tensor/issues/965","id":439205767,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTIwNTc2Nw==","user":{"login":"afrozenator","id":1131030,"node_id":"MDQ6VXNlcjExMzEwMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1131030?v=4","gravatar_id":"","url":"https://api.github.com/users/afrozenator","html_url":"https://github.com/afrozenator","followers_url":"https://api.github.com/users/afrozenator/followers","following_url":"https://api.github.com/users/afrozenator/following{/other_user}","gists_url":"https://api.github.com/users/afrozenator/gists{/gist_id}","starred_url":"https://api.github.com/users/afrozenator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrozenator/subscriptions","organizations_url":"https://api.github.com/users/afrozenator/orgs","repos_url":"https://api.github.com/users/afrozenator/repos","events_url":"https://api.github.com/users/afrozenator/events{/privacy}","received_events_url":"https://api.github.com/users/afrozenator/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T22:00:05Z","updated_at":"2018-11-15T22:00:05Z","author_association":"COLLABORATOR","body":"Many thanks @mirkobronzi -- this is awesome!"}}
{"actor":{"display_login":"afrozenator"}}