{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-ui/pulls/comments/178449018","pull_request_review_id":108509893,"id":178449018,"diff_hunk":"@@ -1,111 +1,58 @@\n import * as React from 'react';\n import style from './Checkbox.st.css';\n-import {bool, func, string, number, array, node} from 'prop-types';\n+import {noop} from 'lodash';\n \n export interface OnChangeEvent extends React.ChangeEvent<HTMLInputElement> {\n   checked: boolean;\n }\n \n-export interface OnClickEvent extends React.MouseEvent<HTMLDivElement> {\n-  checked: boolean;\n-}\n-\n-export interface OnKeydownEvent extends React.KeyboardEvent<HTMLDivElement> {\n-  checked: boolean;\n-}\n-\n-export interface CheckboxProps {\n-  checked?: boolean;\n-  disabled?: boolean;\n-  onChange?: React.EventHandler<OnChangeEvent | OnClickEvent | OnKeydownEvent>;\n-  id?: string;\n-  tabIndex?: number;\n-  checkedIcon?: JSX.Element;\n+export interface CheckboxProps extends React.InputHTMLAttributes<HTMLElement> {\n+  /** The onChange function will be called with a new checked value */\n+  onChange?: React.EventHandler<OnChangeEvent>;","path":"packages/wix-ui-core/src/components/Checkbox/Checkbox.tsx","position":27,"original_position":27,"commit_id":"69468c197df6420c03f33bd1ee5376f0d7d0b6fa","original_commit_id":"69468c197df6420c03f33bd1ee5376f0d7d0b6fa","user":{"login":"JoMarton","id":18241740,"avatar_url":"https://avatars1.githubusercontent.com/u/18241740?v=4","gravatar_id":"","url":"https://api.github.com/users/JoMarton","html_url":"https://github.com/JoMarton","followers_url":"https://api.github.com/users/JoMarton/followers","following_url":"https://api.github.com/users/JoMarton/following{/other_user}","gists_url":"https://api.github.com/users/JoMarton/gists{/gist_id}","starred_url":"https://api.github.com/users/JoMarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoMarton/subscriptions","organizations_url":"https://api.github.com/users/JoMarton/orgs","repos_url":"https://api.github.com/users/JoMarton/repos","events_url":"https://api.github.com/users/JoMarton/events{/privacy}","received_events_url":"https://api.github.com/users/JoMarton/received_events","type":"User","site_admin":false},"body":"ah ok sorry didn't notice that","created_at":"2018-04-01T06:02:48Z","updated_at":"2018-04-01T06:02:48Z","html_url":"https://github.com/wix/wix-ui/pull/358#discussion_r178449018","pull_request_url":"https://api.github.com/repos/wix/wix-ui/pulls/358","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/comments/178449018"},"html":{"href":"https://github.com/wix/wix-ui/pull/358#discussion_r178449018"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/358"}},"in_reply_to_id":178040620},"pull_request":{"url":"https://api.github.com/repos/wix/wix-ui/pulls/358","id":178309139,"html_url":"https://github.com/wix/wix-ui/pull/358","diff_url":"https://github.com/wix/wix-ui/pull/358.diff","patch_url":"https://github.com/wix/wix-ui/pull/358.patch","issue_url":"https://api.github.com/repos/wix/wix-ui/issues/358","number":358,"state":"open","locked":false,"title":"<Checkbox /> - Fix types and implementation","user":{"login":"danielstro","id":23208573,"avatar_url":"https://avatars1.githubusercontent.com/u/23208573?v=4","gravatar_id":"","url":"https://api.github.com/users/danielstro","html_url":"https://github.com/danielstro","followers_url":"https://api.github.com/users/danielstro/followers","following_url":"https://api.github.com/users/danielstro/following{/other_user}","gists_url":"https://api.github.com/users/danielstro/gists{/gist_id}","starred_url":"https://api.github.com/users/danielstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielstro/subscriptions","organizations_url":"https://api.github.com/users/danielstro/orgs","repos_url":"https://api.github.com/users/danielstro/repos","events_url":"https://api.github.com/users/danielstro/events{/privacy}","received_events_url":"https://api.github.com/users/danielstro/received_events","type":"User","site_admin":false},"body":"Part of issue #259 \r\n- Completely changed the checkbox types to extend native input types.\r\n- Removed proptypes, it is not needed now because checkbox doesn't have a storybook demo.\r\n- Changed the inner implementation to use a label instead of a div\r\n- Had to change the driver to fit the new implementation\r\n- Added more tests to the e2e","created_at":"2018-03-29T12:07:38Z","updated_at":"2018-04-01T06:02:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f915965d60b2c5108957f4f4f545ed963bbb08ad","assignee":{"login":"danielstro","id":23208573,"avatar_url":"https://avatars1.githubusercontent.com/u/23208573?v=4","gravatar_id":"","url":"https://api.github.com/users/danielstro","html_url":"https://github.com/danielstro","followers_url":"https://api.github.com/users/danielstro/followers","following_url":"https://api.github.com/users/danielstro/following{/other_user}","gists_url":"https://api.github.com/users/danielstro/gists{/gist_id}","starred_url":"https://api.github.com/users/danielstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielstro/subscriptions","organizations_url":"https://api.github.com/users/danielstro/orgs","repos_url":"https://api.github.com/users/danielstro/repos","events_url":"https://api.github.com/users/danielstro/events{/privacy}","received_events_url":"https://api.github.com/users/danielstro/received_events","type":"User","site_admin":false},"assignees":[{"login":"danielstro","id":23208573,"avatar_url":"https://avatars1.githubusercontent.com/u/23208573?v=4","gravatar_id":"","url":"https://api.github.com/users/danielstro","html_url":"https://github.com/danielstro","followers_url":"https://api.github.com/users/danielstro/followers","following_url":"https://api.github.com/users/danielstro/following{/other_user}","gists_url":"https://api.github.com/users/danielstro/gists{/gist_id}","starred_url":"https://api.github.com/users/danielstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielstro/subscriptions","organizations_url":"https://api.github.com/users/danielstro/orgs","repos_url":"https://api.github.com/users/danielstro/repos","events_url":"https://api.github.com/users/danielstro/events{/privacy}","received_events_url":"https://api.github.com/users/danielstro/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-ui/pulls/358/commits","review_comments_url":"https://api.github.com/repos/wix/wix-ui/pulls/358/comments","review_comment_url":"https://api.github.com/repos/wix/wix-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-ui/issues/358/comments","statuses_url":"https://api.github.com/repos/wix/wix-ui/statuses/69468c197df6420c03f33bd1ee5376f0d7d0b6fa","head":{"label":"wix:danielstr/checkbox-types","ref":"danielstr/checkbox-types","sha":"69468c197df6420c03f33bd1ee5376f0d7d0b6fa","user":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":102359519,"name":"wix-ui","full_name":"wix/wix-ui","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-ui","description":null,"fork":false,"url":"https://api.github.com/repos/wix/wix-ui","forks_url":"https://api.github.com/repos/wix/wix-ui/forks","keys_url":"https://api.github.com/repos/wix/wix-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-ui/teams","hooks_url":"https://api.github.com/repos/wix/wix-ui/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-ui/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-ui/events","assignees_url":"https://api.github.com/repos/wix/wix-ui/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-ui/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-ui/tags","blobs_url":"https://api.github.com/repos/wix/wix-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-ui/languages","stargazers_url":"https://api.github.com/repos/wix/wix-ui/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-ui/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-ui/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-ui/subscription","commits_url":"https://api.github.com/repos/wix/wix-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-ui/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-ui/merges","archive_url":"https://api.github.com/repos/wix/wix-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-ui/downloads","issues_url":"https://api.github.com/repos/wix/wix-ui/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-ui/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-ui/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-ui/deployments","created_at":"2017-09-04T12:34:56Z","updated_at":"2018-03-30T10:14:23Z","pushed_at":"2018-04-01T02:30:19Z","git_url":"git://github.com/wix/wix-ui.git","ssh_url":"git@github.com:wix/wix-ui.git","clone_url":"https://github.com/wix/wix-ui.git","svn_url":"https://github.com/wix/wix-ui","homepage":null,"size":3089,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":8,"open_issues":32,"watchers":18,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"11793cd8c204194578674258d4da756ab9e893d1","user":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":102359519,"name":"wix-ui","full_name":"wix/wix-ui","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-ui","description":null,"fork":false,"url":"https://api.github.com/repos/wix/wix-ui","forks_url":"https://api.github.com/repos/wix/wix-ui/forks","keys_url":"https://api.github.com/repos/wix/wix-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-ui/teams","hooks_url":"https://api.github.com/repos/wix/wix-ui/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-ui/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-ui/events","assignees_url":"https://api.github.com/repos/wix/wix-ui/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-ui/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-ui/tags","blobs_url":"https://api.github.com/repos/wix/wix-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-ui/languages","stargazers_url":"https://api.github.com/repos/wix/wix-ui/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-ui/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-ui/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-ui/subscription","commits_url":"https://api.github.com/repos/wix/wix-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-ui/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-ui/merges","archive_url":"https://api.github.com/repos/wix/wix-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-ui/downloads","issues_url":"https://api.github.com/repos/wix/wix-ui/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-ui/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-ui/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-ui/deployments","created_at":"2017-09-04T12:34:56Z","updated_at":"2018-03-30T10:14:23Z","pushed_at":"2018-04-01T02:30:19Z","git_url":"git://github.com/wix/wix-ui.git","ssh_url":"git@github.com:wix/wix-ui.git","clone_url":"https://github.com/wix/wix-ui.git","svn_url":"https://github.com/wix/wix-ui","homepage":null,"size":3089,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":8,"open_issues":32,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/358"},"html":{"href":"https://github.com/wix/wix-ui/pull/358"},"issue":{"href":"https://api.github.com/repos/wix/wix-ui/issues/358"},"comments":{"href":"https://api.github.com/repos/wix/wix-ui/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-ui/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-ui/statuses/69468c197df6420c03f33bd1ee5376f0d7d0b6fa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JoMarton"}}