{"action":"created","comment":{"url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments/170812927","pull_request_review_id":99555564,"id":170812927,"diff_hunk":"@@ -31,11 +48,20 @@\n     - jenkins/master\n \n - name: Wait for Jenkins to come up\n-  shell: curl --head --silent http://localhost:8080/cli/\n+  wait_for:\n+    host: '{{ ansible_default_ipv4.address }}'\n+    port: 8080\n+    delay: 5\n+    timeout: 300\n+  tags:\n+    - jenkins/master\n+\n+- name: Wait for Jenkins UI to come up\n+  shell: curl --head --silent http://{{ ansible_default_ipv4.address }}:8080/cli/","path":"provisions/roles/jenkins/master/tasks/main.yml","position":35,"original_position":58,"commit_id":"46e8a4b94cc6bf9a835c2128ce7fd61194413291","original_commit_id":"46e8a4b94cc6bf9a835c2128ce7fd61194413291","user":{"login":"bamachrn","id":8213617,"avatar_url":"https://avatars0.githubusercontent.com/u/8213617?v=4","gravatar_id":"","url":"https://api.github.com/users/bamachrn","html_url":"https://github.com/bamachrn","followers_url":"https://api.github.com/users/bamachrn/followers","following_url":"https://api.github.com/users/bamachrn/following{/other_user}","gists_url":"https://api.github.com/users/bamachrn/gists{/gist_id}","starred_url":"https://api.github.com/users/bamachrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamachrn/subscriptions","organizations_url":"https://api.github.com/users/bamachrn/orgs","repos_url":"https://api.github.com/users/bamachrn/repos","events_url":"https://api.github.com/users/bamachrn/events{/privacy}","received_events_url":"https://api.github.com/users/bamachrn/received_events","type":"User","site_admin":false},"body":":+1: :100: ","created_at":"2018-02-27T04:32:27Z","updated_at":"2018-02-27T04:52:33Z","html_url":"https://github.com/CentOS/container-pipeline-service/pull/491#discussion_r170812927","pull_request_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments/170812927"},"html":{"href":"https://github.com/CentOS/container-pipeline-service/pull/491#discussion_r170812927"},"pull_request":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491","id":171402934,"html_url":"https://github.com/CentOS/container-pipeline-service/pull/491","diff_url":"https://github.com/CentOS/container-pipeline-service/pull/491.diff","patch_url":"https://github.com/CentOS/container-pipeline-service/pull/491.patch","issue_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/491","number":491,"state":"open","locked":false,"title":"Improves deployment of Jenkins via Ansible","user":{"login":"cdrage","id":6422176,"avatar_url":"https://avatars1.githubusercontent.com/u/6422176?v=4","gravatar_id":"","url":"https://api.github.com/users/cdrage","html_url":"https://github.com/cdrage","followers_url":"https://api.github.com/users/cdrage/followers","following_url":"https://api.github.com/users/cdrage/following{/other_user}","gists_url":"https://api.github.com/users/cdrage/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrage/subscriptions","organizations_url":"https://api.github.com/users/cdrage/orgs","repos_url":"https://api.github.com/users/cdrage/repos","events_url":"https://api.github.com/users/cdrage/events{/privacy}","received_events_url":"https://api.github.com/users/cdrage/received_events","type":"User","site_admin":false},"body":"This PR:\n\n - Stops the Jenkins master (via systemd) BEFORE configuration takes\n place. There are minor issues where if the configuration is overriden\n while Jenkins is running, configuration settings are potentially\n overridden. After configuration changes are completed, Jenkins is\n started again.\n  - Uses ansible's built-in `wait_for` for port 8080 to come up, then\n  checks to see if the UI has come up. This reduces the delay duration\n  as well as makes it more intuitive (wait for port to come up, then\n  curl it)\n  - Reduces delays (faster deployment)\n  - Makes sure that a shell is created for Jenkins slave user (had\n  issues with master+slave communication due to user being directed to\n  /run/nologin for some reason)","created_at":"2018-02-26T15:15:34Z","updated_at":"2018-02-27T04:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eca233f5ff60a3424147adff200ccaf23d7c329","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491/commits","review_comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491/comments","review_comment_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/491/comments","statuses_url":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/46e8a4b94cc6bf9a835c2128ce7fd61194413291","head":{"label":"cdrage:improve-jenkins-deployment","ref":"improve-jenkins-deployment","sha":"46e8a4b94cc6bf9a835c2128ce7fd61194413291","user":{"login":"cdrage","id":6422176,"avatar_url":"https://avatars1.githubusercontent.com/u/6422176?v=4","gravatar_id":"","url":"https://api.github.com/users/cdrage","html_url":"https://github.com/cdrage","followers_url":"https://api.github.com/users/cdrage/followers","following_url":"https://api.github.com/users/cdrage/following{/other_user}","gists_url":"https://api.github.com/users/cdrage/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrage/subscriptions","organizations_url":"https://api.github.com/users/cdrage/orgs","repos_url":"https://api.github.com/users/cdrage/repos","events_url":"https://api.github.com/users/cdrage/events{/privacy}","received_events_url":"https://api.github.com/users/cdrage/received_events","type":"User","site_admin":false},"repo":{"id":116400300,"name":"container-pipeline-service","full_name":"cdrage/container-pipeline-service","owner":{"login":"cdrage","id":6422176,"avatar_url":"https://avatars1.githubusercontent.com/u/6422176?v=4","gravatar_id":"","url":"https://api.github.com/users/cdrage","html_url":"https://github.com/cdrage","followers_url":"https://api.github.com/users/cdrage/followers","following_url":"https://api.github.com/users/cdrage/following{/other_user}","gists_url":"https://api.github.com/users/cdrage/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrage/subscriptions","organizations_url":"https://api.github.com/users/cdrage/orgs","repos_url":"https://api.github.com/users/cdrage/repos","events_url":"https://api.github.com/users/cdrage/events{/privacy}","received_events_url":"https://api.github.com/users/cdrage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdrage/container-pipeline-service","description":"Code, infrastructure and deployment backend for the CentOS Container Pipeline","fork":true,"url":"https://api.github.com/repos/cdrage/container-pipeline-service","forks_url":"https://api.github.com/repos/cdrage/container-pipeline-service/forks","keys_url":"https://api.github.com/repos/cdrage/container-pipeline-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdrage/container-pipeline-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdrage/container-pipeline-service/teams","hooks_url":"https://api.github.com/repos/cdrage/container-pipeline-service/hooks","issue_events_url":"https://api.github.com/repos/cdrage/container-pipeline-service/issues/events{/number}","events_url":"https://api.github.com/repos/cdrage/container-pipeline-service/events","assignees_url":"https://api.github.com/repos/cdrage/container-pipeline-service/assignees{/user}","branches_url":"https://api.github.com/repos/cdrage/container-pipeline-service/branches{/branch}","tags_url":"https://api.github.com/repos/cdrage/container-pipeline-service/tags","blobs_url":"https://api.github.com/repos/cdrage/container-pipeline-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdrage/container-pipeline-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdrage/container-pipeline-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdrage/container-pipeline-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdrage/container-pipeline-service/statuses/{sha}","languages_url":"https://api.github.com/repos/cdrage/container-pipeline-service/languages","stargazers_url":"https://api.github.com/repos/cdrage/container-pipeline-service/stargazers","contributors_url":"https://api.github.com/repos/cdrage/container-pipeline-service/contributors","subscribers_url":"https://api.github.com/repos/cdrage/container-pipeline-service/subscribers","subscription_url":"https://api.github.com/repos/cdrage/container-pipeline-service/subscription","commits_url":"https://api.github.com/repos/cdrage/container-pipeline-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdrage/container-pipeline-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdrage/container-pipeline-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdrage/container-pipeline-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdrage/container-pipeline-service/contents/{+path}","compare_url":"https://api.github.com/repos/cdrage/container-pipeline-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdrage/container-pipeline-service/merges","archive_url":"https://api.github.com/repos/cdrage/container-pipeline-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdrage/container-pipeline-service/downloads","issues_url":"https://api.github.com/repos/cdrage/container-pipeline-service/issues{/number}","pulls_url":"https://api.github.com/repos/cdrage/container-pipeline-service/pulls{/number}","milestones_url":"https://api.github.com/repos/cdrage/container-pipeline-service/milestones{/number}","notifications_url":"https://api.github.com/repos/cdrage/container-pipeline-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdrage/container-pipeline-service/labels{/name}","releases_url":"https://api.github.com/repos/cdrage/container-pipeline-service/releases{/id}","deployments_url":"https://api.github.com/repos/cdrage/container-pipeline-service/deployments","created_at":"2018-01-05T15:41:33Z","updated_at":"2018-01-05T15:41:35Z","pushed_at":"2018-02-26T20:11:55Z","git_url":"git://github.com/cdrage/container-pipeline-service.git","ssh_url":"git@github.com:cdrage/container-pipeline-service.git","clone_url":"https://github.com/cdrage/container-pipeline-service.git","svn_url":"https://github.com/cdrage/container-pipeline-service","homepage":null,"size":1754,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CentOS:master","ref":"master","sha":"26e1a388ec94ea99acc0d62b975152ba9c348b72","user":{"login":"CentOS","id":79192,"avatar_url":"https://avatars0.githubusercontent.com/u/79192?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS","html_url":"https://github.com/CentOS","followers_url":"https://api.github.com/users/CentOS/followers","following_url":"https://api.github.com/users/CentOS/following{/other_user}","gists_url":"https://api.github.com/users/CentOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS/subscriptions","organizations_url":"https://api.github.com/users/CentOS/orgs","repos_url":"https://api.github.com/users/CentOS/repos","events_url":"https://api.github.com/users/CentOS/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS/received_events","type":"Organization","site_admin":false},"repo":{"id":63242015,"name":"container-pipeline-service","full_name":"CentOS/container-pipeline-service","owner":{"login":"CentOS","id":79192,"avatar_url":"https://avatars0.githubusercontent.com/u/79192?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS","html_url":"https://github.com/CentOS","followers_url":"https://api.github.com/users/CentOS/followers","following_url":"https://api.github.com/users/CentOS/following{/other_user}","gists_url":"https://api.github.com/users/CentOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS/subscriptions","organizations_url":"https://api.github.com/users/CentOS/orgs","repos_url":"https://api.github.com/users/CentOS/repos","events_url":"https://api.github.com/users/CentOS/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CentOS/container-pipeline-service","description":"Code, infrastructure and deployment backend for the CentOS Container Pipeline","fork":false,"url":"https://api.github.com/repos/CentOS/container-pipeline-service","forks_url":"https://api.github.com/repos/CentOS/container-pipeline-service/forks","keys_url":"https://api.github.com/repos/CentOS/container-pipeline-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CentOS/container-pipeline-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CentOS/container-pipeline-service/teams","hooks_url":"https://api.github.com/repos/CentOS/container-pipeline-service/hooks","issue_events_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/events{/number}","events_url":"https://api.github.com/repos/CentOS/container-pipeline-service/events","assignees_url":"https://api.github.com/repos/CentOS/container-pipeline-service/assignees{/user}","branches_url":"https://api.github.com/repos/CentOS/container-pipeline-service/branches{/branch}","tags_url":"https://api.github.com/repos/CentOS/container-pipeline-service/tags","blobs_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/{sha}","languages_url":"https://api.github.com/repos/CentOS/container-pipeline-service/languages","stargazers_url":"https://api.github.com/repos/CentOS/container-pipeline-service/stargazers","contributors_url":"https://api.github.com/repos/CentOS/container-pipeline-service/contributors","subscribers_url":"https://api.github.com/repos/CentOS/container-pipeline-service/subscribers","subscription_url":"https://api.github.com/repos/CentOS/container-pipeline-service/subscription","commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/CentOS/container-pipeline-service/contents/{+path}","compare_url":"https://api.github.com/repos/CentOS/container-pipeline-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CentOS/container-pipeline-service/merges","archive_url":"https://api.github.com/repos/CentOS/container-pipeline-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CentOS/container-pipeline-service/downloads","issues_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues{/number}","pulls_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls{/number}","milestones_url":"https://api.github.com/repos/CentOS/container-pipeline-service/milestones{/number}","notifications_url":"https://api.github.com/repos/CentOS/container-pipeline-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CentOS/container-pipeline-service/labels{/name}","releases_url":"https://api.github.com/repos/CentOS/container-pipeline-service/releases{/id}","deployments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/deployments","created_at":"2016-07-13T11:55:19Z","updated_at":"2018-02-11T07:50:39Z","pushed_at":"2018-02-26T15:35:14Z","git_url":"git://github.com/CentOS/container-pipeline-service.git","ssh_url":"git@github.com:CentOS/container-pipeline-service.git","clone_url":"https://github.com/CentOS/container-pipeline-service.git","svn_url":"https://github.com/CentOS/container-pipeline-service","homepage":null,"size":1745,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":76,"license":null,"forks":16,"open_issues":76,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491"},"html":{"href":"https://github.com/CentOS/container-pipeline-service/pull/491"},"issue":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/491"},"comments":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/46e8a4b94cc6bf9a835c2128ce7fd61194413291"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bamachrn"}}