{"action":"closed","number":422,"pull_request":{"url":"https://api.github.com/repos/nos/client/pulls/422","id":207029713,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDI5NzEz","html_url":"https://github.com/nos/client/pull/422","diff_url":"https://github.com/nos/client/pull/422.diff","patch_url":"https://github.com/nos/client/pull/422.patch","issue_url":"https://api.github.com/repos/nos/client/issues/422","number":422,"state":"closed","locked":false,"title":"chore(register): fixed registration form","user":{"login":"mhuggins","id":169093,"node_id":"MDQ6VXNlcjE2OTA5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169093?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis fixes the registration form:\r\n\r\n* submit was broken\r\n* loading state wasn't being applied\r\n* copy icon for account details wasn't displaying\r\n\r\n## Motivation and Context\r\nNeed registration to work, it's a core feature!\r\n\r\n## How Has This Been Tested?\r\nSmoke testing.\r\n\r\n## Types of changes\r\n- [x] Chore (tests, refactors, and fixes)\r\n- [ ] New feature (adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n- [x] I have read the **[CONTRIBUTING](./CONTRIBUTING.md)** guidelines and confirm that my code follows the code style of this project.\r\n- [ ] Tests for the changes have been added (for bug fixes/features)\r\n\r\n#### Documentation\r\n- [ ] Docs need to be added/updated (for bug fixes/features)\r\n\r\n## Closing issues\r\nFixes #421","created_at":"2018-08-08T14:35:15Z","updated_at":"2018-08-08T15:20:45Z","closed_at":"2018-08-08T15:20:45Z","merged_at":"2018-08-08T15:20:45Z","merge_commit_sha":"7685c4ecd30076cc5a6b9139c7a2dfa9e3df9099","assignee":null,"assignees":[],"requested_reviewers":[{"login":"deanpress","id":31391056,"node_id":"MDQ6VXNlcjMxMzkxMDU2","avatar_url":"https://avatars1.githubusercontent.com/u/31391056?v=4","gravatar_id":"","url":"https://api.github.com/users/deanpress","html_url":"https://github.com/deanpress","followers_url":"https://api.github.com/users/deanpress/followers","following_url":"https://api.github.com/users/deanpress/following{/other_user}","gists_url":"https://api.github.com/users/deanpress/gists{/gist_id}","starred_url":"https://api.github.com/users/deanpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanpress/subscriptions","organizations_url":"https://api.github.com/users/deanpress/orgs","repos_url":"https://api.github.com/users/deanpress/repos","events_url":"https://api.github.com/users/deanpress/events{/privacy}","received_events_url":"https://api.github.com/users/deanpress/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":934113422,"node_id":"MDU6TGFiZWw5MzQxMTM0MjI=","url":"https://api.github.com/repos/nos/client/labels/PR:%20needs%20review","name":"PR: needs review","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nos/client/pulls/422/commits","review_comments_url":"https://api.github.com/repos/nos/client/pulls/422/comments","review_comment_url":"https://api.github.com/repos/nos/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nos/client/issues/422/comments","statuses_url":"https://api.github.com/repos/nos/client/statuses/ecf804087eaf610a9c5c77f82fe949b08a0496da","head":{"label":"nos:chore/register","ref":"chore/register","sha":"ecf804087eaf610a9c5c77f82fe949b08a0496da","user":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"repo":{"id":121267259,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNjcyNTk=","name":"client","full_name":"nos/client","owner":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nos/client","description":"The nOS Client","fork":false,"url":"https://api.github.com/repos/nos/client","forks_url":"https://api.github.com/repos/nos/client/forks","keys_url":"https://api.github.com/repos/nos/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nos/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nos/client/teams","hooks_url":"https://api.github.com/repos/nos/client/hooks","issue_events_url":"https://api.github.com/repos/nos/client/issues/events{/number}","events_url":"https://api.github.com/repos/nos/client/events","assignees_url":"https://api.github.com/repos/nos/client/assignees{/user}","branches_url":"https://api.github.com/repos/nos/client/branches{/branch}","tags_url":"https://api.github.com/repos/nos/client/tags","blobs_url":"https://api.github.com/repos/nos/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nos/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nos/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nos/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nos/client/statuses/{sha}","languages_url":"https://api.github.com/repos/nos/client/languages","stargazers_url":"https://api.github.com/repos/nos/client/stargazers","contributors_url":"https://api.github.com/repos/nos/client/contributors","subscribers_url":"https://api.github.com/repos/nos/client/subscribers","subscription_url":"https://api.github.com/repos/nos/client/subscription","commits_url":"https://api.github.com/repos/nos/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nos/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nos/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nos/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nos/client/contents/{+path}","compare_url":"https://api.github.com/repos/nos/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nos/client/merges","archive_url":"https://api.github.com/repos/nos/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nos/client/downloads","issues_url":"https://api.github.com/repos/nos/client/issues{/number}","pulls_url":"https://api.github.com/repos/nos/client/pulls{/number}","milestones_url":"https://api.github.com/repos/nos/client/milestones{/number}","notifications_url":"https://api.github.com/repos/nos/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nos/client/labels{/name}","releases_url":"https://api.github.com/repos/nos/client/releases{/id}","deployments_url":"https://api.github.com/repos/nos/client/deployments","created_at":"2018-02-12T15:54:37Z","updated_at":"2018-08-08T06:39:07Z","pushed_at":"2018-08-08T15:20:45Z","git_url":"git://github.com/nos/client.git","ssh_url":"git@github.com:nos/client.git","clone_url":"https://github.com/nos/client.git","svn_url":"https://github.com/nos/client","homepage":"https://nos.io","size":4468,"stargazers_count":159,"watchers_count":159,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":59,"watchers":159,"default_branch":"develop"}},"base":{"label":"nos:develop","ref":"develop","sha":"1e044a63d80d1387447ec5aaddfa562ab4602d0c","user":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"repo":{"id":121267259,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNjcyNTk=","name":"client","full_name":"nos/client","owner":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nos/client","description":"The nOS Client","fork":false,"url":"https://api.github.com/repos/nos/client","forks_url":"https://api.github.com/repos/nos/client/forks","keys_url":"https://api.github.com/repos/nos/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nos/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nos/client/teams","hooks_url":"https://api.github.com/repos/nos/client/hooks","issue_events_url":"https://api.github.com/repos/nos/client/issues/events{/number}","events_url":"https://api.github.com/repos/nos/client/events","assignees_url":"https://api.github.com/repos/nos/client/assignees{/user}","branches_url":"https://api.github.com/repos/nos/client/branches{/branch}","tags_url":"https://api.github.com/repos/nos/client/tags","blobs_url":"https://api.github.com/repos/nos/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nos/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nos/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nos/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nos/client/statuses/{sha}","languages_url":"https://api.github.com/repos/nos/client/languages","stargazers_url":"https://api.github.com/repos/nos/client/stargazers","contributors_url":"https://api.github.com/repos/nos/client/contributors","subscribers_url":"https://api.github.com/repos/nos/client/subscribers","subscription_url":"https://api.github.com/repos/nos/client/subscription","commits_url":"https://api.github.com/repos/nos/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nos/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nos/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nos/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nos/client/contents/{+path}","compare_url":"https://api.github.com/repos/nos/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nos/client/merges","archive_url":"https://api.github.com/repos/nos/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nos/client/downloads","issues_url":"https://api.github.com/repos/nos/client/issues{/number}","pulls_url":"https://api.github.com/repos/nos/client/pulls{/number}","milestones_url":"https://api.github.com/repos/nos/client/milestones{/number}","notifications_url":"https://api.github.com/repos/nos/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nos/client/labels{/name}","releases_url":"https://api.github.com/repos/nos/client/releases{/id}","deployments_url":"https://api.github.com/repos/nos/client/deployments","created_at":"2018-02-12T15:54:37Z","updated_at":"2018-08-08T06:39:07Z","pushed_at":"2018-08-08T15:20:45Z","git_url":"git://github.com/nos/client.git","ssh_url":"git@github.com:nos/client.git","clone_url":"https://github.com/nos/client.git","svn_url":"https://github.com/nos/client","homepage":"https://nos.io","size":4468,"stargazers_count":159,"watchers_count":159,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":59,"watchers":159,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nos/client/pulls/422"},"html":{"href":"https://github.com/nos/client/pull/422"},"issue":{"href":"https://api.github.com/repos/nos/client/issues/422"},"comments":{"href":"https://api.github.com/repos/nos/client/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/nos/client/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/nos/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nos/client/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/nos/client/statuses/ecf804087eaf610a9c5c77f82fe949b08a0496da"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DalderupMaurice","id":10922045,"node_id":"MDQ6VXNlcjEwOTIyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10922045?v=4","gravatar_id":"","url":"https://api.github.com/users/DalderupMaurice","html_url":"https://github.com/DalderupMaurice","followers_url":"https://api.github.com/users/DalderupMaurice/followers","following_url":"https://api.github.com/users/DalderupMaurice/following{/other_user}","gists_url":"https://api.github.com/users/DalderupMaurice/gists{/gist_id}","starred_url":"https://api.github.com/users/DalderupMaurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DalderupMaurice/subscriptions","organizations_url":"https://api.github.com/users/DalderupMaurice/orgs","repos_url":"https://api.github.com/users/DalderupMaurice/repos","events_url":"https://api.github.com/users/DalderupMaurice/events{/privacy}","received_events_url":"https://api.github.com/users/DalderupMaurice/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":8,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"DalderupMaurice"}}