{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/177437233","pull_request_review_id":107306144,"id":177437233,"diff_hunk":"@@ -246,6 +246,9 @@ Common build options\n - ``BL2_AT_EL3``: This is an optional build option that enables the use of\n    BL2 at EL3 execution level.\n \n+- ``BL2_AT_EL3_ROM``: This is an optional build option that enables the use of\n+   BL2 at EL3 execution level, and BL2 read only section is in ROM.","path":"docs/user-guide.rst","position":5,"original_position":5,"commit_id":"7462a2412da537f7514188d4799c3380d307cce9","original_commit_id":"7462a2412da537f7514188d4799c3380d307cce9","user":{"login":"JiafeiPan","id":25921855,"avatar_url":"https://avatars3.githubusercontent.com/u/25921855?v=4","gravatar_id":"","url":"https://api.github.com/users/JiafeiPan","html_url":"https://github.com/JiafeiPan","followers_url":"https://api.github.com/users/JiafeiPan/followers","following_url":"https://api.github.com/users/JiafeiPan/following{/other_user}","gists_url":"https://api.github.com/users/JiafeiPan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiafeiPan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiafeiPan/subscriptions","organizations_url":"https://api.github.com/users/JiafeiPan/orgs","repos_url":"https://api.github.com/users/JiafeiPan/repos","events_url":"https://api.github.com/users/JiafeiPan/events{/privacy}","received_events_url":"https://api.github.com/users/JiafeiPan/received_events","type":"User","site_admin":false},"body":"Done, thanks.","created_at":"2018-03-27T14:07:17Z","updated_at":"2018-03-27T14:07:17Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328#discussion_r177437233","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/177437233"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328#discussion_r177437233"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328"}},"in_reply_to_id":177395517},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328","id":176407374,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1328","number":1328,"state":"open","locked":false,"title":"bl2-el3: add ROM support when bl2 runs in el3","user":{"login":"JiafeiPan","id":25921855,"avatar_url":"https://avatars3.githubusercontent.com/u/25921855?v=4","gravatar_id":"","url":"https://api.github.com/users/JiafeiPan","html_url":"https://github.com/JiafeiPan","followers_url":"https://api.github.com/users/JiafeiPan/followers","following_url":"https://api.github.com/users/JiafeiPan/following{/other_user}","gists_url":"https://api.github.com/users/JiafeiPan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiafeiPan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiafeiPan/subscriptions","organizations_url":"https://api.github.com/users/JiafeiPan/orgs","repos_url":"https://api.github.com/users/JiafeiPan/repos","events_url":"https://api.github.com/users/JiafeiPan/events{/privacy}","received_events_url":"https://api.github.com/users/JiafeiPan/received_events","type":"User","site_admin":false},"body":"When bl2 runs in el3, it will be the first TF image to\r\nbe executed, so in some cases bl2 will be in ROM just\r\nlike bl1. This patch enable bl2 in ROM in case of it\r\nruns in el3.\r\n\r\nSigned-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>","created_at":"2018-03-21T08:32:29Z","updated_at":"2018-03-27T14:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a11360dff7fe0051f29d2fca9b1c89afecf5ee4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1328/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/7462a2412da537f7514188d4799c3380d307cce9","head":{"label":"JiafeiPan:upstream-bl2-rom","ref":"upstream-bl2-rom","sha":"7462a2412da537f7514188d4799c3380d307cce9","user":{"login":"JiafeiPan","id":25921855,"avatar_url":"https://avatars3.githubusercontent.com/u/25921855?v=4","gravatar_id":"","url":"https://api.github.com/users/JiafeiPan","html_url":"https://github.com/JiafeiPan","followers_url":"https://api.github.com/users/JiafeiPan/followers","following_url":"https://api.github.com/users/JiafeiPan/following{/other_user}","gists_url":"https://api.github.com/users/JiafeiPan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiafeiPan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiafeiPan/subscriptions","organizations_url":"https://api.github.com/users/JiafeiPan/orgs","repos_url":"https://api.github.com/users/JiafeiPan/repos","events_url":"https://api.github.com/users/JiafeiPan/events{/privacy}","received_events_url":"https://api.github.com/users/JiafeiPan/received_events","type":"User","site_admin":false},"repo":{"id":125317348,"name":"arm-trusted-firmware","full_name":"JiafeiPan/arm-trusted-firmware","owner":{"login":"JiafeiPan","id":25921855,"avatar_url":"https://avatars3.githubusercontent.com/u/25921855?v=4","gravatar_id":"","url":"https://api.github.com/users/JiafeiPan","html_url":"https://github.com/JiafeiPan","followers_url":"https://api.github.com/users/JiafeiPan/followers","following_url":"https://api.github.com/users/JiafeiPan/following{/other_user}","gists_url":"https://api.github.com/users/JiafeiPan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiafeiPan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiafeiPan/subscriptions","organizations_url":"https://api.github.com/users/JiafeiPan/orgs","repos_url":"https://api.github.com/users/JiafeiPan/repos","events_url":"https://api.github.com/users/JiafeiPan/events{/privacy}","received_events_url":"https://api.github.com/users/JiafeiPan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JiafeiPan/arm-trusted-firmware","description":"Arm Trusted Firmware","fork":true,"url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware","forks_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/JiafeiPan/arm-trusted-firmware/deployments","created_at":"2018-03-15T05:34:35Z","updated_at":"2018-03-26T12:30:56Z","pushed_at":"2018-03-26T12:30:53Z","git_url":"git://github.com/JiafeiPan/arm-trusted-firmware.git","ssh_url":"git@github.com:JiafeiPan/arm-trusted-firmware.git","clone_url":"https://github.com/JiafeiPan/arm-trusted-firmware.git","svn_url":"https://github.com/JiafeiPan/arm-trusted-firmware","homepage":"","size":12878,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"0d48df84b3bd2b9167ec9cb92e6ccdb15ac7de95","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Trusted Firmware-A","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-03-27T00:48:21Z","pushed_at":"2018-03-27T12:41:48Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":12879,"stargazers_count":529,"watchers_count":529,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":442,"open_issues":16,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1328"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1328"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1328/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1328/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/7462a2412da537f7514188d4799c3380d307cce9"}},"author_association":"NONE"}}
{"actor":{"display_login":"JiafeiPan"}}