{"action":"closed","number":9079,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/9079","id":209383657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzgzNjU3","html_url":"https://github.com/juju/juju/pull/9079","diff_url":"https://github.com/juju/juju/pull/9079.diff","patch_url":"https://github.com/juju/juju/pull/9079.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/9079","number":9079,"state":"closed","locked":false,"title":"Move status and watcher packages into core","user":{"login":"howbazaar","id":1744247,"node_id":"MDQ6VXNlcjE3NDQyNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1744247?v=4","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"Both the status and watcher packages are business logic packages, so can be moved into core.\r\n\r\nThe idea of the core package is to have a home for all packages that aren't workers, not involved with translation over the API, not persistence and not provider specific.\r\n\r\nNo core package should import from outside of core. While doing this change I noticed that the migration package does exactly this, and should be fixed.","created_at":"2018-08-19T22:37:25Z","updated_at":"2018-08-19T23:43:46Z","closed_at":"2018-08-19T23:43:46Z","merged_at":"2018-08-19T23:43:46Z","merge_commit_sha":"2ad84b1b676eab460d6b9604aa1973944af02f9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/9079/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/9079/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/9079/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/23c4b4ff5235d7cc09fdb3708cae08b31e0527ea","head":{"label":"howbazaar:core-watcher","ref":"core-watcher","sha":"23c4b4ff5235d7cc09fdb3708cae08b31e0527ea","user":{"login":"howbazaar","id":1744247,"node_id":"MDQ6VXNlcjE3NDQyNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1744247?v=4","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"repo":{"id":20467403,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ2NzQwMw==","name":"juju","full_name":"howbazaar/juju","owner":{"login":"howbazaar","id":1744247,"node_id":"MDQ6VXNlcjE3NDQyNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1744247?v=4","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/howbazaar/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/howbazaar/juju","forks_url":"https://api.github.com/repos/howbazaar/juju/forks","keys_url":"https://api.github.com/repos/howbazaar/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howbazaar/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howbazaar/juju/teams","hooks_url":"https://api.github.com/repos/howbazaar/juju/hooks","issue_events_url":"https://api.github.com/repos/howbazaar/juju/issues/events{/number}","events_url":"https://api.github.com/repos/howbazaar/juju/events","assignees_url":"https://api.github.com/repos/howbazaar/juju/assignees{/user}","branches_url":"https://api.github.com/repos/howbazaar/juju/branches{/branch}","tags_url":"https://api.github.com/repos/howbazaar/juju/tags","blobs_url":"https://api.github.com/repos/howbazaar/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howbazaar/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howbazaar/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/howbazaar/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howbazaar/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/howbazaar/juju/languages","stargazers_url":"https://api.github.com/repos/howbazaar/juju/stargazers","contributors_url":"https://api.github.com/repos/howbazaar/juju/contributors","subscribers_url":"https://api.github.com/repos/howbazaar/juju/subscribers","subscription_url":"https://api.github.com/repos/howbazaar/juju/subscription","commits_url":"https://api.github.com/repos/howbazaar/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/howbazaar/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/howbazaar/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/howbazaar/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/howbazaar/juju/contents/{+path}","compare_url":"https://api.github.com/repos/howbazaar/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howbazaar/juju/merges","archive_url":"https://api.github.com/repos/howbazaar/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howbazaar/juju/downloads","issues_url":"https://api.github.com/repos/howbazaar/juju/issues{/number}","pulls_url":"https://api.github.com/repos/howbazaar/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/howbazaar/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/howbazaar/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howbazaar/juju/labels{/name}","releases_url":"https://api.github.com/repos/howbazaar/juju/releases{/id}","deployments_url":"https://api.github.com/repos/howbazaar/juju/deployments","created_at":"2014-06-04T02:27:18Z","updated_at":"2016-01-15T01:18:35Z","pushed_at":"2018-08-19T22:29:57Z","git_url":"git://github.com/howbazaar/juju.git","ssh_url":"git@github.com:howbazaar/juju.git","clone_url":"https://github.com/howbazaar/juju.git","svn_url":"https://github.com/howbazaar/juju","homepage":null,"size":222906,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"ea6da15066ade8f571cb7e22ae984c5f7e69a17b","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-08-18T14:09:11Z","pushed_at":"2018-08-19T23:43:46Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":226339,"stargazers_count":1204,"watchers_count":1204,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":277,"open_issues":16,"watchers":1204,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/9079"},"html":{"href":"https://github.com/juju/juju/pull/9079"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/9079"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/9079/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/9079/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/9079/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/23c4b4ff5235d7cc09fdb3708cae08b31e0527ea"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"node_id":"MDQ6VXNlcjc3Nzk0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7779494?v=4","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":518,"deletions":482,"changed_files":416}}
{"actor":{"display_login":"jujubot"}}