{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201733332","pull_request_review_id":136288269,"id":201733332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTczMzMzMg==","diff_hunk":"@@ -68,7 +70,6 @@ def cleanup_tempdir():\n     _()\n     del _\n \n-\n __all__ = [","path":"zipline/__init__.py","position":23,"original_position":23,"commit_id":"24eebfdb8c3ff7edbd2b7e56dfd2f3dfc4861870","original_commit_id":"24eebfdb8c3ff7edbd2b7e56dfd2f3dfc4861870","user":{"login":"llllllllll","id":3064397,"node_id":"MDQ6VXNlcjMwNjQzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3064397?v=4","gravatar_id":"","url":"https://api.github.com/users/llllllllll","html_url":"https://github.com/llllllllll","followers_url":"https://api.github.com/users/llllllllll/followers","following_url":"https://api.github.com/users/llllllllll/following{/other_user}","gists_url":"https://api.github.com/users/llllllllll/gists{/gist_id}","starred_url":"https://api.github.com/users/llllllllll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llllllllll/subscriptions","organizations_url":"https://api.github.com/users/llllllllll/orgs","repos_url":"https://api.github.com/users/llllllllll/repos","events_url":"https://api.github.com/users/llllllllll/events{/privacy}","received_events_url":"https://api.github.com/users/llllllllll/received_events","type":"User","site_admin":false},"body":"we should put `extension_args` in the __all__`","created_at":"2018-07-11T15:22:43Z","updated_at":"2018-07-11T15:25:26Z","html_url":"https://github.com/quantopian/zipline/pull/2210#discussion_r201733332","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/2210","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/201733332"},"html":{"href":"https://github.com/quantopian/zipline/pull/2210#discussion_r201733332"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2210"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/2210","id":194385455,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Mzg1NDU1","html_url":"https://github.com/quantopian/zipline/pull/2210","diff_url":"https://github.com/quantopian/zipline/pull/2210.diff","patch_url":"https://github.com/quantopian/zipline/pull/2210.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/2210","number":2210,"state":"open","locked":false,"title":"ENH: custom class registration support","user":{"login":"jnazaren","id":9516597,"node_id":"MDQ6VXNlcjk1MTY1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/9516597?v=4","gravatar_id":"","url":"https://api.github.com/users/jnazaren","html_url":"https://github.com/jnazaren","followers_url":"https://api.github.com/users/jnazaren/followers","following_url":"https://api.github.com/users/jnazaren/following{/other_user}","gists_url":"https://api.github.com/users/jnazaren/gists{/gist_id}","starred_url":"https://api.github.com/users/jnazaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnazaren/subscriptions","organizations_url":"https://api.github.com/users/jnazaren/orgs","repos_url":"https://api.github.com/users/jnazaren/repos","events_url":"https://api.github.com/users/jnazaren/events{/privacy}","received_events_url":"https://api.github.com/users/jnazaren/received_events","type":"User","site_admin":false},"body":"This PR further extends #2200 and #2201, which respectively implement custom blotter and custom command line argument support. It includes some restructuring of the code, and a new general RegistrationManager class defined in the extensions.py file started in #2201 . Users can now add RegistrationManager instances for abstract base classes into the global custom_types dictionary by decorating abstract base classes with `@create_registration_manager`. Once this is done, subclasses can be registered with the following decorator: `@register(base-class, 'name')`. Registration of subclasses will also add options to the corresponding base class's click option in the `__main__.run()` command, which can be set with `--[base-class]-class 'name'`. This PR fully preserves the functionality introduced in #2201 , which includes support for accessing custom command line arguments introduced with `-x` via namespaces, as in `zipline.extension_args.[argument].[optional_namespaces...]`","created_at":"2018-06-12T19:36:52Z","updated_at":"2018-07-11T15:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"548bba0733f206d899e24d8727ccb87fddf8f7f8","assignee":{"login":"richafrank","id":2123660,"node_id":"MDQ6VXNlcjIxMjM2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2123660?v=4","gravatar_id":"","url":"https://api.github.com/users/richafrank","html_url":"https://github.com/richafrank","followers_url":"https://api.github.com/users/richafrank/followers","following_url":"https://api.github.com/users/richafrank/following{/other_user}","gists_url":"https://api.github.com/users/richafrank/gists{/gist_id}","starred_url":"https://api.github.com/users/richafrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richafrank/subscriptions","organizations_url":"https://api.github.com/users/richafrank/orgs","repos_url":"https://api.github.com/users/richafrank/repos","events_url":"https://api.github.com/users/richafrank/events{/privacy}","received_events_url":"https://api.github.com/users/richafrank/received_events","type":"User","site_admin":false},"assignees":[{"login":"richafrank","id":2123660,"node_id":"MDQ6VXNlcjIxMjM2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2123660?v=4","gravatar_id":"","url":"https://api.github.com/users/richafrank","html_url":"https://github.com/richafrank","followers_url":"https://api.github.com/users/richafrank/followers","following_url":"https://api.github.com/users/richafrank/following{/other_user}","gists_url":"https://api.github.com/users/richafrank/gists{/gist_id}","starred_url":"https://api.github.com/users/richafrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richafrank/subscriptions","organizations_url":"https://api.github.com/users/richafrank/orgs","repos_url":"https://api.github.com/users/richafrank/repos","events_url":"https://api.github.com/users/richafrank/events{/privacy}","received_events_url":"https://api.github.com/users/richafrank/received_events","type":"User","site_admin":false},{"login":"llllllllll","id":3064397,"node_id":"MDQ6VXNlcjMwNjQzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3064397?v=4","gravatar_id":"","url":"https://api.github.com/users/llllllllll","html_url":"https://github.com/llllllllll","followers_url":"https://api.github.com/users/llllllllll/followers","following_url":"https://api.github.com/users/llllllllll/following{/other_user}","gists_url":"https://api.github.com/users/llllllllll/gists{/gist_id}","starred_url":"https://api.github.com/users/llllllllll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llllllllll/subscriptions","organizations_url":"https://api.github.com/users/llllllllll/orgs","repos_url":"https://api.github.com/users/llllllllll/repos","events_url":"https://api.github.com/users/llllllllll/events{/privacy}","received_events_url":"https://api.github.com/users/llllllllll/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/2210/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/2210/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/2210/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/24eebfdb8c3ff7edbd2b7e56dfd2f3dfc4861870","head":{"label":"quantopian:custom_class_support","ref":"custom_class_support","sha":"24eebfdb8c3ff7edbd2b7e56dfd2f3dfc4861870","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-11T14:37:52Z","pushed_at":"2018-07-11T15:24:04Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153773,"stargazers_count":7297,"watchers_count":7297,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2316,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2316,"open_issues":238,"watchers":7297,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"f61d3dfb141b12e14c9b4de332bdd7b7de620eb1","user":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk3NTIw","name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTMyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2018-07-11T14:37:52Z","pushed_at":"2018-07-11T15:24:04Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"http://www.zipline.io/","size":153773,"stargazers_count":7297,"watchers_count":7297,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2316,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2316,"open_issues":238,"watchers":7297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2210"},"html":{"href":"https://github.com/quantopian/zipline/pull/2210"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2210"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/2210/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2210/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/2210/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/24eebfdb8c3ff7edbd2b7e56dfd2f3dfc4861870"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"llllllllll"}}