{"action":"created","issue":{"url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/15","repository_url":"https://api.github.com/repos/nippur72/ifdef-loader","labels_url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/15/comments","events_url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/15/events","html_url":"https://github.com/nippur72/ifdef-loader/issues/15","id":329653726,"node_id":"MDU6SXNzdWUzMjk2NTM3MjY=","number":15,"title":"Cannot use defines that have dashes","user":{"login":"jgranick","id":833997,"node_id":"MDQ6VXNlcjgzMzk5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/833997?v=4","gravatar_id":"","url":"https://api.github.com/users/jgranick","html_url":"https://github.com/jgranick","followers_url":"https://api.github.com/users/jgranick/followers","following_url":"https://api.github.com/users/jgranick/following{/other_user}","gists_url":"https://api.github.com/users/jgranick/gists{/gist_id}","starred_url":"https://api.github.com/users/jgranick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgranick/subscriptions","organizations_url":"https://api.github.com/users/jgranick/orgs","repos_url":"https://api.github.com/users/jgranick/repos","events_url":"https://api.github.com/users/jgranick/events{/privacy}","received_events_url":"https://api.github.com/users/jgranick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-05T22:57:57Z","updated_at":"2018-06-06T19:38:16Z","closed_at":null,"author_association":"NONE","body":"You cannot use defines that use dashes (similar to `ifdef-verbose`) because this doesn't evaluate as proper JavaScript:\r\n\r\n```\r\n/// #if my-custom-define\r\n```\r\n\r\nThe Haxe language compiler converts `-D my-custom-define` to `#if my_custom_define` when evaluating source files, perhaps this would be a reasonable solution?\r\n\r\n\r\n_Related issue:_\r\n\r\nhttps://github.com/openfl/openfl/pull/1911"},"comment":{"url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/comments/395188694","html_url":"https://github.com/nippur72/ifdef-loader/issues/15#issuecomment-395188694","issue_url":"https://api.github.com/repos/nippur72/ifdef-loader/issues/15","id":395188694,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTE4ODY5NA==","user":{"login":"jgranick","id":833997,"node_id":"MDQ6VXNlcjgzMzk5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/833997?v=4","gravatar_id":"","url":"https://api.github.com/users/jgranick","html_url":"https://github.com/jgranick","followers_url":"https://api.github.com/users/jgranick/followers","following_url":"https://api.github.com/users/jgranick/following{/other_user}","gists_url":"https://api.github.com/users/jgranick/gists{/gist_id}","starred_url":"https://api.github.com/users/jgranick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgranick/subscriptions","organizations_url":"https://api.github.com/users/jgranick/orgs","repos_url":"https://api.github.com/users/jgranick/repos","events_url":"https://api.github.com/users/jgranick/events{/privacy}","received_events_url":"https://api.github.com/users/jgranick/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T19:38:16Z","updated_at":"2018-06-06T19:38:16Z","author_association":"NONE","body":"Oh yeah, I understand :smile:\r\n\r\nI just mean, `ifdef-verbose` feels nice. `ifdef_verbose` feels a little funny. I don't think these defines (themselves) are necessary in other source files, but a quick sanitize on the define names might be nice and make this pattern valid"}}
{"actor":{"display_login":"jgranick"}}