{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/30301","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/30301/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30301/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/30301/events","html_url":"https://github.com/dotnet/corefx/pull/30301","id":331378466,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTI0NjA5","number":30301,"title":"Move S.T.M. Span<char> tests to StringTests.cs(part 4)","user":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-11T22:53:34Z","updated_at":"2018-06-12T07:13:09Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30301","html_url":"https://github.com/dotnet/corefx/pull/30301","diff_url":"https://github.com/dotnet/corefx/pull/30301.diff","patch_url":"https://github.com/dotnet/corefx/pull/30301.patch"},"body":"contributes(maybe closes) #28238\r\n\r\nFiles merged:\r\nReadOnlySpan\\IsWhiteSpace.cs\r\nReadOnlySpan\\SequenceCompareTo.char.cs \r\nReadOnlySpan\\SequenceEqual.char.cs \r\nReadOnlySpan\\StartsWith.char.cs \r\nReadOnlySpan\\StartsWith.StringComparison.cs\r\nReadOnlySpan\\TrimAnyCharacter.cs\r\nReadOnlySpan\\TrimManyCharacters.cs \r\nReadOnlySpan\\TrimWhiteSpace.cs\r\n\r\n\r\ncc: @ahsonkhan @tarekgh"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/396489401","html_url":"https://github.com/dotnet/corefx/pull/30301#issuecomment-396489401","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30301","id":396489401,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjQ4OTQwMQ==","user":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T07:13:09Z","updated_at":"2018-06-12T07:13:09Z","author_association":"COLLABORATOR","body":"> What do you mean the semantics are different? We can change the span ones to use strings instead of char arrays. I don't understand why you don't think the string tests make sense. Can you clarify?\r\n\r\nI meant in a test like this https://github.com/dotnet/corefx/blob/master/src/System.Memory/tests/ReadOnlySpan/ToLower.cs#L14\r\n\r\nassert https://github.com/dotnet/corefx/blob/master/src/System.Memory/tests/ReadOnlySpan/ToLower.cs#L23-L24 check for length and check for ToLower expected length seems unuseful...is possible a bug like this on string?I think there are a lot of tests on it\r\n\r\nthis assert https://github.com/dotnet/corefx/blob/master/src/System.Memory/tests/ReadOnlySpan/ToLower.cs#L26 for string doesn't make sense because string are immutable\r\n\r\nmaybe the only assert make sense is https://github.com/dotnet/corefx/blob/master/src/System.Memory/tests/ReadOnlySpan/ToLower.cs#L25\r\n\r\nHowever i'll commit attempts and after we'll choose.\r\n\r\n/cc @ahsonkhan \r\n\r\n"}}
{"actor":{"display_login":"MarcoRossignoli"}}