{"action":"opened","number":2564,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2564","id":189140338,"html_url":"https://github.com/eclipse/omr/pull/2564","diff_url":"https://github.com/eclipse/omr/pull/2564.diff","patch_url":"https://github.com/eclipse/omr/pull/2564.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2564","number":2564,"state":"open","locked":false,"title":"Killing default Memory Space","user":{"login":"amicic","id":18264984,"avatar_url":"https://avatars1.githubusercontent.com/u/18264984?v=4","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"body":"Move the destruction of default Memory Space from kill() to teardown()\r\nof base Configuration class.\r\n\r\nFirstly, kill() should not be doing anything more than just calling the\r\ndestructor (teardown() method), and destroying the backing memory\r\n(free() method).\r\n\r\nSecondly, and more imporantly, doing it in kill() before teardown, would\r\ndo it too early, before specific teardown of Configuration subclasses\r\nwould be not be complete. For example\r\nConfigurationGenerational::tearDown would want to set scavenger pointer\r\nin extensions to NULL before Scavenger instance is destroyed (inderectly\r\nby MemorySpace and SubSpaceSemiSpace)  \r\n\r\nSigned-off-by: Aleksandar Micic <amicic@ca.ibm.com>","created_at":"2018-05-18T21:34:55Z","updated_at":"2018-05-18T21:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2564/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2564/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2564/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/c886d1280803c55bfcfe5eec60d08f4a96d594ac","head":{"label":"amicic:memoryspace","ref":"memoryspace","sha":"c886d1280803c55bfcfe5eec60d08f4a96d594ac","user":{"login":"amicic","id":18264984,"avatar_url":"https://avatars1.githubusercontent.com/u/18264984?v=4","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"repo":{"id":55422149,"name":"omr","full_name":"amicic/omr","owner":{"login":"amicic","id":18264984,"avatar_url":"https://avatars1.githubusercontent.com/u/18264984?v=4","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amicic/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/amicic/omr","forks_url":"https://api.github.com/repos/amicic/omr/forks","keys_url":"https://api.github.com/repos/amicic/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amicic/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amicic/omr/teams","hooks_url":"https://api.github.com/repos/amicic/omr/hooks","issue_events_url":"https://api.github.com/repos/amicic/omr/issues/events{/number}","events_url":"https://api.github.com/repos/amicic/omr/events","assignees_url":"https://api.github.com/repos/amicic/omr/assignees{/user}","branches_url":"https://api.github.com/repos/amicic/omr/branches{/branch}","tags_url":"https://api.github.com/repos/amicic/omr/tags","blobs_url":"https://api.github.com/repos/amicic/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amicic/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amicic/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/amicic/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amicic/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/amicic/omr/languages","stargazers_url":"https://api.github.com/repos/amicic/omr/stargazers","contributors_url":"https://api.github.com/repos/amicic/omr/contributors","subscribers_url":"https://api.github.com/repos/amicic/omr/subscribers","subscription_url":"https://api.github.com/repos/amicic/omr/subscription","commits_url":"https://api.github.com/repos/amicic/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/amicic/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/amicic/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/amicic/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/amicic/omr/contents/{+path}","compare_url":"https://api.github.com/repos/amicic/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amicic/omr/merges","archive_url":"https://api.github.com/repos/amicic/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amicic/omr/downloads","issues_url":"https://api.github.com/repos/amicic/omr/issues{/number}","pulls_url":"https://api.github.com/repos/amicic/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/amicic/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/amicic/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amicic/omr/labels{/name}","releases_url":"https://api.github.com/repos/amicic/omr/releases{/id}","deployments_url":"https://api.github.com/repos/amicic/omr/deployments","created_at":"2016-04-04T15:22:53Z","updated_at":"2016-04-04T15:22:57Z","pushed_at":"2018-05-18T21:33:17Z","git_url":"git://github.com/amicic/omr.git","ssh_url":"git@github.com:amicic/omr.git","clone_url":"https://github.com/amicic/omr.git","svn_url":"https://github.com/amicic/omr","homepage":null,"size":24259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"ae83e1d716cae2dbec861b910c62cddab7930fda","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-05-18T20:04:59Z","pushed_at":"2018-05-18T20:04:49Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":24287,"stargazers_count":486,"watchers_count":486,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":215,"open_issues":443,"watchers":486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2564"},"html":{"href":"https://github.com/eclipse/omr/pull/2564"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2564"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2564/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2564/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2564/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/c886d1280803c55bfcfe5eec60d08f4a96d594ac"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"amicic"}}