{"action":"closed","issue":{"url":"https://api.github.com/repos/Sanchos01/MarsRovers/issues/1","repository_url":"https://api.github.com/repos/Sanchos01/MarsRovers","labels_url":"https://api.github.com/repos/Sanchos01/MarsRovers/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Sanchos01/MarsRovers/issues/1/comments","events_url":"https://api.github.com/repos/Sanchos01/MarsRovers/issues/1/events","html_url":"https://github.com/Sanchos01/MarsRovers/issues/1","id":299957942,"number":1,"title":"Review","user":{"login":"Apelsinka223","id":6092419,"avatar_url":"https://avatars1.githubusercontent.com/u/6092419?v=4","gravatar_id":"","url":"https://api.github.com/users/Apelsinka223","html_url":"https://github.com/Apelsinka223","followers_url":"https://api.github.com/users/Apelsinka223/followers","following_url":"https://api.github.com/users/Apelsinka223/following{/other_user}","gists_url":"https://api.github.com/users/Apelsinka223/gists{/gist_id}","starred_url":"https://api.github.com/users/Apelsinka223/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apelsinka223/subscriptions","organizations_url":"https://api.github.com/users/Apelsinka223/orgs","repos_url":"https://api.github.com/users/Apelsinka223/repos","events_url":"https://api.github.com/users/Apelsinka223/events{/privacy}","received_events_url":"https://api.github.com/users/Apelsinka223/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-24T17:38:09Z","updated_at":"2018-03-02T15:05:29Z","closed_at":"2018-03-02T15:05:29Z","author_association":"NONE","body":"https://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/file_parse.ex#L26-L29\r\nошибки лучше оборачивать в `{:error, _}`\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/file_parse.ex#L18-L18\r\nлучше проверку длины выписать в отдельную функцию, которая будет возвращать например `:ok`/`true` или `{:error, :wrong_format_file}`\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/file_parse.ex#L34-L34\r\nтут больше подойдет ` [x, y] <- head, `\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/mars_rovers.ex#L13-L22\r\n~~можно по дефолту сделать `opts \\\\ [stop_on_blocked: false]` и убрать присваивание~~\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/mars_rovers.ex#L28-L36\r\nлучше заменить на if\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/mars_rovers.ex#L39-L51\r\nкогда много параметров лучше добавить `@spec` и не повторять названия после `_`, иначе тяжело читать. Ну и в длинной строке `do:` надо перенести\r\n`(new_x == s_x and new_y == s_y) or (new_x == new_s_x and new_y == new_s_y)`  лучше вынести в отдельную функцию проверки\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/state.ex#L17-L24\r\nобе проверки выделить в отдельные функции, которые будут возвращать соответствующие ошибки(можно будет обойтись без else)\r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/state.ex#L4-L4\r\nкруто, не знала что так можно 👍 \r\n\r\nhttps://github.com/Sanchos01/MarsRovers/blob/a1de680222d6e7998f6bd77f4f7e3dbc68b02381/lib/state.ex#L34-L41\r\nтут по идее можно было в одной функции все задать"}}
{"actor":{"display_login":"Sanchos01"}}