{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/212813126","pull_request_review_id":149525130,"id":212813126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgxMzEyNg==","diff_hunk":"@@ -0,0 +1,174 @@\n+﻿' Licensed to the .NET Foundation under one or more agreements.\n+' The .NET Foundation licenses this file to you under the MIT license.\n+' See the LICENSE file in the project root for more information.\n+\n+Imports Microsoft.VisualBasic.FileIO\n+\n+Imports System\n+Imports System.Collections\n+Imports System.Collections.Generic\n+Imports System.Linq\n+Imports System.Runtime.InteropServices\n+Imports System.Security\n+Imports Xunit\n+Imports System.Text\n+' DO NOT IMPORT System.IO\n+Namespace Microsoft.VisualBasic.Tests\n+\n+    Public NotInheritable Class DriveInfoWindowsTests\n+        Private Shared Sub DoDriveCheck()\n+            ' Get Volume Label - valid drive\n+            Dim serialNumber, maxFileNameLen, fileSystemFlags As Integer\n+            Dim volNameLen As Integer = 50\n+            Dim fileNameLen As Integer = 50\n+            Dim volumeName As StringBuilder = New StringBuilder(volNameLen)\n+            Dim fileSystemName As StringBuilder = New StringBuilder(fileNameLen)\n+\n+            Dim validDrive As IO.DriveInfo = FileSystem.Drives().First(Function(d) d.DriveType = IO.DriveType.Fixed)\n+            Dim volumeInformationSuccess As Boolean = GetVolumeInformation(validDrive.Name, volumeName, volNameLen, serialNumber, maxFileNameLen, fileSystemFlags, fileSystemName, fileNameLen)\n+\n+            If volumeInformationSuccess Then\n+                Assert.Equal(volumeName.ToString(), validDrive.VolumeLabel)\n+            Else\n+                Dim name As String = validDrive.VolumeLabel\n+            End If\n+        End Sub\n+\n+        <Fact>\n+        <PlatformSpecific(TestPlatforms.Windows)>","path":"src/Microsoft.VisualBasic/tests/VB/DriveInfo.Windows.Tests.vb","position":38,"original_position":38,"commit_id":"c0c88687abc7c2251556071a4683da3a62bc9f45","original_commit_id":"c0c88687abc7c2251556071a4683da3a62bc9f45","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"body":"The Platform Attributes come from the original .Net Tests. All the tests I wrote are platform independent. There are some tests that are platform specific today, DriveInfo is one of them. I did not write these but I assume all the test files run on all the platforms, the fact that it has .Windows. in the name is visual. I think these test also run on Linux but get skipped but I am not the expert here.","created_at":"2018-08-26T02:16:51Z","updated_at":"2018-08-26T02:16:51Z","html_url":"https://github.com/dotnet/corefx/pull/31955#discussion_r212813126","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/31955","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/212813126"},"html":{"href":"https://github.com/dotnet/corefx/pull/31955#discussion_r212813126"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31955"}},"in_reply_to_id":212805567},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31955","id":210911559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTExNTU5","html_url":"https://github.com/dotnet/corefx/pull/31955","diff_url":"https://github.com/dotnet/corefx/pull/31955.diff","patch_url":"https://github.com/dotnet/corefx/pull/31955.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31955","number":31955,"state":"open","locked":false,"title":"[WIP]File io","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"body":"I have completed the Port of the FileIO functions and have test for all the File/Directory commands. I don't have the Text read and write tests or any parsing tests yet. I would like to see what happens with the automated tests and Linux and get some feedback on the tests I have.","created_at":"2018-08-25T16:56:39Z","updated_at":"2018-08-26T02:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a05d9f6bf0b48e3778a2bcee33ae31f7006ecdfb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/31955/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/31955/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31955/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/c0c88687abc7c2251556071a4683da3a62bc9f45","head":{"label":"paul1956:FileIO","ref":"FileIO","sha":"c0c88687abc7c2251556071a4683da3a62bc9f45","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"repo":{"id":145071956,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNzE5NTY=","name":"corefx","full_name":"paul1956/corefx","owner":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paul1956/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/paul1956/corefx","forks_url":"https://api.github.com/repos/paul1956/corefx/forks","keys_url":"https://api.github.com/repos/paul1956/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul1956/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul1956/corefx/teams","hooks_url":"https://api.github.com/repos/paul1956/corefx/hooks","issue_events_url":"https://api.github.com/repos/paul1956/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/paul1956/corefx/events","assignees_url":"https://api.github.com/repos/paul1956/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/paul1956/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/paul1956/corefx/tags","blobs_url":"https://api.github.com/repos/paul1956/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul1956/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul1956/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul1956/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul1956/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/paul1956/corefx/languages","stargazers_url":"https://api.github.com/repos/paul1956/corefx/stargazers","contributors_url":"https://api.github.com/repos/paul1956/corefx/contributors","subscribers_url":"https://api.github.com/repos/paul1956/corefx/subscribers","subscription_url":"https://api.github.com/repos/paul1956/corefx/subscription","commits_url":"https://api.github.com/repos/paul1956/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul1956/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul1956/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul1956/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul1956/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/paul1956/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul1956/corefx/merges","archive_url":"https://api.github.com/repos/paul1956/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul1956/corefx/downloads","issues_url":"https://api.github.com/repos/paul1956/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/paul1956/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/paul1956/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/paul1956/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul1956/corefx/labels{/name}","releases_url":"https://api.github.com/repos/paul1956/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/paul1956/corefx/deployments","created_at":"2018-08-17T04:32:40Z","updated_at":"2018-08-17T04:33:35Z","pushed_at":"2018-08-25T12:02:57Z","git_url":"git://github.com/paul1956/corefx.git","ssh_url":"git@github.com:paul1956/corefx.git","clone_url":"https://github.com/paul1956/corefx.git","svn_url":"https://github.com/paul1956/corefx","homepage":"https://github.com/dotnet/core","size":185793,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"50edd57cbc39f02234a8423125746941c211af13","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-08-26T01:47:02Z","pushed_at":"2018-08-26T02:10:22Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":186224,"stargazers_count":14664,"watchers_count":14664,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4265,"mirror_url":null,"archived":false,"open_issues_count":2540,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4265,"open_issues":2540,"watchers":14664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31955"},"html":{"href":"https://github.com/dotnet/corefx/pull/31955"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31955"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31955/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31955/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31955/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/c0c88687abc7c2251556071a4683da3a62bc9f45"}},"author_association":"NONE"}}
{"actor":{"display_login":"paul1956"}}