{"action":"created","issue":{"url":"https://api.github.com/repos/aeternity/epoch/issues/1370","repository_url":"https://api.github.com/repos/aeternity/epoch","labels_url":"https://api.github.com/repos/aeternity/epoch/issues/1370/labels{/name}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/1370/comments","events_url":"https://api.github.com/repos/aeternity/epoch/issues/1370/events","html_url":"https://github.com/aeternity/epoch/pull/1370","id":343320473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDA2MzE1","number":1370,"title":"Fix a bug in channel's FSM: deposit and withdrawal txs","user":{"login":"velzevur","id":4035918,"node_id":"MDQ6VXNlcjQwMzU5MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-21T11:36:55Z","updated_at":"2018-07-22T07:11:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/1370","html_url":"https://github.com/aeternity/epoch/pull/1370","diff_url":"https://github.com/aeternity/epoch/pull/1370.diff","patch_url":"https://github.com/aeternity/epoch/pull/1370.patch"},"body":"[FSM balances of deposit/withdrawal](https://www.pivotaltracker.com/story/show/159215557)\r\n\r\nFSM used to produce `channel_deposit_tx` and `channel_withdraw_tx` with erronous `state_hash`\r\nIt used to be the current root hash of the channel state tree without the changes being applied (while it should include the change being applied as well). Basically the resulted state hash was correct, disregarding the deposit/withdrawal, so it was correct for the wrong balances. This results in posting an incorrect state hash on-chain.\r\n\r\nIn order to expose the bug, I needed to peek inside the FSM state. Provided an `aesc_fsm:get_state/1` for this."},"comment":{"url":"https://api.github.com/repos/aeternity/epoch/issues/comments/406846245","html_url":"https://github.com/aeternity/epoch/pull/1370#issuecomment-406846245","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/1370","id":406846245,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg0NjI0NQ==","user":{"login":"velzevur","id":4035918,"node_id":"MDQ6VXNlcjQwMzU5MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T07:11:17Z","updated_at":"2018-07-22T07:11:17Z","author_association":"CONTRIBUTOR","body":"I see EUnit failed with\r\n```\r\n\r\nFailures:\r\n\r\n  1) aec_peers_pool_tests:pool_make_space_test/0\r\n     Failure/Error: ?assert(LessEvicted =< 3)\r\n       expected: true\r\n            got: false\r\n     %% /home/builder/epoch/_build/test/lib/aecore/test/aec_peers_pool_tests.erl:1459:in `aec_peers_pool_tests:pool_make_space_test/0`\r\n     Output: \r\n     Output: \r\n```\r\nWhich seems unreleated to this PR. I am investigating"}}
{"actor":{"display_login":"velzevur"}}