{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/178222829","pull_request_review_id":108252452,"id":178222829,"diff_hunk":"@@ -61,6 +61,17 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {\n     // }\n   }\n \n+  /**\n+   * Upgrade function.\n+   *\n+   * @param string $rev\n+   */\n+  public function upgrade_5_1_beta1($rev) {","path":"CRM/Upgrade/Incremental/php/FiveOne.php","position":9,"original_position":9,"commit_id":"092024a74ed75bc3dd64c5a283bbe789dbc8743d","original_commit_id":"092024a74ed75bc3dd64c5a283bbe789dbc8743d","user":{"login":"totten","id":1336047,"avatar_url":"https://avatars0.githubusercontent.com/u/1336047?v=4","gravatar_id":"","url":"https://api.github.com/users/totten","html_url":"https://github.com/totten","followers_url":"https://api.github.com/users/totten/followers","following_url":"https://api.github.com/users/totten/following{/other_user}","gists_url":"https://api.github.com/users/totten/gists{/gist_id}","starred_url":"https://api.github.com/users/totten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totten/subscriptions","organizations_url":"https://api.github.com/users/totten/orgs","repos_url":"https://api.github.com/users/totten/repos","events_url":"https://api.github.com/users/totten/events{/privacy}","received_events_url":"https://api.github.com/users/totten/received_events","type":"User","site_admin":false},"body":"Rule of thumb would be:\r\n\r\n* If the patch is against `master`, then use `alpha` (e.g. `upgrade_5_1_alpha1()`).\r\n* If the patch is against the RC branch, then use `beta` (e.g. `upgrade_5_1_beta1()`).\r\n* If the patch is a backport to a stable branch... then please reconsider. Patch releases generally shouldn't need DB changes. But if it's absolutely needed, then use the number of the upcoming release (e.g. `upgrade_5_1_1()` or `upgrade_5_1_2()`).\r\n\r\nThe best time to change schema is during the `master`/`alpha` phase. Just put any upgrades in the `5.X.alpha1`.\r\n\r\nFor changes later in the process, it's probably a good idea to be verbal about the target version#. You may need to bump the version# up with `set-version.php`, but the decision would have implications for anyone running the RC/stable. There may be times when it's appropriate to bump to `5.X.beta2` or `5.X.1`. This only comes up if patching an RC or stable branch.","created_at":"2018-03-30T02:30:37Z","updated_at":"2018-03-30T02:30:37Z","html_url":"https://github.com/civicrm/civicrm-core/pull/11883#discussion_r178222829","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/178222829"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/11883#discussion_r178222829"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883"}},"in_reply_to_id":177633215},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883","id":177641419,"html_url":"https://github.com/civicrm/civicrm-core/pull/11883","diff_url":"https://github.com/civicrm/civicrm-core/pull/11883.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/11883.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11883","number":11883,"state":"open","locked":false,"title":"core-32 - Add option to disable cancel button on a profile form","user":{"login":"jitendrapurohit","id":5929648,"avatar_url":"https://avatars3.githubusercontent.com/u/5929648?v=4","gravatar_id":"","url":"https://api.github.com/users/jitendrapurohit","html_url":"https://github.com/jitendrapurohit","followers_url":"https://api.github.com/users/jitendrapurohit/followers","following_url":"https://api.github.com/users/jitendrapurohit/following{/other_user}","gists_url":"https://api.github.com/users/jitendrapurohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendrapurohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendrapurohit/subscriptions","organizations_url":"https://api.github.com/users/jitendrapurohit/orgs","repos_url":"https://api.github.com/users/jitendrapurohit/repos","events_url":"https://api.github.com/users/jitendrapurohit/events{/privacy}","received_events_url":"https://api.github.com/users/jitendrapurohit/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nAdd setting to disable cancel button on the profile form.\r\n\r\nBefore\r\n----------------------------------------\r\nWhile setting up \"subscribe\" and \"contact us\" forms for a site, the default behaviour for a wordpress profile form of type \"create\" embedded via a shortcode is to show a cancel button. This isn't really necessary for a single page form with no existing data in it - but there is no way to disable it.\r\n\r\nAfter\r\n----------------------------------------\r\nA new checkbox is added to the Advanced Setting pane(enabled by default) which provides an option to user to remove the cancel button display on the profile form.\r\n\r\n![image](https://user-images.githubusercontent.com/5929648/37949922-4ba3c120-31b4-11e8-8692-bc1f29852811.png)\r\n\r\nTechnical Details\r\n----------------------------------------\r\nCancel button Text and URL setting will only be shown if the `add_cancel_button` checkbox is enabled. \r\nUpgrade handling is done in 5.1.beta1.\r\n\r\nIssue filed here - https://lab.civicrm.org/dev/core/issues/32","created_at":"2018-03-27T06:20:18Z","updated_at":"2018-03-30T02:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daa85155ab31526953501946143503644da0d49a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246037889,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11883/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/092024a74ed75bc3dd64c5a283bbe789dbc8743d","head":{"label":"jitendrapurohit:core-32","ref":"core-32","sha":"092024a74ed75bc3dd64c5a283bbe789dbc8743d","user":{"login":"jitendrapurohit","id":5929648,"avatar_url":"https://avatars3.githubusercontent.com/u/5929648?v=4","gravatar_id":"","url":"https://api.github.com/users/jitendrapurohit","html_url":"https://github.com/jitendrapurohit","followers_url":"https://api.github.com/users/jitendrapurohit/followers","following_url":"https://api.github.com/users/jitendrapurohit/following{/other_user}","gists_url":"https://api.github.com/users/jitendrapurohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendrapurohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendrapurohit/subscriptions","organizations_url":"https://api.github.com/users/jitendrapurohit/orgs","repos_url":"https://api.github.com/users/jitendrapurohit/repos","events_url":"https://api.github.com/users/jitendrapurohit/events{/privacy}","received_events_url":"https://api.github.com/users/jitendrapurohit/received_events","type":"User","site_admin":false},"repo":{"id":14384658,"name":"civicrm-core","full_name":"jitendrapurohit/civicrm-core","owner":{"login":"jitendrapurohit","id":5929648,"avatar_url":"https://avatars3.githubusercontent.com/u/5929648?v=4","gravatar_id":"","url":"https://api.github.com/users/jitendrapurohit","html_url":"https://github.com/jitendrapurohit","followers_url":"https://api.github.com/users/jitendrapurohit/followers","following_url":"https://api.github.com/users/jitendrapurohit/following{/other_user}","gists_url":"https://api.github.com/users/jitendrapurohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendrapurohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendrapurohit/subscriptions","organizations_url":"https://api.github.com/users/jitendrapurohit/orgs","repos_url":"https://api.github.com/users/jitendrapurohit/repos","events_url":"https://api.github.com/users/jitendrapurohit/events{/privacy}","received_events_url":"https://api.github.com/users/jitendrapurohit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jitendrapurohit/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/jitendrapurohit/civicrm-core","forks_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/forks","keys_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/teams","hooks_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/events","assignees_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/tags","blobs_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/subscription","commits_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/merges","archive_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/downloads","issues_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/jitendrapurohit/civicrm-core/deployments","created_at":"2013-11-14T04:02:34Z","updated_at":"2017-02-20T07:17:58Z","pushed_at":"2018-03-28T04:21:33Z","git_url":"git://github.com/jitendrapurohit/civicrm-core.git","ssh_url":"git@github.com:jitendrapurohit/civicrm-core.git","clone_url":"https://github.com/jitendrapurohit/civicrm-core.git","svn_url":"https://github.com/jitendrapurohit/civicrm-core","homepage":null,"size":153744,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"778e350f4baedc027b6a4fcc67a474cf17de7352","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-03-30T00:13:32Z","pushed_at":"2018-03-30T02:04:24Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":158864,"stargazers_count":262,"watchers_count":262,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":617,"mirror_url":null,"archived":false,"open_issues_count":142,"license":null,"forks":617,"open_issues":142,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/11883"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/11883"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/11883/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11883/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/092024a74ed75bc3dd64c5a283bbe789dbc8743d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"totten"}}