{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5","id":236210494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjEwNDk0","html_url":"https://github.com/racker/salus-telemetry-model/pull/5","diff_url":"https://github.com/racker/salus-telemetry-model/pull/5.diff","patch_url":"https://github.com/racker/salus-telemetry-model/pull/5.patch","issue_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/5","number":5,"state":"closed","locked":false,"title":"Fix NodeInfo serialization","user":{"login":"jjbuchan","id":4358210,"node_id":"MDQ6VXNlcjQzNTgyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4358210?v=4","gravatar_id":"","url":"https://api.github.com/users/jjbuchan","html_url":"https://github.com/jjbuchan","followers_url":"https://api.github.com/users/jjbuchan/followers","following_url":"https://api.github.com/users/jjbuchan/following{/other_user}","gists_url":"https://api.github.com/users/jjbuchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jjbuchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjbuchan/subscriptions","organizations_url":"https://api.github.com/users/jjbuchan/orgs","repos_url":"https://api.github.com/users/jjbuchan/repos","events_url":"https://api.github.com/users/jjbuchan/events{/privacy}","received_events_url":"https://api.github.com/users/jjbuchan/received_events","type":"User","site_admin":false},"body":"Cannot use an abstract class in these models.  Casting to `InetSocketAddress` works fine.\r\n\r\nFixed up the annotations as well as they were wrongly swapped for two values.\r\n\r\nOther thoughts:\r\nYesterday I was thinking we might want to create these objects without yet seeing a connection, so I was going to change the address field to `Nullable`, but then that'd mean the envoyId should also be able to be null.  Decided not to do that yet until we know since it'd involve extra validations in other parts of the system.","created_at":"2018-12-05T15:13:36Z","updated_at":"2018-12-05T16:43:05Z","closed_at":"2018-12-05T16:43:05Z","merged_at":"2018-12-05T16:43:05Z","merge_commit_sha":"68b68eceeea3ba0ed91fd6e9e1e45c61ad62f68b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5/commits","review_comments_url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5/comments","review_comment_url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/5/comments","statuses_url":"https://api.github.com/repos/racker/salus-telemetry-model/statuses/d66d022d40931f0bb1d17d125ccfb2ef77925de7","head":{"label":"racker:jjbuchan/fix-node","ref":"jjbuchan/fix-node","sha":"d66d022d40931f0bb1d17d125ccfb2ef77925de7","user":{"login":"racker","id":556922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NjkyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/556922?v=4","gravatar_id":"","url":"https://api.github.com/users/racker","html_url":"https://github.com/racker","followers_url":"https://api.github.com/users/racker/followers","following_url":"https://api.github.com/users/racker/following{/other_user}","gists_url":"https://api.github.com/users/racker/gists{/gist_id}","starred_url":"https://api.github.com/users/racker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racker/subscriptions","organizations_url":"https://api.github.com/users/racker/orgs","repos_url":"https://api.github.com/users/racker/repos","events_url":"https://api.github.com/users/racker/events{/privacy}","received_events_url":"https://api.github.com/users/racker/received_events","type":"Organization","site_admin":false},"repo":{"id":157890995,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4OTA5OTU=","name":"salus-telemetry-model","full_name":"racker/salus-telemetry-model","private":false,"owner":{"login":"racker","id":556922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NjkyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/556922?v=4","gravatar_id":"","url":"https://api.github.com/users/racker","html_url":"https://github.com/racker","followers_url":"https://api.github.com/users/racker/followers","following_url":"https://api.github.com/users/racker/following{/other_user}","gists_url":"https://api.github.com/users/racker/gists{/gist_id}","starred_url":"https://api.github.com/users/racker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racker/subscriptions","organizations_url":"https://api.github.com/users/racker/orgs","repos_url":"https://api.github.com/users/racker/repos","events_url":"https://api.github.com/users/racker/events{/privacy}","received_events_url":"https://api.github.com/users/racker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racker/salus-telemetry-model","description":null,"fork":false,"url":"https://api.github.com/repos/racker/salus-telemetry-model","forks_url":"https://api.github.com/repos/racker/salus-telemetry-model/forks","keys_url":"https://api.github.com/repos/racker/salus-telemetry-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racker/salus-telemetry-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racker/salus-telemetry-model/teams","hooks_url":"https://api.github.com/repos/racker/salus-telemetry-model/hooks","issue_events_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/events{/number}","events_url":"https://api.github.com/repos/racker/salus-telemetry-model/events","assignees_url":"https://api.github.com/repos/racker/salus-telemetry-model/assignees{/user}","branches_url":"https://api.github.com/repos/racker/salus-telemetry-model/branches{/branch}","tags_url":"https://api.github.com/repos/racker/salus-telemetry-model/tags","blobs_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racker/salus-telemetry-model/statuses/{sha}","languages_url":"https://api.github.com/repos/racker/salus-telemetry-model/languages","stargazers_url":"https://api.github.com/repos/racker/salus-telemetry-model/stargazers","contributors_url":"https://api.github.com/repos/racker/salus-telemetry-model/contributors","subscribers_url":"https://api.github.com/repos/racker/salus-telemetry-model/subscribers","subscription_url":"https://api.github.com/repos/racker/salus-telemetry-model/subscription","commits_url":"https://api.github.com/repos/racker/salus-telemetry-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/racker/salus-telemetry-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/racker/salus-telemetry-model/contents/{+path}","compare_url":"https://api.github.com/repos/racker/salus-telemetry-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racker/salus-telemetry-model/merges","archive_url":"https://api.github.com/repos/racker/salus-telemetry-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racker/salus-telemetry-model/downloads","issues_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues{/number}","pulls_url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls{/number}","milestones_url":"https://api.github.com/repos/racker/salus-telemetry-model/milestones{/number}","notifications_url":"https://api.github.com/repos/racker/salus-telemetry-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racker/salus-telemetry-model/labels{/name}","releases_url":"https://api.github.com/repos/racker/salus-telemetry-model/releases{/id}","deployments_url":"https://api.github.com/repos/racker/salus-telemetry-model/deployments","created_at":"2018-11-16T16:08:02Z","updated_at":"2018-12-04T17:21:55Z","pushed_at":"2018-12-05T16:43:05Z","git_url":"git://github.com/racker/salus-telemetry-model.git","ssh_url":"git@github.com:racker/salus-telemetry-model.git","clone_url":"https://github.com/racker/salus-telemetry-model.git","svn_url":"https://github.com/racker/salus-telemetry-model","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"racker:master","ref":"master","sha":"9b54cba9ca40b560f333ea63c9644c2e18465c46","user":{"login":"racker","id":556922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NjkyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/556922?v=4","gravatar_id":"","url":"https://api.github.com/users/racker","html_url":"https://github.com/racker","followers_url":"https://api.github.com/users/racker/followers","following_url":"https://api.github.com/users/racker/following{/other_user}","gists_url":"https://api.github.com/users/racker/gists{/gist_id}","starred_url":"https://api.github.com/users/racker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racker/subscriptions","organizations_url":"https://api.github.com/users/racker/orgs","repos_url":"https://api.github.com/users/racker/repos","events_url":"https://api.github.com/users/racker/events{/privacy}","received_events_url":"https://api.github.com/users/racker/received_events","type":"Organization","site_admin":false},"repo":{"id":157890995,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4OTA5OTU=","name":"salus-telemetry-model","full_name":"racker/salus-telemetry-model","private":false,"owner":{"login":"racker","id":556922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NjkyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/556922?v=4","gravatar_id":"","url":"https://api.github.com/users/racker","html_url":"https://github.com/racker","followers_url":"https://api.github.com/users/racker/followers","following_url":"https://api.github.com/users/racker/following{/other_user}","gists_url":"https://api.github.com/users/racker/gists{/gist_id}","starred_url":"https://api.github.com/users/racker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racker/subscriptions","organizations_url":"https://api.github.com/users/racker/orgs","repos_url":"https://api.github.com/users/racker/repos","events_url":"https://api.github.com/users/racker/events{/privacy}","received_events_url":"https://api.github.com/users/racker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racker/salus-telemetry-model","description":null,"fork":false,"url":"https://api.github.com/repos/racker/salus-telemetry-model","forks_url":"https://api.github.com/repos/racker/salus-telemetry-model/forks","keys_url":"https://api.github.com/repos/racker/salus-telemetry-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racker/salus-telemetry-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racker/salus-telemetry-model/teams","hooks_url":"https://api.github.com/repos/racker/salus-telemetry-model/hooks","issue_events_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/events{/number}","events_url":"https://api.github.com/repos/racker/salus-telemetry-model/events","assignees_url":"https://api.github.com/repos/racker/salus-telemetry-model/assignees{/user}","branches_url":"https://api.github.com/repos/racker/salus-telemetry-model/branches{/branch}","tags_url":"https://api.github.com/repos/racker/salus-telemetry-model/tags","blobs_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racker/salus-telemetry-model/statuses/{sha}","languages_url":"https://api.github.com/repos/racker/salus-telemetry-model/languages","stargazers_url":"https://api.github.com/repos/racker/salus-telemetry-model/stargazers","contributors_url":"https://api.github.com/repos/racker/salus-telemetry-model/contributors","subscribers_url":"https://api.github.com/repos/racker/salus-telemetry-model/subscribers","subscription_url":"https://api.github.com/repos/racker/salus-telemetry-model/subscription","commits_url":"https://api.github.com/repos/racker/salus-telemetry-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/racker/salus-telemetry-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/racker/salus-telemetry-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/racker/salus-telemetry-model/contents/{+path}","compare_url":"https://api.github.com/repos/racker/salus-telemetry-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racker/salus-telemetry-model/merges","archive_url":"https://api.github.com/repos/racker/salus-telemetry-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racker/salus-telemetry-model/downloads","issues_url":"https://api.github.com/repos/racker/salus-telemetry-model/issues{/number}","pulls_url":"https://api.github.com/repos/racker/salus-telemetry-model/pulls{/number}","milestones_url":"https://api.github.com/repos/racker/salus-telemetry-model/milestones{/number}","notifications_url":"https://api.github.com/repos/racker/salus-telemetry-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racker/salus-telemetry-model/labels{/name}","releases_url":"https://api.github.com/repos/racker/salus-telemetry-model/releases{/id}","deployments_url":"https://api.github.com/repos/racker/salus-telemetry-model/deployments","created_at":"2018-11-16T16:08:02Z","updated_at":"2018-12-04T17:21:55Z","pushed_at":"2018-12-05T16:43:05Z","git_url":"git://github.com/racker/salus-telemetry-model.git","ssh_url":"git@github.com:racker/salus-telemetry-model.git","clone_url":"https://github.com/racker/salus-telemetry-model.git","svn_url":"https://github.com/racker/salus-telemetry-model","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5"},"html":{"href":"https://github.com/racker/salus-telemetry-model/pull/5"},"issue":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/issues/5"},"comments":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/racker/salus-telemetry-model/statuses/d66d022d40931f0bb1d17d125ccfb2ef77925de7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jjbuchan","id":4358210,"node_id":"MDQ6VXNlcjQzNTgyMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4358210?v=4","gravatar_id":"","url":"https://api.github.com/users/jjbuchan","html_url":"https://github.com/jjbuchan","followers_url":"https://api.github.com/users/jjbuchan/followers","following_url":"https://api.github.com/users/jjbuchan/following{/other_user}","gists_url":"https://api.github.com/users/jjbuchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jjbuchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjbuchan/subscriptions","organizations_url":"https://api.github.com/users/jjbuchan/orgs","repos_url":"https://api.github.com/users/jjbuchan/repos","events_url":"https://api.github.com/users/jjbuchan/events{/privacy}","received_events_url":"https://api.github.com/users/jjbuchan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"jjbuchan"}}