{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/345","repository_url":"https://api.github.com/repos/Islandora/islandora_solr_search","labels_url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/345/comments","events_url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/345/events","html_url":"https://github.com/Islandora/islandora_solr_search/pull/345","id":365989185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Nzc0NzMx","number":345,"title":"Allow alternate backend Solr implementations - WIP","user":{"login":"whikloj","id":2857697,"node_id":"MDQ6VXNlcjI4NTc2OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2857697?v=4","gravatar_id":"","url":"https://api.github.com/users/whikloj","html_url":"https://github.com/whikloj","followers_url":"https://api.github.com/users/whikloj/followers","following_url":"https://api.github.com/users/whikloj/following{/other_user}","gists_url":"https://api.github.com/users/whikloj/gists{/gist_id}","starred_url":"https://api.github.com/users/whikloj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whikloj/subscriptions","organizations_url":"https://api.github.com/users/whikloj/orgs","repos_url":"https://api.github.com/users/whikloj/repos","events_url":"https://api.github.com/users/whikloj/events{/privacy}","received_events_url":"https://api.github.com/users/whikloj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T16:54:32Z","updated_at":"2018-10-19T18:11:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_solr_search/pulls/345","html_url":"https://github.com/Islandora/islandora_solr_search/pull/345","diff_url":"https://github.com/Islandora/islandora_solr_search/pull/345.diff","patch_url":"https://github.com/Islandora/islandora_solr_search/pull/345.patch"},"body":"**JIRA Ticket**: NONE\r\n\r\nThis was an alternative solution started based on discussions in the below (now merged) PR. \r\nhttps://github.com/Islandora/islandora_solr_search/pull/342\r\n\r\nThis is a Work-In-Progress, it should work with the existing ApacheSolrClient but would need a new implementation to really see if it was viable. If there is interest, this can be resurrected. Otherwise I am happy to leave this a sign-post for some intrepid soul.\r\n\r\n# What does this Pull Request do?\r\n\r\nFirst of all, this is **NOT** ready. I was trying to see if I could get it to work with the existing stuff. The admin page is probably broken and I haven't tested all the various other Solr things (facet pages, metadata, etc) that might get broken by the new level of abstraction.\r\n\r\nBut this is my attempt to abstract the ApacheSolrClient layer out. There is much garbage in here, but there is too much member variable use in the code to clean it without a huge time investment (ie. `$solr_build->solrParams`).\r\n\r\nThis moves the current ApacheSolrClient work down a level and makes the existing `IslandoraSolrQueryProcessor` just a proxy to load the actual code. Same for `IslandoraSolrResults` and `IslandoraSolrFacets`.\r\n\r\nIf this seems viable, and there is interest (in the form of work, review and testing) I can continue to push forward with cleaning up the admin pages and trying a Solarium implementation along side.\r\n\r\nIf not, this can die here and I press on to Claw.\r\n\r\n# What's new?\r\nCode is the same just shifted so it could be replaced.\r\n\r\n# How should this be tested?\r\n\r\nAnything you used to use Solr for should work the same, but probably won't. That is what I need to know.\r\n\r\n# Additional Notes:\r\n\r\nExample:\r\n* Does this change require documentation to be updated? yes\r\n* Does this change add any new dependencies? yes\r\n* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)?  no\r\n* Could this change impact execution of existing code? 🤷‍♂️ \r\n\r\n# Interested parties\r\n@Islandora/7-x-1-x-committers\r\n"},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/comments/431451068","html_url":"https://github.com/Islandora/islandora_solr_search/pull/345#issuecomment-431451068","issue_url":"https://api.github.com/repos/Islandora/islandora_solr_search/issues/345","id":431451068,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQ1MTA2OA==","user":{"login":"whikloj","id":2857697,"node_id":"MDQ6VXNlcjI4NTc2OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2857697?v=4","gravatar_id":"","url":"https://api.github.com/users/whikloj","html_url":"https://github.com/whikloj","followers_url":"https://api.github.com/users/whikloj/followers","following_url":"https://api.github.com/users/whikloj/following{/other_user}","gists_url":"https://api.github.com/users/whikloj/gists{/gist_id}","starred_url":"https://api.github.com/users/whikloj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whikloj/subscriptions","organizations_url":"https://api.github.com/users/whikloj/orgs","repos_url":"https://api.github.com/users/whikloj/repos","events_url":"https://api.github.com/users/whikloj/events{/privacy}","received_events_url":"https://api.github.com/users/whikloj/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T18:11:57Z","updated_at":"2018-10-19T18:11:57Z","author_association":"MEMBER","body":"@DonRichards this is rebased, but as it says in the description this is a Work In Progress. I certainly am happy if you test it out, but please **do not merge** this. \r\n\r\nThere will have to be more discussion around what a change like this will look like and if I can get an alternate client (Solarium) that still works."}}
{"actor":{"display_login":"whikloj"}}