{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/2614","repository_url":"https://api.github.com/repos/ripple/rippled","labels_url":"https://api.github.com/repos/ripple/rippled/issues/2614/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2614/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/2614/events","html_url":"https://github.com/ripple/rippled/pull/2614","id":336968770,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mjk0MDI4","number":2614,"title":"Remove TODO in DisputedTx.h about renaming constants for ConsensusParms","user":{"login":"JoeLoser","id":6462525,"node_id":"MDQ6VXNlcjY0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6462525?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeLoser","html_url":"https://github.com/JoeLoser","followers_url":"https://api.github.com/users/JoeLoser/followers","following_url":"https://api.github.com/users/JoeLoser/following{/other_user}","gists_url":"https://api.github.com/users/JoeLoser/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeLoser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeLoser/subscriptions","organizations_url":"https://api.github.com/users/JoeLoser/orgs","repos_url":"https://api.github.com/users/JoeLoser/repos","events_url":"https://api.github.com/users/JoeLoser/events{/privacy}","received_events_url":"https://api.github.com/users/JoeLoser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wilsonianb","id":5885521,"node_id":"MDQ6VXNlcjU4ODU1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5885521?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilsonianb","id":5885521,"node_id":"MDQ6VXNlcjU4ODU1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5885521?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},{"login":"scottschurr","id":7840379,"node_id":"MDQ6VXNlcjc4NDAzNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/7840379?v=4","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-06-29T11:46:23Z","updated_at":"2018-07-06T01:45:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2614","html_url":"https://github.com/ripple/rippled/pull/2614","diff_url":"https://github.com/ripple/rippled/pull/2614.diff","patch_url":"https://github.com/ripple/rippled/pull/2614.patch"},"body":"Based on a TODO comment in `DisputedTX.h`, it seems at one point the\r\ndata members of `ConsensusParms` were macros. Now that they are not,\r\nwe should spell them like other data members (without all uppercase).\r\n\r\nReviewers:\r\n@wilsonianb @scottschurr "},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/402900703","html_url":"https://github.com/ripple/rippled/pull/2614#issuecomment-402900703","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2614","id":402900703,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjkwMDcwMw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T01:45:42Z","updated_at":"2018-07-06T01:45:42Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=h1) Report\n> Merging [#2614](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=desc) into [develop](https://codecov.io/gh/ripple/rippled/commit/381a1b948b06d9526cc73f14cfc69635fabf8605?src=pr&el=desc) will **decrease** coverage by `0.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ripple/rippled/pull/2614/graphs/tree.svg?width=650&token=y0OgJuslsq&height=150&src=pr)](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop    #2614      +/-   ##\n===========================================\n- Coverage    70.83%   70.81%   -0.02%     \n===========================================\n  Files          698      698              \n  Lines        54367    54367              \n===========================================\n- Hits         38510    38502       -8     \n- Misses       15857    15865       +8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/ripple/consensus/DisputedTx.h](https://codecov.io/gh/ripple/rippled/pull/2614/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9jb25zZW5zdXMvRGlzcHV0ZWRUeC5o) | `97.26% <ø> (ø)` | :arrow_up: |\n| [src/ripple/server/impl/BaseHTTPPeer.h](https://codecov.io/gh/ripple/rippled/pull/2614/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9zZXJ2ZXIvaW1wbC9CYXNlSFRUUFBlZXIuaA==) | `87.65% <0%> (-3.09%)` | :arrow_down: |\n| [src/ripple/ledger/impl/ApplyView.cpp](https://codecov.io/gh/ripple/rippled/pull/2614/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9sZWRnZXIvaW1wbC9BcHBseVZpZXcuY3Bw) | `80% <0%> (-2.61%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=footer). Last update [381a1b9...ab65c47](https://codecov.io/gh/ripple/rippled/pull/2614?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}