{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/15395","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/15395/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/15395/comments","events_url":"https://api.github.com/repos/electron/electron/issues/15395/events","html_url":"https://github.com/electron/electron/pull/15395","id":373998023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1Nzk5MTg0","number":15395,"title":"build: move some common parts to a new \"apply_patches.py\" script","user":{"login":"alexeykuzmin","id":607250,"node_id":"MDQ6VXNlcjYwNzI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/607250?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykuzmin","html_url":"https://github.com/alexeykuzmin","followers_url":"https://api.github.com/users/alexeykuzmin/followers","following_url":"https://api.github.com/users/alexeykuzmin/following{/other_user}","gists_url":"https://api.github.com/users/alexeykuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykuzmin/subscriptions","organizations_url":"https://api.github.com/users/alexeykuzmin/orgs","repos_url":"https://api.github.com/users/alexeykuzmin/repos","events_url":"https://api.github.com/users/alexeykuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykuzmin/received_events","type":"User","site_admin":false},"labels":[{"id":1086970368,"node_id":"MDU6TGFiZWwxMDg2OTcwMzY4","url":"https://api.github.com/repos/electron/electron/labels/target/4-0-x","name":"target/4-0-x","color":"f22fa2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-25T15:12:05Z","updated_at":"2018-11-02T08:28:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/15395","html_url":"https://github.com/electron/electron/pull/15395","diff_url":"https://github.com/electron/electron/pull/15395.diff","patch_url":"https://github.com/electron/electron/pull/15395.patch"},"body":"#### Description of Change\r\n<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\n```\r\n$ ./script/apply_patches.py \\\r\n  my_patches/chromium:src \\\r\n  my_patches/electron:src/electron\r\n```\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n\r\n\r\n#### Release Notes\r\n<!-- Used to describe release notes for future release versions. Use `no-notes` to indicate no user-facing changes. -->\r\n\r\nNotes: no notes"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/435306206","html_url":"https://github.com/electron/electron/pull/15395#issuecomment-435306206","issue_url":"https://api.github.com/repos/electron/electron/issues/15395","id":435306206,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTMwNjIwNg==","user":{"login":"alexeykuzmin","id":607250,"node_id":"MDQ6VXNlcjYwNzI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/607250?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykuzmin","html_url":"https://github.com/alexeykuzmin","followers_url":"https://api.github.com/users/alexeykuzmin/followers","following_url":"https://api.github.com/users/alexeykuzmin/following{/other_user}","gists_url":"https://api.github.com/users/alexeykuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykuzmin/subscriptions","organizations_url":"https://api.github.com/users/alexeykuzmin/orgs","repos_url":"https://api.github.com/users/alexeykuzmin/repos","events_url":"https://api.github.com/users/alexeykuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykuzmin/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T08:28:28Z","updated_at":"2018-11-02T08:28:28Z","author_association":"CONTRIBUTOR","body":"@nornagon \r\n\r\n> `apply_all_patches.py` was supposed to be a slightly glorified for loop, and could have been written in bash. i don't love adding a little syntax to it (with the `:`). \r\n\r\n`apply_all_patches.py` still does exactly the same, just the `for` loop has been moved to a new file.\r\n\r\n> i'd rather simplify the scripts so that it's trivial for you to write your own for loop.\r\n\r\nI basically can't import anything from the `script/lib/` if code I write is not in the `electron` repo."}}
{"actor":{"display_login":"alexeykuzmin"}}