{"action":"created","comment":{"url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/comments/165853569","pull_request_review_id":93854062,"id":165853569,"diff_hunk":"@@ -2,6 +2,7 @@\n \n from . import views\n \n+app_name = 'users'","path":"{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/users/urls.py","position":4,"original_position":4,"commit_id":"9ca98e02d48bbf81d5b67904702aef1c04ea7d48","original_commit_id":"9ca98e02d48bbf81d5b67904702aef1c04ea7d48","user":{"login":"browniebroke","id":861044,"avatar_url":"https://avatars1.githubusercontent.com/u/861044?v=4","gravatar_id":"","url":"https://api.github.com/users/browniebroke","html_url":"https://github.com/browniebroke","followers_url":"https://api.github.com/users/browniebroke/followers","following_url":"https://api.github.com/users/browniebroke/following{/other_user}","gists_url":"https://api.github.com/users/browniebroke/gists{/gist_id}","starred_url":"https://api.github.com/users/browniebroke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browniebroke/subscriptions","organizations_url":"https://api.github.com/users/browniebroke/orgs","repos_url":"https://api.github.com/users/browniebroke/repos","events_url":"https://api.github.com/users/browniebroke/events{/privacy}","received_events_url":"https://api.github.com/users/browniebroke/received_events","type":"User","site_admin":false},"body":"@zoidbergwill is right, it's a combination of several removed features:\r\n\r\n> - Support for setting a URL instance namespace without an application namespace is removed.\r\n\r\nThis URL pattern is included with namespace, so now we must provide an `app_name`. At the same time:\r\n\r\n> - The app_name argument to include() is removed.","created_at":"2018-02-04T18:43:04Z","updated_at":"2018-02-04T18:43:04Z","html_url":"https://github.com/pydanny/cookiecutter-django/pull/1421#discussion_r165853569","pull_request_url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/comments/165853569"},"html":{"href":"https://github.com/pydanny/cookiecutter-django/pull/1421#discussion_r165853569"},"pull_request":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421"}},"in_reply_to_id":165847803},"pull_request":{"url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421","id":160581181,"html_url":"https://github.com/pydanny/cookiecutter-django/pull/1421","diff_url":"https://github.com/pydanny/cookiecutter-django/pull/1421.diff","patch_url":"https://github.com/pydanny/cookiecutter-django/pull/1421.patch","issue_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1421","number":1421,"state":"open","locked":false,"title":"Upgrade Django to 2.0","user":{"login":"epicwhale","id":670655,"avatar_url":"https://avatars0.githubusercontent.com/u/670655?v=4","gravatar_id":"","url":"https://api.github.com/users/epicwhale","html_url":"https://github.com/epicwhale","followers_url":"https://api.github.com/users/epicwhale/followers","following_url":"https://api.github.com/users/epicwhale/following{/other_user}","gists_url":"https://api.github.com/users/epicwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/epicwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicwhale/subscriptions","organizations_url":"https://api.github.com/users/epicwhale/orgs","repos_url":"https://api.github.com/users/epicwhale/repos","events_url":"https://api.github.com/users/epicwhale/events{/privacy}","received_events_url":"https://api.github.com/users/epicwhale/received_events","type":"User","site_admin":false},"body":"I needed to start my project on django 2.0 and thought this would help give the discussion at #1416  a headstart. All tests run successfully. \r\n\r\n- Refactor django.core.urlresolvers module import to django.urls. Resolves: The django.core.urlresolvers module is removed in favor of its new location, django.urls.\r\n\r\n- Add an app namespace to urls in user app. Resolves: Support for setting a URL instance namespace without an application namespace is removed.","created_at":"2017-12-30T06:48:29Z","updated_at":"2018-02-04T18:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f64dcefae22ab9aeab6fbab74de0b4e34a88a3aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421/commits","review_comments_url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421/comments","review_comment_url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1421/comments","statuses_url":"https://api.github.com/repos/pydanny/cookiecutter-django/statuses/9ca98e02d48bbf81d5b67904702aef1c04ea7d48","head":{"label":"epicwhale:update-django-1.11.8-to-2.0","ref":"update-django-1.11.8-to-2.0","sha":"9ca98e02d48bbf81d5b67904702aef1c04ea7d48","user":{"login":"epicwhale","id":670655,"avatar_url":"https://avatars0.githubusercontent.com/u/670655?v=4","gravatar_id":"","url":"https://api.github.com/users/epicwhale","html_url":"https://github.com/epicwhale","followers_url":"https://api.github.com/users/epicwhale/followers","following_url":"https://api.github.com/users/epicwhale/following{/other_user}","gists_url":"https://api.github.com/users/epicwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/epicwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicwhale/subscriptions","organizations_url":"https://api.github.com/users/epicwhale/orgs","repos_url":"https://api.github.com/users/epicwhale/repos","events_url":"https://api.github.com/users/epicwhale/events{/privacy}","received_events_url":"https://api.github.com/users/epicwhale/received_events","type":"User","site_admin":false},"repo":{"id":115778241,"name":"cookiecutter-django","full_name":"epicwhale/cookiecutter-django","owner":{"login":"epicwhale","id":670655,"avatar_url":"https://avatars0.githubusercontent.com/u/670655?v=4","gravatar_id":"","url":"https://api.github.com/users/epicwhale","html_url":"https://github.com/epicwhale","followers_url":"https://api.github.com/users/epicwhale/followers","following_url":"https://api.github.com/users/epicwhale/following{/other_user}","gists_url":"https://api.github.com/users/epicwhale/gists{/gist_id}","starred_url":"https://api.github.com/users/epicwhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicwhale/subscriptions","organizations_url":"https://api.github.com/users/epicwhale/orgs","repos_url":"https://api.github.com/users/epicwhale/repos","events_url":"https://api.github.com/users/epicwhale/events{/privacy}","received_events_url":"https://api.github.com/users/epicwhale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epicwhale/cookiecutter-django","description":"Cookiecutter Django is a framework for jumpstarting production-ready Django projects quickly.","fork":true,"url":"https://api.github.com/repos/epicwhale/cookiecutter-django","forks_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/forks","keys_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/teams","hooks_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/hooks","issue_events_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/issues/events{/number}","events_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/events","assignees_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/assignees{/user}","branches_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/branches{/branch}","tags_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/tags","blobs_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/statuses/{sha}","languages_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/languages","stargazers_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/stargazers","contributors_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/contributors","subscribers_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/subscribers","subscription_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/subscription","commits_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/contents/{+path}","compare_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/merges","archive_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/downloads","issues_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/issues{/number}","pulls_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/pulls{/number}","milestones_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/milestones{/number}","notifications_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/labels{/name}","releases_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/releases{/id}","deployments_url":"https://api.github.com/repos/epicwhale/cookiecutter-django/deployments","created_at":"2017-12-30T06:20:57Z","updated_at":"2017-12-30T06:20:59Z","pushed_at":"2018-01-25T09:36:07Z","git_url":"git://github.com/epicwhale/cookiecutter-django.git","ssh_url":"git@github.com:epicwhale/cookiecutter-django.git","clone_url":"https://github.com/epicwhale/cookiecutter-django.git","svn_url":"https://github.com/epicwhale/cookiecutter-django","homepage":"","size":3385,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydanny:master","ref":"master","sha":"8725809f5e24676990fed2a3772ba3dff5232ab5","user":{"login":"pydanny","id":62857,"avatar_url":"https://avatars1.githubusercontent.com/u/62857?v=4","gravatar_id":"","url":"https://api.github.com/users/pydanny","html_url":"https://github.com/pydanny","followers_url":"https://api.github.com/users/pydanny/followers","following_url":"https://api.github.com/users/pydanny/following{/other_user}","gists_url":"https://api.github.com/users/pydanny/gists{/gist_id}","starred_url":"https://api.github.com/users/pydanny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydanny/subscriptions","organizations_url":"https://api.github.com/users/pydanny/orgs","repos_url":"https://api.github.com/users/pydanny/repos","events_url":"https://api.github.com/users/pydanny/events{/privacy}","received_events_url":"https://api.github.com/users/pydanny/received_events","type":"User","site_admin":false},"repo":{"id":12115269,"name":"cookiecutter-django","full_name":"pydanny/cookiecutter-django","owner":{"login":"pydanny","id":62857,"avatar_url":"https://avatars1.githubusercontent.com/u/62857?v=4","gravatar_id":"","url":"https://api.github.com/users/pydanny","html_url":"https://github.com/pydanny","followers_url":"https://api.github.com/users/pydanny/followers","following_url":"https://api.github.com/users/pydanny/following{/other_user}","gists_url":"https://api.github.com/users/pydanny/gists{/gist_id}","starred_url":"https://api.github.com/users/pydanny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydanny/subscriptions","organizations_url":"https://api.github.com/users/pydanny/orgs","repos_url":"https://api.github.com/users/pydanny/repos","events_url":"https://api.github.com/users/pydanny/events{/privacy}","received_events_url":"https://api.github.com/users/pydanny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pydanny/cookiecutter-django","description":"Cookiecutter Django is a framework for jumpstarting production-ready Django projects quickly.","fork":false,"url":"https://api.github.com/repos/pydanny/cookiecutter-django","forks_url":"https://api.github.com/repos/pydanny/cookiecutter-django/forks","keys_url":"https://api.github.com/repos/pydanny/cookiecutter-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydanny/cookiecutter-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydanny/cookiecutter-django/teams","hooks_url":"https://api.github.com/repos/pydanny/cookiecutter-django/hooks","issue_events_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/events{/number}","events_url":"https://api.github.com/repos/pydanny/cookiecutter-django/events","assignees_url":"https://api.github.com/repos/pydanny/cookiecutter-django/assignees{/user}","branches_url":"https://api.github.com/repos/pydanny/cookiecutter-django/branches{/branch}","tags_url":"https://api.github.com/repos/pydanny/cookiecutter-django/tags","blobs_url":"https://api.github.com/repos/pydanny/cookiecutter-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydanny/cookiecutter-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydanny/cookiecutter-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydanny/cookiecutter-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydanny/cookiecutter-django/statuses/{sha}","languages_url":"https://api.github.com/repos/pydanny/cookiecutter-django/languages","stargazers_url":"https://api.github.com/repos/pydanny/cookiecutter-django/stargazers","contributors_url":"https://api.github.com/repos/pydanny/cookiecutter-django/contributors","subscribers_url":"https://api.github.com/repos/pydanny/cookiecutter-django/subscribers","subscription_url":"https://api.github.com/repos/pydanny/cookiecutter-django/subscription","commits_url":"https://api.github.com/repos/pydanny/cookiecutter-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydanny/cookiecutter-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydanny/cookiecutter-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydanny/cookiecutter-django/contents/{+path}","compare_url":"https://api.github.com/repos/pydanny/cookiecutter-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydanny/cookiecutter-django/merges","archive_url":"https://api.github.com/repos/pydanny/cookiecutter-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydanny/cookiecutter-django/downloads","issues_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues{/number}","pulls_url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls{/number}","milestones_url":"https://api.github.com/repos/pydanny/cookiecutter-django/milestones{/number}","notifications_url":"https://api.github.com/repos/pydanny/cookiecutter-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydanny/cookiecutter-django/labels{/name}","releases_url":"https://api.github.com/repos/pydanny/cookiecutter-django/releases{/id}","deployments_url":"https://api.github.com/repos/pydanny/cookiecutter-django/deployments","created_at":"2013-08-14T17:43:31Z","updated_at":"2018-02-04T16:15:58Z","pushed_at":"2018-02-04T11:38:53Z","git_url":"git://github.com/pydanny/cookiecutter-django.git","ssh_url":"git@github.com:pydanny/cookiecutter-django.git","clone_url":"https://github.com/pydanny/cookiecutter-django.git","svn_url":"https://github.com/pydanny/cookiecutter-django","homepage":"","size":3424,"stargazers_count":3331,"watchers_count":3331,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1024,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1024,"open_issues":122,"watchers":3331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421"},"html":{"href":"https://github.com/pydanny/cookiecutter-django/pull/1421"},"issue":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1421"},"comments":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1421/comments"},"review_comments":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421/comments"},"review_comment":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1421/commits"},"statuses":{"href":"https://api.github.com/repos/pydanny/cookiecutter-django/statuses/9ca98e02d48bbf81d5b67904702aef1c04ea7d48"}},"author_association":"NONE"}}
{"actor":{"display_login":"browniebroke"}}