{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/226259229","pull_request_review_id":166034778,"id":226259229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI1OTIyOQ==","diff_hunk":"@@ -45,17 +45,17 @@ void SPISlave::frequency(int hz)\n \n int SPISlave::receive(void)\n {\n-    return (spi_slave_receive(&_spi));\n+    return 0;//(spi_slave_receive(&_spi));","path":"drivers/SPISlave.cpp","position":null,"original_position":30,"commit_id":"6d2dd1333f1d6f53fd3832ad5e7054bbfb43fc4b","original_commit_id":"8f1f3b0071ef7d381becdfca876031b7370ee946","user":{"login":"ithinuel","id":4605303,"node_id":"MDQ6VXNlcjQ2MDUzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4605303?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinuel","html_url":"https://github.com/ithinuel","followers_url":"https://api.github.com/users/ithinuel/followers","following_url":"https://api.github.com/users/ithinuel/following{/other_user}","gists_url":"https://api.github.com/users/ithinuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinuel/subscriptions","organizations_url":"https://api.github.com/users/ithinuel/orgs","repos_url":"https://api.github.com/users/ithinuel/repos","events_url":"https://api.github.com/users/ithinuel/events{/privacy}","received_events_url":"https://api.github.com/users/ithinuel/received_events","type":"User","site_admin":false},"body":"It looks like I forgot the commit SPISlave driver changes. This should be ok now.","created_at":"2018-10-18T10:54:39Z","updated_at":"2018-10-18T10:54:39Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8445#discussion_r226259229","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/226259229"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8445#discussion_r226259229"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445"}},"in_reply_to_id":225730828},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445","id":223269748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjY5NzQ4","html_url":"https://github.com/ARMmbed/mbed-os/pull/8445","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8445.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8445.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8445","number":8445,"state":"open","locked":false,"title":"RFC SPI: Reference Implementation.","user":{"login":"ithinuel","id":4605303,"node_id":"MDQ6VXNlcjQ2MDUzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4605303?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinuel","html_url":"https://github.com/ithinuel","followers_url":"https://api.github.com/users/ithinuel/followers","following_url":"https://api.github.com/users/ithinuel/following{/other_user}","gists_url":"https://api.github.com/users/ithinuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinuel/subscriptions","organizations_url":"https://api.github.com/users/ithinuel/orgs","repos_url":"https://api.github.com/users/ithinuel/repos","events_url":"https://api.github.com/users/ithinuel/events{/privacy}","received_events_url":"https://api.github.com/users/ithinuel/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR contains reference implementations of the SPI HAL RFC changes for the FRDM-K66F and NUCLEO_F429ZI boards.\r\n\r\n#### Known issues :\r\n- The implementation for the K66F does not support least significant bit first in slave mode. This is due to a hardware limitation that needs to be workedaround in software.\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [x] Breaking change\r\n\r\n","created_at":"2018-10-16T14:19:50Z","updated_at":"2018-10-18T10:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ec04584d7a613970eb7498407127ef78e76392","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false},{"id":1013456810,"node_id":"MDU6TGFiZWwxMDEzNDU2ODEw","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%20feature%20branch","name":"release-version: feature branch","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8445/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/6d2dd1333f1d6f53fd3832ad5e7054bbfb43fc4b","head":{"label":"ithinuel:rfc-spi-overhaul-ref-impl","ref":"rfc-spi-overhaul-ref-impl","sha":"6d2dd1333f1d6f53fd3832ad5e7054bbfb43fc4b","user":{"login":"ithinuel","id":4605303,"node_id":"MDQ6VXNlcjQ2MDUzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4605303?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinuel","html_url":"https://github.com/ithinuel","followers_url":"https://api.github.com/users/ithinuel/followers","following_url":"https://api.github.com/users/ithinuel/following{/other_user}","gists_url":"https://api.github.com/users/ithinuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinuel/subscriptions","organizations_url":"https://api.github.com/users/ithinuel/orgs","repos_url":"https://api.github.com/users/ithinuel/repos","events_url":"https://api.github.com/users/ithinuel/events{/privacy}","received_events_url":"https://api.github.com/users/ithinuel/received_events","type":"User","site_admin":false},"repo":{"id":116013876,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwMTM4NzY=","name":"mbed-os","full_name":"ithinuel/mbed-os","private":false,"owner":{"login":"ithinuel","id":4605303,"node_id":"MDQ6VXNlcjQ2MDUzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4605303?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinuel","html_url":"https://github.com/ithinuel","followers_url":"https://api.github.com/users/ithinuel/followers","following_url":"https://api.github.com/users/ithinuel/following{/other_user}","gists_url":"https://api.github.com/users/ithinuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinuel/subscriptions","organizations_url":"https://api.github.com/users/ithinuel/orgs","repos_url":"https://api.github.com/users/ithinuel/repos","events_url":"https://api.github.com/users/ithinuel/events{/privacy}","received_events_url":"https://api.github.com/users/ithinuel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ithinuel/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/ithinuel/mbed-os","forks_url":"https://api.github.com/repos/ithinuel/mbed-os/forks","keys_url":"https://api.github.com/repos/ithinuel/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ithinuel/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ithinuel/mbed-os/teams","hooks_url":"https://api.github.com/repos/ithinuel/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ithinuel/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ithinuel/mbed-os/events","assignees_url":"https://api.github.com/repos/ithinuel/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ithinuel/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ithinuel/mbed-os/tags","blobs_url":"https://api.github.com/repos/ithinuel/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ithinuel/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ithinuel/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ithinuel/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ithinuel/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ithinuel/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ithinuel/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ithinuel/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ithinuel/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ithinuel/mbed-os/subscription","commits_url":"https://api.github.com/repos/ithinuel/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ithinuel/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ithinuel/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ithinuel/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ithinuel/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ithinuel/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ithinuel/mbed-os/merges","archive_url":"https://api.github.com/repos/ithinuel/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ithinuel/mbed-os/downloads","issues_url":"https://api.github.com/repos/ithinuel/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ithinuel/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ithinuel/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ithinuel/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ithinuel/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ithinuel/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ithinuel/mbed-os/deployments","created_at":"2018-01-02T12:39:52Z","updated_at":"2018-09-13T22:24:17Z","pushed_at":"2018-10-18T10:53:45Z","git_url":"git://github.com/ithinuel/mbed-os.git","ssh_url":"git@github.com:ithinuel/mbed-os.git","clone_url":"https://github.com/ithinuel/mbed-os.git","svn_url":"https://github.com/ithinuel/mbed-os","homepage":"https://mbed.com","size":224809,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:feature-hal-spec-spi","ref":"feature-hal-spec-spi","sha":"689890e1de06de8aa983e10316a4c5b861c63e75","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-10-18T02:42:10Z","pushed_at":"2018-10-18T10:53:47Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":233670,"stargazers_count":1996,"watchers_count":1996,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1640,"mirror_url":null,"archived":false,"open_issues_count":433,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1640,"open_issues":433,"watchers":1996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8445"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8445"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8445/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8445/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/6d2dd1333f1d6f53fd3832ad5e7054bbfb43fc4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ithinuel"}}