{"action":"created","issue":{"url":"https://api.github.com/repos/svg/svgo/issues/978","repository_url":"https://api.github.com/repos/svg/svgo","labels_url":"https://api.github.com/repos/svg/svgo/issues/978/labels{/name}","comments_url":"https://api.github.com/repos/svg/svgo/issues/978/comments","events_url":"https://api.github.com/repos/svg/svgo/issues/978/events","html_url":"https://github.com/svg/svgo/pull/978","id":330840141,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzUwOTEw","number":978,"title":"tweak: do not collapse group properties to children if they contain filters.","user":{"login":"stristr","id":1203925,"node_id":"MDQ6VXNlcjEyMDM5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1203925?v=4","gravatar_id":"","url":"https://api.github.com/users/stristr","html_url":"https://github.com/stristr","followers_url":"https://api.github.com/users/stristr/followers","following_url":"https://api.github.com/users/stristr/following{/other_user}","gists_url":"https://api.github.com/users/stristr/gists{/gist_id}","starred_url":"https://api.github.com/users/stristr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stristr/subscriptions","organizations_url":"https://api.github.com/users/stristr/orgs","repos_url":"https://api.github.com/users/stristr/repos","events_url":"https://api.github.com/users/stristr/events{/privacy}","received_events_url":"https://api.github.com/users/stristr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-09T01:06:16Z","updated_at":"2018-09-16T18:02:59Z","closed_at":"2018-09-15T11:45:48Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/svg/svgo/pulls/978","html_url":"https://github.com/svg/svgo/pull/978","diff_url":"https://github.com/svg/svgo/pull/978.diff","patch_url":"https://github.com/svg/svgo/pull/978.patch"},"body":"Some CSS filters have layout properties, a canonical example being:\r\n\r\n```\r\n<svg>\r\n  <defs>\r\n    <filter id=\"a\">\r\n      <feOffset dx=\"10\" />\r\n      <feGaussianBlur …/>\r\n      <feColorMatrix …/>\r\n    </filter>\r\n  </defs>\r\n  <g filter=\"url(#a)\">\r\n    <circle … />\r\n  </g>\r\n</svg>\r\n```\r\n\r\n(This happens to be how Figma does drop shadows, which is how I noticed this.)\r\n\r\nWhen `svgo` pushes the `filter` attribute down to the `<circle />`, the gaussian blur gets awkwardly clipped on the top-left edges of the circle's bounding box. Based on this, I concluded it's best to not push down filters, just like `clip-path` and so forth."},"comment":{"url":"https://api.github.com/repos/svg/svgo/issues/comments/421805351","html_url":"https://github.com/svg/svgo/pull/978#issuecomment-421805351","issue_url":"https://api.github.com/repos/svg/svgo/issues/978","id":421805351,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTgwNTM1MQ==","user":{"login":"GreLI","id":1467392,"node_id":"MDQ6VXNlcjE0NjczOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1467392?v=4","gravatar_id":"","url":"https://api.github.com/users/GreLI","html_url":"https://github.com/GreLI","followers_url":"https://api.github.com/users/GreLI/followers","following_url":"https://api.github.com/users/GreLI/following{/other_user}","gists_url":"https://api.github.com/users/GreLI/gists{/gist_id}","starred_url":"https://api.github.com/users/GreLI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GreLI/subscriptions","organizations_url":"https://api.github.com/users/GreLI/orgs","repos_url":"https://api.github.com/users/GreLI/repos","events_url":"https://api.github.com/users/GreLI/events{/privacy}","received_events_url":"https://api.github.com/users/GreLI/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T18:02:59Z","updated_at":"2018-09-16T18:02:59Z","author_association":"MEMBER","body":"SVGO v1.1.0 with the fix has been just released."}}
{"actor":{"display_login":"GreLI"}}