{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/222698776","pull_request_review_id":161648906,"id":222698776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjY5ODc3Ng==","diff_hunk":"@@ -13,30 +13,36 @@ config BOARD\n if UART_CONSOLE\n \n config UART_STM32_PORT_1\n-\tdefault y\n+\tdef_bool y","path":"boards/arm/96b_argonkey/Kconfig.defconfig","position":5,"original_position":5,"commit_id":"c2f005d10f5c28086e20cc252df1e7ffbd93fd1b","original_commit_id":"1c76740b27fcd31ca5f691f206717f36e2ee4a79","user":{"login":"Mani-Sadhasivam","id":9375848,"node_id":"MDQ6VXNlcjkzNzU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/9375848?v=4","gravatar_id":"","url":"https://api.github.com/users/Mani-Sadhasivam","html_url":"https://github.com/Mani-Sadhasivam","followers_url":"https://api.github.com/users/Mani-Sadhasivam/followers","following_url":"https://api.github.com/users/Mani-Sadhasivam/following{/other_user}","gists_url":"https://api.github.com/users/Mani-Sadhasivam/gists{/gist_id}","starred_url":"https://api.github.com/users/Mani-Sadhasivam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mani-Sadhasivam/subscriptions","organizations_url":"https://api.github.com/users/Mani-Sadhasivam/orgs","repos_url":"https://api.github.com/users/Mani-Sadhasivam/repos","events_url":"https://api.github.com/users/Mani-Sadhasivam/events{/privacy}","received_events_url":"https://api.github.com/users/Mani-Sadhasivam/received_events","type":"User","site_admin":false},"body":"I'm not sure either. Looking at some other boards like `reel_board` I thought that we should use `def_bool` for providing boolean choices and `default` for other than booleans.","created_at":"2018-10-04T14:44:35Z","updated_at":"2018-10-04T14:44:35Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10367#discussion_r222698776","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/222698776"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10367#discussion_r222698776"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367"}},"in_reply_to_id":222678081},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367","id":220269512,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjY5NTEy","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10367","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10367.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10367.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10367","number":10367,"state":"open","locked":false,"title":"96Boards: Adapt board configuration guidelines","user":{"login":"Mani-Sadhasivam","id":9375848,"node_id":"MDQ6VXNlcjkzNzU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/9375848?v=4","gravatar_id":"","url":"https://api.github.com/users/Mani-Sadhasivam","html_url":"https://github.com/Mani-Sadhasivam","followers_url":"https://api.github.com/users/Mani-Sadhasivam/followers","following_url":"https://api.github.com/users/Mani-Sadhasivam/following{/other_user}","gists_url":"https://api.github.com/users/Mani-Sadhasivam/gists{/gist_id}","starred_url":"https://api.github.com/users/Mani-Sadhasivam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mani-Sadhasivam/subscriptions","organizations_url":"https://api.github.com/users/Mani-Sadhasivam/orgs","repos_url":"https://api.github.com/users/Mani-Sadhasivam/repos","events_url":"https://api.github.com/users/Mani-Sadhasivam/events{/privacy}","received_events_url":"https://api.github.com/users/Mani-Sadhasivam/received_events","type":"User","site_admin":false},"body":"This PR modifies the 96Boards board support to adapt to the default board configuration guidelines as per http://docs.zephyrproject.org/porting/board_porting.html#default-board-configuration. Reference is taken from: https://github.com/zephyrproject-rtos/zephyr/tree/master/boards/arm/nucleo_f429zi\r\n\r\nFollowing supported 96Boards are modified:\r\n\r\n1. 96b_argonkey\r\n2. 96b_carbon\r\n3. 96b_carbon_nrf51\r\n4. 96b_nitrogen\r\n5. 96b_neonkey\r\n\r\nFixes: #9233 \r\n\r\nSigned-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>","created_at":"2018-10-04T07:01:47Z","updated_at":"2018-10-04T14:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e5f6ebcaa2604dcc514bf6a65cf6fbeebcd4fd0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MaureenHelm","id":6172539,"node_id":"MDQ6VXNlcjYxNzI1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"dbkinder","id":11063618,"node_id":"MDQ6VXNlcjExMDYzNjE4","avatar_url":"https://avatars0.githubusercontent.com/u/11063618?v=4","gravatar_id":"","url":"https://api.github.com/users/dbkinder","html_url":"https://github.com/dbkinder","followers_url":"https://api.github.com/users/dbkinder/followers","following_url":"https://api.github.com/users/dbkinder/following{/other_user}","gists_url":"https://api.github.com/users/dbkinder/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkinder/subscriptions","organizations_url":"https://api.github.com/users/dbkinder/orgs","repos_url":"https://api.github.com/users/dbkinder/repos","events_url":"https://api.github.com/users/dbkinder/events{/privacy}","received_events_url":"https://api.github.com/users/dbkinder/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":700753703,"node_id":"MDU6TGFiZWw3MDA3NTM3MDM=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Boards","name":"area: Boards","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10367/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/c2f005d10f5c28086e20cc252df1e7ffbd93fd1b","head":{"label":"Mani-Sadhasivam:96b_cleanup","ref":"96b_cleanup","sha":"c2f005d10f5c28086e20cc252df1e7ffbd93fd1b","user":{"login":"Mani-Sadhasivam","id":9375848,"node_id":"MDQ6VXNlcjkzNzU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/9375848?v=4","gravatar_id":"","url":"https://api.github.com/users/Mani-Sadhasivam","html_url":"https://github.com/Mani-Sadhasivam","followers_url":"https://api.github.com/users/Mani-Sadhasivam/followers","following_url":"https://api.github.com/users/Mani-Sadhasivam/following{/other_user}","gists_url":"https://api.github.com/users/Mani-Sadhasivam/gists{/gist_id}","starred_url":"https://api.github.com/users/Mani-Sadhasivam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mani-Sadhasivam/subscriptions","organizations_url":"https://api.github.com/users/Mani-Sadhasivam/orgs","repos_url":"https://api.github.com/users/Mani-Sadhasivam/repos","events_url":"https://api.github.com/users/Mani-Sadhasivam/events{/privacy}","received_events_url":"https://api.github.com/users/Mani-Sadhasivam/received_events","type":"User","site_admin":false},"repo":{"id":97301817,"node_id":"MDEwOlJlcG9zaXRvcnk5NzMwMTgxNw==","name":"zephyr","full_name":"Mani-Sadhasivam/zephyr","private":false,"owner":{"login":"Mani-Sadhasivam","id":9375848,"node_id":"MDQ6VXNlcjkzNzU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/9375848?v=4","gravatar_id":"","url":"https://api.github.com/users/Mani-Sadhasivam","html_url":"https://github.com/Mani-Sadhasivam","followers_url":"https://api.github.com/users/Mani-Sadhasivam/followers","following_url":"https://api.github.com/users/Mani-Sadhasivam/following{/other_user}","gists_url":"https://api.github.com/users/Mani-Sadhasivam/gists{/gist_id}","starred_url":"https://api.github.com/users/Mani-Sadhasivam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mani-Sadhasivam/subscriptions","organizations_url":"https://api.github.com/users/Mani-Sadhasivam/orgs","repos_url":"https://api.github.com/users/Mani-Sadhasivam/repos","events_url":"https://api.github.com/users/Mani-Sadhasivam/events{/privacy}","received_events_url":"https://api.github.com/users/Mani-Sadhasivam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Mani-Sadhasivam/zephyr","description":"Repo for my personal contributions to Zephyr","fork":true,"url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr","forks_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/forks","keys_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/teams","hooks_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/hooks","issue_events_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/events","assignees_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/tags","blobs_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/languages","stargazers_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/stargazers","contributors_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/contributors","subscribers_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/subscribers","subscription_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/subscription","commits_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/merges","archive_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/downloads","issues_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/Mani-Sadhasivam/zephyr/deployments","created_at":"2017-07-15T08:11:19Z","updated_at":"2018-08-15T02:32:33Z","pushed_at":"2018-10-04T10:42:01Z","git_url":"git://github.com/Mani-Sadhasivam/zephyr.git","ssh_url":"git@github.com:Mani-Sadhasivam/zephyr.git","clone_url":"https://github.com/Mani-Sadhasivam/zephyr.git","svn_url":"https://github.com/Mani-Sadhasivam/zephyr","homepage":"http://zephyrproject.org/doc","size":144548,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"3d1a659019c8191af073a0d973c86172eb60ffe3","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-10-04T12:55:37Z","pushed_at":"2018-10-04T14:42:11Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":144911,"stargazers_count":1241,"watchers_count":1241,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":813,"mirror_url":null,"archived":false,"open_issues_count":1051,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":813,"open_issues":1051,"watchers":1241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10367"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10367"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10367/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10367/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/c2f005d10f5c28086e20cc252df1e7ffbd93fd1b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Mani-Sadhasivam"}}