{"action":"closed","number":683,"pull_request":{"url":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683","id":228809941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODA5OTQx","html_url":"https://github.com/p4lang/behavioral-model/pull/683","diff_url":"https://github.com/p4lang/behavioral-model/pull/683.diff","patch_url":"https://github.com/p4lang/behavioral-model/pull/683.patch","issue_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/683","number":683,"state":"closed","locked":false,"title":"Do not use futures in simple_switch_grpc GTests","user":{"login":"antoninbas","id":2495809,"node_id":"MDQ6VXNlcjI0OTU4MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2495809?v=4","gravatar_id":"","url":"https://api.github.com/users/antoninbas","html_url":"https://github.com/antoninbas","followers_url":"https://api.github.com/users/antoninbas/followers","following_url":"https://api.github.com/users/antoninbas/following{/other_user}","gists_url":"https://api.github.com/users/antoninbas/gists{/gist_id}","starred_url":"https://api.github.com/users/antoninbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoninbas/subscriptions","organizations_url":"https://api.github.com/users/antoninbas/orgs","repos_url":"https://api.github.com/users/antoninbas/repos","events_url":"https://api.github.com/users/antoninbas/events{/privacy}","received_events_url":"https://api.github.com/users/antoninbas/received_events","type":"User","site_admin":false},"body":"As a cheap way of reading from a gRPC steam asynchronously. I think\r\nthere was a possibility of multiple futures existing simultaneously and\r\ncalling Read from different threads, which is invalid. It was also\r\nbasically impossible to handle failure cases and cleanup was difficult.","created_at":"2018-11-06T19:35:12Z","updated_at":"2018-11-06T21:05:51Z","closed_at":"2018-11-06T21:05:51Z","merged_at":"2018-11-06T21:05:51Z","merge_commit_sha":"871dfa95c287fc5cad361c81d472b4ff15e120f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683/commits","review_comments_url":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683/comments","review_comment_url":"https://api.github.com/repos/p4lang/behavioral-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/683/comments","statuses_url":"https://api.github.com/repos/p4lang/behavioral-model/statuses/ebf7fec000b207ad0346925291fded6f7fcde0f3","head":{"label":"p4lang:antonin/simple-switch-grpc-do-not-use-futures-in-gtests","ref":"antonin/simple-switch-grpc-do-not-use-futures-in-gtests","sha":"ebf7fec000b207ad0346925291fded6f7fcde0f3","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":29883110,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MzExMA==","name":"behavioral-model","full_name":"p4lang/behavioral-model","private":false,"owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/p4lang/behavioral-model","description":"Rewrite of the behavioral model as a C++ project without auto-generated code (except for the PD interface)","fork":false,"url":"https://api.github.com/repos/p4lang/behavioral-model","forks_url":"https://api.github.com/repos/p4lang/behavioral-model/forks","keys_url":"https://api.github.com/repos/p4lang/behavioral-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/behavioral-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/behavioral-model/teams","hooks_url":"https://api.github.com/repos/p4lang/behavioral-model/hooks","issue_events_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/behavioral-model/events","assignees_url":"https://api.github.com/repos/p4lang/behavioral-model/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/behavioral-model/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/behavioral-model/tags","blobs_url":"https://api.github.com/repos/p4lang/behavioral-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/behavioral-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/behavioral-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/behavioral-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/behavioral-model/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/behavioral-model/languages","stargazers_url":"https://api.github.com/repos/p4lang/behavioral-model/stargazers","contributors_url":"https://api.github.com/repos/p4lang/behavioral-model/contributors","subscribers_url":"https://api.github.com/repos/p4lang/behavioral-model/subscribers","subscription_url":"https://api.github.com/repos/p4lang/behavioral-model/subscription","commits_url":"https://api.github.com/repos/p4lang/behavioral-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/behavioral-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/behavioral-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/behavioral-model/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/behavioral-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/behavioral-model/merges","archive_url":"https://api.github.com/repos/p4lang/behavioral-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/behavioral-model/downloads","issues_url":"https://api.github.com/repos/p4lang/behavioral-model/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/behavioral-model/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/behavioral-model/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/behavioral-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/behavioral-model/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/behavioral-model/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/behavioral-model/deployments","created_at":"2015-01-26T21:43:23Z","updated_at":"2018-11-06T17:34:06Z","pushed_at":"2018-11-06T21:05:50Z","git_url":"git://github.com/p4lang/behavioral-model.git","ssh_url":"git@github.com:p4lang/behavioral-model.git","clone_url":"https://github.com/p4lang/behavioral-model.git","svn_url":"https://github.com/p4lang/behavioral-model","homepage":null,"size":33481,"stargazers_count":119,"watchers_count":119,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":133,"open_issues":23,"watchers":119,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"6d02c1b9099c12ef3ee5e249a4d84fa4e50b5daf","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":29883110,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MzExMA==","name":"behavioral-model","full_name":"p4lang/behavioral-model","private":false,"owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/p4lang/behavioral-model","description":"Rewrite of the behavioral model as a C++ project without auto-generated code (except for the PD interface)","fork":false,"url":"https://api.github.com/repos/p4lang/behavioral-model","forks_url":"https://api.github.com/repos/p4lang/behavioral-model/forks","keys_url":"https://api.github.com/repos/p4lang/behavioral-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/behavioral-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/behavioral-model/teams","hooks_url":"https://api.github.com/repos/p4lang/behavioral-model/hooks","issue_events_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/behavioral-model/events","assignees_url":"https://api.github.com/repos/p4lang/behavioral-model/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/behavioral-model/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/behavioral-model/tags","blobs_url":"https://api.github.com/repos/p4lang/behavioral-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/behavioral-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/behavioral-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/behavioral-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/behavioral-model/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/behavioral-model/languages","stargazers_url":"https://api.github.com/repos/p4lang/behavioral-model/stargazers","contributors_url":"https://api.github.com/repos/p4lang/behavioral-model/contributors","subscribers_url":"https://api.github.com/repos/p4lang/behavioral-model/subscribers","subscription_url":"https://api.github.com/repos/p4lang/behavioral-model/subscription","commits_url":"https://api.github.com/repos/p4lang/behavioral-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/behavioral-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/behavioral-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/behavioral-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/behavioral-model/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/behavioral-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/behavioral-model/merges","archive_url":"https://api.github.com/repos/p4lang/behavioral-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/behavioral-model/downloads","issues_url":"https://api.github.com/repos/p4lang/behavioral-model/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/behavioral-model/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/behavioral-model/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/behavioral-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/behavioral-model/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/behavioral-model/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/behavioral-model/deployments","created_at":"2015-01-26T21:43:23Z","updated_at":"2018-11-06T17:34:06Z","pushed_at":"2018-11-06T21:05:50Z","git_url":"git://github.com/p4lang/behavioral-model.git","ssh_url":"git@github.com:p4lang/behavioral-model.git","clone_url":"https://github.com/p4lang/behavioral-model.git","svn_url":"https://github.com/p4lang/behavioral-model","homepage":null,"size":33481,"stargazers_count":119,"watchers_count":119,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":133,"open_issues":23,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683"},"html":{"href":"https://github.com/p4lang/behavioral-model/pull/683"},"issue":{"href":"https://api.github.com/repos/p4lang/behavioral-model/issues/683"},"comments":{"href":"https://api.github.com/repos/p4lang/behavioral-model/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/behavioral-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/behavioral-model/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/behavioral-model/statuses/ebf7fec000b207ad0346925291fded6f7fcde0f3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"antoninbas","id":2495809,"node_id":"MDQ6VXNlcjI0OTU4MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/2495809?v=4","gravatar_id":"","url":"https://api.github.com/users/antoninbas","html_url":"https://github.com/antoninbas","followers_url":"https://api.github.com/users/antoninbas/followers","following_url":"https://api.github.com/users/antoninbas/following{/other_user}","gists_url":"https://api.github.com/users/antoninbas/gists{/gist_id}","starred_url":"https://api.github.com/users/antoninbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoninbas/subscriptions","organizations_url":"https://api.github.com/users/antoninbas/orgs","repos_url":"https://api.github.com/users/antoninbas/repos","events_url":"https://api.github.com/users/antoninbas/events{/privacy}","received_events_url":"https://api.github.com/users/antoninbas/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":122,"deletions":157,"changed_files":4}}
{"actor":{"display_login":"antoninbas"}}