{"action":"created","comment":{"url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/comments/177484014","pull_request_review_id":107354416,"id":177484014,"diff_hunk":"@@ -0,0 +1,34 @@\n+package com.fvv.bookstore.dao;\n+\n+import java.sql.Connection;\n+import java.sql.DriverManager;\n+import java.sql.SQLException;\n+\n+/**\n+ * Class Connection Factory to implement a connection with the database.\n+ * \n+ * Created on 03/21/2018\n+ * @author Fatima Vasquez\n+ * @version 1.0\n+ */\n+public class ConnectionFactory {\n+\n+\tprivate static final String DB_DRIVER = \"com.mysql.jdbc.Driver\";\n+\tprivate static final String DB_URL = \"jdbc:mysql://localhost:3306/bookstore_db\";\n+\tprivate static final String DB_USER = \"root\";\n+\tprivate static final String DB_PASS = \"test1234\";","path":"src/main/java/com/fvv/bookstore/dao/ConnectionFactory.java","position":19,"original_position":19,"commit_id":"af371ffbd71d8a874c734e4378509f638785b346","original_commit_id":"af371ffbd71d8a874c734e4378509f638785b346","user":{"login":"cssantos0","id":20981337,"avatar_url":"https://avatars0.githubusercontent.com/u/20981337?v=4","gravatar_id":"","url":"https://api.github.com/users/cssantos0","html_url":"https://github.com/cssantos0","followers_url":"https://api.github.com/users/cssantos0/followers","following_url":"https://api.github.com/users/cssantos0/following{/other_user}","gists_url":"https://api.github.com/users/cssantos0/gists{/gist_id}","starred_url":"https://api.github.com/users/cssantos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssantos0/subscriptions","organizations_url":"https://api.github.com/users/cssantos0/orgs","repos_url":"https://api.github.com/users/cssantos0/repos","events_url":"https://api.github.com/users/cssantos0/events{/privacy}","received_events_url":"https://api.github.com/users/cssantos0/received_events","type":"User","site_admin":false},"body":"It is not a good idea to keep user/password in the code. For now its okay, but before ending the project you need to hide this.","created_at":"2018-03-27T16:12:12Z","updated_at":"2018-03-27T16:15:03Z","html_url":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2#discussion_r177484014","pull_request_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/comments/177484014"},"html":{"href":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2#discussion_r177484014"},"pull_request":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2","id":176970867,"html_url":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2","diff_url":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2.diff","patch_url":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2.patch","issue_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/2","number":2,"state":"open","locked":false,"title":"Interfaces daos exceptions","user":{"login":"fvv-vasquez","id":37545177,"avatar_url":"https://avatars3.githubusercontent.com/u/37545177?v=4","gravatar_id":"","url":"https://api.github.com/users/fvv-vasquez","html_url":"https://github.com/fvv-vasquez","followers_url":"https://api.github.com/users/fvv-vasquez/followers","following_url":"https://api.github.com/users/fvv-vasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvv-vasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvv-vasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvv-vasquez/subscriptions","organizations_url":"https://api.github.com/users/fvv-vasquez/orgs","repos_url":"https://api.github.com/users/fvv-vasquez/repos","events_url":"https://api.github.com/users/fvv-vasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvv-vasquez/received_events","type":"User","site_admin":false},"body":"Updated Javadoc in classes bean. \r\nInterfaces DAO. \r\nDAO Class of Book - Impl.\r\nClass book exception.\r\nBookstore database.","created_at":"2018-03-23T04:26:37Z","updated_at":"2018-03-27T16:15:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e51c29486baf972374134cd0cbdde6c7a8aae5ea","assignee":{"login":"cssantos0","id":20981337,"avatar_url":"https://avatars0.githubusercontent.com/u/20981337?v=4","gravatar_id":"","url":"https://api.github.com/users/cssantos0","html_url":"https://github.com/cssantos0","followers_url":"https://api.github.com/users/cssantos0/followers","following_url":"https://api.github.com/users/cssantos0/following{/other_user}","gists_url":"https://api.github.com/users/cssantos0/gists{/gist_id}","starred_url":"https://api.github.com/users/cssantos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssantos0/subscriptions","organizations_url":"https://api.github.com/users/cssantos0/orgs","repos_url":"https://api.github.com/users/cssantos0/repos","events_url":"https://api.github.com/users/cssantos0/events{/privacy}","received_events_url":"https://api.github.com/users/cssantos0/received_events","type":"User","site_admin":false},"assignees":[{"login":"cssantos0","id":20981337,"avatar_url":"https://avatars0.githubusercontent.com/u/20981337?v=4","gravatar_id":"","url":"https://api.github.com/users/cssantos0","html_url":"https://github.com/cssantos0","followers_url":"https://api.github.com/users/cssantos0/followers","following_url":"https://api.github.com/users/cssantos0/following{/other_user}","gists_url":"https://api.github.com/users/cssantos0/gists{/gist_id}","starred_url":"https://api.github.com/users/cssantos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssantos0/subscriptions","organizations_url":"https://api.github.com/users/cssantos0/orgs","repos_url":"https://api.github.com/users/cssantos0/repos","events_url":"https://api.github.com/users/cssantos0/events{/privacy}","received_events_url":"https://api.github.com/users/cssantos0/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2/commits","review_comments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2/comments","review_comment_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/2/comments","statuses_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/statuses/af371ffbd71d8a874c734e4378509f638785b346","head":{"label":"fvv-vasquez:interfaces-daos-exceptions","ref":"interfaces-daos-exceptions","sha":"af371ffbd71d8a874c734e4378509f638785b346","user":{"login":"fvv-vasquez","id":37545177,"avatar_url":"https://avatars3.githubusercontent.com/u/37545177?v=4","gravatar_id":"","url":"https://api.github.com/users/fvv-vasquez","html_url":"https://github.com/fvv-vasquez","followers_url":"https://api.github.com/users/fvv-vasquez/followers","following_url":"https://api.github.com/users/fvv-vasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvv-vasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvv-vasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvv-vasquez/subscriptions","organizations_url":"https://api.github.com/users/fvv-vasquez/orgs","repos_url":"https://api.github.com/users/fvv-vasquez/repos","events_url":"https://api.github.com/users/fvv-vasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvv-vasquez/received_events","type":"User","site_admin":false},"repo":{"id":125870597,"name":"prj-jse-bookstore","full_name":"fvv-vasquez/prj-jse-bookstore","owner":{"login":"fvv-vasquez","id":37545177,"avatar_url":"https://avatars3.githubusercontent.com/u/37545177?v=4","gravatar_id":"","url":"https://api.github.com/users/fvv-vasquez","html_url":"https://github.com/fvv-vasquez","followers_url":"https://api.github.com/users/fvv-vasquez/followers","following_url":"https://api.github.com/users/fvv-vasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvv-vasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvv-vasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvv-vasquez/subscriptions","organizations_url":"https://api.github.com/users/fvv-vasquez/orgs","repos_url":"https://api.github.com/users/fvv-vasquez/repos","events_url":"https://api.github.com/users/fvv-vasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvv-vasquez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fvv-vasquez/prj-jse-bookstore","description":"Desktop application to automate a book store","fork":false,"url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore","forks_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/forks","keys_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/teams","hooks_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/hooks","issue_events_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/events{/number}","events_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/events","assignees_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/assignees{/user}","branches_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/branches{/branch}","tags_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/tags","blobs_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/statuses/{sha}","languages_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/languages","stargazers_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/stargazers","contributors_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/contributors","subscribers_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/subscribers","subscription_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/subscription","commits_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/contents/{+path}","compare_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/merges","archive_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/downloads","issues_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues{/number}","pulls_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls{/number}","milestones_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/milestones{/number}","notifications_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/labels{/name}","releases_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/releases{/id}","deployments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/deployments","created_at":"2018-03-19T14:26:57Z","updated_at":"2018-03-20T21:06:18Z","pushed_at":"2018-03-27T02:39:33Z","git_url":"git://github.com/fvv-vasquez/prj-jse-bookstore.git","ssh_url":"git@github.com:fvv-vasquez/prj-jse-bookstore.git","clone_url":"https://github.com/fvv-vasquez/prj-jse-bookstore.git","svn_url":"https://github.com/fvv-vasquez/prj-jse-bookstore","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fvv-vasquez:master","ref":"master","sha":"68f6ec8b72109d28b7c32c11edebd7af4fd48715","user":{"login":"fvv-vasquez","id":37545177,"avatar_url":"https://avatars3.githubusercontent.com/u/37545177?v=4","gravatar_id":"","url":"https://api.github.com/users/fvv-vasquez","html_url":"https://github.com/fvv-vasquez","followers_url":"https://api.github.com/users/fvv-vasquez/followers","following_url":"https://api.github.com/users/fvv-vasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvv-vasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvv-vasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvv-vasquez/subscriptions","organizations_url":"https://api.github.com/users/fvv-vasquez/orgs","repos_url":"https://api.github.com/users/fvv-vasquez/repos","events_url":"https://api.github.com/users/fvv-vasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvv-vasquez/received_events","type":"User","site_admin":false},"repo":{"id":125870597,"name":"prj-jse-bookstore","full_name":"fvv-vasquez/prj-jse-bookstore","owner":{"login":"fvv-vasquez","id":37545177,"avatar_url":"https://avatars3.githubusercontent.com/u/37545177?v=4","gravatar_id":"","url":"https://api.github.com/users/fvv-vasquez","html_url":"https://github.com/fvv-vasquez","followers_url":"https://api.github.com/users/fvv-vasquez/followers","following_url":"https://api.github.com/users/fvv-vasquez/following{/other_user}","gists_url":"https://api.github.com/users/fvv-vasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/fvv-vasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvv-vasquez/subscriptions","organizations_url":"https://api.github.com/users/fvv-vasquez/orgs","repos_url":"https://api.github.com/users/fvv-vasquez/repos","events_url":"https://api.github.com/users/fvv-vasquez/events{/privacy}","received_events_url":"https://api.github.com/users/fvv-vasquez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fvv-vasquez/prj-jse-bookstore","description":"Desktop application to automate a book store","fork":false,"url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore","forks_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/forks","keys_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/teams","hooks_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/hooks","issue_events_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/events{/number}","events_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/events","assignees_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/assignees{/user}","branches_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/branches{/branch}","tags_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/tags","blobs_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/statuses/{sha}","languages_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/languages","stargazers_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/stargazers","contributors_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/contributors","subscribers_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/subscribers","subscription_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/subscription","commits_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/contents/{+path}","compare_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/merges","archive_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/downloads","issues_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues{/number}","pulls_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls{/number}","milestones_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/milestones{/number}","notifications_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/labels{/name}","releases_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/releases{/id}","deployments_url":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/deployments","created_at":"2018-03-19T14:26:57Z","updated_at":"2018-03-20T21:06:18Z","pushed_at":"2018-03-27T02:39:33Z","git_url":"git://github.com/fvv-vasquez/prj-jse-bookstore.git","ssh_url":"git@github.com:fvv-vasquez/prj-jse-bookstore.git","clone_url":"https://github.com/fvv-vasquez/prj-jse-bookstore.git","svn_url":"https://github.com/fvv-vasquez/prj-jse-bookstore","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2"},"html":{"href":"https://github.com/fvv-vasquez/prj-jse-bookstore/pull/2"},"issue":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/2"},"comments":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/fvv-vasquez/prj-jse-bookstore/statuses/af371ffbd71d8a874c734e4378509f638785b346"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cssantos0"}}