{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/169506557","pull_request_review_id":98043667,"id":169506557,"diff_hunk":"@@ -336,32 +336,41 @@ function serializeSegment(segment: UrlSegmentGroup, root: boolean): string {\n  *    sub-delims    = \"!\" / \"$\" / \"&\" / \"'\" / \"(\" / \")\"\n  *                     / \"*\" / \"+\" / \",\" / \";\" / \"=\"\n  */\n-export function encode(s: string): string {\n-  return encodeURIComponent(s)\n+export function encodeUriParams(s: string, type: 'query' | 'segment' = 'query'): string {","path":"packages/router/src/url_tree.ts","position":15,"original_position":15,"commit_id":"dc0de4a96ebfd4441feb2a5769ceb7917165ed93","original_commit_id":"dc0de4a96ebfd4441feb2a5769ceb7917165ed93","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"please update the API doc","created_at":"2018-02-21T00:44:43Z","updated_at":"2018-02-21T00:44:43Z","html_url":"https://github.com/angular/angular/pull/22337#discussion_r169506557","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/22337","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/169506557"},"html":{"href":"https://github.com/angular/angular/pull/22337#discussion_r169506557"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/22337"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/22337","id":170349037,"html_url":"https://github.com/angular/angular/pull/22337","diff_url":"https://github.com/angular/angular/pull/22337.diff","patch_url":"https://github.com/angular/angular/pull/22337.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/22337","number":22337,"state":"open","locked":false,"title":"fix(router): fix URL serialization so special characters are only enc…","user":{"login":"jasonaden","id":516168,"avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"body":"…oded where needed\r\n\r\nFixes: #10280\r\n\r\nThis PR might cause breaking changes. While it shouldn't generally cause any issues, if an application were relying on the over-aggressive encoding Angular previously used, this PR is less aggressive leaving more of the URL intact.","created_at":"2018-02-21T00:42:00Z","updated_at":"2018-02-21T00:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75972d7449567715af7d1dfa881f149a855c0098","assignee":null,"assignees":[],"requested_reviewers":[{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars3.githubusercontent.com/u/216296?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":375500771,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20router","name":"comp: router","color":"c7def8","default":false},{"id":221038051,"url":"https://api.github.com/repos/angular/angular/labels/flag:%20breaking%20change","name":"flag: breaking change","color":"d93f0b","default":false},{"id":592670120,"url":"https://api.github.com/repos/angular/angular/labels/hotlist:%20google","name":"hotlist: google","color":"d4c5f9","default":false},{"id":130606843,"url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/22337/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/22337/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/22337/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/dc0de4a96ebfd4441feb2a5769ceb7917165ed93","head":{"label":"jasonaden:fix_url_seralization","ref":"fix_url_seralization","sha":"dc0de4a96ebfd4441feb2a5769ceb7917165ed93","user":{"login":"jasonaden","id":516168,"avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"repo":{"id":79865337,"name":"angular","full_name":"jasonaden/angular","owner":{"login":"jasonaden","id":516168,"avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonaden/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/jasonaden/angular","forks_url":"https://api.github.com/repos/jasonaden/angular/forks","keys_url":"https://api.github.com/repos/jasonaden/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonaden/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonaden/angular/teams","hooks_url":"https://api.github.com/repos/jasonaden/angular/hooks","issue_events_url":"https://api.github.com/repos/jasonaden/angular/issues/events{/number}","events_url":"https://api.github.com/repos/jasonaden/angular/events","assignees_url":"https://api.github.com/repos/jasonaden/angular/assignees{/user}","branches_url":"https://api.github.com/repos/jasonaden/angular/branches{/branch}","tags_url":"https://api.github.com/repos/jasonaden/angular/tags","blobs_url":"https://api.github.com/repos/jasonaden/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonaden/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonaden/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonaden/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonaden/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonaden/angular/languages","stargazers_url":"https://api.github.com/repos/jasonaden/angular/stargazers","contributors_url":"https://api.github.com/repos/jasonaden/angular/contributors","subscribers_url":"https://api.github.com/repos/jasonaden/angular/subscribers","subscription_url":"https://api.github.com/repos/jasonaden/angular/subscription","commits_url":"https://api.github.com/repos/jasonaden/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonaden/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonaden/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonaden/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonaden/angular/contents/{+path}","compare_url":"https://api.github.com/repos/jasonaden/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonaden/angular/merges","archive_url":"https://api.github.com/repos/jasonaden/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonaden/angular/downloads","issues_url":"https://api.github.com/repos/jasonaden/angular/issues{/number}","pulls_url":"https://api.github.com/repos/jasonaden/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonaden/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonaden/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonaden/angular/labels{/name}","releases_url":"https://api.github.com/repos/jasonaden/angular/releases{/id}","deployments_url":"https://api.github.com/repos/jasonaden/angular/deployments","created_at":"2017-01-24T01:01:10Z","updated_at":"2017-01-24T01:01:32Z","pushed_at":"2018-02-21T00:39:30Z","git_url":"git://github.com/jasonaden/angular.git","ssh_url":"git@github.com:jasonaden/angular.git","clone_url":"https://github.com/jasonaden/angular.git","svn_url":"https://github.com/jasonaden/angular","homepage":"https://angular.io","size":84272,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1c1cbba04bd4914c2c73dc3ac8cc7f9fcc8c4a08","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-02-20T23:57:01Z","pushed_at":"2018-02-21T00:42:01Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":74018,"stargazers_count":33270,"watchers_count":33270,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8219,"mirror_url":null,"archived":false,"open_issues_count":2119,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8219,"open_issues":2119,"watchers":33270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/22337"},"html":{"href":"https://github.com/angular/angular/pull/22337"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/22337"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/22337/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/22337/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/22337/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/dc0de4a96ebfd4441feb2a5769ceb7917165ed93"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vicb"}}