{"action":"created","comment":{"url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/comments/196976128","pull_request_review_id":130626733,"id":196976128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njk3NjEyOA==","diff_hunk":"@@ -115,6 +118,7 @@ private void stream() throws ConnectionException {\n \n     private Optional<StartPosition> getPosition() {\n         Optional<String> lastOffset = consumer.get();\n+        log.debug(\"Position - Consumer: \" + consumer + \" InitialPosition: \" + initialPosition + \" Last Offset: \" + lastOffset);","path":"src/main/java/com/urbanairship/connect/client/StreamConsumeTask.java","position":27,"original_position":27,"commit_id":"263042222342aef62c66c9da03c54cc8b364677b","original_commit_id":"263042222342aef62c66c9da03c54cc8b364677b","user":{"login":"AWinterman","id":524923,"node_id":"MDQ6VXNlcjUyNDkyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/524923?v=4","gravatar_id":"","url":"https://api.github.com/users/AWinterman","html_url":"https://github.com/AWinterman","followers_url":"https://api.github.com/users/AWinterman/followers","following_url":"https://api.github.com/users/AWinterman/following{/other_user}","gists_url":"https://api.github.com/users/AWinterman/gists{/gist_id}","starred_url":"https://api.github.com/users/AWinterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWinterman/subscriptions","organizations_url":"https://api.github.com/users/AWinterman/orgs","repos_url":"https://api.github.com/users/AWinterman/repos","events_url":"https://api.github.com/users/AWinterman/events{/privacy}","received_events_url":"https://api.github.com/users/AWinterman/received_events","type":"User","site_admin":false},"body":"Do we need to log the initial position every time? Or should we do that once before the call to `stream` in run?","created_at":"2018-06-20T23:52:00Z","updated_at":"2018-06-20T23:52:39Z","html_url":"https://github.com/urbanairship/connect-java-library/pull/12#discussion_r196976128","pull_request_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/comments/196976128"},"html":{"href":"https://github.com/urbanairship/connect-java-library/pull/12#discussion_r196976128"},"pull_request":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12"}},"in_reply_to_id":196975891},"pull_request":{"url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12","id":196298805,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Mjk4ODA1","html_url":"https://github.com/urbanairship/connect-java-library/pull/12","diff_url":"https://github.com/urbanairship/connect-java-library/pull/12.diff","patch_url":"https://github.com/urbanairship/connect-java-library/pull/12.patch","issue_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/12","number":12,"state":"open","locked":false,"title":"Add logs for CUSTENG-292","user":{"login":"MDeGiulio","id":6980130,"node_id":"MDQ6VXNlcjY5ODAxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6980130?v=4","gravatar_id":"","url":"https://api.github.com/users/MDeGiulio","html_url":"https://github.com/MDeGiulio","followers_url":"https://api.github.com/users/MDeGiulio/followers","following_url":"https://api.github.com/users/MDeGiulio/following{/other_user}","gists_url":"https://api.github.com/users/MDeGiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/MDeGiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDeGiulio/subscriptions","organizations_url":"https://api.github.com/users/MDeGiulio/orgs","repos_url":"https://api.github.com/users/MDeGiulio/repos","events_url":"https://api.github.com/users/MDeGiulio/events{/privacy}","received_events_url":"https://api.github.com/users/MDeGiulio/received_events","type":"User","site_admin":false},"body":"### What does this do and why?\r\nhttps://urbanairship.atlassian.net/browse/CUSTENG-292\r\n\r\n### Additional notes for reviewers\r\n* This adds additional logging for Panera, please see ticket for more details.\r\n\r\nTest run:\r\n```\r\n[Stream iteration thread 0] INFO com.urbanairship.connect.client.StreamConsumeTask - Starting run\r\n[main] DEBUG com.urbanairship.connect.client.Stream - Starting Stream. Filters: [] Subset: Optional.absent() Starting Position Optional.of(StartPosition{relativePosition=null, offset=1002648894678})\r\n[Stream iteration thread 0] DEBUG com.urbanairship.connect.client.StreamConsumeTask - getPosition - Consumer: com.urbanairship.connect.client.StreamConsumeTask$EnqueuingConsumer@33371f2d InitialPosition: Optional.of(StartPosition{relativePosition=null, offset=1002648894678}) Last Offset: Optional.absent()\r\n[Stream iteration thread 0] DEBUG com.urbanairship.connect.client.StreamConsumeTask - stream position: Optional.of(StartPosition{relativePosition=null, offset=1002648894678})\r\n[pool-5-thread-1] INFO com.urbanairship.connect.client.StreamConsumeTask - Shutting down stream handler for app JhYcm4waRZy5QCIgBykCSA\r\n[Stream iteration thread 0] DEBUG com.urbanairship.connect.client.StreamConsumeTask - Stopping run\r\n```\r\n\r\n","created_at":"2018-06-20T23:27:04Z","updated_at":"2018-06-20T23:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8856548850bdd1df276eb5823e75c2e894065a9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12/commits","review_comments_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12/comments","review_comment_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/12/comments","statuses_url":"https://api.github.com/repos/urbanairship/connect-java-library/statuses/263042222342aef62c66c9da03c54cc8b364677b","head":{"label":"urbanairship:CUSTENG-292","ref":"CUSTENG-292","sha":"263042222342aef62c66c9da03c54cc8b364677b","user":{"login":"urbanairship","id":360059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDA1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/360059?v=4","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"repo":{"id":41939411,"node_id":"MDEwOlJlcG9zaXRvcnk0MTkzOTQxMQ==","name":"connect-java-library","full_name":"urbanairship/connect-java-library","owner":{"login":"urbanairship","id":360059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDA1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/360059?v=4","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbanairship/connect-java-library","description":"Java client library for Urban Airship Connect","fork":false,"url":"https://api.github.com/repos/urbanairship/connect-java-library","forks_url":"https://api.github.com/repos/urbanairship/connect-java-library/forks","keys_url":"https://api.github.com/repos/urbanairship/connect-java-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbanairship/connect-java-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbanairship/connect-java-library/teams","hooks_url":"https://api.github.com/repos/urbanairship/connect-java-library/hooks","issue_events_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/events{/number}","events_url":"https://api.github.com/repos/urbanairship/connect-java-library/events","assignees_url":"https://api.github.com/repos/urbanairship/connect-java-library/assignees{/user}","branches_url":"https://api.github.com/repos/urbanairship/connect-java-library/branches{/branch}","tags_url":"https://api.github.com/repos/urbanairship/connect-java-library/tags","blobs_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbanairship/connect-java-library/statuses/{sha}","languages_url":"https://api.github.com/repos/urbanairship/connect-java-library/languages","stargazers_url":"https://api.github.com/repos/urbanairship/connect-java-library/stargazers","contributors_url":"https://api.github.com/repos/urbanairship/connect-java-library/contributors","subscribers_url":"https://api.github.com/repos/urbanairship/connect-java-library/subscribers","subscription_url":"https://api.github.com/repos/urbanairship/connect-java-library/subscription","commits_url":"https://api.github.com/repos/urbanairship/connect-java-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbanairship/connect-java-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbanairship/connect-java-library/contents/{+path}","compare_url":"https://api.github.com/repos/urbanairship/connect-java-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbanairship/connect-java-library/merges","archive_url":"https://api.github.com/repos/urbanairship/connect-java-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbanairship/connect-java-library/downloads","issues_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues{/number}","pulls_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls{/number}","milestones_url":"https://api.github.com/repos/urbanairship/connect-java-library/milestones{/number}","notifications_url":"https://api.github.com/repos/urbanairship/connect-java-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbanairship/connect-java-library/labels{/name}","releases_url":"https://api.github.com/repos/urbanairship/connect-java-library/releases{/id}","deployments_url":"https://api.github.com/repos/urbanairship/connect-java-library/deployments","created_at":"2015-09-04T21:54:15Z","updated_at":"2018-03-29T18:48:29Z","pushed_at":"2018-06-20T23:27:04Z","git_url":"git://github.com/urbanairship/connect-java-library.git","ssh_url":"git@github.com:urbanairship/connect-java-library.git","clone_url":"https://github.com/urbanairship/connect-java-library.git","svn_url":"https://github.com/urbanairship/connect-java-library","homepage":"","size":324,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"urbanairship:master","ref":"master","sha":"8e61a066f6537bdaf3e48dc14ecc3cebf0928334","user":{"login":"urbanairship","id":360059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDA1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/360059?v=4","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"repo":{"id":41939411,"node_id":"MDEwOlJlcG9zaXRvcnk0MTkzOTQxMQ==","name":"connect-java-library","full_name":"urbanairship/connect-java-library","owner":{"login":"urbanairship","id":360059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDA1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/360059?v=4","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbanairship/connect-java-library","description":"Java client library for Urban Airship Connect","fork":false,"url":"https://api.github.com/repos/urbanairship/connect-java-library","forks_url":"https://api.github.com/repos/urbanairship/connect-java-library/forks","keys_url":"https://api.github.com/repos/urbanairship/connect-java-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbanairship/connect-java-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbanairship/connect-java-library/teams","hooks_url":"https://api.github.com/repos/urbanairship/connect-java-library/hooks","issue_events_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/events{/number}","events_url":"https://api.github.com/repos/urbanairship/connect-java-library/events","assignees_url":"https://api.github.com/repos/urbanairship/connect-java-library/assignees{/user}","branches_url":"https://api.github.com/repos/urbanairship/connect-java-library/branches{/branch}","tags_url":"https://api.github.com/repos/urbanairship/connect-java-library/tags","blobs_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbanairship/connect-java-library/statuses/{sha}","languages_url":"https://api.github.com/repos/urbanairship/connect-java-library/languages","stargazers_url":"https://api.github.com/repos/urbanairship/connect-java-library/stargazers","contributors_url":"https://api.github.com/repos/urbanairship/connect-java-library/contributors","subscribers_url":"https://api.github.com/repos/urbanairship/connect-java-library/subscribers","subscription_url":"https://api.github.com/repos/urbanairship/connect-java-library/subscription","commits_url":"https://api.github.com/repos/urbanairship/connect-java-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbanairship/connect-java-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbanairship/connect-java-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbanairship/connect-java-library/contents/{+path}","compare_url":"https://api.github.com/repos/urbanairship/connect-java-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbanairship/connect-java-library/merges","archive_url":"https://api.github.com/repos/urbanairship/connect-java-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbanairship/connect-java-library/downloads","issues_url":"https://api.github.com/repos/urbanairship/connect-java-library/issues{/number}","pulls_url":"https://api.github.com/repos/urbanairship/connect-java-library/pulls{/number}","milestones_url":"https://api.github.com/repos/urbanairship/connect-java-library/milestones{/number}","notifications_url":"https://api.github.com/repos/urbanairship/connect-java-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbanairship/connect-java-library/labels{/name}","releases_url":"https://api.github.com/repos/urbanairship/connect-java-library/releases{/id}","deployments_url":"https://api.github.com/repos/urbanairship/connect-java-library/deployments","created_at":"2015-09-04T21:54:15Z","updated_at":"2018-03-29T18:48:29Z","pushed_at":"2018-06-20T23:27:04Z","git_url":"git://github.com/urbanairship/connect-java-library.git","ssh_url":"git@github.com:urbanairship/connect-java-library.git","clone_url":"https://github.com/urbanairship/connect-java-library.git","svn_url":"https://github.com/urbanairship/connect-java-library","homepage":"","size":324,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12"},"html":{"href":"https://github.com/urbanairship/connect-java-library/pull/12"},"issue":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/issues/12"},"comments":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/urbanairship/connect-java-library/statuses/263042222342aef62c66c9da03c54cc8b364677b"}},"author_association":"NONE"}}
{"actor":{"display_login":"AWinterman"}}