{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21182","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21182/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21182/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21182/events","html_url":"https://github.com/nodejs/node/pull/21182","id":330065670,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTY2NDMy","number":21182,"title":"inspector: split main thread interface from transport","user":{"login":"eugeneo","id":287917,"node_id":"MDQ6VXNlcjI4NzkxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/287917?v=4","gravatar_id":"","url":"https://api.github.com/users/eugeneo","html_url":"https://github.com/eugeneo","followers_url":"https://api.github.com/users/eugeneo/followers","following_url":"https://api.github.com/users/eugeneo/following{/other_user}","gists_url":"https://api.github.com/users/eugeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneo/subscriptions","organizations_url":"https://api.github.com/users/eugeneo/orgs","repos_url":"https://api.github.com/users/eugeneo/repos","events_url":"https://api.github.com/users/eugeneo/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneo/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":386816750,"node_id":"MDU6TGFiZWwzODY4MTY3NTA=","url":"https://api.github.com/repos/nodejs/node/labels/inspector","name":"inspector","color":"bfd4f2","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-06-06T23:20:39Z","updated_at":"2018-07-15T16:59:27Z","closed_at":"2018-07-13T23:05:07Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21182","html_url":"https://github.com/nodejs/node/pull/21182","diff_url":"https://github.com/nodejs/node/pull/21182.diff","patch_url":"https://github.com/nodejs/node/pull/21182.patch"},"body":"Workers debugging will require interfacing between the \"main\" inspector\r\nand per-worker isolate inspectors. This is consistent with what WS\r\ninterface does. This change is a refactoring change and does not change\r\nthe functionality.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/405104087","html_url":"https://github.com/nodejs/node/pull/21182#issuecomment-405104087","issue_url":"https://api.github.com/repos/nodejs/node/issues/21182","id":405104087,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEwNDA4Nw==","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T16:59:27Z","updated_at":"2018-07-15T16:59:27Z","author_association":"MEMBER","body":"Unfortunately, this change seems to have increased the failure of sequential/test-debug-prompt test on OS X 10.10 (Yosemite) in CI from about 0.01% failure to about a 24% failure. See https://github.com/nodejs/node/issues/21724. I'm not sure if the problem lies here or in the test or is something specific to older versions of OS X."}}
{"actor":{"display_login":"Trott"}}