{"action":"created","comment":{"url":"https://api.github.com/repos/matomo-org/matomo/pulls/comments/237372390","pull_request_review_id":179651447,"id":237372390,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM3MjM5MA==","diff_hunk":"@@ -46,6 +46,18 @@ public static function getOutputPrefix()\n     {\n         return 'OneVisitorTwoVisits_withCookieSupport';\n     }\n+\n+    public function provideContainerConfig()\n+    {\n+        return array(\n+            'Piwik\\Config' => \\DI\\decorate(function ($previous) {\n+                $general = $previous->General;\n+                $general['action_title_category_delimiter'] = \"/\";\n+                $previous->General = $general;\n+                return $previous;\n+            }),\n+        );\n+    }","path":"tests/PHPUnit/System/OneVisitorTwoVisitsWithCookieSupportTest.php","position":15,"original_position":15,"commit_id":"7c5882c22dc6359891f440d3d6038e7aff5f8a8a","original_commit_id":"7c5882c22dc6359891f440d3d6038e7aff5f8a8a","user":{"login":"diosmosis","id":125140,"node_id":"MDQ6VXNlcjEyNTE0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/125140?v=4","gravatar_id":"","url":"https://api.github.com/users/diosmosis","html_url":"https://github.com/diosmosis","followers_url":"https://api.github.com/users/diosmosis/followers","following_url":"https://api.github.com/users/diosmosis/following{/other_user}","gists_url":"https://api.github.com/users/diosmosis/gists{/gist_id}","starred_url":"https://api.github.com/users/diosmosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diosmosis/subscriptions","organizations_url":"https://api.github.com/users/diosmosis/orgs","repos_url":"https://api.github.com/users/diosmosis/repos","events_url":"https://api.github.com/users/diosmosis/events{/privacy}","received_events_url":"https://api.github.com/users/diosmosis/received_events","type":"User","site_admin":false},"body":"Actually, it looks like only a couple of the tests have this, so I guess most use the new default?","created_at":"2018-11-29T07:07:12Z","updated_at":"2018-11-29T07:07:13Z","html_url":"https://github.com/matomo-org/matomo/pull/13688#discussion_r237372390","pull_request_url":"https://api.github.com/repos/matomo-org/matomo/pulls/13688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/comments/237372390"},"html":{"href":"https://github.com/matomo-org/matomo/pull/13688#discussion_r237372390"},"pull_request":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/13688"}},"in_reply_to_id":237371803},"pull_request":{"url":"https://api.github.com/repos/matomo-org/matomo/pulls/13688","id":229505953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTA1OTUz","html_url":"https://github.com/matomo-org/matomo/pull/13688","diff_url":"https://github.com/matomo-org/matomo/pull/13688.diff","patch_url":"https://github.com/matomo-org/matomo/pull/13688.patch","issue_url":"https://api.github.com/repos/matomo-org/matomo/issues/13688","number":13688,"state":"open","locked":false,"title":"Do not specify a category delimiter by default","user":{"login":"tsteur","id":273120,"node_id":"MDQ6VXNlcjI3MzEyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/273120?v=4","gravatar_id":"","url":"https://api.github.com/users/tsteur","html_url":"https://github.com/tsteur","followers_url":"https://api.github.com/users/tsteur/followers","following_url":"https://api.github.com/users/tsteur/following{/other_user}","gists_url":"https://api.github.com/users/tsteur/gists{/gist_id}","starred_url":"https://api.github.com/users/tsteur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsteur/subscriptions","organizations_url":"https://api.github.com/users/tsteur/orgs","repos_url":"https://api.github.com/users/tsteur/repos","events_url":"https://api.github.com/users/tsteur/events{/privacy}","received_events_url":"https://api.github.com/users/tsteur/received_events","type":"User","site_admin":false},"body":"Doesn't require a note in the developer changelog but we should ideally mention this in the changelog as it is changing the behaviour for people that actually want to use it.\r\n\r\nTested it locally and worked.\r\n\r\nfix #2956 ","created_at":"2018-11-08T20:56:54Z","updated_at":"2018-11-29T07:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c988b293dbab0f82d12dcf7e4cc76f56260db74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176285791,"node_id":"MDU6TGFiZWwxNzYyODU3OTE=","url":"https://api.github.com/repos/matomo-org/matomo/labels/Needs%20Review","name":"Needs Review","color":"fad8c7","default":false},{"id":164789690,"node_id":"MDU6TGFiZWwxNjQ3ODk2OTA=","url":"https://api.github.com/repos/matomo-org/matomo/labels/not-in-changelog","name":"not-in-changelog","color":"ffffff","default":false}],"milestone":{"url":"https://api.github.com/repos/matomo-org/matomo/milestones/109","html_url":"https://github.com/matomo-org/matomo/milestone/109","labels_url":"https://api.github.com/repos/matomo-org/matomo/milestones/109/labels","id":2593479,"node_id":"MDk6TWlsZXN0b25lMjU5MzQ3OQ==","number":109,"title":"3.8.0","description":"","creator":{"login":"mattab","id":466765,"node_id":"MDQ6VXNlcjQ2Njc2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/466765?v=4","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":86,"closed_issues":90,"state":"open","created_at":"2017-06-20T11:57:22Z","updated_at":"2018-11-29T04:35:18Z","due_on":"2018-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matomo-org/matomo/pulls/13688/commits","review_comments_url":"https://api.github.com/repos/matomo-org/matomo/pulls/13688/comments","review_comment_url":"https://api.github.com/repos/matomo-org/matomo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matomo-org/matomo/issues/13688/comments","statuses_url":"https://api.github.com/repos/matomo-org/matomo/statuses/7c5882c22dc6359891f440d3d6038e7aff5f8a8a","head":{"label":"matomo-org:2956","ref":"2956","sha":"7c5882c22dc6359891f440d3d6038e7aff5f8a8a","user":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MjAy","name":"matomo","full_name":"matomo-org/matomo","private":false,"owner":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matomo-org/matomo","description":"Liberating Web Analytics. Star us on Github? +1. Matomo is the leading open alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites, apps & the IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/matomo-org/matomo","forks_url":"https://api.github.com/repos/matomo-org/matomo/forks","keys_url":"https://api.github.com/repos/matomo-org/matomo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matomo-org/matomo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matomo-org/matomo/teams","hooks_url":"https://api.github.com/repos/matomo-org/matomo/hooks","issue_events_url":"https://api.github.com/repos/matomo-org/matomo/issues/events{/number}","events_url":"https://api.github.com/repos/matomo-org/matomo/events","assignees_url":"https://api.github.com/repos/matomo-org/matomo/assignees{/user}","branches_url":"https://api.github.com/repos/matomo-org/matomo/branches{/branch}","tags_url":"https://api.github.com/repos/matomo-org/matomo/tags","blobs_url":"https://api.github.com/repos/matomo-org/matomo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matomo-org/matomo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matomo-org/matomo/git/refs{/sha}","trees_url":"https://api.github.com/repos/matomo-org/matomo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matomo-org/matomo/statuses/{sha}","languages_url":"https://api.github.com/repos/matomo-org/matomo/languages","stargazers_url":"https://api.github.com/repos/matomo-org/matomo/stargazers","contributors_url":"https://api.github.com/repos/matomo-org/matomo/contributors","subscribers_url":"https://api.github.com/repos/matomo-org/matomo/subscribers","subscription_url":"https://api.github.com/repos/matomo-org/matomo/subscription","commits_url":"https://api.github.com/repos/matomo-org/matomo/commits{/sha}","git_commits_url":"https://api.github.com/repos/matomo-org/matomo/git/commits{/sha}","comments_url":"https://api.github.com/repos/matomo-org/matomo/comments{/number}","issue_comment_url":"https://api.github.com/repos/matomo-org/matomo/issues/comments{/number}","contents_url":"https://api.github.com/repos/matomo-org/matomo/contents/{+path}","compare_url":"https://api.github.com/repos/matomo-org/matomo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matomo-org/matomo/merges","archive_url":"https://api.github.com/repos/matomo-org/matomo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matomo-org/matomo/downloads","issues_url":"https://api.github.com/repos/matomo-org/matomo/issues{/number}","pulls_url":"https://api.github.com/repos/matomo-org/matomo/pulls{/number}","milestones_url":"https://api.github.com/repos/matomo-org/matomo/milestones{/number}","notifications_url":"https://api.github.com/repos/matomo-org/matomo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matomo-org/matomo/labels{/name}","releases_url":"https://api.github.com/repos/matomo-org/matomo/releases{/id}","deployments_url":"https://api.github.com/repos/matomo-org/matomo/deployments","created_at":"2011-03-30T21:18:17Z","updated_at":"2018-11-29T06:28:59Z","pushed_at":"2018-11-29T06:36:55Z","git_url":"git://github.com/matomo-org/matomo.git","ssh_url":"git@github.com:matomo-org/matomo.git","clone_url":"https://github.com/matomo-org/matomo.git","svn_url":"https://github.com/matomo-org/matomo","homepage":"https://matomo.org/","size":201435,"stargazers_count":10281,"watchers_count":10281,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":1786,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1666,"open_issues":1786,"watchers":10281,"default_branch":"3.x-dev"}},"base":{"label":"matomo-org:3.x-dev","ref":"3.x-dev","sha":"cb5453316711264b07b89a7077b51404a189aa98","user":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MjAy","name":"matomo","full_name":"matomo-org/matomo","private":false,"owner":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matomo-org/matomo","description":"Liberating Web Analytics. Star us on Github? +1. Matomo is the leading open alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites, apps & the IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/matomo-org/matomo","forks_url":"https://api.github.com/repos/matomo-org/matomo/forks","keys_url":"https://api.github.com/repos/matomo-org/matomo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matomo-org/matomo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matomo-org/matomo/teams","hooks_url":"https://api.github.com/repos/matomo-org/matomo/hooks","issue_events_url":"https://api.github.com/repos/matomo-org/matomo/issues/events{/number}","events_url":"https://api.github.com/repos/matomo-org/matomo/events","assignees_url":"https://api.github.com/repos/matomo-org/matomo/assignees{/user}","branches_url":"https://api.github.com/repos/matomo-org/matomo/branches{/branch}","tags_url":"https://api.github.com/repos/matomo-org/matomo/tags","blobs_url":"https://api.github.com/repos/matomo-org/matomo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matomo-org/matomo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matomo-org/matomo/git/refs{/sha}","trees_url":"https://api.github.com/repos/matomo-org/matomo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matomo-org/matomo/statuses/{sha}","languages_url":"https://api.github.com/repos/matomo-org/matomo/languages","stargazers_url":"https://api.github.com/repos/matomo-org/matomo/stargazers","contributors_url":"https://api.github.com/repos/matomo-org/matomo/contributors","subscribers_url":"https://api.github.com/repos/matomo-org/matomo/subscribers","subscription_url":"https://api.github.com/repos/matomo-org/matomo/subscription","commits_url":"https://api.github.com/repos/matomo-org/matomo/commits{/sha}","git_commits_url":"https://api.github.com/repos/matomo-org/matomo/git/commits{/sha}","comments_url":"https://api.github.com/repos/matomo-org/matomo/comments{/number}","issue_comment_url":"https://api.github.com/repos/matomo-org/matomo/issues/comments{/number}","contents_url":"https://api.github.com/repos/matomo-org/matomo/contents/{+path}","compare_url":"https://api.github.com/repos/matomo-org/matomo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matomo-org/matomo/merges","archive_url":"https://api.github.com/repos/matomo-org/matomo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matomo-org/matomo/downloads","issues_url":"https://api.github.com/repos/matomo-org/matomo/issues{/number}","pulls_url":"https://api.github.com/repos/matomo-org/matomo/pulls{/number}","milestones_url":"https://api.github.com/repos/matomo-org/matomo/milestones{/number}","notifications_url":"https://api.github.com/repos/matomo-org/matomo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matomo-org/matomo/labels{/name}","releases_url":"https://api.github.com/repos/matomo-org/matomo/releases{/id}","deployments_url":"https://api.github.com/repos/matomo-org/matomo/deployments","created_at":"2011-03-30T21:18:17Z","updated_at":"2018-11-29T06:28:59Z","pushed_at":"2018-11-29T06:36:55Z","git_url":"git://github.com/matomo-org/matomo.git","ssh_url":"git@github.com:matomo-org/matomo.git","clone_url":"https://github.com/matomo-org/matomo.git","svn_url":"https://github.com/matomo-org/matomo","homepage":"https://matomo.org/","size":201435,"stargazers_count":10281,"watchers_count":10281,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":1786,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1666,"open_issues":1786,"watchers":10281,"default_branch":"3.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/13688"},"html":{"href":"https://github.com/matomo-org/matomo/pull/13688"},"issue":{"href":"https://api.github.com/repos/matomo-org/matomo/issues/13688"},"comments":{"href":"https://api.github.com/repos/matomo-org/matomo/issues/13688/comments"},"review_comments":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/13688/comments"},"review_comment":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matomo-org/matomo/pulls/13688/commits"},"statuses":{"href":"https://api.github.com/repos/matomo-org/matomo/statuses/7c5882c22dc6359891f440d3d6038e7aff5f8a8a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"diosmosis"}}