{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/10192","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/10192/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/10192/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/10192/events","html_url":"https://github.com/sequelize/sequelize/pull/10192","id":383612631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDQwNDky","number":10192,"title":"feat(mariadb): implementation for MariaDB","user":{"login":"rusher","id":618074,"node_id":"MDQ6VXNlcjYxODA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/618074?v=4","gravatar_id":"","url":"https://api.github.com/users/rusher","html_url":"https://github.com/rusher","followers_url":"https://api.github.com/users/rusher/followers","following_url":"https://api.github.com/users/rusher/following{/other_user}","gists_url":"https://api.github.com/users/rusher/gists{/gist_id}","starred_url":"https://api.github.com/users/rusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusher/subscriptions","organizations_url":"https://api.github.com/users/rusher/orgs","repos_url":"https://api.github.com/users/rusher/repos","events_url":"https://api.github.com/users/rusher/events{/privacy}","received_events_url":"https://api.github.com/users/rusher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-22T17:02:57Z","updated_at":"2018-12-03T09:49:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/10192","html_url":"https://github.com/sequelize/sequelize/pull/10192","diff_url":"https://github.com/sequelize/sequelize/pull/10192.diff","patch_url":"https://github.com/sequelize/sequelize/pull/10192.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [x] Have you added new tests to prevent regressions?\r\n- [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [x] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)?\r\n\r\n### Description of change\r\n\r\nImplementation of MariaDB. \r\nThis differs from MySQL mostly for 3 things:\r\n- the driver is different ([mariadb](https://github.com/MariaDB/mariadb-connector-nodejs)\r\n- use of schema\r\n- MariaDB JSON implementation differ from MySQL\r\n\r\nBreaking change is the use of schemas. MySQL/MariaDB have schemas, but no \"default\" public schema. \r\nCurrent implementation for MySQL will create a table with name `mySchema_myTable`, using schema, that is `mySchema`.`myTable`.\r\nI haven't corrected that for MySQL since it will break every existing application, but for new MariaDB implementation, it seems appropriate to use a better base with real schemas. \r\n\r\nTests have been updated accordingly (defaut method that drop all schemas is replace to keep default schema that is needed for MariaDB)\r\n \r\n  \r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/443649958","html_url":"https://github.com/sequelize/sequelize/pull/10192#issuecomment-443649958","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/10192","id":443649958,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY0OTk1OA==","user":{"login":"rusher","id":618074,"node_id":"MDQ6VXNlcjYxODA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/618074?v=4","gravatar_id":"","url":"https://api.github.com/users/rusher","html_url":"https://github.com/rusher","followers_url":"https://api.github.com/users/rusher/followers","following_url":"https://api.github.com/users/rusher/following{/other_user}","gists_url":"https://api.github.com/users/rusher/gists{/gist_id}","starred_url":"https://api.github.com/users/rusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusher/subscriptions","organizations_url":"https://api.github.com/users/rusher/orgs","repos_url":"https://api.github.com/users/rusher/repos","events_url":"https://api.github.com/users/rusher/events{/privacy}","received_events_url":"https://api.github.com/users/rusher/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T09:49:14Z","updated_at":"2018-12-03T09:49:14Z","author_association":"NONE","body":"@sushantdhiman No other changes unless new reviews"}}
{"actor":{"display_login":"rusher"}}