{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17795","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17795/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17795/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17795/events","html_url":"https://github.com/ethereum/go-ethereum/pull/17795","id":365207522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTk0MzMw","number":17795,"title":"ethdb_test: replace some \"panic\" with \"t.Fatal\" and \"t.Fatalf\"","user":{"login":"CoreyLin","id":12689769,"node_id":"MDQ6VXNlcjEyNjg5NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/12689769?v=4","gravatar_id":"","url":"https://api.github.com/users/CoreyLin","html_url":"https://github.com/CoreyLin","followers_url":"https://api.github.com/users/CoreyLin/followers","following_url":"https://api.github.com/users/CoreyLin/following{/other_user}","gists_url":"https://api.github.com/users/CoreyLin/gists{/gist_id}","starred_url":"https://api.github.com/users/CoreyLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoreyLin/subscriptions","organizations_url":"https://api.github.com/users/CoreyLin/orgs","repos_url":"https://api.github.com/users/CoreyLin/repos","events_url":"https://api.github.com/users/CoreyLin/events{/privacy}","received_events_url":"https://api.github.com/users/CoreyLin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-30T09:05:29Z","updated_at":"2018-09-30T14:00:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/17795","html_url":"https://github.com/ethereum/go-ethereum/pull/17795","diff_url":"https://github.com/ethereum/go-ethereum/pull/17795.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/17795.patch"},"body":"In testcases \"TestLDB_PutGet\" and \"TestMemoryDB_PutGet\", when the expected\r\nvalue does not match actual value, keyword \"panic\" is used in several places. It is\r\nnot so appropriate because panic would not only make the current testcase\r\nfail, but also make all the remaining to-be-executed testcases can't be\r\nexecuted.\r\nBesides, the places where panic is used are not some vital preconditions\r\nfor the testcases, even if the current testcase fails, the remaining\r\nto-be-executed testcases should also be executed so that we can get all\r\ntestcases' running result.\r\nSo, suggest that replace \"panic\" instead of \"t.Fatal\" and \"t.Fatalf\"."},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/425722831","html_url":"https://github.com/ethereum/go-ethereum/pull/17795#issuecomment-425722831","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17795","id":425722831,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTcyMjgzMQ==","user":{"login":"CoreyLin","id":12689769,"node_id":"MDQ6VXNlcjEyNjg5NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/12689769?v=4","gravatar_id":"","url":"https://api.github.com/users/CoreyLin","html_url":"https://github.com/CoreyLin","followers_url":"https://api.github.com/users/CoreyLin/followers","following_url":"https://api.github.com/users/CoreyLin/following{/other_user}","gists_url":"https://api.github.com/users/CoreyLin/gists{/gist_id}","starred_url":"https://api.github.com/users/CoreyLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoreyLin/subscriptions","organizations_url":"https://api.github.com/users/CoreyLin/orgs","repos_url":"https://api.github.com/users/CoreyLin/repos","events_url":"https://api.github.com/users/CoreyLin/events{/privacy}","received_events_url":"https://api.github.com/users/CoreyLin/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T14:00:04Z","updated_at":"2018-09-30T14:00:04Z","author_association":"NONE","body":"@obscuren @fjl @rjl493456442 @karalabe @egonelbre could you please have a look at this PR and review it? Thank you."}}
{"actor":{"display_login":"CoreyLin"}}