{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/20069","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/20069/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/20069/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/20069/events","html_url":"https://github.com/ampproject/amphtml/pull/20069","id":393731839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjcwNzI2","number":20069,"title":"🐛: Adding UpScore to Vendor.js","user":{"login":"suransandi","id":39913646,"node_id":"MDQ6VXNlcjM5OTEzNjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/39913646?v=4","gravatar_id":"","url":"https://api.github.com/users/suransandi","html_url":"https://github.com/suransandi","followers_url":"https://api.github.com/users/suransandi/followers","following_url":"https://api.github.com/users/suransandi/following{/other_user}","gists_url":"https://api.github.com/users/suransandi/gists{/gist_id}","starred_url":"https://api.github.com/users/suransandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suransandi/subscriptions","organizations_url":"https://api.github.com/users/suransandi/orgs","repos_url":"https://api.github.com/users/suransandi/repos","events_url":"https://api.github.com/users/suransandi/events{/privacy}","received_events_url":"https://api.github.com/users/suransandi/received_events","type":"User","site_admin":false},"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-23T08:09:16Z","updated_at":"2018-12-27T16:21:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/20069","html_url":"https://github.com/ampproject/amphtml/pull/20069","diff_url":"https://github.com/ampproject/amphtml/pull/20069.diff","patch_url":"https://github.com/ampproject/amphtml/pull/20069.patch"},"body":"Hi @torch2424, \r\n\r\nHow are you? Some time has passed since we last talked, and I hope that you are doing well.\r\n\r\nA few days ago, we tested the UpScore AMP analytics with one of our clients and noticed that we have a small issue. So after an investigation and debugging I noticed that I completely missed out one part of AMP integration, and forgot to add the UPSCORE_CONFIG inside vendors.js file. \r\nI would really appreciate if we could resolve this as soon as possible.\r\n\r\nI wish Merry Christmas and Happy and Prosperous New Year, to you and whole Google AMP team. \r\n\r\nSandi \r\n\r\nLast UpScore pull request#18734\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/450183223","html_url":"https://github.com/ampproject/amphtml/pull/20069#issuecomment-450183223","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/20069","id":450183223,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDE4MzIyMw==","user":{"login":"suransandi","id":39913646,"node_id":"MDQ6VXNlcjM5OTEzNjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/39913646?v=4","gravatar_id":"","url":"https://api.github.com/users/suransandi","html_url":"https://github.com/suransandi","followers_url":"https://api.github.com/users/suransandi/followers","following_url":"https://api.github.com/users/suransandi/following{/other_user}","gists_url":"https://api.github.com/users/suransandi/gists{/gist_id}","starred_url":"https://api.github.com/users/suransandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suransandi/subscriptions","organizations_url":"https://api.github.com/users/suransandi/orgs","repos_url":"https://api.github.com/users/suransandi/repos","events_url":"https://api.github.com/users/suransandi/events{/privacy}","received_events_url":"https://api.github.com/users/suransandi/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T16:21:17Z","updated_at":"2018-12-27T16:21:17Z","author_association":"CONTRIBUTOR","body":"Hi @torch2424 ,\r\n\r\nI have updated upscore config so now unit tests are not failing anymore. But, I am not sure why one of integration tests failed. Am I missing something?\r\n"}}
{"actor":{"display_login":"suransandi"}}