{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/ios-app/pulls/comments/212313671","pull_request_review_id":148916664,"id":212313671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjMxMzY3MQ==","diff_hunk":"@@ -19,9 +19,13 @@\n import UIKit\n import ownCloudSDK\n \n-class ClientQueryViewController: UITableViewController, Themeable {\n-\tvar core : OCCore?\n-\tvar query : OCQuery?\n+class ClientQueryViewController: UIViewController {","path":"ownCloud/Client/ClientQueryViewController.swift","position":7,"original_position":7,"commit_id":"04f368f14185c3ed0de4bad50eac45e914e93856","original_commit_id":"04f368f14185c3ed0de4bad50eac45e914e93856","user":{"login":"felix-schwarz","id":639669,"node_id":"MDQ6VXNlcjYzOTY2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639669?v=4","gravatar_id":"","url":"https://api.github.com/users/felix-schwarz","html_url":"https://github.com/felix-schwarz","followers_url":"https://api.github.com/users/felix-schwarz/followers","following_url":"https://api.github.com/users/felix-schwarz/following{/other_user}","gists_url":"https://api.github.com/users/felix-schwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/felix-schwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix-schwarz/subscriptions","organizations_url":"https://api.github.com/users/felix-schwarz/orgs","repos_url":"https://api.github.com/users/felix-schwarz/repos","events_url":"https://api.github.com/users/felix-schwarz/events{/privacy}","received_events_url":"https://api.github.com/users/felix-schwarz/received_events","type":"User","site_admin":false},"body":"Why did you change the superclass from `UITableViewController` to `UIViewController` and set up the tableView yourself?","created_at":"2018-08-23T13:43:32Z","updated_at":"2018-08-23T13:49:28Z","html_url":"https://github.com/owncloud/ios-app/pull/107#discussion_r212313671","pull_request_url":"https://api.github.com/repos/owncloud/ios-app/pulls/107","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/comments/212313671"},"html":{"href":"https://github.com/owncloud/ios-app/pull/107#discussion_r212313671"},"pull_request":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/ios-app/pulls/107","id":209474188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDc0MTg4","html_url":"https://github.com/owncloud/ios-app/pull/107","diff_url":"https://github.com/owncloud/ios-app/pull/107.diff","patch_url":"https://github.com/owncloud/ios-app/pull/107.patch","issue_url":"https://api.github.com/repos/owncloud/ios-app/issues/107","number":107,"state":"open","locked":false,"title":"Fix/sortbar hidden when no items","user":{"login":"pablocarmu","id":8929738,"node_id":"MDQ6VXNlcjg5Mjk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8929738?v=4","gravatar_id":"","url":"https://api.github.com/users/pablocarmu","html_url":"https://github.com/pablocarmu","followers_url":"https://api.github.com/users/pablocarmu/followers","following_url":"https://api.github.com/users/pablocarmu/following{/other_user}","gists_url":"https://api.github.com/users/pablocarmu/gists{/gist_id}","starred_url":"https://api.github.com/users/pablocarmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablocarmu/subscriptions","organizations_url":"https://api.github.com/users/pablocarmu/orgs","repos_url":"https://api.github.com/users/pablocarmu/repos","events_url":"https://api.github.com/users/pablocarmu/events{/privacy}","received_events_url":"https://api.github.com/users/pablocarmu/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis PR fixes the bug with the sort bar when there were no items inside a folder.\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nWhen there are no items inside a folder, the sort bar was hidden by the \"No items\" view. So you can't tap on the create folder button.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**CONTRIBUTING**](https://github.com/owncloud/ios-app/blob/master/CONTRIBUTING.md) document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n_____\r\n\r\nBUGS & IMPROVEMENTS\r\n\r\n- [ ] Default name of a folder https://github.com/owncloud/ios-app/pull/107#issuecomment-415337603","created_at":"2018-08-20T10:17:55Z","updated_at":"2018-08-23T13:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c33ea8f5f5770180f41be8c832b0469f37a31548","assignee":{"login":"pablocarmu","id":8929738,"node_id":"MDQ6VXNlcjg5Mjk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8929738?v=4","gravatar_id":"","url":"https://api.github.com/users/pablocarmu","html_url":"https://github.com/pablocarmu","followers_url":"https://api.github.com/users/pablocarmu/followers","following_url":"https://api.github.com/users/pablocarmu/following{/other_user}","gists_url":"https://api.github.com/users/pablocarmu/gists{/gist_id}","starred_url":"https://api.github.com/users/pablocarmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablocarmu/subscriptions","organizations_url":"https://api.github.com/users/pablocarmu/orgs","repos_url":"https://api.github.com/users/pablocarmu/repos","events_url":"https://api.github.com/users/pablocarmu/events{/privacy}","received_events_url":"https://api.github.com/users/pablocarmu/received_events","type":"User","site_admin":false},"assignees":[{"login":"pablocarmu","id":8929738,"node_id":"MDQ6VXNlcjg5Mjk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8929738?v=4","gravatar_id":"","url":"https://api.github.com/users/pablocarmu","html_url":"https://github.com/pablocarmu","followers_url":"https://api.github.com/users/pablocarmu/followers","following_url":"https://api.github.com/users/pablocarmu/following{/other_user}","gists_url":"https://api.github.com/users/pablocarmu/gists{/gist_id}","starred_url":"https://api.github.com/users/pablocarmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablocarmu/subscriptions","organizations_url":"https://api.github.com/users/pablocarmu/orgs","repos_url":"https://api.github.com/users/pablocarmu/repos","events_url":"https://api.github.com/users/pablocarmu/events{/privacy}","received_events_url":"https://api.github.com/users/pablocarmu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jesmrec","id":14894746,"node_id":"MDQ6VXNlcjE0ODk0NzQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14894746?v=4","gravatar_id":"","url":"https://api.github.com/users/jesmrec","html_url":"https://github.com/jesmrec","followers_url":"https://api.github.com/users/jesmrec/followers","following_url":"https://api.github.com/users/jesmrec/following{/other_user}","gists_url":"https://api.github.com/users/jesmrec/gists{/gist_id}","starred_url":"https://api.github.com/users/jesmrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesmrec/subscriptions","organizations_url":"https://api.github.com/users/jesmrec/orgs","repos_url":"https://api.github.com/users/jesmrec/repos","events_url":"https://api.github.com/users/jesmrec/events{/privacy}","received_events_url":"https://api.github.com/users/jesmrec/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/ios-app/pulls/107/commits","review_comments_url":"https://api.github.com/repos/owncloud/ios-app/pulls/107/comments","review_comment_url":"https://api.github.com/repos/owncloud/ios-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/ios-app/issues/107/comments","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/04f368f14185c3ed0de4bad50eac45e914e93856","head":{"label":"owncloud:fix/sortbar_hided_when_no_items","ref":"fix/sortbar_hided_when_no_items","sha":"04f368f14185c3ed0de4bad50eac45e914e93856","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":120430704,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MzA3MDQ=","name":"ios-app","full_name":"owncloud/ios-app","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/ios-app","description":"📱iOS app for ownCloud, [WIP not available for production]","fork":false,"url":"https://api.github.com/repos/owncloud/ios-app","forks_url":"https://api.github.com/repos/owncloud/ios-app/forks","keys_url":"https://api.github.com/repos/owncloud/ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/ios-app/teams","hooks_url":"https://api.github.com/repos/owncloud/ios-app/hooks","issue_events_url":"https://api.github.com/repos/owncloud/ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/ios-app/events","assignees_url":"https://api.github.com/repos/owncloud/ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/ios-app/tags","blobs_url":"https://api.github.com/repos/owncloud/ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/ios-app/languages","stargazers_url":"https://api.github.com/repos/owncloud/ios-app/stargazers","contributors_url":"https://api.github.com/repos/owncloud/ios-app/contributors","subscribers_url":"https://api.github.com/repos/owncloud/ios-app/subscribers","subscription_url":"https://api.github.com/repos/owncloud/ios-app/subscription","commits_url":"https://api.github.com/repos/owncloud/ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/ios-app/merges","archive_url":"https://api.github.com/repos/owncloud/ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/ios-app/downloads","issues_url":"https://api.github.com/repos/owncloud/ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/ios-app/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/ios-app/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/ios-app/deployments","created_at":"2018-02-06T09:20:24Z","updated_at":"2018-08-22T08:50:16Z","pushed_at":"2018-08-23T12:57:41Z","git_url":"git://github.com/owncloud/ios-app.git","ssh_url":"git@github.com:owncloud/ios-app.git","clone_url":"https://github.com/owncloud/ios-app.git","svn_url":"https://github.com/owncloud/ios-app","homepage":"","size":3326,"stargazers_count":8,"watchers_count":8,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":6,"open_issues":49,"watchers":8,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"5de01b46ce86464019af2d231a6906ede4b70bb1","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":120430704,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MzA3MDQ=","name":"ios-app","full_name":"owncloud/ios-app","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/ios-app","description":"📱iOS app for ownCloud, [WIP not available for production]","fork":false,"url":"https://api.github.com/repos/owncloud/ios-app","forks_url":"https://api.github.com/repos/owncloud/ios-app/forks","keys_url":"https://api.github.com/repos/owncloud/ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/ios-app/teams","hooks_url":"https://api.github.com/repos/owncloud/ios-app/hooks","issue_events_url":"https://api.github.com/repos/owncloud/ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/ios-app/events","assignees_url":"https://api.github.com/repos/owncloud/ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/ios-app/tags","blobs_url":"https://api.github.com/repos/owncloud/ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/ios-app/languages","stargazers_url":"https://api.github.com/repos/owncloud/ios-app/stargazers","contributors_url":"https://api.github.com/repos/owncloud/ios-app/contributors","subscribers_url":"https://api.github.com/repos/owncloud/ios-app/subscribers","subscription_url":"https://api.github.com/repos/owncloud/ios-app/subscription","commits_url":"https://api.github.com/repos/owncloud/ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/ios-app/merges","archive_url":"https://api.github.com/repos/owncloud/ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/ios-app/downloads","issues_url":"https://api.github.com/repos/owncloud/ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/ios-app/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/ios-app/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/ios-app/deployments","created_at":"2018-02-06T09:20:24Z","updated_at":"2018-08-22T08:50:16Z","pushed_at":"2018-08-23T12:57:41Z","git_url":"git://github.com/owncloud/ios-app.git","ssh_url":"git@github.com:owncloud/ios-app.git","clone_url":"https://github.com/owncloud/ios-app.git","svn_url":"https://github.com/owncloud/ios-app","homepage":"","size":3326,"stargazers_count":8,"watchers_count":8,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":6,"open_issues":49,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/107"},"html":{"href":"https://github.com/owncloud/ios-app/pull/107"},"issue":{"href":"https://api.github.com/repos/owncloud/ios-app/issues/107"},"comments":{"href":"https://api.github.com/repos/owncloud/ios-app/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/ios-app/statuses/04f368f14185c3ed0de4bad50eac45e914e93856"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"felix-schwarz"}}