{"action":"created","comment":{"url":"https://api.github.com/repos/medic/medic-webapp/pulls/comments/236219509","pull_request_review_id":178245714,"id":236219509,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjIxOTUwOQ==","diff_hunk":"@@ -392,19 +409,22 @@ module.exports = function(grunt) {\n                   echo 'ERROR: Links found with target=\"_blank\" but no rel=\"noopener noreferrer\" set.  Please add required rel attribute.')`,\n       },\n       'setup-admin': {\n+        stderr: true,\n         cmd:\n-          'curl -X PUT http://localhost:5984/_node/${COUCH_NODE_NAME}/_config/admins/admin -d \\'\"pass\"\\'' +\n-          ' && curl -X POST http://admin:pass@localhost:5984/_users ' +\n+          `curl -X PUT ${couchConfig.withPathNoAuth(couchConfig.dbName)}` +\n+          ` && curl -X PUT ${couchConfig.withPathNoAuth('_users')}` +\n+          ` && curl -X PUT ${couchConfig.withPathNoAuth('_node/${COUCH_NODE_NAME}/_config/admins/admin')} -d '\"${couchConfig.password}\"'` +\n+          ` && curl -X POST ${couchConfig.withPath('_users')} ` +\n           ' -H \"Content-Type: application/json\" ' +\n-          ' -d \\'{\"_id\": \"org.couchdb.user:admin\", \"name\": \"admin\", \"password\":\"pass\", \"type\":\"user\", \"roles\":[]}\\' ' +\n-          ' && curl -X PUT --data \\'\"true\"\\' http://admin:pass@localhost:5984/_node/${COUCH_NODE_NAME}/_config/chttpd/require_valid_user' +\n-          ' && curl -X PUT --data \\'\"4294967296\"\\' http://admin:pass@localhost:5984/_node/${COUCH_NODE_NAME}/_config/httpd/max_http_request_size',\n+          ` -d '{\"_id\": \"org.couchdb.user:${couchConfig.username}\", \"name\": \"${couchConfig.username}\", \"password\":\"${couchConfig.password}\", \"type\":\"user\", \"roles\":[]}' ` +\n+          ` && curl -X PUT --data '\"true\"' ${couchConfig.withPath('_node/${COUCH_NODE_NAME}/_config/chttpd/require_valid_user')}` +","path":"Gruntfile.js","position":85,"original_position":85,"commit_id":"6dbc317edca759cd0650ea337f1289f59c613ee8","original_commit_id":"6dbc317edca759cd0650ea337f1289f59c613ee8","user":{"login":"alxndrsn","id":191496,"node_id":"MDQ6VXNlcjE5MTQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/191496?v=4","gravatar_id":"","url":"https://api.github.com/users/alxndrsn","html_url":"https://github.com/alxndrsn","followers_url":"https://api.github.com/users/alxndrsn/followers","following_url":"https://api.github.com/users/alxndrsn/following{/other_user}","gists_url":"https://api.github.com/users/alxndrsn/gists{/gist_id}","starred_url":"https://api.github.com/users/alxndrsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxndrsn/subscriptions","organizations_url":"https://api.github.com/users/alxndrsn/orgs","repos_url":"https://api.github.com/users/alxndrsn/repos","events_url":"https://api.github.com/users/alxndrsn/events{/privacy}","received_events_url":"https://api.github.com/users/alxndrsn/received_events","type":"User","site_admin":false},"body":"is the interaction between javascript's and bash's string interpolation going to be problematic? ","created_at":"2018-11-26T11:38:13Z","updated_at":"2018-11-26T11:39:32Z","html_url":"https://github.com/medic/medic-webapp/pull/4980#discussion_r236219509","pull_request_url":"https://api.github.com/repos/medic/medic-webapp/pulls/4980","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/comments/236219509"},"html":{"href":"https://github.com/medic/medic-webapp/pull/4980#discussion_r236219509"},"pull_request":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/4980"}}},"pull_request":{"url":"https://api.github.com/repos/medic/medic-webapp/pulls/4980","id":230770384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzcwMzg0","html_url":"https://github.com/medic/medic-webapp/pull/4980","diff_url":"https://github.com/medic/medic-webapp/pull/4980.diff","patch_url":"https://github.com/medic/medic-webapp/pull/4980.patch","issue_url":"https://api.github.com/repos/medic/medic-webapp/issues/4980","number":4980,"state":"open","locked":false,"title":"#4979 - Update build scripts and documentation to avoid weak CouchDB passwords","user":{"login":"kennsippell","id":9014751,"node_id":"MDQ6VXNlcjkwMTQ3NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9014751?v=4","gravatar_id":"","url":"https://api.github.com/users/kennsippell","html_url":"https://github.com/kennsippell","followers_url":"https://api.github.com/users/kennsippell/followers","following_url":"https://api.github.com/users/kennsippell/following{/other_user}","gists_url":"https://api.github.com/users/kennsippell/gists{/gist_id}","starred_url":"https://api.github.com/users/kennsippell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennsippell/subscriptions","organizations_url":"https://api.github.com/users/kennsippell/orgs","repos_url":"https://api.github.com/users/kennsippell/repos","events_url":"https://api.github.com/users/kennsippell/events{/privacy}","received_events_url":"https://api.github.com/users/kennsippell/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nmedic/medic-webapp#4979\r\n\r\n# Review checklist\r\n\r\n- [ ] Readable: Concise, well named, follows the [style guide](https://github.com/medic/medic-docs/blob/master/development/style-guide.md), documented if necessary.\r\n- [ ] Documented: Announced in Changes.md in plain English. Configuration and user documentation on [medic-docs](https://github.com/medic/medic-docs/)\r\n- [ ] Tested: Unit and/or e2e where appropriate\r\n- [ ] Internationalised: All user facing text\r\n- [ ] Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in Changes.md.\r\n\r\n# License\r\n\r\nThe software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.\r\n","created_at":"2018-11-14T09:49:04Z","updated_at":"2018-11-26T11:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0466c00b41753622f8a0c5bc66b7335dc8521a82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/medic/medic-webapp/pulls/4980/commits","review_comments_url":"https://api.github.com/repos/medic/medic-webapp/pulls/4980/comments","review_comment_url":"https://api.github.com/repos/medic/medic-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/medic/medic-webapp/issues/4980/comments","statuses_url":"https://api.github.com/repos/medic/medic-webapp/statuses/6dbc317edca759cd0650ea337f1289f59c613ee8","head":{"label":"kennsippell:4979-couchdb-weak-passwords","ref":"4979-couchdb-weak-passwords","sha":"6dbc317edca759cd0650ea337f1289f59c613ee8","user":{"login":"kennsippell","id":9014751,"node_id":"MDQ6VXNlcjkwMTQ3NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9014751?v=4","gravatar_id":"","url":"https://api.github.com/users/kennsippell","html_url":"https://github.com/kennsippell","followers_url":"https://api.github.com/users/kennsippell/followers","following_url":"https://api.github.com/users/kennsippell/following{/other_user}","gists_url":"https://api.github.com/users/kennsippell/gists{/gist_id}","starred_url":"https://api.github.com/users/kennsippell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennsippell/subscriptions","organizations_url":"https://api.github.com/users/kennsippell/orgs","repos_url":"https://api.github.com/users/kennsippell/repos","events_url":"https://api.github.com/users/kennsippell/events{/privacy}","received_events_url":"https://api.github.com/users/kennsippell/received_events","type":"User","site_admin":false},"repo":{"id":148520056,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MjAwNTY=","name":"medic-webapp","full_name":"kennsippell/medic-webapp","private":false,"owner":{"login":"kennsippell","id":9014751,"node_id":"MDQ6VXNlcjkwMTQ3NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9014751?v=4","gravatar_id":"","url":"https://api.github.com/users/kennsippell","html_url":"https://github.com/kennsippell","followers_url":"https://api.github.com/users/kennsippell/followers","following_url":"https://api.github.com/users/kennsippell/following{/other_user}","gists_url":"https://api.github.com/users/kennsippell/gists{/gist_id}","starred_url":"https://api.github.com/users/kennsippell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennsippell/subscriptions","organizations_url":"https://api.github.com/users/kennsippell/orgs","repos_url":"https://api.github.com/users/kennsippell/repos","events_url":"https://api.github.com/users/kennsippell/events{/privacy}","received_events_url":"https://api.github.com/users/kennsippell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kennsippell/medic-webapp","description":"Medic Mobile combines SMS messaging, data collection, and analytics for health workers and health systems in hard-to-reach areas with or without internet connectivity.","fork":true,"url":"https://api.github.com/repos/kennsippell/medic-webapp","forks_url":"https://api.github.com/repos/kennsippell/medic-webapp/forks","keys_url":"https://api.github.com/repos/kennsippell/medic-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennsippell/medic-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennsippell/medic-webapp/teams","hooks_url":"https://api.github.com/repos/kennsippell/medic-webapp/hooks","issue_events_url":"https://api.github.com/repos/kennsippell/medic-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/kennsippell/medic-webapp/events","assignees_url":"https://api.github.com/repos/kennsippell/medic-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/kennsippell/medic-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/kennsippell/medic-webapp/tags","blobs_url":"https://api.github.com/repos/kennsippell/medic-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennsippell/medic-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennsippell/medic-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennsippell/medic-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennsippell/medic-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/kennsippell/medic-webapp/languages","stargazers_url":"https://api.github.com/repos/kennsippell/medic-webapp/stargazers","contributors_url":"https://api.github.com/repos/kennsippell/medic-webapp/contributors","subscribers_url":"https://api.github.com/repos/kennsippell/medic-webapp/subscribers","subscription_url":"https://api.github.com/repos/kennsippell/medic-webapp/subscription","commits_url":"https://api.github.com/repos/kennsippell/medic-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennsippell/medic-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennsippell/medic-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennsippell/medic-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennsippell/medic-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/kennsippell/medic-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennsippell/medic-webapp/merges","archive_url":"https://api.github.com/repos/kennsippell/medic-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennsippell/medic-webapp/downloads","issues_url":"https://api.github.com/repos/kennsippell/medic-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/kennsippell/medic-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/kennsippell/medic-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/kennsippell/medic-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennsippell/medic-webapp/labels{/name}","releases_url":"https://api.github.com/repos/kennsippell/medic-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/kennsippell/medic-webapp/deployments","created_at":"2018-09-12T17:56:36Z","updated_at":"2018-11-23T17:28:08Z","pushed_at":"2018-11-26T11:30:28Z","git_url":"git://github.com/kennsippell/medic-webapp.git","ssh_url":"git@github.com:kennsippell/medic-webapp.git","clone_url":"https://github.com/kennsippell/medic-webapp.git","svn_url":"https://github.com/kennsippell/medic-webapp","homepage":"http://medicmobile.org/tools","size":53931,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"medic:master","ref":"master","sha":"5a22eb035f95ede7f6ccb714d270ffd880195648","user":{"login":"medic","id":474424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDQyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/474424?v=4","gravatar_id":"","url":"https://api.github.com/users/medic","html_url":"https://github.com/medic","followers_url":"https://api.github.com/users/medic/followers","following_url":"https://api.github.com/users/medic/following{/other_user}","gists_url":"https://api.github.com/users/medic/gists{/gist_id}","starred_url":"https://api.github.com/users/medic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medic/subscriptions","organizations_url":"https://api.github.com/users/medic/orgs","repos_url":"https://api.github.com/users/medic/repos","events_url":"https://api.github.com/users/medic/events{/privacy}","received_events_url":"https://api.github.com/users/medic/received_events","type":"Organization","site_admin":false},"repo":{"id":2698821,"node_id":"MDEwOlJlcG9zaXRvcnkyNjk4ODIx","name":"medic-webapp","full_name":"medic/medic-webapp","private":false,"owner":{"login":"medic","id":474424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDQyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/474424?v=4","gravatar_id":"","url":"https://api.github.com/users/medic","html_url":"https://github.com/medic","followers_url":"https://api.github.com/users/medic/followers","following_url":"https://api.github.com/users/medic/following{/other_user}","gists_url":"https://api.github.com/users/medic/gists{/gist_id}","starred_url":"https://api.github.com/users/medic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medic/subscriptions","organizations_url":"https://api.github.com/users/medic/orgs","repos_url":"https://api.github.com/users/medic/repos","events_url":"https://api.github.com/users/medic/events{/privacy}","received_events_url":"https://api.github.com/users/medic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/medic/medic-webapp","description":"Medic Mobile combines SMS messaging, data collection, and analytics for health workers and health systems in hard-to-reach areas with or without internet connectivity.","fork":false,"url":"https://api.github.com/repos/medic/medic-webapp","forks_url":"https://api.github.com/repos/medic/medic-webapp/forks","keys_url":"https://api.github.com/repos/medic/medic-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medic/medic-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medic/medic-webapp/teams","hooks_url":"https://api.github.com/repos/medic/medic-webapp/hooks","issue_events_url":"https://api.github.com/repos/medic/medic-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/medic/medic-webapp/events","assignees_url":"https://api.github.com/repos/medic/medic-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/medic/medic-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/medic/medic-webapp/tags","blobs_url":"https://api.github.com/repos/medic/medic-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medic/medic-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medic/medic-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/medic/medic-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medic/medic-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/medic/medic-webapp/languages","stargazers_url":"https://api.github.com/repos/medic/medic-webapp/stargazers","contributors_url":"https://api.github.com/repos/medic/medic-webapp/contributors","subscribers_url":"https://api.github.com/repos/medic/medic-webapp/subscribers","subscription_url":"https://api.github.com/repos/medic/medic-webapp/subscription","commits_url":"https://api.github.com/repos/medic/medic-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/medic/medic-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/medic/medic-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/medic/medic-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/medic/medic-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/medic/medic-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medic/medic-webapp/merges","archive_url":"https://api.github.com/repos/medic/medic-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medic/medic-webapp/downloads","issues_url":"https://api.github.com/repos/medic/medic-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/medic/medic-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/medic/medic-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/medic/medic-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medic/medic-webapp/labels{/name}","releases_url":"https://api.github.com/repos/medic/medic-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/medic/medic-webapp/deployments","created_at":"2011-11-02T23:19:55Z","updated_at":"2018-11-26T09:27:28Z","pushed_at":"2018-11-26T11:30:30Z","git_url":"git://github.com/medic/medic-webapp.git","ssh_url":"git@github.com:medic/medic-webapp.git","clone_url":"https://github.com/medic/medic-webapp.git","svn_url":"https://github.com/medic/medic-webapp","homepage":"http://medicmobile.org/tools","size":61759,"stargazers_count":217,"watchers_count":217,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":312,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":68,"open_issues":312,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/4980"},"html":{"href":"https://github.com/medic/medic-webapp/pull/4980"},"issue":{"href":"https://api.github.com/repos/medic/medic-webapp/issues/4980"},"comments":{"href":"https://api.github.com/repos/medic/medic-webapp/issues/4980/comments"},"review_comments":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/4980/comments"},"review_comment":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/medic/medic-webapp/pulls/4980/commits"},"statuses":{"href":"https://api.github.com/repos/medic/medic-webapp/statuses/6dbc317edca759cd0650ea337f1289f59c613ee8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alxndrsn"}}