{"action":"created","issue":{"url":"https://api.github.com/repos/natritmeyer/site_prism/issues/66","repository_url":"https://api.github.com/repos/natritmeyer/site_prism","labels_url":"https://api.github.com/repos/natritmeyer/site_prism/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/natritmeyer/site_prism/issues/66/comments","events_url":"https://api.github.com/repos/natritmeyer/site_prism/issues/66/events","html_url":"https://github.com/natritmeyer/site_prism/issues/66","id":28471732,"number":66,"title":"[IFRAMES] has_selector? and wait_for_selector? dont seem to work for iframes","user":{"login":"lesliepc16","id":2001041,"avatar_url":"https://avatars2.githubusercontent.com/u/2001041?v=4","gravatar_id":"","url":"https://api.github.com/users/lesliepc16","html_url":"https://github.com/lesliepc16","followers_url":"https://api.github.com/users/lesliepc16/followers","following_url":"https://api.github.com/users/lesliepc16/following{/other_user}","gists_url":"https://api.github.com/users/lesliepc16/gists{/gist_id}","starred_url":"https://api.github.com/users/lesliepc16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesliepc16/subscriptions","organizations_url":"https://api.github.com/users/lesliepc16/orgs","repos_url":"https://api.github.com/users/lesliepc16/repos","events_url":"https://api.github.com/users/lesliepc16/events{/privacy}","received_events_url":"https://api.github.com/users/lesliepc16/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2014-02-28T01:35:38Z","updated_at":"2018-03-10T19:51:34Z","closed_at":null,"author_association":"NONE","body":"The helper functions added by site prism do not appear to work for iFrames.\n\nFor example, say I have the following section:\n\n``` rb\nclass MySection < SitePrism::Section\n  class PreviewIframe < SitePrism::Page\n  end\n  iframe :preview, PreviewIframe, \"#preview\"\nend\n```\n\nThis is returning false even if the preview is displayed on the page.\n\n``` rb\nmy_section.has_preview?\n```\n\nwait_for_preview doesn't appear to work either.\n\nI verified that the iframe works in that I can do actions within it. It's just the wait_for_preview and has_preview? methods that aren't behaving.\n\nIs this as designed? It'd be great to have these working for iframes also. Thanks!\n"},"comment":{"url":"https://api.github.com/repos/natritmeyer/site_prism/issues/comments/372060429","html_url":"https://github.com/natritmeyer/site_prism/issues/66#issuecomment-372060429","issue_url":"https://api.github.com/repos/natritmeyer/site_prism/issues/66","id":372060429,"user":{"login":"luke-hill","id":20105237,"avatar_url":"https://avatars2.githubusercontent.com/u/20105237?v=4","gravatar_id":"","url":"https://api.github.com/users/luke-hill","html_url":"https://github.com/luke-hill","followers_url":"https://api.github.com/users/luke-hill/followers","following_url":"https://api.github.com/users/luke-hill/following{/other_user}","gists_url":"https://api.github.com/users/luke-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-hill/subscriptions","organizations_url":"https://api.github.com/users/luke-hill/orgs","repos_url":"https://api.github.com/users/luke-hill/repos","events_url":"https://api.github.com/users/luke-hill/events{/privacy}","received_events_url":"https://api.github.com/users/luke-hill/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T19:51:34Z","updated_at":"2018-03-10T19:51:34Z","author_association":"COLLABORATOR","body":"So I've re-created this and compared to the unit / feature tests we have and think I've spotted the problem (Although why some of the helpers work I'm not sure). I managed to get a similar example passing.\r\n\r\nYou're code example has the references defined incorrectly. You've namespaced your iFrame inside your other class, and as such need to reference the ClassName accordingly.\r\n\r\nIt could be something that's causing some of the helpers to work and others not. But essentially it wouldn't be looked into unless you've got a valid SSCCE\r\n\r\nReference Cuke that calls both of your failing methods: https://github.com/natritmeyer/site_prism/blob/master/features/step_definitions/iframe_steps.rb#L4-L6"}}
{"actor":{"display_login":"luke-hill"}}