{"action":"created","comment":{"url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/comments/209636415","pull_request_review_id":145687105,"id":209636415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTYzNjQxNQ==","diff_hunk":"@@ -6,4 +6,4 @@ def start(self, doc):\n         print('START ANALYSIS ON {}'.format(doc['uid']))\n \n     def stop(self, doc):\n-        print('FINISH ANALYSIS ON {}'.format(doc['run_start']))\n+        print('FINISH ANALYSIS ON {}'.format(doc.get('run_start', 'NA')))","path":"xpdan/callbacks.py","position":5,"original_position":5,"commit_id":"764c5a1c7e159fd63fd59100b04c77e107093d13","original_commit_id":"f194917ab4c1747655cdcef997d4e37923db4f62","user":{"login":"CJ-Wright","id":6740689,"node_id":"MDQ6VXNlcjY3NDA2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/6740689?v=4","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"body":"This message was initially intended as a kind of heartbeat for the pipeline, letting users know if it is currently processing data or if it has finished (and which data it finished on). I have had users send me this so I could figure out what was going on, and it does help users know how much data there is in the queue.\r\n\r\nFormally it isn't a problem for the pipeline if a stop isn't issued (at least when this PR is merged and it won't keep crashing the pipeline), but it is rather odd for the run engine to not issue a stop (we've been running into this about once or twice a beamtime which is a little bit disconcerting). So I wouldn't do anything to alarm the users, but we do need to handle it somehow.","created_at":"2018-08-13T14:44:35Z","updated_at":"2018-08-13T14:44:35Z","html_url":"https://github.com/xpdAcq/xpdAn/pull/222#discussion_r209636415","pull_request_url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/comments/209636415"},"html":{"href":"https://github.com/xpdAcq/xpdAn/pull/222#discussion_r209636415"},"pull_request":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222"}},"in_reply_to_id":209629165},"pull_request":{"url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222","id":205492693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDkyNjkz","html_url":"https://github.com/xpdAcq/xpdAn/pull/222","diff_url":"https://github.com/xpdAcq/xpdAn/pull/222.diff","patch_url":"https://github.com/xpdAcq/xpdAn/pull/222.patch","issue_url":"https://api.github.com/repos/xpdAcq/xpdAn/issues/222","number":222,"state":"open","locked":false,"title":"Run save before additional analysis","user":{"login":"CJ-Wright","id":6740689,"node_id":"MDQ6VXNlcjY3NDA2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/6740689?v=4","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-01T17:08:03Z","updated_at":"2018-08-13T14:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ccc07d0cedca2bfda18239a741fece4766ecfe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222/commits","review_comments_url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222/comments","review_comment_url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xpdAcq/xpdAn/issues/222/comments","statuses_url":"https://api.github.com/repos/xpdAcq/xpdAn/statuses/764c5a1c7e159fd63fd59100b04c77e107093d13","head":{"label":"CJ-Wright:save_first","ref":"save_first","sha":"764c5a1c7e159fd63fd59100b04c77e107093d13","user":{"login":"CJ-Wright","id":6740689,"node_id":"MDQ6VXNlcjY3NDA2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/6740689?v=4","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"repo":{"id":68024662,"node_id":"MDEwOlJlcG9zaXRvcnk2ODAyNDY2Mg==","name":"xpdAn","full_name":"CJ-Wright/xpdAn","owner":{"login":"CJ-Wright","id":6740689,"node_id":"MDQ6VXNlcjY3NDA2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/6740689?v=4","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CJ-Wright/xpdAn","description":null,"fork":true,"url":"https://api.github.com/repos/CJ-Wright/xpdAn","forks_url":"https://api.github.com/repos/CJ-Wright/xpdAn/forks","keys_url":"https://api.github.com/repos/CJ-Wright/xpdAn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJ-Wright/xpdAn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJ-Wright/xpdAn/teams","hooks_url":"https://api.github.com/repos/CJ-Wright/xpdAn/hooks","issue_events_url":"https://api.github.com/repos/CJ-Wright/xpdAn/issues/events{/number}","events_url":"https://api.github.com/repos/CJ-Wright/xpdAn/events","assignees_url":"https://api.github.com/repos/CJ-Wright/xpdAn/assignees{/user}","branches_url":"https://api.github.com/repos/CJ-Wright/xpdAn/branches{/branch}","tags_url":"https://api.github.com/repos/CJ-Wright/xpdAn/tags","blobs_url":"https://api.github.com/repos/CJ-Wright/xpdAn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJ-Wright/xpdAn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJ-Wright/xpdAn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJ-Wright/xpdAn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJ-Wright/xpdAn/statuses/{sha}","languages_url":"https://api.github.com/repos/CJ-Wright/xpdAn/languages","stargazers_url":"https://api.github.com/repos/CJ-Wright/xpdAn/stargazers","contributors_url":"https://api.github.com/repos/CJ-Wright/xpdAn/contributors","subscribers_url":"https://api.github.com/repos/CJ-Wright/xpdAn/subscribers","subscription_url":"https://api.github.com/repos/CJ-Wright/xpdAn/subscription","commits_url":"https://api.github.com/repos/CJ-Wright/xpdAn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJ-Wright/xpdAn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJ-Wright/xpdAn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJ-Wright/xpdAn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJ-Wright/xpdAn/contents/{+path}","compare_url":"https://api.github.com/repos/CJ-Wright/xpdAn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJ-Wright/xpdAn/merges","archive_url":"https://api.github.com/repos/CJ-Wright/xpdAn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJ-Wright/xpdAn/downloads","issues_url":"https://api.github.com/repos/CJ-Wright/xpdAn/issues{/number}","pulls_url":"https://api.github.com/repos/CJ-Wright/xpdAn/pulls{/number}","milestones_url":"https://api.github.com/repos/CJ-Wright/xpdAn/milestones{/number}","notifications_url":"https://api.github.com/repos/CJ-Wright/xpdAn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJ-Wright/xpdAn/labels{/name}","releases_url":"https://api.github.com/repos/CJ-Wright/xpdAn/releases{/id}","deployments_url":"https://api.github.com/repos/CJ-Wright/xpdAn/deployments","created_at":"2016-09-12T16:03:23Z","updated_at":"2016-09-14T21:41:55Z","pushed_at":"2018-08-13T14:27:16Z","git_url":"git://github.com/CJ-Wright/xpdAn.git","ssh_url":"git@github.com:CJ-Wright/xpdAn.git","clone_url":"https://github.com/CJ-Wright/xpdAn.git","svn_url":"https://github.com/CJ-Wright/xpdAn","homepage":null,"size":42183,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xpdAcq:master","ref":"master","sha":"675cc842652c608cb8fa0431bef98052f4c84b5f","user":{"login":"xpdAcq","id":17029040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDI5MDQw","avatar_url":"https://avatars3.githubusercontent.com/u/17029040?v=4","gravatar_id":"","url":"https://api.github.com/users/xpdAcq","html_url":"https://github.com/xpdAcq","followers_url":"https://api.github.com/users/xpdAcq/followers","following_url":"https://api.github.com/users/xpdAcq/following{/other_user}","gists_url":"https://api.github.com/users/xpdAcq/gists{/gist_id}","starred_url":"https://api.github.com/users/xpdAcq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpdAcq/subscriptions","organizations_url":"https://api.github.com/users/xpdAcq/orgs","repos_url":"https://api.github.com/users/xpdAcq/repos","events_url":"https://api.github.com/users/xpdAcq/events{/privacy}","received_events_url":"https://api.github.com/users/xpdAcq/received_events","type":"Organization","site_admin":false},"repo":{"id":61145961,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE0NTk2MQ==","name":"xpdAn","full_name":"xpdAcq/xpdAn","owner":{"login":"xpdAcq","id":17029040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDI5MDQw","avatar_url":"https://avatars3.githubusercontent.com/u/17029040?v=4","gravatar_id":"","url":"https://api.github.com/users/xpdAcq","html_url":"https://github.com/xpdAcq","followers_url":"https://api.github.com/users/xpdAcq/followers","following_url":"https://api.github.com/users/xpdAcq/following{/other_user}","gists_url":"https://api.github.com/users/xpdAcq/gists{/gist_id}","starred_url":"https://api.github.com/users/xpdAcq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpdAcq/subscriptions","organizations_url":"https://api.github.com/users/xpdAcq/orgs","repos_url":"https://api.github.com/users/xpdAcq/repos","events_url":"https://api.github.com/users/xpdAcq/events{/privacy}","received_events_url":"https://api.github.com/users/xpdAcq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xpdAcq/xpdAn","description":"Analysis Pipelines and Tools for XPD","fork":false,"url":"https://api.github.com/repos/xpdAcq/xpdAn","forks_url":"https://api.github.com/repos/xpdAcq/xpdAn/forks","keys_url":"https://api.github.com/repos/xpdAcq/xpdAn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xpdAcq/xpdAn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xpdAcq/xpdAn/teams","hooks_url":"https://api.github.com/repos/xpdAcq/xpdAn/hooks","issue_events_url":"https://api.github.com/repos/xpdAcq/xpdAn/issues/events{/number}","events_url":"https://api.github.com/repos/xpdAcq/xpdAn/events","assignees_url":"https://api.github.com/repos/xpdAcq/xpdAn/assignees{/user}","branches_url":"https://api.github.com/repos/xpdAcq/xpdAn/branches{/branch}","tags_url":"https://api.github.com/repos/xpdAcq/xpdAn/tags","blobs_url":"https://api.github.com/repos/xpdAcq/xpdAn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xpdAcq/xpdAn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xpdAcq/xpdAn/git/refs{/sha}","trees_url":"https://api.github.com/repos/xpdAcq/xpdAn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xpdAcq/xpdAn/statuses/{sha}","languages_url":"https://api.github.com/repos/xpdAcq/xpdAn/languages","stargazers_url":"https://api.github.com/repos/xpdAcq/xpdAn/stargazers","contributors_url":"https://api.github.com/repos/xpdAcq/xpdAn/contributors","subscribers_url":"https://api.github.com/repos/xpdAcq/xpdAn/subscribers","subscription_url":"https://api.github.com/repos/xpdAcq/xpdAn/subscription","commits_url":"https://api.github.com/repos/xpdAcq/xpdAn/commits{/sha}","git_commits_url":"https://api.github.com/repos/xpdAcq/xpdAn/git/commits{/sha}","comments_url":"https://api.github.com/repos/xpdAcq/xpdAn/comments{/number}","issue_comment_url":"https://api.github.com/repos/xpdAcq/xpdAn/issues/comments{/number}","contents_url":"https://api.github.com/repos/xpdAcq/xpdAn/contents/{+path}","compare_url":"https://api.github.com/repos/xpdAcq/xpdAn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xpdAcq/xpdAn/merges","archive_url":"https://api.github.com/repos/xpdAcq/xpdAn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xpdAcq/xpdAn/downloads","issues_url":"https://api.github.com/repos/xpdAcq/xpdAn/issues{/number}","pulls_url":"https://api.github.com/repos/xpdAcq/xpdAn/pulls{/number}","milestones_url":"https://api.github.com/repos/xpdAcq/xpdAn/milestones{/number}","notifications_url":"https://api.github.com/repos/xpdAcq/xpdAn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xpdAcq/xpdAn/labels{/name}","releases_url":"https://api.github.com/repos/xpdAcq/xpdAn/releases{/id}","deployments_url":"https://api.github.com/repos/xpdAcq/xpdAn/deployments","created_at":"2016-06-14T18:21:57Z","updated_at":"2018-07-29T21:21:59Z","pushed_at":"2018-08-13T14:27:18Z","git_url":"git://github.com/xpdAcq/xpdAn.git","ssh_url":"git@github.com:xpdAcq/xpdAn.git","clone_url":"https://github.com/xpdAcq/xpdAn.git","svn_url":"https://github.com/xpdAcq/xpdAn","homepage":"http://xpdacq.github.io/xpdAn/","size":11617,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":28,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222"},"html":{"href":"https://github.com/xpdAcq/xpdAn/pull/222"},"issue":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/issues/222"},"comments":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/xpdAcq/xpdAn/statuses/764c5a1c7e159fd63fd59100b04c77e107093d13"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CJ-Wright"}}