{"action":"created","issue":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4005","repository_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4005/labels{/name}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4005/comments","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4005/events","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4005","id":383616044,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDQzMDc3","number":4005,"title":"[ADF-3615] created a pipe to replace empty space in strings with a sp…","user":{"login":"VitoAlbano","id":7974125,"node_id":"MDQ6VXNlcjc5NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/7974125?v=4","gravatar_id":"","url":"https://api.github.com/users/VitoAlbano","html_url":"https://github.com/VitoAlbano","followers_url":"https://api.github.com/users/VitoAlbano/followers","following_url":"https://api.github.com/users/VitoAlbano/following{/other_user}","gists_url":"https://api.github.com/users/VitoAlbano/gists{/gist_id}","starred_url":"https://api.github.com/users/VitoAlbano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitoAlbano/subscriptions","organizations_url":"https://api.github.com/users/VitoAlbano/orgs","repos_url":"https://api.github.com/users/VitoAlbano/repos","events_url":"https://api.github.com/users/VitoAlbano/events{/privacy}","received_events_url":"https://api.github.com/users/VitoAlbano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-22T17:16:08Z","updated_at":"2018-11-22T18:54:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4005","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4005","diff_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4005.diff","patch_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4005.patch"},"body":"…ecial character\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n> - [ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-ng2-components/wiki/Commit-format)\r\n> - [ ] Tests for the changes have been added (for bug fixes / features)\r\n> - [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n<!--\r\n Before submitting your PR, please check that your code follows our contribution guidelines:\r\n https://github.com/Alfresco/alfresco-ng2-components/wiki/Code-contribution-acceptance-criteria\r\n -->\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n\r\n> - [X] Bugfix\r\n> - [ ] Feature\r\n> - [ ] Code style update (formatting, local variables)\r\n> - [ ] Refactoring (no functional changes, no api changes)\r\n> - [ ] Build related changes\r\n> - [ ] Documentation\r\n> - [ ] Other... Please describe:\r\n\r\n\r\n**What is the current behaviour?** (You can also link to an open issue here)\r\nCustom outcome id's are keeping the spaces\r\n\r\n\r\n**What is the new behaviour?**\r\nCustom outcome id's are now formatted with an underscore replacing the spaces.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n> - [ ] Yes\r\n> - [x] No\r\n\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n**Other information**:\r\nhttps://issues.alfresco.com/jira/browse/ADF-3615"},"comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments/441103917","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4005#issuecomment-441103917","issue_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4005","id":441103917,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTEwMzkxNw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T18:54:50Z","updated_at":"2018-11-22T18:54:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=h1) Report\n> Merging [#4005](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=desc) into [development](https://codecov.io/gh/Alfresco/alfresco-ng2-components/commit/974929e76deed274ee0a4111f94bf6748610a9a3?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005/graphs/tree.svg?width=650&token=F2fwhZ71jw&height=150&src=pr)](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##           development    #4005   +/-   ##\n============================================\n  Coverage        56.65%   56.65%           \n============================================\n  Files                5        5           \n  Lines              233      233           \n  Branches            52       52           \n============================================\n  Hits               132      132           \n  Misses              98       98           \n  Partials             3        3\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=footer). Last update [974929e...b80e6ee](https://codecov.io/gh/Alfresco/alfresco-ng2-components/pull/4005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}