{"action":"created","comment":{"url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/comments/234470014","pull_request_review_id":176114829,"id":234470014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ3MDAxNA==","diff_hunk":"@@ -167,7 +173,7 @@ func resourceRackcorpServer() *schema.Resource {\n \t\t\t\tSensitive: true,\n \t\t\t},\n \t\t\t\"data_center_id\": {\n-\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tType:     schema.TypeInt,","path":"rackcorp/resourceRackcorpServer.go","position":32,"original_position":32,"commit_id":"5f7fd733f191b3933a0ef16c3200cb83cc5bd4b8","original_commit_id":"5f7fd733f191b3933a0ef16c3200cb83cc5bd4b8","user":{"login":"jstangroome","id":148754,"node_id":"MDQ6VXNlcjE0ODc1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/148754?v=4","gravatar_id":"","url":"https://api.github.com/users/jstangroome","html_url":"https://github.com/jstangroome","followers_url":"https://api.github.com/users/jstangroome/followers","following_url":"https://api.github.com/users/jstangroome/following{/other_user}","gists_url":"https://api.github.com/users/jstangroome/gists{/gist_id}","starred_url":"https://api.github.com/users/jstangroome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstangroome/subscriptions","organizations_url":"https://api.github.com/users/jstangroome/orgs","repos_url":"https://api.github.com/users/jstangroome/repos","events_url":"https://api.github.com/users/jstangroome/events{/privacy}","received_events_url":"https://api.github.com/users/jstangroome/received_events","type":"User","site_admin":false},"body":"This was originally a string because we didn't want to couple to Rackcorp's choice of ID data type but keep it opaque.","created_at":"2018-11-19T00:12:31Z","updated_at":"2018-11-19T00:15:34Z","html_url":"https://github.com/section-io/terraform-provider-rackcorp/pull/8#discussion_r234470014","pull_request_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/comments/234470014"},"html":{"href":"https://github.com/section-io/terraform-provider-rackcorp/pull/8#discussion_r234470014"},"pull_request":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8","id":230373088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzczMDg4","html_url":"https://github.com/section-io/terraform-provider-rackcorp/pull/8","diff_url":"https://github.com/section-io/terraform-provider-rackcorp/pull/8.diff","patch_url":"https://github.com/section-io/terraform-provider-rackcorp/pull/8.patch","issue_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/8","number":8,"state":"closed","locked":false,"title":"adding logic to add/remove firewall rules","user":{"login":"mwickman","id":1020802,"node_id":"MDQ6VXNlcjEwMjA4MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1020802?v=4","gravatar_id":"","url":"https://api.github.com/users/mwickman","html_url":"https://github.com/mwickman","followers_url":"https://api.github.com/users/mwickman/followers","following_url":"https://api.github.com/users/mwickman/following{/other_user}","gists_url":"https://api.github.com/users/mwickman/gists{/gist_id}","starred_url":"https://api.github.com/users/mwickman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwickman/subscriptions","organizations_url":"https://api.github.com/users/mwickman/orgs","repos_url":"https://api.github.com/users/mwickman/repos","events_url":"https://api.github.com/users/mwickman/events{/privacy}","received_events_url":"https://api.github.com/users/mwickman/received_events","type":"User","site_admin":false},"body":"I've tested this with a local terraform file, and was able to both add and delete firewall rules.\r\n\r\nThere are a few odd type conversions around DeviceID which are due to RackCorp's API being inconsistent with treating it as a string or integer. I'll let them know the places for improvement.","created_at":"2018-11-13T07:29:46Z","updated_at":"2018-11-19T00:15:34Z","closed_at":"2018-11-13T17:35:38Z","merged_at":"2018-11-13T17:35:38Z","merge_commit_sha":"c9ac352fbfb1488a58371bd597772a57f936e304","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8/commits","review_comments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8/comments","review_comment_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/8/comments","statuses_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/statuses/5f7fd733f191b3933a0ef16c3200cb83cc5bd4b8","head":{"label":"section-io:feature/firewall-updating","ref":"feature/firewall-updating","sha":"5f7fd733f191b3933a0ef16c3200cb83cc5bd4b8","user":{"login":"section-io","id":10540200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQwMjAw","avatar_url":"https://avatars2.githubusercontent.com/u/10540200?v=4","gravatar_id":"","url":"https://api.github.com/users/section-io","html_url":"https://github.com/section-io","followers_url":"https://api.github.com/users/section-io/followers","following_url":"https://api.github.com/users/section-io/following{/other_user}","gists_url":"https://api.github.com/users/section-io/gists{/gist_id}","starred_url":"https://api.github.com/users/section-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/section-io/subscriptions","organizations_url":"https://api.github.com/users/section-io/orgs","repos_url":"https://api.github.com/users/section-io/repos","events_url":"https://api.github.com/users/section-io/events{/privacy}","received_events_url":"https://api.github.com/users/section-io/received_events","type":"Organization","site_admin":false},"repo":{"id":115079850,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwNzk4NTA=","name":"terraform-provider-rackcorp","full_name":"section-io/terraform-provider-rackcorp","private":false,"owner":{"login":"section-io","id":10540200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQwMjAw","avatar_url":"https://avatars2.githubusercontent.com/u/10540200?v=4","gravatar_id":"","url":"https://api.github.com/users/section-io","html_url":"https://github.com/section-io","followers_url":"https://api.github.com/users/section-io/followers","following_url":"https://api.github.com/users/section-io/following{/other_user}","gists_url":"https://api.github.com/users/section-io/gists{/gist_id}","starred_url":"https://api.github.com/users/section-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/section-io/subscriptions","organizations_url":"https://api.github.com/users/section-io/orgs","repos_url":"https://api.github.com/users/section-io/repos","events_url":"https://api.github.com/users/section-io/events{/privacy}","received_events_url":"https://api.github.com/users/section-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/section-io/terraform-provider-rackcorp","description":null,"fork":false,"url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp","forks_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/forks","keys_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/teams","hooks_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/hooks","issue_events_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/events{/number}","events_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/events","assignees_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/assignees{/user}","branches_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/branches{/branch}","tags_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/tags","blobs_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/refs{/sha}","trees_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/statuses/{sha}","languages_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/languages","stargazers_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/stargazers","contributors_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/contributors","subscribers_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/subscribers","subscription_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/subscription","commits_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/commits{/sha}","git_commits_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/commits{/sha}","comments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/comments{/number}","issue_comment_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/comments{/number}","contents_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/contents/{+path}","compare_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/merges","archive_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/downloads","issues_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues{/number}","pulls_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls{/number}","milestones_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/milestones{/number}","notifications_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/labels{/name}","releases_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/releases{/id}","deployments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/deployments","created_at":"2017-12-22T05:27:41Z","updated_at":"2018-11-14T22:13:56Z","pushed_at":"2018-11-15T15:42:12Z","git_url":"git://github.com/section-io/terraform-provider-rackcorp.git","ssh_url":"git@github.com:section-io/terraform-provider-rackcorp.git","clone_url":"https://github.com/section-io/terraform-provider-rackcorp.git","svn_url":"https://github.com/section-io/terraform-provider-rackcorp","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"section-io:master","ref":"master","sha":"a02712679be03dce8d7111daa72df4adf03a19b8","user":{"login":"section-io","id":10540200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQwMjAw","avatar_url":"https://avatars2.githubusercontent.com/u/10540200?v=4","gravatar_id":"","url":"https://api.github.com/users/section-io","html_url":"https://github.com/section-io","followers_url":"https://api.github.com/users/section-io/followers","following_url":"https://api.github.com/users/section-io/following{/other_user}","gists_url":"https://api.github.com/users/section-io/gists{/gist_id}","starred_url":"https://api.github.com/users/section-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/section-io/subscriptions","organizations_url":"https://api.github.com/users/section-io/orgs","repos_url":"https://api.github.com/users/section-io/repos","events_url":"https://api.github.com/users/section-io/events{/privacy}","received_events_url":"https://api.github.com/users/section-io/received_events","type":"Organization","site_admin":false},"repo":{"id":115079850,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwNzk4NTA=","name":"terraform-provider-rackcorp","full_name":"section-io/terraform-provider-rackcorp","private":false,"owner":{"login":"section-io","id":10540200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQwMjAw","avatar_url":"https://avatars2.githubusercontent.com/u/10540200?v=4","gravatar_id":"","url":"https://api.github.com/users/section-io","html_url":"https://github.com/section-io","followers_url":"https://api.github.com/users/section-io/followers","following_url":"https://api.github.com/users/section-io/following{/other_user}","gists_url":"https://api.github.com/users/section-io/gists{/gist_id}","starred_url":"https://api.github.com/users/section-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/section-io/subscriptions","organizations_url":"https://api.github.com/users/section-io/orgs","repos_url":"https://api.github.com/users/section-io/repos","events_url":"https://api.github.com/users/section-io/events{/privacy}","received_events_url":"https://api.github.com/users/section-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/section-io/terraform-provider-rackcorp","description":null,"fork":false,"url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp","forks_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/forks","keys_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/teams","hooks_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/hooks","issue_events_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/events{/number}","events_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/events","assignees_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/assignees{/user}","branches_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/branches{/branch}","tags_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/tags","blobs_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/refs{/sha}","trees_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/statuses/{sha}","languages_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/languages","stargazers_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/stargazers","contributors_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/contributors","subscribers_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/subscribers","subscription_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/subscription","commits_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/commits{/sha}","git_commits_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/git/commits{/sha}","comments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/comments{/number}","issue_comment_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/comments{/number}","contents_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/contents/{+path}","compare_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/merges","archive_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/downloads","issues_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues{/number}","pulls_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls{/number}","milestones_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/milestones{/number}","notifications_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/labels{/name}","releases_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/releases{/id}","deployments_url":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/deployments","created_at":"2017-12-22T05:27:41Z","updated_at":"2018-11-14T22:13:56Z","pushed_at":"2018-11-15T15:42:12Z","git_url":"git://github.com/section-io/terraform-provider-rackcorp.git","ssh_url":"git@github.com:section-io/terraform-provider-rackcorp.git","clone_url":"https://github.com/section-io/terraform-provider-rackcorp.git","svn_url":"https://github.com/section-io/terraform-provider-rackcorp","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8"},"html":{"href":"https://github.com/section-io/terraform-provider-rackcorp/pull/8"},"issue":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/8"},"comments":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/section-io/terraform-provider-rackcorp/statuses/5f7fd733f191b3933a0ef16c3200cb83cc5bd4b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jstangroome"}}