{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/202481353","pull_request_review_id":137200469,"id":202481353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ4MTM1Mw==","diff_hunk":"@@ -175,18 +120,34 @@ void TR_OutlinedInstructions::generateOutlinedInstructionsDispatch()\n    if (_targetReg)\n       {\n       TR_ASSERT(resultReg, \"assertion failure\");\n+      TR_ASSERT(resultReg->getKind() == _targetReg->getKind(), \"OutlinedInstructions: targetReg must have same time as resultReg.\");\n+\n       TR::RegisterPair *targetRegPair = _targetReg->getRegisterPair();\n       TR::RegisterPair *resultRegPair =  resultReg->getRegisterPair();\n+\n+      TR_ASSERT((targetRegPair == NULL && resultRegPair == NULL) ||\n+                (targetRegPair != NULL && resultRegPair != NULL),\n+                \"OutlinedInstructions: targetReg and resultReg must be both register pairs or neither register pairs.\");\n       if (targetRegPair)\n          {\n-         TR_ASSERT(resultRegPair, \"OutlinedInstructions: targetReg is a register pair and resultReg is not\");\n-         generateRegRegInstruction(_targetRegMovOpcode, _callNode, targetRegPair->getLowOrder(),  resultRegPair->getLowOrder(),  _cg);\n-         generateRegRegInstruction(_targetRegMovOpcode, _callNode, targetRegPair->getHighOrder(), resultRegPair->getHighOrder(), _cg);\n+         generateRegRegInstruction(MOVRegReg(), _callNode, targetRegPair->getLowOrder(),  resultRegPair->getLowOrder(),  _cg);\n+         generateRegRegInstruction(MOVRegReg(), _callNode, targetRegPair->getHighOrder(), resultRegPair->getHighOrder(), _cg);\n          }\n       else\n          {\n-         TR_ASSERT(!resultRegPair, \"OutlinedInstructions: resultReg is a register pair and targetReg is not\");\n-         generateRegRegInstruction(_targetRegMovOpcode, _callNode, _targetReg, resultReg, _cg);\n+         switch (resultReg->getKind())","path":"compiler/x/codegen/OutlinedInstructions.cpp","position":86,"original_position":86,"commit_id":"bf773b350f0cbee8e6bbc7663020036c70024af1","original_commit_id":"bf773b350f0cbee8e6bbc7663020036c70024af1","user":{"login":"vijaysun-omr","id":22303775,"node_id":"MDQ6VXNlcjIyMzAzNzc1","avatar_url":"https://avatars0.githubusercontent.com/u/22303775?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false},"body":"This switch seems to not fall in either category of change you mentioned in the commit message. Could you please clarify what this code is for ?","created_at":"2018-07-13T21:49:51Z","updated_at":"2018-07-13T21:49:51Z","html_url":"https://github.com/eclipse/omr/pull/2736#discussion_r202481353","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/2736","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/202481353"},"html":{"href":"https://github.com/eclipse/omr/pull/2736#discussion_r202481353"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2736"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2736","id":200457045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDU3MDQ1","html_url":"https://github.com/eclipse/omr/pull/2736","diff_url":"https://github.com/eclipse/omr/pull/2736.diff","patch_url":"https://github.com/eclipse/omr/pull/2736.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2736","number":2736,"state":"open","locked":false,"title":"Code cleanup related to X86 OutlinedInstruction","user":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"body":"Two constructors of TR_OutlinedInstructions are deprecated as a result of removal of VM thread rematerialization logic. Removing them.\r\n\r\nA piece of code that guarded by #if 0 is also removed.\r\n\r\nSigned-off-by: Victor Ding <dvictor@ca.ibm.com>","created_at":"2018-07-10T16:37:26Z","updated_at":"2018-07-13T21:49:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7db3aed89b8a7da9556f76493276692832c62590","assignee":{"login":"vijaysun-omr","id":22303775,"node_id":"MDQ6VXNlcjIyMzAzNzc1","avatar_url":"https://avatars0.githubusercontent.com/u/22303775?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false},"assignees":[{"login":"vijaysun-omr","id":22303775,"node_id":"MDQ6VXNlcjIyMzAzNzc1","avatar_url":"https://avatars0.githubusercontent.com/u/22303775?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463261830,"node_id":"MDU6TGFiZWw0NjMyNjE4MzA=","url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2736/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2736/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2736/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/bf773b350f0cbee8e6bbc7663020036c70024af1","head":{"label":"0dvictor:outlined","ref":"outlined","sha":"bf773b350f0cbee8e6bbc7663020036c70024af1","user":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"repo":{"id":72220821,"node_id":"MDEwOlJlcG9zaXRvcnk3MjIyMDgyMQ==","name":"omr","full_name":"0dvictor/omr","owner":{"login":"0dvictor","id":14084856,"node_id":"MDQ6VXNlcjE0MDg0ODU2","avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0dvictor/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/0dvictor/omr","forks_url":"https://api.github.com/repos/0dvictor/omr/forks","keys_url":"https://api.github.com/repos/0dvictor/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0dvictor/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0dvictor/omr/teams","hooks_url":"https://api.github.com/repos/0dvictor/omr/hooks","issue_events_url":"https://api.github.com/repos/0dvictor/omr/issues/events{/number}","events_url":"https://api.github.com/repos/0dvictor/omr/events","assignees_url":"https://api.github.com/repos/0dvictor/omr/assignees{/user}","branches_url":"https://api.github.com/repos/0dvictor/omr/branches{/branch}","tags_url":"https://api.github.com/repos/0dvictor/omr/tags","blobs_url":"https://api.github.com/repos/0dvictor/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0dvictor/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0dvictor/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/0dvictor/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0dvictor/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/0dvictor/omr/languages","stargazers_url":"https://api.github.com/repos/0dvictor/omr/stargazers","contributors_url":"https://api.github.com/repos/0dvictor/omr/contributors","subscribers_url":"https://api.github.com/repos/0dvictor/omr/subscribers","subscription_url":"https://api.github.com/repos/0dvictor/omr/subscription","commits_url":"https://api.github.com/repos/0dvictor/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/0dvictor/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/0dvictor/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/0dvictor/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/0dvictor/omr/contents/{+path}","compare_url":"https://api.github.com/repos/0dvictor/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0dvictor/omr/merges","archive_url":"https://api.github.com/repos/0dvictor/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0dvictor/omr/downloads","issues_url":"https://api.github.com/repos/0dvictor/omr/issues{/number}","pulls_url":"https://api.github.com/repos/0dvictor/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/0dvictor/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/0dvictor/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0dvictor/omr/labels{/name}","releases_url":"https://api.github.com/repos/0dvictor/omr/releases{/id}","deployments_url":"https://api.github.com/repos/0dvictor/omr/deployments","created_at":"2016-10-28T15:47:22Z","updated_at":"2018-07-13T14:50:12Z","pushed_at":"2018-07-13T21:39:34Z","git_url":"git://github.com/0dvictor/omr.git","ssh_url":"git@github.com:0dvictor/omr.git","clone_url":"https://github.com/0dvictor/omr.git","svn_url":"https://github.com/0dvictor/omr","homepage":"","size":25817,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"aa830761d1f700c26a4aff9e8902e0d7a86f6472","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA3NzQ3OA==","name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-07-13T19:27:09Z","pushed_at":"2018-07-13T21:39:35Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":25749,"stargazers_count":543,"watchers_count":543,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"archived":false,"open_issues_count":456,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":224,"open_issues":456,"watchers":543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2736"},"html":{"href":"https://github.com/eclipse/omr/pull/2736"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2736"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2736/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2736/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2736/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/bf773b350f0cbee8e6bbc7663020036c70024af1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vijaysun-omr"}}