{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/205189296","pull_request_review_id":140410714,"id":205189296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE4OTI5Ng==","diff_hunk":"@@ -18,13 +18,13 @@ def self.get(path, headers = {:accept => :json})\n       end\n \n       class RegistryResource < HttpResource\n-        if SETTINGS[:katello][:registry]\n-          cfg = SETTINGS[:katello][:registry]\n-          url = cfg[:url]\n+        if SETTINGS[:katello][:container_image_registry]\n+          cfg = SETTINGS[:katello][:container_image_registry]\n+          url = cfg[:crane_url]","path":"app/lib/katello/resources/registry.rb","position":9,"original_position":9,"commit_id":"84f678425288c0f86b72b1185f8690ba63169f4b","original_commit_id":"b3521df0ba3c66ccf47dbf7fa0b1b2e0737daf65","user":{"login":"thomasmckay","id":338096,"node_id":"MDQ6VXNlcjMzODA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/338096?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmckay","html_url":"https://github.com/thomasmckay","followers_url":"https://api.github.com/users/thomasmckay/followers","following_url":"https://api.github.com/users/thomasmckay/following{/other_user}","gists_url":"https://api.github.com/users/thomasmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmckay/subscriptions","organizations_url":"https://api.github.com/users/thomasmckay/orgs","repos_url":"https://api.github.com/users/thomasmckay/repos","events_url":"https://api.github.com/users/thomasmckay/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmckay/received_events","type":"User","site_admin":false},"body":"I thought this had all been finalized on the related PR too. https://github.com/theforeman/puppet-katello/pull/243#discussion_r199203794","created_at":"2018-07-25T17:07:42Z","updated_at":"2018-07-25T17:07:43Z","html_url":"https://github.com/Katello/katello/pull/7543#discussion_r205189296","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/7543","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/205189296"},"html":{"href":"https://github.com/Katello/katello/pull/7543#discussion_r205189296"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/7543"}},"in_reply_to_id":204047779},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/7543","id":202573583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTczNTgz","html_url":"https://github.com/Katello/katello/pull/7543","diff_url":"https://github.com/Katello/katello/pull/7543.diff","patch_url":"https://github.com/Katello/katello/pull/7543.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/7543","number":7543,"state":"open","locked":false,"title":"fixes #24305 - container image registry config","user":{"login":"thomasmckay","id":338096,"node_id":"MDQ6VXNlcjMzODA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/338096?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmckay","html_url":"https://github.com/thomasmckay","followers_url":"https://api.github.com/users/thomasmckay/followers","following_url":"https://api.github.com/users/thomasmckay/following{/other_user}","gists_url":"https://api.github.com/users/thomasmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmckay/subscriptions","organizations_url":"https://api.github.com/users/thomasmckay/orgs","repos_url":"https://api.github.com/users/thomasmckay/repos","events_url":"https://api.github.com/users/thomasmckay/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmckay/received_events","type":"User","site_admin":false},"body":"https://github.com/theforeman/puppet-katello_devel/pull/168\r\nhttps://github.com/theforeman/puppet-katello/pull/243\r\nhttps://github.com/Katello/katello/pull/7543","created_at":"2018-07-19T14:13:08Z","updated_at":"2018-07-25T17:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a45f8489ae1a074aa458cb3ffcf71c1b9091f20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":117819343,"node_id":"MDU6TGFiZWwxMTc4MTkzNDM=","url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":117819415,"node_id":"MDU6TGFiZWwxMTc4MTk0MTU=","url":"https://api.github.com/repos/Katello/katello/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/7543/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/7543/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/7543/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/84f678425288c0f86b72b1185f8690ba63169f4b","head":{"label":"thomasmckay:24305-registry-config","ref":"24305-registry-config","sha":"84f678425288c0f86b72b1185f8690ba63169f4b","user":{"login":"thomasmckay","id":338096,"node_id":"MDQ6VXNlcjMzODA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/338096?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmckay","html_url":"https://github.com/thomasmckay","followers_url":"https://api.github.com/users/thomasmckay/followers","following_url":"https://api.github.com/users/thomasmckay/following{/other_user}","gists_url":"https://api.github.com/users/thomasmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmckay/subscriptions","organizations_url":"https://api.github.com/users/thomasmckay/orgs","repos_url":"https://api.github.com/users/thomasmckay/repos","events_url":"https://api.github.com/users/thomasmckay/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmckay/received_events","type":"User","site_admin":false},"repo":{"id":4008060,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA4MDYw","name":"katello","full_name":"thomasmckay/katello","owner":{"login":"thomasmckay","id":338096,"node_id":"MDQ6VXNlcjMzODA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/338096?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmckay","html_url":"https://github.com/thomasmckay","followers_url":"https://api.github.com/users/thomasmckay/followers","following_url":"https://api.github.com/users/thomasmckay/following{/other_user}","gists_url":"https://api.github.com/users/thomasmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmckay/subscriptions","organizations_url":"https://api.github.com/users/thomasmckay/orgs","repos_url":"https://api.github.com/users/thomasmckay/repos","events_url":"https://api.github.com/users/thomasmckay/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmckay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasmckay/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/thomasmckay/katello","forks_url":"https://api.github.com/repos/thomasmckay/katello/forks","keys_url":"https://api.github.com/repos/thomasmckay/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasmckay/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasmckay/katello/teams","hooks_url":"https://api.github.com/repos/thomasmckay/katello/hooks","issue_events_url":"https://api.github.com/repos/thomasmckay/katello/issues/events{/number}","events_url":"https://api.github.com/repos/thomasmckay/katello/events","assignees_url":"https://api.github.com/repos/thomasmckay/katello/assignees{/user}","branches_url":"https://api.github.com/repos/thomasmckay/katello/branches{/branch}","tags_url":"https://api.github.com/repos/thomasmckay/katello/tags","blobs_url":"https://api.github.com/repos/thomasmckay/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasmckay/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasmckay/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasmckay/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasmckay/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasmckay/katello/languages","stargazers_url":"https://api.github.com/repos/thomasmckay/katello/stargazers","contributors_url":"https://api.github.com/repos/thomasmckay/katello/contributors","subscribers_url":"https://api.github.com/repos/thomasmckay/katello/subscribers","subscription_url":"https://api.github.com/repos/thomasmckay/katello/subscription","commits_url":"https://api.github.com/repos/thomasmckay/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasmckay/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasmckay/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasmckay/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasmckay/katello/contents/{+path}","compare_url":"https://api.github.com/repos/thomasmckay/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasmckay/katello/merges","archive_url":"https://api.github.com/repos/thomasmckay/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasmckay/katello/downloads","issues_url":"https://api.github.com/repos/thomasmckay/katello/issues{/number}","pulls_url":"https://api.github.com/repos/thomasmckay/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasmckay/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasmckay/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasmckay/katello/labels{/name}","releases_url":"https://api.github.com/repos/thomasmckay/katello/releases{/id}","deployments_url":"https://api.github.com/repos/thomasmckay/katello/deployments","created_at":"2012-04-12T18:46:03Z","updated_at":"2015-05-04T14:50:12Z","pushed_at":"2018-07-25T13:25:15Z","git_url":"git://github.com/thomasmckay/katello.git","ssh_url":"git@github.com:thomasmckay/katello.git","clone_url":"https://github.com/thomasmckay/katello.git","svn_url":"https://github.com/thomasmckay/katello","homepage":"katello.org","size":88963,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"7a234ada63cd11a27874b58b77d119f394f7f4a5","user":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA3MDE4","name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2018-07-25T16:34:25Z","pushed_at":"2018-07-25T16:34:17Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":95215,"stargazers_count":242,"watchers_count":242,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":206,"open_issues":114,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/7543"},"html":{"href":"https://github.com/Katello/katello/pull/7543"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/7543"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/7543/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/7543/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/7543/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/84f678425288c0f86b72b1185f8690ba63169f4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thomasmckay"}}