{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/219671824","pull_request_review_id":157910086,"id":219671824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY3MTgyNA==","diff_hunk":"@@ -393,6 +393,25 @@ static const char * const lookupTableVtxLowPowerDisarm[] = {\n };\n #endif\n \n+// DMA spec table. Indices are coherent with respective dmaIndentifier_e value.\n+#if defined(STM32F3)\n+static const char * const lookupTableDmaChannel[] = {\n+    \"NONE\",\n+    \"DMA1_CH1\", \"DMA1_CH2\", \"DMA1_CH3\", \"DMA1_CH4\",\n+    \"DMA1_CH5\", \"DMA1_CH6\", \"DMA1_CH7\",\n+    \"DMA2_CH1\", \"DMA2_CH2\", \"DMA2_CH3\", \"DMA2_CH4\",\n+    \"DMA2_CH5\",\n+};\n+#elif defined(STM32F4) || defined(STM32F7)\n+static const char * const lookupTableDmaStream[] = {\n+    \"NONE\",\n+    \"DMA1_ST0\", \"DMA1_ST1\", \"DMA1_ST2\", \"DMA1_ST3\",\n+    \"DMA1_ST4\", \"DMA1_ST5\", \"DMA1_ST6\", \"DMA1_ST7\",\n+    \"DMA2_ST0\", \"DMA2_ST1\", \"DMA2_ST2\", \"DMA2_ST3\",\n+    \"DMA2_ST4\", \"DMA2_ST5\", \"DMA2_ST6\", \"DMA2_ST7\",\n+};\n+#endif","path":"src/main/interface/settings.c","position":21,"original_position":21,"commit_id":"3e1d6859eaf6f824bc70d3bfccec0f72c372bfbe","original_commit_id":"3e1d6859eaf6f824bc70d3bfccec0f72c372bfbe","user":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"body":"Are you suggesting a new CLI command or a new parsing mode `MODE_DMA`?","created_at":"2018-09-22T13:33:14Z","updated_at":"2018-09-22T13:33:14Z","html_url":"https://github.com/betaflight/betaflight/pull/6803#discussion_r219671824","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6803","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/219671824"},"html":{"href":"https://github.com/betaflight/betaflight/pull/6803#discussion_r219671824"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6803"}},"in_reply_to_id":219671695},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/6803","id":216673615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjczNjE1","html_url":"https://github.com/betaflight/betaflight/pull/6803","diff_url":"https://github.com/betaflight/betaflight/pull/6803.diff","patch_url":"https://github.com/betaflight/betaflight/pull/6803.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/6803","number":6803,"state":"open","locked":false,"title":"GENERIC: DMA spec specifier in CLI, SD card as an example","user":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"body":"Generic targets call for a way to handle DMA stream and channel in CLI.\r\n\r\nThis PR provides a PoC that uses `dmaIdentifier_e` values and associated literal representation in a value table.\r\n\r\nSDCard DMA is used as an example of CLI variable handling.\r\n\r\nFor F3, DMA channel is the only variable associated with the DMA:\r\n```\r\nsdcard_dma_channel = DMA1_CH5\r\nAllowed values: NONE, DMA1_CH1, DMA1_CH2, DMA1_CH3, DMA1_CH4, DMA1_CH5, DMA1_CH6, DMA1_CH7, DMA2_CH1, DMA2_CH2, DMA2_CH3, DMA2_CH4, DMA2_CH5\r\n```\r\n\r\nFor F4 and F7, DMA stream and channel are handled separately with two variables:\r\n```\r\nsdcard_dma_stream = DMA1_ST5\r\nAllowed values: NONE, DMA1_ST0, DMA1_ST1, DMA1_ST2, DMA1_ST3, DMA1_ST4, DMA1_ST5, DMA1_ST6, DMA1_ST7, DMA2_ST0, DMA2_ST1, DMA2_ST2, DMA2_ST3, DMA2_ST4, DMA2_ST5, DMA2_ST6, DMA2_ST7\r\n\r\nsdcard_dma_channel = 0\r\nAllowed range: 0 - 7\r\n```","created_at":"2018-09-19T15:03:32Z","updated_at":"2018-09-22T13:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f85b603ba2e789f08f5493bf71ea3e3f4d4eb88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6803/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6803/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/6803/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/3e1d6859eaf6f824bc70d3bfccec0f72c372bfbe","head":{"label":"jflyper:bfdev-poc-handle-dma-spec-in-cli","ref":"bfdev-poc-handle-dma-spec-in-cli","sha":"3e1d6859eaf6f824bc70d3bfccec0f72c372bfbe","user":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"repo":{"id":128154418,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTQ0MTg=","name":"betaflight","full_name":"jflyper/betaflight","private":false,"owner":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jflyper/betaflight","description":"Open Source Flight Controller Firmware","fork":true,"url":"https://api.github.com/repos/jflyper/betaflight","forks_url":"https://api.github.com/repos/jflyper/betaflight/forks","keys_url":"https://api.github.com/repos/jflyper/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jflyper/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jflyper/betaflight/teams","hooks_url":"https://api.github.com/repos/jflyper/betaflight/hooks","issue_events_url":"https://api.github.com/repos/jflyper/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/jflyper/betaflight/events","assignees_url":"https://api.github.com/repos/jflyper/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/jflyper/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/jflyper/betaflight/tags","blobs_url":"https://api.github.com/repos/jflyper/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jflyper/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jflyper/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/jflyper/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jflyper/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/jflyper/betaflight/languages","stargazers_url":"https://api.github.com/repos/jflyper/betaflight/stargazers","contributors_url":"https://api.github.com/repos/jflyper/betaflight/contributors","subscribers_url":"https://api.github.com/repos/jflyper/betaflight/subscribers","subscription_url":"https://api.github.com/repos/jflyper/betaflight/subscription","commits_url":"https://api.github.com/repos/jflyper/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/jflyper/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/jflyper/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/jflyper/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/jflyper/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/jflyper/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jflyper/betaflight/merges","archive_url":"https://api.github.com/repos/jflyper/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jflyper/betaflight/downloads","issues_url":"https://api.github.com/repos/jflyper/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/jflyper/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/jflyper/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/jflyper/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jflyper/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/jflyper/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/jflyper/betaflight/deployments","created_at":"2018-04-05T03:27:13Z","updated_at":"2018-04-05T03:27:29Z","pushed_at":"2018-09-22T11:09:58Z","git_url":"git://github.com/jflyper/betaflight.git","ssh_url":"git@github.com:jflyper/betaflight.git","clone_url":"https://github.com/jflyper/betaflight.git","svn_url":"https://github.com/jflyper/betaflight","homepage":"","size":232293,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"e2d2fc2c64c4528b85cedbb2aea6d2ba7a95780c","user":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA2MDg1Mg==","name":"betaflight","full_name":"betaflight/betaflight","private":false,"owner":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betaflight/betaflight","description":"Open Source Flight Controller Firmware","fork":false,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2018-09-22T13:24:09Z","pushed_at":"2018-09-22T13:23:55Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":232337,"stargazers_count":2067,"watchers_count":2067,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1005,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1005,"open_issues":219,"watchers":2067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6803"},"html":{"href":"https://github.com/betaflight/betaflight/pull/6803"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/6803"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/6803/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6803/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6803/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/3e1d6859eaf6f824bc70d3bfccec0f72c372bfbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jflyper"}}