{"action":"created","comment":{"url":"https://api.github.com/repos/hpc-app/nwchem/pulls/comments/230980037","pull_request_review_id":171841251,"id":230980037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk4MDAzNw==","diff_hunk":"@@ -309,7 +309,7 @@ endif\n \n ifdef TCE_HIP\n   LIB_DEFINES += $(HIP_INCLUDE) \n-  DEFINES += -DTCE_HIP -D__HIP_PLATFORM_HCC__= -I/opt/rocm/include -I/opt/rocm/hcc/include/\n+  DEFINES += -DTCE_HIP","path":"src/util/GNUmakefile","position":6,"original_position":5,"commit_id":"38e26c749ad238e42afb5ec80df02230a3ac5f78","original_commit_id":"38e26c749ad238e42afb5ec80df02230a3ac5f78","user":{"login":"yuq","id":499597,"node_id":"MDQ6VXNlcjQ5OTU5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/499597?v=4","gravatar_id":"","url":"https://api.github.com/users/yuq","html_url":"https://github.com/yuq","followers_url":"https://api.github.com/users/yuq/followers","following_url":"https://api.github.com/users/yuq/following{/other_user}","gists_url":"https://api.github.com/users/yuq/gists{/gist_id}","starred_url":"https://api.github.com/users/yuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuq/subscriptions","organizations_url":"https://api.github.com/users/yuq/orgs","repos_url":"https://api.github.com/users/yuq/repos","events_url":"https://api.github.com/users/yuq/events{/privacy}","received_events_url":"https://api.github.com/users/yuq/received_events","type":"User","site_admin":false},"body":"@XuanBaby 请正面回答这个问题以让这次review进行下去。","created_at":"2018-11-06T02:06:09Z","updated_at":"2018-11-06T02:06:09Z","html_url":"https://github.com/hpc-app/nwchem/pull/7#discussion_r230980037","pull_request_url":"https://api.github.com/repos/hpc-app/nwchem/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/comments/230980037"},"html":{"href":"https://github.com/hpc-app/nwchem/pull/7#discussion_r230980037"},"pull_request":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/7"}},"in_reply_to_id":230622763},"pull_request":{"url":"https://api.github.com/repos/hpc-app/nwchem/pulls/7","id":227882693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODgyNjkz","html_url":"https://github.com/hpc-app/nwchem/pull/7","diff_url":"https://github.com/hpc-app/nwchem/pull/7.diff","patch_url":"https://github.com/hpc-app/nwchem/pull/7.patch","issue_url":"https://api.github.com/repos/hpc-app/nwchem/issues/7","number":7,"state":"open","locked":false,"title":"Add files via upload","user":{"login":"XuanBaby","id":29744738,"node_id":"MDQ6VXNlcjI5NzQ0NzM4","avatar_url":"https://avatars0.githubusercontent.com/u/29744738?v=4","gravatar_id":"","url":"https://api.github.com/users/XuanBaby","html_url":"https://github.com/XuanBaby","followers_url":"https://api.github.com/users/XuanBaby/followers","following_url":"https://api.github.com/users/XuanBaby/following{/other_user}","gists_url":"https://api.github.com/users/XuanBaby/gists{/gist_id}","starred_url":"https://api.github.com/users/XuanBaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuanBaby/subscriptions","organizations_url":"https://api.github.com/users/XuanBaby/orgs","repos_url":"https://api.github.com/users/XuanBaby/repos","events_url":"https://api.github.com/users/XuanBaby/events{/privacy}","received_events_url":"https://api.github.com/users/XuanBaby/received_events","type":"User","site_admin":false},"body":"合并util_cuda_support.hip.c 和 util_cuda_support.c 文件\r\n在CLFAGS设置__HIP_PLATFORM_HCC__参数","created_at":"2018-11-02T09:49:39Z","updated_at":"2018-11-06T02:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c5eed37fc8a36d5ea3ee79c53e6a0ecec7828d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpc-app/nwchem/pulls/7/commits","review_comments_url":"https://api.github.com/repos/hpc-app/nwchem/pulls/7/comments","review_comment_url":"https://api.github.com/repos/hpc-app/nwchem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpc-app/nwchem/issues/7/comments","statuses_url":"https://api.github.com/repos/hpc-app/nwchem/statuses/38e26c749ad238e42afb5ec80df02230a3ac5f78","head":{"label":"XuanBaby:hip-6.8.1","ref":"hip-6.8.1","sha":"38e26c749ad238e42afb5ec80df02230a3ac5f78","user":{"login":"XuanBaby","id":29744738,"node_id":"MDQ6VXNlcjI5NzQ0NzM4","avatar_url":"https://avatars0.githubusercontent.com/u/29744738?v=4","gravatar_id":"","url":"https://api.github.com/users/XuanBaby","html_url":"https://github.com/XuanBaby","followers_url":"https://api.github.com/users/XuanBaby/followers","following_url":"https://api.github.com/users/XuanBaby/following{/other_user}","gists_url":"https://api.github.com/users/XuanBaby/gists{/gist_id}","starred_url":"https://api.github.com/users/XuanBaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuanBaby/subscriptions","organizations_url":"https://api.github.com/users/XuanBaby/orgs","repos_url":"https://api.github.com/users/XuanBaby/repos","events_url":"https://api.github.com/users/XuanBaby/events{/privacy}","received_events_url":"https://api.github.com/users/XuanBaby/received_events","type":"User","site_admin":false},"repo":{"id":155827621,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4Mjc2MjE=","name":"nwchem","full_name":"XuanBaby/nwchem","private":false,"owner":{"login":"XuanBaby","id":29744738,"node_id":"MDQ6VXNlcjI5NzQ0NzM4","avatar_url":"https://avatars0.githubusercontent.com/u/29744738?v=4","gravatar_id":"","url":"https://api.github.com/users/XuanBaby","html_url":"https://github.com/XuanBaby","followers_url":"https://api.github.com/users/XuanBaby/followers","following_url":"https://api.github.com/users/XuanBaby/following{/other_user}","gists_url":"https://api.github.com/users/XuanBaby/gists{/gist_id}","starred_url":"https://api.github.com/users/XuanBaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuanBaby/subscriptions","organizations_url":"https://api.github.com/users/XuanBaby/orgs","repos_url":"https://api.github.com/users/XuanBaby/repos","events_url":"https://api.github.com/users/XuanBaby/events{/privacy}","received_events_url":"https://api.github.com/users/XuanBaby/received_events","type":"User","site_admin":false},"html_url":"https://github.com/XuanBaby/nwchem","description":"NWChem: Open Source High-Performance Computational Chemistry","fork":true,"url":"https://api.github.com/repos/XuanBaby/nwchem","forks_url":"https://api.github.com/repos/XuanBaby/nwchem/forks","keys_url":"https://api.github.com/repos/XuanBaby/nwchem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XuanBaby/nwchem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XuanBaby/nwchem/teams","hooks_url":"https://api.github.com/repos/XuanBaby/nwchem/hooks","issue_events_url":"https://api.github.com/repos/XuanBaby/nwchem/issues/events{/number}","events_url":"https://api.github.com/repos/XuanBaby/nwchem/events","assignees_url":"https://api.github.com/repos/XuanBaby/nwchem/assignees{/user}","branches_url":"https://api.github.com/repos/XuanBaby/nwchem/branches{/branch}","tags_url":"https://api.github.com/repos/XuanBaby/nwchem/tags","blobs_url":"https://api.github.com/repos/XuanBaby/nwchem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XuanBaby/nwchem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XuanBaby/nwchem/git/refs{/sha}","trees_url":"https://api.github.com/repos/XuanBaby/nwchem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XuanBaby/nwchem/statuses/{sha}","languages_url":"https://api.github.com/repos/XuanBaby/nwchem/languages","stargazers_url":"https://api.github.com/repos/XuanBaby/nwchem/stargazers","contributors_url":"https://api.github.com/repos/XuanBaby/nwchem/contributors","subscribers_url":"https://api.github.com/repos/XuanBaby/nwchem/subscribers","subscription_url":"https://api.github.com/repos/XuanBaby/nwchem/subscription","commits_url":"https://api.github.com/repos/XuanBaby/nwchem/commits{/sha}","git_commits_url":"https://api.github.com/repos/XuanBaby/nwchem/git/commits{/sha}","comments_url":"https://api.github.com/repos/XuanBaby/nwchem/comments{/number}","issue_comment_url":"https://api.github.com/repos/XuanBaby/nwchem/issues/comments{/number}","contents_url":"https://api.github.com/repos/XuanBaby/nwchem/contents/{+path}","compare_url":"https://api.github.com/repos/XuanBaby/nwchem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XuanBaby/nwchem/merges","archive_url":"https://api.github.com/repos/XuanBaby/nwchem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XuanBaby/nwchem/downloads","issues_url":"https://api.github.com/repos/XuanBaby/nwchem/issues{/number}","pulls_url":"https://api.github.com/repos/XuanBaby/nwchem/pulls{/number}","milestones_url":"https://api.github.com/repos/XuanBaby/nwchem/milestones{/number}","notifications_url":"https://api.github.com/repos/XuanBaby/nwchem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XuanBaby/nwchem/labels{/name}","releases_url":"https://api.github.com/repos/XuanBaby/nwchem/releases{/id}","deployments_url":"https://api.github.com/repos/XuanBaby/nwchem/deployments","created_at":"2018-11-02T07:08:04Z","updated_at":"2018-11-05T02:20:35Z","pushed_at":"2018-11-05T02:20:33Z","git_url":"git://github.com/XuanBaby/nwchem.git","ssh_url":"git@github.com:XuanBaby/nwchem.git","clone_url":"https://github.com/XuanBaby/nwchem.git","svn_url":"https://github.com/XuanBaby/nwchem","homepage":"http://www.nwchem-sw.org","size":290654,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"hip-6.8.1"}},"base":{"label":"hpc-app:hip-6.8.1","ref":"hip-6.8.1","sha":"6454456e543386acde1ac989d98cd7b104ac2ef7","user":{"login":"hpc-app","id":44566389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NTY2Mzg5","avatar_url":"https://avatars1.githubusercontent.com/u/44566389?v=4","gravatar_id":"","url":"https://api.github.com/users/hpc-app","html_url":"https://github.com/hpc-app","followers_url":"https://api.github.com/users/hpc-app/followers","following_url":"https://api.github.com/users/hpc-app/following{/other_user}","gists_url":"https://api.github.com/users/hpc-app/gists{/gist_id}","starred_url":"https://api.github.com/users/hpc-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpc-app/subscriptions","organizations_url":"https://api.github.com/users/hpc-app/orgs","repos_url":"https://api.github.com/users/hpc-app/repos","events_url":"https://api.github.com/users/hpc-app/events{/privacy}","received_events_url":"https://api.github.com/users/hpc-app/received_events","type":"Organization","site_admin":false},"repo":{"id":155317370,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzMTczNzA=","name":"nwchem","full_name":"hpc-app/nwchem","private":false,"owner":{"login":"hpc-app","id":44566389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NTY2Mzg5","avatar_url":"https://avatars1.githubusercontent.com/u/44566389?v=4","gravatar_id":"","url":"https://api.github.com/users/hpc-app","html_url":"https://github.com/hpc-app","followers_url":"https://api.github.com/users/hpc-app/followers","following_url":"https://api.github.com/users/hpc-app/following{/other_user}","gists_url":"https://api.github.com/users/hpc-app/gists{/gist_id}","starred_url":"https://api.github.com/users/hpc-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpc-app/subscriptions","organizations_url":"https://api.github.com/users/hpc-app/orgs","repos_url":"https://api.github.com/users/hpc-app/repos","events_url":"https://api.github.com/users/hpc-app/events{/privacy}","received_events_url":"https://api.github.com/users/hpc-app/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hpc-app/nwchem","description":"NWChem: Open Source High-Performance Computational Chemistry","fork":true,"url":"https://api.github.com/repos/hpc-app/nwchem","forks_url":"https://api.github.com/repos/hpc-app/nwchem/forks","keys_url":"https://api.github.com/repos/hpc-app/nwchem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpc-app/nwchem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpc-app/nwchem/teams","hooks_url":"https://api.github.com/repos/hpc-app/nwchem/hooks","issue_events_url":"https://api.github.com/repos/hpc-app/nwchem/issues/events{/number}","events_url":"https://api.github.com/repos/hpc-app/nwchem/events","assignees_url":"https://api.github.com/repos/hpc-app/nwchem/assignees{/user}","branches_url":"https://api.github.com/repos/hpc-app/nwchem/branches{/branch}","tags_url":"https://api.github.com/repos/hpc-app/nwchem/tags","blobs_url":"https://api.github.com/repos/hpc-app/nwchem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpc-app/nwchem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpc-app/nwchem/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpc-app/nwchem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpc-app/nwchem/statuses/{sha}","languages_url":"https://api.github.com/repos/hpc-app/nwchem/languages","stargazers_url":"https://api.github.com/repos/hpc-app/nwchem/stargazers","contributors_url":"https://api.github.com/repos/hpc-app/nwchem/contributors","subscribers_url":"https://api.github.com/repos/hpc-app/nwchem/subscribers","subscription_url":"https://api.github.com/repos/hpc-app/nwchem/subscription","commits_url":"https://api.github.com/repos/hpc-app/nwchem/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpc-app/nwchem/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpc-app/nwchem/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpc-app/nwchem/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpc-app/nwchem/contents/{+path}","compare_url":"https://api.github.com/repos/hpc-app/nwchem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpc-app/nwchem/merges","archive_url":"https://api.github.com/repos/hpc-app/nwchem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpc-app/nwchem/downloads","issues_url":"https://api.github.com/repos/hpc-app/nwchem/issues{/number}","pulls_url":"https://api.github.com/repos/hpc-app/nwchem/pulls{/number}","milestones_url":"https://api.github.com/repos/hpc-app/nwchem/milestones{/number}","notifications_url":"https://api.github.com/repos/hpc-app/nwchem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpc-app/nwchem/labels{/name}","releases_url":"https://api.github.com/repos/hpc-app/nwchem/releases{/id}","deployments_url":"https://api.github.com/repos/hpc-app/nwchem/deployments","created_at":"2018-10-30T03:14:36Z","updated_at":"2018-11-01T02:53:31Z","pushed_at":"2018-11-05T02:20:33Z","git_url":"git://github.com/hpc-app/nwchem.git","ssh_url":"git@github.com:hpc-app/nwchem.git","clone_url":"https://github.com/hpc-app/nwchem.git","svn_url":"https://github.com/hpc-app/nwchem","homepage":"http://www.nwchem-sw.org","size":290616,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":6,"watchers":0,"default_branch":"hip-6.8.1"}},"_links":{"self":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/7"},"html":{"href":"https://github.com/hpc-app/nwchem/pull/7"},"issue":{"href":"https://api.github.com/repos/hpc-app/nwchem/issues/7"},"comments":{"href":"https://api.github.com/repos/hpc-app/nwchem/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpc-app/nwchem/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/hpc-app/nwchem/statuses/38e26c749ad238e42afb5ec80df02230a3ac5f78"}},"author_association":"NONE"}}
{"actor":{"display_login":"yuq"}}