{"action":"created","issue":{"url":"https://api.github.com/repos/apache/samza/issues/586","repository_url":"https://api.github.com/repos/apache/samza","labels_url":"https://api.github.com/repos/apache/samza/issues/586/labels{/name}","comments_url":"https://api.github.com/repos/apache/samza/issues/586/comments","events_url":"https://api.github.com/repos/apache/samza/issues/586/events","html_url":"https://github.com/apache/samza/pull/586","id":345333677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTE0NDkx","number":586,"title":"SAMZA-1790: LocalContainerRunner should not extend AbstractApplicationRunner.","user":{"login":"prateekm","id":1085859,"node_id":"MDQ6VXNlcjEwODU4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1085859?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekm","html_url":"https://github.com/prateekm","followers_url":"https://api.github.com/users/prateekm/followers","following_url":"https://api.github.com/users/prateekm/following{/other_user}","gists_url":"https://api.github.com/users/prateekm/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekm/subscriptions","organizations_url":"https://api.github.com/users/prateekm/orgs","repos_url":"https://api.github.com/users/prateekm/repos","events_url":"https://api.github.com/users/prateekm/events{/privacy}","received_events_url":"https://api.github.com/users/prateekm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-27T19:02:03Z","updated_at":"2018-08-02T13:53:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/586","html_url":"https://github.com/apache/samza/pull/586","diff_url":"https://github.com/apache/samza/pull/586.diff","patch_url":"https://github.com/apache/samza/pull/586.patch"},"body":"LocalContainerRunner is the launcher for the process running SamzaContainer in YARN. It extends the AbstractApplicationRunner since the container was using ApplicationRunner#getStreamSpec to create StreamSpecs from config to create the High Level API DAG. It doesn't implement any of the other APIs from the ApplicationRunner.\r\n\r\nWith SAMZA-1659 and SAMZA-1745, SamzaContainer no longer needs access to StreamSpec to create and execute the High Level API DAG. We can now clean up the LocalContainerRunner implementation so that it doesn't need to implement the ApplicationRunner interface.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/samza/issues/comments/409934087","html_url":"https://github.com/apache/samza/pull/586#issuecomment-409934087","issue_url":"https://api.github.com/repos/apache/samza/issues/586","id":409934087,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTkzNDA4Nw==","user":{"login":"prateekm","id":1085859,"node_id":"MDQ6VXNlcjEwODU4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1085859?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekm","html_url":"https://github.com/prateekm","followers_url":"https://api.github.com/users/prateekm/followers","following_url":"https://api.github.com/users/prateekm/following{/other_user}","gists_url":"https://api.github.com/users/prateekm/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekm/subscriptions","organizations_url":"https://api.github.com/users/prateekm/orgs","repos_url":"https://api.github.com/users/prateekm/repos","events_url":"https://api.github.com/users/prateekm/events{/privacy}","received_events_url":"https://api.github.com/users/prateekm/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T13:53:52Z","updated_at":"2018-08-02T13:53:52Z","author_association":"CONTRIBUTOR","body":"@nickpan47 Right, this is just to undo the \"extends ApplicationRunner\" and revert to a clean state, as a simple SamzaContainer runner process. We should still move towards using StreamProcessor in YARN as well. We can use \"SAMZA-1168: Migrate yarn local runner to use StreamProcessor\" to track that."}}
{"actor":{"display_login":"prateekm"}}