{"action":"created","comment":{"url":"https://api.github.com/repos/friendica/friendica/pulls/comments/181597902","pull_request_review_id":112252115,"id":181597902,"diff_hunk":"@@ -0,0 +1,326 @@\n+<?php\r\n+/**\r\n+ * @file src/Core/System.php\r\n+ */\r\n+namespace Friendica\\Module;\r","path":"src/Module/Setup.php","position":5,"original_position":5,"commit_id":"abcc6df1008233ec6c059d7a6991e2e875e7fe22","original_commit_id":"abcc6df1008233ec6c059d7a6991e2e875e7fe22","user":{"login":"MrPetovan","id":925415,"avatar_url":"https://avatars1.githubusercontent.com/u/925415?v=4","gravatar_id":"","url":"https://api.github.com/users/MrPetovan","html_url":"https://github.com/MrPetovan","followers_url":"https://api.github.com/users/MrPetovan/followers","following_url":"https://api.github.com/users/MrPetovan/following{/other_user}","gists_url":"https://api.github.com/users/MrPetovan/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPetovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPetovan/subscriptions","organizations_url":"https://api.github.com/users/MrPetovan/orgs","repos_url":"https://api.github.com/users/MrPetovan/repos","events_url":"https://api.github.com/users/MrPetovan/events{/privacy}","received_events_url":"https://api.github.com/users/MrPetovan/received_events","type":"User","site_admin":false},"body":"Modules are special classes intended to be called as `https://friendica.example.com/module`. Look at the `BaseModule` class. If your class doesn't need to extend `BaseModule`, then it probably shouldn't be in `Friendica\\Module`. May I suggest moving it to `Friendica\\Core` instead?","created_at":"2018-04-15T21:33:34Z","updated_at":"2018-04-15T21:39:47Z","html_url":"https://github.com/friendica/friendica/pull/4844#discussion_r181597902","pull_request_url":"https://api.github.com/repos/friendica/friendica/pulls/4844","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments/181597902"},"html":{"href":"https://github.com/friendica/friendica/pull/4844#discussion_r181597902"},"pull_request":{"href":"https://api.github.com/repos/friendica/friendica/pulls/4844"}}},"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/4844","id":181710501,"html_url":"https://github.com/friendica/friendica/pull/4844","diff_url":"https://github.com/friendica/friendica/pull/4844.diff","patch_url":"https://github.com/friendica/friendica/pull/4844.patch","issue_url":"https://api.github.com/repos/friendica/friendica/issues/4844","number":4844,"state":"open","locked":false,"title":"[WIP] Automatic Configuration during installation","user":{"login":"nupplaphil","id":379654,"avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"body":"As promised, I add the capability to automatically install friendica.\r\n\r\nThis is a **Work in Progress**, but I don't want to make changes and when I'm finished, I made it the wrong way, so I want you to review my progress so far.\r\n\r\nWhat I did so far:\r\n- moved htconfig.php (and .htconfig.php) to a folder `config/`\r\n- created a `autoconfig.php` in the folder `util/`\r\n- Extracted the whole business logic of `mod/install.php` to a new Class `src/Module/Setup.php`\r\n- added a new function `autoconfig()` to `boot.php`\r\n- added `autoconfig()` in `index.php`\r\n\r\nWhat I tested and worked:\r\n- manually installation as usual (with some known, conscious errors)\r\n- automatic installation with a `config/autoconfig.php` file","created_at":"2018-04-15T17:30:13Z","updated_at":"2018-04-15T21:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendica/friendica/pulls/4844/commits","review_comments_url":"https://api.github.com/repos/friendica/friendica/pulls/4844/comments","review_comment_url":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/4844/comments","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/abcc6df1008233ec6c059d7a6991e2e875e7fe22","head":{"label":"nupplaphil:autoconfig","ref":"autoconfig","sha":"abcc6df1008233ec6c059d7a6991e2e875e7fe22","user":{"login":"nupplaphil","id":379654,"avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"repo":{"id":128665702,"name":"friendica","full_name":"nupplaphil/friendica","owner":{"login":"nupplaphil","id":379654,"avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nupplaphil/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/nupplaphil/friendica","forks_url":"https://api.github.com/repos/nupplaphil/friendica/forks","keys_url":"https://api.github.com/repos/nupplaphil/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nupplaphil/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nupplaphil/friendica/teams","hooks_url":"https://api.github.com/repos/nupplaphil/friendica/hooks","issue_events_url":"https://api.github.com/repos/nupplaphil/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/nupplaphil/friendica/events","assignees_url":"https://api.github.com/repos/nupplaphil/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/nupplaphil/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/nupplaphil/friendica/tags","blobs_url":"https://api.github.com/repos/nupplaphil/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nupplaphil/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nupplaphil/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/nupplaphil/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nupplaphil/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/nupplaphil/friendica/languages","stargazers_url":"https://api.github.com/repos/nupplaphil/friendica/stargazers","contributors_url":"https://api.github.com/repos/nupplaphil/friendica/contributors","subscribers_url":"https://api.github.com/repos/nupplaphil/friendica/subscribers","subscription_url":"https://api.github.com/repos/nupplaphil/friendica/subscription","commits_url":"https://api.github.com/repos/nupplaphil/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/nupplaphil/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/nupplaphil/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/nupplaphil/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/nupplaphil/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/nupplaphil/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nupplaphil/friendica/merges","archive_url":"https://api.github.com/repos/nupplaphil/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nupplaphil/friendica/downloads","issues_url":"https://api.github.com/repos/nupplaphil/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/nupplaphil/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/nupplaphil/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/nupplaphil/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nupplaphil/friendica/labels{/name}","releases_url":"https://api.github.com/repos/nupplaphil/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/nupplaphil/friendica/deployments","created_at":"2018-04-08T17:33:43Z","updated_at":"2018-04-08T17:33:49Z","pushed_at":"2018-04-15T20:53:51Z","git_url":"git://github.com/nupplaphil/friendica.git","ssh_url":"git@github.com:nupplaphil/friendica.git","clone_url":"https://github.com/nupplaphil/friendica.git","svn_url":"https://github.com/nupplaphil/friendica","homepage":"https://friendi.ca","size":90975,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"friendica:develop","ref":"develop","sha":"c7e6d229ec74e4749685a3b476292938433e7fe1","user":{"login":"friendica","id":1176581,"avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"repo":{"id":2722709,"name":"friendica","full_name":"friendica/friendica","owner":{"login":"friendica","id":1176581,"avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friendica/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/friendica/friendica","forks_url":"https://api.github.com/repos/friendica/friendica/forks","keys_url":"https://api.github.com/repos/friendica/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendica/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendica/friendica/teams","hooks_url":"https://api.github.com/repos/friendica/friendica/hooks","issue_events_url":"https://api.github.com/repos/friendica/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/friendica/friendica/events","assignees_url":"https://api.github.com/repos/friendica/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/friendica/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/friendica/friendica/tags","blobs_url":"https://api.github.com/repos/friendica/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendica/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendica/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendica/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/friendica/friendica/languages","stargazers_url":"https://api.github.com/repos/friendica/friendica/stargazers","contributors_url":"https://api.github.com/repos/friendica/friendica/contributors","subscribers_url":"https://api.github.com/repos/friendica/friendica/subscribers","subscription_url":"https://api.github.com/repos/friendica/friendica/subscription","commits_url":"https://api.github.com/repos/friendica/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendica/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendica/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendica/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendica/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/friendica/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendica/friendica/merges","archive_url":"https://api.github.com/repos/friendica/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendica/friendica/downloads","issues_url":"https://api.github.com/repos/friendica/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/friendica/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/friendica/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/friendica/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendica/friendica/labels{/name}","releases_url":"https://api.github.com/repos/friendica/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/friendica/friendica/deployments","created_at":"2011-11-06T22:19:41Z","updated_at":"2018-04-15T20:35:34Z","pushed_at":"2018-04-15T20:53:52Z","git_url":"git://github.com/friendica/friendica.git","ssh_url":"git@github.com:friendica/friendica.git","clone_url":"https://github.com/friendica/friendica.git","svn_url":"https://github.com/friendica/friendica","homepage":"https://friendi.ca","size":91395,"stargazers_count":580,"watchers_count":580,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":361,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":198,"open_issues":361,"watchers":580,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/4844"},"html":{"href":"https://github.com/friendica/friendica/pull/4844"},"issue":{"href":"https://api.github.com/repos/friendica/friendica/issues/4844"},"comments":{"href":"https://api.github.com/repos/friendica/friendica/issues/4844/comments"},"review_comments":{"href":"https://api.github.com/repos/friendica/friendica/pulls/4844/comments"},"review_comment":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendica/friendica/pulls/4844/commits"},"statuses":{"href":"https://api.github.com/repos/friendica/friendica/statuses/abcc6df1008233ec6c059d7a6991e2e875e7fe22"}},"author_association":"NONE"}}
{"actor":{"display_login":"MrPetovan"}}