{"action":"created","issue":{"url":"https://api.github.com/repos/swoole/swoole-src/issues/2092","repository_url":"https://api.github.com/repos/swoole/swoole-src","labels_url":"https://api.github.com/repos/swoole/swoole-src/issues/2092/labels{/name}","comments_url":"https://api.github.com/repos/swoole/swoole-src/issues/2092/comments","events_url":"https://api.github.com/repos/swoole/swoole-src/issues/2092/events","html_url":"https://github.com/swoole/swoole-src/issues/2092","id":377776757,"node_id":"MDU6SXNzdWUzNzc3NzY3NTc=","number":2092,"title":"Not sure about hiredis dep in 4.2.6","user":{"login":"flddr","id":42785945,"node_id":"MDQ6VXNlcjQyNzg1OTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/42785945?v=4","gravatar_id":"","url":"https://api.github.com/users/flddr","html_url":"https://github.com/flddr","followers_url":"https://api.github.com/users/flddr/followers","following_url":"https://api.github.com/users/flddr/following{/other_user}","gists_url":"https://api.github.com/users/flddr/gists{/gist_id}","starred_url":"https://api.github.com/users/flddr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flddr/subscriptions","organizations_url":"https://api.github.com/users/flddr/orgs","repos_url":"https://api.github.com/users/flddr/repos","events_url":"https://api.github.com/users/flddr/events{/privacy}","received_events_url":"https://api.github.com/users/flddr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-06T10:13:36Z","updated_at":"2018-11-06T10:36:59Z","closed_at":null,"author_association":"NONE","body":"Thanks for your great work every day :blush: \r\n\r\nI build all my setups due to a setup-script for all purposes.\r\n\r\nNow, there comes a change about dependencies - started with _hiredis_.\r\n\r\n> Built-in hiredis dependency, no longer needed to compile it separately, refactor Co\\Redis, more stable\r\n\r\nWill this happen with _mysqlnd_ and _libpq_, too? With _nghttp2_, _openssl_, and so on?\r\n\r\n_Why_ is this now handled by swoole? When will others follow?"},"comment":{"url":"https://api.github.com/repos/swoole/swoole-src/issues/comments/436207535","html_url":"https://github.com/swoole/swoole-src/issues/2092#issuecomment-436207535","issue_url":"https://api.github.com/repos/swoole/swoole-src/issues/2092","id":436207535,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjIwNzUzNQ==","user":{"login":"twose","id":25978241,"node_id":"MDQ6VXNlcjI1OTc4MjQx","avatar_url":"https://avatars0.githubusercontent.com/u/25978241?v=4","gravatar_id":"","url":"https://api.github.com/users/twose","html_url":"https://github.com/twose","followers_url":"https://api.github.com/users/twose/followers","following_url":"https://api.github.com/users/twose/following{/other_user}","gists_url":"https://api.github.com/users/twose/gists{/gist_id}","starred_url":"https://api.github.com/users/twose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twose/subscriptions","organizations_url":"https://api.github.com/users/twose/orgs","repos_url":"https://api.github.com/users/twose/repos","events_url":"https://api.github.com/users/twose/events{/privacy}","received_events_url":"https://api.github.com/users/twose/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T10:36:59Z","updated_at":"2018-11-06T10:36:59Z","author_association":"MEMBER","body":"Good issue, It’s what everyone cares about.\r\n\r\nThe reason to include hiredis\r\n---\r\n  The developers who use the redis class in swoole are so much. The installation of hiredis troubled too many newbies. But this is not the most important reason.\r\n  We used the asynchronous callback method to implement the coroutine in C. The timing problem of asynchronous callback caused the lack of stability to plague us for a long time. Now we have the full coroutine (the C and the PHP layer are both coroutine modes), we directly hooked the source code of hiredis, realizing a high stability version.\r\n\r\nWill other dependencies be integrated?\r\n---\r\nThe dependencies of other libraries are not as complicated as redis, and there are not many developers who need nghttp2, postgre, etc. Those who really need to use them must have the ability to compile them. mysqlnd only provides a mysql_escape method, and openssl Is a very basic library. We can't integrate everything, no project will do this, but we will try to remove the dependency, nghttp2 dependency removal is possible, we only use its header compression function, In the future, we will take the time to complete it.\r\n\r\nBetter Swoole development experience\r\n---\r\nThat is what we are after. In the future, we may release a Swoole Boot, a simple Swoole installation tool.\r\n\r\n---\r\n\r\n集成hiredis是有原因的\r\n---\r\n  在swoole中使用redis类的开发者实在是太多了, hiredis的安装困扰着一大堆新手, 当然这不是首要原因.\r\n  我们之前底层使用的是异步回调的方式来构造协程, 其中存在异步回调的时序问题导致稳定性不足一直困扰着我们, 现在我们有了全协程(即C底层和PHP层都是协程模式), 直接hook了hiredis的源码, 实现了真正的高稳定\r\n\r\n其它依赖会被集成吗?\r\n---\r\n  其它类库的依赖不像redis这么复杂, 并且需要nghttp2, postgre等库的开发者并不多, 真正需要使用它们的人必然具备了编译它们的能力, mysqlnd只提供了一个mysql_escape方法而已, 而openssl是一个很基本的库. 我们不可能集成所有的东西, 没有哪个项目会这么做, 但我们会尽量移除依赖, nghttp2的依赖移除是有可能的, 我们只用到了它的首部压缩功能, 未来我们会抽时间完成\r\n\r\n更好的Swoole开发体验\r\n---\r\n  这是我们所追求的, 未来我们可能会创造一个Swoole Boot, 一个傻瓜式的Swoole安装工具"}}
{"actor":{"display_login":"twose"}}