{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/215599309","pull_request_review_id":152896592,"id":215599309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU5OTMwOQ==","diff_hunk":"@@ -1204,6 +1206,68 @@ static bool maybeConsumeNewlineEscape(const char *&CurPtr, ssize_t Offset) {\n   }\n }\n \n+/// diagnoseZeroWidthMatchAndAdvance - Error zerowidth characters in delimiters.\n+/// A non visible character in the middle of a delimter can be used to extend\n+/// the literal beyond what it would appear creating potential security bugs.\n+static bool diagnoseZeroWidthMatchAndAdvance(char Target, const char *&CurPtr,\n+                                             DiagnosticEngine *Diags) {\n+  // Detect, diagnose and skip over zero-width characters here if required.","path":"lib/Parse/Lexer.cpp","position":29,"original_position":29,"commit_id":"f0f08e1e86d0c24921fe8ca71901a5ef6bd39811","original_commit_id":"f0f08e1e86d0c24921fe8ca71901a5ef6bd39811","user":{"login":"xwu","id":13952,"node_id":"MDQ6VXNlcjEzOTUy","avatar_url":"https://avatars2.githubusercontent.com/u/13952?v=4","gravatar_id":"","url":"https://api.github.com/users/xwu","html_url":"https://github.com/xwu","followers_url":"https://api.github.com/users/xwu/followers","following_url":"https://api.github.com/users/xwu/following{/other_user}","gists_url":"https://api.github.com/users/xwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu/subscriptions","organizations_url":"https://api.github.com/users/xwu/orgs","repos_url":"https://api.github.com/users/xwu/repos","events_url":"https://api.github.com/users/xwu/events{/privacy}","received_events_url":"https://api.github.com/users/xwu/received_events","type":"User","site_admin":false},"body":"Marking this as “TODO:” might be a good idea.","created_at":"2018-09-06T12:03:23Z","updated_at":"2018-09-06T12:11:38Z","html_url":"https://github.com/apple/swift/pull/17668#discussion_r215599309","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/17668","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/215599309"},"html":{"href":"https://github.com/apple/swift/pull/17668#discussion_r215599309"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/17668"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17668","id":198658998,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjU4OTk4","html_url":"https://github.com/apple/swift/pull/17668","diff_url":"https://github.com/apple/swift/pull/17668.diff","patch_url":"https://github.com/apple/swift/pull/17668.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/17668","number":17668,"state":"open","locked":false,"title":"[Parse] Implementation for SE-200 (raw strings)","user":{"login":"johnno1962","id":1786033,"node_id":"MDQ6VXNlcjE3ODYwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1786033?v=4","gravatar_id":"","url":"https://api.github.com/users/johnno1962","html_url":"https://github.com/johnno1962","followers_url":"https://api.github.com/users/johnno1962/followers","following_url":"https://api.github.com/users/johnno1962/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962/subscriptions","organizations_url":"https://api.github.com/users/johnno1962/orgs","repos_url":"https://api.github.com/users/johnno1962/repos","events_url":"https://api.github.com/users/johnno1962/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962/received_events","type":"User","site_admin":false},"body":"As per discussion in second pitch of raw strings on swift-evolution https://forums.swift.org/t/pure-bikeshedding-raw-strings-why-yes-again/13866. Work in progress, submitting now to get PR link.\r\n\r\nResolves [SR-6362](https://bugs.swift.org/browse/SR-6362) and also lays groundwork for [SR-8678](https://bugs.swift.org/browse/SR-8678)","created_at":"2018-07-02T12:07:33Z","updated_at":"2018-09-06T12:11:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f29729efead324cbdafaa9a95218a43309c9273","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/17668/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/17668/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/17668/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/f0f08e1e86d0c24921fe8ca71901a5ef6bd39811","head":{"label":"johnno1962a:master","ref":"master","sha":"f0f08e1e86d0c24921fe8ca71901a5ef6bd39811","user":{"login":"johnno1962a","id":17772788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzcyNzg4","avatar_url":"https://avatars3.githubusercontent.com/u/17772788?v=4","gravatar_id":"","url":"https://api.github.com/users/johnno1962a","html_url":"https://github.com/johnno1962a","followers_url":"https://api.github.com/users/johnno1962a/followers","following_url":"https://api.github.com/users/johnno1962a/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962a/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962a/subscriptions","organizations_url":"https://api.github.com/users/johnno1962a/orgs","repos_url":"https://api.github.com/users/johnno1962a/repos","events_url":"https://api.github.com/users/johnno1962a/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962a/received_events","type":"Organization","site_admin":false},"repo":{"id":138918655,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5MTg2NTU=","name":"swift","full_name":"johnno1962a/swift","owner":{"login":"johnno1962a","id":17772788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzcyNzg4","avatar_url":"https://avatars3.githubusercontent.com/u/17772788?v=4","gravatar_id":"","url":"https://api.github.com/users/johnno1962a","html_url":"https://github.com/johnno1962a","followers_url":"https://api.github.com/users/johnno1962a/followers","following_url":"https://api.github.com/users/johnno1962a/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962a/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962a/subscriptions","organizations_url":"https://api.github.com/users/johnno1962a/orgs","repos_url":"https://api.github.com/users/johnno1962a/repos","events_url":"https://api.github.com/users/johnno1962a/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962a/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/johnno1962a/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/johnno1962a/swift","forks_url":"https://api.github.com/repos/johnno1962a/swift/forks","keys_url":"https://api.github.com/repos/johnno1962a/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnno1962a/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnno1962a/swift/teams","hooks_url":"https://api.github.com/repos/johnno1962a/swift/hooks","issue_events_url":"https://api.github.com/repos/johnno1962a/swift/issues/events{/number}","events_url":"https://api.github.com/repos/johnno1962a/swift/events","assignees_url":"https://api.github.com/repos/johnno1962a/swift/assignees{/user}","branches_url":"https://api.github.com/repos/johnno1962a/swift/branches{/branch}","tags_url":"https://api.github.com/repos/johnno1962a/swift/tags","blobs_url":"https://api.github.com/repos/johnno1962a/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnno1962a/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnno1962a/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnno1962a/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnno1962a/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/johnno1962a/swift/languages","stargazers_url":"https://api.github.com/repos/johnno1962a/swift/stargazers","contributors_url":"https://api.github.com/repos/johnno1962a/swift/contributors","subscribers_url":"https://api.github.com/repos/johnno1962a/swift/subscribers","subscription_url":"https://api.github.com/repos/johnno1962a/swift/subscription","commits_url":"https://api.github.com/repos/johnno1962a/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnno1962a/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnno1962a/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnno1962a/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnno1962a/swift/contents/{+path}","compare_url":"https://api.github.com/repos/johnno1962a/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnno1962a/swift/merges","archive_url":"https://api.github.com/repos/johnno1962a/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnno1962a/swift/downloads","issues_url":"https://api.github.com/repos/johnno1962a/swift/issues{/number}","pulls_url":"https://api.github.com/repos/johnno1962a/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/johnno1962a/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/johnno1962a/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnno1962a/swift/labels{/name}","releases_url":"https://api.github.com/repos/johnno1962a/swift/releases{/id}","deployments_url":"https://api.github.com/repos/johnno1962a/swift/deployments","created_at":"2018-06-27T18:26:58Z","updated_at":"2018-09-05T20:51:46Z","pushed_at":"2018-09-05T20:51:32Z","git_url":"git://github.com/johnno1962a/swift.git","ssh_url":"git@github.com:johnno1962a/swift.git","clone_url":"https://github.com/johnno1962a/swift.git","svn_url":"https://github.com/johnno1962a/swift","homepage":"https://swift.org/","size":306172,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d6184b013dafef008454e46623fb85e4f4f17104","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-06T11:28:59Z","pushed_at":"2018-09-06T12:11:04Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":337043,"stargazers_count":45102,"watchers_count":45102,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7112,"mirror_url":null,"archived":false,"open_issues_count":378,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7112,"open_issues":378,"watchers":45102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/17668"},"html":{"href":"https://github.com/apple/swift/pull/17668"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/17668"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/17668/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/17668/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/17668/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/f0f08e1e86d0c24921fe8ca71901a5ef6bd39811"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xwu"}}