{"action":"created","issue":{"url":"https://api.github.com/repos/cylc/cylc/issues/2614","repository_url":"https://api.github.com/repos/cylc/cylc","labels_url":"https://api.github.com/repos/cylc/cylc/issues/2614/labels{/name}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/2614/comments","events_url":"https://api.github.com/repos/cylc/cylc/issues/2614/events","html_url":"https://github.com/cylc/cylc/pull/2614","id":309421176,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4MDc5OTQx","number":2614,"title":"Rose Bush utility migration to cylc: incoming","user":{"login":"sadielbartholomew","id":30274190,"node_id":"MDQ6VXNlcjMwMjc0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/30274190?v=4","gravatar_id":"","url":"https://api.github.com/users/sadielbartholomew","html_url":"https://github.com/sadielbartholomew","followers_url":"https://api.github.com/users/sadielbartholomew/followers","following_url":"https://api.github.com/users/sadielbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/sadielbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/sadielbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadielbartholomew/subscriptions","organizations_url":"https://api.github.com/users/sadielbartholomew/orgs","repos_url":"https://api.github.com/users/sadielbartholomew/repos","events_url":"https://api.github.com/users/sadielbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/sadielbartholomew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sadielbartholomew","id":30274190,"node_id":"MDQ6VXNlcjMwMjc0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/30274190?v=4","gravatar_id":"","url":"https://api.github.com/users/sadielbartholomew","html_url":"https://github.com/sadielbartholomew","followers_url":"https://api.github.com/users/sadielbartholomew/followers","following_url":"https://api.github.com/users/sadielbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/sadielbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/sadielbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadielbartholomew/subscriptions","organizations_url":"https://api.github.com/users/sadielbartholomew/orgs","repos_url":"https://api.github.com/users/sadielbartholomew/repos","events_url":"https://api.github.com/users/sadielbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/sadielbartholomew/received_events","type":"User","site_admin":false},"assignees":[{"login":"sadielbartholomew","id":30274190,"node_id":"MDQ6VXNlcjMwMjc0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/30274190?v=4","gravatar_id":"","url":"https://api.github.com/users/sadielbartholomew","html_url":"https://github.com/sadielbartholomew","followers_url":"https://api.github.com/users/sadielbartholomew/followers","following_url":"https://api.github.com/users/sadielbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/sadielbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/sadielbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadielbartholomew/subscriptions","organizations_url":"https://api.github.com/users/sadielbartholomew/orgs","repos_url":"https://api.github.com/users/sadielbartholomew/repos","events_url":"https://api.github.com/users/sadielbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/sadielbartholomew/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/5","html_url":"https://github.com/cylc/cylc/milestone/5","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/5/labels","id":262614,"node_id":"MDk6TWlsZXN0b25lMjYyNjE0","number":5,"title":"soon","description":"A few months in the future. Top priority issues and easy fixes should initially be marked against this milestone, and then moved to *next-release* if work progresses quickly enough.","creator":{"login":"hjoliver","id":2362137,"node_id":"MDQ6VXNlcjIzNjIxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2362137?v=4","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":2,"state":"open","created_at":"2013-02-08T07:07:13Z","updated_at":"2018-07-02T20:41:34Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":15,"created_at":"2018-03-28T15:37:22Z","updated_at":"2018-07-04T20:11:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/2614","html_url":"https://github.com/cylc/cylc/pull/2614","diff_url":"https://github.com/cylc/cylc/pull/2614.diff","patch_url":"https://github.com/cylc/cylc/pull/2614.patch"},"body":"Migration of the 'Rose Bush' HTTP-based service. Closes #1052.\r\n\r\nThis PR consists of purely the migration to a functional Cylc facility & related 'tidying up' i.e. removing code needed for Rose as a distinct system to retrieve required Cylc data. Follow-up work such as updating the docs & upgrading bootstrap will be completed separately.\r\n\r\n### Note:\r\n\r\n1. Other than **three core files**, one under `bin/` & two under `lib/`, & **test files** under `tests/`, new files are all **web-based (HTML, CSS & Javascript) files**, under a new directory ``lib/cylc/cylc-nameless/`` with identical structure to that currently in ``rose/lib/html/`` (with files relating to ``rosie disco`` removed & only small modifications made otherwise). These are mostly external. Note that ``jquery.dataTables.js`` constitutes ~3/4 of the ~20,000 line additions for the PR.\r\n2. Commits ``682b311``, ``edd18fc`` & ``b15b25b`` contain unedited copies of Rose files, to allow relative changes to be seen for aid of review.\r\n\r\n### Checklist:\r\n\r\n- [x] **Agree on name** *--> ``cylc review`` agreed in UM workshop week discussions!*\r\n- [x] **Apply agreed name**.\r\n- [x] Decide on **favicon**: initially used a ``.png`` scaled crop of the cylc logo in ``doc/src``, but maybe want something else &/or ``.ico`` format? *--> Addressed in PR sadielbartholomew/cylc#1*\r\n- [x] Decide how to process **Rose log & config files** (where found): currently the code recognises standard Rose file names & displays such files in a 'rose files' drop-down menu.\r\n- [x] Determine best **locations** (for web-based files relative to `lib/` directory & for `CylcNamelessDAO` class).\r\n- [x] **GPL/copyright**: check (MO & NIWA) legal advice RE code 'donation' Rose -> Cylc *--> a longer-term, general discussion that may apply to entire code base => apply in later PR(s).*\r\n- [x] **Fix tests**.\r\n- [x] **Resolve conflicts**\r\n- [x] **Port security PR** (metomi/rose#2167).\r\n- [x] Amend existing text problem (see comment).\r\n\r\n**Open for review**."},"comment":{"url":"https://api.github.com/repos/cylc/cylc/issues/comments/402552515","html_url":"https://github.com/cylc/cylc/pull/2614#issuecomment-402552515","issue_url":"https://api.github.com/repos/cylc/cylc/issues/2614","id":402552515,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjU1MjUxNQ==","user":{"login":"sadielbartholomew","id":30274190,"node_id":"MDQ6VXNlcjMwMjc0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/30274190?v=4","gravatar_id":"","url":"https://api.github.com/users/sadielbartholomew","html_url":"https://github.com/sadielbartholomew","followers_url":"https://api.github.com/users/sadielbartholomew/followers","following_url":"https://api.github.com/users/sadielbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/sadielbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/sadielbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadielbartholomew/subscriptions","organizations_url":"https://api.github.com/users/sadielbartholomew/orgs","repos_url":"https://api.github.com/users/sadielbartholomew/repos","events_url":"https://api.github.com/users/sadielbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/sadielbartholomew/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T20:11:11Z","updated_at":"2018-07-04T20:11:11Z","author_association":"MEMBER","body":":balloon: :confetti_ball: :beers: Put up the bunting @hjoliver @matthewrmshin @oliver-sanders because this is finally **ready for review** :exclamation: See my comment from 8th June RE the Codacy failure; Travis CI & my local test battery pass & no issues now materialise with manual probing of the service on an ad-hoc server.\r\n\r\nI'll very kindly leave one of you to make some obligatory 'reviewing review' joke.\r\n\r\nI am on leave from 9th-16th, otherwise I can respond to feedback fairly promptly."}}
{"actor":{"display_login":"sadielbartholomew"}}