{"action":"created","issue":{"url":"https://api.github.com/repos/joerick/cibuildwheel/issues/99","repository_url":"https://api.github.com/repos/joerick/cibuildwheel","labels_url":"https://api.github.com/repos/joerick/cibuildwheel/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/joerick/cibuildwheel/issues/99/comments","events_url":"https://api.github.com/repos/joerick/cibuildwheel/issues/99/events","html_url":"https://github.com/joerick/cibuildwheel/issues/99","id":359362996,"node_id":"MDU6SXNzdWUzNTkzNjI5OTY=","number":99,"title":"Refactoring the Linux build script","user":{"login":"joerick","id":1244307,"node_id":"MDQ6VXNlcjEyNDQzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1244307?v=4","gravatar_id":"","url":"https://api.github.com/users/joerick","html_url":"https://github.com/joerick","followers_url":"https://api.github.com/users/joerick/followers","following_url":"https://api.github.com/users/joerick/following{/other_user}","gists_url":"https://api.github.com/users/joerick/gists{/gist_id}","starred_url":"https://api.github.com/users/joerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerick/subscriptions","organizations_url":"https://api.github.com/users/joerick/orgs","repos_url":"https://api.github.com/users/joerick/repos","events_url":"https://api.github.com/users/joerick/events{/privacy}","received_events_url":"https://api.github.com/users/joerick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-12T08:10:51Z","updated_at":"2018-09-12T11:45:03Z","closed_at":null,"author_association":"OWNER","body":"Currently the linux build works by piping a bash script into /bin/bash inside the docker container.\r\n\r\nA couple good ideas have come out of the discussion in #97, so I wanted to keep them in an open issue!\r\n\r\n1. @altendky: maybe a good way would be a Python script with a CLI (probably small enough to comfortably do with stdlib and 2/3 compatibility) and we pass in the info via the command. No config file to write and copy, no template to fill out. Just copy the exact Python script over to the container and then docker run it with proper arguments.\r\n\r\n2. @altendky: Or, maybe we just replace the string/file with python code calling docker run for each command?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joerick/cibuildwheel/issues/comments/420618359","html_url":"https://github.com/joerick/cibuildwheel/issues/99#issuecomment-420618359","issue_url":"https://api.github.com/repos/joerick/cibuildwheel/issues/99","id":420618359,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDYxODM1OQ==","user":{"login":"altendky","id":543719,"node_id":"MDQ6VXNlcjU0MzcxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/543719?v=4","gravatar_id":"","url":"https://api.github.com/users/altendky","html_url":"https://github.com/altendky","followers_url":"https://api.github.com/users/altendky/followers","following_url":"https://api.github.com/users/altendky/following{/other_user}","gists_url":"https://api.github.com/users/altendky/gists{/gist_id}","starred_url":"https://api.github.com/users/altendky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/altendky/subscriptions","organizations_url":"https://api.github.com/users/altendky/orgs","repos_url":"https://api.github.com/users/altendky/repos","events_url":"https://api.github.com/users/altendky/events{/privacy}","received_events_url":"https://api.github.com/users/altendky/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T11:45:03Z","updated_at":"2018-09-12T11:45:03Z","author_association":"CONTRIBUTOR","body":"You could use `check_output()` as the general rule instead and could then read out variables and directory listings.  Just make sure of things like having `ls` output a file per line rather than splitting on spaces (hmm, can a file have a newline?).\r\n\r\nhttps://docs.docker.com/engine/reference/run/#env-environment-variables\r\n\r\nFor setting env var you can (1) `['-e', 'deep=purple', 'do', 'something']` or (2) have the function take an additional dict for extra env vars or (3) `**kwargs` for env vars.  I think (2) uses Python syntax and is explicit and flexible so I'd tend towards that."}}
{"actor":{"display_login":"altendky"}}