{"action":"created","issue":{"url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/25","repository_url":"https://api.github.com/repos/CodeSignal/dockerfiles","labels_url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/25/comments","events_url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/25/events","html_url":"https://github.com/CodeSignal/dockerfiles/pull/25","id":374491776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTgyODA1","number":25,"title":"Typescript ","user":{"login":"ksaxberg","id":15057490,"node_id":"MDQ6VXNlcjE1MDU3NDkw","avatar_url":"https://avatars0.githubusercontent.com/u/15057490?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaxberg","html_url":"https://github.com/ksaxberg","followers_url":"https://api.github.com/users/ksaxberg/followers","following_url":"https://api.github.com/users/ksaxberg/following{/other_user}","gists_url":"https://api.github.com/users/ksaxberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaxberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaxberg/subscriptions","organizations_url":"https://api.github.com/users/ksaxberg/orgs","repos_url":"https://api.github.com/users/ksaxberg/repos","events_url":"https://api.github.com/users/ksaxberg/events{/privacy}","received_events_url":"https://api.github.com/users/ksaxberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"menewman","id":747378,"node_id":"MDQ6VXNlcjc0NzM3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/747378?v=4","gravatar_id":"","url":"https://api.github.com/users/menewman","html_url":"https://github.com/menewman","followers_url":"https://api.github.com/users/menewman/followers","following_url":"https://api.github.com/users/menewman/following{/other_user}","gists_url":"https://api.github.com/users/menewman/gists{/gist_id}","starred_url":"https://api.github.com/users/menewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menewman/subscriptions","organizations_url":"https://api.github.com/users/menewman/orgs","repos_url":"https://api.github.com/users/menewman/repos","events_url":"https://api.github.com/users/menewman/events{/privacy}","received_events_url":"https://api.github.com/users/menewman/received_events","type":"User","site_admin":false},"assignees":[{"login":"menewman","id":747378,"node_id":"MDQ6VXNlcjc0NzM3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/747378?v=4","gravatar_id":"","url":"https://api.github.com/users/menewman","html_url":"https://github.com/menewman","followers_url":"https://api.github.com/users/menewman/followers","following_url":"https://api.github.com/users/menewman/following{/other_user}","gists_url":"https://api.github.com/users/menewman/gists{/gist_id}","starred_url":"https://api.github.com/users/menewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menewman/subscriptions","organizations_url":"https://api.github.com/users/menewman/orgs","repos_url":"https://api.github.com/users/menewman/repos","events_url":"https://api.github.com/users/menewman/events{/privacy}","received_events_url":"https://api.github.com/users/menewman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-26T18:11:32Z","updated_at":"2018-10-30T21:29:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CodeSignal/dockerfiles/pulls/25","html_url":"https://github.com/CodeSignal/dockerfiles/pull/25","diff_url":"https://github.com/CodeSignal/dockerfiles/pull/25.diff","patch_url":"https://github.com/CodeSignal/dockerfiles/pull/25.patch"},"body":"Moves out the typescript language into a new docker container. \r\n\r\nIncluded an additional test for the \"add\" request, which includes all of our request language template from the main app. That can be found over [here](https://github.com/CodeSignal/coderunner/pull/142).\r\n\r\n## To Test:\r\n- On a coderunner VM, checkout the `dockerfiles` repo at this branch\r\n- `cd` in to the directory containing the new container, which in this case should be `/path/to/repo/typescript\r\n- Build the container locally, `docker build -t codesignal/typescript:v1.1 .` (The trailing dot tells docker to look for `Dockerfile` in the current directory.\r\n(Sometimes `docker` has trouble with connecting to the internet, this can be resolve by restarting the service with `service docker restart`. I have to do this quite frequently, it's a curious thing)\r\n- Go over to the `coderunner` repo and set the `vm` for the language. This is done by editing the language (in this case `ts`) field in `API/src/compilers.js` to target the VM (`codesignal/typescript:v1.1`).\r\n- If you're testing things from `rundash` on your local coderunner, you should be able to target `raw/ts` to test typescript, and there should be two tests (if you've checked out the coderunner above, which includes a second test for Typescript). Both tests should pass!\r\n- In looking at the `console.log` output of the coderunner server, you should see the docker command for the run request target the new VM, so somewhere in that output you should find `codesignal/typescript:v1.1`"},"comment":{"url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/comments/434476999","html_url":"https://github.com/CodeSignal/dockerfiles/pull/25#issuecomment-434476999","issue_url":"https://api.github.com/repos/CodeSignal/dockerfiles/issues/25","id":434476999,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQ3Njk5OQ==","user":{"login":"ksaxberg","id":15057490,"node_id":"MDQ6VXNlcjE1MDU3NDkw","avatar_url":"https://avatars0.githubusercontent.com/u/15057490?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaxberg","html_url":"https://github.com/ksaxberg","followers_url":"https://api.github.com/users/ksaxberg/followers","following_url":"https://api.github.com/users/ksaxberg/following{/other_user}","gists_url":"https://api.github.com/users/ksaxberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaxberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaxberg/subscriptions","organizations_url":"https://api.github.com/users/ksaxberg/orgs","repos_url":"https://api.github.com/users/ksaxberg/repos","events_url":"https://api.github.com/users/ksaxberg/events{/privacy}","received_events_url":"https://api.github.com/users/ksaxberg/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T21:29:47Z","updated_at":"2018-10-30T21:29:47Z","author_association":"CONTRIBUTOR","body":"@menewman Hmm... `/test/raw/ts` should be returning. Docker timeouts can happen for a variety of reasons (depending on resource usage locally). I can give you a couple options to try:\r\n\r\n1. Just restart docker in the vm with `service docker restart`\r\n2. Restart the coderunner server and restart docker, `vm sc` should toggle the coderunner server from your main app (if you're using the `vm` script), and you could then run step 1\r\n3. Restart the VM and run step 2.\r\n\r\nIf it's truly an out of memory resource issue, you could run `docker rmi codesignal/ubuntu-common:v1.1` or `docker rmi codesignal/ubuntu-common:v1.0`, one of those should delete the large image. You can inspect all locally installed containers with `docker images`, and it should show you images and their relative sizes. The `ubuntu-common` one is going to be a full 8GB or so and freeing that up might prevent docker timeouts."}}
{"actor":{"display_login":"ksaxberg"}}