{"action":"opened","issue":{"url":"https://api.github.com/repos/heptio/gimbal/issues/230","repository_url":"https://api.github.com/repos/heptio/gimbal","labels_url":"https://api.github.com/repos/heptio/gimbal/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/heptio/gimbal/issues/230/comments","events_url":"https://api.github.com/repos/heptio/gimbal/issues/230/events","html_url":"https://github.com/heptio/gimbal/issues/230","id":364198484,"node_id":"MDU6SXNzdWUzNjQxOTg0ODQ=","number":230,"title":"Openstack reconciling is enqueuing pointer of range var, instead of pointer of svcs/endpoints","user":{"login":"alexbrand","id":545723,"node_id":"MDQ6VXNlcjU0NTcyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/545723?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrand","html_url":"https://github.com/alexbrand","followers_url":"https://api.github.com/users/alexbrand/followers","following_url":"https://api.github.com/users/alexbrand/following{/other_user}","gists_url":"https://api.github.com/users/alexbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrand/subscriptions","organizations_url":"https://api.github.com/users/alexbrand/orgs","repos_url":"https://api.github.com/users/alexbrand/repos","events_url":"https://api.github.com/users/alexbrand/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrand/received_events","type":"User","site_admin":false},"labels":[{"id":877348072,"node_id":"MDU6TGFiZWw4NzczNDgwNzI=","url":"https://api.github.com/repos/heptio/gimbal/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":899502228,"node_id":"MDU6TGFiZWw4OTk1MDIyMjg=","url":"https://api.github.com/repos/heptio/gimbal/labels/p0%20-%20Hair%20On%20Fire","name":"p0 - Hair On Fire","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"alexbrand","id":545723,"node_id":"MDQ6VXNlcjU0NTcyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/545723?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrand","html_url":"https://github.com/alexbrand","followers_url":"https://api.github.com/users/alexbrand/followers","following_url":"https://api.github.com/users/alexbrand/following{/other_user}","gists_url":"https://api.github.com/users/alexbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrand/subscriptions","organizations_url":"https://api.github.com/users/alexbrand/orgs","repos_url":"https://api.github.com/users/alexbrand/repos","events_url":"https://api.github.com/users/alexbrand/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrand/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexbrand","id":545723,"node_id":"MDQ6VXNlcjU0NTcyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/545723?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrand","html_url":"https://github.com/alexbrand","followers_url":"https://api.github.com/users/alexbrand/followers","following_url":"https://api.github.com/users/alexbrand/following{/other_user}","gists_url":"https://api.github.com/users/alexbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrand/subscriptions","organizations_url":"https://api.github.com/users/alexbrand/orgs","repos_url":"https://api.github.com/users/alexbrand/repos","events_url":"https://api.github.com/users/alexbrand/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrand/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-26T20:29:56Z","updated_at":"2018-09-26T20:29:56Z","closed_at":null,"author_association":"MEMBER","body":"While testing the openstack discoverer, I found that it was logging the following errors:\r\n```\r\nINFO[2018-09-27T04:07:42+09:00] Successfully handled: add service 'heptio/openstack-discoverytest109-fbad5524e31778'\r\nINFO[2018-09-27T04:07:42+09:00] Successfully handled: add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778'\r\nINFO[2018-09-27T04:07:42+09:00] Successfully handled: add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778'\r\nERRO[2018-09-27T04:07:42+09:00] Error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': resourceVersion should not be set on objects to be created. Number of requeues: 1. Requeuing.\r\nERRO[2018-09-27T04:07:42+09:00] Error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': resourceVersion should not be set on objects to be created. Number of requeues: 1. Requeuing.\r\nERRO[2018-09-27T04:07:42+09:00] Error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': resourceVersion should not be set on objects to be created. Number of requeues: 1. Requeuing.\r\nERRO[2018-09-27T04:07:43+09:00] Error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': error handling add endpoints 'heptio/openstack-discoverytest109-fbad5524e31778': resourceVersion should not be set on objects to be created. Number of requeues: 1. Requeuing.\r\n...\r\n...\r\n...\r\n```\r\n\r\n\r\nAfter further investigation I noticed this change:\r\nhttps://github.com/heptio/gimbal/commit/991b6548ca89b3ae7d6aceb3be19e29cd75c63ad#diff-b53906b731b7f657cecca311ffeb6e98L185\r\n\r\nThe removal of the intermediate var means that we are enqueuing actions on the pointer of the range var, instead of the pointer of the actual svcs/endpoints. For example, in the case where there are 20 services to be added, all 20 add actions will have the same svc within, resulting in the above errors."}}
{"actor":{"display_login":"alexbrand"}}