{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/214134018","pull_request_review_id":151120871,"id":214134018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDEzNDAxOA==","diff_hunk":"@@ -253,6 +286,27 @@ public void run() {\n       }\n     };\n \n+  /** Returns value of security property of network address cache ttl. */\n+  private long getNetworkAddressCacheTtl() {\n+    String cacheTtlPropertyValue = Security.getProperty(NETWORKADDRESS_CACHE_TTL_SECURITY_PROPERTY);\n+    long cacheTtl = DEFAULT_NETWORK_CACHE_TTL;","path":"core/src/main/java/io/grpc/internal/DnsNameResolver.java","position":103,"original_position":103,"commit_id":"3045e58a21ee0ad54967894a95ab0a37300a5564","original_commit_id":"3045e58a21ee0ad54967894a95ab0a37300a5564","user":{"login":"carl-mastrangelo","id":8943572,"node_id":"MDQ6VXNlcjg5NDM1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"DEFAULT_NETWORK_CACHE_TTL_SECONDS","created_at":"2018-08-30T18:24:14Z","updated_at":"2018-08-30T18:28:44Z","html_url":"https://github.com/grpc/grpc-java/pull/4812#discussion_r214134018","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4812","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/214134018"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4812#discussion_r214134018"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4812"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4812","id":211915559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTE1NTU5","html_url":"https://github.com/grpc/grpc-java/pull/4812","diff_url":"https://github.com/grpc/grpc-java/pull/4812.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4812.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4812","number":4812,"state":"open","locked":false,"title":"core: DnsNameResolver caches refresh","user":{"login":"creamsoup","id":1179832,"node_id":"MDQ6VXNlcjExNzk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1179832?v=4","gravatar_id":"","url":"https://api.github.com/users/creamsoup","html_url":"https://github.com/creamsoup","followers_url":"https://api.github.com/users/creamsoup/followers","following_url":"https://api.github.com/users/creamsoup/following{/other_user}","gists_url":"https://api.github.com/users/creamsoup/gists{/gist_id}","starred_url":"https://api.github.com/users/creamsoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creamsoup/subscriptions","organizations_url":"https://api.github.com/users/creamsoup/orgs","repos_url":"https://api.github.com/users/creamsoup/repos","events_url":"https://api.github.com/users/creamsoup/events{/privacy}","received_events_url":"https://api.github.com/users/creamsoup/received_events","type":"User","site_admin":false},"body":"DnsNameResolver caches refresh using java security property networkaddress.cache.ttl.\r\n\r\nResolves #4745","created_at":"2018-08-29T23:28:05Z","updated_at":"2018-08-30T18:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce9e7e8ca2a55aa669bccd0233673426e408ccda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4812/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4812/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4812/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/3045e58a21ee0ad54967894a95ab0a37300a5564","head":{"label":"creamsoup:dns","ref":"dns","sha":"3045e58a21ee0ad54967894a95ab0a37300a5564","user":{"login":"creamsoup","id":1179832,"node_id":"MDQ6VXNlcjExNzk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1179832?v=4","gravatar_id":"","url":"https://api.github.com/users/creamsoup","html_url":"https://github.com/creamsoup","followers_url":"https://api.github.com/users/creamsoup/followers","following_url":"https://api.github.com/users/creamsoup/following{/other_user}","gists_url":"https://api.github.com/users/creamsoup/gists{/gist_id}","starred_url":"https://api.github.com/users/creamsoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creamsoup/subscriptions","organizations_url":"https://api.github.com/users/creamsoup/orgs","repos_url":"https://api.github.com/users/creamsoup/repos","events_url":"https://api.github.com/users/creamsoup/events{/privacy}","received_events_url":"https://api.github.com/users/creamsoup/received_events","type":"User","site_admin":false},"repo":{"id":144617903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MTc5MDM=","name":"grpc-java","full_name":"creamsoup/grpc-java","owner":{"login":"creamsoup","id":1179832,"node_id":"MDQ6VXNlcjExNzk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1179832?v=4","gravatar_id":"","url":"https://api.github.com/users/creamsoup","html_url":"https://github.com/creamsoup","followers_url":"https://api.github.com/users/creamsoup/followers","following_url":"https://api.github.com/users/creamsoup/following{/other_user}","gists_url":"https://api.github.com/users/creamsoup/gists{/gist_id}","starred_url":"https://api.github.com/users/creamsoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creamsoup/subscriptions","organizations_url":"https://api.github.com/users/creamsoup/orgs","repos_url":"https://api.github.com/users/creamsoup/repos","events_url":"https://api.github.com/users/creamsoup/events{/privacy}","received_events_url":"https://api.github.com/users/creamsoup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/creamsoup/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/creamsoup/grpc-java","forks_url":"https://api.github.com/repos/creamsoup/grpc-java/forks","keys_url":"https://api.github.com/repos/creamsoup/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creamsoup/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creamsoup/grpc-java/teams","hooks_url":"https://api.github.com/repos/creamsoup/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/creamsoup/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/creamsoup/grpc-java/events","assignees_url":"https://api.github.com/repos/creamsoup/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/creamsoup/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/creamsoup/grpc-java/tags","blobs_url":"https://api.github.com/repos/creamsoup/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creamsoup/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creamsoup/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/creamsoup/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creamsoup/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/creamsoup/grpc-java/languages","stargazers_url":"https://api.github.com/repos/creamsoup/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/creamsoup/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/creamsoup/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/creamsoup/grpc-java/subscription","commits_url":"https://api.github.com/repos/creamsoup/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/creamsoup/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/creamsoup/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/creamsoup/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/creamsoup/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/creamsoup/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creamsoup/grpc-java/merges","archive_url":"https://api.github.com/repos/creamsoup/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creamsoup/grpc-java/downloads","issues_url":"https://api.github.com/repos/creamsoup/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/creamsoup/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/creamsoup/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/creamsoup/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creamsoup/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/creamsoup/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/creamsoup/grpc-java/deployments","created_at":"2018-08-13T18:23:55Z","updated_at":"2018-08-13T18:24:01Z","pushed_at":"2018-08-30T02:08:35Z","git_url":"git://github.com/creamsoup/grpc-java.git","ssh_url":"git@github.com:creamsoup/grpc-java.git","clone_url":"https://github.com/creamsoup/grpc-java.git","svn_url":"https://github.com/creamsoup/grpc-java","homepage":"https://grpc.io","size":26246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"54f76dfeafe8ac9cf908ceb49ab87bd8348d2dd9","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkyNg==","name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-08-30T14:07:22Z","pushed_at":"2018-08-30T17:10:00Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":26248,"stargazers_count":4771,"watchers_count":4771,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1539,"mirror_url":null,"archived":false,"open_issues_count":366,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1539,"open_issues":366,"watchers":4771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4812"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4812"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4812"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4812/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4812/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4812/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/3045e58a21ee0ad54967894a95ab0a37300a5564"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carl-mastrangelo"}}