{"action":"created","comment":{"url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/comments/244635863","pull_request_review_id":188555211,"id":244635863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYzNTg2Mw==","diff_hunk":"@@ -3,20 +3,32 @@ const {h, Component} = require('preact')\n const helper = require('../modules/helper')\n const setting = remote.require('./setting')\n \n+let winrateGraphMinHeight = setting.get('view.winrategraph_minheight')\n let winrateGraphHeight = setting.get('view.winrategraph_height')\n \n class WinrateGraph extends Component {\n     constructor() {\n         super()\n \n+        this.state = {\n+            sidebarWinrateGraphSplit: setting.get('view.winrategraph_height'),\n+            sidebarWinrateGraphSplitTransition: true","path":"src/components/WinrateGraph.js","position":13,"original_position":13,"commit_id":"6f6c90b54a031a2cfd46ae7d9dc7ac3ad51d69c6","original_commit_id":"6f6c90b54a031a2cfd46ae7d9dc7ac3ad51d69c6","user":{"login":"yishn","id":9217349,"node_id":"MDQ6VXNlcjkyMTczNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/9217349?v=4","gravatar_id":"","url":"https://api.github.com/users/yishn","html_url":"https://github.com/yishn","followers_url":"https://api.github.com/users/yishn/followers","following_url":"https://api.github.com/users/yishn/following{/other_user}","gists_url":"https://api.github.com/users/yishn/gists{/gist_id}","starred_url":"https://api.github.com/users/yishn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yishn/subscriptions","organizations_url":"https://api.github.com/users/yishn/orgs","repos_url":"https://api.github.com/users/yishn/repos","events_url":"https://api.github.com/users/yishn/events{/privacy}","received_events_url":"https://api.github.com/users/yishn/received_events","type":"User","site_admin":false},"body":"Since we're not animating the winrate graph, I don't think keeping track of `sidebarWinrateGraphSplitTransition` is necessary?\r\n\r\nThese are very verbose state names. Can we simplify them a bit? E.g. just use `height` for `sidebarWinrateGraphSplit`.","created_at":"2019-01-01T12:22:42Z","updated_at":"2019-01-01T12:32:41Z","html_url":"https://github.com/SabakiHQ/Sabaki/pull/503#discussion_r244635863","pull_request_url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/comments/244635863"},"html":{"href":"https://github.com/SabakiHQ/Sabaki/pull/503#discussion_r244635863"},"pull_request":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503","id":241619265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjE5MjY1","html_url":"https://github.com/SabakiHQ/Sabaki/pull/503","diff_url":"https://github.com/SabakiHQ/Sabaki/pull/503.diff","patch_url":"https://github.com/SabakiHQ/Sabaki/pull/503.patch","issue_url":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/503","number":503,"state":"open","locked":false,"title":"Resizable Winrate Graph","user":{"login":"dbosst","id":9487496,"node_id":"MDQ6VXNlcjk0ODc0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9487496?v=4","gravatar_id":"","url":"https://api.github.com/users/dbosst","html_url":"https://github.com/dbosst","followers_url":"https://api.github.com/users/dbosst/followers","following_url":"https://api.github.com/users/dbosst/following{/other_user}","gists_url":"https://api.github.com/users/dbosst/gists{/gist_id}","starred_url":"https://api.github.com/users/dbosst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbosst/subscriptions","organizations_url":"https://api.github.com/users/dbosst/orgs","repos_url":"https://api.github.com/users/dbosst/repos","events_url":"https://api.github.com/users/dbosst/events{/privacy}","received_events_url":"https://api.github.com/users/dbosst/received_events","type":"User","site_admin":false},"body":"Lets you resize the winrate graph like you can resize the move comment sidebar.\r\n\r\nI have been zooming in/out too much to see more detail on the graph, so I made it resizable.\r\n\r\nI ended up putting all the relevant code in the WinrateGraph.js rather than Sidebar.js, otherwise, it turned out the same component would end up having conflicting/confusing mouse event handling. Added a min. width in the settings.json, and it has a hard-coded 500 px max (should be plenty). Also added a necessary css for the horizontal resizing bar button.","created_at":"2019-01-01T06:19:05Z","updated_at":"2019-01-01T12:32:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c67d7db28d3c6011a55b4a54cb45ce8aa3561c79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503/commits","review_comments_url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503/comments","review_comment_url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/503/comments","statuses_url":"https://api.github.com/repos/SabakiHQ/Sabaki/statuses/6f6c90b54a031a2cfd46ae7d9dc7ac3ad51d69c6","head":{"label":"dbosst:winrateresizer","ref":"winrateresizer","sha":"6f6c90b54a031a2cfd46ae7d9dc7ac3ad51d69c6","user":{"login":"dbosst","id":9487496,"node_id":"MDQ6VXNlcjk0ODc0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9487496?v=4","gravatar_id":"","url":"https://api.github.com/users/dbosst","html_url":"https://github.com/dbosst","followers_url":"https://api.github.com/users/dbosst/followers","following_url":"https://api.github.com/users/dbosst/following{/other_user}","gists_url":"https://api.github.com/users/dbosst/gists{/gist_id}","starred_url":"https://api.github.com/users/dbosst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbosst/subscriptions","organizations_url":"https://api.github.com/users/dbosst/orgs","repos_url":"https://api.github.com/users/dbosst/repos","events_url":"https://api.github.com/users/dbosst/events{/privacy}","received_events_url":"https://api.github.com/users/dbosst/received_events","type":"User","site_admin":false},"repo":{"id":163668126,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM2NjgxMjY=","name":"Sabaki","full_name":"dbosst/Sabaki","private":false,"owner":{"login":"dbosst","id":9487496,"node_id":"MDQ6VXNlcjk0ODc0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9487496?v=4","gravatar_id":"","url":"https://api.github.com/users/dbosst","html_url":"https://github.com/dbosst","followers_url":"https://api.github.com/users/dbosst/followers","following_url":"https://api.github.com/users/dbosst/following{/other_user}","gists_url":"https://api.github.com/users/dbosst/gists{/gist_id}","starred_url":"https://api.github.com/users/dbosst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbosst/subscriptions","organizations_url":"https://api.github.com/users/dbosst/orgs","repos_url":"https://api.github.com/users/dbosst/repos","events_url":"https://api.github.com/users/dbosst/events{/privacy}","received_events_url":"https://api.github.com/users/dbosst/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbosst/Sabaki","description":"An elegant Go board and SGF editor for a more civilized age.","fork":true,"url":"https://api.github.com/repos/dbosst/Sabaki","forks_url":"https://api.github.com/repos/dbosst/Sabaki/forks","keys_url":"https://api.github.com/repos/dbosst/Sabaki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbosst/Sabaki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbosst/Sabaki/teams","hooks_url":"https://api.github.com/repos/dbosst/Sabaki/hooks","issue_events_url":"https://api.github.com/repos/dbosst/Sabaki/issues/events{/number}","events_url":"https://api.github.com/repos/dbosst/Sabaki/events","assignees_url":"https://api.github.com/repos/dbosst/Sabaki/assignees{/user}","branches_url":"https://api.github.com/repos/dbosst/Sabaki/branches{/branch}","tags_url":"https://api.github.com/repos/dbosst/Sabaki/tags","blobs_url":"https://api.github.com/repos/dbosst/Sabaki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbosst/Sabaki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbosst/Sabaki/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbosst/Sabaki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbosst/Sabaki/statuses/{sha}","languages_url":"https://api.github.com/repos/dbosst/Sabaki/languages","stargazers_url":"https://api.github.com/repos/dbosst/Sabaki/stargazers","contributors_url":"https://api.github.com/repos/dbosst/Sabaki/contributors","subscribers_url":"https://api.github.com/repos/dbosst/Sabaki/subscribers","subscription_url":"https://api.github.com/repos/dbosst/Sabaki/subscription","commits_url":"https://api.github.com/repos/dbosst/Sabaki/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbosst/Sabaki/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbosst/Sabaki/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbosst/Sabaki/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbosst/Sabaki/contents/{+path}","compare_url":"https://api.github.com/repos/dbosst/Sabaki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbosst/Sabaki/merges","archive_url":"https://api.github.com/repos/dbosst/Sabaki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbosst/Sabaki/downloads","issues_url":"https://api.github.com/repos/dbosst/Sabaki/issues{/number}","pulls_url":"https://api.github.com/repos/dbosst/Sabaki/pulls{/number}","milestones_url":"https://api.github.com/repos/dbosst/Sabaki/milestones{/number}","notifications_url":"https://api.github.com/repos/dbosst/Sabaki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbosst/Sabaki/labels{/name}","releases_url":"https://api.github.com/repos/dbosst/Sabaki/releases{/id}","deployments_url":"https://api.github.com/repos/dbosst/Sabaki/deployments","created_at":"2018-12-31T12:41:09Z","updated_at":"2018-12-31T18:15:25Z","pushed_at":"2019-01-01T06:00:18Z","git_url":"git://github.com/dbosst/Sabaki.git","ssh_url":"git@github.com:dbosst/Sabaki.git","clone_url":"https://github.com/dbosst/Sabaki.git","svn_url":"https://github.com/dbosst/Sabaki","homepage":"https://sabaki.yichuanshen.de/","size":32541,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SabakiHQ:master","ref":"master","sha":"0d7f27fadf1ff1ebf04c7b01a70b7096cba8a47e","user":{"login":"SabakiHQ","id":36275559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mjc1NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/36275559?v=4","gravatar_id":"","url":"https://api.github.com/users/SabakiHQ","html_url":"https://github.com/SabakiHQ","followers_url":"https://api.github.com/users/SabakiHQ/followers","following_url":"https://api.github.com/users/SabakiHQ/following{/other_user}","gists_url":"https://api.github.com/users/SabakiHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SabakiHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabakiHQ/subscriptions","organizations_url":"https://api.github.com/users/SabakiHQ/orgs","repos_url":"https://api.github.com/users/SabakiHQ/repos","events_url":"https://api.github.com/users/SabakiHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SabakiHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":34586916,"node_id":"MDEwOlJlcG9zaXRvcnkzNDU4NjkxNg==","name":"Sabaki","full_name":"SabakiHQ/Sabaki","private":false,"owner":{"login":"SabakiHQ","id":36275559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mjc1NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/36275559?v=4","gravatar_id":"","url":"https://api.github.com/users/SabakiHQ","html_url":"https://github.com/SabakiHQ","followers_url":"https://api.github.com/users/SabakiHQ/followers","following_url":"https://api.github.com/users/SabakiHQ/following{/other_user}","gists_url":"https://api.github.com/users/SabakiHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SabakiHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabakiHQ/subscriptions","organizations_url":"https://api.github.com/users/SabakiHQ/orgs","repos_url":"https://api.github.com/users/SabakiHQ/repos","events_url":"https://api.github.com/users/SabakiHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SabakiHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SabakiHQ/Sabaki","description":"An elegant Go board and SGF editor for a more civilized age.","fork":false,"url":"https://api.github.com/repos/SabakiHQ/Sabaki","forks_url":"https://api.github.com/repos/SabakiHQ/Sabaki/forks","keys_url":"https://api.github.com/repos/SabakiHQ/Sabaki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SabakiHQ/Sabaki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SabakiHQ/Sabaki/teams","hooks_url":"https://api.github.com/repos/SabakiHQ/Sabaki/hooks","issue_events_url":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/events{/number}","events_url":"https://api.github.com/repos/SabakiHQ/Sabaki/events","assignees_url":"https://api.github.com/repos/SabakiHQ/Sabaki/assignees{/user}","branches_url":"https://api.github.com/repos/SabakiHQ/Sabaki/branches{/branch}","tags_url":"https://api.github.com/repos/SabakiHQ/Sabaki/tags","blobs_url":"https://api.github.com/repos/SabakiHQ/Sabaki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SabakiHQ/Sabaki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SabakiHQ/Sabaki/git/refs{/sha}","trees_url":"https://api.github.com/repos/SabakiHQ/Sabaki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SabakiHQ/Sabaki/statuses/{sha}","languages_url":"https://api.github.com/repos/SabakiHQ/Sabaki/languages","stargazers_url":"https://api.github.com/repos/SabakiHQ/Sabaki/stargazers","contributors_url":"https://api.github.com/repos/SabakiHQ/Sabaki/contributors","subscribers_url":"https://api.github.com/repos/SabakiHQ/Sabaki/subscribers","subscription_url":"https://api.github.com/repos/SabakiHQ/Sabaki/subscription","commits_url":"https://api.github.com/repos/SabakiHQ/Sabaki/commits{/sha}","git_commits_url":"https://api.github.com/repos/SabakiHQ/Sabaki/git/commits{/sha}","comments_url":"https://api.github.com/repos/SabakiHQ/Sabaki/comments{/number}","issue_comment_url":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/comments{/number}","contents_url":"https://api.github.com/repos/SabakiHQ/Sabaki/contents/{+path}","compare_url":"https://api.github.com/repos/SabakiHQ/Sabaki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SabakiHQ/Sabaki/merges","archive_url":"https://api.github.com/repos/SabakiHQ/Sabaki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SabakiHQ/Sabaki/downloads","issues_url":"https://api.github.com/repos/SabakiHQ/Sabaki/issues{/number}","pulls_url":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls{/number}","milestones_url":"https://api.github.com/repos/SabakiHQ/Sabaki/milestones{/number}","notifications_url":"https://api.github.com/repos/SabakiHQ/Sabaki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SabakiHQ/Sabaki/labels{/name}","releases_url":"https://api.github.com/repos/SabakiHQ/Sabaki/releases{/id}","deployments_url":"https://api.github.com/repos/SabakiHQ/Sabaki/deployments","created_at":"2015-04-25T21:28:01Z","updated_at":"2019-01-01T09:45:36Z","pushed_at":"2019-01-01T06:19:06Z","git_url":"git://github.com/SabakiHQ/Sabaki.git","ssh_url":"git@github.com:SabakiHQ/Sabaki.git","clone_url":"https://github.com/SabakiHQ/Sabaki.git","svn_url":"https://github.com/SabakiHQ/Sabaki","homepage":"https://sabaki.yichuanshen.de/","size":32502,"stargazers_count":762,"watchers_count":762,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":131,"open_issues":45,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503"},"html":{"href":"https://github.com/SabakiHQ/Sabaki/pull/503"},"issue":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/503"},"comments":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/SabakiHQ/Sabaki/statuses/6f6c90b54a031a2cfd46ae7d9dc7ac3ad51d69c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yishn"}}