{"action":"created","issue":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3243","repository_url":"https://api.github.com/repos/rtfd/readthedocs.org","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3243/labels{/name}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3243/comments","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3243/events","html_url":"https://github.com/rtfd/readthedocs.org/pull/3243","id":273020386,"number":3243,"title":"Upgrade docker-py to its latest version (docker==3.1.1)","user":{"login":"humitos","id":244656,"avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false},"labels":[{"id":228777710,"url":"https://api.github.com/repos/rtfd/readthedocs.org/labels/PR:%20ready%20for%20review","name":"PR: ready for review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"humitos","id":244656,"avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false},"assignees":[{"login":"humitos","id":244656,"avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2017-11-10T18:29:16Z","updated_at":"2018-03-09T17:30:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3243","html_url":"https://github.com/rtfd/readthedocs.org/pull/3243","diff_url":"https://github.com/rtfd/readthedocs.org/pull/3243.diff","patch_url":"https://github.com/rtfd/readthedocs.org/pull/3243.patch"},"body":"To avoid this issue immediately after setting up the dev environment:\r\n\r\n```\r\n[10/Nov/2017 12:15:43] readthedocs.doc_builder.environments:316[12710]: ERROR (Build) [fdfdd:latest] mem_limit has been moved to host_config in API version 1.19\r\n```\r\n\r\nI tried updating the `docker-py` version used and the update the code when creating the container to set the proper `mem_limit` under `host_config`.\r\n\r\nSince I don't know what's the version of docker that we are running in production, maybe this PR is useless. Just in case, I'm pasting here what's my local version where it's working with this new upgrade.\r\n\r\n```\r\n(rtfd) [humitos@julia:readthedocs.org|upgrade-dockerpy *$%]$ docker version\r\nClient:\r\n Version:      17.10.0-ce\r\n API version:  1.33\r\n Go version:   go1.9.1\r\n Git commit:   f4ffd2511c\r\n Built:        Wed Oct 18 23:08:56 2017\r\n OS/Arch:      linux/amd64\r\n\r\nServer:\r\n Version:      17.10.0-ce\r\n API version:  1.33 (minimum version 1.12)\r\n Go version:   go1.9.1\r\n Git commit:   f4ffd2511c\r\n Built:        Wed Oct 18 23:09:11 2017\r\n OS/Arch:      linux/amd64\r\n Experimental: false\r\n(rtfd) [humitos@julia:readthedocs.org|upgrade-dockerpy *$%]$ docker info\r\nContainers: 13\r\n Running: 0\r\n Paused: 0\r\n Stopped: 13\r\nImages: 28\r\nServer Version: 17.10.0-ce\r\nStorage Driver: overlay2\r\n Backing Filesystem: extfs\r\n Supports d_type: true\r\n Native Overlay Diff: false\r\nLogging Driver: json-file\r\nCgroup Driver: cgroupfs\r\nPlugins:\r\n Volume: local\r\n Network: bridge host macvlan null overlay\r\n Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog\r\nSwarm: inactive\r\nRuntimes: runc\r\nDefault Runtime: runc\r\nInit Binary: docker-init\r\ncontainerd version: 06b9cb35161009dcb7123345749fef02f7cea8e0\r\nrunc version: 0351df1c5a66838d0c392b4ac4cf9450de844e2d\r\ninit version: 949e6fa\r\nSecurity Options:\r\n seccomp\r\n  Profile: default\r\nKernel Version: 4.13.11-1-ARCH\r\nOperating System: Arch Linux\r\nOSType: linux\r\nArchitecture: x86_64\r\nCPUs: 4\r\nTotal Memory: 7.554GiB\r\nName: julia\r\nID: MEOO:ZCSX:Q7E6:2LVZ:5ECY:VYPD:AMZU:ZW6R:JSMH:Z3NF:RKNQ:IFTI\r\nDocker Root Dir: /var/lib/docker\r\nDebug Mode (client): false\r\nDebug Mode (server): false\r\nRegistry: https://index.docker.io/v1/\r\nExperimental: false\r\nInsecure Registries:\r\n 127.0.0.0/8\r\nLive Restore Enabled: false\r\n\r\n(rtfd) [humitos@julia:readthedocs.org|upgrade-dockerpy *$%]$ \r\n```"},"comment":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments/371883362","html_url":"https://github.com/rtfd/readthedocs.org/pull/3243#issuecomment-371883362","issue_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3243","id":371883362,"user":{"login":"agjohnson","id":1140183,"avatar_url":"https://avatars0.githubusercontent.com/u/1140183?v=4","gravatar_id":"","url":"https://api.github.com/users/agjohnson","html_url":"https://github.com/agjohnson","followers_url":"https://api.github.com/users/agjohnson/followers","following_url":"https://api.github.com/users/agjohnson/following{/other_user}","gists_url":"https://api.github.com/users/agjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/agjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agjohnson/subscriptions","organizations_url":"https://api.github.com/users/agjohnson/orgs","repos_url":"https://api.github.com/users/agjohnson/repos","events_url":"https://api.github.com/users/agjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/agjohnson/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T17:30:35Z","updated_at":"2018-03-09T17:30:35Z","author_association":"CONTRIBUTOR","body":"What is the functionality of `auto`? We've explicitly set an API version in our settings so that our API schema is guaranteed to be correct. I hesitate to make this auto select if it just grabs the version from the docker api and disregards the version of api schema we're actually using."}}
{"actor":{"display_login":"agjohnson"}}