{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/167706750","pull_request_review_id":95965168,"id":167706750,"diff_hunk":"@@ -188,6 +190,69 @@ public void SetTooltip(TFrameworkElement view, string tooltip)\n             ToolTipService.SetToolTip(view, tooltip);\n         }\n \n+        /// <summary>\n+        /// Sets the shadow color of the <typeparamref name=\"TFrameworkElement\"/>.\n+        /// </summary>\n+        /// <param name=\"view\">The view instance.</param>\n+        /// <param name=\"color\">The shadow color.</param>\n+        [ReactProp(\"shadowColor\", CustomType = \"Color\")]\n+        public void SetShadowColor(TFrameworkElement view, uint? color)\n+        {\n+            if (color.HasValue)","path":"ReactWindows/ReactNative/UIManager/BaseViewManager.cs","position":25,"original_position":25,"commit_id":"09a0263ca38e74378e756b8699d49603f89c1ecc","original_commit_id":"b4ae285529da27794e4080bbe2c925a1efa2dc22","user":{"login":"beark","id":4073478,"avatar_url":"https://avatars1.githubusercontent.com/u/4073478?v=4","gravatar_id":"","url":"https://api.github.com/users/beark","html_url":"https://github.com/beark","followers_url":"https://api.github.com/users/beark/followers","following_url":"https://api.github.com/users/beark/following{/other_user}","gists_url":"https://api.github.com/users/beark/gists{/gist_id}","starred_url":"https://api.github.com/users/beark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beark/subscriptions","organizations_url":"https://api.github.com/users/beark/orgs","repos_url":"https://api.github.com/users/beark/repos","events_url":"https://api.github.com/users/beark/events{/privacy}","received_events_url":"https://api.github.com/users/beark/received_events","type":"User","site_admin":false},"body":"The sibling element should now be properly removed/freed when, for example, `shadowColor` is set to `null`. The shadow is also correctly positioned if added after the view has been loaded on the XAML side.","created_at":"2018-02-12T22:26:30Z","updated_at":"2018-02-12T22:26:30Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/1633#discussion_r167706750","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/167706750"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1633#discussion_r167706750"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633"}},"in_reply_to_id":167668321},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633","id":168658391,"html_url":"https://github.com/Microsoft/react-native-windows/pull/1633","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1633.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1633.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1633","number":1633,"state":"open","locked":false,"title":"Implement shadow related properties under UWP","user":{"login":"beark","id":4073478,"avatar_url":"https://avatars1.githubusercontent.com/u/4073478?v=4","gravatar_id":"","url":"https://api.github.com/users/beark","html_url":"https://github.com/beark","followers_url":"https://api.github.com/users/beark/followers","following_url":"https://api.github.com/users/beark/following{/other_user}","gists_url":"https://api.github.com/users/beark/gists{/gist_id}","starred_url":"https://api.github.com/users/beark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beark/subscriptions","organizations_url":"https://api.github.com/users/beark/orgs","repos_url":"https://api.github.com/users/beark/repos","events_url":"https://api.github.com/users/beark/events{/privacy}","received_events_url":"https://api.github.com/users/beark/received_events","type":"User","site_admin":false},"body":"This change adds implementations of the properties `shadowColor`,\r\n`shadowOffset`, `shadowOpacity`, and `shadowRadius` for the UWP flavor of\r\nRNW.\r\n\r\nSpecifically, if any of these properties are set, `BaseViewManager` attempts\r\nto add a new sibling of the relevant view. This sibling will then host the\r\n`DropShadow` in a child `SpriteVisual`. To get correct placement, the\r\nsibling view inherits dimension and transformation properties from the\r\noriginal view.\r\n\r\nNote:\r\nI'm not entirely sure the approach made in this PR is viable.\r\nIn particular, I'm concerned about the following:\r\n- Are the means for finding the `Parent` XAML element and managing the\r\n  sibling robust? \r\n- For example, how likely is it that a `View` ends up being re-parented for\r\n  one reason or another?\r\n- Is it safe to rely on a `OnLoaded` + `OnDropViewInstance` pair of events\r\n  to manage the sibling element's existence?","created_at":"2018-02-12T18:48:22Z","updated_at":"2018-02-12T22:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e67a9927fb66627656fbf9837f8c904ae5a423be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1633/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/09a0263ca38e74378e756b8699d49603f89c1ecc","head":{"label":"beark:uwp-shadows","ref":"uwp-shadows","sha":"09a0263ca38e74378e756b8699d49603f89c1ecc","user":{"login":"beark","id":4073478,"avatar_url":"https://avatars1.githubusercontent.com/u/4073478?v=4","gravatar_id":"","url":"https://api.github.com/users/beark","html_url":"https://github.com/beark","followers_url":"https://api.github.com/users/beark/followers","following_url":"https://api.github.com/users/beark/following{/other_user}","gists_url":"https://api.github.com/users/beark/gists{/gist_id}","starred_url":"https://api.github.com/users/beark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beark/subscriptions","organizations_url":"https://api.github.com/users/beark/orgs","repos_url":"https://api.github.com/users/beark/repos","events_url":"https://api.github.com/users/beark/events{/privacy}","received_events_url":"https://api.github.com/users/beark/received_events","type":"User","site_admin":false},"repo":{"id":116730561,"name":"react-native-windows","full_name":"beark/react-native-windows","owner":{"login":"beark","id":4073478,"avatar_url":"https://avatars1.githubusercontent.com/u/4073478?v=4","gravatar_id":"","url":"https://api.github.com/users/beark","html_url":"https://github.com/beark","followers_url":"https://api.github.com/users/beark/followers","following_url":"https://api.github.com/users/beark/following{/other_user}","gists_url":"https://api.github.com/users/beark/gists{/gist_id}","starred_url":"https://api.github.com/users/beark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beark/subscriptions","organizations_url":"https://api.github.com/users/beark/orgs","repos_url":"https://api.github.com/users/beark/repos","events_url":"https://api.github.com/users/beark/events{/privacy}","received_events_url":"https://api.github.com/users/beark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beark/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/beark/react-native-windows","forks_url":"https://api.github.com/repos/beark/react-native-windows/forks","keys_url":"https://api.github.com/repos/beark/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beark/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beark/react-native-windows/teams","hooks_url":"https://api.github.com/repos/beark/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/beark/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/beark/react-native-windows/events","assignees_url":"https://api.github.com/repos/beark/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/beark/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/beark/react-native-windows/tags","blobs_url":"https://api.github.com/repos/beark/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beark/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beark/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/beark/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beark/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/beark/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/beark/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/beark/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/beark/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/beark/react-native-windows/subscription","commits_url":"https://api.github.com/repos/beark/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/beark/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/beark/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/beark/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/beark/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/beark/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beark/react-native-windows/merges","archive_url":"https://api.github.com/repos/beark/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beark/react-native-windows/downloads","issues_url":"https://api.github.com/repos/beark/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/beark/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/beark/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/beark/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beark/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/beark/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/beark/react-native-windows/deployments","created_at":"2018-01-08T21:33:44Z","updated_at":"2018-01-08T21:33:47Z","pushed_at":"2018-02-12T22:21:20Z","git_url":"git://github.com/beark/react-native-windows.git","ssh_url":"git@github.com:beark/react-native-windows.git","clone_url":"https://github.com/beark/react-native-windows.git","svn_url":"https://github.com/beark/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":156139,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1477040ad1bd83c990fe40eb42d72b936596bc86","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"Microsoft/react-native-windows","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-02-12T21:29:06Z","pushed_at":"2018-02-12T22:21:21Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":158863,"stargazers_count":3514,"watchers_count":3514,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":292,"open_issues":246,"watchers":3514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1633"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1633"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1633/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1633/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/09a0263ca38e74378e756b8699d49603f89c1ecc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"beark"}}