{"action":"created","comment":{"url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/comments/240798176","pull_request_review_id":183912830,"id":240798176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc5ODE3Ng==","diff_hunk":"@@ -0,0 +1,8 @@\n+FactoryBot.define do\n+  factory :user do\n+    name { \"test\" }\n+    sequence(:email) { |n| \"test#{n}@me.com\" }\n+    gender { \"male\" }\n+    password { \"123456\" }","path":"spec/factories/users.rb","position":6,"original_position":6,"commit_id":"4fa3a2ae547d50872414ca5351153b3dfc5ecea0","original_commit_id":"4fa3a2ae547d50872414ca5351153b3dfc5ecea0","user":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"body":"上と同様に、{}を付けないとwarningが発生しまして、\r\nメッセージに従って{}を付けていました。\r\n何か別の箇所で設定必要だったりしますでしょうか？\r\n\r\n> DEPRECATION WARNING: Static attributes will be removed in FactoryBot 5.0. Please use dynamic\r\n> attributes instead by wrapping the attribute value in a block:\r\n> \r\n> password { \"123456\" }\r\n> \r\n> To automatically update from static attributes to dynamic ones,\r\n> install rubocop-rspec and run:\r\n> \r\n> rubocop \\\r\n>   --require rubocop-rspec \\\r\n>   --only FactoryBot/AttributeDefinedStatically \\\r\n>   --auto-correct\r\n> \r\n>  (called from block (2 levels) in <main> at /Users/kp/work/macro_share_v2/spec/factories/users.rb:6)","created_at":"2018-12-11T21:30:32Z","updated_at":"2018-12-11T21:30:32Z","html_url":"https://github.com/jonakp/macro_share_v2/pull/34#discussion_r240798176","pull_request_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/comments/240798176"},"html":{"href":"https://github.com/jonakp/macro_share_v2/pull/34#discussion_r240798176"},"pull_request":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34"}},"in_reply_to_id":240103186},"pull_request":{"url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34","id":237158938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTU4OTM4","html_url":"https://github.com/jonakp/macro_share_v2/pull/34","diff_url":"https://github.com/jonakp/macro_share_v2/pull/34.diff","patch_url":"https://github.com/jonakp/macro_share_v2/pull/34.patch","issue_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/34","number":34,"state":"open","locked":false,"title":"Issue #30 make rspec for like feature","user":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"body":"close #30 \r\n@ms2sato \r\nいいね機能のrspec作成しました。\r\n詳細は以下の通りです。ご確認ください。\r\n\r\n## 修正内容\r\n- userfeature model のlike/unlike/like_by method に対するSpecを作成\r\n- like model のby_user_and_foodhistory scope に対するSpecを作成\r\n  (こちらは)\r\n- テストで必要になるデータはFactoryBotで作成\r\n- 自動生成されていたSpecの中で、passしないものをコメントアウト\r\n  - ほぼdevise関連\r\n\r\n## 確認内容\r\n- bin.rspec foodhistory_spec.rb, like_spec.rbがパスすること\r\n- bin/rspec がパスすること\r\n## 疑問点\r\n- 自動生成のrspecで必要ないものは削除してしまった方が良いでしょうか？","created_at":"2018-12-09T21:36:44Z","updated_at":"2018-12-11T21:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d0afe83c2548200250fcecc1d92ec005adcf9a0","assignee":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34/commits","review_comments_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34/comments","review_comment_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/34/comments","statuses_url":"https://api.github.com/repos/jonakp/macro_share_v2/statuses/4fa3a2ae547d50872414ca5351153b3dfc5ecea0","head":{"label":"jonakp:rspec_for_like_model","ref":"rspec_for_like_model","sha":"4fa3a2ae547d50872414ca5351153b3dfc5ecea0","user":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"repo":{"id":154818776,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MTg3NzY=","name":"macro_share_v2","full_name":"jonakp/macro_share_v2","private":false,"owner":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonakp/macro_share_v2","description":"macro_share_v2","fork":false,"url":"https://api.github.com/repos/jonakp/macro_share_v2","forks_url":"https://api.github.com/repos/jonakp/macro_share_v2/forks","keys_url":"https://api.github.com/repos/jonakp/macro_share_v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonakp/macro_share_v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonakp/macro_share_v2/teams","hooks_url":"https://api.github.com/repos/jonakp/macro_share_v2/hooks","issue_events_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/events{/number}","events_url":"https://api.github.com/repos/jonakp/macro_share_v2/events","assignees_url":"https://api.github.com/repos/jonakp/macro_share_v2/assignees{/user}","branches_url":"https://api.github.com/repos/jonakp/macro_share_v2/branches{/branch}","tags_url":"https://api.github.com/repos/jonakp/macro_share_v2/tags","blobs_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonakp/macro_share_v2/statuses/{sha}","languages_url":"https://api.github.com/repos/jonakp/macro_share_v2/languages","stargazers_url":"https://api.github.com/repos/jonakp/macro_share_v2/stargazers","contributors_url":"https://api.github.com/repos/jonakp/macro_share_v2/contributors","subscribers_url":"https://api.github.com/repos/jonakp/macro_share_v2/subscribers","subscription_url":"https://api.github.com/repos/jonakp/macro_share_v2/subscription","commits_url":"https://api.github.com/repos/jonakp/macro_share_v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonakp/macro_share_v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonakp/macro_share_v2/contents/{+path}","compare_url":"https://api.github.com/repos/jonakp/macro_share_v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonakp/macro_share_v2/merges","archive_url":"https://api.github.com/repos/jonakp/macro_share_v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonakp/macro_share_v2/downloads","issues_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues{/number}","pulls_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls{/number}","milestones_url":"https://api.github.com/repos/jonakp/macro_share_v2/milestones{/number}","notifications_url":"https://api.github.com/repos/jonakp/macro_share_v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonakp/macro_share_v2/labels{/name}","releases_url":"https://api.github.com/repos/jonakp/macro_share_v2/releases{/id}","deployments_url":"https://api.github.com/repos/jonakp/macro_share_v2/deployments","created_at":"2018-10-26T10:37:46Z","updated_at":"2018-12-08T02:18:37Z","pushed_at":"2018-12-11T13:59:09Z","git_url":"git://github.com/jonakp/macro_share_v2.git","ssh_url":"git@github.com:jonakp/macro_share_v2.git","clone_url":"https://github.com/jonakp/macro_share_v2.git","svn_url":"https://github.com/jonakp/macro_share_v2","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"jonakp:master","ref":"master","sha":"9b78972183ea8659e0381b9d8a08c6940d7d8144","user":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"repo":{"id":154818776,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MTg3NzY=","name":"macro_share_v2","full_name":"jonakp/macro_share_v2","private":false,"owner":{"login":"jonakp","id":41995085,"node_id":"MDQ6VXNlcjQxOTk1MDg1","avatar_url":"https://avatars3.githubusercontent.com/u/41995085?v=4","gravatar_id":"","url":"https://api.github.com/users/jonakp","html_url":"https://github.com/jonakp","followers_url":"https://api.github.com/users/jonakp/followers","following_url":"https://api.github.com/users/jonakp/following{/other_user}","gists_url":"https://api.github.com/users/jonakp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonakp/subscriptions","organizations_url":"https://api.github.com/users/jonakp/orgs","repos_url":"https://api.github.com/users/jonakp/repos","events_url":"https://api.github.com/users/jonakp/events{/privacy}","received_events_url":"https://api.github.com/users/jonakp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonakp/macro_share_v2","description":"macro_share_v2","fork":false,"url":"https://api.github.com/repos/jonakp/macro_share_v2","forks_url":"https://api.github.com/repos/jonakp/macro_share_v2/forks","keys_url":"https://api.github.com/repos/jonakp/macro_share_v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonakp/macro_share_v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonakp/macro_share_v2/teams","hooks_url":"https://api.github.com/repos/jonakp/macro_share_v2/hooks","issue_events_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/events{/number}","events_url":"https://api.github.com/repos/jonakp/macro_share_v2/events","assignees_url":"https://api.github.com/repos/jonakp/macro_share_v2/assignees{/user}","branches_url":"https://api.github.com/repos/jonakp/macro_share_v2/branches{/branch}","tags_url":"https://api.github.com/repos/jonakp/macro_share_v2/tags","blobs_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonakp/macro_share_v2/statuses/{sha}","languages_url":"https://api.github.com/repos/jonakp/macro_share_v2/languages","stargazers_url":"https://api.github.com/repos/jonakp/macro_share_v2/stargazers","contributors_url":"https://api.github.com/repos/jonakp/macro_share_v2/contributors","subscribers_url":"https://api.github.com/repos/jonakp/macro_share_v2/subscribers","subscription_url":"https://api.github.com/repos/jonakp/macro_share_v2/subscription","commits_url":"https://api.github.com/repos/jonakp/macro_share_v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonakp/macro_share_v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonakp/macro_share_v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonakp/macro_share_v2/contents/{+path}","compare_url":"https://api.github.com/repos/jonakp/macro_share_v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonakp/macro_share_v2/merges","archive_url":"https://api.github.com/repos/jonakp/macro_share_v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonakp/macro_share_v2/downloads","issues_url":"https://api.github.com/repos/jonakp/macro_share_v2/issues{/number}","pulls_url":"https://api.github.com/repos/jonakp/macro_share_v2/pulls{/number}","milestones_url":"https://api.github.com/repos/jonakp/macro_share_v2/milestones{/number}","notifications_url":"https://api.github.com/repos/jonakp/macro_share_v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonakp/macro_share_v2/labels{/name}","releases_url":"https://api.github.com/repos/jonakp/macro_share_v2/releases{/id}","deployments_url":"https://api.github.com/repos/jonakp/macro_share_v2/deployments","created_at":"2018-10-26T10:37:46Z","updated_at":"2018-12-08T02:18:37Z","pushed_at":"2018-12-11T13:59:09Z","git_url":"git://github.com/jonakp/macro_share_v2.git","ssh_url":"git@github.com:jonakp/macro_share_v2.git","clone_url":"https://github.com/jonakp/macro_share_v2.git","svn_url":"https://github.com/jonakp/macro_share_v2","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34"},"html":{"href":"https://github.com/jonakp/macro_share_v2/pull/34"},"issue":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/issues/34"},"comments":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/jonakp/macro_share_v2/statuses/4fa3a2ae547d50872414ca5351153b3dfc5ecea0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jonakp"}}