{"action":"created","comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/210972013","pull_request_review_id":147305064,"id":210972013,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDk3MjAxMw==","diff_hunk":"@@ -21,37 +22,35 @@ int rl_sim::loop() {\n     const auto context_features = p.get_features();\n     const auto action_features = get_action_features();\n     const auto context_json = create_context_json(context_features,action_features);\n-    const auto req_id = create_uuid();  \n+    const auto req_id = create_event_id();  \n     r::api_status status;\n \n     // Choose an action\n     if ( _rl->choose_rank(req_id.c_str(), context_json.c_str(), response, &status) != err::success ) {\n       std::cout << status.get_error_msg() << std::endl;\n-      return -1;\n+      continue;","path":"reinforcement_learning/examples/rl_sim_cpp/rl_sim.cc","position":20,"original_position":20,"commit_id":"671599b589f3f6e5f5223e521bc6c162f07f25f0","original_commit_id":"442eda859e4c9fbf4fbfbd171054c3981dbe88eb","user":{"login":"rajan-chari","id":21222554,"node_id":"MDQ6VXNlcjIxMjIyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"body":"Since rl_sim is a sample app, probably good to exit in case of error here (or at least handle it differently) to promote proper consumption.  In test_cpp  its probably appropriate to continue.","created_at":"2018-08-17T17:00:08Z","updated_at":"2018-08-17T17:00:08Z","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564#discussion_r210972013","pull_request_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/210972013"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564#discussion_r210972013"},"pull_request":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564"}},"in_reply_to_id":210729400},"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564","id":207682300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjgyMzAw","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564.patch","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1564","number":1564,"state":"closed","locked":false,"title":"Python bindings upd","user":{"login":"ataymano","id":41013086,"node_id":"MDQ6VXNlcjQxMDEzMDg2","avatar_url":"https://avatars2.githubusercontent.com/u/41013086?v=4","gravatar_id":"","url":"https://api.github.com/users/ataymano","html_url":"https://github.com/ataymano","followers_url":"https://api.github.com/users/ataymano/followers","following_url":"https://api.github.com/users/ataymano/following{/other_user}","gists_url":"https://api.github.com/users/ataymano/gists{/gist_id}","starred_url":"https://api.github.com/users/ataymano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataymano/subscriptions","organizations_url":"https://api.github.com/users/ataymano/orgs","repos_url":"https://api.github.com/users/ataymano/repos","events_url":"https://api.github.com/users/ataymano/events{/privacy}","received_events_url":"https://api.github.com/users/ataymano/received_events","type":"User","site_admin":false},"body":"Python bindings. Client lib fixes (actions ordering, chosen action setting, json output). Naming fixes.","created_at":"2018-08-10T17:58:57Z","updated_at":"2018-08-17T17:00:08Z","closed_at":"2018-08-17T16:58:40Z","merged_at":"2018-08-17T16:58:40Z","merge_commit_sha":"8901500148e654e9a55f08b5e990872e259be8af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564/commits","review_comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564/comments","review_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1564/comments","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/671599b589f3f6e5f5223e521bc6c162f07f25f0","head":{"label":"ataymano:python_bindings_upd","ref":"python_bindings_upd","sha":"671599b589f3f6e5f5223e521bc6c162f07f25f0","user":{"login":"ataymano","id":41013086,"node_id":"MDQ6VXNlcjQxMDEzMDg2","avatar_url":"https://avatars2.githubusercontent.com/u/41013086?v=4","gravatar_id":"","url":"https://api.github.com/users/ataymano","html_url":"https://github.com/ataymano","followers_url":"https://api.github.com/users/ataymano/followers","following_url":"https://api.github.com/users/ataymano/following{/other_user}","gists_url":"https://api.github.com/users/ataymano/gists{/gist_id}","starred_url":"https://api.github.com/users/ataymano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataymano/subscriptions","organizations_url":"https://api.github.com/users/ataymano/orgs","repos_url":"https://api.github.com/users/ataymano/repos","events_url":"https://api.github.com/users/ataymano/events{/privacy}","received_events_url":"https://api.github.com/users/ataymano/received_events","type":"User","site_admin":false},"repo":{"id":140489529,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0ODk1Mjk=","name":"vowpal_wabbit","full_name":"ataymano/vowpal_wabbit","owner":{"login":"ataymano","id":41013086,"node_id":"MDQ6VXNlcjQxMDEzMDg2","avatar_url":"https://avatars2.githubusercontent.com/u/41013086?v=4","gravatar_id":"","url":"https://api.github.com/users/ataymano","html_url":"https://github.com/ataymano","followers_url":"https://api.github.com/users/ataymano/followers","following_url":"https://api.github.com/users/ataymano/following{/other_user}","gists_url":"https://api.github.com/users/ataymano/gists{/gist_id}","starred_url":"https://api.github.com/users/ataymano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataymano/subscriptions","organizations_url":"https://api.github.com/users/ataymano/orgs","repos_url":"https://api.github.com/users/ataymano/repos","events_url":"https://api.github.com/users/ataymano/events{/privacy}","received_events_url":"https://api.github.com/users/ataymano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ataymano/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":true,"url":"https://api.github.com/repos/ataymano/vowpal_wabbit","forks_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/ataymano/vowpal_wabbit/deployments","created_at":"2018-07-10T21:34:42Z","updated_at":"2018-07-26T19:21:11Z","pushed_at":"2018-08-17T15:39:29Z","git_url":"git://github.com/ataymano/vowpal_wabbit.git","ssh_url":"git@github.com:ataymano/vowpal_wabbit.git","clone_url":"https://github.com/ataymano/vowpal_wabbit.git","svn_url":"https://github.com/ataymano/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":122187,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JohnLangford:master","ref":"master","sha":"64ac2f8a1f566bb35c811f4f4d2fc8243b5dc5f6","user":{"login":"JohnLangford","id":79590,"node_id":"MDQ6VXNlcjc5NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"repo":{"id":265995,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU5OTU=","name":"vowpal_wabbit","full_name":"JohnLangford/vowpal_wabbit","owner":{"login":"JohnLangford","id":79590,"node_id":"MDQ6VXNlcjc5NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnLangford/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","forks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/deployments","created_at":"2009-07-31T19:36:58Z","updated_at":"2018-08-17T16:58:46Z","pushed_at":"2018-08-17T16:59:35Z","git_url":"git://github.com/JohnLangford/vowpal_wabbit.git","ssh_url":"git@github.com:JohnLangford/vowpal_wabbit.git","clone_url":"https://github.com/JohnLangford/vowpal_wabbit.git","svn_url":"https://github.com/JohnLangford/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":122024,"stargazers_count":5758,"watchers_count":5758,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1448,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1448,"open_issues":33,"watchers":5758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1564"},"issue":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1564"},"comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1564/comments"},"review_comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564/comments"},"review_comment":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1564/commits"},"statuses":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/671599b589f3f6e5f5223e521bc6c162f07f25f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rajan-chari"}}