{"action":"created","issue":{"url":"https://api.github.com/repos/nucleic/enaml/issues/285","repository_url":"https://api.github.com/repos/nucleic/enaml","labels_url":"https://api.github.com/repos/nucleic/enaml/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/nucleic/enaml/issues/285/comments","events_url":"https://api.github.com/repos/nucleic/enaml/issues/285/events","html_url":"https://github.com/nucleic/enaml/pull/285","id":338349332,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzA1MDAw","number":285,"title":"Add support for declarative async func","user":{"login":"frmdstryr","id":380158,"node_id":"MDQ6VXNlcjM4MDE1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/380158?v=4","gravatar_id":"","url":"https://api.github.com/users/frmdstryr","html_url":"https://github.com/frmdstryr","followers_url":"https://api.github.com/users/frmdstryr/followers","following_url":"https://api.github.com/users/frmdstryr/following{/other_user}","gists_url":"https://api.github.com/users/frmdstryr/gists{/gist_id}","starred_url":"https://api.github.com/users/frmdstryr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frmdstryr/subscriptions","organizations_url":"https://api.github.com/users/frmdstryr/orgs","repos_url":"https://api.github.com/users/frmdstryr/repos","events_url":"https://api.github.com/users/frmdstryr/events{/privacy}","received_events_url":"https://api.github.com/users/frmdstryr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-04T18:02:50Z","updated_at":"2018-07-09T03:53:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nucleic/enaml/pulls/285","html_url":"https://github.com/nucleic/enaml/pull/285","diff_url":"https://github.com/nucleic/enaml/pull/285.diff","patch_url":"https://github.com/nucleic/enaml/pull/285.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/nucleic/enaml/issues/comments/403352617","html_url":"https://github.com/nucleic/enaml/pull/285#issuecomment-403352617","issue_url":"https://api.github.com/repos/nucleic/enaml/issues/285","id":403352617,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzM1MjYxNw==","user":{"login":"frmdstryr","id":380158,"node_id":"MDQ6VXNlcjM4MDE1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/380158?v=4","gravatar_id":"","url":"https://api.github.com/users/frmdstryr","html_url":"https://github.com/frmdstryr","followers_url":"https://api.github.com/users/frmdstryr/followers","following_url":"https://api.github.com/users/frmdstryr/following{/other_user}","gists_url":"https://api.github.com/users/frmdstryr/gists{/gist_id}","starred_url":"https://api.github.com/users/frmdstryr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frmdstryr/subscriptions","organizations_url":"https://api.github.com/users/frmdstryr/orgs","repos_url":"https://api.github.com/users/frmdstryr/repos","events_url":"https://api.github.com/users/frmdstryr/events{/privacy}","received_events_url":"https://api.github.com/users/frmdstryr/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T03:53:40Z","updated_at":"2018-07-09T03:53:40Z","author_association":"CONTRIBUTOR","body":"> I don't get why the visitor does not call the visit methods, it seems weird.\r\n\r\nJust realized this is because the test is only parsing, not compiling.  I removed it to double check and it does indeed require the changes to `block_compiler.py`.\r\n\r\n> I wonder if we should try to mark declarative async func as being coroutine based on this test.\r\n\r\nNice find. Probably.\r\n\r\nDo you suggest adding an `_is_coroutine` attribute or set the flag from the issue referenced there?\r\n\r\n```python\r\ndef is_coroutine(function):\r\n    \"\"\"Returns True if the passed in function is a coroutine\"\"\"\r\n    return function.__code__.co_flags & 0x0080 or getattr(function, '_is_coroutine', False)\r\n```\r\n https://github.com/timothycrosley/hug/blob/develop/hug/introspect.py#L33-L35\r\n\r\nIf it's possible to set that flag without any implications, that'd be my vote."}}
{"actor":{"display_login":"frmdstryr"}}