{"action":"created","issue":{"url":"https://api.github.com/repos/franciscop/server/issues/72","repository_url":"https://api.github.com/repos/franciscop/server","labels_url":"https://api.github.com/repos/franciscop/server/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/franciscop/server/issues/72/comments","events_url":"https://api.github.com/repos/franciscop/server/issues/72/events","html_url":"https://github.com/franciscop/server/issues/72","id":296943649,"number":72,"title":"Server is not setting session cookies","user":{"login":"paulrobello","id":955011,"avatar_url":"https://avatars3.githubusercontent.com/u/955011?v=4","gravatar_id":"","url":"https://api.github.com/users/paulrobello","html_url":"https://github.com/paulrobello","followers_url":"https://api.github.com/users/paulrobello/followers","following_url":"https://api.github.com/users/paulrobello/following{/other_user}","gists_url":"https://api.github.com/users/paulrobello/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobello/subscriptions","organizations_url":"https://api.github.com/users/paulrobello/orgs","repos_url":"https://api.github.com/users/paulrobello/repos","events_url":"https://api.github.com/users/paulrobello/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobello/received_events","type":"User","site_admin":false},"labels":[{"id":526849036,"url":"https://api.github.com/repos/franciscop/server/labels/bug","name":"bug","color":"ff5555","default":true},{"id":526848286,"url":"https://api.github.com/repos/franciscop/server/labels/tests","name":"tests","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"franciscop","id":2801252,"avatar_url":"https://avatars2.githubusercontent.com/u/2801252?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscop","html_url":"https://github.com/franciscop","followers_url":"https://api.github.com/users/franciscop/followers","following_url":"https://api.github.com/users/franciscop/following{/other_user}","gists_url":"https://api.github.com/users/franciscop/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscop/subscriptions","organizations_url":"https://api.github.com/users/franciscop/orgs","repos_url":"https://api.github.com/users/franciscop/repos","events_url":"https://api.github.com/users/franciscop/events{/privacy}","received_events_url":"https://api.github.com/users/franciscop/received_events","type":"User","site_admin":false},"assignees":[{"login":"franciscop","id":2801252,"avatar_url":"https://avatars2.githubusercontent.com/u/2801252?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscop","html_url":"https://github.com/franciscop","followers_url":"https://api.github.com/users/franciscop/followers","following_url":"https://api.github.com/users/franciscop/following{/other_user}","gists_url":"https://api.github.com/users/franciscop/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscop/subscriptions","organizations_url":"https://api.github.com/users/franciscop/orgs","repos_url":"https://api.github.com/users/franciscop/repos","events_url":"https://api.github.com/users/franciscop/events{/privacy}","received_events_url":"https://api.github.com/users/franciscop/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/franciscop/server/milestones/4","html_url":"https://github.com/franciscop/server/milestone/4","labels_url":"https://api.github.com/repos/franciscop/server/milestones/4/labels","id":2596152,"number":4,"title":"1.1.0 - Plugins + Socket.io","description":"","creator":{"login":"franciscop","id":2801252,"avatar_url":"https://avatars2.githubusercontent.com/u/2801252?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscop","html_url":"https://github.com/franciscop","followers_url":"https://api.github.com/users/franciscop/followers","following_url":"https://api.github.com/users/franciscop/following{/other_user}","gists_url":"https://api.github.com/users/franciscop/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscop/subscriptions","organizations_url":"https://api.github.com/users/franciscop/orgs","repos_url":"https://api.github.com/users/franciscop/repos","events_url":"https://api.github.com/users/franciscop/events{/privacy}","received_events_url":"https://api.github.com/users/franciscop/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2017-06-21T14:05:07Z","updated_at":"2018-02-15T04:19:04Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-02-14T01:14:20Z","updated_at":"2018-02-15T22:27:34Z","closed_at":null,"author_association":"NONE","body":"Running latest from npm I have a simple GET route and the server response does not contain any cookies.\r\nThe next weird part is. Since the browser gets no cookie its not sending any cookie, however I have a simple visit counter setup in the session and it appears to increment with each visit regardless of using multiple browsers. \r\nThe server seems to be keeping some kind of shared session which it uses for any client that does not provide a session cookie. \r\n\r\nThe next odd thing is I have Redis setup for sessions and have confirmed the server is connected to Redis however if I restart the server the visit counter is lost. \r\n\r\nI am at a loss as how to debug this one...."},"comment":{"url":"https://api.github.com/repos/franciscop/server/issues/comments/366082845","html_url":"https://github.com/franciscop/server/issues/72#issuecomment-366082845","issue_url":"https://api.github.com/repos/franciscop/server/issues/72","id":366082845,"user":{"login":"franciscop","id":2801252,"avatar_url":"https://avatars2.githubusercontent.com/u/2801252?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscop","html_url":"https://github.com/franciscop","followers_url":"https://api.github.com/users/franciscop/followers","following_url":"https://api.github.com/users/franciscop/following{/other_user}","gists_url":"https://api.github.com/users/franciscop/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscop/subscriptions","organizations_url":"https://api.github.com/users/franciscop/orgs","repos_url":"https://api.github.com/users/franciscop/repos","events_url":"https://api.github.com/users/franciscop/events{/privacy}","received_events_url":"https://api.github.com/users/franciscop/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T22:27:34Z","updated_at":"2018-02-15T22:27:34Z","author_association":"OWNER","body":"Really??? Thanks for letting me know, that is certainly big cause of concern. I am reading these awful notes: https://medium.com/@mbostock/prereleases-and-npm-e778fc5e2420\r\n\r\nI think I fixed it. It was about having `server.session` available (needed for some store hooks) AND about the default context extending `server`. So the same instance of `session` was being used for everyone. I'll publish ASAP for furyher testing."}}
{"actor":{"display_login":"franciscop"}}