{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/216206753","pull_request_review_id":153633759,"id":216206753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIwNjc1Mw==","diff_hunk":"@@ -92,7 +97,17 @@ public Result apply(AggregationNode aggregation, Captures captures, Context cont\n                 verify(!mask.isPresent(), \"Expected aggregation without mask symbols, see Rule pattern\");\n                 newAssignments.put(symbol, filter);\n                 mask = Optional.of(symbol);\n+\n+                filterExpressions.add(filter);","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ImplementFilteredAggregations.java","position":31,"original_position":31,"commit_id":"9275d97f007fc58551e98c596f517f92cb0258b4","original_commit_id":"9275d97f007fc58551e98c596f517f92cb0258b4","user":{"login":"kokosing","id":7569403,"node_id":"MDQ6VXNlcjc1Njk0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"body":"Instead of modifying this loop, I would introduce another `method` that would extract the predicate that you could pushdown or `BooleanLiteral.TRUE` if it is not possible extract such a predicate.","created_at":"2018-09-10T06:09:22Z","updated_at":"2018-09-10T06:16:47Z","html_url":"https://github.com/prestodb/presto/pull/11425#discussion_r216206753","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11425","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/216206753"},"html":{"href":"https://github.com/prestodb/presto/pull/11425#discussion_r216206753"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11425"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11425","id":213381663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzgxNjYz","html_url":"https://github.com/prestodb/presto/pull/11425","diff_url":"https://github.com/prestodb/presto/pull/11425.diff","patch_url":"https://github.com/prestodb/presto/pull/11425.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11425","number":11425,"state":"open","locked":false,"title":"Add disjunctive predicate for filtered aggregates","user":{"login":"atris","id":1724131,"node_id":"MDQ6VXNlcjE3MjQxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1724131?v=4","gravatar_id":"","url":"https://api.github.com/users/atris","html_url":"https://github.com/atris","followers_url":"https://api.github.com/users/atris/followers","following_url":"https://api.github.com/users/atris/following{/other_user}","gists_url":"https://api.github.com/users/atris/gists{/gist_id}","starred_url":"https://api.github.com/users/atris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atris/subscriptions","organizations_url":"https://api.github.com/users/atris/orgs","repos_url":"https://api.github.com/users/atris/repos","events_url":"https://api.github.com/users/atris/events{/privacy}","received_events_url":"https://api.github.com/users/atris/received_events","type":"User","site_admin":false},"body":"Filtered aggregates do not make an explicit predicate of the filter clause\r\nthat is present. This limits the ability of the optimizer to potentially\r\npush down the predicate to table scan node. This commit adds a filter node\r\nwith a disjunctive predicate formed from all the filter clauses present in\r\nthe aggregation node's aggregates","created_at":"2018-09-05T18:07:28Z","updated_at":"2018-09-10T06:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22dd27081eeb30adfd60205efc8233e9e5723df8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11425/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11425/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11425/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/9275d97f007fc58551e98c596f517f92cb0258b4","head":{"label":"atris:filter_push_expressions","ref":"filter_push_expressions","sha":"9275d97f007fc58551e98c596f517f92cb0258b4","user":{"login":"atris","id":1724131,"node_id":"MDQ6VXNlcjE3MjQxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1724131?v=4","gravatar_id":"","url":"https://api.github.com/users/atris","html_url":"https://github.com/atris","followers_url":"https://api.github.com/users/atris/followers","following_url":"https://api.github.com/users/atris/following{/other_user}","gists_url":"https://api.github.com/users/atris/gists{/gist_id}","starred_url":"https://api.github.com/users/atris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atris/subscriptions","organizations_url":"https://api.github.com/users/atris/orgs","repos_url":"https://api.github.com/users/atris/repos","events_url":"https://api.github.com/users/atris/events{/privacy}","received_events_url":"https://api.github.com/users/atris/received_events","type":"User","site_admin":false},"repo":{"id":137180583,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxODA1ODM=","name":"presto","full_name":"atris/presto","owner":{"login":"atris","id":1724131,"node_id":"MDQ6VXNlcjE3MjQxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1724131?v=4","gravatar_id":"","url":"https://api.github.com/users/atris","html_url":"https://github.com/atris","followers_url":"https://api.github.com/users/atris/followers","following_url":"https://api.github.com/users/atris/following{/other_user}","gists_url":"https://api.github.com/users/atris/gists{/gist_id}","starred_url":"https://api.github.com/users/atris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atris/subscriptions","organizations_url":"https://api.github.com/users/atris/orgs","repos_url":"https://api.github.com/users/atris/repos","events_url":"https://api.github.com/users/atris/events{/privacy}","received_events_url":"https://api.github.com/users/atris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atris/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/atris/presto","forks_url":"https://api.github.com/repos/atris/presto/forks","keys_url":"https://api.github.com/repos/atris/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atris/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atris/presto/teams","hooks_url":"https://api.github.com/repos/atris/presto/hooks","issue_events_url":"https://api.github.com/repos/atris/presto/issues/events{/number}","events_url":"https://api.github.com/repos/atris/presto/events","assignees_url":"https://api.github.com/repos/atris/presto/assignees{/user}","branches_url":"https://api.github.com/repos/atris/presto/branches{/branch}","tags_url":"https://api.github.com/repos/atris/presto/tags","blobs_url":"https://api.github.com/repos/atris/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atris/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atris/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/atris/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atris/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/atris/presto/languages","stargazers_url":"https://api.github.com/repos/atris/presto/stargazers","contributors_url":"https://api.github.com/repos/atris/presto/contributors","subscribers_url":"https://api.github.com/repos/atris/presto/subscribers","subscription_url":"https://api.github.com/repos/atris/presto/subscription","commits_url":"https://api.github.com/repos/atris/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/atris/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/atris/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/atris/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/atris/presto/contents/{+path}","compare_url":"https://api.github.com/repos/atris/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atris/presto/merges","archive_url":"https://api.github.com/repos/atris/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atris/presto/downloads","issues_url":"https://api.github.com/repos/atris/presto/issues{/number}","pulls_url":"https://api.github.com/repos/atris/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/atris/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/atris/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atris/presto/labels{/name}","releases_url":"https://api.github.com/repos/atris/presto/releases{/id}","deployments_url":"https://api.github.com/repos/atris/presto/deployments","created_at":"2018-06-13T07:42:19Z","updated_at":"2018-06-13T07:42:40Z","pushed_at":"2018-09-07T10:50:06Z","git_url":"git://github.com/atris/presto.git","ssh_url":"git@github.com:atris/presto.git","clone_url":"https://github.com/atris/presto.git","svn_url":"https://github.com/atris/presto","homepage":"https://prestodb.io","size":97677,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"ea3e61ecbe970bbf248efc487cedd88db567da4f","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-09-10T03:04:28Z","pushed_at":"2018-09-10T04:06:17Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":97954,"stargazers_count":8033,"watchers_count":8033,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2720,"mirror_url":null,"archived":false,"open_issues_count":1370,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2720,"open_issues":1370,"watchers":8033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11425"},"html":{"href":"https://github.com/prestodb/presto/pull/11425"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11425"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11425/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11425/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11425/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/9275d97f007fc58551e98c596f517f92cb0258b4"}},"author_association":"NONE"}}
{"actor":{"display_login":"kokosing"}}