{"action":"opened","number":1030,"pull_request":{"url":"https://api.github.com/repos/Shopify/sarama/pulls/1030","id":166632899,"html_url":"https://github.com/Shopify/sarama/pull/1030","diff_url":"https://github.com/Shopify/sarama/pull/1030.diff","patch_url":"https://github.com/Shopify/sarama/pull/1030.patch","issue_url":"https://api.github.com/repos/Shopify/sarama/issues/1030","number":1030,"state":"open","locked":false,"title":"Do not choke on MessageSet without version","user":{"login":"bobrik","id":89186,"avatar_url":"https://avatars0.githubusercontent.com/u/89186?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrik","html_url":"https://github.com/bobrik","followers_url":"https://api.github.com/users/bobrik/followers","following_url":"https://api.github.com/users/bobrik/following{/other_user}","gists_url":"https://api.github.com/users/bobrik/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrik/subscriptions","organizations_url":"https://api.github.com/users/bobrik/orgs","repos_url":"https://api.github.com/users/bobrik/repos","events_url":"https://api.github.com/users/bobrik/events{/privacy}","received_events_url":"https://api.github.com/users/bobrik/received_events","type":"User","site_admin":false},"body":"If we end un unlucky and MessageSet buffer is truncated right before\r\nwe can read magic value, we just return `ErrInsufficientData`, even\r\nif some messages were previously successfully parsed.\r\n\r\nThis propagates all the way up to `partitionConsumer`, where we zero\r\nparsed messages, which results in `ErrMessageTooLarge` returned\r\nto the consumer.\r\n\r\nThis commit fixes the issue by setting `PartialTrailingMessage` to `true`\r\non `MessageSet`, making it possible to read successfully parsed messages.","created_at":"2018-02-01T19:42:42Z","updated_at":"2018-02-01T19:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/sarama/pulls/1030/commits","review_comments_url":"https://api.github.com/repos/Shopify/sarama/pulls/1030/comments","review_comment_url":"https://api.github.com/repos/Shopify/sarama/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/sarama/issues/1030/comments","statuses_url":"https://api.github.com/repos/Shopify/sarama/statuses/885c1b09e527a9204db509283d5027370e238d99","head":{"label":"bobrik:partial-version","ref":"partial-version","sha":"885c1b09e527a9204db509283d5027370e238d99","user":{"login":"bobrik","id":89186,"avatar_url":"https://avatars0.githubusercontent.com/u/89186?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrik","html_url":"https://github.com/bobrik","followers_url":"https://api.github.com/users/bobrik/followers","following_url":"https://api.github.com/users/bobrik/following{/other_user}","gists_url":"https://api.github.com/users/bobrik/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrik/subscriptions","organizations_url":"https://api.github.com/users/bobrik/orgs","repos_url":"https://api.github.com/users/bobrik/repos","events_url":"https://api.github.com/users/bobrik/events{/privacy}","received_events_url":"https://api.github.com/users/bobrik/received_events","type":"User","site_admin":false},"repo":{"id":115766461,"name":"sarama","full_name":"bobrik/sarama","owner":{"login":"bobrik","id":89186,"avatar_url":"https://avatars0.githubusercontent.com/u/89186?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrik","html_url":"https://github.com/bobrik","followers_url":"https://api.github.com/users/bobrik/followers","following_url":"https://api.github.com/users/bobrik/following{/other_user}","gists_url":"https://api.github.com/users/bobrik/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrik/subscriptions","organizations_url":"https://api.github.com/users/bobrik/orgs","repos_url":"https://api.github.com/users/bobrik/repos","events_url":"https://api.github.com/users/bobrik/events{/privacy}","received_events_url":"https://api.github.com/users/bobrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobrik/sarama","description":"Sarama is a Go library for Apache Kafka 0.8, and up.","fork":true,"url":"https://api.github.com/repos/bobrik/sarama","forks_url":"https://api.github.com/repos/bobrik/sarama/forks","keys_url":"https://api.github.com/repos/bobrik/sarama/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobrik/sarama/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobrik/sarama/teams","hooks_url":"https://api.github.com/repos/bobrik/sarama/hooks","issue_events_url":"https://api.github.com/repos/bobrik/sarama/issues/events{/number}","events_url":"https://api.github.com/repos/bobrik/sarama/events","assignees_url":"https://api.github.com/repos/bobrik/sarama/assignees{/user}","branches_url":"https://api.github.com/repos/bobrik/sarama/branches{/branch}","tags_url":"https://api.github.com/repos/bobrik/sarama/tags","blobs_url":"https://api.github.com/repos/bobrik/sarama/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobrik/sarama/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobrik/sarama/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobrik/sarama/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobrik/sarama/statuses/{sha}","languages_url":"https://api.github.com/repos/bobrik/sarama/languages","stargazers_url":"https://api.github.com/repos/bobrik/sarama/stargazers","contributors_url":"https://api.github.com/repos/bobrik/sarama/contributors","subscribers_url":"https://api.github.com/repos/bobrik/sarama/subscribers","subscription_url":"https://api.github.com/repos/bobrik/sarama/subscription","commits_url":"https://api.github.com/repos/bobrik/sarama/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobrik/sarama/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobrik/sarama/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobrik/sarama/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobrik/sarama/contents/{+path}","compare_url":"https://api.github.com/repos/bobrik/sarama/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobrik/sarama/merges","archive_url":"https://api.github.com/repos/bobrik/sarama/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobrik/sarama/downloads","issues_url":"https://api.github.com/repos/bobrik/sarama/issues{/number}","pulls_url":"https://api.github.com/repos/bobrik/sarama/pulls{/number}","milestones_url":"https://api.github.com/repos/bobrik/sarama/milestones{/number}","notifications_url":"https://api.github.com/repos/bobrik/sarama/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobrik/sarama/labels{/name}","releases_url":"https://api.github.com/repos/bobrik/sarama/releases{/id}","deployments_url":"https://api.github.com/repos/bobrik/sarama/deployments","created_at":"2017-12-30T01:43:21Z","updated_at":"2017-12-30T01:43:23Z","pushed_at":"2018-02-01T19:42:29Z","git_url":"git://github.com/bobrik/sarama.git","ssh_url":"git@github.com:bobrik/sarama.git","clone_url":"https://github.com/bobrik/sarama.git","svn_url":"https://github.com/bobrik/sarama","homepage":"https://shopify.github.io/sarama","size":2005,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"0f4f8caef994ca7e4f9072c1858b7c6761ed498f","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":11206255,"name":"sarama","full_name":"Shopify/sarama","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/sarama","description":"Sarama is a Go library for Apache Kafka 0.8, and up.","fork":false,"url":"https://api.github.com/repos/Shopify/sarama","forks_url":"https://api.github.com/repos/Shopify/sarama/forks","keys_url":"https://api.github.com/repos/Shopify/sarama/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/sarama/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/sarama/teams","hooks_url":"https://api.github.com/repos/Shopify/sarama/hooks","issue_events_url":"https://api.github.com/repos/Shopify/sarama/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/sarama/events","assignees_url":"https://api.github.com/repos/Shopify/sarama/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/sarama/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/sarama/tags","blobs_url":"https://api.github.com/repos/Shopify/sarama/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/sarama/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/sarama/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/sarama/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/sarama/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/sarama/languages","stargazers_url":"https://api.github.com/repos/Shopify/sarama/stargazers","contributors_url":"https://api.github.com/repos/Shopify/sarama/contributors","subscribers_url":"https://api.github.com/repos/Shopify/sarama/subscribers","subscription_url":"https://api.github.com/repos/Shopify/sarama/subscription","commits_url":"https://api.github.com/repos/Shopify/sarama/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/sarama/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/sarama/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/sarama/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/sarama/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/sarama/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/sarama/merges","archive_url":"https://api.github.com/repos/Shopify/sarama/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/sarama/downloads","issues_url":"https://api.github.com/repos/Shopify/sarama/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/sarama/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/sarama/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/sarama/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/sarama/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/sarama/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/sarama/deployments","created_at":"2013-07-05T18:52:38Z","updated_at":"2018-02-01T02:54:29Z","pushed_at":"2018-01-25T14:47:39Z","git_url":"git://github.com/Shopify/sarama.git","ssh_url":"git@github.com:Shopify/sarama.git","clone_url":"https://github.com/Shopify/sarama.git","svn_url":"https://github.com/Shopify/sarama","homepage":"https://shopify.github.io/sarama","size":2008,"stargazers_count":2539,"watchers_count":2539,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":492,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":492,"open_issues":30,"watchers":2539,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/sarama/pulls/1030"},"html":{"href":"https://github.com/Shopify/sarama/pull/1030"},"issue":{"href":"https://api.github.com/repos/Shopify/sarama/issues/1030"},"comments":{"href":"https://api.github.com/repos/Shopify/sarama/issues/1030/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/sarama/pulls/1030/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/sarama/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/sarama/pulls/1030/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/sarama/statuses/885c1b09e527a9204db509283d5027370e238d99"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bobrik"}}