{"action":"created","comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/195898722","pull_request_review_id":129358877,"id":195898722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTg5ODcyMg==","diff_hunk":"@@ -402,36 +441,7 @@ INT_PTR CPropToolbar::DispatchEvent(\n \t\tbreak;\n \n \tcase WM_TIMER:\n-\t\tnIndex1 = List_GetCurSel( hwndResList );\n-\t\tnIndex2 = List_GetCurSel( hwndFuncList );\n-\t\ti = List_GetCount( hwndResList );","path":"sakura_core/prop/CPropComToolbar.cpp","position":59,"original_position":59,"commit_id":"9cbff66e16f4f8c638e16df1effe1664eced01ca","original_commit_id":"9cbff66e16f4f8c638e16df1effe1664eced01ca","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"body":"`WM_TIMER` メッセージ時の処理を関数化しましたが、`nIndex1`, `nIndex2`, `i` 等のローカル変数は他のメッセージ時に処理で使われているので削除する事は出来ません。","created_at":"2018-06-16T09:13:18Z","updated_at":"2018-06-16T09:13:18Z","html_url":"https://github.com/sakura-editor/sakura/pull/122#discussion_r195898722","pull_request_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/122","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/195898722"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/122#discussion_r195898722"},"pull_request":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/122"}},"in_reply_to_id":195898012},"pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/122","id":195318436,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzE4NDM2","html_url":"https://github.com/sakura-editor/sakura/pull/122","diff_url":"https://github.com/sakura-editor/sakura/pull/122.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/122.patch","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/122","number":122,"state":"open","locked":false,"title":"プロパティシートのコントロールの有効/無効制御を早めに実施","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"body":"共通設定のメインメニューとツールバーとカスタムメニューのプロパティシートのコントロールが無効化される処理を早めに行う事で、画面を初回表示した際にタイマー処理でコントロールが無効化されるのが目視出来てしまう現象を回避\r\n\r\n- WM_TIMER メッセージ時に行う コントロールの有効/無効制御処理を新規に関数化（SetDlgItemsEnableState）\r\n- WM_INITDIALOG メッセージ処理時に SetTimer した後にコントロールの有効/無効制御処理を実施する新規関数の呼び出しを追加","created_at":"2018-06-16T05:32:54Z","updated_at":"2018-06-16T09:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6dff6700137f381ae6b69d088c180cf9b5f83c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/122/commits","review_comments_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/122/comments","review_comment_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/122/comments","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/9cbff66e16f4f8c638e16df1effe1664eced01ca","head":{"label":"beru:prop_dlg_items_enable_state","ref":"prop_dlg_items_enable_state","sha":"9cbff66e16f4f8c638e16df1effe1664eced01ca","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"repo":{"id":136746507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3NDY1MDc=","name":"sakura","full_name":"beru/sakura","owner":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beru/sakura","description":"SourceForgeから移行。VS2017ビルド確認済。","fork":true,"url":"https://api.github.com/repos/beru/sakura","forks_url":"https://api.github.com/repos/beru/sakura/forks","keys_url":"https://api.github.com/repos/beru/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beru/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beru/sakura/teams","hooks_url":"https://api.github.com/repos/beru/sakura/hooks","issue_events_url":"https://api.github.com/repos/beru/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/beru/sakura/events","assignees_url":"https://api.github.com/repos/beru/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/beru/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/beru/sakura/tags","blobs_url":"https://api.github.com/repos/beru/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beru/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beru/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/beru/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beru/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/beru/sakura/languages","stargazers_url":"https://api.github.com/repos/beru/sakura/stargazers","contributors_url":"https://api.github.com/repos/beru/sakura/contributors","subscribers_url":"https://api.github.com/repos/beru/sakura/subscribers","subscription_url":"https://api.github.com/repos/beru/sakura/subscription","commits_url":"https://api.github.com/repos/beru/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/beru/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/beru/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/beru/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/beru/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/beru/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beru/sakura/merges","archive_url":"https://api.github.com/repos/beru/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beru/sakura/downloads","issues_url":"https://api.github.com/repos/beru/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/beru/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/beru/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/beru/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beru/sakura/labels{/name}","releases_url":"https://api.github.com/repos/beru/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/beru/sakura/deployments","created_at":"2018-06-09T18:03:32Z","updated_at":"2018-06-09T18:03:37Z","pushed_at":"2018-06-16T05:31:17Z","git_url":"git://github.com/beru/sakura.git","ssh_url":"git@github.com:beru/sakura.git","clone_url":"https://github.com/beru/sakura.git","svn_url":"https://github.com/beru/sakura","homepage":"","size":16356,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sakura-editor:master","ref":"master","sha":"b03ddd7acaa1a6f4cc1783a5dfbe3690b44db39b","user":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":134057969,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNTc5Njk=","name":"sakura","full_name":"sakura-editor/sakura","owner":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sakura-editor/sakura","description":"SourceForgeから移行。VS2017ビルド確認済。","fork":false,"url":"https://api.github.com/repos/sakura-editor/sakura","forks_url":"https://api.github.com/repos/sakura-editor/sakura/forks","keys_url":"https://api.github.com/repos/sakura-editor/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakura-editor/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakura-editor/sakura/teams","hooks_url":"https://api.github.com/repos/sakura-editor/sakura/hooks","issue_events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/sakura-editor/sakura/events","assignees_url":"https://api.github.com/repos/sakura-editor/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/sakura-editor/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/sakura-editor/sakura/tags","blobs_url":"https://api.github.com/repos/sakura-editor/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakura-editor/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakura-editor/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakura-editor/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/sakura-editor/sakura/languages","stargazers_url":"https://api.github.com/repos/sakura-editor/sakura/stargazers","contributors_url":"https://api.github.com/repos/sakura-editor/sakura/contributors","subscribers_url":"https://api.github.com/repos/sakura-editor/sakura/subscribers","subscription_url":"https://api.github.com/repos/sakura-editor/sakura/subscription","commits_url":"https://api.github.com/repos/sakura-editor/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakura-editor/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakura-editor/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/sakura-editor/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakura-editor/sakura/merges","archive_url":"https://api.github.com/repos/sakura-editor/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakura-editor/sakura/downloads","issues_url":"https://api.github.com/repos/sakura-editor/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/sakura-editor/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/sakura-editor/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/sakura-editor/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakura-editor/sakura/labels{/name}","releases_url":"https://api.github.com/repos/sakura-editor/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/sakura-editor/sakura/deployments","created_at":"2018-05-19T12:02:06Z","updated_at":"2018-06-15T05:50:43Z","pushed_at":"2018-06-16T08:53:42Z","git_url":"git://github.com/sakura-editor/sakura.git","ssh_url":"git@github.com:sakura-editor/sakura.git","clone_url":"https://github.com/sakura-editor/sakura.git","svn_url":"https://github.com/sakura-editor/sakura","homepage":"","size":16363,"stargazers_count":155,"watchers_count":155,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":53,"license":null,"forks":7,"open_issues":53,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/122"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/122"},"issue":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/122"},"comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/sakura-editor/sakura/statuses/9cbff66e16f4f8c638e16df1effe1664eced01ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"beru"}}