{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/210538850","pull_request_review_id":146773120,"id":210538850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDUzODg1MA==","diff_hunk":"@@ -13,6 +13,7 @@ import {KeyBase} from './key-base';\n import {atob} from '../../../platform/atob-web.js';\n import {btoa} from '../../../platform/btoa-web.js';\n import {CrdtCollectionModel} from './crdt-collection-model';\n+import {Id} from '../id';","path":"runtime/ts/storage/firebase-storage.ts","position":4,"original_position":4,"commit_id":"ff170418c2f07f39f773c3dcab87b256769d60e2","original_commit_id":"ff170418c2f07f39f773c3dcab87b256769d60e2","user":{"login":"shans","id":329053,"node_id":"MDQ6VXNlcjMyOTA1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"in general we're going to need to refer to ts modules via the .js hack so we can preserve load-without-build for the shell. Not all imports require it (e.g. crdt-collection-model above seems to work OK) but I think we should probably start always doing it so that we can remain consistent?\r\n\r\nThis basically just means using `import {Id} from '../id.js';` here. Typescript understands js references to ts files but passes through the full reference (rather than the one without an extension), which then allows module loading to occur in the shell if the .js file is referenced without webPacking (or other ES6 shimming).","created_at":"2018-08-16T09:53:56Z","updated_at":"2018-08-16T09:53:56Z","html_url":"https://github.com/PolymerLabs/arcs/pull/1780#discussion_r210538850","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/210538850"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/1780#discussion_r210538850"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780","id":208792234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzkyMjM0","html_url":"https://github.com/PolymerLabs/arcs/pull/1780","diff_url":"https://github.com/PolymerLabs/arcs/pull/1780.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/1780.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/1780","number":1780,"state":"open","locked":false,"title":"Fix some Id type usages","user":{"login":"lindner","id":96715,"node_id":"MDQ6VXNlcjk2NzE1","avatar_url":"https://avatars1.githubusercontent.com/u/96715?v=4","gravatar_id":"","url":"https://api.github.com/users/lindner","html_url":"https://github.com/lindner","followers_url":"https://api.github.com/users/lindner/followers","following_url":"https://api.github.com/users/lindner/following{/other_user}","gists_url":"https://api.github.com/users/lindner/gists{/gist_id}","starred_url":"https://api.github.com/users/lindner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindner/subscriptions","organizations_url":"https://api.github.com/users/lindner/orgs","repos_url":"https://api.github.com/users/lindner/repos","events_url":"https://api.github.com/users/lindner/events{/privacy}","received_events_url":"https://api.github.com/users/lindner/received_events","type":"User","site_admin":false},"body":"- Fixes type signature in storage-provider-factory and other classes where string\r\n  was being used instead\r\n- Explicit usage of toString when setting key.arcId in InMemoryStorage\r\n- Uses id.toString as the cache key in InMemoryStorage\r\n","created_at":"2018-08-16T09:08:47Z","updated_at":"2018-08-16T09:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb1abb5683752e9a7745eabbed09f14af16499ba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mykmartin","id":34528845,"node_id":"MDQ6VXNlcjM0NTI4ODQ1","avatar_url":"https://avatars0.githubusercontent.com/u/34528845?v=4","gravatar_id":"","url":"https://api.github.com/users/mykmartin","html_url":"https://github.com/mykmartin","followers_url":"https://api.github.com/users/mykmartin/followers","following_url":"https://api.github.com/users/mykmartin/following{/other_user}","gists_url":"https://api.github.com/users/mykmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/mykmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykmartin/subscriptions","organizations_url":"https://api.github.com/users/mykmartin/orgs","repos_url":"https://api.github.com/users/mykmartin/repos","events_url":"https://api.github.com/users/mykmartin/events{/privacy}","received_events_url":"https://api.github.com/users/mykmartin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/1780/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/ff170418c2f07f39f773c3dcab87b256769d60e2","head":{"label":"lindner:ts-convert","ref":"ts-convert","sha":"ff170418c2f07f39f773c3dcab87b256769d60e2","user":{"login":"lindner","id":96715,"node_id":"MDQ6VXNlcjk2NzE1","avatar_url":"https://avatars1.githubusercontent.com/u/96715?v=4","gravatar_id":"","url":"https://api.github.com/users/lindner","html_url":"https://github.com/lindner","followers_url":"https://api.github.com/users/lindner/followers","following_url":"https://api.github.com/users/lindner/following{/other_user}","gists_url":"https://api.github.com/users/lindner/gists{/gist_id}","starred_url":"https://api.github.com/users/lindner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindner/subscriptions","organizations_url":"https://api.github.com/users/lindner/orgs","repos_url":"https://api.github.com/users/lindner/repos","events_url":"https://api.github.com/users/lindner/events{/privacy}","received_events_url":"https://api.github.com/users/lindner/received_events","type":"User","site_admin":false},"repo":{"id":135092571,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwOTI1NzE=","name":"arcs","full_name":"lindner/arcs","owner":{"login":"lindner","id":96715,"node_id":"MDQ6VXNlcjk2NzE1","avatar_url":"https://avatars1.githubusercontent.com/u/96715?v=4","gravatar_id":"","url":"https://api.github.com/users/lindner","html_url":"https://github.com/lindner","followers_url":"https://api.github.com/users/lindner/followers","following_url":"https://api.github.com/users/lindner/following{/other_user}","gists_url":"https://api.github.com/users/lindner/gists{/gist_id}","starred_url":"https://api.github.com/users/lindner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindner/subscriptions","organizations_url":"https://api.github.com/users/lindner/orgs","repos_url":"https://api.github.com/users/lindner/repos","events_url":"https://api.github.com/users/lindner/events{/privacy}","received_events_url":"https://api.github.com/users/lindner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lindner/arcs","description":null,"fork":true,"url":"https://api.github.com/repos/lindner/arcs","forks_url":"https://api.github.com/repos/lindner/arcs/forks","keys_url":"https://api.github.com/repos/lindner/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lindner/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lindner/arcs/teams","hooks_url":"https://api.github.com/repos/lindner/arcs/hooks","issue_events_url":"https://api.github.com/repos/lindner/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/lindner/arcs/events","assignees_url":"https://api.github.com/repos/lindner/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/lindner/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/lindner/arcs/tags","blobs_url":"https://api.github.com/repos/lindner/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lindner/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lindner/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lindner/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lindner/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/lindner/arcs/languages","stargazers_url":"https://api.github.com/repos/lindner/arcs/stargazers","contributors_url":"https://api.github.com/repos/lindner/arcs/contributors","subscribers_url":"https://api.github.com/repos/lindner/arcs/subscribers","subscription_url":"https://api.github.com/repos/lindner/arcs/subscription","commits_url":"https://api.github.com/repos/lindner/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lindner/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lindner/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lindner/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lindner/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/lindner/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lindner/arcs/merges","archive_url":"https://api.github.com/repos/lindner/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lindner/arcs/downloads","issues_url":"https://api.github.com/repos/lindner/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/lindner/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/lindner/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/lindner/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lindner/arcs/labels{/name}","releases_url":"https://api.github.com/repos/lindner/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/lindner/arcs/deployments","created_at":"2018-05-28T00:44:14Z","updated_at":"2018-05-29T04:18:11Z","pushed_at":"2018-08-16T09:31:47Z","git_url":"git://github.com/lindner/arcs.git","ssh_url":"git@github.com:lindner/arcs.git","clone_url":"https://github.com/lindner/arcs.git","svn_url":"https://github.com/lindner/arcs","homepage":null,"size":26203,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"41c0bbfe7d6724f8a8183575a9062d63e7403525","user":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzEyMg==","name":"arcs","full_name":"PolymerLabs/arcs","owner":{"login":"PolymerLabs","id":5912903,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTI5MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/arcs","description":"Arcs aims to create an open ecosystem for privacy-preserving, AI-first computing.","fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2018-08-16T06:08:16Z","pushed_at":"2018-08-16T09:31:48Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":"","size":26173,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":152,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/1780"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/1780"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/1780/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/1780/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/ff170418c2f07f39f773c3dcab87b256769d60e2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shans"}}