{"action":"opened","number":29361,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361","id":212171637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTcxNjM3","html_url":"https://github.com/cockroachdb/cockroach/pull/29361","diff_url":"https://github.com/cockroachdb/cockroach/pull/29361.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/29361.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29361","number":29361,"state":"open","locked":false,"title":"storage: include summary of prereq batches in cmdQ logs/traces","user":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"body":"This change adds a summary of the batch requests that a command is waiting\r\non in the command queue to the trace event from before and after the command\r\nenters the queue. It turns the following two traces:\r\n\r\n```\r\nwaiting for 4 overlapping requests\r\nwaited 8.634716ms for overlapping requests\r\n```\r\n\r\ninto\r\n\r\n```\r\nwaiting for 4 overlapping requests: {write/local: [1 EndTxn], [1 EndTxn], [1 EndTxn], [1 EndTxn]}\r\nwaited 983.742µs for overlapping requests: {read/local: [1 CPut, 1 BeginTxn]} {write/local: [1 CPut, 1 BeginTxn]}\r\n```\r\n\r\nThis should improve our ability to understand command queue contention\r\nfrom traces or high-verbosity logs (`V(2)`).\r\n\r\nRelease note: None","created_at":"2018-08-30T18:33:00Z","updated_at":"2018-08-30T18:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29361/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d162d0eaba6ea19da140ee8fe8a35dc2504e45b8","head":{"label":"nvanbenschoten:nvanbenschoten/cmdSummary","ref":"nvanbenschoten/cmdSummary","sha":"d162d0eaba6ea19da140ee8fe8a35dc2504e45b8","user":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"repo":{"id":42610470,"node_id":"MDEwOlJlcG9zaXRvcnk0MjYxMDQ3MA==","name":"cockroach","full_name":"nvanbenschoten/cockroach","owner":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvanbenschoten/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach","forks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/forks","keys_url":"https://api.github.com/repos/nvanbenschoten/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvanbenschoten/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvanbenschoten/cockroach/teams","hooks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/hooks","issue_events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/events","assignees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/nvanbenschoten/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/tags","blobs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvanbenschoten/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/nvanbenschoten/cockroach/languages","stargazers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/stargazers","contributors_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contributors","subscribers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscribers","subscription_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscription","commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/nvanbenschoten/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvanbenschoten/cockroach/merges","archive_url":"https://api.github.com/repos/nvanbenschoten/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvanbenschoten/cockroach/downloads","issues_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/nvanbenschoten/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/nvanbenschoten/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/nvanbenschoten/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvanbenschoten/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/nvanbenschoten/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/deployments","created_at":"2015-09-16T20:04:21Z","updated_at":"2018-05-30T20:16:23Z","pushed_at":"2018-08-30T18:32:35Z","git_url":"git://github.com/nvanbenschoten/cockroach.git","ssh_url":"git@github.com:nvanbenschoten/cockroach.git","clone_url":"https://github.com/nvanbenschoten/cockroach.git","svn_url":"https://github.com/nvanbenschoten/cockroach","homepage":null,"size":533810,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"065d63d06230f54eb3cb1e3d2b1af37dfc496302","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-08-30T18:20:07Z","pushed_at":"2018-08-30T18:31:19Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1045882,"stargazers_count":14158,"watchers_count":14158,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1485,"mirror_url":null,"archived":false,"open_issues_count":1898,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1485,"open_issues":1898,"watchers":14158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/29361"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29361"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29361/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29361/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d162d0eaba6ea19da140ee8fe8a35dc2504e45b8"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":135,"deletions":40,"changed_files":5}}
{"actor":{"display_login":"nvanbenschoten"}}