{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/6196","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/6196/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6196/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/6196/events","html_url":"https://github.com/openssl/openssl/pull/6196","id":321093567,"number":6196,"title":"Don't fail on an out-of-order CCS in DTLS (1.1.0)","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-08T08:39:28Z","updated_at":"2018-05-08T20:28:53Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6196","html_url":"https://github.com/openssl/openssl/pull/6196","diff_url":"https://github.com/openssl/openssl/pull/6196.diff","patch_url":"https://github.com/openssl/openssl/pull/6196.patch"},"body":"This is the backport to 1.1.0 of #6170.\r\n\r\nFixes #4929\r\n\r\nWhile fixing this I encountered a number of other issues so I fixed those too:\r\n\r\n- Fix s_client and s_server so that they correctly handle the DTLS timer\r\n- Only auto-retry for DTLS if configured to do so (otherwise we may end up in a hang when using blocking sockets)\r\n- During a full handshake the server is the last one to \"speak\". The timer should continue to run until we know that the client has received our last flight (e.g. because we receive some application data).\r\n\r\nI did the work to backport the test and the test passed. However I have not included the test itself in this PR because it was running *very* slowly. The reason for this is that 1.1.0 does not have the feature required to set a custom timer callback. Therefore we have to use the default timeout period which is just too slow for running a test where we deliberately wait for lots of timeouts.\r\n\r\nPing @richsalz."},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/387532166","html_url":"https://github.com/openssl/openssl/pull/6196#issuecomment-387532166","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6196","id":387532166,"user":{"login":"jpujol","id":2039799,"avatar_url":"https://avatars3.githubusercontent.com/u/2039799?v=4","gravatar_id":"","url":"https://api.github.com/users/jpujol","html_url":"https://github.com/jpujol","followers_url":"https://api.github.com/users/jpujol/followers","following_url":"https://api.github.com/users/jpujol/following{/other_user}","gists_url":"https://api.github.com/users/jpujol/gists{/gist_id}","starred_url":"https://api.github.com/users/jpujol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpujol/subscriptions","organizations_url":"https://api.github.com/users/jpujol/orgs","repos_url":"https://api.github.com/users/jpujol/repos","events_url":"https://api.github.com/users/jpujol/events{/privacy}","received_events_url":"https://api.github.com/users/jpujol/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T20:28:53Z","updated_at":"2018-05-08T20:28:53Z","author_association":"NONE","body":"Apparently there are some unit tests that were disabled and caused this issue: \r\nhttps://github.com/openssl/openssl/blob/master/test/ossl_shim/ossl_config.json#L189\r\n\r\nCould they be enabled again?"}}
{"actor":{"display_login":"jpujol"}}