{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/180271198","pull_request_review_id":110663490,"id":180271198,"diff_hunk":"@@ -422,6 +481,12 @@ static int alc5658_getcaps(FAR struct audio_lowerhalf_s *dev, int type, FAR stru\n \tDEBUGASSERT(caps && caps->ac_len >= sizeof(struct audio_caps_s));\n \taudvdbg(\"type=%d ac_type=%d\\n\", type, caps->ac_type);\n \n+#ifndef CONFIG_DEBUG\n+\tif (!caps) {\n+\t\treturn -1;","path":"os/drivers/audio/alc5658.c","position":162,"original_position":162,"commit_id":"eff7d6b9513e572cfae1b74236fef30bde5c91a5","original_commit_id":"eff7d6b9513e572cfae1b74236fef30bde5c91a5","user":{"login":"girishks2000","id":25973632,"avatar_url":"https://avatars1.githubusercontent.com/u/25973632?v=4","gravatar_id":"","url":"https://api.github.com/users/girishks2000","html_url":"https://github.com/girishks2000","followers_url":"https://api.github.com/users/girishks2000/followers","following_url":"https://api.github.com/users/girishks2000/following{/other_user}","gists_url":"https://api.github.com/users/girishks2000/gists{/gist_id}","starred_url":"https://api.github.com/users/girishks2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishks2000/subscriptions","organizations_url":"https://api.github.com/users/girishks2000/orgs","repos_url":"https://api.github.com/users/girishks2000/repos","events_url":"https://api.github.com/users/girishks2000/events{/privacy}","received_events_url":"https://api.github.com/users/girishks2000/received_events","type":"User","site_admin":false},"body":"I checked this part. Actually it returns a count during success. I.e. caps->ac_len. So I return negative len instead of FAIL and ERROR","created_at":"2018-04-10T00:55:13Z","updated_at":"2018-04-10T00:55:13Z","html_url":"https://github.com/Samsung/TizenRT/pull/1425#discussion_r180271198","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/180271198"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1425#discussion_r180271198"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425"}},"in_reply_to_id":180133245},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425","id":179303842,"html_url":"https://github.com/Samsung/TizenRT/pull/1425","diff_url":"https://github.com/Samsung/TizenRT/pull/1425.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/1425.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1425","number":1425,"state":"open","locked":false,"title":"audio: alc: Handle the NULL pointer exception","user":{"login":"girishks2000","id":25973632,"avatar_url":"https://avatars1.githubusercontent.com/u/25973632?v=4","gravatar_id":"","url":"https://api.github.com/users/girishks2000","html_url":"https://github.com/girishks2000","followers_url":"https://api.github.com/users/girishks2000/followers","following_url":"https://api.github.com/users/girishks2000/following{/other_user}","gists_url":"https://api.github.com/users/girishks2000/gists{/gist_id}","starred_url":"https://api.github.com/users/girishks2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishks2000/subscriptions","organizations_url":"https://api.github.com/users/girishks2000/orgs","repos_url":"https://api.github.com/users/girishks2000/repos","events_url":"https://api.github.com/users/girishks2000/events{/privacy}","received_events_url":"https://api.github.com/users/girishks2000/received_events","type":"User","site_admin":false},"body":"This patch checks / validates the pointer validity before access.\r\nThe system might crash if addresses are not validated before use.\r\n\r\nSigned-off-by: Girish K S <ks.giri@samsung.com>","created_at":"2018-04-04T07:29:40Z","updated_at":"2018-04-10T00:55:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9c96c65f64a8efedf017ad76b92ea742eb43899","assignee":null,"assignees":[],"requested_reviewers":[{"login":"btheosam","id":25811400,"avatar_url":"https://avatars3.githubusercontent.com/u/25811400?v=4","gravatar_id":"","url":"https://api.github.com/users/btheosam","html_url":"https://github.com/btheosam","followers_url":"https://api.github.com/users/btheosam/followers","following_url":"https://api.github.com/users/btheosam/following{/other_user}","gists_url":"https://api.github.com/users/btheosam/gists{/gist_id}","starred_url":"https://api.github.com/users/btheosam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btheosam/subscriptions","organizations_url":"https://api.github.com/users/btheosam/orgs","repos_url":"https://api.github.com/users/btheosam/repos","events_url":"https://api.github.com/users/btheosam/events{/privacy}","received_events_url":"https://api.github.com/users/btheosam/received_events","type":"User","site_admin":false},{"login":"Taejun-Kwon","id":25811447,"avatar_url":"https://avatars1.githubusercontent.com/u/25811447?v=4","gravatar_id":"","url":"https://api.github.com/users/Taejun-Kwon","html_url":"https://github.com/Taejun-Kwon","followers_url":"https://api.github.com/users/Taejun-Kwon/followers","following_url":"https://api.github.com/users/Taejun-Kwon/following{/other_user}","gists_url":"https://api.github.com/users/Taejun-Kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/Taejun-Kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taejun-Kwon/subscriptions","organizations_url":"https://api.github.com/users/Taejun-Kwon/orgs","repos_url":"https://api.github.com/users/Taejun-Kwon/repos","events_url":"https://api.github.com/users/Taejun-Kwon/events{/privacy}","received_events_url":"https://api.github.com/users/Taejun-Kwon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1425/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/eff7d6b9513e572cfae1b74236fef30bde5c91a5","head":{"label":"girishks2000:master","ref":"master","sha":"eff7d6b9513e572cfae1b74236fef30bde5c91a5","user":{"login":"girishks2000","id":25973632,"avatar_url":"https://avatars1.githubusercontent.com/u/25973632?v=4","gravatar_id":"","url":"https://api.github.com/users/girishks2000","html_url":"https://github.com/girishks2000","followers_url":"https://api.github.com/users/girishks2000/followers","following_url":"https://api.github.com/users/girishks2000/following{/other_user}","gists_url":"https://api.github.com/users/girishks2000/gists{/gist_id}","starred_url":"https://api.github.com/users/girishks2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishks2000/subscriptions","organizations_url":"https://api.github.com/users/girishks2000/orgs","repos_url":"https://api.github.com/users/girishks2000/repos","events_url":"https://api.github.com/users/girishks2000/events{/privacy}","received_events_url":"https://api.github.com/users/girishks2000/received_events","type":"User","site_admin":false},"repo":{"id":128022255,"name":"TizenRT","full_name":"girishks2000/TizenRT","owner":{"login":"girishks2000","id":25973632,"avatar_url":"https://avatars1.githubusercontent.com/u/25973632?v=4","gravatar_id":"","url":"https://api.github.com/users/girishks2000","html_url":"https://github.com/girishks2000","followers_url":"https://api.github.com/users/girishks2000/followers","following_url":"https://api.github.com/users/girishks2000/following{/other_user}","gists_url":"https://api.github.com/users/girishks2000/gists{/gist_id}","starred_url":"https://api.github.com/users/girishks2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishks2000/subscriptions","organizations_url":"https://api.github.com/users/girishks2000/orgs","repos_url":"https://api.github.com/users/girishks2000/repos","events_url":"https://api.github.com/users/girishks2000/events{/privacy}","received_events_url":"https://api.github.com/users/girishks2000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/girishks2000/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/girishks2000/TizenRT","forks_url":"https://api.github.com/repos/girishks2000/TizenRT/forks","keys_url":"https://api.github.com/repos/girishks2000/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girishks2000/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girishks2000/TizenRT/teams","hooks_url":"https://api.github.com/repos/girishks2000/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/girishks2000/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/girishks2000/TizenRT/events","assignees_url":"https://api.github.com/repos/girishks2000/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/girishks2000/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/girishks2000/TizenRT/tags","blobs_url":"https://api.github.com/repos/girishks2000/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girishks2000/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girishks2000/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/girishks2000/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girishks2000/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/girishks2000/TizenRT/languages","stargazers_url":"https://api.github.com/repos/girishks2000/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/girishks2000/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/girishks2000/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/girishks2000/TizenRT/subscription","commits_url":"https://api.github.com/repos/girishks2000/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/girishks2000/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/girishks2000/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/girishks2000/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/girishks2000/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/girishks2000/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girishks2000/TizenRT/merges","archive_url":"https://api.github.com/repos/girishks2000/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girishks2000/TizenRT/downloads","issues_url":"https://api.github.com/repos/girishks2000/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/girishks2000/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/girishks2000/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/girishks2000/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girishks2000/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/girishks2000/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/girishks2000/TizenRT/deployments","created_at":"2018-04-04T07:10:54Z","updated_at":"2018-04-09T04:19:54Z","pushed_at":"2018-04-09T04:19:52Z","git_url":"git://github.com/girishks2000/TizenRT.git","ssh_url":"git@github.com:girishks2000/TizenRT.git","clone_url":"https://github.com/girishks2000/TizenRT.git","svn_url":"https://github.com/girishks2000/TizenRT","homepage":"","size":92821,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"f57364197b1c10756f5b8d6bfae44fd28907cc2e","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"name":"TizenRT","full_name":"Samsung/TizenRT","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-04-09T09:47:46Z","pushed_at":"2018-04-09T14:11:31Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":93589,"stargazers_count":138,"watchers_count":138,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":35,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1425"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1425"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/eff7d6b9513e572cfae1b74236fef30bde5c91a5"}},"author_association":"NONE"}}
{"actor":{"display_login":"girishks2000"}}