{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/176701335","pull_request_review_id":106451164,"id":176701335,"diff_hunk":"@@ -0,0 +1,146 @@\n+import operator\n+\n+import numpy as np\n+import pytest\n+\n+import pandas as pd\n+import pandas.util.testing as tm\n+from .base import BaseExtensionTests\n+\n+\n+class BaseSetitemTests(BaseExtensionTests):\n+    def test_setitem_scalar_series(self, data):\n+        arr = pd.Series(data)\n+        arr[0] = data[1]\n+        assert arr[0] == data[1]\n+\n+    def test_setitem_sequence(self, data):\n+        arr = pd.Series(data)\n+        original = data.copy()\n+\n+        arr[[0, 1]] = [data[1], data[0]]\n+        assert arr[0] == original[1]\n+        assert arr[1] == original[0]\n+\n+    @pytest.mark.parametrize('as_array', [True, False])\n+    def test_setitem_sequence_mismatched_length_raises(self, data, as_array):\n+        ser = pd.Series(data)\n+        value = [data[0]]\n+        if as_array:\n+            value = type(data)(value)\n+\n+        xpr = 'cannot set using a {} indexer with a different length'\n+        with tm.assert_raises_regex(ValueError, xpr.format('list-like')):\n+            ser[[0, 1]] = value\n+\n+        with tm.assert_raises_regex(ValueError, xpr.format('slice')):\n+            ser[slice(3)] = value\n+\n+    def test_setitem_empty_indxer(self, data):\n+        ser = pd.Series(data)\n+        original = ser.copy()\n+        ser[[]] = []\n+        self.assert_series_equal(ser, original)\n+\n+    def test_setitem_sequence_broadcasts(self, data):\n+        arr = pd.Series(data)\n+\n+        arr[[0, 1]] = data[2]\n+        assert arr[0] == data[2]\n+        assert arr[1] == data[2]\n+\n+    @pytest.mark.parametrize('setter', ['loc', 'iloc'])\n+    def test_set_scalar(self, data, setter):\n+        arr = pd.Series(data)\n+        setter = getattr(arr, setter)\n+        operator.setitem(setter, 0, data[1])\n+        assert arr[0] == data[1]\n+\n+    def test_set_loc_scalar_mixed(self, data):\n+        df = pd.DataFrame({\"A\": np.arange(len(data)), \"B\": data})\n+        df.loc[0, 'B'] = data[1]\n+        assert df.loc[0, 'B'] == data[1]\n+\n+    def test_set_loc_scalar_single(self, data):\n+        df = pd.DataFrame({\"B\": data})\n+        df.loc[10, 'B'] = data[1]\n+        assert df.loc[10, 'B'] == data[1]\n+\n+    def test_set_loc_scalar_multiple_homogoneous(self, data):\n+        df = pd.DataFrame({\"A\": data, \"B\": data})\n+        df.loc[10, 'B'] = data[1]\n+        assert df.loc[10, 'B'] == data[1]\n+\n+    def test_set_iloc_scalar_mixed(self, data):\n+        df = pd.DataFrame({\"A\": np.arange(len(data)), \"B\": data})\n+        df.iloc[0, 1] = data[1]\n+        assert df.loc[0, 'B'] == data[1]\n+\n+    def test_set_iloc_scalar_single(self, data):\n+        df = pd.DataFrame({\"B\": data})\n+        df.iloc[10, 0] = data[1]\n+        assert df.loc[10, 'B'] == data[1]\n+\n+    def test_set_iloc_scalar_multiple_homogoneous(self, data):\n+        df = pd.DataFrame({\"A\": data, \"B\": data})\n+        df.iloc[10, 1] = data[1]\n+        assert df.loc[10, 'B'] == data[1]\n+\n+    @pytest.mark.parametrize('as_callable', [True, False])\n+    def test_set_mask_aligned(self, data, as_callable):","path":"pandas/tests/extension/base/setitem.py","position":90,"original_position":90,"commit_id":"f47ddf27ef2d776e9527843494478c6637e18ba7","original_commit_id":"f47ddf27ef2d776e9527843494478c6637e18ba7","user":{"login":"jorisvandenbossche","id":1020496,"avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"or parametrize this for setitem and loc?","created_at":"2018-03-23T11:00:41Z","updated_at":"2018-03-23T11:03:36Z","html_url":"https://github.com/pandas-dev/pandas/pull/19907#discussion_r176701335","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/176701335"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19907#discussion_r176701335"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907","id":171417768,"html_url":"https://github.com/pandas-dev/pandas/pull/19907","diff_url":"https://github.com/pandas-dev/pandas/pull/19907.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19907.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19907","number":19907,"state":"open","locked":false,"title":"ENH: ExtensionArray.setitem","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"xref https://github.com/pandas-dev/pandas/issues/19696\r\n\r\nAdds `ExtensionBlock.__setitem__`.\r\n\r\nThis is only tested for with `DecimalArray` and `Categorical`. Supporting something like `JSONArray` where the \"scalar\" elements are actual sequences runs into issues elsewhere in internals. Maybe someday we can support that.","created_at":"2018-02-26T16:05:47Z","updated_at":"2018-03-23T11:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c306a3575e30c7423bbc885708d671ac6d181503","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":849023693,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/ExtensionArray","name":"ExtensionArray","color":"6138b5","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/53","html_url":"https://github.com/pandas-dev/pandas/milestone/53","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/53/labels","id":2853937,"number":53,"title":"0.23.0","description":"after 0.22","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":152,"closed_issues":1320,"state":"open","created_at":"2017-10-20T10:17:09Z","updated_at":"2018-03-23T10:34:08Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19907/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/f47ddf27ef2d776e9527843494478c6637e18ba7","head":{"label":"TomAugspurger:fu1+set","ref":"fu1+set","sha":"f47ddf27ef2d776e9527843494478c6637e18ba7","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"repo":{"id":9450481,"name":"pandas","full_name":"TomAugspurger/pandas","owner":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomAugspurger/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/TomAugspurger/pandas","forks_url":"https://api.github.com/repos/TomAugspurger/pandas/forks","keys_url":"https://api.github.com/repos/TomAugspurger/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomAugspurger/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomAugspurger/pandas/teams","hooks_url":"https://api.github.com/repos/TomAugspurger/pandas/hooks","issue_events_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/TomAugspurger/pandas/events","assignees_url":"https://api.github.com/repos/TomAugspurger/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/TomAugspurger/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/TomAugspurger/pandas/tags","blobs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomAugspurger/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomAugspurger/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomAugspurger/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/TomAugspurger/pandas/languages","stargazers_url":"https://api.github.com/repos/TomAugspurger/pandas/stargazers","contributors_url":"https://api.github.com/repos/TomAugspurger/pandas/contributors","subscribers_url":"https://api.github.com/repos/TomAugspurger/pandas/subscribers","subscription_url":"https://api.github.com/repos/TomAugspurger/pandas/subscription","commits_url":"https://api.github.com/repos/TomAugspurger/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomAugspurger/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomAugspurger/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomAugspurger/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/TomAugspurger/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomAugspurger/pandas/merges","archive_url":"https://api.github.com/repos/TomAugspurger/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomAugspurger/pandas/downloads","issues_url":"https://api.github.com/repos/TomAugspurger/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/TomAugspurger/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/TomAugspurger/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/TomAugspurger/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomAugspurger/pandas/labels{/name}","releases_url":"https://api.github.com/repos/TomAugspurger/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/TomAugspurger/pandas/deployments","created_at":"2013-04-15T14:23:40Z","updated_at":"2017-04-20T12:53:33Z","pushed_at":"2018-03-22T19:45:08Z","git_url":"git://github.com/TomAugspurger/pandas.git","ssh_url":"git@github.com:TomAugspurger/pandas.git","clone_url":"https://github.com/TomAugspurger/pandas.git","svn_url":"https://github.com/TomAugspurger/pandas","homepage":"http://pandas.pydata.org","size":122510,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"17c1fadb06bc8f48828e17e603a4d6228a02d73c","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-03-23T10:39:58Z","pushed_at":"2018-03-23T10:18:53Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":120245,"stargazers_count":13561,"watchers_count":13561,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5508,"mirror_url":null,"archived":false,"open_issues_count":2486,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5508,"open_issues":2486,"watchers":13561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19907"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19907"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19907/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19907/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/f47ddf27ef2d776e9527843494478c6637e18ba7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorisvandenbossche"}}