{"action":"created","comment":{"url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/comments/222821401","pull_request_review_id":161803041,"id":222821401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjgyMTQwMQ==","diff_hunk":"@@ -560,8 +560,8 @@ uint32_t getTimerIrq(TIM_TypeDef* tim)\n void TimerHandleDeinit(stimer_t *obj)\n {\n   if(obj != NULL) {\n-    HAL_TIM_Base_DeInit(&(obj->handle));","path":"cores/arduino/stm32/timer.c","position":4,"original_position":4,"commit_id":"5b7c75dc17a0f02622638e8409aafb2d3713972a","original_commit_id":"5b7c75dc17a0f02622638e8409aafb2d3713972a","user":{"login":"edogaldo","id":20240750,"node_id":"MDQ6VXNlcjIwMjQwNzUw","avatar_url":"https://avatars3.githubusercontent.com/u/20240750?v=4","gravatar_id":"","url":"https://api.github.com/users/edogaldo","html_url":"https://github.com/edogaldo","followers_url":"https://api.github.com/users/edogaldo/followers","following_url":"https://api.github.com/users/edogaldo/following{/other_user}","gists_url":"https://api.github.com/users/edogaldo/gists{/gist_id}","starred_url":"https://api.github.com/users/edogaldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edogaldo/subscriptions","organizations_url":"https://api.github.com/users/edogaldo/orgs","repos_url":"https://api.github.com/users/edogaldo/repos","events_url":"https://api.github.com/users/edogaldo/events{/privacy}","received_events_url":"https://api.github.com/users/edogaldo/received_events","type":"User","site_admin":false},"body":"I think this should be fixed independently on this PR..","created_at":"2018-10-04T20:46:17Z","updated_at":"2018-10-04T20:46:17Z","html_url":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344#discussion_r222821401","pull_request_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/comments/222821401"},"html":{"href":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344#discussion_r222821401"},"pull_request":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344"}}},"pull_request":{"url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344","id":219304827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzA0ODI3","html_url":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344","diff_url":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344.diff","patch_url":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344.patch","issue_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/344","number":344,"state":"open","locked":false,"title":"CDC implementation","user":{"login":"hasenbanck","id":12084860,"node_id":"MDQ6VXNlcjEyMDg0ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/12084860?v=4","gravatar_id":"","url":"https://api.github.com/users/hasenbanck","html_url":"https://github.com/hasenbanck","followers_url":"https://api.github.com/users/hasenbanck/followers","following_url":"https://api.github.com/users/hasenbanck/following{/other_user}","gists_url":"https://api.github.com/users/hasenbanck/gists{/gist_id}","starred_url":"https://api.github.com/users/hasenbanck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasenbanck/subscriptions","organizations_url":"https://api.github.com/users/hasenbanck/orgs","repos_url":"https://api.github.com/users/hasenbanck/repos","events_url":"https://api.github.com/users/hasenbanck/events{/privacy}","received_events_url":"https://api.github.com/users/hasenbanck/received_events","type":"User","site_admin":false},"body":"I ported the CDC implementation from the old USB rework PR to the current core.\r\n\r\nFollowing things were done:\r\n * Added some timer related components to the core libraries\r\n * Added the USBSerial library\r\n * Reworked the variant specific USB files\r\n * Updated the STM32 USB Device core and CDC libraries\r\n * Removed some unneeded files\r\n\r\nThis version works currently fine under RemRam V1 with a baudrate of 115200.\r\n\r\n@fpistm It's up to you how to proceed. I of course would like to have these changes as fast as possible upstream, but if you want to rework the general approach anyhow, this PR can also solely as a reference for you later on.","created_at":"2018-10-01T09:07:13Z","updated_at":"2018-10-04T20:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61ae283c9e62e88becc1f9cf3133212a7b042cfe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fpistm","id":20641798,"node_id":"MDQ6VXNlcjIwNjQxNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/20641798?v=4","gravatar_id":"","url":"https://api.github.com/users/fpistm","html_url":"https://github.com/fpistm","followers_url":"https://api.github.com/users/fpistm/followers","following_url":"https://api.github.com/users/fpistm/following{/other_user}","gists_url":"https://api.github.com/users/fpistm/gists{/gist_id}","starred_url":"https://api.github.com/users/fpistm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpistm/subscriptions","organizations_url":"https://api.github.com/users/fpistm/orgs","repos_url":"https://api.github.com/users/fpistm/repos","events_url":"https://api.github.com/users/fpistm/events{/privacy}","received_events_url":"https://api.github.com/users/fpistm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344/commits","review_comments_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344/comments","review_comment_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/344/comments","statuses_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/statuses/5b7c75dc17a0f02622638e8409aafb2d3713972a","head":{"label":"hasenbanck:cdc-implementation","ref":"cdc-implementation","sha":"5b7c75dc17a0f02622638e8409aafb2d3713972a","user":{"login":"hasenbanck","id":12084860,"node_id":"MDQ6VXNlcjEyMDg0ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/12084860?v=4","gravatar_id":"","url":"https://api.github.com/users/hasenbanck","html_url":"https://github.com/hasenbanck","followers_url":"https://api.github.com/users/hasenbanck/followers","following_url":"https://api.github.com/users/hasenbanck/following{/other_user}","gists_url":"https://api.github.com/users/hasenbanck/gists{/gist_id}","starred_url":"https://api.github.com/users/hasenbanck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasenbanck/subscriptions","organizations_url":"https://api.github.com/users/hasenbanck/orgs","repos_url":"https://api.github.com/users/hasenbanck/repos","events_url":"https://api.github.com/users/hasenbanck/events{/privacy}","received_events_url":"https://api.github.com/users/hasenbanck/received_events","type":"User","site_admin":false},"repo":{"id":133970948,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NzA5NDg=","name":"Arduino_Core_STM32","full_name":"hasenbanck/Arduino_Core_STM32","private":false,"owner":{"login":"hasenbanck","id":12084860,"node_id":"MDQ6VXNlcjEyMDg0ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/12084860?v=4","gravatar_id":"","url":"https://api.github.com/users/hasenbanck","html_url":"https://github.com/hasenbanck","followers_url":"https://api.github.com/users/hasenbanck/followers","following_url":"https://api.github.com/users/hasenbanck/following{/other_user}","gists_url":"https://api.github.com/users/hasenbanck/gists{/gist_id}","starred_url":"https://api.github.com/users/hasenbanck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasenbanck/subscriptions","organizations_url":"https://api.github.com/users/hasenbanck/orgs","repos_url":"https://api.github.com/users/hasenbanck/repos","events_url":"https://api.github.com/users/hasenbanck/events{/privacy}","received_events_url":"https://api.github.com/users/hasenbanck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hasenbanck/Arduino_Core_STM32","description":"RemRam board variant for the STM32 core in Arduino ","fork":true,"url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32","forks_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/forks","keys_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/teams","hooks_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/hooks","issue_events_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/issues/events{/number}","events_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/events","assignees_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/assignees{/user}","branches_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/branches{/branch}","tags_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/tags","blobs_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/git/refs{/sha}","trees_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/statuses/{sha}","languages_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/languages","stargazers_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/stargazers","contributors_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/contributors","subscribers_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/subscribers","subscription_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/subscription","commits_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/commits{/sha}","git_commits_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/git/commits{/sha}","comments_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/comments{/number}","issue_comment_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/issues/comments{/number}","contents_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/contents/{+path}","compare_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/merges","archive_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/downloads","issues_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/issues{/number}","pulls_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/pulls{/number}","milestones_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/milestones{/number}","notifications_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/labels{/name}","releases_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/releases{/id}","deployments_url":"https://api.github.com/repos/hasenbanck/Arduino_Core_STM32/deployments","created_at":"2018-05-18T15:15:44Z","updated_at":"2018-10-02T06:47:38Z","pushed_at":"2018-10-04T14:33:48Z","git_url":"git://github.com/hasenbanck/Arduino_Core_STM32.git","ssh_url":"git@github.com:hasenbanck/Arduino_Core_STM32.git","clone_url":"https://github.com/hasenbanck/Arduino_Core_STM32.git","svn_url":"https://github.com/hasenbanck/Arduino_Core_STM32","homepage":"","size":22051,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"cdc-implementation"}},"base":{"label":"stm32duino:master","ref":"master","sha":"e872a357aed81a2eb93e2f134a94e073160b5f52","user":{"login":"stm32duino","id":12180191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTgwMTkx","avatar_url":"https://avatars0.githubusercontent.com/u/12180191?v=4","gravatar_id":"","url":"https://api.github.com/users/stm32duino","html_url":"https://github.com/stm32duino","followers_url":"https://api.github.com/users/stm32duino/followers","following_url":"https://api.github.com/users/stm32duino/following{/other_user}","gists_url":"https://api.github.com/users/stm32duino/gists{/gist_id}","starred_url":"https://api.github.com/users/stm32duino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stm32duino/subscriptions","organizations_url":"https://api.github.com/users/stm32duino/orgs","repos_url":"https://api.github.com/users/stm32duino/repos","events_url":"https://api.github.com/users/stm32duino/events{/privacy}","received_events_url":"https://api.github.com/users/stm32duino/received_events","type":"Organization","site_admin":false},"repo":{"id":90867899,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2Nzg5OQ==","name":"Arduino_Core_STM32","full_name":"stm32duino/Arduino_Core_STM32","private":false,"owner":{"login":"stm32duino","id":12180191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTgwMTkx","avatar_url":"https://avatars0.githubusercontent.com/u/12180191?v=4","gravatar_id":"","url":"https://api.github.com/users/stm32duino","html_url":"https://github.com/stm32duino","followers_url":"https://api.github.com/users/stm32duino/followers","following_url":"https://api.github.com/users/stm32duino/following{/other_user}","gists_url":"https://api.github.com/users/stm32duino/gists{/gist_id}","starred_url":"https://api.github.com/users/stm32duino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stm32duino/subscriptions","organizations_url":"https://api.github.com/users/stm32duino/orgs","repos_url":"https://api.github.com/users/stm32duino/repos","events_url":"https://api.github.com/users/stm32duino/events{/privacy}","received_events_url":"https://api.github.com/users/stm32duino/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stm32duino/Arduino_Core_STM32","description":"STM32 core support for Arduino","fork":false,"url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32","forks_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/forks","keys_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/teams","hooks_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/hooks","issue_events_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/events{/number}","events_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/events","assignees_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/assignees{/user}","branches_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/branches{/branch}","tags_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/tags","blobs_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/git/refs{/sha}","trees_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/statuses/{sha}","languages_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/languages","stargazers_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/stargazers","contributors_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/contributors","subscribers_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/subscribers","subscription_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/subscription","commits_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/commits{/sha}","git_commits_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/git/commits{/sha}","comments_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/comments{/number}","issue_comment_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/comments{/number}","contents_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/contents/{+path}","compare_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/merges","archive_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/downloads","issues_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues{/number}","pulls_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls{/number}","milestones_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/milestones{/number}","notifications_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/labels{/name}","releases_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/releases{/id}","deployments_url":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/deployments","created_at":"2017-05-10T13:32:55Z","updated_at":"2018-10-04T18:24:57Z","pushed_at":"2018-10-04T14:34:46Z","git_url":"git://github.com/stm32duino/Arduino_Core_STM32.git","ssh_url":"git@github.com:stm32duino/Arduino_Core_STM32.git","clone_url":"https://github.com/stm32duino/Arduino_Core_STM32.git","svn_url":"https://github.com/stm32duino/Arduino_Core_STM32","homepage":"","size":22014,"stargazers_count":214,"watchers_count":214,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":100,"open_issues":39,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344"},"html":{"href":"https://github.com/stm32duino/Arduino_Core_STM32/pull/344"},"issue":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/344"},"comments":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/stm32duino/Arduino_Core_STM32/statuses/5b7c75dc17a0f02622638e8409aafb2d3713972a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edogaldo"}}