{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/167959241","pull_request_review_id":96246794,"id":167959241,"diff_hunk":"@@ -1759,18 +1765,18 @@ export function getDirectiveInstance<T>(instanceOrArray: T | [T]): T {\n }\n \n export function assertPreviousIsParent() {\n-  assertEqual(isParent, true, 'isParent');\n+  assertEqual(isParent, true, 'previousOrParentNode should be a parent');\n }\n \n function assertHasParent() {\n-  assertNotEqual(previousOrParentNode.parent, null, 'isParent');\n+  assertNotNull(previousOrParentNode, 'should have a parent');","path":"packages/core/src/render3/instructions.ts","position":148,"original_position":148,"commit_id":"d827b88f89101ba670eeaecd6eaef6b88af8b01a","original_commit_id":"d827b88f89101ba670eeaecd6eaef6b88af8b01a","user":{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},"body":"`previousOrParentNode should have a parent`","created_at":"2018-02-13T18:34:02Z","updated_at":"2018-02-13T18:35:40Z","html_url":"https://github.com/angular/angular/pull/22189#discussion_r167959241","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/22189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/167959241"},"html":{"href":"https://github.com/angular/angular/pull/22189#discussion_r167959241"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/22189"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/22189","id":168766309,"html_url":"https://github.com/angular/angular/pull/22189","diff_url":"https://github.com/angular/angular/pull/22189.diff","patch_url":"https://github.com/angular/angular/pull/22189.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/22189","number":22189,"state":"open","locked":false,"title":"refactor(ivy): assertion","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"Encourage the use of message to explain the assertion\r\n\r\nNote: the messages in this PR are as good as it was possible to do with my current understanding & fast enough.","created_at":"2018-02-13T06:47:24Z","updated_at":"2018-02-13T18:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc98aed0b41c338ae80f368707be4287b3283877","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mhevery","id":111951,"avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":660621334,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":799860804,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false},{"id":218430644,"url":"https://api.github.com/repos/angular/angular/labels/type:%20refactor","name":"type: refactor","color":"EEEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/22189/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/22189/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/22189/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/d827b88f89101ba670eeaecd6eaef6b88af8b01a","head":{"label":"vicb:0212-assert","ref":"0212-assert","sha":"d827b88f89101ba670eeaecd6eaef6b88af8b01a","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"repo":{"id":24640725,"name":"angular","full_name":"vicb/angular","owner":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicb/angular","description":null,"fork":true,"url":"https://api.github.com/repos/vicb/angular","forks_url":"https://api.github.com/repos/vicb/angular/forks","keys_url":"https://api.github.com/repos/vicb/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicb/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicb/angular/teams","hooks_url":"https://api.github.com/repos/vicb/angular/hooks","issue_events_url":"https://api.github.com/repos/vicb/angular/issues/events{/number}","events_url":"https://api.github.com/repos/vicb/angular/events","assignees_url":"https://api.github.com/repos/vicb/angular/assignees{/user}","branches_url":"https://api.github.com/repos/vicb/angular/branches{/branch}","tags_url":"https://api.github.com/repos/vicb/angular/tags","blobs_url":"https://api.github.com/repos/vicb/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicb/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicb/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicb/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicb/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/vicb/angular/languages","stargazers_url":"https://api.github.com/repos/vicb/angular/stargazers","contributors_url":"https://api.github.com/repos/vicb/angular/contributors","subscribers_url":"https://api.github.com/repos/vicb/angular/subscribers","subscription_url":"https://api.github.com/repos/vicb/angular/subscription","commits_url":"https://api.github.com/repos/vicb/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicb/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicb/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicb/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/vicb/angular/contents/{+path}","compare_url":"https://api.github.com/repos/vicb/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicb/angular/merges","archive_url":"https://api.github.com/repos/vicb/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicb/angular/downloads","issues_url":"https://api.github.com/repos/vicb/angular/issues{/number}","pulls_url":"https://api.github.com/repos/vicb/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/vicb/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/vicb/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicb/angular/labels{/name}","releases_url":"https://api.github.com/repos/vicb/angular/releases{/id}","deployments_url":"https://api.github.com/repos/vicb/angular/deployments","created_at":"2014-09-30T14:12:47Z","updated_at":"2017-05-03T03:16:45Z","pushed_at":"2018-02-13T18:03:38Z","git_url":"git://github.com/vicb/angular.git","ssh_url":"git@github.com:vicb/angular.git","clone_url":"https://github.com/vicb/angular.git","svn_url":"https://github.com/vicb/angular","homepage":"https://angular.io","size":71824,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"eb487507055714d923dcc93857f23baabc228e11","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-02-13T18:21:45Z","pushed_at":"2018-02-13T18:27:15Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":73690,"stargazers_count":33035,"watchers_count":33035,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8168,"mirror_url":null,"archived":false,"open_issues_count":2136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8168,"open_issues":2136,"watchers":33035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/22189"},"html":{"href":"https://github.com/angular/angular/pull/22189"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/22189"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/22189/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/22189/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/22189/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/d827b88f89101ba670eeaecd6eaef6b88af8b01a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kara"}}