{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/taxdata/issues/265","repository_url":"https://api.github.com/repos/open-source-economics/taxdata","labels_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/265/comments","events_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/265/events","html_url":"https://github.com/open-source-economics/taxdata/pull/265","id":344144329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjA5Mjc1","number":265,"title":"Different test results on pr-261-MH branch","user":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-24T18:04:23Z","updated_at":"2018-07-25T13:37:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/265","html_url":"https://github.com/open-source-economics/taxdata/pull/265","diff_url":"https://github.com/open-source-economics/taxdata/pull/265.diff","patch_url":"https://github.com/open-source-economics/taxdata/pull/265.patch"},"body":"I'm getting different PUF test_data results on a local branch that includes the code changes in PR #261.\r\nHere is what I've done:\r\n1. Include all recent code changes on master branch in my local master branch\r\n2. Execute `make git-pr N=261`\r\n3. Execute `git merge master` to include recent master changes in the local copy of PR #261\r\n4. Execute `make puf_data/cps-matched-puf.csv`\r\n5. Execute `make puf_data/puf.csv`\r\n6. Execute `test_pufcsv_data`\r\n7. Copy  `puf_agg_actual.txt` to `puf_agg_expect.txt`\r\n\r\n@anderson, note the maximum `age_spouse` difference and others.\r\nHave I done something wrong?  Why are the test results different?\r\nCan it be that the `float_format='%.2f'` used to write the `cps-matched-puf.csv` file makes a difference?\r\nWhat version of pandas are you using?  I'm using 0.23.0 pandas.\r\nDo the `test_pufcsv_data` results I'm getting look \"fishy\" in any way?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/open-source-economics/taxdata/issues/comments/407756678","html_url":"https://github.com/open-source-economics/taxdata/pull/265#issuecomment-407756678","issue_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/265","id":407756678,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzc1NjY3OA==","user":{"login":"andersonfrailey","id":20684675,"node_id":"MDQ6VXNlcjIwNjg0Njc1","avatar_url":"https://avatars0.githubusercontent.com/u/20684675?v=4","gravatar_id":"","url":"https://api.github.com/users/andersonfrailey","html_url":"https://github.com/andersonfrailey","followers_url":"https://api.github.com/users/andersonfrailey/followers","following_url":"https://api.github.com/users/andersonfrailey/following{/other_user}","gists_url":"https://api.github.com/users/andersonfrailey/gists{/gist_id}","starred_url":"https://api.github.com/users/andersonfrailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersonfrailey/subscriptions","organizations_url":"https://api.github.com/users/andersonfrailey/orgs","repos_url":"https://api.github.com/users/andersonfrailey/repos","events_url":"https://api.github.com/users/andersonfrailey/events{/privacy}","received_events_url":"https://api.github.com/users/andersonfrailey/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T13:37:16Z","updated_at":"2018-07-25T13:37:16Z","author_association":"CONTRIBUTOR","body":"@martinholmer said:\r\n<If you can get the same results as I get when you use pandas 0.23.3 (the latest version), then I think we should consider changing the environment and conda recipe to pandas >= 0.23.3 and move on with our work. What do you think?\r\n\r\nI think that's sensible. I'll update to the latest version of Pandas and compare results."}}
{"actor":{"display_login":"andersonfrailey"}}