{"action":"created","issue":{"url":"https://api.github.com/repos/logrotate/logrotate/issues/192","repository_url":"https://api.github.com/repos/logrotate/logrotate","labels_url":"https://api.github.com/repos/logrotate/logrotate/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/logrotate/logrotate/issues/192/comments","events_url":"https://api.github.com/repos/logrotate/logrotate/issues/192/events","html_url":"https://github.com/logrotate/logrotate/pull/192","id":311345399,"number":192,"title":"Warn user if both size and the time interval options are used","user":{"login":"Burgos","id":1011833,"avatar_url":"https://avatars3.githubusercontent.com/u/1011833?v=4","gravatar_id":"","url":"https://api.github.com/users/Burgos","html_url":"https://github.com/Burgos","followers_url":"https://api.github.com/users/Burgos/followers","following_url":"https://api.github.com/users/Burgos/following{/other_user}","gists_url":"https://api.github.com/users/Burgos/gists{/gist_id}","starred_url":"https://api.github.com/users/Burgos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Burgos/subscriptions","organizations_url":"https://api.github.com/users/Burgos/orgs","repos_url":"https://api.github.com/users/Burgos/repos","events_url":"https://api.github.com/users/Burgos/events{/privacy}","received_events_url":"https://api.github.com/users/Burgos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-04T18:41:19Z","updated_at":"2018-04-27T15:03:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/logrotate/logrotate/pulls/192","html_url":"https://github.com/logrotate/logrotate/pull/192","diff_url":"https://github.com/logrotate/logrotate/pull/192.diff","patch_url":"https://github.com/logrotate/logrotate/pull/192.patch"},"body":"The documentation says (in the section for (max,min)size) that\r\nthe size option is mutually exclusive with the time interval option\r\nand it says:\r\n\r\n```\r\nThe related size option\r\nis similar except that it is mutually exclusive with the  time\r\ninterval  options, *and it causes log files to be rotated with-\r\nout regard for the last rotation time.*\r\n```\r\n\r\n(emphasis mine).\r\n\r\nThe emphasised bit of the sentence is not necessarily true - it is\r\ntrue _if the size option is specified after the time option_. If\r\nthe time option is specified after the size option, the logrotate\r\nwill rotate the files without regard for the size. In other words -\r\nthe last option specified in the config file wins.\r\n\r\nThis behaviour is dangerous, because the subtle change in the order\r\nof the configuration options changes the behaviour in the unexpected\r\nway.\r\n\r\nWe can't treat this behaviour as an error, since the chances are that\r\nthere are many logrotate config files deployed in the way that it works\r\nto the satisfactory degree, so that would be a breaking change. This\r\npatch makes logrotate to issue a warning if logrotate run in verbose mode."},"comment":{"url":"https://api.github.com/repos/logrotate/logrotate/issues/comments/384997620","html_url":"https://github.com/logrotate/logrotate/pull/192#issuecomment-384997620","issue_url":"https://api.github.com/repos/logrotate/logrotate/issues/192","id":384997620,"user":{"login":"Burgos","id":1011833,"avatar_url":"https://avatars3.githubusercontent.com/u/1011833?v=4","gravatar_id":"","url":"https://api.github.com/users/Burgos","html_url":"https://github.com/Burgos","followers_url":"https://api.github.com/users/Burgos/followers","following_url":"https://api.github.com/users/Burgos/following{/other_user}","gists_url":"https://api.github.com/users/Burgos/gists{/gist_id}","starred_url":"https://api.github.com/users/Burgos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Burgos/subscriptions","organizations_url":"https://api.github.com/users/Burgos/orgs","repos_url":"https://api.github.com/users/Burgos/repos","events_url":"https://api.github.com/users/Burgos/events{/privacy}","received_events_url":"https://api.github.com/users/Burgos/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T15:03:18Z","updated_at":"2018-04-27T15:03:18Z","author_association":"NONE","body":"@kdudka thank you for pointing that out, that's a bug in the implementation, so I'm not happy with it as well. I'll follow your advice, as it sounds reasonable and I'll update the man pages as well over the weekend. I'll let you know when I push the updated version."}}
{"actor":{"display_login":"Burgos"}}