{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments/224757386","pull_request_review_id":164206448,"id":224757386,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc1NzM4Ng==","diff_hunk":"@@ -2,11 +2,13 @@\n \n \t<label for=\"country\" class=\"o-forms__label\">Country</label>\n \n+\t{{#ncf-countries filterList=filterList}}\n \t<select id=\"country\" name=\"country\" class=\"o-forms__select js-field__input js-item__value\" data-trackable=\"field-billing-country\" aria-required=\"true\" required>\n-\t\t{{#each options as |option|}}\n-\t\t<option value=\"{{option.value}}\"{{#if ../value}}{{#ifEquals option.value ../value }} selected{{/ifEquals}}{{else}}{{#if option.isSelected}} selected{{/if}}{{/if}}>{{option.label}}</option>\n+\t\t{{#each countries as |country|}}\n+\t\t<option value=\"{{country.code}}\"{{#if ../value}}{{#ifEquals country.code ../value }} selected{{/ifEquals}}{{/if}}>{{country.name}}</option>","path":"partials/country.html","position":9,"original_position":9,"commit_id":"6cb897314e51c71a74a22277fe2c0078621efe7f","original_commit_id":"bf58f7de654d7ad122431b313188cc121b9e6413","user":{"login":"liamkeaton","id":1721150,"node_id":"MDQ6VXNlcjE3MjExNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1721150?v=4","gravatar_id":"","url":"https://api.github.com/users/liamkeaton","html_url":"https://github.com/liamkeaton","followers_url":"https://api.github.com/users/liamkeaton/followers","following_url":"https://api.github.com/users/liamkeaton/following{/other_user}","gists_url":"https://api.github.com/users/liamkeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/liamkeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamkeaton/subscriptions","organizations_url":"https://api.github.com/users/liamkeaton/orgs","repos_url":"https://api.github.com/users/liamkeaton/repos","events_url":"https://api.github.com/users/liamkeaton/events{/privacy}","received_events_url":"https://api.github.com/users/liamkeaton/received_events","type":"User","site_admin":false},"body":"For `b2b-prospect` forms as the data goes to Marketo we need to send the value as the full country string rather than an ISO. The more I think about this the more I feel we should do that in b2b-prospect to **fix** the data before sending to Marketo.","created_at":"2018-10-12T11:45:51Z","updated_at":"2018-10-12T11:45:51Z","html_url":"https://github.com/Financial-Times/n-conversion-forms/pull/44#discussion_r224757386","pull_request_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments/224757386"},"html":{"href":"https://github.com/Financial-Times/n-conversion-forms/pull/44#discussion_r224757386"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44"}},"in_reply_to_id":224475733},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44","id":222072224,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDcyMjI0","html_url":"https://github.com/Financial-Times/n-conversion-forms/pull/44","diff_url":"https://github.com/Financial-Times/n-conversion-forms/pull/44.diff","patch_url":"https://github.com/Financial-Times/n-conversion-forms/pull/44.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/44","number":44,"state":"closed","locked":false,"title":"Common data test helpers","user":{"login":"alexnaish","id":6599523,"node_id":"MDQ6VXNlcjY1OTk1MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/6599523?v=4","gravatar_id":"","url":"https://api.github.com/users/alexnaish","html_url":"https://github.com/alexnaish","followers_url":"https://api.github.com/users/alexnaish/followers","following_url":"https://api.github.com/users/alexnaish/following{/other_user}","gists_url":"https://api.github.com/users/alexnaish/gists{/gist_id}","starred_url":"https://api.github.com/users/alexnaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexnaish/subscriptions","organizations_url":"https://api.github.com/users/alexnaish/orgs","repos_url":"https://api.github.com/users/alexnaish/repos","events_url":"https://api.github.com/users/alexnaish/events{/privacy}","received_events_url":"https://api.github.com/users/alexnaish/received_events","type":"User","site_admin":false},"body":"## Feature Description\r\nAdd common-static-data helpers. Still need to create the partials.\r\n\r\n 🐿 v2.8.0\r\n","created_at":"2018-10-11T09:45:47Z","updated_at":"2018-10-12T11:45:51Z","closed_at":"2018-10-12T10:23:09Z","merged_at":"2018-10-12T10:23:09Z","merge_commit_sha":"d3095589868db30ca354cd88418f3683a1c17977","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/44/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/6cb897314e51c71a74a22277fe2c0078621efe7f","head":{"label":"Financial-Times:common-data-helpers","ref":"common-data-helpers","sha":"6cb897314e51c71a74a22277fe2c0078621efe7f","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":133928511,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjg1MTE=","name":"n-conversion-forms","full_name":"Financial-Times/n-conversion-forms","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/n-conversion-forms","description":"Shared components for all conversion forms.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms","forks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/deployments","created_at":"2018-05-18T08:49:07Z","updated_at":"2018-10-12T10:23:11Z","pushed_at":"2018-10-12T11:42:52Z","git_url":"git://github.com/Financial-Times/n-conversion-forms.git","ssh_url":"git@github.com:Financial-Times/n-conversion-forms.git","clone_url":"https://github.com/Financial-Times/n-conversion-forms.git","svn_url":"https://github.com/Financial-Times/n-conversion-forms","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"2783813c29e836617026f1f69911537cf568d290","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":133928511,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjg1MTE=","name":"n-conversion-forms","full_name":"Financial-Times/n-conversion-forms","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/n-conversion-forms","description":"Shared components for all conversion forms.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms","forks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/deployments","created_at":"2018-05-18T08:49:07Z","updated_at":"2018-10-12T10:23:11Z","pushed_at":"2018-10-12T11:42:52Z","git_url":"git://github.com/Financial-Times/n-conversion-forms.git","ssh_url":"git@github.com:Financial-Times/n-conversion-forms.git","clone_url":"https://github.com/Financial-Times/n-conversion-forms.git","svn_url":"https://github.com/Financial-Times/n-conversion-forms","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44"},"html":{"href":"https://github.com/Financial-Times/n-conversion-forms/pull/44"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/44"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/6cb897314e51c71a74a22277fe2c0078621efe7f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liamkeaton"}}