{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/node_exporter/pulls/comments/222623856","pull_request_review_id":161554443,"id":222623856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjYyMzg1Ng==","diff_hunk":"@@ -249,3 +242,19 @@ fileLoop:\n \t)\n \treturn nil\n }\n+\n+// helper: returns true if file contains unsupported timestamps\n+func checkUnsupportedTimestams(parsedFamilies map[string]*dto.MetricFamily, path string) bool {","path":"collector/textfile.go","position":39,"original_position":39,"commit_id":"d00f2e4c837feee1ab6290536d05f918a1a9d425","original_commit_id":"d00f2e4c837feee1ab6290536d05f918a1a9d425","user":{"login":"juliusv","id":538008,"node_id":"MDQ6VXNlcjUzODAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/538008?v=4","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"The function name `checkUnsupportedTimestams()` is misleading (besides missing a \"p\"), as the function does more than checking timestamps (it auto-fills missing help strings as well).\r\n\r\nMaybe still keep the existing loop in `Collect()` just for the help-autofilling, but pull out the timestamp-checking into a separate function? It does mean looping over all parsed metric families twice, but I think that's ok.","created_at":"2018-10-04T11:01:40Z","updated_at":"2018-10-04T11:01:40Z","html_url":"https://github.com/prometheus/node_exporter/pull/1084#discussion_r222623856","pull_request_url":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/comments/222623856"},"html":{"href":"https://github.com/prometheus/node_exporter/pull/1084#discussion_r222623856"},"pull_request":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084","id":217301100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzAxMTAw","html_url":"https://github.com/prometheus/node_exporter/pull/1084","diff_url":"https://github.com/prometheus/node_exporter/pull/1084.diff","patch_url":"https://github.com/prometheus/node_exporter/pull/1084.patch","issue_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1084","number":1084,"state":"open","locked":false,"title":"textfile: Remove continue with label","user":{"login":"MalloZup","id":10886597,"node_id":"MDQ6VXNlcjEwODg2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/10886597?v=4","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"body":"fix #838\r\n\r\ncodecoverage ( note that black is executed, red is not :smiley: )\r\n![screenshot from 2018-09-21 15-52-16](https://user-images.githubusercontent.com/10886597/45886961-c1ee8080-bdba-11e8-83ff-0fe6d5539f8d.png)\r\n\r\n\r\n@SuperQ @discordianfish for any infos feel free to ask. Thx","created_at":"2018-09-21T14:24:42Z","updated_at":"2018-10-04T11:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f39a5142797079538bcf8a4b7774877779ad67c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/prometheus/node_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1084/comments","statuses_url":"https://api.github.com/repos/prometheus/node_exporter/statuses/d00f2e4c837feee1ab6290536d05f918a1a9d425","head":{"label":"MalloZup:fix-continue","ref":"fix-continue","sha":"d00f2e4c837feee1ab6290536d05f918a1a9d425","user":{"login":"MalloZup","id":10886597,"node_id":"MDQ6VXNlcjEwODg2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/10886597?v=4","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"repo":{"id":148914433,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5MTQ0MzM=","name":"node_exporter","full_name":"MalloZup/node_exporter","private":false,"owner":{"login":"MalloZup","id":10886597,"node_id":"MDQ6VXNlcjEwODg2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/10886597?v=4","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MalloZup/node_exporter","description":"Exporter for machine metrics","fork":true,"url":"https://api.github.com/repos/MalloZup/node_exporter","forks_url":"https://api.github.com/repos/MalloZup/node_exporter/forks","keys_url":"https://api.github.com/repos/MalloZup/node_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MalloZup/node_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MalloZup/node_exporter/teams","hooks_url":"https://api.github.com/repos/MalloZup/node_exporter/hooks","issue_events_url":"https://api.github.com/repos/MalloZup/node_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/MalloZup/node_exporter/events","assignees_url":"https://api.github.com/repos/MalloZup/node_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/MalloZup/node_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/MalloZup/node_exporter/tags","blobs_url":"https://api.github.com/repos/MalloZup/node_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MalloZup/node_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MalloZup/node_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MalloZup/node_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MalloZup/node_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/MalloZup/node_exporter/languages","stargazers_url":"https://api.github.com/repos/MalloZup/node_exporter/stargazers","contributors_url":"https://api.github.com/repos/MalloZup/node_exporter/contributors","subscribers_url":"https://api.github.com/repos/MalloZup/node_exporter/subscribers","subscription_url":"https://api.github.com/repos/MalloZup/node_exporter/subscription","commits_url":"https://api.github.com/repos/MalloZup/node_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MalloZup/node_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MalloZup/node_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MalloZup/node_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/MalloZup/node_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/MalloZup/node_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MalloZup/node_exporter/merges","archive_url":"https://api.github.com/repos/MalloZup/node_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MalloZup/node_exporter/downloads","issues_url":"https://api.github.com/repos/MalloZup/node_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/MalloZup/node_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/MalloZup/node_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/MalloZup/node_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MalloZup/node_exporter/labels{/name}","releases_url":"https://api.github.com/repos/MalloZup/node_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/MalloZup/node_exporter/deployments","created_at":"2018-09-15T15:28:52Z","updated_at":"2018-09-21T08:44:13Z","pushed_at":"2018-09-21T13:35:22Z","git_url":"git://github.com/MalloZup/node_exporter.git","ssh_url":"git@github.com:MalloZup/node_exporter.git","clone_url":"https://github.com/MalloZup/node_exporter.git","svn_url":"https://github.com/MalloZup/node_exporter","homepage":"https://prometheus.io/","size":4190,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"4672ea1671b7adec0bfdd99339484bdeaa51f38b","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":9524057,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0MDU3","name":"node_exporter","full_name":"prometheus/node_exporter","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/node_exporter","description":"Exporter for machine metrics","fork":false,"url":"https://api.github.com/repos/prometheus/node_exporter","forks_url":"https://api.github.com/repos/prometheus/node_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/node_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/node_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/node_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/node_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/node_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/node_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/node_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/node_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/node_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/node_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/node_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/node_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/node_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/node_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/node_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/node_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/node_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/node_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/node_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/node_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/node_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/node_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/node_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/node_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/node_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/node_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/node_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/node_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/node_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/node_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/node_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/node_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/node_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/node_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/node_exporter/deployments","created_at":"2013-04-18T14:44:52Z","updated_at":"2018-10-04T09:07:12Z","pushed_at":"2018-10-04T10:39:41Z","git_url":"git://github.com/prometheus/node_exporter.git","ssh_url":"git@github.com:prometheus/node_exporter.git","clone_url":"https://github.com/prometheus/node_exporter.git","svn_url":"https://github.com/prometheus/node_exporter","homepage":"https://prometheus.io/","size":4200,"stargazers_count":2000,"watchers_count":2000,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":577,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":577,"open_issues":81,"watchers":2000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084"},"html":{"href":"https://github.com/prometheus/node_exporter/pull/1084"},"issue":{"href":"https://api.github.com/repos/prometheus/node_exporter/issues/1084"},"comments":{"href":"https://api.github.com/repos/prometheus/node_exporter/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/node_exporter/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/node_exporter/statuses/d00f2e4c837feee1ab6290536d05f918a1a9d425"}},"author_association":"NONE"}}
{"actor":{"display_login":"juliusv"}}