{"action":"created","issue":{"url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1132","repository_url":"https://api.github.com/repos/zenphoto/zenphoto","labels_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1132/labels{/name}","comments_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1132/comments","events_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1132/events","html_url":"https://github.com/zenphoto/zenphoto/issues/1132","id":297053316,"number":1132,"title":"Video thumbnails cropped and stretched even when cropping is turned off","user":{"login":"JatB","id":10157440,"avatar_url":"https://avatars2.githubusercontent.com/u/10157440?v=4","gravatar_id":"","url":"https://api.github.com/users/JatB","html_url":"https://github.com/JatB","followers_url":"https://api.github.com/users/JatB/followers","following_url":"https://api.github.com/users/JatB/following{/other_user}","gists_url":"https://api.github.com/users/JatB/gists{/gist_id}","starred_url":"https://api.github.com/users/JatB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JatB/subscriptions","organizations_url":"https://api.github.com/users/JatB/orgs","repos_url":"https://api.github.com/users/JatB/repos","events_url":"https://api.github.com/users/JatB/events{/privacy}","received_events_url":"https://api.github.com/users/JatB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-14T10:58:23Z","updated_at":"2018-02-14T12:23:53Z","closed_at":null,"author_association":"NONE","body":"If you have cropping turned off, Zenphoto still crops video thumbnails, but will then stretch them out in the theme. So you end up with cropped and warped thumbnails.\r\n\r\nHere I have a 1920x1080 .jpg labeled \"1920x1080 Image only\" and a .jpg with the same resolution labeled \"1920x1080 Video thumbnail\" alongside a .mp4 video with the same name-\r\n![image only thumbnail and video thumbnail](https://user-images.githubusercontent.com/10157440/36199706-3887cde8-112f-11e8-9dd1-c2c4ce641ed7.png)\r\n\r\nIt is easy to test for-\r\n- Turn off cropping in your theme options.\r\n- Add a video thumbnail image alongside your video (it helps if the video image is 16:9 to easily see the crop)\r\n- The thumbnail for the video that will be displayed in the theme will have both the left and right sides cropped and then stretched.\r\n\r\nFor example, in my theme options I currently have thumb size set to 200 pixels and crop thumbnails turned off. This is on a slightly modified version of the Basic theme, so you can test it on there.\r\n\r\n![admin - options - theme](https://user-images.githubusercontent.com/10157440/36199830-98527c14-112f-11e8-97b6-0739be6270f8.png)\r\n\r\nBoth resulting image thumbnails will be set to width=\"200\" height=\"113\" _BUT_ the video thumbnail will be square cropped in the middle at 200x200 with “_w100_h100” added to the filename.\r\n\r\nFor example, the image only thumbnail-\r\nsrc=“/demosite/cache/video_thumbnail_test/video_thumbnail_test-image_only_200_thumb.jpg\"\r\n![video_thumbnail_test-image_only_200_thumb](https://user-images.githubusercontent.com/10157440/36200486-b7de66a4-1131-11e8-969e-a1fdd1302c61.jpg)\r\n\r\nThe video thumbnail-\r\nsrc=“/demosite/cache/video_thumbnail_test/video_thumbnail_test_200_w100_h100_thumb.jpg\"\r\n![video_thumbnail_test_200_w100_h100_thumb](https://user-images.githubusercontent.com/10157440/36200497-c0ac1fc4-1131-11e8-8bfa-d6160342bd9d.jpg)\r\n\r\nWhat it should look like-\r\n![video_thumbnail_test-what_it_should_look_like_200_thumb](https://user-images.githubusercontent.com/10157440/36200532-dda0f6c2-1131-11e8-997d-d28444c06129.jpg)\r\n\r\nWhat’s interesting is that the video player will still display the correct full-sized video thumbnail for the poster (tested in both jplayer and mediaelementjs_player)\r\n\r\nThis has annoyed me for years, so I’m finally submitting a bug report for it.\r\n\r\nI’ve seen other people complain about the issue, but it was never resolved-\r\nhttp://forum.zenphoto.org/discussion/2749/video-thumbnails\r\nhttp://forum.zenphoto.org/discussion/1014069/video-thumbnails-distorting\r\nhttp://forum.zenphoto.org/discussion/10019/best-method-for-custom-thumbnail-sizes\r\nhttp://forum.zenphoto.org/discussion/4346/using-printcustomsizedimagemaxspace-for-video-thumbs\r\n\r\nThanks, and let me know if you want the sample images and video file I whipped up to test for yourselves."},"comment":{"url":"https://api.github.com/repos/zenphoto/zenphoto/issues/comments/365591804","html_url":"https://github.com/zenphoto/zenphoto/issues/1132#issuecomment-365591804","issue_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1132","id":365591804,"user":{"login":"acrylian","id":2474309,"avatar_url":"https://avatars3.githubusercontent.com/u/2474309?v=4","gravatar_id":"","url":"https://api.github.com/users/acrylian","html_url":"https://github.com/acrylian","followers_url":"https://api.github.com/users/acrylian/followers","following_url":"https://api.github.com/users/acrylian/following{/other_user}","gists_url":"https://api.github.com/users/acrylian/gists{/gist_id}","starred_url":"https://api.github.com/users/acrylian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrylian/subscriptions","organizations_url":"https://api.github.com/users/acrylian/orgs","repos_url":"https://api.github.com/users/acrylian/repos","events_url":"https://api.github.com/users/acrylian/events{/privacy}","received_events_url":"https://api.github.com/users/acrylian/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T12:23:53Z","updated_at":"2018-02-14T12:23:53Z","author_association":"OWNER","body":"Addition: Sorry, we generally call image for videos \"video thumbs\" (newer and better term is actually \"sidecar image\"). I meant the image on the video player itself and confused myself. The thumbs on the overview pages of course use the default settings for all images (unless a theme does choose to use custom sizes)."}}
{"actor":{"display_login":"acrylian"}}