{"action":"created","comment":{"url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/comments/200832452","pull_request_review_id":135224972,"id":200832452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgzMjQ1Mg==","diff_hunk":"@@ -21,7 +21,7 @@ if [[ -z $LOGZIO_TOKEN ]]; then\n     exit 1\n fi\n \n-if ! [[ -z $AWS_ACCESS_KEY && -z $AWS_SECRET_KEY ]]; then\n+if ! [[ -z $RDS_LOG_FILE && -z $RDS_SLOW_LOG_FILE && -z $RDS_ERROR_LOG_FILE ]]; then","path":"scripts/go.bash","position":5,"original_position":5,"commit_id":"1870f948d9ea638c75e0e62082bf03421fa67018","original_commit_id":"c625ac872686f590e8901452676cc322b0c4aa78","user":{"login":"ofer-velich","id":7073481,"node_id":"MDQ6VXNlcjcwNzM0ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7073481?v=4","gravatar_id":"","url":"https://api.github.com/users/ofer-velich","html_url":"https://github.com/ofer-velich","followers_url":"https://api.github.com/users/ofer-velich/followers","following_url":"https://api.github.com/users/ofer-velich/following{/other_user}","gists_url":"https://api.github.com/users/ofer-velich/gists{/gist_id}","starred_url":"https://api.github.com/users/ofer-velich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofer-velich/subscriptions","organizations_url":"https://api.github.com/users/ofer-velich/orgs","repos_url":"https://api.github.com/users/ofer-velich/repos","events_url":"https://api.github.com/users/ofer-velich/events{/privacy}","received_events_url":"https://api.github.com/users/ofer-velich/received_events","type":"User","site_admin":false},"body":"why do you need any condition, i think you can just remove this condition, and let the configure_rds to be called. \r\nRDS_LOG_FILE, RDS_SLOW_LOG_FILE, RDS_ERROR_LOG_FILE will be validated on the sync_rds call, am i missing some thing ?","created_at":"2018-07-08T07:56:23Z","updated_at":"2018-07-08T07:56:23Z","html_url":"https://github.com/logzio/logzio-mysql-logs/pull/5#discussion_r200832452","pull_request_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/comments/200832452"},"html":{"href":"https://github.com/logzio/logzio-mysql-logs/pull/5#discussion_r200832452"},"pull_request":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5"}},"in_reply_to_id":199153683},"pull_request":{"url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5","id":197990076,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTkwMDc2","html_url":"https://github.com/logzio/logzio-mysql-logs/pull/5","diff_url":"https://github.com/logzio/logzio-mysql-logs/pull/5.diff","patch_url":"https://github.com/logzio/logzio-mysql-logs/pull/5.patch","issue_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/5","number":5,"state":"open","locked":false,"title":"support (instance) IAM roles","user":{"login":"Mortinke","id":11607896,"node_id":"MDQ6VXNlcjExNjA3ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/11607896?v=4","gravatar_id":"","url":"https://api.github.com/users/Mortinke","html_url":"https://github.com/Mortinke","followers_url":"https://api.github.com/users/Mortinke/followers","following_url":"https://api.github.com/users/Mortinke/following{/other_user}","gists_url":"https://api.github.com/users/Mortinke/gists{/gist_id}","starred_url":"https://api.github.com/users/Mortinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mortinke/subscriptions","organizations_url":"https://api.github.com/users/Mortinke/orgs","repos_url":"https://api.github.com/users/Mortinke/repos","events_url":"https://api.github.com/users/Mortinke/events{/privacy}","received_events_url":"https://api.github.com/users/Mortinke/received_events","type":"User","site_admin":false},"body":"#4 Static IAM (user) credentials are no longer necessary. In addition, the static credentials are no longer a characteristic that you want to push RDS logs.","created_at":"2018-06-28T10:48:45Z","updated_at":"2018-07-08T07:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"199c19cc3324a7b2d3c293d768a37ad497c1192d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5/commits","review_comments_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5/comments","review_comment_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/5/comments","statuses_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/statuses/1870f948d9ea638c75e0e62082bf03421fa67018","head":{"label":"Mortinke:iam-role-support","ref":"iam-role-support","sha":"1870f948d9ea638c75e0e62082bf03421fa67018","user":{"login":"Mortinke","id":11607896,"node_id":"MDQ6VXNlcjExNjA3ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/11607896?v=4","gravatar_id":"","url":"https://api.github.com/users/Mortinke","html_url":"https://github.com/Mortinke","followers_url":"https://api.github.com/users/Mortinke/followers","following_url":"https://api.github.com/users/Mortinke/following{/other_user}","gists_url":"https://api.github.com/users/Mortinke/gists{/gist_id}","starred_url":"https://api.github.com/users/Mortinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mortinke/subscriptions","organizations_url":"https://api.github.com/users/Mortinke/orgs","repos_url":"https://api.github.com/users/Mortinke/repos","events_url":"https://api.github.com/users/Mortinke/events{/privacy}","received_events_url":"https://api.github.com/users/Mortinke/received_events","type":"User","site_admin":false},"repo":{"id":138690881,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2OTA4ODE=","name":"logzio-mysql-logs","full_name":"Mortinke/logzio-mysql-logs","owner":{"login":"Mortinke","id":11607896,"node_id":"MDQ6VXNlcjExNjA3ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/11607896?v=4","gravatar_id":"","url":"https://api.github.com/users/Mortinke","html_url":"https://github.com/Mortinke","followers_url":"https://api.github.com/users/Mortinke/followers","following_url":"https://api.github.com/users/Mortinke/following{/other_user}","gists_url":"https://api.github.com/users/Mortinke/gists{/gist_id}","starred_url":"https://api.github.com/users/Mortinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mortinke/subscriptions","organizations_url":"https://api.github.com/users/Mortinke/orgs","repos_url":"https://api.github.com/users/Mortinke/repos","events_url":"https://api.github.com/users/Mortinke/events{/privacy}","received_events_url":"https://api.github.com/users/Mortinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mortinke/logzio-mysql-logs","description":"Ships your MYSQL / RDS logs to logz.io","fork":true,"url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs","forks_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/forks","keys_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/teams","hooks_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/hooks","issue_events_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/issues/events{/number}","events_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/events","assignees_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/assignees{/user}","branches_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/branches{/branch}","tags_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/tags","blobs_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/statuses/{sha}","languages_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/languages","stargazers_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/stargazers","contributors_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/contributors","subscribers_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/subscribers","subscription_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/subscription","commits_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/contents/{+path}","compare_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/merges","archive_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/downloads","issues_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/issues{/number}","pulls_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/pulls{/number}","milestones_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/milestones{/number}","notifications_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/labels{/name}","releases_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/releases{/id}","deployments_url":"https://api.github.com/repos/Mortinke/logzio-mysql-logs/deployments","created_at":"2018-06-26T05:53:36Z","updated_at":"2018-07-06T04:12:23Z","pushed_at":"2018-07-06T04:30:37Z","git_url":"git://github.com/Mortinke/logzio-mysql-logs.git","ssh_url":"git@github.com:Mortinke/logzio-mysql-logs.git","clone_url":"https://github.com/Mortinke/logzio-mysql-logs.git","svn_url":"https://github.com/Mortinke/logzio-mysql-logs","homepage":"","size":12,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logzio:master","ref":"master","sha":"33387d885eb85a09b14adcbcda8016ce192c664f","user":{"login":"logzio","id":7902073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDIwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/7902073?v=4","gravatar_id":"","url":"https://api.github.com/users/logzio","html_url":"https://github.com/logzio","followers_url":"https://api.github.com/users/logzio/followers","following_url":"https://api.github.com/users/logzio/following{/other_user}","gists_url":"https://api.github.com/users/logzio/gists{/gist_id}","starred_url":"https://api.github.com/users/logzio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logzio/subscriptions","organizations_url":"https://api.github.com/users/logzio/orgs","repos_url":"https://api.github.com/users/logzio/repos","events_url":"https://api.github.com/users/logzio/events{/privacy}","received_events_url":"https://api.github.com/users/logzio/received_events","type":"Organization","site_admin":false},"repo":{"id":92263787,"node_id":"MDEwOlJlcG9zaXRvcnk5MjI2Mzc4Nw==","name":"logzio-mysql-logs","full_name":"logzio/logzio-mysql-logs","owner":{"login":"logzio","id":7902073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDIwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/7902073?v=4","gravatar_id":"","url":"https://api.github.com/users/logzio","html_url":"https://github.com/logzio","followers_url":"https://api.github.com/users/logzio/followers","following_url":"https://api.github.com/users/logzio/following{/other_user}","gists_url":"https://api.github.com/users/logzio/gists{/gist_id}","starred_url":"https://api.github.com/users/logzio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logzio/subscriptions","organizations_url":"https://api.github.com/users/logzio/orgs","repos_url":"https://api.github.com/users/logzio/repos","events_url":"https://api.github.com/users/logzio/events{/privacy}","received_events_url":"https://api.github.com/users/logzio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logzio/logzio-mysql-logs","description":"Ships your MYSQL / RDS logs to logz.io","fork":false,"url":"https://api.github.com/repos/logzio/logzio-mysql-logs","forks_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/forks","keys_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/teams","hooks_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/hooks","issue_events_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/events{/number}","events_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/events","assignees_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/assignees{/user}","branches_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/branches{/branch}","tags_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/tags","blobs_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/git/refs{/sha}","trees_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/statuses/{sha}","languages_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/languages","stargazers_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/stargazers","contributors_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/contributors","subscribers_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/subscribers","subscription_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/subscription","commits_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/commits{/sha}","git_commits_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/git/commits{/sha}","comments_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/comments{/number}","issue_comment_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/comments{/number}","contents_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/contents/{+path}","compare_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/merges","archive_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/downloads","issues_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues{/number}","pulls_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls{/number}","milestones_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/milestones{/number}","notifications_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/labels{/name}","releases_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/releases{/id}","deployments_url":"https://api.github.com/repos/logzio/logzio-mysql-logs/deployments","created_at":"2017-05-24T07:35:01Z","updated_at":"2018-06-27T07:30:39Z","pushed_at":"2018-07-06T04:30:39Z","git_url":"git://github.com/logzio/logzio-mysql-logs.git","ssh_url":"git@github.com:logzio/logzio-mysql-logs.git","clone_url":"https://github.com/logzio/logzio-mysql-logs.git","svn_url":"https://github.com/logzio/logzio-mysql-logs","homepage":"","size":10,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5"},"html":{"href":"https://github.com/logzio/logzio-mysql-logs/pull/5"},"issue":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/5"},"comments":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/logzio/logzio-mysql-logs/statuses/1870f948d9ea638c75e0e62082bf03421fa67018"}},"author_association":"NONE"}}
{"actor":{"display_login":"ofer-velich"}}