{"action":"closed","number":282,"pull_request":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282","id":230357932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzU3OTMy","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/282","diff_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/282.diff","patch_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/282.patch","issue_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/282","number":282,"state":"closed","locked":false,"title":"CoreAccounting.sol/Consistency in param order; Rename Exchange Handler","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-13T06:05:28Z","updated_at":"2018-11-13T20:14:26Z","closed_at":"2018-11-13T20:14:25Z","merged_at":"2018-11-13T20:14:25Z","merge_commit_sha":"4ed783d5f229b0013485ad19b73c9ea1f011924a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asoong","id":3453571,"node_id":"MDQ6VXNlcjM0NTM1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3453571?v=4","gravatar_id":"","url":"https://api.github.com/users/asoong","html_url":"https://github.com/asoong","followers_url":"https://api.github.com/users/asoong/followers","following_url":"https://api.github.com/users/asoong/following{/other_user}","gists_url":"https://api.github.com/users/asoong/gists{/gist_id}","starred_url":"https://api.github.com/users/asoong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asoong/subscriptions","organizations_url":"https://api.github.com/users/asoong/orgs","repos_url":"https://api.github.com/users/asoong/repos","events_url":"https://api.github.com/users/asoong/events{/privacy}","received_events_url":"https://api.github.com/users/asoong/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282/commits","review_comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282/comments","review_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/282/comments","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/90696fb67ed5f566cfb6a41f5a00c6f0eca4a5ad","head":{"label":"SetProtocol:felix/add-consistency-to-function-sigs","ref":"felix/add-consistency-to-function-sigs","sha":"90696fb67ed5f566cfb6a41f5a00c6f0eca4a5ad","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"🎛 Set Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-11-13T02:29:38Z","pushed_at":"2018-11-13T20:14:25Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"https://www.setprotocol.com","size":9582,"stargazers_count":78,"watchers_count":78,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":3,"watchers":78,"default_branch":"master"}},"base":{"label":"SetProtocol:master","ref":"master","sha":"6d5d27aa9e09a40c7bc15718c9712a949762675f","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"🎛 Set Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-11-13T02:29:38Z","pushed_at":"2018-11-13T20:14:25Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"https://www.setprotocol.com","size":9582,"stargazers_count":78,"watchers_count":78,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":3,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/282"},"issue":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/282"},"comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/90696fb67ed5f566cfb6a41f5a00c6f0eca4a5ad"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"felix2feng"}}