{"action":"created","comment":{"url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/comments/235903728","pull_request_review_id":177878361,"id":235903728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkwMzcyOA==","diff_hunk":"@@ -1,21 +1,27 @@\n-plugins {\n-    id 'java'\n-    id 'org.jetbrains.kotlin.jvm' version '1.3.10'\n-    id 'org.jetbrains.kotlin.plugin.allopen' version '1.3.10'\n-    id 'org.jetbrains.kotlin.plugin.spring' version '1.3.10'\n-    id 'org.springframework.boot' version '2.0.4.RELEASE'\n-    id 'io.spring.dependency-management' version '1.0.6.RELEASE'\n+buildscript {\n+    repositories {\n+        mavenCentral()\n+    }\n+    dependencies {\n+        classpath \"org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlinVersion}\"\n+        classpath \"org.jetbrains.kotlin:kotlin-allopen:${kotlinVersion}\"\n+        classpath \"org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}\"\n+        classpath \"io.spring.gradle:dependency-management-plugin:${springDependencyManagementVersion}\"\n+    }\n }\n \n-group 'sk.vrto'","path":"build.gradle","position":20,"original_position":20,"commit_id":"997441d69a1bbffed1d0bd065be1ed2e1730acec","original_commit_id":"997441d69a1bbffed1d0bd065be1ed2e1730acec","user":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"body":"Thx - I was shooting for a fat JAR, but if I agree that having a module named `customers.jar` without any prefix isn't ideal! ","created_at":"2018-11-23T10:45:54Z","updated_at":"2018-11-23T10:45:54Z","html_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1#discussion_r235903728","pull_request_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/comments/235903728"},"html":{"href":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1#discussion_r235903728"},"pull_request":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1"}},"in_reply_to_id":235901173},"pull_request":{"url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1","id":233158403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTU4NDAz","html_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1","diff_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1.diff","patch_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1.patch","issue_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/1","number":1,"state":"open","locked":false,"title":"Use 'gradle.properties' instead of hardcoding them.","user":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-23T10:28:42Z","updated_at":"2018-11-23T10:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9df285874ab5229ea5cbfc629fe67002ea8d359","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1/commits","review_comments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1/comments","review_comment_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/1/comments","statuses_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/statuses/997441d69a1bbffed1d0bd065be1ed2e1730acec","head":{"label":"vrto:use-gradle-versioning","ref":"use-gradle-versioning","sha":"997441d69a1bbffed1d0bd065be1ed2e1730acec","user":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"repo":{"id":158401540,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0MDE1NDA=","name":"gradle-kotlin-spring-multi-modules","full_name":"vrto/gradle-kotlin-spring-multi-modules","private":false,"owner":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules","description":"Multi-module setup with Spring Boot and Kotlin","fork":false,"url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules","forks_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/forks","keys_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/teams","hooks_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/hooks","issue_events_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/events{/number}","events_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/events","assignees_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/assignees{/user}","branches_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/branches{/branch}","tags_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/tags","blobs_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/languages","stargazers_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/stargazers","contributors_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/contributors","subscribers_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/subscribers","subscription_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/subscription","commits_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/contents/{+path}","compare_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/merges","archive_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/downloads","issues_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues{/number}","pulls_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/labels{/name}","releases_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/releases{/id}","deployments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/deployments","created_at":"2018-11-20T14:23:59Z","updated_at":"2018-11-22T14:54:21Z","pushed_at":"2018-11-23T10:28:42Z","git_url":"git://github.com/vrto/gradle-kotlin-spring-multi-modules.git","ssh_url":"git@github.com:vrto/gradle-kotlin-spring-multi-modules.git","clone_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules.git","svn_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vrto:master","ref":"master","sha":"4edd46a96efe30927cfbc228c7fbbe27b84b9721","user":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"repo":{"id":158401540,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0MDE1NDA=","name":"gradle-kotlin-spring-multi-modules","full_name":"vrto/gradle-kotlin-spring-multi-modules","private":false,"owner":{"login":"vrto","id":3193149,"node_id":"MDQ6VXNlcjMxOTMxNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3193149?v=4","gravatar_id":"","url":"https://api.github.com/users/vrto","html_url":"https://github.com/vrto","followers_url":"https://api.github.com/users/vrto/followers","following_url":"https://api.github.com/users/vrto/following{/other_user}","gists_url":"https://api.github.com/users/vrto/gists{/gist_id}","starred_url":"https://api.github.com/users/vrto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrto/subscriptions","organizations_url":"https://api.github.com/users/vrto/orgs","repos_url":"https://api.github.com/users/vrto/repos","events_url":"https://api.github.com/users/vrto/events{/privacy}","received_events_url":"https://api.github.com/users/vrto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules","description":"Multi-module setup with Spring Boot and Kotlin","fork":false,"url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules","forks_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/forks","keys_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/teams","hooks_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/hooks","issue_events_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/events{/number}","events_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/events","assignees_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/assignees{/user}","branches_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/branches{/branch}","tags_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/tags","blobs_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/languages","stargazers_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/stargazers","contributors_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/contributors","subscribers_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/subscribers","subscription_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/subscription","commits_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/contents/{+path}","compare_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/merges","archive_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/downloads","issues_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues{/number}","pulls_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/labels{/name}","releases_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/releases{/id}","deployments_url":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/deployments","created_at":"2018-11-20T14:23:59Z","updated_at":"2018-11-22T14:54:21Z","pushed_at":"2018-11-23T10:28:42Z","git_url":"git://github.com/vrto/gradle-kotlin-spring-multi-modules.git","ssh_url":"git@github.com:vrto/gradle-kotlin-spring-multi-modules.git","clone_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules.git","svn_url":"https://github.com/vrto/gradle-kotlin-spring-multi-modules","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1"},"html":{"href":"https://github.com/vrto/gradle-kotlin-spring-multi-modules/pull/1"},"issue":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/1"},"comments":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/vrto/gradle-kotlin-spring-multi-modules/statuses/997441d69a1bbffed1d0bd065be1ed2e1730acec"}},"author_association":"OWNER"}}
{"actor":{"display_login":"vrto"}}