{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/222822140","pull_request_review_id":161803967,"id":222822140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjgyMjE0MA==","diff_hunk":"@@ -0,0 +1,47 @@\n+#\n+# A release branch requires updating the following two variables at the bottom of this file:\n+#\n+# IOS_PACKAGE_VERSION (major/minor/revision #)\n+# MAC_PACKAGE_VERSION (major/minor/revision #)\n+#\n+# Update version numbers on master as well, to the next version\n+#\n+\n+#\n+# ** Version numbers **\n+#\n+# Versions are defined as: Major.Minor.Revison.Build\n+#\n+# Major/minor (first/second numbers - max 2 digits each):\n+# - Bump for major/minor releases.\n+#\n+# Revision (third number - max 2 digits):\n+# - Reset to 0 after a major or minor bump (do not use 99 for Xcode preview\n+#   branches (use 0 instead), because otherwise we can't bump it further if\n+#   needed).\n+# - Bump for service releases and previews.\n+# - Bump if commit distance becomes > 999.\n+# - Can also be bumped for other reasons (in particular there's no correlation\n+#   between Preview/Service Release #X and Revision #Y).\n+#   - Bumping revision to a high enough number to make it clear that there's","path":"Make.versions","position":26,"original_position":26,"commit_id":"88e5fe10dbb70e7f0493d15df0600cd94bbbf3d1","original_commit_id":"88e5fe10dbb70e7f0493d15df0600cd94bbbf3d1","user":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"body":"It's generally a **minor** `99` (for major Xcode) or an odd minor number (for minor Xcode).\r\nBut there were cases where we're stuck in _odd_ positions and used `99` in revisions (e.g. when the next _even_ number was already used)- but it's not common and there are alternatives (so many numbers)","created_at":"2018-10-04T20:48:47Z","updated_at":"2018-10-04T20:48:47Z","html_url":"https://github.com/xamarin/xamarin-macios/pull/4931#discussion_r222822140","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/222822140"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/4931#discussion_r222822140"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931"}},"in_reply_to_id":222816883},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931","id":220464686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDY0Njg2","html_url":"https://github.com/xamarin/xamarin-macios/pull/4931","diff_url":"https://github.com/xamarin/xamarin-macios/pull/4931.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/4931.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4931","number":4931,"state":"closed","locked":false,"title":"[d15-9] Try to make version numbers clearer, and establish some ground rules.","user":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"body":"Backport of https://github.com/xamarin/xamarin-macios/pull/4927\nwith 15.9 numbers","created_at":"2018-10-04T17:54:27Z","updated_at":"2018-10-04T20:48:47Z","closed_at":"2018-10-04T20:38:10Z","merged_at":"2018-10-04T20:38:10Z","merge_commit_sha":"6d4e78b41972541b90698eb0ee3c7f8eec134be8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rolfbjarne","id":249268,"node_id":"MDQ6VXNlcjI0OTI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/249268?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones/14","html_url":"https://github.com/xamarin/xamarin-macios/milestone/14","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones/14/labels","id":3396418,"node_id":"MDk6TWlsZXN0b25lMzM5NjQxOA==","number":14,"title":"d15-9","description":"","creator":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":40,"state":"open","created_at":"2018-06-03T16:27:55Z","updated_at":"2018-10-04T20:38:10Z","due_on":"2018-08-06T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4931/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/88e5fe10dbb70e7f0493d15df0600cd94bbbf3d1","head":{"label":"spouliot:d15-9-version-fix","ref":"d15-9-version-fix","sha":"88e5fe10dbb70e7f0493d15df0600cd94bbbf3d1","user":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"repo":{"id":58007918,"node_id":"MDEwOlJlcG9zaXRvcnk1ODAwNzkxOA==","name":"xamarin-macios","full_name":"spouliot/xamarin-macios","private":false,"owner":{"login":"spouliot","id":260465,"node_id":"MDQ6VXNlcjI2MDQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/260465?v=4","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spouliot/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":true,"url":"https://api.github.com/repos/spouliot/xamarin-macios","forks_url":"https://api.github.com/repos/spouliot/xamarin-macios/forks","keys_url":"https://api.github.com/repos/spouliot/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spouliot/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spouliot/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/spouliot/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/spouliot/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/spouliot/xamarin-macios/events","assignees_url":"https://api.github.com/repos/spouliot/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/spouliot/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/spouliot/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/spouliot/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spouliot/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spouliot/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spouliot/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spouliot/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/spouliot/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/spouliot/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/spouliot/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/spouliot/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/spouliot/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/spouliot/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spouliot/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spouliot/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spouliot/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/spouliot/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/spouliot/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spouliot/xamarin-macios/merges","archive_url":"https://api.github.com/repos/spouliot/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spouliot/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/spouliot/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/spouliot/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/spouliot/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/spouliot/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spouliot/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/spouliot/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/spouliot/xamarin-macios/deployments","created_at":"2016-05-03T23:24:45Z","updated_at":"2018-06-08T21:25:02Z","pushed_at":"2018-10-04T20:38:15Z","git_url":"git://github.com/spouliot/xamarin-macios.git","ssh_url":"git@github.com:spouliot/xamarin-macios.git","clone_url":"https://github.com/spouliot/xamarin-macios.git","svn_url":"https://github.com/spouliot/xamarin-macios","homepage":null,"size":88710,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:d15-9","ref":"d15-9","sha":"a50180d20bcc8c91b7b3f8421a6c3705fae3ea02","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":56710511,"node_id":"MDEwOlJlcG9zaXRvcnk1NjcxMDUxMQ==","name":"xamarin-macios","full_name":"xamarin/xamarin-macios","private":false,"owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xamarin/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-macios","forks_url":"https://api.github.com/repos/xamarin/xamarin-macios/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-macios/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-macios/deployments","created_at":"2016-04-20T18:24:26Z","updated_at":"2018-10-04T17:49:35Z","pushed_at":"2018-10-04T20:38:10Z","git_url":"git://github.com/xamarin/xamarin-macios.git","ssh_url":"git@github.com:xamarin/xamarin-macios.git","clone_url":"https://github.com/xamarin/xamarin-macios.git","svn_url":"https://github.com/xamarin/xamarin-macios","homepage":null,"size":92090,"stargazers_count":1195,"watchers_count":1195,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":240,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":240,"open_issues":201,"watchers":1195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/4931"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4931"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4931/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4931/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/88e5fe10dbb70e7f0493d15df0600cd94bbbf3d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spouliot"}}