{"action":"created","comment":{"url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/comments/228788218","pull_request_review_id":169133848,"id":228788218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc4ODIxOA==","diff_hunk":"@@ -34,10 +34,10 @@ module Map.Int\n        , alter\n        ) where\n \n-import Prelude hiding (lookup, null)\n+import Control.DeepSeq (NFData (..))\n import Data.Coerce (coerce)\n-\n import qualified Data.IntMap.Strict as M","path":"containers-int-strict/src/Map/Int.hs","position":8,"original_position":8,"commit_id":"89e6071c1609f6e422edd18ab0f3d254d91705c5","original_commit_id":"89e6071c1609f6e422edd18ab0f3d254d91705c5","user":{"login":"ChShersh","id":4276606,"node_id":"MDQ6VXNlcjQyNzY2MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/4276606?v=4","gravatar_id":"","url":"https://api.github.com/users/ChShersh","html_url":"https://github.com/ChShersh","followers_url":"https://api.github.com/users/ChShersh/followers","following_url":"https://api.github.com/users/ChShersh/following{/other_user}","gists_url":"https://api.github.com/users/ChShersh/gists{/gist_id}","starred_url":"https://api.github.com/users/ChShersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChShersh/subscriptions","organizations_url":"https://api.github.com/users/ChShersh/orgs","repos_url":"https://api.github.com/users/ChShersh/repos","events_url":"https://api.github.com/users/ChShersh/events{/privacy}","received_events_url":"https://api.github.com/users/ChShersh/received_events","type":"User","site_admin":false},"body":"According to our style guide, `qualified` imports should be in separate section at the end of imports separated by empty line. This helps readability in general.","created_at":"2018-10-29T03:22:03Z","updated_at":"2018-10-29T03:38:09Z","html_url":"https://github.com/kowainik/containers-backpack/pull/43#discussion_r228788218","pull_request_url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/comments/228788218"},"html":{"href":"https://github.com/kowainik/containers-backpack/pull/43#discussion_r228788218"},"pull_request":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43","id":226276172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mjc2MTcy","html_url":"https://github.com/kowainik/containers-backpack/pull/43","diff_url":"https://github.com/kowainik/containers-backpack/pull/43.diff","patch_url":"https://github.com/kowainik/containers-backpack/pull/43.patch","issue_url":"https://api.github.com/repos/kowainik/containers-backpack/issues/43","number":43,"state":"open","locked":false,"title":"Introduce Benchmarks","user":{"login":"yigitozkavci","id":7188811,"node_id":"MDQ6VXNlcjcxODg4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7188811?v=4","gravatar_id":"","url":"https://api.github.com/users/yigitozkavci","html_url":"https://github.com/yigitozkavci","followers_url":"https://api.github.com/users/yigitozkavci/followers","following_url":"https://api.github.com/users/yigitozkavci/following{/other_user}","gists_url":"https://api.github.com/users/yigitozkavci/gists{/gist_id}","starred_url":"https://api.github.com/users/yigitozkavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yigitozkavci/subscriptions","organizations_url":"https://api.github.com/users/yigitozkavci/orgs","repos_url":"https://api.github.com/users/yigitozkavci/repos","events_url":"https://api.github.com/users/yigitozkavci/events{/privacy}","received_events_url":"https://api.github.com/users/yigitozkavci/received_events","type":"User","site_admin":false},"body":"Closes #11 \r\n\r\n# Purpose\r\nAdding benchmarks for assessing runtimes of `Map.lookup` operation of several packages.\r\n\r\n# Running the Benchmarks\r\nA new cabal project and executable is added. You can run the benchmarks with:\r\n`cabal new-run benchmarks-exe`\r\n\r\n# Questions\r\n- There are more operations other than just `lookup` operation we can do benchmarking for. Shall we add more benchmarks targeting those? If so, shall it be in this PR or in separate PRs?\r\n- Shall we add benchmarks to Travis CI to run?\r\n- Since `Map.Prim` module uses [Data.Map.Lifted.Lifted](http://hackage.haskell.org/package/primitive-containers-0.2.0/docs/Data-Map-Lifted-Lifted.html) behind the scenes and it does not have `NFData` instance, I could not introduce benchmarks for the module. Can we think of a workaround or do we say \"It does make sense that we cannot write a benchmark for it\"?","created_at":"2018-10-27T07:29:51Z","updated_at":"2018-10-29T03:38:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf7d986847d87a6a96fbad0d3fa764dc78dbfd9e","assignee":{"login":"yigitozkavci","id":7188811,"node_id":"MDQ6VXNlcjcxODg4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7188811?v=4","gravatar_id":"","url":"https://api.github.com/users/yigitozkavci","html_url":"https://github.com/yigitozkavci","followers_url":"https://api.github.com/users/yigitozkavci/followers","following_url":"https://api.github.com/users/yigitozkavci/following{/other_user}","gists_url":"https://api.github.com/users/yigitozkavci/gists{/gist_id}","starred_url":"https://api.github.com/users/yigitozkavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yigitozkavci/subscriptions","organizations_url":"https://api.github.com/users/yigitozkavci/orgs","repos_url":"https://api.github.com/users/yigitozkavci/repos","events_url":"https://api.github.com/users/yigitozkavci/events{/privacy}","received_events_url":"https://api.github.com/users/yigitozkavci/received_events","type":"User","site_admin":false},"assignees":[{"login":"yigitozkavci","id":7188811,"node_id":"MDQ6VXNlcjcxODg4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7188811?v=4","gravatar_id":"","url":"https://api.github.com/users/yigitozkavci","html_url":"https://github.com/yigitozkavci","followers_url":"https://api.github.com/users/yigitozkavci/followers","following_url":"https://api.github.com/users/yigitozkavci/following{/other_user}","gists_url":"https://api.github.com/users/yigitozkavci/gists{/gist_id}","starred_url":"https://api.github.com/users/yigitozkavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yigitozkavci/subscriptions","organizations_url":"https://api.github.com/users/yigitozkavci/orgs","repos_url":"https://api.github.com/users/yigitozkavci/repos","events_url":"https://api.github.com/users/yigitozkavci/events{/privacy}","received_events_url":"https://api.github.com/users/yigitozkavci/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vrom911","id":8126674,"node_id":"MDQ6VXNlcjgxMjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8126674?v=4","gravatar_id":"","url":"https://api.github.com/users/vrom911","html_url":"https://github.com/vrom911","followers_url":"https://api.github.com/users/vrom911/followers","following_url":"https://api.github.com/users/vrom911/following{/other_user}","gists_url":"https://api.github.com/users/vrom911/gists{/gist_id}","starred_url":"https://api.github.com/users/vrom911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrom911/subscriptions","organizations_url":"https://api.github.com/users/vrom911/orgs","repos_url":"https://api.github.com/users/vrom911/repos","events_url":"https://api.github.com/users/vrom911/events{/privacy}","received_events_url":"https://api.github.com/users/vrom911/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1074263976,"node_id":"MDU6TGFiZWwxMDc0MjYzOTc2","url":"https://api.github.com/repos/kowainik/containers-backpack/labels/Hacktoberfest","name":"Hacktoberfest","color":"FBA36B","default":false},{"id":1074267926,"node_id":"MDU6TGFiZWwxMDc0MjY3OTI2","url":"https://api.github.com/repos/kowainik/containers-backpack/labels/bench","name":"bench","color":"387899","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43/commits","review_comments_url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43/comments","review_comment_url":"https://api.github.com/repos/kowainik/containers-backpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kowainik/containers-backpack/issues/43/comments","statuses_url":"https://api.github.com/repos/kowainik/containers-backpack/statuses/89e6071c1609f6e422edd18ab0f3d254d91705c5","head":{"label":"yigitozkavci:bench","ref":"bench","sha":"89e6071c1609f6e422edd18ab0f3d254d91705c5","user":{"login":"yigitozkavci","id":7188811,"node_id":"MDQ6VXNlcjcxODg4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7188811?v=4","gravatar_id":"","url":"https://api.github.com/users/yigitozkavci","html_url":"https://github.com/yigitozkavci","followers_url":"https://api.github.com/users/yigitozkavci/followers","following_url":"https://api.github.com/users/yigitozkavci/following{/other_user}","gists_url":"https://api.github.com/users/yigitozkavci/gists{/gist_id}","starred_url":"https://api.github.com/users/yigitozkavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yigitozkavci/subscriptions","organizations_url":"https://api.github.com/users/yigitozkavci/orgs","repos_url":"https://api.github.com/users/yigitozkavci/repos","events_url":"https://api.github.com/users/yigitozkavci/events{/privacy}","received_events_url":"https://api.github.com/users/yigitozkavci/received_events","type":"User","site_admin":false},"repo":{"id":152779392,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NzkzOTI=","name":"containers-backpack","full_name":"yigitozkavci/containers-backpack","private":false,"owner":{"login":"yigitozkavci","id":7188811,"node_id":"MDQ6VXNlcjcxODg4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7188811?v=4","gravatar_id":"","url":"https://api.github.com/users/yigitozkavci","html_url":"https://github.com/yigitozkavci","followers_url":"https://api.github.com/users/yigitozkavci/followers","following_url":"https://api.github.com/users/yigitozkavci/following{/other_user}","gists_url":"https://api.github.com/users/yigitozkavci/gists{/gist_id}","starred_url":"https://api.github.com/users/yigitozkavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yigitozkavci/subscriptions","organizations_url":"https://api.github.com/users/yigitozkavci/orgs","repos_url":"https://api.github.com/users/yigitozkavci/repos","events_url":"https://api.github.com/users/yigitozkavci/events{/privacy}","received_events_url":"https://api.github.com/users/yigitozkavci/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yigitozkavci/containers-backpack","description":"🎒 Backpack interface for containers","fork":true,"url":"https://api.github.com/repos/yigitozkavci/containers-backpack","forks_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/forks","keys_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/teams","hooks_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/hooks","issue_events_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/issues/events{/number}","events_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/events","assignees_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/assignees{/user}","branches_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/branches{/branch}","tags_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/tags","blobs_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/statuses/{sha}","languages_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/languages","stargazers_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/stargazers","contributors_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/contributors","subscribers_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/subscribers","subscription_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/subscription","commits_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/contents/{+path}","compare_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/merges","archive_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/downloads","issues_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/issues{/number}","pulls_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/pulls{/number}","milestones_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/milestones{/number}","notifications_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/labels{/name}","releases_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/releases{/id}","deployments_url":"https://api.github.com/repos/yigitozkavci/containers-backpack/deployments","created_at":"2018-10-12T16:32:21Z","updated_at":"2018-10-12T16:32:23Z","pushed_at":"2018-10-27T07:42:30Z","git_url":"git://github.com/yigitozkavci/containers-backpack.git","ssh_url":"git@github.com:yigitozkavci/containers-backpack.git","clone_url":"https://github.com/yigitozkavci/containers-backpack.git","svn_url":"https://github.com/yigitozkavci/containers-backpack","homepage":"https://kowainik.github.io/projects/containers-backpack","size":72,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kowainik:master","ref":"master","sha":"c84b22f7551bd34183ac76ff20dd4e4fa4cd6f48","user":{"login":"kowainik","id":37126241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI2MjQx","avatar_url":"https://avatars3.githubusercontent.com/u/37126241?v=4","gravatar_id":"","url":"https://api.github.com/users/kowainik","html_url":"https://github.com/kowainik","followers_url":"https://api.github.com/users/kowainik/followers","following_url":"https://api.github.com/users/kowainik/following{/other_user}","gists_url":"https://api.github.com/users/kowainik/gists{/gist_id}","starred_url":"https://api.github.com/users/kowainik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowainik/subscriptions","organizations_url":"https://api.github.com/users/kowainik/orgs","repos_url":"https://api.github.com/users/kowainik/repos","events_url":"https://api.github.com/users/kowainik/events{/privacy}","received_events_url":"https://api.github.com/users/kowainik/received_events","type":"Organization","site_admin":false},"repo":{"id":143502987,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1MDI5ODc=","name":"containers-backpack","full_name":"kowainik/containers-backpack","private":false,"owner":{"login":"kowainik","id":37126241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI2MjQx","avatar_url":"https://avatars3.githubusercontent.com/u/37126241?v=4","gravatar_id":"","url":"https://api.github.com/users/kowainik","html_url":"https://github.com/kowainik","followers_url":"https://api.github.com/users/kowainik/followers","following_url":"https://api.github.com/users/kowainik/following{/other_user}","gists_url":"https://api.github.com/users/kowainik/gists{/gist_id}","starred_url":"https://api.github.com/users/kowainik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowainik/subscriptions","organizations_url":"https://api.github.com/users/kowainik/orgs","repos_url":"https://api.github.com/users/kowainik/repos","events_url":"https://api.github.com/users/kowainik/events{/privacy}","received_events_url":"https://api.github.com/users/kowainik/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kowainik/containers-backpack","description":"🎒 Backpack interface for containers","fork":false,"url":"https://api.github.com/repos/kowainik/containers-backpack","forks_url":"https://api.github.com/repos/kowainik/containers-backpack/forks","keys_url":"https://api.github.com/repos/kowainik/containers-backpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kowainik/containers-backpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kowainik/containers-backpack/teams","hooks_url":"https://api.github.com/repos/kowainik/containers-backpack/hooks","issue_events_url":"https://api.github.com/repos/kowainik/containers-backpack/issues/events{/number}","events_url":"https://api.github.com/repos/kowainik/containers-backpack/events","assignees_url":"https://api.github.com/repos/kowainik/containers-backpack/assignees{/user}","branches_url":"https://api.github.com/repos/kowainik/containers-backpack/branches{/branch}","tags_url":"https://api.github.com/repos/kowainik/containers-backpack/tags","blobs_url":"https://api.github.com/repos/kowainik/containers-backpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kowainik/containers-backpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kowainik/containers-backpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kowainik/containers-backpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kowainik/containers-backpack/statuses/{sha}","languages_url":"https://api.github.com/repos/kowainik/containers-backpack/languages","stargazers_url":"https://api.github.com/repos/kowainik/containers-backpack/stargazers","contributors_url":"https://api.github.com/repos/kowainik/containers-backpack/contributors","subscribers_url":"https://api.github.com/repos/kowainik/containers-backpack/subscribers","subscription_url":"https://api.github.com/repos/kowainik/containers-backpack/subscription","commits_url":"https://api.github.com/repos/kowainik/containers-backpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kowainik/containers-backpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kowainik/containers-backpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kowainik/containers-backpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/kowainik/containers-backpack/contents/{+path}","compare_url":"https://api.github.com/repos/kowainik/containers-backpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kowainik/containers-backpack/merges","archive_url":"https://api.github.com/repos/kowainik/containers-backpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kowainik/containers-backpack/downloads","issues_url":"https://api.github.com/repos/kowainik/containers-backpack/issues{/number}","pulls_url":"https://api.github.com/repos/kowainik/containers-backpack/pulls{/number}","milestones_url":"https://api.github.com/repos/kowainik/containers-backpack/milestones{/number}","notifications_url":"https://api.github.com/repos/kowainik/containers-backpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kowainik/containers-backpack/labels{/name}","releases_url":"https://api.github.com/repos/kowainik/containers-backpack/releases{/id}","deployments_url":"https://api.github.com/repos/kowainik/containers-backpack/deployments","created_at":"2018-08-04T06:12:56Z","updated_at":"2018-10-22T13:54:37Z","pushed_at":"2018-10-27T07:42:31Z","git_url":"git://github.com/kowainik/containers-backpack.git","ssh_url":"git@github.com:kowainik/containers-backpack.git","clone_url":"https://github.com/kowainik/containers-backpack.git","svn_url":"https://github.com/kowainik/containers-backpack","homepage":"https://kowainik.github.io/projects/containers-backpack","size":42,"stargazers_count":16,"watchers_count":16,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":8,"open_issues":15,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43"},"html":{"href":"https://github.com/kowainik/containers-backpack/pull/43"},"issue":{"href":"https://api.github.com/repos/kowainik/containers-backpack/issues/43"},"comments":{"href":"https://api.github.com/repos/kowainik/containers-backpack/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kowainik/containers-backpack/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/kowainik/containers-backpack/statuses/89e6071c1609f6e422edd18ab0f3d254d91705c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChShersh"}}