{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/167831598","pull_request_review_id":96103660,"id":167831598,"diff_hunk":"@@ -0,0 +1,31 @@\n+apiVersion: v1\n+kind: SecurityContextConstraints\n+metadata:\n+  name: kubevirt-scc\n+  labels:\n+    kubevirt.io: scc\n+allowHostDirVolumePlugin: true\n+allowHostIPC: true\n+allowHostNetwork: true\n+allowHostPID: true\n+allowHostPorts: true\n+allowPrivilegedContainer: true\n+allowedCapabilities:\n+  - '*'\n+fsGroup:\n+  type: RunAsAny\n+readOnlyRootFilesystem: false\n+runAsUser:\n+  type: RunAsAny\n+seLinuxContext:\n+  type: RunAsAny\n+seccompProfiles:\n+  - '*'\n+supplementalGroups:\n+  type: RunAsAny\n+volumes:\n+  - '*'\n+users:\n+  - system:serviceaccount:kube-system:kubevirt-privileged\n+  - system:serviceaccount:kube-system:kubevirt-controller\n+  - system:serviceaccount:kube-system:kubevirt-infra","path":"manifests/openshift/dev/kubevirt-scc.yaml.in","position":31,"original_position":31,"commit_id":"a888b4bb52188d8845b334fc855d1a29f1709f70","original_commit_id":"a888b4bb52188d8845b334fc855d1a29f1709f70","user":{"login":"lukas-bednar","id":1505684,"avatar_url":"https://avatars0.githubusercontent.com/u/1505684?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-bednar","html_url":"https://github.com/lukas-bednar","followers_url":"https://api.github.com/users/lukas-bednar/followers","following_url":"https://api.github.com/users/lukas-bednar/following{/other_user}","gists_url":"https://api.github.com/users/lukas-bednar/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-bednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-bednar/subscriptions","organizations_url":"https://api.github.com/users/lukas-bednar/orgs","repos_url":"https://api.github.com/users/lukas-bednar/repos","events_url":"https://api.github.com/users/lukas-bednar/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-bednar/received_events","type":"User","site_admin":false},"body":"kubevirt-infra doesn't exist in latest KubeVirt","created_at":"2018-02-13T11:08:44Z","updated_at":"2018-02-13T11:08:52Z","html_url":"https://github.com/kubevirt/kubevirt/pull/732#discussion_r167831598","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/167831598"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/732#discussion_r167831598"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732","id":168814984,"html_url":"https://github.com/kubevirt/kubevirt/pull/732","diff_url":"https://github.com/kubevirt/kubevirt/pull/732.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/732.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/732","number":732,"state":"open","locked":false,"title":"manifests: Adding SCC manifests","user":{"login":"gbenhaim","id":17479229,"avatar_url":"https://avatars3.githubusercontent.com/u/17479229?v=4","gravatar_id":"","url":"https://api.github.com/users/gbenhaim","html_url":"https://github.com/gbenhaim","followers_url":"https://api.github.com/users/gbenhaim/followers","following_url":"https://api.github.com/users/gbenhaim/following{/other_user}","gists_url":"https://api.github.com/users/gbenhaim/gists{/gist_id}","starred_url":"https://api.github.com/users/gbenhaim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbenhaim/subscriptions","organizations_url":"https://api.github.com/users/gbenhaim/orgs","repos_url":"https://api.github.com/users/gbenhaim/repos","events_url":"https://api.github.com/users/gbenhaim/events{/privacy}","received_events_url":"https://api.github.com/users/gbenhaim/received_events","type":"User","site_admin":false},"body":"- The SCC manifests are required for the deployment of Kubevirt on\r\n  Openshift.\r\n\r\n- Currently, the granted privileges are the same as in the \"privileged\"\r\n  SCC. Once we stabilize the functional tests on Openshift, we can start to drop\r\n  unneeded privileges from the SCC.\r\n\r\ncloses https://github.com/kubevirt/kubevirt/issues/573\r\n\r\nSigned-off-by: gbenhaim <galbh2@gmail.com>","created_at":"2018-02-13T11:05:15Z","updated_at":"2018-02-13T11:08:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1341ee41435be9b67ea37dc6dd9e7dc6f987d0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/732/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/a888b4bb52188d8845b334fc855d1a29f1709f70","head":{"label":"gbenhaim:add_scc_manifests","ref":"add_scc_manifests","sha":"a888b4bb52188d8845b334fc855d1a29f1709f70","user":{"login":"gbenhaim","id":17479229,"avatar_url":"https://avatars3.githubusercontent.com/u/17479229?v=4","gravatar_id":"","url":"https://api.github.com/users/gbenhaim","html_url":"https://github.com/gbenhaim","followers_url":"https://api.github.com/users/gbenhaim/followers","following_url":"https://api.github.com/users/gbenhaim/following{/other_user}","gists_url":"https://api.github.com/users/gbenhaim/gists{/gist_id}","starred_url":"https://api.github.com/users/gbenhaim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbenhaim/subscriptions","organizations_url":"https://api.github.com/users/gbenhaim/orgs","repos_url":"https://api.github.com/users/gbenhaim/repos","events_url":"https://api.github.com/users/gbenhaim/events{/privacy}","received_events_url":"https://api.github.com/users/gbenhaim/received_events","type":"User","site_admin":false},"repo":{"id":102484150,"name":"kubevirt","full_name":"gbenhaim/kubevirt","owner":{"login":"gbenhaim","id":17479229,"avatar_url":"https://avatars3.githubusercontent.com/u/17479229?v=4","gravatar_id":"","url":"https://api.github.com/users/gbenhaim","html_url":"https://github.com/gbenhaim","followers_url":"https://api.github.com/users/gbenhaim/followers","following_url":"https://api.github.com/users/gbenhaim/following{/other_user}","gists_url":"https://api.github.com/users/gbenhaim/gists{/gist_id}","starred_url":"https://api.github.com/users/gbenhaim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbenhaim/subscriptions","organizations_url":"https://api.github.com/users/gbenhaim/orgs","repos_url":"https://api.github.com/users/gbenhaim/repos","events_url":"https://api.github.com/users/gbenhaim/events{/privacy}","received_events_url":"https://api.github.com/users/gbenhaim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbenhaim/kubevirt","description":"KubeVirt is a virtual machine management add-on for Kubernetes.","fork":true,"url":"https://api.github.com/repos/gbenhaim/kubevirt","forks_url":"https://api.github.com/repos/gbenhaim/kubevirt/forks","keys_url":"https://api.github.com/repos/gbenhaim/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbenhaim/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbenhaim/kubevirt/teams","hooks_url":"https://api.github.com/repos/gbenhaim/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/gbenhaim/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/gbenhaim/kubevirt/events","assignees_url":"https://api.github.com/repos/gbenhaim/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/gbenhaim/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/gbenhaim/kubevirt/tags","blobs_url":"https://api.github.com/repos/gbenhaim/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbenhaim/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbenhaim/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbenhaim/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbenhaim/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/gbenhaim/kubevirt/languages","stargazers_url":"https://api.github.com/repos/gbenhaim/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/gbenhaim/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/gbenhaim/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/gbenhaim/kubevirt/subscription","commits_url":"https://api.github.com/repos/gbenhaim/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbenhaim/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbenhaim/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbenhaim/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbenhaim/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/gbenhaim/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbenhaim/kubevirt/merges","archive_url":"https://api.github.com/repos/gbenhaim/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbenhaim/kubevirt/downloads","issues_url":"https://api.github.com/repos/gbenhaim/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/gbenhaim/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/gbenhaim/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/gbenhaim/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbenhaim/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/gbenhaim/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/gbenhaim/kubevirt/deployments","created_at":"2017-09-05T13:24:45Z","updated_at":"2017-09-05T13:24:47Z","pushed_at":"2018-02-13T10:58:21Z","git_url":"git://github.com/gbenhaim/kubevirt.git","ssh_url":"git@github.com:gbenhaim/kubevirt.git","clone_url":"https://github.com/gbenhaim/kubevirt.git","svn_url":"https://github.com/gbenhaim/kubevirt","homepage":"","size":3718,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"e1a1ac09af31bc806d8bb16c2a5b91d93e3d4466","user":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"A virtualization API and runtime add-on for Kubernetes in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-02-10T02:53:25Z","pushed_at":"2018-02-13T11:05:16Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":49777,"stargazers_count":405,"watchers_count":405,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":103,"open_issues":96,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/732"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/732"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/732/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/a888b4bb52188d8845b334fc855d1a29f1709f70"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukas-bednar"}}