{"action":"created","comment":{"url":"https://api.github.com/repos/d3sw/one-mq/pulls/comments/226718975","pull_request_review_id":166615821,"id":226718975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjcxODk3NQ==","diff_hunk":"@@ -0,0 +1,125 @@\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+  xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd\">\n+    <modelVersion>4.0.0</modelVersion>\n+    <groupId>com.bydeluxe.onemq</groupId>\n+    <artifactId>one-mq</artifactId>\n+    <version>0.2.0</version>\n+    \n+    <dependencies>\n+        <dependency>\n+            <groupId>io.grpc</groupId>\n+            <artifactId>grpc-core</artifactId>\n+            <version>1.15.1</version>\n+        </dependency>\n+        <dependency>\n+            <groupId>io.grpc</groupId>\n+            <artifactId>grpc-netty-shaded</artifactId>\n+            <version>1.15.1</version>\n+        </dependency>\n+        <dependency>\n+            <groupId>io.grpc</groupId>\n+            <artifactId>grpc-protobuf</artifactId>\n+            <version>1.15.1</version>\n+        </dependency>\n+        <dependency>\n+            <groupId>io.grpc</groupId>\n+            <artifactId>grpc-stub</artifactId>\n+            <version>1.15.1</version>\n+        </dependency>\n+        <dependency>\n+            <groupId>io.grpc</groupId>\n+            <artifactId>protoc-gen-grpc-java</artifactId>\n+            <version>1.15.1</version>\n+            <type>pom</type>\n+        </dependency>\n+        <dependency>\n+            <groupId>kr.motd.maven</groupId>\n+            <artifactId>os-maven-plugin</artifactId>\n+            <version>1.6.1</version>\n+        </dependency>        \n+        <dependency>\n+            <groupId>com.google.protobuf</groupId>\n+            <artifactId>protobuf-java</artifactId>\n+            <version>3.6.1</version>\n+        </dependency>        \n+        <dependency>\n+            <groupId>junit</groupId>\n+            <artifactId>junit</artifactId>\n+            <version>4.12</version>\n+        </dependency>    \n+\t\t<dependency>\n+\t\t\t<groupId>dnsjava</groupId>\n+\t\t\t<artifactId>dnsjava</artifactId>\n+\t\t\t<version>2.1.8</version>\n+\t\t</dependency>        \n+    </dependencies>\n+\n+    <build>\n+        <extensions>\n+            <extension>\n+                <groupId>kr.motd.maven</groupId>\n+                <artifactId>os-maven-plugin</artifactId>\n+                <version>1.6.1</version>\n+            </extension>\n+        </extensions>    \n+\n+        <plugins>\n+            <plugin>\n+                <groupId>org.apache.maven.plugins</groupId>","path":"java/pom.xml","position":68,"original_position":68,"commit_id":"452a6e470bf7dad3b383d457e35d90de146f67fc","original_commit_id":"452a6e470bf7dad3b383d457e35d90de146f67fc","user":{"login":"JoelAtDeluxe","id":10979605,"node_id":"MDQ6VXNlcjEwOTc5NjA1","avatar_url":"https://avatars1.githubusercontent.com/u/10979605?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelAtDeluxe","html_url":"https://github.com/JoelAtDeluxe","followers_url":"https://api.github.com/users/JoelAtDeluxe/followers","following_url":"https://api.github.com/users/JoelAtDeluxe/following{/other_user}","gists_url":"https://api.github.com/users/JoelAtDeluxe/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelAtDeluxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelAtDeluxe/subscriptions","organizations_url":"https://api.github.com/users/JoelAtDeluxe/orgs","repos_url":"https://api.github.com/users/JoelAtDeluxe/repos","events_url":"https://api.github.com/users/JoelAtDeluxe/events{/privacy}","received_events_url":"https://api.github.com/users/JoelAtDeluxe/received_events","type":"User","site_admin":false},"body":"I'm sure this is one of those cases where there's multiple ways to do this, but here's an alternate approach:\r\nAt project level, you can add in:\r\n```xml\r\n    <properties>\r\n        <maven.compiler.source>1.8</maven.compiler.source>\r\n        <maven.compiler.target>1.8</maven.compiler.target>\r\n    </properties>\r\n```","created_at":"2018-10-19T17:10:41Z","updated_at":"2018-10-19T17:10:41Z","html_url":"https://github.com/d3sw/one-mq/pull/14#discussion_r226718975","pull_request_url":"https://api.github.com/repos/d3sw/one-mq/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/comments/226718975"},"html":{"href":"https://github.com/d3sw/one-mq/pull/14#discussion_r226718975"},"pull_request":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/d3sw/one-mq/pulls/14","id":223960819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTYwODE5","html_url":"https://github.com/d3sw/one-mq/pull/14","diff_url":"https://github.com/d3sw/one-mq/pull/14.diff","patch_url":"https://github.com/d3sw/one-mq/pull/14.patch","issue_url":"https://api.github.com/repos/d3sw/one-mq/issues/14","number":14,"state":"open","locked":false,"title":"Java Client (Initial Version)","user":{"login":"hueys","id":31932977,"node_id":"MDQ6VXNlcjMxOTMyOTc3","avatar_url":"https://avatars1.githubusercontent.com/u/31932977?v=4","gravatar_id":"","url":"https://api.github.com/users/hueys","html_url":"https://github.com/hueys","followers_url":"https://api.github.com/users/hueys/followers","following_url":"https://api.github.com/users/hueys/following{/other_user}","gists_url":"https://api.github.com/users/hueys/gists{/gist_id}","starred_url":"https://api.github.com/users/hueys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueys/subscriptions","organizations_url":"https://api.github.com/users/hueys/orgs","repos_url":"https://api.github.com/users/hueys/repos","events_url":"https://api.github.com/users/hueys/events{/privacy}","received_events_url":"https://api.github.com/users/hueys/received_events","type":"User","site_admin":false},"body":"Here's an initial take on a Java version of the one-mq (shotgun) client library, ported from the go client. \r\n\r\n⚠️ **Known Issues**\r\n\r\n- This version does NOT include the retry / reconnection logic that the go client uses.\r\n- This code hasn't been extensively tested. As we use it to start integrating services it will likely need bug fixes and updates.\r\n\r\n**Requirements**\r\n\r\n- Java 8 or newer\r\n- Maven 3.5.x","created_at":"2018-10-18T13:40:43Z","updated_at":"2018-10-19T17:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea02f179880e1eb62b34e57c8f2ad8d05a9297e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lysakaleksey","id":6275685,"node_id":"MDQ6VXNlcjYyNzU2ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6275685?v=4","gravatar_id":"","url":"https://api.github.com/users/lysakaleksey","html_url":"https://github.com/lysakaleksey","followers_url":"https://api.github.com/users/lysakaleksey/followers","following_url":"https://api.github.com/users/lysakaleksey/following{/other_user}","gists_url":"https://api.github.com/users/lysakaleksey/gists{/gist_id}","starred_url":"https://api.github.com/users/lysakaleksey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysakaleksey/subscriptions","organizations_url":"https://api.github.com/users/lysakaleksey/orgs","repos_url":"https://api.github.com/users/lysakaleksey/repos","events_url":"https://api.github.com/users/lysakaleksey/events{/privacy}","received_events_url":"https://api.github.com/users/lysakaleksey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3sw/one-mq/pulls/14/commits","review_comments_url":"https://api.github.com/repos/d3sw/one-mq/pulls/14/comments","review_comment_url":"https://api.github.com/repos/d3sw/one-mq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3sw/one-mq/issues/14/comments","statuses_url":"https://api.github.com/repos/d3sw/one-mq/statuses/452a6e470bf7dad3b383d457e35d90de146f67fc","head":{"label":"d3sw:java","ref":"java","sha":"452a6e470bf7dad3b383d457e35d90de146f67fc","user":{"login":"d3sw","id":5209497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDk0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5209497?v=4","gravatar_id":"","url":"https://api.github.com/users/d3sw","html_url":"https://github.com/d3sw","followers_url":"https://api.github.com/users/d3sw/followers","following_url":"https://api.github.com/users/d3sw/following{/other_user}","gists_url":"https://api.github.com/users/d3sw/gists{/gist_id}","starred_url":"https://api.github.com/users/d3sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3sw/subscriptions","organizations_url":"https://api.github.com/users/d3sw/orgs","repos_url":"https://api.github.com/users/d3sw/repos","events_url":"https://api.github.com/users/d3sw/events{/privacy}","received_events_url":"https://api.github.com/users/d3sw/received_events","type":"Organization","site_admin":false},"repo":{"id":152366899,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzNjY4OTk=","name":"one-mq","full_name":"d3sw/one-mq","private":false,"owner":{"login":"d3sw","id":5209497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDk0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5209497?v=4","gravatar_id":"","url":"https://api.github.com/users/d3sw","html_url":"https://github.com/d3sw","followers_url":"https://api.github.com/users/d3sw/followers","following_url":"https://api.github.com/users/d3sw/following{/other_user}","gists_url":"https://api.github.com/users/d3sw/gists{/gist_id}","starred_url":"https://api.github.com/users/d3sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3sw/subscriptions","organizations_url":"https://api.github.com/users/d3sw/orgs","repos_url":"https://api.github.com/users/d3sw/repos","events_url":"https://api.github.com/users/d3sw/events{/privacy}","received_events_url":"https://api.github.com/users/d3sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/d3sw/one-mq","description":"Deluxe One message queue service client libraries","fork":false,"url":"https://api.github.com/repos/d3sw/one-mq","forks_url":"https://api.github.com/repos/d3sw/one-mq/forks","keys_url":"https://api.github.com/repos/d3sw/one-mq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3sw/one-mq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3sw/one-mq/teams","hooks_url":"https://api.github.com/repos/d3sw/one-mq/hooks","issue_events_url":"https://api.github.com/repos/d3sw/one-mq/issues/events{/number}","events_url":"https://api.github.com/repos/d3sw/one-mq/events","assignees_url":"https://api.github.com/repos/d3sw/one-mq/assignees{/user}","branches_url":"https://api.github.com/repos/d3sw/one-mq/branches{/branch}","tags_url":"https://api.github.com/repos/d3sw/one-mq/tags","blobs_url":"https://api.github.com/repos/d3sw/one-mq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3sw/one-mq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3sw/one-mq/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3sw/one-mq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3sw/one-mq/statuses/{sha}","languages_url":"https://api.github.com/repos/d3sw/one-mq/languages","stargazers_url":"https://api.github.com/repos/d3sw/one-mq/stargazers","contributors_url":"https://api.github.com/repos/d3sw/one-mq/contributors","subscribers_url":"https://api.github.com/repos/d3sw/one-mq/subscribers","subscription_url":"https://api.github.com/repos/d3sw/one-mq/subscription","commits_url":"https://api.github.com/repos/d3sw/one-mq/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3sw/one-mq/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3sw/one-mq/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3sw/one-mq/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3sw/one-mq/contents/{+path}","compare_url":"https://api.github.com/repos/d3sw/one-mq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3sw/one-mq/merges","archive_url":"https://api.github.com/repos/d3sw/one-mq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3sw/one-mq/downloads","issues_url":"https://api.github.com/repos/d3sw/one-mq/issues{/number}","pulls_url":"https://api.github.com/repos/d3sw/one-mq/pulls{/number}","milestones_url":"https://api.github.com/repos/d3sw/one-mq/milestones{/number}","notifications_url":"https://api.github.com/repos/d3sw/one-mq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3sw/one-mq/labels{/name}","releases_url":"https://api.github.com/repos/d3sw/one-mq/releases{/id}","deployments_url":"https://api.github.com/repos/d3sw/one-mq/deployments","created_at":"2018-10-10T05:17:10Z","updated_at":"2018-10-17T19:13:51Z","pushed_at":"2018-10-19T16:10:42Z","git_url":"git://github.com/d3sw/one-mq.git","ssh_url":"git@github.com:d3sw/one-mq.git","clone_url":"https://github.com/d3sw/one-mq.git","svn_url":"https://github.com/d3sw/one-mq","homepage":null,"size":344,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"d3sw:master","ref":"master","sha":"32a6825eb46f72be4df5c8b199b968d6aaabb480","user":{"login":"d3sw","id":5209497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDk0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5209497?v=4","gravatar_id":"","url":"https://api.github.com/users/d3sw","html_url":"https://github.com/d3sw","followers_url":"https://api.github.com/users/d3sw/followers","following_url":"https://api.github.com/users/d3sw/following{/other_user}","gists_url":"https://api.github.com/users/d3sw/gists{/gist_id}","starred_url":"https://api.github.com/users/d3sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3sw/subscriptions","organizations_url":"https://api.github.com/users/d3sw/orgs","repos_url":"https://api.github.com/users/d3sw/repos","events_url":"https://api.github.com/users/d3sw/events{/privacy}","received_events_url":"https://api.github.com/users/d3sw/received_events","type":"Organization","site_admin":false},"repo":{"id":152366899,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzNjY4OTk=","name":"one-mq","full_name":"d3sw/one-mq","private":false,"owner":{"login":"d3sw","id":5209497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDk0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5209497?v=4","gravatar_id":"","url":"https://api.github.com/users/d3sw","html_url":"https://github.com/d3sw","followers_url":"https://api.github.com/users/d3sw/followers","following_url":"https://api.github.com/users/d3sw/following{/other_user}","gists_url":"https://api.github.com/users/d3sw/gists{/gist_id}","starred_url":"https://api.github.com/users/d3sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3sw/subscriptions","organizations_url":"https://api.github.com/users/d3sw/orgs","repos_url":"https://api.github.com/users/d3sw/repos","events_url":"https://api.github.com/users/d3sw/events{/privacy}","received_events_url":"https://api.github.com/users/d3sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/d3sw/one-mq","description":"Deluxe One message queue service client libraries","fork":false,"url":"https://api.github.com/repos/d3sw/one-mq","forks_url":"https://api.github.com/repos/d3sw/one-mq/forks","keys_url":"https://api.github.com/repos/d3sw/one-mq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3sw/one-mq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3sw/one-mq/teams","hooks_url":"https://api.github.com/repos/d3sw/one-mq/hooks","issue_events_url":"https://api.github.com/repos/d3sw/one-mq/issues/events{/number}","events_url":"https://api.github.com/repos/d3sw/one-mq/events","assignees_url":"https://api.github.com/repos/d3sw/one-mq/assignees{/user}","branches_url":"https://api.github.com/repos/d3sw/one-mq/branches{/branch}","tags_url":"https://api.github.com/repos/d3sw/one-mq/tags","blobs_url":"https://api.github.com/repos/d3sw/one-mq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3sw/one-mq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3sw/one-mq/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3sw/one-mq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3sw/one-mq/statuses/{sha}","languages_url":"https://api.github.com/repos/d3sw/one-mq/languages","stargazers_url":"https://api.github.com/repos/d3sw/one-mq/stargazers","contributors_url":"https://api.github.com/repos/d3sw/one-mq/contributors","subscribers_url":"https://api.github.com/repos/d3sw/one-mq/subscribers","subscription_url":"https://api.github.com/repos/d3sw/one-mq/subscription","commits_url":"https://api.github.com/repos/d3sw/one-mq/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3sw/one-mq/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3sw/one-mq/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3sw/one-mq/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3sw/one-mq/contents/{+path}","compare_url":"https://api.github.com/repos/d3sw/one-mq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3sw/one-mq/merges","archive_url":"https://api.github.com/repos/d3sw/one-mq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3sw/one-mq/downloads","issues_url":"https://api.github.com/repos/d3sw/one-mq/issues{/number}","pulls_url":"https://api.github.com/repos/d3sw/one-mq/pulls{/number}","milestones_url":"https://api.github.com/repos/d3sw/one-mq/milestones{/number}","notifications_url":"https://api.github.com/repos/d3sw/one-mq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3sw/one-mq/labels{/name}","releases_url":"https://api.github.com/repos/d3sw/one-mq/releases{/id}","deployments_url":"https://api.github.com/repos/d3sw/one-mq/deployments","created_at":"2018-10-10T05:17:10Z","updated_at":"2018-10-17T19:13:51Z","pushed_at":"2018-10-19T16:10:42Z","git_url":"git://github.com/d3sw/one-mq.git","ssh_url":"git@github.com:d3sw/one-mq.git","clone_url":"https://github.com/d3sw/one-mq.git","svn_url":"https://github.com/d3sw/one-mq","homepage":null,"size":344,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/14"},"html":{"href":"https://github.com/d3sw/one-mq/pull/14"},"issue":{"href":"https://api.github.com/repos/d3sw/one-mq/issues/14"},"comments":{"href":"https://api.github.com/repos/d3sw/one-mq/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3sw/one-mq/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/d3sw/one-mq/statuses/452a6e470bf7dad3b383d457e35d90de146f67fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"JoelAtDeluxe"}}