{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments/217585141","pull_request_review_id":155333820,"id":217585141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU4NTE0MQ==","diff_hunk":"@@ -69,6 +69,17 @@ default boolean putAllPairs(Iterable<? extends Pair<? extends K, ? extends V>> p\n         return changed;\n     }\n \n+    default Iterable<? extends V> getIfAbsentPut(K key, Iterable<? extends V> value)\n+    {\n+        boolean hasKey = this.containsKey(key);\n+        if (hasKey)\n+        {\n+            this.putAll(key, value);\n+            return value;\n+        }\n+        return this.get(key);","path":"eclipse-collections-api/src/main/java/org/eclipse/collections/api/multimap/MutableMultimap.java","position":12,"original_position":12,"commit_id":"9a72c6d1fff9a5bfa8032f93fef855b205fc3960","original_commit_id":"9a72c6d1fff9a5bfa8032f93fef855b205fc3960","user":{"login":"motlin","id":244258,"node_id":"MDQ6VXNlcjI0NDI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/244258?v=4","gravatar_id":"","url":"https://api.github.com/users/motlin","html_url":"https://github.com/motlin","followers_url":"https://api.github.com/users/motlin/followers","following_url":"https://api.github.com/users/motlin/following{/other_user}","gists_url":"https://api.github.com/users/motlin/gists{/gist_id}","starred_url":"https://api.github.com/users/motlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motlin/subscriptions","organizations_url":"https://api.github.com/users/motlin/orgs","repos_url":"https://api.github.com/users/motlin/repos","events_url":"https://api.github.com/users/motlin/events{/privacy}","received_events_url":"https://api.github.com/users/motlin/received_events","type":"User","site_admin":false},"body":"Commenting here since I just saw that the other copy of this code review is closed. This looks like it's only putting if the key is present, which looks backwards.","created_at":"2018-09-14T02:17:17Z","updated_at":"2018-09-14T02:17:17Z","html_url":"https://github.com/eclipse/eclipse-collections/pull/618#discussion_r217585141","pull_request_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments/217585141"},"html":{"href":"https://github.com/eclipse/eclipse-collections/pull/618#discussion_r217585141"},"pull_request":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618","id":215458626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDU4NjI2","html_url":"https://github.com/eclipse/eclipse-collections/pull/618","diff_url":"https://github.com/eclipse/eclipse-collections/pull/618.diff","patch_url":"https://github.com/eclipse/eclipse-collections/pull/618.patch","issue_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/618","number":618,"state":"open","locked":false,"title":"Fix #566 Implement MutableMultimap.getIfAbsentPut(). ","user":{"login":"njcohen2","id":42784935,"node_id":"MDQ6VXNlcjQyNzg0OTM1","avatar_url":"https://avatars0.githubusercontent.com/u/42784935?v=4","gravatar_id":"","url":"https://api.github.com/users/njcohen2","html_url":"https://github.com/njcohen2","followers_url":"https://api.github.com/users/njcohen2/followers","following_url":"https://api.github.com/users/njcohen2/following{/other_user}","gists_url":"https://api.github.com/users/njcohen2/gists{/gist_id}","starred_url":"https://api.github.com/users/njcohen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njcohen2/subscriptions","organizations_url":"https://api.github.com/users/njcohen2/orgs","repos_url":"https://api.github.com/users/njcohen2/repos","events_url":"https://api.github.com/users/njcohen2/events{/privacy}","received_events_url":"https://api.github.com/users/njcohen2/received_events","type":"User","site_admin":false},"body":"Contributors: @tylermcdonald and @ethan-lord.\r\n\r\nSigned-off-by: Nathaniel Cohen <njc1583@gmail.com>","created_at":"2018-09-14T01:34:37Z","updated_at":"2018-09-14T02:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20cae63e50f735d5277813aba5ff7d6da8beee04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618/commits","review_comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618/comments","review_comment_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/618/comments","statuses_url":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/9a72c6d1fff9a5bfa8032f93fef855b205fc3960","head":{"label":"njcohen2:master","ref":"master","sha":"9a72c6d1fff9a5bfa8032f93fef855b205fc3960","user":{"login":"njcohen2","id":42784935,"node_id":"MDQ6VXNlcjQyNzg0OTM1","avatar_url":"https://avatars0.githubusercontent.com/u/42784935?v=4","gravatar_id":"","url":"https://api.github.com/users/njcohen2","html_url":"https://github.com/njcohen2","followers_url":"https://api.github.com/users/njcohen2/followers","following_url":"https://api.github.com/users/njcohen2/following{/other_user}","gists_url":"https://api.github.com/users/njcohen2/gists{/gist_id}","starred_url":"https://api.github.com/users/njcohen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njcohen2/subscriptions","organizations_url":"https://api.github.com/users/njcohen2/orgs","repos_url":"https://api.github.com/users/njcohen2/repos","events_url":"https://api.github.com/users/njcohen2/events{/privacy}","received_events_url":"https://api.github.com/users/njcohen2/received_events","type":"User","site_admin":false},"repo":{"id":148704865,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3MDQ4NjU=","name":"eclipse-collections","full_name":"njcohen2/eclipse-collections","owner":{"login":"njcohen2","id":42784935,"node_id":"MDQ6VXNlcjQyNzg0OTM1","avatar_url":"https://avatars0.githubusercontent.com/u/42784935?v=4","gravatar_id":"","url":"https://api.github.com/users/njcohen2","html_url":"https://github.com/njcohen2","followers_url":"https://api.github.com/users/njcohen2/followers","following_url":"https://api.github.com/users/njcohen2/following{/other_user}","gists_url":"https://api.github.com/users/njcohen2/gists{/gist_id}","starred_url":"https://api.github.com/users/njcohen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njcohen2/subscriptions","organizations_url":"https://api.github.com/users/njcohen2/orgs","repos_url":"https://api.github.com/users/njcohen2/repos","events_url":"https://api.github.com/users/njcohen2/events{/privacy}","received_events_url":"https://api.github.com/users/njcohen2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njcohen2/eclipse-collections","description":"The Eclipse Collections Project","fork":true,"url":"https://api.github.com/repos/njcohen2/eclipse-collections","forks_url":"https://api.github.com/repos/njcohen2/eclipse-collections/forks","keys_url":"https://api.github.com/repos/njcohen2/eclipse-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njcohen2/eclipse-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njcohen2/eclipse-collections/teams","hooks_url":"https://api.github.com/repos/njcohen2/eclipse-collections/hooks","issue_events_url":"https://api.github.com/repos/njcohen2/eclipse-collections/issues/events{/number}","events_url":"https://api.github.com/repos/njcohen2/eclipse-collections/events","assignees_url":"https://api.github.com/repos/njcohen2/eclipse-collections/assignees{/user}","branches_url":"https://api.github.com/repos/njcohen2/eclipse-collections/branches{/branch}","tags_url":"https://api.github.com/repos/njcohen2/eclipse-collections/tags","blobs_url":"https://api.github.com/repos/njcohen2/eclipse-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njcohen2/eclipse-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njcohen2/eclipse-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/njcohen2/eclipse-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njcohen2/eclipse-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/njcohen2/eclipse-collections/languages","stargazers_url":"https://api.github.com/repos/njcohen2/eclipse-collections/stargazers","contributors_url":"https://api.github.com/repos/njcohen2/eclipse-collections/contributors","subscribers_url":"https://api.github.com/repos/njcohen2/eclipse-collections/subscribers","subscription_url":"https://api.github.com/repos/njcohen2/eclipse-collections/subscription","commits_url":"https://api.github.com/repos/njcohen2/eclipse-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/njcohen2/eclipse-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/njcohen2/eclipse-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/njcohen2/eclipse-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/njcohen2/eclipse-collections/contents/{+path}","compare_url":"https://api.github.com/repos/njcohen2/eclipse-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njcohen2/eclipse-collections/merges","archive_url":"https://api.github.com/repos/njcohen2/eclipse-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njcohen2/eclipse-collections/downloads","issues_url":"https://api.github.com/repos/njcohen2/eclipse-collections/issues{/number}","pulls_url":"https://api.github.com/repos/njcohen2/eclipse-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/njcohen2/eclipse-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/njcohen2/eclipse-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njcohen2/eclipse-collections/labels{/name}","releases_url":"https://api.github.com/repos/njcohen2/eclipse-collections/releases{/id}","deployments_url":"https://api.github.com/repos/njcohen2/eclipse-collections/deployments","created_at":"2018-09-13T22:24:32Z","updated_at":"2018-09-14T01:08:21Z","pushed_at":"2018-09-14T01:38:36Z","git_url":"git://github.com/njcohen2/eclipse-collections.git","ssh_url":"git@github.com:njcohen2/eclipse-collections.git","clone_url":"https://github.com/njcohen2/eclipse-collections.git","svn_url":"https://github.com/njcohen2/eclipse-collections","homepage":"http://www.eclipse.org/collections","size":9833,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"f7e693f4dc39a507b777ce149e8c7d5081837635","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":46803767,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwMzc2Nw==","name":"eclipse-collections","full_name":"eclipse/eclipse-collections","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/eclipse-collections","description":"The Eclipse Collections Project","fork":false,"url":"https://api.github.com/repos/eclipse/eclipse-collections","forks_url":"https://api.github.com/repos/eclipse/eclipse-collections/forks","keys_url":"https://api.github.com/repos/eclipse/eclipse-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/eclipse-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/eclipse-collections/teams","hooks_url":"https://api.github.com/repos/eclipse/eclipse-collections/hooks","issue_events_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/eclipse-collections/events","assignees_url":"https://api.github.com/repos/eclipse/eclipse-collections/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/eclipse-collections/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/eclipse-collections/tags","blobs_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/eclipse-collections/languages","stargazers_url":"https://api.github.com/repos/eclipse/eclipse-collections/stargazers","contributors_url":"https://api.github.com/repos/eclipse/eclipse-collections/contributors","subscribers_url":"https://api.github.com/repos/eclipse/eclipse-collections/subscribers","subscription_url":"https://api.github.com/repos/eclipse/eclipse-collections/subscription","commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/eclipse-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/eclipse-collections/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/eclipse-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/eclipse-collections/merges","archive_url":"https://api.github.com/repos/eclipse/eclipse-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/eclipse-collections/downloads","issues_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/eclipse-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/eclipse-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/eclipse-collections/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/eclipse-collections/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/eclipse-collections/deployments","created_at":"2015-11-24T16:22:48Z","updated_at":"2018-09-13T23:11:39Z","pushed_at":"2018-09-14T01:34:38Z","git_url":"git://github.com/eclipse/eclipse-collections.git","ssh_url":"git@github.com:eclipse/eclipse-collections.git","clone_url":"https://github.com/eclipse/eclipse-collections.git","svn_url":"https://github.com/eclipse/eclipse-collections","homepage":"http://www.eclipse.org/collections","size":9827,"stargazers_count":788,"watchers_count":788,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":215,"open_issues":80,"watchers":788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618"},"html":{"href":"https://github.com/eclipse/eclipse-collections/pull/618"},"issue":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/issues/618"},"comments":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/eclipse-collections/statuses/9a72c6d1fff9a5bfa8032f93fef855b205fc3960"}},"author_association":"NONE"}}
{"actor":{"display_login":"motlin"}}