{"action":"closed","issue":{"url":"https://api.github.com/repos/kokkos/kokkos-kernels/issues/291","repository_url":"https://api.github.com/repos/kokkos/kokkos-kernels","labels_url":"https://api.github.com/repos/kokkos/kokkos-kernels/issues/291/labels{/name}","comments_url":"https://api.github.com/repos/kokkos/kokkos-kernels/issues/291/comments","events_url":"https://api.github.com/repos/kokkos/kokkos-kernels/issues/291/events","html_url":"https://github.com/kokkos/kokkos-kernels/issues/291","id":359558428,"node_id":"MDU6SXNzdWUzNTk1NTg0Mjg=","number":291,"title":"warning error","user":{"login":"kyungjoo-kim","id":6992602,"node_id":"MDQ6VXNlcjY5OTI2MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/6992602?v=4","gravatar_id":"","url":"https://api.github.com/users/kyungjoo-kim","html_url":"https://github.com/kyungjoo-kim","followers_url":"https://api.github.com/users/kyungjoo-kim/followers","following_url":"https://api.github.com/users/kyungjoo-kim/following{/other_user}","gists_url":"https://api.github.com/users/kyungjoo-kim/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungjoo-kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungjoo-kim/subscriptions","organizations_url":"https://api.github.com/users/kyungjoo-kim/orgs","repos_url":"https://api.github.com/users/kyungjoo-kim/repos","events_url":"https://api.github.com/users/kyungjoo-kim/events{/privacy}","received_events_url":"https://api.github.com/users/kyungjoo-kim/received_events","type":"User","site_admin":false},"labels":[{"id":555488868,"node_id":"MDU6TGFiZWw1NTU0ODg4Njg=","url":"https://api.github.com/repos/kokkos/kokkos-kernels/labels/InDevelop","name":"InDevelop","color":"bfd4f2","default":false},{"id":515546715,"node_id":"MDU6TGFiZWw1MTU1NDY3MTU=","url":"https://api.github.com/repos/kokkos/kokkos-kernels/labels/bug","name":"bug","color":"ee0701","default":true},{"id":581861597,"node_id":"MDU6TGFiZWw1ODE4NjE1OTc=","url":"https://api.github.com/repos/kokkos/kokkos-kernels/labels/bug%20fixed-in-develop","name":"bug fixed-in-develop","color":"fbca04","default":false},{"id":515546720,"node_id":"MDU6TGFiZWw1MTU1NDY3MjA=","url":"https://api.github.com/repos/kokkos/kokkos-kernels/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":{"login":"ndellingwood","id":14129110,"node_id":"MDQ6VXNlcjE0MTI5MTEw","avatar_url":"https://avatars3.githubusercontent.com/u/14129110?v=4","gravatar_id":"","url":"https://api.github.com/users/ndellingwood","html_url":"https://github.com/ndellingwood","followers_url":"https://api.github.com/users/ndellingwood/followers","following_url":"https://api.github.com/users/ndellingwood/following{/other_user}","gists_url":"https://api.github.com/users/ndellingwood/gists{/gist_id}","starred_url":"https://api.github.com/users/ndellingwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndellingwood/subscriptions","organizations_url":"https://api.github.com/users/ndellingwood/orgs","repos_url":"https://api.github.com/users/ndellingwood/repos","events_url":"https://api.github.com/users/ndellingwood/events{/privacy}","received_events_url":"https://api.github.com/users/ndellingwood/received_events","type":"User","site_admin":false},"assignees":[{"login":"ndellingwood","id":14129110,"node_id":"MDQ6VXNlcjE0MTI5MTEw","avatar_url":"https://avatars3.githubusercontent.com/u/14129110?v=4","gravatar_id":"","url":"https://api.github.com/users/ndellingwood","html_url":"https://github.com/ndellingwood","followers_url":"https://api.github.com/users/ndellingwood/followers","following_url":"https://api.github.com/users/ndellingwood/following{/other_user}","gists_url":"https://api.github.com/users/ndellingwood/gists{/gist_id}","starred_url":"https://api.github.com/users/ndellingwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndellingwood/subscriptions","organizations_url":"https://api.github.com/users/ndellingwood/orgs","repos_url":"https://api.github.com/users/ndellingwood/repos","events_url":"https://api.github.com/users/ndellingwood/events{/privacy}","received_events_url":"https://api.github.com/users/ndellingwood/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-09-12T16:24:55Z","updated_at":"2018-11-05T02:09:36Z","closed_at":"2018-11-05T02:09:36Z","author_association":"CONTRIBUTOR","body":"I am not sure if I need to put this issue on kokkos or kokkoskernels. I decided to post for both. \r\n\r\ngcc 7.2.0 and cuda 9.2.88. While compiling kokkoskernels with ``-Werror``,  I got the following warning error. Removing compiler warnings is quite annoying. In our build system, do we want to keep werror including ``int-in-bool-context`` ? I believe that we use this things many many places and it is legal anyway.\r\n\r\n```\r\n/home/kyukim/Work/lib/kokkoskernels/master/src/impl/generated_specializations_cpp/spgemm_numeric/KokkosSparse_spgemm_numeric_eti_spec_inst_doub$\r\n/ascldap/users/kyukim/Work/lib/kokkoskernels/build/white/release/kokkos/install/include/Cuda/Kokkos_CudaExec.hpp:267:42:                        \r\nerror: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]                                                               \r\n     if ( grid.x && ( block.x * block.y * block.z ) ) {   \r\n```"}}
{"actor":{"display_login":"crtrott"}}