{"action":"created","comment":{"url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments/234540744","pull_request_review_id":176199455,"id":234540744,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU0MDc0NA==","diff_hunk":"@@ -1,12 +1,24 @@\n+const Telemetry = require('../libs/telemetry').default\n+\n const { GeolocateControl } = require('mapbox-gl--ENV')\n \n /**\n * Override default GeolocateControl\n */\n+\n+const geolocationPermissions = {\n+  PROMPT : 'prompt',\n+  GRANTED : 'granted',\n+  DENIED : 'denied'\n+}\n+\n class ExtendedGeolocateControl extends GeolocateControl {\n   constructor(options, container) {\n     super(options)\n     this._container = container\n+    this.on('trackuserlocationstart', () => {\n+      Telemetry.add(Telemetry.LOCALISE_TRIGGER)","path":"src/mapbox/extended_geolocate_control.js","position":20,"original_position":20,"commit_id":"62526a5927b21d1f8179264b3ff6f6d5f190e136","original_commit_id":"62526a5927b21d1f8179264b3ff6f6d5f190e136","user":{"login":"Julien-laville","id":5485051,"node_id":"MDQ6VXNlcjU0ODUwNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5485051?v=4","gravatar_id":"","url":"https://api.github.com/users/Julien-laville","html_url":"https://github.com/Julien-laville","followers_url":"https://api.github.com/users/Julien-laville/followers","following_url":"https://api.github.com/users/Julien-laville/following{/other_user}","gists_url":"https://api.github.com/users/Julien-laville/gists{/gist_id}","starred_url":"https://api.github.com/users/Julien-laville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Julien-laville/subscriptions","organizations_url":"https://api.github.com/users/Julien-laville/orgs","repos_url":"https://api.github.com/users/Julien-laville/repos","events_url":"https://api.github.com/users/Julien-laville/events{/privacy}","received_events_url":"https://api.github.com/users/Julien-laville/received_events","type":"User","site_admin":false},"body":"i propose a new telemetry method to complete add() : addOnce().","created_at":"2018-11-19T09:15:50Z","updated_at":"2018-11-19T09:15:50Z","html_url":"https://github.com/QwantResearch/erdapfel/pull/59#discussion_r234540744","pull_request_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments/234540744"},"html":{"href":"https://github.com/QwantResearch/erdapfel/pull/59#discussion_r234540744"},"pull_request":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59"}},"in_reply_to_id":234287993},"pull_request":{"url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59","id":228722564,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzIyNTY0","html_url":"https://github.com/QwantResearch/erdapfel/pull/59","diff_url":"https://github.com/QwantResearch/erdapfel/pull/59.diff","patch_url":"https://github.com/QwantResearch/erdapfel/pull/59.patch","issue_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/59","number":59,"state":"open","locked":false,"title":"Qmaps 507 metrics","user":{"login":"Julien-laville","id":5485051,"node_id":"MDQ6VXNlcjU0ODUwNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5485051?v=4","gravatar_id":"","url":"https://api.github.com/users/Julien-laville","html_url":"https://github.com/Julien-laville","followers_url":"https://api.github.com/users/Julien-laville/followers","following_url":"https://api.github.com/users/Julien-laville/following{/other_user}","gists_url":"https://api.github.com/users/Julien-laville/gists{/gist_id}","starred_url":"https://api.github.com/users/Julien-laville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Julien-laville/subscriptions","organizations_url":"https://api.github.com/users/Julien-laville/orgs","repos_url":"https://api.github.com/users/Julien-laville/repos","events_url":"https://api.github.com/users/Julien-laville/events{/privacy}","received_events_url":"https://api.github.com/users/Julien-laville/received_events","type":"User","site_admin":false},"body":"Add common telemetry event list\r\nCreate front telemetry class\r\nAdd telemetry to\r\n-poi\r\n-fav\r\n-share\r\n-service","created_at":"2018-11-06T15:04:10Z","updated_at":"2018-11-19T09:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0c479a3dc1a87c250ffa73f360ef8376c62be8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59/commits","review_comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59/comments","review_comment_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/59/comments","statuses_url":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/62526a5927b21d1f8179264b3ff6f6d5f190e136","head":{"label":"QwantResearch:QMAPS-507_metrics","ref":"QMAPS-507_metrics","sha":"62526a5927b21d1f8179264b3ff6f6d5f190e136","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":140295292,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyOTUyOTI=","name":"erdapfel","full_name":"QwantResearch/erdapfel","private":false,"owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QwantResearch/erdapfel","description":"Qwant Maps frontend","fork":false,"url":"https://api.github.com/repos/QwantResearch/erdapfel","forks_url":"https://api.github.com/repos/QwantResearch/erdapfel/forks","keys_url":"https://api.github.com/repos/QwantResearch/erdapfel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/erdapfel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/erdapfel/teams","hooks_url":"https://api.github.com/repos/QwantResearch/erdapfel/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/erdapfel/events","assignees_url":"https://api.github.com/repos/QwantResearch/erdapfel/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/erdapfel/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/tags","blobs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/erdapfel/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/erdapfel/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/erdapfel/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscription","commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/erdapfel/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/erdapfel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/erdapfel/merges","archive_url":"https://api.github.com/repos/QwantResearch/erdapfel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/erdapfel/downloads","issues_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/erdapfel/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/erdapfel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/erdapfel/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/erdapfel/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/erdapfel/deployments","created_at":"2018-07-09T14:12:57Z","updated_at":"2018-11-18T14:44:47Z","pushed_at":"2018-11-16T16:47:17Z","git_url":"git://github.com/QwantResearch/erdapfel.git","ssh_url":"git@github.com:QwantResearch/erdapfel.git","clone_url":"https://github.com/QwantResearch/erdapfel.git","svn_url":"https://github.com/QwantResearch/erdapfel","homepage":null,"size":3104,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":8,"default_branch":"master"}},"base":{"label":"QwantResearch:master","ref":"master","sha":"106477a7cffa27daff87730606a7e887165b734b","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":140295292,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyOTUyOTI=","name":"erdapfel","full_name":"QwantResearch/erdapfel","private":false,"owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QwantResearch/erdapfel","description":"Qwant Maps frontend","fork":false,"url":"https://api.github.com/repos/QwantResearch/erdapfel","forks_url":"https://api.github.com/repos/QwantResearch/erdapfel/forks","keys_url":"https://api.github.com/repos/QwantResearch/erdapfel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/erdapfel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/erdapfel/teams","hooks_url":"https://api.github.com/repos/QwantResearch/erdapfel/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/erdapfel/events","assignees_url":"https://api.github.com/repos/QwantResearch/erdapfel/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/erdapfel/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/tags","blobs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/erdapfel/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/erdapfel/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/erdapfel/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscription","commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/erdapfel/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/erdapfel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/erdapfel/merges","archive_url":"https://api.github.com/repos/QwantResearch/erdapfel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/erdapfel/downloads","issues_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/erdapfel/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/erdapfel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/erdapfel/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/erdapfel/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/erdapfel/deployments","created_at":"2018-07-09T14:12:57Z","updated_at":"2018-11-18T14:44:47Z","pushed_at":"2018-11-16T16:47:17Z","git_url":"git://github.com/QwantResearch/erdapfel.git","ssh_url":"git@github.com:QwantResearch/erdapfel.git","clone_url":"https://github.com/QwantResearch/erdapfel.git","svn_url":"https://github.com/QwantResearch/erdapfel","homepage":null,"size":3104,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59"},"html":{"href":"https://github.com/QwantResearch/erdapfel/pull/59"},"issue":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/issues/59"},"comments":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/62526a5927b21d1f8179264b3ff6f6d5f190e136"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Julien-laville"}}