{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5","id":209809972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODA5OTcy","html_url":"https://github.com/CirkusApp/airstrings/pull/5","diff_url":"https://github.com/CirkusApp/airstrings/pull/5.diff","patch_url":"https://github.com/CirkusApp/airstrings/pull/5.patch","issue_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/5","number":5,"state":"closed","locked":false,"title":"Added support for URLs in strings' content","user":{"login":"CemerikikT","id":22577054,"node_id":"MDQ6VXNlcjIyNTc3MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/22577054?v=4","gravatar_id":"","url":"https://api.github.com/users/CemerikikT","html_url":"https://github.com/CemerikikT","followers_url":"https://api.github.com/users/CemerikikT/followers","following_url":"https://api.github.com/users/CemerikikT/following{/other_user}","gists_url":"https://api.github.com/users/CemerikikT/gists{/gist_id}","starred_url":"https://api.github.com/users/CemerikikT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CemerikikT/subscriptions","organizations_url":"https://api.github.com/users/CemerikikT/orgs","repos_url":"https://api.github.com/users/CemerikikT/repos","events_url":"https://api.github.com/users/CemerikikT/events{/privacy}","received_events_url":"https://api.github.com/users/CemerikikT/received_events","type":"User","site_admin":false},"body":"I encountered an issue while using AirStrings in the case when i had something like\r\n`\"random-string-key\" = \"visit https://www.google.com for more info\" // Example entry in Localizable.strings`\r\nIt treated the double slash in the URL as it was marking the beginning of a comment.\r\nSo in order to avoid cases where there maybe an URL in the value, or in the comment afterwards I added a regular expression `\\\";\\\\s*//` that doesn't find just the first double slash, but the first double slash that is preceded with optional empty spaces and `\";`","created_at":"2018-08-21T12:33:31Z","updated_at":"2018-08-22T09:52:08Z","closed_at":"2018-08-22T09:52:08Z","merged_at":"2018-08-22T09:52:08Z","merge_commit_sha":"798d7ef4ecfb40b8ab2b9b2455b2fb4768588d91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5/commits","review_comments_url":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5/comments","review_comment_url":"https://api.github.com/repos/CirkusApp/airstrings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/5/comments","statuses_url":"https://api.github.com/repos/CirkusApp/airstrings/statuses/798d7ef4ecfb40b8ab2b9b2455b2fb4768588d91","head":{"label":"CirkusApp:support-url-in-string-content","ref":"support-url-in-string-content","sha":"798d7ef4ecfb40b8ab2b9b2455b2fb4768588d91","user":{"login":"CirkusApp","id":38251693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjUxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/38251693?v=4","gravatar_id":"","url":"https://api.github.com/users/CirkusApp","html_url":"https://github.com/CirkusApp","followers_url":"https://api.github.com/users/CirkusApp/followers","following_url":"https://api.github.com/users/CirkusApp/following{/other_user}","gists_url":"https://api.github.com/users/CirkusApp/gists{/gist_id}","starred_url":"https://api.github.com/users/CirkusApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CirkusApp/subscriptions","organizations_url":"https://api.github.com/users/CirkusApp/orgs","repos_url":"https://api.github.com/users/CirkusApp/repos","events_url":"https://api.github.com/users/CirkusApp/events{/privacy}","received_events_url":"https://api.github.com/users/CirkusApp/received_events","type":"Organization","site_admin":false},"repo":{"id":134713599,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MTM1OTk=","name":"airstrings","full_name":"CirkusApp/airstrings","owner":{"login":"CirkusApp","id":38251693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjUxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/38251693?v=4","gravatar_id":"","url":"https://api.github.com/users/CirkusApp","html_url":"https://github.com/CirkusApp","followers_url":"https://api.github.com/users/CirkusApp/followers","following_url":"https://api.github.com/users/CirkusApp/following{/other_user}","gists_url":"https://api.github.com/users/CirkusApp/gists{/gist_id}","starred_url":"https://api.github.com/users/CirkusApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CirkusApp/subscriptions","organizations_url":"https://api.github.com/users/CirkusApp/orgs","repos_url":"https://api.github.com/users/CirkusApp/repos","events_url":"https://api.github.com/users/CirkusApp/events{/privacy}","received_events_url":"https://api.github.com/users/CirkusApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CirkusApp/airstrings","description":"CLI for localization using Google Sheets","fork":false,"url":"https://api.github.com/repos/CirkusApp/airstrings","forks_url":"https://api.github.com/repos/CirkusApp/airstrings/forks","keys_url":"https://api.github.com/repos/CirkusApp/airstrings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CirkusApp/airstrings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CirkusApp/airstrings/teams","hooks_url":"https://api.github.com/repos/CirkusApp/airstrings/hooks","issue_events_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/events{/number}","events_url":"https://api.github.com/repos/CirkusApp/airstrings/events","assignees_url":"https://api.github.com/repos/CirkusApp/airstrings/assignees{/user}","branches_url":"https://api.github.com/repos/CirkusApp/airstrings/branches{/branch}","tags_url":"https://api.github.com/repos/CirkusApp/airstrings/tags","blobs_url":"https://api.github.com/repos/CirkusApp/airstrings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CirkusApp/airstrings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CirkusApp/airstrings/git/refs{/sha}","trees_url":"https://api.github.com/repos/CirkusApp/airstrings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CirkusApp/airstrings/statuses/{sha}","languages_url":"https://api.github.com/repos/CirkusApp/airstrings/languages","stargazers_url":"https://api.github.com/repos/CirkusApp/airstrings/stargazers","contributors_url":"https://api.github.com/repos/CirkusApp/airstrings/contributors","subscribers_url":"https://api.github.com/repos/CirkusApp/airstrings/subscribers","subscription_url":"https://api.github.com/repos/CirkusApp/airstrings/subscription","commits_url":"https://api.github.com/repos/CirkusApp/airstrings/commits{/sha}","git_commits_url":"https://api.github.com/repos/CirkusApp/airstrings/git/commits{/sha}","comments_url":"https://api.github.com/repos/CirkusApp/airstrings/comments{/number}","issue_comment_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/comments{/number}","contents_url":"https://api.github.com/repos/CirkusApp/airstrings/contents/{+path}","compare_url":"https://api.github.com/repos/CirkusApp/airstrings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CirkusApp/airstrings/merges","archive_url":"https://api.github.com/repos/CirkusApp/airstrings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CirkusApp/airstrings/downloads","issues_url":"https://api.github.com/repos/CirkusApp/airstrings/issues{/number}","pulls_url":"https://api.github.com/repos/CirkusApp/airstrings/pulls{/number}","milestones_url":"https://api.github.com/repos/CirkusApp/airstrings/milestones{/number}","notifications_url":"https://api.github.com/repos/CirkusApp/airstrings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CirkusApp/airstrings/labels{/name}","releases_url":"https://api.github.com/repos/CirkusApp/airstrings/releases{/id}","deployments_url":"https://api.github.com/repos/CirkusApp/airstrings/deployments","created_at":"2018-05-24T12:40:41Z","updated_at":"2018-08-21T08:40:02Z","pushed_at":"2018-08-22T09:52:08Z","git_url":"git://github.com/CirkusApp/airstrings.git","ssh_url":"git@github.com:CirkusApp/airstrings.git","clone_url":"https://github.com/CirkusApp/airstrings.git","svn_url":"https://github.com/CirkusApp/airstrings","homepage":"https://cirkusapp.github.io/airstrings.github.io/","size":917,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"CirkusApp:master","ref":"master","sha":"5b88a416df0b80fd4ecb2323fd79508c099fdb05","user":{"login":"CirkusApp","id":38251693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjUxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/38251693?v=4","gravatar_id":"","url":"https://api.github.com/users/CirkusApp","html_url":"https://github.com/CirkusApp","followers_url":"https://api.github.com/users/CirkusApp/followers","following_url":"https://api.github.com/users/CirkusApp/following{/other_user}","gists_url":"https://api.github.com/users/CirkusApp/gists{/gist_id}","starred_url":"https://api.github.com/users/CirkusApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CirkusApp/subscriptions","organizations_url":"https://api.github.com/users/CirkusApp/orgs","repos_url":"https://api.github.com/users/CirkusApp/repos","events_url":"https://api.github.com/users/CirkusApp/events{/privacy}","received_events_url":"https://api.github.com/users/CirkusApp/received_events","type":"Organization","site_admin":false},"repo":{"id":134713599,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MTM1OTk=","name":"airstrings","full_name":"CirkusApp/airstrings","owner":{"login":"CirkusApp","id":38251693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjUxNjkz","avatar_url":"https://avatars3.githubusercontent.com/u/38251693?v=4","gravatar_id":"","url":"https://api.github.com/users/CirkusApp","html_url":"https://github.com/CirkusApp","followers_url":"https://api.github.com/users/CirkusApp/followers","following_url":"https://api.github.com/users/CirkusApp/following{/other_user}","gists_url":"https://api.github.com/users/CirkusApp/gists{/gist_id}","starred_url":"https://api.github.com/users/CirkusApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CirkusApp/subscriptions","organizations_url":"https://api.github.com/users/CirkusApp/orgs","repos_url":"https://api.github.com/users/CirkusApp/repos","events_url":"https://api.github.com/users/CirkusApp/events{/privacy}","received_events_url":"https://api.github.com/users/CirkusApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CirkusApp/airstrings","description":"CLI for localization using Google Sheets","fork":false,"url":"https://api.github.com/repos/CirkusApp/airstrings","forks_url":"https://api.github.com/repos/CirkusApp/airstrings/forks","keys_url":"https://api.github.com/repos/CirkusApp/airstrings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CirkusApp/airstrings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CirkusApp/airstrings/teams","hooks_url":"https://api.github.com/repos/CirkusApp/airstrings/hooks","issue_events_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/events{/number}","events_url":"https://api.github.com/repos/CirkusApp/airstrings/events","assignees_url":"https://api.github.com/repos/CirkusApp/airstrings/assignees{/user}","branches_url":"https://api.github.com/repos/CirkusApp/airstrings/branches{/branch}","tags_url":"https://api.github.com/repos/CirkusApp/airstrings/tags","blobs_url":"https://api.github.com/repos/CirkusApp/airstrings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CirkusApp/airstrings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CirkusApp/airstrings/git/refs{/sha}","trees_url":"https://api.github.com/repos/CirkusApp/airstrings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CirkusApp/airstrings/statuses/{sha}","languages_url":"https://api.github.com/repos/CirkusApp/airstrings/languages","stargazers_url":"https://api.github.com/repos/CirkusApp/airstrings/stargazers","contributors_url":"https://api.github.com/repos/CirkusApp/airstrings/contributors","subscribers_url":"https://api.github.com/repos/CirkusApp/airstrings/subscribers","subscription_url":"https://api.github.com/repos/CirkusApp/airstrings/subscription","commits_url":"https://api.github.com/repos/CirkusApp/airstrings/commits{/sha}","git_commits_url":"https://api.github.com/repos/CirkusApp/airstrings/git/commits{/sha}","comments_url":"https://api.github.com/repos/CirkusApp/airstrings/comments{/number}","issue_comment_url":"https://api.github.com/repos/CirkusApp/airstrings/issues/comments{/number}","contents_url":"https://api.github.com/repos/CirkusApp/airstrings/contents/{+path}","compare_url":"https://api.github.com/repos/CirkusApp/airstrings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CirkusApp/airstrings/merges","archive_url":"https://api.github.com/repos/CirkusApp/airstrings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CirkusApp/airstrings/downloads","issues_url":"https://api.github.com/repos/CirkusApp/airstrings/issues{/number}","pulls_url":"https://api.github.com/repos/CirkusApp/airstrings/pulls{/number}","milestones_url":"https://api.github.com/repos/CirkusApp/airstrings/milestones{/number}","notifications_url":"https://api.github.com/repos/CirkusApp/airstrings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CirkusApp/airstrings/labels{/name}","releases_url":"https://api.github.com/repos/CirkusApp/airstrings/releases{/id}","deployments_url":"https://api.github.com/repos/CirkusApp/airstrings/deployments","created_at":"2018-05-24T12:40:41Z","updated_at":"2018-08-21T08:40:02Z","pushed_at":"2018-08-22T09:52:08Z","git_url":"git://github.com/CirkusApp/airstrings.git","ssh_url":"git@github.com:CirkusApp/airstrings.git","clone_url":"https://github.com/CirkusApp/airstrings.git","svn_url":"https://github.com/CirkusApp/airstrings","homepage":"https://cirkusapp.github.io/airstrings.github.io/","size":917,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5"},"html":{"href":"https://github.com/CirkusApp/airstrings/pull/5"},"issue":{"href":"https://api.github.com/repos/CirkusApp/airstrings/issues/5"},"comments":{"href":"https://api.github.com/repos/CirkusApp/airstrings/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/CirkusApp/airstrings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CirkusApp/airstrings/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/CirkusApp/airstrings/statuses/798d7ef4ecfb40b8ab2b9b2455b2fb4768588d91"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CemerikikT","id":22577054,"node_id":"MDQ6VXNlcjIyNTc3MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/22577054?v=4","gravatar_id":"","url":"https://api.github.com/users/CemerikikT","html_url":"https://github.com/CemerikikT","followers_url":"https://api.github.com/users/CemerikikT/followers","following_url":"https://api.github.com/users/CemerikikT/following{/other_user}","gists_url":"https://api.github.com/users/CemerikikT/gists{/gist_id}","starred_url":"https://api.github.com/users/CemerikikT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CemerikikT/subscriptions","organizations_url":"https://api.github.com/users/CemerikikT/orgs","repos_url":"https://api.github.com/users/CemerikikT/repos","events_url":"https://api.github.com/users/CemerikikT/events{/privacy}","received_events_url":"https://api.github.com/users/CemerikikT/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"CemerikikT"}}