{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/comments/210481082","pull_request_review_id":146703770,"id":210481082,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQ4MTA4Mg==","diff_hunk":"@@ -1165,6 +1165,58 @@ synchronized public long startForwarding(LearnerHandler handler,\n     }\n     // VisibleForTesting\n     protected final Set<Long> connectingFollowers = new HashSet<Long>();\n+\n+    private volatile boolean quitWaitForEpoch = false;\n+    private volatile long timeStartWaitForEpoch = -1;\n+    private volatile SyncedLearnerTracker voteSet;\n+\n+    public static final String MIN_TIME_WAIT_FOR_EPOCH = \"zookeeper.leader.minTimeToWaitForEpoch\";","path":"src/java/main/org/apache/zookeeper/server/quorum/Leader.java","position":9,"original_position":461,"commit_id":"e0289b7963b042505530260c6c5e679311c6c631","original_commit_id":"9611393b3d4d9e1a0327a5b8bf678e526c7fc5a7","user":{"login":"hanm","id":1009243,"node_id":"MDQ6VXNlcjEwMDkyNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1009243?v=4","gravatar_id":"","url":"https://api.github.com/users/hanm","html_url":"https://github.com/hanm","followers_url":"https://api.github.com/users/hanm/followers","following_url":"https://api.github.com/users/hanm/following{/other_user}","gists_url":"https://api.github.com/users/hanm/gists{/gist_id}","starred_url":"https://api.github.com/users/hanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanm/subscriptions","organizations_url":"https://api.github.com/users/hanm/orgs","repos_url":"https://api.github.com/users/hanm/repos","events_url":"https://api.github.com/users/hanm/events{/privacy}","received_events_url":"https://api.github.com/users/hanm/received_events","type":"User","site_admin":false},"body":"MAX_TIME_TO_WAIT_FOR_EPOCH feels more intuitive for me. Also there should be some documentation of this new property in admin doc so users know its existence and how to configure it.","created_at":"2018-08-16T05:36:44Z","updated_at":"2018-08-16T05:55:53Z","html_url":"https://github.com/apache/zookeeper/pull/588#discussion_r210481082","pull_request_url":"https://api.github.com/repos/apache/zookeeper/pulls/588","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments/210481082"},"html":{"href":"https://github.com/apache/zookeeper/pull/588#discussion_r210481082"},"pull_request":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/588"}},"in_reply_to_id":207597400},"pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/588","id":205575258,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTc1MjU4","html_url":"https://github.com/apache/zookeeper/pull/588","diff_url":"https://github.com/apache/zookeeper/pull/588.diff","patch_url":"https://github.com/apache/zookeeper/pull/588.patch","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/588","number":588,"state":"open","locked":false,"title":"[ZOOKEEPER-3109] Avoid long unavailable time due to voter changed mind during leader election","user":{"login":"lvfangmin","id":2357288,"node_id":"MDQ6VXNlcjIzNTcyODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2357288?v=4","gravatar_id":"","url":"https://api.github.com/users/lvfangmin","html_url":"https://github.com/lvfangmin","followers_url":"https://api.github.com/users/lvfangmin/followers","following_url":"https://api.github.com/users/lvfangmin/following{/other_user}","gists_url":"https://api.github.com/users/lvfangmin/gists{/gist_id}","starred_url":"https://api.github.com/users/lvfangmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvfangmin/subscriptions","organizations_url":"https://api.github.com/users/lvfangmin/orgs","repos_url":"https://api.github.com/users/lvfangmin/repos","events_url":"https://api.github.com/users/lvfangmin/events{/privacy}","received_events_url":"https://api.github.com/users/lvfangmin/received_events","type":"User","site_admin":false},"body":"For more details, please check descriptions in https://issues.apache.org/jira/browse/ZOOKEEPER-3109 ","created_at":"2018-08-01T22:51:53Z","updated_at":"2018-08-16T05:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf9aae5764cc9ac0acbb755dfd2ec1373e65d60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zookeeper/pulls/588/commits","review_comments_url":"https://api.github.com/repos/apache/zookeeper/pulls/588/comments","review_comment_url":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/588/comments","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/e0289b7963b042505530260c6c5e679311c6c631","head":{"label":"lvfangmin:ZOOKEEPER-3109","ref":"ZOOKEEPER-3109","sha":"e0289b7963b042505530260c6c5e679311c6c631","user":{"login":"lvfangmin","id":2357288,"node_id":"MDQ6VXNlcjIzNTcyODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2357288?v=4","gravatar_id":"","url":"https://api.github.com/users/lvfangmin","html_url":"https://github.com/lvfangmin","followers_url":"https://api.github.com/users/lvfangmin/followers","following_url":"https://api.github.com/users/lvfangmin/following{/other_user}","gists_url":"https://api.github.com/users/lvfangmin/gists{/gist_id}","starred_url":"https://api.github.com/users/lvfangmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvfangmin/subscriptions","organizations_url":"https://api.github.com/users/lvfangmin/orgs","repos_url":"https://api.github.com/users/lvfangmin/repos","events_url":"https://api.github.com/users/lvfangmin/events{/privacy}","received_events_url":"https://api.github.com/users/lvfangmin/received_events","type":"User","site_admin":false},"repo":{"id":6470573,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwNTcz","name":"zookeeper","full_name":"lvfangmin/zookeeper","owner":{"login":"lvfangmin","id":2357288,"node_id":"MDQ6VXNlcjIzNTcyODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2357288?v=4","gravatar_id":"","url":"https://api.github.com/users/lvfangmin","html_url":"https://github.com/lvfangmin","followers_url":"https://api.github.com/users/lvfangmin/followers","following_url":"https://api.github.com/users/lvfangmin/following{/other_user}","gists_url":"https://api.github.com/users/lvfangmin/gists{/gist_id}","starred_url":"https://api.github.com/users/lvfangmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvfangmin/subscriptions","organizations_url":"https://api.github.com/users/lvfangmin/orgs","repos_url":"https://api.github.com/users/lvfangmin/repos","events_url":"https://api.github.com/users/lvfangmin/events{/privacy}","received_events_url":"https://api.github.com/users/lvfangmin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lvfangmin/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/lvfangmin/zookeeper","forks_url":"https://api.github.com/repos/lvfangmin/zookeeper/forks","keys_url":"https://api.github.com/repos/lvfangmin/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lvfangmin/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lvfangmin/zookeeper/teams","hooks_url":"https://api.github.com/repos/lvfangmin/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/lvfangmin/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/lvfangmin/zookeeper/events","assignees_url":"https://api.github.com/repos/lvfangmin/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/lvfangmin/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/lvfangmin/zookeeper/tags","blobs_url":"https://api.github.com/repos/lvfangmin/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lvfangmin/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lvfangmin/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/lvfangmin/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lvfangmin/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/lvfangmin/zookeeper/languages","stargazers_url":"https://api.github.com/repos/lvfangmin/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/lvfangmin/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/lvfangmin/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/lvfangmin/zookeeper/subscription","commits_url":"https://api.github.com/repos/lvfangmin/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/lvfangmin/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/lvfangmin/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/lvfangmin/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/lvfangmin/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/lvfangmin/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lvfangmin/zookeeper/merges","archive_url":"https://api.github.com/repos/lvfangmin/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lvfangmin/zookeeper/downloads","issues_url":"https://api.github.com/repos/lvfangmin/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/lvfangmin/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/lvfangmin/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/lvfangmin/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lvfangmin/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/lvfangmin/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/lvfangmin/zookeeper/deployments","created_at":"2012-10-31T07:59:29Z","updated_at":"2013-01-12T22:03:18Z","pushed_at":"2018-08-16T05:55:17Z","git_url":"git://github.com/lvfangmin/zookeeper.git","ssh_url":"git@github.com:lvfangmin/zookeeper.git","clone_url":"https://github.com/lvfangmin/zookeeper.git","svn_url":"https://github.com/lvfangmin/zookeeper","homepage":null,"size":26056,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:master","ref":"master","sha":"df2b3f4fd9944f0dd544b808ea3bad702534625d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":160999,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5OTk=","name":"zookeeper","full_name":"apache/zookeeper","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":false,"url":"https://api.github.com/repos/apache/zookeeper","forks_url":"https://api.github.com/repos/apache/zookeeper/forks","keys_url":"https://api.github.com/repos/apache/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zookeeper/teams","hooks_url":"https://api.github.com/repos/apache/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zookeeper/events","assignees_url":"https://api.github.com/repos/apache/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zookeeper/tags","blobs_url":"https://api.github.com/repos/apache/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zookeeper/languages","stargazers_url":"https://api.github.com/repos/apache/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/zookeeper/subscription","commits_url":"https://api.github.com/repos/apache/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zookeeper/merges","archive_url":"https://api.github.com/repos/apache/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zookeeper/downloads","issues_url":"https://api.github.com/repos/apache/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zookeeper/deployments","created_at":"2009-03-27T15:41:56Z","updated_at":"2018-08-16T03:26:30Z","pushed_at":"2018-08-16T05:55:19Z","git_url":"git://github.com/apache/zookeeper.git","ssh_url":"git@github.com:apache/zookeeper.git","clone_url":"https://github.com/apache/zookeeper.git","svn_url":"https://github.com/apache/zookeeper","homepage":null,"size":108189,"stargazers_count":4881,"watchers_count":4881,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3186,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3186,"open_issues":152,"watchers":4881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/588"},"html":{"href":"https://github.com/apache/zookeeper/pull/588"},"issue":{"href":"https://api.github.com/repos/apache/zookeeper/issues/588"},"comments":{"href":"https://api.github.com/repos/apache/zookeeper/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zookeeper/statuses/e0289b7963b042505530260c6c5e679311c6c631"}},"author_association":"NONE"}}
{"actor":{"display_login":"hanm"}}