{"action":"created","comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/comments/176690515","pull_request_review_id":106438256,"id":176690515,"diff_hunk":"@@ -209,8 +209,11 @@ def modules(self):\n \n     def set_and_check_version(self):\n         \"\"\"Get the module version, and check any requirements\"\"\"\n+        lmod_depends_on_min = '7.6.1'\n         if self.COMMAND in MODULE_VERSION_CACHE:\n             self.version = MODULE_VERSION_CACHE[self.COMMAND]\n+            self.has_depends_on = (isinstance(self, Lmod) and","path":"easybuild/tools/modules.py","position":7,"original_position":7,"commit_id":"2d9166ac7d643912e4fde5fd5b6c1bf285305f1c","original_commit_id":"2d9166ac7d643912e4fde5fd5b6c1bf285305f1c","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"I'd go with `supports_depends_on` rather than `has_depends_on`\r\n\r\n`supports_depends_on` should be set to `False` in `ModulesTool.__init__`\r\n\r\nand then in `Lmod.__init__` it should be set based on the Lmod version after the `super` call (don't use `isinstance(self, Lmod)`)","created_at":"2018-03-23T10:19:48Z","updated_at":"2018-03-23T10:30:54Z","html_url":"https://github.com/easybuilders/easybuild-framework/pull/2391#discussion_r176690515","pull_request_url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/comments/176690515"},"html":{"href":"https://github.com/easybuilders/easybuild-framework/pull/2391#discussion_r176690515"},"pull_request":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391"}}},"pull_request":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391","id":166550116,"html_url":"https://github.com/easybuilders/easybuild-framework/pull/2391","diff_url":"https://github.com/easybuilders/easybuild-framework/pull/2391.diff","patch_url":"https://github.com/easybuilders/easybuild-framework/pull/2391.patch","issue_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2391","number":2391,"state":"open","locked":false,"title":"Support Lmod 7.6+ depends_on via recursive-module-unload-depends-on.","user":{"login":"bartoldeman","id":10634630,"avatar_url":"https://avatars3.githubusercontent.com/u/10634630?v=4","gravatar_id":"","url":"https://api.github.com/users/bartoldeman","html_url":"https://github.com/bartoldeman","followers_url":"https://api.github.com/users/bartoldeman/followers","following_url":"https://api.github.com/users/bartoldeman/following{/other_user}","gists_url":"https://api.github.com/users/bartoldeman/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoldeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoldeman/subscriptions","organizations_url":"https://api.github.com/users/bartoldeman/orgs","repos_url":"https://api.github.com/users/bartoldeman/repos","events_url":"https://api.github.com/users/bartoldeman/events{/privacy}","received_events_url":"https://api.github.com/users/bartoldeman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-01T14:21:43Z","updated_at":"2018-03-23T10:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"961e50f4b8cb34624ddda06d857f48efcbf6c073","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":989297,"url":"https://api.github.com/repos/easybuilders/easybuild-framework/labels/enhancement","name":"enhancement","color":"ffaa00","default":true}],"milestone":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54","html_url":"https://github.com/easybuilders/easybuild-framework/milestone/54","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54/labels","id":3137238,"number":54,"title":"3.6.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":20,"state":"open","created_at":"2018-02-22T19:46:25Z","updated_at":"2018-03-22T12:55:10Z","due_on":"2018-04-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391/commits","review_comments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391/comments","review_comment_url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2391/comments","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-framework/statuses/2d9166ac7d643912e4fde5fd5b6c1bf285305f1c","head":{"label":"ComputeCanada:module_depends_on","ref":"module_depends_on","sha":"2d9166ac7d643912e4fde5fd5b6c1bf285305f1c","user":{"login":"ComputeCanada","id":6922267,"avatar_url":"https://avatars1.githubusercontent.com/u/6922267?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputeCanada","html_url":"https://github.com/ComputeCanada","followers_url":"https://api.github.com/users/ComputeCanada/followers","following_url":"https://api.github.com/users/ComputeCanada/following{/other_user}","gists_url":"https://api.github.com/users/ComputeCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputeCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputeCanada/subscriptions","organizations_url":"https://api.github.com/users/ComputeCanada/orgs","repos_url":"https://api.github.com/users/ComputeCanada/repos","events_url":"https://api.github.com/users/ComputeCanada/events{/privacy}","received_events_url":"https://api.github.com/users/ComputeCanada/received_events","type":"Organization","site_admin":false},"repo":{"id":73950376,"name":"easybuild-framework","full_name":"ComputeCanada/easybuild-framework","owner":{"login":"ComputeCanada","id":6922267,"avatar_url":"https://avatars1.githubusercontent.com/u/6922267?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputeCanada","html_url":"https://github.com/ComputeCanada","followers_url":"https://api.github.com/users/ComputeCanada/followers","following_url":"https://api.github.com/users/ComputeCanada/following{/other_user}","gists_url":"https://api.github.com/users/ComputeCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputeCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputeCanada/subscriptions","organizations_url":"https://api.github.com/users/ComputeCanada/orgs","repos_url":"https://api.github.com/users/ComputeCanada/repos","events_url":"https://api.github.com/users/ComputeCanada/events{/privacy}","received_events_url":"https://api.github.com/users/ComputeCanada/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputeCanada/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/ComputeCanada/easybuild-framework","forks_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/forks","keys_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/events","assignees_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/merges","archive_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ComputeCanada/easybuild-framework/deployments","created_at":"2016-11-16T18:48:16Z","updated_at":"2016-11-16T18:48:18Z","pushed_at":"2018-03-23T10:12:51Z","git_url":"git://github.com/ComputeCanada/easybuild-framework.git","ssh_url":"git@github.com:ComputeCanada/easybuild-framework.git","clone_url":"https://github.com/ComputeCanada/easybuild-framework.git","svn_url":"https://github.com/ComputeCanada/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":16351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"easybuilders:develop","ref":"develop","sha":"2608edd0fd30e6cacf2301a4d041bd7010b9a1e2","user":{"login":"easybuilders","id":29568382,"avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"easybuilders/easybuild-framework","owner":{"login":"easybuilders","id":29568382,"avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/easybuilders/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/easybuilders/easybuild-framework","forks_url":"https://api.github.com/repos/easybuilders/easybuild-framework/forks","keys_url":"https://api.github.com/repos/easybuilders/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/easybuilders/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/easybuilders/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/easybuilders/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/easybuilders/easybuild-framework/events","assignees_url":"https://api.github.com/repos/easybuilders/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/easybuilders/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/easybuilders/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/easybuilders/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/easybuilders/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/easybuilders/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/easybuilders/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/easybuilders/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/easybuilders/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/easybuilders/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/easybuilders/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/easybuilders/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/easybuilders/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/easybuilders/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/easybuilders/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/easybuilders/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/easybuilders/easybuild-framework/merges","archive_url":"https://api.github.com/repos/easybuilders/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/easybuilders/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/easybuilders/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/easybuilders/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/deployments","created_at":"2012-03-08T17:07:43Z","updated_at":"2018-03-14T20:01:35Z","pushed_at":"2018-03-22T12:55:11Z","git_url":"git://github.com/easybuilders/easybuild-framework.git","ssh_url":"git@github.com:easybuilders/easybuild-framework.git","clone_url":"https://github.com/easybuilders/easybuild-framework.git","svn_url":"https://github.com/easybuilders/easybuild-framework","homepage":"http://easybuilders.github.io/easybuild/","size":16326,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":120,"open_issues":425,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391"},"html":{"href":"https://github.com/easybuilders/easybuild-framework/pull/2391"},"issue":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2391"},"comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2391/comments"},"review_comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391/comments"},"review_comment":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/pulls/2391/commits"},"statuses":{"href":"https://api.github.com/repos/easybuilders/easybuild-framework/statuses/2d9166ac7d643912e4fde5fd5b6c1bf285305f1c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"boegel"}}