{"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/180650820","pull_request_review_id":111105276,"id":180650820,"diff_hunk":"@@ -308,8 +281,33 @@ RenderComponentWalker.prototype = {\n     visit (scene) {\n         this.reset();\n \n-        // Store all render components to _queue\n-        scene.walk(this._handleRender, this._postHandleRender);\n+        let entry = hierarchyChain.entry(scene);\n+        while (entry) {\n+            let comp = entry.comp;\n+\n+            // Pre handle\n+            if (!entry.post) {","path":"cocos2d/core/renderer/render-component-walker.js","position":61,"original_position":61,"commit_id":"3dcaf1937620d3682cae934a0b63f1a3ef3bcd30","original_commit_id":"3dcaf1937620d3682cae934a0b63f1a3ef3bcd30","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"body":"不行哦，pre 是遍历子树之前，post 是遍历完子树之后，所以遍历关系是\r\n\r\nABCCBA\r\n\r\n这样，不是两条分开的 chain","created_at":"2018-04-11T06:53:47Z","updated_at":"2018-04-11T06:53:47Z","html_url":"https://github.com/cocos-creator/engine/pull/2521#discussion_r180650820","pull_request_url":"https://api.github.com/repos/cocos-creator/engine/pulls/2521","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/180650820"},"html":{"href":"https://github.com/cocos-creator/engine/pull/2521#discussion_r180650820"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/2521"}},"in_reply_to_id":180646785},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/2521","id":180800103,"html_url":"https://github.com/cocos-creator/engine/pull/2521","diff_url":"https://github.com/cocos-creator/engine/pull/2521.diff","patch_url":"https://github.com/cocos-creator/engine/pull/2521.patch","issue_url":"https://api.github.com/repos/cocos-creator/engine/issues/2521","number":2521,"state":"open","locked":false,"title":"Visit render component with chain instead of walking scene graph","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"body":"Re: cocos-creator/fireball#7131\r\n","created_at":"2018-04-11T06:17:59Z","updated_at":"2018-04-11T06:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42b7f83f07bf744fcb81d54ed1b121b07970e860","assignee":null,"assignees":[],"requested_reviewers":[{"login":"2youyou2","id":1862402,"avatar_url":"https://avatars3.githubusercontent.com/u/1862402?v=4","gravatar_id":"","url":"https://api.github.com/users/2youyou2","html_url":"https://github.com/2youyou2","followers_url":"https://api.github.com/users/2youyou2/followers","following_url":"https://api.github.com/users/2youyou2/following{/other_user}","gists_url":"https://api.github.com/users/2youyou2/gists{/gist_id}","starred_url":"https://api.github.com/users/2youyou2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2youyou2/subscriptions","organizations_url":"https://api.github.com/users/2youyou2/orgs","repos_url":"https://api.github.com/users/2youyou2/repos","events_url":"https://api.github.com/users/2youyou2/events{/privacy}","received_events_url":"https://api.github.com/users/2youyou2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/engine/pulls/2521/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/engine/pulls/2521/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/engine/issues/2521/comments","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/3dcaf1937620d3682cae934a0b63f1a3ef3bcd30","head":{"label":"pandamicro:optimize","ref":"optimize","sha":"3dcaf1937620d3682cae934a0b63f1a3ef3bcd30","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"repo":{"id":54607274,"name":"fire-engine","full_name":"pandamicro/fire-engine","owner":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandamicro/fire-engine","description":"New integrated engine to replace cocos2d-html5","fork":true,"url":"https://api.github.com/repos/pandamicro/fire-engine","forks_url":"https://api.github.com/repos/pandamicro/fire-engine/forks","keys_url":"https://api.github.com/repos/pandamicro/fire-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandamicro/fire-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandamicro/fire-engine/teams","hooks_url":"https://api.github.com/repos/pandamicro/fire-engine/hooks","issue_events_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/events{/number}","events_url":"https://api.github.com/repos/pandamicro/fire-engine/events","assignees_url":"https://api.github.com/repos/pandamicro/fire-engine/assignees{/user}","branches_url":"https://api.github.com/repos/pandamicro/fire-engine/branches{/branch}","tags_url":"https://api.github.com/repos/pandamicro/fire-engine/tags","blobs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandamicro/fire-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandamicro/fire-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandamicro/fire-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/pandamicro/fire-engine/languages","stargazers_url":"https://api.github.com/repos/pandamicro/fire-engine/stargazers","contributors_url":"https://api.github.com/repos/pandamicro/fire-engine/contributors","subscribers_url":"https://api.github.com/repos/pandamicro/fire-engine/subscribers","subscription_url":"https://api.github.com/repos/pandamicro/fire-engine/subscription","commits_url":"https://api.github.com/repos/pandamicro/fire-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandamicro/fire-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandamicro/fire-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandamicro/fire-engine/contents/{+path}","compare_url":"https://api.github.com/repos/pandamicro/fire-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandamicro/fire-engine/merges","archive_url":"https://api.github.com/repos/pandamicro/fire-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandamicro/fire-engine/downloads","issues_url":"https://api.github.com/repos/pandamicro/fire-engine/issues{/number}","pulls_url":"https://api.github.com/repos/pandamicro/fire-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/pandamicro/fire-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/pandamicro/fire-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandamicro/fire-engine/labels{/name}","releases_url":"https://api.github.com/repos/pandamicro/fire-engine/releases{/id}","deployments_url":"https://api.github.com/repos/pandamicro/fire-engine/deployments","created_at":"2016-03-24T02:06:28Z","updated_at":"2018-03-23T10:37:08Z","pushed_at":"2018-04-11T06:17:05Z","git_url":"git://github.com/pandamicro/fire-engine.git","ssh_url":"git@github.com:pandamicro/fire-engine.git","clone_url":"https://github.com/pandamicro/fire-engine.git","svn_url":"https://github.com/pandamicro/fire-engine","homepage":null,"size":32687,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cocos-creator:optimize","ref":"optimize","sha":"6e6bdf64a9cffa36b5ca6847bc54a5c730eec496","user":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":47440536,"name":"engine","full_name":"cocos-creator/engine","owner":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/engine","description":"The engine for Cocos Creator","fork":false,"url":"https://api.github.com/repos/cocos-creator/engine","forks_url":"https://api.github.com/repos/cocos-creator/engine/forks","keys_url":"https://api.github.com/repos/cocos-creator/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/engine/teams","hooks_url":"https://api.github.com/repos/cocos-creator/engine/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/engine/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/engine/events","assignees_url":"https://api.github.com/repos/cocos-creator/engine/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/engine/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/engine/tags","blobs_url":"https://api.github.com/repos/cocos-creator/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/engine/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/engine/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/engine/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/engine/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/engine/subscription","commits_url":"https://api.github.com/repos/cocos-creator/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/engine/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/engine/merges","archive_url":"https://api.github.com/repos/cocos-creator/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/engine/downloads","issues_url":"https://api.github.com/repos/cocos-creator/engine/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/engine/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/engine/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/engine/deployments","created_at":"2015-12-05T03:28:59Z","updated_at":"2018-04-11T06:49:23Z","pushed_at":"2018-04-11T06:18:00Z","git_url":"git://github.com/cocos-creator/engine.git","ssh_url":"git@github.com:cocos-creator/engine.git","clone_url":"https://github.com/cocos-creator/engine.git","svn_url":"https://github.com/cocos-creator/engine","homepage":"http://www.cocos2d-x.org/creator","size":33887,"stargazers_count":459,"watchers_count":459,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":91,"license":null,"forks":337,"open_issues":91,"watchers":459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/2521"},"html":{"href":"https://github.com/cocos-creator/engine/pull/2521"},"issue":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/2521"},"comments":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/2521/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/2521/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/2521/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/engine/statuses/3dcaf1937620d3682cae934a0b63f1a3ef3bcd30"}},"author_association":"OWNER"}}
{"actor":{"display_login":"pandamicro"}}