{"action":"created","comment":{"url":"https://api.github.com/repos/bsm/bfs/pulls/comments/220892500","pull_request_review_id":159406143,"id":220892500,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDg5MjUwMA==","diff_hunk":"@@ -32,8 +32,11 @@ import (\n \n func init() {\n \tbfs.Register(\"file\", func(_ context.Context, u *url.URL) (bfs.Bucket, error) {\n-\t\tq := u.Query()\n-\t\treturn New(u.Path, q.Get(\"tmpdir\"))","path":"bfsfs/bfsfs.go","position":14,"original_position":14,"commit_id":"f61b476d4cb221bff7eb7c10c7593767971034ab","original_commit_id":"f61b476d4cb221bff7eb7c10c7593767971034ab","user":{"login":"mxmCherry","id":5172338,"node_id":"MDQ6VXNlcjUxNzIzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"body":"Oh, another feature request would be - let's have `http(s)://` scheme support at least for Open? Sometimes it's useful to read HTTP files using same abstraction (again, mostly for testing). With such adapter other methods could return error like \"not supported\".","created_at":"2018-09-27T11:50:21Z","updated_at":"2018-09-27T11:50:21Z","html_url":"https://github.com/bsm/bfs/pull/12#discussion_r220892500","pull_request_url":"https://api.github.com/repos/bsm/bfs/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bsm/bfs/pulls/comments/220892500"},"html":{"href":"https://github.com/bsm/bfs/pull/12#discussion_r220892500"},"pull_request":{"href":"https://api.github.com/repos/bsm/bfs/pulls/12"}},"in_reply_to_id":220614324},"pull_request":{"url":"https://api.github.com/repos/bsm/bfs/pulls/12","id":218046136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDQ2MTM2","html_url":"https://github.com/bsm/bfs/pull/12","diff_url":"https://github.com/bsm/bfs/pull/12.diff","patch_url":"https://github.com/bsm/bfs/pull/12.patch","issue_url":"https://api.github.com/repos/bsm/bfs/issues/12","number":12,"state":"open","locked":false,"title":"bfsfs: fix Resolver - set root to url Host, not Path","user":{"login":"mxmCherry","id":5172338,"node_id":"MDQ6VXNlcjUxNzIzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"body":"Roughly, to be in line with bfss3/bfsgs","created_at":"2018-09-25T16:37:27Z","updated_at":"2018-09-27T11:50:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a00b1968d2c71a117b8389206c47cf936100d78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bsm/bfs/pulls/12/commits","review_comments_url":"https://api.github.com/repos/bsm/bfs/pulls/12/comments","review_comment_url":"https://api.github.com/repos/bsm/bfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsm/bfs/issues/12/comments","statuses_url":"https://api.github.com/repos/bsm/bfs/statuses/f61b476d4cb221bff7eb7c10c7593767971034ab","head":{"label":"mxmCherry:fix/bfsfs-resolve-bucket-correct-root","ref":"fix/bfsfs-resolve-bucket-correct-root","sha":"f61b476d4cb221bff7eb7c10c7593767971034ab","user":{"login":"mxmCherry","id":5172338,"node_id":"MDQ6VXNlcjUxNzIzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"repo":{"id":150296967,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyOTY5Njc=","name":"bfs","full_name":"mxmCherry/bfs","private":false,"owner":{"login":"mxmCherry","id":5172338,"node_id":"MDQ6VXNlcjUxNzIzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mxmCherry/bfs","description":"Multi-adapter bucket-based file system abstraction. #golang","fork":true,"url":"https://api.github.com/repos/mxmCherry/bfs","forks_url":"https://api.github.com/repos/mxmCherry/bfs/forks","keys_url":"https://api.github.com/repos/mxmCherry/bfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxmCherry/bfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxmCherry/bfs/teams","hooks_url":"https://api.github.com/repos/mxmCherry/bfs/hooks","issue_events_url":"https://api.github.com/repos/mxmCherry/bfs/issues/events{/number}","events_url":"https://api.github.com/repos/mxmCherry/bfs/events","assignees_url":"https://api.github.com/repos/mxmCherry/bfs/assignees{/user}","branches_url":"https://api.github.com/repos/mxmCherry/bfs/branches{/branch}","tags_url":"https://api.github.com/repos/mxmCherry/bfs/tags","blobs_url":"https://api.github.com/repos/mxmCherry/bfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxmCherry/bfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxmCherry/bfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxmCherry/bfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxmCherry/bfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mxmCherry/bfs/languages","stargazers_url":"https://api.github.com/repos/mxmCherry/bfs/stargazers","contributors_url":"https://api.github.com/repos/mxmCherry/bfs/contributors","subscribers_url":"https://api.github.com/repos/mxmCherry/bfs/subscribers","subscription_url":"https://api.github.com/repos/mxmCherry/bfs/subscription","commits_url":"https://api.github.com/repos/mxmCherry/bfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxmCherry/bfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxmCherry/bfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxmCherry/bfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxmCherry/bfs/contents/{+path}","compare_url":"https://api.github.com/repos/mxmCherry/bfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxmCherry/bfs/merges","archive_url":"https://api.github.com/repos/mxmCherry/bfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxmCherry/bfs/downloads","issues_url":"https://api.github.com/repos/mxmCherry/bfs/issues{/number}","pulls_url":"https://api.github.com/repos/mxmCherry/bfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mxmCherry/bfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mxmCherry/bfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxmCherry/bfs/labels{/name}","releases_url":"https://api.github.com/repos/mxmCherry/bfs/releases{/id}","deployments_url":"https://api.github.com/repos/mxmCherry/bfs/deployments","created_at":"2018-09-25T16:33:55Z","updated_at":"2018-09-25T16:33:57Z","pushed_at":"2018-09-26T12:11:49Z","git_url":"git://github.com/mxmCherry/bfs.git","ssh_url":"git@github.com:mxmCherry/bfs.git","clone_url":"https://github.com/mxmCherry/bfs.git","svn_url":"https://github.com/mxmCherry/bfs","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bsm:master","ref":"master","sha":"f61529928f0d451b0624cb9b19fa90c4811a9542","user":{"login":"bsm","id":260474,"node_id":"MDQ6VXNlcjI2MDQ3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/260474?v=4","gravatar_id":"","url":"https://api.github.com/users/bsm","html_url":"https://github.com/bsm","followers_url":"https://api.github.com/users/bsm/followers","following_url":"https://api.github.com/users/bsm/following{/other_user}","gists_url":"https://api.github.com/users/bsm/gists{/gist_id}","starred_url":"https://api.github.com/users/bsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsm/subscriptions","organizations_url":"https://api.github.com/users/bsm/orgs","repos_url":"https://api.github.com/users/bsm/repos","events_url":"https://api.github.com/users/bsm/events{/privacy}","received_events_url":"https://api.github.com/users/bsm/received_events","type":"User","site_admin":false},"repo":{"id":129373391,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzNzMzOTE=","name":"bfs","full_name":"bsm/bfs","private":false,"owner":{"login":"bsm","id":260474,"node_id":"MDQ6VXNlcjI2MDQ3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/260474?v=4","gravatar_id":"","url":"https://api.github.com/users/bsm","html_url":"https://github.com/bsm","followers_url":"https://api.github.com/users/bsm/followers","following_url":"https://api.github.com/users/bsm/following{/other_user}","gists_url":"https://api.github.com/users/bsm/gists{/gist_id}","starred_url":"https://api.github.com/users/bsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsm/subscriptions","organizations_url":"https://api.github.com/users/bsm/orgs","repos_url":"https://api.github.com/users/bsm/repos","events_url":"https://api.github.com/users/bsm/events{/privacy}","received_events_url":"https://api.github.com/users/bsm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bsm/bfs","description":"Multi-adapter bucket-based file system abstraction. #golang","fork":false,"url":"https://api.github.com/repos/bsm/bfs","forks_url":"https://api.github.com/repos/bsm/bfs/forks","keys_url":"https://api.github.com/repos/bsm/bfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsm/bfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsm/bfs/teams","hooks_url":"https://api.github.com/repos/bsm/bfs/hooks","issue_events_url":"https://api.github.com/repos/bsm/bfs/issues/events{/number}","events_url":"https://api.github.com/repos/bsm/bfs/events","assignees_url":"https://api.github.com/repos/bsm/bfs/assignees{/user}","branches_url":"https://api.github.com/repos/bsm/bfs/branches{/branch}","tags_url":"https://api.github.com/repos/bsm/bfs/tags","blobs_url":"https://api.github.com/repos/bsm/bfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsm/bfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsm/bfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsm/bfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsm/bfs/statuses/{sha}","languages_url":"https://api.github.com/repos/bsm/bfs/languages","stargazers_url":"https://api.github.com/repos/bsm/bfs/stargazers","contributors_url":"https://api.github.com/repos/bsm/bfs/contributors","subscribers_url":"https://api.github.com/repos/bsm/bfs/subscribers","subscription_url":"https://api.github.com/repos/bsm/bfs/subscription","commits_url":"https://api.github.com/repos/bsm/bfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsm/bfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsm/bfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsm/bfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsm/bfs/contents/{+path}","compare_url":"https://api.github.com/repos/bsm/bfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsm/bfs/merges","archive_url":"https://api.github.com/repos/bsm/bfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsm/bfs/downloads","issues_url":"https://api.github.com/repos/bsm/bfs/issues{/number}","pulls_url":"https://api.github.com/repos/bsm/bfs/pulls{/number}","milestones_url":"https://api.github.com/repos/bsm/bfs/milestones{/number}","notifications_url":"https://api.github.com/repos/bsm/bfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsm/bfs/labels{/name}","releases_url":"https://api.github.com/repos/bsm/bfs/releases{/id}","deployments_url":"https://api.github.com/repos/bsm/bfs/deployments","created_at":"2018-04-13T08:33:41Z","updated_at":"2018-09-04T09:41:26Z","pushed_at":"2018-09-26T12:11:50Z","git_url":"git://github.com/bsm/bfs.git","ssh_url":"git@github.com:bsm/bfs.git","clone_url":"https://github.com/bsm/bfs.git","svn_url":"https://github.com/bsm/bfs","homepage":null,"size":49,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsm/bfs/pulls/12"},"html":{"href":"https://github.com/bsm/bfs/pull/12"},"issue":{"href":"https://api.github.com/repos/bsm/bfs/issues/12"},"comments":{"href":"https://api.github.com/repos/bsm/bfs/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/bsm/bfs/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/bsm/bfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsm/bfs/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/bsm/bfs/statuses/f61b476d4cb221bff7eb7c10c7593767971034ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mxmCherry"}}