{"push_id":2364123647,"size":41,"distinct_size":0,"ref":"refs/heads/master","head":"4e813c67d34465952e0ce2317971028348502b58","before":"af91bd810f915519cc00fbe7fae5cee92e36df4b","commits":[{"sha":"476f37a0301210197d73f5e775d5623bfeebbbf6","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Bundle all kythe entries, regardless of origin. (#5450)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/476f37a0301210197d73f5e775d5623bfeebbbf6"},{"sha":"01a5b5c9313cae02c8fd866c4d2524fe46952a85","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Prepare the 1.5.0dev3 release. (#5454)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/01a5b5c9313cae02c8fd866c4d2524fe46952a85"},{"sha":"569f14c2682444729340101929fee07edfd959fa","author":{"name":"Danny McClanahan","email":"6f5308fb8d084d2a533fa5443e787308f4351c3f@users.noreply.github.com"},"message":"fix/tests: subsystems can't declare dependencies on non-globally-scoped subsystems (#5456)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/569f14c2682444729340101929fee07edfd959fa"},{"sha":"9d25283baa30aa2bac091e7a67783d82ce8a1db3","author":{"name":"Daniel Wagner-Hall","email":"c40951cae4144dfc9ea230d348620fd65cad9ae8@gmail.com"},"message":"Narrow the warnings we ignore when compiling our cffi (#5458)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/9d25283baa30aa2bac091e7a67783d82ce8a1db3"},{"sha":"2885fea31d71e26d2ae686ca56cd3fbcb7444b4b","author":{"name":"Kris Wilson","email":"9f1f8f2033f372439cc56ab141cb7f446fb3689a@users.noreply.github.com"},"message":"Bump release.sh to pex 1.2.16. (#5460)\n\nThis helps pick up recent runtime changes (PEX_PYTHON_PATH et al) for pants as built as a pex.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/2885fea31d71e26d2ae686ca56cd3fbcb7444b4b"},{"sha":"2207ab6d12d7f4d877fb93192a6a41a9a27e3c00","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Qualify kythe target names with 'java-'. (#5459)\n\nAlso qualifies the names of constants pointing to Kythe main classes.\r\n\r\nThis is to prepare for indexing other languages.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/2207ab6d12d7f4d877fb93192a6a41a9a27e3c00"},{"sha":"9b5e662311d27e94045195b5b6cfefdfb202ba95","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Never allow the shader to rewrite the empty-string package. (#5461)\n\nSome files in jars (e.g., module-info.class) will confuse the shader\r\ninto trying to shade the '' package, which leads to, among other\r\nthings, rewriting every single string literal.\r\n\r\nThis change checks that a package name is not empty before\r\ncreating a shader rule from it.\r\n\r\nWhile in this code, this change also properly caches the\r\nsystem packages on the Shader class. Previously they were\r\ncached on each Shader instance, but since we don't reuse those\r\ninstances, the caching was worthless.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/9b5e662311d27e94045195b5b6cfefdfb202ba95"},{"sha":"7cdea9ac3f266d7468e8aea114ff41a09fbb0cf2","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"A convenient mechanism for fetching binary tools via subsystems (#5443)\n\nAn easy way to generate subsystems representing binary tools.\r\n\r\nThe subsystem registers an option to set the tool's version,\r\nand provides a convenient mechanism for retrieving the tool\r\nlazily as needed.\r\n\r\nProvides a convenient migration path from existing tool\r\nversion options to this standardized one.\r\n\r\nThis change switches just one usage to the new mechanism.\r\nThe others will be switched in followup changes.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/7cdea9ac3f266d7468e8aea114ff41a09fbb0cf2"},{"sha":"f55260a4e92443f47709b9cf1c9a172fa7e6d2ca","author":{"name":"Danny McClanahan","email":"6f5308fb8d084d2a533fa5443e787308f4351c3f@users.noreply.github.com"},"message":"fix/integration test for pants_requirement() (#5457)\n\n### Problem\r\n\r\nIt's not possible to use `pants_requirement()` to stand in for `python_requirement_library(requirements=[python_requirement('pantsbuild.pants==1.5.0.dev3')])` in a separate repo. This defeats the purpose of `pants_requirement()`, which expands into an `==` requirement on the pants version denoted in the repo's `pants.ini`. The error is:\r\n```\r\nu\"There is no type registered for alias <class 'pants.backend.python.targets.python_requirement_library.PythonRequirementLibrary'>\"\r\n```\r\n\r\n### Solution\r\n\r\n`ParseContext#create_object()` accepts an alias as the first argument, not the class itself. [Changing `PythonRequirementLibrary` to `'python_requirement_library'` in `src/python/pants/backend/python/pants_requirement.py`](https://github.com/cosmicexplorer/pants/blob/1fc4ba0310d3fd20d26384e5e1c356e8f99b9eea/src/python/pants/backend/python/pants_requirement.py#L37) allows `pants_requirement()` to be used as documented. Integration tests were added in `tests/python/pants_test/backend/python{test_pants_requirement_integration,/tasks/test_setup_py_integration}.py`.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/f55260a4e92443f47709b9cf1c9a172fa7e6d2ca"},{"sha":"cd228b7da2e572e7da19b492d8e248a5faf7d92e","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Fetch the buildozer binary using a subsystem. (#5462)\n\nThis is part of our transition to registering all binary tools\r\nexplicitly, instead of letting code access them arbitrarily.\r\n\r\nThis required some refactoring of the buildrefactor tasks.\r\n\r\nThis change also fixes a goof in the new protoc subsystem.\r\n\r\nIt also adds a way to specify a tool name different from\r\nthe options_scope, which is necessary here for legacy reasons.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/cd228b7da2e572e7da19b492d8e248a5faf7d92e"},{"sha":"bc58220f0ae6c31e6274cf6180804058b2308cec","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Refactor python pipeline utilities (#5474)\n\nPrimarily - when you have some standalone requirements\r\nspecified as pip-style strings, previously we injected a\r\nPythonRequirementsLibrary into the build graph for them,\r\nand then passed them down the pipeline.\r\nThis refactoring allows them to be resolved without that\r\nunnecessary hackery.\r\n\r\nThis will help get rid of some legacy cruft from\r\nthe old pipeline, such as PythonTask.\r\n\r\nAlso applies changes to two contrib tasks: eval and mypy.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/bc58220f0ae6c31e6274cf6180804058b2308cec"},{"sha":"9d3f7715ea5207cd06ea816d85d98727cc844b07","author":{"name":"Danny McClanahan","email":"6f5308fb8d084d2a533fa5443e787308f4351c3f@users.noreply.github.com"},"message":"Tweaks to the BinaryTool subsystem and use it to create an LLVM subsystem (#5471)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/9d3f7715ea5207cd06ea816d85d98727cc844b07"},{"sha":"d2b7afb401830b62f3ece4a8852e9fdb7f5bb979","author":{"name":"Danny McClanahan","email":"6f5308fb8d084d2a533fa5443e787308f4351c3f@users.noreply.github.com"},"message":"Add a dependency on the pants source to the integration test base target (#5481)\n\n### Problem\r\n\r\nIntegration test results are cached regardless of changes to source files governing their behavior.\r\n\r\n### Solution\r\n\r\nAdd a dependency on `src/python/pants/bin:pants_local_binary` to `tests/python/pants_test:int-test`, and some explanatory comments.\r\n\r\n### Result\r\n\r\nIntegration tests now depend on all relevant source files, and the results are invalidated whenever one is changed. This is obviously far too coarse, but it seems infeasible to do anything more refined without a lot of unnecessarily complex code.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/d2b7afb401830b62f3ece4a8852e9fdb7f5bb979"},{"sha":"0138d98814b82bd5004d21cafb41315fa39da825","author":{"name":"Stu Hood","email":"50abbb3a4290d1d6c08c7e8a002d0c743d331242@twitter.com"},"message":"Remove some outdated test harness code that exists in the base class (#5472)","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/0138d98814b82bd5004d21cafb41315fa39da825"},{"sha":"7788d47d856fb487629cd849e29c325bee3b5899","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Simplify python local dist handling code. (#5480)\n\nPreviously, BuildLocalPythonDistributions generated local dists and put them\r\nin products. Downstream tasks then synthesized PythonRequirementLibrary\r\ntargets to point to the local dists, if they needed to resolve them. This was clunky,\r\nand required special knowledge of local dist issues to reside in multiple downstream\r\ntasks.\r\n\r\nThis change has BuildLocalPythonDistributions itself inject the synthetic\r\nPythonRequirementLibrary targets - one per dist - and stitches them into the\r\nbuild graph. Downstream tasks no longer need to know or care about local dists\r\n(apart from declaring them as required products), they just see PythonRequirementLibrary\r\ntargets, whether synthetic or organic, and handle them uniformly.\r\n\r\nNote that previously PythonBinaryCreate had to do some footwork to ensure that only the\r\ndists depended on by a specific PythonBinary were used when creating that binary.\r\nThis now happens naturally, since we generate one requirement library per dist,\r\nand the dependencies are wired up in the right way.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/7788d47d856fb487629cd849e29c325bee3b5899"},{"sha":"c014e8de83c5c01f8517e8b3420be67e9c050c7c","author":{"name":"Daniel Wagner-Hall","email":"c40951cae4144dfc9ea230d348620fd65cad9ae8@gmail.com"},"message":"Upgrade to rust 1.24 (#5477)\n\n1.24 defaults codegen-units to 16, which parallelises some compilation\r\nstages, which is great for iteration speed, but leads to fewer\r\noptimisations being applied. Force maximum optimisation on this axis,\r\nwhen building in release mode.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/c014e8de83c5c01f8517e8b3420be67e9c050c7c"},{"sha":"71a33d65d11458ccceb67126c9dc418682e479a5","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Don't special-case python dists in resolve_requirements(). (#5483)\n\nSince we now synthesize PythonRequirementLibrary targets for\r\neach local dist, there's no need to handle them specially.\r\n\r\nAlso ensures that we always create a requirements product, even\r\nfor an empty set of requirements, so that downstream tasks\r\ndon't have to check for this case.  Removes a test that actually\r\nverified that the opposite was true, for some reason...","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/71a33d65d11458ccceb67126c9dc418682e479a5"},{"sha":"aa85487264f41b5c5856fe7d354594ca7d365c59","author":{"name":"Ny Saechao","email":"b45990c534d57a077bdc848acf34aba5d9f0a4ff@outlook.com"},"message":"Redesign JavaScript Style Checker to use ESLint directly (#5265)\n\n### Problem\r\n\r\nCurrently, the JS style checker is limited in capabilities due to being dependent on a 3rd party node package that is not well defined in code. Moreover, many features were limited because of the external undefined node package.\r\n\r\nOne such limitations is found during pants execution. A developer's working directory may include working files that is ignored by git. One such instance is when Webpack builds and bundles all javascript code into a single javascript file. A target's BUILD may include something like rglobs(*.js) which will result in pants trying to lint code that it shouldn't.\r\n\r\n### Solution\r\n\r\nMajor change: Move away from use the standard-engine framework and use eslint directly.\r\nThis provides a lot of flexibility in terms of self-bootstrapping and being able to utilize all of eslint's command-line parameters such as adding target-level ignore patterns.\r\n\r\n### Result\r\n\r\n1.) ESLint distribution is well-defined\r\n2.) Able to configure ESLint options through pants.ini\r\n3.) Able to ignore patterns on a target-level\r\n4.) Able to self-bootstrap with default rules specified by ESLint distribution.\r\n5.) Cache is versioned by package.json / yarn.lock","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/aa85487264f41b5c5856fe7d354594ca7d365c59"},{"sha":"de972ecee23b665bb76cde8b9c3293168c5e5a26","author":{"name":"Danny McClanahan","email":"6f5308fb8d084d2a533fa5443e787308f4351c3f@users.noreply.github.com"},"message":"remove support dir overrides (#5489)\n\n### Problem/Solution\r\n\r\n@benjyw and I left in some manual `get_support_dir()` overrides for the buildozer and protoc subsystems subclassing `BinaryTool` in #5471. The paths have since been copied over in s3 so that these overrides can be removed.\r\n\r\n### Result\r\n\r\n`./pants test contrib/buildrefactor/tests/python/pants_test/contrib/buildrefactor:: tests/python/pants_test/backend/codegen/protobuf/java::` succeeded locally.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/de972ecee23b665bb76cde8b9c3293168c5e5a26"},{"sha":"5d85cd7ea68087c8411a0d1d523af8b618e87dda","author":{"name":"Daniel Wagner-Hall","email":"c40951cae4144dfc9ea230d348620fd65cad9ae8@gmail.com"},"message":"Move materialize_{file,directory} from fs_util to Store (#5493)\n\nThese will be used for local process execution, so need to be re-usable.","distinct":false,"url":"https://api.github.com/repos/traviscrawford/pants/commits/5d85cd7ea68087c8411a0d1d523af8b618e87dda"}]}
{"actor":{"display_login":"traviscrawford"}}