{"action":"created","comment":{"url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/comments/193411211","pull_request_review_id":126376666,"id":193411211,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQxMTIxMQ==","diff_hunk":"@@ -205,13 +212,16 @@ class TextRenderer extends CellRenderer {\n     // Compute the X position for the text.\n     switch (hAlign) {\n     case 'left':\n-      textX = config.x + 2;\n+      textX = config.x + 8;","path":"packages/datagrid/src/textrenderer.ts","position":33,"original_position":33,"commit_id":"b167d4ec3522bc18b4f6b7123890fa99a89b3334","original_commit_id":"b167d4ec3522bc18b4f6b7123890fa99a89b3334","user":{"login":"sccolbert","id":137289,"node_id":"MDQ6VXNlcjEzNzI4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/137289?v=4","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"body":"IIRC I got the original padding values from Excel on Windows. ","created_at":"2018-06-06T13:34:58Z","updated_at":"2018-06-06T13:34:58Z","html_url":"https://github.com/phosphorjs/phosphor/pull/341#discussion_r193411211","pull_request_url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/comments/193411211"},"html":{"href":"https://github.com/phosphorjs/phosphor/pull/341#discussion_r193411211"},"pull_request":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341"}},"in_reply_to_id":192850847},"pull_request":{"url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341","id":191635637,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjM1NjM3","html_url":"https://github.com/phosphorjs/phosphor/pull/341","diff_url":"https://github.com/phosphorjs/phosphor/pull/341.diff","patch_url":"https://github.com/phosphorjs/phosphor/pull/341.patch","issue_url":"https://api.github.com/repos/phosphorjs/phosphor/issues/341","number":341,"state":"open","locked":false,"title":"Handle cell text overflow with ellipsis or clipping","user":{"login":"nmichaud","id":648190,"node_id":"MDQ6VXNlcjY0ODE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/648190?v=4","gravatar_id":"","url":"https://api.github.com/users/nmichaud","html_url":"https://github.com/nmichaud","followers_url":"https://api.github.com/users/nmichaud/followers","following_url":"https://api.github.com/users/nmichaud/following{/other_user}","gists_url":"https://api.github.com/users/nmichaud/gists{/gist_id}","starred_url":"https://api.github.com/users/nmichaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmichaud/subscriptions","organizations_url":"https://api.github.com/users/nmichaud/orgs","repos_url":"https://api.github.com/users/nmichaud/repos","events_url":"https://api.github.com/users/nmichaud/events{/privacy}","received_events_url":"https://api.github.com/users/nmichaud/received_events","type":"User","site_admin":false},"body":"This provides an option for the default TextRenderer to show ellipses instead of clipping the text at the cell boundary.","created_at":"2018-05-31T03:37:24Z","updated_at":"2018-06-06T13:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94cfd8abe4cc31371cd094a945fc94656b4a9cef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341/commits","review_comments_url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341/comments","review_comment_url":"https://api.github.com/repos/phosphorjs/phosphor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor/issues/341/comments","statuses_url":"https://api.github.com/repos/phosphorjs/phosphor/statuses/b167d4ec3522bc18b4f6b7123890fa99a89b3334","head":{"label":"nmichaud:textrenderer-overflow","ref":"textrenderer-overflow","sha":"b167d4ec3522bc18b4f6b7123890fa99a89b3334","user":{"login":"nmichaud","id":648190,"node_id":"MDQ6VXNlcjY0ODE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/648190?v=4","gravatar_id":"","url":"https://api.github.com/users/nmichaud","html_url":"https://github.com/nmichaud","followers_url":"https://api.github.com/users/nmichaud/followers","following_url":"https://api.github.com/users/nmichaud/following{/other_user}","gists_url":"https://api.github.com/users/nmichaud/gists{/gist_id}","starred_url":"https://api.github.com/users/nmichaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmichaud/subscriptions","organizations_url":"https://api.github.com/users/nmichaud/orgs","repos_url":"https://api.github.com/users/nmichaud/repos","events_url":"https://api.github.com/users/nmichaud/events{/privacy}","received_events_url":"https://api.github.com/users/nmichaud/received_events","type":"User","site_admin":false},"repo":{"id":121144519,"node_id":"MDEwOlJlcG9zaXRvcnkxMjExNDQ1MTk=","name":"phosphor","full_name":"nmichaud/phosphor","owner":{"login":"nmichaud","id":648190,"node_id":"MDQ6VXNlcjY0ODE5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/648190?v=4","gravatar_id":"","url":"https://api.github.com/users/nmichaud","html_url":"https://github.com/nmichaud","followers_url":"https://api.github.com/users/nmichaud/followers","following_url":"https://api.github.com/users/nmichaud/following{/other_user}","gists_url":"https://api.github.com/users/nmichaud/gists{/gist_id}","starred_url":"https://api.github.com/users/nmichaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmichaud/subscriptions","organizations_url":"https://api.github.com/users/nmichaud/orgs","repos_url":"https://api.github.com/users/nmichaud/repos","events_url":"https://api.github.com/users/nmichaud/events{/privacy}","received_events_url":"https://api.github.com/users/nmichaud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmichaud/phosphor","description":"The PhosphorJS Library","fork":true,"url":"https://api.github.com/repos/nmichaud/phosphor","forks_url":"https://api.github.com/repos/nmichaud/phosphor/forks","keys_url":"https://api.github.com/repos/nmichaud/phosphor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmichaud/phosphor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmichaud/phosphor/teams","hooks_url":"https://api.github.com/repos/nmichaud/phosphor/hooks","issue_events_url":"https://api.github.com/repos/nmichaud/phosphor/issues/events{/number}","events_url":"https://api.github.com/repos/nmichaud/phosphor/events","assignees_url":"https://api.github.com/repos/nmichaud/phosphor/assignees{/user}","branches_url":"https://api.github.com/repos/nmichaud/phosphor/branches{/branch}","tags_url":"https://api.github.com/repos/nmichaud/phosphor/tags","blobs_url":"https://api.github.com/repos/nmichaud/phosphor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmichaud/phosphor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmichaud/phosphor/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmichaud/phosphor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmichaud/phosphor/statuses/{sha}","languages_url":"https://api.github.com/repos/nmichaud/phosphor/languages","stargazers_url":"https://api.github.com/repos/nmichaud/phosphor/stargazers","contributors_url":"https://api.github.com/repos/nmichaud/phosphor/contributors","subscribers_url":"https://api.github.com/repos/nmichaud/phosphor/subscribers","subscription_url":"https://api.github.com/repos/nmichaud/phosphor/subscription","commits_url":"https://api.github.com/repos/nmichaud/phosphor/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmichaud/phosphor/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmichaud/phosphor/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmichaud/phosphor/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmichaud/phosphor/contents/{+path}","compare_url":"https://api.github.com/repos/nmichaud/phosphor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmichaud/phosphor/merges","archive_url":"https://api.github.com/repos/nmichaud/phosphor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmichaud/phosphor/downloads","issues_url":"https://api.github.com/repos/nmichaud/phosphor/issues{/number}","pulls_url":"https://api.github.com/repos/nmichaud/phosphor/pulls{/number}","milestones_url":"https://api.github.com/repos/nmichaud/phosphor/milestones{/number}","notifications_url":"https://api.github.com/repos/nmichaud/phosphor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmichaud/phosphor/labels{/name}","releases_url":"https://api.github.com/repos/nmichaud/phosphor/releases{/id}","deployments_url":"https://api.github.com/repos/nmichaud/phosphor/deployments","created_at":"2018-02-11T16:48:28Z","updated_at":"2018-02-11T16:48:31Z","pushed_at":"2018-05-31T03:41:32Z","git_url":"git://github.com/nmichaud/phosphor.git","ssh_url":"git@github.com:nmichaud/phosphor.git","clone_url":"https://github.com/nmichaud/phosphor.git","svn_url":"https://github.com/nmichaud/phosphor","homepage":"","size":4516,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phosphorjs:master","ref":"master","sha":"cdb412e9dfb9a987b99143e4be79d477e5136832","user":{"login":"phosphorjs","id":9534026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MzQwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/9534026?v=4","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"repo":{"id":31988820,"node_id":"MDEwOlJlcG9zaXRvcnkzMTk4ODgyMA==","name":"phosphor","full_name":"phosphorjs/phosphor","owner":{"login":"phosphorjs","id":9534026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MzQwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/9534026?v=4","gravatar_id":"","url":"https://api.github.com/users/phosphorjs","html_url":"https://github.com/phosphorjs","followers_url":"https://api.github.com/users/phosphorjs/followers","following_url":"https://api.github.com/users/phosphorjs/following{/other_user}","gists_url":"https://api.github.com/users/phosphorjs/gists{/gist_id}","starred_url":"https://api.github.com/users/phosphorjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phosphorjs/subscriptions","organizations_url":"https://api.github.com/users/phosphorjs/orgs","repos_url":"https://api.github.com/users/phosphorjs/repos","events_url":"https://api.github.com/users/phosphorjs/events{/privacy}","received_events_url":"https://api.github.com/users/phosphorjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phosphorjs/phosphor","description":"The PhosphorJS Library","fork":false,"url":"https://api.github.com/repos/phosphorjs/phosphor","forks_url":"https://api.github.com/repos/phosphorjs/phosphor/forks","keys_url":"https://api.github.com/repos/phosphorjs/phosphor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phosphorjs/phosphor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phosphorjs/phosphor/teams","hooks_url":"https://api.github.com/repos/phosphorjs/phosphor/hooks","issue_events_url":"https://api.github.com/repos/phosphorjs/phosphor/issues/events{/number}","events_url":"https://api.github.com/repos/phosphorjs/phosphor/events","assignees_url":"https://api.github.com/repos/phosphorjs/phosphor/assignees{/user}","branches_url":"https://api.github.com/repos/phosphorjs/phosphor/branches{/branch}","tags_url":"https://api.github.com/repos/phosphorjs/phosphor/tags","blobs_url":"https://api.github.com/repos/phosphorjs/phosphor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phosphorjs/phosphor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phosphorjs/phosphor/git/refs{/sha}","trees_url":"https://api.github.com/repos/phosphorjs/phosphor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phosphorjs/phosphor/statuses/{sha}","languages_url":"https://api.github.com/repos/phosphorjs/phosphor/languages","stargazers_url":"https://api.github.com/repos/phosphorjs/phosphor/stargazers","contributors_url":"https://api.github.com/repos/phosphorjs/phosphor/contributors","subscribers_url":"https://api.github.com/repos/phosphorjs/phosphor/subscribers","subscription_url":"https://api.github.com/repos/phosphorjs/phosphor/subscription","commits_url":"https://api.github.com/repos/phosphorjs/phosphor/commits{/sha}","git_commits_url":"https://api.github.com/repos/phosphorjs/phosphor/git/commits{/sha}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor/comments{/number}","issue_comment_url":"https://api.github.com/repos/phosphorjs/phosphor/issues/comments{/number}","contents_url":"https://api.github.com/repos/phosphorjs/phosphor/contents/{+path}","compare_url":"https://api.github.com/repos/phosphorjs/phosphor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phosphorjs/phosphor/merges","archive_url":"https://api.github.com/repos/phosphorjs/phosphor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phosphorjs/phosphor/downloads","issues_url":"https://api.github.com/repos/phosphorjs/phosphor/issues{/number}","pulls_url":"https://api.github.com/repos/phosphorjs/phosphor/pulls{/number}","milestones_url":"https://api.github.com/repos/phosphorjs/phosphor/milestones{/number}","notifications_url":"https://api.github.com/repos/phosphorjs/phosphor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phosphorjs/phosphor/labels{/name}","releases_url":"https://api.github.com/repos/phosphorjs/phosphor/releases{/id}","deployments_url":"https://api.github.com/repos/phosphorjs/phosphor/deployments","created_at":"2015-03-11T00:07:20Z","updated_at":"2018-06-06T02:53:55Z","pushed_at":"2018-06-05T11:02:35Z","git_url":"git://github.com/phosphorjs/phosphor.git","ssh_url":"git@github.com:phosphorjs/phosphor.git","clone_url":"https://github.com/phosphorjs/phosphor.git","svn_url":"https://github.com/phosphorjs/phosphor","homepage":"","size":4740,"stargazers_count":498,"watchers_count":498,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":68,"open_issues":47,"watchers":498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341"},"html":{"href":"https://github.com/phosphorjs/phosphor/pull/341"},"issue":{"href":"https://api.github.com/repos/phosphorjs/phosphor/issues/341"},"comments":{"href":"https://api.github.com/repos/phosphorjs/phosphor/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phosphorjs/phosphor/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/phosphorjs/phosphor/statuses/b167d4ec3522bc18b4f6b7123890fa99a89b3334"}},"author_association":"NONE"}}
{"actor":{"display_login":"sccolbert"}}