{"action":"created","comment":{"url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/comments/173610104","pull_request_review_id":102837781,"id":173610104,"diff_hunk":"@@ -1,91 +0,0 @@\n-import React from 'react';\n-import \"./SearchBar.css\";\n-\n-\n-\n-class SearchBar extends React.Component {\n-  constructor(props){\n-    super(props);\n-   \n-    this.state = {\n-        term: \" \",\n-        location: \" \",\n-        sortBy: 'best_match'\n-    } ;\n-    \n-    this.sortByOptions = {\n-      'Best Match': 'best_match',\n-      'Highest Rated': 'rating',\n-      'Most Reviewed': 'review_count'\n-      };\n-\n-    this.handleTermChange = this.handleTermChange.bind(this);\n-    this.handleLocationChange = this.handleLocationChange.bind(this);\n-    this.handleSearch = this.handleSearch.bind(this)\n-  }\n-\n-    renderSortByOptions(){\n-        return Object.keys(this.sortByOptions).map(sortByOption => {\n-          console.log(sortByOption);\n-          let sortByOptionValue = this.sortByOptions[sortByOption];\n-          console.log(sortByOptionValue)","path":"ravenous/src/components/SearchBar/SearchBar.js","position":31,"original_position":31,"commit_id":"dc5a87229e342a29125a720b8955d6d4d878bc32","original_commit_id":"dc5a87229e342a29125a720b8955d6d4d878bc32","user":{"login":"mackiedrew","id":20718044,"avatar_url":"https://avatars2.githubusercontent.com/u/20718044?v=4","gravatar_id":"","url":"https://api.github.com/users/mackiedrew","html_url":"https://github.com/mackiedrew","followers_url":"https://api.github.com/users/mackiedrew/followers","following_url":"https://api.github.com/users/mackiedrew/following{/other_user}","gists_url":"https://api.github.com/users/mackiedrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mackiedrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mackiedrew/subscriptions","organizations_url":"https://api.github.com/users/mackiedrew/orgs","repos_url":"https://api.github.com/users/mackiedrew/repos","events_url":"https://api.github.com/users/mackiedrew/events{/privacy}","received_events_url":"https://api.github.com/users/mackiedrew/received_events","type":"User","site_admin":false},"body":"Console logs are also bad to leave in usually","created_at":"2018-03-10T03:20:22Z","updated_at":"2018-03-10T03:26:26Z","html_url":"https://github.com/friedjohnnycake/Ravenous/pull/1#discussion_r173610104","pull_request_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/comments/173610104"},"html":{"href":"https://github.com/friedjohnnycake/Ravenous/pull/1#discussion_r173610104"},"pull_request":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1","id":174149540,"html_url":"https://github.com/friedjohnnycake/Ravenous/pull/1","diff_url":"https://github.com/friedjohnnycake/Ravenous/pull/1.diff","patch_url":"https://github.com/friedjohnnycake/Ravenous/pull/1.patch","issue_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/1","number":1,"state":"open","locked":false,"title":"Some notes!","user":{"login":"mackiedrew","id":20718044,"avatar_url":"https://avatars2.githubusercontent.com/u/20718044?v=4","gravatar_id":"","url":"https://api.github.com/users/mackiedrew","html_url":"https://github.com/mackiedrew","followers_url":"https://api.github.com/users/mackiedrew/followers","following_url":"https://api.github.com/users/mackiedrew/following{/other_user}","gists_url":"https://api.github.com/users/mackiedrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mackiedrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mackiedrew/subscriptions","organizations_url":"https://api.github.com/users/mackiedrew/orgs","repos_url":"https://api.github.com/users/mackiedrew/repos","events_url":"https://api.github.com/users/mackiedrew/events{/privacy}","received_events_url":"https://api.github.com/users/mackiedrew/received_events","type":"User","site_admin":false},"body":"Very nice! I thought this was quite well done. I have some modernization steps I'd like to talk about, and some code style stuff. But other than that there was very little wrong with it. Some enhancements you could make:\r\n- [ ] Add static `propTypes` and `defaultProps` to each component you can do this by adding the `prop-types` library with `npm install prop-types`\r\n- [ ] Add error handling, if you type really bad queries into the search bar you can cause the Yelp API to respond with a 400 error. You can try to handle this and display a message.\r\n- [ ] Handling 0 results, there was no way to tell if 0 results or an error was occurring.\r\n- [ ] Loading state, after the request, goes out, but before the result comes in, show some loading text.\r\n\r\nAlso I'm going to go through the code and comment on my changes and your old code so I can explain what/why I did it.","created_at":"2018-03-10T02:56:22Z","updated_at":"2018-03-10T03:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"748e291700e3779278bd1c8385b208c0472c9ce0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1/commits","review_comments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1/comments","review_comment_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/1/comments","statuses_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/statuses/dc5a87229e342a29125a720b8955d6d4d878bc32","head":{"label":"friedjohnnycake:mackie","ref":"mackie","sha":"dc5a87229e342a29125a720b8955d6d4d878bc32","user":{"login":"friedjohnnycake","id":35741205,"avatar_url":"https://avatars0.githubusercontent.com/u/35741205?v=4","gravatar_id":"","url":"https://api.github.com/users/friedjohnnycake","html_url":"https://github.com/friedjohnnycake","followers_url":"https://api.github.com/users/friedjohnnycake/followers","following_url":"https://api.github.com/users/friedjohnnycake/following{/other_user}","gists_url":"https://api.github.com/users/friedjohnnycake/gists{/gist_id}","starred_url":"https://api.github.com/users/friedjohnnycake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedjohnnycake/subscriptions","organizations_url":"https://api.github.com/users/friedjohnnycake/orgs","repos_url":"https://api.github.com/users/friedjohnnycake/repos","events_url":"https://api.github.com/users/friedjohnnycake/events{/privacy}","received_events_url":"https://api.github.com/users/friedjohnnycake/received_events","type":"User","site_admin":false},"repo":{"id":122786717,"name":"Ravenous","full_name":"friedjohnnycake/Ravenous","owner":{"login":"friedjohnnycake","id":35741205,"avatar_url":"https://avatars0.githubusercontent.com/u/35741205?v=4","gravatar_id":"","url":"https://api.github.com/users/friedjohnnycake","html_url":"https://github.com/friedjohnnycake","followers_url":"https://api.github.com/users/friedjohnnycake/followers","following_url":"https://api.github.com/users/friedjohnnycake/following{/other_user}","gists_url":"https://api.github.com/users/friedjohnnycake/gists{/gist_id}","starred_url":"https://api.github.com/users/friedjohnnycake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedjohnnycake/subscriptions","organizations_url":"https://api.github.com/users/friedjohnnycake/orgs","repos_url":"https://api.github.com/users/friedjohnnycake/repos","events_url":"https://api.github.com/users/friedjohnnycake/events{/privacy}","received_events_url":"https://api.github.com/users/friedjohnnycake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friedjohnnycake/Ravenous","description":null,"fork":false,"url":"https://api.github.com/repos/friedjohnnycake/Ravenous","forks_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/forks","keys_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/teams","hooks_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/hooks","issue_events_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/events{/number}","events_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/events","assignees_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/assignees{/user}","branches_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/branches{/branch}","tags_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/tags","blobs_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/refs{/sha}","trees_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/statuses/{sha}","languages_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/languages","stargazers_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/stargazers","contributors_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/contributors","subscribers_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/subscribers","subscription_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/subscription","commits_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/commits{/sha}","git_commits_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/commits{/sha}","comments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/comments{/number}","issue_comment_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/comments{/number}","contents_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/contents/{+path}","compare_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/merges","archive_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/downloads","issues_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues{/number}","pulls_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls{/number}","milestones_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/milestones{/number}","notifications_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/labels{/name}","releases_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/releases{/id}","deployments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/deployments","created_at":"2018-02-24T22:46:44Z","updated_at":"2018-02-24T22:47:52Z","pushed_at":"2018-03-10T02:56:22Z","git_url":"git://github.com/friedjohnnycake/Ravenous.git","ssh_url":"git@github.com:friedjohnnycake/Ravenous.git","clone_url":"https://github.com/friedjohnnycake/Ravenous.git","svn_url":"https://github.com/friedjohnnycake/Ravenous","homepage":null,"size":3801,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"friedjohnnycake:master","ref":"master","sha":"4e48020a34152fc7c4ced33e385514112a86864f","user":{"login":"friedjohnnycake","id":35741205,"avatar_url":"https://avatars0.githubusercontent.com/u/35741205?v=4","gravatar_id":"","url":"https://api.github.com/users/friedjohnnycake","html_url":"https://github.com/friedjohnnycake","followers_url":"https://api.github.com/users/friedjohnnycake/followers","following_url":"https://api.github.com/users/friedjohnnycake/following{/other_user}","gists_url":"https://api.github.com/users/friedjohnnycake/gists{/gist_id}","starred_url":"https://api.github.com/users/friedjohnnycake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedjohnnycake/subscriptions","organizations_url":"https://api.github.com/users/friedjohnnycake/orgs","repos_url":"https://api.github.com/users/friedjohnnycake/repos","events_url":"https://api.github.com/users/friedjohnnycake/events{/privacy}","received_events_url":"https://api.github.com/users/friedjohnnycake/received_events","type":"User","site_admin":false},"repo":{"id":122786717,"name":"Ravenous","full_name":"friedjohnnycake/Ravenous","owner":{"login":"friedjohnnycake","id":35741205,"avatar_url":"https://avatars0.githubusercontent.com/u/35741205?v=4","gravatar_id":"","url":"https://api.github.com/users/friedjohnnycake","html_url":"https://github.com/friedjohnnycake","followers_url":"https://api.github.com/users/friedjohnnycake/followers","following_url":"https://api.github.com/users/friedjohnnycake/following{/other_user}","gists_url":"https://api.github.com/users/friedjohnnycake/gists{/gist_id}","starred_url":"https://api.github.com/users/friedjohnnycake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedjohnnycake/subscriptions","organizations_url":"https://api.github.com/users/friedjohnnycake/orgs","repos_url":"https://api.github.com/users/friedjohnnycake/repos","events_url":"https://api.github.com/users/friedjohnnycake/events{/privacy}","received_events_url":"https://api.github.com/users/friedjohnnycake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friedjohnnycake/Ravenous","description":null,"fork":false,"url":"https://api.github.com/repos/friedjohnnycake/Ravenous","forks_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/forks","keys_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/teams","hooks_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/hooks","issue_events_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/events{/number}","events_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/events","assignees_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/assignees{/user}","branches_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/branches{/branch}","tags_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/tags","blobs_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/refs{/sha}","trees_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/statuses/{sha}","languages_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/languages","stargazers_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/stargazers","contributors_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/contributors","subscribers_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/subscribers","subscription_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/subscription","commits_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/commits{/sha}","git_commits_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/git/commits{/sha}","comments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/comments{/number}","issue_comment_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/comments{/number}","contents_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/contents/{+path}","compare_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/merges","archive_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/downloads","issues_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues{/number}","pulls_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls{/number}","milestones_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/milestones{/number}","notifications_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/labels{/name}","releases_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/releases{/id}","deployments_url":"https://api.github.com/repos/friedjohnnycake/Ravenous/deployments","created_at":"2018-02-24T22:46:44Z","updated_at":"2018-02-24T22:47:52Z","pushed_at":"2018-03-10T02:56:22Z","git_url":"git://github.com/friedjohnnycake/Ravenous.git","ssh_url":"git@github.com:friedjohnnycake/Ravenous.git","clone_url":"https://github.com/friedjohnnycake/Ravenous.git","svn_url":"https://github.com/friedjohnnycake/Ravenous","homepage":null,"size":3801,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1"},"html":{"href":"https://github.com/friedjohnnycake/Ravenous/pull/1"},"issue":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/1"},"comments":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/friedjohnnycake/Ravenous/statuses/dc5a87229e342a29125a720b8955d6d4d878bc32"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mackiedrew"}}