{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43222","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43222/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43222/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43222/events","html_url":"https://github.com/NixOS/nixpkgs/pull/43222","id":339230885,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTQ1MTMz","number":43222,"title":"nixos/udisks2: use upstream unit","user":{"login":"jtojnar","id":705123,"node_id":"MDQ6VXNlcjcwNTEyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"labels":[{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-08T14:37:40Z","updated_at":"2018-07-08T15:18:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/43222","html_url":"https://github.com/NixOS/nixpkgs/pull/43222","diff_url":"https://github.com/NixOS/nixpkgs/pull/43222.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/43222.patch"},"body":"###### Motivation for this change\r\nSimplifies the module and gets rid of the following error:\r\n\r\n> The --no-debug option is deprecated and ignored. See '--help\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/403294844","html_url":"https://github.com/NixOS/nixpkgs/pull/43222#issuecomment-403294844","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43222","id":403294844,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzI5NDg0NA==","user":{"login":"GrahamcOfBorg","id":25447658,"node_id":"MDQ6VXNlcjI1NDQ3NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25447658?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamcOfBorg","html_url":"https://github.com/GrahamcOfBorg","followers_url":"https://api.github.com/users/GrahamcOfBorg/followers","following_url":"https://api.github.com/users/GrahamcOfBorg/following{/other_user}","gists_url":"https://api.github.com/users/GrahamcOfBorg/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamcOfBorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamcOfBorg/subscriptions","organizations_url":"https://api.github.com/users/GrahamcOfBorg/orgs","repos_url":"https://api.github.com/users/GrahamcOfBorg/repos","events_url":"https://api.github.com/users/GrahamcOfBorg/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamcOfBorg/received_events","type":"User","site_admin":false},"created_at":"2018-07-08T15:18:11Z","updated_at":"2018-07-08T15:18:11Z","author_association":"NONE","body":"No attempt on x86_64-linux [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.43222&attempt_id=487816d4-645f-4721-a5b8-b445179a4d02)\n\nThe following builds were skipped because they don't evaluate on x86_64-linux: tests.udisks2\n\n<details><summary>Partial log (click to expand)</summary><p>\n\n```\nwhile evaluating ‘hydraJob’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/customisation.nix:162:14, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/release.nix:23:16:\nwhile evaluating the attribute ‘drvPath’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/customisation.nix:179:13:\nwhile evaluating the attribute ‘drvPath’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/customisation.nix:146:13:\nwhile evaluating the attribute ‘buildCommand’ of the derivation ‘vm-test-run-udisks2’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/stdenv/generic/make-derivation.nix:170:11:\nwhile evaluating the attribute ‘buildCommand’ of the derivation ‘nixos-test-driver-udisks2’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/stdenv/generic/make-derivation.nix:170:11:\nwhile evaluating the attribute ‘buildCommand’ of the derivation ‘nixos-vm’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/stdenv/generic/make-derivation.nix:170:11:\nwhile evaluating the attribute ‘text’ of the derivation ‘run-nixos-vm’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/stdenv/generic/make-derivation.nix:170:11:\nwhile evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/build-support/closure-info.nix:9:1, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/modules/virtualisation/qemu-vm.nix:121:13:\nassertion failed at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/build-support/closure-info.nix:11:1\n\n```\n</p></details>\n\n"}}
{"actor":{"display_login":"GrahamcOfBorg"}}