{"action":"closed","number":965,"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965","id":200041606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDQxNjA2","html_url":"https://github.com/vert-x3/vertx-web/pull/965","diff_url":"https://github.com/vert-x3/vertx-web/pull/965.diff","patch_url":"https://github.com/vert-x3/vertx-web/pull/965.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/965","number":965,"state":"closed","locked":false,"title":"Do not override CORS for SockJS","user":{"login":"pmlopes","id":849467,"node_id":"MDQ6VXNlcjg0OTQ2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/849467?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"body":"Fixes #649\r\n\r\nDoes not override CORS headers if headers have been set by for example the CORS handler. It also respects the requirement that user credentials are not allowed for wildcard origin","created_at":"2018-07-09T09:31:56Z","updated_at":"2018-07-10T09:12:45Z","closed_at":"2018-07-10T09:12:45Z","merged_at":"2018-07-10T09:12:44Z","merge_commit_sha":"0e85e3fe2b74e513b4ff62146431f64701ff1ab7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":234665676,"node_id":"MDU6TGFiZWwyMzQ2NjU2NzY=","url":"https://api.github.com/repos/vert-x3/vertx-web/labels/to%20review","name":"to review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/vert-x3/vertx-web/milestones/9","html_url":"https://github.com/vert-x3/vertx-web/milestone/9","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/milestones/9/labels","id":3106859,"node_id":"MDk6TWlsZXN0b25lMzEwNjg1OQ==","number":9,"title":"3.6.0","description":null,"creator":{"login":"vietj","id":225674,"node_id":"MDQ6VXNlcjIyNTY3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/225674?v=4","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":22,"state":"open","created_at":"2018-02-12T07:40:24Z","updated_at":"2018-07-10T09:12:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/965/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-web/statuses/237dfefd66a44872771ce2fd16a650852081a498","head":{"label":"vert-x3:issues/do-not-verride-cors-for-sockjs","ref":"issues/do-not-verride-cors-for-sockjs","sha":"237dfefd66a44872771ce2fd16a650852081a498","user":{"login":"vert-x3","id":8124623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjQ2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":26628954,"node_id":"MDEwOlJlcG9zaXRvcnkyNjYyODk1NA==","name":"vertx-web","full_name":"vert-x3/vertx-web","owner":{"login":"vert-x3","id":8124623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjQ2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-web","description":"HTTP web applications for Vert.x","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-web","forks_url":"https://api.github.com/repos/vert-x3/vertx-web/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-web/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-web/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-web/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-web/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-web/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-web/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-web/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-web/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-web/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-web/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-web/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-web/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-web/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-web/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-web/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-web/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-web/deployments","created_at":"2014-11-14T08:15:20Z","updated_at":"2018-07-10T02:03:00Z","pushed_at":"2018-07-10T09:12:44Z","git_url":"git://github.com/vert-x3/vertx-web.git","ssh_url":"git@github.com:vert-x3/vertx-web.git","clone_url":"https://github.com/vert-x3/vertx-web.git","svn_url":"https://github.com/vert-x3/vertx-web","homepage":"","size":12037,"stargazers_count":459,"watchers_count":459,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":247,"open_issues":136,"watchers":459,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"6a3666476037b35d1f093c136a8070ed31693baa","user":{"login":"vert-x3","id":8124623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjQ2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":26628954,"node_id":"MDEwOlJlcG9zaXRvcnkyNjYyODk1NA==","name":"vertx-web","full_name":"vert-x3/vertx-web","owner":{"login":"vert-x3","id":8124623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMjQ2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-web","description":"HTTP web applications for Vert.x","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-web","forks_url":"https://api.github.com/repos/vert-x3/vertx-web/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-web/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-web/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-web/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-web/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-web/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-web/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-web/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-web/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-web/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-web/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-web/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-web/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-web/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-web/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-web/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-web/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-web/deployments","created_at":"2014-11-14T08:15:20Z","updated_at":"2018-07-10T02:03:00Z","pushed_at":"2018-07-10T09:12:44Z","git_url":"git://github.com/vert-x3/vertx-web.git","ssh_url":"git@github.com:vert-x3/vertx-web.git","clone_url":"https://github.com/vert-x3/vertx-web.git","svn_url":"https://github.com/vert-x3/vertx-web","homepage":"","size":12037,"stargazers_count":459,"watchers_count":459,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":247,"open_issues":136,"watchers":459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965"},"html":{"href":"https://github.com/vert-x3/vertx-web/pull/965"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-web/issues/965"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-web/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-web/statuses/237dfefd66a44872771ce2fd16a650852081a498"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pmlopes","id":849467,"node_id":"MDQ6VXNlcjg0OTQ2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/849467?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"pmlopes"}}