{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/1120","repository_url":"https://api.github.com/repos/chef/chef","labels_url":"https://api.github.com/repos/chef/chef/issues/1120/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/1120/comments","events_url":"https://api.github.com/repos/chef/chef/issues/1120/events","html_url":"https://github.com/chef/chef/pull/1120","id":22247438,"node_id":"MDExOlB1bGxSZXF1ZXN0OTc0NzY2Nw==","number":1120,"title":"CHEF-3511: call chkconfig --add instead of on","user":{"login":"dsp-eoss","id":4979501,"node_id":"MDQ6VXNlcjQ5Nzk1MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4979501?v=4","gravatar_id":"","url":"https://api.github.com/users/dsp-eoss","html_url":"https://github.com/dsp-eoss","followers_url":"https://api.github.com/users/dsp-eoss/followers","following_url":"https://api.github.com/users/dsp-eoss/following{/other_user}","gists_url":"https://api.github.com/users/dsp-eoss/gists{/gist_id}","starred_url":"https://api.github.com/users/dsp-eoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsp-eoss/subscriptions","organizations_url":"https://api.github.com/users/dsp-eoss/orgs","repos_url":"https://api.github.com/users/dsp-eoss/repos","events_url":"https://api.github.com/users/dsp-eoss/events{/privacy}","received_events_url":"https://api.github.com/users/dsp-eoss/received_events","type":"User","site_admin":false},"labels":[{"id":120015508,"node_id":"MDU6TGFiZWwxMjAwMTU1MDg=","url":"https://api.github.com/repos/chef/chef/labels/Area:%20Enterprise%20Linux","name":"Area: Enterprise Linux","color":"d4c5f9","default":false},{"id":525672508,"node_id":"MDU6TGFiZWw1MjU2NzI1MDg=","url":"https://api.github.com/repos/chef/chef/labels/Priority:%20Critical","name":"Priority: Critical","color":"eb6420","default":false},{"id":525672311,"node_id":"MDU6TGFiZWw1MjU2NzIzMTE=","url":"https://api.github.com/repos/chef/chef/labels/Status:%20Finish%20for%20Merge","name":"Status: Finish for Merge","color":"0052cc","default":false},{"id":525666751,"node_id":"MDU6TGFiZWw1MjU2NjY3NTE=","url":"https://api.github.com/repos/chef/chef/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"assignees":[{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/chef/chef/milestones/13","html_url":"https://github.com/chef/chef/milestone/13","labels_url":"https://api.github.com/repos/chef/chef/milestones/13/labels","id":975715,"node_id":"MDk6TWlsZXN0b25lOTc1NzE1","number":13,"title":"Accepted Minor","description":"Bucket to pull issues from for next minor. These issues should be fixable without needing a *major* version bump per semver; they're unlikely to cause a compatibility break or an API change.","creator":{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"open_issues":192,"closed_issues":306,"state":"open","created_at":"2015-02-11T18:42:48Z","updated_at":"2018-07-17T17:06:47Z","due_on":null,"closed_at":null},"comments":22,"created_at":"2013-11-07T06:42:51Z","updated_at":"2018-07-17T17:06:47Z","closed_at":"2018-07-17T17:06:46Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/1120","html_url":"https://github.com/chef/chef/pull/1120","diff_url":"https://github.com/chef/chef/pull/1120.diff","patch_url":"https://github.com/chef/chef/pull/1120.patch"},"body":"The correct way to enable a service on RHEL for chkconfig management\nis to pass chkconfig the --add option; passing it on instead will\nresult in it ignoring the service's init script's chkconfig lines or\nLSB stanza, enabling it for default runlevels and skipping kill\nentry creation.\n"},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/405655979","html_url":"https://github.com/chef/chef/pull/1120#issuecomment-405655979","issue_url":"https://api.github.com/repos/chef/chef/issues/1120","id":405655979,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTY1NTk3OQ==","user":{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T17:06:46Z","updated_at":"2018-07-17T17:06:46Z","author_association":"CONTRIBUTOR","body":"I think I'm going to close this as not the responsibility of the service provider.\r\n\r\nThe title as stated is incorrect, \"--add\" is what you must call to add a new initscript, \"enable\" is what you need to call to enable it.  If enable doesn't enable the right runlevels then the service provider should be passed the levels property that was added in #3793.\r\n\r\nThe normal way that `chkconfig --add` is called is via the post install script in an RPM.  If the user is dropping a cookbook_file or template in then they should construct code like:\r\n\r\n```ruby\r\ntemplate '/etc/init.d/foo' do\r\n  source 'foo-init.erb'\r\n  notifies :run, 'execute[chkconfig-add-foo]', :immediately\r\nend\r\n\r\nexecute 'chkconfig-add-foo' do\r\n  command '/sbin/chkconfig --add foo'\r\n  action :nothing\r\nend\r\n```\r\n\r\nAnd if a package install doesn't correctly `--add` the init script then a notification can be hung off of the package resource instead of a template.\r\n\r\nHaving the enable action override the LSB settings in the init script duplicates the command line, and is the responsibility of the system admin to correctly use the `--levels` argument if they want to replicate the settings in the initscript.  I don't know why RedHat behaves this way, but this is the same as the command line.  The alternative of only using `--add` is just going to get into warfare between users who expect one behavior and uses who expect the other kind of behavior.  If you feel the behavior is incorrect for a service, then you're really fighting with chkconfig's own API and again you can manually roll your own `chkconfig --add` command and use the `levels` option to `:enable` or skip using `:enable` entirely.\r\n\r\nAdding an `:add` action to the service resource doesn't create a useful abstraction since the caller is still going to be responsible for writing e.g. platform-specific code to avoid calling `:add` on platforms other than redhat."}}
{"actor":{"display_login":"lamont-granquist"}}