{"action":"created","comment":{"url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/comments/239990537","pull_request_review_id":182928582,"id":239990537,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk5MDUzNw==","diff_hunk":"@@ -17,16 +20,19 @@\n \t@Autowired\n \tDBConnectionInfoMgr dBConnectionInfoMgr;\n \t\n-\tpublic DatabaseProvider getInstance(String shardId){\n+\t@Autowired\n+\tAdvisoryLoader advisoryLoader;\n+\t\t\n+\tpublic DatabaseProvider getInstance(String property, String value) throws IOException{","path":"java/registry/src/main/java/io/opensaber/registry/sink/DBShard.java","position":24,"original_position":24,"commit_id":"4c17a036f96cfe0b3bc8628ee1d7dcafa34f5bae","original_commit_id":"4c17a036f96cfe0b3bc8628ee1d7dcafa34f5bae","user":{"login":"indrajra","id":14975444,"node_id":"MDQ6VXNlcjE0OTc1NDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/14975444?v=4","gravatar_id":"","url":"https://api.github.com/users/indrajra","html_url":"https://github.com/indrajra","followers_url":"https://api.github.com/users/indrajra/followers","following_url":"https://api.github.com/users/indrajra/following{/other_user}","gists_url":"https://api.github.com/users/indrajra/gists{/gist_id}","starred_url":"https://api.github.com/users/indrajra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indrajra/subscriptions","organizations_url":"https://api.github.com/users/indrajra/orgs","repos_url":"https://api.github.com/users/indrajra/repos","events_url":"https://api.github.com/users/indrajra/events{/privacy}","received_events_url":"https://api.github.com/users/indrajra/received_events","type":"User","site_admin":false},"body":"I thought the DBShard just manages the connection. It does not need to know the attribute, value details. Given a shardId or connectionInfo, it merely gives initializes a provider. All this must either go to a separate class or this class be re-invented.\r\nTreat DBShard as one that can just give a 'graph' instance, when you supply a connectionInfo.\r\nTreat Advisor as one that merely advises the connectionInfo to be used for a given attribute value.\r\nTreat X (to be invented) as one that can handle both the above classes and give you 'graph' instance.","created_at":"2018-12-08T02:47:04Z","updated_at":"2018-12-08T02:47:31Z","html_url":"https://github.com/pritha-tarento/open-saber/pull/3#discussion_r239990537","pull_request_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/comments/239990537"},"html":{"href":"https://github.com/pritha-tarento/open-saber/pull/3#discussion_r239990537"},"pull_request":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3","id":236862614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODYyNjE0","html_url":"https://github.com/pritha-tarento/open-saber/pull/3","diff_url":"https://github.com/pritha-tarento/open-saber/pull/3.diff","patch_url":"https://github.com/pritha-tarento/open-saber/pull/3.patch","issue_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/3","number":3,"state":"open","locked":false,"title":"Issue #OS-131 Shard advisory for serialnum property","user":{"login":"pritha-tarento","id":42533384,"node_id":"MDQ6VXNlcjQyNTMzMzg0","avatar_url":"https://avatars0.githubusercontent.com/u/42533384?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-tarento","html_url":"https://github.com/pritha-tarento","followers_url":"https://api.github.com/users/pritha-tarento/followers","following_url":"https://api.github.com/users/pritha-tarento/following{/other_user}","gists_url":"https://api.github.com/users/pritha-tarento/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-tarento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-tarento/subscriptions","organizations_url":"https://api.github.com/users/pritha-tarento/orgs","repos_url":"https://api.github.com/users/pritha-tarento/repos","events_url":"https://api.github.com/users/pritha-tarento/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-tarento/received_events","type":"User","site_admin":false},"body":"Indroduced Shard advisor.\r\nAdded interface IShardAdvisory\r\nSingle sample impl for serial number property.\r\nAdvisoryLoader for registering the impl with property, this suppose to get pre loaded.\r\nShard factory intiatiate a connection with help of AdvisoryLoader .\r\n\r\n","created_at":"2018-12-07T13:07:53Z","updated_at":"2018-12-08T02:47:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5db5090db9d2723bb3e65af30ee3be39095d57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/3/comments","statuses_url":"https://api.github.com/repos/pritha-tarento/open-saber/statuses/4c17a036f96cfe0b3bc8628ee1d7dcafa34f5bae","head":{"label":"pritha-tarento:OS-131","ref":"OS-131","sha":"4c17a036f96cfe0b3bc8628ee1d7dcafa34f5bae","user":{"login":"pritha-tarento","id":42533384,"node_id":"MDQ6VXNlcjQyNTMzMzg0","avatar_url":"https://avatars0.githubusercontent.com/u/42533384?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-tarento","html_url":"https://github.com/pritha-tarento","followers_url":"https://api.github.com/users/pritha-tarento/followers","following_url":"https://api.github.com/users/pritha-tarento/following{/other_user}","gists_url":"https://api.github.com/users/pritha-tarento/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-tarento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-tarento/subscriptions","organizations_url":"https://api.github.com/users/pritha-tarento/orgs","repos_url":"https://api.github.com/users/pritha-tarento/repos","events_url":"https://api.github.com/users/pritha-tarento/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-tarento/received_events","type":"User","site_admin":false},"repo":{"id":160312873,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzMTI4NzM=","name":"open-saber","full_name":"pritha-tarento/open-saber","private":false,"owner":{"login":"pritha-tarento","id":42533384,"node_id":"MDQ6VXNlcjQyNTMzMzg0","avatar_url":"https://avatars0.githubusercontent.com/u/42533384?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-tarento","html_url":"https://github.com/pritha-tarento","followers_url":"https://api.github.com/users/pritha-tarento/followers","following_url":"https://api.github.com/users/pritha-tarento/following{/other_user}","gists_url":"https://api.github.com/users/pritha-tarento/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-tarento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-tarento/subscriptions","organizations_url":"https://api.github.com/users/pritha-tarento/orgs","repos_url":"https://api.github.com/users/pritha-tarento/repos","events_url":"https://api.github.com/users/pritha-tarento/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-tarento/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pritha-tarento/open-saber","description":"Registry team","fork":true,"url":"https://api.github.com/repos/pritha-tarento/open-saber","forks_url":"https://api.github.com/repos/pritha-tarento/open-saber/forks","keys_url":"https://api.github.com/repos/pritha-tarento/open-saber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pritha-tarento/open-saber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pritha-tarento/open-saber/teams","hooks_url":"https://api.github.com/repos/pritha-tarento/open-saber/hooks","issue_events_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/events{/number}","events_url":"https://api.github.com/repos/pritha-tarento/open-saber/events","assignees_url":"https://api.github.com/repos/pritha-tarento/open-saber/assignees{/user}","branches_url":"https://api.github.com/repos/pritha-tarento/open-saber/branches{/branch}","tags_url":"https://api.github.com/repos/pritha-tarento/open-saber/tags","blobs_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/refs{/sha}","trees_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pritha-tarento/open-saber/statuses/{sha}","languages_url":"https://api.github.com/repos/pritha-tarento/open-saber/languages","stargazers_url":"https://api.github.com/repos/pritha-tarento/open-saber/stargazers","contributors_url":"https://api.github.com/repos/pritha-tarento/open-saber/contributors","subscribers_url":"https://api.github.com/repos/pritha-tarento/open-saber/subscribers","subscription_url":"https://api.github.com/repos/pritha-tarento/open-saber/subscription","commits_url":"https://api.github.com/repos/pritha-tarento/open-saber/commits{/sha}","git_commits_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/commits{/sha}","comments_url":"https://api.github.com/repos/pritha-tarento/open-saber/comments{/number}","issue_comment_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/comments{/number}","contents_url":"https://api.github.com/repos/pritha-tarento/open-saber/contents/{+path}","compare_url":"https://api.github.com/repos/pritha-tarento/open-saber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pritha-tarento/open-saber/merges","archive_url":"https://api.github.com/repos/pritha-tarento/open-saber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pritha-tarento/open-saber/downloads","issues_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues{/number}","pulls_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls{/number}","milestones_url":"https://api.github.com/repos/pritha-tarento/open-saber/milestones{/number}","notifications_url":"https://api.github.com/repos/pritha-tarento/open-saber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pritha-tarento/open-saber/labels{/name}","releases_url":"https://api.github.com/repos/pritha-tarento/open-saber/releases{/id}","deployments_url":"https://api.github.com/repos/pritha-tarento/open-saber/deployments","created_at":"2018-12-04T06:55:14Z","updated_at":"2018-12-04T06:55:17Z","pushed_at":"2018-12-07T13:07:54Z","git_url":"git://github.com/pritha-tarento/open-saber.git","ssh_url":"git@github.com:pritha-tarento/open-saber.git","clone_url":"https://github.com/pritha-tarento/open-saber.git","svn_url":"https://github.com/pritha-tarento/open-saber","homepage":"","size":2560,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pritha-tarento:release-2.0.0","ref":"release-2.0.0","sha":"4eb299c0c47eeb997f1ce8009c85f3c0406114c2","user":{"login":"pritha-tarento","id":42533384,"node_id":"MDQ6VXNlcjQyNTMzMzg0","avatar_url":"https://avatars0.githubusercontent.com/u/42533384?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-tarento","html_url":"https://github.com/pritha-tarento","followers_url":"https://api.github.com/users/pritha-tarento/followers","following_url":"https://api.github.com/users/pritha-tarento/following{/other_user}","gists_url":"https://api.github.com/users/pritha-tarento/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-tarento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-tarento/subscriptions","organizations_url":"https://api.github.com/users/pritha-tarento/orgs","repos_url":"https://api.github.com/users/pritha-tarento/repos","events_url":"https://api.github.com/users/pritha-tarento/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-tarento/received_events","type":"User","site_admin":false},"repo":{"id":160312873,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzMTI4NzM=","name":"open-saber","full_name":"pritha-tarento/open-saber","private":false,"owner":{"login":"pritha-tarento","id":42533384,"node_id":"MDQ6VXNlcjQyNTMzMzg0","avatar_url":"https://avatars0.githubusercontent.com/u/42533384?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-tarento","html_url":"https://github.com/pritha-tarento","followers_url":"https://api.github.com/users/pritha-tarento/followers","following_url":"https://api.github.com/users/pritha-tarento/following{/other_user}","gists_url":"https://api.github.com/users/pritha-tarento/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-tarento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-tarento/subscriptions","organizations_url":"https://api.github.com/users/pritha-tarento/orgs","repos_url":"https://api.github.com/users/pritha-tarento/repos","events_url":"https://api.github.com/users/pritha-tarento/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-tarento/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pritha-tarento/open-saber","description":"Registry team","fork":true,"url":"https://api.github.com/repos/pritha-tarento/open-saber","forks_url":"https://api.github.com/repos/pritha-tarento/open-saber/forks","keys_url":"https://api.github.com/repos/pritha-tarento/open-saber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pritha-tarento/open-saber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pritha-tarento/open-saber/teams","hooks_url":"https://api.github.com/repos/pritha-tarento/open-saber/hooks","issue_events_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/events{/number}","events_url":"https://api.github.com/repos/pritha-tarento/open-saber/events","assignees_url":"https://api.github.com/repos/pritha-tarento/open-saber/assignees{/user}","branches_url":"https://api.github.com/repos/pritha-tarento/open-saber/branches{/branch}","tags_url":"https://api.github.com/repos/pritha-tarento/open-saber/tags","blobs_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/refs{/sha}","trees_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pritha-tarento/open-saber/statuses/{sha}","languages_url":"https://api.github.com/repos/pritha-tarento/open-saber/languages","stargazers_url":"https://api.github.com/repos/pritha-tarento/open-saber/stargazers","contributors_url":"https://api.github.com/repos/pritha-tarento/open-saber/contributors","subscribers_url":"https://api.github.com/repos/pritha-tarento/open-saber/subscribers","subscription_url":"https://api.github.com/repos/pritha-tarento/open-saber/subscription","commits_url":"https://api.github.com/repos/pritha-tarento/open-saber/commits{/sha}","git_commits_url":"https://api.github.com/repos/pritha-tarento/open-saber/git/commits{/sha}","comments_url":"https://api.github.com/repos/pritha-tarento/open-saber/comments{/number}","issue_comment_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues/comments{/number}","contents_url":"https://api.github.com/repos/pritha-tarento/open-saber/contents/{+path}","compare_url":"https://api.github.com/repos/pritha-tarento/open-saber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pritha-tarento/open-saber/merges","archive_url":"https://api.github.com/repos/pritha-tarento/open-saber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pritha-tarento/open-saber/downloads","issues_url":"https://api.github.com/repos/pritha-tarento/open-saber/issues{/number}","pulls_url":"https://api.github.com/repos/pritha-tarento/open-saber/pulls{/number}","milestones_url":"https://api.github.com/repos/pritha-tarento/open-saber/milestones{/number}","notifications_url":"https://api.github.com/repos/pritha-tarento/open-saber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pritha-tarento/open-saber/labels{/name}","releases_url":"https://api.github.com/repos/pritha-tarento/open-saber/releases{/id}","deployments_url":"https://api.github.com/repos/pritha-tarento/open-saber/deployments","created_at":"2018-12-04T06:55:14Z","updated_at":"2018-12-04T06:55:17Z","pushed_at":"2018-12-07T13:07:54Z","git_url":"git://github.com/pritha-tarento/open-saber.git","ssh_url":"git@github.com:pritha-tarento/open-saber.git","clone_url":"https://github.com/pritha-tarento/open-saber.git","svn_url":"https://github.com/pritha-tarento/open-saber","homepage":"","size":2560,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3"},"html":{"href":"https://github.com/pritha-tarento/open-saber/pull/3"},"issue":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/issues/3"},"comments":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pritha-tarento/open-saber/statuses/4c17a036f96cfe0b3bc8628ee1d7dcafa34f5bae"}},"author_association":"OWNER"}}
{"actor":{"display_login":"indrajra"}}