{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/comments/194596341","pull_request_review_id":127797952,"id":194596341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU5NjM0MQ==","diff_hunk":"@@ -154,16 +164,11 @@ namespace DirectX\n         static INIT_ONCE s_initOnce = INIT_ONCE_STATIC_INIT;\n \n         IWICImagingFactory2* factory = nullptr;\n-        (void)InitOnceExecuteOnce(&s_initOnce,\n-            [](PINIT_ONCE, PVOID, PVOID *ifactory) -> BOOL","path":"Src/WICTextureLoader.cpp","position":22,"original_position":22,"commit_id":"8790e8279c4883617cd033e5700044a19e4aaf86","original_commit_id":"8790e8279c4883617cd033e5700044a19e4aaf86","user":{"login":"walbourn","id":11866002,"node_id":"MDQ6VXNlcjExODY2MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/11866002?v=4","gravatar_id":"","url":"https://api.github.com/users/walbourn","html_url":"https://github.com/walbourn","followers_url":"https://api.github.com/users/walbourn/followers","following_url":"https://api.github.com/users/walbourn/following{/other_user}","gists_url":"https://api.github.com/users/walbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/walbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walbourn/subscriptions","organizations_url":"https://api.github.com/users/walbourn/orgs","repos_url":"https://api.github.com/users/walbourn/repos","events_url":"https://api.github.com/users/walbourn/events{/privacy}","received_events_url":"https://api.github.com/users/walbourn/received_events","type":"User","site_admin":false},"body":"So this builds fine with Visual C++ and with clang when using x64, but fails with clang on x86.\r\n\r\nTurns out the problem is that clang doesn't implement casting stateless lambdas to different calling conventions, so this code fails.\r\n\r\nSadly, I refactored this into a classic callback function instead of a lambda...","created_at":"2018-06-12T01:56:50Z","updated_at":"2018-06-12T01:56:56Z","html_url":"https://github.com/Microsoft/DirectXTK12/pull/37#discussion_r194596341","pull_request_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/comments/194596341"},"html":{"href":"https://github.com/Microsoft/DirectXTK12/pull/37#discussion_r194596341"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37","id":194124154,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTI0MTU0","html_url":"https://github.com/Microsoft/DirectXTK12/pull/37","diff_url":"https://github.com/Microsoft/DirectXTK12/pull/37.diff","patch_url":"https://github.com/Microsoft/DirectXTK12/pull/37.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/37","number":37,"state":"open","locked":false,"title":"Fix complier errors (Clang 6)","user":{"login":"walbourn","id":11866002,"node_id":"MDQ6VXNlcjExODY2MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/11866002?v=4","gravatar_id":"","url":"https://api.github.com/users/walbourn","html_url":"https://github.com/walbourn","followers_url":"https://api.github.com/users/walbourn/followers","following_url":"https://api.github.com/users/walbourn/following{/other_user}","gists_url":"https://api.github.com/users/walbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/walbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walbourn/subscriptions","organizations_url":"https://api.github.com/users/walbourn/orgs","repos_url":"https://api.github.com/users/walbourn/repos","events_url":"https://api.github.com/users/walbourn/events{/privacy}","received_events_url":"https://api.github.com/users/walbourn/received_events","type":"User","site_admin":false},"body":"The change here is to make the _DirectX Tool Kit_ math code build correctly with DirectXMath 3.12 or later when using ``_XM_NO_XMVECTOR_OVERLOADS_``.","created_at":"2018-06-11T22:50:45Z","updated_at":"2018-06-12T01:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"960c4afabca94a895931ba81697d3a2e41fdb294","assignee":{"login":"walbourn","id":11866002,"node_id":"MDQ6VXNlcjExODY2MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/11866002?v=4","gravatar_id":"","url":"https://api.github.com/users/walbourn","html_url":"https://github.com/walbourn","followers_url":"https://api.github.com/users/walbourn/followers","following_url":"https://api.github.com/users/walbourn/following{/other_user}","gists_url":"https://api.github.com/users/walbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/walbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walbourn/subscriptions","organizations_url":"https://api.github.com/users/walbourn/orgs","repos_url":"https://api.github.com/users/walbourn/repos","events_url":"https://api.github.com/users/walbourn/events{/privacy}","received_events_url":"https://api.github.com/users/walbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"walbourn","id":11866002,"node_id":"MDQ6VXNlcjExODY2MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/11866002?v=4","gravatar_id":"","url":"https://api.github.com/users/walbourn","html_url":"https://github.com/walbourn","followers_url":"https://api.github.com/users/walbourn/followers","following_url":"https://api.github.com/users/walbourn/following{/other_user}","gists_url":"https://api.github.com/users/walbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/walbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walbourn/subscriptions","organizations_url":"https://api.github.com/users/walbourn/orgs","repos_url":"https://api.github.com/users/walbourn/repos","events_url":"https://api.github.com/users/walbourn/events{/privacy}","received_events_url":"https://api.github.com/users/walbourn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shawnhar","id":8118468,"node_id":"MDQ6VXNlcjgxMTg0Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8118468?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnhar","html_url":"https://github.com/shawnhar","followers_url":"https://api.github.com/users/shawnhar/followers","following_url":"https://api.github.com/users/shawnhar/following{/other_user}","gists_url":"https://api.github.com/users/shawnhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnhar/subscriptions","organizations_url":"https://api.github.com/users/shawnhar/orgs","repos_url":"https://api.github.com/users/shawnhar/repos","events_url":"https://api.github.com/users/shawnhar/events{/privacy}","received_events_url":"https://api.github.com/users/shawnhar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":955559733,"node_id":"MDU6TGFiZWw5NTU1NTk3MzM=","url":"https://api.github.com/repos/Microsoft/DirectXTK12/labels/conformance","name":"conformance","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/37/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectXTK12/statuses/8790e8279c4883617cd033e5700044a19e4aaf86","head":{"label":"Microsoft:clangdxmath","ref":"clangdxmath","sha":"8790e8279c4883617cd033e5700044a19e4aaf86","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61335563,"node_id":"MDEwOlJlcG9zaXRvcnk2MTMzNTU2Mw==","name":"DirectXTK12","full_name":"Microsoft/DirectXTK12","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectXTK12","description":"The DirectX Tool Kit (aka DirectXTK12) is a collection of helper classes for writing DirectX 12 code in C++","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectXTK12","forks_url":"https://api.github.com/repos/Microsoft/DirectXTK12/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectXTK12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectXTK12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectXTK12/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectXTK12/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectXTK12/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectXTK12/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectXTK12/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectXTK12/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectXTK12/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectXTK12/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectXTK12/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectXTK12/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectXTK12/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectXTK12/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectXTK12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectXTK12/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectXTK12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectXTK12/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectXTK12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectXTK12/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectXTK12/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectXTK12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectXTK12/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectXTK12/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/deployments","created_at":"2016-06-17T00:54:50Z","updated_at":"2018-06-11T22:42:53Z","pushed_at":"2018-06-12T01:54:35Z","git_url":"git://github.com/Microsoft/DirectXTK12.git","ssh_url":"git@github.com:Microsoft/DirectXTK12.git","clone_url":"https://github.com/Microsoft/DirectXTK12.git","svn_url":"https://github.com/Microsoft/DirectXTK12","homepage":"https://blogs.msdn.microsoft.com/chuckw/2016/07/18/directx-tool-kit-for-directx-12/","size":4058,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":12,"watchers":268,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8aba96f6fbb753616b0fb0a360c1a17f81a64ece","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61335563,"node_id":"MDEwOlJlcG9zaXRvcnk2MTMzNTU2Mw==","name":"DirectXTK12","full_name":"Microsoft/DirectXTK12","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectXTK12","description":"The DirectX Tool Kit (aka DirectXTK12) is a collection of helper classes for writing DirectX 12 code in C++","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectXTK12","forks_url":"https://api.github.com/repos/Microsoft/DirectXTK12/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectXTK12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectXTK12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectXTK12/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectXTK12/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectXTK12/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectXTK12/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectXTK12/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectXTK12/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectXTK12/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectXTK12/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectXTK12/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectXTK12/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectXTK12/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectXTK12/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectXTK12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectXTK12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectXTK12/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectXTK12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectXTK12/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectXTK12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectXTK12/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectXTK12/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectXTK12/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectXTK12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectXTK12/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectXTK12/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectXTK12/deployments","created_at":"2016-06-17T00:54:50Z","updated_at":"2018-06-11T22:42:53Z","pushed_at":"2018-06-12T01:54:35Z","git_url":"git://github.com/Microsoft/DirectXTK12.git","ssh_url":"git@github.com:Microsoft/DirectXTK12.git","clone_url":"https://github.com/Microsoft/DirectXTK12.git","svn_url":"https://github.com/Microsoft/DirectXTK12","homepage":"https://blogs.msdn.microsoft.com/chuckw/2016/07/18/directx-tool-kit-for-directx-12/","size":4058,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":12,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37"},"html":{"href":"https://github.com/Microsoft/DirectXTK12/pull/37"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/37"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectXTK12/statuses/8790e8279c4883617cd033e5700044a19e4aaf86"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"walbourn"}}