{"action":"created","comment":{"url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/comments/216599439","pull_request_review_id":154115216,"id":216599439,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjU5OTQzOQ==","diff_hunk":"@@ -23,6 +23,11 @@ plugins {\n \n repositories {\n   jcenter()\n+  repositories {","path":"build.gradle","position":4,"original_position":4,"commit_id":"14178d6e7863b44d01a322338d4691303df8ac16","original_commit_id":"14178d6e7863b44d01a322338d4691303df8ac16","user":{"login":"jponge","id":25961,"node_id":"MDQ6VXNlcjI1OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25961?v=4","gravatar_id":"","url":"https://api.github.com/users/jponge","html_url":"https://github.com/jponge","followers_url":"https://api.github.com/users/jponge/followers","following_url":"https://api.github.com/users/jponge/following{/other_user}","gists_url":"https://api.github.com/users/jponge/gists{/gist_id}","starred_url":"https://api.github.com/users/jponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jponge/subscriptions","organizations_url":"https://api.github.com/users/jponge/orgs","repos_url":"https://api.github.com/users/jponge/repos","events_url":"https://api.github.com/users/jponge/events{/privacy}","received_events_url":"https://api.github.com/users/jponge/received_events","type":"User","site_admin":false},"body":"Is it really needed?","created_at":"2018-09-11T09:16:12Z","updated_at":"2018-09-11T09:17:16Z","html_url":"https://github.com/jponge/vertx-gradle-plugin/pull/19#discussion_r216599439","pull_request_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/comments/216599439"},"html":{"href":"https://github.com/jponge/vertx-gradle-plugin/pull/19#discussion_r216599439"},"pull_request":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19","id":205474765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDc0NzY1","html_url":"https://github.com/jponge/vertx-gradle-plugin/pull/19","diff_url":"https://github.com/jponge/vertx-gradle-plugin/pull/19.diff","patch_url":"https://github.com/jponge/vertx-gradle-plugin/pull/19.patch","issue_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/19","number":19,"state":"open","locked":false,"title":"Docker support based on Jib","user":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"body":"A proposal for #18 \r\n\r\nIt simply works (i used the `openjdk:8-jdk-alpine` as default image). \r\nMy concerns with jib:\r\n- According to their [FAQ](https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#can-i-build-to-a-local-docker-daemon) the local build requires a weird `docker pull` to make the image available. We'll see the result on a CI environment. Plus, it requires to run the `jibDockerBuild` rather than the simple `jib` task.\r\n\r\n- The docker build is 100% programatically, we can't override with a classic `Dockerfile` (discussed [here](https://github.com/GoogleContainerTools/jib/issues/657). I understand the discussion but it's not ops-friendly\r\n\r\nI wait for your feedback before starting the documentation.","created_at":"2018-08-01T16:01:58Z","updated_at":"2018-09-11T09:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9f24b8127dfb79041471b6fedae40352a27dc6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19/commits","review_comments_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19/comments","review_comment_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/19/comments","statuses_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/statuses/14178d6e7863b44d01a322338d4691303df8ac16","head":{"label":"danielpetisme:feat-18","ref":"feat-18","sha":"14178d6e7863b44d01a322338d4691303df8ac16","user":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"repo":{"id":143153046,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTMwNDY=","name":"vertx-gradle-plugin","full_name":"danielpetisme/vertx-gradle-plugin","owner":{"login":"danielpetisme","id":593564,"node_id":"MDQ6VXNlcjU5MzU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/593564?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpetisme","html_url":"https://github.com/danielpetisme","followers_url":"https://api.github.com/users/danielpetisme/followers","following_url":"https://api.github.com/users/danielpetisme/following{/other_user}","gists_url":"https://api.github.com/users/danielpetisme/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpetisme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpetisme/subscriptions","organizations_url":"https://api.github.com/users/danielpetisme/orgs","repos_url":"https://api.github.com/users/danielpetisme/repos","events_url":"https://api.github.com/users/danielpetisme/events{/privacy}","received_events_url":"https://api.github.com/users/danielpetisme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielpetisme/vertx-gradle-plugin","description":"An opinionated Gradle plugin for Vert.x projects","fork":true,"url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin","forks_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/forks","keys_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/events","assignees_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/merges","archive_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/danielpetisme/vertx-gradle-plugin/deployments","created_at":"2018-08-01T12:27:50Z","updated_at":"2018-08-01T12:27:52Z","pushed_at":"2018-09-03T10:11:38Z","git_url":"git://github.com/danielpetisme/vertx-gradle-plugin.git","ssh_url":"git@github.com:danielpetisme/vertx-gradle-plugin.git","clone_url":"https://github.com/danielpetisme/vertx-gradle-plugin.git","svn_url":"https://github.com/danielpetisme/vertx-gradle-plugin","homepage":"","size":193,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jponge:master","ref":"master","sha":"a82dab65b1431ce73f768370373e3cb2d536f9b1","user":{"login":"jponge","id":25961,"node_id":"MDQ6VXNlcjI1OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25961?v=4","gravatar_id":"","url":"https://api.github.com/users/jponge","html_url":"https://github.com/jponge","followers_url":"https://api.github.com/users/jponge/followers","following_url":"https://api.github.com/users/jponge/following{/other_user}","gists_url":"https://api.github.com/users/jponge/gists{/gist_id}","starred_url":"https://api.github.com/users/jponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jponge/subscriptions","organizations_url":"https://api.github.com/users/jponge/orgs","repos_url":"https://api.github.com/users/jponge/repos","events_url":"https://api.github.com/users/jponge/events{/privacy}","received_events_url":"https://api.github.com/users/jponge/received_events","type":"User","site_admin":false},"repo":{"id":102364281,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNjQyODE=","name":"vertx-gradle-plugin","full_name":"jponge/vertx-gradle-plugin","owner":{"login":"jponge","id":25961,"node_id":"MDQ6VXNlcjI1OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25961?v=4","gravatar_id":"","url":"https://api.github.com/users/jponge","html_url":"https://github.com/jponge","followers_url":"https://api.github.com/users/jponge/followers","following_url":"https://api.github.com/users/jponge/following{/other_user}","gists_url":"https://api.github.com/users/jponge/gists{/gist_id}","starred_url":"https://api.github.com/users/jponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jponge/subscriptions","organizations_url":"https://api.github.com/users/jponge/orgs","repos_url":"https://api.github.com/users/jponge/repos","events_url":"https://api.github.com/users/jponge/events{/privacy}","received_events_url":"https://api.github.com/users/jponge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jponge/vertx-gradle-plugin","description":"An opinionated Gradle plugin for Vert.x projects","fork":false,"url":"https://api.github.com/repos/jponge/vertx-gradle-plugin","forks_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/forks","keys_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/events","assignees_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/merges","archive_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jponge/vertx-gradle-plugin/deployments","created_at":"2017-09-04T13:25:50Z","updated_at":"2018-08-31T17:00:24Z","pushed_at":"2018-09-03T10:11:39Z","git_url":"git://github.com/jponge/vertx-gradle-plugin.git","ssh_url":"git@github.com:jponge/vertx-gradle-plugin.git","clone_url":"https://github.com/jponge/vertx-gradle-plugin.git","svn_url":"https://github.com/jponge/vertx-gradle-plugin","homepage":"","size":191,"stargazers_count":51,"watchers_count":51,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":3,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19"},"html":{"href":"https://github.com/jponge/vertx-gradle-plugin/pull/19"},"issue":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/19"},"comments":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/jponge/vertx-gradle-plugin/statuses/14178d6e7863b44d01a322338d4691303df8ac16"}},"author_association":"NONE"}}
{"actor":{"display_login":"jponge"}}