{"action":"closed","number":4739,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739","id":170165184,"html_url":"https://github.com/fish-shell/fish-shell/pull/4739","diff_url":"https://github.com/fish-shell/fish-shell/pull/4739.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/4739.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4739","number":4739,"state":"closed","locked":false,"title":"[cmake] don't try too hard to create extra vendor directories","user":{"login":"zanchey","id":520741,"avatar_url":"https://avatars1.githubusercontent.com/u/520741?v=4","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"body":"This commit mirrors the behaviour in Makefile.in for the autotools build, but I'd appreciate another set of eyes.\n\nCMake doesn't support ignoring failures on install operations, so instead do the entire operation as an external command and ignore any failures.","created_at":"2018-02-20T11:25:00Z","updated_at":"2018-02-27T12:43:42Z","closed_at":"2018-02-27T12:43:42Z","merged_at":"2018-02-27T12:43:42Z","merge_commit_sha":"2747945c55edb32e4d7efc7ed539c83feea9d54d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/18","html_url":"https://github.com/fish-shell/fish-shell/milestone/18","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/18/labels","id":2597361,"number":18,"title":"fish-3.0","description":"The proposed 3.0 major release of fish. May contain breaking changes.","creator":{"login":"faho","id":5185367,"avatar_url":"https://avatars3.githubusercontent.com/u/5185367?v=4","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":161,"state":"open","created_at":"2017-06-22T00:28:56Z","updated_at":"2018-02-27T12:43:42Z","due_on":"2018-03-01T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4739/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/2747945c55edb32e4d7efc7ed539c83feea9d54d","head":{"label":"zanchey:cmake-optionaldirs","ref":"cmake-optionaldirs","sha":"2747945c55edb32e4d7efc7ed539c83feea9d54d","user":{"login":"zanchey","id":520741,"avatar_url":"https://avatars1.githubusercontent.com/u/520741?v=4","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"repo":{"id":4661414,"name":"fish-shell","full_name":"zanchey/fish-shell","owner":{"login":"zanchey","id":520741,"avatar_url":"https://avatars1.githubusercontent.com/u/520741?v=4","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zanchey/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/zanchey/fish-shell","forks_url":"https://api.github.com/repos/zanchey/fish-shell/forks","keys_url":"https://api.github.com/repos/zanchey/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanchey/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanchey/fish-shell/teams","hooks_url":"https://api.github.com/repos/zanchey/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/zanchey/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/zanchey/fish-shell/events","assignees_url":"https://api.github.com/repos/zanchey/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/zanchey/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/zanchey/fish-shell/tags","blobs_url":"https://api.github.com/repos/zanchey/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanchey/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanchey/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanchey/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanchey/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/zanchey/fish-shell/languages","stargazers_url":"https://api.github.com/repos/zanchey/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/zanchey/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/zanchey/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/zanchey/fish-shell/subscription","commits_url":"https://api.github.com/repos/zanchey/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanchey/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanchey/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanchey/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanchey/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/zanchey/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanchey/fish-shell/merges","archive_url":"https://api.github.com/repos/zanchey/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanchey/fish-shell/downloads","issues_url":"https://api.github.com/repos/zanchey/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/zanchey/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/zanchey/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/zanchey/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanchey/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/zanchey/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/zanchey/fish-shell/deployments","created_at":"2012-06-14T09:22:02Z","updated_at":"2016-10-14T13:13:11Z","pushed_at":"2018-02-27T12:43:10Z","git_url":"git://github.com/zanchey/fish-shell.git","ssh_url":"git@github.com:zanchey/fish-shell.git","clone_url":"https://github.com/zanchey/fish-shell.git","svn_url":"https://github.com/zanchey/fish-shell","homepage":"","size":42017,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"5282d3e7110f40fc9cb51f4ae952f65000bbf0ae","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"name":"fish-shell","full_name":"fish-shell/fish-shell","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/fish-shell/fish-shell/deployments","created_at":"2012-05-10T03:00:55Z","updated_at":"2018-02-27T12:36:11Z","pushed_at":"2018-02-27T12:43:41Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":42134,"stargazers_count":9193,"watchers_count":9193,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":894,"mirror_url":null,"archived":false,"open_issues_count":464,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":894,"open_issues":464,"watchers":9193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/4739"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/4739"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/4739/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4739/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/2747945c55edb32e4d7efc7ed539c83feea9d54d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zanchey","id":520741,"avatar_url":"https://avatars1.githubusercontent.com/u/520741?v=4","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"zanchey"}}