{"action":"opened","number":396,"pull_request":{"url":"https://api.github.com/repos/shadow/shadow/pulls/396","id":168342053,"html_url":"https://github.com/shadow/shadow/pull/396","diff_url":"https://github.com/shadow/shadow/pull/396.diff","patch_url":"https://github.com/shadow/shadow/pull/396.patch","issue_url":"https://api.github.com/repos/shadow/shadow/issues/396","number":396,"state":"open","locked":false,"title":"add support for specifying the plugin start symbol in the config","user":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars0.githubusercontent.com/u/5017470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"body":"I am researching using Shadow to simulate blockchain networks and wanted to try and see if I could get it to run a Rust executable.  It turns out that the Rust compiler doesn't allow the creation of a C callable dynamic linked library with the \"main\" symbol exported.  To get around this, I modified Shadow to add a \"startsymbol\" attribute to the plugin tags in the config.  If it isn't specified, it defaults to \"main\" so the existing behavior is preserved.  I also modified a few tests to verify it works.  I think this may also be useful for other situations also.","created_at":"2018-02-09T21:05:15Z","updated_at":"2018-02-09T21:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shadow/shadow/pulls/396/commits","review_comments_url":"https://api.github.com/repos/shadow/shadow/pulls/396/comments","review_comment_url":"https://api.github.com/repos/shadow/shadow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shadow/shadow/issues/396/comments","statuses_url":"https://api.github.com/repos/shadow/shadow/statuses/cb30a672ae6ff3108114a1bade19f616b3488744","head":{"label":"dhuseby:configurable_start_symbol","ref":"configurable_start_symbol","sha":"cb30a672ae6ff3108114a1bade19f616b3488744","user":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars0.githubusercontent.com/u/5017470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"repo":{"id":120952846,"name":"shadow","full_name":"dhuseby/shadow","owner":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars0.githubusercontent.com/u/5017470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhuseby/shadow","description":"Shadow is a unique discrete-event network simulator that runs real  applications like Tor, and distributed systems of thousands of nodes on a single machine. Shadow combines the accuracy of emulation with the  efficiency and control of simulation, achieving the best of both approaches.","fork":true,"url":"https://api.github.com/repos/dhuseby/shadow","forks_url":"https://api.github.com/repos/dhuseby/shadow/forks","keys_url":"https://api.github.com/repos/dhuseby/shadow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhuseby/shadow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhuseby/shadow/teams","hooks_url":"https://api.github.com/repos/dhuseby/shadow/hooks","issue_events_url":"https://api.github.com/repos/dhuseby/shadow/issues/events{/number}","events_url":"https://api.github.com/repos/dhuseby/shadow/events","assignees_url":"https://api.github.com/repos/dhuseby/shadow/assignees{/user}","branches_url":"https://api.github.com/repos/dhuseby/shadow/branches{/branch}","tags_url":"https://api.github.com/repos/dhuseby/shadow/tags","blobs_url":"https://api.github.com/repos/dhuseby/shadow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhuseby/shadow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhuseby/shadow/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhuseby/shadow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhuseby/shadow/statuses/{sha}","languages_url":"https://api.github.com/repos/dhuseby/shadow/languages","stargazers_url":"https://api.github.com/repos/dhuseby/shadow/stargazers","contributors_url":"https://api.github.com/repos/dhuseby/shadow/contributors","subscribers_url":"https://api.github.com/repos/dhuseby/shadow/subscribers","subscription_url":"https://api.github.com/repos/dhuseby/shadow/subscription","commits_url":"https://api.github.com/repos/dhuseby/shadow/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhuseby/shadow/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhuseby/shadow/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhuseby/shadow/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhuseby/shadow/contents/{+path}","compare_url":"https://api.github.com/repos/dhuseby/shadow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhuseby/shadow/merges","archive_url":"https://api.github.com/repos/dhuseby/shadow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhuseby/shadow/downloads","issues_url":"https://api.github.com/repos/dhuseby/shadow/issues{/number}","pulls_url":"https://api.github.com/repos/dhuseby/shadow/pulls{/number}","milestones_url":"https://api.github.com/repos/dhuseby/shadow/milestones{/number}","notifications_url":"https://api.github.com/repos/dhuseby/shadow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhuseby/shadow/labels{/name}","releases_url":"https://api.github.com/repos/dhuseby/shadow/releases{/id}","deployments_url":"https://api.github.com/repos/dhuseby/shadow/deployments","created_at":"2018-02-09T20:34:52Z","updated_at":"2018-02-09T20:34:54Z","pushed_at":"2018-02-09T20:55:51Z","git_url":"git://github.com/dhuseby/shadow.git","ssh_url":"git@github.com:dhuseby/shadow.git","clone_url":"https://github.com/dhuseby/shadow.git","svn_url":"https://github.com/dhuseby/shadow","homepage":"https://shadow.github.io","size":17386,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shadow:master","ref":"master","sha":"6ffe6ffb93b9c944976b9e8058e4d6b01edb18d8","user":{"login":"shadow","id":791398,"avatar_url":"https://avatars3.githubusercontent.com/u/791398?v=4","gravatar_id":"","url":"https://api.github.com/users/shadow","html_url":"https://github.com/shadow","followers_url":"https://api.github.com/users/shadow/followers","following_url":"https://api.github.com/users/shadow/following{/other_user}","gists_url":"https://api.github.com/users/shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow/subscriptions","organizations_url":"https://api.github.com/users/shadow/orgs","repos_url":"https://api.github.com/users/shadow/repos","events_url":"https://api.github.com/users/shadow/events{/privacy}","received_events_url":"https://api.github.com/users/shadow/received_events","type":"Organization","site_admin":false},"repo":{"id":1759835,"name":"shadow","full_name":"shadow/shadow","owner":{"login":"shadow","id":791398,"avatar_url":"https://avatars3.githubusercontent.com/u/791398?v=4","gravatar_id":"","url":"https://api.github.com/users/shadow","html_url":"https://github.com/shadow","followers_url":"https://api.github.com/users/shadow/followers","following_url":"https://api.github.com/users/shadow/following{/other_user}","gists_url":"https://api.github.com/users/shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow/subscriptions","organizations_url":"https://api.github.com/users/shadow/orgs","repos_url":"https://api.github.com/users/shadow/repos","events_url":"https://api.github.com/users/shadow/events{/privacy}","received_events_url":"https://api.github.com/users/shadow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shadow/shadow","description":"Shadow is a unique discrete-event network simulator that runs real  applications like Tor, and distributed systems of thousands of nodes on a single machine. Shadow combines the accuracy of emulation with the  efficiency and control of simulation, achieving the best of both approaches.","fork":false,"url":"https://api.github.com/repos/shadow/shadow","forks_url":"https://api.github.com/repos/shadow/shadow/forks","keys_url":"https://api.github.com/repos/shadow/shadow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shadow/shadow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shadow/shadow/teams","hooks_url":"https://api.github.com/repos/shadow/shadow/hooks","issue_events_url":"https://api.github.com/repos/shadow/shadow/issues/events{/number}","events_url":"https://api.github.com/repos/shadow/shadow/events","assignees_url":"https://api.github.com/repos/shadow/shadow/assignees{/user}","branches_url":"https://api.github.com/repos/shadow/shadow/branches{/branch}","tags_url":"https://api.github.com/repos/shadow/shadow/tags","blobs_url":"https://api.github.com/repos/shadow/shadow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shadow/shadow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shadow/shadow/git/refs{/sha}","trees_url":"https://api.github.com/repos/shadow/shadow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shadow/shadow/statuses/{sha}","languages_url":"https://api.github.com/repos/shadow/shadow/languages","stargazers_url":"https://api.github.com/repos/shadow/shadow/stargazers","contributors_url":"https://api.github.com/repos/shadow/shadow/contributors","subscribers_url":"https://api.github.com/repos/shadow/shadow/subscribers","subscription_url":"https://api.github.com/repos/shadow/shadow/subscription","commits_url":"https://api.github.com/repos/shadow/shadow/commits{/sha}","git_commits_url":"https://api.github.com/repos/shadow/shadow/git/commits{/sha}","comments_url":"https://api.github.com/repos/shadow/shadow/comments{/number}","issue_comment_url":"https://api.github.com/repos/shadow/shadow/issues/comments{/number}","contents_url":"https://api.github.com/repos/shadow/shadow/contents/{+path}","compare_url":"https://api.github.com/repos/shadow/shadow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shadow/shadow/merges","archive_url":"https://api.github.com/repos/shadow/shadow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shadow/shadow/downloads","issues_url":"https://api.github.com/repos/shadow/shadow/issues{/number}","pulls_url":"https://api.github.com/repos/shadow/shadow/pulls{/number}","milestones_url":"https://api.github.com/repos/shadow/shadow/milestones{/number}","notifications_url":"https://api.github.com/repos/shadow/shadow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shadow/shadow/labels{/name}","releases_url":"https://api.github.com/repos/shadow/shadow/releases{/id}","deployments_url":"https://api.github.com/repos/shadow/shadow/deployments","created_at":"2011-05-17T08:18:57Z","updated_at":"2018-02-05T21:52:11Z","pushed_at":"2018-02-05T14:54:34Z","git_url":"git://github.com/shadow/shadow.git","ssh_url":"git@github.com:shadow/shadow.git","clone_url":"https://github.com/shadow/shadow.git","svn_url":"https://github.com/shadow/shadow","homepage":"https://shadow.github.io","size":17386,"stargazers_count":501,"watchers_count":501,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":105,"open_issues":44,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shadow/shadow/pulls/396"},"html":{"href":"https://github.com/shadow/shadow/pull/396"},"issue":{"href":"https://api.github.com/repos/shadow/shadow/issues/396"},"comments":{"href":"https://api.github.com/repos/shadow/shadow/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/shadow/shadow/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/shadow/shadow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shadow/shadow/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/shadow/shadow/statuses/cb30a672ae6ff3108114a1bade19f616b3488744"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":78,"deletions":21,"changed_files":13}}
{"actor":{"display_login":"dhuseby"}}