{"action":"created","issue":{"url":"https://api.github.com/repos/jborean93/pypsrp/issues/10","repository_url":"https://api.github.com/repos/jborean93/pypsrp","labels_url":"https://api.github.com/repos/jborean93/pypsrp/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/jborean93/pypsrp/issues/10/comments","events_url":"https://api.github.com/repos/jborean93/pypsrp/issues/10/events","html_url":"https://github.com/jborean93/pypsrp/pull/10","id":367600264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTc3Njk2","number":10,"title":"Implement connection retries","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-07T22:25:41Z","updated_at":"2018-10-13T01:51:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jborean93/pypsrp/pulls/10","html_url":"https://github.com/jborean93/pypsrp/pull/10","diff_url":"https://github.com/jborean93/pypsrp/pull/10.diff","patch_url":"https://github.com/jborean93/pypsrp/pull/10.patch"},"body":"This implements the same solution for retrying connections as in pywinrm https://github.com/diyan/pywinrm/pull/174"},"comment":{"url":"https://api.github.com/repos/jborean93/pypsrp/issues/comments/429501863","html_url":"https://github.com/jborean93/pypsrp/pull/10#issuecomment-429501863","issue_url":"https://api.github.com/repos/jborean93/pypsrp/issues/10","id":429501863,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTUwMTg2Mw==","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T01:51:05Z","updated_at":"2018-10-13T01:51:05Z","author_association":"CONTRIBUTOR","body":"@jborean93 Right, I guess SSL errors are also connection errors, just like \"Connection refused\" and other connection errors. We cannot distinguish one from another within the requests Retry framework. And the intention is clearly that we do want to retry for \"Connection refused\" and other connection errors.\r\n\r\nI expect other HTTP clients using requests with Retry will have the same behavior. Not sure if we can/want to influence this behavior internally."}}
{"actor":{"display_login":"dagwieers"}}