{"action":"created","issue":{"url":"https://api.github.com/repos/open62541/open62541/issues/1556","repository_url":"https://api.github.com/repos/open62541/open62541","labels_url":"https://api.github.com/repos/open62541/open62541/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/open62541/open62541/issues/1556/comments","events_url":"https://api.github.com/repos/open62541/open62541/issues/1556/events","html_url":"https://github.com/open62541/open62541/pull/1556","id":292399205,"number":1556,"title":"fix LifetimeCount and call UA_Subscription_publishCallback if a publi…","user":{"login":"StalderT","id":13799456,"avatar_url":"https://avatars3.githubusercontent.com/u/13799456?v=4","gravatar_id":"","url":"https://api.github.com/users/StalderT","html_url":"https://github.com/StalderT","followers_url":"https://api.github.com/users/StalderT/followers","following_url":"https://api.github.com/users/StalderT/following{/other_user}","gists_url":"https://api.github.com/users/StalderT/gists{/gist_id}","starred_url":"https://api.github.com/users/StalderT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StalderT/subscriptions","organizations_url":"https://api.github.com/users/StalderT/orgs","repos_url":"https://api.github.com/users/StalderT/repos","events_url":"https://api.github.com/users/StalderT/events{/privacy}","received_events_url":"https://api.github.com/users/StalderT/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/open62541/open62541/milestones/4","html_url":"https://github.com/open62541/open62541/milestone/4","labels_url":"https://api.github.com/repos/open62541/open62541/milestones/4/labels","id":1856909,"number":4,"title":"0.3","description":"","creator":{"login":"jpfr","id":1726411,"avatar_url":"https://avatars1.githubusercontent.com/u/1726411?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":50,"state":"open","created_at":"2016-06-30T08:22:40Z","updated_at":"2018-02-06T11:34:14Z","due_on":"2018-02-18T08:00:00Z","closed_at":null},"comments":4,"created_at":"2018-01-29T13:04:12Z","updated_at":"2018-02-06T15:01:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/open62541/open62541/pulls/1556","html_url":"https://github.com/open62541/open62541/pull/1556","diff_url":"https://github.com/open62541/open62541/pull/1556.diff","patch_url":"https://github.com/open62541/open62541/pull/1556.patch"},"body":"…shResponse is present\r\n\r\nCurrently, the LifeTimeCount is not checked if the securechannel is invalid. LifeTimeCount is only checked when maxKeepAliveCount occurs.\r\n\r\nThis PR fix it.\r\n\r\nOther change : UA_Subscription_publishCallback only call UA_Subscription_publishCallback if publishResponse is available (small performance improvement).\r\n\r\nPart of https://github.com/open62541/open62541/pull/1339"},"comment":{"url":"https://api.github.com/repos/open62541/open62541/issues/comments/363448645","html_url":"https://github.com/open62541/open62541/pull/1556#issuecomment-363448645","issue_url":"https://api.github.com/repos/open62541/open62541/issues/1556","id":363448645,"user":{"login":"StalderT","id":13799456,"avatar_url":"https://avatars3.githubusercontent.com/u/13799456?v=4","gravatar_id":"","url":"https://api.github.com/users/StalderT","html_url":"https://github.com/StalderT","followers_url":"https://api.github.com/users/StalderT/followers","following_url":"https://api.github.com/users/StalderT/following{/other_user}","gists_url":"https://api.github.com/users/StalderT/gists{/gist_id}","starred_url":"https://api.github.com/users/StalderT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StalderT/subscriptions","organizations_url":"https://api.github.com/users/StalderT/orgs","repos_url":"https://api.github.com/users/StalderT/repos","events_url":"https://api.github.com/users/StalderT/events{/privacy}","received_events_url":"https://api.github.com/users/StalderT/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T15:01:05Z","updated_at":"2018-02-06T15:01:05Z","author_association":"CONTRIBUTOR","body":"Here : https://github.com/StalderT/open62541/blob/3c5fbc7ff2a3e7d52be52f04cb0494aa097bf313/src/server/ua_subscription.c#L276 we return if maxKeepAliveCount is not reached. In this case we don't increase currentLifetimeCount."}}
{"actor":{"display_login":"StalderT"}}