{"action":"created","comment":{"url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/comments/232513593","pull_request_review_id":173725013,"id":232513593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjUxMzU5Mw==","diff_hunk":"@@ -1,30 +1,67 @@\n // @flow\n import { createSelector } from 'reselect'\n-import { uniq, reverse } from 'lodash'\n+import { uniq, reverse, set } from 'lodash'\n \n import type { InputSelector } from 'reselect'\n-import type { State } from '../../store/state'\n+import type { State, Issue } from '../../store/state'\n \n+type AllIssuesObj = { [key: string]: Issue }\n export type OptionType = { value: string, label: string }\n \n const allIssuesSelector = (state: State) => state.issues\n const pointsSelector = (state: State) => state.points\n \n-const recentIssuesSelector = createSelector([pointsSelector], points =>\n+const recentIssueKeysSelector: InputSelector<\n+  State,\n+  any,\n+  string[]\n+> = createSelector([pointsSelector], points =>\n   reverse(uniq(reverse(points.map(point => point.issue).filter(Boolean))))\n )\n \n-const combinedIssuesSelector = createSelector(\n-  [recentIssuesSelector, allIssuesSelector],\n+const allIssuesObjSelector: InputSelector<\n+  State,\n+  any,\n+  AllIssuesObj\n+> = createSelector([allIssuesSelector], allIssues =>\n+  allIssues.reduce((acc, issue) => set(acc, issue.key, issue), {})\n+)\n+\n+const allIssueKeysSelector: InputSelector<\n+  State,\n+  any,\n+  string[]\n+> = createSelector([allIssuesSelector], allIssues =>\n+  allIssues.map(issue => issue.key)\n+)\n+\n+const combinedIssueKeysSelector: InputSelector<\n+  State,\n+  any,\n+  string[]\n+> = createSelector(\n+  [recentIssueKeysSelector, allIssueKeysSelector],\n   (recentIssues, allIssues) => uniq(recentIssues.concat(allIssues))\n )\n \n+const combinedIssuesSelector: InputSelector<\n+  State,\n+  any,\n+  Issue[]\n+> = createSelector(\n+  [combinedIssueKeysSelector, allIssuesObjSelector],\n+  (keys, allIssuesObj) => keys.map(key => allIssuesObj[key]).filter(Boolean)","path":"src/worklogs/components/issuesInputSelector.js","position":58,"original_position":58,"commit_id":"212f0a0f6bb62a6b72b6d1c765ab7733a9b0042b","original_commit_id":"212f0a0f6bb62a6b72b6d1c765ab7733a9b0042b","user":{"login":"Siegrift","id":22679154,"node_id":"MDQ6VXNlcjIyNjc5MTU0","avatar_url":"https://avatars0.githubusercontent.com/u/22679154?v=4","gravatar_id":"","url":"https://api.github.com/users/Siegrift","html_url":"https://github.com/Siegrift","followers_url":"https://api.github.com/users/Siegrift/followers","following_url":"https://api.github.com/users/Siegrift/following{/other_user}","gists_url":"https://api.github.com/users/Siegrift/gists{/gist_id}","starred_url":"https://api.github.com/users/Siegrift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siegrift/subscriptions","organizations_url":"https://api.github.com/users/Siegrift/orgs","repos_url":"https://api.github.com/users/Siegrift/repos","events_url":"https://api.github.com/users/Siegrift/events{/privacy}","received_events_url":"https://api.github.com/users/Siegrift/received_events","type":"User","site_admin":false},"body":"I didn't know you can pass Boolean to lodash's functions :+1: ","created_at":"2018-11-12T00:44:38Z","updated_at":"2018-11-12T00:44:57Z","html_url":"https://github.com/vacuumlabs/fine-tracker/pull/56#discussion_r232513593","pull_request_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/comments/232513593"},"html":{"href":"https://github.com/vacuumlabs/fine-tracker/pull/56#discussion_r232513593"},"pull_request":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56","id":229689634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Njg5NjM0","html_url":"https://github.com/vacuumlabs/fine-tracker/pull/56","diff_url":"https://github.com/vacuumlabs/fine-tracker/pull/56.diff","patch_url":"https://github.com/vacuumlabs/fine-tracker/pull/56.patch","issue_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/56","number":56,"state":"open","locked":false,"title":"Show issue title","user":{"login":"mikx98","id":22675674,"node_id":"MDQ6VXNlcjIyNjc1Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/22675674?v=4","gravatar_id":"","url":"https://api.github.com/users/mikx98","html_url":"https://github.com/mikx98","followers_url":"https://api.github.com/users/mikx98/followers","following_url":"https://api.github.com/users/mikx98/following{/other_user}","gists_url":"https://api.github.com/users/mikx98/gists{/gist_id}","starred_url":"https://api.github.com/users/mikx98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikx98/subscriptions","organizations_url":"https://api.github.com/users/mikx98/orgs","repos_url":"https://api.github.com/users/mikx98/repos","events_url":"https://api.github.com/users/mikx98/events{/privacy}","received_events_url":"https://api.github.com/users/mikx98/received_events","type":"User","site_admin":false},"body":"Closes #51","created_at":"2018-11-09T13:12:07Z","updated_at":"2018-11-12T00:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2423a94078f6770531787423e1855f8d860f3562","assignee":{"login":"mikx98","id":22675674,"node_id":"MDQ6VXNlcjIyNjc1Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/22675674?v=4","gravatar_id":"","url":"https://api.github.com/users/mikx98","html_url":"https://github.com/mikx98","followers_url":"https://api.github.com/users/mikx98/followers","following_url":"https://api.github.com/users/mikx98/following{/other_user}","gists_url":"https://api.github.com/users/mikx98/gists{/gist_id}","starred_url":"https://api.github.com/users/mikx98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikx98/subscriptions","organizations_url":"https://api.github.com/users/mikx98/orgs","repos_url":"https://api.github.com/users/mikx98/repos","events_url":"https://api.github.com/users/mikx98/events{/privacy}","received_events_url":"https://api.github.com/users/mikx98/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikx98","id":22675674,"node_id":"MDQ6VXNlcjIyNjc1Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/22675674?v=4","gravatar_id":"","url":"https://api.github.com/users/mikx98","html_url":"https://github.com/mikx98","followers_url":"https://api.github.com/users/mikx98/followers","following_url":"https://api.github.com/users/mikx98/following{/other_user}","gists_url":"https://api.github.com/users/mikx98/gists{/gist_id}","starred_url":"https://api.github.com/users/mikx98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikx98/subscriptions","organizations_url":"https://api.github.com/users/mikx98/orgs","repos_url":"https://api.github.com/users/mikx98/repos","events_url":"https://api.github.com/users/mikx98/events{/privacy}","received_events_url":"https://api.github.com/users/mikx98/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56/commits","review_comments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56/comments","review_comment_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/56/comments","statuses_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/statuses/212f0a0f6bb62a6b72b6d1c765ab7733a9b0042b","head":{"label":"vacuumlabs:show-issue-title","ref":"show-issue-title","sha":"212f0a0f6bb62a6b72b6d1c765ab7733a9b0042b","user":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":142430867,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MzA4Njc=","name":"fine-tracker","full_name":"vacuumlabs/fine-tracker","private":false,"owner":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vacuumlabs/fine-tracker","description":"Finally some fine time tracker for JIRA/Tempo","fork":false,"url":"https://api.github.com/repos/vacuumlabs/fine-tracker","forks_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/forks","keys_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/teams","hooks_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/hooks","issue_events_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/events","assignees_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/tags","blobs_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/languages","stargazers_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/stargazers","contributors_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/contributors","subscribers_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/subscribers","subscription_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/subscription","commits_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/merges","archive_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/downloads","issues_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/labels{/name}","releases_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/deployments","created_at":"2018-07-26T11:18:37Z","updated_at":"2018-11-12T00:11:30Z","pushed_at":"2018-11-12T00:12:10Z","git_url":"git://github.com/vacuumlabs/fine-tracker.git","ssh_url":"git@github.com:vacuumlabs/fine-tracker.git","clone_url":"https://github.com/vacuumlabs/fine-tracker.git","svn_url":"https://github.com/vacuumlabs/fine-tracker","homepage":null,"size":478,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":1,"open_issues":19,"watchers":2,"default_branch":"master"}},"base":{"label":"vacuumlabs:sort-issues-by-activity","ref":"sort-issues-by-activity","sha":"17e6d642c5163306e188263cd51a10b32e9f5ad1","user":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":142430867,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MzA4Njc=","name":"fine-tracker","full_name":"vacuumlabs/fine-tracker","private":false,"owner":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vacuumlabs/fine-tracker","description":"Finally some fine time tracker for JIRA/Tempo","fork":false,"url":"https://api.github.com/repos/vacuumlabs/fine-tracker","forks_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/forks","keys_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/teams","hooks_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/hooks","issue_events_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/events","assignees_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/tags","blobs_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/languages","stargazers_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/stargazers","contributors_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/contributors","subscribers_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/subscribers","subscription_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/subscription","commits_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/merges","archive_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/downloads","issues_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/labels{/name}","releases_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/vacuumlabs/fine-tracker/deployments","created_at":"2018-07-26T11:18:37Z","updated_at":"2018-11-12T00:11:30Z","pushed_at":"2018-11-12T00:12:10Z","git_url":"git://github.com/vacuumlabs/fine-tracker.git","ssh_url":"git@github.com:vacuumlabs/fine-tracker.git","clone_url":"https://github.com/vacuumlabs/fine-tracker.git","svn_url":"https://github.com/vacuumlabs/fine-tracker","homepage":null,"size":478,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":1,"open_issues":19,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56"},"html":{"href":"https://github.com/vacuumlabs/fine-tracker/pull/56"},"issue":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/56"},"comments":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/vacuumlabs/fine-tracker/statuses/212f0a0f6bb62a6b72b6d1c765ab7733a9b0042b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Siegrift"}}