{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/228673907","pull_request_review_id":169010574,"id":228673907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY3MzkwNw==","diff_hunk":"@@ -121,6 +112,59 @@ void NODDB::setCacheDir(const std::string& cachedir)\n   }\n }\n \n+// Dump the SBF to a file\n+// To spend the least amount of time inside the mutex, we dump to an\n+// intermediate stringstream, otherwise the lock would be waiting for\n+// file IO to complete\n+bool PersistentSBF::snapshotCurrent(std::thread::id tid)","path":"pdns/nod.cc","position":69,"original_position":69,"commit_id":"27afebfdca5f829460b6284e63c07e5e12235aad","original_commit_id":"27afebfdca5f829460b6284e63c07e5e12235aad","user":{"login":"chbruyand","id":2854905,"node_id":"MDQ6VXNlcjI4NTQ5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2854905?v=4","gravatar_id":"","url":"https://api.github.com/users/chbruyand","html_url":"https://github.com/chbruyand","followers_url":"https://api.github.com/users/chbruyand/followers","following_url":"https://api.github.com/users/chbruyand/following{/other_user}","gists_url":"https://api.github.com/users/chbruyand/gists{/gist_id}","starred_url":"https://api.github.com/users/chbruyand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbruyand/subscriptions","organizations_url":"https://api.github.com/users/chbruyand/orgs","repos_url":"https://api.github.com/users/chbruyand/repos","events_url":"https://api.github.com/users/chbruyand/events{/privacy}","received_events_url":"https://api.github.com/users/chbruyand/received_events","type":"User","site_admin":false},"body":"Maybe use a const reference for the arg?","created_at":"2018-10-26T21:45:39Z","updated_at":"2018-10-26T21:50:39Z","html_url":"https://github.com/PowerDNS/pdns/pull/7094#discussion_r228673907","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/228673907"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7094#discussion_r228673907"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094","id":224973976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTczOTc2","html_url":"https://github.com/PowerDNS/pdns/pull/7094","diff_url":"https://github.com/PowerDNS/pdns/pull/7094.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/7094.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7094","number":7094,"state":"open","locked":false,"title":"Unique DNS Responses","user":{"login":"neilcook","id":15052760,"node_id":"MDQ6VXNlcjE1MDUyNzYw","avatar_url":"https://avatars0.githubusercontent.com/u/15052760?v=4","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"body":"### Short description\r\nThis PR extends the work on Newly Observed Domains by adding support for Unique DNS Responses; these are never-seen-before triplets of (qname, qtype, RR(rrname, rrtype, rrdata)). These are used by folks to detect potential evilness, such as fast-flux DNS.\r\n\r\nCompletely new to this PR is the ability to pass the NOD and UDR status via Protobuf. These are only set in the Response Protobuf packet. Protobuf responses from the packet cache have these flags cleared, as we only want to indicate this once. \r\n\r\n### Checklist\r\n<!-- please indicate if any of these things are done/included with this Pull Request. Not all boxes need to be checked for the Pull Request to be accepted -->\r\nI have:\r\n- [x ] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [x] compiled this code\r\n- [x] tested this code\r\n- [ ] included documentation (including possible behaviour changes)\r\n- [x] documented the code\r\n- [ ] added or modified regression test(s)\r\n- [x] added or modified unit test(s)","created_at":"2018-10-23T10:00:57Z","updated_at":"2018-10-26T21:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cf2d3a4bdff6ca07c3abfa491c46cd79bf6a81e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7094/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/27afebfdca5f829460b6284e63c07e5e12235aad","head":{"label":"neilcook:udr","ref":"udr","sha":"27afebfdca5f829460b6284e63c07e5e12235aad","user":{"login":"neilcook","id":15052760,"node_id":"MDQ6VXNlcjE1MDUyNzYw","avatar_url":"https://avatars0.githubusercontent.com/u/15052760?v=4","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"repo":{"id":135158008,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNTgwMDg=","name":"pdns","full_name":"neilcook/pdns","private":false,"owner":{"login":"neilcook","id":15052760,"node_id":"MDQ6VXNlcjE1MDUyNzYw","avatar_url":"https://avatars0.githubusercontent.com/u/15052760?v=4","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"html_url":"https://github.com/neilcook/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/neilcook/pdns","forks_url":"https://api.github.com/repos/neilcook/pdns/forks","keys_url":"https://api.github.com/repos/neilcook/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neilcook/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neilcook/pdns/teams","hooks_url":"https://api.github.com/repos/neilcook/pdns/hooks","issue_events_url":"https://api.github.com/repos/neilcook/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/neilcook/pdns/events","assignees_url":"https://api.github.com/repos/neilcook/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/neilcook/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/neilcook/pdns/tags","blobs_url":"https://api.github.com/repos/neilcook/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neilcook/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neilcook/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/neilcook/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neilcook/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/neilcook/pdns/languages","stargazers_url":"https://api.github.com/repos/neilcook/pdns/stargazers","contributors_url":"https://api.github.com/repos/neilcook/pdns/contributors","subscribers_url":"https://api.github.com/repos/neilcook/pdns/subscribers","subscription_url":"https://api.github.com/repos/neilcook/pdns/subscription","commits_url":"https://api.github.com/repos/neilcook/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/neilcook/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/neilcook/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/neilcook/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/neilcook/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/neilcook/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neilcook/pdns/merges","archive_url":"https://api.github.com/repos/neilcook/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neilcook/pdns/downloads","issues_url":"https://api.github.com/repos/neilcook/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/neilcook/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/neilcook/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/neilcook/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neilcook/pdns/labels{/name}","releases_url":"https://api.github.com/repos/neilcook/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/neilcook/pdns/deployments","created_at":"2018-05-28T12:28:28Z","updated_at":"2018-05-28T12:28:34Z","pushed_at":"2018-10-26T10:29:10Z","git_url":"git://github.com/neilcook/pdns.git","ssh_url":"git@github.com:neilcook/pdns.git","clone_url":"https://github.com/neilcook/pdns.git","svn_url":"https://github.com/neilcook/pdns","homepage":null,"size":45185,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"ebba82f8033878ddafed6904233bfc7b8810698d","user":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkzNTM0","name":"pdns","full_name":"PowerDNS/pdns","private":false,"owner":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2018-10-26T11:31:34Z","pushed_at":"2018-10-26T21:03:58Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":45416,"stargazers_count":1385,"watchers_count":1385,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":456,"mirror_url":null,"archived":false,"open_issues_count":655,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":456,"open_issues":655,"watchers":1385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7094"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7094"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7094/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7094/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/27afebfdca5f829460b6284e63c07e5e12235aad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chbruyand"}}