{"action":"closed","number":22115,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/22115","id":161887204,"html_url":"https://github.com/odoo/odoo/pull/22115","diff_url":"https://github.com/odoo/odoo/pull/22115.diff","patch_url":"https://github.com/odoo/odoo/pull/22115.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/22115","number":22115,"state":"closed","locked":false,"title":"[FIX] Calendar View: overridden unlink id being passed as String","user":{"login":"gbaumgartner-callino","id":26440671,"avatar_url":"https://avatars0.githubusercontent.com/u/26440671?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaumgartner-callino","html_url":"https://github.com/gbaumgartner-callino","followers_url":"https://api.github.com/users/gbaumgartner-callino/followers","following_url":"https://api.github.com/users/gbaumgartner-callino/following{/other_user}","gists_url":"https://api.github.com/users/gbaumgartner-callino/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaumgartner-callino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaumgartner-callino/subscriptions","organizations_url":"https://api.github.com/users/gbaumgartner-callino/orgs","repos_url":"https://api.github.com/users/gbaumgartner-callino/repos","events_url":"https://api.github.com/users/gbaumgartner-callino/events{/privacy}","received_events_url":"https://api.github.com/users/gbaumgartner-callino/received_events","type":"User","site_admin":false},"body":"Description of the issue/feature this PR addresses:\r\n\r\nhttps://github.com/odoo/odoo/blob/849d8ffd2193db2001626e455ed86a96bf1cddb7/addons/web_calendar/static/src/js/web_calendar.js#L934\r\n\r\nThis leads to \"Database fetch misses ids ({}) and has extra ids ({}), may be caused by a type incoherence in a previous request\" Error in some cases of overriden unlink() because the record is not correctly set. (e.g. model.name(u'1',) insead of model.name(1,))\r\n\r\nA simple fix would be to explicitly cast id to int.\r\n\r\n`{text: _t(\"Delete\"), close: true, click: function() {\r\n    self.remove_event(parseInt(id));\r\n}},`\r\n\r\nCurrent behavior before PR:\r\n\r\nOverridden unlink methods might fail.\r\n\r\nDesired behavior after PR is merged:\r\n\r\nUnlink from calendar views working as desired.\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2018-01-09T14:35:39Z","updated_at":"2018-04-06T12:35:21Z","closed_at":"2018-04-06T12:35:21Z","merged_at":null,"merge_commit_sha":"a85afeb05aa861c6569160b8d766257aadd70249","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712046916,"url":"https://api.github.com/repos/odoo/odoo/labels/10.0","name":"10.0","color":"f1d91f","default":false},{"id":616698546,"url":"https://api.github.com/repos/odoo/odoo/labels/Framework","name":"Framework","color":"E5E970","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/22115/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/22115/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/22115/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/eb68bfac3fe75257b74dc7ba14a12acd7f2e0ea5","head":{"label":"gbaumgartner-callino:10.0","ref":"10.0","sha":"eb68bfac3fe75257b74dc7ba14a12acd7f2e0ea5","user":{"login":"gbaumgartner-callino","id":26440671,"avatar_url":"https://avatars0.githubusercontent.com/u/26440671?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaumgartner-callino","html_url":"https://github.com/gbaumgartner-callino","followers_url":"https://api.github.com/users/gbaumgartner-callino/followers","following_url":"https://api.github.com/users/gbaumgartner-callino/following{/other_user}","gists_url":"https://api.github.com/users/gbaumgartner-callino/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaumgartner-callino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaumgartner-callino/subscriptions","organizations_url":"https://api.github.com/users/gbaumgartner-callino/orgs","repos_url":"https://api.github.com/users/gbaumgartner-callino/repos","events_url":"https://api.github.com/users/gbaumgartner-callino/events{/privacy}","received_events_url":"https://api.github.com/users/gbaumgartner-callino/received_events","type":"User","site_admin":false},"repo":{"id":116820209,"name":"odoo","full_name":"gbaumgartner-callino/odoo","owner":{"login":"gbaumgartner-callino","id":26440671,"avatar_url":"https://avatars0.githubusercontent.com/u/26440671?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaumgartner-callino","html_url":"https://github.com/gbaumgartner-callino","followers_url":"https://api.github.com/users/gbaumgartner-callino/followers","following_url":"https://api.github.com/users/gbaumgartner-callino/following{/other_user}","gists_url":"https://api.github.com/users/gbaumgartner-callino/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaumgartner-callino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaumgartner-callino/subscriptions","organizations_url":"https://api.github.com/users/gbaumgartner-callino/orgs","repos_url":"https://api.github.com/users/gbaumgartner-callino/repos","events_url":"https://api.github.com/users/gbaumgartner-callino/events{/privacy}","received_events_url":"https://api.github.com/users/gbaumgartner-callino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbaumgartner-callino/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":true,"url":"https://api.github.com/repos/gbaumgartner-callino/odoo","forks_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/forks","keys_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/teams","hooks_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/hooks","issue_events_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/events","assignees_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/tags","blobs_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/languages","stargazers_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/stargazers","contributors_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/contributors","subscribers_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/subscribers","subscription_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/subscription","commits_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/merges","archive_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/downloads","issues_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/labels{/name}","releases_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/gbaumgartner-callino/odoo/deployments","created_at":"2018-01-09T13:34:37Z","updated_at":"2018-01-09T13:35:53Z","pushed_at":"2018-01-09T14:12:21Z","git_url":"git://github.com/gbaumgartner-callino/odoo.git","ssh_url":"git@github.com:gbaumgartner-callino/odoo.git","clone_url":"https://github.com/gbaumgartner-callino/odoo.git","svn_url":"https://github.com/gbaumgartner-callino/odoo","homepage":"https://www.odoo.com","size":1915623,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"11.0"}},"base":{"label":"odoo:10.0","ref":"10.0","sha":"1ad8867deea179e3548f8f7619fd1bd11d1446ae","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-04-06T12:34:51Z","pushed_at":"2018-04-06T12:33:49Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2013852,"stargazers_count":9214,"watchers_count":9214,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7892,"mirror_url":null,"archived":false,"open_issues_count":1897,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7892,"open_issues":1897,"watchers":9214,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22115"},"html":{"href":"https://github.com/odoo/odoo/pull/22115"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/22115"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/22115/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22115/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22115/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/eb68bfac3fe75257b74dc7ba14a12acd7f2e0ea5"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mart-e"}}