{"action":"created","issue":{"url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/36","repository_url":"https://api.github.com/repos/Wizcorp/node-graylog2","labels_url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/36/comments","events_url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/36/events","html_url":"https://github.com/Wizcorp/node-graylog2/pull/36","id":336645669,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDQ4Nzk3","number":36,"title":"Unfinished pull","user":{"login":"Fl4m3Ph03n1x","id":2980392,"node_id":"MDQ6VXNlcjI5ODAzOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2980392?v=4","gravatar_id":"","url":"https://api.github.com/users/Fl4m3Ph03n1x","html_url":"https://github.com/Fl4m3Ph03n1x","followers_url":"https://api.github.com/users/Fl4m3Ph03n1x/followers","following_url":"https://api.github.com/users/Fl4m3Ph03n1x/following{/other_user}","gists_url":"https://api.github.com/users/Fl4m3Ph03n1x/gists{/gist_id}","starred_url":"https://api.github.com/users/Fl4m3Ph03n1x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fl4m3Ph03n1x/subscriptions","organizations_url":"https://api.github.com/users/Fl4m3Ph03n1x/orgs","repos_url":"https://api.github.com/users/Fl4m3Ph03n1x/repos","events_url":"https://api.github.com/users/Fl4m3Ph03n1x/events{/privacy}","received_events_url":"https://api.github.com/users/Fl4m3Ph03n1x/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T14:28:11Z","updated_at":"2018-06-29T08:02:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Wizcorp/node-graylog2/pulls/36","html_url":"https://github.com/Wizcorp/node-graylog2/pull/36","diff_url":"https://github.com/Wizcorp/node-graylog2/pull/36.diff","patch_url":"https://github.com/Wizcorp/node-graylog2/pull/36.patch"},"body":"Here. \r\n\r\nI was super original and named it \"unfinished pull\". \r\nIt passes all the tape tests, for what it's worth. \r\nThe bench script also runs. \r\nUpdated several vulnerable dependencies. \r\nNo more security issues with Buffer. \r\nNeeds Node v6 or higher.\r\n\r\nI could use a hand in testing it with a real system though, as I didn't have enough time for it yet, but all seems to be well.\r\n\r\nThe merge was quite hard to be honest. But anyway, what do you think?"},"comment":{"url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/comments/401280199","html_url":"https://github.com/Wizcorp/node-graylog2/pull/36#issuecomment-401280199","issue_url":"https://api.github.com/repos/Wizcorp/node-graylog2/issues/36","id":401280199,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTI4MDE5OQ==","user":{"login":"Fl4m3Ph03n1x","id":2980392,"node_id":"MDQ6VXNlcjI5ODAzOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2980392?v=4","gravatar_id":"","url":"https://api.github.com/users/Fl4m3Ph03n1x","html_url":"https://github.com/Fl4m3Ph03n1x","followers_url":"https://api.github.com/users/Fl4m3Ph03n1x/followers","following_url":"https://api.github.com/users/Fl4m3Ph03n1x/following{/other_user}","gists_url":"https://api.github.com/users/Fl4m3Ph03n1x/gists{/gist_id}","starred_url":"https://api.github.com/users/Fl4m3Ph03n1x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fl4m3Ph03n1x/subscriptions","organizations_url":"https://api.github.com/users/Fl4m3Ph03n1x/orgs","repos_url":"https://api.github.com/users/Fl4m3Ph03n1x/repos","events_url":"https://api.github.com/users/Fl4m3Ph03n1x/events{/privacy}","received_events_url":"https://api.github.com/users/Fl4m3Ph03n1x/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T08:02:39Z","updated_at":"2018-06-29T08:02:39Z","author_association":"NONE","body":"moved dependencies to DEV, updated changelog with some preliminar information ( will need to confirm and change as we see what has actually be done and what has not ). \r\n\r\nFor me, personally, I would make the log events async ( via Promises ) and get rid of the need to close the Graylog object for it to empty the queue. This need to close the socket is also not documented at all and I argue that we should ditch it altogether and just make the logs async. \r\n\r\nSince this is supposed to be a major version bump, why not get rid of all the issues we currently have?\r\n\r\n"}}
{"actor":{"display_login":"Fl4m3Ph03n1x"}}