{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1935","repository_url":"https://api.github.com/repos/xamarin/Xamarin.Forms","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1935/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1935/comments","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1935/events","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1935","id":298812385,"number":1935,"title":"[Android] Buttons can be round; remove Padding & Shadow by default","user":{"login":"samhouts","id":7827070,"avatar_url":"https://avatars3.githubusercontent.com/u/7827070?v=4","gravatar_id":"","url":"https://api.github.com/users/samhouts","html_url":"https://github.com/samhouts","followers_url":"https://api.github.com/users/samhouts/followers","following_url":"https://api.github.com/users/samhouts/following{/other_user}","gists_url":"https://api.github.com/users/samhouts/gists{/gist_id}","starred_url":"https://api.github.com/users/samhouts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhouts/subscriptions","organizations_url":"https://api.github.com/users/samhouts/orgs","repos_url":"https://api.github.com/users/samhouts/repos","events_url":"https://api.github.com/users/samhouts/events{/privacy}","received_events_url":"https://api.github.com/users/samhouts/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-21T01:37:24Z","updated_at":"2018-03-23T15:19:23Z","closed_at":"2018-03-05T20:50:16Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1935","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1935","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/1935.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/1935.patch"},"body":"### Description of Change ###\r\n\r\nRemoving the Padding and Shadow that were added in #1570 to make the X.F. Buttons mimic the style of a default Android `Button`. These can be added back to Buttons using new Platform Specifics.\r\n\r\nAlso adjusting the padding mismatch that made circle Buttons appear to be slightly rectangular.\r\n\r\nBefore #1570:\r\n![before-1570](https://user-images.githubusercontent.com/7827070/36458576-5d0c1bbc-1664-11e8-8af0-3b5a96bd01ad.png)\r\n\r\n\r\nAfter #1570:\r\n![before](https://user-images.githubusercontent.com/7827070/36458583-6a95ba54-1664-11e8-9730-3b218fdbcb51.png)\r\n\r\n\r\nAfter this change (note, changed the test case for an additional parameter):\r\n![screenshot_20180227-124138](https://user-images.githubusercontent.com/7827070/36753667-b3689344-1bbb-11e8-8737-86eb31502d8a.png)\r\n\r\n\r\n\r\n### Bugs Fixed ###\r\n\r\n- fixes #1909\r\n- fixes #1954 \r\n\r\n### API Changes ###\r\n\r\nAdded:\r\n- `bool Button.On<Android>().UseDefaultPadding()`\r\n- `void Button.On<Android>().SetUseDefaultPadding(true/false)`\r\n- `bool Button.On<Android>().UseDefaultShadow()`\r\n- `void Button.On<Android>().SetUseDefaultShadow(true/false)`\r\n\r\n### Behavioral Changes ###\r\n\r\n#### ⚠️ Setting the `CornerRadius`, `BackgroundColor`, `BorderColor`, or `BorderWidth` properties _will_ replace the Background drawable of an Android Button. If you need to use a custom drawable, please incorporate all of these properties into your custom drawable instead of attempting to use the Xamarin.Forms properties to adjust some or all of those values. \r\n\r\n### PR Checklist ###\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments/375700015","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1935#issuecomment-375700015","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1935","id":375700015,"user":{"login":"EmilAlipiev","id":10422347,"avatar_url":"https://avatars1.githubusercontent.com/u/10422347?v=4","gravatar_id":"","url":"https://api.github.com/users/EmilAlipiev","html_url":"https://github.com/EmilAlipiev","followers_url":"https://api.github.com/users/EmilAlipiev/followers","following_url":"https://api.github.com/users/EmilAlipiev/following{/other_user}","gists_url":"https://api.github.com/users/EmilAlipiev/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilAlipiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilAlipiev/subscriptions","organizations_url":"https://api.github.com/users/EmilAlipiev/orgs","repos_url":"https://api.github.com/users/EmilAlipiev/repos","events_url":"https://api.github.com/users/EmilAlipiev/events{/privacy}","received_events_url":"https://api.github.com/users/EmilAlipiev/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T15:19:23Z","updated_at":"2018-03-23T15:19:23Z","author_association":"NONE","body":"I understand some poeple had problems with previous changes but now reverting or redoing those changes breaks others. I was quite happy with the previous version indeed. would you mind sharing all styles you have removed that we can set in the shared library? because when I look at your commits I am bit lost. some padding are set dynamically looks like."}}
{"actor":{"display_login":"EmilAlipiev"}}