{"action":"created","comment":{"url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/comments/233263961","pull_request_review_id":174638352,"id":233263961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI2Mzk2MQ==","diff_hunk":"@@ -636,3 +655,189 @@ def test_pack_header_for_user(self, app, user_class):\n             assert token_data['rls'] == 'admin,operator'\n             assert token_data['duder'] == 'brief'\n             assert token_data['el_duderino'] == 'not brief'\n+\n+    def test_registration_email(self, app, user_class, db):\n+        \"\"\"\n+        This test verifies that Praetorian encrypts passwords using the scheme","path":"tests/test_base.py","position":163,"original_position":163,"commit_id":"b8f91adbd02fb9b7944b8680d9116c641bd1d5ed","original_commit_id":"b8f91adbd02fb9b7944b8680d9116c641bd1d5ed","user":{"login":"pahrohfit","id":1569906,"node_id":"MDQ6VXNlcjE1Njk5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1569906?v=4","gravatar_id":"","url":"https://api.github.com/users/pahrohfit","html_url":"https://github.com/pahrohfit","followers_url":"https://api.github.com/users/pahrohfit/followers","following_url":"https://api.github.com/users/pahrohfit/following{/other_user}","gists_url":"https://api.github.com/users/pahrohfit/gists{/gist_id}","starred_url":"https://api.github.com/users/pahrohfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahrohfit/subscriptions","organizations_url":"https://api.github.com/users/pahrohfit/orgs","repos_url":"https://api.github.com/users/pahrohfit/repos","events_url":"https://api.github.com/users/pahrohfit/events{/privacy}","received_events_url":"https://api.github.com/users/pahrohfit/received_events","type":"User","site_admin":false},"body":"yeah, i yy/p my code a lot .. told you i'm lazy with docs","created_at":"2018-11-13T23:32:42Z","updated_at":"2018-11-13T23:32:43Z","html_url":"https://github.com/dusktreader/flask-praetorian/pull/146#discussion_r233263961","pull_request_url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/comments/233263961"},"html":{"href":"https://github.com/dusktreader/flask-praetorian/pull/146#discussion_r233263961"},"pull_request":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146"}},"in_reply_to_id":233151390},"pull_request":{"url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146","id":230274707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjc0NzA3","html_url":"https://github.com/dusktreader/flask-praetorian/pull/146","diff_url":"https://github.com/dusktreader/flask-praetorian/pull/146.diff","patch_url":"https://github.com/dusktreader/flask-praetorian/pull/146.patch","issue_url":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/146","number":146,"state":"open","locked":false,"title":"Verify and update","user":{"login":"pahrohfit","id":1569906,"node_id":"MDQ6VXNlcjE1Njk5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1569906?v=4","gravatar_id":"","url":"https://api.github.com/users/pahrohfit","html_url":"https://github.com/pahrohfit","followers_url":"https://api.github.com/users/pahrohfit/followers","following_url":"https://api.github.com/users/pahrohfit/following{/other_user}","gists_url":"https://api.github.com/users/pahrohfit/gists{/gist_id}","starred_url":"https://api.github.com/users/pahrohfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahrohfit/subscriptions","organizations_url":"https://api.github.com/users/pahrohfit/orgs","repos_url":"https://api.github.com/users/pahrohfit/repos","events_url":"https://api.github.com/users/pahrohfit/events{/privacy}","received_events_url":"https://api.github.com/users/pahrohfit/received_events","type":"User","site_admin":false},"body":"Per Issue #43 --\r\n\r\nDeprecated `encrypt_password()`, as it is misleading to what crypto work is actually being done.  New function `hash_password`(duplicate of `encrypt_password()`) should be used instead.  It will raise a warning stating so when used.\r\n\r\nNew function `verify_and_update`.\r\n - When passed just a user object, it will test the scheme of the password field, and then raise exception if there is an outdated hash scheme used.\r\n - When passed a user object and a plaintext password, after verification of that password, if the hash used is outdated, it will silently update it to current, and return the user object for the developer to update his storage with.\r\n\r\nNew config setting `PRAETORIAN_HASH_AUTOTEST`.\r\n - When set to `True`, it will raise exception during calls to `authenticate()` if the hash scheme used is outdated.\r\n\r\nNew config setting `PRAETORIAN_HASH_AUTOUPDATE`.\r\n - When set to `True`, after successful `authentication()`, it will blindly update the hash if its deprecated, and return the updated user model for the developer to save to storage.\r\n\r\nNew config setting `PRAETORIAN_HASH_ALLOWED_SCHEMES`\r\n - When set, will override the defaults of 'pbkdf2_sha512', 'sha256_crypt', 'sha512_crypt', 'bcrypt', 'argon2', 'bcrypt_sha256'\r\n\r\nNew config setting `PRAETORIAN_HASH_DEPRECATED_SCHEMES`\r\n - When set, will override the defaults of '[]' (None)\r\n - This setting defines what are considered 'outdated' schemes.","created_at":"2018-11-12T21:31:32Z","updated_at":"2018-11-13T23:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa792bb66d95896e429a1c9bdeb958f2af32ff1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146/commits","review_comments_url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146/comments","review_comment_url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/146/comments","statuses_url":"https://api.github.com/repos/dusktreader/flask-praetorian/statuses/b8f91adbd02fb9b7944b8680d9116c641bd1d5ed","head":{"label":"pahrohfit:verify_and_update","ref":"verify_and_update","sha":"b8f91adbd02fb9b7944b8680d9116c641bd1d5ed","user":{"login":"pahrohfit","id":1569906,"node_id":"MDQ6VXNlcjE1Njk5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1569906?v=4","gravatar_id":"","url":"https://api.github.com/users/pahrohfit","html_url":"https://github.com/pahrohfit","followers_url":"https://api.github.com/users/pahrohfit/followers","following_url":"https://api.github.com/users/pahrohfit/following{/other_user}","gists_url":"https://api.github.com/users/pahrohfit/gists{/gist_id}","starred_url":"https://api.github.com/users/pahrohfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahrohfit/subscriptions","organizations_url":"https://api.github.com/users/pahrohfit/orgs","repos_url":"https://api.github.com/users/pahrohfit/repos","events_url":"https://api.github.com/users/pahrohfit/events{/privacy}","received_events_url":"https://api.github.com/users/pahrohfit/received_events","type":"User","site_admin":false},"repo":{"id":157034950,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwMzQ5NTA=","name":"flask-praetorian","full_name":"pahrohfit/flask-praetorian","private":false,"owner":{"login":"pahrohfit","id":1569906,"node_id":"MDQ6VXNlcjE1Njk5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1569906?v=4","gravatar_id":"","url":"https://api.github.com/users/pahrohfit","html_url":"https://github.com/pahrohfit","followers_url":"https://api.github.com/users/pahrohfit/followers","following_url":"https://api.github.com/users/pahrohfit/following{/other_user}","gists_url":"https://api.github.com/users/pahrohfit/gists{/gist_id}","starred_url":"https://api.github.com/users/pahrohfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pahrohfit/subscriptions","organizations_url":"https://api.github.com/users/pahrohfit/orgs","repos_url":"https://api.github.com/users/pahrohfit/repos","events_url":"https://api.github.com/users/pahrohfit/events{/privacy}","received_events_url":"https://api.github.com/users/pahrohfit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pahrohfit/flask-praetorian","description":"Strong, Simple, and Precise security for Flask APIs (using jwt)","fork":true,"url":"https://api.github.com/repos/pahrohfit/flask-praetorian","forks_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/forks","keys_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/teams","hooks_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/hooks","issue_events_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/issues/events{/number}","events_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/events","assignees_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/assignees{/user}","branches_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/branches{/branch}","tags_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/tags","blobs_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/git/refs{/sha}","trees_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/statuses/{sha}","languages_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/languages","stargazers_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/stargazers","contributors_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/contributors","subscribers_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/subscribers","subscription_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/subscription","commits_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/commits{/sha}","git_commits_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/git/commits{/sha}","comments_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/comments{/number}","issue_comment_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/issues/comments{/number}","contents_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/contents/{+path}","compare_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/merges","archive_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/downloads","issues_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/issues{/number}","pulls_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/pulls{/number}","milestones_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/milestones{/number}","notifications_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/labels{/name}","releases_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/releases{/id}","deployments_url":"https://api.github.com/repos/pahrohfit/flask-praetorian/deployments","created_at":"2018-11-11T00:45:10Z","updated_at":"2018-11-11T01:14:37Z","pushed_at":"2018-11-12T21:35:11Z","git_url":"git://github.com/pahrohfit/flask-praetorian.git","ssh_url":"git@github.com:pahrohfit/flask-praetorian.git","clone_url":"https://github.com/pahrohfit/flask-praetorian.git","svn_url":"https://github.com/pahrohfit/flask-praetorian","homepage":"http://flask-praetorian.readthedocs.io/en/latest/","size":2907,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dusktreader:master","ref":"master","sha":"dc9f732d65fa393a6b1013a00064c47d48018eab","user":{"login":"dusktreader","id":713676,"node_id":"MDQ6VXNlcjcxMzY3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/713676?v=4","gravatar_id":"","url":"https://api.github.com/users/dusktreader","html_url":"https://github.com/dusktreader","followers_url":"https://api.github.com/users/dusktreader/followers","following_url":"https://api.github.com/users/dusktreader/following{/other_user}","gists_url":"https://api.github.com/users/dusktreader/gists{/gist_id}","starred_url":"https://api.github.com/users/dusktreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dusktreader/subscriptions","organizations_url":"https://api.github.com/users/dusktreader/orgs","repos_url":"https://api.github.com/users/dusktreader/repos","events_url":"https://api.github.com/users/dusktreader/events{/privacy}","received_events_url":"https://api.github.com/users/dusktreader/received_events","type":"User","site_admin":false},"repo":{"id":74596218,"node_id":"MDEwOlJlcG9zaXRvcnk3NDU5NjIxOA==","name":"flask-praetorian","full_name":"dusktreader/flask-praetorian","private":false,"owner":{"login":"dusktreader","id":713676,"node_id":"MDQ6VXNlcjcxMzY3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/713676?v=4","gravatar_id":"","url":"https://api.github.com/users/dusktreader","html_url":"https://github.com/dusktreader","followers_url":"https://api.github.com/users/dusktreader/followers","following_url":"https://api.github.com/users/dusktreader/following{/other_user}","gists_url":"https://api.github.com/users/dusktreader/gists{/gist_id}","starred_url":"https://api.github.com/users/dusktreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dusktreader/subscriptions","organizations_url":"https://api.github.com/users/dusktreader/orgs","repos_url":"https://api.github.com/users/dusktreader/repos","events_url":"https://api.github.com/users/dusktreader/events{/privacy}","received_events_url":"https://api.github.com/users/dusktreader/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dusktreader/flask-praetorian","description":"Strong, Simple, and Precise security for Flask APIs (using jwt)","fork":false,"url":"https://api.github.com/repos/dusktreader/flask-praetorian","forks_url":"https://api.github.com/repos/dusktreader/flask-praetorian/forks","keys_url":"https://api.github.com/repos/dusktreader/flask-praetorian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dusktreader/flask-praetorian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dusktreader/flask-praetorian/teams","hooks_url":"https://api.github.com/repos/dusktreader/flask-praetorian/hooks","issue_events_url":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/events{/number}","events_url":"https://api.github.com/repos/dusktreader/flask-praetorian/events","assignees_url":"https://api.github.com/repos/dusktreader/flask-praetorian/assignees{/user}","branches_url":"https://api.github.com/repos/dusktreader/flask-praetorian/branches{/branch}","tags_url":"https://api.github.com/repos/dusktreader/flask-praetorian/tags","blobs_url":"https://api.github.com/repos/dusktreader/flask-praetorian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dusktreader/flask-praetorian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dusktreader/flask-praetorian/git/refs{/sha}","trees_url":"https://api.github.com/repos/dusktreader/flask-praetorian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dusktreader/flask-praetorian/statuses/{sha}","languages_url":"https://api.github.com/repos/dusktreader/flask-praetorian/languages","stargazers_url":"https://api.github.com/repos/dusktreader/flask-praetorian/stargazers","contributors_url":"https://api.github.com/repos/dusktreader/flask-praetorian/contributors","subscribers_url":"https://api.github.com/repos/dusktreader/flask-praetorian/subscribers","subscription_url":"https://api.github.com/repos/dusktreader/flask-praetorian/subscription","commits_url":"https://api.github.com/repos/dusktreader/flask-praetorian/commits{/sha}","git_commits_url":"https://api.github.com/repos/dusktreader/flask-praetorian/git/commits{/sha}","comments_url":"https://api.github.com/repos/dusktreader/flask-praetorian/comments{/number}","issue_comment_url":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/comments{/number}","contents_url":"https://api.github.com/repos/dusktreader/flask-praetorian/contents/{+path}","compare_url":"https://api.github.com/repos/dusktreader/flask-praetorian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dusktreader/flask-praetorian/merges","archive_url":"https://api.github.com/repos/dusktreader/flask-praetorian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dusktreader/flask-praetorian/downloads","issues_url":"https://api.github.com/repos/dusktreader/flask-praetorian/issues{/number}","pulls_url":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls{/number}","milestones_url":"https://api.github.com/repos/dusktreader/flask-praetorian/milestones{/number}","notifications_url":"https://api.github.com/repos/dusktreader/flask-praetorian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dusktreader/flask-praetorian/labels{/name}","releases_url":"https://api.github.com/repos/dusktreader/flask-praetorian/releases{/id}","deployments_url":"https://api.github.com/repos/dusktreader/flask-praetorian/deployments","created_at":"2016-11-23T16:47:18Z","updated_at":"2018-11-13T19:45:21Z","pushed_at":"2018-11-12T21:35:12Z","git_url":"git://github.com/dusktreader/flask-praetorian.git","ssh_url":"git@github.com:dusktreader/flask-praetorian.git","clone_url":"https://github.com/dusktreader/flask-praetorian.git","svn_url":"https://github.com/dusktreader/flask-praetorian","homepage":"http://flask-praetorian.readthedocs.io/en/latest/","size":2831,"stargazers_count":96,"watchers_count":96,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":7,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146"},"html":{"href":"https://github.com/dusktreader/flask-praetorian/pull/146"},"issue":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/146"},"comments":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/dusktreader/flask-praetorian/statuses/b8f91adbd02fb9b7944b8680d9116c641bd1d5ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"pahrohfit"}}