{"action":"closed","number":3243,"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3243","id":222224570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjI0NTcw","html_url":"https://github.com/eclipse/openj9/pull/3243","diff_url":"https://github.com/eclipse/openj9/pull/3243.diff","patch_url":"https://github.com/eclipse/openj9/pull/3243.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3243","number":3243,"state":"closed","locked":false,"title":"Remove the use of the C Preprocessor on NASM assembly files","user":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"body":"NASM assembly files will no longer need the C Preprocessor. Going forward, there will be no intermediate source files to look at when debugging any of the JIT assembly code. Furthermore, OMR will not need to update its CMake files to handle the temporary `pnasm` extention (see eclipse/omr#3042)\r\n\r\nDepends on: #3237 \r\n\r\n~WIP because of dependency on the PR above which enables writing constants in `jilconsts.inc` with `%define` directives.~","created_at":"2018-10-11T17:49:00Z","updated_at":"2018-10-12T18:44:08Z","closed_at":"2018-10-12T18:44:08Z","merged_at":"2018-10-12T18:44:08Z","merge_commit_sha":"2f039d8a487c1d4f281742e3c91241aa02fca10d","assignee":{"login":"0xdaryl","id":17713611,"node_id":"MDQ6VXNlcjE3NzEzNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"assignees":[{"login":"0xdaryl","id":17713611,"node_id":"MDQ6VXNlcjE3NzEzNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962585,"node_id":"MDU6TGFiZWw2OTc5NjI1ODU=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:jit","name":"comp:jit","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3243/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3243/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3243/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/c8f5b02ee9ce4ef7c14f347b8956c27f56533431","head":{"label":"nbhuiyan:no-cpp-nasm","ref":"no-cpp-nasm","sha":"c8f5b02ee9ce4ef7c14f347b8956c27f56533431","user":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"repo":{"id":111456935,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0NTY5MzU=","name":"openj9","full_name":"nbhuiyan/openj9","private":false,"owner":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nbhuiyan/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/nbhuiyan/openj9","forks_url":"https://api.github.com/repos/nbhuiyan/openj9/forks","keys_url":"https://api.github.com/repos/nbhuiyan/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbhuiyan/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbhuiyan/openj9/teams","hooks_url":"https://api.github.com/repos/nbhuiyan/openj9/hooks","issue_events_url":"https://api.github.com/repos/nbhuiyan/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/nbhuiyan/openj9/events","assignees_url":"https://api.github.com/repos/nbhuiyan/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/nbhuiyan/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/nbhuiyan/openj9/tags","blobs_url":"https://api.github.com/repos/nbhuiyan/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbhuiyan/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbhuiyan/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbhuiyan/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbhuiyan/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/nbhuiyan/openj9/languages","stargazers_url":"https://api.github.com/repos/nbhuiyan/openj9/stargazers","contributors_url":"https://api.github.com/repos/nbhuiyan/openj9/contributors","subscribers_url":"https://api.github.com/repos/nbhuiyan/openj9/subscribers","subscription_url":"https://api.github.com/repos/nbhuiyan/openj9/subscription","commits_url":"https://api.github.com/repos/nbhuiyan/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbhuiyan/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbhuiyan/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbhuiyan/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbhuiyan/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/nbhuiyan/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbhuiyan/openj9/merges","archive_url":"https://api.github.com/repos/nbhuiyan/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbhuiyan/openj9/downloads","issues_url":"https://api.github.com/repos/nbhuiyan/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/nbhuiyan/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/nbhuiyan/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/nbhuiyan/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbhuiyan/openj9/labels{/name}","releases_url":"https://api.github.com/repos/nbhuiyan/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/nbhuiyan/openj9/deployments","created_at":"2017-11-20T20:01:42Z","updated_at":"2018-10-12T16:29:46Z","pushed_at":"2018-10-12T16:29:45Z","git_url":"git://github.com/nbhuiyan/openj9.git","ssh_url":"git@github.com:nbhuiyan/openj9.git","clone_url":"https://github.com/nbhuiyan/openj9.git","svn_url":"https://github.com/nbhuiyan/openj9","homepage":"","size":35781,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"db3043a197d432ad3002bbd176883137406a53bb","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-10-12T18:34:28Z","pushed_at":"2018-10-12T18:44:08Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":37086,"stargazers_count":1484,"watchers_count":1484,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":486,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":287,"open_issues":486,"watchers":1484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3243"},"html":{"href":"https://github.com/eclipse/openj9/pull/3243"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3243"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3243/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3243/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3243/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/c8f5b02ee9ce4ef7c14f347b8956c27f56533431"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"0xdaryl","id":17713611,"node_id":"MDQ6VXNlcjE3NzEzNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":11,"deletions":50,"changed_files":4}}
{"actor":{"display_login":"0xdaryl"}}