{"action":"created","issue":{"url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/104","repository_url":"https://api.github.com/repos/NTumbleBit/NTumbleBit","labels_url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/104/comments","events_url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/104/events","html_url":"https://github.com/NTumbleBit/NTumbleBit/pull/104","id":302445461,"number":104,"title":"Updated the proof implementation","user":{"login":"osagga","id":5073889,"avatar_url":"https://avatars0.githubusercontent.com/u/5073889?v=4","gravatar_id":"","url":"https://api.github.com/users/osagga","html_url":"https://github.com/osagga","followers_url":"https://api.github.com/users/osagga/followers","following_url":"https://api.github.com/users/osagga/following{/other_user}","gists_url":"https://api.github.com/users/osagga/gists{/gist_id}","starred_url":"https://api.github.com/users/osagga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osagga/subscriptions","organizations_url":"https://api.github.com/users/osagga/orgs","repos_url":"https://api.github.com/users/osagga/repos","events_url":"https://api.github.com/users/osagga/events{/privacy}","received_events_url":"https://api.github.com/users/osagga/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars0.githubusercontent.com/u/3020646?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"assignees":[{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars0.githubusercontent.com/u/3020646?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-03-05T20:14:54Z","updated_at":"2018-03-05T21:04:58Z","closed_at":"2018-03-05T21:04:35Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/pulls/104","html_url":"https://github.com/NTumbleBit/NTumbleBit/pull/104","diff_url":"https://github.com/NTumbleBit/NTumbleBit/pull/104.diff","patch_url":"https://github.com/NTumbleBit/NTumbleBit/pull/104.patch"},"body":"The TumbleBitSetup protocol paper was reviewed and the protocol was modified slightly. This pull request updates the implementation to reflect the fixes/updates to the paper.\r\n\r\nFixes included:\r\n- The way m1 and m2 are generated (changed in the paper).\r\n- The number of m1 iterations was not preformed correctly\r\n  - Originally it was:\r\n https://github.com/NTumbleBit/NTumbleBit/blob/1f036dac064af240b8b951deada87fde36834c83/NTumbleBit/Proof/PermutationTest/Implementation/PermutationTest.cs#L72-L75\r\n    But this would preform `m+1` iterations since i starts from 0\r\n  So the fix would be to remove the `=` sign on line 74\r\n\r\nChanges include performance optimizations such as the way the Modulus value of the RSA key was checked.\r\nInstead of this\r\nhttps://github.com/NTumbleBit/NTumbleBit/blob/1f036dac064af240b8b951deada87fde36834c83/NTumbleBit/Proof/PermutationTest/Implementation/PermutationTest.cs#L105-L117\r\nWe can just do this instead\r\n```csharp          \r\n            // if N < 2^{KeySize-1} or N >= 2^{KeySize}\r\n            if (Modulus.BitLength != keyLength)\r\n                return false;\r\n```\r\nAnd other small optimizations that could be found in the pull request.\r\n\r\nI ran `NTumbleBit.Tests:TestStandard` after the changes and it passed, feel free to try any other tests and check if the updates would break anything."},"comment":{"url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/comments/370565146","html_url":"https://github.com/NTumbleBit/NTumbleBit/pull/104#issuecomment-370565146","issue_url":"https://api.github.com/repos/NTumbleBit/NTumbleBit/issues/104","id":370565146,"user":{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars0.githubusercontent.com/u/3020646?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T21:04:58Z","updated_at":"2018-03-05T21:04:58Z","author_association":"CONTRIBUTOR","body":"Thanks, I will update TB later to use native bech32 and 0.16.0 as well."}}
{"actor":{"display_login":"NicolasDorier"}}