{"action":"created","comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/198051287","pull_request_review_id":131908133,"id":198051287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA1MTI4Nw==","diff_hunk":"@@ -2887,6 +2964,73 @@ by a client in protected packets, because it is certain that the server is able\n to decipher the packet.\n \n \n+## ACK_ECN Frame {#frame-ack-ecn}\n+\n+A QUIC connection MUST keep counters for each ECN codepoint, recording the\n+number of packets that were received with the corresponding ECN codepoint in the\n+IP header. If the header is not readable from the application, the codepoint 00\n+(Not-ECT) MUST be assumed. If any packet are duplicated by the network then only","path":"draft-ietf-quic-transport.md","position":182,"original_position":182,"commit_id":"cf312f90a6d844953e35a095d411e20965724124","original_commit_id":"cf312f90a6d844953e35a095d411e20965724124","user":{"login":"larseggert","id":200328,"node_id":"MDQ6VXNlcjIwMDMyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/200328?v=4","gravatar_id":"","url":"https://api.github.com/users/larseggert","html_url":"https://github.com/larseggert","followers_url":"https://api.github.com/users/larseggert/followers","following_url":"https://api.github.com/users/larseggert/following{/other_user}","gists_url":"https://api.github.com/users/larseggert/gists{/gist_id}","starred_url":"https://api.github.com/users/larseggert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larseggert/subscriptions","organizations_url":"https://api.github.com/users/larseggert/orgs","repos_url":"https://api.github.com/users/larseggert/repos","events_url":"https://api.github.com/users/larseggert/events{/privacy}","received_events_url":"https://api.github.com/users/larseggert/received_events","type":"User","site_admin":false},"body":"s/by the network/by the network,/","created_at":"2018-06-26T08:15:27Z","updated_at":"2018-06-26T08:35:59Z","html_url":"https://github.com/quicwg/base-drafts/pull/1372#discussion_r198051287","pull_request_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/198051287"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1372#discussion_r198051287"},"pull_request":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372"}},"in_reply_to_id":198051071},"pull_request":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372","id":189751939,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NzUxOTM5","html_url":"https://github.com/quicwg/base-drafts/pull/1372","diff_url":"https://github.com/quicwg/base-drafts/pull/1372.diff","patch_url":"https://github.com/quicwg/base-drafts/pull/1372.patch","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1372","number":1372,"state":"open","locked":false,"title":"Proposal for adding ECN support to QUIC.","user":{"login":"gloinul","id":11295323,"node_id":"MDQ6VXNlcjExMjk1MzIz","avatar_url":"https://avatars3.githubusercontent.com/u/11295323?v=4","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"body":"This pull request contains an initial adaptation of what was in the design teams Wiki, but with more explanatory glue, and modifications to places where ACK or ACK_ECN frames can be used for example. \r\n\r\nRecovery draft changes are only pseudo code level so far and need a bit more work. ","created_at":"2018-05-22T18:24:54Z","updated_at":"2018-06-26T08:35:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c02898b0a7c40cf3f947afcb0d501e2844e49a5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372/commits","review_comments_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372/comments","review_comment_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1372/comments","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/cf312f90a6d844953e35a095d411e20965724124","head":{"label":"gloinul:ecn","ref":"ecn","sha":"cf312f90a6d844953e35a095d411e20965724124","user":{"login":"gloinul","id":11295323,"node_id":"MDQ6VXNlcjExMjk1MzIz","avatar_url":"https://avatars3.githubusercontent.com/u/11295323?v=4","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"repo":{"id":116247066,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYyNDcwNjY=","name":"base-drafts","full_name":"gloinul/base-drafts","owner":{"login":"gloinul","id":11295323,"node_id":"MDQ6VXNlcjExMjk1MzIz","avatar_url":"https://avatars3.githubusercontent.com/u/11295323?v=4","gravatar_id":"","url":"https://api.github.com/users/gloinul","html_url":"https://github.com/gloinul","followers_url":"https://api.github.com/users/gloinul/followers","following_url":"https://api.github.com/users/gloinul/following{/other_user}","gists_url":"https://api.github.com/users/gloinul/gists{/gist_id}","starred_url":"https://api.github.com/users/gloinul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloinul/subscriptions","organizations_url":"https://api.github.com/users/gloinul/orgs","repos_url":"https://api.github.com/users/gloinul/repos","events_url":"https://api.github.com/users/gloinul/events{/privacy}","received_events_url":"https://api.github.com/users/gloinul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gloinul/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":true,"url":"https://api.github.com/repos/gloinul/base-drafts","forks_url":"https://api.github.com/repos/gloinul/base-drafts/forks","keys_url":"https://api.github.com/repos/gloinul/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gloinul/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gloinul/base-drafts/teams","hooks_url":"https://api.github.com/repos/gloinul/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/gloinul/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/gloinul/base-drafts/events","assignees_url":"https://api.github.com/repos/gloinul/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/gloinul/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/gloinul/base-drafts/tags","blobs_url":"https://api.github.com/repos/gloinul/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gloinul/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gloinul/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/gloinul/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gloinul/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/gloinul/base-drafts/languages","stargazers_url":"https://api.github.com/repos/gloinul/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/gloinul/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/gloinul/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/gloinul/base-drafts/subscription","commits_url":"https://api.github.com/repos/gloinul/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/gloinul/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/gloinul/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/gloinul/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/gloinul/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/gloinul/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gloinul/base-drafts/merges","archive_url":"https://api.github.com/repos/gloinul/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gloinul/base-drafts/downloads","issues_url":"https://api.github.com/repos/gloinul/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/gloinul/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/gloinul/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/gloinul/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gloinul/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/gloinul/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/gloinul/base-drafts/deployments","created_at":"2018-01-04T10:29:56Z","updated_at":"2018-01-04T10:29:58Z","pushed_at":"2018-06-25T23:22:30Z","git_url":"git://github.com/gloinul/base-drafts.git","ssh_url":"git@github.com:gloinul/base-drafts.git","clone_url":"https://github.com/gloinul/base-drafts.git","svn_url":"https://github.com/gloinul/base-drafts","homepage":"https://quicwg.github.io/","size":36129,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"quicwg:master","ref":"master","sha":"031f07f40bf91b8d13f0a766cf22fcc10e7e5cec","user":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc3OTU5OQ==","name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-06-26T00:42:26Z","pushed_at":"2018-06-26T06:35:51Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":53107,"stargazers_count":258,"watchers_count":258,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":138,"license":null,"forks":63,"open_issues":138,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1372"},"issue":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1372"},"comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1372/comments"},"review_comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372/comments"},"review_comment":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1372/commits"},"statuses":{"href":"https://api.github.com/repos/quicwg/base-drafts/statuses/cf312f90a6d844953e35a095d411e20965724124"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"larseggert"}}