{"action":"closed","number":62,"pull_request":{"url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62","id":207041464,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDQxNDY0","html_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard/pull/62","diff_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard/pull/62.diff","patch_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard/pull/62.patch","issue_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/62","number":62,"state":"closed","locked":false,"title":"Remove Novell eDirectory-specific code","user":{"login":"mstum","id":104127,"node_id":"MDQ6VXNlcjEwNDEyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/104127?v=4","gravatar_id":"","url":"https://api.github.com/users/mstum","html_url":"https://github.com/mstum","followers_url":"https://api.github.com/users/mstum/followers","following_url":"https://api.github.com/users/mstum/following{/other_user}","gists_url":"https://api.github.com/users/mstum/gists{/gist_id}","starred_url":"https://api.github.com/users/mstum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstum/subscriptions","organizations_url":"https://api.github.com/users/mstum/orgs","repos_url":"https://api.github.com/users/mstum/repos","events_url":"https://api.github.com/users/mstum/events{/privacy}","received_events_url":"https://api.github.com/users/mstum/received_events","type":"User","site_admin":false},"body":"Novell used to have their own LDAP Server, Novell eDirectory. They added [a bunch of LDAP Extensions](https://www.novell.com/documentation/developer/ldapover/ldap_enu/data/a6ik7oi.html) that is properitary to eDirectory (Anything that starts with [OID 2.16.840.1.113719.1](http://oidref.com/2.16.840.1.113719.1) is specific to Novell).\r\n\r\nNaturally, they added all these Extensions [to their own LDAP Client](https://www.novell.com/documentation/developer/jldap/jldapenu/data/ab4o245.html) and thus they are in the C# port.\r\n\r\nNow, that was in 2006, and since then eDirectory got acquired and is now [NetIQ eDirectory](https://www.netiq.com/products/edirectory/) and while [it seems to still use the Novell extensions](https://www.netiq.com/documentation/edir88/edir88/data/b4r36pg.html), I doubt anyone has tested this stuff in forever.\r\n\r\nI think that it's best to remove the code that's eDirectory specific since it's a large amount of code that's just sitting around, and I feel that support for properitary LDAP Extensions is best done as a separate library/nuget package (for which a better extensibility might be needed).\r\n\r\nSo this PR just rips out all Novell eDirectory-specific code, and if there is a request/requirement to re-add it I'd suggest creating a separate Novell.Directory.Ldap.NETStandard.eDirectory project/nuget package.","created_at":"2018-08-08T15:09:30Z","updated_at":"2018-08-13T09:16:56Z","closed_at":"2018-08-13T09:16:56Z","merged_at":"2018-08-13T09:16:56Z","merge_commit_sha":"1694ffdcd9267d466ffd20fda711d231fae4e80c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62/commits","review_comments_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62/comments","review_comment_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/62/comments","statuses_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/statuses/9f8edc7893b7b610fea94791fb275fa22e67b553","head":{"label":"mstum:RemoveEDirectory","ref":"RemoveEDirectory","sha":"9f8edc7893b7b610fea94791fb275fa22e67b553","user":{"login":"mstum","id":104127,"node_id":"MDQ6VXNlcjEwNDEyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/104127?v=4","gravatar_id":"","url":"https://api.github.com/users/mstum","html_url":"https://github.com/mstum","followers_url":"https://api.github.com/users/mstum/followers","following_url":"https://api.github.com/users/mstum/following{/other_user}","gists_url":"https://api.github.com/users/mstum/gists{/gist_id}","starred_url":"https://api.github.com/users/mstum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstum/subscriptions","organizations_url":"https://api.github.com/users/mstum/orgs","repos_url":"https://api.github.com/users/mstum/repos","events_url":"https://api.github.com/users/mstum/events{/privacy}","received_events_url":"https://api.github.com/users/mstum/received_events","type":"User","site_admin":false},"repo":{"id":143753798,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NTM3OTg=","name":"Novell.Directory.Ldap.NETStandard","full_name":"mstum/Novell.Directory.Ldap.NETStandard","owner":{"login":"mstum","id":104127,"node_id":"MDQ6VXNlcjEwNDEyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/104127?v=4","gravatar_id":"","url":"https://api.github.com/users/mstum","html_url":"https://github.com/mstum","followers_url":"https://api.github.com/users/mstum/followers","following_url":"https://api.github.com/users/mstum/following{/other_user}","gists_url":"https://api.github.com/users/mstum/gists{/gist_id}","starred_url":"https://api.github.com/users/mstum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstum/subscriptions","organizations_url":"https://api.github.com/users/mstum/orgs","repos_url":"https://api.github.com/users/mstum/repos","events_url":"https://api.github.com/users/mstum/events{/privacy}","received_events_url":"https://api.github.com/users/mstum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstum/Novell.Directory.Ldap.NETStandard","description":"LDAP client library for .NET Standard 1.3 and up - works with any LDAP protocol compatible directory server (including Microsoft Active Directory).","fork":true,"url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard","forks_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/forks","keys_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/teams","hooks_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/hooks","issue_events_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/issues/events{/number}","events_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/events","assignees_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/assignees{/user}","branches_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/branches{/branch}","tags_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/tags","blobs_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/statuses/{sha}","languages_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/languages","stargazers_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/stargazers","contributors_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/contributors","subscribers_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/subscribers","subscription_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/subscription","commits_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/contents/{+path}","compare_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/merges","archive_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/downloads","issues_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/issues{/number}","pulls_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/pulls{/number}","milestones_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/milestones{/number}","notifications_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/labels{/name}","releases_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/releases{/id}","deployments_url":"https://api.github.com/repos/mstum/Novell.Directory.Ldap.NETStandard/deployments","created_at":"2018-08-06T16:17:29Z","updated_at":"2018-08-08T14:39:05Z","pushed_at":"2018-08-12T06:07:31Z","git_url":"git://github.com/mstum/Novell.Directory.Ldap.NETStandard.git","ssh_url":"git@github.com:mstum/Novell.Directory.Ldap.NETStandard.git","clone_url":"https://github.com/mstum/Novell.Directory.Ldap.NETStandard.git","svn_url":"https://github.com/mstum/Novell.Directory.Ldap.NETStandard","homepage":"","size":2133,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dsbenghe:master","ref":"master","sha":"b23d445bc5e8b1e2c5c02ab468ac59111c6dda12","user":{"login":"dsbenghe","id":9379302,"node_id":"MDQ6VXNlcjkzNzkzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9379302?v=4","gravatar_id":"","url":"https://api.github.com/users/dsbenghe","html_url":"https://github.com/dsbenghe","followers_url":"https://api.github.com/users/dsbenghe/followers","following_url":"https://api.github.com/users/dsbenghe/following{/other_user}","gists_url":"https://api.github.com/users/dsbenghe/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbenghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbenghe/subscriptions","organizations_url":"https://api.github.com/users/dsbenghe/orgs","repos_url":"https://api.github.com/users/dsbenghe/repos","events_url":"https://api.github.com/users/dsbenghe/events{/privacy}","received_events_url":"https://api.github.com/users/dsbenghe/received_events","type":"User","site_admin":false},"repo":{"id":58428685,"node_id":"MDEwOlJlcG9zaXRvcnk1ODQyODY4NQ==","name":"Novell.Directory.Ldap.NETStandard","full_name":"dsbenghe/Novell.Directory.Ldap.NETStandard","owner":{"login":"dsbenghe","id":9379302,"node_id":"MDQ6VXNlcjkzNzkzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9379302?v=4","gravatar_id":"","url":"https://api.github.com/users/dsbenghe","html_url":"https://github.com/dsbenghe","followers_url":"https://api.github.com/users/dsbenghe/followers","following_url":"https://api.github.com/users/dsbenghe/following{/other_user}","gists_url":"https://api.github.com/users/dsbenghe/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbenghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbenghe/subscriptions","organizations_url":"https://api.github.com/users/dsbenghe/orgs","repos_url":"https://api.github.com/users/dsbenghe/repos","events_url":"https://api.github.com/users/dsbenghe/events{/privacy}","received_events_url":"https://api.github.com/users/dsbenghe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard","description":"LDAP client library for .NET Standard 1.3 and up - works with any LDAP protocol compatible directory server (including Microsoft Active Directory).","fork":false,"url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard","forks_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/forks","keys_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/teams","hooks_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/hooks","issue_events_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/events{/number}","events_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/events","assignees_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/assignees{/user}","branches_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/branches{/branch}","tags_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/tags","blobs_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/statuses/{sha}","languages_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/languages","stargazers_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/stargazers","contributors_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/contributors","subscribers_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/subscribers","subscription_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/subscription","commits_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/contents/{+path}","compare_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/merges","archive_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/downloads","issues_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues{/number}","pulls_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls{/number}","milestones_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/milestones{/number}","notifications_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/labels{/name}","releases_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/releases{/id}","deployments_url":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/deployments","created_at":"2016-05-10T04:01:22Z","updated_at":"2018-08-08T10:38:33Z","pushed_at":"2018-08-13T09:16:56Z","git_url":"git://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard.git","ssh_url":"git@github.com:dsbenghe/Novell.Directory.Ldap.NETStandard.git","clone_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard.git","svn_url":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard","homepage":"","size":1897,"stargazers_count":122,"watchers_count":122,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":43,"open_issues":9,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62"},"html":{"href":"https://github.com/dsbenghe/Novell.Directory.Ldap.NETStandard/pull/62"},"issue":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/62"},"comments":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/dsbenghe/Novell.Directory.Ldap.NETStandard/statuses/9f8edc7893b7b610fea94791fb275fa22e67b553"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dsbenghe","id":9379302,"node_id":"MDQ6VXNlcjkzNzkzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9379302?v=4","gravatar_id":"","url":"https://api.github.com/users/dsbenghe","html_url":"https://github.com/dsbenghe","followers_url":"https://api.github.com/users/dsbenghe/followers","following_url":"https://api.github.com/users/dsbenghe/following{/other_user}","gists_url":"https://api.github.com/users/dsbenghe/gists{/gist_id}","starred_url":"https://api.github.com/users/dsbenghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsbenghe/subscriptions","organizations_url":"https://api.github.com/users/dsbenghe/orgs","repos_url":"https://api.github.com/users/dsbenghe/repos","events_url":"https://api.github.com/users/dsbenghe/events{/privacy}","received_events_url":"https://api.github.com/users/dsbenghe/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":7436,"changed_files":61}}
{"actor":{"display_login":"dsbenghe"}}