{"action":"created","comment":{"url":"https://api.github.com/repos/chef/inspec/pulls/comments/176466751","pull_request_review_id":106174376,"id":176466751,"diff_hunk":"@@ -86,7 +86,14 @@ Provides the destination that the SNS Topic will send notifications to.\n \n     # Inspect the endpoint\n     describe aws_sns_subscription(subscription_arn: 'arn:aws:sns:us-east-1::test-topic-01:b214aff5-a2c7-438f-a753-8494493f2ff6' ) do\n-      its('endpoint') { should cmp 'arn:aws:sns:us-east-1::test-topic-02' }\n+      # If protocol is 'sms', this should be a phone number:\n+      its('endpoint') { should cmp '+16105551234' }\n+      # If protocol is 'email' or 'email-json', endpoint should be an email address\n+      its('endpoint') { should cmp 'myemail@example.com' }\n+      # If protocal is 'http', endpoint should be a URL beginning with 'https://'\n+      its('endpoint') { should cmp 'https://www.exampleurl.com' }\n+      # If the protocol is 'lambda', its endpoint should be the ARN of a AWS Lambda function\n+      its('endpoint') { should cmp 'rn:aws:lambda:us-east-1:account-id:function:myfunction' }","path":"docs/resources/aws_sns_subscription.md.erb","position":96,"original_position":48,"commit_id":"c6d640145b1a90fd8ab58fe1f5d4f2ca1ad52b0c","original_commit_id":"c6d640145b1a90fd8ab58fe1f5d4f2ca1ad52b0c","user":{"login":"clintoncwolfe","id":156460,"avatar_url":"https://avatars3.githubusercontent.com/u/156460?v=4","gravatar_id":"","url":"https://api.github.com/users/clintoncwolfe","html_url":"https://github.com/clintoncwolfe","followers_url":"https://api.github.com/users/clintoncwolfe/followers","following_url":"https://api.github.com/users/clintoncwolfe/following{/other_user}","gists_url":"https://api.github.com/users/clintoncwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/clintoncwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintoncwolfe/subscriptions","organizations_url":"https://api.github.com/users/clintoncwolfe/orgs","repos_url":"https://api.github.com/users/clintoncwolfe/repos","events_url":"https://api.github.com/users/clintoncwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/clintoncwolfe/received_events","type":"User","site_admin":false},"body":":100:","created_at":"2018-03-22T15:35:57Z","updated_at":"2018-03-22T15:37:39Z","html_url":"https://github.com/chef/inspec/pull/2697#discussion_r176466751","pull_request_url":"https://api.github.com/repos/chef/inspec/pulls/2697","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chef/inspec/pulls/comments/176466751"},"html":{"href":"https://github.com/chef/inspec/pull/2697#discussion_r176466751"},"pull_request":{"href":"https://api.github.com/repos/chef/inspec/pulls/2697"}}},"pull_request":{"url":"https://api.github.com/repos/chef/inspec/pulls/2697","id":170025240,"html_url":"https://github.com/chef/inspec/pull/2697","diff_url":"https://github.com/chef/inspec/pull/2697.diff","patch_url":"https://github.com/chef/inspec/pull/2697.patch","issue_url":"https://api.github.com/repos/chef/inspec/issues/2697","number":2697,"state":"open","locked":false,"title":"New Skeletal Resource aws_sns_subscription","user":{"login":"dromazmj","id":28717645,"avatar_url":"https://avatars1.githubusercontent.com/u/28717645?v=4","gravatar_id":"","url":"https://api.github.com/users/dromazmj","html_url":"https://github.com/dromazmj","followers_url":"https://api.github.com/users/dromazmj/followers","following_url":"https://api.github.com/users/dromazmj/following{/other_user}","gists_url":"https://api.github.com/users/dromazmj/gists{/gist_id}","starred_url":"https://api.github.com/users/dromazmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dromazmj/subscriptions","organizations_url":"https://api.github.com/users/dromazmj/orgs","repos_url":"https://api.github.com/users/dromazmj/repos","events_url":"https://api.github.com/users/dromazmj/events{/privacy}","received_events_url":"https://api.github.com/users/dromazmj/received_events","type":"User","site_admin":false},"body":"This PR adds functionality for a new resource that allows testing against a SNS Subscription.\r\n\r\nSigned-off-by: Matthew Dromazos <dromazmj@dukes.jmu.edu>","created_at":"2018-02-19T18:09:39Z","updated_at":"2018-03-22T15:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c084b96f4486868c9c0a0839c0abb0ac07d742bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":669500225,"url":"https://api.github.com/repos/chef/inspec/labels/Type:%20New%20Resource","name":"Type: New Resource","color":"1d76db","default":false},{"id":832497816,"url":"https://api.github.com/repos/chef/inspec/labels/aws","name":"aws","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chef/inspec/pulls/2697/commits","review_comments_url":"https://api.github.com/repos/chef/inspec/pulls/2697/comments","review_comment_url":"https://api.github.com/repos/chef/inspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/inspec/issues/2697/comments","statuses_url":"https://api.github.com/repos/chef/inspec/statuses/c6d640145b1a90fd8ab58fe1f5d4f2ca1ad52b0c","head":{"label":"dromazmj:md/aws_sns_subscription","ref":"md/aws_sns_subscription","sha":"c6d640145b1a90fd8ab58fe1f5d4f2ca1ad52b0c","user":{"login":"dromazmj","id":28717645,"avatar_url":"https://avatars1.githubusercontent.com/u/28717645?v=4","gravatar_id":"","url":"https://api.github.com/users/dromazmj","html_url":"https://github.com/dromazmj","followers_url":"https://api.github.com/users/dromazmj/followers","following_url":"https://api.github.com/users/dromazmj/following{/other_user}","gists_url":"https://api.github.com/users/dromazmj/gists{/gist_id}","starred_url":"https://api.github.com/users/dromazmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dromazmj/subscriptions","organizations_url":"https://api.github.com/users/dromazmj/orgs","repos_url":"https://api.github.com/users/dromazmj/repos","events_url":"https://api.github.com/users/dromazmj/events{/privacy}","received_events_url":"https://api.github.com/users/dromazmj/received_events","type":"User","site_admin":false},"repo":{"id":121163579,"name":"inspec","full_name":"dromazmj/inspec","owner":{"login":"dromazmj","id":28717645,"avatar_url":"https://avatars1.githubusercontent.com/u/28717645?v=4","gravatar_id":"","url":"https://api.github.com/users/dromazmj","html_url":"https://github.com/dromazmj","followers_url":"https://api.github.com/users/dromazmj/followers","following_url":"https://api.github.com/users/dromazmj/following{/other_user}","gists_url":"https://api.github.com/users/dromazmj/gists{/gist_id}","starred_url":"https://api.github.com/users/dromazmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dromazmj/subscriptions","organizations_url":"https://api.github.com/users/dromazmj/orgs","repos_url":"https://api.github.com/users/dromazmj/repos","events_url":"https://api.github.com/users/dromazmj/events{/privacy}","received_events_url":"https://api.github.com/users/dromazmj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dromazmj/inspec","description":"InSpec: Auditing and Testing Framework","fork":true,"url":"https://api.github.com/repos/dromazmj/inspec","forks_url":"https://api.github.com/repos/dromazmj/inspec/forks","keys_url":"https://api.github.com/repos/dromazmj/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dromazmj/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dromazmj/inspec/teams","hooks_url":"https://api.github.com/repos/dromazmj/inspec/hooks","issue_events_url":"https://api.github.com/repos/dromazmj/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/dromazmj/inspec/events","assignees_url":"https://api.github.com/repos/dromazmj/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/dromazmj/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/dromazmj/inspec/tags","blobs_url":"https://api.github.com/repos/dromazmj/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dromazmj/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dromazmj/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/dromazmj/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dromazmj/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/dromazmj/inspec/languages","stargazers_url":"https://api.github.com/repos/dromazmj/inspec/stargazers","contributors_url":"https://api.github.com/repos/dromazmj/inspec/contributors","subscribers_url":"https://api.github.com/repos/dromazmj/inspec/subscribers","subscription_url":"https://api.github.com/repos/dromazmj/inspec/subscription","commits_url":"https://api.github.com/repos/dromazmj/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/dromazmj/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/dromazmj/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/dromazmj/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/dromazmj/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/dromazmj/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dromazmj/inspec/merges","archive_url":"https://api.github.com/repos/dromazmj/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dromazmj/inspec/downloads","issues_url":"https://api.github.com/repos/dromazmj/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/dromazmj/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/dromazmj/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/dromazmj/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dromazmj/inspec/labels{/name}","releases_url":"https://api.github.com/repos/dromazmj/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/dromazmj/inspec/deployments","created_at":"2018-02-11T20:23:21Z","updated_at":"2018-02-11T20:23:24Z","pushed_at":"2018-03-07T17:52:25Z","git_url":"git://github.com/dromazmj/inspec.git","ssh_url":"git@github.com:dromazmj/inspec.git","clone_url":"https://github.com/dromazmj/inspec.git","svn_url":"https://github.com/dromazmj/inspec","homepage":"http://inspec.io","size":12813,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"a0db14485aad94f69b77416b85dd12458ab59f39","user":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"name":"inspec","full_name":"chef/inspec","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/chef/inspec","forks_url":"https://api.github.com/repos/chef/inspec/forks","keys_url":"https://api.github.com/repos/chef/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/inspec/teams","hooks_url":"https://api.github.com/repos/chef/inspec/hooks","issue_events_url":"https://api.github.com/repos/chef/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/chef/inspec/events","assignees_url":"https://api.github.com/repos/chef/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/chef/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/chef/inspec/tags","blobs_url":"https://api.github.com/repos/chef/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/inspec/languages","stargazers_url":"https://api.github.com/repos/chef/inspec/stargazers","contributors_url":"https://api.github.com/repos/chef/inspec/contributors","subscribers_url":"https://api.github.com/repos/chef/inspec/subscribers","subscription_url":"https://api.github.com/repos/chef/inspec/subscription","commits_url":"https://api.github.com/repos/chef/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/chef/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/inspec/merges","archive_url":"https://api.github.com/repos/chef/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/inspec/downloads","issues_url":"https://api.github.com/repos/chef/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/chef/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/inspec/labels{/name}","releases_url":"https://api.github.com/repos/chef/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/chef/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2018-03-22T14:46:33Z","pushed_at":"2018-03-22T15:05:13Z","git_url":"git://github.com/chef/inspec.git","ssh_url":"git@github.com:chef/inspec.git","clone_url":"https://github.com/chef/inspec.git","svn_url":"https://github.com/chef/inspec","homepage":"http://inspec.io","size":12923,"stargazers_count":1100,"watchers_count":1100,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":313,"mirror_url":null,"archived":false,"open_issues_count":449,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":313,"open_issues":449,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/inspec/pulls/2697"},"html":{"href":"https://github.com/chef/inspec/pull/2697"},"issue":{"href":"https://api.github.com/repos/chef/inspec/issues/2697"},"comments":{"href":"https://api.github.com/repos/chef/inspec/issues/2697/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/inspec/pulls/2697/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/inspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/inspec/pulls/2697/commits"},"statuses":{"href":"https://api.github.com/repos/chef/inspec/statuses/c6d640145b1a90fd8ab58fe1f5d4f2ca1ad52b0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"clintoncwolfe"}}