{"action":"created","issue":{"url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/55","repository_url":"https://api.github.com/repos/prisma/graphql-resolver-codegen","labels_url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/55/comments","events_url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/55/events","html_url":"https://github.com/prisma/graphql-resolver-codegen/pull/55","id":366430043,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTA1ODM1","number":55,"title":"Fix: Enum Argument value ","user":{"login":"ryanquinn3","id":5115565,"node_id":"MDQ6VXNlcjUxMTU1NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/5115565?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanquinn3","html_url":"https://github.com/ryanquinn3","followers_url":"https://api.github.com/users/ryanquinn3/followers","following_url":"https://api.github.com/users/ryanquinn3/following{/other_user}","gists_url":"https://api.github.com/users/ryanquinn3/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanquinn3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanquinn3/subscriptions","organizations_url":"https://api.github.com/users/ryanquinn3/orgs","repos_url":"https://api.github.com/users/ryanquinn3/repos","events_url":"https://api.github.com/users/ryanquinn3/events{/privacy}","received_events_url":"https://api.github.com/users/ryanquinn3/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-03T16:44:18Z","updated_at":"2018-10-11T16:04:11Z","closed_at":"2018-10-11T16:04:11Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/pulls/55","html_url":"https://github.com/prisma/graphql-resolver-codegen/pull/55","diff_url":"https://github.com/prisma/graphql-resolver-codegen/pull/55.diff","patch_url":"https://github.com/prisma/graphql-resolver-codegen/pull/55.patch"},"body":"Took a stab at fixing: https://github.com/prisma/graphql-resolver-codegen/issues/53\r\n\r\nI also added a little tsc helper so its possible to sanity check the output of `generate`. I tried running the output of `scaffold-ts` against it but unfortunately, I think `isValidTypescript` is too naive. "},"comment":{"url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/comments/429014432","html_url":"https://github.com/prisma/graphql-resolver-codegen/pull/55#issuecomment-429014432","issue_url":"https://api.github.com/repos/prisma/graphql-resolver-codegen/issues/55","id":429014432,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAxNDQzMg==","user":{"login":"divyenduz","id":746482,"node_id":"MDQ6VXNlcjc0NjQ4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/746482?v=4","gravatar_id":"","url":"https://api.github.com/users/divyenduz","html_url":"https://github.com/divyenduz","followers_url":"https://api.github.com/users/divyenduz/followers","following_url":"https://api.github.com/users/divyenduz/following{/other_user}","gists_url":"https://api.github.com/users/divyenduz/gists{/gist_id}","starred_url":"https://api.github.com/users/divyenduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyenduz/subscriptions","organizations_url":"https://api.github.com/users/divyenduz/orgs","repos_url":"https://api.github.com/users/divyenduz/repos","events_url":"https://api.github.com/users/divyenduz/events{/privacy}","received_events_url":"https://api.github.com/users/divyenduz/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T16:04:11Z","updated_at":"2018-10-11T16:04:11Z","author_association":"COLLABORATOR","body":"Thanks for raising the PR, the implementation is correct, however, the validation part looks a bit off. I took inspiration from this and implemented this https://github.com/prisma/graphql-resolver-codegen/pull/68 (this is released in `0.3.1` beta - `npm install graphql-resolver-codegen@beta`)\r\n\r\nI will create a separate issue for TS validation. \r\n\r\nThanks again for your work 🙌 "}}
{"actor":{"display_login":"divyenduz"}}