{"action":"created","comment":{"url":"https://api.github.com/repos/Semmle/ql/pulls/comments/224140451","pull_request_review_id":163436436,"id":224140451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE0MDQ1MQ==","diff_hunk":"@@ -335,7 +346,8 @@ deprecated Expr getInitializer()\n ```\n \n ```ql\n-  if e1 instanceof BitwiseOrExpr or e1 instanceof LogicalOrExpr then (\n+  if e1 instanceof BitwiseOrExpr or e1 instanceof LogicalOrExpr\n+  then (","path":"docs/ql-style-guide.md","position":94,"original_position":94,"commit_id":"99846474eb9e2a56829c0f07a66877bb0e5982a5","original_commit_id":"99846474eb9e2a56829c0f07a66877bb0e5982a5","user":{"login":"aschackmull","id":28296824,"node_id":"MDQ6VXNlcjI4Mjk2ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/28296824?v=4","gravatar_id":"","url":"https://api.github.com/users/aschackmull","html_url":"https://github.com/aschackmull","followers_url":"https://api.github.com/users/aschackmull/followers","following_url":"https://api.github.com/users/aschackmull/following{/other_user}","gists_url":"https://api.github.com/users/aschackmull/gists{/gist_id}","starred_url":"https://api.github.com/users/aschackmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschackmull/subscriptions","organizations_url":"https://api.github.com/users/aschackmull/orgs","repos_url":"https://api.github.com/users/aschackmull/repos","events_url":"https://api.github.com/users/aschackmull/events{/privacy}","received_events_url":"https://api.github.com/users/aschackmull/received_events","type":"User","site_admin":false},"body":"I believe the consensus was to allow both.  With the autoformatter it makes sense to choose one of the two options.  (And IIRC I championed the \"`then` at eol\" style)","created_at":"2018-10-10T15:59:30Z","updated_at":"2018-10-10T15:59:30Z","html_url":"https://github.com/Semmle/ql/pull/148#discussion_r224140451","pull_request_url":"https://api.github.com/repos/Semmle/ql/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Semmle/ql/pulls/comments/224140451"},"html":{"href":"https://github.com/Semmle/ql/pull/148#discussion_r224140451"},"pull_request":{"href":"https://api.github.com/repos/Semmle/ql/pulls/148"}},"in_reply_to_id":224118635},"pull_request":{"url":"https://api.github.com/repos/Semmle/ql/pulls/148","id":212930190,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTMwMTkw","html_url":"https://github.com/Semmle/ql/pull/148","diff_url":"https://github.com/Semmle/ql/pull/148.diff","patch_url":"https://github.com/Semmle/ql/pull/148.patch","issue_url":"https://api.github.com/repos/Semmle/ql/issues/148","number":148,"state":"open","locked":false,"title":"QL style guide: Clarify some outstanding issues","user":{"login":"aschackmull","id":28296824,"node_id":"MDQ6VXNlcjI4Mjk2ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/28296824?v=4","gravatar_id":"","url":"https://api.github.com/users/aschackmull","html_url":"https://github.com/aschackmull","followers_url":"https://api.github.com/users/aschackmull/followers","following_url":"https://api.github.com/users/aschackmull/following{/other_user}","gists_url":"https://api.github.com/users/aschackmull/gists{/gist_id}","starred_url":"https://api.github.com/users/aschackmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschackmull/subscriptions","organizations_url":"https://api.github.com/users/aschackmull/orgs","repos_url":"https://api.github.com/users/aschackmull/repos","events_url":"https://api.github.com/users/aschackmull/events{/privacy}","received_events_url":"https://api.github.com/users/aschackmull/received_events","type":"User","site_admin":false},"body":"Two commits: The first makes some trivial whitespace fixes including unix newlines. The second introduces guidance for long parameter lists, parentheses surrounding `and`, `or`, and `not`, and formatting of quantifiers such as `exists`.","created_at":"2018-09-04T10:36:33Z","updated_at":"2018-10-10T15:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"464b26ccf438c5a881a732e93ebbc01b204dc5ef","assignee":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Semmle/ql/pulls/148/commits","review_comments_url":"https://api.github.com/repos/Semmle/ql/pulls/148/comments","review_comment_url":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Semmle/ql/issues/148/comments","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/99846474eb9e2a56829c0f07a66877bb0e5982a5","head":{"label":"aschackmull:docs/ql-style-guide","ref":"docs/ql-style-guide","sha":"99846474eb9e2a56829c0f07a66877bb0e5982a5","user":{"login":"aschackmull","id":28296824,"node_id":"MDQ6VXNlcjI4Mjk2ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/28296824?v=4","gravatar_id":"","url":"https://api.github.com/users/aschackmull","html_url":"https://github.com/aschackmull","followers_url":"https://api.github.com/users/aschackmull/followers","following_url":"https://api.github.com/users/aschackmull/following{/other_user}","gists_url":"https://api.github.com/users/aschackmull/gists{/gist_id}","starred_url":"https://api.github.com/users/aschackmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschackmull/subscriptions","organizations_url":"https://api.github.com/users/aschackmull/orgs","repos_url":"https://api.github.com/users/aschackmull/repos","events_url":"https://api.github.com/users/aschackmull/events{/privacy}","received_events_url":"https://api.github.com/users/aschackmull/received_events","type":"User","site_admin":false},"repo":{"id":143422705,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MjI3MDU=","name":"ql","full_name":"aschackmull/ql","private":false,"owner":{"login":"aschackmull","id":28296824,"node_id":"MDQ6VXNlcjI4Mjk2ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/28296824?v=4","gravatar_id":"","url":"https://api.github.com/users/aschackmull","html_url":"https://github.com/aschackmull","followers_url":"https://api.github.com/users/aschackmull/followers","following_url":"https://api.github.com/users/aschackmull/following{/other_user}","gists_url":"https://api.github.com/users/aschackmull/gists{/gist_id}","starred_url":"https://api.github.com/users/aschackmull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschackmull/subscriptions","organizations_url":"https://api.github.com/users/aschackmull/orgs","repos_url":"https://api.github.com/users/aschackmull/repos","events_url":"https://api.github.com/users/aschackmull/events{/privacy}","received_events_url":"https://api.github.com/users/aschackmull/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aschackmull/ql","description":null,"fork":true,"url":"https://api.github.com/repos/aschackmull/ql","forks_url":"https://api.github.com/repos/aschackmull/ql/forks","keys_url":"https://api.github.com/repos/aschackmull/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschackmull/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschackmull/ql/teams","hooks_url":"https://api.github.com/repos/aschackmull/ql/hooks","issue_events_url":"https://api.github.com/repos/aschackmull/ql/issues/events{/number}","events_url":"https://api.github.com/repos/aschackmull/ql/events","assignees_url":"https://api.github.com/repos/aschackmull/ql/assignees{/user}","branches_url":"https://api.github.com/repos/aschackmull/ql/branches{/branch}","tags_url":"https://api.github.com/repos/aschackmull/ql/tags","blobs_url":"https://api.github.com/repos/aschackmull/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschackmull/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschackmull/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschackmull/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschackmull/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/aschackmull/ql/languages","stargazers_url":"https://api.github.com/repos/aschackmull/ql/stargazers","contributors_url":"https://api.github.com/repos/aschackmull/ql/contributors","subscribers_url":"https://api.github.com/repos/aschackmull/ql/subscribers","subscription_url":"https://api.github.com/repos/aschackmull/ql/subscription","commits_url":"https://api.github.com/repos/aschackmull/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschackmull/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschackmull/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschackmull/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschackmull/ql/contents/{+path}","compare_url":"https://api.github.com/repos/aschackmull/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschackmull/ql/merges","archive_url":"https://api.github.com/repos/aschackmull/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschackmull/ql/downloads","issues_url":"https://api.github.com/repos/aschackmull/ql/issues{/number}","pulls_url":"https://api.github.com/repos/aschackmull/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/aschackmull/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/aschackmull/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschackmull/ql/labels{/name}","releases_url":"https://api.github.com/repos/aschackmull/ql/releases{/id}","deployments_url":"https://api.github.com/repos/aschackmull/ql/deployments","created_at":"2018-08-03T12:07:28Z","updated_at":"2018-08-29T07:35:23Z","pushed_at":"2018-10-10T14:44:44Z","git_url":"git://github.com/aschackmull/ql.git","ssh_url":"git@github.com:aschackmull/ql.git","clone_url":"https://github.com/aschackmull/ql.git","svn_url":"https://github.com/aschackmull/ql","homepage":null,"size":8110,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Semmle:master","ref":"master","sha":"3e022ad36fd6e3c185375539ccbb2c4ee957c93c","user":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"repo":{"id":143040428,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDA0Mjg=","name":"ql","full_name":"Semmle/ql","private":false,"owner":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semmle/ql","description":"The standard QL libraries and queries that power LGTM.com and other Semmle Products","fork":false,"url":"https://api.github.com/repos/Semmle/ql","forks_url":"https://api.github.com/repos/Semmle/ql/forks","keys_url":"https://api.github.com/repos/Semmle/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semmle/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semmle/ql/teams","hooks_url":"https://api.github.com/repos/Semmle/ql/hooks","issue_events_url":"https://api.github.com/repos/Semmle/ql/issues/events{/number}","events_url":"https://api.github.com/repos/Semmle/ql/events","assignees_url":"https://api.github.com/repos/Semmle/ql/assignees{/user}","branches_url":"https://api.github.com/repos/Semmle/ql/branches{/branch}","tags_url":"https://api.github.com/repos/Semmle/ql/tags","blobs_url":"https://api.github.com/repos/Semmle/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semmle/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semmle/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semmle/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/Semmle/ql/languages","stargazers_url":"https://api.github.com/repos/Semmle/ql/stargazers","contributors_url":"https://api.github.com/repos/Semmle/ql/contributors","subscribers_url":"https://api.github.com/repos/Semmle/ql/subscribers","subscription_url":"https://api.github.com/repos/Semmle/ql/subscription","commits_url":"https://api.github.com/repos/Semmle/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semmle/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semmle/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semmle/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semmle/ql/contents/{+path}","compare_url":"https://api.github.com/repos/Semmle/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semmle/ql/merges","archive_url":"https://api.github.com/repos/Semmle/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semmle/ql/downloads","issues_url":"https://api.github.com/repos/Semmle/ql/issues{/number}","pulls_url":"https://api.github.com/repos/Semmle/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/Semmle/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/Semmle/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semmle/ql/labels{/name}","releases_url":"https://api.github.com/repos/Semmle/ql/releases{/id}","deployments_url":"https://api.github.com/repos/Semmle/ql/deployments","created_at":"2018-07-31T16:35:51Z","updated_at":"2018-10-10T12:59:47Z","pushed_at":"2018-10-10T15:10:17Z","git_url":"git://github.com/Semmle/ql.git","ssh_url":"git@github.com:Semmle/ql.git","clone_url":"https://github.com/Semmle/ql.git","svn_url":"https://github.com/Semmle/ql","homepage":"https://semmle.com/ql","size":8207,"stargazers_count":41,"watchers_count":41,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":37,"open_issues":28,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Semmle/ql/pulls/148"},"html":{"href":"https://github.com/Semmle/ql/pull/148"},"issue":{"href":"https://api.github.com/repos/Semmle/ql/issues/148"},"comments":{"href":"https://api.github.com/repos/Semmle/ql/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/Semmle/ql/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Semmle/ql/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/Semmle/ql/statuses/99846474eb9e2a56829c0f07a66877bb0e5982a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aschackmull"}}