{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/228364964","pull_request_review_id":168623132,"id":228364964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODM2NDk2NA==","diff_hunk":"@@ -2672,18 +2675,22 @@ def footprint_to_file(self, filename='footprint.reg', color='green',\n \n     @property\n     def _naxis1(self):\n+        warnings.warn(naxis_deprecated_message, AstropyDeprecationWarning)","path":"astropy/wcs/wcs.py","position":25,"original_position":25,"commit_id":"6e8d64f1d390f0c70cff0ce66d02ed0242aae0c4","original_commit_id":"6e8d64f1d390f0c70cff0ce66d02ed0242aae0c4","user":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"body":"do we really need to deprecate this? I mean this was supposed to be private rather than in the public API, so no one should have used it","created_at":"2018-10-25T23:14:43Z","updated_at":"2018-10-25T23:14:43Z","html_url":"https://github.com/astropy/astropy/pull/7973#discussion_r228364964","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/7973","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/228364964"},"html":{"href":"https://github.com/astropy/astropy/pull/7973#discussion_r228364964"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7973"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/7973","id":225924976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTI0OTc2","html_url":"https://github.com/astropy/astropy/pull/7973","diff_url":"https://github.com/astropy/astropy/pull/7973.diff","patch_url":"https://github.com/astropy/astropy/pull/7973.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/7973","number":7973,"state":"open","locked":false,"title":"deprecate _naxis1/2","user":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"Note: This depends on #7962 and astrofrog/astropy#75.\r\n\r\nThis deprecates `Wcs._naxis1` and `Wcs._naxis2` in favor of `WCS.pixel_shape`.\r\nResolves #5461 and #4669 where there's a description of the problem. ","created_at":"2018-10-25T22:33:11Z","updated_at":"2018-10-25T23:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e7d47dccb64a08878a02729a1ae66a3933c5385","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":188323,"node_id":"MDU6TGFiZWwxODgzMjM=","url":"https://api.github.com/repos/astropy/astropy/labels/wcs","name":"wcs","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/52","html_url":"https://github.com/astropy/astropy/milestone/52","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/52/labels","id":2929745,"node_id":"MDk6TWlsZXN0b25lMjkyOTc0NQ==","number":52,"title":"v3.1","description":"","creator":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":167,"state":"open","created_at":"2017-11-21T23:24:18Z","updated_at":"2018-10-25T22:41:06Z","due_on":"2018-10-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/7973/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/7973/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/7973/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/6e8d64f1d390f0c70cff0ce66d02ed0242aae0c4","head":{"label":"nden:wcs-deprecate-naxis","ref":"wcs-deprecate-naxis","sha":"6e8d64f1d390f0c70cff0ce66d02ed0242aae0c4","user":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"repo":{"id":6738136,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM4MTM2","name":"astropy","full_name":"nden/astropy","private":false,"owner":{"login":"nden","id":1110361,"node_id":"MDQ6VXNlcjExMTAzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nden/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/nden/astropy","forks_url":"https://api.github.com/repos/nden/astropy/forks","keys_url":"https://api.github.com/repos/nden/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nden/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nden/astropy/teams","hooks_url":"https://api.github.com/repos/nden/astropy/hooks","issue_events_url":"https://api.github.com/repos/nden/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/nden/astropy/events","assignees_url":"https://api.github.com/repos/nden/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/nden/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/nden/astropy/tags","blobs_url":"https://api.github.com/repos/nden/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nden/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nden/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nden/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nden/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/nden/astropy/languages","stargazers_url":"https://api.github.com/repos/nden/astropy/stargazers","contributors_url":"https://api.github.com/repos/nden/astropy/contributors","subscribers_url":"https://api.github.com/repos/nden/astropy/subscribers","subscription_url":"https://api.github.com/repos/nden/astropy/subscription","commits_url":"https://api.github.com/repos/nden/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nden/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nden/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nden/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nden/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/nden/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nden/astropy/merges","archive_url":"https://api.github.com/repos/nden/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nden/astropy/downloads","issues_url":"https://api.github.com/repos/nden/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/nden/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/nden/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/nden/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nden/astropy/labels{/name}","releases_url":"https://api.github.com/repos/nden/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/nden/astropy/deployments","created_at":"2012-11-17T18:06:04Z","updated_at":"2015-04-21T09:44:25Z","pushed_at":"2018-10-25T23:05:53Z","git_url":"git://github.com/nden/astropy.git","ssh_url":"git@github.com:nden/astropy.git","clone_url":"https://github.com/nden/astropy.git","svn_url":"https://github.com/nden/astropy","homepage":"astropy.org","size":66003,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"2534a2dd747da3d50644812ce4faab6d909e7f36","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxMjg5","name":"astropy","full_name":"astropy/astropy","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2018-10-25T20:59:10Z","pushed_at":"2018-10-25T23:05:55Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":74636,"stargazers_count":1901,"watchers_count":1901,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":975,"mirror_url":null,"archived":false,"open_issues_count":935,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":975,"open_issues":935,"watchers":1901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7973"},"html":{"href":"https://github.com/astropy/astropy/pull/7973"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/7973"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/7973/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7973/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7973/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/6e8d64f1d390f0c70cff0ce66d02ed0242aae0c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bsipocz"}}