{"action":"closed","number":990,"pull_request":{"url":"https://api.github.com/repos/pentaho/data-access/pulls/990","id":174379747,"html_url":"https://github.com/pentaho/data-access/pull/990","diff_url":"https://github.com/pentaho/data-access/pull/990.diff","patch_url":"https://github.com/pentaho/data-access/pull/990.patch","issue_url":"https://api.github.com/repos/pentaho/data-access/issues/990","number":990,"state":"closed","locked":false,"title":"[PPP-4022] Japanese character in the data source name causes data inconsistency and an errors to occur","user":{"login":"Advent51","id":5530292,"avatar_url":"https://avatars1.githubusercontent.com/u/5530292?v=4","gravatar_id":"","url":"https://api.github.com/users/Advent51","html_url":"https://github.com/Advent51","followers_url":"https://api.github.com/users/Advent51/followers","following_url":"https://api.github.com/users/Advent51/following{/other_user}","gists_url":"https://api.github.com/users/Advent51/gists{/gist_id}","starred_url":"https://api.github.com/users/Advent51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Advent51/subscriptions","organizations_url":"https://api.github.com/users/Advent51/orgs","repos_url":"https://api.github.com/users/Advent51/repos","events_url":"https://api.github.com/users/Advent51/events{/privacy}","received_events_url":"https://api.github.com/users/Advent51/received_events","type":"User","site_admin":false},"body":"- RegExp was modified in order to accept all alphanumeric unicode characters. Since GWT's RegExp is not supporting unicode flag on Java side (and pattern with unicode character class) the modified method is not working on the Java side, but works as expected on the JS side. That's why generateTableName() was mocked in tests and testGenerateTablename() method was removed.\r\n- checkstyle fixes","created_at":"2018-03-12T14:12:06Z","updated_at":"2018-03-26T10:02:19Z","closed_at":"2018-03-26T10:02:19Z","merged_at":"2018-03-26T10:02:19Z","merge_commit_sha":"912fd01b41adfb96bf78ac3eab89aa1732af7e53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/data-access/pulls/990/commits","review_comments_url":"https://api.github.com/repos/pentaho/data-access/pulls/990/comments","review_comment_url":"https://api.github.com/repos/pentaho/data-access/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/data-access/issues/990/comments","statuses_url":"https://api.github.com/repos/pentaho/data-access/statuses/7d75265fc47f4bffb93992f1a2430c636f0d1781","head":{"label":"Advent51:PPP-4022","ref":"PPP-4022","sha":"7d75265fc47f4bffb93992f1a2430c636f0d1781","user":{"login":"Advent51","id":5530292,"avatar_url":"https://avatars1.githubusercontent.com/u/5530292?v=4","gravatar_id":"","url":"https://api.github.com/users/Advent51","html_url":"https://github.com/Advent51","followers_url":"https://api.github.com/users/Advent51/followers","following_url":"https://api.github.com/users/Advent51/following{/other_user}","gists_url":"https://api.github.com/users/Advent51/gists{/gist_id}","starred_url":"https://api.github.com/users/Advent51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Advent51/subscriptions","organizations_url":"https://api.github.com/users/Advent51/orgs","repos_url":"https://api.github.com/users/Advent51/repos","events_url":"https://api.github.com/users/Advent51/events{/privacy}","received_events_url":"https://api.github.com/users/Advent51/received_events","type":"User","site_admin":false},"repo":{"id":69323731,"name":"data-access","full_name":"Advent51/data-access","owner":{"login":"Advent51","id":5530292,"avatar_url":"https://avatars1.githubusercontent.com/u/5530292?v=4","gravatar_id":"","url":"https://api.github.com/users/Advent51","html_url":"https://github.com/Advent51","followers_url":"https://api.github.com/users/Advent51/followers","following_url":"https://api.github.com/users/Advent51/following{/other_user}","gists_url":"https://api.github.com/users/Advent51/gists{/gist_id}","starred_url":"https://api.github.com/users/Advent51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Advent51/subscriptions","organizations_url":"https://api.github.com/users/Advent51/orgs","repos_url":"https://api.github.com/users/Advent51/repos","events_url":"https://api.github.com/users/Advent51/events{/privacy}","received_events_url":"https://api.github.com/users/Advent51/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Advent51/data-access","description":"Pentaho Data Access Wizard","fork":true,"url":"https://api.github.com/repos/Advent51/data-access","forks_url":"https://api.github.com/repos/Advent51/data-access/forks","keys_url":"https://api.github.com/repos/Advent51/data-access/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Advent51/data-access/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Advent51/data-access/teams","hooks_url":"https://api.github.com/repos/Advent51/data-access/hooks","issue_events_url":"https://api.github.com/repos/Advent51/data-access/issues/events{/number}","events_url":"https://api.github.com/repos/Advent51/data-access/events","assignees_url":"https://api.github.com/repos/Advent51/data-access/assignees{/user}","branches_url":"https://api.github.com/repos/Advent51/data-access/branches{/branch}","tags_url":"https://api.github.com/repos/Advent51/data-access/tags","blobs_url":"https://api.github.com/repos/Advent51/data-access/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Advent51/data-access/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Advent51/data-access/git/refs{/sha}","trees_url":"https://api.github.com/repos/Advent51/data-access/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Advent51/data-access/statuses/{sha}","languages_url":"https://api.github.com/repos/Advent51/data-access/languages","stargazers_url":"https://api.github.com/repos/Advent51/data-access/stargazers","contributors_url":"https://api.github.com/repos/Advent51/data-access/contributors","subscribers_url":"https://api.github.com/repos/Advent51/data-access/subscribers","subscription_url":"https://api.github.com/repos/Advent51/data-access/subscription","commits_url":"https://api.github.com/repos/Advent51/data-access/commits{/sha}","git_commits_url":"https://api.github.com/repos/Advent51/data-access/git/commits{/sha}","comments_url":"https://api.github.com/repos/Advent51/data-access/comments{/number}","issue_comment_url":"https://api.github.com/repos/Advent51/data-access/issues/comments{/number}","contents_url":"https://api.github.com/repos/Advent51/data-access/contents/{+path}","compare_url":"https://api.github.com/repos/Advent51/data-access/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Advent51/data-access/merges","archive_url":"https://api.github.com/repos/Advent51/data-access/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Advent51/data-access/downloads","issues_url":"https://api.github.com/repos/Advent51/data-access/issues{/number}","pulls_url":"https://api.github.com/repos/Advent51/data-access/pulls{/number}","milestones_url":"https://api.github.com/repos/Advent51/data-access/milestones{/number}","notifications_url":"https://api.github.com/repos/Advent51/data-access/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Advent51/data-access/labels{/name}","releases_url":"https://api.github.com/repos/Advent51/data-access/releases{/id}","deployments_url":"https://api.github.com/repos/Advent51/data-access/deployments","created_at":"2016-09-27T05:48:33Z","updated_at":"2016-09-27T05:48:36Z","pushed_at":"2018-03-26T07:01:40Z","git_url":"git://github.com/Advent51/data-access.git","ssh_url":"git@github.com:Advent51/data-access.git","clone_url":"https://github.com/Advent51/data-access.git","svn_url":"https://github.com/Advent51/data-access","homepage":"www.pentaho.com","size":6314,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"395c1a2d1c55da6fa16be7901b6f09e48ab6611a","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":2316191,"name":"data-access","full_name":"pentaho/data-access","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/data-access","description":"Pentaho Data Access Wizard","fork":false,"url":"https://api.github.com/repos/pentaho/data-access","forks_url":"https://api.github.com/repos/pentaho/data-access/forks","keys_url":"https://api.github.com/repos/pentaho/data-access/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/data-access/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/data-access/teams","hooks_url":"https://api.github.com/repos/pentaho/data-access/hooks","issue_events_url":"https://api.github.com/repos/pentaho/data-access/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/data-access/events","assignees_url":"https://api.github.com/repos/pentaho/data-access/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/data-access/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/data-access/tags","blobs_url":"https://api.github.com/repos/pentaho/data-access/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/data-access/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/data-access/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/data-access/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/data-access/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/data-access/languages","stargazers_url":"https://api.github.com/repos/pentaho/data-access/stargazers","contributors_url":"https://api.github.com/repos/pentaho/data-access/contributors","subscribers_url":"https://api.github.com/repos/pentaho/data-access/subscribers","subscription_url":"https://api.github.com/repos/pentaho/data-access/subscription","commits_url":"https://api.github.com/repos/pentaho/data-access/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/data-access/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/data-access/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/data-access/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/data-access/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/data-access/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/data-access/merges","archive_url":"https://api.github.com/repos/pentaho/data-access/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/data-access/downloads","issues_url":"https://api.github.com/repos/pentaho/data-access/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/data-access/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/data-access/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/data-access/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/data-access/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/data-access/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/data-access/deployments","created_at":"2011-09-02T20:11:11Z","updated_at":"2018-03-22T14:00:00Z","pushed_at":"2018-03-26T10:02:19Z","git_url":"git://github.com/pentaho/data-access.git","ssh_url":"git@github.com:pentaho/data-access.git","clone_url":"https://github.com/pentaho/data-access.git","svn_url":"https://github.com/pentaho/data-access","homepage":"www.pentaho.com","size":6832,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":114,"open_issues":11,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/990"},"html":{"href":"https://github.com/pentaho/data-access/pull/990"},"issue":{"href":"https://api.github.com/repos/pentaho/data-access/issues/990"},"comments":{"href":"https://api.github.com/repos/pentaho/data-access/issues/990/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/990/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/990/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/data-access/statuses/7d75265fc47f4bffb93992f1a2430c636f0d1781"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pamval","id":347476,"avatar_url":"https://avatars2.githubusercontent.com/u/347476?v=4","gravatar_id":"","url":"https://api.github.com/users/pamval","html_url":"https://github.com/pamval","followers_url":"https://api.github.com/users/pamval/followers","following_url":"https://api.github.com/users/pamval/following{/other_user}","gists_url":"https://api.github.com/users/pamval/gists{/gist_id}","starred_url":"https://api.github.com/users/pamval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamval/subscriptions","organizations_url":"https://api.github.com/users/pamval/orgs","repos_url":"https://api.github.com/users/pamval/repos","events_url":"https://api.github.com/users/pamval/events{/privacy}","received_events_url":"https://api.github.com/users/pamval/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":112,"deletions":115,"changed_files":3}}
{"actor":{"display_login":"pamval"}}