{"action":"opened","number":3640,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640","id":217425765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDI1NzY1","html_url":"https://github.com/jenkinsci/jenkins/pull/3640","diff_url":"https://github.com/jenkinsci/jenkins/pull/3640.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/3640.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3640","number":3640,"state":"open","locked":false,"title":"JDK-11 support: refactor code to avoid underscore variable names","user":{"login":"oleg-nenashev","id":3000480,"node_id":"MDQ6VXNlcjMwMDA0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3000480?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"Refactoring towards Java 11. Underscore variables are not welcome in Java anymore, and IMO it makes sense to just refactor them away.\r\n\r\n# Changelog\r\n\r\n* Not required\r\n\r\n@jenkinsci/sig-platform ","created_at":"2018-09-21T23:52:03Z","updated_at":"2018-09-21T23:52:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3640/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/a3cc7780aa2d6d36bdbabf663bd4b26f1172ecf3","head":{"label":"oleg-nenashev:build/jdk11-underscore-vars","ref":"build/jdk11-underscore-vars","sha":"a3cc7780aa2d6d36bdbabf663bd4b26f1172ecf3","user":{"login":"oleg-nenashev","id":3000480,"node_id":"MDQ6VXNlcjMwMDA0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3000480?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"repo":{"id":14375421,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NTQyMQ==","name":"jenkins","full_name":"oleg-nenashev/jenkins","private":false,"owner":{"login":"oleg-nenashev","id":3000480,"node_id":"MDQ6VXNlcjMwMDA0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3000480?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oleg-nenashev/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/oleg-nenashev/jenkins","forks_url":"https://api.github.com/repos/oleg-nenashev/jenkins/forks","keys_url":"https://api.github.com/repos/oleg-nenashev/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oleg-nenashev/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oleg-nenashev/jenkins/teams","hooks_url":"https://api.github.com/repos/oleg-nenashev/jenkins/hooks","issue_events_url":"https://api.github.com/repos/oleg-nenashev/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/oleg-nenashev/jenkins/events","assignees_url":"https://api.github.com/repos/oleg-nenashev/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/oleg-nenashev/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/oleg-nenashev/jenkins/tags","blobs_url":"https://api.github.com/repos/oleg-nenashev/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oleg-nenashev/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oleg-nenashev/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/oleg-nenashev/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oleg-nenashev/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/oleg-nenashev/jenkins/languages","stargazers_url":"https://api.github.com/repos/oleg-nenashev/jenkins/stargazers","contributors_url":"https://api.github.com/repos/oleg-nenashev/jenkins/contributors","subscribers_url":"https://api.github.com/repos/oleg-nenashev/jenkins/subscribers","subscription_url":"https://api.github.com/repos/oleg-nenashev/jenkins/subscription","commits_url":"https://api.github.com/repos/oleg-nenashev/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/oleg-nenashev/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/oleg-nenashev/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/oleg-nenashev/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/oleg-nenashev/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/oleg-nenashev/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oleg-nenashev/jenkins/merges","archive_url":"https://api.github.com/repos/oleg-nenashev/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oleg-nenashev/jenkins/downloads","issues_url":"https://api.github.com/repos/oleg-nenashev/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/oleg-nenashev/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/oleg-nenashev/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/oleg-nenashev/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oleg-nenashev/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/oleg-nenashev/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/oleg-nenashev/jenkins/deployments","created_at":"2013-11-13T20:24:23Z","updated_at":"2018-07-09T07:42:12Z","pushed_at":"2018-09-21T23:48:31Z","git_url":"git://github.com/oleg-nenashev/jenkins.git","ssh_url":"git@github.com:oleg-nenashev/jenkins.git","clone_url":"https://github.com/oleg-nenashev/jenkins.git","svn_url":"https://github.com/oleg-nenashev/jenkins","homepage":"http://jenkins-ci.org/","size":114448,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"eb1a1f757a4a03678bf3b7968eba0cb1c7f364df","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNjA3","name":"jenkins","full_name":"jenkinsci/jenkins","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":false,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2018-09-21T23:07:04Z","pushed_at":"2018-09-21T23:21:26Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":108888,"stargazers_count":11190,"watchers_count":11190,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4806,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4806,"open_issues":112,"watchers":11190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3640"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3640"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3640/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3640/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/a3cc7780aa2d6d36bdbabf663bd4b26f1172ecf3"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":42,"deletions":42,"changed_files":21}}
{"actor":{"display_login":"oleg-nenashev"}}