{"action":"closed","number":123,"pull_request":{"url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123","id":232350689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzUwNjg5","html_url":"https://github.com/hmrc/mobile-help-to-save/pull/123","diff_url":"https://github.com/hmrc/mobile-help-to-save/pull/123.diff","patch_url":"https://github.com/hmrc/mobile-help-to-save/pull/123.patch","issue_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/123","number":123,"state":"closed","locked":false,"title":"[NGC-4195][NGC-4196] 'Set Target' endpoint now checks if there's an account","user":{"login":"DougC","id":98534,"node_id":"MDQ6VXNlcjk4NTM0","avatar_url":"https://avatars1.githubusercontent.com/u/98534?v=4","gravatar_id":"","url":"https://api.github.com/users/DougC","html_url":"https://github.com/DougC","followers_url":"https://api.github.com/users/DougC/followers","following_url":"https://api.github.com/users/DougC/following{/other_user}","gists_url":"https://api.github.com/users/DougC/gists{/gist_id}","starred_url":"https://api.github.com/users/DougC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougC/subscriptions","organizations_url":"https://api.github.com/users/DougC/orgs","repos_url":"https://api.github.com/users/DougC/repos","events_url":"https://api.github.com/users/DougC/events{/privacy}","received_events_url":"https://api.github.com/users/DougC/received_events","type":"User","site_admin":false},"body":"The `setSavingsTarget` controller action now does a lookup to check that an account exists at NS&I for the NINO and will respond with 404 if not (NGC-4159). \r\n\r\nThe controller will now also use the value of the `maximumPaidInThisMonth` from the NS&I account to validate the upper bound on the savings target (NGC-4196) so we no longer need to have configuration in this service for the maximum savings, and if it ever changes either globally or for individual accounts then we won't need to change this service to accommodate that.","created_at":"2018-11-20T15:07:11Z","updated_at":"2018-11-20T15:14:37Z","closed_at":"2018-11-20T15:14:37Z","merged_at":"2018-11-20T15:14:37Z","merge_commit_sha":"e75d3f01e745f6340225e84dd2096f2af3586857","assignee":{"login":"DougC","id":98534,"node_id":"MDQ6VXNlcjk4NTM0","avatar_url":"https://avatars1.githubusercontent.com/u/98534?v=4","gravatar_id":"","url":"https://api.github.com/users/DougC","html_url":"https://github.com/DougC","followers_url":"https://api.github.com/users/DougC/followers","following_url":"https://api.github.com/users/DougC/following{/other_user}","gists_url":"https://api.github.com/users/DougC/gists{/gist_id}","starred_url":"https://api.github.com/users/DougC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougC/subscriptions","organizations_url":"https://api.github.com/users/DougC/orgs","repos_url":"https://api.github.com/users/DougC/repos","events_url":"https://api.github.com/users/DougC/events{/privacy}","received_events_url":"https://api.github.com/users/DougC/received_events","type":"User","site_admin":false},"assignees":[{"login":"DougC","id":98534,"node_id":"MDQ6VXNlcjk4NTM0","avatar_url":"https://avatars1.githubusercontent.com/u/98534?v=4","gravatar_id":"","url":"https://api.github.com/users/DougC","html_url":"https://github.com/DougC","followers_url":"https://api.github.com/users/DougC/followers","following_url":"https://api.github.com/users/DougC/following{/other_user}","gists_url":"https://api.github.com/users/DougC/gists{/gist_id}","starred_url":"https://api.github.com/users/DougC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougC/subscriptions","organizations_url":"https://api.github.com/users/DougC/orgs","repos_url":"https://api.github.com/users/DougC/repos","events_url":"https://api.github.com/users/DougC/events{/privacy}","received_events_url":"https://api.github.com/users/DougC/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123/commits","review_comments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123/comments","review_comment_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/123/comments","statuses_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/statuses/229f0cb4273365c78f7818277289430f59c481bf","head":{"label":"hmrc:NGC-4195-check-for-account-on-set","ref":"NGC-4195-check-for-account-on-set","sha":"229f0cb4273365c78f7818277289430f59c481bf","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":114645633,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2NDU2MzM=","name":"mobile-help-to-save","full_name":"hmrc/mobile-help-to-save","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/mobile-help-to-save","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/mobile-help-to-save","forks_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/forks","keys_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/teams","hooks_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/hooks","issue_events_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/events","assignees_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/tags","blobs_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/languages","stargazers_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/stargazers","contributors_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/contributors","subscribers_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/subscribers","subscription_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/subscription","commits_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/merges","archive_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/downloads","issues_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/deployments","created_at":"2017-12-18T13:41:44Z","updated_at":"2018-11-20T11:38:37Z","pushed_at":"2018-11-20T15:14:37Z","git_url":"git://github.com/hmrc/mobile-help-to-save.git","ssh_url":"git@github.com:hmrc/mobile-help-to-save.git","clone_url":"https://github.com/hmrc/mobile-help-to-save.git","svn_url":"https://github.com/hmrc/mobile-help-to-save","homepage":"","size":632,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"e364ce3b876e2220e117b9d11325670cb92acc1f","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":114645633,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2NDU2MzM=","name":"mobile-help-to-save","full_name":"hmrc/mobile-help-to-save","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/mobile-help-to-save","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/mobile-help-to-save","forks_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/forks","keys_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/teams","hooks_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/hooks","issue_events_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/events","assignees_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/tags","blobs_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/languages","stargazers_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/stargazers","contributors_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/contributors","subscribers_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/subscribers","subscription_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/subscription","commits_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/merges","archive_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/downloads","issues_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/mobile-help-to-save/deployments","created_at":"2017-12-18T13:41:44Z","updated_at":"2018-11-20T11:38:37Z","pushed_at":"2018-11-20T15:14:37Z","git_url":"git://github.com/hmrc/mobile-help-to-save.git","ssh_url":"git@github.com:hmrc/mobile-help-to-save.git","clone_url":"https://github.com/hmrc/mobile-help-to-save.git","svn_url":"https://github.com/hmrc/mobile-help-to-save","homepage":"","size":632,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123"},"html":{"href":"https://github.com/hmrc/mobile-help-to-save/pull/123"},"issue":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/123"},"comments":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/mobile-help-to-save/statuses/229f0cb4273365c78f7818277289430f59c481bf"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"howzat","id":920913,"node_id":"MDQ6VXNlcjkyMDkxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/920913?v=4","gravatar_id":"","url":"https://api.github.com/users/howzat","html_url":"https://github.com/howzat","followers_url":"https://api.github.com/users/howzat/followers","following_url":"https://api.github.com/users/howzat/following{/other_user}","gists_url":"https://api.github.com/users/howzat/gists{/gist_id}","starred_url":"https://api.github.com/users/howzat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howzat/subscriptions","organizations_url":"https://api.github.com/users/howzat/orgs","repos_url":"https://api.github.com/users/howzat/repos","events_url":"https://api.github.com/users/howzat/events{/privacy}","received_events_url":"https://api.github.com/users/howzat/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":57,"deletions":28,"changed_files":6}}
{"actor":{"display_login":"howzat"}}