{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/243329245","pull_request_review_id":187070606,"id":243329245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzMyOTI0NQ==","diff_hunk":"@@ -1420,9 +1420,17 @@ void moveEmplace(T)(ref T source, ref T target) @system\n     }\n     else\n     {\n-        // Primitive data (including pointers and arrays) or class -\n-        // assignment works great\n-        target = source;\n+        static if (isStaticArray!T)\n+        {\n+            for (size_t i = 0; i < source.length; ++i)\n+                move(source[i], target[i]);\n+        }\n+        else\n+        {\n+            // Primitive data (including pointers and arrays) or class -\n+            // assignment works great\n+            target = source;\n+        }","path":"std/algorithm/mutation.d","position":null,"original_position":26,"commit_id":"a3fdf76c092e7c4852986316598ec882ab0d46c1","original_commit_id":"5df2b9b4234704922b9137c5f88785bb2a2ddfb7","user":{"login":"ZombineDev","id":3475150,"node_id":"MDQ6VXNlcjM0NzUxNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3475150?v=4","gravatar_id":"","url":"https://api.github.com/users/ZombineDev","html_url":"https://github.com/ZombineDev","followers_url":"https://api.github.com/users/ZombineDev/followers","following_url":"https://api.github.com/users/ZombineDev/following{/other_user}","gists_url":"https://api.github.com/users/ZombineDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ZombineDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZombineDev/subscriptions","organizations_url":"https://api.github.com/users/ZombineDev/orgs","repos_url":"https://api.github.com/users/ZombineDev/repos","events_url":"https://api.github.com/users/ZombineDev/events{/privacy}","received_events_url":"https://api.github.com/users/ZombineDev/received_events","type":"User","site_admin":false},"body":"Yes, unfortunately the `isInputRange` constraint is too strict for `move[Emplace]{All|Some}` functions, as a range, whose elements are not copy-able is the primary use-case for `move`-ing.\r\n\r\nIf we adjust `isInputRange` like so \r\n```diff\r\n@@ -168,7 +168,10 @@\r\n enum bool isInputRange(R) =\r\n     is(typeof(R.init) == R)\r\n     && is(ReturnType!((R r) => r.empty) == bool)\r\n-    && is(typeof((return ref R r) => r.front))\r\n+    && (\r\n+            is(typeof((return ref R r) => r.front)) ||\r\n+            is(typeof((return ref R r) => &r.front()))\r\n+       )\r\n     && !is(ReturnType!((R r) => r.front) == void)\r\n     && is(typeof((R r) => r.popFront));\r\n```\r\n\r\nall tests pass.","created_at":"2018-12-20T16:12:56Z","updated_at":"2018-12-20T16:12:56Z","html_url":"https://github.com/dlang/phobos/pull/6810#discussion_r243329245","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/6810","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/243329245"},"html":{"href":"https://github.com/dlang/phobos/pull/6810#discussion_r243329245"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6810"}},"in_reply_to_id":242819202},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/6810","id":239500356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTAwMzU2","html_url":"https://github.com/dlang/phobos/pull/6810","diff_url":"https://github.com/dlang/phobos/pull/6810.diff","patch_url":"https://github.com/dlang/phobos/pull/6810.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/6810","number":6810,"state":"open","locked":false,"title":"Fix Issue 18913 - Cannot move static array of non-copyable type","user":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-18T14:03:52Z","updated_at":"2018-12-20T16:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"095559b4db2637dfe0c45d8271463f850a1c6f79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andralex","id":566679,"node_id":"MDQ6VXNlcjU2NjY3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/566679?v=4","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},{"login":"JackStouffer","id":680068,"node_id":"MDQ6VXNlcjY4MDA2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/680068?v=4","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false},{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":416188102,"node_id":"MDU6TGFiZWw0MTYxODgxMDI=","url":"https://api.github.com/repos/dlang/phobos/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/6810/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/6810/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/6810/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/a3fdf76c092e7c4852986316598ec882ab0d46c1","head":{"label":"edi33416:issue_18913","ref":"issue_18913","sha":"a3fdf76c092e7c4852986316598ec882ab0d46c1","user":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"repo":{"id":73472663,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQ3MjY2Mw==","name":"phobos","full_name":"edi33416/phobos","private":false,"owner":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edi33416/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/edi33416/phobos","forks_url":"https://api.github.com/repos/edi33416/phobos/forks","keys_url":"https://api.github.com/repos/edi33416/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edi33416/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edi33416/phobos/teams","hooks_url":"https://api.github.com/repos/edi33416/phobos/hooks","issue_events_url":"https://api.github.com/repos/edi33416/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/edi33416/phobos/events","assignees_url":"https://api.github.com/repos/edi33416/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/edi33416/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/edi33416/phobos/tags","blobs_url":"https://api.github.com/repos/edi33416/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edi33416/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edi33416/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/edi33416/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edi33416/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/edi33416/phobos/languages","stargazers_url":"https://api.github.com/repos/edi33416/phobos/stargazers","contributors_url":"https://api.github.com/repos/edi33416/phobos/contributors","subscribers_url":"https://api.github.com/repos/edi33416/phobos/subscribers","subscription_url":"https://api.github.com/repos/edi33416/phobos/subscription","commits_url":"https://api.github.com/repos/edi33416/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/edi33416/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/edi33416/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/edi33416/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/edi33416/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/edi33416/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edi33416/phobos/merges","archive_url":"https://api.github.com/repos/edi33416/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edi33416/phobos/downloads","issues_url":"https://api.github.com/repos/edi33416/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/edi33416/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/edi33416/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/edi33416/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edi33416/phobos/labels{/name}","releases_url":"https://api.github.com/repos/edi33416/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/edi33416/phobos/deployments","created_at":"2016-11-11T11:34:18Z","updated_at":"2018-11-05T21:09:45Z","pushed_at":"2018-12-20T14:41:11Z","git_url":"git://github.com/edi33416/phobos.git","ssh_url":"git@github.com:edi33416/phobos.git","clone_url":"https://github.com/edi33416/phobos.git","svn_url":"https://github.com/edi33416/phobos","homepage":"dlang.org/phobos","size":51597,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"f38edb0a1f6329e1fcc5d61310a3c23fee00c6a2","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDg0","name":"phobos","full_name":"dlang/phobos","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2018-12-19T04:25:09Z","pushed_at":"2018-12-20T14:41:14Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":51590,"stargazers_count":898,"watchers_count":898,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":625,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":625,"open_issues":115,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6810"},"html":{"href":"https://github.com/dlang/phobos/pull/6810"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/6810"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/6810/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6810/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6810/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/a3fdf76c092e7c4852986316598ec882ab0d46c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ZombineDev"}}