{"action":"created","issue":{"url":"https://api.github.com/repos/FezVrasta/popper.js/issues/508","repository_url":"https://api.github.com/repos/FezVrasta/popper.js","labels_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/508/labels{/name}","comments_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/508/comments","events_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/508/events","html_url":"https://github.com/FezVrasta/popper.js/issues/508","id":280521708,"node_id":"MDU6SXNzdWUyODA1MjE3MDg=","number":508,"title":"make Popper#update sync + make scheduleUpdate return promise","user":{"login":"atomiks","id":22450188,"node_id":"MDQ6VXNlcjIyNDUwMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/22450188?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiks","html_url":"https://github.com/atomiks","followers_url":"https://api.github.com/users/atomiks/followers","following_url":"https://api.github.com/users/atomiks/following{/other_user}","gists_url":"https://api.github.com/users/atomiks/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiks/subscriptions","organizations_url":"https://api.github.com/users/atomiks/orgs","repos_url":"https://api.github.com/users/atomiks/repos","events_url":"https://api.github.com/users/atomiks/events{/privacy}","received_events_url":"https://api.github.com/users/atomiks/received_events","type":"User","site_admin":false},"labels":[{"id":741988513,"node_id":"MDU6TGFiZWw3NDE5ODg1MTM=","url":"https://api.github.com/repos/FezVrasta/popper.js/labels/%23%20BREAKING%20CHANGE","name":"# BREAKING CHANGE","color":"e58537","default":false},{"id":577909395,"node_id":"MDU6TGFiZWw1Nzc5MDkzOTU=","url":"https://api.github.com/repos/FezVrasta/popper.js/labels/DIFFICULTY:%20low","name":"DIFFICULTY: low","color":"4CAF50","default":false},{"id":420628435,"node_id":"MDU6TGFiZWw0MjA2Mjg0MzU=","url":"https://api.github.com/repos/FezVrasta/popper.js/labels/TARGETS:%20core","name":"TARGETS: core","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-12-08T15:19:22Z","updated_at":"2018-11-19T12:30:09Z","closed_at":"2018-11-19T12:30:09Z","author_association":"CONTRIBUTOR","body":"### CodePen Demo\r\n\r\nhttps://codepen.io/anon/pen/NwZQwK\r\n\r\n### What is the expected behavior?\r\n\r\nIn the CodePen, the popper should incorrectly be positioned if the update was sync. But because it's not, the last transform line is what Popper knows about, not the first one.\r\n\r\n### Any other comments?\r\n\r\nThe asynchronous `popper.update()` can cause some issues if the next line of code assumes the popper's position has been updated. The `onUpdate()` callback can't really be used depending on the code structure.\r\n\r\nI've been able to remedy this for a while with `setTimeout()` defer calls (not sure if this is 100% reliable though), but it would be easier just to have a sync update method.\r\n\r\nThat, or `update` is sync while `scheduleUpdate` is async.\r\n\r\nIs there a case where this wouldn't be appropriate?"},"comment":{"url":"https://api.github.com/repos/FezVrasta/popper.js/issues/comments/439877244","html_url":"https://github.com/FezVrasta/popper.js/issues/508#issuecomment-439877244","issue_url":"https://api.github.com/repos/FezVrasta/popper.js/issues/508","id":439877244,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTg3NzI0NA==","user":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T12:30:09Z","updated_at":"2018-11-19T12:30:09Z","author_association":"OWNER","body":"Closing because it has been implemented in the `next` branch, we now have `Popper#update` which runs asynchronously and returns a promise, and `Popper#forceUpdate` which runs synchronously."}}
{"actor":{"display_login":"FezVrasta"}}