{"action":"created","issue":{"url":"https://api.github.com/repos/openai/spinningup/issues/5","repository_url":"https://api.github.com/repos/openai/spinningup","labels_url":"https://api.github.com/repos/openai/spinningup/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/openai/spinningup/issues/5/comments","events_url":"https://api.github.com/repos/openai/spinningup/issues/5/events","html_url":"https://github.com/openai/spinningup/issues/5","id":378971669,"node_id":"MDU6SXNzdWUzNzg5NzE2Njk=","number":5,"title":"Minimizing over global variables instead of trainable variables","user":{"login":"unrealwill","id":11304248,"node_id":"MDQ6VXNlcjExMzA0MjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/11304248?v=4","gravatar_id":"","url":"https://api.github.com/users/unrealwill","html_url":"https://github.com/unrealwill","followers_url":"https://api.github.com/users/unrealwill/followers","following_url":"https://api.github.com/users/unrealwill/following{/other_user}","gists_url":"https://api.github.com/users/unrealwill/gists{/gist_id}","starred_url":"https://api.github.com/users/unrealwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unrealwill/subscriptions","organizations_url":"https://api.github.com/users/unrealwill/orgs","repos_url":"https://api.github.com/users/unrealwill/repos","events_url":"https://api.github.com/users/unrealwill/events{/privacy}","received_events_url":"https://api.github.com/users/unrealwill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-09T00:15:33Z","updated_at":"2018-11-10T10:16:36Z","closed_at":null,"author_association":"NONE","body":"In https://github.com/openai/spinningup/blob/master/spinup/algos/sac/sac.py \r\nL185\r\ntrain_pi_op = pi_optimizer.minimize(pi_loss, var_list=get_vars('main/pi'))\r\n\r\n```\r\ndef get_vars(scope):\r\nreturn [x for x in tf.global_variables() if scope in x.name]\r\n```\r\n\r\nyou minimize over the global variables, instead of trainable variables as it should (because the network is user defined)."},"comment":{"url":"https://api.github.com/repos/openai/spinningup/issues/comments/437573369","html_url":"https://github.com/openai/spinningup/issues/5#issuecomment-437573369","issue_url":"https://api.github.com/repos/openai/spinningup/issues/5","id":437573369,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzU3MzM2OQ==","user":{"login":"jachiam","id":11470845,"node_id":"MDQ6VXNlcjExNDcwODQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11470845?v=4","gravatar_id":"","url":"https://api.github.com/users/jachiam","html_url":"https://github.com/jachiam","followers_url":"https://api.github.com/users/jachiam/followers","following_url":"https://api.github.com/users/jachiam/following{/other_user}","gists_url":"https://api.github.com/users/jachiam/gists{/gist_id}","starred_url":"https://api.github.com/users/jachiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jachiam/subscriptions","organizations_url":"https://api.github.com/users/jachiam/orgs","repos_url":"https://api.github.com/users/jachiam/repos","events_url":"https://api.github.com/users/jachiam/events{/privacy}","received_events_url":"https://api.github.com/users/jachiam/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T10:16:36Z","updated_at":"2018-11-10T10:16:36Z","author_association":"COLLABORATOR","body":"This is a valid critique. I hope you don't mind, but this one will be a bit slower to fix; my preference is to only commit changes to the implementation code if I correspondingly update the entire set of published benchmarks, and that will take a bit of time to set up and publish (and a lot more time if I wind up having to do some kind of debugging)."}}
{"actor":{"display_login":"jachiam"}}