{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/4552","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/4552/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/4552/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/4552/events","html_url":"https://github.com/Homebrew/brew/pull/4552","id":344616119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTcwMzI5","number":4552,"title":"Reorder unpack strategies.","user":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"labels":[{"id":351931983,"node_id":"MDU6TGFiZWwzNTE5MzE5ODM=","url":"https://api.github.com/repos/Homebrew/brew/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"assignees":[{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-07-25T21:35:42Z","updated_at":"2018-07-29T13:05:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/4552","html_url":"https://github.com/Homebrew/brew/pull/4552","diff_url":"https://github.com/Homebrew/brew/pull/4552.diff","patch_url":"https://github.com/Homebrew/brew/pull/4552.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/PATH_spec.rb).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nAddresses https://github.com/Homebrew/brew/pull/4541#issuecomment-407681345."},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/408676596","html_url":"https://github.com/Homebrew/brew/pull/4552#issuecomment-408676596","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/4552","id":408676596,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY3NjU5Ng==","user":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T13:05:11Z","updated_at":"2018-07-29T13:05:11Z","author_association":"MEMBER","body":"The current implementation works for both cases, when the extension is right, and when it is wrong, so I don't see any benefit in changing it now to use extensions.\r\n\r\n> it optimises for the corner case and introduces additional complexity\r\n\r\nThis is less complex than handling extensions first, and only then falling back to this approach.\r\n\r\n> therefore likely runtime cost\r\n\r\nI think this is negligible in comparison to the actual extraction time. And with the latest reordering it will shell out three times at most, if at all."}}
{"actor":{"display_login":"reitermarkus"}}