{"action":"created","comment":{"url":"https://api.github.com/repos/ovh/cds/pulls/comments/171559365","pull_request_review_id":100431555,"id":171559365,"diff_hunk":"@@ -199,7 +200,7 @@ func (api *API) postWorkflowJobArtifactWithTempURLCallbackHandler() Handler {\n \t\t\treturn sdk.WrapError(sdk.ErrNotFound, \"postWorkflowJobArtifactWithTempURLCallbackHandler> Unable to find artifact, key:%s\", cacheKey)\n \t\t}\n \n-\t\tif art != cachedArt {\n+\t\tif !cmp.Equal(art, cachedArt) {","path":"engine/api/workflow_queue_artifact.go","position":13,"original_position":13,"commit_id":"0eff129fe1ad43c891e1b0e3761fbe9cf438c03c","original_commit_id":"0eff129fe1ad43c891e1b0e3761fbe9cf438c03c","user":{"login":"fsamin","id":684151,"avatar_url":"https://avatars1.githubusercontent.com/u/684151?v=4","gravatar_id":"","url":"https://api.github.com/users/fsamin","html_url":"https://github.com/fsamin","followers_url":"https://api.github.com/users/fsamin/followers","following_url":"https://api.github.com/users/fsamin/following{/other_user}","gists_url":"https://api.github.com/users/fsamin/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamin/subscriptions","organizations_url":"https://api.github.com/users/fsamin/orgs","repos_url":"https://api.github.com/users/fsamin/repos","events_url":"https://api.github.com/users/fsamin/events{/privacy}","received_events_url":"https://api.github.com/users/fsamin/received_events","type":"User","site_admin":false},"body":"What was the difference between the object ?\r\nThe struct in only composed of comparable types, so we don't need reflection to compare it\r\n\r\nEventually if the comparison is a bit specific implement an Equal function on the type to avoid a new dependency and reflection","created_at":"2018-03-01T13:37:07Z","updated_at":"2018-03-01T13:37:13Z","html_url":"https://github.com/ovh/cds/pull/2339#discussion_r171559365","pull_request_url":"https://api.github.com/repos/ovh/cds/pulls/2339","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments/171559365"},"html":{"href":"https://github.com/ovh/cds/pull/2339#discussion_r171559365"},"pull_request":{"href":"https://api.github.com/repos/ovh/cds/pulls/2339"}}},"pull_request":{"url":"https://api.github.com/repos/ovh/cds/pulls/2339","id":172227850,"html_url":"https://github.com/ovh/cds/pull/2339","diff_url":"https://github.com/ovh/cds/pull/2339.diff","patch_url":"https://github.com/ovh/cds/pull/2339.patch","issue_url":"https://api.github.com/repos/ovh/cds/issues/2339","number":2339,"state":"open","locked":false,"title":"fix (api): upload artifact - compare obj","user":{"login":"yesnault","id":395454,"avatar_url":"https://avatars3.githubusercontent.com/u/395454?v=4","gravatar_id":"","url":"https://api.github.com/users/yesnault","html_url":"https://github.com/yesnault","followers_url":"https://api.github.com/users/yesnault/followers","following_url":"https://api.github.com/users/yesnault/following{/other_user}","gists_url":"https://api.github.com/users/yesnault/gists{/gist_id}","starred_url":"https://api.github.com/users/yesnault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesnault/subscriptions","organizations_url":"https://api.github.com/users/yesnault/orgs","repos_url":"https://api.github.com/users/yesnault/repos","events_url":"https://api.github.com/users/yesnault/events{/privacy}","received_events_url":"https://api.github.com/users/yesnault/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>","created_at":"2018-03-01T12:50:27Z","updated_at":"2018-03-01T13:37:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c5f51582cf6c1f399038c2c4cda53d08431419","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sguiheux","id":1478025,"avatar_url":"https://avatars2.githubusercontent.com/u/1478025?v=4","gravatar_id":"","url":"https://api.github.com/users/sguiheux","html_url":"https://github.com/sguiheux","followers_url":"https://api.github.com/users/sguiheux/followers","following_url":"https://api.github.com/users/sguiheux/following{/other_user}","gists_url":"https://api.github.com/users/sguiheux/gists{/gist_id}","starred_url":"https://api.github.com/users/sguiheux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguiheux/subscriptions","organizations_url":"https://api.github.com/users/sguiheux/orgs","repos_url":"https://api.github.com/users/sguiheux/repos","events_url":"https://api.github.com/users/sguiheux/events{/privacy}","received_events_url":"https://api.github.com/users/sguiheux/received_events","type":"User","site_admin":false},{"login":"bnjjj","id":5719034,"avatar_url":"https://avatars2.githubusercontent.com/u/5719034?v=4","gravatar_id":"","url":"https://api.github.com/users/bnjjj","html_url":"https://github.com/bnjjj","followers_url":"https://api.github.com/users/bnjjj/followers","following_url":"https://api.github.com/users/bnjjj/following{/other_user}","gists_url":"https://api.github.com/users/bnjjj/gists{/gist_id}","starred_url":"https://api.github.com/users/bnjjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnjjj/subscriptions","organizations_url":"https://api.github.com/users/bnjjj/orgs","repos_url":"https://api.github.com/users/bnjjj/repos","events_url":"https://api.github.com/users/bnjjj/events{/privacy}","received_events_url":"https://api.github.com/users/bnjjj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":827850417,"url":"https://api.github.com/repos/ovh/cds/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ovh/cds/pulls/2339/commits","review_comments_url":"https://api.github.com/repos/ovh/cds/pulls/2339/comments","review_comment_url":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh/cds/issues/2339/comments","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/0eff129fe1ad43c891e1b0e3761fbe9cf438c03c","head":{"label":"ovh:ye-fix-upload-tmpl-url","ref":"ye-fix-upload-tmpl-url","sha":"0eff129fe1ad43c891e1b0e3761fbe9cf438c03c","user":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"name":"cds","full_name":"ovh/cds","owner":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh/cds","description":"Enterprise-Grade Continuous Delivery & DevOps Automation Open Source Platform","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2018-03-01T13:11:06Z","pushed_at":"2018-03-01T13:14:06Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"https://ovh.github.io/cds/","size":72229,"stargazers_count":226,"watchers_count":226,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":45,"open_issues":117,"watchers":226,"default_branch":"master"}},"base":{"label":"ovh:master","ref":"master","sha":"85671e3420f4a3137ca7470c04182f68f0858d43","user":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"name":"cds","full_name":"ovh/cds","owner":{"login":"ovh","id":1698434,"avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh/cds","description":"Enterprise-Grade Continuous Delivery & DevOps Automation Open Source Platform","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2018-03-01T13:11:06Z","pushed_at":"2018-03-01T13:14:06Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"https://ovh.github.io/cds/","size":72229,"stargazers_count":226,"watchers_count":226,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":45,"open_issues":117,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/2339"},"html":{"href":"https://github.com/ovh/cds/pull/2339"},"issue":{"href":"https://api.github.com/repos/ovh/cds/issues/2339"},"comments":{"href":"https://api.github.com/repos/ovh/cds/issues/2339/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh/cds/pulls/2339/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh/cds/pulls/2339/commits"},"statuses":{"href":"https://api.github.com/repos/ovh/cds/statuses/0eff129fe1ad43c891e1b0e3761fbe9cf438c03c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fsamin"}}