{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4279","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4279/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4279/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4279/events","html_url":"https://github.com/MetaMask/metamask-extension/pull/4279","id":323863213,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NjE2OTY4","number":4279,"title":"Enhancement: New BlockTracker and Json-Rpc-Engine based Provider","user":{"login":"kumavis","id":1474978,"node_id":"MDQ6VXNlcjE0NzQ5Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1474978?v=4","gravatar_id":"","url":"https://api.github.com/users/kumavis","html_url":"https://github.com/kumavis","followers_url":"https://api.github.com/users/kumavis/followers","following_url":"https://api.github.com/users/kumavis/following{/other_user}","gists_url":"https://api.github.com/users/kumavis/gists{/gist_id}","starred_url":"https://api.github.com/users/kumavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumavis/subscriptions","organizations_url":"https://api.github.com/users/kumavis/orgs","repos_url":"https://api.github.com/users/kumavis/repos","events_url":"https://api.github.com/users/kumavis/events{/privacy}","received_events_url":"https://api.github.com/users/kumavis/received_events","type":"User","site_admin":false},"labels":[{"id":573693206,"node_id":"MDU6TGFiZWw1NzM2OTMyMDY=","url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/T12-DONOTMERGE","name":"T12-DONOTMERGE","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-05-17T03:51:25Z","updated_at":"2018-06-12T15:52:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4279","html_url":"https://github.com/MetaMask/metamask-extension/pull/4279","diff_url":"https://github.com/MetaMask/metamask-extension/pull/4279.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/4279.patch"},"body":"- [x] move to away from provider engine\r\n  - [x] configure network via json-rpc-engine\r\n  - [x] remove `provider._blockTracker` and `provider.on('block')` usage\r\n  - [x] remove provider-engine dep\r\n  - [x] remove docs mentioning provider-engine dep\r\n- [x] move to `eth-block-tracker`@4\r\n  - [x] update block event handlers\r\n    - [x] eth-json-rpc-filters\r\n    - [x] recent-block controller\r\n    - [x] balance controller\r\n    - [x] tx controller\r\n    - [x] nonce-tracker\r\n    - [x] others??\r\n    - [x] fix missing block on block body requests\r\n  - [x] update `eth-block-tracker` dep to use semver\r\n\r\nbonus:\r\n- [ ] add subs support\r\n- [ ] dont subscribe to blocks unless necessary\r\n- [ ] dedupe repeated code in controllers/network/createXyzClient\r\n- [ ] publish `createBlockTrackerInspectorMiddleware`\r\n- [x] nonce-tracker `_getCurrentBlock` -> `await getLatestBlock()`"},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/396640430","html_url":"https://github.com/MetaMask/metamask-extension/pull/4279#issuecomment-396640430","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4279","id":396640430,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjY0MDQzMA==","user":{"login":"metamaskbot","id":37885440,"node_id":"MDQ6VXNlcjM3ODg1NDQw","avatar_url":"https://avatars2.githubusercontent.com/u/37885440?v=4","gravatar_id":"","url":"https://api.github.com/users/metamaskbot","html_url":"https://github.com/metamaskbot","followers_url":"https://api.github.com/users/metamaskbot/followers","following_url":"https://api.github.com/users/metamaskbot/following{/other_user}","gists_url":"https://api.github.com/users/metamaskbot/gists{/gist_id}","starred_url":"https://api.github.com/users/metamaskbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamaskbot/subscriptions","organizations_url":"https://api.github.com/users/metamaskbot/orgs","repos_url":"https://api.github.com/users/metamaskbot/repos","events_url":"https://api.github.com/users/metamaskbot/events{/privacy}","received_events_url":"https://api.github.com/users/metamaskbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T15:52:06Z","updated_at":"2018-06-12T15:52:06Z","author_association":"NONE","body":"\n  <details>\n    <summary>\n      Builds ready [030fea7]:\n      <a href=\"https://26336-42009758-gh.circle-artifacts.com/0/builds/mascara/home.html\">mascara</a>,\n      <a href=\"https://26336-42009758-gh.circle-artifacts.com/0/builds/metamask-chrome-4.7.4.zip\">chrome</a>,\n      <a href=\"https://26336-42009758-gh.circle-artifacts.com/0/builds/metamask-firefox-4.7.4.zip\">firefox</a>,\n      <a href=\"https://26336-42009758-gh.circle-artifacts.com/0/builds/metamask-edge-4.7.4.zip\">edge</a>,\n      <a href=\"https://26336-42009758-gh.circle-artifacts.com/0/builds/metamask-opera-4.7.4.zip\">opera</a>\n    </summary>\n    <image src=\"https://26336-42009758-gh.circle-artifacts.com/0/test-artifacts/screens/walkthrough%20%28en%29.gif\">\n  </details>\n  "}}
{"actor":{"display_login":"metamaskbot"}}