{"action":"created","comment":{"url":"https://api.github.com/repos/certbot/certbot/pulls/comments/191611310","pull_request_review_id":124214488,"id":191611310,"diff_hunk":"@@ -39,9 +39,11 @@ class SSLSocket(object):  # pylint: disable=too-few-public-methods\n     :ivar method: See `OpenSSL.SSL.Context` for allowed values.\n \n     \"\"\"\n-    def __init__(self, sock, certs, method=_DEFAULT_TLSSNI01_SSL_METHOD):\n+    def __init__(self, sock, cert_selection, alpn_selection=None,","path":"acme/acme/crypto_util.py","position":5,"original_position":5,"commit_id":"a68ea39a45e92a7679a952f4fc08249622c97695","original_commit_id":"a68ea39a45e92a7679a952f4fc08249622c97695","user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"body":"I appreciate you setting up the plumbing here so we can only serve the cert when it's requested using ALPN when openssl and pyopenssl support it and while this change is probably OK, we've been avoiding making breaking changes in `acme` since we entered beta in 2015. With this in mind, I'm thinking we should revert the `cert -> cert_selection` changes here for now and we can revisit this if desired when this feature is added to our dependencies.\r\n\r\nDoes this seem reasonable to you?","created_at":"2018-05-30T00:11:13Z","updated_at":"2018-05-30T00:34:50Z","html_url":"https://github.com/certbot/certbot/pull/5894#discussion_r191611310","pull_request_url":"https://api.github.com/repos/certbot/certbot/pulls/5894","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments/191611310"},"html":{"href":"https://github.com/certbot/certbot/pull/5894#discussion_r191611310"},"pull_request":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5894"}}},"pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/5894","id":183373245,"html_url":"https://github.com/certbot/certbot/pull/5894","diff_url":"https://github.com/certbot/certbot/pull/5894.diff","patch_url":"https://github.com/certbot/certbot/pull/5894.patch","issue_url":"https://api.github.com/repos/certbot/certbot/issues/5894","number":5894,"state":"open","locked":false,"title":"Implement TLS-ALPN-01 challenge and standalone TLS-ALPN server ","user":{"login":"mdebski","id":4614150,"avatar_url":"https://avatars0.githubusercontent.com/u/4614150?v=4","gravatar_id":"","url":"https://api.github.com/users/mdebski","html_url":"https://github.com/mdebski","followers_url":"https://api.github.com/users/mdebski/followers","following_url":"https://api.github.com/users/mdebski/following{/other_user}","gists_url":"https://api.github.com/users/mdebski/gists{/gist_id}","starred_url":"https://api.github.com/users/mdebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdebski/subscriptions","organizations_url":"https://api.github.com/users/mdebski/orgs","repos_url":"https://api.github.com/users/mdebski/repos","events_url":"https://api.github.com/users/mdebski/events{/privacy}","received_events_url":"https://api.github.com/users/mdebski/received_events","type":"User","site_admin":false},"body":"The new challenge is described in https://github.com/rolandshoemaker/acme-tls-alpn.\r\n","created_at":"2018-04-23T09:23:43Z","updated_at":"2018-05-30T00:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"829b83431c94ef35124bb2c57cda87db25ff96c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/certbot/certbot/pulls/5894/commits","review_comments_url":"https://api.github.com/repos/certbot/certbot/pulls/5894/comments","review_comment_url":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/5894/comments","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/a68ea39a45e92a7679a952f4fc08249622c97695","head":{"label":"mdebski:tlsalpn","ref":"tlsalpn","sha":"a68ea39a45e92a7679a952f4fc08249622c97695","user":{"login":"mdebski","id":4614150,"avatar_url":"https://avatars0.githubusercontent.com/u/4614150?v=4","gravatar_id":"","url":"https://api.github.com/users/mdebski","html_url":"https://github.com/mdebski","followers_url":"https://api.github.com/users/mdebski/followers","following_url":"https://api.github.com/users/mdebski/following{/other_user}","gists_url":"https://api.github.com/users/mdebski/gists{/gist_id}","starred_url":"https://api.github.com/users/mdebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdebski/subscriptions","organizations_url":"https://api.github.com/users/mdebski/orgs","repos_url":"https://api.github.com/users/mdebski/repos","events_url":"https://api.github.com/users/mdebski/events{/privacy}","received_events_url":"https://api.github.com/users/mdebski/received_events","type":"User","site_admin":false},"repo":{"id":128757687,"name":"certbot","full_name":"mdebski/certbot","owner":{"login":"mdebski","id":4614150,"avatar_url":"https://avatars0.githubusercontent.com/u/4614150?v=4","gravatar_id":"","url":"https://api.github.com/users/mdebski","html_url":"https://github.com/mdebski","followers_url":"https://api.github.com/users/mdebski/followers","following_url":"https://api.github.com/users/mdebski/following{/other_user}","gists_url":"https://api.github.com/users/mdebski/gists{/gist_id}","starred_url":"https://api.github.com/users/mdebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdebski/subscriptions","organizations_url":"https://api.github.com/users/mdebski/orgs","repos_url":"https://api.github.com/users/mdebski/repos","events_url":"https://api.github.com/users/mdebski/events{/privacy}","received_events_url":"https://api.github.com/users/mdebski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdebski/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":true,"url":"https://api.github.com/repos/mdebski/certbot","forks_url":"https://api.github.com/repos/mdebski/certbot/forks","keys_url":"https://api.github.com/repos/mdebski/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdebski/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdebski/certbot/teams","hooks_url":"https://api.github.com/repos/mdebski/certbot/hooks","issue_events_url":"https://api.github.com/repos/mdebski/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/mdebski/certbot/events","assignees_url":"https://api.github.com/repos/mdebski/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/mdebski/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/mdebski/certbot/tags","blobs_url":"https://api.github.com/repos/mdebski/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdebski/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdebski/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdebski/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdebski/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/mdebski/certbot/languages","stargazers_url":"https://api.github.com/repos/mdebski/certbot/stargazers","contributors_url":"https://api.github.com/repos/mdebski/certbot/contributors","subscribers_url":"https://api.github.com/repos/mdebski/certbot/subscribers","subscription_url":"https://api.github.com/repos/mdebski/certbot/subscription","commits_url":"https://api.github.com/repos/mdebski/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdebski/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdebski/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdebski/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdebski/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/mdebski/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdebski/certbot/merges","archive_url":"https://api.github.com/repos/mdebski/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdebski/certbot/downloads","issues_url":"https://api.github.com/repos/mdebski/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/mdebski/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/mdebski/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/mdebski/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdebski/certbot/labels{/name}","releases_url":"https://api.github.com/repos/mdebski/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/mdebski/certbot/deployments","created_at":"2018-04-09T10:55:07Z","updated_at":"2018-04-09T16:07:43Z","pushed_at":"2018-05-16T15:09:37Z","git_url":"git://github.com/mdebski/certbot.git","ssh_url":"git@github.com:mdebski/certbot.git","clone_url":"https://github.com/mdebski/certbot.git","svn_url":"https://github.com/mdebski/certbot","homepage":"","size":18554,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"certbot:master","ref":"master","sha":"41e1976c178dac8875584e8f11d68e28515e0a01","user":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-05-29T23:55:54Z","pushed_at":"2018-05-30T00:33:20Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":18875,"stargazers_count":22278,"watchers_count":22278,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2141,"mirror_url":null,"archived":false,"open_issues_count":992,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2141,"open_issues":992,"watchers":22278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5894"},"html":{"href":"https://github.com/certbot/certbot/pull/5894"},"issue":{"href":"https://api.github.com/repos/certbot/certbot/issues/5894"},"comments":{"href":"https://api.github.com/repos/certbot/certbot/issues/5894/comments"},"review_comments":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5894/comments"},"review_comment":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5894/commits"},"statuses":{"href":"https://api.github.com/repos/certbot/certbot/statuses/a68ea39a45e92a7679a952f4fc08249622c97695"}},"author_association":"NONE"}}
{"actor":{"display_login":"bmw"}}