{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/244391779","pull_request_review_id":188356188,"id":244391779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM5MTc3OQ==","diff_hunk":"@@ -58,18 +62,73 @@ Rectangle {\n                 }\n             }\n \n-            LineEditMulti {\n-                Layout.fillWidth: true;\n+            MoneroComponents.LineEditMulti {\n                 id: addressLine\n                 labelText: qsTr(\"Address\") + translationManager.emptyString\n-                error: true;\n-                placeholderText: qsTr(\"4.. / 8..\") + translationManager.emptyString\n+                placeholderText: \"4.. / 8.. / OpenAlias\"\n                 wrapMode: Text.WrapAnywhere\n                 addressValidation: true\n+                pasteButton: true\n+                onPaste: function(clipboardText) {\n+                    const parsed = walletManager.parse_uri_to_object(clipboardText);\n+                    if (!parsed.error) {\n+                        addressLine.text = parsed.address;\n+                        setPaymentId(parsed.payment_id);\n+                        setDescription(parsed.tx_description);\n+                    } else {\n+                        addressLine.text = clipboardText;\n+                    }\n+                }\n             }\n         }\n \n-        LineEditMulti {\n+        MoneroComponents.StandardButton {\n+            id: resolveButton\n+            text: qsTr(\"Resolve\") + translationManager.emptyString\n+            visible: TxUtils.isValidOpenAliasAddress(addressLine.text)\n+            enabled : visible\n+            onClicked: {\n+                var result = walletManager.resolveOpenAlias(addressLine.text)","path":"pages/AddressBook.qml","position":64,"original_position":64,"commit_id":"2e154e016f0145a41e2bd7138125ef55b7ed5efd","original_commit_id":"a48f3deac43bb3f2af79e9d4612b1660532ac42e","user":{"login":"mmbyday","id":40871101,"node_id":"MDQ6VXNlcjQwODcxMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/40871101?v=4","gravatar_id":"","url":"https://api.github.com/users/mmbyday","html_url":"https://github.com/mmbyday","followers_url":"https://api.github.com/users/mmbyday/followers","following_url":"https://api.github.com/users/mmbyday/following{/other_user}","gists_url":"https://api.github.com/users/mmbyday/gists{/gist_id}","starred_url":"https://api.github.com/users/mmbyday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmbyday/subscriptions","organizations_url":"https://api.github.com/users/mmbyday/orgs","repos_url":"https://api.github.com/users/mmbyday/repos","events_url":"https://api.github.com/users/mmbyday/events{/privacy}","received_events_url":"https://api.github.com/users/mmbyday/received_events","type":"User","site_admin":false},"body":"Do you mean resolveOpenAlias vs isValidOpenAliasAddress? Not really as they do different things.","created_at":"2018-12-28T19:32:48Z","updated_at":"2018-12-28T19:32:48Z","html_url":"https://github.com/monero-project/monero-gui/pull/1870#discussion_r244391779","pull_request_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/244391779"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1870#discussion_r244391779"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870"}},"in_reply_to_id":244382288},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870","id":241369917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzY5OTE3","html_url":"https://github.com/monero-project/monero-gui/pull/1870","diff_url":"https://github.com/monero-project/monero-gui/pull/1870.diff","patch_url":"https://github.com/monero-project/monero-gui/pull/1870.patch","issue_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1870","number":1870,"state":"open","locked":false,"title":"openalias: usability improvements on addressbook/transfer page","user":{"login":"mmbyday","id":40871101,"node_id":"MDQ6VXNlcjQwODcxMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/40871101?v=4","gravatar_id":"","url":"https://api.github.com/users/mmbyday","html_url":"https://github.com/mmbyday","followers_url":"https://api.github.com/users/mmbyday/followers","following_url":"https://api.github.com/users/mmbyday/following{/other_user}","gists_url":"https://api.github.com/users/mmbyday/gists{/gist_id}","starred_url":"https://api.github.com/users/mmbyday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmbyday/subscriptions","organizations_url":"https://api.github.com/users/mmbyday/orgs","repos_url":"https://api.github.com/users/mmbyday/repos","events_url":"https://api.github.com/users/mmbyday/events{/privacy}","received_events_url":"https://api.github.com/users/mmbyday/received_events","type":"User","site_admin":false},"body":"resolves #1072\r\n\r\n- [x] sending : adds placeholderText to indicate openalias support\r\n- [x] sending tab address validation :  resolved by PR #1849 \r\n- [x] transaction history : adds openalias to description field, which is displayed in transaction history\r\n- [x] address book : add openalias resolve button, update placeholderText, adde openalias address validation, and saves openalias address to description field.\r\n\r\n![getxmr](https://user-images.githubusercontent.com/40871101/50523184-88957300-0a83-11e9-8509-bde85118a3fa.gif)","created_at":"2018-12-28T17:33:33Z","updated_at":"2018-12-28T19:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7532ab3c5ec14b8e356f130837bbc1700a75133c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1870/comments","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/2e154e016f0145a41e2bd7138125ef55b7ed5efd","head":{"label":"mmbyday:openalias-support","ref":"openalias-support","sha":"2e154e016f0145a41e2bd7138125ef55b7ed5efd","user":{"login":"mmbyday","id":40871101,"node_id":"MDQ6VXNlcjQwODcxMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/40871101?v=4","gravatar_id":"","url":"https://api.github.com/users/mmbyday","html_url":"https://github.com/mmbyday","followers_url":"https://api.github.com/users/mmbyday/followers","following_url":"https://api.github.com/users/mmbyday/following{/other_user}","gists_url":"https://api.github.com/users/mmbyday/gists{/gist_id}","starred_url":"https://api.github.com/users/mmbyday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmbyday/subscriptions","organizations_url":"https://api.github.com/users/mmbyday/orgs","repos_url":"https://api.github.com/users/mmbyday/repos","events_url":"https://api.github.com/users/mmbyday/events{/privacy}","received_events_url":"https://api.github.com/users/mmbyday/received_events","type":"User","site_admin":false},"repo":{"id":159565003,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NjUwMDM=","name":"monero-gui","full_name":"mmbyday/monero-gui","private":false,"owner":{"login":"mmbyday","id":40871101,"node_id":"MDQ6VXNlcjQwODcxMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/40871101?v=4","gravatar_id":"","url":"https://api.github.com/users/mmbyday","html_url":"https://github.com/mmbyday","followers_url":"https://api.github.com/users/mmbyday/followers","following_url":"https://api.github.com/users/mmbyday/following{/other_user}","gists_url":"https://api.github.com/users/mmbyday/gists{/gist_id}","starred_url":"https://api.github.com/users/mmbyday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmbyday/subscriptions","organizations_url":"https://api.github.com/users/mmbyday/orgs","repos_url":"https://api.github.com/users/mmbyday/repos","events_url":"https://api.github.com/users/mmbyday/events{/privacy}","received_events_url":"https://api.github.com/users/mmbyday/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmbyday/monero-gui","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/mmbyday/monero-gui","forks_url":"https://api.github.com/repos/mmbyday/monero-gui/forks","keys_url":"https://api.github.com/repos/mmbyday/monero-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmbyday/monero-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmbyday/monero-gui/teams","hooks_url":"https://api.github.com/repos/mmbyday/monero-gui/hooks","issue_events_url":"https://api.github.com/repos/mmbyday/monero-gui/issues/events{/number}","events_url":"https://api.github.com/repos/mmbyday/monero-gui/events","assignees_url":"https://api.github.com/repos/mmbyday/monero-gui/assignees{/user}","branches_url":"https://api.github.com/repos/mmbyday/monero-gui/branches{/branch}","tags_url":"https://api.github.com/repos/mmbyday/monero-gui/tags","blobs_url":"https://api.github.com/repos/mmbyday/monero-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmbyday/monero-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmbyday/monero-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmbyday/monero-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmbyday/monero-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/mmbyday/monero-gui/languages","stargazers_url":"https://api.github.com/repos/mmbyday/monero-gui/stargazers","contributors_url":"https://api.github.com/repos/mmbyday/monero-gui/contributors","subscribers_url":"https://api.github.com/repos/mmbyday/monero-gui/subscribers","subscription_url":"https://api.github.com/repos/mmbyday/monero-gui/subscription","commits_url":"https://api.github.com/repos/mmbyday/monero-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmbyday/monero-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmbyday/monero-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmbyday/monero-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmbyday/monero-gui/contents/{+path}","compare_url":"https://api.github.com/repos/mmbyday/monero-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmbyday/monero-gui/merges","archive_url":"https://api.github.com/repos/mmbyday/monero-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmbyday/monero-gui/downloads","issues_url":"https://api.github.com/repos/mmbyday/monero-gui/issues{/number}","pulls_url":"https://api.github.com/repos/mmbyday/monero-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/mmbyday/monero-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/mmbyday/monero-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmbyday/monero-gui/labels{/name}","releases_url":"https://api.github.com/repos/mmbyday/monero-gui/releases{/id}","deployments_url":"https://api.github.com/repos/mmbyday/monero-gui/deployments","created_at":"2018-11-28T21:07:42Z","updated_at":"2018-12-28T05:14:55Z","pushed_at":"2018-12-28T19:29:12Z","git_url":"git://github.com/mmbyday/monero-gui.git","ssh_url":"git@github.com:mmbyday/monero-gui.git","clone_url":"https://github.com/mmbyday/monero-gui.git","svn_url":"https://github.com/mmbyday/monero-gui","homepage":null,"size":10038,"stargazers_count":0,"watchers_count":0,"language":"QML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"48a267f631c18d3159cccfc551d72cc5aeb0df03","user":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":33237663,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIzNzY2Mw==","name":"monero-gui","full_name":"monero-project/monero-gui","private":false,"owner":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monero-project/monero-gui","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero-gui","forks_url":"https://api.github.com/repos/monero-project/monero-gui/forks","keys_url":"https://api.github.com/repos/monero-project/monero-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero-gui/teams","hooks_url":"https://api.github.com/repos/monero-project/monero-gui/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero-gui/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero-gui/events","assignees_url":"https://api.github.com/repos/monero-project/monero-gui/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero-gui/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero-gui/tags","blobs_url":"https://api.github.com/repos/monero-project/monero-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero-gui/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero-gui/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero-gui/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero-gui/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero-gui/subscription","commits_url":"https://api.github.com/repos/monero-project/monero-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero-gui/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero-gui/merges","archive_url":"https://api.github.com/repos/monero-project/monero-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero-gui/downloads","issues_url":"https://api.github.com/repos/monero-project/monero-gui/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero-gui/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero-gui/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero-gui/deployments","created_at":"2015-04-01T09:08:42Z","updated_at":"2018-12-28T07:23:15Z","pushed_at":"2018-12-28T19:29:13Z","git_url":"git://github.com/monero-project/monero-gui.git","ssh_url":"git@github.com:monero-project/monero-gui.git","clone_url":"https://github.com/monero-project/monero-gui.git","svn_url":"https://github.com/monero-project/monero-gui","homepage":null,"size":10037,"stargazers_count":379,"watchers_count":379,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":492,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":492,"open_issues":169,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1870"},"issue":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1870"},"comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1870/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1870/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero-gui/statuses/2e154e016f0145a41e2bd7138125ef55b7ed5efd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mmbyday"}}