{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/4343","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4343/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4343/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4343/events","html_url":"https://github.com/envoyproxy/envoy/pull/4343","id":357182816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjU3NzQ1","number":4343,"title":"time: Rename time_source_ and timeSource() to time_system_ and timeSystem() as appropriate","user":{"login":"jmarantz","id":1942589,"node_id":"MDQ6VXNlcjE5NDI1ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-05T11:21:07Z","updated_at":"2018-09-05T18:54:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4343","html_url":"https://github.com/envoyproxy/envoy/pull/4343","diff_url":"https://github.com/envoyproxy/envoy/pull/4343.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4343.patch"},"body":"*Description*: In #4257, Event::TimeSystem was introduced to augment the TimeSource abstraction to include timers. Most places in the system that had previously held onto a TimeSource held it in a member variable time_source_ and, if appropriate, exposed it as a method timeSource(), and #4257 changed those to Event::TimeSystem without renaming them, in order to minimize diffs. This PR just renames the members and methods to time_system_ and timeSystem() as appropriate. This is part of the chain of CLs to resolve #4160.\r\n\r\n*Risk Level*: low -- no functional risk, but depending on timing of when this gets merged, an easily-remedied build breakage could arise.\r\n*Testing*: //test/...\r\n*Docs Changes*: n/a\r\n*Release Notes*: n/a\r\n"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/418841914","html_url":"https://github.com/envoyproxy/envoy/pull/4343#issuecomment-418841914","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4343","id":418841914,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODg0MTkxNA==","user":{"login":"dnoe","id":1183641,"node_id":"MDQ6VXNlcjExODM2NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1183641?v=4","gravatar_id":"","url":"https://api.github.com/users/dnoe","html_url":"https://github.com/dnoe","followers_url":"https://api.github.com/users/dnoe/followers","following_url":"https://api.github.com/users/dnoe/following{/other_user}","gists_url":"https://api.github.com/users/dnoe/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoe/subscriptions","organizations_url":"https://api.github.com/users/dnoe/orgs","repos_url":"https://api.github.com/users/dnoe/repos","events_url":"https://api.github.com/users/dnoe/events{/privacy}","received_events_url":"https://api.github.com/users/dnoe/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T18:54:14Z","updated_at":"2018-09-05T18:54:14Z","author_association":"CONTRIBUTOR","body":"Are all three of your time-related PRs independent or is there any desired order of review/merging that will make people's lives easier?"}}
{"actor":{"display_login":"dnoe"}}