{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/tally-cpp/pulls/comments/202987641","pull_request_review_id":137782499,"id":202987641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjk4NzY0MQ==","diff_hunk":"@@ -0,0 +1,63 @@\n+// Copyright (c) 2018 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+#include \"tally/src/noop_stats_reporter.h\"\n+\n+#include \"tally/src/capable_of.h\"\n+\n+namespace tally {\n+\n+std::shared_ptr<StatsReporter> NoopStatsReporter::New() {","path":"tally/src/noop_stats_reporter.cc","position":27,"original_position":27,"commit_id":"ba511d1eb06ec675578dea001b71ad5801e665f2","original_commit_id":"ba511d1eb06ec675578dea001b71ad5801e665f2","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"So I have done the `Noop` thing too in Jaeger and then thought people may not like it. In this case it might be worse because you aren't inlining the noops in the class declaration header. The compiler may not realize these are noops and incur the function call overhead unnecessarily. Definitely suggest moving any empty function definition to header. There may be a way around `Noop` objects entirely involving macros, but I haven't thought of a good solution yet.","created_at":"2018-07-17T11:35:50Z","updated_at":"2018-07-17T11:44:11Z","html_url":"https://github.com/m3db/tally-cpp/pull/1#discussion_r202987641","pull_request_url":"https://api.github.com/repos/m3db/tally-cpp/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/comments/202987641"},"html":{"href":"https://github.com/m3db/tally-cpp/pull/1#discussion_r202987641"},"pull_request":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/tally-cpp/pulls/1","id":200434834,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDM0ODM0","html_url":"https://github.com/m3db/tally-cpp/pull/1","diff_url":"https://github.com/m3db/tally-cpp/pull/1.diff","patch_url":"https://github.com/m3db/tally-cpp/pull/1.patch","issue_url":"https://api.github.com/repos/m3db/tally-cpp/issues/1","number":1,"state":"open","locked":false,"title":"Add initial implementation of tally client","user":{"login":"jeromefroe","id":7217598,"node_id":"MDQ6VXNlcjcyMTc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7217598?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromefroe","html_url":"https://github.com/jeromefroe","followers_url":"https://api.github.com/users/jeromefroe/followers","following_url":"https://api.github.com/users/jeromefroe/following{/other_user}","gists_url":"https://api.github.com/users/jeromefroe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromefroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromefroe/subscriptions","organizations_url":"https://api.github.com/users/jeromefroe/orgs","repos_url":"https://api.github.com/users/jeromefroe/repos","events_url":"https://api.github.com/users/jeromefroe/events{/privacy}","received_events_url":"https://api.github.com/users/jeromefroe/received_events","type":"User","site_admin":false},"body":"This PR adds the initial implementation of the tally client for C++. The client is divided into two major libraries, `tally` and `m3`, each of which is in a top-level directory with the same name. The `tally` library defines the scope, reporter, and metrics (counters, gauges, timers, and histograms) interfaces. It provides a default implementation of a scope and the metrics. The `m3` library provides an implementation of the reporter interface for emitting metrics using the M3 thrift format.\r\n\r\n~~I still need to get CI setup fully but the code should be ready for review.~~ CI should be all set now.\r\n\r\nUnresolved questions:\r\n- [X] Conventions around exceptions. - Exceptions are permitted for exceptional cases, just not control flow.\r\n- [ ] Conventions for generated code.\r\n- [ ] Logging.\r\n- [ ] Versions of compilers and Thrift should we test and use.","created_at":"2018-07-10T15:23:55Z","updated_at":"2018-07-17T11:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22662b1613b993d08a5c96f9b082b8036d9e41f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/tally-cpp/pulls/1/commits","review_comments_url":"https://api.github.com/repos/m3db/tally-cpp/pulls/1/comments","review_comment_url":"https://api.github.com/repos/m3db/tally-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/tally-cpp/issues/1/comments","statuses_url":"https://api.github.com/repos/m3db/tally-cpp/statuses/ba511d1eb06ec675578dea001b71ad5801e665f2","head":{"label":"m3db:jeromefroe/initial-implementation-of-tally","ref":"jeromefroe/initial-implementation-of-tally","sha":"ba511d1eb06ec675578dea001b71ad5801e665f2","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":136653889,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NTM4ODk=","name":"tally-cpp","full_name":"m3db/tally-cpp","owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/tally-cpp","description":"C++ Tally Client","fork":false,"url":"https://api.github.com/repos/m3db/tally-cpp","forks_url":"https://api.github.com/repos/m3db/tally-cpp/forks","keys_url":"https://api.github.com/repos/m3db/tally-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/tally-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/tally-cpp/teams","hooks_url":"https://api.github.com/repos/m3db/tally-cpp/hooks","issue_events_url":"https://api.github.com/repos/m3db/tally-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/tally-cpp/events","assignees_url":"https://api.github.com/repos/m3db/tally-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/tally-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/tally-cpp/tags","blobs_url":"https://api.github.com/repos/m3db/tally-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/tally-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/tally-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/tally-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/tally-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/tally-cpp/languages","stargazers_url":"https://api.github.com/repos/m3db/tally-cpp/stargazers","contributors_url":"https://api.github.com/repos/m3db/tally-cpp/contributors","subscribers_url":"https://api.github.com/repos/m3db/tally-cpp/subscribers","subscription_url":"https://api.github.com/repos/m3db/tally-cpp/subscription","commits_url":"https://api.github.com/repos/m3db/tally-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/tally-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/tally-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/tally-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/tally-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/tally-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/tally-cpp/merges","archive_url":"https://api.github.com/repos/m3db/tally-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/tally-cpp/downloads","issues_url":"https://api.github.com/repos/m3db/tally-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/tally-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/tally-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/tally-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/tally-cpp/labels{/name}","releases_url":"https://api.github.com/repos/m3db/tally-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/tally-cpp/deployments","created_at":"2018-06-08T18:35:24Z","updated_at":"2018-07-17T11:09:31Z","pushed_at":"2018-07-16T21:55:18Z","git_url":"git://github.com/m3db/tally-cpp.git","ssh_url":"git@github.com:m3db/tally-cpp.git","clone_url":"https://github.com/m3db/tally-cpp.git","svn_url":"https://github.com/m3db/tally-cpp","homepage":null,"size":132,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"12ee07e68c3cbd0d1d1126bee0a8dad64182a06e","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":136653889,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NTM4ODk=","name":"tally-cpp","full_name":"m3db/tally-cpp","owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/tally-cpp","description":"C++ Tally Client","fork":false,"url":"https://api.github.com/repos/m3db/tally-cpp","forks_url":"https://api.github.com/repos/m3db/tally-cpp/forks","keys_url":"https://api.github.com/repos/m3db/tally-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/tally-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/tally-cpp/teams","hooks_url":"https://api.github.com/repos/m3db/tally-cpp/hooks","issue_events_url":"https://api.github.com/repos/m3db/tally-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/tally-cpp/events","assignees_url":"https://api.github.com/repos/m3db/tally-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/tally-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/tally-cpp/tags","blobs_url":"https://api.github.com/repos/m3db/tally-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/tally-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/tally-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/tally-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/tally-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/tally-cpp/languages","stargazers_url":"https://api.github.com/repos/m3db/tally-cpp/stargazers","contributors_url":"https://api.github.com/repos/m3db/tally-cpp/contributors","subscribers_url":"https://api.github.com/repos/m3db/tally-cpp/subscribers","subscription_url":"https://api.github.com/repos/m3db/tally-cpp/subscription","commits_url":"https://api.github.com/repos/m3db/tally-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/tally-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/tally-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/tally-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/tally-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/tally-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/tally-cpp/merges","archive_url":"https://api.github.com/repos/m3db/tally-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/tally-cpp/downloads","issues_url":"https://api.github.com/repos/m3db/tally-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/tally-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/tally-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/tally-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/tally-cpp/labels{/name}","releases_url":"https://api.github.com/repos/m3db/tally-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/tally-cpp/deployments","created_at":"2018-06-08T18:35:24Z","updated_at":"2018-07-17T11:09:31Z","pushed_at":"2018-07-16T21:55:18Z","git_url":"git://github.com/m3db/tally-cpp.git","ssh_url":"git@github.com:m3db/tally-cpp.git","clone_url":"https://github.com/m3db/tally-cpp.git","svn_url":"https://github.com/m3db/tally-cpp","homepage":null,"size":132,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/1"},"html":{"href":"https://github.com/m3db/tally-cpp/pull/1"},"issue":{"href":"https://api.github.com/repos/m3db/tally-cpp/issues/1"},"comments":{"href":"https://api.github.com/repos/m3db/tally-cpp/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/tally-cpp/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/tally-cpp/statuses/ba511d1eb06ec675578dea001b71ad5801e665f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isaachier"}}