{"action":"created","issue":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9349","repository_url":"https://api.github.com/repos/qbittorrent/qBittorrent","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9349/labels{/name}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9349/comments","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9349/events","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9349","id":351225383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODc0OTAx","number":9349,"title":"Read command line parameters from <exeName>.params file","user":{"login":"zeule","id":394621,"node_id":"MDQ6VXNlcjM5NDYyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/394621?v=4","gravatar_id":"","url":"https://api.github.com/users/zeule","html_url":"https://github.com/zeule","followers_url":"https://api.github.com/users/zeule/followers","following_url":"https://api.github.com/users/zeule/following{/other_user}","gists_url":"https://api.github.com/users/zeule/gists{/gist_id}","starred_url":"https://api.github.com/users/zeule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeule/subscriptions","organizations_url":"https://api.github.com/users/zeule/orgs","repos_url":"https://api.github.com/users/zeule/repos","events_url":"https://api.github.com/users/zeule/events{/privacy}","received_events_url":"https://api.github.com/users/zeule/received_events","type":"User","site_admin":false},"labels":[{"id":662470851,"node_id":"MDU6TGFiZWw2NjI0NzA4NTE=","url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels/Core","name":"Core","color":"111111","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":38,"created_at":"2018-08-16T14:16:46Z","updated_at":"2018-09-17T18:39:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9349","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9349","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/9349.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/9349.patch"},"body":"The file is mainly intended to put `--portable` there, thus solving user complains from #465. \r\n\r\nNot sure that putting the function to obtain executable path in the utils is the right way to go, because it is used only in `main()`  when the application object is not yet created."},"comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments/422124958","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9349#issuecomment-422124958","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9349","id":422124958,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjEyNDk1OA==","user":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T18:39:35Z","updated_at":"2018-09-17T18:39:35Z","author_association":"MEMBER","body":">If one wants to abuse the Qt's parameter parser, it doesn't matter how to pass strings, either via the command line directly, or writing them into a file and reading afterwards.\r\n\r\nNo. It's about valid use case.\r\nQt don't use argc/argv on Windows by default since it contains strings in 8-bit encoding and so it cannot correctly handle params containing characters missing in such code page. It is use `GetCommandLineW()` instead.\r\nBut when you pass modified argc/argv to the QApplication constructor Qt has to use it. **_In that case, encoding problems might occur._** E.g. in case when user tries to open some file containing any of missing in current code page characters."}}
{"actor":{"display_login":"glassez"}}