{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/21820","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/21820/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/21820/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/21820/events","html_url":"https://github.com/facebook/react-native/pull/21820","id":370868707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDQ3NjYy","number":21820,"title":"Make facebook::react::Instance methods overridable.","user":{"login":"JunielKatarn","id":4507319,"node_id":"MDQ6VXNlcjQ1MDczMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/4507319?v=4","gravatar_id":"","url":"https://api.github.com/users/JunielKatarn","html_url":"https://github.com/JunielKatarn","followers_url":"https://api.github.com/users/JunielKatarn/followers","following_url":"https://api.github.com/users/JunielKatarn/following{/other_user}","gists_url":"https://api.github.com/users/JunielKatarn/gists{/gist_id}","starred_url":"https://api.github.com/users/JunielKatarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunielKatarn/subscriptions","organizations_url":"https://api.github.com/users/JunielKatarn/orgs","repos_url":"https://api.github.com/users/JunielKatarn/repos","events_url":"https://api.github.com/users/JunielKatarn/events{/privacy}","received_events_url":"https://api.github.com/users/JunielKatarn/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-17T02:09:34Z","updated_at":"2018-10-17T02:19:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/21820","html_url":"https://github.com/facebook/react-native/pull/21820","diff_url":"https://github.com/facebook/react-native/pull/21820.diff","patch_url":"https://github.com/facebook/react-native/pull/21820.patch"},"body":"Thank you for sending the PR! We appreciate you spending the time to work on these changes.\r\nHelp us understand your motivation by explaining why you decided to make this change.\r\n\r\nIf this PR fixes an issue, type \"Fixes #issueNumber\" to automatically close the issue when the PR is merged.\r\n\r\n_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_\r\n\r\nTest Plan:\r\n----------\r\n- Build\r\n- Run unit and integration tests for both iOS and Android\r\n\r\nRelease Notes:\r\n--------------\r\nHelp reviewers and the release process by writing your own release notes. See below for an example.\r\n\r\n[GENERAL] [ENHANCEMENT] [ReactCommon] - Allow facebook::react::Instance to be extended for unit testing / mocking purposes.\r\n\r\nCustom native modules don't have a way to mock the expected `Instance` reference.\r\nThis change allows writing a mock or stub for class `facebook::react::Instance`.\r\n\r\n<!--\r\n  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**\r\n\r\n    CATEGORY\r\n  [----------]      TYPE\r\n  [ CLI      ] [-------------]    LOCATION\r\n  [ DOCS     ] [ BREAKING    ] [-------------]\r\n  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]\r\n  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]\r\n  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|\r\n  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |\r\n  [----------] [-------------] [-------------]   |-----------|\r\n\r\n EXAMPLES:\r\n\r\n [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things\r\n [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput\r\n [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with\r\n [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word\r\n [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position\r\n [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/430465780","html_url":"https://github.com/facebook/react-native/pull/21820#issuecomment-430465780","issue_url":"https://api.github.com/repos/facebook/react-native/issues/21820","id":430465780,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDQ2NTc4MA==","user":{"login":"facebook-github-bot","id":6422482,"node_id":"MDQ6VXNlcjY0MjI0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T02:19:23Z","updated_at":"2018-10-17T02:19:23Z","author_association":"NONE","body":"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!"}}
{"actor":{"display_login":"facebook-github-bot"}}