{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/200958835","pull_request_review_id":135365336,"id":200958835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk1ODgzNQ==","diff_hunk":"@@ -26,11 +26,16 @@ import (\n \t\"github.com/cilium/cilium/pkg/health/defaults\"\n \t\"github.com/cilium/cilium/pkg/lock\"\n \t\"github.com/cilium/cilium/pkg/logging/logfields\"\n+\t\"github.com/cilium/cilium/pkg/metrics\"\n \n \t\"github.com/servak/go-fastping\"\n \t\"github.com/sirupsen/logrus\"\n )\n \n+const (\n+\tFailedProbeLatency = float64(0)","path":"pkg/health/server/prober.go","position":11,"original_position":11,"commit_id":"4f3d64fcd1c343d2ba25d1e618ea15ae30b1a0c8","original_commit_id":"4f3d64fcd1c343d2ba25d1e618ea15ae30b1a0c8","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported const FailedProbeLatency should have comment (or a comment on this block) or be unexported","created_at":"2018-07-09T10:47:25Z","updated_at":"2018-07-09T10:47:26Z","html_url":"https://github.com/cilium/cilium/pull/4596#discussion_r200958835","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/4596","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/200958835"},"html":{"href":"https://github.com/cilium/cilium/pull/4596#discussion_r200958835"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4596"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/4596","id":196473097,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDczMDk3","html_url":"https://github.com/cilium/cilium/pull/4596","diff_url":"https://github.com/cilium/cilium/pull/4596.diff","patch_url":"https://github.com/cilium/cilium/pull/4596.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/4596","number":4596,"state":"open","locked":false,"title":"[WIP] metrics: Add cilium-health metrics about latency","user":{"login":"mrostecki","id":34685103,"node_id":"MDQ6VXNlcjM0Njg1MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/34685103?v=4","gravatar_id":"","url":"https://api.github.com/users/mrostecki","html_url":"https://github.com/mrostecki","followers_url":"https://api.github.com/users/mrostecki/followers","following_url":"https://api.github.com/users/mrostecki/following{/other_user}","gists_url":"https://api.github.com/users/mrostecki/gists{/gist_id}","starred_url":"https://api.github.com/users/mrostecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrostecki/subscriptions","organizations_url":"https://api.github.com/users/mrostecki/orgs","repos_url":"https://api.github.com/users/mrostecki/repos","events_url":"https://api.github.com/users/mrostecki/events{/privacy}","received_events_url":"https://api.github.com/users/mrostecki/received_events","type":"User","site_admin":false},"body":"Cilium-health runs in the separate network namespace, so in order\r\nto serve Prometheus metrics from it, it serves a metrics server\r\non unix socket. Then cilium-agent serves a proxy server, which\r\nredirects the traffic from HTTP port to unix socket.\r\n\r\nCurrently supported metric is a histogram with information about\r\nlatency to nodes and endpoints.\r\n\r\nFixes #4267\r\n\r\nSigned-off-by: Michal Rostecki <mrostecki@suse.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/4596)\n<!-- Reviewable:end -->\n","created_at":"2018-06-21T14:32:32Z","updated_at":"2018-07-09T10:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f7074f88734595a86b80f37920907d4aaff1026","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"kubernetes","id":2519785,"node_id":"MDQ6VGVhbTI1MTk3ODU=","slug":"kubernetes","description":"Kubernetes integration","privacy":"closed","url":"https://api.github.com/teams/2519785","members_url":"https://api.github.com/teams/2519785/members{/member}","repositories_url":"https://api.github.com/teams/2519785/repos","permission":"pull"},{"name":"docs","id":2519789,"node_id":"MDQ6VGVhbTI1MTk3ODk=","slug":"docs","description":"Documentation","privacy":"closed","url":"https://api.github.com/teams/2519789","members_url":"https://api.github.com/teams/2519789/members{/member}","repositories_url":"https://api.github.com/teams/2519789/repos","permission":"pull"},{"name":"agent","id":2519792,"node_id":"MDQ6VGVhbTI1MTk3OTI=","slug":"agent","description":"Cilium Agent","privacy":"closed","url":"https://api.github.com/teams/2519792","members_url":"https://api.github.com/teams/2519792/members{/member}","repositories_url":"https://api.github.com/teams/2519792/repos","permission":"pull"},{"name":"vagrant","id":2524637,"node_id":"MDQ6VGVhbTI1MjQ2Mzc=","slug":"vagrant","description":"Vagrant use","privacy":"closed","url":"https://api.github.com/teams/2524637","members_url":"https://api.github.com/teams/2524637/members{/member}","repositories_url":"https://api.github.com/teams/2524637/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/4596/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/4596/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/4596/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/4f3d64fcd1c343d2ba25d1e618ea15ae30b1a0c8","head":{"label":"mrostecki:cilium-health-metrics","ref":"cilium-health-metrics","sha":"4f3d64fcd1c343d2ba25d1e618ea15ae30b1a0c8","user":{"login":"mrostecki","id":34685103,"node_id":"MDQ6VXNlcjM0Njg1MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/34685103?v=4","gravatar_id":"","url":"https://api.github.com/users/mrostecki","html_url":"https://github.com/mrostecki","followers_url":"https://api.github.com/users/mrostecki/followers","following_url":"https://api.github.com/users/mrostecki/following{/other_user}","gists_url":"https://api.github.com/users/mrostecki/gists{/gist_id}","starred_url":"https://api.github.com/users/mrostecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrostecki/subscriptions","organizations_url":"https://api.github.com/users/mrostecki/orgs","repos_url":"https://api.github.com/users/mrostecki/repos","events_url":"https://api.github.com/users/mrostecki/events{/privacy}","received_events_url":"https://api.github.com/users/mrostecki/received_events","type":"User","site_admin":false},"repo":{"id":116836218,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MzYyMTg=","name":"cilium","full_name":"mrostecki/cilium","owner":{"login":"mrostecki","id":34685103,"node_id":"MDQ6VXNlcjM0Njg1MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/34685103?v=4","gravatar_id":"","url":"https://api.github.com/users/mrostecki","html_url":"https://github.com/mrostecki","followers_url":"https://api.github.com/users/mrostecki/followers","following_url":"https://api.github.com/users/mrostecki/following{/other_user}","gists_url":"https://api.github.com/users/mrostecki/gists{/gist_id}","starred_url":"https://api.github.com/users/mrostecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrostecki/subscriptions","organizations_url":"https://api.github.com/users/mrostecki/orgs","repos_url":"https://api.github.com/users/mrostecki/repos","events_url":"https://api.github.com/users/mrostecki/events{/privacy}","received_events_url":"https://api.github.com/users/mrostecki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrostecki/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":true,"url":"https://api.github.com/repos/mrostecki/cilium","forks_url":"https://api.github.com/repos/mrostecki/cilium/forks","keys_url":"https://api.github.com/repos/mrostecki/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrostecki/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrostecki/cilium/teams","hooks_url":"https://api.github.com/repos/mrostecki/cilium/hooks","issue_events_url":"https://api.github.com/repos/mrostecki/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/mrostecki/cilium/events","assignees_url":"https://api.github.com/repos/mrostecki/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/mrostecki/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/mrostecki/cilium/tags","blobs_url":"https://api.github.com/repos/mrostecki/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrostecki/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrostecki/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrostecki/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrostecki/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/mrostecki/cilium/languages","stargazers_url":"https://api.github.com/repos/mrostecki/cilium/stargazers","contributors_url":"https://api.github.com/repos/mrostecki/cilium/contributors","subscribers_url":"https://api.github.com/repos/mrostecki/cilium/subscribers","subscription_url":"https://api.github.com/repos/mrostecki/cilium/subscription","commits_url":"https://api.github.com/repos/mrostecki/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrostecki/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrostecki/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrostecki/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrostecki/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/mrostecki/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrostecki/cilium/merges","archive_url":"https://api.github.com/repos/mrostecki/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrostecki/cilium/downloads","issues_url":"https://api.github.com/repos/mrostecki/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/mrostecki/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/mrostecki/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/mrostecki/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrostecki/cilium/labels{/name}","releases_url":"https://api.github.com/repos/mrostecki/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/mrostecki/cilium/deployments","created_at":"2018-01-09T15:47:39Z","updated_at":"2018-06-19T15:00:06Z","pushed_at":"2018-07-09T10:47:19Z","git_url":"git://github.com/mrostecki/cilium.git","ssh_url":"git@github.com:mrostecki/cilium.git","clone_url":"https://github.com/mrostecki/cilium.git","svn_url":"https://github.com/mrostecki/cilium","homepage":"","size":52388,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"594a619626ae676eeb7a49bf857d563644722a11","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-07-09T09:51:34Z","pushed_at":"2018-07-09T10:47:21Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":53908,"stargazers_count":2505,"watchers_count":2505,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":489,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":219,"open_issues":489,"watchers":2505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4596"},"html":{"href":"https://github.com/cilium/cilium/pull/4596"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/4596"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/4596/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4596/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4596/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/4f3d64fcd1c343d2ba25d1e618ea15ae30b1a0c8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"houndci-bot"}}