{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/comments/235552846","pull_request_review_id":177446253,"id":235552846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU1Mjg0Ng==","diff_hunk":"@@ -60,6 +60,12 @@\n public abstract class X509Util {\n     private static final Logger LOG = LoggerFactory.getLogger(X509Util.class);\n \n+    static {\n+        // Client-initiated renegotiation in TLS is unsafe and\n+        // allows MITM attacks, so we should always disable it.\n+        System.setProperty(\"jdk.tls.rejectClientInitiatedRenegotiation\", \"true\");","path":"zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java","position":7,"original_position":7,"commit_id":"027d7d24912dc7a00d798a77196f83be06229755","original_commit_id":"027d7d24912dc7a00d798a77196f83be06229755","user":{"login":"ivmaykov","id":682290,"node_id":"MDQ6VXNlcjY4MjI5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/682290?v=4","gravatar_id":"","url":"https://api.github.com/users/ivmaykov","html_url":"https://github.com/ivmaykov","followers_url":"https://api.github.com/users/ivmaykov/followers","following_url":"https://api.github.com/users/ivmaykov/following{/other_user}","gists_url":"https://api.github.com/users/ivmaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmaykov/subscriptions","organizations_url":"https://api.github.com/users/ivmaykov/orgs","repos_url":"https://api.github.com/users/ivmaykov/repos","events_url":"https://api.github.com/users/ivmaykov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmaykov/received_events","type":"User","site_admin":false},"body":"Sure, will do","created_at":"2018-11-21T22:12:28Z","updated_at":"2018-11-21T22:12:28Z","html_url":"https://github.com/apache/zookeeper/pull/710#discussion_r235552846","pull_request_url":"https://api.github.com/repos/apache/zookeeper/pulls/710","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments/235552846"},"html":{"href":"https://github.com/apache/zookeeper/pull/710#discussion_r235552846"},"pull_request":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/710"}},"in_reply_to_id":235223996},"pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/710","id":232492807,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDkyODA3","html_url":"https://github.com/apache/zookeeper/pull/710","diff_url":"https://github.com/apache/zookeeper/pull/710.diff","patch_url":"https://github.com/apache/zookeeper/pull/710.patch","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/710","number":710,"state":"open","locked":false,"title":"ZOOKEEPER-3195: TLS - disable client-initiated renegotiation","user":{"login":"ivmaykov","id":682290,"node_id":"MDQ6VXNlcjY4MjI5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/682290?v=4","gravatar_id":"","url":"https://api.github.com/users/ivmaykov","html_url":"https://github.com/ivmaykov","followers_url":"https://api.github.com/users/ivmaykov/followers","following_url":"https://api.github.com/users/ivmaykov/following{/other_user}","gists_url":"https://api.github.com/users/ivmaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmaykov/subscriptions","organizations_url":"https://api.github.com/users/ivmaykov/orgs","repos_url":"https://api.github.com/users/ivmaykov/repos","events_url":"https://api.github.com/users/ivmaykov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmaykov/received_events","type":"User","site_admin":false},"body":"Summary: client-initiated renegotiation is insecure and is vulnerable to MITM attacks.\r\nUnfortunately, the feature is enabled in Java by default. This disables it.\r\nSee https://bugs.openjdk.java.net/browse/JDK-7188658 and\r\nhttps://www.oracle.com/technetwork/java/javase/documentation/tlsreadme-141115.html\r\n\r\nTest Plan: manually tested by running a secure ZK server and probing the listening port\r\nwith python's sslyze tool (using `sslyze --reneg ...`). Tested on Java 8, 9, 10, and 11.","created_at":"2018-11-20T23:32:43Z","updated_at":"2018-11-21T22:12:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5ff3133d998abce43ece0ced405e9e898e56769","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zookeeper/pulls/710/commits","review_comments_url":"https://api.github.com/repos/apache/zookeeper/pulls/710/comments","review_comment_url":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/710/comments","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/027d7d24912dc7a00d798a77196f83be06229755","head":{"label":"ivmaykov:ZOOKEEPER-3195","ref":"ZOOKEEPER-3195","sha":"027d7d24912dc7a00d798a77196f83be06229755","user":{"login":"ivmaykov","id":682290,"node_id":"MDQ6VXNlcjY4MjI5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/682290?v=4","gravatar_id":"","url":"https://api.github.com/users/ivmaykov","html_url":"https://github.com/ivmaykov","followers_url":"https://api.github.com/users/ivmaykov/followers","following_url":"https://api.github.com/users/ivmaykov/following{/other_user}","gists_url":"https://api.github.com/users/ivmaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmaykov/subscriptions","organizations_url":"https://api.github.com/users/ivmaykov/orgs","repos_url":"https://api.github.com/users/ivmaykov/repos","events_url":"https://api.github.com/users/ivmaykov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmaykov/received_events","type":"User","site_admin":false},"repo":{"id":148827460,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4Mjc0NjA=","name":"zookeeper","full_name":"ivmaykov/zookeeper","private":false,"owner":{"login":"ivmaykov","id":682290,"node_id":"MDQ6VXNlcjY4MjI5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/682290?v=4","gravatar_id":"","url":"https://api.github.com/users/ivmaykov","html_url":"https://github.com/ivmaykov","followers_url":"https://api.github.com/users/ivmaykov/followers","following_url":"https://api.github.com/users/ivmaykov/following{/other_user}","gists_url":"https://api.github.com/users/ivmaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmaykov/subscriptions","organizations_url":"https://api.github.com/users/ivmaykov/orgs","repos_url":"https://api.github.com/users/ivmaykov/repos","events_url":"https://api.github.com/users/ivmaykov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmaykov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivmaykov/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/ivmaykov/zookeeper","forks_url":"https://api.github.com/repos/ivmaykov/zookeeper/forks","keys_url":"https://api.github.com/repos/ivmaykov/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivmaykov/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivmaykov/zookeeper/teams","hooks_url":"https://api.github.com/repos/ivmaykov/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/ivmaykov/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/ivmaykov/zookeeper/events","assignees_url":"https://api.github.com/repos/ivmaykov/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/ivmaykov/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/ivmaykov/zookeeper/tags","blobs_url":"https://api.github.com/repos/ivmaykov/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivmaykov/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivmaykov/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivmaykov/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivmaykov/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/ivmaykov/zookeeper/languages","stargazers_url":"https://api.github.com/repos/ivmaykov/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/ivmaykov/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/ivmaykov/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/ivmaykov/zookeeper/subscription","commits_url":"https://api.github.com/repos/ivmaykov/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivmaykov/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivmaykov/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivmaykov/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivmaykov/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/ivmaykov/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivmaykov/zookeeper/merges","archive_url":"https://api.github.com/repos/ivmaykov/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivmaykov/zookeeper/downloads","issues_url":"https://api.github.com/repos/ivmaykov/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/ivmaykov/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/ivmaykov/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/ivmaykov/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivmaykov/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/ivmaykov/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/ivmaykov/zookeeper/deployments","created_at":"2018-09-14T18:30:52Z","updated_at":"2018-11-20T17:26:09Z","pushed_at":"2018-11-20T23:32:34Z","git_url":"git://github.com/ivmaykov/zookeeper.git","ssh_url":"git@github.com:ivmaykov/zookeeper.git","clone_url":"https://github.com/ivmaykov/zookeeper.git","svn_url":"https://github.com/ivmaykov/zookeeper","homepage":null,"size":108674,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"91460546a14c03d211d4126864c81a1b2dde2394","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":160999,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5OTk=","name":"zookeeper","full_name":"apache/zookeeper","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":false,"url":"https://api.github.com/repos/apache/zookeeper","forks_url":"https://api.github.com/repos/apache/zookeeper/forks","keys_url":"https://api.github.com/repos/apache/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zookeeper/teams","hooks_url":"https://api.github.com/repos/apache/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zookeeper/events","assignees_url":"https://api.github.com/repos/apache/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zookeeper/tags","blobs_url":"https://api.github.com/repos/apache/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zookeeper/languages","stargazers_url":"https://api.github.com/repos/apache/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/zookeeper/subscription","commits_url":"https://api.github.com/repos/apache/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zookeeper/merges","archive_url":"https://api.github.com/repos/apache/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zookeeper/downloads","issues_url":"https://api.github.com/repos/apache/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zookeeper/deployments","created_at":"2009-03-27T15:41:56Z","updated_at":"2018-11-21T18:30:38Z","pushed_at":"2018-11-21T21:33:12Z","git_url":"git://github.com/apache/zookeeper.git","ssh_url":"git@github.com:apache/zookeeper.git","clone_url":"https://github.com/apache/zookeeper.git","svn_url":"https://github.com/apache/zookeeper","homepage":null,"size":108897,"stargazers_count":5395,"watchers_count":5395,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3449,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3449,"open_issues":172,"watchers":5395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/710"},"html":{"href":"https://github.com/apache/zookeeper/pull/710"},"issue":{"href":"https://api.github.com/repos/apache/zookeeper/issues/710"},"comments":{"href":"https://api.github.com/repos/apache/zookeeper/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zookeeper/statuses/027d7d24912dc7a00d798a77196f83be06229755"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ivmaykov"}}