{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/comments/221263227","pull_request_review_id":159873037,"id":221263227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI2MzIyNw==","diff_hunk":"@@ -47,3 +47,10 @@ MathProgBase.loadproblem!(m, -obj, A, rowub, [(:NonNeg,1:3)],[(:NonNeg,1:5)])\n MathProgBase.setwarmstart!(m, primal_sol; dual_sol = dual_sol, slack = slack)\n MathProgBase.optimize!(m)\n @test isapprox(MathProgBase.getobjval(m), -99.0, atol=1e-10, rtol=0.0)\n+\n+# tests for incorrect options\n+s = SCSSolver(eps=1e-12, epps=1.0)\n+m = MathProgBase.ConicModel(s)\n+MathProgBase.loadproblem!(m, -obj, A, rowub, [(:NonNeg,1:3)],[(:NonNeg,1:5)])\n+\n+@test_throws ArgumentError MathProgBase.optimize!(m)","path":"test/options.jl","position":40,"original_position":10,"commit_id":"e2b1e70233def26db42564d2a9b0c1903a260a00","original_commit_id":"e2b1e70233def26db42564d2a9b0c1903a260a00","user":{"login":"mlubin","id":1733683,"node_id":"MDQ6VXNlcjE3MzM2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1733683?v=4","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"body":"Is there some way to test the text of the error message? That's pretty important in this case.","created_at":"2018-09-28T14:02:18Z","updated_at":"2018-09-28T14:02:19Z","html_url":"https://github.com/JuliaOpt/SCS.jl/pull/110#discussion_r221263227","pull_request_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/comments/221263227"},"html":{"href":"https://github.com/JuliaOpt/SCS.jl/pull/110#discussion_r221263227"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110","id":218167691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTY3Njkx","html_url":"https://github.com/JuliaOpt/SCS.jl/pull/110","diff_url":"https://github.com/JuliaOpt/SCS.jl/pull/110.diff","patch_url":"https://github.com/JuliaOpt/SCS.jl/pull/110.patch","issue_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/110","number":110,"state":"open","locked":false,"title":"Enh/options","user":{"login":"kalmarek","id":1666118,"node_id":"MDQ6VXNlcjE2NjYxMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1666118?v=4","gravatar_id":"","url":"https://api.github.com/users/kalmarek","html_url":"https://github.com/kalmarek","followers_url":"https://api.github.com/users/kalmarek/followers","following_url":"https://api.github.com/users/kalmarek/following{/other_user}","gists_url":"https://api.github.com/users/kalmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmarek/subscriptions","organizations_url":"https://api.github.com/users/kalmarek/orgs","repos_url":"https://api.github.com/users/kalmarek/repos","events_url":"https://api.github.com/users/kalmarek/events{/privacy}","received_events_url":"https://api.github.com/users/kalmarek/received_events","type":"User","site_admin":false},"body":"Would be great if someone could test it on the MOI side;\r\n\r\nI took a simple route of extracting the `Direct`/`Indirect` type from `options` in `optimize!` (as it was done in MPB), but that could be easily changed to `Optimizer` (and `SCSMathProgModel`) parametrized by the type\r\n\r\nEdit by mlubin@: Closes #94","created_at":"2018-09-26T01:58:11Z","updated_at":"2018-09-28T14:02:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80804900720f623c40d3cf41b7f8049eae9c3fa3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/110/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/statuses/e2b1e70233def26db42564d2a9b0c1903a260a00","head":{"label":"kalmarek:enh/options","ref":"enh/options","sha":"e2b1e70233def26db42564d2a9b0c1903a260a00","user":{"login":"kalmarek","id":1666118,"node_id":"MDQ6VXNlcjE2NjYxMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1666118?v=4","gravatar_id":"","url":"https://api.github.com/users/kalmarek","html_url":"https://github.com/kalmarek","followers_url":"https://api.github.com/users/kalmarek/followers","following_url":"https://api.github.com/users/kalmarek/following{/other_user}","gists_url":"https://api.github.com/users/kalmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmarek/subscriptions","organizations_url":"https://api.github.com/users/kalmarek/orgs","repos_url":"https://api.github.com/users/kalmarek/repos","events_url":"https://api.github.com/users/kalmarek/events{/privacy}","received_events_url":"https://api.github.com/users/kalmarek/received_events","type":"User","site_admin":false},"repo":{"id":83203554,"node_id":"MDEwOlJlcG9zaXRvcnk4MzIwMzU1NA==","name":"SCS.jl","full_name":"kalmarek/SCS.jl","private":false,"owner":{"login":"kalmarek","id":1666118,"node_id":"MDQ6VXNlcjE2NjYxMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1666118?v=4","gravatar_id":"","url":"https://api.github.com/users/kalmarek","html_url":"https://github.com/kalmarek","followers_url":"https://api.github.com/users/kalmarek/followers","following_url":"https://api.github.com/users/kalmarek/following{/other_user}","gists_url":"https://api.github.com/users/kalmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmarek/subscriptions","organizations_url":"https://api.github.com/users/kalmarek/orgs","repos_url":"https://api.github.com/users/kalmarek/repos","events_url":"https://api.github.com/users/kalmarek/events{/privacy}","received_events_url":"https://api.github.com/users/kalmarek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kalmarek/SCS.jl","description":"Julia Wrapper for SCS (https://github.com/cvxgrp/scs)","fork":true,"url":"https://api.github.com/repos/kalmarek/SCS.jl","forks_url":"https://api.github.com/repos/kalmarek/SCS.jl/forks","keys_url":"https://api.github.com/repos/kalmarek/SCS.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalmarek/SCS.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalmarek/SCS.jl/teams","hooks_url":"https://api.github.com/repos/kalmarek/SCS.jl/hooks","issue_events_url":"https://api.github.com/repos/kalmarek/SCS.jl/issues/events{/number}","events_url":"https://api.github.com/repos/kalmarek/SCS.jl/events","assignees_url":"https://api.github.com/repos/kalmarek/SCS.jl/assignees{/user}","branches_url":"https://api.github.com/repos/kalmarek/SCS.jl/branches{/branch}","tags_url":"https://api.github.com/repos/kalmarek/SCS.jl/tags","blobs_url":"https://api.github.com/repos/kalmarek/SCS.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalmarek/SCS.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalmarek/SCS.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalmarek/SCS.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalmarek/SCS.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/kalmarek/SCS.jl/languages","stargazers_url":"https://api.github.com/repos/kalmarek/SCS.jl/stargazers","contributors_url":"https://api.github.com/repos/kalmarek/SCS.jl/contributors","subscribers_url":"https://api.github.com/repos/kalmarek/SCS.jl/subscribers","subscription_url":"https://api.github.com/repos/kalmarek/SCS.jl/subscription","commits_url":"https://api.github.com/repos/kalmarek/SCS.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalmarek/SCS.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalmarek/SCS.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalmarek/SCS.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalmarek/SCS.jl/contents/{+path}","compare_url":"https://api.github.com/repos/kalmarek/SCS.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalmarek/SCS.jl/merges","archive_url":"https://api.github.com/repos/kalmarek/SCS.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalmarek/SCS.jl/downloads","issues_url":"https://api.github.com/repos/kalmarek/SCS.jl/issues{/number}","pulls_url":"https://api.github.com/repos/kalmarek/SCS.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/kalmarek/SCS.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/kalmarek/SCS.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalmarek/SCS.jl/labels{/name}","releases_url":"https://api.github.com/repos/kalmarek/SCS.jl/releases{/id}","deployments_url":"https://api.github.com/repos/kalmarek/SCS.jl/deployments","created_at":"2017-02-26T11:28:01Z","updated_at":"2017-02-26T11:28:02Z","pushed_at":"2018-09-28T09:59:57Z","git_url":"git://github.com/kalmarek/SCS.jl.git","ssh_url":"git@github.com:kalmarek/SCS.jl.git","clone_url":"https://github.com/kalmarek/SCS.jl.git","svn_url":"https://github.com/kalmarek/SCS.jl","homepage":"","size":525,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"d80fa11bd6b3cf2f377ab0df7e15f755fba89571","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":19882065,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg4MjA2NQ==","name":"SCS.jl","full_name":"JuliaOpt/SCS.jl","private":false,"owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaOpt/SCS.jl","description":"Julia Wrapper for SCS (https://github.com/cvxgrp/scs)","fork":false,"url":"https://api.github.com/repos/JuliaOpt/SCS.jl","forks_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/SCS.jl/deployments","created_at":"2014-05-17T08:20:14Z","updated_at":"2018-09-21T01:31:38Z","pushed_at":"2018-09-28T09:59:58Z","git_url":"git://github.com/JuliaOpt/SCS.jl.git","ssh_url":"git@github.com:JuliaOpt/SCS.jl.git","clone_url":"https://github.com/JuliaOpt/SCS.jl.git","svn_url":"https://github.com/JuliaOpt/SCS.jl","homepage":"","size":454,"stargazers_count":23,"watchers_count":23,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":9,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110"},"html":{"href":"https://github.com/JuliaOpt/SCS.jl/pull/110"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/110"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/SCS.jl/statuses/e2b1e70233def26db42564d2a9b0c1903a260a00"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mlubin"}}