{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55","id":229450523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDUwNTIz","html_url":"https://github.com/Exawind/nalu-wind/pull/55","diff_url":"https://github.com/Exawind/nalu-wind/pull/55.diff","patch_url":"https://github.com/Exawind/nalu-wind/pull/55.patch","issue_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/55","number":55,"state":"closed","locked":false,"title":"Fix 'partially overridden' warnings","user":{"login":"sayerhs","id":433480,"node_id":"MDQ6VXNlcjQzMzQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/433480?v=4","gravatar_id":"","url":"https://api.github.com/users/sayerhs","html_url":"https://github.com/sayerhs","followers_url":"https://api.github.com/users/sayerhs/followers","following_url":"https://api.github.com/users/sayerhs/following{/other_user}","gists_url":"https://api.github.com/users/sayerhs/gists{/gist_id}","starred_url":"https://api.github.com/users/sayerhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayerhs/subscriptions","organizations_url":"https://api.github.com/users/sayerhs/orgs","repos_url":"https://api.github.com/users/sayerhs/repos","events_url":"https://api.github.com/users/sayerhs/events{/privacy}","received_events_url":"https://api.github.com/users/sayerhs/received_events","type":"User","site_admin":false},"body":"This commit addresses the following warnings issued when compiling on GCC 7.2.0 and Cuda 9.x on ORNL SummitDev and SNL ascicgpu machines.\r\n\r\n```\r\nnalu-wind/include/master_element/MasterElement.h(180): warning: statement is unreachable\r\n\r\nnalu-wind/include/master_element/MasterElement.h(374): warning: overloaded\r\nvirtual function \"sierra::nalu::MasterElement::determinant\" is only partially\r\noverridden in class \"sierra::nalu::Tri2DSCV\"\r\n\r\nnalu-wind/include/user_functions/FlowPastCylinderTempAuxFunction.h(17): warning:\r\noverloaded virtual function \"sierra::nalu::AuxFunction::do_evaluate\" is only\r\npartially overridden in class \"sierra::nalu::FlowPastCylinderTempAuxFunction\"\r\n\r\nnalu-wind/include/kernel/ScalarMassElemKernel.h(30): warning: overloaded virtual function \"sierra::nalu::Kernel::execute\" is only partially overridden in class \"sierra::nalu::ScalarMassElemKernel<sierra::nalu::AlgTraitsHex8>\"\r\n          detected during:\r\n            instantiation of class \"sierra::nalu::ScalarMassElemKernel<AlgTraits> [with AlgTraits=sierra::nalu::AlgTraitsHex8]\"\r\n```","created_at":"2018-11-08T17:34:00Z","updated_at":"2018-11-08T19:02:16Z","closed_at":"2018-11-08T19:02:16Z","merged_at":"2018-11-08T19:02:16Z","merge_commit_sha":"7b570a61123644726079593788f8105a94c25b45","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rcknaus","id":11062437,"node_id":"MDQ6VXNlcjExMDYyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/11062437?v=4","gravatar_id":"","url":"https://api.github.com/users/rcknaus","html_url":"https://github.com/rcknaus","followers_url":"https://api.github.com/users/rcknaus/followers","following_url":"https://api.github.com/users/rcknaus/following{/other_user}","gists_url":"https://api.github.com/users/rcknaus/gists{/gist_id}","starred_url":"https://api.github.com/users/rcknaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcknaus/subscriptions","organizations_url":"https://api.github.com/users/rcknaus/orgs","repos_url":"https://api.github.com/users/rcknaus/repos","events_url":"https://api.github.com/users/rcknaus/events{/privacy}","received_events_url":"https://api.github.com/users/rcknaus/received_events","type":"User","site_admin":false},{"login":"alanw0","id":18755013,"node_id":"MDQ6VXNlcjE4NzU1MDEz","avatar_url":"https://avatars1.githubusercontent.com/u/18755013?v=4","gravatar_id":"","url":"https://api.github.com/users/alanw0","html_url":"https://github.com/alanw0","followers_url":"https://api.github.com/users/alanw0/followers","following_url":"https://api.github.com/users/alanw0/following{/other_user}","gists_url":"https://api.github.com/users/alanw0/gists{/gist_id}","starred_url":"https://api.github.com/users/alanw0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanw0/subscriptions","organizations_url":"https://api.github.com/users/alanw0/orgs","repos_url":"https://api.github.com/users/alanw0/repos","events_url":"https://api.github.com/users/alanw0/events{/privacy}","received_events_url":"https://api.github.com/users/alanw0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55/commits","review_comments_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55/comments","review_comment_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/55/comments","statuses_url":"https://api.github.com/repos/Exawind/nalu-wind/statuses/8a7af3e496d288dcae59870750396c2c27a94e25","head":{"label":"sayerhs:f/me_warnings","ref":"f/me_warnings","sha":"8a7af3e496d288dcae59870750396c2c27a94e25","user":{"login":"sayerhs","id":433480,"node_id":"MDQ6VXNlcjQzMzQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/433480?v=4","gravatar_id":"","url":"https://api.github.com/users/sayerhs","html_url":"https://github.com/sayerhs","followers_url":"https://api.github.com/users/sayerhs/followers","following_url":"https://api.github.com/users/sayerhs/following{/other_user}","gists_url":"https://api.github.com/users/sayerhs/gists{/gist_id}","starred_url":"https://api.github.com/users/sayerhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayerhs/subscriptions","organizations_url":"https://api.github.com/users/sayerhs/orgs","repos_url":"https://api.github.com/users/sayerhs/repos","events_url":"https://api.github.com/users/sayerhs/events{/privacy}","received_events_url":"https://api.github.com/users/sayerhs/received_events","type":"User","site_admin":false},"repo":{"id":133409943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0MDk5NDM=","name":"nalu-wind","full_name":"sayerhs/nalu-wind","private":false,"owner":{"login":"sayerhs","id":433480,"node_id":"MDQ6VXNlcjQzMzQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/433480?v=4","gravatar_id":"","url":"https://api.github.com/users/sayerhs","html_url":"https://github.com/sayerhs","followers_url":"https://api.github.com/users/sayerhs/followers","following_url":"https://api.github.com/users/sayerhs/following{/other_user}","gists_url":"https://api.github.com/users/sayerhs/gists{/gist_id}","starred_url":"https://api.github.com/users/sayerhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayerhs/subscriptions","organizations_url":"https://api.github.com/users/sayerhs/orgs","repos_url":"https://api.github.com/users/sayerhs/repos","events_url":"https://api.github.com/users/sayerhs/events{/privacy}","received_events_url":"https://api.github.com/users/sayerhs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sayerhs/nalu-wind","description":null,"fork":true,"url":"https://api.github.com/repos/sayerhs/nalu-wind","forks_url":"https://api.github.com/repos/sayerhs/nalu-wind/forks","keys_url":"https://api.github.com/repos/sayerhs/nalu-wind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sayerhs/nalu-wind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sayerhs/nalu-wind/teams","hooks_url":"https://api.github.com/repos/sayerhs/nalu-wind/hooks","issue_events_url":"https://api.github.com/repos/sayerhs/nalu-wind/issues/events{/number}","events_url":"https://api.github.com/repos/sayerhs/nalu-wind/events","assignees_url":"https://api.github.com/repos/sayerhs/nalu-wind/assignees{/user}","branches_url":"https://api.github.com/repos/sayerhs/nalu-wind/branches{/branch}","tags_url":"https://api.github.com/repos/sayerhs/nalu-wind/tags","blobs_url":"https://api.github.com/repos/sayerhs/nalu-wind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sayerhs/nalu-wind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sayerhs/nalu-wind/git/refs{/sha}","trees_url":"https://api.github.com/repos/sayerhs/nalu-wind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sayerhs/nalu-wind/statuses/{sha}","languages_url":"https://api.github.com/repos/sayerhs/nalu-wind/languages","stargazers_url":"https://api.github.com/repos/sayerhs/nalu-wind/stargazers","contributors_url":"https://api.github.com/repos/sayerhs/nalu-wind/contributors","subscribers_url":"https://api.github.com/repos/sayerhs/nalu-wind/subscribers","subscription_url":"https://api.github.com/repos/sayerhs/nalu-wind/subscription","commits_url":"https://api.github.com/repos/sayerhs/nalu-wind/commits{/sha}","git_commits_url":"https://api.github.com/repos/sayerhs/nalu-wind/git/commits{/sha}","comments_url":"https://api.github.com/repos/sayerhs/nalu-wind/comments{/number}","issue_comment_url":"https://api.github.com/repos/sayerhs/nalu-wind/issues/comments{/number}","contents_url":"https://api.github.com/repos/sayerhs/nalu-wind/contents/{+path}","compare_url":"https://api.github.com/repos/sayerhs/nalu-wind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sayerhs/nalu-wind/merges","archive_url":"https://api.github.com/repos/sayerhs/nalu-wind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sayerhs/nalu-wind/downloads","issues_url":"https://api.github.com/repos/sayerhs/nalu-wind/issues{/number}","pulls_url":"https://api.github.com/repos/sayerhs/nalu-wind/pulls{/number}","milestones_url":"https://api.github.com/repos/sayerhs/nalu-wind/milestones{/number}","notifications_url":"https://api.github.com/repos/sayerhs/nalu-wind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sayerhs/nalu-wind/labels{/name}","releases_url":"https://api.github.com/repos/sayerhs/nalu-wind/releases{/id}","deployments_url":"https://api.github.com/repos/sayerhs/nalu-wind/deployments","created_at":"2018-05-14T19:15:27Z","updated_at":"2018-05-14T19:15:32Z","pushed_at":"2018-11-08T19:01:22Z","git_url":"git://github.com/sayerhs/nalu-wind.git","ssh_url":"git@github.com:sayerhs/nalu-wind.git","clone_url":"https://github.com/sayerhs/nalu-wind.git","svn_url":"https://github.com/sayerhs/nalu-wind","homepage":null,"size":11958,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Exawind:master","ref":"master","sha":"6ec104de023fb46dded09e39fa63c076266139eb","user":{"login":"Exawind","id":22328575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzI4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/22328575?v=4","gravatar_id":"","url":"https://api.github.com/users/Exawind","html_url":"https://github.com/Exawind","followers_url":"https://api.github.com/users/Exawind/followers","following_url":"https://api.github.com/users/Exawind/following{/other_user}","gists_url":"https://api.github.com/users/Exawind/gists{/gist_id}","starred_url":"https://api.github.com/users/Exawind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exawind/subscriptions","organizations_url":"https://api.github.com/users/Exawind/orgs","repos_url":"https://api.github.com/users/Exawind/repos","events_url":"https://api.github.com/users/Exawind/events{/privacy}","received_events_url":"https://api.github.com/users/Exawind/received_events","type":"Organization","site_admin":false},"repo":{"id":132016365,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMTYzNjU=","name":"nalu-wind","full_name":"Exawind/nalu-wind","private":false,"owner":{"login":"Exawind","id":22328575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzI4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/22328575?v=4","gravatar_id":"","url":"https://api.github.com/users/Exawind","html_url":"https://github.com/Exawind","followers_url":"https://api.github.com/users/Exawind/followers","following_url":"https://api.github.com/users/Exawind/following{/other_user}","gists_url":"https://api.github.com/users/Exawind/gists{/gist_id}","starred_url":"https://api.github.com/users/Exawind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exawind/subscriptions","organizations_url":"https://api.github.com/users/Exawind/orgs","repos_url":"https://api.github.com/users/Exawind/repos","events_url":"https://api.github.com/users/Exawind/events{/privacy}","received_events_url":"https://api.github.com/users/Exawind/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Exawind/nalu-wind","description":"Wind energy focused variant of https://github.com/NaluCFD/Nalu","fork":false,"url":"https://api.github.com/repos/Exawind/nalu-wind","forks_url":"https://api.github.com/repos/Exawind/nalu-wind/forks","keys_url":"https://api.github.com/repos/Exawind/nalu-wind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exawind/nalu-wind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exawind/nalu-wind/teams","hooks_url":"https://api.github.com/repos/Exawind/nalu-wind/hooks","issue_events_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/events{/number}","events_url":"https://api.github.com/repos/Exawind/nalu-wind/events","assignees_url":"https://api.github.com/repos/Exawind/nalu-wind/assignees{/user}","branches_url":"https://api.github.com/repos/Exawind/nalu-wind/branches{/branch}","tags_url":"https://api.github.com/repos/Exawind/nalu-wind/tags","blobs_url":"https://api.github.com/repos/Exawind/nalu-wind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exawind/nalu-wind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exawind/nalu-wind/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exawind/nalu-wind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exawind/nalu-wind/statuses/{sha}","languages_url":"https://api.github.com/repos/Exawind/nalu-wind/languages","stargazers_url":"https://api.github.com/repos/Exawind/nalu-wind/stargazers","contributors_url":"https://api.github.com/repos/Exawind/nalu-wind/contributors","subscribers_url":"https://api.github.com/repos/Exawind/nalu-wind/subscribers","subscription_url":"https://api.github.com/repos/Exawind/nalu-wind/subscription","commits_url":"https://api.github.com/repos/Exawind/nalu-wind/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exawind/nalu-wind/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exawind/nalu-wind/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exawind/nalu-wind/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exawind/nalu-wind/contents/{+path}","compare_url":"https://api.github.com/repos/Exawind/nalu-wind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exawind/nalu-wind/merges","archive_url":"https://api.github.com/repos/Exawind/nalu-wind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exawind/nalu-wind/downloads","issues_url":"https://api.github.com/repos/Exawind/nalu-wind/issues{/number}","pulls_url":"https://api.github.com/repos/Exawind/nalu-wind/pulls{/number}","milestones_url":"https://api.github.com/repos/Exawind/nalu-wind/milestones{/number}","notifications_url":"https://api.github.com/repos/Exawind/nalu-wind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exawind/nalu-wind/labels{/name}","releases_url":"https://api.github.com/repos/Exawind/nalu-wind/releases{/id}","deployments_url":"https://api.github.com/repos/Exawind/nalu-wind/deployments","created_at":"2018-05-03T15:39:32Z","updated_at":"2018-11-08T18:21:57Z","pushed_at":"2018-11-08T19:02:16Z","git_url":"git://github.com/Exawind/nalu-wind.git","ssh_url":"git@github.com:Exawind/nalu-wind.git","clone_url":"https://github.com/Exawind/nalu-wind.git","svn_url":"https://github.com/Exawind/nalu-wind","homepage":"","size":11839,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55"},"html":{"href":"https://github.com/Exawind/nalu-wind/pull/55"},"issue":{"href":"https://api.github.com/repos/Exawind/nalu-wind/issues/55"},"comments":{"href":"https://api.github.com/repos/Exawind/nalu-wind/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exawind/nalu-wind/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/Exawind/nalu-wind/statuses/8a7af3e496d288dcae59870750396c2c27a94e25"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sayerhs","id":433480,"node_id":"MDQ6VXNlcjQzMzQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/433480?v=4","gravatar_id":"","url":"https://api.github.com/users/sayerhs","html_url":"https://github.com/sayerhs","followers_url":"https://api.github.com/users/sayerhs/followers","following_url":"https://api.github.com/users/sayerhs/following{/other_user}","gists_url":"https://api.github.com/users/sayerhs/gists{/gist_id}","starred_url":"https://api.github.com/users/sayerhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayerhs/subscriptions","organizations_url":"https://api.github.com/users/sayerhs/orgs","repos_url":"https://api.github.com/users/sayerhs/repos","events_url":"https://api.github.com/users/sayerhs/events{/privacy}","received_events_url":"https://api.github.com/users/sayerhs/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":177,"deletions":9,"changed_files":71}}
{"actor":{"display_login":"sayerhs"}}