{"action":"created","comment":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments/185553592","pull_request_review_id":116966272,"id":185553592,"diff_hunk":"@@ -2090,6 +2111,28 @@ set<string> &PlayerInfo::Collapsed(const string &name)\n \n \n \n+bool PlayerInfo::GetCached(const System *object, std::map<const System*, bool> &cache, bool (PlayerInfo::*func)(const System*) const) const\n+{\n+\tauto it = cache.find(object);\n+\tif (it == cache.end())\n+\t{\n+\t\tbool value = (this->*func)(object);\n+\t\tcache.insert(make_pair(object, value));","path":"source/PlayerInfo.cpp","position":null,"original_position":76,"commit_id":"533be408354150199be8fceed3f4d788c4e23e48","original_commit_id":"e71192ef585f1daa7a24482c40d7e1df04099c0f","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"body":"Wasn't aware of that C++11 addition. Fixed.","created_at":"2018-05-02T16:13:27Z","updated_at":"2018-05-02T16:13:27Z","html_url":"https://github.com/endless-sky/endless-sky/pull/3724#discussion_r185553592","pull_request_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments/185553592"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/3724#discussion_r185553592"},"pull_request":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724"}},"in_reply_to_id":185435409},"pull_request":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724","id":184837452,"html_url":"https://github.com/endless-sky/endless-sky/pull/3724","diff_url":"https://github.com/endless-sky/endless-sky/pull/3724.diff","patch_url":"https://github.com/endless-sky/endless-sky/pull/3724.patch","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3724","number":3724,"state":"open","locked":false,"title":"Optimize map rendering by caching frequently-calculated values","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"body":"This + #3720 + #3721 finally get my laptop much quieter and cooler on the map screen.","created_at":"2018-04-29T14:34:09Z","updated_at":"2018-05-02T16:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e479a21e253029ef1a5225e220a005c77edc79a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724/commits","review_comments_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724/comments","review_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3724/comments","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/533be408354150199be8fceed3f4d788c4e23e48","head":{"label":"CyberShadow:cache-seen-visited","ref":"cache-seen-visited","sha":"533be408354150199be8fceed3f4d788c4e23e48","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"repo":{"id":131442835,"name":"endless-sky","full_name":"CyberShadow/endless-sky","owner":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CyberShadow/endless-sky","description":"Space exploration, trading, and combat game.","fork":true,"url":"https://api.github.com/repos/CyberShadow/endless-sky","forks_url":"https://api.github.com/repos/CyberShadow/endless-sky/forks","keys_url":"https://api.github.com/repos/CyberShadow/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyberShadow/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyberShadow/endless-sky/teams","hooks_url":"https://api.github.com/repos/CyberShadow/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/CyberShadow/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/CyberShadow/endless-sky/events","assignees_url":"https://api.github.com/repos/CyberShadow/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/CyberShadow/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/CyberShadow/endless-sky/tags","blobs_url":"https://api.github.com/repos/CyberShadow/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyberShadow/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyberShadow/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyberShadow/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyberShadow/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/CyberShadow/endless-sky/languages","stargazers_url":"https://api.github.com/repos/CyberShadow/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/CyberShadow/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/CyberShadow/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/CyberShadow/endless-sky/subscription","commits_url":"https://api.github.com/repos/CyberShadow/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyberShadow/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyberShadow/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyberShadow/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyberShadow/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/CyberShadow/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyberShadow/endless-sky/merges","archive_url":"https://api.github.com/repos/CyberShadow/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyberShadow/endless-sky/downloads","issues_url":"https://api.github.com/repos/CyberShadow/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/CyberShadow/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/CyberShadow/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/CyberShadow/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyberShadow/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/CyberShadow/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/CyberShadow/endless-sky/deployments","created_at":"2018-04-28T20:43:12Z","updated_at":"2018-04-28T20:43:16Z","pushed_at":"2018-05-02T16:13:14Z","git_url":"git://github.com/CyberShadow/endless-sky.git","ssh_url":"git@github.com:CyberShadow/endless-sky.git","clone_url":"https://github.com/CyberShadow/endless-sky.git","svn_url":"https://github.com/CyberShadow/endless-sky","homepage":"http://endless-sky.github.io/","size":144051,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endless-sky:master","ref":"master","sha":"2068740c9fbfa01e0cb509c735f11cf19afed684","user":{"login":"endless-sky","id":11450262,"avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"repo":{"id":32231207,"name":"endless-sky","full_name":"endless-sky/endless-sky","owner":{"login":"endless-sky","id":11450262,"avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endless-sky/endless-sky","description":"Space exploration, trading, and combat game.","fork":false,"url":"https://api.github.com/repos/endless-sky/endless-sky","forks_url":"https://api.github.com/repos/endless-sky/endless-sky/forks","keys_url":"https://api.github.com/repos/endless-sky/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endless-sky/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endless-sky/endless-sky/teams","hooks_url":"https://api.github.com/repos/endless-sky/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/endless-sky/endless-sky/events","assignees_url":"https://api.github.com/repos/endless-sky/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/endless-sky/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/endless-sky/endless-sky/tags","blobs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endless-sky/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/endless-sky/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/endless-sky/endless-sky/languages","stargazers_url":"https://api.github.com/repos/endless-sky/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/endless-sky/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/endless-sky/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/endless-sky/endless-sky/subscription","commits_url":"https://api.github.com/repos/endless-sky/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/endless-sky/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/endless-sky/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/endless-sky/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endless-sky/endless-sky/merges","archive_url":"https://api.github.com/repos/endless-sky/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endless-sky/endless-sky/downloads","issues_url":"https://api.github.com/repos/endless-sky/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/endless-sky/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/endless-sky/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/endless-sky/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/endless-sky/endless-sky/deployments","created_at":"2015-03-14T20:44:39Z","updated_at":"2018-05-01T04:58:04Z","pushed_at":"2018-05-02T16:13:15Z","git_url":"git://github.com/endless-sky/endless-sky.git","ssh_url":"git@github.com:endless-sky/endless-sky.git","clone_url":"https://github.com/endless-sky/endless-sky.git","svn_url":"https://github.com/endless-sky/endless-sky","homepage":"http://endless-sky.github.io/","size":145238,"stargazers_count":1413,"watchers_count":1413,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":385,"mirror_url":null,"archived":false,"open_issues_count":519,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":385,"open_issues":519,"watchers":1413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/3724"},"issue":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/3724"},"comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/3724/comments"},"review_comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724/comments"},"review_comment":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3724/commits"},"statuses":{"href":"https://api.github.com/repos/endless-sky/endless-sky/statuses/533be408354150199be8fceed3f4d788c4e23e48"}},"author_association":"NONE"}}
{"actor":{"display_login":"CyberShadow"}}