{"action":"created","comment":{"url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/comments/187579811","pull_request_review_id":119390179,"id":187579811,"diff_hunk":"@@ -84,52 +70,51 @@ public function testRunAction()\n \n     public function testRunBasicUser()\n     {\n-        // cleanup\n-        $config = json_decode(file_get_contents(ROOT_PATH . 'tests/data/runBCP/config.json'), true);\n-        $config['parameters']['writer_class'] = 'MSSQL';\n-        $config['parameters']['db']['user'] = 'basicUser';\n-        $config['parameters']['db']['password'] = 'Abcdefg1234';\n-        $config['parameters']['db']['#password'] = 'Abcdefg1234';\n-        $config['parameters']['db']['collation'] = 'CZECH_CI_AS';\n-\n-        $this->cleanup($config);\n-        $this->initInputFiles('runBCP', $config);\n+        $config = $this->initConfig('runFull', function ($config) {\n+            $newValues = [\n+                'parameters' => [\n+                    'db' => [\n+                        'user' => [\n+                            'user' => 'basicUser',\n+                            'password' => 'Abcdefg1234',\n+                            '#password' => 'Abcdefg1234',\n+                            'collation' => 'CZECH_CI_AS',\n+                        ]\n+                    ]\n+                ]\n+            ];\n+\n+            return array_merge($newValues, $config);\n+        });\n \n-        // run entrypoint\n-        $process = new Process('php ' . ROOT_PATH . 'run.php --data=' . $this->tmpDataPath . '/runBCP 2>&1');\n-        $process->setTimeout(300);\n-        $process->run();\n+        $this->initInputFiles('runFull', $config);\n \n+        $process = $this->runApp();\n         $this->assertEquals(0, $process->getExitCode(), $process->getOutput());\n \n-        $expectedFilename = ROOT_PATH . 'tests/data/runBCP/in/tables/simple.csv';\n+        $expectedFilename = $this->testsDataPath . '/runFull/in/tables/simple.csv';\n         $resFilename = $this->writeCsvFromDB($config, 'simple');\n         $this->assertFileEquals($expectedFilename, $resFilename);\n \n-        $expectedFilename = ROOT_PATH . 'tests/data/runBCP/in/tables/special.csv';\n+        $expectedFilename = $this->testsDataPath . '/runFull/in/tables/special.csv';\n         $resFilename = $this->writeCsvFromDB($config, 'special');\n         $this->assertFileEquals($expectedFilename, $resFilename);\n     }\n \n-    public function testRunActionIncremental()\n+    public function testRunIncremental()\n     {\n-        $config = json_decode(\n-            file_get_contents(ROOT_PATH . 'tests/data/runActionIncremental/config_default.json'),\n-            true\n-        );\n+        $config = $this->initConfig('runIncremental', function ($config) {\n+            // shuffle columns in one table\n+            // @todo: remove, will be replaced with simple IM check","path":"tests/phpunit/Writer/MSSQLEntrypointTest.php","position":112,"original_position":112,"commit_id":"f5641de009ffe79fc43dbebd51ea8a9478c54ba4","original_commit_id":"f5641de009ffe79fc43dbebd51ea8a9478c54ba4","user":{"login":"MiroCillik","id":1488015,"avatar_url":"https://avatars1.githubusercontent.com/u/1488015?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroCillik","html_url":"https://github.com/MiroCillik","followers_url":"https://api.github.com/users/MiroCillik/followers","following_url":"https://api.github.com/users/MiroCillik/following{/other_user}","gists_url":"https://api.github.com/users/MiroCillik/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroCillik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroCillik/subscriptions","organizations_url":"https://api.github.com/users/MiroCillik/orgs","repos_url":"https://api.github.com/users/MiroCillik/repos","events_url":"https://api.github.com/users/MiroCillik/events{/privacy}","received_events_url":"https://api.github.com/users/MiroCillik/received_events","type":"User","site_admin":false},"body":"Plati to, ale mas pravdu, zalozim issue","created_at":"2018-05-11T10:36:51Z","updated_at":"2018-05-11T10:36:51Z","html_url":"https://github.com/keboola/db-writer-mssql/pull/26#discussion_r187579811","pull_request_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/comments/187579811"},"html":{"href":"https://github.com/keboola/db-writer-mssql/pull/26#discussion_r187579811"},"pull_request":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26"}},"in_reply_to_id":187576566},"pull_request":{"url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26","id":187188302,"html_url":"https://github.com/keboola/db-writer-mssql/pull/26","diff_url":"https://github.com/keboola/db-writer-mssql/pull/26.diff","patch_url":"https://github.com/keboola/db-writer-mssql/pull/26.patch","issue_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/26","number":26,"state":"open","locked":false,"title":"Tests refactoring","user":{"login":"MiroCillik","id":1488015,"avatar_url":"https://avatars1.githubusercontent.com/u/1488015?v=4","gravatar_id":"","url":"https://api.github.com/users/MiroCillik","html_url":"https://github.com/MiroCillik","followers_url":"https://api.github.com/users/MiroCillik/followers","following_url":"https://api.github.com/users/MiroCillik/following{/other_user}","gists_url":"https://api.github.com/users/MiroCillik/gists{/gist_id}","starred_url":"https://api.github.com/users/MiroCillik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiroCillik/subscriptions","organizations_url":"https://api.github.com/users/MiroCillik/orgs","repos_url":"https://api.github.com/users/MiroCillik/repos","events_url":"https://api.github.com/users/MiroCillik/events{/privacy}","received_events_url":"https://api.github.com/users/MiroCillik/received_events","type":"User","site_admin":false},"body":"Simplified, reduced duplicated code, removed ROOT_PATH constant.","created_at":"2018-05-10T13:10:15Z","updated_at":"2018-05-11T10:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf12124cd85fb529c3b68d82e075e83f231acf7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26/commits","review_comments_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26/comments","review_comment_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/26/comments","statuses_url":"https://api.github.com/repos/keboola/db-writer-mssql/statuses/f5641de009ffe79fc43dbebd51ea8a9478c54ba4","head":{"label":"keboola:miro-tests-refactor","ref":"miro-tests-refactor","sha":"f5641de009ffe79fc43dbebd51ea8a9478c54ba4","user":{"login":"keboola","id":1424387,"avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":67046010,"name":"db-writer-mssql","full_name":"keboola/db-writer-mssql","owner":{"login":"keboola","id":1424387,"avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keboola/db-writer-mssql","description":"SQL Server Database Writer","fork":false,"url":"https://api.github.com/repos/keboola/db-writer-mssql","forks_url":"https://api.github.com/repos/keboola/db-writer-mssql/forks","keys_url":"https://api.github.com/repos/keboola/db-writer-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/db-writer-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/db-writer-mssql/teams","hooks_url":"https://api.github.com/repos/keboola/db-writer-mssql/hooks","issue_events_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/db-writer-mssql/events","assignees_url":"https://api.github.com/repos/keboola/db-writer-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/db-writer-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/db-writer-mssql/tags","blobs_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/db-writer-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/db-writer-mssql/languages","stargazers_url":"https://api.github.com/repos/keboola/db-writer-mssql/stargazers","contributors_url":"https://api.github.com/repos/keboola/db-writer-mssql/contributors","subscribers_url":"https://api.github.com/repos/keboola/db-writer-mssql/subscribers","subscription_url":"https://api.github.com/repos/keboola/db-writer-mssql/subscription","commits_url":"https://api.github.com/repos/keboola/db-writer-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/db-writer-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/db-writer-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/db-writer-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/db-writer-mssql/merges","archive_url":"https://api.github.com/repos/keboola/db-writer-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/db-writer-mssql/downloads","issues_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/db-writer-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/db-writer-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/db-writer-mssql/labels{/name}","releases_url":"https://api.github.com/repos/keboola/db-writer-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/db-writer-mssql/deployments","created_at":"2016-08-31T14:41:58Z","updated_at":"2018-05-09T08:52:10Z","pushed_at":"2018-05-11T10:00:52Z","git_url":"git://github.com/keboola/db-writer-mssql.git","ssh_url":"git@github.com:keboola/db-writer-mssql.git","clone_url":"https://github.com/keboola/db-writer-mssql.git","svn_url":"https://github.com/keboola/db-writer-mssql","homepage":null,"size":245,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"keboola:master","ref":"master","sha":"446691453f9a5c464269d3c09494abbac3b85d98","user":{"login":"keboola","id":1424387,"avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":67046010,"name":"db-writer-mssql","full_name":"keboola/db-writer-mssql","owner":{"login":"keboola","id":1424387,"avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keboola/db-writer-mssql","description":"SQL Server Database Writer","fork":false,"url":"https://api.github.com/repos/keboola/db-writer-mssql","forks_url":"https://api.github.com/repos/keboola/db-writer-mssql/forks","keys_url":"https://api.github.com/repos/keboola/db-writer-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/db-writer-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/db-writer-mssql/teams","hooks_url":"https://api.github.com/repos/keboola/db-writer-mssql/hooks","issue_events_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/db-writer-mssql/events","assignees_url":"https://api.github.com/repos/keboola/db-writer-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/db-writer-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/db-writer-mssql/tags","blobs_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/db-writer-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/db-writer-mssql/languages","stargazers_url":"https://api.github.com/repos/keboola/db-writer-mssql/stargazers","contributors_url":"https://api.github.com/repos/keboola/db-writer-mssql/contributors","subscribers_url":"https://api.github.com/repos/keboola/db-writer-mssql/subscribers","subscription_url":"https://api.github.com/repos/keboola/db-writer-mssql/subscription","commits_url":"https://api.github.com/repos/keboola/db-writer-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/db-writer-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/db-writer-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/db-writer-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/db-writer-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/db-writer-mssql/merges","archive_url":"https://api.github.com/repos/keboola/db-writer-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/db-writer-mssql/downloads","issues_url":"https://api.github.com/repos/keboola/db-writer-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/db-writer-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/db-writer-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/db-writer-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/db-writer-mssql/labels{/name}","releases_url":"https://api.github.com/repos/keboola/db-writer-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/db-writer-mssql/deployments","created_at":"2016-08-31T14:41:58Z","updated_at":"2018-05-09T08:52:10Z","pushed_at":"2018-05-11T10:00:52Z","git_url":"git://github.com/keboola/db-writer-mssql.git","ssh_url":"git@github.com:keboola/db-writer-mssql.git","clone_url":"https://github.com/keboola/db-writer-mssql.git","svn_url":"https://github.com/keboola/db-writer-mssql","homepage":null,"size":245,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26"},"html":{"href":"https://github.com/keboola/db-writer-mssql/pull/26"},"issue":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/issues/26"},"comments":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/keboola/db-writer-mssql/statuses/f5641de009ffe79fc43dbebd51ea8a9478c54ba4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"MiroCillik"}}