{"action":"closed","number":4266,"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/4266","id":230311525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzExNTI1","html_url":"https://github.com/dotnet/project-system/pull/4266","diff_url":"https://github.com/dotnet/project-system/pull/4266.diff","patch_url":"https://github.com/dotnet/project-system/pull/4266.patch","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/4266","number":4266,"state":"closed","locked":false,"title":"Implement RunCodeAnalysis property to prevent watsons","user":{"login":"davidwengier","id":754264,"node_id":"MDQ6VXNlcjc1NDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/754264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwengier","html_url":"https://github.com/davidwengier","followers_url":"https://api.github.com/users/davidwengier/followers","following_url":"https://api.github.com/users/davidwengier/following{/other_user}","gists_url":"https://api.github.com/users/davidwengier/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwengier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwengier/subscriptions","organizations_url":"https://api.github.com/users/davidwengier/orgs","repos_url":"https://api.github.com/users/davidwengier/repos","events_url":"https://api.github.com/users/davidwengier/events{/privacy}","received_events_url":"https://api.github.com/users/davidwengier/received_events","type":"User","site_admin":false},"body":"Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/680205\r\n\r\nThis at least solves the 99% case of this property always being hit for SDK projects and correctly handles returning false for the empty string default value. In testing even when RunCodeAnalysis is specifically set to true, none of the other CodeAnalysis* properties are hit.","created_at":"2018-11-13T00:34:04Z","updated_at":"2018-11-19T08:36:19Z","closed_at":"2018-11-19T08:36:19Z","merged_at":"2018-11-19T08:36:19Z","merge_commit_sha":"c2989aae78a6d26167ab8476f6ef5345ff934b51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/project-system/pulls/4266/commits","review_comments_url":"https://api.github.com/repos/dotnet/project-system/pulls/4266/comments","review_comment_url":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/4266/comments","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/d793f447666d07b0068c0e1c5b18c46ed69ff483","head":{"label":"davidwengier:ImplementRunCodeAnalysis","ref":"ImplementRunCodeAnalysis","sha":"d793f447666d07b0068c0e1c5b18c46ed69ff483","user":{"login":"davidwengier","id":754264,"node_id":"MDQ6VXNlcjc1NDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/754264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwengier","html_url":"https://github.com/davidwengier","followers_url":"https://api.github.com/users/davidwengier/followers","following_url":"https://api.github.com/users/davidwengier/following{/other_user}","gists_url":"https://api.github.com/users/davidwengier/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwengier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwengier/subscriptions","organizations_url":"https://api.github.com/users/davidwengier/orgs","repos_url":"https://api.github.com/users/davidwengier/repos","events_url":"https://api.github.com/users/davidwengier/events{/privacy}","received_events_url":"https://api.github.com/users/davidwengier/received_events","type":"User","site_admin":false},"repo":{"id":147134940,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMzQ5NDA=","name":"project-system","full_name":"davidwengier/project-system","private":false,"owner":{"login":"davidwengier","id":754264,"node_id":"MDQ6VXNlcjc1NDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/754264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwengier","html_url":"https://github.com/davidwengier","followers_url":"https://api.github.com/users/davidwengier/followers","following_url":"https://api.github.com/users/davidwengier/following{/other_user}","gists_url":"https://api.github.com/users/davidwengier/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwengier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwengier/subscriptions","organizations_url":"https://api.github.com/users/davidwengier/orgs","repos_url":"https://api.github.com/users/davidwengier/repos","events_url":"https://api.github.com/users/davidwengier/events{/privacy}","received_events_url":"https://api.github.com/users/davidwengier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidwengier/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":true,"url":"https://api.github.com/repos/davidwengier/project-system","forks_url":"https://api.github.com/repos/davidwengier/project-system/forks","keys_url":"https://api.github.com/repos/davidwengier/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidwengier/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidwengier/project-system/teams","hooks_url":"https://api.github.com/repos/davidwengier/project-system/hooks","issue_events_url":"https://api.github.com/repos/davidwengier/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/davidwengier/project-system/events","assignees_url":"https://api.github.com/repos/davidwengier/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/davidwengier/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/davidwengier/project-system/tags","blobs_url":"https://api.github.com/repos/davidwengier/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidwengier/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidwengier/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidwengier/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidwengier/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/davidwengier/project-system/languages","stargazers_url":"https://api.github.com/repos/davidwengier/project-system/stargazers","contributors_url":"https://api.github.com/repos/davidwengier/project-system/contributors","subscribers_url":"https://api.github.com/repos/davidwengier/project-system/subscribers","subscription_url":"https://api.github.com/repos/davidwengier/project-system/subscription","commits_url":"https://api.github.com/repos/davidwengier/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidwengier/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidwengier/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidwengier/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidwengier/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/davidwengier/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidwengier/project-system/merges","archive_url":"https://api.github.com/repos/davidwengier/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidwengier/project-system/downloads","issues_url":"https://api.github.com/repos/davidwengier/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/davidwengier/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/davidwengier/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/davidwengier/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidwengier/project-system/labels{/name}","releases_url":"https://api.github.com/repos/davidwengier/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/davidwengier/project-system/deployments","created_at":"2018-09-03T01:07:57Z","updated_at":"2018-11-08T01:02:08Z","pushed_at":"2018-11-19T06:43:54Z","git_url":"git://github.com/davidwengier/project-system.git","ssh_url":"git@github.com:davidwengier/project-system.git","clone_url":"https://github.com/davidwengier/project-system.git","svn_url":"https://github.com/davidwengier/project-system","homepage":"","size":22182,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"00186ba1e36e902662d8b08fbdfa1f67bb239d7e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"node_id":"MDEwOlJlcG9zaXRvcnk1Njc0MDI3NQ==","name":"project-system","full_name":"dotnet/project-system","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":false,"url":"https://api.github.com/repos/dotnet/project-system","forks_url":"https://api.github.com/repos/dotnet/project-system/forks","keys_url":"https://api.github.com/repos/dotnet/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/project-system/events","assignees_url":"https://api.github.com/repos/dotnet/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/project-system/merges","archive_url":"https://api.github.com/repos/dotnet/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2018-11-18T22:50:52Z","pushed_at":"2018-11-19T08:36:19Z","git_url":"git://github.com/dotnet/project-system.git","ssh_url":"git@github.com:dotnet/project-system.git","clone_url":"https://github.com/dotnet/project-system.git","svn_url":"https://github.com/dotnet/project-system","homepage":"","size":22239,"stargazers_count":443,"watchers_count":443,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":598,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":144,"open_issues":598,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4266"},"html":{"href":"https://github.com/dotnet/project-system/pull/4266"},"issue":{"href":"https://api.github.com/repos/dotnet/project-system/issues/4266"},"comments":{"href":"https://api.github.com/repos/dotnet/project-system/issues/4266/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4266/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4266/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/project-system/statuses/d793f447666d07b0068c0e1c5b18c46ed69ff483"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davidwengier","id":754264,"node_id":"MDQ6VXNlcjc1NDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/754264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwengier","html_url":"https://github.com/davidwengier","followers_url":"https://api.github.com/users/davidwengier/followers","following_url":"https://api.github.com/users/davidwengier/following{/other_user}","gists_url":"https://api.github.com/users/davidwengier/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwengier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwengier/subscriptions","organizations_url":"https://api.github.com/users/davidwengier/orgs","repos_url":"https://api.github.com/users/davidwengier/repos","events_url":"https://api.github.com/users/davidwengier/events{/privacy}","received_events_url":"https://api.github.com/users/davidwengier/received_events","type":"User","site_admin":false},"comments":2,"review_comments":7,"maintainer_can_modify":false,"commits":3,"additions":22,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"davidwengier"}}