{"action":"created","issue":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/310","repository_url":"https://api.github.com/repos/KiCad/kicad-symbols","labels_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/310/comments","events_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/310/events","html_url":"https://github.com/KiCad/kicad-symbols/pull/310","id":297967472,"number":310,"title":"Connector_Specialized.lib -> Connector.lib, add Wuerth 7499151120","user":{"login":"evanshultz","id":1936989,"avatar_url":"https://avatars0.githubusercontent.com/u/1936989?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshultz","html_url":"https://github.com/evanshultz","followers_url":"https://api.github.com/users/evanshultz/followers","following_url":"https://api.github.com/users/evanshultz/following{/other_user}","gists_url":"https://api.github.com/users/evanshultz/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshultz/subscriptions","organizations_url":"https://api.github.com/users/evanshultz/orgs","repos_url":"https://api.github.com/users/evanshultz/repos","events_url":"https://api.github.com/users/evanshultz/events{/privacy}","received_events_url":"https://api.github.com/users/evanshultz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-02-17T01:40:26Z","updated_at":"2018-04-13T09:45:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/pulls/310","html_url":"https://github.com/KiCad/kicad-symbols/pull/310","diff_url":"https://github.com/KiCad/kicad-symbols/pull/310.diff","patch_url":"https://github.com/KiCad/kicad-symbols/pull/310.patch"},"body":"Both items mentioned at https://github.com/KiCad/kicad-symbols/issues/301.\r\n\r\nNotes:\r\n- I made a lot of fixes to this library, but many KLC violations still remain.\r\n- Several new XLR symbols and a renaming of the audio jack symbols are for the audio footprints I mentioned at https://github.com/KiCad/kicad-footprints/issues/191.\r\n- The AudioJack symbols use \"_Ground\" if the sleeve is grounded and \"_Switch\" if the poles are switched (normalling jack).\r\n- Some of the XLR pins use the Neutrik nomenclature for G (ground) and N/NC/NO for the switch. We've been discussing using letters as a short abbreviation for pin numbers elsewhere so this is up for debate.\r\n- The two existing RJ45 jacks have no manufacturer information I can see. Should I remove them? Can anyone identify the vendor and MPN?\r\n- I chose pin names that follow the datasheet, using 1-14 and appending D or U for DOWN or UP.\r\n- The housing pins are named SH, in accordance with out latest plan (I believe).\r\n\r\nDatasheet: http://katalog.we-online.de/pbs/datasheet/7499151120.pdf\r\n\r\nImage:\r\n![image](https://user-images.githubusercontent.com/1936989/36336780-d52b7282-133f-11e8-9cbf-4f47796600cf.png)\r\n\r\n------------\r\nThanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:\r\n\r\n- [ ] Provide a URL to a datasheet for the symbol(s) you are contributing\r\n- [ ] An example screenshot image is very helpful\r\n- [ ] Ensure that the associated footprints match the [official footprint library](https://github.com/kicad/kicad-footprints)\r\n- [ ] If there are matching footprint PRs, provide link(s) as appropriate\r\n- [ ] Check the output of the Travis automated check scripts - fix any errors as required\r\n"},"comment":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/comments/381084282","html_url":"https://github.com/KiCad/kicad-symbols/pull/310#issuecomment-381084282","issue_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/310","id":381084282,"user":{"login":"poeschlr","id":18327350,"avatar_url":"https://avatars0.githubusercontent.com/u/18327350?v=4","gravatar_id":"","url":"https://api.github.com/users/poeschlr","html_url":"https://github.com/poeschlr","followers_url":"https://api.github.com/users/poeschlr/followers","following_url":"https://api.github.com/users/poeschlr/following{/other_user}","gists_url":"https://api.github.com/users/poeschlr/gists{/gist_id}","starred_url":"https://api.github.com/users/poeschlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poeschlr/subscriptions","organizations_url":"https://api.github.com/users/poeschlr/orgs","repos_url":"https://api.github.com/users/poeschlr/repos","events_url":"https://api.github.com/users/poeschlr/events{/privacy}","received_events_url":"https://api.github.com/users/poeschlr/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T09:45:52Z","updated_at":"2018-04-13T09:45:52Z","author_association":"CONTRIBUTOR","body":"The main reason for our problem is that you do not use atomic commits. You mixed up changing the lib name plus some other things. This makes it hard for git to follow what is happening. (And it reduces the tools available to fix the resulting problems.)\r\n\r\n---\r\n\r\nThe best (least amount of work) option would have been that you take the branch i created **before** making further changes to it. (easiest option would have been to simply copy the file from my branch into yours and checking what changed there. Yes it would have been dirty but this is already the case anyways.)\r\n\r\nSimply merging this and deleting connector_specialized later would mean we loose data. (Two rather large PRs are not present in your connector lib)\r\n\r\nAs you continued without thinking about how this can be merged nicely it will again require a lot of manual work. At the earliest i have time for that at the start of next week.\r\n\r\n---\r\n\r\nI will not merge a PR that results in two libs that are different stages of the same lib. (This will confuse users. And it will set a precedence that something like that is accepted.)"}}
{"actor":{"display_login":"poeschlr"}}