{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/203522075","pull_request_review_id":138427727,"id":203522075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzUyMjA3NQ==","diff_hunk":"@@ -87,7 +87,7 @@ For 2.1, a given framework can only depend upon another single framework. An app\n \n Each framework has its own roll-forward semantics. This means ASP.NET can roll-forward independently of NETCore.App even though ASP.NET depends upon the NETCore.App framework.\n \n-NETCore.App in 2.0 has its own deps.json file in its own folder that lists its assemblies. In 2.1, other frameworks will also have their own deps.jon. In addition, each framework has an optional runtimeconfig.json that describes its framework dependency including optional setting overrides (applyPatches, preReleaseRollForward, rollForwardOnNoCandidateFx). If the runtimeconfig.json file does not exist, or does not have a value for a setting, it uses the value from the higher-level runtimeconfig.json.\n+NETCore.App in 2.0 has its own deps.json file in its own folder that lists its assemblies. In 2.1, other frameworks will also have their own deps.jon. In addition, each framework has an optional runtimeconfig.json that describes its framework dependency including optional setting overrides (applyPatches, rollForwardOnNoCandidateFx). If the runtimeconfig.json file does not exist, or does not have a value for a setting, it uses the values from the app's runtimeconfig.json or from environment variables.","path":"Documentation/design-docs/multilevel-sharedfx-lookup.md","position":14,"original_position":14,"commit_id":"565579acaf64ff834e8ec9179dd2f6484f4f2b14","original_commit_id":"565579acaf64ff834e8ec9179dd2f6484f4f2b14","user":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"body":"Nit: typo \"also have their own deps.jon\"","created_at":"2018-07-18T20:41:15Z","updated_at":"2018-07-18T20:41:30Z","html_url":"https://github.com/dotnet/core-setup/pull/4374#discussion_r203522075","pull_request_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4374","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/203522075"},"html":{"href":"https://github.com/dotnet/core-setup/pull/4374#discussion_r203522075"},"pull_request":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4374"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/4374","id":202069630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDY5NjMw","html_url":"https://github.com/dotnet/core-setup/pull/4374","diff_url":"https://github.com/dotnet/core-setup/pull/4374.diff","patch_url":"https://github.com/dotnet/core-setup/pull/4374.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/4374","number":4374,"state":"open","locked":false,"title":"Add section for multiple framework references","user":{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"Requesting feedback for this feature","created_at":"2018-07-17T21:05:27Z","updated_at":"2018-07-18T20:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1f159cbbbe979ceb558d4fdc7aa4e15ae428aa4","assignee":{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":802052213,"node_id":"MDU6TGFiZWw4MDIwNTIyMTM=","url":"https://api.github.com/repos/dotnet/core-setup/labels/documentation","name":"documentation","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4374/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/4374/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/4374/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/565579acaf64ff834e8ec9179dd2f6484f4f2b14","head":{"label":"steveharter:MultipleFxRefDoc","ref":"MultipleFxRefDoc","sha":"565579acaf64ff834e8ec9179dd2f6484f4f2b14","user":{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"repo":{"id":92880099,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg4MDA5OQ==","name":"core-setup","full_name":"steveharter/core-setup","owner":{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveharter/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/steveharter/core-setup","forks_url":"https://api.github.com/repos/steveharter/core-setup/forks","keys_url":"https://api.github.com/repos/steveharter/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveharter/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveharter/core-setup/teams","hooks_url":"https://api.github.com/repos/steveharter/core-setup/hooks","issue_events_url":"https://api.github.com/repos/steveharter/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/steveharter/core-setup/events","assignees_url":"https://api.github.com/repos/steveharter/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/steveharter/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/steveharter/core-setup/tags","blobs_url":"https://api.github.com/repos/steveharter/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveharter/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveharter/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveharter/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveharter/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/steveharter/core-setup/languages","stargazers_url":"https://api.github.com/repos/steveharter/core-setup/stargazers","contributors_url":"https://api.github.com/repos/steveharter/core-setup/contributors","subscribers_url":"https://api.github.com/repos/steveharter/core-setup/subscribers","subscription_url":"https://api.github.com/repos/steveharter/core-setup/subscription","commits_url":"https://api.github.com/repos/steveharter/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveharter/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveharter/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveharter/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveharter/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/steveharter/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveharter/core-setup/merges","archive_url":"https://api.github.com/repos/steveharter/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveharter/core-setup/downloads","issues_url":"https://api.github.com/repos/steveharter/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/steveharter/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/steveharter/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/steveharter/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveharter/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/steveharter/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/steveharter/core-setup/deployments","created_at":"2017-05-30T22:02:54Z","updated_at":"2018-07-03T14:58:45Z","pushed_at":"2018-07-18T20:03:54Z","git_url":"git://github.com/steveharter/core-setup.git","ssh_url":"git@github.com:steveharter/core-setup.git","clone_url":"https://github.com/steveharter/core-setup.git","svn_url":"https://github.com/steveharter/core-setup","homepage":"","size":5770,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8221d91a11ca51c08c40211b4e3b9242cada2d60","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI0OTE5Ng==","name":"core-setup","full_name":"dotnet/core-setup","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2018-07-18T14:58:48Z","pushed_at":"2018-07-18T19:40:05Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"git@github.com:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":6337,"stargazers_count":216,"watchers_count":216,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":143,"open_issues":172,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4374"},"html":{"href":"https://github.com/dotnet/core-setup/pull/4374"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4374"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/4374/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4374/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/4374/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/565579acaf64ff834e8ec9179dd2f6484f4f2b14"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vitek-karas"}}