{"action":"created","comment":{"url":"https://api.github.com/repos/creditkarma/Mimic/pulls/comments/238451761","pull_request_review_id":180997793,"id":238451761,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ1MTc2MQ==","diff_hunk":"@@ -264,9 +265,12 @@ export class ThriftProvider extends EventEmitter implements IServiceProvider, IC\n         });\n       } else {\n         const { data, exception } = this.respManager.find(id)[func.name] || {\n-          data: generateThriftResponse(func.returnTypeId, def, func.returnType, func.returnExtra),\n+          data: new Thrift.TApplicationException(\n+            Thrift.TApplicationExceptionType.MISSING_RESULT,\n+            `Mimic: no method found named:${func.name}`),","path":"packages/mimic-thrift/src/provider.ts","position":15,"original_position":15,"commit_id":"cfe4872448944ad40c201b1a848868a5d25a5a14","original_commit_id":"cfe4872448944ad40c201b1a848868a5d25a5a14","user":{"login":"kevin-gary-ck","id":38294517,"node_id":"MDQ6VXNlcjM4Mjk0NTE3","avatar_url":"https://avatars3.githubusercontent.com/u/38294517?v=4","gravatar_id":"","url":"https://api.github.com/users/kevin-gary-ck","html_url":"https://github.com/kevin-gary-ck","followers_url":"https://api.github.com/users/kevin-gary-ck/followers","following_url":"https://api.github.com/users/kevin-gary-ck/following{/other_user}","gists_url":"https://api.github.com/users/kevin-gary-ck/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-gary-ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-gary-ck/subscriptions","organizations_url":"https://api.github.com/users/kevin-gary-ck/orgs","repos_url":"https://api.github.com/users/kevin-gary-ck/repos","events_url":"https://api.github.com/users/kevin-gary-ck/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-gary-ck/received_events","type":"User","site_admin":false},"body":"could add a space between `named:` and `${func.name}` but nbd","created_at":"2018-12-03T21:52:46Z","updated_at":"2018-12-03T21:52:56Z","html_url":"https://github.com/creditkarma/Mimic/pull/17#discussion_r238451761","pull_request_url":"https://api.github.com/repos/creditkarma/Mimic/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/comments/238451761"},"html":{"href":"https://github.com/creditkarma/Mimic/pull/17#discussion_r238451761"},"pull_request":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/creditkarma/Mimic/pulls/17","id":234508002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTA4MDAy","html_url":"https://github.com/creditkarma/Mimic/pull/17","diff_url":"https://github.com/creditkarma/Mimic/pull/17.diff","patch_url":"https://github.com/creditkarma/Mimic/pull/17.patch","issue_url":"https://api.github.com/repos/creditkarma/Mimic/issues/17","number":17,"state":"open","locked":false,"title":"Returns exception when mimic response is not found.","user":{"login":"john-twigg-ck","id":26441261,"node_id":"MDQ6VXNlcjI2NDQxMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/26441261?v=4","gravatar_id":"","url":"https://api.github.com/users/john-twigg-ck","html_url":"https://github.com/john-twigg-ck","followers_url":"https://api.github.com/users/john-twigg-ck/followers","following_url":"https://api.github.com/users/john-twigg-ck/following{/other_user}","gists_url":"https://api.github.com/users/john-twigg-ck/gists{/gist_id}","starred_url":"https://api.github.com/users/john-twigg-ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-twigg-ck/subscriptions","organizations_url":"https://api.github.com/users/john-twigg-ck/orgs","repos_url":"https://api.github.com/users/john-twigg-ck/repos","events_url":"https://api.github.com/users/john-twigg-ck/events{/privacy}","received_events_url":"https://api.github.com/users/john-twigg-ck/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nThe behavior has been altered to raise an exception when a call to an unregistered method is placed to a mimic service.\r\n\r\nThis is a change in the behavior previously where mimic would auto generate a random response for any unregistered method calls.\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nIt was not possible to test the failure path where the Thrift IDL did not explicitly declare an exception, since you could not \r\na) Return an exception\r\nb) Mimic auto generate a successful response for you.\r\n\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\nManually tested that it returns exceptions.\r\n\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\nI've tested the a mixture of \r\na) registered methods\r\nb) registered exceptions\r\nc) unregistered methods\r\nall respond as expected.\r\n\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [X] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ X] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2018-11-29T04:48:13Z","updated_at":"2018-12-03T21:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b631018ceb4335537a9fb0912d2abba5faf02b6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"volodymyr-ladnik-ck","id":29311929,"node_id":"MDQ6VXNlcjI5MzExOTI5","avatar_url":"https://avatars1.githubusercontent.com/u/29311929?v=4","gravatar_id":"","url":"https://api.github.com/users/volodymyr-ladnik-ck","html_url":"https://github.com/volodymyr-ladnik-ck","followers_url":"https://api.github.com/users/volodymyr-ladnik-ck/followers","following_url":"https://api.github.com/users/volodymyr-ladnik-ck/following{/other_user}","gists_url":"https://api.github.com/users/volodymyr-ladnik-ck/gists{/gist_id}","starred_url":"https://api.github.com/users/volodymyr-ladnik-ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volodymyr-ladnik-ck/subscriptions","organizations_url":"https://api.github.com/users/volodymyr-ladnik-ck/orgs","repos_url":"https://api.github.com/users/volodymyr-ladnik-ck/repos","events_url":"https://api.github.com/users/volodymyr-ladnik-ck/events{/privacy}","received_events_url":"https://api.github.com/users/volodymyr-ladnik-ck/received_events","type":"User","site_admin":false},{"login":"Jeremy-Unruh-CK","id":35185058,"node_id":"MDQ6VXNlcjM1MTg1MDU4","avatar_url":"https://avatars2.githubusercontent.com/u/35185058?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeremy-Unruh-CK","html_url":"https://github.com/Jeremy-Unruh-CK","followers_url":"https://api.github.com/users/Jeremy-Unruh-CK/followers","following_url":"https://api.github.com/users/Jeremy-Unruh-CK/following{/other_user}","gists_url":"https://api.github.com/users/Jeremy-Unruh-CK/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremy-Unruh-CK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremy-Unruh-CK/subscriptions","organizations_url":"https://api.github.com/users/Jeremy-Unruh-CK/orgs","repos_url":"https://api.github.com/users/Jeremy-Unruh-CK/repos","events_url":"https://api.github.com/users/Jeremy-Unruh-CK/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremy-Unruh-CK/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/creditkarma/Mimic/pulls/17/commits","review_comments_url":"https://api.github.com/repos/creditkarma/Mimic/pulls/17/comments","review_comment_url":"https://api.github.com/repos/creditkarma/Mimic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/creditkarma/Mimic/issues/17/comments","statuses_url":"https://api.github.com/repos/creditkarma/Mimic/statuses/cfe4872448944ad40c201b1a848868a5d25a5a14","head":{"label":"creditkarma:john/ReturnException","ref":"john/ReturnException","sha":"cfe4872448944ad40c201b1a848868a5d25a5a14","user":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"repo":{"id":150152643,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNTI2NDM=","name":"Mimic","full_name":"creditkarma/Mimic","private":false,"owner":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/creditkarma/Mimic","description":"Mimic Service Impersonator","fork":false,"url":"https://api.github.com/repos/creditkarma/Mimic","forks_url":"https://api.github.com/repos/creditkarma/Mimic/forks","keys_url":"https://api.github.com/repos/creditkarma/Mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creditkarma/Mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creditkarma/Mimic/teams","hooks_url":"https://api.github.com/repos/creditkarma/Mimic/hooks","issue_events_url":"https://api.github.com/repos/creditkarma/Mimic/issues/events{/number}","events_url":"https://api.github.com/repos/creditkarma/Mimic/events","assignees_url":"https://api.github.com/repos/creditkarma/Mimic/assignees{/user}","branches_url":"https://api.github.com/repos/creditkarma/Mimic/branches{/branch}","tags_url":"https://api.github.com/repos/creditkarma/Mimic/tags","blobs_url":"https://api.github.com/repos/creditkarma/Mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creditkarma/Mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creditkarma/Mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/creditkarma/Mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creditkarma/Mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/creditkarma/Mimic/languages","stargazers_url":"https://api.github.com/repos/creditkarma/Mimic/stargazers","contributors_url":"https://api.github.com/repos/creditkarma/Mimic/contributors","subscribers_url":"https://api.github.com/repos/creditkarma/Mimic/subscribers","subscription_url":"https://api.github.com/repos/creditkarma/Mimic/subscription","commits_url":"https://api.github.com/repos/creditkarma/Mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/creditkarma/Mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/creditkarma/Mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/creditkarma/Mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/creditkarma/Mimic/contents/{+path}","compare_url":"https://api.github.com/repos/creditkarma/Mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creditkarma/Mimic/merges","archive_url":"https://api.github.com/repos/creditkarma/Mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creditkarma/Mimic/downloads","issues_url":"https://api.github.com/repos/creditkarma/Mimic/issues{/number}","pulls_url":"https://api.github.com/repos/creditkarma/Mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/creditkarma/Mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/creditkarma/Mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creditkarma/Mimic/labels{/name}","releases_url":"https://api.github.com/repos/creditkarma/Mimic/releases{/id}","deployments_url":"https://api.github.com/repos/creditkarma/Mimic/deployments","created_at":"2018-09-24T18:51:08Z","updated_at":"2018-11-06T02:35:31Z","pushed_at":"2018-12-03T21:43:13Z","git_url":"git://github.com/creditkarma/Mimic.git","ssh_url":"git@github.com:creditkarma/Mimic.git","clone_url":"https://github.com/creditkarma/Mimic.git","svn_url":"https://github.com/creditkarma/Mimic","homepage":"","size":1064,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"creditkarma:develop","ref":"develop","sha":"078b6e0d9ad520fc74d6fc5925deeeb56be43014","user":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"repo":{"id":150152643,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNTI2NDM=","name":"Mimic","full_name":"creditkarma/Mimic","private":false,"owner":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/creditkarma/Mimic","description":"Mimic Service Impersonator","fork":false,"url":"https://api.github.com/repos/creditkarma/Mimic","forks_url":"https://api.github.com/repos/creditkarma/Mimic/forks","keys_url":"https://api.github.com/repos/creditkarma/Mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creditkarma/Mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creditkarma/Mimic/teams","hooks_url":"https://api.github.com/repos/creditkarma/Mimic/hooks","issue_events_url":"https://api.github.com/repos/creditkarma/Mimic/issues/events{/number}","events_url":"https://api.github.com/repos/creditkarma/Mimic/events","assignees_url":"https://api.github.com/repos/creditkarma/Mimic/assignees{/user}","branches_url":"https://api.github.com/repos/creditkarma/Mimic/branches{/branch}","tags_url":"https://api.github.com/repos/creditkarma/Mimic/tags","blobs_url":"https://api.github.com/repos/creditkarma/Mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creditkarma/Mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creditkarma/Mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/creditkarma/Mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creditkarma/Mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/creditkarma/Mimic/languages","stargazers_url":"https://api.github.com/repos/creditkarma/Mimic/stargazers","contributors_url":"https://api.github.com/repos/creditkarma/Mimic/contributors","subscribers_url":"https://api.github.com/repos/creditkarma/Mimic/subscribers","subscription_url":"https://api.github.com/repos/creditkarma/Mimic/subscription","commits_url":"https://api.github.com/repos/creditkarma/Mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/creditkarma/Mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/creditkarma/Mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/creditkarma/Mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/creditkarma/Mimic/contents/{+path}","compare_url":"https://api.github.com/repos/creditkarma/Mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creditkarma/Mimic/merges","archive_url":"https://api.github.com/repos/creditkarma/Mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creditkarma/Mimic/downloads","issues_url":"https://api.github.com/repos/creditkarma/Mimic/issues{/number}","pulls_url":"https://api.github.com/repos/creditkarma/Mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/creditkarma/Mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/creditkarma/Mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creditkarma/Mimic/labels{/name}","releases_url":"https://api.github.com/repos/creditkarma/Mimic/releases{/id}","deployments_url":"https://api.github.com/repos/creditkarma/Mimic/deployments","created_at":"2018-09-24T18:51:08Z","updated_at":"2018-11-06T02:35:31Z","pushed_at":"2018-12-03T21:43:13Z","git_url":"git://github.com/creditkarma/Mimic.git","ssh_url":"git@github.com:creditkarma/Mimic.git","clone_url":"https://github.com/creditkarma/Mimic.git","svn_url":"https://github.com/creditkarma/Mimic","homepage":"","size":1064,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/17"},"html":{"href":"https://github.com/creditkarma/Mimic/pull/17"},"issue":{"href":"https://api.github.com/repos/creditkarma/Mimic/issues/17"},"comments":{"href":"https://api.github.com/repos/creditkarma/Mimic/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/creditkarma/Mimic/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/creditkarma/Mimic/statuses/cfe4872448944ad40c201b1a848868a5d25a5a14"}},"author_association":"NONE"}}
{"actor":{"display_login":"kevin-gary-ck"}}