{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/console/issues/674","repository_url":"https://api.github.com/repos/openshift/console","labels_url":"https://api.github.com/repos/openshift/console/issues/674/labels{/name}","comments_url":"https://api.github.com/repos/openshift/console/issues/674/comments","events_url":"https://api.github.com/repos/openshift/console/issues/674/events","html_url":"https://github.com/openshift/console/pull/674","id":371941368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mjc0NDg5","number":674,"title":"W.I.P. pf4 masthead and vert nav spike","user":{"login":"priley86","id":4237045,"node_id":"MDQ6VXNlcjQyMzcwNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4237045?v=4","gravatar_id":"","url":"https://api.github.com/users/priley86","html_url":"https://github.com/priley86","followers_url":"https://api.github.com/users/priley86/followers","following_url":"https://api.github.com/users/priley86/following{/other_user}","gists_url":"https://api.github.com/users/priley86/gists{/gist_id}","starred_url":"https://api.github.com/users/priley86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priley86/subscriptions","organizations_url":"https://api.github.com/users/priley86/orgs","repos_url":"https://api.github.com/users/priley86/repos","events_url":"https://api.github.com/users/priley86/events{/privacy}","received_events_url":"https://api.github.com/users/priley86/received_events","type":"User","site_admin":false},"labels":[{"id":926924472,"node_id":"MDU6TGFiZWw5MjY5MjQ0NzI=","url":"https://api.github.com/repos/openshift/console/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-10-19T12:42:58Z","updated_at":"2018-11-08T19:04:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/674","html_url":"https://github.com/openshift/console/pull/674","diff_url":"https://github.com/openshift/console/pull/674.diff","patch_url":"https://github.com/openshift/console/pull/674.patch"},"body":"This is a work in progress PR to conceptualize the masthead and vertical navigation, and to begin integration efforts for PF4. This PR provides the following:\r\n\r\n* @patternfly/patternfly-next base accessibility and spacing css\r\n* @patternfly/react-core page layout components (page, page section, nav, toolbar, etc)\r\n* default pf4 background images (to be further customized)\r\n* some css tweaks to the existing #content area: the page contents will no longer need absolute positioning in a PF4 design. The goal with this spike was to preserve the existing page content look and feel within a PF4 layout, so some minor revisions to PF4 css variables will be needed. I have started to showcase a few examples of overriding a PF4 css variable with the `pf-l-page__main-section` class to preserve the existing page content fonts. \r\n\r\nCurrent todo items for spike:\r\nhttps://docs.google.com/document/d/1o8o3iuMjnReM5RZJouqN53wg7iea-BIv_Z_woMEr8sY/edit?usp=sharing"},"comment":{"url":"https://api.github.com/repos/openshift/console/issues/comments/437118057","html_url":"https://github.com/openshift/console/pull/674#issuecomment-437118057","issue_url":"https://api.github.com/repos/openshift/console/issues/674","id":437118057,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzExODA1Nw==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T19:04:49Z","updated_at":"2018-11-08T19:04:49Z","author_association":"NONE","body":"@priley86: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/images | 21b8d5a51a8665671d2407258bf776da3aac8940 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_console/674/pull-ci-openshift-console-master-images/895) | `/test images`\nci/prow/backend | 21b8d5a51a8665671d2407258bf776da3aac8940 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_console/674/pull-ci-openshift-console-master-backend/1019) | `/test backend`\nci/prow/frontend | 21b8d5a51a8665671d2407258bf776da3aac8940 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_console/674/pull-ci-openshift-console-master-frontend/1027) | `/test frontend`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_console/674). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/priley86). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/console/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}