{"push_id":2562555694,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"ff7abf2705252073c6cbbeb160f07d9fb423fe9b","before":"2fd9d8654eeb63aed59776e18c012f42b2e6d130","commits":[{"sha":"9e7379ab97f784813a8bd1fd6c035ada0c935c0a","author":{"name":"WanLinghao","email":"7c0edcb066d78e845f27e883eaa8e4af59f164ed@cn.fujitsu.com"},"message":"\tclean duplicate test function","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/9e7379ab97f784813a8bd1fd6c035ada0c935c0a"},{"sha":"90b3f46eaef7afb3db15953c1e3b00dc24283494","author":{"name":"Chao Wang","email":"96dce87d407ae2ea57e2718f17a4e136eef72432@cn.fujitsu.com"},"message":"Add necessary explanation for container log rotation.","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/90b3f46eaef7afb3db15953c1e3b00dc24283494"},{"sha":"10664ee8c6c76ea22b265d1cdddee71f3941803c","author":{"name":"Weibin Lin","email":"742459de2421e6df571d78e41e71b0414fffd434@huawei.com"},"message":"Add comments for ipset entries in kube-proxy","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/10664ee8c6c76ea22b265d1cdddee71f3941803c"},{"sha":"3e22383a8a14eb3bd02630f3f11c0ad7a806e027","author":{"name":"Devdatta Kulkarni","email":"12a0bf94d22e4f622800aabbc941eec3d02e2e3c@gmail.com"},"message":"Added documentation of how client-go interfaces with custom controller code\n\n**What this PR does / why we need it**:\n\nThe sample-controller makes extensive use of various mechanisms\navailable in the client-go library. For writing custom controllers/operators\nit will be helpful if there is precise description of how the\nclient-go library works and how/where it interfaces with\ncustom controller code.\n\nThis patch adds documentation that sheds light on how (parts) of the\nclient-go library work and its interaction-points with\ncontroller code. The documentation and the diagram comes from [1],\n(link included here for reference purpose).\n\n[1] https://medium.com/@cloudark/kubernetes-custom-controllers-b6c7d0668fdf\n\nContributing the diagram and the writeup was recommended by\nby @sttts and @nikhita on https://github.com/kubernetes/sample-controller/issues/13\n\n**Release note**:\n\n```release-note\nNONE\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/3e22383a8a14eb3bd02630f3f11c0ad7a806e027"},{"sha":"856110a21cac0a9911b11eb08e2e9c4573ebbe7b","author":{"name":"Ian Y. Choi","email":"46d4e2a8123a01c20bc92065db984b71951a42a8@gmail.com"},"message":"Adds initial Korean translations for kubectl","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/856110a21cac0a9911b11eb08e2e9c4573ebbe7b"},{"sha":"a674335ccc0b09dc2d25b0cc3e5b4548a28c3a2a","author":{"name":"Jordan Liggitt","email":"aa6ef2bbe17379c3e8e7883829f55c5a7ad052b1@redhat.com"},"message":"Avoid copying aggregated admin/edit/view roles during bootstrap","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/a674335ccc0b09dc2d25b0cc3e5b4548a28c3a2a"},{"sha":"9f7348ed50821fdc9ba986c1dbeb78fd4f8a305f","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63230 from WanLinghao/sa_util_fix\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nclean duplicate test function\n\n**What this PR does / why we need it**:\r\nAs the patch shows, the function it tests has been moved to \r\nhttps://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/staging/src/k8s.io/apiserver/pkg/authentication/serviceaccount/util.go#L43\r\n The make/split function has been tested on file https://github.com/kubernetes/kubernetes/blob/b87a392b1a7ece8335ad3ade410e5070e29f216e/staging/src/k8s.io/apiserver/pkg/authentication/serviceaccount/util_test.go#L21\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/9f7348ed50821fdc9ba986c1dbeb78fd4f8a305f"},{"sha":"e24fd8efb1f18be4b5e94cece61a0183722dd010","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #62040 from ianychoi/korean-translation\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAdds initial Korean translations for kubectl\n\n**What this PR does / why we need it**:\r\nThis PR provides a first attempt to translate kubectl in Korean (related to #51867, #40645, #45573, #45562, #40591, #46559, #50155).\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nNo issues\r\n\r\n**Special notes for your reviewer**:\r\nThis PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ).\r\n\r\n**Release note**:\r\n```release-note\r\nAdding initial Korean translation for kubectl\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/e24fd8efb1f18be4b5e94cece61a0183722dd010"},{"sha":"e8ef744493a163ccde89686f469c7664a8eec192","author":{"name":"Di Xu","email":"907a8fd392dce771a5dff55eaced82595e18cb44@gmail.com"},"message":"fix missing flag value bindings in kubectl","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/e8ef744493a163ccde89686f469c7664a8eec192"},{"sha":"098996737475235ae6488048797227023e873ef9","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #62833 from charrywanganthony/log_rotation\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAdd necessary explanation for container log rotation.\n\n**What this PR does / why we need it**:\r\n#59898\r\n> Container log manager only starts when the container runtime is remote (not docker), because we can't implement ReopenContainerLog for docker.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/098996737475235ae6488048797227023e873ef9"},{"sha":"e34df0a26cc69ebc0987d0e87fe4ad732bcda42a","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63585 from islinwb/ipset_comment\n\nAutomatic merge from submit-queue (batch tested with PRs 62833, 63585). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAdd comments for ipset entries in kube-proxy\n\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #63584 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/e34df0a26cc69ebc0987d0e87fe4ad732bcda42a"},{"sha":"773def0194ecc1cd845ea9a01da761d5a0390e6e","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #62563 from devdattakulkarni/client-go-details\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nUpdated README to include client-go<->controller diagram\n\nThe sample-controller makes extensive use of various mechanisms\r\navailable in client-go. For writing custom controllers/operators\r\nit will be helpful if there is precise description of how the\r\nclient-go library works and how/where it interfaces with\r\ncustom controller code.\r\n\r\nRecently we published a blog post with these details here:\r\n\r\nhttps://medium.com/@cloudark/kubernetes-custom-controllers-b6c7d0668fdf\r\n\r\nThis patch includes the diagram from the post, as was recommended\r\nby @sttts on https://github.com/kubernetes/sample-controller/issues/13\r\n\r\n\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\n\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/773def0194ecc1cd845ea9a01da761d5a0390e6e"},{"sha":"7e4014e02befbdf62673f2a82c21e52ed9b8a791","author":{"name":"xuzhonghu","email":"caf88d0f3cd7d1d764dc6646976d1f2384a6b9dd@huawei.com"},"message":"remove unused PrintFlags.Scheme","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/7e4014e02befbdf62673f2a82c21e52ed9b8a791"},{"sha":"d5a930bed49b2a290b09e87995813fa3aa649fe5","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63761 from liggitt/aggregated-bootstrap-race\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nAvoid copying aggregated admin/edit/view roles during bootstrap\n\nFixes #63760\r\n\r\nAt apiserver startup, prior to reconciling cluster roles, the following roles (if they exist) are copied:\r\n* admin -> system:aggregate-to-admin\r\n* edit -> system:aggregate-to-edit\r\n* view -> system:aggregate-to-view\r\n\r\nThis was added in 1.9 as part of role aggregation to ensure custom permissions added to the admin/edit/view roles were preserved, prior to making the admin/edit/view roles aggregated (since the permissions of an aggregated role are controller-managed)\r\n\r\nWhen starting multiple members of a new HA cluster simultaneously, the following race can occur:\r\n* t=0, server 1,2,3 start up\r\n* t=1, server 1 finds no admin/edit/view roles exist, begins role reconciliation and creates the aggregated `admin` role\r\n* t=2, server 2 finds and copies the `admin` role created by server 1 to `system:aggregate-to-admin`\r\n\r\nIf this race is encountered, it results in `system:aggregate-to-admin` being an aggregated role, and its permissions subject to being overwritten by the aggregating controller. To prevent this from happening, the permission-preserving copy should only copy over roles that are not yet aggregated.\r\n\r\nTo correct this in clusters that have already encountered it, role reconciliation should remove aggregation from a role that is not expected to be aggregated at all.\r\n\r\n```release-note\r\ncorrects a race condition in bootstrapping aggregated cluster roles in new HA clusters\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/d5a930bed49b2a290b09e87995813fa3aa649fe5"},{"sha":"1b1defb0600b7b4b15bcc476c7338a301f0dca89","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63794 from hzxuzhonghu/tmp-5-14\n\nAutomatic merge from submit-queue (batch tested with PRs 63761, 63794, 63649). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nremove unused PrintFlags.Scheme\n\nPrintFlags.Scheme is unused, remove it.\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/1b1defb0600b7b4b15bcc476c7338a301f0dca89"},{"sha":"ff7abf2705252073c6cbbeb160f07d9fb423fe9b","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #63649 from dixudx/kubectl_flags_binding\n\nAutomatic merge from submit-queue (batch tested with PRs 63761, 63794, 63649). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nfix missing flag value bindings in kubectl\n\n**What this PR does / why we need it**:\r\nWhen working #63644, I find there are still some flag not bound correctly.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nxref #60366\r\n\r\n**Special notes for your reviewer**:\r\n/cc soltysh deads2k \r\n/cc kubernetes/sig-cli-api-reviews \r\n**Release note**:\r\n\r\n```release-note\r\nNone\r\n```","distinct":true,"url":"https://api.github.com/repos/heckj/kubernetes/commits/ff7abf2705252073c6cbbeb160f07d9fb423fe9b"}]}
{"actor":{"display_login":"heckj"}}