{"action":"opened","number":53950,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/53950","id":213030430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDMwNDMw","html_url":"https://github.com/rust-lang/rust/pull/53950","diff_url":"https://github.com/rust-lang/rust/pull/53950.diff","patch_url":"https://github.com/rust-lang/rust/pull/53950.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53950","number":53950,"state":"open","locked":false,"title":"Allow for opting out of ThinLTO and clean up LTO related cli flag handling.","user":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"body":"It turns out that there currently is no way to explicitly disable ThinLTO (except for the nightly-only `-Zthinlto` flag). This PR extends `-C lto` to take `yes` and `no` in addition to `thin` and `fat`. It should be backwards compatible. \r\n\r\nIt also cleans up how LTO mode selection is handled.\r\n\r\nNote that merging the PR in the current state would make the new values for `-C lto` available on the stable channel. I think that would be fine but maybe some team should vote on it.\r\n\r\nr? @alexcrichton ","created_at":"2018-09-04T16:11:05Z","updated_at":"2018-09-04T16:11:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/53950/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/53950/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53950/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/8c0c29bcf4475ef5816681fe8a8bee19806ccd0d","head":{"label":"michaelwoerister:more-lto-cli","ref":"more-lto-cli","sha":"8c0c29bcf4475ef5816681fe8a8bee19806ccd0d","user":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"repo":{"id":9431220,"node_id":"MDEwOlJlcG9zaXRvcnk5NDMxMjIw","name":"rust","full_name":"michaelwoerister/rust","owner":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelwoerister/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/michaelwoerister/rust","forks_url":"https://api.github.com/repos/michaelwoerister/rust/forks","keys_url":"https://api.github.com/repos/michaelwoerister/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelwoerister/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelwoerister/rust/teams","hooks_url":"https://api.github.com/repos/michaelwoerister/rust/hooks","issue_events_url":"https://api.github.com/repos/michaelwoerister/rust/issues/events{/number}","events_url":"https://api.github.com/repos/michaelwoerister/rust/events","assignees_url":"https://api.github.com/repos/michaelwoerister/rust/assignees{/user}","branches_url":"https://api.github.com/repos/michaelwoerister/rust/branches{/branch}","tags_url":"https://api.github.com/repos/michaelwoerister/rust/tags","blobs_url":"https://api.github.com/repos/michaelwoerister/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelwoerister/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelwoerister/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelwoerister/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelwoerister/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelwoerister/rust/languages","stargazers_url":"https://api.github.com/repos/michaelwoerister/rust/stargazers","contributors_url":"https://api.github.com/repos/michaelwoerister/rust/contributors","subscribers_url":"https://api.github.com/repos/michaelwoerister/rust/subscribers","subscription_url":"https://api.github.com/repos/michaelwoerister/rust/subscription","commits_url":"https://api.github.com/repos/michaelwoerister/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelwoerister/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelwoerister/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelwoerister/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelwoerister/rust/contents/{+path}","compare_url":"https://api.github.com/repos/michaelwoerister/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelwoerister/rust/merges","archive_url":"https://api.github.com/repos/michaelwoerister/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelwoerister/rust/downloads","issues_url":"https://api.github.com/repos/michaelwoerister/rust/issues{/number}","pulls_url":"https://api.github.com/repos/michaelwoerister/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelwoerister/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelwoerister/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelwoerister/rust/labels{/name}","releases_url":"https://api.github.com/repos/michaelwoerister/rust/releases{/id}","deployments_url":"https://api.github.com/repos/michaelwoerister/rust/deployments","created_at":"2013-04-14T15:57:02Z","updated_at":"2018-03-13T22:14:02Z","pushed_at":"2018-09-04T16:05:32Z","git_url":"git://github.com/michaelwoerister/rust.git","ssh_url":"git@github.com:michaelwoerister/rust.git","clone_url":"https://github.com/michaelwoerister/rust.git","svn_url":"https://github.com/michaelwoerister/rust","homepage":"http://www.rust-lang.org","size":387102,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"1c2e17f4e3a2070a7f703f51e29c1c388ef703b6","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-09-04T15:54:24Z","pushed_at":"2018-09-04T15:54:01Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":390589,"stargazers_count":30423,"watchers_count":30423,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5146,"mirror_url":null,"archived":false,"open_issues_count":4288,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5146,"open_issues":4288,"watchers":30423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53950"},"html":{"href":"https://github.com/rust-lang/rust/pull/53950"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53950"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53950/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53950/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53950/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/8c0c29bcf4475ef5816681fe8a8bee19806ccd0d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":92,"deletions":27,"changed_files":7}}
{"actor":{"display_login":"michaelwoerister"}}