{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/206978737","pull_request_review_id":142498072,"id":206978737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk3ODczNw==","diff_hunk":"@@ -0,0 +1,30 @@\n+// Type definitions for json-rpc-error 2.0\n+// Project: https://github.com/claudijo/json-rpc-error\n+// Definitions by: Leonid Logvinov <https://github.com/LogvinovLeon>\n+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n+// TypeScript Version: 2.4\n+\n+declare class JsonRpcError extends Error {}","path":"types/json-rpc-error/index.d.ts","position":7,"original_position":7,"commit_id":"7381b5b31cdb33b2b1f4ee26fb7cc909f28a6cbc","original_commit_id":"7381b5b31cdb33b2b1f4ee26fb7cc909f28a6cbc","user":{"login":"sheetalkamat","id":8052792,"node_id":"MDQ6VXNlcjgwNTI3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false},"body":"Please add constructor signature as per : https://github.com/claudijo/json-rpc-error#jsonrpcerror","created_at":"2018-08-01T18:07:58Z","updated_at":"2018-08-01T18:09:06Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677#discussion_r206978737","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/206978737"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677#discussion_r206978737"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677","id":204761436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzYxNDM2","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27677","number":27677,"state":"open","locked":false,"title":"Add types for json-rpc-error","user":{"login":"LogvinovLeon","id":6204356,"node_id":"MDQ6VXNlcjYyMDQzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [x] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [x] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n","created_at":"2018-07-30T10:33:45Z","updated_at":"2018-08-01T18:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bbed8518dee2f657e3830e637cd10d2614e44de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":646788888,"node_id":"MDU6TGFiZWw2NDY3ODg4ODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27677/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/7381b5b31cdb33b2b1f4ee26fb7cc909f28a6cbc","head":{"label":"0xProject:new-type/json-rpc-error","ref":"new-type/json-rpc-error","sha":"7381b5b31cdb33b2b1f4ee26fb7cc909f28a6cbc","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":134900657,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ5MDA2NTc=","name":"DefinitelyTyped","full_name":"0xProject/DefinitelyTyped","owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/0xProject/DefinitelyTyped","forks_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/DefinitelyTyped/deployments","created_at":"2018-05-25T20:14:23Z","updated_at":"2018-07-25T13:27:30Z","pushed_at":"2018-08-01T14:52:10Z","git_url":"git://github.com/0xProject/DefinitelyTyped.git","ssh_url":"git@github.com:0xProject/DefinitelyTyped.git","clone_url":"https://github.com/0xProject/DefinitelyTyped.git","svn_url":"https://github.com/0xProject/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":326833,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"cdcc5dd4ff3a08eebb585200b9fae29209637650","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-08-01T16:24:04Z","pushed_at":"2018-08-01T17:44:50Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":343024,"stargazers_count":16692,"watchers_count":16692,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13961,"mirror_url":null,"archived":false,"open_issues_count":2267,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13961,"open_issues":2267,"watchers":16692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27677"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27677"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27677/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27677/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/7381b5b31cdb33b2b1f4ee26fb7cc909f28a6cbc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sheetalkamat"}}