{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21401","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21401/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21401/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21401/events","html_url":"https://github.com/Microsoft/TypeScript/pull/21401","id":291404847,"number":21401,"title":"Move insertSorted from server to core, use for diagnostic collections","user":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars3.githubusercontent.com/u/2932786?v=4","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-01-25T00:03:29Z","updated_at":"2018-02-07T23:29:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/21401","html_url":"https://github.com/Microsoft/TypeScript/pull/21401","diff_url":"https://github.com/Microsoft/TypeScript/pull/21401.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/21401.patch"},"body":"This causes us to spend considerably less time sorting diagnostics in projects with many files where we alternate between getting the file's diagnostics and adding diagnostics (~10s, or 8% on a very large project). Additionally, I've upped the time rwc tests have to verify js output, because our newest RWC test takes 5s (!!!) just to textually compare its js emit, and mocha's default 2s timeout was causing it to timeout when I ran it via mocha directly (to profile it).\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/363947420","html_url":"https://github.com/Microsoft/TypeScript/pull/21401#issuecomment-363947420","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21401","id":363947420,"user":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars3.githubusercontent.com/u/8000722?v=4","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T23:29:11Z","updated_at":"2018-02-07T23:29:11Z","author_association":"CONTRIBUTOR","body":"I like your suggestion of creating allDiagnostics list on demand by combining all file diagnostics in the right order instead of having to keep a second sorted list. let's do that as well."}}
{"actor":{"display_login":"mhegazy"}}