{"action":"closed","number":246,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246","id":185265841,"html_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/246","diff_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/246.diff","patch_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/246.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/246","number":246,"state":"closed","locked":false,"title":"[EMB-256] Pass params and queryParams properly to urlFor","user":{"login":"jamescdavis","id":348630,"avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"body":"<!-- Before you submit your Pull Request, make sure you picked the right branch:\r\n\r\n     - For hotfixes, select \"master\" as the target branch\r\n     - For new features and non-hotfix bugfixes, select \"develop\" as the target branch\r\n     - For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch -->\r\n\r\n## Purpose\r\n\r\nPass params and queryParams properly to urlFor so it doesn't error out.\r\n\r\n## Summary of Changes\r\n\r\nspread params and nest queryParams in object with `queryParams` key\r\n\r\n## Side Effects / Testing Notes\r\n\r\nAll other future CAS Authenticated Routes should work.\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/EMB-256\r\n\r\n# Reviewer Checklist\r\n\r\n- [ ] meets requirements\r\n- [ ] easy to understand\r\n- [ ] DRY\r\n- [ ] testable and includes test(s)\r\n- [ ] changes described in `CHANGELOG.md`\r\n\r\n<!-- Please strike through any checks that you think are not relevant for this PR and indicate why, e.g.\r\n\r\n     - [ ] ~~easy to understand~~ *(necessarily complex)*\r\n-->\r\n","created_at":"2018-05-01T20:19:47Z","updated_at":"2018-05-01T20:38:29Z","closed_at":"2018-05-01T20:38:29Z","merged_at":"2018-05-01T20:38:29Z","merge_commit_sha":"c0dd3383ef52e219887eb1996d07075abf57c435","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/246/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/statuses/c5300475c7c8f43d001b3fc2d4434b555dc3eb16","head":{"label":"jamescdavis:fix_cas-authenticated-route_mixin","ref":"fix_cas-authenticated-route_mixin","sha":"c5300475c7c8f43d001b3fc2d4434b555dc3eb16","user":{"login":"jamescdavis","id":348630,"avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"repo":{"id":104222512,"name":"ember-osf-web","full_name":"jamescdavis/ember-osf-web","owner":{"login":"jamescdavis","id":348630,"avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamescdavis/ember-osf-web","description":null,"fork":true,"url":"https://api.github.com/repos/jamescdavis/ember-osf-web","forks_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/forks","keys_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/teams","hooks_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/hooks","issue_events_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/issues/events{/number}","events_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/events","assignees_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/assignees{/user}","branches_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/branches{/branch}","tags_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/tags","blobs_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/statuses/{sha}","languages_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/languages","stargazers_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/stargazers","contributors_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/contributors","subscribers_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/subscribers","subscription_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/subscription","commits_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/contents/{+path}","compare_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/merges","archive_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/downloads","issues_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/issues{/number}","pulls_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/pulls{/number}","milestones_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/milestones{/number}","notifications_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/labels{/name}","releases_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/releases{/id}","deployments_url":"https://api.github.com/repos/jamescdavis/ember-osf-web/deployments","created_at":"2017-09-20T13:58:28Z","updated_at":"2018-05-01T15:25:25Z","pushed_at":"2018-05-01T20:16:36Z","git_url":"git://github.com/jamescdavis/ember-osf-web.git","ssh_url":"git@github.com:jamescdavis/ember-osf-web.git","clone_url":"https://github.com/jamescdavis/ember-osf-web.git","svn_url":"https://github.com/jamescdavis/ember-osf-web","homepage":null,"size":2536,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"182f73e15c8a194af25a351e8a2075d80d093633","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":103567245,"name":"ember-osf-web","full_name":"CenterForOpenScience/ember-osf-web","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-osf-web","description":"Ember front-end for the Open Science Framework","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/deployments","created_at":"2017-09-14T18:25:41Z","updated_at":"2018-05-01T15:20:06Z","pushed_at":"2018-05-01T20:38:29Z","git_url":"git://github.com/CenterForOpenScience/ember-osf-web.git","ssh_url":"git@github.com:CenterForOpenScience/ember-osf-web.git","clone_url":"https://github.com/CenterForOpenScience/ember-osf-web.git","svn_url":"https://github.com/CenterForOpenScience/ember-osf-web","homepage":"https://osf.io","size":2521,"stargazers_count":42,"watchers_count":42,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":7,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246"},"html":{"href":"https://github.com/CenterForOpenScience/ember-osf-web/pull/246"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/246"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/statuses/c5300475c7c8f43d001b3fc2d4434b555dc3eb16"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jamescdavis","id":348630,"avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jamescdavis"}}