{"action":"created","comment":{"url":"https://api.github.com/repos/JDRF/spirit/pulls/comments/196933333","pull_request_review_id":130577871,"id":196933333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkzMzMzMw==","diff_hunk":"@@ -1,23 +1,132 @@\n+// Letter Spacing\n+$spirit-button-font-letter-spacing-15: .15em;","path":"library/components/button/button.scss","position":2,"original_position":2,"commit_id":"bc71c377d38613df87c62bf19f529fdf49a3e459","original_commit_id":"3c7b86d821032516c6ab60a3ddc02a84f9d52fc3","user":{"login":"jamesmelzer","id":1207666,"node_id":"MDQ6VXNlcjEyMDc2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1207666?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmelzer","html_url":"https://github.com/jamesmelzer","followers_url":"https://api.github.com/users/jamesmelzer/followers","following_url":"https://api.github.com/users/jamesmelzer/following{/other_user}","gists_url":"https://api.github.com/users/jamesmelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmelzer/subscriptions","organizations_url":"https://api.github.com/users/jamesmelzer/orgs","repos_url":"https://api.github.com/users/jamesmelzer/repos","events_url":"https://api.github.com/users/jamesmelzer/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmelzer/received_events","type":"User","site_admin":false},"body":"I don't. I'll ping Patrick","created_at":"2018-06-20T20:34:50Z","updated_at":"2018-06-20T20:34:50Z","html_url":"https://github.com/JDRF/spirit/pull/152#discussion_r196933333","pull_request_url":"https://api.github.com/repos/JDRF/spirit/pulls/152","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/comments/196933333"},"html":{"href":"https://github.com/JDRF/spirit/pull/152#discussion_r196933333"},"pull_request":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/152"}},"in_reply_to_id":196913492},"pull_request":{"url":"https://api.github.com/repos/JDRF/spirit/pulls/152","id":196225148,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjI1MTQ4","html_url":"https://github.com/JDRF/spirit/pull/152","diff_url":"https://github.com/JDRF/spirit/pull/152.diff","patch_url":"https://github.com/JDRF/spirit/pull/152.patch","issue_url":"https://api.github.com/repos/JDRF/spirit/issues/152","number":152,"state":"open","locked":false,"title":"Feature/59 component button","user":{"login":"joesnellpdx","id":1504070,"node_id":"MDQ6VXNlcjE1MDQwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1504070?v=4","gravatar_id":"","url":"https://api.github.com/users/joesnellpdx","html_url":"https://github.com/joesnellpdx","followers_url":"https://api.github.com/users/joesnellpdx/followers","following_url":"https://api.github.com/users/joesnellpdx/following{/other_user}","gists_url":"https://api.github.com/users/joesnellpdx/gists{/gist_id}","starred_url":"https://api.github.com/users/joesnellpdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joesnellpdx/subscriptions","organizations_url":"https://api.github.com/users/joesnellpdx/orgs","repos_url":"https://api.github.com/users/joesnellpdx/repos","events_url":"https://api.github.com/users/joesnellpdx/events{/privacy}","received_events_url":"https://api.github.com/users/joesnellpdx/received_events","type":"User","site_admin":false},"body":"Added library component button\r\n\r\n- Not able to add to doc-site locally\r\n- Custom variables in buttons.scss: need discussion on tokens\r\n- box sizing and border: not able to alter box sizing to have button ignore border width\r\n\r\nFor box sizing, options:\r\n\r\n- Kevin passes knowledge to accomplish with box sizing\r\n- Use pseudo element\r\n- Use box shadow inset\r\n- Use custom padding ( remove border width )\r\n\r\nTesting process: \r\nLMK where / how workflow should be altered + any other feedback \r\nAlso, not all buttons complete at this time, but want review on current state of branch.\r\nI assume PRs and Issues will not be directly connected besides branch titles\r\n","created_at":"2018-06-20T17:54:30Z","updated_at":"2018-06-20T20:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b12b430eb6ff8f63e8195e330346fa9ffa3a0adf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jamesmelzer","id":1207666,"node_id":"MDQ6VXNlcjEyMDc2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1207666?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmelzer","html_url":"https://github.com/jamesmelzer","followers_url":"https://api.github.com/users/jamesmelzer/followers","following_url":"https://api.github.com/users/jamesmelzer/following{/other_user}","gists_url":"https://api.github.com/users/jamesmelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmelzer/subscriptions","organizations_url":"https://api.github.com/users/jamesmelzer/orgs","repos_url":"https://api.github.com/users/jamesmelzer/repos","events_url":"https://api.github.com/users/jamesmelzer/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmelzer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JDRF/spirit/pulls/152/commits","review_comments_url":"https://api.github.com/repos/JDRF/spirit/pulls/152/comments","review_comment_url":"https://api.github.com/repos/JDRF/spirit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JDRF/spirit/issues/152/comments","statuses_url":"https://api.github.com/repos/JDRF/spirit/statuses/bc71c377d38613df87c62bf19f529fdf49a3e459","head":{"label":"JDRF:feature/59-component-button","ref":"feature/59-component-button","sha":"bc71c377d38613df87c62bf19f529fdf49a3e459","user":{"login":"JDRF","id":4071597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzE1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4071597?v=4","gravatar_id":"","url":"https://api.github.com/users/JDRF","html_url":"https://github.com/JDRF","followers_url":"https://api.github.com/users/JDRF/followers","following_url":"https://api.github.com/users/JDRF/following{/other_user}","gists_url":"https://api.github.com/users/JDRF/gists{/gist_id}","starred_url":"https://api.github.com/users/JDRF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDRF/subscriptions","organizations_url":"https://api.github.com/users/JDRF/orgs","repos_url":"https://api.github.com/users/JDRF/repos","events_url":"https://api.github.com/users/JDRF/events{/privacy}","received_events_url":"https://api.github.com/users/JDRF/received_events","type":"Organization","site_admin":false},"repo":{"id":101075244,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNzUyNDQ=","name":"spirit","full_name":"JDRF/spirit","owner":{"login":"JDRF","id":4071597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzE1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4071597?v=4","gravatar_id":"","url":"https://api.github.com/users/JDRF","html_url":"https://github.com/JDRF","followers_url":"https://api.github.com/users/JDRF/followers","following_url":"https://api.github.com/users/JDRF/following{/other_user}","gists_url":"https://api.github.com/users/JDRF/gists{/gist_id}","starred_url":"https://api.github.com/users/JDRF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDRF/subscriptions","organizations_url":"https://api.github.com/users/JDRF/orgs","repos_url":"https://api.github.com/users/JDRF/repos","events_url":"https://api.github.com/users/JDRF/events{/privacy}","received_events_url":"https://api.github.com/users/JDRF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JDRF/spirit","description":"JDRF Design Language System","fork":false,"url":"https://api.github.com/repos/JDRF/spirit","forks_url":"https://api.github.com/repos/JDRF/spirit/forks","keys_url":"https://api.github.com/repos/JDRF/spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDRF/spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDRF/spirit/teams","hooks_url":"https://api.github.com/repos/JDRF/spirit/hooks","issue_events_url":"https://api.github.com/repos/JDRF/spirit/issues/events{/number}","events_url":"https://api.github.com/repos/JDRF/spirit/events","assignees_url":"https://api.github.com/repos/JDRF/spirit/assignees{/user}","branches_url":"https://api.github.com/repos/JDRF/spirit/branches{/branch}","tags_url":"https://api.github.com/repos/JDRF/spirit/tags","blobs_url":"https://api.github.com/repos/JDRF/spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDRF/spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDRF/spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDRF/spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDRF/spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/JDRF/spirit/languages","stargazers_url":"https://api.github.com/repos/JDRF/spirit/stargazers","contributors_url":"https://api.github.com/repos/JDRF/spirit/contributors","subscribers_url":"https://api.github.com/repos/JDRF/spirit/subscribers","subscription_url":"https://api.github.com/repos/JDRF/spirit/subscription","commits_url":"https://api.github.com/repos/JDRF/spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDRF/spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDRF/spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDRF/spirit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDRF/spirit/contents/{+path}","compare_url":"https://api.github.com/repos/JDRF/spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDRF/spirit/merges","archive_url":"https://api.github.com/repos/JDRF/spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDRF/spirit/downloads","issues_url":"https://api.github.com/repos/JDRF/spirit/issues{/number}","pulls_url":"https://api.github.com/repos/JDRF/spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/JDRF/spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/JDRF/spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDRF/spirit/labels{/name}","releases_url":"https://api.github.com/repos/JDRF/spirit/releases{/id}","deployments_url":"https://api.github.com/repos/JDRF/spirit/deployments","created_at":"2017-08-22T15:00:28Z","updated_at":"2018-06-20T18:27:46Z","pushed_at":"2018-06-20T20:32:28Z","git_url":"git://github.com/JDRF/spirit.git","ssh_url":"git@github.com:JDRF/spirit.git","clone_url":"https://github.com/JDRF/spirit.git","svn_url":"https://github.com/JDRF/spirit","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":147,"license":null,"forks":0,"open_issues":147,"watchers":0,"default_branch":"master"}},"base":{"label":"JDRF:master","ref":"master","sha":"159b6e9c8b8c5ba110ede72abf720003e0fe1d02","user":{"login":"JDRF","id":4071597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzE1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4071597?v=4","gravatar_id":"","url":"https://api.github.com/users/JDRF","html_url":"https://github.com/JDRF","followers_url":"https://api.github.com/users/JDRF/followers","following_url":"https://api.github.com/users/JDRF/following{/other_user}","gists_url":"https://api.github.com/users/JDRF/gists{/gist_id}","starred_url":"https://api.github.com/users/JDRF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDRF/subscriptions","organizations_url":"https://api.github.com/users/JDRF/orgs","repos_url":"https://api.github.com/users/JDRF/repos","events_url":"https://api.github.com/users/JDRF/events{/privacy}","received_events_url":"https://api.github.com/users/JDRF/received_events","type":"Organization","site_admin":false},"repo":{"id":101075244,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNzUyNDQ=","name":"spirit","full_name":"JDRF/spirit","owner":{"login":"JDRF","id":4071597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzE1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4071597?v=4","gravatar_id":"","url":"https://api.github.com/users/JDRF","html_url":"https://github.com/JDRF","followers_url":"https://api.github.com/users/JDRF/followers","following_url":"https://api.github.com/users/JDRF/following{/other_user}","gists_url":"https://api.github.com/users/JDRF/gists{/gist_id}","starred_url":"https://api.github.com/users/JDRF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDRF/subscriptions","organizations_url":"https://api.github.com/users/JDRF/orgs","repos_url":"https://api.github.com/users/JDRF/repos","events_url":"https://api.github.com/users/JDRF/events{/privacy}","received_events_url":"https://api.github.com/users/JDRF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JDRF/spirit","description":"JDRF Design Language System","fork":false,"url":"https://api.github.com/repos/JDRF/spirit","forks_url":"https://api.github.com/repos/JDRF/spirit/forks","keys_url":"https://api.github.com/repos/JDRF/spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDRF/spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDRF/spirit/teams","hooks_url":"https://api.github.com/repos/JDRF/spirit/hooks","issue_events_url":"https://api.github.com/repos/JDRF/spirit/issues/events{/number}","events_url":"https://api.github.com/repos/JDRF/spirit/events","assignees_url":"https://api.github.com/repos/JDRF/spirit/assignees{/user}","branches_url":"https://api.github.com/repos/JDRF/spirit/branches{/branch}","tags_url":"https://api.github.com/repos/JDRF/spirit/tags","blobs_url":"https://api.github.com/repos/JDRF/spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDRF/spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDRF/spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDRF/spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDRF/spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/JDRF/spirit/languages","stargazers_url":"https://api.github.com/repos/JDRF/spirit/stargazers","contributors_url":"https://api.github.com/repos/JDRF/spirit/contributors","subscribers_url":"https://api.github.com/repos/JDRF/spirit/subscribers","subscription_url":"https://api.github.com/repos/JDRF/spirit/subscription","commits_url":"https://api.github.com/repos/JDRF/spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDRF/spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDRF/spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDRF/spirit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDRF/spirit/contents/{+path}","compare_url":"https://api.github.com/repos/JDRF/spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDRF/spirit/merges","archive_url":"https://api.github.com/repos/JDRF/spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDRF/spirit/downloads","issues_url":"https://api.github.com/repos/JDRF/spirit/issues{/number}","pulls_url":"https://api.github.com/repos/JDRF/spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/JDRF/spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/JDRF/spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDRF/spirit/labels{/name}","releases_url":"https://api.github.com/repos/JDRF/spirit/releases{/id}","deployments_url":"https://api.github.com/repos/JDRF/spirit/deployments","created_at":"2017-08-22T15:00:28Z","updated_at":"2018-06-20T18:27:46Z","pushed_at":"2018-06-20T20:32:28Z","git_url":"git://github.com/JDRF/spirit.git","ssh_url":"git@github.com:JDRF/spirit.git","clone_url":"https://github.com/JDRF/spirit.git","svn_url":"https://github.com/JDRF/spirit","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":147,"license":null,"forks":0,"open_issues":147,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/152"},"html":{"href":"https://github.com/JDRF/spirit/pull/152"},"issue":{"href":"https://api.github.com/repos/JDRF/spirit/issues/152"},"comments":{"href":"https://api.github.com/repos/JDRF/spirit/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JDRF/spirit/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/JDRF/spirit/statuses/bc71c377d38613df87c62bf19f529fdf49a3e459"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jamesmelzer"}}