{"action":"created","issue":{"url":"https://api.github.com/repos/tablexi/nucore-open/issues/1788","repository_url":"https://api.github.com/repos/tablexi/nucore-open","labels_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1788/labels{/name}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1788/comments","events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1788/events","html_url":"https://github.com/tablexi/nucore-open/pull/1788","id":387368830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODcyODM5","number":1788,"title":"Add support for multiple favicons","user":{"login":"ColinMcNeil","id":5000430,"node_id":"MDQ6VXNlcjUwMDA0MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5000430?v=4","gravatar_id":"","url":"https://api.github.com/users/ColinMcNeil","html_url":"https://github.com/ColinMcNeil","followers_url":"https://api.github.com/users/ColinMcNeil/followers","following_url":"https://api.github.com/users/ColinMcNeil/following{/other_user}","gists_url":"https://api.github.com/users/ColinMcNeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinMcNeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinMcNeil/subscriptions","organizations_url":"https://api.github.com/users/ColinMcNeil/orgs","repos_url":"https://api.github.com/users/ColinMcNeil/repos","events_url":"https://api.github.com/users/ColinMcNeil/events{/privacy}","received_events_url":"https://api.github.com/users/ColinMcNeil/received_events","type":"User","site_admin":false},"labels":[{"id":864713861,"node_id":"MDU6TGFiZWw4NjQ3MTM4NjE=","url":"https://api.github.com/repos/tablexi/nucore-open/labels/UConn","name":"UConn","color":"000E2F","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-04T16:24:30Z","updated_at":"2018-12-17T19:25:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1788","html_url":"https://github.com/tablexi/nucore-open/pull/1788","diff_url":"https://github.com/tablexi/nucore-open/pull/1788.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/1788.patch"},"body":"# Release Notes\r\n\r\nSimilar to the brand image, we have added the support for multiple favicon resolutions.\r\n\r\n# Screenshot\r\n\r\n<img width=\"618\" alt=\"screen shot 2018-12-04 at 11 19 03 am\" src=\"https://user-images.githubusercontent.com/5000430/49456237-bce47f00-f7b6-11e8-85aa-76043f6c5d0d.png\">\r\nAs you can see, they are added via paths in `settings.yml`. They are only rendered in the head if a path is specified.\r\n\r\n##\r\n<img width=\"308\" alt=\"screen shot 2018-12-04 at 11 20 00 am\" src=\"https://user-images.githubusercontent.com/5000430/49456282-d2f23f80-f7b6-11e8-9b7a-313b8fc984b3.png\">\r\n\r\n`favicon_link_tag` looks in `assets/images` for favicons, so we just added them to their own folder.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments/447967203","html_url":"https://github.com/tablexi/nucore-open/pull/1788#issuecomment-447967203","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1788","id":447967203,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzk2NzIwMw==","user":{"login":"ColinMcNeil","id":5000430,"node_id":"MDQ6VXNlcjUwMDA0MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5000430?v=4","gravatar_id":"","url":"https://api.github.com/users/ColinMcNeil","html_url":"https://github.com/ColinMcNeil","followers_url":"https://api.github.com/users/ColinMcNeil/followers","following_url":"https://api.github.com/users/ColinMcNeil/following{/other_user}","gists_url":"https://api.github.com/users/ColinMcNeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinMcNeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinMcNeil/subscriptions","organizations_url":"https://api.github.com/users/ColinMcNeil/orgs","repos_url":"https://api.github.com/users/ColinMcNeil/repos","events_url":"https://api.github.com/users/ColinMcNeil/events{/privacy}","received_events_url":"https://api.github.com/users/ColinMcNeil/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T19:25:05Z","updated_at":"2018-12-17T19:25:05Z","author_association":"CONTRIBUTOR","body":"Alright, I'm now loading favicons from the directory. Right now the logic is in application_controller. I could move it to its own helper, or alternatively try a different approach entirely."}}
{"actor":{"display_login":"ColinMcNeil"}}