{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/240877554","pull_request_review_id":184007270,"id":240877554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDg3NzU1NA==","diff_hunk":"@@ -1682,6 +1682,36 @@ The `OverWindow` defines a range of rows over which aggregates are computed. `Ov\n \n {% top %}\n \n+### Aggregate\n+\n+Aggregate performs an aggregate operation with an aggregate function. You have to close the\n+\"aggregate\" with a select statement. The output will be flattened if the output type is a","path":"docs/dev/table/tableApi.md","position":7,"original_position":7,"commit_id":"c67aa646bb0938c51f284d1890759259ce1915ea","original_commit_id":"c67aa646bb0938c51f284d1890759259ce1915ea","user":{"login":"hequn8128","id":4971479,"node_id":"MDQ6VXNlcjQ5NzE0Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/4971479?v=4","gravatar_id":"","url":"https://api.github.com/users/hequn8128","html_url":"https://github.com/hequn8128","followers_url":"https://api.github.com/users/hequn8128/followers","following_url":"https://api.github.com/users/hequn8128/following{/other_user}","gists_url":"https://api.github.com/users/hequn8128/gists{/gist_id}","starred_url":"https://api.github.com/users/hequn8128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hequn8128/subscriptions","organizations_url":"https://api.github.com/users/hequn8128/orgs","repos_url":"https://api.github.com/users/hequn8128/repos","events_url":"https://api.github.com/users/hequn8128/events{/privacy}","received_events_url":"https://api.github.com/users/hequn8128/received_events","type":"User","site_admin":false},"body":"Add a sentence that can't use an aggregate function in the select statement as it has been checked in the select. ","created_at":"2018-12-12T04:15:59Z","updated_at":"2018-12-12T04:19:12Z","html_url":"https://github.com/apache/flink/pull/7235#discussion_r240877554","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/7235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/240877554"},"html":{"href":"https://github.com/apache/flink/pull/7235#discussion_r240877554"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/7235"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/7235","id":236049098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQ5MDk4","html_url":"https://github.com/apache/flink/pull/7235","diff_url":"https://github.com/apache/flink/pull/7235.diff","patch_url":"https://github.com/apache/flink/pull/7235.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/7235","number":7235,"state":"open","locked":false,"title":"[FLINK-10976] [table] Add support for aggregate to table API","user":{"login":"dianfu","id":5466492,"node_id":"MDQ6VXNlcjU0NjY0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5466492?v=4","gravatar_id":"","url":"https://api.github.com/users/dianfu","html_url":"https://github.com/dianfu","followers_url":"https://api.github.com/users/dianfu/followers","following_url":"https://api.github.com/users/dianfu/following{/other_user}","gists_url":"https://api.github.com/users/dianfu/gists{/gist_id}","starred_url":"https://api.github.com/users/dianfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianfu/subscriptions","organizations_url":"https://api.github.com/users/dianfu/orgs","repos_url":"https://api.github.com/users/dianfu/repos","events_url":"https://api.github.com/users/dianfu/events{/privacy}","received_events_url":"https://api.github.com/users/dianfu/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\n*This pull request adds the aggregate operation to table API.*\r\n\r\n## Brief change log\r\n\r\n  - *Adds aggregate API to Table and GroupedTable in table.scala and adds AggregatedTable in table.scala*\r\n  - *Added tests in AggregateTest, AggregateITCase, AggregateStringExpressionTest, AggregateValidationTest*\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n*(example:)*\r\n  - *Added tests in AggregateTest, AggregateITCase, AggregateStringExpressionTest, AggregateValidationTest*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes)\r\n  - If yes, how is the feature documented? (docs)\r\n","created_at":"2018-12-05T05:13:55Z","updated_at":"2018-12-12T04:19:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10dac1030f4a4939a204b788548fe28beb9d0fc8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/7235/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/7235/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/7235/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/c67aa646bb0938c51f284d1890759259ce1915ea","head":{"label":"dianfu:agg","ref":"agg","sha":"c67aa646bb0938c51f284d1890759259ce1915ea","user":{"login":"dianfu","id":5466492,"node_id":"MDQ6VXNlcjU0NjY0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5466492?v=4","gravatar_id":"","url":"https://api.github.com/users/dianfu","html_url":"https://github.com/dianfu","followers_url":"https://api.github.com/users/dianfu/followers","following_url":"https://api.github.com/users/dianfu/following{/other_user}","gists_url":"https://api.github.com/users/dianfu/gists{/gist_id}","starred_url":"https://api.github.com/users/dianfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianfu/subscriptions","organizations_url":"https://api.github.com/users/dianfu/orgs","repos_url":"https://api.github.com/users/dianfu/repos","events_url":"https://api.github.com/users/dianfu/events{/privacy}","received_events_url":"https://api.github.com/users/dianfu/received_events","type":"User","site_admin":false},"repo":{"id":93816928,"node_id":"MDEwOlJlcG9zaXRvcnk5MzgxNjkyOA==","name":"flink","full_name":"dianfu/flink","private":false,"owner":{"login":"dianfu","id":5466492,"node_id":"MDQ6VXNlcjU0NjY0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5466492?v=4","gravatar_id":"","url":"https://api.github.com/users/dianfu","html_url":"https://github.com/dianfu","followers_url":"https://api.github.com/users/dianfu/followers","following_url":"https://api.github.com/users/dianfu/following{/other_user}","gists_url":"https://api.github.com/users/dianfu/gists{/gist_id}","starred_url":"https://api.github.com/users/dianfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianfu/subscriptions","organizations_url":"https://api.github.com/users/dianfu/orgs","repos_url":"https://api.github.com/users/dianfu/repos","events_url":"https://api.github.com/users/dianfu/events{/privacy}","received_events_url":"https://api.github.com/users/dianfu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dianfu/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/dianfu/flink","forks_url":"https://api.github.com/repos/dianfu/flink/forks","keys_url":"https://api.github.com/repos/dianfu/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dianfu/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dianfu/flink/teams","hooks_url":"https://api.github.com/repos/dianfu/flink/hooks","issue_events_url":"https://api.github.com/repos/dianfu/flink/issues/events{/number}","events_url":"https://api.github.com/repos/dianfu/flink/events","assignees_url":"https://api.github.com/repos/dianfu/flink/assignees{/user}","branches_url":"https://api.github.com/repos/dianfu/flink/branches{/branch}","tags_url":"https://api.github.com/repos/dianfu/flink/tags","blobs_url":"https://api.github.com/repos/dianfu/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dianfu/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dianfu/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/dianfu/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dianfu/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/dianfu/flink/languages","stargazers_url":"https://api.github.com/repos/dianfu/flink/stargazers","contributors_url":"https://api.github.com/repos/dianfu/flink/contributors","subscribers_url":"https://api.github.com/repos/dianfu/flink/subscribers","subscription_url":"https://api.github.com/repos/dianfu/flink/subscription","commits_url":"https://api.github.com/repos/dianfu/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/dianfu/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/dianfu/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/dianfu/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/dianfu/flink/contents/{+path}","compare_url":"https://api.github.com/repos/dianfu/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dianfu/flink/merges","archive_url":"https://api.github.com/repos/dianfu/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dianfu/flink/downloads","issues_url":"https://api.github.com/repos/dianfu/flink/issues{/number}","pulls_url":"https://api.github.com/repos/dianfu/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/dianfu/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/dianfu/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dianfu/flink/labels{/name}","releases_url":"https://api.github.com/repos/dianfu/flink/releases{/id}","deployments_url":"https://api.github.com/repos/dianfu/flink/deployments","created_at":"2017-06-09T03:54:59Z","updated_at":"2018-11-20T07:18:08Z","pushed_at":"2018-12-12T04:09:03Z","git_url":"git://github.com/dianfu/flink.git","ssh_url":"git@github.com:dianfu/flink.git","clone_url":"https://github.com/dianfu/flink.git","svn_url":"https://github.com/dianfu/flink","homepage":null,"size":165819,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bf5dc6c8bac73e7f8d54e983be2080cf6ce48a94","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-12-12T03:37:26Z","pushed_at":"2018-12-12T04:09:05Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":171626,"stargazers_count":5249,"watchers_count":5249,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3244,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3244,"open_issues":425,"watchers":5249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/7235"},"html":{"href":"https://github.com/apache/flink/pull/7235"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/7235"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/7235/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/7235/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/7235/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/c67aa646bb0938c51f284d1890759259ce1915ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hequn8128"}}