{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/brigade/issues/469","repository_url":"https://api.github.com/repos/Azure/brigade","labels_url":"https://api.github.com/repos/Azure/brigade/issues/469/labels{/name}","comments_url":"https://api.github.com/repos/Azure/brigade/issues/469/comments","events_url":"https://api.github.com/repos/Azure/brigade/issues/469/events","html_url":"https://github.com/Azure/brigade/issues/469","id":325443055,"node_id":"MDU6SXNzdWUzMjU0NDMwNTU=","number":469,"title":"If a Job.env{} var is empty, it will cause a Kubernetes error","user":{"login":"technosophos","id":89193,"node_id":"MDQ6VXNlcjg5MTkz","avatar_url":"https://avatars1.githubusercontent.com/u/89193?v=4","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"labels":[{"id":728799837,"node_id":"MDU6TGFiZWw3Mjg3OTk4Mzc=","url":"https://api.github.com/repos/Azure/brigade/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-22T20:04:26Z","updated_at":"2018-10-02T21:29:26Z","closed_at":null,"author_association":"MEMBER","body":"Consider this:\r\n\r\n```javascript\r\nj = new Job(\"foo\", \"alpine:3.7\")\r\nj.env = {\r\n  foo: null\r\n}\r\n```\r\n\r\nThe above will create a Kubernetes pod with this in the env section:\r\n\r\n```json\r\n          {\r\n            \"name\": \"foo\",\r\n            \"valueFrom\": {}\r\n          }\r\n```\r\n\r\nThe above is invalid. It should be:\r\n\r\n```json\r\n          {\r\n            \"name\": \"foo\",\r\n            \"value\": \"\"\r\n          }\r\n```\r\n\r\nOr something else that is structurally allowed.\r\n\r\nThe code that generates this is in the worker's `k8s.ts` file somewhere."},"comment":{"url":"https://api.github.com/repos/Azure/brigade/issues/comments/426437123","html_url":"https://github.com/Azure/brigade/issues/469#issuecomment-426437123","issue_url":"https://api.github.com/repos/Azure/brigade/issues/469","id":426437123,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjQzNzEyMw==","user":{"login":"shubheksha","id":7693422,"node_id":"MDQ6VXNlcjc2OTM0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7693422?v=4","gravatar_id":"","url":"https://api.github.com/users/shubheksha","html_url":"https://github.com/shubheksha","followers_url":"https://api.github.com/users/shubheksha/followers","following_url":"https://api.github.com/users/shubheksha/following{/other_user}","gists_url":"https://api.github.com/users/shubheksha/gists{/gist_id}","starred_url":"https://api.github.com/users/shubheksha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubheksha/subscriptions","organizations_url":"https://api.github.com/users/shubheksha/orgs","repos_url":"https://api.github.com/users/shubheksha/repos","events_url":"https://api.github.com/users/shubheksha/events{/privacy}","received_events_url":"https://api.github.com/users/shubheksha/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T21:29:26Z","updated_at":"2018-10-02T21:29:26Z","author_association":"NONE","body":"I can pick this up!"}}
{"actor":{"display_login":"shubheksha"}}