{"action":"created","comment":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/comments/196868056","pull_request_review_id":130503504,"id":196868056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njg2ODA1Ng==","diff_hunk":"@@ -72,6 +72,7 @@ func TestCliStatForConduitNamespace(t *testing.T) {\n \n \tt.Run(\"test conduit stat namespace\", func(t *testing.T) {\n \t\terr := TestHelper.RetryFor(20*time.Second, func() error {\n+\t\t\tfmt.Println(\"HEREEEEE\")","path":"test/stat/stat_test.go","position":4,"original_position":4,"commit_id":"95de5acb9e88abda49801429f212360fef1cf96c","original_commit_id":"95de5acb9e88abda49801429f212360fef1cf96c","user":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"WHOOPS :D","created_at":"2018-06-20T17:15:55Z","updated_at":"2018-06-20T17:15:55Z","html_url":"https://github.com/runconduit/conduit/pull/1163#discussion_r196868056","pull_request_url":"https://api.github.com/repos/runconduit/conduit/pulls/1163","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments/196868056"},"html":{"href":"https://github.com/runconduit/conduit/pull/1163#discussion_r196868056"},"pull_request":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1163"}},"in_reply_to_id":196620653},"pull_request":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/1163","id":195993996,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTkzOTk2","html_url":"https://github.com/runconduit/conduit/pull/1163","diff_url":"https://github.com/runconduit/conduit/pull/1163.diff","patch_url":"https://github.com/runconduit/conduit/pull/1163.patch","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/1163","number":1163,"state":"open","locked":false,"title":"Don't allow api stat requests for named resources in --all-namespaces ","user":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"This follows `kubectl`, which also does not allow requesting named resources over all namespaces:\r\n\r\n```\r\n$ kubectl get po/foo --all-namespaces\r\nerror: a resource cannot be retrieved by name across all namespaces\r\n```\r\n\r\nThis PR also updates the Web API's behaviour to be in line with the CLI's. Both will now default to the `default` namespace if no namespace is specified.\r\n\r\nFixes #1159","created_at":"2018-06-20T00:38:03Z","updated_at":"2018-06-20T17:15:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68d76916846e257d8699995484f1c8ade7f9ef39","assignee":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"klingerf","id":9226,"node_id":"MDQ6VXNlcjkyMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9226?v=4","gravatar_id":"","url":"https://api.github.com/users/klingerf","html_url":"https://github.com/klingerf","followers_url":"https://api.github.com/users/klingerf/followers","following_url":"https://api.github.com/users/klingerf/following{/other_user}","gists_url":"https://api.github.com/users/klingerf/gists{/gist_id}","starred_url":"https://api.github.com/users/klingerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klingerf/subscriptions","organizations_url":"https://api.github.com/users/klingerf/orgs","repos_url":"https://api.github.com/users/klingerf/repos","events_url":"https://api.github.com/users/klingerf/events{/privacy}","received_events_url":"https://api.github.com/users/klingerf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":779475981,"node_id":"MDU6TGFiZWw3Nzk0NzU5ODE=","url":"https://api.github.com/repos/runconduit/conduit/labels/area/cli","name":"area/cli","color":"0052CC","default":false},{"id":777123402,"node_id":"MDU6TGFiZWw3NzcxMjM0MDI=","url":"https://api.github.com/repos/runconduit/conduit/labels/area/web","name":"area/web","color":"0052CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runconduit/conduit/pulls/1163/commits","review_comments_url":"https://api.github.com/repos/runconduit/conduit/pulls/1163/comments","review_comment_url":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/1163/comments","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/95de5acb9e88abda49801429f212360fef1cf96c","head":{"label":"runconduit:rmars/filter-irrelevant","ref":"rmars/filter-irrelevant","sha":"95de5acb9e88abda49801429f212360fef1cf96c","user":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-06-20T16:36:10Z","pushed_at":"2018-06-20T04:01:33Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":6197,"stargazers_count":1858,"watchers_count":1858,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":170,"watchers":1858,"default_branch":"master"}},"base":{"label":"runconduit:master","ref":"master","sha":"8ece9c450804e2ae0f062cfd8573219933b5364a","user":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-06-20T16:36:10Z","pushed_at":"2018-06-20T04:01:33Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":6197,"stargazers_count":1858,"watchers_count":1858,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":170,"watchers":1858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1163"},"html":{"href":"https://github.com/runconduit/conduit/pull/1163"},"issue":{"href":"https://api.github.com/repos/runconduit/conduit/issues/1163"},"comments":{"href":"https://api.github.com/repos/runconduit/conduit/issues/1163/comments"},"review_comments":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1163/comments"},"review_comment":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1163/commits"},"statuses":{"href":"https://api.github.com/repos/runconduit/conduit/statuses/95de5acb9e88abda49801429f212360fef1cf96c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rmars"}}