{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/n4js/pulls/comments/174086969","pull_request_review_id":103378425,"id":174086969,"diff_hunk":"@@ -0,0 +1,27 @@\n+/*","path":"tests/org.eclipse.n4js.spec.tests/xpect-tests/Ch05_04__Redefinition_of_Members/Req70_OverrideFieldFinal.n4js.xt","position":1,"original_position":1,"commit_id":"de2773ffc187e170ce465dc9964a5db2c4e499cc","original_commit_id":"de2773ffc187e170ce465dc9964a5db2c4e499cc","user":{"login":"qtran-n4","id":22659566,"avatar_url":"https://avatars3.githubusercontent.com/u/22659566?v=4","gravatar_id":"","url":"https://api.github.com/users/qtran-n4","html_url":"https://github.com/qtran-n4","followers_url":"https://api.github.com/users/qtran-n4/followers","following_url":"https://api.github.com/users/qtran-n4/following{/other_user}","gists_url":"https://api.github.com/users/qtran-n4/gists{/gist_id}","starred_url":"https://api.github.com/users/qtran-n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qtran-n4/subscriptions","organizations_url":"https://api.github.com/users/qtran-n4/orgs","repos_url":"https://api.github.com/users/qtran-n4/repos","events_url":"https://api.github.com/users/qtran-n4/events{/privacy}","received_events_url":"https://api.github.com/users/qtran-n4/received_events","type":"User","site_admin":false},"body":"This is not a review comment but general observation. It is interesting that as opposed to N4JS, if we redeclare a field in the subclass, a new field is created and this new field _shadows_ that field in the superclass.\r\n\r\n```java\r\n// JAVA CODE!\r\nclass A {\r\n\tpublic String field;\r\n\r\n\tpublic void foo() {\r\n\t\tfield = \"Something else\";\r\n\t}\r\n}\r\n\r\ninterface I {\r\n\tint field2 = 10;\r\n}\r\n\r\nclass B extends A implements I {\r\n\tpublic String field = \"hello\";\r\n\tfinal int field2 = 42;\r\n}\r\n\r\nclass C extends B {\r\n\r\n\tString field = \"hello\";\r\n\tint field2 = 42;\r\n}\r\n\r\npublic class Test {\r\n\tpublic static void main(String[] args) {\r\n\t\tB b = new B();\r\n\t\tb.foo();\r\n\t\tSystem.out.println(b.field);               // Output: hello\r\n\t\tSystem.out.println(((A) b).field);     //  Output: Something else\r\n\t}\r\n}\r\n```\r\n\r\n\r\n","created_at":"2018-03-13T10:52:55Z","updated_at":"2018-03-13T10:52:56Z","html_url":"https://github.com/eclipse/n4js/pull/684#discussion_r174086969","pull_request_url":"https://api.github.com/repos/eclipse/n4js/pulls/684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/comments/174086969"},"html":{"href":"https://github.com/eclipse/n4js/pull/684#discussion_r174086969"},"pull_request":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/n4js/pulls/684","id":174392112,"html_url":"https://github.com/eclipse/n4js/pull/684","diff_url":"https://github.com/eclipse/n4js/pull/684.diff","patch_url":"https://github.com/eclipse/n4js/pull/684.patch","issue_url":"https://api.github.com/repos/eclipse/n4js/issues/684","number":684,"state":"open","locked":false,"title":"GH-674: Validations for member redefinition handle @Final for fields incorrectly","user":{"login":"mor-n4","id":7124687,"avatar_url":"https://avatars1.githubusercontent.com/u/7124687?v=4","gravatar_id":"","url":"https://api.github.com/users/mor-n4","html_url":"https://github.com/mor-n4","followers_url":"https://api.github.com/users/mor-n4/followers","following_url":"https://api.github.com/users/mor-n4/following{/other_user}","gists_url":"https://api.github.com/users/mor-n4/gists{/gist_id}","starred_url":"https://api.github.com/users/mor-n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mor-n4/subscriptions","organizations_url":"https://api.github.com/users/mor-n4/orgs","repos_url":"https://api.github.com/users/mor-n4/repos","events_url":"https://api.github.com/users/mor-n4/events{/privacy}","received_events_url":"https://api.github.com/users/mor-n4/received_events","type":"User","site_admin":false},"body":"See #674.","created_at":"2018-03-12T14:52:11Z","updated_at":"2018-03-13T10:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1dfca6c5e51402c23cf54a6942bf3ce47667b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/n4js/pulls/684/commits","review_comments_url":"https://api.github.com/repos/eclipse/n4js/pulls/684/comments","review_comment_url":"https://api.github.com/repos/eclipse/n4js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/n4js/issues/684/comments","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/de2773ffc187e170ce465dc9964a5db2c4e499cc","head":{"label":"eclipse:GH-674","ref":"GH-674","sha":"de2773ffc187e170ce465dc9964a5db2c4e499cc","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":87847606,"name":"n4js","full_name":"eclipse/n4js","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/n4js","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/n4js","forks_url":"https://api.github.com/repos/eclipse/n4js/forks","keys_url":"https://api.github.com/repos/eclipse/n4js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/n4js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/n4js/teams","hooks_url":"https://api.github.com/repos/eclipse/n4js/hooks","issue_events_url":"https://api.github.com/repos/eclipse/n4js/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/n4js/events","assignees_url":"https://api.github.com/repos/eclipse/n4js/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/n4js/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/n4js/tags","blobs_url":"https://api.github.com/repos/eclipse/n4js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/n4js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/n4js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/n4js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/n4js/languages","stargazers_url":"https://api.github.com/repos/eclipse/n4js/stargazers","contributors_url":"https://api.github.com/repos/eclipse/n4js/contributors","subscribers_url":"https://api.github.com/repos/eclipse/n4js/subscribers","subscription_url":"https://api.github.com/repos/eclipse/n4js/subscription","commits_url":"https://api.github.com/repos/eclipse/n4js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/n4js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/n4js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/n4js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/n4js/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/n4js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/n4js/merges","archive_url":"https://api.github.com/repos/eclipse/n4js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/n4js/downloads","issues_url":"https://api.github.com/repos/eclipse/n4js/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/n4js/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/n4js/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/n4js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/n4js/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/n4js/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/n4js/deployments","created_at":"2017-04-10T19:05:37Z","updated_at":"2018-03-13T10:52:55Z","pushed_at":"2018-03-13T09:29:05Z","git_url":"git://github.com/eclipse/n4js.git","ssh_url":"git@github.com:eclipse/n4js.git","clone_url":"https://github.com/eclipse/n4js.git","svn_url":"https://github.com/eclipse/n4js","homepage":null,"size":45688,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":6,"open_issues":187,"watchers":7,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"61c8ebbb15333303a08d0089fa95b3628d767082","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":87847606,"name":"n4js","full_name":"eclipse/n4js","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/n4js","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/n4js","forks_url":"https://api.github.com/repos/eclipse/n4js/forks","keys_url":"https://api.github.com/repos/eclipse/n4js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/n4js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/n4js/teams","hooks_url":"https://api.github.com/repos/eclipse/n4js/hooks","issue_events_url":"https://api.github.com/repos/eclipse/n4js/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/n4js/events","assignees_url":"https://api.github.com/repos/eclipse/n4js/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/n4js/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/n4js/tags","blobs_url":"https://api.github.com/repos/eclipse/n4js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/n4js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/n4js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/n4js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/n4js/languages","stargazers_url":"https://api.github.com/repos/eclipse/n4js/stargazers","contributors_url":"https://api.github.com/repos/eclipse/n4js/contributors","subscribers_url":"https://api.github.com/repos/eclipse/n4js/subscribers","subscription_url":"https://api.github.com/repos/eclipse/n4js/subscription","commits_url":"https://api.github.com/repos/eclipse/n4js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/n4js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/n4js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/n4js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/n4js/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/n4js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/n4js/merges","archive_url":"https://api.github.com/repos/eclipse/n4js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/n4js/downloads","issues_url":"https://api.github.com/repos/eclipse/n4js/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/n4js/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/n4js/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/n4js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/n4js/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/n4js/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/n4js/deployments","created_at":"2017-04-10T19:05:37Z","updated_at":"2018-03-13T10:52:55Z","pushed_at":"2018-03-13T09:29:05Z","git_url":"git://github.com/eclipse/n4js.git","ssh_url":"git@github.com:eclipse/n4js.git","clone_url":"https://github.com/eclipse/n4js.git","svn_url":"https://github.com/eclipse/n4js","homepage":null,"size":45688,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":6,"open_issues":187,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/684"},"html":{"href":"https://github.com/eclipse/n4js/pull/684"},"issue":{"href":"https://api.github.com/repos/eclipse/n4js/issues/684"},"comments":{"href":"https://api.github.com/repos/eclipse/n4js/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/n4js/statuses/de2773ffc187e170ce465dc9964a5db2c4e499cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qtran-n4"}}