{"action":"created","comment":{"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/comments/217474174","pull_request_review_id":155194903,"id":217474174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ3NDE3NA==","diff_hunk":"@@ -78,7 +78,9 @@ public function stringify(){\n \t\t}\n \n \t\t$charset = $this->getCharset();\n-\n+\t\t\n+\t\t/* xml attributes need to have certain characters escaped to be w3c compliant */\n+\t\t$titleSafe = htmlspecialchars($title);","path":"formats/MrssFormat.php","position":7,"original_position":7,"commit_id":"d3ae4d07b91edab2f461d76037ae4a0a78f03414","original_commit_id":"d3ae4d07b91edab2f461d76037ae4a0a78f03414","user":{"login":"LogMANOriginal","id":5776685,"node_id":"MDQ6VXNlcjU3NzY2ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/5776685?v=4","gravatar_id":"","url":"https://api.github.com/users/LogMANOriginal","html_url":"https://github.com/LogMANOriginal","followers_url":"https://api.github.com/users/LogMANOriginal/followers","following_url":"https://api.github.com/users/LogMANOriginal/following{/other_user}","gists_url":"https://api.github.com/users/LogMANOriginal/gists{/gist_id}","starred_url":"https://api.github.com/users/LogMANOriginal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogMANOriginal/subscriptions","organizations_url":"https://api.github.com/users/LogMANOriginal/orgs","repos_url":"https://api.github.com/users/LogMANOriginal/repos","events_url":"https://api.github.com/users/LogMANOriginal/events{/privacy}","received_events_url":"https://api.github.com/users/LogMANOriginal/received_events","type":"User","site_admin":false},"body":"The variable name should reflect its use, like `imageTitle`. Additionally, make sure to only encode double quotes, so other items don't get encoded as well (like \"<\" turning into \"&lt\"). You can use the [`ENT_COMPAT`](http://php.net/manual/en/function.htmlspecialchars.php) flag for that:\r\n\r\n```PHP\r\n$imageTitle = htmlspecialchars($title, ENT_COMPAT);\r\n```\r\n\r\n>Will convert double-quotes and leave single-quotes alone.\r\n>\r\n>-- http://php.net/manual/en/function.htmlspecialchars.php","created_at":"2018-09-13T17:42:26Z","updated_at":"2018-09-13T17:49:13Z","html_url":"https://github.com/RSS-Bridge/rss-bridge/pull/813#discussion_r217474174","pull_request_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/comments/217474174"},"html":{"href":"https://github.com/RSS-Bridge/rss-bridge/pull/813#discussion_r217474174"},"pull_request":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813","id":214115933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTE1OTMz","html_url":"https://github.com/RSS-Bridge/rss-bridge/pull/813","diff_url":"https://github.com/RSS-Bridge/rss-bridge/pull/813.diff","patch_url":"https://github.com/RSS-Bridge/rss-bridge/pull/813.patch","issue_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/813","number":813,"state":"open","locked":false,"title":"[MrssFormat.php] make sure feed is w3c compliant","user":{"login":"matthewseal","id":12375446,"node_id":"MDQ6VXNlcjEyMzc1NDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/12375446?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewseal","html_url":"https://github.com/matthewseal","followers_url":"https://api.github.com/users/matthewseal/followers","following_url":"https://api.github.com/users/matthewseal/following{/other_user}","gists_url":"https://api.github.com/users/matthewseal/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewseal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewseal/subscriptions","organizations_url":"https://api.github.com/users/matthewseal/orgs","repos_url":"https://api.github.com/users/matthewseal/repos","events_url":"https://api.github.com/users/matthewseal/events{/privacy}","received_events_url":"https://api.github.com/users/matthewseal/received_events","type":"User","site_admin":false},"body":"xml attributes need to have certain characters escaped to be valid\r\nthe title attribute in this case sometimes has double quotes in it\r\n\r\nInitial pull request was #798 but that was a dirty fix and only for the Youtube bridge, this one is for all Mrss feeds","created_at":"2018-09-08T21:41:36Z","updated_at":"2018-09-13T17:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf6e26fd4afd4aa90367cd5260aa645bad983a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813/commits","review_comments_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813/comments","review_comment_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/813/comments","statuses_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/statuses/d3ae4d07b91edab2f461d76037ae4a0a78f03414","head":{"label":"matthewseal:master","ref":"master","sha":"d3ae4d07b91edab2f461d76037ae4a0a78f03414","user":{"login":"matthewseal","id":12375446,"node_id":"MDQ6VXNlcjEyMzc1NDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/12375446?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewseal","html_url":"https://github.com/matthewseal","followers_url":"https://api.github.com/users/matthewseal/followers","following_url":"https://api.github.com/users/matthewseal/following{/other_user}","gists_url":"https://api.github.com/users/matthewseal/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewseal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewseal/subscriptions","organizations_url":"https://api.github.com/users/matthewseal/orgs","repos_url":"https://api.github.com/users/matthewseal/repos","events_url":"https://api.github.com/users/matthewseal/events{/privacy}","received_events_url":"https://api.github.com/users/matthewseal/received_events","type":"User","site_admin":false},"repo":{"id":147971022,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5NzEwMjI=","name":"rss-bridge","full_name":"matthewseal/rss-bridge","owner":{"login":"matthewseal","id":12375446,"node_id":"MDQ6VXNlcjEyMzc1NDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/12375446?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewseal","html_url":"https://github.com/matthewseal","followers_url":"https://api.github.com/users/matthewseal/followers","following_url":"https://api.github.com/users/matthewseal/following{/other_user}","gists_url":"https://api.github.com/users/matthewseal/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewseal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewseal/subscriptions","organizations_url":"https://api.github.com/users/matthewseal/orgs","repos_url":"https://api.github.com/users/matthewseal/repos","events_url":"https://api.github.com/users/matthewseal/events{/privacy}","received_events_url":"https://api.github.com/users/matthewseal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewseal/rss-bridge","description":"The RSS feed for websites missing it","fork":true,"url":"https://api.github.com/repos/matthewseal/rss-bridge","forks_url":"https://api.github.com/repos/matthewseal/rss-bridge/forks","keys_url":"https://api.github.com/repos/matthewseal/rss-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewseal/rss-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewseal/rss-bridge/teams","hooks_url":"https://api.github.com/repos/matthewseal/rss-bridge/hooks","issue_events_url":"https://api.github.com/repos/matthewseal/rss-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/matthewseal/rss-bridge/events","assignees_url":"https://api.github.com/repos/matthewseal/rss-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/matthewseal/rss-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/matthewseal/rss-bridge/tags","blobs_url":"https://api.github.com/repos/matthewseal/rss-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewseal/rss-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewseal/rss-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewseal/rss-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewseal/rss-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewseal/rss-bridge/languages","stargazers_url":"https://api.github.com/repos/matthewseal/rss-bridge/stargazers","contributors_url":"https://api.github.com/repos/matthewseal/rss-bridge/contributors","subscribers_url":"https://api.github.com/repos/matthewseal/rss-bridge/subscribers","subscription_url":"https://api.github.com/repos/matthewseal/rss-bridge/subscription","commits_url":"https://api.github.com/repos/matthewseal/rss-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewseal/rss-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewseal/rss-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewseal/rss-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewseal/rss-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/matthewseal/rss-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewseal/rss-bridge/merges","archive_url":"https://api.github.com/repos/matthewseal/rss-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewseal/rss-bridge/downloads","issues_url":"https://api.github.com/repos/matthewseal/rss-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/matthewseal/rss-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewseal/rss-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewseal/rss-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewseal/rss-bridge/labels{/name}","releases_url":"https://api.github.com/repos/matthewseal/rss-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/matthewseal/rss-bridge/deployments","created_at":"2018-09-08T21:25:15Z","updated_at":"2018-09-08T21:39:39Z","pushed_at":"2018-09-08T21:39:37Z","git_url":"git://github.com/matthewseal/rss-bridge.git","ssh_url":"git@github.com:matthewseal/rss-bridge.git","clone_url":"https://github.com/matthewseal/rss-bridge.git","svn_url":"https://github.com/matthewseal/rss-bridge","homepage":null,"size":2091,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RSS-Bridge:master","ref":"master","sha":"a3f99c9c3ff7aebc6552cb1eead1c2a041f54078","user":{"login":"RSS-Bridge","id":20958263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU4MjYz","avatar_url":"https://avatars3.githubusercontent.com/u/20958263?v=4","gravatar_id":"","url":"https://api.github.com/users/RSS-Bridge","html_url":"https://github.com/RSS-Bridge","followers_url":"https://api.github.com/users/RSS-Bridge/followers","following_url":"https://api.github.com/users/RSS-Bridge/following{/other_user}","gists_url":"https://api.github.com/users/RSS-Bridge/gists{/gist_id}","starred_url":"https://api.github.com/users/RSS-Bridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RSS-Bridge/subscriptions","organizations_url":"https://api.github.com/users/RSS-Bridge/orgs","repos_url":"https://api.github.com/users/RSS-Bridge/repos","events_url":"https://api.github.com/users/RSS-Bridge/events{/privacy}","received_events_url":"https://api.github.com/users/RSS-Bridge/received_events","type":"Organization","site_admin":false},"repo":{"id":11935508,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkzNTUwOA==","name":"rss-bridge","full_name":"RSS-Bridge/rss-bridge","owner":{"login":"RSS-Bridge","id":20958263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU4MjYz","avatar_url":"https://avatars3.githubusercontent.com/u/20958263?v=4","gravatar_id":"","url":"https://api.github.com/users/RSS-Bridge","html_url":"https://github.com/RSS-Bridge","followers_url":"https://api.github.com/users/RSS-Bridge/followers","following_url":"https://api.github.com/users/RSS-Bridge/following{/other_user}","gists_url":"https://api.github.com/users/RSS-Bridge/gists{/gist_id}","starred_url":"https://api.github.com/users/RSS-Bridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RSS-Bridge/subscriptions","organizations_url":"https://api.github.com/users/RSS-Bridge/orgs","repos_url":"https://api.github.com/users/RSS-Bridge/repos","events_url":"https://api.github.com/users/RSS-Bridge/events{/privacy}","received_events_url":"https://api.github.com/users/RSS-Bridge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RSS-Bridge/rss-bridge","description":"The RSS feed for websites missing it","fork":false,"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge","forks_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/forks","keys_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/teams","hooks_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/hooks","issue_events_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/events","assignees_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/tags","blobs_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/languages","stargazers_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/stargazers","contributors_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/contributors","subscribers_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/subscribers","subscription_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/subscription","commits_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/merges","archive_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/downloads","issues_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/labels{/name}","releases_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/deployments","created_at":"2013-08-06T21:55:13Z","updated_at":"2018-09-13T15:46:39Z","pushed_at":"2018-09-13T16:42:21Z","git_url":"git://github.com/RSS-Bridge/rss-bridge.git","ssh_url":"git@github.com:RSS-Bridge/rss-bridge.git","clone_url":"https://github.com/RSS-Bridge/rss-bridge.git","svn_url":"https://github.com/RSS-Bridge/rss-bridge","homepage":null,"size":2169,"stargazers_count":1210,"watchers_count":1210,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":218,"open_issues":64,"watchers":1210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813"},"html":{"href":"https://github.com/RSS-Bridge/rss-bridge/pull/813"},"issue":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/813"},"comments":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/RSS-Bridge/rss-bridge/statuses/d3ae4d07b91edab2f461d76037ae4a0a78f03414"}},"author_association":"NONE"}}
{"actor":{"display_login":"LogMANOriginal"}}