{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/223307277","pull_request_review_id":162398938,"id":223307277,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzMwNzI3Nw==","diff_hunk":"@@ -0,0 +1,218 @@\n+package privval\n+\n+import (\n+\t\"io\"\n+\t\"net\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\tcmn \"github.com/tendermint/tendermint/libs/common\"\n+\t\"github.com/tendermint/tendermint/libs/log\"\n+\t\"github.com/tendermint/tendermint/types\"\n+)\n+\n+// IPCPV implements PrivValidator, it uses a unix socket to request signatures\n+// from an external process.\n+type IPCPV struct {\n+\tcmn.BaseService\n+\t*RemoteSignerClient\n+\n+\taddr string\n+\n+\tconnTimeout time.Duration\n+\n+\tlock       sync.Mutex\n+\tcancelPing chan bool\n+}\n+\n+// Check that IPCPV implements PrivValidator.\n+var _ types.PrivValidator = (*IPCPV)(nil)\n+\n+// NewIPCPV returns an instance of IPCPV.\n+func NewIPCPV(\n+\tlogger log.Logger,\n+\tsocketAddr string,\n+) *IPCPV {\n+\tsc := &IPCPV{\n+\t\taddr:        socketAddr,\n+\t\tconnTimeout: connTimeout,\n+\t}\n+\n+\tsc.BaseService = *cmn.NewBaseService(logger, \"IPCPV\", sc)\n+\tsc.RemoteSignerClient = NewRemoteSignerClient(logger, nil)\n+\n+\treturn sc\n+}\n+\n+// OnStart implements cmn.Service.\n+func (sc *IPCPV) OnStart() error {\n+\terr := sc.connect()\n+\tif err != nil {\n+\t\terr = cmn.ErrorWrap(err, \"failed to connect\")\n+\t\tsc.Logger.Error(\n+\t\t\t\"OnStart\",\n+\t\t\t\"err\", err,\n+\t\t)\n+\n+\t\treturn err\n+\t}\n+\n+\terr = sc.RemoteSignerClient.Start()\n+\tif err != nil {\n+\t\terr = cmn.ErrorWrap(err, \"failed to start RemoteSignerClient\")\n+\t\tsc.Logger.Error(\n+\t\t\t\"OnStart\",\n+\t\t\t\"err\", err,\n+\t\t)\n+\n+\t\treturn err\n+\t}\n+\n+\treturn nil\n+}\n+\n+// OnStop implements cmn.Service.\n+func (sc *IPCPV) OnStop() {\n+\tif err := sc.RemoteSignerClient.Stop(); err != nil {\n+\t\terr = cmn.ErrorWrap(err, \"failed to stop RemoteSignerClient\")\n+\t\tsc.Logger.Error(\n+\t\t\t\"OnStop\",\n+\t\t\t\"err\", err,\n+\t\t)\n+\t}\n+\n+\tif sc.conn != nil {\n+\t\tif err := sc.conn.Close(); err != nil {\n+\t\t\terr = cmn.ErrorWrap(err, \"failed to close connection\")\n+\t\t\tsc.Logger.Error(\n+\t\t\t\t\"OnStop\",\n+\t\t\t\t\"err\", err,\n+\t\t\t)\n+\t\t}\n+\t}\n+}\n+\n+func (sc *IPCPV) connect() error {\n+\tla, err := net.ResolveUnixAddr(\"unix\", sc.addr)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tconn, err := net.DialUnix(\"unix\", nil, la)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\t// Wrap in a timeoutConn\n+\tsc.conn = newTimeoutConn(conn, sc.connTimeout)\n+\n+\treturn nil\n+}\n+\n+//---------------------------------------------------------","path":"privval/ipc.go","position":112,"original_position":112,"commit_id":"3e95047714f37fc4e023cad7d3fc96b19e430216","original_commit_id":"3e95047714f37fc4e023cad7d3fc96b19e430216","user":{"login":"Slamper","id":1405758,"node_id":"MDQ6VXNlcjE0MDU3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1405758?v=4","gravatar_id":"","url":"https://api.github.com/users/Slamper","html_url":"https://github.com/Slamper","followers_url":"https://api.github.com/users/Slamper/followers","following_url":"https://api.github.com/users/Slamper/following{/other_user}","gists_url":"https://api.github.com/users/Slamper/gists{/gist_id}","starred_url":"https://api.github.com/users/Slamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slamper/subscriptions","organizations_url":"https://api.github.com/users/Slamper/orgs","repos_url":"https://api.github.com/users/Slamper/repos","events_url":"https://api.github.com/users/Slamper/events{/privacy}","received_events_url":"https://api.github.com/users/Slamper/received_events","type":"User","site_admin":false},"body":"Ok. I will also remove it from the existing socketpv","created_at":"2018-10-08T09:54:04Z","updated_at":"2018-10-08T09:54:04Z","html_url":"https://github.com/tendermint/tendermint/pull/2568#discussion_r223307277","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2568","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/223307277"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2568#discussion_r223307277"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2568"}},"in_reply_to_id":223283077},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2568","id":220951153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTUxMTUz","html_url":"https://github.com/tendermint/tendermint/pull/2568","diff_url":"https://github.com/tendermint/tendermint/pull/2568.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2568.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2568","number":2568,"state":"open","locked":false,"title":"privval: Add IPCPV and fix SocketPV","user":{"login":"Slamper","id":1405758,"node_id":"MDQ6VXNlcjE0MDU3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1405758?v=4","gravatar_id":"","url":"https://api.github.com/users/Slamper","html_url":"https://github.com/Slamper","followers_url":"https://api.github.com/users/Slamper/followers","following_url":"https://api.github.com/users/Slamper/following{/other_user}","gists_url":"https://api.github.com/users/Slamper/gists{/gist_id}","starred_url":"https://api.github.com/users/Slamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slamper/subscriptions","organizations_url":"https://api.github.com/users/Slamper/orgs","repos_url":"https://api.github.com/users/Slamper/repos","events_url":"https://api.github.com/users/Slamper/events{/privacy}","received_events_url":"https://api.github.com/users/Slamper/received_events","type":"User","site_admin":false},"body":"Ref: #2563 \r\n\r\nI added IPC as an unencrypted alternative to SocketPV.\r\n\r\nBesides I fixed the following aspects of SocketPV:\r\n- Added locking since we are operating on a single socket\r\n- The connection deadline is extended every time a successful packet exchange happens; otherwise the connection would always die permanently x seconds after the connection was established.\r\n- Added a ping/heartbeat mechanism to keep the connection alive; native TCP keepalives do not work in this use-case\r\n\r\n* [ ] Updated all relevant documentation in docs\r\n* [X] Updated all code comments where relevant\r\n* [X] Wrote tests\r\n* [ ] Updated CHANGELOG_PENDING.md\r\n","created_at":"2018-10-07T14:24:05Z","updated_at":"2018-10-08T09:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4fbbad0bde1bf009d3626bcf7a503059615c8f4","assignee":{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},"assignees":[{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"melekes","id":1282182,"node_id":"MDQ6VXNlcjEyODIxODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1282182?v=4","gravatar_id":"","url":"https://api.github.com/users/melekes","html_url":"https://github.com/melekes","followers_url":"https://api.github.com/users/melekes/followers","following_url":"https://api.github.com/users/melekes/following{/other_user}","gists_url":"https://api.github.com/users/melekes/gists{/gist_id}","starred_url":"https://api.github.com/users/melekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melekes/subscriptions","organizations_url":"https://api.github.com/users/melekes/orgs","repos_url":"https://api.github.com/users/melekes/repos","events_url":"https://api.github.com/users/melekes/events{/privacy}","received_events_url":"https://api.github.com/users/melekes/received_events","type":"User","site_admin":false},{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},{"login":"Liamsi","id":7441766,"node_id":"MDQ6VXNlcjc0NDE3NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7441766?v=4","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2568/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2568/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2568/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/3e95047714f37fc4e023cad7d3fc96b19e430216","head":{"label":"certusone:develop","ref":"develop","sha":"3e95047714f37fc4e023cad7d3fc96b19e430216","user":{"login":"certusone","id":41452357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNDUyMzU3","avatar_url":"https://avatars1.githubusercontent.com/u/41452357?v=4","gravatar_id":"","url":"https://api.github.com/users/certusone","html_url":"https://github.com/certusone","followers_url":"https://api.github.com/users/certusone/followers","following_url":"https://api.github.com/users/certusone/following{/other_user}","gists_url":"https://api.github.com/users/certusone/gists{/gist_id}","starred_url":"https://api.github.com/users/certusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certusone/subscriptions","organizations_url":"https://api.github.com/users/certusone/orgs","repos_url":"https://api.github.com/users/certusone/repos","events_url":"https://api.github.com/users/certusone/events{/privacy}","received_events_url":"https://api.github.com/users/certusone/received_events","type":"Organization","site_admin":false},"repo":{"id":151949097,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5NDkwOTc=","name":"tendermint","full_name":"certusone/tendermint","private":false,"owner":{"login":"certusone","id":41452357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNDUyMzU3","avatar_url":"https://avatars1.githubusercontent.com/u/41452357?v=4","gravatar_id":"","url":"https://api.github.com/users/certusone","html_url":"https://github.com/certusone","followers_url":"https://api.github.com/users/certusone/followers","following_url":"https://api.github.com/users/certusone/following{/other_user}","gists_url":"https://api.github.com/users/certusone/gists{/gist_id}","starred_url":"https://api.github.com/users/certusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certusone/subscriptions","organizations_url":"https://api.github.com/users/certusone/orgs","repos_url":"https://api.github.com/users/certusone/repos","events_url":"https://api.github.com/users/certusone/events{/privacy}","received_events_url":"https://api.github.com/users/certusone/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/certusone/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":true,"url":"https://api.github.com/repos/certusone/tendermint","forks_url":"https://api.github.com/repos/certusone/tendermint/forks","keys_url":"https://api.github.com/repos/certusone/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certusone/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certusone/tendermint/teams","hooks_url":"https://api.github.com/repos/certusone/tendermint/hooks","issue_events_url":"https://api.github.com/repos/certusone/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/certusone/tendermint/events","assignees_url":"https://api.github.com/repos/certusone/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/certusone/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/certusone/tendermint/tags","blobs_url":"https://api.github.com/repos/certusone/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certusone/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certusone/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/certusone/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certusone/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/certusone/tendermint/languages","stargazers_url":"https://api.github.com/repos/certusone/tendermint/stargazers","contributors_url":"https://api.github.com/repos/certusone/tendermint/contributors","subscribers_url":"https://api.github.com/repos/certusone/tendermint/subscribers","subscription_url":"https://api.github.com/repos/certusone/tendermint/subscription","commits_url":"https://api.github.com/repos/certusone/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/certusone/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/certusone/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/certusone/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/certusone/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/certusone/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certusone/tendermint/merges","archive_url":"https://api.github.com/repos/certusone/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certusone/tendermint/downloads","issues_url":"https://api.github.com/repos/certusone/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/certusone/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/certusone/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/certusone/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certusone/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/certusone/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/certusone/tendermint/deployments","created_at":"2018-10-07T14:18:32Z","updated_at":"2018-10-07T14:18:36Z","pushed_at":"2018-10-07T18:05:28Z","git_url":"git://github.com/certusone/tendermint.git","ssh_url":"git@github.com:certusone/tendermint.git","clone_url":"https://github.com/certusone/tendermint.git","svn_url":"https://github.com/certusone/tendermint","homepage":"https://tendermint.com/","size":51468,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"1d8348d70750fe5a942f5ed3997a13bf68c463f0","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","private":false,"owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-10-08T06:25:43Z","pushed_at":"2018-10-08T08:32:56Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51469,"stargazers_count":2363,"watchers_count":2363,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":582,"mirror_url":null,"archived":false,"open_issues_count":325,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":582,"open_issues":325,"watchers":2363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2568"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2568"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2568"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2568/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2568/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2568/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/3e95047714f37fc4e023cad7d3fc96b19e430216"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Slamper"}}