{"action":"opened","number":1767,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1767","id":241868420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODY4NDIw","html_url":"https://github.com/puppetlabs/facter/pull/1767","diff_url":"https://github.com/puppetlabs/facter/pull/1767.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1767.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1767","number":1767,"state":"open","locked":false,"title":"(FACT-1900) Only check for `sysnative` if we are running under Wow64","user":{"login":"branan","id":37594,"node_id":"MDQ6VXNlcjM3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37594?v=4","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"body":"Previously, facter would check for the existence of\r\n`%sysroot%\\sysnative` and assume it was the correct system32 directory\r\nif it exists. This is incorrect if that directory has somehow been\r\ncreated as a normal directory in the normal filesystem.\r\n\r\nInstead, we should just check for whether we are running under WOW64,\r\nand spit out the correct directory based on that query.","created_at":"2019-01-02T22:53:05Z","updated_at":"2019-01-02T22:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1767/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1767/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1767/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/bfcee1bdbb2134559c99faa60a0a0aec4c21d7b0","head":{"label":"branan:system32_wow64","ref":"system32_wow64","sha":"bfcee1bdbb2134559c99faa60a0a0aec4c21d7b0","user":{"login":"branan","id":37594,"node_id":"MDQ6VXNlcjM3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37594?v=4","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"repo":{"id":14342682,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MjY4Mg==","name":"facter","full_name":"branan/facter","private":false,"owner":{"login":"branan","id":37594,"node_id":"MDQ6VXNlcjM3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37594?v=4","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/branan/facter","description":null,"fork":true,"url":"https://api.github.com/repos/branan/facter","forks_url":"https://api.github.com/repos/branan/facter/forks","keys_url":"https://api.github.com/repos/branan/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branan/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branan/facter/teams","hooks_url":"https://api.github.com/repos/branan/facter/hooks","issue_events_url":"https://api.github.com/repos/branan/facter/issues/events{/number}","events_url":"https://api.github.com/repos/branan/facter/events","assignees_url":"https://api.github.com/repos/branan/facter/assignees{/user}","branches_url":"https://api.github.com/repos/branan/facter/branches{/branch}","tags_url":"https://api.github.com/repos/branan/facter/tags","blobs_url":"https://api.github.com/repos/branan/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branan/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branan/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/branan/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branan/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/branan/facter/languages","stargazers_url":"https://api.github.com/repos/branan/facter/stargazers","contributors_url":"https://api.github.com/repos/branan/facter/contributors","subscribers_url":"https://api.github.com/repos/branan/facter/subscribers","subscription_url":"https://api.github.com/repos/branan/facter/subscription","commits_url":"https://api.github.com/repos/branan/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/branan/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/branan/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/branan/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/branan/facter/contents/{+path}","compare_url":"https://api.github.com/repos/branan/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branan/facter/merges","archive_url":"https://api.github.com/repos/branan/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branan/facter/downloads","issues_url":"https://api.github.com/repos/branan/facter/issues{/number}","pulls_url":"https://api.github.com/repos/branan/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/branan/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/branan/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branan/facter/labels{/name}","releases_url":"https://api.github.com/repos/branan/facter/releases{/id}","deployments_url":"https://api.github.com/repos/branan/facter/deployments","created_at":"2013-11-12T19:25:37Z","updated_at":"2015-12-17T18:00:48Z","pushed_at":"2019-01-02T22:52:40Z","git_url":"git://github.com/branan/facter.git","ssh_url":"git@github.com:branan/facter.git","clone_url":"https://github.com/branan/facter.git","svn_url":"https://github.com/branan/facter","homepage":"http://projects.puppetlabs.com/projects/facter","size":12468,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"7d3ac67c281703f86616378217c1a949e4b78d53","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NTc=","name":"facter","full_name":"puppetlabs/facter","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2018-12-19T20:01:23Z","pushed_at":"2018-12-20T23:52:12Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":14033,"stargazers_count":524,"watchers_count":524,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":439,"open_issues":15,"watchers":524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1767"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1767"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1767"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1767/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1767/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1767/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/bfcee1bdbb2134559c99faa60a0a0aec4c21d7b0"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":9,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"branan"}}