{"action":"closed","number":1075,"pull_request":{"url":"https://api.github.com/repos/twisted/twisted/pulls/1075","id":220863089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODYzMDg5","html_url":"https://github.com/twisted/twisted/pull/1075","diff_url":"https://github.com/twisted/twisted/pull/1075.diff","patch_url":"https://github.com/twisted/twisted/pull/1075.patch","issue_url":"https://api.github.com/repos/twisted/twisted/issues/1075","number":1075,"state":"closed","locked":false,"title":"[8831] Make Conch use `cryptography` for DH","user":{"login":"wiml","id":156891,"node_id":"MDQ6VXNlcjE1Njg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/156891?v=4","gravatar_id":"","url":"https://api.github.com/users/wiml","html_url":"https://github.com/wiml","followers_url":"https://api.github.com/users/wiml/followers","following_url":"https://api.github.com/users/wiml/following{/other_user}","gists_url":"https://api.github.com/users/wiml/gists{/gist_id}","starred_url":"https://api.github.com/users/wiml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiml/subscriptions","organizations_url":"https://api.github.com/users/wiml/orgs","repos_url":"https://api.github.com/users/wiml/repos","events_url":"https://api.github.com/users/wiml/events{/privacy}","received_events_url":"https://api.github.com/users/wiml/received_events","type":"User","site_admin":false},"body":"Not exactly a frequently used algorithm any more, but this moves the DH implementation and (more importantly from a security standpoint, I think) the key generation into `cryptography` (and therefore into openssl).\r\n\r\n## Contributor Checklist:\r\n\r\n* [X] There is an associated ticket in Trac: https://twistedmatrix.com/trac/ticket/8831\r\n* [X] The changes pass minimal style checks (see: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#GettingYourPatchAccepted )\r\n* [X] I have created a newsfragment in src/twisted/newsfragments/\r\n* [X] I have updated the automated tests.\r\n","created_at":"2018-10-06T03:57:58Z","updated_at":"2018-10-13T23:31:00Z","closed_at":"2018-10-13T23:31:00Z","merged_at":"2018-10-13T23:31:00Z","merge_commit_sha":"3c88cc43579501b6eeaaff027ac6c7bddf040b89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"markrwilliams","id":704247,"node_id":"MDQ6VXNlcjcwNDI0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/704247?v=4","gravatar_id":"","url":"https://api.github.com/users/markrwilliams","html_url":"https://github.com/markrwilliams","followers_url":"https://api.github.com/users/markrwilliams/followers","following_url":"https://api.github.com/users/markrwilliams/following{/other_user}","gists_url":"https://api.github.com/users/markrwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/markrwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrwilliams/subscriptions","organizations_url":"https://api.github.com/users/markrwilliams/orgs","repos_url":"https://api.github.com/users/markrwilliams/repos","events_url":"https://api.github.com/users/markrwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/markrwilliams/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twisted/twisted/pulls/1075/commits","review_comments_url":"https://api.github.com/repos/twisted/twisted/pulls/1075/comments","review_comment_url":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/twisted/issues/1075/comments","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/9d8449700c960dd649f3d26419cbc5ca313559da","head":{"label":"twisted:8831-conch-diffie-hellman","ref":"8831-conch-diffie-hellman","sha":"9d8449700c960dd649f3d26419cbc5ca313559da","user":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzU4","name":"twisted","full_name":"twisted/twisted","private":false,"owner":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2018-10-13T14:38:42Z","pushed_at":"2018-10-13T23:31:00Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":59145,"stargazers_count":2958,"watchers_count":2958,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":799,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":799,"open_issues":94,"watchers":2958,"default_branch":"trunk"}},"base":{"label":"twisted:trunk","ref":"trunk","sha":"b49c78ca9e200507b86be5a460912150132850f3","user":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzU4","name":"twisted","full_name":"twisted/twisted","private":false,"owner":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2018-10-13T14:38:42Z","pushed_at":"2018-10-13T23:31:00Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":59145,"stargazers_count":2958,"watchers_count":2958,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":799,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":799,"open_issues":94,"watchers":2958,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1075"},"html":{"href":"https://github.com/twisted/twisted/pull/1075"},"issue":{"href":"https://api.github.com/repos/twisted/twisted/issues/1075"},"comments":{"href":"https://api.github.com/repos/twisted/twisted/issues/1075/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1075/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1075/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/twisted/statuses/9d8449700c960dd649f3d26419cbc5ca313559da"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"twm","id":43662,"node_id":"MDQ6VXNlcjQzNjYy","avatar_url":"https://avatars2.githubusercontent.com/u/43662?v=4","gravatar_id":"","url":"https://api.github.com/users/twm","html_url":"https://github.com/twm","followers_url":"https://api.github.com/users/twm/followers","following_url":"https://api.github.com/users/twm/following{/other_user}","gists_url":"https://api.github.com/users/twm/gists{/gist_id}","starred_url":"https://api.github.com/users/twm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twm/subscriptions","organizations_url":"https://api.github.com/users/twm/orgs","repos_url":"https://api.github.com/users/twm/repos","events_url":"https://api.github.com/users/twm/events{/privacy}","received_events_url":"https://api.github.com/users/twm/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":236,"deletions":213,"changed_files":4}}
{"actor":{"display_login":"twm"}}