{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7923","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7923/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7923/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7923/events","html_url":"https://github.com/coq/coq/pull/7923","id":335709540,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzM5NjUw","number":7923,"title":"Documentation for custom entries","user":{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"labels":[{"id":762376854,"node_id":"MDU6TGFiZWw3NjIzNzY4NTQ=","url":"https://api.github.com/repos/coq/coq/labels/needs:%20merge%20of%20dependency","name":"needs: merge of dependency","color":"cc3b6b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-26T08:23:07Z","updated_at":"2018-06-30T12:22:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7923","html_url":"https://github.com/coq/coq/pull/7923","diff_url":"https://github.com/coq/coq/pull/7923.diff","patch_url":"https://github.com/coq/coq/pull/7923.patch"},"body":"**Kind:** documentation / fine-tuning\r\n\r\n~~This collects the part of #6247 which needs some more work (documentation + decide how involved the example of the documentation can be).~~ This extends #6247 with documentation, fixes and improved support for \"grammar coercions\".\r\n\r\n- [X] Documentation in reference manual\r\n- [X] Entry to be added in CHANGES\r\n- [X] Fine-tuning to make the example of the documentation working (parsing of parentheses, of identifiers, of rules without a symbol)\r\n- [ ] Feedback on documentation needed\r\n\r\nNote: This is on top of #6247."},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/401537842","html_url":"https://github.com/coq/coq/pull/7923#issuecomment-401537842","issue_url":"https://api.github.com/repos/coq/coq/issues/7923","id":401537842,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTUzNzg0Mg==","user":{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T12:22:52Z","updated_at":"2018-06-30T12:22:52Z","author_association":"MEMBER","body":"Even if there are still possible improvements to do in style (*), the documentation seems now ok in terms of contents. Feedback is welcome.\r\n\r\nThe design of the custom entry feature seems to stabilize with a realistic example shown in the manual. The \"ident\" and \"parentheses\" features discussed in #6247 are implemented by means of \"grammar coercions\". The \"field\" feature (@andres-erbsen [here](https://github.com/coq/coq/pull/6247#issuecomment-395241913) and [here](https://github.com/coq/coq/pull/6247#issuecomment-401097675)), maybe generally the availability of any `g_prim` entry, is not done.\r\n\r\n(*) e.g. non systematic use of `cmd::`, alternance of a \"pedagogical\" style with a \"factual\" style, terminology sometimes informal (can we more clearly define \"term\", \"expression\", \"entry\", \"grammar\", \"rule\", ...), not very smooth English, ..."}}
{"actor":{"display_login":"herbelin"}}