{"action":"created","comment":{"url":"https://api.github.com/repos/golang/protobuf/pulls/comments/173963322","pull_request_review_id":103238793,"id":173963322,"diff_hunk":"@@ -0,0 +1,4 @@\n+#!/bin/sh\n+\n+cd $(dirname $0)\n+exec go run conformance.go $*","path":"conformance/conformance.sh","position":4,"original_position":4,"commit_id":"d83a901cbb02bddbb9c750e1b83ee4fa5e9fcaff","original_commit_id":"d83a901cbb02bddbb9c750e1b83ee4fa5e9fcaff","user":{"login":"dsnet","id":6354026,"avatar_url":"https://avatars1.githubusercontent.com/u/6354026?v=4","gravatar_id":"","url":"https://api.github.com/users/dsnet","html_url":"https://github.com/dsnet","followers_url":"https://api.github.com/users/dsnet/followers","following_url":"https://api.github.com/users/dsnet/following{/other_user}","gists_url":"https://api.github.com/users/dsnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dsnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsnet/subscriptions","organizations_url":"https://api.github.com/users/dsnet/orgs","repos_url":"https://api.github.com/users/dsnet/repos","events_url":"https://api.github.com/users/dsnet/events{/privacy}","received_events_url":"https://api.github.com/users/dsnet/received_events","type":"User","site_admin":false},"body":"Also, what's the purpose of `$*`? The conformance.go program doesn't care about the input args.","created_at":"2018-03-12T22:10:26Z","updated_at":"2018-03-12T22:10:26Z","html_url":"https://github.com/golang/protobuf/pull/552#discussion_r173963322","pull_request_url":"https://api.github.com/repos/golang/protobuf/pulls/552","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/golang/protobuf/pulls/comments/173963322"},"html":{"href":"https://github.com/golang/protobuf/pull/552#discussion_r173963322"},"pull_request":{"href":"https://api.github.com/repos/golang/protobuf/pulls/552"}},"in_reply_to_id":173959629},"pull_request":{"url":"https://api.github.com/repos/golang/protobuf/pulls/552","id":174096610,"html_url":"https://github.com/golang/protobuf/pull/552","diff_url":"https://github.com/golang/protobuf/pull/552.diff","patch_url":"https://github.com/golang/protobuf/pull/552.patch","issue_url":"https://api.github.com/repos/golang/protobuf/issues/552","number":552,"state":"open","locked":false,"title":"conformance: clean up, fix conformance tests","user":{"login":"neild","id":52544,"avatar_url":"https://avatars1.githubusercontent.com/u/52544?v=4","gravatar_id":"","url":"https://api.github.com/users/neild","html_url":"https://github.com/neild","followers_url":"https://api.github.com/users/neild/followers","following_url":"https://api.github.com/users/neild/following{/other_user}","gists_url":"https://api.github.com/users/neild/gists{/gist_id}","starred_url":"https://api.github.com/users/neild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neild/subscriptions","organizations_url":"https://api.github.com/users/neild/orgs","repos_url":"https://api.github.com/users/neild/repos","events_url":"https://api.github.com/users/neild/events{/privacy}","received_events_url":"https://api.github.com/users/neild/received_events","type":"User","site_admin":false},"body":"Move _conformance directory to conformance. (The _ was apparently there\r\nto prevent \"go install ./...\" from touching that directory, which\r\ndoesn't seem like a sufficient reason to have a weird path name.)\r\n\r\nDelete conformance_proto directory, regenerate the proto at test time.\r\n(This proto is used for communications between the test runner and test\r\nprocess; nothing else needs it.)\r\n\r\nAdd a list of known failures.\r\n\r\nAdd a Makefile so that \"make test\" in the conformance directory does the\r\nright thing. (Requires that github.com/google/protobuf be installed\r\nsomewhere.) Include documentation in \"make all\" output. Skip tests if\r\nthe necessary dependencies don't exist.","created_at":"2018-03-09T20:06:46Z","updated_at":"2018-03-12T22:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"301aef1b5b9a57c8d438f31ca5cd66285c1c640c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/golang/protobuf/pulls/552/commits","review_comments_url":"https://api.github.com/repos/golang/protobuf/pulls/552/comments","review_comment_url":"https://api.github.com/repos/golang/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golang/protobuf/issues/552/comments","statuses_url":"https://api.github.com/repos/golang/protobuf/statuses/d83a901cbb02bddbb9c750e1b83ee4fa5e9fcaff","head":{"label":"neild:dev.conform","ref":"dev.conform","sha":"d83a901cbb02bddbb9c750e1b83ee4fa5e9fcaff","user":{"login":"neild","id":52544,"avatar_url":"https://avatars1.githubusercontent.com/u/52544?v=4","gravatar_id":"","url":"https://api.github.com/users/neild","html_url":"https://github.com/neild","followers_url":"https://api.github.com/users/neild/followers","following_url":"https://api.github.com/users/neild/following{/other_user}","gists_url":"https://api.github.com/users/neild/gists{/gist_id}","starred_url":"https://api.github.com/users/neild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neild/subscriptions","organizations_url":"https://api.github.com/users/neild/orgs","repos_url":"https://api.github.com/users/neild/repos","events_url":"https://api.github.com/users/neild/events{/privacy}","received_events_url":"https://api.github.com/users/neild/received_events","type":"User","site_admin":false},"repo":{"id":85211678,"name":"protobuf","full_name":"neild/protobuf","owner":{"login":"neild","id":52544,"avatar_url":"https://avatars1.githubusercontent.com/u/52544?v=4","gravatar_id":"","url":"https://api.github.com/users/neild","html_url":"https://github.com/neild","followers_url":"https://api.github.com/users/neild/followers","following_url":"https://api.github.com/users/neild/following{/other_user}","gists_url":"https://api.github.com/users/neild/gists{/gist_id}","starred_url":"https://api.github.com/users/neild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neild/subscriptions","organizations_url":"https://api.github.com/users/neild/orgs","repos_url":"https://api.github.com/users/neild/repos","events_url":"https://api.github.com/users/neild/events{/privacy}","received_events_url":"https://api.github.com/users/neild/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neild/protobuf","description":"Go support for Google's protocol buffers","fork":true,"url":"https://api.github.com/repos/neild/protobuf","forks_url":"https://api.github.com/repos/neild/protobuf/forks","keys_url":"https://api.github.com/repos/neild/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neild/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neild/protobuf/teams","hooks_url":"https://api.github.com/repos/neild/protobuf/hooks","issue_events_url":"https://api.github.com/repos/neild/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/neild/protobuf/events","assignees_url":"https://api.github.com/repos/neild/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/neild/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/neild/protobuf/tags","blobs_url":"https://api.github.com/repos/neild/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neild/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neild/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/neild/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neild/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/neild/protobuf/languages","stargazers_url":"https://api.github.com/repos/neild/protobuf/stargazers","contributors_url":"https://api.github.com/repos/neild/protobuf/contributors","subscribers_url":"https://api.github.com/repos/neild/protobuf/subscribers","subscription_url":"https://api.github.com/repos/neild/protobuf/subscription","commits_url":"https://api.github.com/repos/neild/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/neild/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/neild/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/neild/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/neild/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/neild/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neild/protobuf/merges","archive_url":"https://api.github.com/repos/neild/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neild/protobuf/downloads","issues_url":"https://api.github.com/repos/neild/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/neild/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/neild/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/neild/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neild/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/neild/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/neild/protobuf/deployments","created_at":"2017-03-16T15:29:12Z","updated_at":"2017-03-16T15:29:14Z","pushed_at":"2018-03-10T01:23:41Z","git_url":"git://github.com/neild/protobuf.git","ssh_url":"git@github.com:neild/protobuf.git","clone_url":"https://github.com/neild/protobuf.git","svn_url":"https://github.com/neild/protobuf","homepage":null,"size":3437,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"golang:dev","ref":"dev","sha":"12a586e0adaf626e5d2f8da7881f321f076dbe2c","user":{"login":"golang","id":4314092,"avatar_url":"https://avatars3.githubusercontent.com/u/4314092?v=4","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"repo":{"id":27051771,"name":"protobuf","full_name":"golang/protobuf","owner":{"login":"golang","id":4314092,"avatar_url":"https://avatars3.githubusercontent.com/u/4314092?v=4","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golang/protobuf","description":"Go support for Google's protocol buffers","fork":false,"url":"https://api.github.com/repos/golang/protobuf","forks_url":"https://api.github.com/repos/golang/protobuf/forks","keys_url":"https://api.github.com/repos/golang/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golang/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golang/protobuf/teams","hooks_url":"https://api.github.com/repos/golang/protobuf/hooks","issue_events_url":"https://api.github.com/repos/golang/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/golang/protobuf/events","assignees_url":"https://api.github.com/repos/golang/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/golang/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/golang/protobuf/tags","blobs_url":"https://api.github.com/repos/golang/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golang/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golang/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/golang/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golang/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/golang/protobuf/languages","stargazers_url":"https://api.github.com/repos/golang/protobuf/stargazers","contributors_url":"https://api.github.com/repos/golang/protobuf/contributors","subscribers_url":"https://api.github.com/repos/golang/protobuf/subscribers","subscription_url":"https://api.github.com/repos/golang/protobuf/subscription","commits_url":"https://api.github.com/repos/golang/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/golang/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/golang/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/golang/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/golang/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/golang/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golang/protobuf/merges","archive_url":"https://api.github.com/repos/golang/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golang/protobuf/downloads","issues_url":"https://api.github.com/repos/golang/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/golang/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/golang/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/golang/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golang/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/golang/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/golang/protobuf/deployments","created_at":"2014-11-23T23:07:23Z","updated_at":"2018-03-12T19:58:00Z","pushed_at":"2018-03-12T20:28:39Z","git_url":"git://github.com/golang/protobuf.git","ssh_url":"git@github.com:golang/protobuf.git","clone_url":"https://github.com/golang/protobuf.git","svn_url":"https://github.com/golang/protobuf","homepage":null,"size":3371,"stargazers_count":2677,"watchers_count":2677,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":610,"open_issues":62,"watchers":2677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golang/protobuf/pulls/552"},"html":{"href":"https://github.com/golang/protobuf/pull/552"},"issue":{"href":"https://api.github.com/repos/golang/protobuf/issues/552"},"comments":{"href":"https://api.github.com/repos/golang/protobuf/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/golang/protobuf/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/golang/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golang/protobuf/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/golang/protobuf/statuses/d83a901cbb02bddbb9c750e1b83ee4fa5e9fcaff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dsnet"}}