{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/833","repository_url":"https://api.github.com/repos/alphagov/govuk-frontend","labels_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/833/comments","events_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/833/events","html_url":"https://github.com/alphagov/govuk-frontend/pull/833","id":335450981,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTQ2NTg2","number":833,"title":"Fix failing Heroku deployment","user":{"login":"igloosi","id":3758555,"node_id":"MDQ6VXNlcjM3NTg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3758555?v=4","gravatar_id":"","url":"https://api.github.com/users/igloosi","html_url":"https://github.com/igloosi","followers_url":"https://api.github.com/users/igloosi/followers","following_url":"https://api.github.com/users/igloosi/following{/other_user}","gists_url":"https://api.github.com/users/igloosi/gists{/gist_id}","starred_url":"https://api.github.com/users/igloosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igloosi/subscriptions","organizations_url":"https://api.github.com/users/igloosi/orgs","repos_url":"https://api.github.com/users/igloosi/repos","events_url":"https://api.github.com/users/igloosi/events{/privacy}","received_events_url":"https://api.github.com/users/igloosi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-25T15:13:57Z","updated_at":"2018-06-26T08:01:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/pulls/833","html_url":"https://github.com/alphagov/govuk-frontend/pull/833","diff_url":"https://github.com/alphagov/govuk-frontend/pull/833.diff","patch_url":"https://github.com/alphagov/govuk-frontend/pull/833.patch"},"body":"Heroku used Node 10.5, built and deployed correctly\r\n```\r\nInstalling binaries\r\nengines.node (package.json):  >= 8.9.4\r\nengines.npm (package.json):   unspecified (use default)\r\n       \r\nResolving node version >= 8.9.4...\r\nDownloading and installing node 10.5.0...\r\nUsing default npm version: 6.1.0\r\n\r\nCaching build\r\n       Clearing previous node cache\r\n       Skipping cache save (disabled by config)\r\n-----> Pruning devDependencies\r\n       Skipping because NPM_CONFIG_PRODUCTION is 'false'\r\n-----> Build succeeded!\r\n-----> Discovering process types\r\n       Procfile declares types -> web\r\n-----> Compressing...\r\n       Done: 144.1M\r\n-----> Launching...\r\n       Released v517\r\n       https://govuk-frontend-review.herokuapp.com/ deployed to Heroku\r\n```\r\n\r\nWhen requesting the site it threw a 503 error\r\n\r\n```\r\n2018-06-25T15:15:57.649864+00:00 heroku[router]: at=error code=H10 desc=\"App crashed\" method=GET path=\"/favicon.ico\" host=govuk-frontend-review.herokuapp.com request_id=180da83d-7c96-4c99-9a4e-52830e670538 fwd=\"195.89.171.5\" dyno= connect= service= status=503 bytes= protocol=http\r\n```\r\n\r\nFirstly we tried removing the space between number and greaterOrEqual sign, but that didn't work."},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/comments/400217493","html_url":"https://github.com/alphagov/govuk-frontend/pull/833#issuecomment-400217493","issue_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/833","id":400217493,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIxNzQ5Mw==","user":{"login":"igloosi","id":3758555,"node_id":"MDQ6VXNlcjM3NTg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3758555?v=4","gravatar_id":"","url":"https://api.github.com/users/igloosi","html_url":"https://github.com/igloosi","followers_url":"https://api.github.com/users/igloosi/followers","following_url":"https://api.github.com/users/igloosi/following{/other_user}","gists_url":"https://api.github.com/users/igloosi/gists{/gist_id}","starred_url":"https://api.github.com/users/igloosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igloosi/subscriptions","organizations_url":"https://api.github.com/users/igloosi/orgs","repos_url":"https://api.github.com/users/igloosi/repos","events_url":"https://api.github.com/users/igloosi/events{/privacy}","received_events_url":"https://api.github.com/users/igloosi/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:01:59Z","updated_at":"2018-06-26T08:01:59Z","author_association":"CONTRIBUTOR","body":"Update 10.5.0 fails with this\r\n```\r\ngulp[88868]: ../src/node_contextify.cc:629:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.\r\n 1: 0x100033c31 node::Abort() [/usr/local/bin/node]\r\n 2: 0x100032c77 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) [/usr/local/bin/node]\r\n 3: 0x100058a4b node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]\r\n 4: 0x10022822f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node]\r\n 5: 0x1002273c8 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]\r\n 6: 0x100226d97 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]\r\n 7: 0x3eb7788041bd\r\nsh: line 1: 88868 Abort trap: 6           gulp copy-assets\r\n```"}}
{"actor":{"display_login":"igloosi"}}