{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/223067086","pull_request_review_id":162111540,"id":223067086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzA2NzA4Ng==","diff_hunk":"@@ -1,4 +1,4 @@\n-from hashlib import blake2b\n+from hashlib import blake2b  # type: ignore","path":"eth/utils/blake.py","position":2,"original_position":2,"commit_id":"df73159790b9ff3616c2f64ce88d0cf42c691b07","original_commit_id":"df73159790b9ff3616c2f64ce88d0cf42c691b07","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"Can you add a comment explaining why we have to `type: ignore` this.","created_at":"2018-10-05T16:29:42Z","updated_at":"2018-10-05T16:29:47Z","html_url":"https://github.com/ethereum/py-evm/pull/1362#discussion_r223067086","pull_request_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1362","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/223067086"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1362#discussion_r223067086"},"pull_request":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1362"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/1362","id":220756520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzU2NTIw","html_url":"https://github.com/ethereum/py-evm/pull/1362","diff_url":"https://github.com/ethereum/py-evm/pull/1362.diff","patch_url":"https://github.com/ethereum/py-evm/pull/1362.patch","issue_url":"https://api.github.com/repos/ethereum/py-evm/issues/1362","number":1362,"state":"open","locked":false,"title":"Fix mypy tests for `eth` package","user":{"login":"hwwhww","id":9263930,"node_id":"MDQ6VXNlcjkyNjM5MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\nMypy tests were not being triggered for `eth` module.\r\n\r\n### How was it fixed?\r\n1. Fixed CircleCI setting\r\n2. Fixed some type hints errors\r\n\r\n#### Cute Animal Picture\r\n\r\n![halloween](https://user-images.githubusercontent.com/9263930/46547025-441f8e80-c8fd-11e8-8fe2-2f85c41b959d.jpg)","created_at":"2018-10-05T16:23:54Z","updated_at":"2018-10-05T16:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83e7c3c4be626638dccfc2f07547a54b618d777b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1362/commits","review_comments_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1362/comments","review_comment_url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/py-evm/issues/1362/comments","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/df73159790b9ff3616c2f64ce88d0cf42c691b07","head":{"label":"hwwhww:fix_mypy_ci","ref":"fix_mypy_ci","sha":"df73159790b9ff3616c2f64ce88d0cf42c691b07","user":{"login":"hwwhww","id":9263930,"node_id":"MDQ6VXNlcjkyNjM5MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"repo":{"id":112237812,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyMzc4MTI=","name":"py-evm","full_name":"hwwhww/py-evm","private":false,"owner":{"login":"hwwhww","id":9263930,"node_id":"MDQ6VXNlcjkyNjM5MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hwwhww/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":true,"url":"https://api.github.com/repos/hwwhww/py-evm","forks_url":"https://api.github.com/repos/hwwhww/py-evm/forks","keys_url":"https://api.github.com/repos/hwwhww/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hwwhww/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hwwhww/py-evm/teams","hooks_url":"https://api.github.com/repos/hwwhww/py-evm/hooks","issue_events_url":"https://api.github.com/repos/hwwhww/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/hwwhww/py-evm/events","assignees_url":"https://api.github.com/repos/hwwhww/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/hwwhww/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/hwwhww/py-evm/tags","blobs_url":"https://api.github.com/repos/hwwhww/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hwwhww/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hwwhww/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hwwhww/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hwwhww/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/hwwhww/py-evm/languages","stargazers_url":"https://api.github.com/repos/hwwhww/py-evm/stargazers","contributors_url":"https://api.github.com/repos/hwwhww/py-evm/contributors","subscribers_url":"https://api.github.com/repos/hwwhww/py-evm/subscribers","subscription_url":"https://api.github.com/repos/hwwhww/py-evm/subscription","commits_url":"https://api.github.com/repos/hwwhww/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hwwhww/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hwwhww/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hwwhww/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hwwhww/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/hwwhww/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hwwhww/py-evm/merges","archive_url":"https://api.github.com/repos/hwwhww/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hwwhww/py-evm/downloads","issues_url":"https://api.github.com/repos/hwwhww/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/hwwhww/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/hwwhww/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/hwwhww/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hwwhww/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/hwwhww/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/hwwhww/py-evm/deployments","created_at":"2017-11-27T19:17:15Z","updated_at":"2018-09-28T16:22:02Z","pushed_at":"2018-10-05T16:17:18Z","git_url":"git://github.com/hwwhww/py-evm.git","ssh_url":"git@github.com:hwwhww/py-evm.git","clone_url":"https://github.com/hwwhww/py-evm.git","svn_url":"https://github.com/hwwhww/py-evm","homepage":"","size":7399,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"3061a48d112b2ae7d94adec89000372dd4bcac2c","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":77478378,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ3ODM3OA==","name":"py-evm","full_name":"ethereum/py-evm","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":false,"url":"https://api.github.com/repos/ethereum/py-evm","forks_url":"https://api.github.com/repos/ethereum/py-evm/forks","keys_url":"https://api.github.com/repos/ethereum/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/py-evm/teams","hooks_url":"https://api.github.com/repos/ethereum/py-evm/hooks","issue_events_url":"https://api.github.com/repos/ethereum/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/py-evm/events","assignees_url":"https://api.github.com/repos/ethereum/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/py-evm/tags","blobs_url":"https://api.github.com/repos/ethereum/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/py-evm/languages","stargazers_url":"https://api.github.com/repos/ethereum/py-evm/stargazers","contributors_url":"https://api.github.com/repos/ethereum/py-evm/contributors","subscribers_url":"https://api.github.com/repos/ethereum/py-evm/subscribers","subscription_url":"https://api.github.com/repos/ethereum/py-evm/subscription","commits_url":"https://api.github.com/repos/ethereum/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/py-evm/merges","archive_url":"https://api.github.com/repos/ethereum/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/py-evm/downloads","issues_url":"https://api.github.com/repos/ethereum/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/py-evm/deployments","created_at":"2016-12-27T19:36:00Z","updated_at":"2018-10-05T13:54:36Z","pushed_at":"2018-10-05T16:23:55Z","git_url":"git://github.com/ethereum/py-evm.git","ssh_url":"git@github.com:ethereum/py-evm.git","clone_url":"https://github.com/ethereum/py-evm.git","svn_url":"https://github.com/ethereum/py-evm","homepage":"https://trinity.ethereum.org/","size":5634,"stargazers_count":690,"watchers_count":690,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":300,"open_issues":111,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1362"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1362"},"issue":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1362"},"comments":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1362/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1362/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1362/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/py-evm/statuses/df73159790b9ff3616c2f64ce88d0cf42c691b07"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pipermerriam"}}