{"action":"created","issue":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/24","repository_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java","labels_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/24/comments","events_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/24/events","html_url":"https://github.com/folio-org/mod-kb-ebsco-java/pull/24","id":374371272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDg4MDk4","number":24,"title":"MODKBEKBJ-34 - Adjust RAML for Titles endpoint to conform to JSON API","user":{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false},"labels":[{"id":1080293309,"node_id":"MDU6TGFiZWwxMDgwMjkzMzA5","url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/labels/epam-internal-review","name":"epam-internal-review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false},"assignees":[{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-26T12:55:23Z","updated_at":"2018-10-30T11:57:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/pulls/24","html_url":"https://github.com/folio-org/mod-kb-ebsco-java/pull/24","diff_url":"https://github.com/folio-org/mod-kb-ebsco-java/pull/24.diff","patch_url":"https://github.com/folio-org/mod-kb-ebsco-java/pull/24.patch"},"body":"* updated raml files for title endpoints\r\n\r\n## Purpose\r\nPer https://issues.folio.org/browse/MODKBEKBJ-34,  we want to tweak RAML and put together JSON schema that supports requests/responses for various /eholdings/titles endpoints conforming to JSON API schema. \r\n\r\n## Approach\r\n* organize raml directory\r\n* tweak json schema for the following endpoints:\r\n  * GET and POST for /eholdings/titles\r\n  * GET /eholdings/titles/{titleId}\r\n\r\n## TODOS and Open Questions\r\n\r\nThe types 'visibilityData' and 'proxy' caused Jenkins errors because they were created not as classes but interfaces by RMB which is not acceptable for models.\r\nAs a temporal solution, I had to comment on those types which cause messages from lint-raml-cop.\r\n\r\n- [ ] ramls/packages.raml should be fixed with https://issues.folio.org/browse/MODKBEKBJ-22\r\n- [ ] ramls/resources.raml should be fixed with https://issues.folio.org/browse/MODKBEKBJ-29\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/comments/434272709","html_url":"https://github.com/folio-org/mod-kb-ebsco-java/pull/24#issuecomment-434272709","issue_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco-java/issues/24","id":434272709,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDI3MjcwOQ==","user":{"login":"id-jenkins","id":16718781,"node_id":"MDQ6VXNlcjE2NzE4Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/16718781?v=4","gravatar_id":"","url":"https://api.github.com/users/id-jenkins","html_url":"https://github.com/id-jenkins","followers_url":"https://api.github.com/users/id-jenkins/followers","following_url":"https://api.github.com/users/id-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/id-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/id-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/id-jenkins/subscriptions","organizations_url":"https://api.github.com/users/id-jenkins/orgs","repos_url":"https://api.github.com/users/id-jenkins/repos","events_url":"https://api.github.com/users/id-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/id-jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T11:57:55Z","updated_at":"2018-10-30T11:57:55Z","author_association":"NONE","body":"<html><body><pre>\nINFO: lint-raml-cop: Investigating mod-kb-ebsco-java/ramls\nINFO: lint-raml-cop: Using submodule ramls/raml-util at 1d92b1079e865cd5830f49d73c21a9a27f1800e0\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/providers\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/packages\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/status\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/resources\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/titles\nINFO: lint-raml-cop: Looking for JSON schema files: ./ramls/types/configuration\nINFO: lint-raml-cop: Assessing schema files (FOLIO-1447):\nINFO: lint-raml-cop: types/embargo.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/relationshipData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/jsonapi.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/included.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/metaIncluded.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/contributor.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/metaTotalResults.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/token.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/tokenPut.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/identifier.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/visibilityData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/proxy.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/proxyPut.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/subject.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/relationships.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/coverage.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/provider.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerPutData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerListDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerPutRequest.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providers.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerPutDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/providers/providerCollection.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/packages/packageDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/packages/packages.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/packages/packageCollection.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/status/status.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/status/statusAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/status/statusData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/resources/resources.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/resources/resourceDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/resources/resourcesRelationships.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titlePostIncludedPackageId.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titleData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titlePostIncludedPackages.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titlePostData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titleListDataAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/title.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titleCollection.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titleRelationship.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titles.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/titles/titlePostRequest.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configurationAttributes.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configurationUnprocessableError.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configurationUnprocessableErrorResponse.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configuration.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configurationPutRequest.json: Each property \"description\" is present.\nINFO: lint-raml-cop: types/configuration/configurationData.json: Each property \"description\" is present.\nINFO: lint-raml-cop: Assessing RAML files:\nINFO: lint-raml-cop: Processing RAML v1.0 file: eholdings.raml\nINFO: lint-raml-cop:   raml-cop did not detect any errors with eholdings.raml\nINFO: lint-raml-cop: Processing RAML v1.0 file: packages.raml\nERROR: lint-raml-cop:   raml-cop detected errors with packages.raml:\n[ramls/packages.raml:272:10] WARNING Unknown property: 'visibilityData'\n[ramls/packages.raml:272:10] WARNING Unknown property: 'proxy'\n\nINFO: lint-raml-cop: Processing RAML v1.0 file: providers.raml\nINFO: lint-raml-cop:   raml-cop did not detect any errors with providers.raml\nINFO: lint-raml-cop: Processing RAML v1.0 file: resources.raml\nERROR: lint-raml-cop:   raml-cop detected errors with resources.raml:\n[ramls/resources.raml:308:10] WARNING Unknown property: 'visibilityData'\n[ramls/resources.raml:308:10] WARNING Unknown property: 'proxy'\n\nINFO: lint-raml-cop: Processing RAML v1.0 file: titles.raml\nINFO: lint-raml-cop:   raml-cop did not detect any errors with titles.raml\nERROR: lint-raml-cop: There were processing errors. See list above.\n</pre><body></html>\n"}}
{"actor":{"display_login":"id-jenkins"}}