{"action":"opened","number":50,"pull_request":{"url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50","id":179836486,"html_url":"https://github.com/KAIST-IS521/2018s-onion-team6/pull/50","diff_url":"https://github.com/KAIST-IS521/2018s-onion-team6/pull/50.diff","patch_url":"https://github.com/KAIST-IS521/2018s-onion-team6/pull/50.patch","issue_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/50","number":50,"state":"open","locked":false,"title":"Report the bug in Json Parse","user":{"login":"zanywhale","id":26449129,"avatar_url":"https://avatars3.githubusercontent.com/u/26449129?v=4","gravatar_id":"","url":"https://api.github.com/users/zanywhale","html_url":"https://github.com/zanywhale","followers_url":"https://api.github.com/users/zanywhale/followers","following_url":"https://api.github.com/users/zanywhale/following{/other_user}","gists_url":"https://api.github.com/users/zanywhale/gists{/gist_id}","starred_url":"https://api.github.com/users/zanywhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanywhale/subscriptions","organizations_url":"https://api.github.com/users/zanywhale/orgs","repos_url":"https://api.github.com/users/zanywhale/repos","events_url":"https://api.github.com/users/zanywhale/events{/privacy}","received_events_url":"https://api.github.com/users/zanywhale/received_events","type":"User","site_admin":false},"body":"In `msgserver.cpp` There is a error handling source.\r\n```\r\n    reader->parse(msg.c_str(), msg.c_str()+msg.length(), &root, &errs);\r\n    if(errs.find(\"error\") != string::npos)\r\n    {\r\n        cout << \"[Error!] Not JSON Format\" << endl;\r\n        return 0;\r\n    }\r\n```\r\nBut it does not detect other kinds of errors.\r\nSo there is a case where Messenger is abnormally terminated due to lack of error handling in messenger.\r\n\r\n```\r\nnc 172.17.0.2 8888\r\n\"\"\r\n```\r\nThen Boom\r\n\r\n![image](https://user-images.githubusercontent.com/26449129/38399488-a5cbbf8a-3985-11e8-956d-ebe64c7d4846.png)\r\n","created_at":"2018-04-06T01:38:19Z","updated_at":"2018-04-06T01:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50/commits","review_comments_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50/comments","review_comment_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/50/comments","statuses_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/statuses/e7bb23d930f2735e3220a0041738e8c8b2735d6c","head":{"label":"zanywhale:json_parse_error","ref":"json_parse_error","sha":"e7bb23d930f2735e3220a0041738e8c8b2735d6c","user":{"login":"zanywhale","id":26449129,"avatar_url":"https://avatars3.githubusercontent.com/u/26449129?v=4","gravatar_id":"","url":"https://api.github.com/users/zanywhale","html_url":"https://github.com/zanywhale","followers_url":"https://api.github.com/users/zanywhale/followers","following_url":"https://api.github.com/users/zanywhale/following{/other_user}","gists_url":"https://api.github.com/users/zanywhale/gists{/gist_id}","starred_url":"https://api.github.com/users/zanywhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanywhale/subscriptions","organizations_url":"https://api.github.com/users/zanywhale/orgs","repos_url":"https://api.github.com/users/zanywhale/repos","events_url":"https://api.github.com/users/zanywhale/events{/privacy}","received_events_url":"https://api.github.com/users/zanywhale/received_events","type":"User","site_admin":false},"repo":{"id":128060922,"name":"2018s-onion-team6","full_name":"zanywhale/2018s-onion-team6","owner":{"login":"zanywhale","id":26449129,"avatar_url":"https://avatars3.githubusercontent.com/u/26449129?v=4","gravatar_id":"","url":"https://api.github.com/users/zanywhale","html_url":"https://github.com/zanywhale","followers_url":"https://api.github.com/users/zanywhale/followers","following_url":"https://api.github.com/users/zanywhale/following{/other_user}","gists_url":"https://api.github.com/users/zanywhale/gists{/gist_id}","starred_url":"https://api.github.com/users/zanywhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanywhale/subscriptions","organizations_url":"https://api.github.com/users/zanywhale/orgs","repos_url":"https://api.github.com/users/zanywhale/repos","events_url":"https://api.github.com/users/zanywhale/events{/privacy}","received_events_url":"https://api.github.com/users/zanywhale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zanywhale/2018s-onion-team6","description":null,"fork":true,"url":"https://api.github.com/repos/zanywhale/2018s-onion-team6","forks_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/forks","keys_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/teams","hooks_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/hooks","issue_events_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/issues/events{/number}","events_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/events","assignees_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/assignees{/user}","branches_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/branches{/branch}","tags_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/tags","blobs_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/statuses/{sha}","languages_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/languages","stargazers_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/stargazers","contributors_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/contributors","subscribers_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/subscribers","subscription_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/subscription","commits_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/contents/{+path}","compare_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/merges","archive_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/downloads","issues_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/issues{/number}","pulls_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/pulls{/number}","milestones_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/milestones{/number}","notifications_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/labels{/name}","releases_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/releases{/id}","deployments_url":"https://api.github.com/repos/zanywhale/2018s-onion-team6/deployments","created_at":"2018-04-04T12:46:11Z","updated_at":"2018-04-04T12:46:13Z","pushed_at":"2018-04-06T01:30:44Z","git_url":"git://github.com/zanywhale/2018s-onion-team6.git","ssh_url":"git@github.com:zanywhale/2018s-onion-team6.git","clone_url":"https://github.com/zanywhale/2018s-onion-team6.git","svn_url":"https://github.com/zanywhale/2018s-onion-team6","homepage":null,"size":1520,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KAIST-IS521:master","ref":"master","sha":"f641eb3a706b1bbef81a2139aa32e0eaf6927828","user":{"login":"KAIST-IS521","id":24927353,"avatar_url":"https://avatars2.githubusercontent.com/u/24927353?v=4","gravatar_id":"","url":"https://api.github.com/users/KAIST-IS521","html_url":"https://github.com/KAIST-IS521","followers_url":"https://api.github.com/users/KAIST-IS521/followers","following_url":"https://api.github.com/users/KAIST-IS521/following{/other_user}","gists_url":"https://api.github.com/users/KAIST-IS521/gists{/gist_id}","starred_url":"https://api.github.com/users/KAIST-IS521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KAIST-IS521/subscriptions","organizations_url":"https://api.github.com/users/KAIST-IS521/orgs","repos_url":"https://api.github.com/users/KAIST-IS521/repos","events_url":"https://api.github.com/users/KAIST-IS521/events{/privacy}","received_events_url":"https://api.github.com/users/KAIST-IS521/received_events","type":"Organization","site_admin":false},"repo":{"id":125777746,"name":"2018s-onion-team6","full_name":"KAIST-IS521/2018s-onion-team6","owner":{"login":"KAIST-IS521","id":24927353,"avatar_url":"https://avatars2.githubusercontent.com/u/24927353?v=4","gravatar_id":"","url":"https://api.github.com/users/KAIST-IS521","html_url":"https://github.com/KAIST-IS521","followers_url":"https://api.github.com/users/KAIST-IS521/followers","following_url":"https://api.github.com/users/KAIST-IS521/following{/other_user}","gists_url":"https://api.github.com/users/KAIST-IS521/gists{/gist_id}","starred_url":"https://api.github.com/users/KAIST-IS521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KAIST-IS521/subscriptions","organizations_url":"https://api.github.com/users/KAIST-IS521/orgs","repos_url":"https://api.github.com/users/KAIST-IS521/repos","events_url":"https://api.github.com/users/KAIST-IS521/events{/privacy}","received_events_url":"https://api.github.com/users/KAIST-IS521/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KAIST-IS521/2018s-onion-team6","description":null,"fork":false,"url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6","forks_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/forks","keys_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/teams","hooks_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/hooks","issue_events_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/events{/number}","events_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/events","assignees_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/assignees{/user}","branches_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/branches{/branch}","tags_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/tags","blobs_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/git/refs{/sha}","trees_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/statuses/{sha}","languages_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/languages","stargazers_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/stargazers","contributors_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/contributors","subscribers_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/subscribers","subscription_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/subscription","commits_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/commits{/sha}","git_commits_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/git/commits{/sha}","comments_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/comments{/number}","issue_comment_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/comments{/number}","contents_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/contents/{+path}","compare_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/merges","archive_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/downloads","issues_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues{/number}","pulls_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls{/number}","milestones_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/milestones{/number}","notifications_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/labels{/name}","releases_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/releases{/id}","deployments_url":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/deployments","created_at":"2018-03-18T23:36:36Z","updated_at":"2018-04-01T15:11:02Z","pushed_at":"2018-04-05T17:19:05Z","git_url":"git://github.com/KAIST-IS521/2018s-onion-team6.git","ssh_url":"git@github.com:KAIST-IS521/2018s-onion-team6.git","clone_url":"https://github.com/KAIST-IS521/2018s-onion-team6.git","svn_url":"https://github.com/KAIST-IS521/2018s-onion-team6","homepage":null,"size":1509,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50"},"html":{"href":"https://github.com/KAIST-IS521/2018s-onion-team6/pull/50"},"issue":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/50"},"comments":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/KAIST-IS521/2018s-onion-team6/statuses/e7bb23d930f2735e3220a0041738e8c8b2735d6c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"zanywhale"}}