{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/171083587","pull_request_review_id":99875049,"id":171083587,"diff_hunk":"@@ -11,6 +11,8 @@ import 'io.dart';\n import 'terminal.dart';\n import 'utils.dart';\n \n+const int kDefaultStatusPadding = 59;","path":"packages/flutter_tools/lib/src/base/logger.dart","position":4,"original_position":4,"commit_id":"91779d0c27cce475d6a534dbf039f94e76841714","original_commit_id":"428d79a5f5d5b25811418a21916201a33edf2fa8","user":{"login":"jcollins-g","id":14116827,"avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-02-27T22:09:26Z","updated_at":"2018-02-27T22:19:54Z","html_url":"https://github.com/flutter/flutter/pull/14783#discussion_r171083587","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/14783","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/171083587"},"html":{"href":"https://github.com/flutter/flutter/pull/14783#discussion_r171083587"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/14783"}},"in_reply_to_id":170398290},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/14783","id":170326075,"html_url":"https://github.com/flutter/flutter/pull/14783","diff_url":"https://github.com/flutter/flutter/pull/14783.diff","patch_url":"https://github.com/flutter/flutter/pull/14783.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/14783","number":14783,"state":"open","locked":false,"title":"Android license detector in doctor, take two","user":{"login":"jcollins-g","id":14116827,"avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"body":"Fixes #13584, for real this time.  This fixes all known problems with #14535, detailed [here](https://github.com/flutter/flutter/issues/13584#issuecomment-366051100).\r\n\r\nNew unit tests are included to exercise the features of the new AnsiSpinner as well as the old _AnsiStatus (now AnsiStatus).\r\n\r\nAdditionally, this fixes another problem where flutter doctor --android-licenses wouldn't work on MacOS (_sdkManagerEnv wasn't being set properly) and adjusts the offset for AnsiStatus so that progress indicators are shifted right enough for longer lines on update packages.\r\n\r\nBefore:\r\n<img width=\"482\" alt=\"before\" src=\"https://user-images.githubusercontent.com/14116827/36452492-aa30c23c-1649-11e8-9ef9-a32b60ee7c01.png\">\r\n\r\nAfter:\r\n<img width=\"428\" alt=\"after\" src=\"https://user-images.githubusercontent.com/14116827/36452495-af71d416-1649-11e8-8ca7-44d5227deca1.png\">\r\n","created_at":"2018-02-20T22:24:27Z","updated_at":"2018-02-27T22:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"417c428cc0647474543bc0efa3bf459d560b8170","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tvolkert","id":15253456,"avatar_url":"https://avatars0.githubusercontent.com/u/15253456?v=4","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/14783/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/14783/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/14783/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/91779d0c27cce475d6a534dbf039f94e76841714","head":{"label":"jcollins-g:fix-android-license-detector","ref":"fix-android-license-detector","sha":"91779d0c27cce475d6a534dbf039f94e76841714","user":{"login":"jcollins-g","id":14116827,"avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"repo":{"id":88872521,"name":"flutter","full_name":"jcollins-g/flutter","owner":{"login":"jcollins-g","id":14116827,"avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcollins-g/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/jcollins-g/flutter","forks_url":"https://api.github.com/repos/jcollins-g/flutter/forks","keys_url":"https://api.github.com/repos/jcollins-g/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcollins-g/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcollins-g/flutter/teams","hooks_url":"https://api.github.com/repos/jcollins-g/flutter/hooks","issue_events_url":"https://api.github.com/repos/jcollins-g/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jcollins-g/flutter/events","assignees_url":"https://api.github.com/repos/jcollins-g/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jcollins-g/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jcollins-g/flutter/tags","blobs_url":"https://api.github.com/repos/jcollins-g/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcollins-g/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcollins-g/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcollins-g/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcollins-g/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jcollins-g/flutter/languages","stargazers_url":"https://api.github.com/repos/jcollins-g/flutter/stargazers","contributors_url":"https://api.github.com/repos/jcollins-g/flutter/contributors","subscribers_url":"https://api.github.com/repos/jcollins-g/flutter/subscribers","subscription_url":"https://api.github.com/repos/jcollins-g/flutter/subscription","commits_url":"https://api.github.com/repos/jcollins-g/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcollins-g/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcollins-g/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcollins-g/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcollins-g/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jcollins-g/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcollins-g/flutter/merges","archive_url":"https://api.github.com/repos/jcollins-g/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcollins-g/flutter/downloads","issues_url":"https://api.github.com/repos/jcollins-g/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jcollins-g/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jcollins-g/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jcollins-g/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcollins-g/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jcollins-g/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jcollins-g/flutter/deployments","created_at":"2017-04-20T14:05:09Z","updated_at":"2017-04-20T14:05:14Z","pushed_at":"2018-02-27T22:10:22Z","git_url":"git://github.com/jcollins-g/flutter.git","ssh_url":"git@github.com:jcollins-g/flutter.git","clone_url":"https://github.com/jcollins-g/flutter.git","svn_url":"https://github.com/jcollins-g/flutter","homepage":"https://flutter.io","size":34888,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"5dca13dea598514a828ff5621a5f9810ba0446dd","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-02-27T22:18:26Z","pushed_at":"2018-02-27T22:10:24Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":34873,"stargazers_count":11492,"watchers_count":11492,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1048,"mirror_url":null,"archived":false,"open_issues_count":2316,"license":null,"forks":1048,"open_issues":2316,"watchers":11492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/14783"},"html":{"href":"https://github.com/flutter/flutter/pull/14783"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/14783"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/14783/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/14783/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/14783/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/91779d0c27cce475d6a534dbf039f94e76841714"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jcollins-g"}}