{"action":"created","issue":{"url":"https://api.github.com/repos/theia-ide/theia/issues/2001","repository_url":"https://api.github.com/repos/theia-ide/theia","labels_url":"https://api.github.com/repos/theia-ide/theia/issues/2001/labels{/name}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/2001/comments","events_url":"https://api.github.com/repos/theia-ide/theia/issues/2001/events","html_url":"https://github.com/theia-ide/theia/pull/2001","id":327712232,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDM4NDgy","number":2001,"title":"Define terminal api in the Theia core.","user":{"login":"AndrienkoAleksandr","id":6873095,"node_id":"MDQ6VXNlcjY4NzMwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6873095?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrienkoAleksandr","html_url":"https://github.com/AndrienkoAleksandr","followers_url":"https://api.github.com/users/AndrienkoAleksandr/followers","following_url":"https://api.github.com/users/AndrienkoAleksandr/following{/other_user}","gists_url":"https://api.github.com/users/AndrienkoAleksandr/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrienkoAleksandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrienkoAleksandr/subscriptions","organizations_url":"https://api.github.com/users/AndrienkoAleksandr/orgs","repos_url":"https://api.github.com/users/AndrienkoAleksandr/repos","events_url":"https://api.github.com/users/AndrienkoAleksandr/events{/privacy}","received_events_url":"https://api.github.com/users/AndrienkoAleksandr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-30T12:39:28Z","updated_at":"2018-06-05T11:46:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/2001","html_url":"https://github.com/theia-ide/theia/pull/2001","diff_url":"https://github.com/theia-ide/theia/pull/2001.diff","patch_url":"https://github.com/theia-ide/theia/pull/2001.patch"},"body":"Define terminal api in the Theia core.\r\nSupport set-up more parameters on terminal creation:\r\n - current working directory (cwd);\r\n - environment variables;\r\n - terminal shell path;\r\n - terminal shell arguments.\r\nAdd ability to display created terminal with delay, send text to the terminal.\r\n\r\nRelated issue: https://github.com/eclipse/che/issues/9595\r\nRelated pull request: https://github.com/theia-demo-plugins/wiptheia/pull/24\r\nHow it works with plugin model: https://youtu.be/_Y0zU7rYPpQ\r\n\r\nSigned-off-by: Oleksandr Andriienko <oandriie@redhat.com>"},"comment":{"url":"https://api.github.com/repos/theia-ide/theia/issues/comments/394679440","html_url":"https://github.com/theia-ide/theia/pull/2001#issuecomment-394679440","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/2001","id":394679440,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDY3OTQ0MA==","user":{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T11:46:12Z","updated_at":"2018-06-05T11:46:12Z","author_association":"MEMBER","body":"Thanks for the prompt reply, @akosyakov. Exactly, that's why I did not get in the beginning why we do this in `@theia/core`. Indeed, extracting the current implementation to an interface-based API is cool, and it helps people to replace/extend it easily, but why do we need to move the interfaces to `@theia/core` and cannot leave it `@theia/terminal`?"}}
{"actor":{"display_login":"kittaakos"}}