{"action":"created","issue":{"url":"https://api.github.com/repos/loveyacper/Qedis/issues/4","repository_url":"https://api.github.com/repos/loveyacper/Qedis","labels_url":"https://api.github.com/repos/loveyacper/Qedis/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/loveyacper/Qedis/issues/4/comments","events_url":"https://api.github.com/repos/loveyacper/Qedis/issues/4/events","html_url":"https://github.com/loveyacper/Qedis/issues/4","id":336884412,"node_id":"MDU6SXNzdWUzMzY4ODQ0MTI=","number":4,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"node_id":"MDQ6VXNlcjY2MDQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-29T06:55:05Z","updated_at":"2018-07-01T02:32:41Z","closed_at":null,"author_association":"NONE","body":"I would like to point out that identifiers like “[`_HandlePacket`](https://github.com/loveyacper/Qedis/blob/3cc0e4a1ecc48bbc55958559b1953c270ff10b06/QSentinel/QClusterClient.h#L26)” and “[`__ziplistDelete`](https://github.com/loveyacper/Qedis/blob/464a8500c3d3f0f9b4b42f351566a07466e64049/QedisCore/redisZipList.c#L529)” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier \"Do not declare an identifier which is reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/loveyacper/Qedis/issues/comments/401578801","html_url":"https://github.com/loveyacper/Qedis/issues/4#issuecomment-401578801","issue_url":"https://api.github.com/repos/loveyacper/Qedis/issues/4","id":401578801,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTU3ODgwMQ==","user":{"login":"loveyacper","id":1626303,"node_id":"MDQ6VXNlcjE2MjYzMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1626303?v=4","gravatar_id":"","url":"https://api.github.com/users/loveyacper","html_url":"https://github.com/loveyacper","followers_url":"https://api.github.com/users/loveyacper/followers","following_url":"https://api.github.com/users/loveyacper/following{/other_user}","gists_url":"https://api.github.com/users/loveyacper/gists{/gist_id}","starred_url":"https://api.github.com/users/loveyacper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loveyacper/subscriptions","organizations_url":"https://api.github.com/users/loveyacper/orgs","repos_url":"https://api.github.com/users/loveyacper/repos","events_url":"https://api.github.com/users/loveyacper/events{/privacy}","received_events_url":"https://api.github.com/users/loveyacper/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T02:32:41Z","updated_at":"2018-07-01T02:32:41Z","author_association":"OWNER","body":"The `redisIntSet.c` and `redisZipList.c` files are copied from redis source,  just for compatibility with redis, for Qedis can read RDB file generated by redis.\r\n\r\n`_HandlePacket` is the non-public member function's name.\r\nIf it's public, should be `HandlePacket`."}}
{"actor":{"display_login":"loveyacper"}}