{"action":"created","comment":{"url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/comments/184356622","pull_request_review_id":115534478,"id":184356622,"diff_hunk":"@@ -1,51 +1,55 @@\n-# Communicating within the iOS team\n+# Communicating With Your Colleagues","path":"COMMUNICATION.md","position":2,"original_position":2,"commit_id":"35a05a8af214624549cd6bf04d2bac319b23eb2c","original_commit_id":"35a05a8af214624549cd6bf04d2bac319b23eb2c","user":{"login":"designatednerd","id":1976498,"avatar_url":"https://avatars1.githubusercontent.com/u/1976498?v=4","gravatar_id":"","url":"https://api.github.com/users/designatednerd","html_url":"https://github.com/designatednerd","followers_url":"https://api.github.com/users/designatednerd/followers","following_url":"https://api.github.com/users/designatednerd/following{/other_user}","gists_url":"https://api.github.com/users/designatednerd/gists{/gist_id}","starred_url":"https://api.github.com/users/designatednerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designatednerd/subscriptions","organizations_url":"https://api.github.com/users/designatednerd/orgs","repos_url":"https://api.github.com/users/designatednerd/repos","events_url":"https://api.github.com/users/designatednerd/events{/privacy}","received_events_url":"https://api.github.com/users/designatednerd/received_events","type":"User","site_admin":false},"body":"Yeah I think I did this a bit automatically as this is how I'm used to setting up titles in markdown documents. Will update.","created_at":"2018-04-26T11:33:18Z","updated_at":"2018-04-26T11:33:19Z","html_url":"https://github.com/bakkenbaeck/iOS-handbook/pull/118#discussion_r184356622","pull_request_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/comments/184356622"},"html":{"href":"https://github.com/bakkenbaeck/iOS-handbook/pull/118#discussion_r184356622"},"pull_request":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118"}},"in_reply_to_id":184354236},"pull_request":{"url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118","id":184040716,"html_url":"https://github.com/bakkenbaeck/iOS-handbook/pull/118","diff_url":"https://github.com/bakkenbaeck/iOS-handbook/pull/118.diff","patch_url":"https://github.com/bakkenbaeck/iOS-handbook/pull/118.patch","issue_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/118","number":118,"state":"open","locked":false,"title":"Simplification, Clarification, Robotification","user":{"login":"designatednerd","id":1976498,"avatar_url":"https://avatars1.githubusercontent.com/u/1976498?v=4","gravatar_id":"","url":"https://api.github.com/users/designatednerd","html_url":"https://github.com/designatednerd","followers_url":"https://api.github.com/users/designatednerd/followers","following_url":"https://api.github.com/users/designatednerd/following{/other_user}","gists_url":"https://api.github.com/users/designatednerd/gists{/gist_id}","starred_url":"https://api.github.com/users/designatednerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designatednerd/subscriptions","organizations_url":"https://api.github.com/users/designatednerd/orgs","repos_url":"https://api.github.com/users/designatednerd/repos","events_url":"https://api.github.com/users/designatednerd/events{/privacy}","received_events_url":"https://api.github.com/users/designatednerd/received_events","type":"User","site_admin":false},"body":"Per discussion yesterday, I took a swing through the Handbook to see what could be updated and simplified. \r\n\r\nIn this PR, I: \r\n\r\n- Broke out the Style Guide from the Best Practices. Basically, now the style guide contains requirements, and best practices are strong suggestions and links to things that you should or should not do based on other people's experience.\r\n- Added a default `.swiftlint.yml` file that should be usable across most projects immediately.\r\n- Condensed a couple of files which had been separate into other sections.\r\n- Made a number of points significantly more concise. \r\n- Removed a couple of things which a) Were overly prescriptive and/or b) Were not actually being followed. \r\n- Made an \"Archive\" folder and added a couple of files that hadn't been updated in over a year. \r\n\r\nFeedback requested: \r\n- Is there anything in Style Guide that should be in Best Practices, or vice versa? \r\n- Is there anything you feel we're enforcing too aggressively with SwiftLint? \r\n- Is there anything you feel we should be enforcing too leniently with SwiftLint?\r\n- Is there anything here you feel was taken out too hastily? \r\n\r\nAny other feedback is most welcome!","created_at":"2018-04-25T13:43:53Z","updated_at":"2018-04-26T11:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b42fbbb1401113e85a03c9ecab8f2b566df5c17c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"roberthein","id":474246,"avatar_url":"https://avatars1.githubusercontent.com/u/474246?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthein","html_url":"https://github.com/roberthein","followers_url":"https://api.github.com/users/roberthein/followers","following_url":"https://api.github.com/users/roberthein/following{/other_user}","gists_url":"https://api.github.com/users/roberthein/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthein/subscriptions","organizations_url":"https://api.github.com/users/roberthein/orgs","repos_url":"https://api.github.com/users/roberthein/repos","events_url":"https://api.github.com/users/roberthein/events{/privacy}","received_events_url":"https://api.github.com/users/roberthein/received_events","type":"User","site_admin":false},{"login":"marijnschilling","id":1125417,"avatar_url":"https://avatars1.githubusercontent.com/u/1125417?v=4","gravatar_id":"","url":"https://api.github.com/users/marijnschilling","html_url":"https://github.com/marijnschilling","followers_url":"https://api.github.com/users/marijnschilling/followers","following_url":"https://api.github.com/users/marijnschilling/following{/other_user}","gists_url":"https://api.github.com/users/marijnschilling/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnschilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnschilling/subscriptions","organizations_url":"https://api.github.com/users/marijnschilling/orgs","repos_url":"https://api.github.com/users/marijnschilling/repos","events_url":"https://api.github.com/users/marijnschilling/events{/privacy}","received_events_url":"https://api.github.com/users/marijnschilling/received_events","type":"User","site_admin":false},{"login":"yuliaveres","id":27722554,"avatar_url":"https://avatars2.githubusercontent.com/u/27722554?v=4","gravatar_id":"","url":"https://api.github.com/users/yuliaveres","html_url":"https://github.com/yuliaveres","followers_url":"https://api.github.com/users/yuliaveres/followers","following_url":"https://api.github.com/users/yuliaveres/following{/other_user}","gists_url":"https://api.github.com/users/yuliaveres/gists{/gist_id}","starred_url":"https://api.github.com/users/yuliaveres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuliaveres/subscriptions","organizations_url":"https://api.github.com/users/yuliaveres/orgs","repos_url":"https://api.github.com/users/yuliaveres/repos","events_url":"https://api.github.com/users/yuliaveres/events{/privacy}","received_events_url":"https://api.github.com/users/yuliaveres/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118/commits","review_comments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118/comments","review_comment_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/118/comments","statuses_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/statuses/35a05a8af214624549cd6bf04d2bac319b23eb2c","head":{"label":"bakkenbaeck:robots","ref":"robots","sha":"35a05a8af214624549cd6bf04d2bac319b23eb2c","user":{"login":"bakkenbaeck","id":2485680,"avatar_url":"https://avatars3.githubusercontent.com/u/2485680?v=4","gravatar_id":"","url":"https://api.github.com/users/bakkenbaeck","html_url":"https://github.com/bakkenbaeck","followers_url":"https://api.github.com/users/bakkenbaeck/followers","following_url":"https://api.github.com/users/bakkenbaeck/following{/other_user}","gists_url":"https://api.github.com/users/bakkenbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkenbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkenbaeck/subscriptions","organizations_url":"https://api.github.com/users/bakkenbaeck/orgs","repos_url":"https://api.github.com/users/bakkenbaeck/repos","events_url":"https://api.github.com/users/bakkenbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/bakkenbaeck/received_events","type":"Organization","site_admin":false},"repo":{"id":37313626,"name":"iOS-handbook","full_name":"bakkenbaeck/iOS-handbook","owner":{"login":"bakkenbaeck","id":2485680,"avatar_url":"https://avatars3.githubusercontent.com/u/2485680?v=4","gravatar_id":"","url":"https://api.github.com/users/bakkenbaeck","html_url":"https://github.com/bakkenbaeck","followers_url":"https://api.github.com/users/bakkenbaeck/followers","following_url":"https://api.github.com/users/bakkenbaeck/following{/other_user}","gists_url":"https://api.github.com/users/bakkenbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkenbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkenbaeck/subscriptions","organizations_url":"https://api.github.com/users/bakkenbaeck/orgs","repos_url":"https://api.github.com/users/bakkenbaeck/repos","events_url":"https://api.github.com/users/bakkenbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/bakkenbaeck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bakkenbaeck/iOS-handbook","description":"Guidelines and best practices for excellent iOS apps","fork":false,"url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook","forks_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/forks","keys_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/teams","hooks_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/hooks","issue_events_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/events{/number}","events_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/events","assignees_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/assignees{/user}","branches_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/branches{/branch}","tags_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/tags","blobs_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/languages","stargazers_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/stargazers","contributors_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/contributors","subscribers_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/subscribers","subscription_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/subscription","commits_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/contents/{+path}","compare_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/merges","archive_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/downloads","issues_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues{/number}","pulls_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/labels{/name}","releases_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/releases{/id}","deployments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/deployments","created_at":"2015-06-12T09:28:07Z","updated_at":"2018-04-26T11:11:52Z","pushed_at":"2018-04-25T13:50:01Z","git_url":"git://github.com/bakkenbaeck/iOS-handbook.git","ssh_url":"git@github.com:bakkenbaeck/iOS-handbook.git","clone_url":"https://github.com/bakkenbaeck/iOS-handbook.git","svn_url":"https://github.com/bakkenbaeck/iOS-handbook","homepage":"","size":7508,"stargazers_count":159,"watchers_count":159,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":20,"open_issues":9,"watchers":159,"default_branch":"master"}},"base":{"label":"bakkenbaeck:master","ref":"master","sha":"e7aeadc03d76f673a02e497a2d9d443206ee103c","user":{"login":"bakkenbaeck","id":2485680,"avatar_url":"https://avatars3.githubusercontent.com/u/2485680?v=4","gravatar_id":"","url":"https://api.github.com/users/bakkenbaeck","html_url":"https://github.com/bakkenbaeck","followers_url":"https://api.github.com/users/bakkenbaeck/followers","following_url":"https://api.github.com/users/bakkenbaeck/following{/other_user}","gists_url":"https://api.github.com/users/bakkenbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkenbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkenbaeck/subscriptions","organizations_url":"https://api.github.com/users/bakkenbaeck/orgs","repos_url":"https://api.github.com/users/bakkenbaeck/repos","events_url":"https://api.github.com/users/bakkenbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/bakkenbaeck/received_events","type":"Organization","site_admin":false},"repo":{"id":37313626,"name":"iOS-handbook","full_name":"bakkenbaeck/iOS-handbook","owner":{"login":"bakkenbaeck","id":2485680,"avatar_url":"https://avatars3.githubusercontent.com/u/2485680?v=4","gravatar_id":"","url":"https://api.github.com/users/bakkenbaeck","html_url":"https://github.com/bakkenbaeck","followers_url":"https://api.github.com/users/bakkenbaeck/followers","following_url":"https://api.github.com/users/bakkenbaeck/following{/other_user}","gists_url":"https://api.github.com/users/bakkenbaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkenbaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkenbaeck/subscriptions","organizations_url":"https://api.github.com/users/bakkenbaeck/orgs","repos_url":"https://api.github.com/users/bakkenbaeck/repos","events_url":"https://api.github.com/users/bakkenbaeck/events{/privacy}","received_events_url":"https://api.github.com/users/bakkenbaeck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bakkenbaeck/iOS-handbook","description":"Guidelines and best practices for excellent iOS apps","fork":false,"url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook","forks_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/forks","keys_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/teams","hooks_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/hooks","issue_events_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/events{/number}","events_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/events","assignees_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/assignees{/user}","branches_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/branches{/branch}","tags_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/tags","blobs_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/languages","stargazers_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/stargazers","contributors_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/contributors","subscribers_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/subscribers","subscription_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/subscription","commits_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/contents/{+path}","compare_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/merges","archive_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/downloads","issues_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues{/number}","pulls_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/labels{/name}","releases_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/releases{/id}","deployments_url":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/deployments","created_at":"2015-06-12T09:28:07Z","updated_at":"2018-04-26T11:11:52Z","pushed_at":"2018-04-25T13:50:01Z","git_url":"git://github.com/bakkenbaeck/iOS-handbook.git","ssh_url":"git@github.com:bakkenbaeck/iOS-handbook.git","clone_url":"https://github.com/bakkenbaeck/iOS-handbook.git","svn_url":"https://github.com/bakkenbaeck/iOS-handbook","homepage":"","size":7508,"stargazers_count":159,"watchers_count":159,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":20,"open_issues":9,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118"},"html":{"href":"https://github.com/bakkenbaeck/iOS-handbook/pull/118"},"issue":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/118"},"comments":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/bakkenbaeck/iOS-handbook/statuses/35a05a8af214624549cd6bf04d2bac319b23eb2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"designatednerd"}}