{"action":"created","comment":{"url":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments/200953227","pull_request_review_id":135358856,"id":200953227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk1MzIyNw==","diff_hunk":"@@ -237,8 +237,8 @@ export default Component.extend({\n \n   didReceiveAttrs() {\n     this._super(...arguments);\n-    this.set('items', this.get('items').map((item) => {\n-      if (item.id === this.get('selectedItem.id')) {\n+    this.set('items', this.items.map((item) => {\n+      if (item.id === this.selectedItem.id) {","path":"guides/v3.2.0/components/the-component-lifecycle.md","position":34,"original_position":34,"commit_id":"b28bf1d8e79a2436a613d27647807e181a0fb0e9","original_commit_id":"b28bf1d8e79a2436a613d27647807e181a0fb0e9","user":{"login":"CodingItWrong","id":15832198,"node_id":"MDQ6VXNlcjE1ODMyMTk4","avatar_url":"https://avatars0.githubusercontent.com/u/15832198?v=4","gravatar_id":"","url":"https://api.github.com/users/CodingItWrong","html_url":"https://github.com/CodingItWrong","followers_url":"https://api.github.com/users/CodingItWrong/followers","following_url":"https://api.github.com/users/CodingItWrong/following{/other_user}","gists_url":"https://api.github.com/users/CodingItWrong/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingItWrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingItWrong/subscriptions","organizations_url":"https://api.github.com/users/CodingItWrong/orgs","repos_url":"https://api.github.com/users/CodingItWrong/repos","events_url":"https://api.github.com/users/CodingItWrong/events{/privacy}","received_events_url":"https://api.github.com/users/CodingItWrong/received_events","type":"User","site_admin":false},"body":"Unrelated to this PR, but it seems like this `map()` is mutating the items. I think some kind of for…of or forEach could better express that we are changing the items in place. But no need to make the change in this PR unless you feel especially motivated to do so :-)","created_at":"2018-07-09T10:24:41Z","updated_at":"2018-07-09T10:38:46Z","html_url":"https://github.com/ember-learn/guides-source/pull/87#discussion_r200953227","pull_request_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments/200953227"},"html":{"href":"https://github.com/ember-learn/guides-source/pull/87#discussion_r200953227"},"pull_request":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/ember-learn/guides-source/pulls/87","id":193836296,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODM2Mjk2","html_url":"https://github.com/ember-learn/guides-source/pull/87","diff_url":"https://github.com/ember-learn/guides-source/pull/87.diff","patch_url":"https://github.com/ember-learn/guides-source/pull/87.patch","issue_url":"https://api.github.com/repos/ember-learn/guides-source/issues/87","number":87,"state":"open","locked":false,"title":"Replaces `this.get with ES5 getter where possible (#2303) in v3.2.0","user":{"login":"cspanring","id":89122,"node_id":"MDQ6VXNlcjg5MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/89122?v=4","gravatar_id":"","url":"https://api.github.com/users/cspanring","html_url":"https://github.com/cspanring","followers_url":"https://api.github.com/users/cspanring/followers","following_url":"https://api.github.com/users/cspanring/following{/other_user}","gists_url":"https://api.github.com/users/cspanring/gists{/gist_id}","starred_url":"https://api.github.com/users/cspanring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cspanring/subscriptions","organizations_url":"https://api.github.com/users/cspanring/orgs","repos_url":"https://api.github.com/users/cspanring/repos","events_url":"https://api.github.com/users/cspanring/events{/privacy}","received_events_url":"https://api.github.com/users/cspanring/received_events","type":"User","site_admin":false},"body":"Attempt to check off task 1 in https://github.com/emberjs/guides/issues/2303\r\n\r\n@jenweber please have a look and/or pull in more eyes to make sure the changes are OK.","created_at":"2018-06-10T17:08:49Z","updated_at":"2018-07-09T10:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"186d759bd93e8e818b7a3f05f3138553cf84d595","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":987850580,"node_id":"MDU6TGFiZWw5ODc4NTA1ODA=","url":"https://api.github.com/repos/ember-learn/guides-source/labels/needs%20a%20reviewer","name":"needs a reviewer","color":"b5a2e5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/87/commits","review_comments_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/87/comments","review_comment_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-learn/guides-source/issues/87/comments","statuses_url":"https://api.github.com/repos/ember-learn/guides-source/statuses/b28bf1d8e79a2436a613d27647807e181a0fb0e9","head":{"label":"cspanring:es5-getters-2303","ref":"es5-getters-2303","sha":"b28bf1d8e79a2436a613d27647807e181a0fb0e9","user":{"login":"cspanring","id":89122,"node_id":"MDQ6VXNlcjg5MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/89122?v=4","gravatar_id":"","url":"https://api.github.com/users/cspanring","html_url":"https://github.com/cspanring","followers_url":"https://api.github.com/users/cspanring/followers","following_url":"https://api.github.com/users/cspanring/following{/other_user}","gists_url":"https://api.github.com/users/cspanring/gists{/gist_id}","starred_url":"https://api.github.com/users/cspanring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cspanring/subscriptions","organizations_url":"https://api.github.com/users/cspanring/orgs","repos_url":"https://api.github.com/users/cspanring/repos","events_url":"https://api.github.com/users/cspanring/events{/privacy}","received_events_url":"https://api.github.com/users/cspanring/received_events","type":"User","site_admin":false},"repo":{"id":136821911,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4MjE5MTE=","name":"guides-source","full_name":"cspanring/guides-source","owner":{"login":"cspanring","id":89122,"node_id":"MDQ6VXNlcjg5MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/89122?v=4","gravatar_id":"","url":"https://api.github.com/users/cspanring","html_url":"https://github.com/cspanring","followers_url":"https://api.github.com/users/cspanring/followers","following_url":"https://api.github.com/users/cspanring/following{/other_user}","gists_url":"https://api.github.com/users/cspanring/gists{/gist_id}","starred_url":"https://api.github.com/users/cspanring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cspanring/subscriptions","organizations_url":"https://api.github.com/users/cspanring/orgs","repos_url":"https://api.github.com/users/cspanring/repos","events_url":"https://api.github.com/users/cspanring/events{/privacy}","received_events_url":"https://api.github.com/users/cspanring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cspanring/guides-source","description":"This repository contains the written content for the Ember.js Guides","fork":true,"url":"https://api.github.com/repos/cspanring/guides-source","forks_url":"https://api.github.com/repos/cspanring/guides-source/forks","keys_url":"https://api.github.com/repos/cspanring/guides-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cspanring/guides-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cspanring/guides-source/teams","hooks_url":"https://api.github.com/repos/cspanring/guides-source/hooks","issue_events_url":"https://api.github.com/repos/cspanring/guides-source/issues/events{/number}","events_url":"https://api.github.com/repos/cspanring/guides-source/events","assignees_url":"https://api.github.com/repos/cspanring/guides-source/assignees{/user}","branches_url":"https://api.github.com/repos/cspanring/guides-source/branches{/branch}","tags_url":"https://api.github.com/repos/cspanring/guides-source/tags","blobs_url":"https://api.github.com/repos/cspanring/guides-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cspanring/guides-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cspanring/guides-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/cspanring/guides-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cspanring/guides-source/statuses/{sha}","languages_url":"https://api.github.com/repos/cspanring/guides-source/languages","stargazers_url":"https://api.github.com/repos/cspanring/guides-source/stargazers","contributors_url":"https://api.github.com/repos/cspanring/guides-source/contributors","subscribers_url":"https://api.github.com/repos/cspanring/guides-source/subscribers","subscription_url":"https://api.github.com/repos/cspanring/guides-source/subscription","commits_url":"https://api.github.com/repos/cspanring/guides-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/cspanring/guides-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/cspanring/guides-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/cspanring/guides-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/cspanring/guides-source/contents/{+path}","compare_url":"https://api.github.com/repos/cspanring/guides-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cspanring/guides-source/merges","archive_url":"https://api.github.com/repos/cspanring/guides-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cspanring/guides-source/downloads","issues_url":"https://api.github.com/repos/cspanring/guides-source/issues{/number}","pulls_url":"https://api.github.com/repos/cspanring/guides-source/pulls{/number}","milestones_url":"https://api.github.com/repos/cspanring/guides-source/milestones{/number}","notifications_url":"https://api.github.com/repos/cspanring/guides-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cspanring/guides-source/labels{/name}","releases_url":"https://api.github.com/repos/cspanring/guides-source/releases{/id}","deployments_url":"https://api.github.com/repos/cspanring/guides-source/deployments","created_at":"2018-06-10T15:42:07Z","updated_at":"2018-06-10T15:42:18Z","pushed_at":"2018-06-10T16:53:07Z","git_url":"git://github.com/cspanring/guides-source.git","ssh_url":"git@github.com:cspanring/guides-source.git","clone_url":"https://github.com/cspanring/guides-source.git","svn_url":"https://github.com/cspanring/guides-source","homepage":"https://guides.emberjs.com/","size":18495,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-learn:master","ref":"master","sha":"f001d70281b3b29e391180a6a09fa5d68a72e08e","user":{"login":"ember-learn","id":18540472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTQwNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":105325202,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzMjUyMDI=","name":"guides-source","full_name":"ember-learn/guides-source","owner":{"login":"ember-learn","id":18540472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTQwNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-learn/guides-source","description":"This repository contains the written content for the Ember.js Guides","fork":false,"url":"https://api.github.com/repos/ember-learn/guides-source","forks_url":"https://api.github.com/repos/ember-learn/guides-source/forks","keys_url":"https://api.github.com/repos/ember-learn/guides-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-learn/guides-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-learn/guides-source/teams","hooks_url":"https://api.github.com/repos/ember-learn/guides-source/hooks","issue_events_url":"https://api.github.com/repos/ember-learn/guides-source/issues/events{/number}","events_url":"https://api.github.com/repos/ember-learn/guides-source/events","assignees_url":"https://api.github.com/repos/ember-learn/guides-source/assignees{/user}","branches_url":"https://api.github.com/repos/ember-learn/guides-source/branches{/branch}","tags_url":"https://api.github.com/repos/ember-learn/guides-source/tags","blobs_url":"https://api.github.com/repos/ember-learn/guides-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-learn/guides-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-learn/guides-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-learn/guides-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-learn/guides-source/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-learn/guides-source/languages","stargazers_url":"https://api.github.com/repos/ember-learn/guides-source/stargazers","contributors_url":"https://api.github.com/repos/ember-learn/guides-source/contributors","subscribers_url":"https://api.github.com/repos/ember-learn/guides-source/subscribers","subscription_url":"https://api.github.com/repos/ember-learn/guides-source/subscription","commits_url":"https://api.github.com/repos/ember-learn/guides-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-learn/guides-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-learn/guides-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-learn/guides-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-learn/guides-source/contents/{+path}","compare_url":"https://api.github.com/repos/ember-learn/guides-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-learn/guides-source/merges","archive_url":"https://api.github.com/repos/ember-learn/guides-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-learn/guides-source/downloads","issues_url":"https://api.github.com/repos/ember-learn/guides-source/issues{/number}","pulls_url":"https://api.github.com/repos/ember-learn/guides-source/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-learn/guides-source/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-learn/guides-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-learn/guides-source/labels{/name}","releases_url":"https://api.github.com/repos/ember-learn/guides-source/releases{/id}","deployments_url":"https://api.github.com/repos/ember-learn/guides-source/deployments","created_at":"2017-09-29T23:27:33Z","updated_at":"2018-07-09T03:25:45Z","pushed_at":"2018-07-09T03:25:43Z","git_url":"git://github.com/ember-learn/guides-source.git","ssh_url":"git@github.com:ember-learn/guides-source.git","clone_url":"https://github.com/ember-learn/guides-source.git","svn_url":"https://github.com/ember-learn/guides-source","homepage":"https://guides.emberjs.com/","size":18431,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":56,"open_issues":13,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/87"},"html":{"href":"https://github.com/ember-learn/guides-source/pull/87"},"issue":{"href":"https://api.github.com/repos/ember-learn/guides-source/issues/87"},"comments":{"href":"https://api.github.com/repos/ember-learn/guides-source/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/ember-learn/guides-source/statuses/b28bf1d8e79a2436a613d27647807e181a0fb0e9"}},"author_association":"NONE"}}
{"actor":{"display_login":"CodingItWrong"}}