{"action":"created","issue":{"url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/22","repository_url":"https://api.github.com/repos/JonathanHolvey/sharepy","labels_url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/22/comments","events_url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/22/events","html_url":"https://github.com/JonathanHolvey/sharepy/pull/22","id":375753299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTI2MTMz","number":22,"title":"Possible fix for #20 ADFS based authentication","user":{"login":"joemeneses","id":1746678,"node_id":"MDQ6VXNlcjE3NDY2Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1746678?v=4","gravatar_id":"","url":"https://api.github.com/users/joemeneses","html_url":"https://github.com/joemeneses","followers_url":"https://api.github.com/users/joemeneses/followers","following_url":"https://api.github.com/users/joemeneses/following{/other_user}","gists_url":"https://api.github.com/users/joemeneses/gists{/gist_id}","starred_url":"https://api.github.com/users/joemeneses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemeneses/subscriptions","organizations_url":"https://api.github.com/users/joemeneses/orgs","repos_url":"https://api.github.com/users/joemeneses/repos","events_url":"https://api.github.com/users/joemeneses/events{/privacy}","received_events_url":"https://api.github.com/users/joemeneses/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-31T00:48:16Z","updated_at":"2018-12-05T23:35:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JonathanHolvey/sharepy/pulls/22","html_url":"https://github.com/JonathanHolvey/sharepy/pull/22","diff_url":"https://github.com/JonathanHolvey/sharepy/pull/22.diff","patch_url":"https://github.com/JonathanHolvey/sharepy/pull/22.patch"},"body":"#20 \r\nThis library originally did not work for my SharePoint environment either, but I wrote a fix for it in a custom SharePoint Token Service (STS) + Microsoft Online (MSO) Authentication configuration to replicate [this diagram](https://docs.microsoft.com/en-us/sharepoint/authentication)\r\nCreated the SharePointAPI class to help deal with interactions with sharepoint lists. Far as I can tell will work with non ADFS SPO implementations as well as my own ADFS version. Use is the same as any other connection except to set adfsAuth = True\r\n\r\nAdded _spoAdfsAuth member function to SharePointSession class to handle authenticating with custom STS based ADFS SPO implementations. Documentation for that is [here](https://blogs.technet.microsoft.com/sharepointdevelopersupport/2018/02/07/sharepoint-online-active-authentication/).\r\n\r\nTo handle this new authentication method, also created customStsSamlm and msoSaml xml templates.\r\n\r\nHere is a test drive\r\n\r\n```\r\nimport sharepy as session\r\nfrom sharepy import spListsAPI\r\n\r\nconnect_url = \"https://tenant.sharepoint.com/sites/subsite/\"\r\ns = session.connect(connect_url, username=\"user@domain.com\", password=\"pass\", adfsAuth=True)\r\nshareLists = spListsAPI(s)\r\nprint(shareLists.GetListCollection())\r\nprint(shareLists.GetListItems('Case-insensitive List Name'))\r\n```"},"comment":{"url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/comments/444692557","html_url":"https://github.com/JonathanHolvey/sharepy/pull/22#issuecomment-444692557","issue_url":"https://api.github.com/repos/JonathanHolvey/sharepy/issues/22","id":444692557,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDY5MjU1Nw==","user":{"login":"joemeneses","id":1746678,"node_id":"MDQ6VXNlcjE3NDY2Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1746678?v=4","gravatar_id":"","url":"https://api.github.com/users/joemeneses","html_url":"https://github.com/joemeneses","followers_url":"https://api.github.com/users/joemeneses/followers","following_url":"https://api.github.com/users/joemeneses/following{/other_user}","gists_url":"https://api.github.com/users/joemeneses/gists{/gist_id}","starred_url":"https://api.github.com/users/joemeneses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemeneses/subscriptions","organizations_url":"https://api.github.com/users/joemeneses/orgs","repos_url":"https://api.github.com/users/joemeneses/repos","events_url":"https://api.github.com/users/joemeneses/events{/privacy}","received_events_url":"https://api.github.com/users/joemeneses/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T23:35:20Z","updated_at":"2018-12-05T23:35:20Z","author_association":"NONE","body":"Hi all,\r\nBusy week on my end, I will be free of a lot of my current load in the new few days so I expect to work on this in the coming week. See updates in the above PR changes requested thread."}}
{"actor":{"display_login":"joemeneses"}}