{"action":"created","comment":{"url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/comments/186275150","pull_request_review_id":117827855,"id":186275150,"diff_hunk":"@@ -1020,8 +1020,8 @@ def omni_abscal_arg_parser():\n     a.add_argument(\"--phase_slope_cal\", default=False, action='store_true', help='perform frequency-indepdendent phase slope calibration')\n     a.add_argument(\"--abs_amp_cal\", default=False, action='store_true', help='perform absolute amplitude calibration')\n     a.add_argument(\"--TT_phs_cal\", default=False, action='store_true', help='perform Tip-Tilt phase slope calibration')\n-    a.add_argument(\"--TT_phs_max_iter\", type=int, default=100, help=\"maximum number of iterations of TT_phs_cal allowed\")\n-    a.add_argument(\"--TT_phs_conv_crit\", type=float, default=1e-6, help=\"convergence criterion in Delta g / g for stopping iterative TT_phs_cal\")\n+    a.add_argument(\"--phs_max_iter\", type=int, default=100, help=\"maximum number of iterations of phase_slope_cal or TT_phs_cal allowed\")\n+    a.add_argument(\"--phs_conv_crit\", type=float, default=1e-6, help=\"convergence criterion in Delta g / g for stopping iterative phase_slope_cal or TT_phs_cal\")","path":"hera_cal/abscal.py","position":7,"original_position":18,"commit_id":"2dcd2c5dc7f6118bdbea65e3b08d127602d8027e","original_commit_id":"2dcd2c5dc7f6118bdbea65e3b08d127602d8027e","user":{"login":"nkern","id":4307358,"avatar_url":"https://avatars0.githubusercontent.com/u/4307358?v=4","gravatar_id":"","url":"https://api.github.com/users/nkern","html_url":"https://github.com/nkern","followers_url":"https://api.github.com/users/nkern/followers","following_url":"https://api.github.com/users/nkern/following{/other_user}","gists_url":"https://api.github.com/users/nkern/gists{/gist_id}","starred_url":"https://api.github.com/users/nkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkern/subscriptions","organizations_url":"https://api.github.com/users/nkern/orgs","repos_url":"https://api.github.com/users/nkern/repos","events_url":"https://api.github.com/users/nkern/events{/privacy}","received_events_url":"https://api.github.com/users/nkern/received_events","type":"User","site_admin":false},"body":"is there a good reason why the `phs_conv_crit` is being used for both the global phase slope and the freq-dependent phase slope? If one is much slower than another, as you suggested, it might make sense to have two different knobs for these algorithms? However, I'm fine w/ keeping as is and adjusting if we see that in practice we find we need to..","created_at":"2018-05-05T23:56:53Z","updated_at":"2018-05-05T23:56:53Z","html_url":"https://github.com/HERA-Team/hera_cal/pull/285#discussion_r186275150","pull_request_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/comments/186275150"},"html":{"href":"https://github.com/HERA-Team/hera_cal/pull/285#discussion_r186275150"},"pull_request":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285","id":186125608,"html_url":"https://github.com/HERA-Team/hera_cal/pull/285","diff_url":"https://github.com/HERA-Team/hera_cal/pull/285.diff","patch_url":"https://github.com/HERA-Team/hera_cal/pull/285.patch","issue_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/285","number":285,"state":"open","locked":false,"title":"Make phase_slope_cal iterative","user":{"login":"jsdillon","id":5281139,"avatar_url":"https://avatars1.githubusercontent.com/u/5281139?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdillon","html_url":"https://github.com/jsdillon","followers_url":"https://api.github.com/users/jsdillon/followers","following_url":"https://api.github.com/users/jsdillon/following{/other_user}","gists_url":"https://api.github.com/users/jsdillon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdillon/subscriptions","organizations_url":"https://api.github.com/users/jsdillon/orgs","repos_url":"https://api.github.com/users/jsdillon/repos","events_url":"https://api.github.com/users/jsdillon/events{/privacy}","received_events_url":"https://api.github.com/users/jsdillon/received_events","type":"User","site_admin":false},"body":"This generally converges in a few iterations and it helps TT_phs_cal (which is slower) converge more quickly.","created_at":"2018-05-04T23:38:35Z","updated_at":"2018-05-05T23:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfbf0e850f899f5585bdf521834207b190ba42cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285/commits","review_comments_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285/comments","review_comment_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/285/comments","statuses_url":"https://api.github.com/repos/HERA-Team/hera_cal/statuses/2dcd2c5dc7f6118bdbea65e3b08d127602d8027e","head":{"label":"HERA-Team:iterative-global-phase-cal","ref":"iterative-global-phase-cal","sha":"2dcd2c5dc7f6118bdbea65e3b08d127602d8027e","user":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":75780327,"name":"hera_cal","full_name":"HERA-Team/hera_cal","owner":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HERA-Team/hera_cal","description":"Library for online calibration of HERA data.","fork":false,"url":"https://api.github.com/repos/HERA-Team/hera_cal","forks_url":"https://api.github.com/repos/HERA-Team/hera_cal/forks","keys_url":"https://api.github.com/repos/HERA-Team/hera_cal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HERA-Team/hera_cal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HERA-Team/hera_cal/teams","hooks_url":"https://api.github.com/repos/HERA-Team/hera_cal/hooks","issue_events_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/events{/number}","events_url":"https://api.github.com/repos/HERA-Team/hera_cal/events","assignees_url":"https://api.github.com/repos/HERA-Team/hera_cal/assignees{/user}","branches_url":"https://api.github.com/repos/HERA-Team/hera_cal/branches{/branch}","tags_url":"https://api.github.com/repos/HERA-Team/hera_cal/tags","blobs_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/refs{/sha}","trees_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HERA-Team/hera_cal/statuses/{sha}","languages_url":"https://api.github.com/repos/HERA-Team/hera_cal/languages","stargazers_url":"https://api.github.com/repos/HERA-Team/hera_cal/stargazers","contributors_url":"https://api.github.com/repos/HERA-Team/hera_cal/contributors","subscribers_url":"https://api.github.com/repos/HERA-Team/hera_cal/subscribers","subscription_url":"https://api.github.com/repos/HERA-Team/hera_cal/subscription","commits_url":"https://api.github.com/repos/HERA-Team/hera_cal/commits{/sha}","git_commits_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/commits{/sha}","comments_url":"https://api.github.com/repos/HERA-Team/hera_cal/comments{/number}","issue_comment_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/comments{/number}","contents_url":"https://api.github.com/repos/HERA-Team/hera_cal/contents/{+path}","compare_url":"https://api.github.com/repos/HERA-Team/hera_cal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HERA-Team/hera_cal/merges","archive_url":"https://api.github.com/repos/HERA-Team/hera_cal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HERA-Team/hera_cal/downloads","issues_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues{/number}","pulls_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls{/number}","milestones_url":"https://api.github.com/repos/HERA-Team/hera_cal/milestones{/number}","notifications_url":"https://api.github.com/repos/HERA-Team/hera_cal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HERA-Team/hera_cal/labels{/name}","releases_url":"https://api.github.com/repos/HERA-Team/hera_cal/releases{/id}","deployments_url":"https://api.github.com/repos/HERA-Team/hera_cal/deployments","created_at":"2016-12-06T23:24:02Z","updated_at":"2018-05-05T20:19:40Z","pushed_at":"2018-05-05T20:46:53Z","git_url":"git://github.com/HERA-Team/hera_cal.git","ssh_url":"git@github.com:HERA-Team/hera_cal.git","clone_url":"https://github.com/HERA-Team/hera_cal.git","svn_url":"https://github.com/HERA-Team/hera_cal","homepage":null,"size":61178,"stargazers_count":2,"watchers_count":2,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":51,"license":null,"forks":2,"open_issues":51,"watchers":2,"default_branch":"master"}},"base":{"label":"HERA-Team:master","ref":"master","sha":"39cbeb8ccbbedeb6fecb214ee3ea1cf273a08d71","user":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":75780327,"name":"hera_cal","full_name":"HERA-Team/hera_cal","owner":{"login":"HERA-Team","id":14352544,"avatar_url":"https://avatars1.githubusercontent.com/u/14352544?v=4","gravatar_id":"","url":"https://api.github.com/users/HERA-Team","html_url":"https://github.com/HERA-Team","followers_url":"https://api.github.com/users/HERA-Team/followers","following_url":"https://api.github.com/users/HERA-Team/following{/other_user}","gists_url":"https://api.github.com/users/HERA-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/HERA-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HERA-Team/subscriptions","organizations_url":"https://api.github.com/users/HERA-Team/orgs","repos_url":"https://api.github.com/users/HERA-Team/repos","events_url":"https://api.github.com/users/HERA-Team/events{/privacy}","received_events_url":"https://api.github.com/users/HERA-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HERA-Team/hera_cal","description":"Library for online calibration of HERA data.","fork":false,"url":"https://api.github.com/repos/HERA-Team/hera_cal","forks_url":"https://api.github.com/repos/HERA-Team/hera_cal/forks","keys_url":"https://api.github.com/repos/HERA-Team/hera_cal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HERA-Team/hera_cal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HERA-Team/hera_cal/teams","hooks_url":"https://api.github.com/repos/HERA-Team/hera_cal/hooks","issue_events_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/events{/number}","events_url":"https://api.github.com/repos/HERA-Team/hera_cal/events","assignees_url":"https://api.github.com/repos/HERA-Team/hera_cal/assignees{/user}","branches_url":"https://api.github.com/repos/HERA-Team/hera_cal/branches{/branch}","tags_url":"https://api.github.com/repos/HERA-Team/hera_cal/tags","blobs_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/refs{/sha}","trees_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HERA-Team/hera_cal/statuses/{sha}","languages_url":"https://api.github.com/repos/HERA-Team/hera_cal/languages","stargazers_url":"https://api.github.com/repos/HERA-Team/hera_cal/stargazers","contributors_url":"https://api.github.com/repos/HERA-Team/hera_cal/contributors","subscribers_url":"https://api.github.com/repos/HERA-Team/hera_cal/subscribers","subscription_url":"https://api.github.com/repos/HERA-Team/hera_cal/subscription","commits_url":"https://api.github.com/repos/HERA-Team/hera_cal/commits{/sha}","git_commits_url":"https://api.github.com/repos/HERA-Team/hera_cal/git/commits{/sha}","comments_url":"https://api.github.com/repos/HERA-Team/hera_cal/comments{/number}","issue_comment_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/comments{/number}","contents_url":"https://api.github.com/repos/HERA-Team/hera_cal/contents/{+path}","compare_url":"https://api.github.com/repos/HERA-Team/hera_cal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HERA-Team/hera_cal/merges","archive_url":"https://api.github.com/repos/HERA-Team/hera_cal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HERA-Team/hera_cal/downloads","issues_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues{/number}","pulls_url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls{/number}","milestones_url":"https://api.github.com/repos/HERA-Team/hera_cal/milestones{/number}","notifications_url":"https://api.github.com/repos/HERA-Team/hera_cal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HERA-Team/hera_cal/labels{/name}","releases_url":"https://api.github.com/repos/HERA-Team/hera_cal/releases{/id}","deployments_url":"https://api.github.com/repos/HERA-Team/hera_cal/deployments","created_at":"2016-12-06T23:24:02Z","updated_at":"2018-05-05T20:19:40Z","pushed_at":"2018-05-05T20:46:53Z","git_url":"git://github.com/HERA-Team/hera_cal.git","ssh_url":"git@github.com:HERA-Team/hera_cal.git","clone_url":"https://github.com/HERA-Team/hera_cal.git","svn_url":"https://github.com/HERA-Team/hera_cal","homepage":null,"size":61178,"stargazers_count":2,"watchers_count":2,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":51,"license":null,"forks":2,"open_issues":51,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285"},"html":{"href":"https://github.com/HERA-Team/hera_cal/pull/285"},"issue":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/issues/285"},"comments":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/HERA-Team/hera_cal/statuses/2dcd2c5dc7f6118bdbea65e3b08d127602d8027e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"nkern"}}