{"action":"opened","number":18932,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18932","id":226655482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjU1NDgy","html_url":"https://github.com/magento/magento2/pull/18932","diff_url":"https://github.com/magento/magento2/pull/18932.diff","patch_url":"https://github.com/magento/magento2/pull/18932.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/18932","number":18932,"state":"open","locked":false,"title":"Fix/update newsletter i18n strings","user":{"login":"arnoudhgz","id":10864061,"node_id":"MDQ6VXNlcjEwODY0MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/10864061?v=4","gravatar_id":"","url":"https://api.github.com/users/arnoudhgz","html_url":"https://github.com/arnoudhgz","followers_url":"https://api.github.com/users/arnoudhgz/followers","following_url":"https://api.github.com/users/arnoudhgz/following{/other_user}","gists_url":"https://api.github.com/users/arnoudhgz/gists{/gist_id}","starred_url":"https://api.github.com/users/arnoudhgz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnoudhgz/subscriptions","organizations_url":"https://api.github.com/users/arnoudhgz/orgs","repos_url":"https://api.github.com/users/arnoudhgz/repos","events_url":"https://api.github.com/users/arnoudhgz/events{/privacy}","received_events_url":"https://api.github.com/users/arnoudhgz/received_events","type":"User","site_admin":false},"body":"### Description (*)\r\nThe messages in the Newsletter module were update, but the messages in the translation files have been forgotten. \r\n\r\nWhen using translation tools it is mandatory to have correct strings in the i18n files. This pull request aims to solve this. \r\n\r\n### Manual testing scenarios (*)\r\n1. Compare the messages in **app/code/Magento/Newsletter/Controller/Manage/Save.php** with the **i18n** file\r\n\r\n### Contribution checklist (*)\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-10-29T17:49:58Z","updated_at":"2018-10-29T17:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/18932/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/18932/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18932/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/7b5c012e443494af85dd6ef90712910ca7b9fb34","head":{"label":"arnoudhgz:fix/update-newsletter-i18n-strings","ref":"fix/update-newsletter-i18n-strings","sha":"7b5c012e443494af85dd6ef90712910ca7b9fb34","user":{"login":"arnoudhgz","id":10864061,"node_id":"MDQ6VXNlcjEwODY0MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/10864061?v=4","gravatar_id":"","url":"https://api.github.com/users/arnoudhgz","html_url":"https://github.com/arnoudhgz","followers_url":"https://api.github.com/users/arnoudhgz/followers","following_url":"https://api.github.com/users/arnoudhgz/following{/other_user}","gists_url":"https://api.github.com/users/arnoudhgz/gists{/gist_id}","starred_url":"https://api.github.com/users/arnoudhgz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnoudhgz/subscriptions","organizations_url":"https://api.github.com/users/arnoudhgz/orgs","repos_url":"https://api.github.com/users/arnoudhgz/repos","events_url":"https://api.github.com/users/arnoudhgz/events{/privacy}","received_events_url":"https://api.github.com/users/arnoudhgz/received_events","type":"User","site_admin":false},"repo":{"id":139886072,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4ODYwNzI=","name":"magento2","full_name":"arnoudhgz/magento2","private":false,"owner":{"login":"arnoudhgz","id":10864061,"node_id":"MDQ6VXNlcjEwODY0MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/10864061?v=4","gravatar_id":"","url":"https://api.github.com/users/arnoudhgz","html_url":"https://github.com/arnoudhgz","followers_url":"https://api.github.com/users/arnoudhgz/followers","following_url":"https://api.github.com/users/arnoudhgz/following{/other_user}","gists_url":"https://api.github.com/users/arnoudhgz/gists{/gist_id}","starred_url":"https://api.github.com/users/arnoudhgz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnoudhgz/subscriptions","organizations_url":"https://api.github.com/users/arnoudhgz/orgs","repos_url":"https://api.github.com/users/arnoudhgz/repos","events_url":"https://api.github.com/users/arnoudhgz/events{/privacy}","received_events_url":"https://api.github.com/users/arnoudhgz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arnoudhgz/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/arnoudhgz/magento2","forks_url":"https://api.github.com/repos/arnoudhgz/magento2/forks","keys_url":"https://api.github.com/repos/arnoudhgz/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnoudhgz/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnoudhgz/magento2/teams","hooks_url":"https://api.github.com/repos/arnoudhgz/magento2/hooks","issue_events_url":"https://api.github.com/repos/arnoudhgz/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/arnoudhgz/magento2/events","assignees_url":"https://api.github.com/repos/arnoudhgz/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/arnoudhgz/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/arnoudhgz/magento2/tags","blobs_url":"https://api.github.com/repos/arnoudhgz/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnoudhgz/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnoudhgz/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnoudhgz/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnoudhgz/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/arnoudhgz/magento2/languages","stargazers_url":"https://api.github.com/repos/arnoudhgz/magento2/stargazers","contributors_url":"https://api.github.com/repos/arnoudhgz/magento2/contributors","subscribers_url":"https://api.github.com/repos/arnoudhgz/magento2/subscribers","subscription_url":"https://api.github.com/repos/arnoudhgz/magento2/subscription","commits_url":"https://api.github.com/repos/arnoudhgz/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnoudhgz/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnoudhgz/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnoudhgz/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnoudhgz/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/arnoudhgz/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnoudhgz/magento2/merges","archive_url":"https://api.github.com/repos/arnoudhgz/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnoudhgz/magento2/downloads","issues_url":"https://api.github.com/repos/arnoudhgz/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/arnoudhgz/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/arnoudhgz/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/arnoudhgz/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnoudhgz/magento2/labels{/name}","releases_url":"https://api.github.com/repos/arnoudhgz/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/arnoudhgz/magento2/deployments","created_at":"2018-07-05T18:22:35Z","updated_at":"2018-10-29T17:39:17Z","pushed_at":"2018-10-29T17:44:47Z","git_url":"git://github.com/arnoudhgz/magento2.git","ssh_url":"git@github.com:arnoudhgz/magento2.git","clone_url":"https://github.com/arnoudhgz/magento2.git","svn_url":"https://github.com/arnoudhgz/magento2","homepage":"http://www.magento.com","size":486501,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.2-develop","ref":"2.2-develop","sha":"74821996e6aa72b8b7ae85a9f9c819b80ff9a7af","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-10-29T17:30:17Z","pushed_at":"2018-10-29T17:21:22Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":489129,"stargazers_count":6271,"watchers_count":6271,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5467,"mirror_url":null,"archived":false,"open_issues_count":1408,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5467,"open_issues":1408,"watchers":6271,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/18932"},"html":{"href":"https://github.com/magento/magento2/pull/18932"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/18932"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/18932/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/18932/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/18932/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/7b5c012e443494af85dd6ef90712910ca7b9fb34"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"arnoudhgz"}}