{"action":"created","comment":{"url":"https://api.github.com/repos/dopetard/xchange/pulls/comments/229590534","pull_request_review_id":170123957,"id":229590534,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTU5MDUzNA==","diff_hunk":"@@ -115,16 +116,16 @@ export const ltcKeys = ECPair.fromWIF('cPnCzwHtVipcX7hb72mkkMMf4MSrknHbRnff2LDut\n export const ltcAddress = 'mysNm7METD1JffsC4E1ZW7EcPapmVm9AK4';\n \n const host = process.platform === 'win32' ? '192.168.99.100' : 'localhost';\n-\n-export const btcdClient = new ChainClient({\n+const logger = new Logger('./test', 'debug');","path":"test/integration/chain/ChainClient.spec.ts","position":12,"original_position":12,"commit_id":"4d7a4ecb5174d56880e0bdeb2334c63382e6cdef","original_commit_id":"4d7a4ecb5174d56880e0bdeb2334c63382e6cdef","user":{"login":"michael1011","id":8138838,"node_id":"MDQ6VXNlcjgxMzg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8138838?v=4","gravatar_id":"","url":"https://api.github.com/users/michael1011","html_url":"https://github.com/michael1011","followers_url":"https://api.github.com/users/michael1011/followers","following_url":"https://api.github.com/users/michael1011/following{/other_user}","gists_url":"https://api.github.com/users/michael1011/gists{/gist_id}","starred_url":"https://api.github.com/users/michael1011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael1011/subscriptions","organizations_url":"https://api.github.com/users/michael1011/orgs","repos_url":"https://api.github.com/users/michael1011/repos","events_url":"https://api.github.com/users/michael1011/events{/privacy}","received_events_url":"https://api.github.com/users/michael1011/received_events","type":"User","site_admin":false},"body":"There is a `Logger` I created for that purpose: [it can be found in the Logger class](https://github.com/dopetard/xchange/pull/85/files#diff-2623c35db8e74a0afa56d6d9b5a64810R7)\r\n\r\nPlease use it for the tests since we don't want them to print something to a file or even the console","created_at":"2018-10-31T07:49:06Z","updated_at":"2018-10-31T07:49:56Z","html_url":"https://github.com/dopetard/xchange/pull/85#discussion_r229590534","pull_request_url":"https://api.github.com/repos/dopetard/xchange/pulls/85","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/comments/229590534"},"html":{"href":"https://github.com/dopetard/xchange/pull/85#discussion_r229590534"},"pull_request":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/dopetard/xchange/pulls/85","id":224680420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjgwNDIw","html_url":"https://github.com/dopetard/xchange/pull/85","diff_url":"https://github.com/dopetard/xchange/pull/85.diff","patch_url":"https://github.com/dopetard/xchange/pull/85.patch","issue_url":"https://api.github.com/repos/dopetard/xchange/issues/85","number":85,"state":"open","locked":false,"title":"Add connection status to clients","user":{"login":"ImmanuelSegol","id":11227560,"node_id":"MDQ6VXNlcjExMjI3NTYw","avatar_url":"https://avatars3.githubusercontent.com/u/11227560?v=4","gravatar_id":"","url":"https://api.github.com/users/ImmanuelSegol","html_url":"https://github.com/ImmanuelSegol","followers_url":"https://api.github.com/users/ImmanuelSegol/followers","following_url":"https://api.github.com/users/ImmanuelSegol/following{/other_user}","gists_url":"https://api.github.com/users/ImmanuelSegol/gists{/gist_id}","starred_url":"https://api.github.com/users/ImmanuelSegol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImmanuelSegol/subscriptions","organizations_url":"https://api.github.com/users/ImmanuelSegol/orgs","repos_url":"https://api.github.com/users/ImmanuelSegol/repos","events_url":"https://api.github.com/users/ImmanuelSegol/events{/privacy}","received_events_url":"https://api.github.com/users/ImmanuelSegol/received_events","type":"User","site_admin":false},"body":"@michael1011 Im not sure how to fix the test, could you have a look?","created_at":"2018-10-22T13:26:11Z","updated_at":"2018-10-31T07:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c561e728f1f28313a4206904a0a2f56363372d7c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dopetard","id":3644166,"node_id":"MDQ6VXNlcjM2NDQxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3644166?v=4","gravatar_id":"","url":"https://api.github.com/users/dopetard","html_url":"https://github.com/dopetard","followers_url":"https://api.github.com/users/dopetard/followers","following_url":"https://api.github.com/users/dopetard/following{/other_user}","gists_url":"https://api.github.com/users/dopetard/gists{/gist_id}","starred_url":"https://api.github.com/users/dopetard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopetard/subscriptions","organizations_url":"https://api.github.com/users/dopetard/orgs","repos_url":"https://api.github.com/users/dopetard/repos","events_url":"https://api.github.com/users/dopetard/events{/privacy}","received_events_url":"https://api.github.com/users/dopetard/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dopetard/xchange/pulls/85/commits","review_comments_url":"https://api.github.com/repos/dopetard/xchange/pulls/85/comments","review_comment_url":"https://api.github.com/repos/dopetard/xchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dopetard/xchange/issues/85/comments","statuses_url":"https://api.github.com/repos/dopetard/xchange/statuses/4d7a4ecb5174d56880e0bdeb2334c63382e6cdef","head":{"label":"dopetard:retry-lnd-connection","ref":"retry-lnd-connection","sha":"4d7a4ecb5174d56880e0bdeb2334c63382e6cdef","user":{"login":"dopetard","id":3644166,"node_id":"MDQ6VXNlcjM2NDQxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3644166?v=4","gravatar_id":"","url":"https://api.github.com/users/dopetard","html_url":"https://github.com/dopetard","followers_url":"https://api.github.com/users/dopetard/followers","following_url":"https://api.github.com/users/dopetard/following{/other_user}","gists_url":"https://api.github.com/users/dopetard/gists{/gist_id}","starred_url":"https://api.github.com/users/dopetard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopetard/subscriptions","organizations_url":"https://api.github.com/users/dopetard/orgs","repos_url":"https://api.github.com/users/dopetard/repos","events_url":"https://api.github.com/users/dopetard/events{/privacy}","received_events_url":"https://api.github.com/users/dopetard/received_events","type":"User","site_admin":false},"repo":{"id":139837096,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MzcwOTY=","name":"xchange","full_name":"dopetard/xchange","private":false,"owner":{"login":"dopetard","id":3644166,"node_id":"MDQ6VXNlcjM2NDQxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3644166?v=4","gravatar_id":"","url":"https://api.github.com/users/dopetard","html_url":"https://github.com/dopetard","followers_url":"https://api.github.com/users/dopetard/followers","following_url":"https://api.github.com/users/dopetard/following{/other_user}","gists_url":"https://api.github.com/users/dopetard/gists{/gist_id}","starred_url":"https://api.github.com/users/dopetard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopetard/subscriptions","organizations_url":"https://api.github.com/users/dopetard/orgs","repos_url":"https://api.github.com/users/dopetard/repos","events_url":"https://api.github.com/users/dopetard/events{/privacy}","received_events_url":"https://api.github.com/users/dopetard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dopetard/xchange","description":"Implementation of Xchange","fork":false,"url":"https://api.github.com/repos/dopetard/xchange","forks_url":"https://api.github.com/repos/dopetard/xchange/forks","keys_url":"https://api.github.com/repos/dopetard/xchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dopetard/xchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dopetard/xchange/teams","hooks_url":"https://api.github.com/repos/dopetard/xchange/hooks","issue_events_url":"https://api.github.com/repos/dopetard/xchange/issues/events{/number}","events_url":"https://api.github.com/repos/dopetard/xchange/events","assignees_url":"https://api.github.com/repos/dopetard/xchange/assignees{/user}","branches_url":"https://api.github.com/repos/dopetard/xchange/branches{/branch}","tags_url":"https://api.github.com/repos/dopetard/xchange/tags","blobs_url":"https://api.github.com/repos/dopetard/xchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dopetard/xchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dopetard/xchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/dopetard/xchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dopetard/xchange/statuses/{sha}","languages_url":"https://api.github.com/repos/dopetard/xchange/languages","stargazers_url":"https://api.github.com/repos/dopetard/xchange/stargazers","contributors_url":"https://api.github.com/repos/dopetard/xchange/contributors","subscribers_url":"https://api.github.com/repos/dopetard/xchange/subscribers","subscription_url":"https://api.github.com/repos/dopetard/xchange/subscription","commits_url":"https://api.github.com/repos/dopetard/xchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/dopetard/xchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/dopetard/xchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/dopetard/xchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/dopetard/xchange/contents/{+path}","compare_url":"https://api.github.com/repos/dopetard/xchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dopetard/xchange/merges","archive_url":"https://api.github.com/repos/dopetard/xchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dopetard/xchange/downloads","issues_url":"https://api.github.com/repos/dopetard/xchange/issues{/number}","pulls_url":"https://api.github.com/repos/dopetard/xchange/pulls{/number}","milestones_url":"https://api.github.com/repos/dopetard/xchange/milestones{/number}","notifications_url":"https://api.github.com/repos/dopetard/xchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dopetard/xchange/labels{/name}","releases_url":"https://api.github.com/repos/dopetard/xchange/releases{/id}","deployments_url":"https://api.github.com/repos/dopetard/xchange/deployments","created_at":"2018-07-05T11:03:19Z","updated_at":"2018-10-30T18:07:26Z","pushed_at":"2018-10-30T18:25:37Z","git_url":"git://github.com/dopetard/xchange.git","ssh_url":"git@github.com:dopetard/xchange.git","clone_url":"https://github.com/dopetard/xchange.git","svn_url":"https://github.com/dopetard/xchange","homepage":"","size":2938,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"dopetard:master","ref":"master","sha":"62c156009f1bc31ec594faaae5124873463210ce","user":{"login":"dopetard","id":3644166,"node_id":"MDQ6VXNlcjM2NDQxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3644166?v=4","gravatar_id":"","url":"https://api.github.com/users/dopetard","html_url":"https://github.com/dopetard","followers_url":"https://api.github.com/users/dopetard/followers","following_url":"https://api.github.com/users/dopetard/following{/other_user}","gists_url":"https://api.github.com/users/dopetard/gists{/gist_id}","starred_url":"https://api.github.com/users/dopetard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopetard/subscriptions","organizations_url":"https://api.github.com/users/dopetard/orgs","repos_url":"https://api.github.com/users/dopetard/repos","events_url":"https://api.github.com/users/dopetard/events{/privacy}","received_events_url":"https://api.github.com/users/dopetard/received_events","type":"User","site_admin":false},"repo":{"id":139837096,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MzcwOTY=","name":"xchange","full_name":"dopetard/xchange","private":false,"owner":{"login":"dopetard","id":3644166,"node_id":"MDQ6VXNlcjM2NDQxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3644166?v=4","gravatar_id":"","url":"https://api.github.com/users/dopetard","html_url":"https://github.com/dopetard","followers_url":"https://api.github.com/users/dopetard/followers","following_url":"https://api.github.com/users/dopetard/following{/other_user}","gists_url":"https://api.github.com/users/dopetard/gists{/gist_id}","starred_url":"https://api.github.com/users/dopetard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopetard/subscriptions","organizations_url":"https://api.github.com/users/dopetard/orgs","repos_url":"https://api.github.com/users/dopetard/repos","events_url":"https://api.github.com/users/dopetard/events{/privacy}","received_events_url":"https://api.github.com/users/dopetard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dopetard/xchange","description":"Implementation of Xchange","fork":false,"url":"https://api.github.com/repos/dopetard/xchange","forks_url":"https://api.github.com/repos/dopetard/xchange/forks","keys_url":"https://api.github.com/repos/dopetard/xchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dopetard/xchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dopetard/xchange/teams","hooks_url":"https://api.github.com/repos/dopetard/xchange/hooks","issue_events_url":"https://api.github.com/repos/dopetard/xchange/issues/events{/number}","events_url":"https://api.github.com/repos/dopetard/xchange/events","assignees_url":"https://api.github.com/repos/dopetard/xchange/assignees{/user}","branches_url":"https://api.github.com/repos/dopetard/xchange/branches{/branch}","tags_url":"https://api.github.com/repos/dopetard/xchange/tags","blobs_url":"https://api.github.com/repos/dopetard/xchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dopetard/xchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dopetard/xchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/dopetard/xchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dopetard/xchange/statuses/{sha}","languages_url":"https://api.github.com/repos/dopetard/xchange/languages","stargazers_url":"https://api.github.com/repos/dopetard/xchange/stargazers","contributors_url":"https://api.github.com/repos/dopetard/xchange/contributors","subscribers_url":"https://api.github.com/repos/dopetard/xchange/subscribers","subscription_url":"https://api.github.com/repos/dopetard/xchange/subscription","commits_url":"https://api.github.com/repos/dopetard/xchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/dopetard/xchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/dopetard/xchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/dopetard/xchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/dopetard/xchange/contents/{+path}","compare_url":"https://api.github.com/repos/dopetard/xchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dopetard/xchange/merges","archive_url":"https://api.github.com/repos/dopetard/xchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dopetard/xchange/downloads","issues_url":"https://api.github.com/repos/dopetard/xchange/issues{/number}","pulls_url":"https://api.github.com/repos/dopetard/xchange/pulls{/number}","milestones_url":"https://api.github.com/repos/dopetard/xchange/milestones{/number}","notifications_url":"https://api.github.com/repos/dopetard/xchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dopetard/xchange/labels{/name}","releases_url":"https://api.github.com/repos/dopetard/xchange/releases{/id}","deployments_url":"https://api.github.com/repos/dopetard/xchange/deployments","created_at":"2018-07-05T11:03:19Z","updated_at":"2018-10-30T18:07:26Z","pushed_at":"2018-10-30T18:25:37Z","git_url":"git://github.com/dopetard/xchange.git","ssh_url":"git@github.com:dopetard/xchange.git","clone_url":"https://github.com/dopetard/xchange.git","svn_url":"https://github.com/dopetard/xchange","homepage":"","size":2938,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/85"},"html":{"href":"https://github.com/dopetard/xchange/pull/85"},"issue":{"href":"https://api.github.com/repos/dopetard/xchange/issues/85"},"comments":{"href":"https://api.github.com/repos/dopetard/xchange/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dopetard/xchange/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/dopetard/xchange/statuses/4d7a4ecb5174d56880e0bdeb2334c63382e6cdef"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michael1011"}}