{"action":"created","comment":{"url":"https://api.github.com/repos/angular/tsickle/pulls/comments/206952534","pull_request_review_id":142464848,"id":206952534,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk1MjUzNA==","diff_hunk":"@@ -190,19 +189,51 @@ export function createMultiLineComment(original: ts.Node, text: string) {\n  * to do. By default, tsickle does not report any warnings to the caller, and warnings are hidden\n  * behind a debug flag, as warnings are only for tsickle to debug itself.\n  */\n-export function debugWarn(\n-    host: {logWarning ? (d: ts.Diagnostic) : void}, context: ts.Node, messageText: string) {\n+export function reportDebugWarning(\n+    host: {logWarning ? (d: ts.Diagnostic) : void}, node: ts.Node, messageText: string) {\n   if (!host.logWarning) return;\n-  // Use a ts.Diagnosic so that the warning includes context and file offets.\n-  const diagnostic: ts.Diagnostic = {\n-    file: context.getSourceFile(),\n-    start: context.getStart(),\n-    length: context.getEnd() - context.getStart(),\n+  host.logWarning(createDiagnostic(node, ts.DiagnosticCategory.Warning, messageText));\n+}\n+\n+/**\n+ * Creates and reports a diagnostic by adding it to the given array.\n+ *\n+ * This is used for erros and warnings in tsickle's input. Emit errors (the default) if tsickle\n+ * cannot emit a correct result given the input. Emit warnings for questionable input if there's a\n+ * good chance that the output will work.\n+ *\n+ * For typical tsickle users, errors are always reported and break the compilation operation,","path":"src/transformer_util.ts","position":32,"original_position":32,"commit_id":"6c6f375e05cfcb21b57624a637730fc00dada185","original_commit_id":"6c6f375e05cfcb21b57624a637730fc00dada185","user":{"login":"evmar","id":3847,"node_id":"MDQ6VXNlcjM4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3847?v=4","gravatar_id":"","url":"https://api.github.com/users/evmar","html_url":"https://github.com/evmar","followers_url":"https://api.github.com/users/evmar/followers","following_url":"https://api.github.com/users/evmar/following{/other_user}","gists_url":"https://api.github.com/users/evmar/gists{/gist_id}","starred_url":"https://api.github.com/users/evmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evmar/subscriptions","organizations_url":"https://api.github.com/users/evmar/orgs","repos_url":"https://api.github.com/users/evmar/repos","events_url":"https://api.github.com/users/evmar/events{/privacy}","received_events_url":"https://api.github.com/users/evmar/received_events","type":"User","site_admin":false},"body":"typical = google3?  This user seemed to be experiencing warnings as errors, though I'm not sure what tool they were using. https://github.com/angular/tsickle/issues/863","created_at":"2018-08-01T16:46:15Z","updated_at":"2018-08-01T16:51:47Z","html_url":"https://github.com/angular/tsickle/pull/881#discussion_r206952534","pull_request_url":"https://api.github.com/repos/angular/tsickle/pulls/881","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments/206952534"},"html":{"href":"https://github.com/angular/tsickle/pull/881#discussion_r206952534"},"pull_request":{"href":"https://api.github.com/repos/angular/tsickle/pulls/881"}}},"pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/881","id":205361935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzYxOTM1","html_url":"https://github.com/angular/tsickle/pull/881","diff_url":"https://github.com/angular/tsickle/pull/881.diff","patch_url":"https://github.com/angular/tsickle/pull/881.patch","issue_url":"https://api.github.com/repos/angular/tsickle/issues/881","number":881,"state":"open","locked":false,"title":" Fail on duplicated and run in file comments. ","user":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"In TypeScript, file level comments are comments that are separated from\r\nthe file body with an empty line. In Closure, file level comments are\r\ncomments marked with a particular (often load bearing) JSDoc tag, e.g.\r\n`@fileoverview` or `@pintomodule`.\r\n\r\nIf a TypeScript contains such a Closure file level comment in a comment\r\nthat is *not* a TypeScript file level comment, TypeScript will often not\r\nemit the comment at all, e.g. because it was placed on an interface or\r\ntype import that will not be emitted. That violates user expectations,\r\nas their (load bearing) comment is now silently gone.\r\n\r\nThis change has tsickle report hard errors whenever it encounters a file\r\ncomment that's either not properly separated from the file body, is\r\nduplicated, or appears after the initial statement in the body of the\r\nfile, so that the situation can be discovered and fixed early by the\r\nuser.","created_at":"2018-08-01T09:26:05Z","updated_at":"2018-08-01T16:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a62d607e954063afe36cde9bd8c2aa13f8a8323","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308083292,"node_id":"MDU6TGFiZWwzMDgwODMyOTI=","url":"https://api.github.com/repos/angular/tsickle/labels/cla:%20yes","name":"cla: yes","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/tsickle/pulls/881/commits","review_comments_url":"https://api.github.com/repos/angular/tsickle/pulls/881/comments","review_comment_url":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/881/comments","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/6c6f375e05cfcb21b57624a637730fc00dada185","head":{"label":"angular:file-level-comment-error","ref":"file-level-comment-error","sha":"6c6f375e05cfcb21b57624a637730fc00dada185","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-08-01T07:38:45Z","pushed_at":"2018-08-01T16:00:55Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3237,"stargazers_count":464,"watchers_count":464,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":71,"open_issues":140,"watchers":464,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ee47ee47cc094a1df5e163150b00b96a1ad856f4","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-08-01T07:38:45Z","pushed_at":"2018-08-01T16:00:55Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3237,"stargazers_count":464,"watchers_count":464,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":71,"open_issues":140,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/881"},"html":{"href":"https://github.com/angular/tsickle/pull/881"},"issue":{"href":"https://api.github.com/repos/angular/tsickle/issues/881"},"comments":{"href":"https://api.github.com/repos/angular/tsickle/issues/881/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/tsickle/pulls/881/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/tsickle/pulls/881/commits"},"statuses":{"href":"https://api.github.com/repos/angular/tsickle/statuses/6c6f375e05cfcb21b57624a637730fc00dada185"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"evmar"}}