{"action":"closed","number":15397,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/15397","id":176545793,"html_url":"https://github.com/apple/swift/pull/15397","diff_url":"https://github.com/apple/swift/pull/15397.diff","patch_url":"https://github.com/apple/swift/pull/15397.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/15397","number":15397,"state":"closed","locked":false,"title":" IRGen: Fix witness-table accessors for conditional conformances","user":{"login":"aschwaighofer","id":15268288,"avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"body":"When there is a conditional conformance the witness table accessor is passed one argument in memory. Using ReadNone like we used to do is not correct.\r\n\r\nSR-7228\r\nrdar://38624842","created_at":"2018-03-21T17:02:32Z","updated_at":"2018-03-21T22:13:00Z","closed_at":"2018-03-21T22:12:59Z","merged_at":"2018-03-21T22:12:59Z","merge_commit_sha":"e4679cba61f355e04c1db355af5c54f36e6fd2b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/15397/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/15397/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/15397/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/30da035837c97a32ca05296135139e963e78220b","head":{"label":"aschwaighofer:irgen_fix_mem_attr_witness_table_accessor_conditional_conformance","ref":"irgen_fix_mem_attr_witness_table_accessor_conditional_conformance","sha":"30da035837c97a32ca05296135139e963e78220b","user":{"login":"aschwaighofer","id":15268288,"avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"repo":{"id":47787198,"name":"swift","full_name":"aschwaighofer/swift","owner":{"login":"aschwaighofer","id":15268288,"avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aschwaighofer/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/aschwaighofer/swift","forks_url":"https://api.github.com/repos/aschwaighofer/swift/forks","keys_url":"https://api.github.com/repos/aschwaighofer/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschwaighofer/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschwaighofer/swift/teams","hooks_url":"https://api.github.com/repos/aschwaighofer/swift/hooks","issue_events_url":"https://api.github.com/repos/aschwaighofer/swift/issues/events{/number}","events_url":"https://api.github.com/repos/aschwaighofer/swift/events","assignees_url":"https://api.github.com/repos/aschwaighofer/swift/assignees{/user}","branches_url":"https://api.github.com/repos/aschwaighofer/swift/branches{/branch}","tags_url":"https://api.github.com/repos/aschwaighofer/swift/tags","blobs_url":"https://api.github.com/repos/aschwaighofer/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschwaighofer/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschwaighofer/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschwaighofer/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschwaighofer/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/aschwaighofer/swift/languages","stargazers_url":"https://api.github.com/repos/aschwaighofer/swift/stargazers","contributors_url":"https://api.github.com/repos/aschwaighofer/swift/contributors","subscribers_url":"https://api.github.com/repos/aschwaighofer/swift/subscribers","subscription_url":"https://api.github.com/repos/aschwaighofer/swift/subscription","commits_url":"https://api.github.com/repos/aschwaighofer/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschwaighofer/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschwaighofer/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschwaighofer/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschwaighofer/swift/contents/{+path}","compare_url":"https://api.github.com/repos/aschwaighofer/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschwaighofer/swift/merges","archive_url":"https://api.github.com/repos/aschwaighofer/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschwaighofer/swift/downloads","issues_url":"https://api.github.com/repos/aschwaighofer/swift/issues{/number}","pulls_url":"https://api.github.com/repos/aschwaighofer/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/aschwaighofer/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/aschwaighofer/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschwaighofer/swift/labels{/name}","releases_url":"https://api.github.com/repos/aschwaighofer/swift/releases{/id}","deployments_url":"https://api.github.com/repos/aschwaighofer/swift/deployments","created_at":"2015-12-10T21:01:21Z","updated_at":"2018-03-21T21:26:31Z","pushed_at":"2018-03-21T21:26:29Z","git_url":"git://github.com/aschwaighofer/swift.git","ssh_url":"git@github.com:aschwaighofer/swift.git","clone_url":"https://github.com/aschwaighofer/swift.git","svn_url":"https://github.com/aschwaighofer/swift","homepage":"","size":267694,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e19fc5e1611a918d718c367f10189674e5572eb9","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-03-21T21:44:47Z","pushed_at":"2018-03-21T22:12:59Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":272406,"stargazers_count":43036,"watchers_count":43036,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6774,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6774,"open_issues":293,"watchers":43036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/15397"},"html":{"href":"https://github.com/apple/swift/pull/15397"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/15397"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/15397/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/15397/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/15397/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/30da035837c97a32ca05296135139e963e78220b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aschwaighofer","id":15268288,"avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":6,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"aschwaighofer"}}