{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments/170308847","pull_request_review_id":98982230,"id":170308847,"diff_hunk":"@@ -212,56 +187,6 @@ MeshFilter:\n   m_PrefabInternal: {fileID: 100100000}\n   m_GameObject: {fileID: 1000013883439490}\n   m_Mesh: {fileID: 4300002, guid: d6fab9b92d520f54fb1d447be32320f2, type: 3}\n---- !u!108 &108000011815251248\n-Light:\n-  m_ObjectHideFlags: 1\n-  m_PrefabParentObject: {fileID: 0}\n-  m_PrefabInternal: {fileID: 100100000}\n-  m_GameObject: {fileID: 1000012327360030}","path":"Assets/MixedRealityToolkit/InputModule/Prefabs/Cursor/InteractiveMeshCursor.prefab","position":96,"original_position":96,"commit_id":"f9b954c15031f1a86da99c31c1d4c3b12b74f2ea","original_commit_id":"f9b954c15031f1a86da99c31c1d4c3b12b74f2ea","user":{"login":"Cameron-Micka","id":13305729,"avatar_url":"https://avatars1.githubusercontent.com/u/13305729?v=4","gravatar_id":"","url":"https://api.github.com/users/Cameron-Micka","html_url":"https://github.com/Cameron-Micka","followers_url":"https://api.github.com/users/Cameron-Micka/followers","following_url":"https://api.github.com/users/Cameron-Micka/following{/other_user}","gists_url":"https://api.github.com/users/Cameron-Micka/gists{/gist_id}","starred_url":"https://api.github.com/users/Cameron-Micka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cameron-Micka/subscriptions","organizations_url":"https://api.github.com/users/Cameron-Micka/orgs","repos_url":"https://api.github.com/users/Cameron-Micka/repos","events_url":"https://api.github.com/users/Cameron-Micka/events{/privacy}","received_events_url":"https://api.github.com/users/Cameron-Micka/received_events","type":"User","site_admin":false},"body":"This was the Unity light on the cursor, which was replaced with a HoverLight. I'll fix the missing reference above and make sure if can be toggle on/off like the InteractiveMeshCursor requires. Thanks for pointing this out!","created_at":"2018-02-23T17:05:44Z","updated_at":"2018-02-23T17:05:44Z","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743#discussion_r170308847","pull_request_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments/170308847"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743#discussion_r170308847"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743"}},"in_reply_to_id":170307183},"pull_request":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743","id":170621531,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743","diff_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743.diff","patch_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743.patch","issue_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1743","number":1743,"state":"open","locked":false,"title":"MixedReality/Standard Shading System","user":{"login":"Cameron-Micka","id":13305729,"avatar_url":"https://avatars1.githubusercontent.com/u/13305729?v=4","gravatar_id":"","url":"https://api.github.com/users/Cameron-Micka","html_url":"https://github.com/Cameron-Micka","followers_url":"https://api.github.com/users/Cameron-Micka/followers","following_url":"https://api.github.com/users/Cameron-Micka/following{/other_user}","gists_url":"https://api.github.com/users/Cameron-Micka/gists{/gist_id}","starred_url":"https://api.github.com/users/Cameron-Micka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cameron-Micka/subscriptions","organizations_url":"https://api.github.com/users/Cameron-Micka/orgs","repos_url":"https://api.github.com/users/Cameron-Micka/repos","events_url":"https://api.github.com/users/Cameron-Micka/events{/privacy}","received_events_url":"https://api.github.com/users/Cameron-Micka/received_events","type":"User","site_admin":false},"body":"Overview\r\n---\r\nThis pull request introduces a new MixedReality/Standard shading system (outlined in issue #1715) which utilizes a single, flexible shader that can achieve visuals similar to Unity's Standard Shader, implement Fluent Design System principles, and remain performant on mixed reality devices.\r\n\r\nTo experience many of the new shading techniques available please see the new MaterialGallery example scene (this scene contains only the MixedReality/Standard shader to demonstrate it's flexibility):\r\n![materialgallery](https://user-images.githubusercontent.com/13305729/36511641-4eceafac-171c-11e8-991f-40896f75e2ee.png)\r\n\r\nAll other materials and example scenes have been updated to the new  MixedReality/Standard shader. As demonstrated below:  \r\n![objectgallery](https://user-images.githubusercontent.com/13305729/36511868-3d441406-171d-11e8-9c15-d4c44290c0d8.png)\r\n\r\nOther notable improvements include the addition of a hover light to all MRTK cursors, automatic near plane fade support, and automatic material conversion from Standard and FastConfigurable shaders to the MixedReality/Standard shader.\r\n\r\nThe existing FastConfigurable shader has been moved to \"Obsolete\" but it still available for backwards compatibility until it is decided that it can be safely removed.\r\n\r\nThis PR also includes fixes for broken materials listed in #1721.\r\n\r\nOur team uses and maintains this shader on a daily basis, and in the future, plans to add additional example scenes to the MRTK to help demonstrate functionality.\r\n\r\nChanges\r\n---\r\n- Fixes: #1715 #1721 #1531 \r\n","created_at":"2018-02-21T23:52:19Z","updated_at":"2018-02-23T17:05:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af2ac1bd64320fb9a68b1ce027ff17af9a846e0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1743/comments","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/f9b954c15031f1a86da99c31c1d4c3b12b74f2ea","head":{"label":"Cameron-Micka:Feature_MRStandardShader","ref":"Feature_MRStandardShader","sha":"f9b954c15031f1a86da99c31c1d4c3b12b74f2ea","user":{"login":"Cameron-Micka","id":13305729,"avatar_url":"https://avatars1.githubusercontent.com/u/13305729?v=4","gravatar_id":"","url":"https://api.github.com/users/Cameron-Micka","html_url":"https://github.com/Cameron-Micka","followers_url":"https://api.github.com/users/Cameron-Micka/followers","following_url":"https://api.github.com/users/Cameron-Micka/following{/other_user}","gists_url":"https://api.github.com/users/Cameron-Micka/gists{/gist_id}","starred_url":"https://api.github.com/users/Cameron-Micka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cameron-Micka/subscriptions","organizations_url":"https://api.github.com/users/Cameron-Micka/orgs","repos_url":"https://api.github.com/users/Cameron-Micka/repos","events_url":"https://api.github.com/users/Cameron-Micka/events{/privacy}","received_events_url":"https://api.github.com/users/Cameron-Micka/received_events","type":"User","site_admin":false},"repo":{"id":121307143,"name":"MixedRealityToolkit-Unity","full_name":"Cameron-Micka/MixedRealityToolkit-Unity","owner":{"login":"Cameron-Micka","id":13305729,"avatar_url":"https://avatars1.githubusercontent.com/u/13305729?v=4","gravatar_id":"","url":"https://api.github.com/users/Cameron-Micka","html_url":"https://github.com/Cameron-Micka","followers_url":"https://api.github.com/users/Cameron-Micka/followers","following_url":"https://api.github.com/users/Cameron-Micka/following{/other_user}","gists_url":"https://api.github.com/users/Cameron-Micka/gists{/gist_id}","starred_url":"https://api.github.com/users/Cameron-Micka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cameron-Micka/subscriptions","organizations_url":"https://api.github.com/users/Cameron-Micka/orgs","repos_url":"https://api.github.com/users/Cameron-Micka/repos","events_url":"https://api.github.com/users/Cameron-Micka/events{/privacy}","received_events_url":"https://api.github.com/users/Cameron-Micka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cameron-Micka/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":true,"url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Cameron-Micka/MixedRealityToolkit-Unity/deployments","created_at":"2018-02-12T21:57:14Z","updated_at":"2018-02-12T21:57:29Z","pushed_at":"2018-02-23T02:10:40Z","git_url":"git://github.com/Cameron-Micka/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:Cameron-Micka/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/Cameron-Micka/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/Cameron-Micka/MixedRealityToolkit-Unity","homepage":"","size":544206,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:Dev_Working_Branch","ref":"Dev_Working_Branch","sha":"2d4a6e5ecbe42dd374cb919e22259ce078a2a908","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"name":"MixedRealityToolkit-Unity","full_name":"Microsoft/MixedRealityToolkit-Unity","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":false,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2018-02-23T00:31:49Z","pushed_at":"2018-02-23T16:51:00Z","git_url":"git://github.com/Microsoft/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","homepage":"","size":532239,"stargazers_count":1501,"watchers_count":1501,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":743,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":743,"open_issues":309,"watchers":1501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1743"},"issue":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1743"},"comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/f9b954c15031f1a86da99c31c1d4c3b12b74f2ea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Cameron-Micka"}}