{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5","id":229155593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTU1NTkz","html_url":"https://github.com/CDAT/jupyter-vcdat/pull/5","diff_url":"https://github.com/CDAT/jupyter-vcdat/pull/5.diff","patch_url":"https://github.com/CDAT/jupyter-vcdat/pull/5.patch","issue_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/5","number":5,"state":"open","locked":false,"title":"Vcdat2.0 sterling","user":{"login":"sterlingbaldwin","id":6477639,"node_id":"MDQ6VXNlcjY0Nzc2Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6477639?v=4","gravatar_id":"","url":"https://api.github.com/users/sterlingbaldwin","html_url":"https://github.com/sterlingbaldwin","followers_url":"https://api.github.com/users/sterlingbaldwin/followers","following_url":"https://api.github.com/users/sterlingbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/sterlingbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sterlingbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sterlingbaldwin/subscriptions","organizations_url":"https://api.github.com/users/sterlingbaldwin/orgs","repos_url":"https://api.github.com/users/sterlingbaldwin/repos","events_url":"https://api.github.com/users/sterlingbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/sterlingbaldwin/received_events","type":"User","site_admin":false},"body":"Fixes three issues:\r\n\r\n1) When a user hits plot without first selecting a graphics method or template, uses the \"default\" for either instead of erroring.\r\n2) After a plot has been run, the code that collected the variables/gms/templates would crash. This is because there was an assumption that the call to ```document.getElementsByClassName(\"jp-OutputArea-output\")``` would return a single element array. Instead I changed it to collect the whole array, and just pop off the last element of it. This seams to have fixed the issue.\r\n3) Removes the requirement to use vcs.js, and moves the call to an HTTP API call to the backend server extension.","created_at":"2018-11-07T20:17:58Z","updated_at":"2018-11-07T20:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5/commits","review_comments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5/comments","review_comment_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/5/comments","statuses_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/statuses/1716df0954c7e413cdb575799190d7a25b135621","head":{"label":"CDAT:vcdat2.0-sterling","ref":"vcdat2.0-sterling","sha":"1716df0954c7e413cdb575799190d7a25b135621","user":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":147574270,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NzQyNzA=","name":"jupyter-vcdat","full_name":"CDAT/jupyter-vcdat","private":false,"owner":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CDAT/jupyter-vcdat","description":"Learning to make extensions for Jupyter Lab, and building with React components.","fork":false,"url":"https://api.github.com/repos/CDAT/jupyter-vcdat","forks_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/forks","keys_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/teams","hooks_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/hooks","issue_events_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/events{/number}","events_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/events","assignees_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/assignees{/user}","branches_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/branches{/branch}","tags_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/tags","blobs_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/languages","stargazers_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/stargazers","contributors_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/contributors","subscribers_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/subscribers","subscription_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/subscription","commits_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/contents/{+path}","compare_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/merges","archive_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/downloads","issues_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues{/number}","pulls_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/labels{/name}","releases_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/releases{/id}","deployments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/deployments","created_at":"2018-09-05T20:13:37Z","updated_at":"2018-10-29T13:32:01Z","pushed_at":"2018-11-07T20:13:56Z","git_url":"git://github.com/CDAT/jupyter-vcdat.git","ssh_url":"git@github.com:CDAT/jupyter-vcdat.git","clone_url":"https://github.com/CDAT/jupyter-vcdat.git","svn_url":"https://github.com/CDAT/jupyter-vcdat","homepage":null,"size":8139,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CDAT:master","ref":"master","sha":"862d643e47d1cbe57bb44c03a1e7b6c81df73cf0","user":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":147574270,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NzQyNzA=","name":"jupyter-vcdat","full_name":"CDAT/jupyter-vcdat","private":false,"owner":{"login":"CDAT","id":2781444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODE0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2781444?v=4","gravatar_id":"","url":"https://api.github.com/users/CDAT","html_url":"https://github.com/CDAT","followers_url":"https://api.github.com/users/CDAT/followers","following_url":"https://api.github.com/users/CDAT/following{/other_user}","gists_url":"https://api.github.com/users/CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDAT/subscriptions","organizations_url":"https://api.github.com/users/CDAT/orgs","repos_url":"https://api.github.com/users/CDAT/repos","events_url":"https://api.github.com/users/CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/CDAT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CDAT/jupyter-vcdat","description":"Learning to make extensions for Jupyter Lab, and building with React components.","fork":false,"url":"https://api.github.com/repos/CDAT/jupyter-vcdat","forks_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/forks","keys_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/teams","hooks_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/hooks","issue_events_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/events{/number}","events_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/events","assignees_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/assignees{/user}","branches_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/branches{/branch}","tags_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/tags","blobs_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/languages","stargazers_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/stargazers","contributors_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/contributors","subscribers_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/subscribers","subscription_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/subscription","commits_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/contents/{+path}","compare_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/merges","archive_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/downloads","issues_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues{/number}","pulls_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/labels{/name}","releases_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/releases{/id}","deployments_url":"https://api.github.com/repos/CDAT/jupyter-vcdat/deployments","created_at":"2018-09-05T20:13:37Z","updated_at":"2018-10-29T13:32:01Z","pushed_at":"2018-11-07T20:13:56Z","git_url":"git://github.com/CDAT/jupyter-vcdat.git","ssh_url":"git@github.com:CDAT/jupyter-vcdat.git","clone_url":"https://github.com/CDAT/jupyter-vcdat.git","svn_url":"https://github.com/CDAT/jupyter-vcdat","homepage":null,"size":8139,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5"},"html":{"href":"https://github.com/CDAT/jupyter-vcdat/pull/5"},"issue":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/5"},"comments":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/CDAT/jupyter-vcdat/statuses/1716df0954c7e413cdb575799190d7a25b135621"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":137,"deletions":95,"changed_files":87}}
{"actor":{"display_login":"sterlingbaldwin"}}