{"action":"opened","issue":{"url":"https://api.github.com/repos/knative/build-pipeline/issues/227","repository_url":"https://api.github.com/repos/knative/build-pipeline","labels_url":"https://api.github.com/repos/knative/build-pipeline/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/knative/build-pipeline/issues/227/comments","events_url":"https://api.github.com/repos/knative/build-pipeline/issues/227/events","html_url":"https://github.com/knative/build-pipeline/issues/227","id":377972597,"node_id":"MDU6SXNzdWUzNzc5NzI1OTc=","number":227,"title":"Create integration tests for `knative/serving` with PipelineRun + TaskRun","user":{"login":"bobcatfish","id":432502,"node_id":"MDQ6VXNlcjQzMjUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/432502?v=4","gravatar_id":"","url":"https://api.github.com/users/bobcatfish","html_url":"https://github.com/bobcatfish","followers_url":"https://api.github.com/users/bobcatfish/followers","following_url":"https://api.github.com/users/bobcatfish/following{/other_user}","gists_url":"https://api.github.com/users/bobcatfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bobcatfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobcatfish/subscriptions","organizations_url":"https://api.github.com/users/bobcatfish/orgs","repos_url":"https://api.github.com/users/bobcatfish/repos","events_url":"https://api.github.com/users/bobcatfish/events{/privacy}","received_events_url":"https://api.github.com/users/bobcatfish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/knative/build-pipeline/milestones/2","html_url":"https://github.com/knative/build-pipeline/milestone/2","labels_url":"https://api.github.com/repos/knative/build-pipeline/milestones/2/labels","id":3792285,"node_id":"MDk6TWlsZXN0b25lMzc5MjI4NQ==","number":2,"title":"0.0.1 Alpha release","description":"The goal of this milestone is to get the project to the point that it's stable enough that folks can actually use it.","creator":{"login":"bobcatfish","id":432502,"node_id":"MDQ6VXNlcjQzMjUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/432502?v=4","gravatar_id":"","url":"https://api.github.com/users/bobcatfish","html_url":"https://github.com/bobcatfish","followers_url":"https://api.github.com/users/bobcatfish/followers","following_url":"https://api.github.com/users/bobcatfish/following{/other_user}","gists_url":"https://api.github.com/users/bobcatfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bobcatfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobcatfish/subscriptions","organizations_url":"https://api.github.com/users/bobcatfish/orgs","repos_url":"https://api.github.com/users/bobcatfish/repos","events_url":"https://api.github.com/users/bobcatfish/events{/privacy}","received_events_url":"https://api.github.com/users/bobcatfish/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":1,"state":"open","created_at":"2018-11-03T00:02:14Z","updated_at":"2018-11-06T18:15:52Z","due_on":"2018-12-14T08:00:00Z","closed_at":null},"comments":0,"created_at":"2018-11-06T18:15:52Z","updated_at":"2018-11-06T18:15:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Expected Behavior\r\nIn github.com/knative/serving, a [`Configuration`](https://github.com/knative/serving/blob/master/docs/spec/spec.md#configuration) (see [overview](https://github.com/knative/serving/blob/master/docs/spec/overview.md)) can contain a `Build`, which can be used to build the image which will be used in the `Revision`.\r\n\r\nThanks to [duck typing](https://docs.google.com/document/d/16j8C91jML4fQRQPhnHihNJUJDcbvW0RM1YAX2REHgyY/edit) (viewable by members of [knative-dev@](https://groups.google.com/forum/#!forum/knative-dev)), it should be possible to use a `PipelineRun` or a `TaskRun` instead.\r\n\r\nWe should have [e2e tests](https://github.com/knative/serving/blob/master/test/adding_tests.md) (maybe even confromance tests?) inside `knative/serving` which verify that `Build` can be swapped out for a `TaskRun` or a `PipelineRun`.\r\n\r\n## Actual Behavior\r\n\r\nWhile this theoretically should work, we haven't tried it and there is nothing to ensure this keeps working over time.\r\n\r\n## Steps to Reproduce the Problem\r\n\r\nThe test should:\r\n  1. Create a Configuration where the [spec.build](https://github.com/knative/serving/blob/master/docs/spec/spec.md#configuration) contains a TaskRun definition that uses a Task which builds the image which the Revision will use.\r\n  2. Deploy the Configuration\r\n  3. Verify that the image was built and deployed\r\n\r\nRepeat the same for a `PipelineRun`.\r\n\r\n## Additional Info\r\nPart of #147 "}}
{"actor":{"display_login":"bobcatfish"}}