{"action":"created","issue":{"url":"https://api.github.com/repos/cloudtools/stacker/issues/631","repository_url":"https://api.github.com/repos/cloudtools/stacker","labels_url":"https://api.github.com/repos/cloudtools/stacker/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/cloudtools/stacker/issues/631/comments","events_url":"https://api.github.com/repos/cloudtools/stacker/issues/631/events","html_url":"https://github.com/cloudtools/stacker/issues/631","id":342546899,"node_id":"MDU6SXNzdWUzNDI1NDY4OTk=","number":631,"title":"Disabling Rollback and Custom S3 Bucket/Key","user":{"login":"Spareo","id":6540323,"node_id":"MDQ6VXNlcjY1NDAzMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6540323?v=4","gravatar_id":"","url":"https://api.github.com/users/Spareo","html_url":"https://github.com/Spareo","followers_url":"https://api.github.com/users/Spareo/followers","following_url":"https://api.github.com/users/Spareo/following{/other_user}","gists_url":"https://api.github.com/users/Spareo/gists{/gist_id}","starred_url":"https://api.github.com/users/Spareo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spareo/subscriptions","organizations_url":"https://api.github.com/users/Spareo/orgs","repos_url":"https://api.github.com/users/Spareo/repos","events_url":"https://api.github.com/users/Spareo/events{/privacy}","received_events_url":"https://api.github.com/users/Spareo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-19T01:29:22Z","updated_at":"2018-07-19T04:42:24Z","closed_at":null,"author_association":"NONE","body":"I just have a couple questions for some things I haven't been able to find. I have dug around the source a bit but just wanted to verify here.\r\n\r\n1. Is it possible to disable the rollback feature if the stack fails to deploy? We have a lot of stuff that goes on in UserData and if that fails, we like to get on the EC2 instance and troubleshoot. With rollback, it kills the instances so we can't do this anymore.\r\n\r\n2. I am aware that you can set a custom bucket for where the template is uploaded, but is it possible to also set the Key so it goes into specific folders in the bucket? "},"comment":{"url":"https://api.github.com/repos/cloudtools/stacker/issues/comments/406152779","html_url":"https://github.com/cloudtools/stacker/issues/631#issuecomment-406152779","issue_url":"https://api.github.com/repos/cloudtools/stacker/issues/631","id":406152779,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjE1Mjc3OQ==","user":{"login":"xiaket","id":171967,"node_id":"MDQ6VXNlcjE3MTk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/171967?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaket","html_url":"https://github.com/xiaket","followers_url":"https://api.github.com/users/xiaket/followers","following_url":"https://api.github.com/users/xiaket/following{/other_user}","gists_url":"https://api.github.com/users/xiaket/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaket/subscriptions","organizations_url":"https://api.github.com/users/xiaket/orgs","repos_url":"https://api.github.com/users/xiaket/repos","events_url":"https://api.github.com/users/xiaket/events{/privacy}","received_events_url":"https://api.github.com/users/xiaket/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T04:42:24Z","updated_at":"2018-07-19T04:42:24Z","author_association":"CONTRIBUTOR","body":"To answer your question:\r\n\r\n1. I think the current codebase does not support this feature. To disable rollback, we must specify `OnFailure='DO_NOTHING'` during stack creation. When we build the arguments for Cloudformation in `generate_cloudformation_args` in `~/providers/aws/default.py` file, we have not included this flag at all. Correct me if I'm wrong, but I think you cannot disable rollback for an existing stack.\r\n\r\nI think it is possible to add support for this feature, reading environment variables would be a quick fix, but I don't know whether that's a good idea. I think it's more about design than the implementation.\r\n\r\n2. I think the path is hardcoded in `stack_template_key_name` in `actions/base.py` file. If you are familiar with Python, I guess you could somehow override this function with a wrapper around stacker command. Again, this could be customisable, but I don't think it's a good idea. Mixing other things with cloudformation templates in a single bucket does not make sense to me, but that's just my personal opinion."}}
{"actor":{"display_login":"xiaket"}}