{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/24131","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24131/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24131/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24131/events","html_url":"https://github.com/cms-sw/cmssw/pull/24131","id":345784376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODI0NjAw","number":24131,"title":"Preparing RecoEgamma_PhotonIdentification for Fall17 V2 MVA ID","user":{"login":"guitargeek","id":6578603,"node_id":"MDQ6VXNlcjY1Nzg2MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6578603?v=4","gravatar_id":"","url":"https://api.github.com/users/guitargeek","html_url":"https://github.com/guitargeek","followers_url":"https://api.github.com/users/guitargeek/followers","following_url":"https://api.github.com/users/guitargeek/following{/other_user}","gists_url":"https://api.github.com/users/guitargeek/gists{/gist_id}","starred_url":"https://api.github.com/users/guitargeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitargeek/subscriptions","organizations_url":"https://api.github.com/users/guitargeek/orgs","repos_url":"https://api.github.com/users/guitargeek/repos","events_url":"https://api.github.com/users/guitargeek/events{/privacy}","received_events_url":"https://api.github.com/users/guitargeek/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"node_id":"MDU6TGFiZWw1Mjg4MTE3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"node_id":"MDU6TGFiZWw1MjgyMDU0OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77","html_url":"https://github.com/cms-sw/cmssw/milestone/77","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77/labels","id":3502981,"node_id":"MDk6TWlsZXN0b25lMzUwMjk4MQ==","number":77,"title":"CMSSW_10_3_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":319,"state":"open","created_at":"2018-07-17T14:14:12Z","updated_at":"2018-08-06T12:55:51Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2018-07-30T14:33:07Z","updated_at":"2018-08-06T13:08:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24131","html_url":"https://github.com/cms-sw/cmssw/pull/24131","diff_url":"https://github.com/cms-sw/cmssw/pull/24131.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24131.patch"},"body":"* Updated weight file names to fit the new naming scheme of the now gzipped weight files (see https://github.com/cms-sw/cmsdist/pull/4230).\r\n\r\n* Implemented MVA category finding with cut parser for photons as well, now that the multithreading-related bugs got ironed out on the electron side:\r\n  https://github.com/guitargeek/cmssw/blob/PhotonMVA_10_3_X_without_new_ID/RecoEgamma/PhotonIdentification/plugins/PhotonMVAEstimator.cc#L127.\r\n\r\n* Moved remaining effective area files from https://github.com/cms-data/RecoEgamma-PhotonIdentification back to CMSSW, since most of them already were in CMSSW and they are very small.\r\n\r\n* Brought back 2014 Electron MVA ID config file to achieve backwards compatibility until the beginning of run 2. Now that the MVA framework is rewritten in a flexible way, there wouldn't have been any reason to delete old IDs a few months ago.\r\n\r\n* Started to improve `PhotonIDValueMapProducer.cc` since it became slow and difficult to maintain. I spotted for example the bug that https://github.com/cms-sw/cmssw/blob/master/RecoEgamma/PhotonIdentification/plugins/PhotonIDValueMapProducer.cc#L496 and https://github.com/cms-sw/cmssw/blob/master/RecoEgamma/PhotonIdentification/plugins/PhotonIDValueMapProducer.cc#L507 calculate exactly the same thing.\r\n\r\n* Config file for actual Fall17 V2 PhotonMVA will follow later after validation within Egamma.\r\n\r\n__Has to be tested with__ https://github.com/cms-sw/cmsdist/pull/4230."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/410702030","html_url":"https://github.com/cms-sw/cmssw/pull/24131#issuecomment-410702030","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24131","id":410702030,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDcwMjAzMA==","user":{"login":"slava77","id":4676718,"node_id":"MDQ6VXNlcjQ2NzY3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T13:08:56Z","updated_at":"2018-08-06T13:08:56Z","author_association":"CONTRIBUTOR","body":"about the ```getByLabel ```. If it's still needed for FWLIte interface support, it's somewhat OK to have it (```getByLabel ```)  in the main framework implementation.\r\n\r\nWhat it the reason now that the fwlite mechanism is not working?\r\n"}}
{"actor":{"display_login":"slava77"}}