{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/206412735","pull_request_review_id":141821121,"id":206412735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQxMjczNQ==","diff_hunk":"@@ -608,7 +637,20 @@ func findPath(tx *bolt.Tx, graph *channeldb.ChannelGraph,\n \t\t// edges), then we're done here and can exit the graph\n \t\t// traversal early.\n \t\tif bytes.Equal(bestNode.PubKeyBytes[:], targetVertex[:]) {\n-\t\t\tbreak\n+\t\t\t// In the event that we're sending payments to ourselves,\n+\t\t\t// we don't want to give up when starting at the source,\n+\t\t\t// thinking the shortest path is zero.\n+\t\t\t// But, at the same time, we want to ensure the second time\n+\t\t\t// that source shows up, it's considered 'destination reached.'\n+\t\t\tif distance[sourceVertex].dist == infinity &&\n+\t\t\t\tsourceNode.PubKeyBytes == targetNode.PubKeyBytes{\n+\t\t\t\tdistance[sourceVertex] = nodeWithDist{\n+                 \t\t\tdist: infinity-1,\n+\t\t\t\t\tnode: sourceNode,\n+               \t\t\t}\n+\t\t\t} else {\n+\t\t\t\tbreak\n+\t\t\t}","path":"routing/pathfind.go","position":66,"original_position":66,"commit_id":"ea0649608d929522026887a966706e3538146436","original_commit_id":"ea0649608d929522026887a966706e3538146436","user":{"login":"ZapUser77","id":40261754,"node_id":"MDQ6VXNlcjQwMjYxNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/40261754?v=4","gravatar_id":"","url":"https://api.github.com/users/ZapUser77","html_url":"https://github.com/ZapUser77","followers_url":"https://api.github.com/users/ZapUser77/followers","following_url":"https://api.github.com/users/ZapUser77/following{/other_user}","gists_url":"https://api.github.com/users/ZapUser77/gists{/gist_id}","starred_url":"https://api.github.com/users/ZapUser77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZapUser77/subscriptions","organizations_url":"https://api.github.com/users/ZapUser77/orgs","repos_url":"https://api.github.com/users/ZapUser77/repos","events_url":"https://api.github.com/users/ZapUser77/events{/privacy}","received_events_url":"https://api.github.com/users/ZapUser77/received_events","type":"User","site_admin":false},"body":"First time using GitHub.  I'm assuming the reviewers run the unit tests, correct?","created_at":"2018-07-31T06:56:24Z","updated_at":"2018-07-31T06:56:24Z","html_url":"https://github.com/lightningnetwork/lnd/pull/1652#discussion_r206412735","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/206412735"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/1652#discussion_r206412735"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652"}},"in_reply_to_id":206408686},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652","id":204751610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzUxNjEw","html_url":"https://github.com/lightningnetwork/lnd/pull/1652","diff_url":"https://github.com/lightningnetwork/lnd/pull/1652.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/1652.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1652","number":1652,"state":"open","locked":false,"title":"Update pathfind.go to allow sending to self","user":{"login":"ZapUser77","id":40261754,"node_id":"MDQ6VXNlcjQwMjYxNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/40261754?v=4","gravatar_id":"","url":"https://api.github.com/users/ZapUser77","html_url":"https://github.com/ZapUser77","followers_url":"https://api.github.com/users/ZapUser77/followers","following_url":"https://api.github.com/users/ZapUser77/following{/other_user}","gists_url":"https://api.github.com/users/ZapUser77/gists{/gist_id}","starred_url":"https://api.github.com/users/ZapUser77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZapUser77/subscriptions","organizations_url":"https://api.github.com/users/ZapUser77/orgs","repos_url":"https://api.github.com/users/ZapUser77/repos","events_url":"https://api.github.com/users/ZapUser77/events{/privacy}","received_events_url":"https://api.github.com/users/ZapUser77/received_events","type":"User","site_admin":false},"body":"This commit allows payments to be sent to one's self, in order to balance channels.  It has added loop prevention mechanisms as well.\r\nIt also ensures that payments to one's self only comes in channels with sufficient balance.","created_at":"2018-07-30T09:55:19Z","updated_at":"2018-07-31T06:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8777655147c760bb1000fe4ce14ee7ec1716d03f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1652/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/ea0649608d929522026887a966706e3538146436","head":{"label":"ZapUser77:master","ref":"master","sha":"ea0649608d929522026887a966706e3538146436","user":{"login":"ZapUser77","id":40261754,"node_id":"MDQ6VXNlcjQwMjYxNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/40261754?v=4","gravatar_id":"","url":"https://api.github.com/users/ZapUser77","html_url":"https://github.com/ZapUser77","followers_url":"https://api.github.com/users/ZapUser77/followers","following_url":"https://api.github.com/users/ZapUser77/following{/other_user}","gists_url":"https://api.github.com/users/ZapUser77/gists{/gist_id}","starred_url":"https://api.github.com/users/ZapUser77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZapUser77/subscriptions","organizations_url":"https://api.github.com/users/ZapUser77/orgs","repos_url":"https://api.github.com/users/ZapUser77/repos","events_url":"https://api.github.com/users/ZapUser77/events{/privacy}","received_events_url":"https://api.github.com/users/ZapUser77/received_events","type":"User","site_admin":false},"repo":{"id":142735515,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MzU1MTU=","name":"lnd","full_name":"ZapUser77/lnd","owner":{"login":"ZapUser77","id":40261754,"node_id":"MDQ6VXNlcjQwMjYxNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/40261754?v=4","gravatar_id":"","url":"https://api.github.com/users/ZapUser77","html_url":"https://github.com/ZapUser77","followers_url":"https://api.github.com/users/ZapUser77/followers","following_url":"https://api.github.com/users/ZapUser77/following{/other_user}","gists_url":"https://api.github.com/users/ZapUser77/gists{/gist_id}","starred_url":"https://api.github.com/users/ZapUser77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZapUser77/subscriptions","organizations_url":"https://api.github.com/users/ZapUser77/orgs","repos_url":"https://api.github.com/users/ZapUser77/repos","events_url":"https://api.github.com/users/ZapUser77/events{/privacy}","received_events_url":"https://api.github.com/users/ZapUser77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZapUser77/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/ZapUser77/lnd","forks_url":"https://api.github.com/repos/ZapUser77/lnd/forks","keys_url":"https://api.github.com/repos/ZapUser77/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZapUser77/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZapUser77/lnd/teams","hooks_url":"https://api.github.com/repos/ZapUser77/lnd/hooks","issue_events_url":"https://api.github.com/repos/ZapUser77/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/ZapUser77/lnd/events","assignees_url":"https://api.github.com/repos/ZapUser77/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/ZapUser77/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/ZapUser77/lnd/tags","blobs_url":"https://api.github.com/repos/ZapUser77/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZapUser77/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZapUser77/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZapUser77/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZapUser77/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/ZapUser77/lnd/languages","stargazers_url":"https://api.github.com/repos/ZapUser77/lnd/stargazers","contributors_url":"https://api.github.com/repos/ZapUser77/lnd/contributors","subscribers_url":"https://api.github.com/repos/ZapUser77/lnd/subscribers","subscription_url":"https://api.github.com/repos/ZapUser77/lnd/subscription","commits_url":"https://api.github.com/repos/ZapUser77/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZapUser77/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZapUser77/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZapUser77/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZapUser77/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/ZapUser77/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZapUser77/lnd/merges","archive_url":"https://api.github.com/repos/ZapUser77/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZapUser77/lnd/downloads","issues_url":"https://api.github.com/repos/ZapUser77/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/ZapUser77/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/ZapUser77/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/ZapUser77/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZapUser77/lnd/labels{/name}","releases_url":"https://api.github.com/repos/ZapUser77/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/ZapUser77/lnd/deployments","created_at":"2018-07-29T06:07:52Z","updated_at":"2018-07-30T09:46:47Z","pushed_at":"2018-07-30T11:36:50Z","git_url":"git://github.com/ZapUser77/lnd.git","ssh_url":"git@github.com:ZapUser77/lnd.git","clone_url":"https://github.com/ZapUser77/lnd.git","svn_url":"https://github.com/ZapUser77/lnd","homepage":"","size":17289,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"804598057dd844868f6eaf2225e63cd7e1cdb0f0","user":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"node_id":"MDEwOlJlcG9zaXRvcnk0OTc2NTQ4MA==","name":"lnd","full_name":"lightningnetwork/lnd","owner":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2018-07-31T06:26:39Z","pushed_at":"2018-07-31T06:41:12Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":17283,"stargazers_count":2838,"watchers_count":2838,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":705,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":705,"open_issues":246,"watchers":2838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/1652"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/1652"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/1652/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1652/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/ea0649608d929522026887a966706e3538146436"}},"author_association":"NONE"}}
{"actor":{"display_login":"ZapUser77"}}