{"action":"created","issue":{"url":"https://api.github.com/repos/jgraichen/restify/issues/14","repository_url":"https://api.github.com/repos/jgraichen/restify","labels_url":"https://api.github.com/repos/jgraichen/restify/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/jgraichen/restify/issues/14/comments","events_url":"https://api.github.com/repos/jgraichen/restify/issues/14/events","html_url":"https://github.com/jgraichen/restify/pull/14","id":346622648,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDQyNTIw","number":14,"title":"Spec out and fix header precedence","user":{"login":"franzliedke","id":249125,"node_id":"MDQ6VXNlcjI0OTEyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/249125?v=4","gravatar_id":"","url":"https://api.github.com/users/franzliedke","html_url":"https://github.com/franzliedke","followers_url":"https://api.github.com/users/franzliedke/followers","following_url":"https://api.github.com/users/franzliedke/following{/other_user}","gists_url":"https://api.github.com/users/franzliedke/gists{/gist_id}","starred_url":"https://api.github.com/users/franzliedke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franzliedke/subscriptions","organizations_url":"https://api.github.com/users/franzliedke/orgs","repos_url":"https://api.github.com/users/franzliedke/repos","events_url":"https://api.github.com/users/franzliedke/events{/privacy}","received_events_url":"https://api.github.com/users/franzliedke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-01T14:22:40Z","updated_at":"2018-08-01T15:07:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jgraichen/restify/pulls/14","html_url":"https://github.com/jgraichen/restify/pull/14","diff_url":"https://github.com/jgraichen/restify/pull/14.diff","patch_url":"https://github.com/jgraichen/restify/pull/14.patch"},"body":"This adds some feature specs (I hope you agree with that name, I did not want to clutter up the `restify_spec.rb` file, which IMO is a nice high-level example of library usage, not sweating the details).\r\n\r\nThe specs clearly define how request headers can be added both on a context level and per request. They describe the behavior that would make sense from my perspective, but requires some small fixes in how request opts are merged.\r\n\r\nSince no previously existing tests are failing with the new behavior, I would argue this does not have to be considered as breaking backwards compatibility, we are simply changing unspecified behavior (and making it more expectable). So, no major release would be necessary."},"comment":{"url":"https://api.github.com/repos/jgraichen/restify/issues/comments/409608300","html_url":"https://github.com/jgraichen/restify/pull/14#issuecomment-409608300","issue_url":"https://api.github.com/repos/jgraichen/restify/issues/14","id":409608300,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTYwODMwMA==","user":{"login":"franzliedke","id":249125,"node_id":"MDQ6VXNlcjI0OTEyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/249125?v=4","gravatar_id":"","url":"https://api.github.com/users/franzliedke","html_url":"https://github.com/franzliedke","followers_url":"https://api.github.com/users/franzliedke/followers","following_url":"https://api.github.com/users/franzliedke/following{/other_user}","gists_url":"https://api.github.com/users/franzliedke/gists{/gist_id}","starred_url":"https://api.github.com/users/franzliedke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franzliedke/subscriptions","organizations_url":"https://api.github.com/users/franzliedke/orgs","repos_url":"https://api.github.com/users/franzliedke/repos","events_url":"https://api.github.com/users/franzliedke/events{/privacy}","received_events_url":"https://api.github.com/users/franzliedke/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T15:07:24Z","updated_at":"2018-08-01T15:07:24Z","author_association":"COLLABORATOR","body":"Fixed both, let's see if tests are passing this time."}}
{"actor":{"display_login":"franzliedke"}}