{"action":"created","comment":{"url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/comments/174835643","pull_request_review_id":104265916,"id":174835643,"diff_hunk":"@@ -410,18 +387,22 @@ func (h *handler) HandleQuota(ctx context.Context, inst *quotaT.Instance, args a\n // For future compatibility with Istio, accepts the \"encoded\" base64 string value\n // until request.auth.claims attribute is defined and supported.\n // see: https://github.com/istio/istio/issues/3194\n-func convertClaims(log adapter.Logger, claims map[string]string) map[string]interface{} {\n-\tvar claimsOut = map[string]interface{}{}\n-\tif len(claims) > 1 {\n-\t\tfor k, v := range claims {\n-\t\t\tclaimsOut[k] = v\n+func resolveClaims(log adapter.Logger, claimsIn map[string]string) map[string]interface{} {","path":"apigee/adapter.go","position":137,"original_position":137,"commit_id":"de30cc8d4985a5fd17078f3586039b8b4e1cc2bd","original_commit_id":"de30cc8d4985a5fd17078f3586039b8b4e1cc2bd","user":{"login":"robbrit","id":39163,"avatar_url":"https://avatars1.githubusercontent.com/u/39163?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrit","html_url":"https://github.com/robbrit","followers_url":"https://api.github.com/users/robbrit/followers","following_url":"https://api.github.com/users/robbrit/following{/other_user}","gists_url":"https://api.github.com/users/robbrit/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrit/subscriptions","organizations_url":"https://api.github.com/users/robbrit/orgs","repos_url":"https://api.github.com/users/robbrit/repos","events_url":"https://api.github.com/users/robbrit/events{/privacy}","received_events_url":"https://api.github.com/users/robbrit/received_events","type":"User","site_admin":false},"body":"Can you add a little comment to say what this function does? It looks like it's filtering the claims, but I am not 100% sure.","created_at":"2018-03-15T15:57:10Z","updated_at":"2018-03-15T16:01:35Z","html_url":"https://github.com/apigee/istio-mixer-adapter/pull/8#discussion_r174835643","pull_request_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/comments/174835643"},"html":{"href":"https://github.com/apigee/istio-mixer-adapter/pull/8#discussion_r174835643"},"pull_request":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8","id":175123181,"html_url":"https://github.com/apigee/istio-mixer-adapter/pull/8","diff_url":"https://github.com/apigee/istio-mixer-adapter/pull/8.diff","patch_url":"https://github.com/apigee/istio-mixer-adapter/pull/8.patch","issue_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/8","number":8,"state":"open","locked":false,"title":"Common claims handling","user":{"login":"theganyo","id":772731,"avatar_url":"https://avatars2.githubusercontent.com/u/772731?v=4","gravatar_id":"","url":"https://api.github.com/users/theganyo","html_url":"https://github.com/theganyo","followers_url":"https://api.github.com/users/theganyo/followers","following_url":"https://api.github.com/users/theganyo/following{/other_user}","gists_url":"https://api.github.com/users/theganyo/gists{/gist_id}","starred_url":"https://api.github.com/users/theganyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theganyo/subscriptions","organizations_url":"https://api.github.com/users/theganyo/orgs","repos_url":"https://api.github.com/users/theganyo/repos","events_url":"https://api.github.com/users/theganyo/events{/privacy}","received_events_url":"https://api.github.com/users/theganyo/received_events","type":"User","site_admin":false},"body":"enable full auth handling via HandleAuthorization and remove HandleAPIKey","created_at":"2018-03-15T00:56:28Z","updated_at":"2018-03-15T16:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e22d0c5f32d3b6f4f0ce0f9293b77f23c184328","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8/commits","review_comments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8/comments","review_comment_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/8/comments","statuses_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/statuses/de30cc8d4985a5fd17078f3586039b8b4e1cc2bd","head":{"label":"apigee:common-claims-handling","ref":"common-claims-handling","sha":"de30cc8d4985a5fd17078f3586039b8b4e1cc2bd","user":{"login":"apigee","id":19557821,"avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"repo":{"id":124308494,"name":"istio-mixer-adapter","full_name":"apigee/istio-mixer-adapter","owner":{"login":"apigee","id":19557821,"avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apigee/istio-mixer-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/apigee/istio-mixer-adapter","forks_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/forks","keys_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/teams","hooks_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/hooks","issue_events_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/events","assignees_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/tags","blobs_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/languages","stargazers_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/stargazers","contributors_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/contributors","subscribers_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/subscribers","subscription_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/subscription","commits_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/merges","archive_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/downloads","issues_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/labels{/name}","releases_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/deployments","created_at":"2018-03-07T23:43:09Z","updated_at":"2018-03-14T22:46:55Z","pushed_at":"2018-03-15T00:56:29Z","git_url":"git://github.com/apigee/istio-mixer-adapter.git","ssh_url":"git@github.com:apigee/istio-mixer-adapter.git","clone_url":"https://github.com/apigee/istio-mixer-adapter.git","svn_url":"https://github.com/apigee/istio-mixer-adapter","homepage":null,"size":2892,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"apigee:master","ref":"master","sha":"89e63fb4746b497526a8dba255e9ff3da4ee0262","user":{"login":"apigee","id":19557821,"avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"repo":{"id":124308494,"name":"istio-mixer-adapter","full_name":"apigee/istio-mixer-adapter","owner":{"login":"apigee","id":19557821,"avatar_url":"https://avatars0.githubusercontent.com/u/19557821?v=4","gravatar_id":"","url":"https://api.github.com/users/apigee","html_url":"https://github.com/apigee","followers_url":"https://api.github.com/users/apigee/followers","following_url":"https://api.github.com/users/apigee/following{/other_user}","gists_url":"https://api.github.com/users/apigee/gists{/gist_id}","starred_url":"https://api.github.com/users/apigee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apigee/subscriptions","organizations_url":"https://api.github.com/users/apigee/orgs","repos_url":"https://api.github.com/users/apigee/repos","events_url":"https://api.github.com/users/apigee/events{/privacy}","received_events_url":"https://api.github.com/users/apigee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apigee/istio-mixer-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/apigee/istio-mixer-adapter","forks_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/forks","keys_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/teams","hooks_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/hooks","issue_events_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/events","assignees_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/tags","blobs_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/languages","stargazers_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/stargazers","contributors_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/contributors","subscribers_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/subscribers","subscription_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/subscription","commits_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/merges","archive_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/downloads","issues_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/labels{/name}","releases_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/apigee/istio-mixer-adapter/deployments","created_at":"2018-03-07T23:43:09Z","updated_at":"2018-03-14T22:46:55Z","pushed_at":"2018-03-15T00:56:29Z","git_url":"git://github.com/apigee/istio-mixer-adapter.git","ssh_url":"git@github.com:apigee/istio-mixer-adapter.git","clone_url":"https://github.com/apigee/istio-mixer-adapter.git","svn_url":"https://github.com/apigee/istio-mixer-adapter","homepage":null,"size":2892,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8"},"html":{"href":"https://github.com/apigee/istio-mixer-adapter/pull/8"},"issue":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/8"},"comments":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/apigee/istio-mixer-adapter/statuses/de30cc8d4985a5fd17078f3586039b8b4e1cc2bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robbrit"}}