{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/208616906","pull_request_review_id":144460327,"id":208616906,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYxNjkwNg==","diff_hunk":"@@ -0,0 +1,25 @@\n+---\n+- debug: msg=\"{{ openshift_aws_dns_records[l_openshift_aws_dns_element] }}\"\n+\n+- name: querying elb\n+  ec2_elb_facts:\n+    names: \"{{ openshift_aws_dns_records[l_openshift_aws_dns_element]['value'] }}\"\n+    region: \"{{ openshift_aws_region }}\"\n+  register: elb_facts\n+  when:\n+    - \"'elb' in openshift_aws_dns_records[l_openshift_aws_dns_element]['kind']\"\n+    - \"'CNAME' in openshift_aws_dns_records[l_openshift_aws_dns_element]['type']\"\n+\n+- name: creating record\n+  route53:\n+    command: create\n+    overwrite: no\n+    private_zone: \"{{ (openshift_aws_dns_records[l_openshift_aws_dns_element]['scheme'] == 'internal') | ternary('yes','no') }}\"\n+    record: \"{{ l_openshift_aws_dns_element }}.{{ openshift_aws_dns_zone }}\"\n+    type: \"{{ openshift_aws_dns_records[l_openshift_aws_dns_element]['type'] }}\"\n+    ttl: 300\n+    value: \"{{ value | trim }}\"\n+    zone: \"{{ openshift_aws_dns_zone }}\"\n+  vars:\n+    value: \"{% if 'CNAME' in openshift_aws_dns_records[l_openshift_aws_dns_element]['type'] -%} {{ elb_facts.elbs[0].dns_name }} \\","path":"roles/openshift_aws/tasks/dns_route53_record.yml","position":24,"original_position":24,"commit_id":"a7f25ca6df41a8d1103f0444785461383e4b975e","original_commit_id":"a7f25ca6df41a8d1103f0444785461383e4b975e","user":{"login":"michaelgugino","id":6255238,"node_id":"MDQ6VXNlcjYyNTUyMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/6255238?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelgugino","html_url":"https://github.com/michaelgugino","followers_url":"https://api.github.com/users/michaelgugino/followers","following_url":"https://api.github.com/users/michaelgugino/following{/other_user}","gists_url":"https://api.github.com/users/michaelgugino/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgugino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgugino/subscriptions","organizations_url":"https://api.github.com/users/michaelgugino/orgs","repos_url":"https://api.github.com/users/michaelgugino/repos","events_url":"https://api.github.com/users/michaelgugino/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgugino/received_events","type":"User","site_admin":false},"body":"Please clarify why we're overriding the value here, and if type is not == CNAME, what do we get?","created_at":"2018-08-08T15:02:05Z","updated_at":"2018-08-08T15:02:10Z","html_url":"https://github.com/openshift/openshift-ansible/pull/9389#discussion_r208616906","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/208616906"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9389#discussion_r208616906"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389","id":205489264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDg5MjY0","html_url":"https://github.com/openshift/openshift-ansible/pull/9389","diff_url":"https://github.com/openshift/openshift-ansible/pull/9389.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/9389.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9389","number":9389,"state":"open","locked":false,"title":"Add functionality for AWS DNS framework and route53 provider","user":{"login":"mazzystr","id":2479463,"node_id":"MDQ6VXNlcjI0Nzk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2479463?v=4","gravatar_id":"","url":"https://api.github.com/users/mazzystr","html_url":"https://github.com/mazzystr","followers_url":"https://api.github.com/users/mazzystr/followers","following_url":"https://api.github.com/users/mazzystr/following{/other_user}","gists_url":"https://api.github.com/users/mazzystr/gists{/gist_id}","starred_url":"https://api.github.com/users/mazzystr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazzystr/subscriptions","organizations_url":"https://api.github.com/users/mazzystr/orgs","repos_url":"https://api.github.com/users/mazzystr/repos","events_url":"https://api.github.com/users/mazzystr/events{/privacy}","received_events_url":"https://api.github.com/users/mazzystr/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/R6yaXLpF/666-aws-dns-hook\r\n\r\n### Scenario:\r\nAs an openshift Ops admin\r\nI want AWS provisioning to include a DNS hook and create the CNAME for the ELB so that I can browse to openshift_master_cluster_public_hostname or openshift_master_cluster_hostname when installer completes.\r\n\r\n### Acceptance Criteria\r\n- provision_install play should deploy all AWS infrastructure\r\n- provision_install play should install OpenShift\r\n\r\n### Notes:\r\n- https://bugzilla.redhat.com/show_bug.cgi?id=1569635\r\n- https://bugzilla.redhat.com/show_bug.cgi?id=1569631\r\n\r\nSorry about closing pull/9194.  After consulting with the team the fix for the scenario ended up being very easy.  \r\nSorry about closing pull/9264.  I created another rebase/commit to my forks master and wiped out the linked commit.  Amateur hour on my part.","created_at":"2018-08-01T16:54:54Z","updated_at":"2018-08-08T15:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77571503fc160042c46dc0b72de1dd20f2a8d561","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdodson","id":48161,"node_id":"MDQ6VXNlcjQ4MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},{"login":"mtnbikenc","id":7808636,"node_id":"MDQ6VXNlcjc4MDg2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7808636?v=4","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":681633081,"node_id":"MDU6TGFiZWw2ODE2MzMwODE=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9389/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/a7f25ca6df41a8d1103f0444785461383e4b975e","head":{"label":"mazzystr:dns","ref":"dns","sha":"a7f25ca6df41a8d1103f0444785461383e4b975e","user":{"login":"mazzystr","id":2479463,"node_id":"MDQ6VXNlcjI0Nzk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2479463?v=4","gravatar_id":"","url":"https://api.github.com/users/mazzystr","html_url":"https://github.com/mazzystr","followers_url":"https://api.github.com/users/mazzystr/followers","following_url":"https://api.github.com/users/mazzystr/following{/other_user}","gists_url":"https://api.github.com/users/mazzystr/gists{/gist_id}","starred_url":"https://api.github.com/users/mazzystr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazzystr/subscriptions","organizations_url":"https://api.github.com/users/mazzystr/orgs","repos_url":"https://api.github.com/users/mazzystr/repos","events_url":"https://api.github.com/users/mazzystr/events{/privacy}","received_events_url":"https://api.github.com/users/mazzystr/received_events","type":"User","site_admin":false},"repo":{"id":91731627,"node_id":"MDEwOlJlcG9zaXRvcnk5MTczMTYyNw==","name":"openshift-ansible","full_name":"mazzystr/openshift-ansible","owner":{"login":"mazzystr","id":2479463,"node_id":"MDQ6VXNlcjI0Nzk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2479463?v=4","gravatar_id":"","url":"https://api.github.com/users/mazzystr","html_url":"https://github.com/mazzystr","followers_url":"https://api.github.com/users/mazzystr/followers","following_url":"https://api.github.com/users/mazzystr/following{/other_user}","gists_url":"https://api.github.com/users/mazzystr/gists{/gist_id}","starred_url":"https://api.github.com/users/mazzystr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazzystr/subscriptions","organizations_url":"https://api.github.com/users/mazzystr/orgs","repos_url":"https://api.github.com/users/mazzystr/repos","events_url":"https://api.github.com/users/mazzystr/events{/privacy}","received_events_url":"https://api.github.com/users/mazzystr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mazzystr/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":true,"url":"https://api.github.com/repos/mazzystr/openshift-ansible","forks_url":"https://api.github.com/repos/mazzystr/openshift-ansible/forks","keys_url":"https://api.github.com/repos/mazzystr/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mazzystr/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mazzystr/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/mazzystr/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/mazzystr/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/mazzystr/openshift-ansible/events","assignees_url":"https://api.github.com/repos/mazzystr/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/mazzystr/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/mazzystr/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/mazzystr/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mazzystr/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mazzystr/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/mazzystr/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mazzystr/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/mazzystr/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/mazzystr/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/mazzystr/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/mazzystr/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/mazzystr/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/mazzystr/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/mazzystr/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/mazzystr/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/mazzystr/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/mazzystr/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/mazzystr/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mazzystr/openshift-ansible/merges","archive_url":"https://api.github.com/repos/mazzystr/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mazzystr/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/mazzystr/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/mazzystr/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/mazzystr/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/mazzystr/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mazzystr/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/mazzystr/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/mazzystr/openshift-ansible/deployments","created_at":"2017-05-18T19:45:26Z","updated_at":"2018-08-07T16:40:20Z","pushed_at":"2018-08-07T19:54:48Z","git_url":"git://github.com/mazzystr/openshift-ansible.git","ssh_url":"git@github.com:mazzystr/openshift-ansible.git","clone_url":"https://github.com/mazzystr/openshift-ansible.git","svn_url":"https://github.com/mazzystr/openshift-ansible","homepage":"https://install.openshift.com","size":27180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"2f5784a9a611ffe8b71b1187340391978efb70e9","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwOTE5OQ==","name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2018-08-08T12:26:04Z","pushed_at":"2018-08-08T14:50:19Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":31503,"stargazers_count":1076,"watchers_count":1076,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1518,"mirror_url":null,"archived":false,"open_issues_count":1009,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1518,"open_issues":1009,"watchers":1076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9389"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9389"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9389/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9389/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/a7f25ca6df41a8d1103f0444785461383e4b975e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelgugino"}}