{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/172488116","pull_request_review_id":101509650,"id":172488116,"diff_hunk":"@@ -98,3 +98,115 @@ inline void CoverRect(m2::RectD rect, size_t cellsCount, int maxDepth, vector<Ce\n     result.push_back(id);\n   }\n }\n+\n+template <typename BoundsT, typename CellIdT>\n+void CoverRanked(m2::RectD rect, int maxDepth, vector<CellIdT> & result)\n+{\n+  using Converter = CellIdConverter<BoundsT, CellIdT>;\n+\n+  enum class Direction : uint8_t\n+  {\n+    Right = 0,\n+    Down = 1,\n+    Left = 2,\n+    Up = 3\n+  };\n+\n+  CHECK(result.empty(), ());\n+  // Cut rect with world bound coordinates.\n+  if (!rect.Intersect({BoundsT::minX, BoundsT::minY, BoundsT::maxX, BoundsT::maxY}))\n+    return;\n+  CHECK(rect.IsValid(), ());\n+\n+  auto centralCell = Converter::ToCellId(rect.Center().x, rect.Center().y);\n+  while (centralCell.Level() > maxDepth && centralCell.Level() > 0)\n+    centralCell = centralCell.Parent();\n+\n+  if(centralCell.Level() > maxDepth)","path":"indexer/cell_coverer.hpp","position":null,"original_position":28,"commit_id":"2b418512fe4fffb35ca6a42fca661f95969f3386","original_commit_id":"50748e994d3b3c3491fe012487cc67664be8b63b","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-03-06T11:31:49Z","updated_at":"2018-03-06T11:31:49Z","html_url":"https://github.com/mapsme/omim/pull/8262#discussion_r172488116","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/8262","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/172488116"},"html":{"href":"https://github.com/mapsme/omim/pull/8262#discussion_r172488116"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8262"}},"in_reply_to_id":172481373},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/8262","id":173103738,"html_url":"https://github.com/mapsme/omim/pull/8262","diff_url":"https://github.com/mapsme/omim/pull/8262.diff","patch_url":"https://github.com/mapsme/omim/pull/8262.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/8262","number":8262,"state":"open","locked":false,"title":"[geocoder]Add geo ranking","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"Добавила в CellCoverer режим, в котором интервалы выдаются в порядке увеличения расстояния от центра и соответствующий режим в CoveringGetter и LocalityIndex.\r\n\r\nУ этого PR приоритет ниже чем у https://github.com/mapsme/omim/pull/8093 (лучше смотреть сначала https://github.com/mapsme/omim/pull/8093).\r\n","created_at":"2018-03-06T09:40:42Z","updated_at":"2018-03-06T11:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02a5d0f4069a4723b2486680d5db36b73f02b2e5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars0.githubusercontent.com/u/10366009?v=4","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/8262/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/8262/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/8262/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/2b418512fe4fffb35ca6a42fca661f95969f3386","head":{"label":"tatiana-kondakova:reverse_geocoder_ranking","ref":"reverse_geocoder_ranking","sha":"2b418512fe4fffb35ca6a42fca661f95969f3386","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"name":"omim","full_name":"tatiana-kondakova/omim","owner":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatiana-kondakova/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-kondakova/omim","forks_url":"https://api.github.com/repos/tatiana-kondakova/omim/forks","keys_url":"https://api.github.com/repos/tatiana-kondakova/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-kondakova/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-kondakova/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-kondakova/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-kondakova/omim/events","assignees_url":"https://api.github.com/repos/tatiana-kondakova/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-kondakova/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-kondakova/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-kondakova/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-kondakova/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-kondakova/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-kondakova/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-kondakova/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-kondakova/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-kondakova/omim/merges","archive_url":"https://api.github.com/repos/tatiana-kondakova/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-kondakova/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-kondakova/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-kondakova/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-kondakova/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-kondakova/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-kondakova/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-kondakova/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2017-07-24T10:45:30Z","pushed_at":"2018-03-06T11:31:30Z","git_url":"git://github.com/tatiana-kondakova/omim.git","ssh_url":"git@github.com:tatiana-kondakova/omim.git","clone_url":"https://github.com/tatiana-kondakova/omim.git","svn_url":"https://github.com/tatiana-kondakova/omim","homepage":"","size":3618645,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"a375fa9da79577837032687ce25fe00fd6d490c2","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-03-06T07:01:33Z","pushed_at":"2018-03-06T11:31:39Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3649190,"stargazers_count":2591,"watchers_count":2591,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":558,"mirror_url":null,"archived":false,"open_issues_count":655,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":558,"open_issues":655,"watchers":2591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8262"},"html":{"href":"https://github.com/mapsme/omim/pull/8262"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/8262"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/8262/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8262/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8262/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/2b418512fe4fffb35ca6a42fca661f95969f3386"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tatiana-kondakova"}}