{"action":"created","issue":{"url":"https://api.github.com/repos/gonetz/GLideN64/issues/1878","repository_url":"https://api.github.com/repos/gonetz/GLideN64","labels_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1878/labels{/name}","comments_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1878/comments","events_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1878/events","html_url":"https://github.com/gonetz/GLideN64/pull/1878","id":347725460,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjU0NTMz","number":1878,"title":"ObjCoordinates: Implement G_OBJRM_BILERP (2D texture fix)","user":{"login":"gizmo98","id":6412699,"node_id":"MDQ6VXNlcjY0MTI2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6412699?v=4","gravatar_id":"","url":"https://api.github.com/users/gizmo98","html_url":"https://github.com/gizmo98","followers_url":"https://api.github.com/users/gizmo98/followers","following_url":"https://api.github.com/users/gizmo98/following{/other_user}","gists_url":"https://api.github.com/users/gizmo98/gists{/gist_id}","starred_url":"https://api.github.com/users/gizmo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gizmo98/subscriptions","organizations_url":"https://api.github.com/users/gizmo98/orgs","repos_url":"https://api.github.com/users/gizmo98/repos","events_url":"https://api.github.com/users/gizmo98/events{/privacy}","received_events_url":"https://api.github.com/users/gizmo98/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":83,"created_at":"2018-08-05T19:46:24Z","updated_at":"2018-08-21T17:01:31Z","closed_at":"2018-08-12T09:42:10Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gonetz/GLideN64/pulls/1878","html_url":"https://github.com/gonetz/GLideN64/pull/1878","diff_url":"https://github.com/gonetz/GLideN64/pull/1878.diff","patch_url":"https://github.com/gonetz/GLideN64/pull/1878.patch"},"body":"- Worms Armageddon: Menu items, 2D elements and worms are no longer blurred and washed out\r\n- Kirby Crystal Shards: Menu items and titel screen are much sharper\r\n- Yoshi's Story: background image seem to look better\r\n- Rewrite lrx, ulx, lry, uly, lrs, uls, lrt, ult calculation. First step: calculate image coords. Second step: calculate screen coords with scale and image coords.\r\n- Only allow 2Bit fractional \"fixed point\" precision for image coords.\r\n- Implement SHRINKSIZE 1 and 2 according to programmers guide.\r\n- Implement G_OBJRM_BILERP according to programmers guide. Subtract 0.5 from image coords if G_OBJRM_BILERP is set. This is the main fix for bad looking textures.\r\n> Corrects for the 0.5 slippage of the texture that occurs when bilinear interpolation is performed.  \r\n> For example, by setting bilinear interpolation on and off, texture coordinates will vary by 0.5. S2DEX Microcode has been designed to correct these effects at the RSP to minimize the user's efforts to get around these problems.\r\nhttp://n64devkit.square7.ch/pro-man/pro13/13-07.htm#05-03\r\n- I have not seen any regression in other games\r\n\r\n@gonetz \r\nImplementing G_OBJRM_BILERP coord correction in drawScreenSpaceTriangle(), drawTexturedRect() and gSPDrawObjRect() could fix other bad looking 2D texture problems."},"comment":{"url":"https://api.github.com/repos/gonetz/GLideN64/issues/comments/414747516","html_url":"https://github.com/gonetz/GLideN64/pull/1878#issuecomment-414747516","issue_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1878","id":414747516,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc0NzUxNg==","user":{"login":"olivieryuyu","id":8987490,"node_id":"MDQ6VXNlcjg5ODc0OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8987490?v=4","gravatar_id":"","url":"https://api.github.com/users/olivieryuyu","html_url":"https://github.com/olivieryuyu","followers_url":"https://api.github.com/users/olivieryuyu/followers","following_url":"https://api.github.com/users/olivieryuyu/following{/other_user}","gists_url":"https://api.github.com/users/olivieryuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/olivieryuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivieryuyu/subscriptions","organizations_url":"https://api.github.com/users/olivieryuyu/orgs","repos_url":"https://api.github.com/users/olivieryuyu/repos","events_url":"https://api.github.com/users/olivieryuyu/events{/privacy}","received_events_url":"https://api.github.com/users/olivieryuyu/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T17:01:31Z","updated_at":"2018-08-21T17:01:31Z","author_association":"NONE","body":"@theboy181 \r\n\r\nG_BG_COPY is used for SD Hiryuu noKen Densetsu.\r\n\r\nit is fixed by gizmo98 implementation which is not yet merged with gonetz branch."}}
{"actor":{"display_login":"olivieryuyu"}}