{"action":"created","comment":{"url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments/223236664","pull_request_review_id":162314444,"id":223236664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIzNjY2NA==","diff_hunk":"@@ -2,6 +2,8 @@ import { isFunction, isNumber, isString, isUndefined } from 'lodash';\n import { Evented } from './evented.js';\n import { Step } from './step.js';\n import { bindMethods } from './bind.js';\n+import tippy from 'tippy.js';","path":"src/js/tour.js","position":4,"original_position":4,"commit_id":"465c39340bcc356b7dbd827dbd8f0468d89be907","original_commit_id":"465c39340bcc356b7dbd827dbd8f0468d89be907","user":{"login":"chuckcarpenter","id":706378,"node_id":"MDQ6VXNlcjcwNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/706378?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckcarpenter","html_url":"https://github.com/chuckcarpenter","followers_url":"https://api.github.com/users/chuckcarpenter/followers","following_url":"https://api.github.com/users/chuckcarpenter/following{/other_user}","gists_url":"https://api.github.com/users/chuckcarpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckcarpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckcarpenter/subscriptions","organizations_url":"https://api.github.com/users/chuckcarpenter/orgs","repos_url":"https://api.github.com/users/chuckcarpenter/repos","events_url":"https://api.github.com/users/chuckcarpenter/events{/privacy}","received_events_url":"https://api.github.com/users/chuckcarpenter/received_events","type":"User","site_admin":false},"body":"adding it here, means we don't need it in the HTML `<script>`","created_at":"2018-10-08T01:27:29Z","updated_at":"2018-10-08T01:27:30Z","html_url":"https://github.com/shipshapecode/shepherd/pull/261#discussion_r223236664","pull_request_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments/223236664"},"html":{"href":"https://github.com/shipshapecode/shepherd/pull/261#discussion_r223236664"},"pull_request":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261","id":220146291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTQ2Mjkx","html_url":"https://github.com/shipshapecode/shepherd/pull/261","diff_url":"https://github.com/shipshapecode/shepherd/pull/261.diff","patch_url":"https://github.com/shipshapecode/shepherd/pull/261.patch","issue_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/261","number":261,"state":"open","locked":false,"title":"Tippy.js Integration","user":{"login":"BrianSipple","id":5483853,"node_id":"MDQ6VXNlcjU0ODM4NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5483853?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"body":"Closes #255 \r\n\r\nReplaces our direct usage of Popper.js with [Tippy.js](https://atomiks.github.io/tippyjs/), which uses Popper under the hood and provides very robust animation support.\r\n\r\n## Main changes\r\n\r\n- Interface with Tippy instead of Popper\r\n- Remove the `Step._attach` method. Tippy handles this automatically via its `appendTo` option.\r\n    + This also removes the need for a `renderLocation` option.\r\n- Remove usage of `Step.attachTo.modifiers`.\r\n    + This should be left to `Step.popperOptions.modifiers`.\r\n- Update styles to target Tippy's elements instead of Popper's.\r\n- Update the demo app, documentation, and tests to show how to use Tippy. \r\n\r\n## Instructions for runninng\r\n- Checkout the branch\r\n- Run `yarn start`\r\n\r\n## TODO\r\n- Update/fix tests\r\n- Properly configure Tippy in the dist build","created_at":"2018-10-03T19:05:51Z","updated_at":"2018-10-08T01:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d7d44571fdf5db3e3d4cf3e5d0f51024c605920","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261/commits","review_comments_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261/comments","review_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/261/comments","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/465c39340bcc356b7dbd827dbd8f0468d89be907","head":{"label":"shipshapecode:use-tippy-for-popovers","ref":"use-tippy-for-popovers","sha":"465c39340bcc356b7dbd827dbd8f0468d89be907","user":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"repo":{"id":15246993,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0Njk5Mw==","name":"shepherd","full_name":"shipshapecode/shepherd","private":false,"owner":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/shipshapecode/shepherd","description":"Guide your users through a tour of your app","fork":false,"url":"https://api.github.com/repos/shipshapecode/shepherd","forks_url":"https://api.github.com/repos/shipshapecode/shepherd/forks","keys_url":"https://api.github.com/repos/shipshapecode/shepherd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shipshapecode/shepherd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shipshapecode/shepherd/teams","hooks_url":"https://api.github.com/repos/shipshapecode/shepherd/hooks","issue_events_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/events{/number}","events_url":"https://api.github.com/repos/shipshapecode/shepherd/events","assignees_url":"https://api.github.com/repos/shipshapecode/shepherd/assignees{/user}","branches_url":"https://api.github.com/repos/shipshapecode/shepherd/branches{/branch}","tags_url":"https://api.github.com/repos/shipshapecode/shepherd/tags","blobs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shipshapecode/shepherd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/refs{/sha}","trees_url":"https://api.github.com/repos/shipshapecode/shepherd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/{sha}","languages_url":"https://api.github.com/repos/shipshapecode/shepherd/languages","stargazers_url":"https://api.github.com/repos/shipshapecode/shepherd/stargazers","contributors_url":"https://api.github.com/repos/shipshapecode/shepherd/contributors","subscribers_url":"https://api.github.com/repos/shipshapecode/shepherd/subscribers","subscription_url":"https://api.github.com/repos/shipshapecode/shepherd/subscription","commits_url":"https://api.github.com/repos/shipshapecode/shepherd/commits{/sha}","git_commits_url":"https://api.github.com/repos/shipshapecode/shepherd/git/commits{/sha}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/comments{/number}","issue_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/comments{/number}","contents_url":"https://api.github.com/repos/shipshapecode/shepherd/contents/{+path}","compare_url":"https://api.github.com/repos/shipshapecode/shepherd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shipshapecode/shepherd/merges","archive_url":"https://api.github.com/repos/shipshapecode/shepherd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shipshapecode/shepherd/downloads","issues_url":"https://api.github.com/repos/shipshapecode/shepherd/issues{/number}","pulls_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls{/number}","milestones_url":"https://api.github.com/repos/shipshapecode/shepherd/milestones{/number}","notifications_url":"https://api.github.com/repos/shipshapecode/shepherd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shipshapecode/shepherd/labels{/name}","releases_url":"https://api.github.com/repos/shipshapecode/shepherd/releases{/id}","deployments_url":"https://api.github.com/repos/shipshapecode/shepherd/deployments","created_at":"2013-12-17T06:30:27Z","updated_at":"2018-10-07T22:23:56Z","pushed_at":"2018-10-08T01:19:19Z","git_url":"git://github.com/shipshapecode/shepherd.git","ssh_url":"git@github.com:shipshapecode/shepherd.git","clone_url":"https://github.com/shipshapecode/shepherd.git","svn_url":"https://github.com/shipshapecode/shepherd","homepage":"https://shipshapecode.github.io/shepherd/docs/welcome","size":3186,"stargazers_count":5888,"watchers_count":5888,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":376,"open_issues":13,"watchers":5888,"default_branch":"master"}},"base":{"label":"shipshapecode:master","ref":"master","sha":"e3e95ec893dfe0e4de505308e482a37c50efd057","user":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"repo":{"id":15246993,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0Njk5Mw==","name":"shepherd","full_name":"shipshapecode/shepherd","private":false,"owner":{"login":"shipshapecode","id":17297725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk3NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17297725?v=4","gravatar_id":"","url":"https://api.github.com/users/shipshapecode","html_url":"https://github.com/shipshapecode","followers_url":"https://api.github.com/users/shipshapecode/followers","following_url":"https://api.github.com/users/shipshapecode/following{/other_user}","gists_url":"https://api.github.com/users/shipshapecode/gists{/gist_id}","starred_url":"https://api.github.com/users/shipshapecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipshapecode/subscriptions","organizations_url":"https://api.github.com/users/shipshapecode/orgs","repos_url":"https://api.github.com/users/shipshapecode/repos","events_url":"https://api.github.com/users/shipshapecode/events{/privacy}","received_events_url":"https://api.github.com/users/shipshapecode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/shipshapecode/shepherd","description":"Guide your users through a tour of your app","fork":false,"url":"https://api.github.com/repos/shipshapecode/shepherd","forks_url":"https://api.github.com/repos/shipshapecode/shepherd/forks","keys_url":"https://api.github.com/repos/shipshapecode/shepherd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shipshapecode/shepherd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shipshapecode/shepherd/teams","hooks_url":"https://api.github.com/repos/shipshapecode/shepherd/hooks","issue_events_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/events{/number}","events_url":"https://api.github.com/repos/shipshapecode/shepherd/events","assignees_url":"https://api.github.com/repos/shipshapecode/shepherd/assignees{/user}","branches_url":"https://api.github.com/repos/shipshapecode/shepherd/branches{/branch}","tags_url":"https://api.github.com/repos/shipshapecode/shepherd/tags","blobs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shipshapecode/shepherd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shipshapecode/shepherd/git/refs{/sha}","trees_url":"https://api.github.com/repos/shipshapecode/shepherd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shipshapecode/shepherd/statuses/{sha}","languages_url":"https://api.github.com/repos/shipshapecode/shepherd/languages","stargazers_url":"https://api.github.com/repos/shipshapecode/shepherd/stargazers","contributors_url":"https://api.github.com/repos/shipshapecode/shepherd/contributors","subscribers_url":"https://api.github.com/repos/shipshapecode/shepherd/subscribers","subscription_url":"https://api.github.com/repos/shipshapecode/shepherd/subscription","commits_url":"https://api.github.com/repos/shipshapecode/shepherd/commits{/sha}","git_commits_url":"https://api.github.com/repos/shipshapecode/shepherd/git/commits{/sha}","comments_url":"https://api.github.com/repos/shipshapecode/shepherd/comments{/number}","issue_comment_url":"https://api.github.com/repos/shipshapecode/shepherd/issues/comments{/number}","contents_url":"https://api.github.com/repos/shipshapecode/shepherd/contents/{+path}","compare_url":"https://api.github.com/repos/shipshapecode/shepherd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shipshapecode/shepherd/merges","archive_url":"https://api.github.com/repos/shipshapecode/shepherd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shipshapecode/shepherd/downloads","issues_url":"https://api.github.com/repos/shipshapecode/shepherd/issues{/number}","pulls_url":"https://api.github.com/repos/shipshapecode/shepherd/pulls{/number}","milestones_url":"https://api.github.com/repos/shipshapecode/shepherd/milestones{/number}","notifications_url":"https://api.github.com/repos/shipshapecode/shepherd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shipshapecode/shepherd/labels{/name}","releases_url":"https://api.github.com/repos/shipshapecode/shepherd/releases{/id}","deployments_url":"https://api.github.com/repos/shipshapecode/shepherd/deployments","created_at":"2013-12-17T06:30:27Z","updated_at":"2018-10-07T22:23:56Z","pushed_at":"2018-10-08T01:19:19Z","git_url":"git://github.com/shipshapecode/shepherd.git","ssh_url":"git@github.com:shipshapecode/shepherd.git","clone_url":"https://github.com/shipshapecode/shepherd.git","svn_url":"https://github.com/shipshapecode/shepherd","homepage":"https://shipshapecode.github.io/shepherd/docs/welcome","size":3186,"stargazers_count":5888,"watchers_count":5888,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":376,"open_issues":13,"watchers":5888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261"},"html":{"href":"https://github.com/shipshapecode/shepherd/pull/261"},"issue":{"href":"https://api.github.com/repos/shipshapecode/shepherd/issues/261"},"comments":{"href":"https://api.github.com/repos/shipshapecode/shepherd/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shipshapecode/shepherd/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/shipshapecode/shepherd/statuses/465c39340bcc356b7dbd827dbd8f0468d89be907"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chuckcarpenter"}}