{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4704","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4704/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4704/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4704/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/4704","id":391299683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODU4OTMz","number":4704,"title":"Switches email-popup close widget from an anchor to a button.","user":{"login":"wpears","id":1558033,"node_id":"MDQ6VXNlcjE1NTgwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1558033?v=4","gravatar_id":"","url":"https://api.github.com/users/wpears","html_url":"https://github.com/wpears","followers_url":"https://api.github.com/users/wpears/followers","following_url":"https://api.github.com/users/wpears/following{/other_user}","gists_url":"https://api.github.com/users/wpears/gists{/gist_id}","starred_url":"https://api.github.com/users/wpears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpears/subscriptions","organizations_url":"https://api.github.com/users/wpears/orgs","repos_url":"https://api.github.com/users/wpears/repos","events_url":"https://api.github.com/users/wpears/events{/privacy}","received_events_url":"https://api.github.com/users/wpears/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T22:24:07Z","updated_at":"2018-12-17T15:16:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4704","html_url":"https://github.com/cfpb/cfgov-refresh/pull/4704","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/4704.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/4704.patch"},"body":"Closes GHE/CFGOV/platform/issues/3129\r\n\r\n## Changes\r\n - Switches close button to an actual button. This inserts it into the tab index and is more semantically correct.\r\n - Adjusts styling to match current anchor styling\r\n\r\n## Testing\r\n\r\n1. Pull branch and `yarn run gulp styles`\r\n2. Go to http://localhost:8000/owning-a-home\r\n - You may need to localStorage.clear() and refresh if the \"Buying A House?\" popup doesn't activate on scroll.\r\n3. Once the popup is activated, you should be able to tab to the close button and close the popup with enter.\r\n4. Styling of the close button should match the one at https://consumerfinance.gov/owning-a-home"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/447880705","html_url":"https://github.com/cfpb/cfgov-refresh/pull/4704#issuecomment-447880705","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4704","id":447880705,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg4MDcwNQ==","user":{"login":"anselmbradford","id":704760,"node_id":"MDQ6VXNlcjcwNDc2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/704760?v=4","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T15:16:21Z","updated_at":"2018-12-17T15:16:21Z","author_association":"MEMBER","body":"Could you utilize `a-btn a-btn__link` from CF to make a button that looks like a link and not need to add more styles here?"}}
{"actor":{"display_login":"anselmbradford"}}