{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/comments/223086554","pull_request_review_id":162136241,"id":223086554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzA4NjU1NA==","diff_hunk":"@@ -16,13 +18,32 @@ import mozilla.lockbox.store.DataStore\n interface ItemDetailView {\n     var itemId: String?\n     fun updateItem(item: ItemDetailViewModel)\n+\n+    val addressLayoutClicks: Observable<Unit>\n+    fun openWebsite(hostname: String)\n }\n \n class ItemDetailPresenter(\n     private val view: ItemDetailView,\n     private val dispatcher: Dispatcher = Dispatcher.shared,\n     private val dataStore: DataStore = DataStore.shared\n ) : Presenter() {\n+\n+    override fun onViewReady() {\n+        this.view.addressLayoutClicks\n+                .subscribe {\n+                    view.itemId?.let {\n+                        dataStore.get(it)\n+                                .subscribe {\n+                                    Log.d(\"hello\", \"${it!!.hostname}, ${it!!.formSubmitURL}\")","path":"app/src/main/java/mozilla/lockbox/presenter/ItemDetailPresenter.kt","position":30,"original_position":30,"commit_id":"d999798e2487bedb6d4b3f00eba25a39903fa9f0","original_commit_id":"d999798e2487bedb6d4b3f00eba25a39903fa9f0","user":{"login":"sashei","id":3207666,"node_id":"MDQ6VXNlcjMyMDc2NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3207666?v=4","gravatar_id":"","url":"https://api.github.com/users/sashei","html_url":"https://github.com/sashei","followers_url":"https://api.github.com/users/sashei/followers","following_url":"https://api.github.com/users/sashei/following{/other_user}","gists_url":"https://api.github.com/users/sashei/gists{/gist_id}","starred_url":"https://api.github.com/users/sashei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashei/subscriptions","organizations_url":"https://api.github.com/users/sashei/orgs","repos_url":"https://api.github.com/users/sashei/repos","events_url":"https://api.github.com/users/sashei/events{/privacy}","received_events_url":"https://api.github.com/users/sashei/received_events","type":"User","site_admin":false},"body":"Is this ready for review yet? This should be marked `WIP` until debugging statements are cleaned up.","created_at":"2018-10-05T17:39:12Z","updated_at":"2018-10-05T17:39:12Z","html_url":"https://github.com/mozilla-lockbox/lockbox-android/pull/129#discussion_r223086554","pull_request_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/comments/223086554"},"html":{"href":"https://github.com/mozilla-lockbox/lockbox-android/pull/129#discussion_r223086554"},"pull_request":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129","id":220705184,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzA1MTg0","html_url":"https://github.com/mozilla-lockbox/lockbox-android/pull/129","diff_url":"https://github.com/mozilla-lockbox/lockbox-android/pull/129.diff","patch_url":"https://github.com/mozilla-lockbox/lockbox-android/pull/129.patch","issue_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/129","number":129,"state":"open","locked":false,"title":"Web address launches site/app (entry detail view)","user":{"login":"mihainisipeanusv","id":43753283,"node_id":"MDQ6VXNlcjQzNzUzMjgz","avatar_url":"https://avatars3.githubusercontent.com/u/43753283?v=4","gravatar_id":"","url":"https://api.github.com/users/mihainisipeanusv","html_url":"https://github.com/mihainisipeanusv","followers_url":"https://api.github.com/users/mihainisipeanusv/followers","following_url":"https://api.github.com/users/mihainisipeanusv/following{/other_user}","gists_url":"https://api.github.com/users/mihainisipeanusv/gists{/gist_id}","starred_url":"https://api.github.com/users/mihainisipeanusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihainisipeanusv/subscriptions","organizations_url":"https://api.github.com/users/mihainisipeanusv/orgs","repos_url":"https://api.github.com/users/mihainisipeanusv/repos","events_url":"https://api.github.com/users/mihainisipeanusv/events{/privacy}","received_events_url":"https://api.github.com/users/mihainisipeanusv/received_events","type":"User","site_admin":false},"body":"Fixes #39 \r\n\r\nOpen hostname in user default browser \r\n\r\n","created_at":"2018-10-05T13:38:57Z","updated_at":"2018-10-05T17:39:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0da17fc90c01b5fc63ee711775673afcc940efff","assignee":{"login":"mihainisipeanusv","id":43753283,"node_id":"MDQ6VXNlcjQzNzUzMjgz","avatar_url":"https://avatars3.githubusercontent.com/u/43753283?v=4","gravatar_id":"","url":"https://api.github.com/users/mihainisipeanusv","html_url":"https://github.com/mihainisipeanusv","followers_url":"https://api.github.com/users/mihainisipeanusv/followers","following_url":"https://api.github.com/users/mihainisipeanusv/following{/other_user}","gists_url":"https://api.github.com/users/mihainisipeanusv/gists{/gist_id}","starred_url":"https://api.github.com/users/mihainisipeanusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihainisipeanusv/subscriptions","organizations_url":"https://api.github.com/users/mihainisipeanusv/orgs","repos_url":"https://api.github.com/users/mihainisipeanusv/repos","events_url":"https://api.github.com/users/mihainisipeanusv/events{/privacy}","received_events_url":"https://api.github.com/users/mihainisipeanusv/received_events","type":"User","site_admin":false},"assignees":[{"login":"mihainisipeanusv","id":43753283,"node_id":"MDQ6VXNlcjQzNzUzMjgz","avatar_url":"https://avatars3.githubusercontent.com/u/43753283?v=4","gravatar_id":"","url":"https://api.github.com/users/mihainisipeanusv","html_url":"https://github.com/mihainisipeanusv","followers_url":"https://api.github.com/users/mihainisipeanusv/followers","following_url":"https://api.github.com/users/mihainisipeanusv/following{/other_user}","gists_url":"https://api.github.com/users/mihainisipeanusv/gists{/gist_id}","starred_url":"https://api.github.com/users/mihainisipeanusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihainisipeanusv/subscriptions","organizations_url":"https://api.github.com/users/mihainisipeanusv/orgs","repos_url":"https://api.github.com/users/mihainisipeanusv/repos","events_url":"https://api.github.com/users/mihainisipeanusv/events{/privacy}","received_events_url":"https://api.github.com/users/mihainisipeanusv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":887673781,"node_id":"MDU6TGFiZWw4ODc2NzM3ODE=","url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/labels/in%20progress","name":"in progress","color":"E6E6E6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129/commits","review_comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129/comments","review_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/129/comments","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/statuses/d999798e2487bedb6d4b3f00eba25a39903fa9f0","head":{"label":"mozilla-lockbox:go-to-website","ref":"go-to-website","sha":"d999798e2487bedb6d4b3f00eba25a39903fa9f0","user":{"login":"mozilla-lockbox","id":29802027,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODAyMDI3","avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"repo":{"id":124426908,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjY5MDg=","name":"lockbox-android","full_name":"mozilla-lockbox/lockbox-android","private":false,"owner":{"login":"mozilla-lockbox","id":29802027,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODAyMDI3","avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-lockbox/lockbox-android","description":"Firefox Lockbox companion app for Android","fork":false,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android","forks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/forks","keys_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/teams","hooks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/hooks","issue_events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/events","assignees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/tags","blobs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/languages","stargazers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/stargazers","contributors_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/contributors","subscribers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/subscribers","subscription_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/subscription","commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/merges","archive_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/downloads","issues_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/deployments","created_at":"2018-03-08T17:41:51Z","updated_at":"2018-10-04T18:23:29Z","pushed_at":"2018-10-05T17:07:20Z","git_url":"git://github.com/mozilla-lockbox/lockbox-android.git","ssh_url":"git@github.com:mozilla-lockbox/lockbox-android.git","clone_url":"https://github.com/mozilla-lockbox/lockbox-android.git","svn_url":"https://github.com/mozilla-lockbox/lockbox-android","homepage":"https://mozilla-lockbox.github.io/lockbox-android/","size":972,"stargazers_count":27,"watchers_count":27,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":74,"watchers":27,"default_branch":"master"}},"base":{"label":"mozilla-lockbox:master","ref":"master","sha":"9fe880008daeb7996d4e85dd2128325149d4b8bd","user":{"login":"mozilla-lockbox","id":29802027,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODAyMDI3","avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"repo":{"id":124426908,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjY5MDg=","name":"lockbox-android","full_name":"mozilla-lockbox/lockbox-android","private":false,"owner":{"login":"mozilla-lockbox","id":29802027,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5ODAyMDI3","avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-lockbox/lockbox-android","description":"Firefox Lockbox companion app for Android","fork":false,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android","forks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/forks","keys_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/teams","hooks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/hooks","issue_events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/events","assignees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/tags","blobs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/languages","stargazers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/stargazers","contributors_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/contributors","subscribers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/subscribers","subscription_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/subscription","commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/merges","archive_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/downloads","issues_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/deployments","created_at":"2018-03-08T17:41:51Z","updated_at":"2018-10-04T18:23:29Z","pushed_at":"2018-10-05T17:07:20Z","git_url":"git://github.com/mozilla-lockbox/lockbox-android.git","ssh_url":"git@github.com:mozilla-lockbox/lockbox-android.git","clone_url":"https://github.com/mozilla-lockbox/lockbox-android.git","svn_url":"https://github.com/mozilla-lockbox/lockbox-android","homepage":"https://mozilla-lockbox.github.io/lockbox-android/","size":972,"stargazers_count":27,"watchers_count":27,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":74,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129"},"html":{"href":"https://github.com/mozilla-lockbox/lockbox-android/pull/129"},"issue":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/129"},"comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-android/statuses/d999798e2487bedb6d4b3f00eba25a39903fa9f0"}},"author_association":"NONE"}}
{"actor":{"display_login":"sashei"}}