{"action":"created","issue":{"url":"https://api.github.com/repos/jkozlowski/starfish/issues/8","repository_url":"https://api.github.com/repos/jkozlowski/starfish","labels_url":"https://api.github.com/repos/jkozlowski/starfish/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/jkozlowski/starfish/issues/8/comments","events_url":"https://api.github.com/repos/jkozlowski/starfish/issues/8/events","html_url":"https://github.com/jkozlowski/starfish/pull/8","id":383994377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzIyODY2","number":8,"title":"Upgrade rust and SPDK to newer versions","user":{"login":"jkryl","id":5690145,"node_id":"MDQ6VXNlcjU2OTAxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5690145?v=4","gravatar_id":"","url":"https://api.github.com/users/jkryl","html_url":"https://github.com/jkryl","followers_url":"https://api.github.com/users/jkryl/followers","following_url":"https://api.github.com/users/jkryl/following{/other_user}","gists_url":"https://api.github.com/users/jkryl/gists{/gist_id}","starred_url":"https://api.github.com/users/jkryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkryl/subscriptions","organizations_url":"https://api.github.com/users/jkryl/orgs","repos_url":"https://api.github.com/users/jkryl/repos","events_url":"https://api.github.com/users/jkryl/events{/privacy}","received_events_url":"https://api.github.com/users/jkryl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-11-24T14:34:14Z","updated_at":"2018-11-30T21:59:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jkozlowski/starfish/pulls/8","html_url":"https://github.com/jkozlowski/starfish/pull/8","diff_url":"https://github.com/jkozlowski/starfish/pull/8.diff","patch_url":"https://github.com/jkozlowski/starfish/pull/8.patch"},"body":"The primary motivation for doing that was to work around problems\r\nencountered with previous versions. However the fix is dirty.\r\nI haven't found a good solution for problem of missing\r\nrte_mempool_ring shared library so tests need to be run like this:\r\n\r\nLD_PRELOAD=/usr/local/lib/librte_mempool_ring.so.1.1 cargo test --all\r\n\r\nFor more detailed background information see discussion in issue #6 . \r\n\r\nNOTE: I don't have idea if circleci tests will pass. It's quite possible that I will\r\nhave to fix a few more things before we can merge these changes."},"comment":{"url":"https://api.github.com/repos/jkozlowski/starfish/issues/comments/443352534","html_url":"https://github.com/jkozlowski/starfish/pull/8#issuecomment-443352534","issue_url":"https://api.github.com/repos/jkozlowski/starfish/issues/8","id":443352534,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzM1MjUzNA==","user":{"login":"jkryl","id":5690145,"node_id":"MDQ6VXNlcjU2OTAxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5690145?v=4","gravatar_id":"","url":"https://api.github.com/users/jkryl","html_url":"https://github.com/jkryl","followers_url":"https://api.github.com/users/jkryl/followers","following_url":"https://api.github.com/users/jkryl/following{/other_user}","gists_url":"https://api.github.com/users/jkryl/gists{/gist_id}","starred_url":"https://api.github.com/users/jkryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkryl/subscriptions","organizations_url":"https://api.github.com/users/jkryl/orgs","repos_url":"https://api.github.com/users/jkryl/repos","events_url":"https://api.github.com/users/jkryl/events{/privacy}","received_events_url":"https://api.github.com/users/jkryl/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T21:59:29Z","updated_at":"2018-11-30T21:59:29Z","author_association":"NONE","body":"Hi @jkozlowski , just a couple of thoughts:\r\n\r\n1) I don't think we can convince them to go back to a single libspdk.so library. This is against their philosophy of modularizing dpdk dependency. We could probably convince them to provide additional monolithic libspdk.so (with a different name) in addition to current set of dynamic libs. However that means we are stuck with shared libraries (instead of static) which is not optimal.\r\n2) We could also try to convince them to export some of the symbols globally and continue using the hack with pulling static libraries in using those symbols. For spdk that would be a minor change. We would still need the hack, but no patching of spdk source code.\r\n3) As for what's possible to accomplish with rustc linker I'm completely clueless as I don't understand it much. Though if we can \"fix\" the linker somehow, that would be obviously the best solution. I tried to change linker defaults using .cargo/config and it did not work for me. As I understand it the whole-archive linker option is really the only problem.\r\n4) I'm not aware of the effort to provide pkg-config tool for rust, but IMHO it is not going to help us, unless it could somehow influence whole-archive flag which I doubt about."}}
{"actor":{"display_login":"jkryl"}}