{"action":"closed","number":4723,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/4723","id":167305974,"html_url":"https://github.com/serverless/serverless/pull/4723","diff_url":"https://github.com/serverless/serverless/pull/4723.diff","patch_url":"https://github.com/serverless/serverless/pull/4723.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/4723","number":4723,"state":"closed","locked":false,"title":"Spotinst: Added support for CORS for Functions","user":{"login":"alexindeed","id":35503263,"avatar_url":"https://avatars1.githubusercontent.com/u/35503263?v=4","gravatar_id":"","url":"https://api.github.com/users/alexindeed","html_url":"https://github.com/alexindeed","followers_url":"https://api.github.com/users/alexindeed/followers","following_url":"https://api.github.com/users/alexindeed/following{/other_user}","gists_url":"https://api.github.com/users/alexindeed/gists{/gist_id}","starred_url":"https://api.github.com/users/alexindeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexindeed/subscriptions","organizations_url":"https://api.github.com/users/alexindeed/orgs","repos_url":"https://api.github.com/users/alexindeed/repos","events_url":"https://api.github.com/users/alexindeed/events{/privacy}","received_events_url":"https://api.github.com/users/alexindeed/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\nAdded support for CORS in functions + documentation.\r\nUpdated Spotinst templates.\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\nUpdated serverless.yml file for python, ruby, node, and java.\r\nAdded docs.\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\nSee: /serverless/docs/providers/spotinst/guide/cors.md\r\n        /serverless/lib/plugins/create/templates\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* Cloud Configuration - List cloud resources and show that the correct configuration is in place (e.g. AWS CLI commands)\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [ ] Write documentation\r\n- [ ] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config / commands / resources\r\n- [ ] Enable \"Allow edits from maintainers\" for this PR\r\n- [ ] Update the messages below\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO","created_at":"2018-02-06T02:31:30Z","updated_at":"2018-02-07T01:17:46Z","closed_at":"2018-02-07T01:17:46Z","merged_at":null,"merge_commit_sha":"2ed7c4ce0d716823c9793e7d61d2c7b32943ec87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/4723/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/4723/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/4723/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/cfe4f4b12b92823c93efac0cc9282687a1ddd547","head":{"label":"alexindeed:master","ref":"master","sha":"cfe4f4b12b92823c93efac0cc9282687a1ddd547","user":{"login":"alexindeed","id":35503263,"avatar_url":"https://avatars1.githubusercontent.com/u/35503263?v=4","gravatar_id":"","url":"https://api.github.com/users/alexindeed","html_url":"https://github.com/alexindeed","followers_url":"https://api.github.com/users/alexindeed/followers","following_url":"https://api.github.com/users/alexindeed/following{/other_user}","gists_url":"https://api.github.com/users/alexindeed/gists{/gist_id}","starred_url":"https://api.github.com/users/alexindeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexindeed/subscriptions","organizations_url":"https://api.github.com/users/alexindeed/orgs","repos_url":"https://api.github.com/users/alexindeed/repos","events_url":"https://api.github.com/users/alexindeed/events{/privacy}","received_events_url":"https://api.github.com/users/alexindeed/received_events","type":"User","site_admin":false},"repo":{"id":117727643,"name":"serverless","full_name":"alexindeed/serverless","owner":{"login":"alexindeed","id":35503263,"avatar_url":"https://avatars1.githubusercontent.com/u/35503263?v=4","gravatar_id":"","url":"https://api.github.com/users/alexindeed","html_url":"https://github.com/alexindeed","followers_url":"https://api.github.com/users/alexindeed/followers","following_url":"https://api.github.com/users/alexindeed/following{/other_user}","gists_url":"https://api.github.com/users/alexindeed/gists{/gist_id}","starred_url":"https://api.github.com/users/alexindeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexindeed/subscriptions","organizations_url":"https://api.github.com/users/alexindeed/orgs","repos_url":"https://api.github.com/users/alexindeed/repos","events_url":"https://api.github.com/users/alexindeed/events{/privacy}","received_events_url":"https://api.github.com/users/alexindeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexindeed/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/alexindeed/serverless","forks_url":"https://api.github.com/repos/alexindeed/serverless/forks","keys_url":"https://api.github.com/repos/alexindeed/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexindeed/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexindeed/serverless/teams","hooks_url":"https://api.github.com/repos/alexindeed/serverless/hooks","issue_events_url":"https://api.github.com/repos/alexindeed/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/alexindeed/serverless/events","assignees_url":"https://api.github.com/repos/alexindeed/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/alexindeed/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/alexindeed/serverless/tags","blobs_url":"https://api.github.com/repos/alexindeed/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexindeed/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexindeed/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexindeed/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexindeed/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/alexindeed/serverless/languages","stargazers_url":"https://api.github.com/repos/alexindeed/serverless/stargazers","contributors_url":"https://api.github.com/repos/alexindeed/serverless/contributors","subscribers_url":"https://api.github.com/repos/alexindeed/serverless/subscribers","subscription_url":"https://api.github.com/repos/alexindeed/serverless/subscription","commits_url":"https://api.github.com/repos/alexindeed/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexindeed/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexindeed/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexindeed/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexindeed/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/alexindeed/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexindeed/serverless/merges","archive_url":"https://api.github.com/repos/alexindeed/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexindeed/serverless/downloads","issues_url":"https://api.github.com/repos/alexindeed/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/alexindeed/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/alexindeed/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/alexindeed/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexindeed/serverless/labels{/name}","releases_url":"https://api.github.com/repos/alexindeed/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/alexindeed/serverless/deployments","created_at":"2018-01-16T19:00:30Z","updated_at":"2018-01-16T19:00:34Z","pushed_at":"2018-02-07T01:13:33Z","git_url":"git://github.com/alexindeed/serverless.git","ssh_url":"git@github.com:alexindeed/serverless.git","clone_url":"https://github.com/alexindeed/serverless.git","svn_url":"https://github.com/alexindeed/serverless","homepage":"http://www.serverless.com","size":77546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"fe89d4071d36e973285cc1f8b4c8322dd85e8b8d","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2018-02-06T23:24:22Z","pushed_at":"2018-02-07T01:13:35Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":77539,"stargazers_count":21653,"watchers_count":21653,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2283,"mirror_url":null,"archived":false,"open_issues_count":430,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2283,"open_issues":430,"watchers":21653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4723"},"html":{"href":"https://github.com/serverless/serverless/pull/4723"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/4723"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/4723/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4723/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4723/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/cfe4f4b12b92823c93efac0cc9282687a1ddd547"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":65,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"alexindeed"}}