{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3225","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3225/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3225/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3225/events","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3225","id":369060298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDg5NTc2","number":3225,"title":"Deploy: Add missing `allowPrivilegeEscalation: true`","user":{"login":"meeee","id":188986,"node_id":"MDQ6VXNlcjE4ODk4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/188986?v=4","gravatar_id":"","url":"https://api.github.com/users/meeee","html_url":"https://github.com/meeee","followers_url":"https://api.github.com/users/meeee/followers","following_url":"https://api.github.com/users/meeee/following{/other_user}","gists_url":"https://api.github.com/users/meeee/gists{/gist_id}","starred_url":"https://api.github.com/users/meeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeee/subscriptions","organizations_url":"https://api.github.com/users/meeee/orgs","repos_url":"https://api.github.com/users/meeee/repos","events_url":"https://api.github.com/users/meeee/events{/privacy}","received_events_url":"https://api.github.com/users/meeee/received_events","type":"User","site_admin":false},"labels":[{"id":486873161,"node_id":"MDU6TGFiZWw0ODY4NzMxNjE=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":677769656,"node_id":"MDU6TGFiZWw2Nzc3Njk2NTY=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-11T10:42:43Z","updated_at":"2018-10-25T13:56:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3225","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3225","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/3225.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/3225.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nauthbind uses a setuid binary to bind a privileged port, so we need\r\nto allow privilege escalation.\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI'm wondering why no one noticed this before - I guess there are few\r\nclusters configured with a pod security policy disabling privilege\r\nescalation by default.\r\n\r\nI'm also wondering whether `setcap` in the Dockerfile is still necessary\r\ngiven that ingress-nginx now uses authbind, which acquires the\r\ncapability by running with uid 0 instead of having the capability\r\nassigned explicitly (as far as I understand).\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/433061121","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3225#issuecomment-433061121","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3225","id":433061121,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzA2MTEyMQ==","user":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T13:56:29Z","updated_at":"2018-10-25T13:56:29Z","author_association":"MEMBER","body":"@meeee the tests already use RBAC https://github.com/kubernetes/ingress-nginx/blob/master/test/manifests/ingress-controller/mandatory.yaml"}}
{"actor":{"display_login":"aledbf"}}