{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/639","repository_url":"https://api.github.com/repos/Microsoft/botbuilder-js","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/639/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/639/comments","events_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/639/events","html_url":"https://github.com/Microsoft/botbuilder-js/issues/639","id":381286275,"node_id":"MDU6SXNzdWUzODEyODYyNzU=","number":639,"title":"CardAction requires channelData property","user":{"login":"ryanvolum","id":3891951,"node_id":"MDQ6VXNlcjM4OTE5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3891951?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanvolum","html_url":"https://github.com/ryanvolum","followers_url":"https://api.github.com/users/ryanvolum/followers","following_url":"https://api.github.com/users/ryanvolum/following{/other_user}","gists_url":"https://api.github.com/users/ryanvolum/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanvolum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanvolum/subscriptions","organizations_url":"https://api.github.com/users/ryanvolum/orgs","repos_url":"https://api.github.com/users/ryanvolum/repos","events_url":"https://api.github.com/users/ryanvolum/events{/privacy}","received_events_url":"https://api.github.com/users/ryanvolum/received_events","type":"User","site_admin":false},"labels":[{"id":1078665280,"node_id":"MDU6TGFiZWwxMDc4NjY1Mjgw","url":"https://api.github.com/repos/Microsoft/botbuilder-js/labels/4.2","name":"4.2","color":"2b7028","default":false},{"id":904160447,"node_id":"MDU6TGFiZWw5MDQxNjA0NDc=","url":"https://api.github.com/repos/Microsoft/botbuilder-js/labels/P2","name":"P2","color":"fef2c0","default":false},{"id":1078361845,"node_id":"MDU6TGFiZWwxMDc4MzYxODQ1","url":"https://api.github.com/repos/Microsoft/botbuilder-js/labels/Triaged","name":"Triaged","color":"4f69d1","default":false}],"state":"open","locked":false,"assignee":{"login":"stevengum","id":14935595,"node_id":"MDQ6VXNlcjE0OTM1NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/14935595?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengum","html_url":"https://github.com/stevengum","followers_url":"https://api.github.com/users/stevengum/followers","following_url":"https://api.github.com/users/stevengum/following{/other_user}","gists_url":"https://api.github.com/users/stevengum/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengum/subscriptions","organizations_url":"https://api.github.com/users/stevengum/orgs","repos_url":"https://api.github.com/users/stevengum/repos","events_url":"https://api.github.com/users/stevengum/events{/privacy}","received_events_url":"https://api.github.com/users/stevengum/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevengum","id":14935595,"node_id":"MDQ6VXNlcjE0OTM1NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/14935595?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengum","html_url":"https://github.com/stevengum","followers_url":"https://api.github.com/users/stevengum/followers","following_url":"https://api.github.com/users/stevengum/following{/other_user}","gists_url":"https://api.github.com/users/stevengum/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengum/subscriptions","organizations_url":"https://api.github.com/users/stevengum/orgs","repos_url":"https://api.github.com/users/stevengum/repos","events_url":"https://api.github.com/users/stevengum/events{/privacy}","received_events_url":"https://api.github.com/users/stevengum/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-11-15T18:29:32Z","updated_at":"2018-11-28T18:32:43Z","closed_at":null,"author_association":"MEMBER","body":"## Versions\r\nWhat package version of the SDK are you using.\r\n4.1.5\r\n\r\nWhat nodejs version are you using\r\nv10.13.0\r\n\r\nWhat os are you using\r\nWindows\r\n\r\n## Describe the bug\r\nCardAction interface requires unexplained ```channelData``` property. [06.using-cards sample](https://github.com/Microsoft/BotBuilder-Samples/blob/master/samples/javascript_nodejs/06.using-cards/bot.js) creates CardActions without channelData, implying that it should not be required: \r\n```\r\n            CardFactory.actions([\r\n                {\r\n                    type: 'openUrl',\r\n                    title: 'Get started',\r\n                    value: 'https://docs.microsoft.com/en-us/azure/bot-service/'\r\n                }\r\n```\r\n\r\n## To Reproduce\r\nFollow [06.using-cards sample](https://github.com/Microsoft/BotBuilder-Samples/blob/master/samples/javascript_nodejs/06.using-cards/bot.js) sample to create a HeroCard with a card action. Don't pass in ```channelData```.\r\n\r\n## Expected behavior\r\nCard should not require unnecessary properties. If there is a reason for this property, samples/docs should use it and explain it. \r\n\r\n## Screenshots\r\n![image](https://user-images.githubusercontent.com/3891951/48573485-30ceee00-e8c1-11e8-84cc-e00f664be416.png)\r\n\r\n## Additional context\r\nI'm developing in TypeScript, so I have to adhere to more rules. This is a bug nonetheless. \r\n\r\n[bug]\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/comments/442555450","html_url":"https://github.com/Microsoft/botbuilder-js/issues/639#issuecomment-442555450","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/639","id":442555450,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjU1NTQ1MA==","user":{"login":"sgellock","id":733559,"node_id":"MDQ6VXNlcjczMzU1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/733559?v=4","gravatar_id":"","url":"https://api.github.com/users/sgellock","html_url":"https://github.com/sgellock","followers_url":"https://api.github.com/users/sgellock/followers","following_url":"https://api.github.com/users/sgellock/following{/other_user}","gists_url":"https://api.github.com/users/sgellock/gists{/gist_id}","starred_url":"https://api.github.com/users/sgellock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgellock/subscriptions","organizations_url":"https://api.github.com/users/sgellock/orgs","repos_url":"https://api.github.com/users/sgellock/repos","events_url":"https://api.github.com/users/sgellock/events{/privacy}","received_events_url":"https://api.github.com/users/sgellock/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T18:32:43Z","updated_at":"2018-11-28T18:32:43Z","author_association":"MEMBER","body":"Let’s decide if we are picking up the lastest ms-rest-js or staying pinned to the current version we are using\r\n\r\nFrom: Steven Gum <notifications@github.com>\r\nReply-To: Microsoft/botbuilder-js <reply@reply.github.com>\r\nDate: Wednesday, November 28, 2018 at 10:22 AM\r\nTo: Microsoft/botbuilder-js <botbuilder-js@noreply.github.com>\r\nCc: Scott Gellock <Scott.Gellock@microsoft.com>, Mention <mention@noreply.github.com>\r\nSubject: Re: [Microsoft/botbuilder-js] CardAction requires channelData property (#639)\r\n\r\n\r\nFor public record, we'll be regenerating the the connector and schema libraries for 4.2, no manual changes!\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-js%2Fissues%2F639%23issuecomment-442552023&data=02%7C01%7Cscott.gellock%40microsoft.com%7Cd2a71e8b184a4a316af108d6555e693f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636790261317829618&sdata=WmIZaQRrQ%2B21FJxl0irzUV67nNgLUBnF7ewu290dox4%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAsxd1ZTq3ijznqIqNckqWRVQmokGw2nks5uztRQgaJpZM4Yhc-s&data=02%7C01%7Cscott.gellock%40microsoft.com%7Cd2a71e8b184a4a316af108d6555e693f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636790261317839627&sdata=gb4w3V9QhBImmR1lfUoZyL%2FOmNF5fwdyY87Ii1Lbc74%3D&reserved=0>.\r\n"}}
{"actor":{"display_login":"sgellock"}}