{"action":"opened","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24525","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24525/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24525/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24525/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/issues/24525","id":308416191,"number":24525,"title":"Express helmet definitions seem to be off","user":{"login":"ORESoftware","id":11139560,"avatar_url":"https://avatars1.githubusercontent.com/u/11139560?v=4","gravatar_id":"","url":"https://api.github.com/users/ORESoftware","html_url":"https://github.com/ORESoftware","followers_url":"https://api.github.com/users/ORESoftware/followers","following_url":"https://api.github.com/users/ORESoftware/following{/other_user}","gists_url":"https://api.github.com/users/ORESoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/ORESoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORESoftware/subscriptions","organizations_url":"https://api.github.com/users/ORESoftware/orgs","repos_url":"https://api.github.com/users/ORESoftware/repos","events_url":"https://api.github.com/users/ORESoftware/events{/privacy}","received_events_url":"https://api.github.com/users/ORESoftware/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-26T02:43:36Z","updated_at":"2018-03-26T02:43:36Z","closed_at":null,"author_association":"NONE","body":"\r\n- [x] I tried using the `@types/helmet` package and had problems.\r\n\r\nI am using @types/helmet version: `\"@types/helmet\": \"0.0.37\"`\r\nI am using helmet version: `\"helmet\": \"~0.9.1\"`\r\n\r\nI see this in my Express server codebase:\r\n\r\n```js\r\n\r\nimport helmet = require('helmet');\r\n\r\n // ....\r\nlet SIX_MONTHS = 15778476000;\r\napp.use(helmet.xframe());\r\napp.use(helmet.xssFilter());\r\napp.use(helmet.nosniff());\r\napp.use(helmet.ienoopen());\r\n\r\napp.use(helmet.hsts({\r\n  maxAge: SIX_MONTHS,\r\n  includeSubdomains: true,\r\n  force: true\r\n}));\r\n\r\n```\r\n\r\nbut that leads to these errors/warnings:\r\n\r\n![screenshot 2018-03-25 19 42 38](https://user-images.githubusercontent.com/11139560/37884412-b08e4cb4-3064-11e8-8f76-eadeea04bc13.png)\r\n\r\n\r\nIt looks like `nosniff()` has become `noSniff()` and `ienoopen()` has become `ieNoOpen()`, but what about `xframe()`?\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"ORESoftware"}}