{"action":"created","comment":{"url":"https://api.github.com/repos/chef/knife-ec2/pulls/comments/197018573","pull_request_review_id":130675455,"id":197018573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzAxODU3Mw==","diff_hunk":"@@ -111,10 +111,7 @@ class Ec2ServerCreate < Knife\n         :short => \"-T T=V[,T=V,...]\",\n         :long => \"--tags Tag=Value[,Tag=Value...]\",\n         :description => \"The tags for this server. [DEPRECATED] Use --aws-tag instead.\",\n-        :proc => Proc.new { |v|\n-          Chef::Log.warn(\"[DEPRECATED] --tags option is deprecated. Use --aws-tag option instead.\")\n-          v\n-        }\n+        :proc => Proc.new { |tags| tags.split(',') }","path":"lib/chef/knife/ec2_server_create.rb","position":8,"original_position":8,"commit_id":"1ed5df165d4a1fe68307750d1d559109c45cac5e","original_commit_id":"1ed5df165d4a1fe68307750d1d559109c45cac5e","user":{"login":"Vasu1105","id":4181545,"node_id":"MDQ6VXNlcjQxODE1NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4181545?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasu1105","html_url":"https://github.com/Vasu1105","followers_url":"https://api.github.com/users/Vasu1105/followers","following_url":"https://api.github.com/users/Vasu1105/following{/other_user}","gists_url":"https://api.github.com/users/Vasu1105/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasu1105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasu1105/subscriptions","organizations_url":"https://api.github.com/users/Vasu1105/orgs","repos_url":"https://api.github.com/users/Vasu1105/repos","events_url":"https://api.github.com/users/Vasu1105/events{/privacy}","received_events_url":"https://api.github.com/users/Vasu1105/received_events","type":"User","site_admin":false},"body":"why we have to remove the deprecation warning from here? can't we do tags.split(',') along with deprecation warning here?","created_at":"2018-06-21T05:56:59Z","updated_at":"2018-06-21T05:57:48Z","html_url":"https://github.com/chef/knife-ec2/pull/527#discussion_r197018573","pull_request_url":"https://api.github.com/repos/chef/knife-ec2/pulls/527","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/comments/197018573"},"html":{"href":"https://github.com/chef/knife-ec2/pull/527#discussion_r197018573"},"pull_request":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/chef/knife-ec2/pulls/527","id":190609010,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNjA5MDEw","html_url":"https://github.com/chef/knife-ec2/pull/527","diff_url":"https://github.com/chef/knife-ec2/pull/527.diff","patch_url":"https://github.com/chef/knife-ec2/pull/527.patch","issue_url":"https://api.github.com/repos/chef/knife-ec2/issues/527","number":527,"state":"open","locked":false,"title":"[MSYS-824] fix breaking tag changes & deprecation warning","user":{"login":"dheerajd-msys","id":17288094,"node_id":"MDQ6VXNlcjE3Mjg4MDk0","avatar_url":"https://avatars0.githubusercontent.com/u/17288094?v=4","gravatar_id":"","url":"https://api.github.com/users/dheerajd-msys","html_url":"https://github.com/dheerajd-msys","followers_url":"https://api.github.com/users/dheerajd-msys/followers","following_url":"https://api.github.com/users/dheerajd-msys/following{/other_user}","gists_url":"https://api.github.com/users/dheerajd-msys/gists{/gist_id}","starred_url":"https://api.github.com/users/dheerajd-msys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dheerajd-msys/subscriptions","organizations_url":"https://api.github.com/users/dheerajd-msys/orgs","repos_url":"https://api.github.com/users/dheerajd-msys/repos","events_url":"https://api.github.com/users/dheerajd-msys/events{/privacy}","received_events_url":"https://api.github.com/users/dheerajd-msys/received_events","type":"User","site_admin":false},"body":"### Description\r\n`--tags` flag was being used with `--tag-node-in-chef` in 0.17.0 and earlier. Deprecation warnings were added in 0.18.0. However deprecation warnings are warnings that suggest while the flags are on the way out, but with an expectation that they still function:\r\n```\r\nWARN: [DEPRECATED] --tags option is deprecated. Use --aws-tag option instead.\r\nWARN: [DEPRECATED] --tag-node-in-chef option is deprecated. Use --chef-tag option instead.\r\n```\r\n\r\n### Resolved Issue\r\nhttps://github.com/chef/knife-ec2/issues/526 ","created_at":"2018-05-25T14:38:41Z","updated_at":"2018-06-21T05:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29fe4a3935ef1db89e87201035757a0460e9d874","assignee":null,"assignees":[],"requested_reviewers":[{"login":"btm","id":4381,"node_id":"MDQ6VXNlcjQzODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4381?v=4","gravatar_id":"","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/knife-ec2/pulls/527/commits","review_comments_url":"https://api.github.com/repos/chef/knife-ec2/pulls/527/comments","review_comment_url":"https://api.github.com/repos/chef/knife-ec2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/knife-ec2/issues/527/comments","statuses_url":"https://api.github.com/repos/chef/knife-ec2/statuses/1ed5df165d4a1fe68307750d1d559109c45cac5e","head":{"label":"MsysTechnologiesllc:dh/fix_tags_deprecation_options","ref":"dh/fix_tags_deprecation_options","sha":"1ed5df165d4a1fe68307750d1d559109c45cac5e","user":{"login":"MsysTechnologiesllc","id":2493241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTMyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"repo":{"id":6089171,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg5MTcx","name":"knife-ec2","full_name":"MsysTechnologiesllc/knife-ec2","owner":{"login":"MsysTechnologiesllc","id":2493241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTMyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MsysTechnologiesllc/knife-ec2","description":"Opscode Chef knife plug-in for EC2","fork":true,"url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2","forks_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/forks","keys_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/teams","hooks_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/hooks","issue_events_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues/events{/number}","events_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/events","assignees_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/assignees{/user}","branches_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/branches{/branch}","tags_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/tags","blobs_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/statuses/{sha}","languages_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/languages","stargazers_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/stargazers","contributors_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/contributors","subscribers_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/subscribers","subscription_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/subscription","commits_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues/comments{/number}","contents_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/contents/{+path}","compare_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/merges","archive_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/downloads","issues_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues{/number}","pulls_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/pulls{/number}","milestones_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/milestones{/number}","notifications_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/labels{/name}","releases_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/releases{/id}","deployments_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/deployments","created_at":"2012-10-05T11:05:57Z","updated_at":"2018-06-21T05:54:19Z","pushed_at":"2018-06-21T05:54:17Z","git_url":"git://github.com/MsysTechnologiesllc/knife-ec2.git","ssh_url":"git@github.com:MsysTechnologiesllc/knife-ec2.git","clone_url":"https://github.com/MsysTechnologiesllc/knife-ec2.git","svn_url":"https://github.com/MsysTechnologiesllc/knife-ec2","homepage":"","size":1244,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"cc3106928481a615a18b60abf837d6c5a9bfe5ed","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":1452458,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUyNDU4","name":"knife-ec2","full_name":"chef/knife-ec2","owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/knife-ec2","description":"Chef knife plug-in for AWS EC2","fork":false,"url":"https://api.github.com/repos/chef/knife-ec2","forks_url":"https://api.github.com/repos/chef/knife-ec2/forks","keys_url":"https://api.github.com/repos/chef/knife-ec2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/knife-ec2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/knife-ec2/teams","hooks_url":"https://api.github.com/repos/chef/knife-ec2/hooks","issue_events_url":"https://api.github.com/repos/chef/knife-ec2/issues/events{/number}","events_url":"https://api.github.com/repos/chef/knife-ec2/events","assignees_url":"https://api.github.com/repos/chef/knife-ec2/assignees{/user}","branches_url":"https://api.github.com/repos/chef/knife-ec2/branches{/branch}","tags_url":"https://api.github.com/repos/chef/knife-ec2/tags","blobs_url":"https://api.github.com/repos/chef/knife-ec2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/knife-ec2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/knife-ec2/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/knife-ec2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/knife-ec2/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/knife-ec2/languages","stargazers_url":"https://api.github.com/repos/chef/knife-ec2/stargazers","contributors_url":"https://api.github.com/repos/chef/knife-ec2/contributors","subscribers_url":"https://api.github.com/repos/chef/knife-ec2/subscribers","subscription_url":"https://api.github.com/repos/chef/knife-ec2/subscription","commits_url":"https://api.github.com/repos/chef/knife-ec2/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/knife-ec2/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/knife-ec2/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/knife-ec2/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/knife-ec2/contents/{+path}","compare_url":"https://api.github.com/repos/chef/knife-ec2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/knife-ec2/merges","archive_url":"https://api.github.com/repos/chef/knife-ec2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/knife-ec2/downloads","issues_url":"https://api.github.com/repos/chef/knife-ec2/issues{/number}","pulls_url":"https://api.github.com/repos/chef/knife-ec2/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/knife-ec2/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/knife-ec2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/knife-ec2/labels{/name}","releases_url":"https://api.github.com/repos/chef/knife-ec2/releases{/id}","deployments_url":"https://api.github.com/repos/chef/knife-ec2/deployments","created_at":"2011-03-07T23:26:53Z","updated_at":"2018-06-07T16:16:50Z","pushed_at":"2018-06-07T16:16:47Z","git_url":"git://github.com/chef/knife-ec2.git","ssh_url":"git@github.com:chef/knife-ec2.git","clone_url":"https://github.com/chef/knife-ec2.git","svn_url":"https://github.com/chef/knife-ec2","homepage":"","size":1162,"stargazers_count":398,"watchers_count":398,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":352,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":352,"open_issues":24,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/527"},"html":{"href":"https://github.com/chef/knife-ec2/pull/527"},"issue":{"href":"https://api.github.com/repos/chef/knife-ec2/issues/527"},"comments":{"href":"https://api.github.com/repos/chef/knife-ec2/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/chef/knife-ec2/statuses/1ed5df165d4a1fe68307750d1d559109c45cac5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Vasu1105"}}