{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2440","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2440/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2440/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2440/events","html_url":"https://github.com/knative/serving/pull/2440","id":378974644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTUyOTAz","number":2440,"title":"Refactoring of conformance tests","user":{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false},"labels":[{"id":860875203,"node_id":"MDU6TGFiZWw4NjA4NzUyMDM=","url":"https://api.github.com/repos/knative/serving/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-11-09T00:28:58Z","updated_at":"2018-12-03T18:13:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2440","html_url":"https://github.com/knative/serving/pull/2440","diff_url":"https://github.com/knative/serving/pull/2440.diff","patch_url":"https://github.com/knative/serving/pull/2440.patch"},"body":"This change refactors the conformance tests in an attempt to make it\r\neasier to both write new tests and extend existing tests.\r\n\r\nAt a high-level this:\r\n* Moves (to util or test lib) or decouples shared code and constants\r\nacross test files\r\n* Collapses Digest, Metadata, and Label tests to reduce duplication and\r\ntest suite runtime\r\n* (Mostly) standardizes object creation, update, and validation across\r\ntests\r\n* Moves some magic strings to constants\r\n* Adds additional ResourceObjects and ResourceNames\r\n* Removes unnecessary or duplicate validation steps\r\n\r\n<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/443810891","html_url":"https://github.com/knative/serving/pull/2440#issuecomment-443810891","issue_url":"https://api.github.com/repos/knative/serving/issues/2440","id":443810891,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzgxMDg5MQ==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T18:13:44Z","updated_at":"2018-12-03T18:13:44Z","author_association":"NONE","body":"@dgerd: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-knative-serving-integration-tests | ebe0c9f640f18182d94720c500804fd121b4600e | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2440/pull-knative-serving-integration-tests/1069648513169625088/) | `/test pull-knative-serving-integration-tests`\n\n[Full PR test history](https://gubernator.knative.dev/pr/knative_serving/2440). [Your PR dashboard](https://gubernator.knative.dev/pr/dgerd).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"knative-prow-robot"}}