{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/179733978","pull_request_review_id":110034367,"id":179733978,"diff_hunk":"@@ -172,6 +172,19 @@\n \t\t\t}\n \t\t\telse {\n \t\t\t\tfiles = _.pluck(this.getSelectedFiles(), 'name');\n+\t\t\t\t/**\n+\t\t\t\t * The getSelectedFiles gives the file name as it is seen in UI.\n+\t\t\t\t * But the fact is filenames are storead as filename.dxxxxx. This\n+\t\t\t\t * change helps to extract exact filename.\n+\t\t\t\t */\n+\t\t\t\tvar trSelectedFiles = this.$el.find('tr.selected');\n+\t\t\t\tvar filesFromAttribute = [];\n+\t\t\t\tfor (var i = 0; i < trSelectedFiles.length; i++) {\n+\t\t\t\t\tfilesFromAttribute.push(trSelectedFiles[i].getAttribute('data-file'));\n+\t\t\t\t}\n+\t\t\t\tif (files !== filesFromAttribute) {","path":"apps/files_trashbin/js/filelist.js","position":14,"original_position":14,"commit_id":"55a3ff090dcaadc4cfa5ec24350dabcb8186be2d","original_commit_id":"55a3ff090dcaadc4cfa5ec24350dabcb8186be2d","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"body":"I'm not sure this comparison is accurate as it might be comparing only the pointer reference and not the contents. Please use a clearer approach for this check.","created_at":"2018-04-06T11:48:10Z","updated_at":"2018-04-06T11:48:11Z","html_url":"https://github.com/owncloud/core/pull/30993#discussion_r179733978","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/30993","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/179733978"},"html":{"href":"https://github.com/owncloud/core/pull/30993#discussion_r179733978"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/30993"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/30993","id":179095777,"html_url":"https://github.com/owncloud/core/pull/30993","diff_url":"https://github.com/owncloud/core/pull/30993.diff","patch_url":"https://github.com/owncloud/core/pull/30993.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/30993","number":30993,"state":"open","locked":false,"title":"Fix deletion of selected files in trashbin","user":{"login":"sharidas","id":3600427,"avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false},"body":"When files were selected all, and later\r\nselective files were opted for deletion,\r\nthe deletion was not happening. The reason\r\nfor this behaviour is filenames are passed\r\nthrough ajax as seen in ui. Where as that\r\nis not the case. This change helps to fix it.\r\n\r\nSigned-off-by: Sujith H <sharidasan@owncloud.com>\r\n\r\n<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThe filenames passed in the ajax were the files seen in UI. But that is not the case with trashbin files. This change fixes the issue.\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nhttps://github.com/owncloud/core/issues/30942\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nThe filenames passed in the ajax were the files seen in UI. But that is not the case with trashbin files. This change fixes the issue.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n- [x] Create 2 files. And delete them.\r\n- [x] Select all and then change the decision to select only one. Delete the file. The file is deleted.\r\n- [x] The same experiment is repeated with multiple files. And the files were deleted.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n","created_at":"2018-04-03T13:18:28Z","updated_at":"2018-04-06T11:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd8a0e3405a317ff24bd034859e08c4f6e713a9","assignee":{"login":"sharidas","id":3600427,"avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharidas","id":3600427,"avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":45887383,"url":"https://api.github.com/repos/owncloud/core/labels/app:files_trashbin","name":"app:files_trashbin","color":"02d7e1","default":false},{"id":132150275,"url":"https://api.github.com/repos/owncloud/core/labels/backport-request","name":"backport-request","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/119","html_url":"https://github.com/owncloud/core/milestone/119","labels_url":"https://api.github.com/repos/owncloud/core/milestones/119/labels","id":2827584,"number":119,"title":"development","description":"10.0.8","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":621,"state":"open","created_at":"2017-10-10T13:37:01Z","updated_at":"2018-04-06T11:46:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/30993/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/30993/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/30993/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/55a3ff090dcaadc4cfa5ec24350dabcb8186be2d","head":{"label":"owncloud:trashbin-fix","ref":"trashbin-fix","sha":"55a3ff090dcaadc4cfa5ec24350dabcb8186be2d","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2018-04-06T10:53:19Z","pushed_at":"2018-04-06T11:42:00Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":235351,"stargazers_count":5917,"watchers_count":5917,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1793,"mirror_url":null,"archived":false,"open_issues_count":1154,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1793,"open_issues":1154,"watchers":5917,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"151b1b8a0d2ae3fbfa7fd34243b156ba73ac7f5e","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2018-04-06T10:53:19Z","pushed_at":"2018-04-06T11:42:00Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":235351,"stargazers_count":5917,"watchers_count":5917,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1793,"mirror_url":null,"archived":false,"open_issues_count":1154,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1793,"open_issues":1154,"watchers":5917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/30993"},"html":{"href":"https://github.com/owncloud/core/pull/30993"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/30993"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/30993/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/30993/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/30993/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/55a3ff090dcaadc4cfa5ec24350dabcb8186be2d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"PVince81"}}