{"action":"created","comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/220140784","pull_request_review_id":158476832,"id":220140784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDE0MDc4NA==","diff_hunk":"@@ -28,19 +29,26 @@ namespace reinforcement_learning {\n     }\n   }\n \n-  status_builder::status_builder(api_status* status, const int code)\n-    : _code {code}, _status {status} {\n-    if (status != nullptr)\n+  status_builder::status_builder(i_trace* trace, api_status* status, const int code)\n+    : _code { code }, _status { status }, _trace {trace} {\n+    if ( enable_logging() )\n       _os << \"(ERR:\" << _code << \")\";\n   }\n \n   status_builder::~status_builder() {\n     if (_status != nullptr) {\n       api_status::try_update(_status, _code, _os.str().c_str());\n     }\n+    if (_trace != nullptr ) {\n+      _trace->log(_os.str());\n+    }\n   }\n \n   status_builder::operator int() const {\n     return _code;\n   }\n+\n+  bool status_builder::enable_logging() const {\n+    return _status != nullptr || _trace == nullptr;","path":"reinforcement_learning/rlclientlib/api_status.cc","position":null,"original_position":33,"commit_id":"887da179a2602261a4a45428e0b4192e3b1e475a","original_commit_id":"ca1e13e0b42b737527521e87ea6c18d342706707","user":{"login":"rajan-chari","id":21222554,"node_id":"MDQ6VXNlcjIxMjIyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"body":"Yes.  Thanks.","created_at":"2018-09-25T10:36:44Z","updated_at":"2018-09-25T10:36:44Z","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600#discussion_r220140784","pull_request_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/220140784"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600#discussion_r220140784"},"pull_request":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600"}},"in_reply_to_id":219296757},"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600","id":216518528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTE4NTI4","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600.patch","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1600","number":1600,"state":"open","locked":false,"title":"Trace logging","user":{"login":"rajan-chari","id":21222554,"node_id":"MDQ6VXNlcjIxMjIyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"body":"Initial PR for trace logging.  ** Not ready to be merged yet ** ","created_at":"2018-09-19T05:32:32Z","updated_at":"2018-09-25T10:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed046eafcaa96b08297891ddf1cacf602e5cf9f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600/commits","review_comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600/comments","review_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1600/comments","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/887da179a2602261a4a45428e0b4192e3b1e475a","head":{"label":"rajan-chari:trace_logging","ref":"trace_logging","sha":"887da179a2602261a4a45428e0b4192e3b1e475a","user":{"login":"rajan-chari","id":21222554,"node_id":"MDQ6VXNlcjIxMjIyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"repo":{"id":145607043,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MDcwNDM=","name":"vowpal_wabbit","full_name":"rajan-chari/vowpal_wabbit","private":false,"owner":{"login":"rajan-chari","id":21222554,"node_id":"MDQ6VXNlcjIxMjIyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rajan-chari/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":true,"url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit","forks_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/deployments","created_at":"2018-08-21T18:59:03Z","updated_at":"2018-09-21T12:24:19Z","pushed_at":"2018-09-25T10:32:44Z","git_url":"git://github.com/rajan-chari/vowpal_wabbit.git","ssh_url":"git@github.com:rajan-chari/vowpal_wabbit.git","clone_url":"https://github.com/rajan-chari/vowpal_wabbit.git","svn_url":"https://github.com/rajan-chari/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":122427,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JohnLangford:master","ref":"master","sha":"285620eae372fdb7aeb081c044301acf36f53483","user":{"login":"JohnLangford","id":79590,"node_id":"MDQ6VXNlcjc5NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"repo":{"id":265995,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU5OTU=","name":"vowpal_wabbit","full_name":"JohnLangford/vowpal_wabbit","private":false,"owner":{"login":"JohnLangford","id":79590,"node_id":"MDQ6VXNlcjc5NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JohnLangford/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","forks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/deployments","created_at":"2009-07-31T19:36:58Z","updated_at":"2018-09-24T19:35:51Z","pushed_at":"2018-09-25T10:32:47Z","git_url":"git://github.com/JohnLangford/vowpal_wabbit.git","ssh_url":"git@github.com:JohnLangford/vowpal_wabbit.git","clone_url":"https://github.com/JohnLangford/vowpal_wabbit.git","svn_url":"https://github.com/JohnLangford/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":122351,"stargazers_count":5829,"watchers_count":5829,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1456,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1456,"open_issues":43,"watchers":5829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1600"},"issue":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1600"},"comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1600/comments"},"review_comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600/comments"},"review_comment":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1600/commits"},"statuses":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/887da179a2602261a4a45428e0b4192e3b1e475a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rajan-chari"}}