{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/LightGBM/issues/1396","repository_url":"https://api.github.com/repos/Microsoft/LightGBM","labels_url":"https://api.github.com/repos/Microsoft/LightGBM/issues/1396/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/LightGBM/issues/1396/comments","events_url":"https://api.github.com/repos/Microsoft/LightGBM/issues/1396/events","html_url":"https://github.com/Microsoft/LightGBM/issues/1396","id":326115257,"number":1396,"title":"Dataset::ConstructHistograms() redundant cycle","user":{"login":"IbanezJS","id":2943717,"avatar_url":"https://avatars0.githubusercontent.com/u/2943717?v=4","gravatar_id":"","url":"https://api.github.com/users/IbanezJS","html_url":"https://github.com/IbanezJS","followers_url":"https://api.github.com/users/IbanezJS/followers","following_url":"https://api.github.com/users/IbanezJS/following{/other_user}","gists_url":"https://api.github.com/users/IbanezJS/gists{/gist_id}","starred_url":"https://api.github.com/users/IbanezJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IbanezJS/subscriptions","organizations_url":"https://api.github.com/users/IbanezJS/orgs","repos_url":"https://api.github.com/users/IbanezJS/repos","events_url":"https://api.github.com/users/IbanezJS/events{/privacy}","received_events_url":"https://api.github.com/users/IbanezJS/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-24T13:11:34Z","updated_at":"2018-05-24T15:17:47Z","closed_at":"2018-05-24T14:49:34Z","author_association":"NONE","body":"Hello. it seems that this cycle is useless:\r\nhttps://github.com/Microsoft/LightGBM/blob/e2a0de5082cc4f5630f0d446592547a7e4026801/src/io/dataset.cpp#L624\r\n\r\nis it a bug?\r\nafter this cycle `used_group` vector is always 0,1,...num_groups_-1\r\n`int num_used_group = static_cast<int>(used_group.size());` is always equals to `num_groups_`\r\n\r\nso `is_feature_used` function argument does not affect \"used_group\" at all...\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/LightGBM/issues/comments/391753095","html_url":"https://github.com/Microsoft/LightGBM/issues/1396#issuecomment-391753095","issue_url":"https://api.github.com/repos/Microsoft/LightGBM/issues/1396","id":391753095,"user":{"login":"IbanezJS","id":2943717,"avatar_url":"https://avatars0.githubusercontent.com/u/2943717?v=4","gravatar_id":"","url":"https://api.github.com/users/IbanezJS","html_url":"https://github.com/IbanezJS","followers_url":"https://api.github.com/users/IbanezJS/followers","following_url":"https://api.github.com/users/IbanezJS/following{/other_user}","gists_url":"https://api.github.com/users/IbanezJS/gists{/gist_id}","starred_url":"https://api.github.com/users/IbanezJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IbanezJS/subscriptions","organizations_url":"https://api.github.com/users/IbanezJS/orgs","repos_url":"https://api.github.com/users/IbanezJS/repos","events_url":"https://api.github.com/users/IbanezJS/events{/privacy}","received_events_url":"https://api.github.com/users/IbanezJS/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T15:17:47Z","updated_at":"2018-05-24T15:17:47Z","author_association":"NONE","body":"@guolinke \r\nabsolutly dont get how it associated with the code issue...\r\nthe cycle is obviously useless.\r\nA BUG in code!  "}}
{"actor":{"display_login":"IbanezJS"}}