{"action":"closed","number":1945,"pull_request":{"url":"https://api.github.com/repos/bisq-network/bisq/pulls/1945","id":232567569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTY3NTY5","html_url":"https://github.com/bisq-network/bisq/pull/1945","diff_url":"https://github.com/bisq-network/bisq/pull/1945.diff","patch_url":"https://github.com/bisq-network/bisq/pull/1945.patch","issue_url":"https://api.github.com/repos/bisq-network/bisq/issues/1945","number":1945,"state":"closed","locked":false,"title":"Limit initial window size on application launch","user":{"login":"devinbileck","id":603793,"node_id":"MDQ6VXNlcjYwMzc5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/603793?v=4","gravatar_id":"","url":"https://api.github.com/users/devinbileck","html_url":"https://github.com/devinbileck","followers_url":"https://api.github.com/users/devinbileck/followers","following_url":"https://api.github.com/users/devinbileck/following{/other_user}","gists_url":"https://api.github.com/users/devinbileck/gists{/gist_id}","starred_url":"https://api.github.com/users/devinbileck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinbileck/subscriptions","organizations_url":"https://api.github.com/users/devinbileck/orgs","repos_url":"https://api.github.com/users/devinbileck/repos","events_url":"https://api.github.com/users/devinbileck/events{/privacy}","received_events_url":"https://api.github.com/users/devinbileck/received_events","type":"User","site_admin":false},"body":"**Problem:** When launching Bisq on my Windows 10 laptop, the application window is larger than the usable screen bounds causing the title bar of the application to be mostly off the screen. This is an annoyance and requires me to move and resize the window so that it is within the screen bounds.\r\n\r\n**Cause:** My laptop has a 13-inch 1920x1080 display and uses 150% display scaling. As a result, it has a usable resolution (maximum screen bounds) of 1280x660 (accounting for the height of the Windows task bar). When launching the application, it sets the initial window height to 710px, which exceeds my usable screen height.\r\n\r\n**Fix:** When launching the application, prevent the initial window size from exceeding the maximum available bounds. These bounds account for objects in the native windowing system such as task bars and menu bars.\r\n\r\n<s>**Note: This is a work in progress as I have yet to test it on anything other than Windows (I plan to verify against Ubuntu). Nor have I verified a multi-display setup. But I still wanted to put this PR together in case anyone is able to verify it especially on Mac which I do not have available to test.**</s>","created_at":"2018-11-21T07:50:59Z","updated_at":"2018-11-22T12:18:15Z","closed_at":"2018-11-22T12:18:15Z","merged_at":"2018-11-22T12:18:15Z","merge_commit_sha":"d31fb45ae6460bf3472518f12125e947a84e3da5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ripcurlx","id":170962,"node_id":"MDQ6VXNlcjE3MDk2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/170962?v=4","gravatar_id":"","url":"https://api.github.com/users/ripcurlx","html_url":"https://github.com/ripcurlx","followers_url":"https://api.github.com/users/ripcurlx/followers","following_url":"https://api.github.com/users/ripcurlx/following{/other_user}","gists_url":"https://api.github.com/users/ripcurlx/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurlx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurlx/subscriptions","organizations_url":"https://api.github.com/users/ripcurlx/orgs","repos_url":"https://api.github.com/users/ripcurlx/repos","events_url":"https://api.github.com/users/ripcurlx/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurlx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bisq-network/bisq/pulls/1945/commits","review_comments_url":"https://api.github.com/repos/bisq-network/bisq/pulls/1945/comments","review_comment_url":"https://api.github.com/repos/bisq-network/bisq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bisq-network/bisq/issues/1945/comments","statuses_url":"https://api.github.com/repos/bisq-network/bisq/statuses/27c41a080c27c6f3ea0fbfa78c279dc7a0f36450","head":{"label":"devinbileck:limit-initial-window-size","ref":"limit-initial-window-size","sha":"27c41a080c27c6f3ea0fbfa78c279dc7a0f36450","user":{"login":"devinbileck","id":603793,"node_id":"MDQ6VXNlcjYwMzc5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/603793?v=4","gravatar_id":"","url":"https://api.github.com/users/devinbileck","html_url":"https://github.com/devinbileck","followers_url":"https://api.github.com/users/devinbileck/followers","following_url":"https://api.github.com/users/devinbileck/following{/other_user}","gists_url":"https://api.github.com/users/devinbileck/gists{/gist_id}","starred_url":"https://api.github.com/users/devinbileck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinbileck/subscriptions","organizations_url":"https://api.github.com/users/devinbileck/orgs","repos_url":"https://api.github.com/users/devinbileck/repos","events_url":"https://api.github.com/users/devinbileck/events{/privacy}","received_events_url":"https://api.github.com/users/devinbileck/received_events","type":"User","site_admin":false},"repo":{"id":150502499,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1MDI0OTk=","name":"bisq","full_name":"devinbileck/bisq","private":false,"owner":{"login":"devinbileck","id":603793,"node_id":"MDQ6VXNlcjYwMzc5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/603793?v=4","gravatar_id":"","url":"https://api.github.com/users/devinbileck","html_url":"https://github.com/devinbileck","followers_url":"https://api.github.com/users/devinbileck/followers","following_url":"https://api.github.com/users/devinbileck/following{/other_user}","gists_url":"https://api.github.com/users/devinbileck/gists{/gist_id}","starred_url":"https://api.github.com/users/devinbileck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinbileck/subscriptions","organizations_url":"https://api.github.com/users/devinbileck/orgs","repos_url":"https://api.github.com/users/devinbileck/repos","events_url":"https://api.github.com/users/devinbileck/events{/privacy}","received_events_url":"https://api.github.com/users/devinbileck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/devinbileck/bisq","description":"The decentralized bitcoin exchange network","fork":true,"url":"https://api.github.com/repos/devinbileck/bisq","forks_url":"https://api.github.com/repos/devinbileck/bisq/forks","keys_url":"https://api.github.com/repos/devinbileck/bisq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devinbileck/bisq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devinbileck/bisq/teams","hooks_url":"https://api.github.com/repos/devinbileck/bisq/hooks","issue_events_url":"https://api.github.com/repos/devinbileck/bisq/issues/events{/number}","events_url":"https://api.github.com/repos/devinbileck/bisq/events","assignees_url":"https://api.github.com/repos/devinbileck/bisq/assignees{/user}","branches_url":"https://api.github.com/repos/devinbileck/bisq/branches{/branch}","tags_url":"https://api.github.com/repos/devinbileck/bisq/tags","blobs_url":"https://api.github.com/repos/devinbileck/bisq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devinbileck/bisq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devinbileck/bisq/git/refs{/sha}","trees_url":"https://api.github.com/repos/devinbileck/bisq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devinbileck/bisq/statuses/{sha}","languages_url":"https://api.github.com/repos/devinbileck/bisq/languages","stargazers_url":"https://api.github.com/repos/devinbileck/bisq/stargazers","contributors_url":"https://api.github.com/repos/devinbileck/bisq/contributors","subscribers_url":"https://api.github.com/repos/devinbileck/bisq/subscribers","subscription_url":"https://api.github.com/repos/devinbileck/bisq/subscription","commits_url":"https://api.github.com/repos/devinbileck/bisq/commits{/sha}","git_commits_url":"https://api.github.com/repos/devinbileck/bisq/git/commits{/sha}","comments_url":"https://api.github.com/repos/devinbileck/bisq/comments{/number}","issue_comment_url":"https://api.github.com/repos/devinbileck/bisq/issues/comments{/number}","contents_url":"https://api.github.com/repos/devinbileck/bisq/contents/{+path}","compare_url":"https://api.github.com/repos/devinbileck/bisq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devinbileck/bisq/merges","archive_url":"https://api.github.com/repos/devinbileck/bisq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devinbileck/bisq/downloads","issues_url":"https://api.github.com/repos/devinbileck/bisq/issues{/number}","pulls_url":"https://api.github.com/repos/devinbileck/bisq/pulls{/number}","milestones_url":"https://api.github.com/repos/devinbileck/bisq/milestones{/number}","notifications_url":"https://api.github.com/repos/devinbileck/bisq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devinbileck/bisq/labels{/name}","releases_url":"https://api.github.com/repos/devinbileck/bisq/releases{/id}","deployments_url":"https://api.github.com/repos/devinbileck/bisq/deployments","created_at":"2018-09-26T23:40:20Z","updated_at":"2018-11-21T06:36:33Z","pushed_at":"2018-11-21T06:45:01Z","git_url":"git://github.com/devinbileck/bisq.git","ssh_url":"git@github.com:devinbileck/bisq.git","clone_url":"https://github.com/devinbileck/bisq.git","svn_url":"https://github.com/devinbileck/bisq","homepage":"https://bisq.network/downloads","size":203098,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bisq-network:master","ref":"master","sha":"cd616ffaf3e277fa1fab36c7184e694ae2140b08","user":{"login":"bisq-network","id":6928048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MjgwNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/6928048?v=4","gravatar_id":"","url":"https://api.github.com/users/bisq-network","html_url":"https://github.com/bisq-network","followers_url":"https://api.github.com/users/bisq-network/followers","following_url":"https://api.github.com/users/bisq-network/following{/other_user}","gists_url":"https://api.github.com/users/bisq-network/gists{/gist_id}","starred_url":"https://api.github.com/users/bisq-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisq-network/subscriptions","organizations_url":"https://api.github.com/users/bisq-network/orgs","repos_url":"https://api.github.com/users/bisq-network/repos","events_url":"https://api.github.com/users/bisq-network/events{/privacy}","received_events_url":"https://api.github.com/users/bisq-network/received_events","type":"Organization","site_admin":false},"repo":{"id":17662022,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY2MjAyMg==","name":"bisq","full_name":"bisq-network/bisq","private":false,"owner":{"login":"bisq-network","id":6928048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MjgwNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/6928048?v=4","gravatar_id":"","url":"https://api.github.com/users/bisq-network","html_url":"https://github.com/bisq-network","followers_url":"https://api.github.com/users/bisq-network/followers","following_url":"https://api.github.com/users/bisq-network/following{/other_user}","gists_url":"https://api.github.com/users/bisq-network/gists{/gist_id}","starred_url":"https://api.github.com/users/bisq-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisq-network/subscriptions","organizations_url":"https://api.github.com/users/bisq-network/orgs","repos_url":"https://api.github.com/users/bisq-network/repos","events_url":"https://api.github.com/users/bisq-network/events{/privacy}","received_events_url":"https://api.github.com/users/bisq-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bisq-network/bisq","description":"The decentralized bitcoin exchange network","fork":false,"url":"https://api.github.com/repos/bisq-network/bisq","forks_url":"https://api.github.com/repos/bisq-network/bisq/forks","keys_url":"https://api.github.com/repos/bisq-network/bisq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bisq-network/bisq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bisq-network/bisq/teams","hooks_url":"https://api.github.com/repos/bisq-network/bisq/hooks","issue_events_url":"https://api.github.com/repos/bisq-network/bisq/issues/events{/number}","events_url":"https://api.github.com/repos/bisq-network/bisq/events","assignees_url":"https://api.github.com/repos/bisq-network/bisq/assignees{/user}","branches_url":"https://api.github.com/repos/bisq-network/bisq/branches{/branch}","tags_url":"https://api.github.com/repos/bisq-network/bisq/tags","blobs_url":"https://api.github.com/repos/bisq-network/bisq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bisq-network/bisq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bisq-network/bisq/git/refs{/sha}","trees_url":"https://api.github.com/repos/bisq-network/bisq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bisq-network/bisq/statuses/{sha}","languages_url":"https://api.github.com/repos/bisq-network/bisq/languages","stargazers_url":"https://api.github.com/repos/bisq-network/bisq/stargazers","contributors_url":"https://api.github.com/repos/bisq-network/bisq/contributors","subscribers_url":"https://api.github.com/repos/bisq-network/bisq/subscribers","subscription_url":"https://api.github.com/repos/bisq-network/bisq/subscription","commits_url":"https://api.github.com/repos/bisq-network/bisq/commits{/sha}","git_commits_url":"https://api.github.com/repos/bisq-network/bisq/git/commits{/sha}","comments_url":"https://api.github.com/repos/bisq-network/bisq/comments{/number}","issue_comment_url":"https://api.github.com/repos/bisq-network/bisq/issues/comments{/number}","contents_url":"https://api.github.com/repos/bisq-network/bisq/contents/{+path}","compare_url":"https://api.github.com/repos/bisq-network/bisq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bisq-network/bisq/merges","archive_url":"https://api.github.com/repos/bisq-network/bisq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bisq-network/bisq/downloads","issues_url":"https://api.github.com/repos/bisq-network/bisq/issues{/number}","pulls_url":"https://api.github.com/repos/bisq-network/bisq/pulls{/number}","milestones_url":"https://api.github.com/repos/bisq-network/bisq/milestones{/number}","notifications_url":"https://api.github.com/repos/bisq-network/bisq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bisq-network/bisq/labels{/name}","releases_url":"https://api.github.com/repos/bisq-network/bisq/releases{/id}","deployments_url":"https://api.github.com/repos/bisq-network/bisq/deployments","created_at":"2014-03-12T09:42:29Z","updated_at":"2018-11-22T06:18:30Z","pushed_at":"2018-11-22T12:18:15Z","git_url":"git://github.com/bisq-network/bisq.git","ssh_url":"git@github.com:bisq-network/bisq.git","clone_url":"https://github.com/bisq-network/bisq.git","svn_url":"https://github.com/bisq-network/bisq","homepage":"https://bisq.network/downloads","size":206109,"stargazers_count":2543,"watchers_count":2543,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":301,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":707,"open_issues":301,"watchers":2543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bisq-network/bisq/pulls/1945"},"html":{"href":"https://github.com/bisq-network/bisq/pull/1945"},"issue":{"href":"https://api.github.com/repos/bisq-network/bisq/issues/1945"},"comments":{"href":"https://api.github.com/repos/bisq-network/bisq/issues/1945/comments"},"review_comments":{"href":"https://api.github.com/repos/bisq-network/bisq/pulls/1945/comments"},"review_comment":{"href":"https://api.github.com/repos/bisq-network/bisq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bisq-network/bisq/pulls/1945/commits"},"statuses":{"href":"https://api.github.com/repos/bisq-network/bisq/statuses/27c41a080c27c6f3ea0fbfa78c279dc7a0f36450"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ManfredKarrer","id":1449498,"node_id":"MDQ6VXNlcjE0NDk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1449498?v=4","gravatar_id":"","url":"https://api.github.com/users/ManfredKarrer","html_url":"https://github.com/ManfredKarrer","followers_url":"https://api.github.com/users/ManfredKarrer/followers","following_url":"https://api.github.com/users/ManfredKarrer/following{/other_user}","gists_url":"https://api.github.com/users/ManfredKarrer/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredKarrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredKarrer/subscriptions","organizations_url":"https://api.github.com/users/ManfredKarrer/orgs","repos_url":"https://api.github.com/users/ManfredKarrer/repos","events_url":"https://api.github.com/users/ManfredKarrer/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredKarrer/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"ManfredKarrer"}}