{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/186196166","pull_request_review_id":117737727,"id":186196166,"diff_hunk":"@@ -712,6 +720,7 @@ def test_job_run_on_knl_node(self):\n             self.logger.info(\"exec_vnode %s is a KNL vnode.\" % (evnode))\n             rv = True\n         else:\n+            rv = False\n             self.logger.info(\"exec_vnode %s is not a KNL vnode.\" % (evnode))","path":"test/tests/functional/pbs_basil_support.py","position":null,"original_position":94,"commit_id":"b1710f0adc287c432daf5090f8e40ab0ad5394f3","original_commit_id":"026fa81e9a150a1e13d15b3a9f850d6ffab4a0c2","user":{"login":"Klovely","id":17923164,"avatar_url":"https://avatars2.githubusercontent.com/u/17923164?v=4","gravatar_id":"","url":"https://api.github.com/users/Klovely","html_url":"https://github.com/Klovely","followers_url":"https://api.github.com/users/Klovely/followers","following_url":"https://api.github.com/users/Klovely/following{/other_user}","gists_url":"https://api.github.com/users/Klovely/gists{/gist_id}","starred_url":"https://api.github.com/users/Klovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klovely/subscriptions","organizations_url":"https://api.github.com/users/Klovely/orgs","repos_url":"https://api.github.com/users/Klovely/repos","events_url":"https://api.github.com/users/Klovely/events{/privacy}","received_events_url":"https://api.github.com/users/Klovely/received_events","type":"User","site_admin":false},"body":"For now I would like to keep it as it is . ","created_at":"2018-05-04T19:41:56Z","updated_at":"2018-05-04T19:41:56Z","html_url":"https://github.com/PBSPro/pbspro/pull/659#discussion_r186196166","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/659","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/186196166"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/659#discussion_r186196166"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/659"}},"in_reply_to_id":186171515},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/659","id":184645643,"html_url":"https://github.com/PBSPro/pbspro/pull/659","diff_url":"https://github.com/PBSPro/pbspro/pull/659.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/659.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/659","number":659,"state":"open","locked":false,"title":"Additional PTL test for PP-706","user":{"login":"Klovely","id":17923164,"avatar_url":"https://avatars2.githubusercontent.com/u/17923164?v=4","gravatar_id":"","url":"https://api.github.com/users/Klovely","html_url":"https://github.com/Klovely","followers_url":"https://api.github.com/users/Klovely/followers","following_url":"https://api.github.com/users/Klovely/following{/other_user}","gists_url":"https://api.github.com/users/Klovely/gists{/gist_id}","starred_url":"https://api.github.com/users/Klovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klovely/subscriptions","organizations_url":"https://api.github.com/users/Klovely/orgs","repos_url":"https://api.github.com/users/Klovely/repos","events_url":"https://api.github.com/users/Klovely/events{/privacy}","received_events_url":"https://api.github.com/users/Klovely/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\n*  Added more regression for PP-706  in existing file pbs_basil_support.py\r\n*  Bug: server.manager is throwing error when using expect=True with object PBS_HOOK\r\n\r\n#### Affected Platform(s)\r\n* Linux\r\n\r\n#### Cause / Analysis / Design\r\n* Object PBS_HOOK is not defined in pbs_testlib.py due to this server.manager is throwing error when using expect=True with object PBS_HOOK\r\n\r\n#### Solution Description\r\n* Added code for object PBS_HOOK in pbs_testlib.py\r\n\r\n#### Testing logs/output\r\n\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [ ] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [ ] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n   - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n   - [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [ ] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-04-27T14:54:05Z","updated_at":"2018-05-04T19:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a91ce2dc66c9a1faa33596ec994fe88c826232b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/659/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/659/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/659/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/b1710f0adc287c432daf5090f8e40ab0ad5394f3","head":{"label":"Klovely:19472-PTLtest","ref":"19472-PTLtest","sha":"b1710f0adc287c432daf5090f8e40ab0ad5394f3","user":{"login":"Klovely","id":17923164,"avatar_url":"https://avatars2.githubusercontent.com/u/17923164?v=4","gravatar_id":"","url":"https://api.github.com/users/Klovely","html_url":"https://github.com/Klovely","followers_url":"https://api.github.com/users/Klovely/followers","following_url":"https://api.github.com/users/Klovely/following{/other_user}","gists_url":"https://api.github.com/users/Klovely/gists{/gist_id}","starred_url":"https://api.github.com/users/Klovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klovely/subscriptions","organizations_url":"https://api.github.com/users/Klovely/orgs","repos_url":"https://api.github.com/users/Klovely/repos","events_url":"https://api.github.com/users/Klovely/events{/privacy}","received_events_url":"https://api.github.com/users/Klovely/received_events","type":"User","site_admin":false},"repo":{"id":63219790,"name":"pbspro","full_name":"Klovely/pbspro","owner":{"login":"Klovely","id":17923164,"avatar_url":"https://avatars2.githubusercontent.com/u/17923164?v=4","gravatar_id":"","url":"https://api.github.com/users/Klovely","html_url":"https://github.com/Klovely","followers_url":"https://api.github.com/users/Klovely/followers","following_url":"https://api.github.com/users/Klovely/following{/other_user}","gists_url":"https://api.github.com/users/Klovely/gists{/gist_id}","starred_url":"https://api.github.com/users/Klovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klovely/subscriptions","organizations_url":"https://api.github.com/users/Klovely/orgs","repos_url":"https://api.github.com/users/Klovely/repos","events_url":"https://api.github.com/users/Klovely/events{/privacy}","received_events_url":"https://api.github.com/users/Klovely/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Klovely/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/Klovely/pbspro","forks_url":"https://api.github.com/repos/Klovely/pbspro/forks","keys_url":"https://api.github.com/repos/Klovely/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Klovely/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Klovely/pbspro/teams","hooks_url":"https://api.github.com/repos/Klovely/pbspro/hooks","issue_events_url":"https://api.github.com/repos/Klovely/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/Klovely/pbspro/events","assignees_url":"https://api.github.com/repos/Klovely/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/Klovely/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/Klovely/pbspro/tags","blobs_url":"https://api.github.com/repos/Klovely/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Klovely/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Klovely/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/Klovely/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Klovely/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/Klovely/pbspro/languages","stargazers_url":"https://api.github.com/repos/Klovely/pbspro/stargazers","contributors_url":"https://api.github.com/repos/Klovely/pbspro/contributors","subscribers_url":"https://api.github.com/repos/Klovely/pbspro/subscribers","subscription_url":"https://api.github.com/repos/Klovely/pbspro/subscription","commits_url":"https://api.github.com/repos/Klovely/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/Klovely/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/Klovely/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/Klovely/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/Klovely/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/Klovely/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Klovely/pbspro/merges","archive_url":"https://api.github.com/repos/Klovely/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Klovely/pbspro/downloads","issues_url":"https://api.github.com/repos/Klovely/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/Klovely/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/Klovely/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/Klovely/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Klovely/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/Klovely/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/Klovely/pbspro/deployments","created_at":"2016-07-13T06:17:12Z","updated_at":"2018-04-27T13:33:55Z","pushed_at":"2018-05-04T19:39:01Z","git_url":"git://github.com/Klovely/pbspro.git","ssh_url":"git@github.com:Klovely/pbspro.git","clone_url":"https://github.com/Klovely/pbspro.git","svn_url":"https://github.com/Klovely/pbspro","homepage":"www.pbspro.org","size":14970,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"af385faca98b15925d8e0100fbb98c342c91c7c8","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-05-04T13:52:45Z","pushed_at":"2018-05-04T19:39:02Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":15055,"stargazers_count":160,"watchers_count":160,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":132,"open_issues":9,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/659"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/659"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/659"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/b1710f0adc287c432daf5090f8e40ab0ad5394f3"}},"author_association":"NONE"}}
{"actor":{"display_login":"Klovely"}}