{"action":"created","issue":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1946","repository_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1946/labels{/name}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1946/comments","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1946/events","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1946","id":351497593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDc0NDQx","number":1946,"title":"Add delay & parallelise node connections","user":{"login":"zeptin","id":25860,"node_id":"MDQ6VXNlcjI1ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/25860?v=4","gravatar_id":"","url":"https://api.github.com/users/zeptin","html_url":"https://github.com/zeptin","followers_url":"https://api.github.com/users/zeptin/followers","following_url":"https://api.github.com/users/zeptin/following{/other_user}","gists_url":"https://api.github.com/users/zeptin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptin/subscriptions","organizations_url":"https://api.github.com/users/zeptin/orgs","repos_url":"https://api.github.com/users/zeptin/repos","events_url":"https://api.github.com/users/zeptin/events{/privacy}","received_events_url":"https://api.github.com/users/zeptin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-17T08:07:16Z","updated_at":"2018-08-18T06:09:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1946","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1946","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1946.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1946.patch"},"body":"For #1131"},"comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments/414035227","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1946#issuecomment-414035227","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1946","id":414035227,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDAzNTIyNw==","user":{"login":"zeptin","id":25860,"node_id":"MDQ6VXNlcjI1ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/25860?v=4","gravatar_id":"","url":"https://api.github.com/users/zeptin","html_url":"https://github.com/zeptin","followers_url":"https://api.github.com/users/zeptin/followers","following_url":"https://api.github.com/users/zeptin/following{/other_user}","gists_url":"https://api.github.com/users/zeptin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptin/subscriptions","organizations_url":"https://api.github.com/users/zeptin/orgs","repos_url":"https://api.github.com/users/zeptin/repos","events_url":"https://api.github.com/users/zeptin/events{/privacy}","received_events_url":"https://api.github.com/users/zeptin/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T06:09:00Z","updated_at":"2018-08-18T06:09:00Z","author_association":"CONTRIBUTOR","body":"Hi @ferdeen, note that there are three classes that override the abstract `OnConnectAsync` method (the third being `PeerConnectorDiscovery`). The `PeerConnectorDiscovery` logic is quite different to the `-connect` and `-addnode` connectors, so it would probably just clutter up the inheritance trying to avoid this one instance of duplication.\r\n\r\nAlso note that the design of how `-connect` and `-addnode` get handled may further diverge in the future, in which case the method implementations would need to remain separate. But if there is general agreement that the duplication should be removed then I will do it."}}
{"actor":{"display_login":"zeptin"}}