{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/comments/196579239","pull_request_review_id":130150310,"id":196579239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU3OTIzOQ==","diff_hunk":"@@ -0,0 +1,241 @@\n+<html>\n+\n+<head>\n+    <title>Applause App</title>\n+    <meta charset=\"utf-8\">\n+    <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n+    <link href=\"https://fonts.googleapis.com/css?family=Raleway:300,400,600,700\" rel=\"stylesheet\">\n+    <style>\n+        body {\n+            margin: 10;\n+            width: 100% - 10px;\n+            font-family: 'Raleway', sans-serif;\n+            color: white;\n+            background: linear-gradient(#2b2b2b, #0f212e);\n+        }\n+\n+        .top-bar {","path":"DomainContent/Zaru/applause-app/applause.html","position":17,"original_position":17,"commit_id":"a0ace68ab69882b6363664a8542492303083b262","original_commit_id":"a0ace68ab69882b6363664a8542492303083b262","user":{"login":"MiladNazeri","id":11789978,"node_id":"MDQ6VXNlcjExNzg5OTc4","avatar_url":"https://avatars3.githubusercontent.com/u/11789978?v=4","gravatar_id":"","url":"https://api.github.com/users/MiladNazeri","html_url":"https://github.com/MiladNazeri","followers_url":"https://api.github.com/users/MiladNazeri/followers","following_url":"https://api.github.com/users/MiladNazeri/following{/other_user}","gists_url":"https://api.github.com/users/MiladNazeri/gists{/gist_id}","starred_url":"https://api.github.com/users/MiladNazeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiladNazeri/subscriptions","organizations_url":"https://api.github.com/users/MiladNazeri/orgs","repos_url":"https://api.github.com/users/MiladNazeri/repos","events_url":"https://api.github.com/users/MiladNazeri/events{/privacy}","received_events_url":"https://api.github.com/users/MiladNazeri/received_events","type":"User","site_admin":false},"body":"guess you can remove this class","created_at":"2018-06-19T21:09:01Z","updated_at":"2018-06-19T21:16:25Z","html_url":"https://github.com/highfidelity/hifi-content/pull/159#discussion_r196579239","pull_request_url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/comments/196579239"},"html":{"href":"https://github.com/highfidelity/hifi-content/pull/159#discussion_r196579239"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159","id":195654158,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjU0MTU4","html_url":"https://github.com/highfidelity/hifi-content/pull/159","diff_url":"https://github.com/highfidelity/hifi-content/pull/159.diff","patch_url":"https://github.com/highfidelity/hifi-content/pull/159.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi-content/issues/159","number":159,"state":"open","locked":false,"title":"Applause Application for Zaru","user":{"login":"misslivirose","id":4313320,"node_id":"MDQ6VXNlcjQzMTMzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4313320?v=4","gravatar_id":"","url":"https://api.github.com/users/misslivirose","html_url":"https://github.com/misslivirose","followers_url":"https://api.github.com/users/misslivirose/followers","following_url":"https://api.github.com/users/misslivirose/following{/other_user}","gists_url":"https://api.github.com/users/misslivirose/gists{/gist_id}","starred_url":"https://api.github.com/users/misslivirose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misslivirose/subscriptions","organizations_url":"https://api.github.com/users/misslivirose/orgs","repos_url":"https://api.github.com/users/misslivirose/repos","events_url":"https://api.github.com/users/misslivirose/events{/privacy}","received_events_url":"https://api.github.com/users/misslivirose/received_events","type":"User","site_admin":false},"body":"This feature will allow users who enter into Zaru to applaud in desktop and HMD mode. In desktop mode, the user will get a button on the screen and be able to clap with a keyboard key press. In HMD mode, the user will be able to shake their hand controllers to allow them to generate applause sounds and heart particles. \r\n\r\n**Test Plan - App Setup**\r\n1. In a domain where you have rez permissions, add a cube and put https://hifi-content.s3-us-west-1.amazonaws.com/liv/Prototypes/Clapping-V4/applause-app.js into the script URL field. \r\n\r\nConfirm that the button appears on your HUD / tablet. \r\n\r\n2. Reload scripts (CTRL + R)\r\n\r\nConfirm that you do not get multiple instances of the button\r\n\r\n3. Leave the domain and return\r\n\r\nConfirm that the button is removed when you exit your domain, and returns when you come back to the domain close to where the cube is. \r\n\r\n**Test Plan - Desktop Mode**\r\n1. Click on the button for the applause app on your HUD. \r\n\r\nConfirm that you are presented with a UI that explains the app and has a toggle to enable the applause setting. \r\n\r\n2. Toggle on the applause setting\r\n\r\nConfirm that you see a button with instructions, a toggle for using the particle effects, and a new overlay button has been added to the bottom left corner of your screen. \r\n\r\nConfirm that when you click the buttons or press the 't' key on your keyboard that you see applause. Configure the app and open and close it to check that states remain the same when enabling and disabling the components. Toggling off 'use particles' should keep the hearts from showing. Confirm that your avatar scaling changes and that the particles still come from the position of your avatar's head. You should hear audio playing for the clapping.\r\n\r\n**Test Plan - HMD Mode**\r\n\r\n1. Open up the tablet app for the applause app in your HMD.\r\n\r\nConfirm that you see the tablet UI and a toggle. \r\n\r\n2. Toggle on the applause setting.\r\n\r\nConfirm that you see a gif that shows you how to move your hands.\r\n\r\n3. Try clapping.\r\n\r\nConfirm that as you bring your hands close while applause is enabled, your hands flatten out and return to their usual state when pulled away. Confirm that the desktop button overlay is not present around you somewhere in world. Confirm that the particles follow your hands and that the audio plays. \r\n\r\n4. Switch between desktop and VR mode. Confirm that the app cleans up appropriately between swapping (e.g. your hands do not stay flattened, your overlay returns) and maintains your configurations from the app. ","created_at":"2018-06-18T21:30:10Z","updated_at":"2018-06-19T21:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91884fd1de8f5aae7646cfb86d4821e939c3729b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":675887532,"node_id":"MDU6TGFiZWw2NzU4ODc1MzI=","url":"https://api.github.com/repos/highfidelity/hifi-content/labels/Needs%20CR","name":"Needs CR","color":"cccccc","default":false},{"id":675887234,"node_id":"MDU6TGFiZWw2NzU4ODcyMzQ=","url":"https://api.github.com/repos/highfidelity/hifi-content/labels/QA%20Ready","name":"QA Ready","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi-content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi-content/issues/159/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi-content/statuses/a0ace68ab69882b6363664a8542492303083b262","head":{"label":"misslivirose:applause-scripts","ref":"applause-scripts","sha":"a0ace68ab69882b6363664a8542492303083b262","user":{"login":"misslivirose","id":4313320,"node_id":"MDQ6VXNlcjQzMTMzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4313320?v=4","gravatar_id":"","url":"https://api.github.com/users/misslivirose","html_url":"https://github.com/misslivirose","followers_url":"https://api.github.com/users/misslivirose/followers","following_url":"https://api.github.com/users/misslivirose/following{/other_user}","gists_url":"https://api.github.com/users/misslivirose/gists{/gist_id}","starred_url":"https://api.github.com/users/misslivirose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misslivirose/subscriptions","organizations_url":"https://api.github.com/users/misslivirose/orgs","repos_url":"https://api.github.com/users/misslivirose/repos","events_url":"https://api.github.com/users/misslivirose/events{/privacy}","received_events_url":"https://api.github.com/users/misslivirose/received_events","type":"User","site_admin":false},"repo":{"id":101325634,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEzMjU2MzQ=","name":"hifi-content","full_name":"misslivirose/hifi-content","owner":{"login":"misslivirose","id":4313320,"node_id":"MDQ6VXNlcjQzMTMzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4313320?v=4","gravatar_id":"","url":"https://api.github.com/users/misslivirose","html_url":"https://github.com/misslivirose","followers_url":"https://api.github.com/users/misslivirose/followers","following_url":"https://api.github.com/users/misslivirose/following{/other_user}","gists_url":"https://api.github.com/users/misslivirose/gists{/gist_id}","starred_url":"https://api.github.com/users/misslivirose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misslivirose/subscriptions","organizations_url":"https://api.github.com/users/misslivirose/orgs","repos_url":"https://api.github.com/users/misslivirose/repos","events_url":"https://api.github.com/users/misslivirose/events{/privacy}","received_events_url":"https://api.github.com/users/misslivirose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misslivirose/hifi-content","description":"High Fidelity content","fork":true,"url":"https://api.github.com/repos/misslivirose/hifi-content","forks_url":"https://api.github.com/repos/misslivirose/hifi-content/forks","keys_url":"https://api.github.com/repos/misslivirose/hifi-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misslivirose/hifi-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misslivirose/hifi-content/teams","hooks_url":"https://api.github.com/repos/misslivirose/hifi-content/hooks","issue_events_url":"https://api.github.com/repos/misslivirose/hifi-content/issues/events{/number}","events_url":"https://api.github.com/repos/misslivirose/hifi-content/events","assignees_url":"https://api.github.com/repos/misslivirose/hifi-content/assignees{/user}","branches_url":"https://api.github.com/repos/misslivirose/hifi-content/branches{/branch}","tags_url":"https://api.github.com/repos/misslivirose/hifi-content/tags","blobs_url":"https://api.github.com/repos/misslivirose/hifi-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misslivirose/hifi-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misslivirose/hifi-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/misslivirose/hifi-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misslivirose/hifi-content/statuses/{sha}","languages_url":"https://api.github.com/repos/misslivirose/hifi-content/languages","stargazers_url":"https://api.github.com/repos/misslivirose/hifi-content/stargazers","contributors_url":"https://api.github.com/repos/misslivirose/hifi-content/contributors","subscribers_url":"https://api.github.com/repos/misslivirose/hifi-content/subscribers","subscription_url":"https://api.github.com/repos/misslivirose/hifi-content/subscription","commits_url":"https://api.github.com/repos/misslivirose/hifi-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/misslivirose/hifi-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/misslivirose/hifi-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/misslivirose/hifi-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/misslivirose/hifi-content/contents/{+path}","compare_url":"https://api.github.com/repos/misslivirose/hifi-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misslivirose/hifi-content/merges","archive_url":"https://api.github.com/repos/misslivirose/hifi-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misslivirose/hifi-content/downloads","issues_url":"https://api.github.com/repos/misslivirose/hifi-content/issues{/number}","pulls_url":"https://api.github.com/repos/misslivirose/hifi-content/pulls{/number}","milestones_url":"https://api.github.com/repos/misslivirose/hifi-content/milestones{/number}","notifications_url":"https://api.github.com/repos/misslivirose/hifi-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misslivirose/hifi-content/labels{/name}","releases_url":"https://api.github.com/repos/misslivirose/hifi-content/releases{/id}","deployments_url":"https://api.github.com/repos/misslivirose/hifi-content/deployments","created_at":"2017-08-24T18:27:33Z","updated_at":"2018-05-11T21:17:41Z","pushed_at":"2018-06-19T00:08:58Z","git_url":"git://github.com/misslivirose/hifi-content.git","ssh_url":"git@github.com:misslivirose/hifi-content.git","clone_url":"https://github.com/misslivirose/hifi-content.git","svn_url":"https://github.com/misslivirose/hifi-content","homepage":null,"size":235203,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"06c33e853bda1c55fd4b131f69cb909a449d61fc","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":89404899,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQwNDg5OQ==","name":"hifi-content","full_name":"highfidelity/hifi-content","owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi-content","description":"High Fidelity content","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi-content","forks_url":"https://api.github.com/repos/highfidelity/hifi-content/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi-content/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi-content/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi-content/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi-content/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi-content/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi-content/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi-content/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi-content/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi-content/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi-content/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi-content/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi-content/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi-content/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi-content/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi-content/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi-content/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi-content/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi-content/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi-content/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi-content/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi-content/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi-content/deployments","created_at":"2017-04-25T20:41:52Z","updated_at":"2018-06-15T19:56:23Z","pushed_at":"2018-06-19T18:42:29Z","git_url":"git://github.com/highfidelity/hifi-content.git","ssh_url":"git@github.com:highfidelity/hifi-content.git","clone_url":"https://github.com/highfidelity/hifi-content.git","svn_url":"https://github.com/highfidelity/hifi-content","homepage":null,"size":242639,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159"},"html":{"href":"https://github.com/highfidelity/hifi-content/pull/159"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi-content/issues/159"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi-content/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi-content/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi-content/statuses/a0ace68ab69882b6363664a8542492303083b262"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MiladNazeri"}}