{"action":"closed","number":2638,"pull_request":{"url":"https://api.github.com/repos/nipy/nipype/pulls/2638","id":201652336,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjUyMzM2","html_url":"https://github.com/nipy/nipype/pull/2638","diff_url":"https://github.com/nipy/nipype/pull/2638.diff","patch_url":"https://github.com/nipy/nipype/pull/2638.patch","issue_url":"https://api.github.com/repos/nipy/nipype/issues/2638","number":2638,"state":"closed","locked":false,"title":"[WIP] adding mapping and submitter to  enh/workflow syntax","user":{"login":"djarecka","id":1662746,"node_id":"MDQ6VXNlcjE2NjI3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1662746?v=4","gravatar_id":"","url":"https://api.github.com/users/djarecka","html_url":"https://github.com/djarecka","followers_url":"https://api.github.com/users/djarecka/followers","following_url":"https://api.github.com/users/djarecka/following{/other_user}","gists_url":"https://api.github.com/users/djarecka/gists{/gist_id}","starred_url":"https://api.github.com/users/djarecka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djarecka/subscriptions","organizations_url":"https://api.github.com/users/djarecka/orgs","repos_url":"https://api.github.com/users/djarecka/repos","events_url":"https://api.github.com/users/djarecka/events{/privacy}","received_events_url":"https://api.github.com/users/djarecka/received_events","type":"User","site_admin":false},"body":"I've started adding my mapping and submitter to #2629. I didn't know how to merge `NewNode` with my submitter without creating an extra class `NewNodeBase` and treating `NewNode` as a wrapper that runs nodes's  interface.\r\n\r\nFor now, I only added things related `mapper`, ignored `join` and `joindByKey`. Would like to get feedback first.\r\n\r\nI will be adding more tests (to shows mapping), working on `NewWorkflow` class.\r\n","created_at":"2018-07-16T14:17:45Z","updated_at":"2018-07-21T10:47:26Z","closed_at":"2018-07-21T10:47:26Z","merged_at":null,"merge_commit_sha":"0a788ec2d7011a3f6555d5673bd207d3ab342686","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712685151,"node_id":"MDU6TGFiZWw3MTI2ODUxNTE=","url":"https://api.github.com/repos/nipy/nipype/labels/nipype%202.0","name":"nipype 2.0","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/nipype/pulls/2638/commits","review_comments_url":"https://api.github.com/repos/nipy/nipype/pulls/2638/comments","review_comment_url":"https://api.github.com/repos/nipy/nipype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/nipype/issues/2638/comments","statuses_url":"https://api.github.com/repos/nipy/nipype/statuses/8300a98d3cd286534f3008ff7d066082f64d3848","head":{"label":"djarecka:effigies-enh/workflow_syntax","ref":"effigies-enh/workflow_syntax","sha":"8300a98d3cd286534f3008ff7d066082f64d3848","user":{"login":"djarecka","id":1662746,"node_id":"MDQ6VXNlcjE2NjI3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1662746?v=4","gravatar_id":"","url":"https://api.github.com/users/djarecka","html_url":"https://github.com/djarecka","followers_url":"https://api.github.com/users/djarecka/followers","following_url":"https://api.github.com/users/djarecka/following{/other_user}","gists_url":"https://api.github.com/users/djarecka/gists{/gist_id}","starred_url":"https://api.github.com/users/djarecka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djarecka/subscriptions","organizations_url":"https://api.github.com/users/djarecka/orgs","repos_url":"https://api.github.com/users/djarecka/repos","events_url":"https://api.github.com/users/djarecka/events{/privacy}","received_events_url":"https://api.github.com/users/djarecka/received_events","type":"User","site_admin":false},"repo":{"id":59325098,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMyNTA5OA==","name":"nipype","full_name":"djarecka/nipype","owner":{"login":"djarecka","id":1662746,"node_id":"MDQ6VXNlcjE2NjI3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1662746?v=4","gravatar_id":"","url":"https://api.github.com/users/djarecka","html_url":"https://github.com/djarecka","followers_url":"https://api.github.com/users/djarecka/followers","following_url":"https://api.github.com/users/djarecka/following{/other_user}","gists_url":"https://api.github.com/users/djarecka/gists{/gist_id}","starred_url":"https://api.github.com/users/djarecka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djarecka/subscriptions","organizations_url":"https://api.github.com/users/djarecka/orgs","repos_url":"https://api.github.com/users/djarecka/repos","events_url":"https://api.github.com/users/djarecka/events{/privacy}","received_events_url":"https://api.github.com/users/djarecka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djarecka/nipype","description":"Workflows and interfaces for neuroimaging packages","fork":true,"url":"https://api.github.com/repos/djarecka/nipype","forks_url":"https://api.github.com/repos/djarecka/nipype/forks","keys_url":"https://api.github.com/repos/djarecka/nipype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djarecka/nipype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djarecka/nipype/teams","hooks_url":"https://api.github.com/repos/djarecka/nipype/hooks","issue_events_url":"https://api.github.com/repos/djarecka/nipype/issues/events{/number}","events_url":"https://api.github.com/repos/djarecka/nipype/events","assignees_url":"https://api.github.com/repos/djarecka/nipype/assignees{/user}","branches_url":"https://api.github.com/repos/djarecka/nipype/branches{/branch}","tags_url":"https://api.github.com/repos/djarecka/nipype/tags","blobs_url":"https://api.github.com/repos/djarecka/nipype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djarecka/nipype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djarecka/nipype/git/refs{/sha}","trees_url":"https://api.github.com/repos/djarecka/nipype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djarecka/nipype/statuses/{sha}","languages_url":"https://api.github.com/repos/djarecka/nipype/languages","stargazers_url":"https://api.github.com/repos/djarecka/nipype/stargazers","contributors_url":"https://api.github.com/repos/djarecka/nipype/contributors","subscribers_url":"https://api.github.com/repos/djarecka/nipype/subscribers","subscription_url":"https://api.github.com/repos/djarecka/nipype/subscription","commits_url":"https://api.github.com/repos/djarecka/nipype/commits{/sha}","git_commits_url":"https://api.github.com/repos/djarecka/nipype/git/commits{/sha}","comments_url":"https://api.github.com/repos/djarecka/nipype/comments{/number}","issue_comment_url":"https://api.github.com/repos/djarecka/nipype/issues/comments{/number}","contents_url":"https://api.github.com/repos/djarecka/nipype/contents/{+path}","compare_url":"https://api.github.com/repos/djarecka/nipype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djarecka/nipype/merges","archive_url":"https://api.github.com/repos/djarecka/nipype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djarecka/nipype/downloads","issues_url":"https://api.github.com/repos/djarecka/nipype/issues{/number}","pulls_url":"https://api.github.com/repos/djarecka/nipype/pulls{/number}","milestones_url":"https://api.github.com/repos/djarecka/nipype/milestones{/number}","notifications_url":"https://api.github.com/repos/djarecka/nipype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djarecka/nipype/labels{/name}","releases_url":"https://api.github.com/repos/djarecka/nipype/releases{/id}","deployments_url":"https://api.github.com/repos/djarecka/nipype/deployments","created_at":"2016-05-20T20:41:27Z","updated_at":"2018-07-13T16:07:20Z","pushed_at":"2018-07-21T03:03:56Z","git_url":"git://github.com/djarecka/nipype.git","ssh_url":"git@github.com:djarecka/nipype.git","clone_url":"https://github.com/djarecka/nipype.git","svn_url":"https://github.com/djarecka/nipype","homepage":"http://nipype.readthedocs.org/en/latest/","size":31649,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"6c00f853a4f706e5a8792185e143c5bb3d857938","user":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":791477,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE0Nzc=","name":"nipype","full_name":"nipy/nipype","owner":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/nipype","description":"Workflows and interfaces for neuroimaging packages","fork":false,"url":"https://api.github.com/repos/nipy/nipype","forks_url":"https://api.github.com/repos/nipy/nipype/forks","keys_url":"https://api.github.com/repos/nipy/nipype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/nipype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/nipype/teams","hooks_url":"https://api.github.com/repos/nipy/nipype/hooks","issue_events_url":"https://api.github.com/repos/nipy/nipype/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/nipype/events","assignees_url":"https://api.github.com/repos/nipy/nipype/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/nipype/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/nipype/tags","blobs_url":"https://api.github.com/repos/nipy/nipype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/nipype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/nipype/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/nipype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/nipype/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/nipype/languages","stargazers_url":"https://api.github.com/repos/nipy/nipype/stargazers","contributors_url":"https://api.github.com/repos/nipy/nipype/contributors","subscribers_url":"https://api.github.com/repos/nipy/nipype/subscribers","subscription_url":"https://api.github.com/repos/nipy/nipype/subscription","commits_url":"https://api.github.com/repos/nipy/nipype/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/nipype/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/nipype/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/nipype/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/nipype/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/nipype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/nipype/merges","archive_url":"https://api.github.com/repos/nipy/nipype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/nipype/downloads","issues_url":"https://api.github.com/repos/nipy/nipype/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/nipype/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/nipype/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/nipype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/nipype/labels{/name}","releases_url":"https://api.github.com/repos/nipy/nipype/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/nipype/deployments","created_at":"2010-07-22T17:06:49Z","updated_at":"2018-07-19T12:21:47Z","pushed_at":"2018-07-21T03:03:57Z","git_url":"git://github.com/nipy/nipype.git","ssh_url":"git@github.com:nipy/nipype.git","clone_url":"https://github.com/nipy/nipype.git","svn_url":"https://github.com/nipy/nipype","homepage":"https://nipype.readthedocs.org/en/latest/","size":71040,"stargazers_count":359,"watchers_count":359,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":358,"open_issues":203,"watchers":359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/nipype/pulls/2638"},"html":{"href":"https://github.com/nipy/nipype/pull/2638"},"issue":{"href":"https://api.github.com/repos/nipy/nipype/issues/2638"},"comments":{"href":"https://api.github.com/repos/nipy/nipype/issues/2638/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/nipype/pulls/2638/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/nipype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/nipype/pulls/2638/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/nipype/statuses/8300a98d3cd286534f3008ff7d066082f64d3848"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":1123,"deletions":3,"changed_files":12}}
{"actor":{"display_login":"djarecka"}}