{"action":"created","comment":{"url":"https://api.github.com/repos/CASL/Futility/pulls/comments/210720599","pull_request_review_id":146997648,"id":210720599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDcyMDU5OQ==","diff_hunk":"@@ -663,7 +659,7 @@ SUBROUTINE get_DenseSquareMatrixType(matrix,i,j,getval)\n !>\n !> This routine gets the values of the sparse matrix.  If an (i,j) value\n !> is not present, then 0.0 is returned.  If the (i,j) location is out of\n-!> bounds, then -1051.0 is returned (-1051.0 is an arbitrarily chosen key).\n+!> bounds, then an exception is raised.","path":"src/MatrixTypes_Native.f90","position":91,"original_position":91,"commit_id":"c99fd32d31b9f8a1599b5d072c974842526bc19b","original_commit_id":"c99fd32d31b9f8a1599b5d072c974842526bc19b","user":{"login":"stimpsonsg","id":15932146,"node_id":"MDQ6VXNlcjE1OTMyMTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15932146?v=4","gravatar_id":"","url":"https://api.github.com/users/stimpsonsg","html_url":"https://github.com/stimpsonsg","followers_url":"https://api.github.com/users/stimpsonsg/followers","following_url":"https://api.github.com/users/stimpsonsg/following{/other_user}","gists_url":"https://api.github.com/users/stimpsonsg/gists{/gist_id}","starred_url":"https://api.github.com/users/stimpsonsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stimpsonsg/subscriptions","organizations_url":"https://api.github.com/users/stimpsonsg/orgs","repos_url":"https://api.github.com/users/stimpsonsg/repos","events_url":"https://api.github.com/users/stimpsonsg/events{/privacy}","received_events_url":"https://api.github.com/users/stimpsonsg/received_events","type":"User","site_admin":false},"body":"I personally prefer the first","created_at":"2018-08-16T19:49:20Z","updated_at":"2018-08-16T19:49:20Z","html_url":"https://github.com/CASL/Futility/pull/119#discussion_r210720599","pull_request_url":"https://api.github.com/repos/CASL/Futility/pulls/119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CASL/Futility/pulls/comments/210720599"},"html":{"href":"https://github.com/CASL/Futility/pull/119#discussion_r210720599"},"pull_request":{"href":"https://api.github.com/repos/CASL/Futility/pulls/119"}},"in_reply_to_id":210715159},"pull_request":{"url":"https://api.github.com/repos/CASL/Futility/pulls/119","id":204481803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDgxODAz","html_url":"https://github.com/CASL/Futility/pull/119","diff_url":"https://github.com/CASL/Futility/pull/119.diff","patch_url":"https://github.com/CASL/Futility/pull/119.patch","issue_url":"https://api.github.com/repos/CASL/Futility/issues/119","number":119,"state":"open","locked":false,"title":"Add exceptions to MatrixType","user":{"login":"rks171","id":2204328,"node_id":"MDQ6VXNlcjIyMDQzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2204328?v=4","gravatar_id":"","url":"https://api.github.com/users/rks171","html_url":"https://github.com/rks171","followers_url":"https://api.github.com/users/rks171/followers","following_url":"https://api.github.com/users/rks171/following{/other_user}","gists_url":"https://api.github.com/users/rks171/gists{/gist_id}","starred_url":"https://api.github.com/users/rks171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rks171/subscriptions","organizations_url":"https://api.github.com/users/rks171/orgs","repos_url":"https://api.github.com/users/rks171/repos","events_url":"https://api.github.com/users/rks171/events{/privacy}","received_events_url":"https://api.github.com/users/rks171/received_events","type":"User","site_admin":false},"body":"Integrating the native solvers for sparse matrices would have went more smoothly if Futility would have warned me that I needed to call setShape before setting data and that the j values need to be in ascending order.  Added a few other exceptions that should help prevent unintended behavior.","created_at":"2018-07-27T16:34:29Z","updated_at":"2018-08-16T19:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d33debf40b8d3b12de76168f4007dd2d4104c9c6","assignee":{"login":"stimpsonsg","id":15932146,"node_id":"MDQ6VXNlcjE1OTMyMTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15932146?v=4","gravatar_id":"","url":"https://api.github.com/users/stimpsonsg","html_url":"https://github.com/stimpsonsg","followers_url":"https://api.github.com/users/stimpsonsg/followers","following_url":"https://api.github.com/users/stimpsonsg/following{/other_user}","gists_url":"https://api.github.com/users/stimpsonsg/gists{/gist_id}","starred_url":"https://api.github.com/users/stimpsonsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stimpsonsg/subscriptions","organizations_url":"https://api.github.com/users/stimpsonsg/orgs","repos_url":"https://api.github.com/users/stimpsonsg/repos","events_url":"https://api.github.com/users/stimpsonsg/events{/privacy}","received_events_url":"https://api.github.com/users/stimpsonsg/received_events","type":"User","site_admin":false},"assignees":[{"login":"stimpsonsg","id":15932146,"node_id":"MDQ6VXNlcjE1OTMyMTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15932146?v=4","gravatar_id":"","url":"https://api.github.com/users/stimpsonsg","html_url":"https://github.com/stimpsonsg","followers_url":"https://api.github.com/users/stimpsonsg/followers","following_url":"https://api.github.com/users/stimpsonsg/following{/other_user}","gists_url":"https://api.github.com/users/stimpsonsg/gists{/gist_id}","starred_url":"https://api.github.com/users/stimpsonsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stimpsonsg/subscriptions","organizations_url":"https://api.github.com/users/stimpsonsg/orgs","repos_url":"https://api.github.com/users/stimpsonsg/repos","events_url":"https://api.github.com/users/stimpsonsg/events{/privacy}","received_events_url":"https://api.github.com/users/stimpsonsg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CASL/Futility/pulls/119/commits","review_comments_url":"https://api.github.com/repos/CASL/Futility/pulls/119/comments","review_comment_url":"https://api.github.com/repos/CASL/Futility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CASL/Futility/issues/119/comments","statuses_url":"https://api.github.com/repos/CASL/Futility/statuses/c99fd32d31b9f8a1599b5d072c974842526bc19b","head":{"label":"CASL:ticket_5400","ref":"ticket_5400","sha":"c99fd32d31b9f8a1599b5d072c974842526bc19b","user":{"login":"CASL","id":2250245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTAyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2250245?v=4","gravatar_id":"","url":"https://api.github.com/users/CASL","html_url":"https://github.com/CASL","followers_url":"https://api.github.com/users/CASL/followers","following_url":"https://api.github.com/users/CASL/following{/other_user}","gists_url":"https://api.github.com/users/CASL/gists{/gist_id}","starred_url":"https://api.github.com/users/CASL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CASL/subscriptions","organizations_url":"https://api.github.com/users/CASL/orgs","repos_url":"https://api.github.com/users/CASL/repos","events_url":"https://api.github.com/users/CASL/events{/privacy}","received_events_url":"https://api.github.com/users/CASL/received_events","type":"Organization","site_admin":false},"repo":{"id":75673882,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY3Mzg4Mg==","name":"Futility","full_name":"CASL/Futility","owner":{"login":"CASL","id":2250245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTAyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2250245?v=4","gravatar_id":"","url":"https://api.github.com/users/CASL","html_url":"https://github.com/CASL","followers_url":"https://api.github.com/users/CASL/followers","following_url":"https://api.github.com/users/CASL/following{/other_user}","gists_url":"https://api.github.com/users/CASL/gists{/gist_id}","starred_url":"https://api.github.com/users/CASL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CASL/subscriptions","organizations_url":"https://api.github.com/users/CASL/orgs","repos_url":"https://api.github.com/users/CASL/repos","events_url":"https://api.github.com/users/CASL/events{/privacy}","received_events_url":"https://api.github.com/users/CASL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CASL/Futility","description":"VERA Fortran Utilities","fork":false,"url":"https://api.github.com/repos/CASL/Futility","forks_url":"https://api.github.com/repos/CASL/Futility/forks","keys_url":"https://api.github.com/repos/CASL/Futility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CASL/Futility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CASL/Futility/teams","hooks_url":"https://api.github.com/repos/CASL/Futility/hooks","issue_events_url":"https://api.github.com/repos/CASL/Futility/issues/events{/number}","events_url":"https://api.github.com/repos/CASL/Futility/events","assignees_url":"https://api.github.com/repos/CASL/Futility/assignees{/user}","branches_url":"https://api.github.com/repos/CASL/Futility/branches{/branch}","tags_url":"https://api.github.com/repos/CASL/Futility/tags","blobs_url":"https://api.github.com/repos/CASL/Futility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CASL/Futility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CASL/Futility/git/refs{/sha}","trees_url":"https://api.github.com/repos/CASL/Futility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CASL/Futility/statuses/{sha}","languages_url":"https://api.github.com/repos/CASL/Futility/languages","stargazers_url":"https://api.github.com/repos/CASL/Futility/stargazers","contributors_url":"https://api.github.com/repos/CASL/Futility/contributors","subscribers_url":"https://api.github.com/repos/CASL/Futility/subscribers","subscription_url":"https://api.github.com/repos/CASL/Futility/subscription","commits_url":"https://api.github.com/repos/CASL/Futility/commits{/sha}","git_commits_url":"https://api.github.com/repos/CASL/Futility/git/commits{/sha}","comments_url":"https://api.github.com/repos/CASL/Futility/comments{/number}","issue_comment_url":"https://api.github.com/repos/CASL/Futility/issues/comments{/number}","contents_url":"https://api.github.com/repos/CASL/Futility/contents/{+path}","compare_url":"https://api.github.com/repos/CASL/Futility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CASL/Futility/merges","archive_url":"https://api.github.com/repos/CASL/Futility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CASL/Futility/downloads","issues_url":"https://api.github.com/repos/CASL/Futility/issues{/number}","pulls_url":"https://api.github.com/repos/CASL/Futility/pulls{/number}","milestones_url":"https://api.github.com/repos/CASL/Futility/milestones{/number}","notifications_url":"https://api.github.com/repos/CASL/Futility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CASL/Futility/labels{/name}","releases_url":"https://api.github.com/repos/CASL/Futility/releases{/id}","deployments_url":"https://api.github.com/repos/CASL/Futility/deployments","created_at":"2016-12-05T22:58:13Z","updated_at":"2018-08-07T21:40:35Z","pushed_at":"2018-08-16T18:55:21Z","git_url":"git://github.com/CASL/Futility.git","ssh_url":"git@github.com:CASL/Futility.git","clone_url":"https://github.com/CASL/Futility.git","svn_url":"https://github.com/CASL/Futility","homepage":null,"size":9829,"stargazers_count":5,"watchers_count":5,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":10,"watchers":5,"default_branch":"master"}},"base":{"label":"CASL:master","ref":"master","sha":"fce47f76f3c59c50e179cf4e9b74ae58f9b27647","user":{"login":"CASL","id":2250245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTAyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2250245?v=4","gravatar_id":"","url":"https://api.github.com/users/CASL","html_url":"https://github.com/CASL","followers_url":"https://api.github.com/users/CASL/followers","following_url":"https://api.github.com/users/CASL/following{/other_user}","gists_url":"https://api.github.com/users/CASL/gists{/gist_id}","starred_url":"https://api.github.com/users/CASL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CASL/subscriptions","organizations_url":"https://api.github.com/users/CASL/orgs","repos_url":"https://api.github.com/users/CASL/repos","events_url":"https://api.github.com/users/CASL/events{/privacy}","received_events_url":"https://api.github.com/users/CASL/received_events","type":"Organization","site_admin":false},"repo":{"id":75673882,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY3Mzg4Mg==","name":"Futility","full_name":"CASL/Futility","owner":{"login":"CASL","id":2250245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTAyNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2250245?v=4","gravatar_id":"","url":"https://api.github.com/users/CASL","html_url":"https://github.com/CASL","followers_url":"https://api.github.com/users/CASL/followers","following_url":"https://api.github.com/users/CASL/following{/other_user}","gists_url":"https://api.github.com/users/CASL/gists{/gist_id}","starred_url":"https://api.github.com/users/CASL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CASL/subscriptions","organizations_url":"https://api.github.com/users/CASL/orgs","repos_url":"https://api.github.com/users/CASL/repos","events_url":"https://api.github.com/users/CASL/events{/privacy}","received_events_url":"https://api.github.com/users/CASL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CASL/Futility","description":"VERA Fortran Utilities","fork":false,"url":"https://api.github.com/repos/CASL/Futility","forks_url":"https://api.github.com/repos/CASL/Futility/forks","keys_url":"https://api.github.com/repos/CASL/Futility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CASL/Futility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CASL/Futility/teams","hooks_url":"https://api.github.com/repos/CASL/Futility/hooks","issue_events_url":"https://api.github.com/repos/CASL/Futility/issues/events{/number}","events_url":"https://api.github.com/repos/CASL/Futility/events","assignees_url":"https://api.github.com/repos/CASL/Futility/assignees{/user}","branches_url":"https://api.github.com/repos/CASL/Futility/branches{/branch}","tags_url":"https://api.github.com/repos/CASL/Futility/tags","blobs_url":"https://api.github.com/repos/CASL/Futility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CASL/Futility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CASL/Futility/git/refs{/sha}","trees_url":"https://api.github.com/repos/CASL/Futility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CASL/Futility/statuses/{sha}","languages_url":"https://api.github.com/repos/CASL/Futility/languages","stargazers_url":"https://api.github.com/repos/CASL/Futility/stargazers","contributors_url":"https://api.github.com/repos/CASL/Futility/contributors","subscribers_url":"https://api.github.com/repos/CASL/Futility/subscribers","subscription_url":"https://api.github.com/repos/CASL/Futility/subscription","commits_url":"https://api.github.com/repos/CASL/Futility/commits{/sha}","git_commits_url":"https://api.github.com/repos/CASL/Futility/git/commits{/sha}","comments_url":"https://api.github.com/repos/CASL/Futility/comments{/number}","issue_comment_url":"https://api.github.com/repos/CASL/Futility/issues/comments{/number}","contents_url":"https://api.github.com/repos/CASL/Futility/contents/{+path}","compare_url":"https://api.github.com/repos/CASL/Futility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CASL/Futility/merges","archive_url":"https://api.github.com/repos/CASL/Futility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CASL/Futility/downloads","issues_url":"https://api.github.com/repos/CASL/Futility/issues{/number}","pulls_url":"https://api.github.com/repos/CASL/Futility/pulls{/number}","milestones_url":"https://api.github.com/repos/CASL/Futility/milestones{/number}","notifications_url":"https://api.github.com/repos/CASL/Futility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CASL/Futility/labels{/name}","releases_url":"https://api.github.com/repos/CASL/Futility/releases{/id}","deployments_url":"https://api.github.com/repos/CASL/Futility/deployments","created_at":"2016-12-05T22:58:13Z","updated_at":"2018-08-07T21:40:35Z","pushed_at":"2018-08-16T18:55:21Z","git_url":"git://github.com/CASL/Futility.git","ssh_url":"git@github.com:CASL/Futility.git","clone_url":"https://github.com/CASL/Futility.git","svn_url":"https://github.com/CASL/Futility","homepage":null,"size":9829,"stargazers_count":5,"watchers_count":5,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CASL/Futility/pulls/119"},"html":{"href":"https://github.com/CASL/Futility/pull/119"},"issue":{"href":"https://api.github.com/repos/CASL/Futility/issues/119"},"comments":{"href":"https://api.github.com/repos/CASL/Futility/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/CASL/Futility/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/CASL/Futility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CASL/Futility/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/CASL/Futility/statuses/c99fd32d31b9f8a1599b5d072c974842526bc19b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stimpsonsg"}}