{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/2116","repository_url":"https://api.github.com/repos/dgraph-io/dgraph","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/2116/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/2116/comments","events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/2116/events","html_url":"https://github.com/dgraph-io/dgraph/pull/2116","id":296273391,"number":2116,"title":"Query attributes with empty strings.","user":{"login":"sboorlagadda","id":7171016,"avatar_url":"https://avatars0.githubusercontent.com/u/7171016?v=4","gravatar_id":"","url":"https://api.github.com/users/sboorlagadda","html_url":"https://github.com/sboorlagadda","followers_url":"https://api.github.com/users/sboorlagadda/followers","following_url":"https://api.github.com/users/sboorlagadda/following{/other_user}","gists_url":"https://api.github.com/users/sboorlagadda/gists{/gist_id}","starred_url":"https://api.github.com/users/sboorlagadda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboorlagadda/subscriptions","organizations_url":"https://api.github.com/users/sboorlagadda/orgs","repos_url":"https://api.github.com/users/sboorlagadda/repos","events_url":"https://api.github.com/users/sboorlagadda/events{/privacy}","received_events_url":"https://api.github.com/users/sboorlagadda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pawanrawal","id":7247941,"avatar_url":"https://avatars1.githubusercontent.com/u/7247941?v=4","gravatar_id":"","url":"https://api.github.com/users/pawanrawal","html_url":"https://github.com/pawanrawal","followers_url":"https://api.github.com/users/pawanrawal/followers","following_url":"https://api.github.com/users/pawanrawal/following{/other_user}","gists_url":"https://api.github.com/users/pawanrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawanrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawanrawal/subscriptions","organizations_url":"https://api.github.com/users/pawanrawal/orgs","repos_url":"https://api.github.com/users/pawanrawal/repos","events_url":"https://api.github.com/users/pawanrawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawanrawal/received_events","type":"User","site_admin":false},"assignees":[{"login":"pawanrawal","id":7247941,"avatar_url":"https://avatars1.githubusercontent.com/u/7247941?v=4","gravatar_id":"","url":"https://api.github.com/users/pawanrawal","html_url":"https://github.com/pawanrawal","followers_url":"https://api.github.com/users/pawanrawal/followers","following_url":"https://api.github.com/users/pawanrawal/following{/other_user}","gists_url":"https://api.github.com/users/pawanrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawanrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawanrawal/subscriptions","organizations_url":"https://api.github.com/users/pawanrawal/orgs","repos_url":"https://api.github.com/users/pawanrawal/repos","events_url":"https://api.github.com/users/pawanrawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawanrawal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-02-12T05:54:29Z","updated_at":"2018-02-12T08:08:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/2116","html_url":"https://github.com/dgraph-io/dgraph/pull/2116","diff_url":"https://github.com/dgraph-io/dgraph/pull/2116.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/2116.patch"},"body":"Accept empty strings in queries for inequality functions.\r\n\r\nthis closes #2108\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/dgraph/2116)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments/364851633","html_url":"https://github.com/dgraph-io/dgraph/pull/2116#issuecomment-364851633","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/2116","id":364851633,"user":{"login":"sboorlagadda","id":7171016,"avatar_url":"https://avatars0.githubusercontent.com/u/7171016?v=4","gravatar_id":"","url":"https://api.github.com/users/sboorlagadda","html_url":"https://github.com/sboorlagadda","followers_url":"https://api.github.com/users/sboorlagadda/followers","following_url":"https://api.github.com/users/sboorlagadda/following{/other_user}","gists_url":"https://api.github.com/users/sboorlagadda/gists{/gist_id}","starred_url":"https://api.github.com/users/sboorlagadda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboorlagadda/subscriptions","organizations_url":"https://api.github.com/users/sboorlagadda/orgs","repos_url":"https://api.github.com/users/sboorlagadda/repos","events_url":"https://api.github.com/users/sboorlagadda/events{/privacy}","received_events_url":"https://api.github.com/users/sboorlagadda/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T08:08:16Z","updated_at":"2018-02-12T08:08:16Z","author_association":"MEMBER","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[gql/parser.go, line 1464 at r1](https://reviewable.io:443/reviews/dgraph-io/dgraph/2116#-L57bciM8eNU-IAg0xCV:-L582KaFBHtEONCrL_qf:b-896fix) ([raw file](https://github.com/dgraph-io/dgraph/blob/84194be1c19c465596d68786a07af2200ba4eb70/gql/parser.go#L1464)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary><blockquote>\n\nWe should probably still throw error if its not inequality operation.\n</blockquote></details>\n\nDone.\n\n---\n\n*[worker/task.go, line 988 at r1](https://reviewable.io:443/reviews/dgraph-io/dgraph/2116#-L57b4Q3-sDQBC8uHrZF:-L582MjcKmWEHJytyY-j:boh4g8w) ([raw file](https://github.com/dgraph-io/dgraph/blob/7202ca21888b549c1c9b3430a47f5aa917280260/worker/task.go#L988)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary><blockquote>\n\nWow, was that a bug?\n</blockquote></details>\n\nYes. matchStrings should receive only filtered uid list (as was done in previous case)> .\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dgraph-io/dgraph/2116)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"sboorlagadda"}}