{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65988","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65988/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65988/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65988/events","html_url":"https://github.com/kubernetes/kubernetes/issues/65988","id":339572424,"node_id":"MDU6SXNzdWUzMzk1NzI0MjQ=","number":65988,"title":"Code gen is out of sync","user":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"labels":[{"id":617149945,"node_id":"MDU6TGFiZWw2MTcxNDk5NDU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-07-09T19:12:00Z","updated_at":"2018-07-10T19:46:05Z","closed_at":"2018-07-10T19:46:05Z","author_association":"MEMBER","body":"@sttts it looks like something is up on master.  Clean checkout, touch staging/src/k8s.io/api/batch/v2alpha1/, then `make generated_files` -- produces a delta.\r\n\r\n```\r\ndiff --git a/pkg/apis/batch/v2alpha1/zz_generated.conversion.go b/pkg/apis/batch/v2alpha1/zz_generated.conversion.go\r\nindex 3a0fe9cd74..058c6a7093 100644\r\n--- a/pkg/apis/batch/v2alpha1/zz_generated.conversion.go\r\n+++ b/pkg/apis/batch/v2alpha1/zz_generated.conversion.go\r\n@@ -29,7 +29,6 @@ import (\r\n        conversion \"k8s.io/apimachinery/pkg/conversion\"\r\n        runtime \"k8s.io/apimachinery/pkg/runtime\"\r\n        batch \"k8s.io/kubernetes/pkg/apis/batch\"\r\n-       batchv1 \"k8s.io/kubernetes/pkg/apis/batch/v1\"\r\n        core \"k8s.io/kubernetes/pkg/apis/core\"\r\n )\r\n \r\n@@ -216,7 +215,8 @@ func Convert_batch_JobTemplate_To_v2alpha1_JobTemplate(in *batch.JobTemplate, ou\r\n \r\n func autoConvert_v2alpha1_JobTemplateSpec_To_batch_JobTemplateSpec(in *v2alpha1.JobTemplateSpec, out *batch.JobTemplateSpec, s conversion.Scope) error {\r\n        out.ObjectMeta = in.ObjectMeta\r\n-       if err := batchv1.Convert_v1_JobSpec_To_batch_JobSpec(&in.Spec, &out.Spec, s); err != nil {\r\n+       // TODO: Inefficient conversion - can we improve it?\r\n+       if err := s.Convert(&in.Spec, &out.Spec, 0); err != nil {\r\n                return err\r\n        }\r\n        return nil\r\n@@ -229,7 +229,8 @@ func Convert_v2alpha1_JobTemplateSpec_To_batch_JobTemplateSpec(in *v2alpha1.JobT\r\n \r\n func autoConvert_batch_JobTemplateSpec_To_v2alpha1_JobTemplateSpec(in *batch.JobTemplateSpec, out *v2alpha1.JobTemplateSpec, s conversion.Scope) error {\r\n        out.ObjectMeta = in.ObjectMeta\r\n-       if err := batchv1.Convert_batch_JobSpec_To_v1_JobSpec(&in.Spec, &out.Spec, s); err != nil {\r\n+       // TODO: Inefficient conversion - can we improve it?\r\n+       if err := s.Convert(&in.Spec, &out.Spec, 0); err != nil {\r\n                return err\r\n        }\r\n        return nil\r\n```"}}
{"actor":{"display_login":"k8s-merge-robot"}}