{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/169812758","pull_request_review_id":98401633,"id":169812758,"diff_hunk":"@@ -22,32 +21,14 @@ angular.module('calcentral.controllers').controller('FinaidController', function\n     blank: 'blank'\n   };\n \n-  var setFinaidYear = function(data, finaidYearId) {\n-    if (finaidYearId) {\n-      $scope.finaidYear = finaidService.findFinaidYear(data, finaidYearId);\n-    } else {\n-      finaidService.setDefaultFinaidYear(data);\n-      $scope.finaidYear = _.get(finaidService, 'options.finaidYear');\n-    }\n-  };\n-\n-  var combinationExists = function(data, finaidYearId) {\n-    var combination = finaidService.combinationExists(data, finaidYearId);\n-    if (!combination) {\n-      apiService.user.redirectToPage('finances');\n-      return false;\n-    }\n-  };\n-\n   var getFinaidSummary = function(options) {\n     return finaidFactory.getSummary(options).then(\n       function successCallback(response) {\n-        combinationExists(response.data.feed, _.get($scope, 'finaidYear.id'));\n-        setFinaidYear(response.data.feed, $routeParams.finaidYearId);","path":"src/assets/javascripts/angular/controllers/pages/finaidController.js","position":33,"original_position":33,"commit_id":"99f48685e740c796a73c14a8943555da4262d098","original_commit_id":"99f48685e740c796a73c14a8943555da4262d098","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars1.githubusercontent.com/u/12127480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"body":"Sorry @nkutub, I added a comment but I dunno if it was visible to you.  Won't be using the \"Start a review\" function anymore.\r\n\r\nWhy are these functions being removed?  These set the default finaid year in `finaidService`, which a lot of other cards depend on.  `combinationExists` also has important redirect logic for invalid aid years. ","created_at":"2018-02-21T23:34:15Z","updated_at":"2018-02-21T23:34:16Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6997#discussion_r169812758","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/169812758"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6997#discussion_r169812758"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997","id":169867399,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6997","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6997.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6997.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6997","number":6997,"state":"open","locked":false,"title":"SISRP-38686 - FinAId Title IV Response Page in CalCentral should NOT be Aid Year Specific","user":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-38686","created_at":"2018-02-19T02:22:51Z","updated_at":"2018-02-21T23:34:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe82929044449b25741a8917206248c9d84671f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6997/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/99f48685e740c796a73c14a8943555da4262d098","head":{"label":"nkutub:SISRP-38686","ref":"SISRP-38686","sha":"99f48685e740c796a73c14a8943555da4262d098","user":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"repo":{"id":63798985,"name":"calcentral","full_name":"nkutub/calcentral","owner":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkutub/calcentral","description":null,"fork":true,"url":"https://api.github.com/repos/nkutub/calcentral","forks_url":"https://api.github.com/repos/nkutub/calcentral/forks","keys_url":"https://api.github.com/repos/nkutub/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkutub/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkutub/calcentral/teams","hooks_url":"https://api.github.com/repos/nkutub/calcentral/hooks","issue_events_url":"https://api.github.com/repos/nkutub/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/nkutub/calcentral/events","assignees_url":"https://api.github.com/repos/nkutub/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/nkutub/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/nkutub/calcentral/tags","blobs_url":"https://api.github.com/repos/nkutub/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkutub/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkutub/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkutub/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkutub/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/nkutub/calcentral/languages","stargazers_url":"https://api.github.com/repos/nkutub/calcentral/stargazers","contributors_url":"https://api.github.com/repos/nkutub/calcentral/contributors","subscribers_url":"https://api.github.com/repos/nkutub/calcentral/subscribers","subscription_url":"https://api.github.com/repos/nkutub/calcentral/subscription","commits_url":"https://api.github.com/repos/nkutub/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkutub/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkutub/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkutub/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkutub/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/nkutub/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkutub/calcentral/merges","archive_url":"https://api.github.com/repos/nkutub/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkutub/calcentral/downloads","issues_url":"https://api.github.com/repos/nkutub/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/nkutub/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/nkutub/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/nkutub/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkutub/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/nkutub/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/nkutub/calcentral/deployments","created_at":"2016-07-20T16:58:40Z","updated_at":"2016-07-20T16:58:45Z","pushed_at":"2018-02-20T17:08:04Z","git_url":"git://github.com/nkutub/calcentral.git","ssh_url":"git@github.com:nkutub/calcentral.git","clone_url":"https://github.com/nkutub/calcentral.git","svn_url":"https://github.com/nkutub/calcentral","homepage":"https://calcentral.berkeley.edu","size":29620,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"fc990a89d91670a73e9d1890b2b75097acd745eb","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":null,"fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2018-02-12T22:45:27Z","pushed_at":"2018-02-21T23:09:41Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":29954,"stargazers_count":83,"watchers_count":83,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":68,"open_issues":4,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6997"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6997"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6997/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6997/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/99f48685e740c796a73c14a8943555da4262d098"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidlimcheng"}}