{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/osbs-client/issues/779","repository_url":"https://api.github.com/repos/projectatomic/osbs-client","labels_url":"https://api.github.com/repos/projectatomic/osbs-client/issues/779/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/osbs-client/issues/779/comments","events_url":"https://api.github.com/repos/projectatomic/osbs-client/issues/779/events","html_url":"https://github.com/projectatomic/osbs-client/pull/779","id":332688710,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTA4NTg0","number":779,"title":"Do not load the flatpak_create_plugin if we are not building a flatpak","user":{"login":"cverna","id":7237866,"node_id":"MDQ6VXNlcjcyMzc4NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7237866?v=4","gravatar_id":"","url":"https://api.github.com/users/cverna","html_url":"https://github.com/cverna","followers_url":"https://api.github.com/users/cverna/followers","following_url":"https://api.github.com/users/cverna/following{/other_user}","gists_url":"https://api.github.com/users/cverna/gists{/gist_id}","starred_url":"https://api.github.com/users/cverna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cverna/subscriptions","organizations_url":"https://api.github.com/users/cverna/orgs","repos_url":"https://api.github.com/users/cverna/repos","events_url":"https://api.github.com/users/cverna/events{/privacy}","received_events_url":"https://api.github.com/users/cverna/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-15T08:30:12Z","updated_at":"2018-06-19T13:49:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/projectatomic/osbs-client/pulls/779","html_url":"https://github.com/projectatomic/osbs-client/pull/779","diff_url":"https://github.com/projectatomic/osbs-client/pull/779.diff","patch_url":"https://github.com/projectatomic/osbs-client/pull/779.patch"},"body":"Without this we are trying to run the pre_flatpak_create_dockerfile plugin when trying to build normal containers.\r\n\r\nMaybe @mlangsdorf could review this and make sure this is a sane change.\r\n\r\nI ll be happy to work on some tests if I could get some pointers on which test to modify.\r\n\r\ncc'ing @owtaylor \r\n\r\nSigned-off-by: Clement Verna <cverna@tutanota.com>"},"comment":{"url":"https://api.github.com/repos/projectatomic/osbs-client/issues/comments/398405547","html_url":"https://github.com/projectatomic/osbs-client/pull/779#issuecomment-398405547","issue_url":"https://api.github.com/repos/projectatomic/osbs-client/issues/779","id":398405547,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQwNTU0Nw==","user":{"login":"cverna","id":7237866,"node_id":"MDQ6VXNlcjcyMzc4NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7237866?v=4","gravatar_id":"","url":"https://api.github.com/users/cverna","html_url":"https://github.com/cverna","followers_url":"https://api.github.com/users/cverna/followers","following_url":"https://api.github.com/users/cverna/following{/other_user}","gists_url":"https://api.github.com/users/cverna/gists{/gist_id}","starred_url":"https://api.github.com/users/cverna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cverna/subscriptions","organizations_url":"https://api.github.com/users/cverna/orgs","repos_url":"https://api.github.com/users/cverna/repos","events_url":"https://api.github.com/users/cverna/events{/privacy}","received_events_url":"https://api.github.com/users/cverna/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T13:49:39Z","updated_at":"2018-06-19T13:49:39Z","author_association":"NONE","body":"@mlangsdorf currently `flatpak = True and flatpak_base_image = Flase` is loading the `resolve_module_compose`.\r\n\r\nI am not 100% if this is correct or not, based on the `flatpak_create_dockerfile` plugin should we check if we have a `flatpak_base_image` before loading the plugin. "}}
{"actor":{"display_login":"cverna"}}