{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode-native/pulls/comments/166403821","pull_request_review_id":94460604,"id":166403821,"diff_hunk":"@@ -30,9 +30,8 @@ BEGIN_TEST(POOLFACTORY)\n   auto cacheFactory = CacheFactory();\n   auto cache = cacheFactory.create();\n   auto poolFactory = cache.getPoolManager().createFactory();\n-  ASSERT(poolFactory != nullptr, \"poolFactory was a nullptr\");\n-  auto& testPoolFactory = poolFactory->setSubscriptionEnabled(true);\n-  bool test = poolFactory.get() == std::addressof<PoolFactory>(testPoolFactory);\n+  auto& testPoolFactory = poolFactory.setSubscriptionEnabled(true);\n+  bool test = &poolFactory == std::addressof<PoolFactory>(testPoolFactory);","path":"cppcache/integration-test/testPoolFactory.cpp","position":8,"original_position":8,"commit_id":"54b29e463dc10678c24f0b1548b00e88e76e7931","original_commit_id":"54b29e463dc10678c24f0b1548b00e88e76e7931","user":{"login":"dgkimura","id":1569601,"avatar_url":"https://avatars0.githubusercontent.com/u/1569601?v=4","gravatar_id":"","url":"https://api.github.com/users/dgkimura","html_url":"https://github.com/dgkimura","followers_url":"https://api.github.com/users/dgkimura/followers","following_url":"https://api.github.com/users/dgkimura/following{/other_user}","gists_url":"https://api.github.com/users/dgkimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dgkimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgkimura/subscriptions","organizations_url":"https://api.github.com/users/dgkimura/orgs","repos_url":"https://api.github.com/users/dgkimura/repos","events_url":"https://api.github.com/users/dgkimura/events{/privacy}","received_events_url":"https://api.github.com/users/dgkimura/received_events","type":"User","site_admin":false},"body":"I had wondered this as well.  My interpretation is that this test is trying to assert that the fluent interface is returning the exact same object which is probably not how one would usually expect `operator==()` to work.  I am fine deleting this test if you agree that it has minimal value.","created_at":"2018-02-06T18:47:53Z","updated_at":"2018-02-06T18:47:53Z","html_url":"https://github.com/apache/geode-native/pull/208#discussion_r166403821","pull_request_url":"https://api.github.com/repos/apache/geode-native/pulls/208","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments/166403821"},"html":{"href":"https://github.com/apache/geode-native/pull/208#discussion_r166403821"},"pull_request":{"href":"https://api.github.com/repos/apache/geode-native/pulls/208"}},"in_reply_to_id":166393610},"pull_request":{"url":"https://api.github.com/repos/apache/geode-native/pulls/208","id":167441266,"html_url":"https://github.com/apache/geode-native/pull/208","diff_url":"https://github.com/apache/geode-native/pull/208.diff","patch_url":"https://github.com/apache/geode-native/pull/208.patch","issue_url":"https://api.github.com/repos/apache/geode-native/issues/208","number":208,"state":"open","locked":false,"title":"GEODE-4424: Refactor PoolManager::createFactory to return value","user":{"login":"mmartell","id":16687967,"avatar_url":"https://avatars0.githubusercontent.com/u/16687967?v=4","gravatar_id":"","url":"https://api.github.com/users/mmartell","html_url":"https://github.com/mmartell","followers_url":"https://api.github.com/users/mmartell/followers","following_url":"https://api.github.com/users/mmartell/following{/other_user}","gists_url":"https://api.github.com/users/mmartell/gists{/gist_id}","starred_url":"https://api.github.com/users/mmartell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmartell/subscriptions","organizations_url":"https://api.github.com/users/mmartell/orgs","repos_url":"https://api.github.com/users/mmartell/repos","events_url":"https://api.github.com/users/mmartell/events{/privacy}","received_events_url":"https://api.github.com/users/mmartell/received_events","type":"User","site_admin":false},"body":"Testing: Unit/integration tests passed on Mac and Windows","created_at":"2018-02-06T15:13:56Z","updated_at":"2018-02-06T18:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3759bf5dbe1b21f2d0d2ff0c1174dbee52c1172","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode-native/pulls/208/commits","review_comments_url":"https://api.github.com/repos/apache/geode-native/pulls/208/comments","review_comment_url":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode-native/issues/208/comments","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/54b29e463dc10678c24f0b1548b00e88e76e7931","head":{"label":"mmartell:feature/GEODE-4424","ref":"feature/GEODE-4424","sha":"54b29e463dc10678c24f0b1548b00e88e76e7931","user":{"login":"mmartell","id":16687967,"avatar_url":"https://avatars0.githubusercontent.com/u/16687967?v=4","gravatar_id":"","url":"https://api.github.com/users/mmartell","html_url":"https://github.com/mmartell","followers_url":"https://api.github.com/users/mmartell/followers","following_url":"https://api.github.com/users/mmartell/following{/other_user}","gists_url":"https://api.github.com/users/mmartell/gists{/gist_id}","starred_url":"https://api.github.com/users/mmartell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmartell/subscriptions","organizations_url":"https://api.github.com/users/mmartell/orgs","repos_url":"https://api.github.com/users/mmartell/repos","events_url":"https://api.github.com/users/mmartell/events{/privacy}","received_events_url":"https://api.github.com/users/mmartell/received_events","type":"User","site_admin":false},"repo":{"id":81501967,"name":"geode-native","full_name":"mmartell/geode-native","owner":{"login":"mmartell","id":16687967,"avatar_url":"https://avatars0.githubusercontent.com/u/16687967?v=4","gravatar_id":"","url":"https://api.github.com/users/mmartell","html_url":"https://github.com/mmartell","followers_url":"https://api.github.com/users/mmartell/followers","following_url":"https://api.github.com/users/mmartell/following{/other_user}","gists_url":"https://api.github.com/users/mmartell/gists{/gist_id}","starred_url":"https://api.github.com/users/mmartell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmartell/subscriptions","organizations_url":"https://api.github.com/users/mmartell/orgs","repos_url":"https://api.github.com/users/mmartell/repos","events_url":"https://api.github.com/users/mmartell/events{/privacy}","received_events_url":"https://api.github.com/users/mmartell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmartell/geode-native","description":"Mirror of Apache Geode native components","fork":true,"url":"https://api.github.com/repos/mmartell/geode-native","forks_url":"https://api.github.com/repos/mmartell/geode-native/forks","keys_url":"https://api.github.com/repos/mmartell/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmartell/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmartell/geode-native/teams","hooks_url":"https://api.github.com/repos/mmartell/geode-native/hooks","issue_events_url":"https://api.github.com/repos/mmartell/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/mmartell/geode-native/events","assignees_url":"https://api.github.com/repos/mmartell/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/mmartell/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/mmartell/geode-native/tags","blobs_url":"https://api.github.com/repos/mmartell/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmartell/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmartell/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmartell/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmartell/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mmartell/geode-native/languages","stargazers_url":"https://api.github.com/repos/mmartell/geode-native/stargazers","contributors_url":"https://api.github.com/repos/mmartell/geode-native/contributors","subscribers_url":"https://api.github.com/repos/mmartell/geode-native/subscribers","subscription_url":"https://api.github.com/repos/mmartell/geode-native/subscription","commits_url":"https://api.github.com/repos/mmartell/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmartell/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmartell/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmartell/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmartell/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/mmartell/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmartell/geode-native/merges","archive_url":"https://api.github.com/repos/mmartell/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmartell/geode-native/downloads","issues_url":"https://api.github.com/repos/mmartell/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/mmartell/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mmartell/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mmartell/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmartell/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/mmartell/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/mmartell/geode-native/deployments","created_at":"2017-02-09T22:37:58Z","updated_at":"2017-02-09T22:38:06Z","pushed_at":"2018-02-06T18:01:34Z","git_url":"git://github.com/mmartell/geode-native.git","ssh_url":"git@github.com:mmartell/geode-native.git","clone_url":"https://github.com/mmartell/geode-native.git","svn_url":"https://github.com/mmartell/geode-native","homepage":null,"size":16898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"2fb2d83d0ca38e0d7eecae81f3e69ab3bcdb1f35","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":80904111,"name":"geode-native","full_name":"apache/geode-native","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode-native","description":"Apache Geode native components","fork":false,"url":"https://api.github.com/repos/apache/geode-native","forks_url":"https://api.github.com/repos/apache/geode-native/forks","keys_url":"https://api.github.com/repos/apache/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode-native/teams","hooks_url":"https://api.github.com/repos/apache/geode-native/hooks","issue_events_url":"https://api.github.com/repos/apache/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode-native/events","assignees_url":"https://api.github.com/repos/apache/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode-native/tags","blobs_url":"https://api.github.com/repos/apache/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode-native/languages","stargazers_url":"https://api.github.com/repos/apache/geode-native/stargazers","contributors_url":"https://api.github.com/repos/apache/geode-native/contributors","subscribers_url":"https://api.github.com/repos/apache/geode-native/subscribers","subscription_url":"https://api.github.com/repos/apache/geode-native/subscription","commits_url":"https://api.github.com/repos/apache/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode-native/merges","archive_url":"https://api.github.com/repos/apache/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode-native/downloads","issues_url":"https://api.github.com/repos/apache/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode-native/deployments","created_at":"2017-02-04T08:00:06Z","updated_at":"2018-02-05T07:22:44Z","pushed_at":"2018-02-06T18:31:07Z","git_url":"git://github.com/apache/geode-native.git","ssh_url":"git@github.com:apache/geode-native.git","clone_url":"https://github.com/apache/geode-native.git","svn_url":"https://github.com/apache/geode-native","homepage":"","size":16879,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/208"},"html":{"href":"https://github.com/apache/geode-native/pull/208"},"issue":{"href":"https://api.github.com/repos/apache/geode-native/issues/208"},"comments":{"href":"https://api.github.com/repos/apache/geode-native/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode-native/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode-native/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode-native/statuses/54b29e463dc10678c24f0b1548b00e88e76e7931"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgkimura"}}