{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.io/pulls/comments/239998508","pull_request_review_id":182937506,"id":239998508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk5ODUwOA==","diff_hunk":"@@ -134,6 +134,42 @@ liveness-http-975595bb6-5b2z7c   2/2       Running   0           1m\n \n ### Mutual TLS is enabled\n \n+When Mutual TLS is enabled, we have two options to support HTTP probe, liveness probe rewrites and seperate port.\n+\n+#### Probe Rewrite\n+\n+This approache rewrites the application `PodSpec` liveness probe, such that the probe request will be sent to\n+sidecar. And the sidecar then redirects the request to application, and strip the response body only returning","path":"content/docs/tasks/traffic-management/app-health-check/index.md","position":9,"original_position":9,"commit_id":"9e0bbf3e078ba8c57d082dba62ff8ce96f3fbd5b","original_commit_id":"9e0bbf3e078ba8c57d082dba62ff8ce96f3fbd5b","user":{"login":"incfly","id":1661831,"node_id":"MDQ6VXNlcjE2NjE4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1661831?v=4","gravatar_id":"","url":"https://api.github.com/users/incfly","html_url":"https://github.com/incfly","followers_url":"https://api.github.com/users/incfly/followers","following_url":"https://api.github.com/users/incfly/following{/other_user}","gists_url":"https://api.github.com/users/incfly/gists{/gist_id}","starred_url":"https://api.github.com/users/incfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incfly/subscriptions","organizations_url":"https://api.github.com/users/incfly/orgs","repos_url":"https://api.github.com/users/incfly/repos","events_url":"https://api.github.com/users/incfly/events{/privacy}","received_events_url":"https://api.github.com/users/incfly/received_events","type":"User","site_admin":false},"body":"Actually I gave some thought about this. I originally was about to say `pilot agent`, however I'm not sure if that's a common concept to general istio users, or even we should expose that to them.","created_at":"2018-12-08T08:49:27Z","updated_at":"2018-12-08T08:49:27Z","html_url":"https://github.com/istio/istio.io/pull/2961#discussion_r239998508","pull_request_url":"https://api.github.com/repos/istio/istio.io/pulls/2961","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments/239998508"},"html":{"href":"https://github.com/istio/istio.io/pull/2961#discussion_r239998508"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2961"}},"in_reply_to_id":239998461},"pull_request":{"url":"https://api.github.com/repos/istio/istio.io/pulls/2961","id":237032366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDMyMzY2","html_url":"https://github.com/istio/istio.io/pull/2961","diff_url":"https://github.com/istio/istio.io/pull/2961.diff","patch_url":"https://github.com/istio/istio.io/pull/2961.patch","issue_url":"https://api.github.com/repos/istio/istio.io/issues/2961","number":2961,"state":"open","locked":false,"title":"Document the liveness health check rewrite.","user":{"login":"incfly","id":1661831,"node_id":"MDQ6VXNlcjE2NjE4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1661831?v=4","gravatar_id":"","url":"https://api.github.com/users/incfly","html_url":"https://github.com/incfly","followers_url":"https://api.github.com/users/incfly/followers","following_url":"https://api.github.com/users/incfly/following{/other_user}","gists_url":"https://api.github.com/users/incfly/gists{/gist_id}","starred_url":"https://api.github.com/users/incfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incfly/subscriptions","organizations_url":"https://api.github.com/users/incfly/orgs","repos_url":"https://api.github.com/users/incfly/repos","events_url":"https://api.github.com/users/incfly/events{/privacy}","received_events_url":"https://api.github.com/users/incfly/received_events","type":"User","site_admin":false},"body":"Documentation part for https://github.com/istio/istio/issues/9150\r\n\r\n/assign @wattli @mandarjog ","created_at":"2018-12-08T00:57:37Z","updated_at":"2018-12-08T08:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb1c90912d6d8f3ca2fba4d058ec084bd7f65ea7","assignee":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},{"login":"wattli","id":24381542,"node_id":"MDQ6VXNlcjI0MzgxNTQy","avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},{"login":"rcaballeromx","id":10066027,"node_id":"MDQ6VXNlcjEwMDY2MDI3","avatar_url":"https://avatars1.githubusercontent.com/u/10066027?v=4","gravatar_id":"","url":"https://api.github.com/users/rcaballeromx","html_url":"https://github.com/rcaballeromx","followers_url":"https://api.github.com/users/rcaballeromx/followers","following_url":"https://api.github.com/users/rcaballeromx/following{/other_user}","gists_url":"https://api.github.com/users/rcaballeromx/gists{/gist_id}","starred_url":"https://api.github.com/users/rcaballeromx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcaballeromx/subscriptions","organizations_url":"https://api.github.com/users/rcaballeromx/orgs","repos_url":"https://api.github.com/users/rcaballeromx/repos","events_url":"https://api.github.com/users/rcaballeromx/events{/privacy}","received_events_url":"https://api.github.com/users/rcaballeromx/received_events","type":"User","site_admin":false},{"login":"liminw","id":20001914,"node_id":"MDQ6VXNlcjIwMDAxOTE0","avatar_url":"https://avatars3.githubusercontent.com/u/20001914?v=4","gravatar_id":"","url":"https://api.github.com/users/liminw","html_url":"https://github.com/liminw","followers_url":"https://api.github.com/users/liminw/followers","following_url":"https://api.github.com/users/liminw/following{/other_user}","gists_url":"https://api.github.com/users/liminw/gists{/gist_id}","starred_url":"https://api.github.com/users/liminw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liminw/subscriptions","organizations_url":"https://api.github.com/users/liminw/orgs","repos_url":"https://api.github.com/users/liminw/repos","events_url":"https://api.github.com/users/liminw/events{/privacy}","received_events_url":"https://api.github.com/users/liminw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"node_id":"MDU6TGFiZWw4ODQyNDc0NzU=","url":"https://api.github.com/repos/istio/istio.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.io/pulls/2961/commits","review_comments_url":"https://api.github.com/repos/istio/istio.io/pulls/2961/comments","review_comment_url":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.io/issues/2961/comments","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/9e0bbf3e078ba8c57d082dba62ff8ce96f3fbd5b","head":{"label":"incfly:healthcheck","ref":"healthcheck","sha":"9e0bbf3e078ba8c57d082dba62ff8ce96f3fbd5b","user":{"login":"incfly","id":1661831,"node_id":"MDQ6VXNlcjE2NjE4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1661831?v=4","gravatar_id":"","url":"https://api.github.com/users/incfly","html_url":"https://github.com/incfly","followers_url":"https://api.github.com/users/incfly/followers","following_url":"https://api.github.com/users/incfly/following{/other_user}","gists_url":"https://api.github.com/users/incfly/gists{/gist_id}","starred_url":"https://api.github.com/users/incfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incfly/subscriptions","organizations_url":"https://api.github.com/users/incfly/orgs","repos_url":"https://api.github.com/users/incfly/repos","events_url":"https://api.github.com/users/incfly/events{/privacy}","received_events_url":"https://api.github.com/users/incfly/received_events","type":"User","site_admin":false},"repo":{"id":124001240,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwMDEyNDA=","name":"istio.github.io","full_name":"incfly/istio.github.io","private":false,"owner":{"login":"incfly","id":1661831,"node_id":"MDQ6VXNlcjE2NjE4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1661831?v=4","gravatar_id":"","url":"https://api.github.com/users/incfly","html_url":"https://github.com/incfly","followers_url":"https://api.github.com/users/incfly/followers","following_url":"https://api.github.com/users/incfly/following{/other_user}","gists_url":"https://api.github.com/users/incfly/gists{/gist_id}","starred_url":"https://api.github.com/users/incfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incfly/subscriptions","organizations_url":"https://api.github.com/users/incfly/orgs","repos_url":"https://api.github.com/users/incfly/repos","events_url":"https://api.github.com/users/incfly/events{/privacy}","received_events_url":"https://api.github.com/users/incfly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/incfly/istio.github.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/incfly/istio.github.io","forks_url":"https://api.github.com/repos/incfly/istio.github.io/forks","keys_url":"https://api.github.com/repos/incfly/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incfly/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incfly/istio.github.io/teams","hooks_url":"https://api.github.com/repos/incfly/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/incfly/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/incfly/istio.github.io/events","assignees_url":"https://api.github.com/repos/incfly/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/incfly/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/incfly/istio.github.io/tags","blobs_url":"https://api.github.com/repos/incfly/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incfly/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incfly/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/incfly/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incfly/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/incfly/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/incfly/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/incfly/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/incfly/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/incfly/istio.github.io/subscription","commits_url":"https://api.github.com/repos/incfly/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/incfly/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/incfly/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/incfly/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/incfly/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/incfly/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incfly/istio.github.io/merges","archive_url":"https://api.github.com/repos/incfly/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incfly/istio.github.io/downloads","issues_url":"https://api.github.com/repos/incfly/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/incfly/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/incfly/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/incfly/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incfly/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/incfly/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/incfly/istio.github.io/deployments","created_at":"2018-03-06T01:20:33Z","updated_at":"2018-06-21T01:12:15Z","pushed_at":"2018-12-08T00:54:45Z","git_url":"git://github.com/incfly/istio.github.io.git","ssh_url":"git@github.com:incfly/istio.github.io.git","clone_url":"https://github.com/incfly/istio.github.io.git","svn_url":"https://github.com/incfly/istio.github.io","homepage":"https://istio.io/","size":36361,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"10b0aa0b31c8b1436ef7be70af9052a5e7416fb0","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.io","full_name":"istio/istio.io","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.io","forks_url":"https://api.github.com/repos/istio/istio.io/forks","keys_url":"https://api.github.com/repos/istio/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.io/events","assignees_url":"https://api.github.com/repos/istio/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.io/merges","archive_url":"https://api.github.com/repos/istio/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-12-07T20:40:08Z","pushed_at":"2018-12-08T08:42:50Z","git_url":"git://github.com/istio/istio.io.git","ssh_url":"git@github.com:istio/istio.io.git","clone_url":"https://github.com/istio/istio.io.git","svn_url":"https://github.com/istio/istio.io","homepage":"https://istio.io/","size":38464,"stargazers_count":168,"watchers_count":168,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":410,"open_issues":98,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2961"},"html":{"href":"https://github.com/istio/istio.io/pull/2961"},"issue":{"href":"https://api.github.com/repos/istio/istio.io/issues/2961"},"comments":{"href":"https://api.github.com/repos/istio/istio.io/issues/2961/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2961/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2961/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.io/statuses/9e0bbf3e078ba8c57d082dba62ff8ce96f3fbd5b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"incfly"}}