{"action":"created","comment":{"url":"https://api.github.com/repos/ropensci/codemetar/pulls/comments/239443602","pull_request_review_id":182226910,"id":239443602,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTQ0MzYwMg==","diff_hunk":"@@ -0,0 +1,48 @@\n+# get_url_bioconductor_package -------------------------------------------------\n+get_url_bioconductor_package <- function(package) {\n+\n+  get_url_bioconductor_package_2(\"https://bioconductor.org\", package)\n+}\n+\n+# get_url_bioconductor_package_2 -----------------------------------------------\n+get_url_bioconductor_package_2 <- function(base_url, package) {","path":"R/get_url.R","position":8,"original_position":8,"commit_id":"6448628760ac02f9de105378003f7f9cc73e5d2e","original_commit_id":"6448628760ac02f9de105378003f7f9cc73e5d2e","user":{"login":"hsonne","id":11964315,"node_id":"MDQ6VXNlcjExOTY0MzE1","avatar_url":"https://avatars1.githubusercontent.com/u/11964315?v=4","gravatar_id":"","url":"https://api.github.com/users/hsonne","html_url":"https://github.com/hsonne","followers_url":"https://api.github.com/users/hsonne/followers","following_url":"https://api.github.com/users/hsonne/following{/other_user}","gists_url":"https://api.github.com/users/hsonne/gists{/gist_id}","starred_url":"https://api.github.com/users/hsonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsonne/subscriptions","organizations_url":"https://api.github.com/users/hsonne/orgs","repos_url":"https://api.github.com/users/hsonne/repos","events_url":"https://api.github.com/users/hsonne/events{/privacy}","received_events_url":"https://api.github.com/users/hsonne/received_events","type":"User","site_admin":false},"body":"Yes. However, I would like to do this later. I would like to work over the other code files from which I would like to extract all URL generating parts in a similar manner. Once this is done, and once it is clear in which ways URLs are put together, we can look over the helper functions again and combine/rename them as appropriate.","created_at":"2018-12-06T13:02:38Z","updated_at":"2018-12-06T13:02:38Z","html_url":"https://github.com/ropensci/codemetar/pull/207#discussion_r239443602","pull_request_url":"https://api.github.com/repos/ropensci/codemetar/pulls/207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/comments/239443602"},"html":{"href":"https://github.com/ropensci/codemetar/pull/207#discussion_r239443602"},"pull_request":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/207"}},"in_reply_to_id":239410391},"pull_request":{"url":"https://api.github.com/repos/ropensci/codemetar/pulls/207","id":236327942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzI3OTQy","html_url":"https://github.com/ropensci/codemetar/pull/207","diff_url":"https://github.com/ropensci/codemetar/pull/207.diff","patch_url":"https://github.com/ropensci/codemetar/pull/207.patch","issue_url":"https://api.github.com/repos/ropensci/codemetar/issues/207","number":207,"state":"open","locked":false,"title":"Clean the code in create_codemeta.R","user":{"login":"hsonne","id":11964315,"node_id":"MDQ6VXNlcjExOTY0MzE1","avatar_url":"https://avatars1.githubusercontent.com/u/11964315?v=4","gravatar_id":"","url":"https://api.github.com/users/hsonne","html_url":"https://github.com/hsonne","followers_url":"https://api.github.com/users/hsonne/followers","following_url":"https://api.github.com/users/hsonne/following{/other_user}","gists_url":"https://api.github.com/users/hsonne/gists{/gist_id}","starred_url":"https://api.github.com/users/hsonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsonne/subscriptions","organizations_url":"https://api.github.com/users/hsonne/orgs","repos_url":"https://api.github.com/users/hsonne/repos","events_url":"https://api.github.com/users/hsonne/events{/privacy}","received_events_url":"https://api.github.com/users/hsonne/received_events","type":"User","site_admin":false},"body":"Please consider my suggestions for cleaner code. I extracted parts of create_codemeta() into sub-functions, avoiding too deep nesting of if-else-statements. Now, there are only three closing curly braces (still too many) at the end of the function. In the original version there were eight! See my single commits for details. With the last commits I came back to parse_depends.R where I reused and continued the concepts that have resulted from previous cleaning steps. Looking forward to hearing your opinion! Kind regards, Hauke","created_at":"2018-12-05T21:26:08Z","updated_at":"2018-12-06T13:02:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"059db8574a6c2cde462138f8d9f1b00d81e2add0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ropensci/codemetar/pulls/207/commits","review_comments_url":"https://api.github.com/repos/ropensci/codemetar/pulls/207/comments","review_comment_url":"https://api.github.com/repos/ropensci/codemetar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ropensci/codemetar/issues/207/comments","statuses_url":"https://api.github.com/repos/ropensci/codemetar/statuses/6448628760ac02f9de105378003f7f9cc73e5d2e","head":{"label":"hsonne:clean/create","ref":"clean/create","sha":"6448628760ac02f9de105378003f7f9cc73e5d2e","user":{"login":"hsonne","id":11964315,"node_id":"MDQ6VXNlcjExOTY0MzE1","avatar_url":"https://avatars1.githubusercontent.com/u/11964315?v=4","gravatar_id":"","url":"https://api.github.com/users/hsonne","html_url":"https://github.com/hsonne","followers_url":"https://api.github.com/users/hsonne/followers","following_url":"https://api.github.com/users/hsonne/following{/other_user}","gists_url":"https://api.github.com/users/hsonne/gists{/gist_id}","starred_url":"https://api.github.com/users/hsonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsonne/subscriptions","organizations_url":"https://api.github.com/users/hsonne/orgs","repos_url":"https://api.github.com/users/hsonne/repos","events_url":"https://api.github.com/users/hsonne/events{/privacy}","received_events_url":"https://api.github.com/users/hsonne/received_events","type":"User","site_admin":false},"repo":{"id":160033177,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAwMzMxNzc=","name":"codemetar","full_name":"hsonne/codemetar","private":false,"owner":{"login":"hsonne","id":11964315,"node_id":"MDQ6VXNlcjExOTY0MzE1","avatar_url":"https://avatars1.githubusercontent.com/u/11964315?v=4","gravatar_id":"","url":"https://api.github.com/users/hsonne","html_url":"https://github.com/hsonne","followers_url":"https://api.github.com/users/hsonne/followers","following_url":"https://api.github.com/users/hsonne/following{/other_user}","gists_url":"https://api.github.com/users/hsonne/gists{/gist_id}","starred_url":"https://api.github.com/users/hsonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsonne/subscriptions","organizations_url":"https://api.github.com/users/hsonne/orgs","repos_url":"https://api.github.com/users/hsonne/repos","events_url":"https://api.github.com/users/hsonne/events{/privacy}","received_events_url":"https://api.github.com/users/hsonne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hsonne/codemetar","description":"an R package for generating and working with codemeta","fork":true,"url":"https://api.github.com/repos/hsonne/codemetar","forks_url":"https://api.github.com/repos/hsonne/codemetar/forks","keys_url":"https://api.github.com/repos/hsonne/codemetar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hsonne/codemetar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hsonne/codemetar/teams","hooks_url":"https://api.github.com/repos/hsonne/codemetar/hooks","issue_events_url":"https://api.github.com/repos/hsonne/codemetar/issues/events{/number}","events_url":"https://api.github.com/repos/hsonne/codemetar/events","assignees_url":"https://api.github.com/repos/hsonne/codemetar/assignees{/user}","branches_url":"https://api.github.com/repos/hsonne/codemetar/branches{/branch}","tags_url":"https://api.github.com/repos/hsonne/codemetar/tags","blobs_url":"https://api.github.com/repos/hsonne/codemetar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hsonne/codemetar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hsonne/codemetar/git/refs{/sha}","trees_url":"https://api.github.com/repos/hsonne/codemetar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hsonne/codemetar/statuses/{sha}","languages_url":"https://api.github.com/repos/hsonne/codemetar/languages","stargazers_url":"https://api.github.com/repos/hsonne/codemetar/stargazers","contributors_url":"https://api.github.com/repos/hsonne/codemetar/contributors","subscribers_url":"https://api.github.com/repos/hsonne/codemetar/subscribers","subscription_url":"https://api.github.com/repos/hsonne/codemetar/subscription","commits_url":"https://api.github.com/repos/hsonne/codemetar/commits{/sha}","git_commits_url":"https://api.github.com/repos/hsonne/codemetar/git/commits{/sha}","comments_url":"https://api.github.com/repos/hsonne/codemetar/comments{/number}","issue_comment_url":"https://api.github.com/repos/hsonne/codemetar/issues/comments{/number}","contents_url":"https://api.github.com/repos/hsonne/codemetar/contents/{+path}","compare_url":"https://api.github.com/repos/hsonne/codemetar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hsonne/codemetar/merges","archive_url":"https://api.github.com/repos/hsonne/codemetar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hsonne/codemetar/downloads","issues_url":"https://api.github.com/repos/hsonne/codemetar/issues{/number}","pulls_url":"https://api.github.com/repos/hsonne/codemetar/pulls{/number}","milestones_url":"https://api.github.com/repos/hsonne/codemetar/milestones{/number}","notifications_url":"https://api.github.com/repos/hsonne/codemetar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hsonne/codemetar/labels{/name}","releases_url":"https://api.github.com/repos/hsonne/codemetar/releases{/id}","deployments_url":"https://api.github.com/repos/hsonne/codemetar/deployments","created_at":"2018-12-02T09:45:32Z","updated_at":"2018-12-04T20:08:13Z","pushed_at":"2018-12-06T12:42:38Z","git_url":"git://github.com/hsonne/codemetar.git","ssh_url":"git@github.com:hsonne/codemetar.git","clone_url":"https://github.com/hsonne/codemetar.git","svn_url":"https://github.com/hsonne/codemetar","homepage":"https://codemeta.github.io/codemetar","size":1030,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ropensci:dev","ref":"dev","sha":"543a48ddfc125854903b45ca5f04dfff6a21fe6b","user":{"login":"ropensci","id":1200269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDAyNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1200269?v=4","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":86626030,"node_id":"MDEwOlJlcG9zaXRvcnk4NjYyNjAzMA==","name":"codemetar","full_name":"ropensci/codemetar","private":false,"owner":{"login":"ropensci","id":1200269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDAyNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1200269?v=4","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ropensci/codemetar","description":"an R package for generating and working with codemeta","fork":false,"url":"https://api.github.com/repos/ropensci/codemetar","forks_url":"https://api.github.com/repos/ropensci/codemetar/forks","keys_url":"https://api.github.com/repos/ropensci/codemetar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/codemetar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/codemetar/teams","hooks_url":"https://api.github.com/repos/ropensci/codemetar/hooks","issue_events_url":"https://api.github.com/repos/ropensci/codemetar/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/codemetar/events","assignees_url":"https://api.github.com/repos/ropensci/codemetar/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/codemetar/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/codemetar/tags","blobs_url":"https://api.github.com/repos/ropensci/codemetar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/codemetar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/codemetar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/codemetar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/codemetar/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/codemetar/languages","stargazers_url":"https://api.github.com/repos/ropensci/codemetar/stargazers","contributors_url":"https://api.github.com/repos/ropensci/codemetar/contributors","subscribers_url":"https://api.github.com/repos/ropensci/codemetar/subscribers","subscription_url":"https://api.github.com/repos/ropensci/codemetar/subscription","commits_url":"https://api.github.com/repos/ropensci/codemetar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/codemetar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/codemetar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/codemetar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ropensci/codemetar/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/codemetar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/codemetar/merges","archive_url":"https://api.github.com/repos/ropensci/codemetar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/codemetar/downloads","issues_url":"https://api.github.com/repos/ropensci/codemetar/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/codemetar/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/codemetar/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/codemetar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/codemetar/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/codemetar/releases{/id}","deployments_url":"https://api.github.com/repos/ropensci/codemetar/deployments","created_at":"2017-03-29T20:23:39Z","updated_at":"2018-12-05T09:29:22Z","pushed_at":"2018-12-06T12:42:39Z","git_url":"git://github.com/ropensci/codemetar.git","ssh_url":"git@github.com:ropensci/codemetar.git","clone_url":"https://github.com/ropensci/codemetar.git","svn_url":"https://github.com/ropensci/codemetar","homepage":"https://codemeta.github.io/codemetar","size":1077,"stargazers_count":26,"watchers_count":26,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":9,"open_issues":32,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/207"},"html":{"href":"https://github.com/ropensci/codemetar/pull/207"},"issue":{"href":"https://api.github.com/repos/ropensci/codemetar/issues/207"},"comments":{"href":"https://api.github.com/repos/ropensci/codemetar/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ropensci/codemetar/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/ropensci/codemetar/statuses/6448628760ac02f9de105378003f7f9cc73e5d2e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hsonne"}}