{"action":"created","comment":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/180825793","pull_request_review_id":111316393,"id":180825793,"diff_hunk":"@@ -38,6 +38,19 @@ public class PuppeteerLaunchTests : PuppeteerBaseTest\n             }\n         }\n \n+        [Fact]\n+        public async Task ShouldWorkInRealLifeWithOptions()\n+        {\n+            var options = TestConstants.DefaultBrowserOptions();\n+\n+            using (var browser = await PuppeteerSharp.Puppeteer.LaunchAsync(options, TestConstants.ChromiumRevision))\n+            using (var page = await browser.NewPageAsync())\n+            {\n+                var response = await page.GoToAsync(\"https://www.google.com\", new NavigationOptions() { Timeout = 5000, WaitUntil = new[] { \"networkidle0\" } });","path":"lib/PuppeteerSharp.Tests/Puppeteer/PuppeteerLaunchTests.cs","position":12,"original_position":12,"commit_id":"59d7a43d89bf1396272e1531da41bf3e903f453a","original_commit_id":"59d7a43d89bf1396272e1531da41bf3e903f453a","user":{"login":"cdroulers","id":708798,"avatar_url":"https://avatars0.githubusercontent.com/u/708798?v=4","gravatar_id":"","url":"https://api.github.com/users/cdroulers","html_url":"https://github.com/cdroulers","followers_url":"https://api.github.com/users/cdroulers/followers","following_url":"https://api.github.com/users/cdroulers/following{/other_user}","gists_url":"https://api.github.com/users/cdroulers/gists{/gist_id}","starred_url":"https://api.github.com/users/cdroulers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdroulers/subscriptions","organizations_url":"https://api.github.com/users/cdroulers/orgs","repos_url":"https://api.github.com/users/cdroulers/repos","events_url":"https://api.github.com/users/cdroulers/events{/privacy}","received_events_url":"https://api.github.com/users/cdroulers/received_events","type":"User","site_admin":false},"body":"Stylecop recommends putting each parameter on its own line in that case, is that ok?\r\n\r\n```csharp\r\n                var response = await page.GoToAsync(\r\n                    \"https://www.google.com\",\r\n                    new NavigationOptions()\r\n                    {\r\n                        Timeout = 5000,\r\n                        WaitUntil = new[] { \"networkidle0\" }\r\n                    });\r\n```","created_at":"2018-04-11T16:54:51Z","updated_at":"2018-04-11T16:54:51Z","html_url":"https://github.com/kblok/puppeteer-sharp/pull/129#discussion_r180825793","pull_request_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/180825793"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/129#discussion_r180825793"},"pull_request":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129"}},"in_reply_to_id":180809358},"pull_request":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129","id":180951459,"html_url":"https://github.com/kblok/puppeteer-sharp/pull/129","diff_url":"https://github.com/kblok/puppeteer-sharp/pull/129.diff","patch_url":"https://github.com/kblok/puppeteer-sharp/pull/129.patch","issue_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/129","number":129,"state":"open","locked":false,"title":"Make navigation options all public!","user":{"login":"cdroulers","id":708798,"avatar_url":"https://avatars0.githubusercontent.com/u/708798?v=4","gravatar_id":"","url":"https://api.github.com/users/cdroulers","html_url":"https://github.com/cdroulers","followers_url":"https://api.github.com/users/cdroulers/followers","following_url":"https://api.github.com/users/cdroulers/following{/other_user}","gists_url":"https://api.github.com/users/cdroulers/gists{/gist_id}","starred_url":"https://api.github.com/users/cdroulers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdroulers/subscriptions","organizations_url":"https://api.github.com/users/cdroulers/orgs","repos_url":"https://api.github.com/users/cdroulers/repos","events_url":"https://api.github.com/users/cdroulers/events{/privacy}","received_events_url":"https://api.github.com/users/cdroulers/received_events","type":"User","site_admin":false},"body":"Add at least one test that uses the options!","created_at":"2018-04-11T15:56:36Z","updated_at":"2018-04-11T16:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"180d4d6ee2a0b376e94b730f2fa3c6d2f2d2e7c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129/commits","review_comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129/comments","review_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/129/comments","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/59d7a43d89bf1396272e1531da41bf3e903f453a","head":{"label":"akinoxsolutions:master","ref":"master","sha":"59d7a43d89bf1396272e1531da41bf3e903f453a","user":{"login":"akinoxsolutions","id":13718639,"avatar_url":"https://avatars0.githubusercontent.com/u/13718639?v=4","gravatar_id":"","url":"https://api.github.com/users/akinoxsolutions","html_url":"https://github.com/akinoxsolutions","followers_url":"https://api.github.com/users/akinoxsolutions/followers","following_url":"https://api.github.com/users/akinoxsolutions/following{/other_user}","gists_url":"https://api.github.com/users/akinoxsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/akinoxsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akinoxsolutions/subscriptions","organizations_url":"https://api.github.com/users/akinoxsolutions/orgs","repos_url":"https://api.github.com/users/akinoxsolutions/repos","events_url":"https://api.github.com/users/akinoxsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/akinoxsolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":129110582,"name":"puppeteer-sharp","full_name":"akinoxsolutions/puppeteer-sharp","owner":{"login":"akinoxsolutions","id":13718639,"avatar_url":"https://avatars0.githubusercontent.com/u/13718639?v=4","gravatar_id":"","url":"https://api.github.com/users/akinoxsolutions","html_url":"https://github.com/akinoxsolutions","followers_url":"https://api.github.com/users/akinoxsolutions/followers","following_url":"https://api.github.com/users/akinoxsolutions/following{/other_user}","gists_url":"https://api.github.com/users/akinoxsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/akinoxsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akinoxsolutions/subscriptions","organizations_url":"https://api.github.com/users/akinoxsolutions/orgs","repos_url":"https://api.github.com/users/akinoxsolutions/repos","events_url":"https://api.github.com/users/akinoxsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/akinoxsolutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akinoxsolutions/puppeteer-sharp","description":"Headless Chrome .NET API","fork":true,"url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp","forks_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/akinoxsolutions/puppeteer-sharp/deployments","created_at":"2018-04-11T14:56:03Z","updated_at":"2018-04-11T15:53:00Z","pushed_at":"2018-04-11T15:52:59Z","git_url":"git://github.com/akinoxsolutions/puppeteer-sharp.git","ssh_url":"git@github.com:akinoxsolutions/puppeteer-sharp.git","clone_url":"https://github.com/akinoxsolutions/puppeteer-sharp.git","svn_url":"https://github.com/akinoxsolutions/puppeteer-sharp","homepage":null,"size":423,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kblok:master","ref":"master","sha":"7da573d11713e6e2be64302b0a08d392278f6c8d","user":{"login":"kblok","id":2198466,"avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"repo":{"id":105399035,"name":"puppeteer-sharp","full_name":"kblok/puppeteer-sharp","owner":{"login":"kblok","id":2198466,"avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kblok/puppeteer-sharp","description":"Headless Chrome .NET API","fork":false,"url":"https://api.github.com/repos/kblok/puppeteer-sharp","forks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/kblok/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kblok/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kblok/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/kblok/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/kblok/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/kblok/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kblok/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/kblok/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kblok/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/kblok/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/kblok/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kblok/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/kblok/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/deployments","created_at":"2017-09-30T20:32:25Z","updated_at":"2018-04-11T12:18:07Z","pushed_at":"2018-04-11T16:44:27Z","git_url":"git://github.com/kblok/puppeteer-sharp.git","ssh_url":"git@github.com:kblok/puppeteer-sharp.git","clone_url":"https://github.com/kblok/puppeteer-sharp.git","svn_url":"https://github.com/kblok/puppeteer-sharp","homepage":null,"size":422,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":57,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/129"},"issue":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/129"},"comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/59d7a43d89bf1396272e1531da41bf3e903f453a"}},"author_association":"NONE"}}
{"actor":{"display_login":"cdroulers"}}