{"action":"created","issue":{"url":"https://api.github.com/repos/theislab/scanpy/issues/358","repository_url":"https://api.github.com/repos/theislab/scanpy","labels_url":"https://api.github.com/repos/theislab/scanpy/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/theislab/scanpy/issues/358/comments","events_url":"https://api.github.com/repos/theislab/scanpy/issues/358/events","html_url":"https://github.com/theislab/scanpy/pull/358","id":379612514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDExOTY4","number":358,"title":"qc_metrics update","user":{"login":"ivirshup","id":8238804,"node_id":"MDQ6VXNlcjgyMzg4MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8238804?v=4","gravatar_id":"","url":"https://api.github.com/users/ivirshup","html_url":"https://github.com/ivirshup","followers_url":"https://api.github.com/users/ivirshup/followers","following_url":"https://api.github.com/users/ivirshup/following{/other_user}","gists_url":"https://api.github.com/users/ivirshup/gists{/gist_id}","starred_url":"https://api.github.com/users/ivirshup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivirshup/subscriptions","organizations_url":"https://api.github.com/users/ivirshup/orgs","repos_url":"https://api.github.com/users/ivirshup/repos","events_url":"https://api.github.com/users/ivirshup/events{/privacy}","received_events_url":"https://api.github.com/users/ivirshup/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-12T04:03:56Z","updated_at":"2018-11-12T19:48:33Z","closed_at":"2018-11-12T19:48:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/theislab/scanpy/pulls/358","html_url":"https://github.com/theislab/scanpy/pull/358","diff_url":"https://github.com/theislab/scanpy/pull/358.diff","patch_url":"https://github.com/theislab/scanpy/pull/358.patch"},"body":"Following on discussion from #316, I've renamed a number of arguments and metrics. Additionally I've optimized a bit for memory usage.\r\n\r\nChanges to naming can be summarized as follows:\r\n\r\n| current | proposed |\r\n| ------- | -------- |\r\n|`total_features_by_{expr_values}` | `n_{var_type}_by_{expr_type}`|\r\n|`total_{expr_values}` | `total_{expr_type}`|\r\n|`pct_{expr_values}_in_top_{n}_features` | `pct_{expr_type}_in_top_{n}_{var_type}`|\r\n|`total_{expr_values}_{feature_control}` | `total_{expr_type}_{qc_var}`|\r\n|`pct_{expr_values}_{feature_control}` | `pct_{expr_type}_{qc_var}`|\r\n| | |\r\n|`total_{expr_values}` | `total_{expr_type}`|\r\n|`mean_{expr_values}` | `mean_{expr_type}`|\r\n|`n_cells_by_{expr_values}` | `n_cells_by_{expr_type}`|\r\n|`pct_dropout_by_{expr_values}` | `pct_dropout_by_{expr_type}`|\r\n\r\nI went with `qc_vars` over `control_vars` on the recommendation of a lab mate, since they are presumably variables which are important for quality control, but were not necessarily controlled."},"comment":{"url":"https://api.github.com/repos/theislab/scanpy/issues/comments/438006625","html_url":"https://github.com/theislab/scanpy/pull/358#issuecomment-438006625","issue_url":"https://api.github.com/repos/theislab/scanpy/issues/358","id":438006625,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAwNjYyNQ==","user":{"login":"falexwolf","id":16916678,"node_id":"MDQ6VXNlcjE2OTE2Njc4","avatar_url":"https://avatars1.githubusercontent.com/u/16916678?v=4","gravatar_id":"","url":"https://api.github.com/users/falexwolf","html_url":"https://github.com/falexwolf","followers_url":"https://api.github.com/users/falexwolf/followers","following_url":"https://api.github.com/users/falexwolf/following{/other_user}","gists_url":"https://api.github.com/users/falexwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/falexwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falexwolf/subscriptions","organizations_url":"https://api.github.com/users/falexwolf/orgs","repos_url":"https://api.github.com/users/falexwolf/repos","events_url":"https://api.github.com/users/falexwolf/events{/privacy}","received_events_url":"https://api.github.com/users/falexwolf/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T19:48:33Z","updated_at":"2018-11-12T19:48:33Z","author_association":"MEMBER","body":"PS: Don't worry about the tutorial, I'll move that into the Scanpy docs without images soon and update it there. Thank you!"}}
{"actor":{"display_login":"falexwolf"}}