{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/172928542","pull_request_review_id":102031276,"id":172928542,"diff_hunk":"@@ -115,6 +115,19 @@ time_label_day={number}d\n # in English, while \"Home\" should be localized matching the about:preferences\n # sidebar mozilla-central string for the panel that has preferences related to\n # what is shown for the homepage, new windows, and new tabs.\n+prefs_new_windows_tabs_header=New Windows and Tabs\n+prefs_new_windows_description=Choose what you see when you open your homepage, new windows, and new tabs.\n+\n+prefs_homepage_choice_label=Homepage and new windows:\n+prefs_newtab_choice_label=New tabs:\n+prefs_homepage_newtab_choice_1_firefox_home=Firefox Home\n+prefs_homepage_newtab_choice_2_custom=Custom URL(s)","path":"locales/en-US/strings.properties","position":10,"original_position":10,"commit_id":"bad96bba933de7843612ffa34667b1d04554c6fc","original_commit_id":"bad96bba933de7843612ffa34667b1d04554c6fc","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars3.githubusercontent.com/u/1455535?v=4","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"Ok, that sounds find to me","created_at":"2018-03-07T17:52:51Z","updated_at":"2018-03-07T17:52:51Z","html_url":"https://github.com/mozilla/activity-stream/pull/4027#discussion_r172928542","pull_request_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/172928542"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4027#discussion_r172928542"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027"}},"in_reply_to_id":172907755},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027","id":173508010,"html_url":"https://github.com/mozilla/activity-stream/pull/4027","diff_url":"https://github.com/mozilla/activity-stream/pull/4027.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/4027.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4027","number":4027,"state":"open","locked":false,"title":"(nobug): Add strings for New Windows and Tabs section of prefs","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars3.githubusercontent.com/u/1455535?v=4","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"These are additional strings for the New Windows and Tabs section of the new about:preferences section. Designs are here: https://mozilla.invisionapp.com/share/65FPNL9RH4V#/screens/280785532\r\n\r\n@flodolo UX has decided these are necessary in order to land the other sections of  about:preferences, however due to the fact we don't have much time left in 60 to implement it there's a good chance we will push landing the feature to 61. In your opinion would it be OK to export these now or is it better to wait?","created_at":"2018-03-07T16:41:34Z","updated_at":"2018-03-07T17:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d970dd1cb98d3ae70d24ad4441711302c8adde3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4027/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/bad96bba933de7843612ffa34667b1d04554c6fc","head":{"label":"k88hudson:more-preferences-strings","ref":"more-preferences-strings","sha":"bad96bba933de7843612ffa34667b1d04554c6fc","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars3.githubusercontent.com/u/1455535?v=4","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"repo":{"id":52153556,"name":"activity-stream","full_name":"k88hudson/activity-stream","owner":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars3.githubusercontent.com/u/1455535?v=4","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k88hudson/activity-stream","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/k88hudson/activity-stream","forks_url":"https://api.github.com/repos/k88hudson/activity-stream/forks","keys_url":"https://api.github.com/repos/k88hudson/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k88hudson/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k88hudson/activity-stream/teams","hooks_url":"https://api.github.com/repos/k88hudson/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/k88hudson/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/k88hudson/activity-stream/events","assignees_url":"https://api.github.com/repos/k88hudson/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/k88hudson/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/k88hudson/activity-stream/tags","blobs_url":"https://api.github.com/repos/k88hudson/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k88hudson/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k88hudson/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/k88hudson/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k88hudson/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/k88hudson/activity-stream/languages","stargazers_url":"https://api.github.com/repos/k88hudson/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/k88hudson/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/k88hudson/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/k88hudson/activity-stream/subscription","commits_url":"https://api.github.com/repos/k88hudson/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/k88hudson/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/k88hudson/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/k88hudson/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/k88hudson/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/k88hudson/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k88hudson/activity-stream/merges","archive_url":"https://api.github.com/repos/k88hudson/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k88hudson/activity-stream/downloads","issues_url":"https://api.github.com/repos/k88hudson/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/k88hudson/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/k88hudson/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/k88hudson/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k88hudson/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/k88hudson/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/k88hudson/activity-stream/deployments","created_at":"2016-02-20T13:02:48Z","updated_at":"2017-09-06T18:30:35Z","pushed_at":"2018-03-07T16:37:04Z","git_url":"git://github.com/k88hudson/activity-stream.git","ssh_url":"git@github.com:k88hudson/activity-stream.git","clone_url":"https://github.com/k88hudson/activity-stream.git","svn_url":"https://github.com/k88hudson/activity-stream","homepage":"","size":8663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"7536b339113448ab099b139cc6873076cfe8f1d1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":"A refreshed \"new tab page\" for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2018-03-07T16:55:12Z","pushed_at":"2018-03-07T16:55:16Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":8899,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":92,"open_issues":51,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4027"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4027"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4027/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4027/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/bad96bba933de7843612ffa34667b1d04554c6fc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"k88hudson"}}