{"action":"opened","number":2506,"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506","id":234673529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjczNTI5","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2506","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2506.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2506.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2506","number":2506,"state":"open","locked":false,"title":"Fix incorrect condition & event msg on retriable instance update failures","user":{"login":"luksa","id":823581,"node_id":"MDQ6VXNlcjgyMzU4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823581?v=4","gravatar_id":"","url":"https://api.github.com/users/luksa","html_url":"https://github.com/luksa","followers_url":"https://api.github.com/users/luksa/followers","following_url":"https://api.github.com/users/luksa/following{/other_user}","gists_url":"https://api.github.com/users/luksa/gists{/gist_id}","starred_url":"https://api.github.com/users/luksa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luksa/subscriptions","organizations_url":"https://api.github.com/users/luksa/orgs","repos_url":"https://api.github.com/users/luksa/repos","events_url":"https://api.github.com/users/luksa/events{/privacy}","received_events_url":"https://api.github.com/users/luksa/received_events","type":"User","site_admin":false},"body":"This PR is a \r\n - [x] Bug Fix\r\n\r\n**What this PR does / why we need it**:\r\nWhen the broker responds with a retriable failure on an instance update\r\nrequest, the controller sets the Ready condition's message (and also\r\nproduces an event with the same message) that says that the update\r\nwill NOT be retried, where, in fact, it will be.\r\n\r\nThis PR changes the message to \"will be retried\".\r\n\r\n\r\nMerge Checklist:\r\n - [ ] New feature \r\n   - [ ] Tests\r\n   - [ ] Documentation\r\n - [ ] SVCat CLI flag\r\n - [ ] Server Flag for config\r\n   - [ ] Chart changes\r\n   - [ ] removing a flag by marking deprecated and hiding to avoid\r\n         breaking the chart release and existing clients who provide a\r\n         flag that will get an error when they try to update\r\n","created_at":"2018-11-29T15:11:41Z","updated_at":"2018-11-29T15:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2506/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/9f0e04b4e88c422e67067456f558846422b00a71","head":{"label":"luksa:retriable_update_wrong_msg","ref":"retriable_update_wrong_msg","sha":"9f0e04b4e88c422e67067456f558846422b00a71","user":{"login":"luksa","id":823581,"node_id":"MDQ6VXNlcjgyMzU4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823581?v=4","gravatar_id":"","url":"https://api.github.com/users/luksa","html_url":"https://github.com/luksa","followers_url":"https://api.github.com/users/luksa/followers","following_url":"https://api.github.com/users/luksa/following{/other_user}","gists_url":"https://api.github.com/users/luksa/gists{/gist_id}","starred_url":"https://api.github.com/users/luksa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luksa/subscriptions","organizations_url":"https://api.github.com/users/luksa/orgs","repos_url":"https://api.github.com/users/luksa/repos","events_url":"https://api.github.com/users/luksa/events{/privacy}","received_events_url":"https://api.github.com/users/luksa/received_events","type":"User","site_admin":false},"repo":{"id":81081414,"node_id":"MDEwOlJlcG9zaXRvcnk4MTA4MTQxNA==","name":"service-catalog","full_name":"luksa/service-catalog","private":false,"owner":{"login":"luksa","id":823581,"node_id":"MDQ6VXNlcjgyMzU4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823581?v=4","gravatar_id":"","url":"https://api.github.com/users/luksa","html_url":"https://github.com/luksa","followers_url":"https://api.github.com/users/luksa/followers","following_url":"https://api.github.com/users/luksa/following{/other_user}","gists_url":"https://api.github.com/users/luksa/gists{/gist_id}","starred_url":"https://api.github.com/users/luksa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luksa/subscriptions","organizations_url":"https://api.github.com/users/luksa/orgs","repos_url":"https://api.github.com/users/luksa/repos","events_url":"https://api.github.com/users/luksa/events{/privacy}","received_events_url":"https://api.github.com/users/luksa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/luksa/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/luksa/service-catalog","forks_url":"https://api.github.com/repos/luksa/service-catalog/forks","keys_url":"https://api.github.com/repos/luksa/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luksa/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luksa/service-catalog/teams","hooks_url":"https://api.github.com/repos/luksa/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/luksa/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/luksa/service-catalog/events","assignees_url":"https://api.github.com/repos/luksa/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/luksa/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/luksa/service-catalog/tags","blobs_url":"https://api.github.com/repos/luksa/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luksa/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luksa/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/luksa/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luksa/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/luksa/service-catalog/languages","stargazers_url":"https://api.github.com/repos/luksa/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/luksa/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/luksa/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/luksa/service-catalog/subscription","commits_url":"https://api.github.com/repos/luksa/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/luksa/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/luksa/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/luksa/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/luksa/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/luksa/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luksa/service-catalog/merges","archive_url":"https://api.github.com/repos/luksa/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luksa/service-catalog/downloads","issues_url":"https://api.github.com/repos/luksa/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/luksa/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/luksa/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/luksa/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luksa/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/luksa/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/luksa/service-catalog/deployments","created_at":"2017-02-06T11:42:29Z","updated_at":"2017-02-06T11:42:31Z","pushed_at":"2018-11-29T15:10:07Z","git_url":"git://github.com/luksa/service-catalog.git","ssh_url":"git@github.com:luksa/service-catalog.git","clone_url":"https://github.com/luksa/service-catalog.git","svn_url":"https://github.com/luksa/service-catalog","homepage":"","size":105322,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"c4a32e4977da0d95eebc13f6e6d2a01fc2bb66e2","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"node_id":"MDEwOlJlcG9zaXRvcnk2ODAyNDI4OA==","name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","private":false,"owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2018-11-28T21:32:59Z","pushed_at":"2018-11-29T14:28:37Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"https://svc-cat.io","size":105186,"stargazers_count":651,"watchers_count":651,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":248,"open_issues":256,"watchers":651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/2506"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2506"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2506/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2506/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/9f0e04b4e88c422e67067456f558846422b00a71"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":95,"deletions":57,"changed_files":3}}
{"actor":{"display_login":"luksa"}}