{"action":"created","issue":{"url":"https://api.github.com/repos/tokio-rs/tokio/issues/750","repository_url":"https://api.github.com/repos/tokio-rs/tokio","labels_url":"https://api.github.com/repos/tokio-rs/tokio/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/tokio-rs/tokio/issues/750/comments","events_url":"https://api.github.com/repos/tokio-rs/tokio/issues/750/events","html_url":"https://github.com/tokio-rs/tokio/issues/750","id":379997292,"node_id":"MDU6SXNzdWUzNzk5OTcyOTI=","number":750,"title":"Performance regression in tokio-threadpool 0.1.8","user":{"login":"jsgf","id":147966,"node_id":"MDQ6VXNlcjE0Nzk2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/147966?v=4","gravatar_id":"","url":"https://api.github.com/users/jsgf","html_url":"https://github.com/jsgf","followers_url":"https://api.github.com/users/jsgf/followers","following_url":"https://api.github.com/users/jsgf/following{/other_user}","gists_url":"https://api.github.com/users/jsgf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsgf/subscriptions","organizations_url":"https://api.github.com/users/jsgf/orgs","repos_url":"https://api.github.com/users/jsgf/repos","events_url":"https://api.github.com/users/jsgf/events{/privacy}","received_events_url":"https://api.github.com/users/jsgf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-11-12T23:43:34Z","updated_at":"2018-11-29T19:49:57Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nThank you for reporting an issue.\r\n\r\nPlease fill in as much of the template below as you're able.\r\n-->\r\n\r\n## Version\r\ntokio 0.1.11\r\ntokio-codec 0.1.1\r\ntokio-core 0.1.17\r\ntokio-current-thread 0.1.3\r\ntokio-executor 0.1.5\r\ntokio-fs 0.1.4\r\ntokio-io 0.1.10\r\ntokio-openssl 0.2.1\r\ntokio-pool 0.1.0\r\ntokio-process 0.2.2\r\ntokio-proto 0.1.1\r\ntokio-reactor 0.1.6\r\ntokio-service 0.1.0\r\ntokio-signal 0.2.6\r\ntokio-tcp 0.1.2\r\ntokio-threadpool 0.1.8\r\ntokio-timer 0.1.2\r\ntokio-timer 0.2.7\r\ntokio-tls 0.1.4\r\ntokio-tls-api 0.1.20\r\ntokio-udp 0.1.2\r\ntokio-uds 0.1.7\r\ntokio-uds 0.2.3\r\n\r\n## Platform\r\n\r\nLinux, 64-bit.\r\n\r\n## Subcrates\r\n\r\ntokio-threadpool\r\n\r\n## Description\r\n\r\nOne of our tests shows a large performance regression (20x slowdown in p95 request latency; p75 is unchanged) with tokio-threadpool 0.1.8. Rolling just that crate back to 0.1.7 restores the original performance."},"comment":{"url":"https://api.github.com/repos/tokio-rs/tokio/issues/comments/442969496","html_url":"https://github.com/tokio-rs/tokio/issues/750#issuecomment-442969496","issue_url":"https://api.github.com/repos/tokio-rs/tokio/issues/750","id":442969496,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjk2OTQ5Ng==","user":{"login":"jsgf","id":147966,"node_id":"MDQ6VXNlcjE0Nzk2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/147966?v=4","gravatar_id":"","url":"https://api.github.com/users/jsgf","html_url":"https://github.com/jsgf","followers_url":"https://api.github.com/users/jsgf/followers","following_url":"https://api.github.com/users/jsgf/following{/other_user}","gists_url":"https://api.github.com/users/jsgf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsgf/subscriptions","organizations_url":"https://api.github.com/users/jsgf/orgs","repos_url":"https://api.github.com/users/jsgf/repos","events_url":"https://api.github.com/users/jsgf/events{/privacy}","received_events_url":"https://api.github.com/users/jsgf/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T19:49:57Z","updated_at":"2018-11-29T19:49:57Z","author_association":"NONE","body":"The revert is still useful. I'll make a PR.\r\n\r\n> @jsgf your project is OSS no? Is there any way to get a repro even if it is in a large system?\r\n\r\nIt's not usefully OSS right now. You can see a lot of the code at https://github.com/facebookexperimental/mononoke but it isn't buildable with standard tools, and doesn't have code for all the pieces you'd need (it uses bits of FB infra which we need to provide non-FB alternatives for)."}}
{"actor":{"display_login":"jsgf"}}