{"action":"created","issue":{"url":"https://api.github.com/repos/PyWavelets/pywt/issues/423","repository_url":"https://api.github.com/repos/PyWavelets/pywt","labels_url":"https://api.github.com/repos/PyWavelets/pywt/issues/423/labels{/name}","comments_url":"https://api.github.com/repos/PyWavelets/pywt/issues/423/comments","events_url":"https://api.github.com/repos/PyWavelets/pywt/issues/423/events","html_url":"https://github.com/PyWavelets/pywt/pull/423","id":360397226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjY2Mjc3","number":423,"title":"fix bug in FswavedecnResult.__setitem__ and improve docstrings","user":{"login":"grlee77","id":6528957,"node_id":"MDQ6VXNlcjY1Mjg5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/6528957?v=4","gravatar_id":"","url":"https://api.github.com/users/grlee77","html_url":"https://github.com/grlee77","followers_url":"https://api.github.com/users/grlee77/followers","following_url":"https://api.github.com/users/grlee77/following{/other_user}","gists_url":"https://api.github.com/users/grlee77/gists{/gist_id}","starred_url":"https://api.github.com/users/grlee77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlee77/subscriptions","organizations_url":"https://api.github.com/users/grlee77/orgs","repos_url":"https://api.github.com/users/grlee77/repos","events_url":"https://api.github.com/users/grlee77/events{/privacy}","received_events_url":"https://api.github.com/users/grlee77/received_events","type":"User","site_admin":false},"labels":[{"id":48909846,"node_id":"MDU6TGFiZWw0ODkwOTg0Ng==","url":"https://api.github.com/repos/PyWavelets/pywt/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-14T17:50:14Z","updated_at":"2018-09-15T18:07:02Z","closed_at":"2018-09-15T18:06:46Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/PyWavelets/pywt/pulls/423","html_url":"https://github.com/PyWavelets/pywt/pull/423","diff_url":"https://github.com/PyWavelets/pywt/pull/423.diff","patch_url":"https://github.com/PyWavelets/pywt/pull/423.patch"},"body":"There was a bug in the dtype check in the __setitem__ method of FswavedecnResult that prevents assigning modified coefficients. I think this probably warrants a 1.0.1 release to address.\r\n\r\nThe issue is that the user is supposed to be able to do something like:\r\n```Python\r\ndkey = (1, 2)\r\nresult[dkey] = modified_coeffs\r\n```\r\nA workaround in 1.0.0 is to do:\r\n```Python\r\nresult.coeffs[result._get_coef_sl(dkey)] = modified_coeffs\r\n``` \r\n\r\nThis PR also improves testing of the FswaverecnResult and makes a few docstring improvements.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PyWavelets/pywt/issues/comments/421609260","html_url":"https://github.com/PyWavelets/pywt/pull/423#issuecomment-421609260","issue_url":"https://api.github.com/repos/PyWavelets/pywt/issues/423","id":421609260,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTYwOTI2MA==","user":{"login":"rgommers","id":98330,"node_id":"MDQ6VXNlcjk4MzMw","avatar_url":"https://avatars3.githubusercontent.com/u/98330?v=4","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T18:07:02Z","updated_at":"2018-09-15T18:07:02Z","author_association":"MEMBER","body":"Okay thanks @grlee77 . LGTM, merged."}}
{"actor":{"display_login":"rgommers"}}