{"action":"created","issue":{"url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/120","repository_url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader","labels_url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/120/comments","events_url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/120/events","html_url":"https://github.com/ifcaro/Open-PS2-Loader/issues/120","id":345418026,"node_id":"MDU6SXNzdWUzNDU0MTgwMjY=","number":120,"title":"Merging GSM and PS2RD into OPL permanently - do we want it?","user":{"login":"sp193","id":3446348,"node_id":"MDQ6VXNlcjM0NDYzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3446348?v=4","gravatar_id":"","url":"https://api.github.com/users/sp193","html_url":"https://github.com/sp193","followers_url":"https://api.github.com/users/sp193/followers","following_url":"https://api.github.com/users/sp193/following{/other_user}","gists_url":"https://api.github.com/users/sp193/gists{/gist_id}","starred_url":"https://api.github.com/users/sp193/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sp193/subscriptions","organizations_url":"https://api.github.com/users/sp193/orgs","repos_url":"https://api.github.com/users/sp193/repos","events_url":"https://api.github.com/users/sp193/events{/privacy}","received_events_url":"https://api.github.com/users/sp193/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-28T04:38:03Z","updated_at":"2018-07-28T11:05:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Given that GSM and PS2RD can be disabled properly, do we not want to merge them into OPL permanently?\r\nThere will be less choices for the user, which gives increased simplicity.\r\n\r\nI know we previously had some concerns about why enabling/disabling some features seemed to affect games. But after Fatal Frame was fixed, I have this feeling the reason for the varying functionality (even GSM or PS2RD is not enabled for the game) must be related.\r\n\r\nFor the uninitiated: Fatal Frame has started working after a recent patch, which wipes all (close to what Sony does) registers so that the boot conditions will be always the same. I noted that the only visible difference between running the game with PS2RD built in or not, was the register content. There was also this bug whereby OPL would corrupt memory at 0x02000000.\r\nI actually dumped all memory to see if there are differences in the memory meant for the game, but no. There were differences, but they were in the stack area and the EE kernel.\r\n\r\nIf there are games that are still affected by whether we include these features (when disabled during runtime) or not, then I am sure it has got to do with a problem within the game itself. Even if we do sweep the issue under the rug by disabling these features, it might occur again whenever the EE core grows in size. So by this logic, I think it is okay to have these features built in.\r\n\r\nAs for VMC: I was told long ago that it can result in worse performance in some games, but I never figured out why. That is why I am not including VMC in this suggestion, although I guess we could if we reach a general consensus that it is okay.\r\nTechnically, the VMC module is also not loaded when that function is disabled. So the overhead might have just been related to the additional WaitSema() & SignalSema() calls that the VMC builds have. That was also a long time ago, before a lot of fixes and enhancements were made."},"comment":{"url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/comments/408599785","html_url":"https://github.com/ifcaro/Open-PS2-Loader/issues/120#issuecomment-408599785","issue_url":"https://api.github.com/repos/ifcaro/Open-PS2-Loader/issues/120","id":408599785,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODU5OTc4NQ==","user":{"login":"TnA-Plastic","id":26502586,"node_id":"MDQ6VXNlcjI2NTAyNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/26502586?v=4","gravatar_id":"","url":"https://api.github.com/users/TnA-Plastic","html_url":"https://github.com/TnA-Plastic","followers_url":"https://api.github.com/users/TnA-Plastic/followers","following_url":"https://api.github.com/users/TnA-Plastic/following{/other_user}","gists_url":"https://api.github.com/users/TnA-Plastic/gists{/gist_id}","starred_url":"https://api.github.com/users/TnA-Plastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TnA-Plastic/subscriptions","organizations_url":"https://api.github.com/users/TnA-Plastic/orgs","repos_url":"https://api.github.com/users/TnA-Plastic/repos","events_url":"https://api.github.com/users/TnA-Plastic/events{/privacy}","received_events_url":"https://api.github.com/users/TnA-Plastic/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T11:05:55Z","updated_at":"2018-07-28T11:05:55Z","author_association":"NONE","body":"While I am all for 'cutting down' on the compile-options AND also for implementing both features permanently, I would really like to see a 0.9.4-release before and thus a test of the crowd out there... If we encounter games, which still have incompatibility with one but not another build, then that might be a useful feature to keep. ;)"}}
{"actor":{"display_login":"TnA-Plastic"}}