{"action":"closed","number":20088,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/20088","id":241059588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDU5NTg4","html_url":"https://github.com/ampproject/amphtml/pull/20088","diff_url":"https://github.com/ampproject/amphtml/pull/20088.diff","patch_url":"https://github.com/ampproject/amphtml/pull/20088.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/20088","number":20088,"state":"closed","locked":false,"title":"🖍amp-consent: Added Additional Styling to amp-consent CMP UI","user":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"body":"realtes to #19969\r\n\r\nThis implements the [box-shadow from amp-sticky-ad](https://ampbyexample.com/components/amp-sticky-ad/), as well as some border radius on the amp-consent CMP Modal.\r\n\r\nThis was done per a design review, and suggested by @spacedino 😄 \r\n\r\n<img width=\"334\" alt=\"screen shot 2018-12-26 at 5 57 54 pm\" src=\"https://user-images.githubusercontent.com/1448289/50462142-23813680-0938-11e9-9489-a60d95c82207.png\">\r\n<img width=\"326\" alt=\"screen shot 2018-12-26 at 5 58 08 pm\" src=\"https://user-images.githubusercontent.com/1448289/50462143-23813680-0938-11e9-8eaa-796654ead9d0.png\">\r\n","created_at":"2018-12-27T02:01:25Z","updated_at":"2018-12-27T18:59:19Z","closed_at":"2018-12-27T18:59:19Z","merged_at":"2018-12-27T18:59:19Z","merge_commit_sha":"4bed1d71625f1bb00324b2810eb1ff3c05d04939","assignee":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},{"login":"spacedino","id":7339798,"node_id":"MDQ6VXNlcjczMzk3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7339798?v=4","gravatar_id":"","url":"https://api.github.com/users/spacedino","html_url":"https://github.com/spacedino","followers_url":"https://api.github.com/users/spacedino/followers","following_url":"https://api.github.com/users/spacedino/following{/other_user}","gists_url":"https://api.github.com/users/spacedino/gists{/gist_id}","starred_url":"https://api.github.com/users/spacedino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacedino/subscriptions","organizations_url":"https://api.github.com/users/spacedino/orgs","repos_url":"https://api.github.com/users/spacedino/repos","events_url":"https://api.github.com/users/spacedino/events{/privacy}","received_events_url":"https://api.github.com/users/spacedino/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20088/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20088/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/20088/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/db7ec249ee13c6db543f71b74a873bb69657707d","head":{"label":"torch2424:amp-consent-ui-styling-fixes","ref":"amp-consent-ui-styling-fixes","sha":"db7ec249ee13c6db543f71b74a873bb69657707d","user":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"repo":{"id":76588875,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU4ODg3NQ==","name":"amphtml","full_name":"torch2424/amphtml","private":false,"owner":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"html_url":"https://github.com/torch2424/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/torch2424/amphtml","forks_url":"https://api.github.com/repos/torch2424/amphtml/forks","keys_url":"https://api.github.com/repos/torch2424/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch2424/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch2424/amphtml/teams","hooks_url":"https://api.github.com/repos/torch2424/amphtml/hooks","issue_events_url":"https://api.github.com/repos/torch2424/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/torch2424/amphtml/events","assignees_url":"https://api.github.com/repos/torch2424/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/torch2424/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/torch2424/amphtml/tags","blobs_url":"https://api.github.com/repos/torch2424/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch2424/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch2424/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch2424/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch2424/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/torch2424/amphtml/languages","stargazers_url":"https://api.github.com/repos/torch2424/amphtml/stargazers","contributors_url":"https://api.github.com/repos/torch2424/amphtml/contributors","subscribers_url":"https://api.github.com/repos/torch2424/amphtml/subscribers","subscription_url":"https://api.github.com/repos/torch2424/amphtml/subscription","commits_url":"https://api.github.com/repos/torch2424/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch2424/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch2424/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch2424/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch2424/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/torch2424/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch2424/amphtml/merges","archive_url":"https://api.github.com/repos/torch2424/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch2424/amphtml/downloads","issues_url":"https://api.github.com/repos/torch2424/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/torch2424/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/torch2424/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/torch2424/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch2424/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/torch2424/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/torch2424/amphtml/deployments","created_at":"2016-12-15T19:22:04Z","updated_at":"2018-12-26T18:57:25Z","pushed_at":"2018-12-27T01:57:51Z","git_url":"git://github.com/torch2424/amphtml.git","ssh_url":"git@github.com:torch2424/amphtml.git","clone_url":"https://github.com/torch2424/amphtml.git","svn_url":"https://github.com/torch2424/amphtml","homepage":"https://ampproject.org","size":567163,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"ab482fa68f2d42df18e280bcea427883a8f4c926","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-12-27T15:13:22Z","pushed_at":"2018-12-27T18:59:19Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":567248,"stargazers_count":12255,"watchers_count":12255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2749,"mirror_url":null,"archived":false,"open_issues_count":1577,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2749,"open_issues":1577,"watchers":12255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20088"},"html":{"href":"https://github.com/ampproject/amphtml/pull/20088"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20088"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20088/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20088/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20088/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/db7ec249ee13c6db543f71b74a873bb69657707d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"torch2424"}}