{"action":"created","comment":{"url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/comments/180901009","pull_request_review_id":111406142,"id":180901009,"diff_hunk":"@@ -76,8 +84,8 @@ namespace cppcoro\n \t\ttemplate<typename REP, typename PERIOD>\n \t\t[[nodiscard]]\n \t\ttimed_schedule_operation schedule_after(\n-\t\t\tconst std::chrono::duration<REP, PERIOD>& delay,","path":"include/cppcoro/io_service.hpp","position":29,"original_position":29,"commit_id":"26e6c723c8c6fc3590b05c0a4cc4374b4d0f6401","original_commit_id":"26e6c723c8c6fc3590b05c0a4cc4374b4d0f6401","user":{"login":"neo5167","id":22897450,"avatar_url":"https://avatars0.githubusercontent.com/u/22897450?v=4","gravatar_id":"","url":"https://api.github.com/users/neo5167","html_url":"https://github.com/neo5167","followers_url":"https://api.github.com/users/neo5167/followers","following_url":"https://api.github.com/users/neo5167/following{/other_user}","gists_url":"https://api.github.com/users/neo5167/gists{/gist_id}","starred_url":"https://api.github.com/users/neo5167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo5167/subscriptions","organizations_url":"https://api.github.com/users/neo5167/orgs","repos_url":"https://api.github.com/users/neo5167/repos","events_url":"https://api.github.com/users/neo5167/events{/privacy}","received_events_url":"https://api.github.com/users/neo5167/received_events","type":"User","site_admin":false},"body":"Will circle back on this. I am fixing my editor to have the same whitespace language as yours.","created_at":"2018-04-11T21:16:34Z","updated_at":"2018-04-11T21:16:34Z","html_url":"https://github.com/lewissbaker/cppcoro/pull/64#discussion_r180901009","pull_request_url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/comments/180901009"},"html":{"href":"https://github.com/lewissbaker/cppcoro/pull/64#discussion_r180901009"},"pull_request":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64"}},"in_reply_to_id":167762287},"pull_request":{"url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64","id":165529405,"html_url":"https://github.com/lewissbaker/cppcoro/pull/64","diff_url":"https://github.com/lewissbaker/cppcoro/pull/64.diff","patch_url":"https://github.com/lewissbaker/cppcoro/pull/64.patch","issue_url":"https://api.github.com/repos/lewissbaker/cppcoro/issues/64","number":64,"state":"open","locked":false,"title":"support for linux scheduler and timer","user":{"login":"neo5167","id":22897450,"avatar_url":"https://avatars0.githubusercontent.com/u/22897450?v=4","gravatar_id":"","url":"https://api.github.com/users/neo5167","html_url":"https://github.com/neo5167","followers_url":"https://api.github.com/users/neo5167/followers","following_url":"https://api.github.com/users/neo5167/following{/other_user}","gists_url":"https://api.github.com/users/neo5167/gists{/gist_id}","starred_url":"https://api.github.com/users/neo5167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo5167/subscriptions","organizations_url":"https://api.github.com/users/neo5167/orgs","repos_url":"https://api.github.com/users/neo5167/repos","events_url":"https://api.github.com/users/neo5167/events{/privacy}","received_events_url":"https://api.github.com/users/neo5167/received_events","type":"User","site_admin":false},"body":"Linux support for scheduler and timer with epoll, timerfd, eventfd, and other such sundry stuff. I am restructuring the code with less ifdefs. But I want to do that with guidance from you guys. Also, its a fork of an older version. I am working rebasing it to something more recent as well. In this PR, please comment on how to structure the code so that we can move platform dependent stuff into something more manageable.","created_at":"2018-01-27T18:14:10Z","updated_at":"2018-04-11T21:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64/commits","review_comments_url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64/comments","review_comment_url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lewissbaker/cppcoro/issues/64/comments","statuses_url":"https://api.github.com/repos/lewissbaker/cppcoro/statuses/26e6c723c8c6fc3590b05c0a4cc4374b4d0f6401","head":{"label":"neo5167:linux_scheduler_timer_support","ref":"linux_scheduler_timer_support","sha":"26e6c723c8c6fc3590b05c0a4cc4374b4d0f6401","user":{"login":"neo5167","id":22897450,"avatar_url":"https://avatars0.githubusercontent.com/u/22897450?v=4","gravatar_id":"","url":"https://api.github.com/users/neo5167","html_url":"https://github.com/neo5167","followers_url":"https://api.github.com/users/neo5167/followers","following_url":"https://api.github.com/users/neo5167/following{/other_user}","gists_url":"https://api.github.com/users/neo5167/gists{/gist_id}","starred_url":"https://api.github.com/users/neo5167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo5167/subscriptions","organizations_url":"https://api.github.com/users/neo5167/orgs","repos_url":"https://api.github.com/users/neo5167/repos","events_url":"https://api.github.com/users/neo5167/events{/privacy}","received_events_url":"https://api.github.com/users/neo5167/received_events","type":"User","site_admin":false},"repo":{"id":119187918,"name":"cppcoro","full_name":"neo5167/cppcoro","owner":{"login":"neo5167","id":22897450,"avatar_url":"https://avatars0.githubusercontent.com/u/22897450?v=4","gravatar_id":"","url":"https://api.github.com/users/neo5167","html_url":"https://github.com/neo5167","followers_url":"https://api.github.com/users/neo5167/followers","following_url":"https://api.github.com/users/neo5167/following{/other_user}","gists_url":"https://api.github.com/users/neo5167/gists{/gist_id}","starred_url":"https://api.github.com/users/neo5167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo5167/subscriptions","organizations_url":"https://api.github.com/users/neo5167/orgs","repos_url":"https://api.github.com/users/neo5167/repos","events_url":"https://api.github.com/users/neo5167/events{/privacy}","received_events_url":"https://api.github.com/users/neo5167/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neo5167/cppcoro","description":"A library of C++ coroutine abstractions for the coroutines TS","fork":true,"url":"https://api.github.com/repos/neo5167/cppcoro","forks_url":"https://api.github.com/repos/neo5167/cppcoro/forks","keys_url":"https://api.github.com/repos/neo5167/cppcoro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo5167/cppcoro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo5167/cppcoro/teams","hooks_url":"https://api.github.com/repos/neo5167/cppcoro/hooks","issue_events_url":"https://api.github.com/repos/neo5167/cppcoro/issues/events{/number}","events_url":"https://api.github.com/repos/neo5167/cppcoro/events","assignees_url":"https://api.github.com/repos/neo5167/cppcoro/assignees{/user}","branches_url":"https://api.github.com/repos/neo5167/cppcoro/branches{/branch}","tags_url":"https://api.github.com/repos/neo5167/cppcoro/tags","blobs_url":"https://api.github.com/repos/neo5167/cppcoro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo5167/cppcoro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo5167/cppcoro/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo5167/cppcoro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo5167/cppcoro/statuses/{sha}","languages_url":"https://api.github.com/repos/neo5167/cppcoro/languages","stargazers_url":"https://api.github.com/repos/neo5167/cppcoro/stargazers","contributors_url":"https://api.github.com/repos/neo5167/cppcoro/contributors","subscribers_url":"https://api.github.com/repos/neo5167/cppcoro/subscribers","subscription_url":"https://api.github.com/repos/neo5167/cppcoro/subscription","commits_url":"https://api.github.com/repos/neo5167/cppcoro/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo5167/cppcoro/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo5167/cppcoro/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo5167/cppcoro/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo5167/cppcoro/contents/{+path}","compare_url":"https://api.github.com/repos/neo5167/cppcoro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo5167/cppcoro/merges","archive_url":"https://api.github.com/repos/neo5167/cppcoro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo5167/cppcoro/downloads","issues_url":"https://api.github.com/repos/neo5167/cppcoro/issues{/number}","pulls_url":"https://api.github.com/repos/neo5167/cppcoro/pulls{/number}","milestones_url":"https://api.github.com/repos/neo5167/cppcoro/milestones{/number}","notifications_url":"https://api.github.com/repos/neo5167/cppcoro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo5167/cppcoro/labels{/name}","releases_url":"https://api.github.com/repos/neo5167/cppcoro/releases{/id}","deployments_url":"https://api.github.com/repos/neo5167/cppcoro/deployments","created_at":"2018-01-27T17:50:36Z","updated_at":"2018-01-27T17:50:38Z","pushed_at":"2018-02-12T20:20:38Z","git_url":"git://github.com/neo5167/cppcoro.git","ssh_url":"git@github.com:neo5167/cppcoro.git","clone_url":"https://github.com/neo5167/cppcoro.git","svn_url":"https://github.com/neo5167/cppcoro","homepage":"","size":555,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lewissbaker:master","ref":"master","sha":"6ba0778c4efe2ac97fe18516c3bafb41ee6cf32e","user":{"login":"lewissbaker","id":211814,"avatar_url":"https://avatars1.githubusercontent.com/u/211814?v=4","gravatar_id":"","url":"https://api.github.com/users/lewissbaker","html_url":"https://github.com/lewissbaker","followers_url":"https://api.github.com/users/lewissbaker/followers","following_url":"https://api.github.com/users/lewissbaker/following{/other_user}","gists_url":"https://api.github.com/users/lewissbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/lewissbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewissbaker/subscriptions","organizations_url":"https://api.github.com/users/lewissbaker/orgs","repos_url":"https://api.github.com/users/lewissbaker/repos","events_url":"https://api.github.com/users/lewissbaker/events{/privacy}","received_events_url":"https://api.github.com/users/lewissbaker/received_events","type":"User","site_admin":false},"repo":{"id":85565658,"name":"cppcoro","full_name":"lewissbaker/cppcoro","owner":{"login":"lewissbaker","id":211814,"avatar_url":"https://avatars1.githubusercontent.com/u/211814?v=4","gravatar_id":"","url":"https://api.github.com/users/lewissbaker","html_url":"https://github.com/lewissbaker","followers_url":"https://api.github.com/users/lewissbaker/followers","following_url":"https://api.github.com/users/lewissbaker/following{/other_user}","gists_url":"https://api.github.com/users/lewissbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/lewissbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewissbaker/subscriptions","organizations_url":"https://api.github.com/users/lewissbaker/orgs","repos_url":"https://api.github.com/users/lewissbaker/repos","events_url":"https://api.github.com/users/lewissbaker/events{/privacy}","received_events_url":"https://api.github.com/users/lewissbaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lewissbaker/cppcoro","description":"A library of C++ coroutine abstractions for the coroutines TS","fork":false,"url":"https://api.github.com/repos/lewissbaker/cppcoro","forks_url":"https://api.github.com/repos/lewissbaker/cppcoro/forks","keys_url":"https://api.github.com/repos/lewissbaker/cppcoro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lewissbaker/cppcoro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lewissbaker/cppcoro/teams","hooks_url":"https://api.github.com/repos/lewissbaker/cppcoro/hooks","issue_events_url":"https://api.github.com/repos/lewissbaker/cppcoro/issues/events{/number}","events_url":"https://api.github.com/repos/lewissbaker/cppcoro/events","assignees_url":"https://api.github.com/repos/lewissbaker/cppcoro/assignees{/user}","branches_url":"https://api.github.com/repos/lewissbaker/cppcoro/branches{/branch}","tags_url":"https://api.github.com/repos/lewissbaker/cppcoro/tags","blobs_url":"https://api.github.com/repos/lewissbaker/cppcoro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lewissbaker/cppcoro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lewissbaker/cppcoro/git/refs{/sha}","trees_url":"https://api.github.com/repos/lewissbaker/cppcoro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lewissbaker/cppcoro/statuses/{sha}","languages_url":"https://api.github.com/repos/lewissbaker/cppcoro/languages","stargazers_url":"https://api.github.com/repos/lewissbaker/cppcoro/stargazers","contributors_url":"https://api.github.com/repos/lewissbaker/cppcoro/contributors","subscribers_url":"https://api.github.com/repos/lewissbaker/cppcoro/subscribers","subscription_url":"https://api.github.com/repos/lewissbaker/cppcoro/subscription","commits_url":"https://api.github.com/repos/lewissbaker/cppcoro/commits{/sha}","git_commits_url":"https://api.github.com/repos/lewissbaker/cppcoro/git/commits{/sha}","comments_url":"https://api.github.com/repos/lewissbaker/cppcoro/comments{/number}","issue_comment_url":"https://api.github.com/repos/lewissbaker/cppcoro/issues/comments{/number}","contents_url":"https://api.github.com/repos/lewissbaker/cppcoro/contents/{+path}","compare_url":"https://api.github.com/repos/lewissbaker/cppcoro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lewissbaker/cppcoro/merges","archive_url":"https://api.github.com/repos/lewissbaker/cppcoro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lewissbaker/cppcoro/downloads","issues_url":"https://api.github.com/repos/lewissbaker/cppcoro/issues{/number}","pulls_url":"https://api.github.com/repos/lewissbaker/cppcoro/pulls{/number}","milestones_url":"https://api.github.com/repos/lewissbaker/cppcoro/milestones{/number}","notifications_url":"https://api.github.com/repos/lewissbaker/cppcoro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lewissbaker/cppcoro/labels{/name}","releases_url":"https://api.github.com/repos/lewissbaker/cppcoro/releases{/id}","deployments_url":"https://api.github.com/repos/lewissbaker/cppcoro/deployments","created_at":"2017-03-20T10:48:10Z","updated_at":"2018-04-11T16:03:24Z","pushed_at":"2018-04-09T02:45:07Z","git_url":"git://github.com/lewissbaker/cppcoro.git","ssh_url":"git@github.com:lewissbaker/cppcoro.git","clone_url":"https://github.com/lewissbaker/cppcoro.git","svn_url":"https://github.com/lewissbaker/cppcoro","homepage":"","size":565,"stargazers_count":228,"watchers_count":228,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":27,"open_issues":38,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64"},"html":{"href":"https://github.com/lewissbaker/cppcoro/pull/64"},"issue":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/issues/64"},"comments":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/lewissbaker/cppcoro/statuses/26e6c723c8c6fc3590b05c0a4cc4374b4d0f6401"}},"author_association":"NONE"}}
{"actor":{"display_login":"neo5167"}}