{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/comments/199296855","pull_request_review_id":133397218,"id":199296855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTI5Njg1NQ==","diff_hunk":"@@ -0,0 +1,39 @@\n+function almostEquals(u, v, epsilon) {\n+  return Math.abs(u.x - v.x) < epsilon && Math.abs(u.y - v.y) < epsilon && Math.abs(u.z - v.z) < epsilon;\n+}\n+\n+function debounce(fn, delay) {","path":"src/components/auto-scale-cannon-physics-body.js","position":5,"original_position":5,"commit_id":"3a6db63db4ffb2649b941c50243e33d9fa34de78","original_commit_id":"3a6db63db4ffb2649b941c50243e33d9fa34de78","user":{"login":"johnshaughnessy","id":4072106,"node_id":"MDQ6VXNlcjQwNzIxMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4072106?v=4","gravatar_id":"","url":"https://api.github.com/users/johnshaughnessy","html_url":"https://github.com/johnshaughnessy","followers_url":"https://api.github.com/users/johnshaughnessy/followers","following_url":"https://api.github.com/users/johnshaughnessy/following{/other_user}","gists_url":"https://api.github.com/users/johnshaughnessy/gists{/gist_id}","starred_url":"https://api.github.com/users/johnshaughnessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnshaughnessy/subscriptions","organizations_url":"https://api.github.com/users/johnshaughnessy/orgs","repos_url":"https://api.github.com/users/johnshaughnessy/repos","events_url":"https://api.github.com/users/johnshaughnessy/events{/privacy}","received_events_url":"https://api.github.com/users/johnshaughnessy/received_events","type":"User","site_admin":false},"body":"going to rewrite it to avoid `debounce` because (I think) having the `debounced` function call `requestAnimationFrame` or `setTimeout` and `clearTimeout` rapidly is undesirable.","created_at":"2018-06-29T22:45:50Z","updated_at":"2018-06-29T22:45:51Z","html_url":"https://github.com/mozilla/hubs/pull/435#discussion_r199296855","pull_request_url":"https://api.github.com/repos/mozilla/hubs/pulls/435","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments/199296855"},"html":{"href":"https://github.com/mozilla/hubs/pull/435#discussion_r199296855"},"pull_request":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/435"}},"in_reply_to_id":199012876},"pull_request":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/435","id":196606629,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjA2NjI5","html_url":"https://github.com/mozilla/hubs/pull/435","diff_url":"https://github.com/mozilla/hubs/pull/435.diff","patch_url":"https://github.com/mozilla/hubs/pull/435.patch","issue_url":"https://api.github.com/repos/mozilla/hubs/issues/435","number":435,"state":"open","locked":false,"title":"Add the ability to spawn 3D models","user":{"login":"johnshaughnessy","id":4072106,"node_id":"MDQ6VXNlcjQwNzIxMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4072106?v=4","gravatar_id":"","url":"https://api.github.com/users/johnshaughnessy","html_url":"https://github.com/johnshaughnessy","followers_url":"https://api.github.com/users/johnshaughnessy/followers","following_url":"https://api.github.com/users/johnshaughnessy/following{/other_user}","gists_url":"https://api.github.com/users/johnshaughnessy/gists{/gist_id}","starred_url":"https://api.github.com/users/johnshaughnessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnshaughnessy/subscriptions","organizations_url":"https://api.github.com/users/johnshaughnessy/orgs","repos_url":"https://api.github.com/users/johnshaughnessy/repos","events_url":"https://api.github.com/users/johnshaughnessy/events{/privacy}","received_events_url":"https://api.github.com/users/johnshaughnessy/received_events","type":"User","site_admin":false},"body":"We use a capability introduced in our fork of `aframe-physics-system` in this PR: https://github.com/MozillaReality/aframe-physics-system/pull/1","created_at":"2018-06-22T00:00:32Z","updated_at":"2018-06-29T22:45:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86e87e4de9874bbc427752ff5881a305cd30a7dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/hubs/pulls/435/commits","review_comments_url":"https://api.github.com/repos/mozilla/hubs/pulls/435/comments","review_comment_url":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/hubs/issues/435/comments","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/3a6db63db4ffb2649b941c50243e33d9fa34de78","head":{"label":"mozilla:feature/paste-models","ref":"feature/paste-models","sha":"3a6db63db4ffb2649b941c50243e33d9fa34de78","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/hubs","description":"A prototype client demonstrating a multi-user experience in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2018-06-28T23:15:55Z","pushed_at":"2018-06-29T19:37:15Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":77223,"stargazers_count":109,"watchers_count":109,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":77,"watchers":109,"default_branch":"master"}},"base":{"label":"mozilla:feature/image-interactables","ref":"feature/image-interactables","sha":"660d4469bd88d5391721ea44dfad2e3cdde84d3c","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/hubs","description":"A prototype client demonstrating a multi-user experience in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2018-06-28T23:15:55Z","pushed_at":"2018-06-29T19:37:15Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":77223,"stargazers_count":109,"watchers_count":109,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":77,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/435"},"html":{"href":"https://github.com/mozilla/hubs/pull/435"},"issue":{"href":"https://api.github.com/repos/mozilla/hubs/issues/435"},"comments":{"href":"https://api.github.com/repos/mozilla/hubs/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/hubs/statuses/3a6db63db4ffb2649b941c50243e33d9fa34de78"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"johnshaughnessy"}}