{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/kanakb/pyhelix/pulls/25","id":142228041,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQyMjI4MDQx","html_url":"https://github.com/kanakb/pyhelix/pull/25","diff_url":"https://github.com/kanakb/pyhelix/pull/25.diff","patch_url":"https://github.com/kanakb/pyhelix/pull/25.patch","issue_url":"https://api.github.com/repos/kanakb/pyhelix/issues/25","number":25,"state":"closed","locked":false,"title":"Fix initialization of new instances by avoiding a TypeError","user":{"login":"jrgp","id":472066,"node_id":"MDQ6VXNlcjQ3MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/472066?v=4","gravatar_id":"","url":"https://api.github.com/users/jrgp","html_url":"https://github.com/jrgp","followers_url":"https://api.github.com/users/jrgp/followers","following_url":"https://api.github.com/users/jrgp/following{/other_user}","gists_url":"https://api.github.com/users/jrgp/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgp/subscriptions","organizations_url":"https://api.github.com/users/jrgp/orgs","repos_url":"https://api.github.com/users/jrgp/repos","events_url":"https://api.github.com/users/jrgp/events{/privacy}","received_events_url":"https://api.github.com/users/jrgp/received_events","type":"User","site_admin":false},"body":"Problem:\r\n\r\n1) When we start this on a new instance, it will check to see if\r\n   CONFIGS/PARTICIPANT/{host} exists. If it doesn't, it proceeds\r\n   to create all of the needed znodes under INSTANCES/{host}\r\n\r\n2) As it tries creating the nodes under INSTANCES/{host}, one of\r\n   the functions it uses raises TypeError as it wasn't passed enough\r\n   arguments.\r\n\r\n3) As 1 already ran, the needed nodes under INSTANCES/{host} will\r\n   never exist, which is what leads to us needing to manually create\r\n   them to avoid a NoNodeError.\r\n\r\nFix:\r\n\r\n- Fix the keybuilder `errors` helper as it looks to be a broken copy/paste\r\n  problem, in that it's identical to `error` and only used in this one\r\n  spot.","created_at":"2017-09-20T23:48:38Z","updated_at":"2018-12-20T07:33:57Z","closed_at":"2018-12-20T07:33:57Z","merged_at":"2018-12-20T07:33:56Z","merge_commit_sha":"10b51b278f6cb4a64841bd6b54f47a02bb908095","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kanakb/pyhelix/pulls/25/commits","review_comments_url":"https://api.github.com/repos/kanakb/pyhelix/pulls/25/comments","review_comment_url":"https://api.github.com/repos/kanakb/pyhelix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kanakb/pyhelix/issues/25/comments","statuses_url":"https://api.github.com/repos/kanakb/pyhelix/statuses/70cd40a96b886866f2e29a011889d6cc39c8219c","head":{"label":"jrgp:fix_typerror_upon_initialization","ref":"fix_typerror_upon_initialization","sha":"70cd40a96b886866f2e29a011889d6cc39c8219c","user":{"login":"jrgp","id":472066,"node_id":"MDQ6VXNlcjQ3MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/472066?v=4","gravatar_id":"","url":"https://api.github.com/users/jrgp","html_url":"https://github.com/jrgp","followers_url":"https://api.github.com/users/jrgp/followers","following_url":"https://api.github.com/users/jrgp/following{/other_user}","gists_url":"https://api.github.com/users/jrgp/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgp/subscriptions","organizations_url":"https://api.github.com/users/jrgp/orgs","repos_url":"https://api.github.com/users/jrgp/repos","events_url":"https://api.github.com/users/jrgp/events{/privacy}","received_events_url":"https://api.github.com/users/jrgp/received_events","type":"User","site_admin":false},"repo":{"id":104278916,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyNzg5MTY=","name":"pyhelix","full_name":"jrgp/pyhelix","private":false,"owner":{"login":"jrgp","id":472066,"node_id":"MDQ6VXNlcjQ3MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/472066?v=4","gravatar_id":"","url":"https://api.github.com/users/jrgp","html_url":"https://github.com/jrgp","followers_url":"https://api.github.com/users/jrgp/followers","following_url":"https://api.github.com/users/jrgp/following{/other_user}","gists_url":"https://api.github.com/users/jrgp/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgp/subscriptions","organizations_url":"https://api.github.com/users/jrgp/orgs","repos_url":"https://api.github.com/users/jrgp/repos","events_url":"https://api.github.com/users/jrgp/events{/privacy}","received_events_url":"https://api.github.com/users/jrgp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jrgp/pyhelix","description":"Python participant and spectator for Apache Helix","fork":true,"url":"https://api.github.com/repos/jrgp/pyhelix","forks_url":"https://api.github.com/repos/jrgp/pyhelix/forks","keys_url":"https://api.github.com/repos/jrgp/pyhelix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrgp/pyhelix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrgp/pyhelix/teams","hooks_url":"https://api.github.com/repos/jrgp/pyhelix/hooks","issue_events_url":"https://api.github.com/repos/jrgp/pyhelix/issues/events{/number}","events_url":"https://api.github.com/repos/jrgp/pyhelix/events","assignees_url":"https://api.github.com/repos/jrgp/pyhelix/assignees{/user}","branches_url":"https://api.github.com/repos/jrgp/pyhelix/branches{/branch}","tags_url":"https://api.github.com/repos/jrgp/pyhelix/tags","blobs_url":"https://api.github.com/repos/jrgp/pyhelix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrgp/pyhelix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrgp/pyhelix/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrgp/pyhelix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrgp/pyhelix/statuses/{sha}","languages_url":"https://api.github.com/repos/jrgp/pyhelix/languages","stargazers_url":"https://api.github.com/repos/jrgp/pyhelix/stargazers","contributors_url":"https://api.github.com/repos/jrgp/pyhelix/contributors","subscribers_url":"https://api.github.com/repos/jrgp/pyhelix/subscribers","subscription_url":"https://api.github.com/repos/jrgp/pyhelix/subscription","commits_url":"https://api.github.com/repos/jrgp/pyhelix/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrgp/pyhelix/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrgp/pyhelix/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrgp/pyhelix/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrgp/pyhelix/contents/{+path}","compare_url":"https://api.github.com/repos/jrgp/pyhelix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrgp/pyhelix/merges","archive_url":"https://api.github.com/repos/jrgp/pyhelix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrgp/pyhelix/downloads","issues_url":"https://api.github.com/repos/jrgp/pyhelix/issues{/number}","pulls_url":"https://api.github.com/repos/jrgp/pyhelix/pulls{/number}","milestones_url":"https://api.github.com/repos/jrgp/pyhelix/milestones{/number}","notifications_url":"https://api.github.com/repos/jrgp/pyhelix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrgp/pyhelix/labels{/name}","releases_url":"https://api.github.com/repos/jrgp/pyhelix/releases{/id}","deployments_url":"https://api.github.com/repos/jrgp/pyhelix/deployments","created_at":"2017-09-20T23:45:33Z","updated_at":"2017-09-20T23:45:34Z","pushed_at":"2017-09-20T23:48:28Z","git_url":"git://github.com/jrgp/pyhelix.git","ssh_url":"git@github.com:jrgp/pyhelix.git","clone_url":"https://github.com/jrgp/pyhelix.git","svn_url":"https://github.com/jrgp/pyhelix","homepage":"","size":84,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kanakb:master","ref":"master","sha":"91c34149022d7857b8f292f07344abd7324727ff","user":{"login":"kanakb","id":1173516,"node_id":"MDQ6VXNlcjExNzM1MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1173516?v=4","gravatar_id":"","url":"https://api.github.com/users/kanakb","html_url":"https://github.com/kanakb","followers_url":"https://api.github.com/users/kanakb/followers","following_url":"https://api.github.com/users/kanakb/following{/other_user}","gists_url":"https://api.github.com/users/kanakb/gists{/gist_id}","starred_url":"https://api.github.com/users/kanakb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanakb/subscriptions","organizations_url":"https://api.github.com/users/kanakb/orgs","repos_url":"https://api.github.com/users/kanakb/repos","events_url":"https://api.github.com/users/kanakb/events{/privacy}","received_events_url":"https://api.github.com/users/kanakb/received_events","type":"User","site_admin":false},"repo":{"id":14651509,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1MTUwOQ==","name":"pyhelix","full_name":"kanakb/pyhelix","private":false,"owner":{"login":"kanakb","id":1173516,"node_id":"MDQ6VXNlcjExNzM1MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1173516?v=4","gravatar_id":"","url":"https://api.github.com/users/kanakb","html_url":"https://github.com/kanakb","followers_url":"https://api.github.com/users/kanakb/followers","following_url":"https://api.github.com/users/kanakb/following{/other_user}","gists_url":"https://api.github.com/users/kanakb/gists{/gist_id}","starred_url":"https://api.github.com/users/kanakb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanakb/subscriptions","organizations_url":"https://api.github.com/users/kanakb/orgs","repos_url":"https://api.github.com/users/kanakb/repos","events_url":"https://api.github.com/users/kanakb/events{/privacy}","received_events_url":"https://api.github.com/users/kanakb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kanakb/pyhelix","description":"Python participant and spectator for Apache Helix","fork":false,"url":"https://api.github.com/repos/kanakb/pyhelix","forks_url":"https://api.github.com/repos/kanakb/pyhelix/forks","keys_url":"https://api.github.com/repos/kanakb/pyhelix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanakb/pyhelix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanakb/pyhelix/teams","hooks_url":"https://api.github.com/repos/kanakb/pyhelix/hooks","issue_events_url":"https://api.github.com/repos/kanakb/pyhelix/issues/events{/number}","events_url":"https://api.github.com/repos/kanakb/pyhelix/events","assignees_url":"https://api.github.com/repos/kanakb/pyhelix/assignees{/user}","branches_url":"https://api.github.com/repos/kanakb/pyhelix/branches{/branch}","tags_url":"https://api.github.com/repos/kanakb/pyhelix/tags","blobs_url":"https://api.github.com/repos/kanakb/pyhelix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanakb/pyhelix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanakb/pyhelix/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanakb/pyhelix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanakb/pyhelix/statuses/{sha}","languages_url":"https://api.github.com/repos/kanakb/pyhelix/languages","stargazers_url":"https://api.github.com/repos/kanakb/pyhelix/stargazers","contributors_url":"https://api.github.com/repos/kanakb/pyhelix/contributors","subscribers_url":"https://api.github.com/repos/kanakb/pyhelix/subscribers","subscription_url":"https://api.github.com/repos/kanakb/pyhelix/subscription","commits_url":"https://api.github.com/repos/kanakb/pyhelix/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanakb/pyhelix/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanakb/pyhelix/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanakb/pyhelix/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanakb/pyhelix/contents/{+path}","compare_url":"https://api.github.com/repos/kanakb/pyhelix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanakb/pyhelix/merges","archive_url":"https://api.github.com/repos/kanakb/pyhelix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanakb/pyhelix/downloads","issues_url":"https://api.github.com/repos/kanakb/pyhelix/issues{/number}","pulls_url":"https://api.github.com/repos/kanakb/pyhelix/pulls{/number}","milestones_url":"https://api.github.com/repos/kanakb/pyhelix/milestones{/number}","notifications_url":"https://api.github.com/repos/kanakb/pyhelix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanakb/pyhelix/labels{/name}","releases_url":"https://api.github.com/repos/kanakb/pyhelix/releases{/id}","deployments_url":"https://api.github.com/repos/kanakb/pyhelix/deployments","created_at":"2013-11-23T22:20:56Z","updated_at":"2017-09-05T17:17:18Z","pushed_at":"2018-12-20T07:33:56Z","git_url":"git://github.com/kanakb/pyhelix.git","ssh_url":"git@github.com:kanakb/pyhelix.git","clone_url":"https://github.com/kanakb/pyhelix.git","svn_url":"https://github.com/kanakb/pyhelix","homepage":"","size":83,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kanakb/pyhelix/pulls/25"},"html":{"href":"https://github.com/kanakb/pyhelix/pull/25"},"issue":{"href":"https://api.github.com/repos/kanakb/pyhelix/issues/25"},"comments":{"href":"https://api.github.com/repos/kanakb/pyhelix/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/kanakb/pyhelix/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/kanakb/pyhelix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kanakb/pyhelix/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/kanakb/pyhelix/statuses/70cd40a96b886866f2e29a011889d6cc39c8219c"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kanakb","id":1173516,"node_id":"MDQ6VXNlcjExNzM1MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1173516?v=4","gravatar_id":"","url":"https://api.github.com/users/kanakb","html_url":"https://github.com/kanakb","followers_url":"https://api.github.com/users/kanakb/followers","following_url":"https://api.github.com/users/kanakb/following{/other_user}","gists_url":"https://api.github.com/users/kanakb/gists{/gist_id}","starred_url":"https://api.github.com/users/kanakb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanakb/subscriptions","organizations_url":"https://api.github.com/users/kanakb/orgs","repos_url":"https://api.github.com/users/kanakb/repos","events_url":"https://api.github.com/users/kanakb/events{/privacy}","received_events_url":"https://api.github.com/users/kanakb/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"kanakb"}}