{"action":"closed","issue":{"url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1015","repository_url":"https://api.github.com/repos/stratis-storage/stratisd","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1015/labels{/name}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1015/comments","events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/1015/events","html_url":"https://github.com/stratis-storage/stratisd/issues/1015","id":336374647,"node_id":"MDU6SXNzdWUzMzYzNzQ2NDc=","number":1015,"title":"Stratisd can have multiple instances running at same time (regression)","user":{"login":"tasleson","id":2520480,"node_id":"MDQ6VXNlcjI1MjA0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2520480?v=4","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"labels":[{"id":430927463,"node_id":"MDU6TGFiZWw0MzA5Mjc0NjM=","url":"https://api.github.com/repos/stratis-storage/stratisd/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"mulkieran","id":1218366,"node_id":"MDQ6VXNlcjEyMTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"assignees":[{"login":"mulkieran","id":1218366,"node_id":"MDQ6VXNlcjEyMTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-27T20:25:02Z","updated_at":"2018-06-28T17:07:52Z","closed_at":"2018-06-28T17:07:52Z","author_association":"MEMBER","body":"I was able to run 3 instances of stratisd today off of master branch.  I knew we added a lock file to handle this.  I believe the problem is this:\r\n\r\n```\r\n...\r\nopenat(AT_FDCWD, \"/var/run/stratisd.pid\", O_RDWR|O_CREAT|O_CLOEXEC, 0666) = 3\r\nioctl(3, FIOCLEX)                       = 0\r\nflock(3, LOCK_EX|LOCK_NB)               = 0\r\ngetpid()                                = 25063\r\nwrite(3, \"25063\\n\", 6)                  = 6\r\nclose(3)\r\n...\r\n```\r\n\r\nWe need to keep the lock file open if we want to use `man 2 flock`.  I'm not sure when this broke during all the changes to `stratisd.rs`, but we need a unit test added for this in addition to a fix."}}
{"actor":{"display_login":"agrover"}}