{"action":"created","comment":{"url":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments/191105495","pull_request_review_id":123615644,"id":191105495,"diff_hunk":"@@ -39,9 +39,11 @@ export default function Body(body, {\n \t} else if (body instanceof Blob) {\n \t\t// body is blob\n \t} else if (Buffer.isBuffer(body)) {\n-\t\t// body is buffer\n-\t} else if (Object.prototype.toString.call(body) === '[object ArrayBuffer]') {\n-\t\t// body is array buffer\n+\t\t// body is ArrayBuffer\n+\t} else if (body instanceof ArrayBuffer) {","path":"src/body.js","position":8,"original_position":8,"commit_id":"61789760ca9478807f6ebebdc857e42cf1dc455a","original_commit_id":"61789760ca9478807f6ebebdc857e42cf1dc455a","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"body":"Was there a reason to change the ArrayBuffer check semantics? This makes it impossible to use e.g. ArrayBuffer from a VM context, while ArrayBufferView from a VM context would work fine.","created_at":"2018-05-28T03:41:28Z","updated_at":"2018-05-28T03:42:02Z","html_url":"https://github.com/bitinn/node-fetch/pull/457#discussion_r191105495","pull_request_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/457","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments/191105495"},"html":{"href":"https://github.com/bitinn/node-fetch/pull/457#discussion_r191105495"},"pull_request":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/bitinn/node-fetch/pulls/457","id":189776744,"html_url":"https://github.com/bitinn/node-fetch/pull/457","diff_url":"https://github.com/bitinn/node-fetch/pull/457.diff","patch_url":"https://github.com/bitinn/node-fetch/pull/457.patch","issue_url":"https://api.github.com/repos/bitinn/node-fetch/issues/457","number":457,"state":"closed","locked":false,"title":"Added support for `ArrayBufferView`","user":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars0.githubusercontent.com/u/928965?v=4","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"body":"Fixes #247","created_at":"2018-05-22T20:05:06Z","updated_at":"2018-05-28T03:42:02Z","closed_at":"2018-05-28T03:18:18Z","merged_at":"2018-05-28T03:18:18Z","merge_commit_sha":"5bc23d81cf7ebb97b0a7310b2c88c13cdaa706dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/457/commits","review_comments_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/457/comments","review_comment_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitinn/node-fetch/issues/457/comments","statuses_url":"https://api.github.com/repos/bitinn/node-fetch/statuses/61789760ca9478807f6ebebdc857e42cf1dc455a","head":{"label":"nazar-pc:ArrayBufferView-support","ref":"ArrayBufferView-support","sha":"61789760ca9478807f6ebebdc857e42cf1dc455a","user":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars0.githubusercontent.com/u/928965?v=4","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"repo":{"id":134463595,"name":"node-fetch","full_name":"nazar-pc/node-fetch","owner":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars0.githubusercontent.com/u/928965?v=4","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nazar-pc/node-fetch","description":"A light-weight module that brings window.fetch to Node.js","fork":true,"url":"https://api.github.com/repos/nazar-pc/node-fetch","forks_url":"https://api.github.com/repos/nazar-pc/node-fetch/forks","keys_url":"https://api.github.com/repos/nazar-pc/node-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nazar-pc/node-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nazar-pc/node-fetch/teams","hooks_url":"https://api.github.com/repos/nazar-pc/node-fetch/hooks","issue_events_url":"https://api.github.com/repos/nazar-pc/node-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/nazar-pc/node-fetch/events","assignees_url":"https://api.github.com/repos/nazar-pc/node-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/nazar-pc/node-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/nazar-pc/node-fetch/tags","blobs_url":"https://api.github.com/repos/nazar-pc/node-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nazar-pc/node-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nazar-pc/node-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nazar-pc/node-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nazar-pc/node-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/nazar-pc/node-fetch/languages","stargazers_url":"https://api.github.com/repos/nazar-pc/node-fetch/stargazers","contributors_url":"https://api.github.com/repos/nazar-pc/node-fetch/contributors","subscribers_url":"https://api.github.com/repos/nazar-pc/node-fetch/subscribers","subscription_url":"https://api.github.com/repos/nazar-pc/node-fetch/subscription","commits_url":"https://api.github.com/repos/nazar-pc/node-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nazar-pc/node-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nazar-pc/node-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nazar-pc/node-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nazar-pc/node-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/nazar-pc/node-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nazar-pc/node-fetch/merges","archive_url":"https://api.github.com/repos/nazar-pc/node-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nazar-pc/node-fetch/downloads","issues_url":"https://api.github.com/repos/nazar-pc/node-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/nazar-pc/node-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/nazar-pc/node-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/nazar-pc/node-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nazar-pc/node-fetch/labels{/name}","releases_url":"https://api.github.com/repos/nazar-pc/node-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/nazar-pc/node-fetch/deployments","created_at":"2018-05-22T19:10:25Z","updated_at":"2018-05-22T19:10:27Z","pushed_at":"2018-05-28T03:27:01Z","git_url":"git://github.com/nazar-pc/node-fetch.git","ssh_url":"git@github.com:nazar-pc/node-fetch.git","clone_url":"https://github.com/nazar-pc/node-fetch.git","svn_url":"https://github.com/nazar-pc/node-fetch","homepage":"","size":473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitinn:master","ref":"master","sha":"fa6548ed316a3c512147a3bb4f4d6e986d738be6","user":{"login":"bitinn","id":1484279,"avatar_url":"https://avatars3.githubusercontent.com/u/1484279?v=4","gravatar_id":"","url":"https://api.github.com/users/bitinn","html_url":"https://github.com/bitinn","followers_url":"https://api.github.com/users/bitinn/followers","following_url":"https://api.github.com/users/bitinn/following{/other_user}","gists_url":"https://api.github.com/users/bitinn/gists{/gist_id}","starred_url":"https://api.github.com/users/bitinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitinn/subscriptions","organizations_url":"https://api.github.com/users/bitinn/orgs","repos_url":"https://api.github.com/users/bitinn/repos","events_url":"https://api.github.com/users/bitinn/events{/privacy}","received_events_url":"https://api.github.com/users/bitinn/received_events","type":"User","site_admin":false},"repo":{"id":29849956,"name":"node-fetch","full_name":"bitinn/node-fetch","owner":{"login":"bitinn","id":1484279,"avatar_url":"https://avatars3.githubusercontent.com/u/1484279?v=4","gravatar_id":"","url":"https://api.github.com/users/bitinn","html_url":"https://github.com/bitinn","followers_url":"https://api.github.com/users/bitinn/followers","following_url":"https://api.github.com/users/bitinn/following{/other_user}","gists_url":"https://api.github.com/users/bitinn/gists{/gist_id}","starred_url":"https://api.github.com/users/bitinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitinn/subscriptions","organizations_url":"https://api.github.com/users/bitinn/orgs","repos_url":"https://api.github.com/users/bitinn/repos","events_url":"https://api.github.com/users/bitinn/events{/privacy}","received_events_url":"https://api.github.com/users/bitinn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitinn/node-fetch","description":"A light-weight module that brings window.fetch to Node.js","fork":false,"url":"https://api.github.com/repos/bitinn/node-fetch","forks_url":"https://api.github.com/repos/bitinn/node-fetch/forks","keys_url":"https://api.github.com/repos/bitinn/node-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitinn/node-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitinn/node-fetch/teams","hooks_url":"https://api.github.com/repos/bitinn/node-fetch/hooks","issue_events_url":"https://api.github.com/repos/bitinn/node-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/bitinn/node-fetch/events","assignees_url":"https://api.github.com/repos/bitinn/node-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/bitinn/node-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/bitinn/node-fetch/tags","blobs_url":"https://api.github.com/repos/bitinn/node-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitinn/node-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitinn/node-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitinn/node-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitinn/node-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/bitinn/node-fetch/languages","stargazers_url":"https://api.github.com/repos/bitinn/node-fetch/stargazers","contributors_url":"https://api.github.com/repos/bitinn/node-fetch/contributors","subscribers_url":"https://api.github.com/repos/bitinn/node-fetch/subscribers","subscription_url":"https://api.github.com/repos/bitinn/node-fetch/subscription","commits_url":"https://api.github.com/repos/bitinn/node-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitinn/node-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitinn/node-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitinn/node-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitinn/node-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/bitinn/node-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitinn/node-fetch/merges","archive_url":"https://api.github.com/repos/bitinn/node-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitinn/node-fetch/downloads","issues_url":"https://api.github.com/repos/bitinn/node-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/bitinn/node-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/bitinn/node-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/bitinn/node-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitinn/node-fetch/labels{/name}","releases_url":"https://api.github.com/repos/bitinn/node-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/bitinn/node-fetch/deployments","created_at":"2015-01-26T07:29:26Z","updated_at":"2018-05-28T03:18:22Z","pushed_at":"2018-05-28T03:18:19Z","git_url":"git://github.com/bitinn/node-fetch.git","ssh_url":"git@github.com:bitinn/node-fetch.git","clone_url":"https://github.com/bitinn/node-fetch.git","svn_url":"https://github.com/bitinn/node-fetch","homepage":"","size":449,"stargazers_count":3025,"watchers_count":3025,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":294,"open_issues":45,"watchers":3025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/457"},"html":{"href":"https://github.com/bitinn/node-fetch/pull/457"},"issue":{"href":"https://api.github.com/repos/bitinn/node-fetch/issues/457"},"comments":{"href":"https://api.github.com/repos/bitinn/node-fetch/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/bitinn/node-fetch/statuses/61789760ca9478807f6ebebdc857e42cf1dc455a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TimothyGu"}}