{"action":"created","comment":{"url":"https://api.github.com/repos/desktop/desktop/pulls/comments/223787633","pull_request_review_id":163000425,"id":223787633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzc4NzYzMw==","diff_hunk":"@@ -51,15 +51,11 @@ function typeMatchesSelection(\n  * whose selection state has diverged from the default selection state.\n  */\n export class DiffSelection {\n-  private readonly defaultSelectionType:\n-    | DiffSelectionType.All\n-    | DiffSelectionType.None\n-\n   /* Any line numbers where the selection differs from the default state. */\n-  private readonly divergingLines: Set<number> | null\n+  //private readonly divergingLines: Set<number> | null\n \n   /* Optional set of line numbers which can be selected. */\n-  private readonly selectableLines: Set<number> | null\n+  //private readonly selectableLines: Set<number> | null","path":"app/src/models/diff/diff-selection.ts","position":null,"original_position":14,"commit_id":"54295eb01c11d7aa32aa8fef7f7508e634dc82c2","original_commit_id":"b185311481dc2262d2d89158da2546819eee4cea","user":{"login":"outofambit","id":964912,"node_id":"MDQ6VXNlcjk2NDkxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/964912?v=4","gravatar_id":"","url":"https://api.github.com/users/outofambit","html_url":"https://github.com/outofambit","followers_url":"https://api.github.com/users/outofambit/followers","following_url":"https://api.github.com/users/outofambit/following{/other_user}","gists_url":"https://api.github.com/users/outofambit/gists{/gist_id}","starred_url":"https://api.github.com/users/outofambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outofambit/subscriptions","organizations_url":"https://api.github.com/users/outofambit/orgs","repos_url":"https://api.github.com/users/outofambit/repos","events_url":"https://api.github.com/users/outofambit/events{/privacy}","received_events_url":"https://api.github.com/users/outofambit/received_events","type":"User","site_admin":true},"body":"thank you both!","created_at":"2018-10-09T17:11:17Z","updated_at":"2018-10-09T17:11:17Z","html_url":"https://github.com/desktop/desktop/pull/5815#discussion_r223787633","pull_request_url":"https://api.github.com/repos/desktop/desktop/pulls/5815","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments/223787633"},"html":{"href":"https://github.com/desktop/desktop/pull/5815#discussion_r223787633"},"pull_request":{"href":"https://api.github.com/repos/desktop/desktop/pulls/5815"}},"in_reply_to_id":222956948},"pull_request":{"url":"https://api.github.com/repos/desktop/desktop/pulls/5815","id":220486281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDg2Mjgx","html_url":"https://github.com/desktop/desktop/pull/5815","diff_url":"https://github.com/desktop/desktop/pull/5815.diff","patch_url":"https://github.com/desktop/desktop/pull/5815.patch","issue_url":"https://api.github.com/repos/desktop/desktop/issues/5815","number":5815,"state":"open","locked":false,"title":"Refactored models/diff/diff-selection constructors with parameter properties","user":{"login":"Daniel-McCarthy","id":4957200,"node_id":"MDQ6VXNlcjQ5NTcyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4957200?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-McCarthy","html_url":"https://github.com/Daniel-McCarthy","followers_url":"https://api.github.com/users/Daniel-McCarthy/followers","following_url":"https://api.github.com/users/Daniel-McCarthy/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-McCarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-McCarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-McCarthy/subscriptions","organizations_url":"https://api.github.com/users/Daniel-McCarthy/orgs","repos_url":"https://api.github.com/users/Daniel-McCarthy/repos","events_url":"https://api.github.com/users/Daniel-McCarthy/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-McCarthy/received_events","type":"User","site_admin":false},"body":"This is continuing off Issue #4272. It has updated the `models/diff/diff-line` file with parameter properties.\r\n\r\nAlong with the `models/diff/raw-diff` pull requests this should be the last one.","created_at":"2018-10-04T19:11:03Z","updated_at":"2018-10-09T17:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"045d8518482d7d3decae3705159044391a19f01e","assignee":{"login":"outofambit","id":964912,"node_id":"MDQ6VXNlcjk2NDkxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/964912?v=4","gravatar_id":"","url":"https://api.github.com/users/outofambit","html_url":"https://github.com/outofambit","followers_url":"https://api.github.com/users/outofambit/followers","following_url":"https://api.github.com/users/outofambit/following{/other_user}","gists_url":"https://api.github.com/users/outofambit/gists{/gist_id}","starred_url":"https://api.github.com/users/outofambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outofambit/subscriptions","organizations_url":"https://api.github.com/users/outofambit/orgs","repos_url":"https://api.github.com/users/outofambit/repos","events_url":"https://api.github.com/users/outofambit/events{/privacy}","received_events_url":"https://api.github.com/users/outofambit/received_events","type":"User","site_admin":true},"assignees":[{"login":"outofambit","id":964912,"node_id":"MDQ6VXNlcjk2NDkxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/964912?v=4","gravatar_id":"","url":"https://api.github.com/users/outofambit","html_url":"https://github.com/outofambit","followers_url":"https://api.github.com/users/outofambit/followers","following_url":"https://api.github.com/users/outofambit/following{/other_user}","gists_url":"https://api.github.com/users/outofambit/gists{/gist_id}","starred_url":"https://api.github.com/users/outofambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outofambit/subscriptions","organizations_url":"https://api.github.com/users/outofambit/orgs","repos_url":"https://api.github.com/users/outofambit/repos","events_url":"https://api.github.com/users/outofambit/events{/privacy}","received_events_url":"https://api.github.com/users/outofambit/received_events","type":"User","site_admin":true}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":590997902,"node_id":"MDU6TGFiZWw1OTA5OTc5MDI=","url":"https://api.github.com/repos/desktop/desktop/labels/ready-for-review","name":"ready-for-review","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/desktop/desktop/milestones/27","html_url":"https://github.com/desktop/desktop/milestone/27","labels_url":"https://api.github.com/repos/desktop/desktop/milestones/27/labels","id":3725004,"node_id":"MDk6TWlsZXN0b25lMzcyNTAwNA==","number":27,"title":"1.4.3","description":"","creator":{"login":"outofambit","id":964912,"node_id":"MDQ6VXNlcjk2NDkxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/964912?v=4","gravatar_id":"","url":"https://api.github.com/users/outofambit","html_url":"https://github.com/outofambit","followers_url":"https://api.github.com/users/outofambit/followers","following_url":"https://api.github.com/users/outofambit/following{/other_user}","gists_url":"https://api.github.com/users/outofambit/gists{/gist_id}","starred_url":"https://api.github.com/users/outofambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outofambit/subscriptions","organizations_url":"https://api.github.com/users/outofambit/orgs","repos_url":"https://api.github.com/users/outofambit/repos","events_url":"https://api.github.com/users/outofambit/events{/privacy}","received_events_url":"https://api.github.com/users/outofambit/received_events","type":"User","site_admin":true},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-10-09T16:52:36Z","updated_at":"2018-10-09T16:55:49Z","due_on":"2018-10-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/desktop/desktop/pulls/5815/commits","review_comments_url":"https://api.github.com/repos/desktop/desktop/pulls/5815/comments","review_comment_url":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/5815/comments","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/54295eb01c11d7aa32aa8fef7f7508e634dc82c2","head":{"label":"Daniel-McCarthy:Add-Parameter-Properties-to-diff-selection-Diff-Model","ref":"Add-Parameter-Properties-to-diff-selection-Diff-Model","sha":"54295eb01c11d7aa32aa8fef7f7508e634dc82c2","user":{"login":"Daniel-McCarthy","id":4957200,"node_id":"MDQ6VXNlcjQ5NTcyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4957200?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-McCarthy","html_url":"https://github.com/Daniel-McCarthy","followers_url":"https://api.github.com/users/Daniel-McCarthy/followers","following_url":"https://api.github.com/users/Daniel-McCarthy/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-McCarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-McCarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-McCarthy/subscriptions","organizations_url":"https://api.github.com/users/Daniel-McCarthy/orgs","repos_url":"https://api.github.com/users/Daniel-McCarthy/repos","events_url":"https://api.github.com/users/Daniel-McCarthy/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-McCarthy/received_events","type":"User","site_admin":false},"repo":{"id":143821594,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4MjE1OTQ=","name":"desktop","full_name":"Daniel-McCarthy/desktop","private":false,"owner":{"login":"Daniel-McCarthy","id":4957200,"node_id":"MDQ6VXNlcjQ5NTcyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4957200?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-McCarthy","html_url":"https://github.com/Daniel-McCarthy","followers_url":"https://api.github.com/users/Daniel-McCarthy/followers","following_url":"https://api.github.com/users/Daniel-McCarthy/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-McCarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-McCarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-McCarthy/subscriptions","organizations_url":"https://api.github.com/users/Daniel-McCarthy/orgs","repos_url":"https://api.github.com/users/Daniel-McCarthy/repos","events_url":"https://api.github.com/users/Daniel-McCarthy/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-McCarthy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Daniel-McCarthy/desktop","description":"Simple collaboration from your desktop","fork":true,"url":"https://api.github.com/repos/Daniel-McCarthy/desktop","forks_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/forks","keys_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/teams","hooks_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/hooks","issue_events_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/events","assignees_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/tags","blobs_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/languages","stargazers_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/stargazers","contributors_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/contributors","subscribers_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/subscribers","subscription_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/subscription","commits_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/merges","archive_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/downloads","issues_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/labels{/name}","releases_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/Daniel-McCarthy/desktop/deployments","created_at":"2018-08-07T04:54:53Z","updated_at":"2018-10-04T18:51:02Z","pushed_at":"2018-10-05T12:22:21Z","git_url":"git://github.com/Daniel-McCarthy/desktop.git","ssh_url":"git@github.com:Daniel-McCarthy/desktop.git","clone_url":"https://github.com/Daniel-McCarthy/desktop.git","svn_url":"https://github.com/Daniel-McCarthy/desktop","homepage":"https://desktop.github.com","size":147759,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"desktop:master","ref":"master","sha":"d8e79651a71a0bb72878b6ed465349712be845dd","user":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":58559694,"node_id":"MDEwOlJlcG9zaXRvcnk1ODU1OTY5NA==","name":"desktop","full_name":"desktop/desktop","private":false,"owner":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/desktop/desktop","description":"Simple collaboration from your desktop","fork":false,"url":"https://api.github.com/repos/desktop/desktop","forks_url":"https://api.github.com/repos/desktop/desktop/forks","keys_url":"https://api.github.com/repos/desktop/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desktop/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desktop/desktop/teams","hooks_url":"https://api.github.com/repos/desktop/desktop/hooks","issue_events_url":"https://api.github.com/repos/desktop/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/desktop/desktop/events","assignees_url":"https://api.github.com/repos/desktop/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/desktop/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/desktop/desktop/tags","blobs_url":"https://api.github.com/repos/desktop/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desktop/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desktop/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/desktop/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/desktop/desktop/languages","stargazers_url":"https://api.github.com/repos/desktop/desktop/stargazers","contributors_url":"https://api.github.com/repos/desktop/desktop/contributors","subscribers_url":"https://api.github.com/repos/desktop/desktop/subscribers","subscription_url":"https://api.github.com/repos/desktop/desktop/subscription","commits_url":"https://api.github.com/repos/desktop/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/desktop/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/desktop/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/desktop/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/desktop/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/desktop/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desktop/desktop/merges","archive_url":"https://api.github.com/repos/desktop/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desktop/desktop/downloads","issues_url":"https://api.github.com/repos/desktop/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/desktop/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/desktop/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/desktop/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desktop/desktop/labels{/name}","releases_url":"https://api.github.com/repos/desktop/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/desktop/desktop/deployments","created_at":"2016-05-11T15:59:00Z","updated_at":"2018-10-09T06:03:02Z","pushed_at":"2018-10-09T15:28:34Z","git_url":"git://github.com/desktop/desktop.git","ssh_url":"git@github.com:desktop/desktop.git","clone_url":"https://github.com/desktop/desktop.git","svn_url":"https://github.com/desktop/desktop","homepage":"https://desktop.github.com","size":34397,"stargazers_count":6041,"watchers_count":6041,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2568,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2568,"open_issues":465,"watchers":6041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/5815"},"html":{"href":"https://github.com/desktop/desktop/pull/5815"},"issue":{"href":"https://api.github.com/repos/desktop/desktop/issues/5815"},"comments":{"href":"https://api.github.com/repos/desktop/desktop/issues/5815/comments"},"review_comments":{"href":"https://api.github.com/repos/desktop/desktop/pulls/5815/comments"},"review_comment":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/desktop/desktop/pulls/5815/commits"},"statuses":{"href":"https://api.github.com/repos/desktop/desktop/statuses/54295eb01c11d7aa32aa8fef7f7508e634dc82c2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"outofambit"}}