{"action":"closed","issue":{"url":"https://api.github.com/repos/Filipsi/Packsly/issues/16","repository_url":"https://api.github.com/repos/Filipsi/Packsly","labels_url":"https://api.github.com/repos/Filipsi/Packsly/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/Filipsi/Packsly/issues/16/comments","events_url":"https://api.github.com/repos/Filipsi/Packsly/issues/16/events","html_url":"https://github.com/Filipsi/Packsly/issues/16","id":337309693,"node_id":"MDU6SXNzdWUzMzczMDk2OTM=","number":16,"title":"Project structure reorganization","user":{"login":"Filipsi","id":5103404,"node_id":"MDQ6VXNlcjUxMDM0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5103404?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipsi","html_url":"https://github.com/Filipsi","followers_url":"https://api.github.com/users/Filipsi/followers","following_url":"https://api.github.com/users/Filipsi/following{/other_user}","gists_url":"https://api.github.com/users/Filipsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipsi/subscriptions","organizations_url":"https://api.github.com/users/Filipsi/orgs","repos_url":"https://api.github.com/users/Filipsi/repos","events_url":"https://api.github.com/users/Filipsi/events{/privacy}","received_events_url":"https://api.github.com/users/Filipsi/received_events","type":"User","site_admin":false},"labels":[{"id":961487345,"node_id":"MDU6TGFiZWw5NjE0ODczNDU=","url":"https://api.github.com/repos/Filipsi/Packsly/labels/Cleanup","name":"Cleanup","color":"EEEEEE","default":false},{"id":968267218,"node_id":"MDU6TGFiZWw5NjgyNjcyMTg=","url":"https://api.github.com/repos/Filipsi/Packsly/labels/Core","name":"Core","color":"e8964e","default":false}],"state":"closed","locked":false,"assignee":{"login":"Filipsi","id":5103404,"node_id":"MDQ6VXNlcjUxMDM0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5103404?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipsi","html_url":"https://github.com/Filipsi","followers_url":"https://api.github.com/users/Filipsi/followers","following_url":"https://api.github.com/users/Filipsi/following{/other_user}","gists_url":"https://api.github.com/users/Filipsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipsi/subscriptions","organizations_url":"https://api.github.com/users/Filipsi/orgs","repos_url":"https://api.github.com/users/Filipsi/repos","events_url":"https://api.github.com/users/Filipsi/events{/privacy}","received_events_url":"https://api.github.com/users/Filipsi/received_events","type":"User","site_admin":false},"assignees":[{"login":"Filipsi","id":5103404,"node_id":"MDQ6VXNlcjUxMDM0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5103404?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipsi","html_url":"https://github.com/Filipsi","followers_url":"https://api.github.com/users/Filipsi/followers","following_url":"https://api.github.com/users/Filipsi/following{/other_user}","gists_url":"https://api.github.com/users/Filipsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipsi/subscriptions","organizations_url":"https://api.github.com/users/Filipsi/orgs","repos_url":"https://api.github.com/users/Filipsi/repos","events_url":"https://api.github.com/users/Filipsi/events{/privacy}","received_events_url":"https://api.github.com/users/Filipsi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Filipsi/Packsly/milestones/1","html_url":"https://github.com/Filipsi/Packsly/milestone/1","labels_url":"https://api.github.com/repos/Filipsi/Packsly/milestones/1/labels","id":3416291,"node_id":"MDk6TWlsZXN0b25lMzQxNjI5MQ==","number":1,"title":"1.0 Release","description":null,"creator":{"login":"Filipsi","id":5103404,"node_id":"MDQ6VXNlcjUxMDM0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5103404?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipsi","html_url":"https://github.com/Filipsi","followers_url":"https://api.github.com/users/Filipsi/followers","following_url":"https://api.github.com/users/Filipsi/following{/other_user}","gists_url":"https://api.github.com/users/Filipsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipsi/subscriptions","organizations_url":"https://api.github.com/users/Filipsi/orgs","repos_url":"https://api.github.com/users/Filipsi/repos","events_url":"https://api.github.com/users/Filipsi/events{/privacy}","received_events_url":"https://api.github.com/users/Filipsi/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2018-06-11T16:23:29Z","updated_at":"2018-07-21T18:44:48Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-01T18:02:17Z","updated_at":"2018-07-21T18:44:48Z","closed_at":"2018-07-21T18:44:48Z","author_association":"OWNER","body":"### Summary\r\nProject would benefit from structure reorganization to improve usability.\r\nThe plan is to create a static `Packsly` class as a entry point and move around some classes to better organize them.\r\n\r\n### Scope\r\n- Add internal constructor and remove static from `MinecraftLauncher`\r\n- Add internal constructor and remove static from `Lifecycle`\r\n- Remove `PackslyConfig#Instnace` filed and make constructor internal\r\n- Create static `Packsly` class with `MinecraftLauncher` instance, `Lifecycle` instance. `PackslyConfig` instance and allow to set and get central workspace location\r\n- Move `RemoteResource`, `ModSource `and `EnvironmentSpecific` to it's own sub-namespace  `Packsly3.Core.Modpack.Model`\r\n- Make `MinecraftInstanceFactory` internal and forward creation methods to `MinecraftLauncher`\r\n- Make `MinecraftLauncher#CurrentEnvironment` internal and expose `Name` property\r\n- Move `PackslyConfig` and `PackslyInstanceFile` to it's own sub-namespace `Packsly3.Core.FileSystem.Impl`\r\n- Move `RegisterAttribute` and `PackslyAssemblyLoader` to to it's own sub-namespace `Packsly3.Core.Common.Register`\r\n- Make `PackslyAssemblyLoader#LoadedAssemblies` read-only\r\n- Move `EnvironmentVariables`, `FileManager`, `Icon` and `Lifecycle` to it's own sub-namespace `Packsly3.Core.Launcher.Instance.Logic`\r\n- Fix typos"}}
{"actor":{"display_login":"Filipsi"}}