{"action":"created","comment":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/171068579","pull_request_review_id":99857626,"id":171068579,"diff_hunk":"@@ -18,46 +18,17 @@ Logger.configure({\n \n Meteor.startup(() => {\n   const LOG_CONFIG = Meteor.settings.private.log || {};\n-  let { filename } = LOG_CONFIG;","path":"bigbluebutton-html5/imports/startup/server/logger.js","position":4,"original_position":4,"commit_id":"a79ca555678925d94ec467d855aa1e14a578de70","original_commit_id":"a79ca555678925d94ec467d855aa1e14a578de70","user":{"login":"OZhurbenko","id":9299997,"avatar_url":"https://avatars0.githubusercontent.com/u/9299997?v=4","gravatar_id":"","url":"https://api.github.com/users/OZhurbenko","html_url":"https://github.com/OZhurbenko","followers_url":"https://api.github.com/users/OZhurbenko/followers","following_url":"https://api.github.com/users/OZhurbenko/following{/other_user}","gists_url":"https://api.github.com/users/OZhurbenko/gists{/gist_id}","starred_url":"https://api.github.com/users/OZhurbenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OZhurbenko/subscriptions","organizations_url":"https://api.github.com/users/OZhurbenko/orgs","repos_url":"https://api.github.com/users/OZhurbenko/repos","events_url":"https://api.github.com/users/OZhurbenko/events{/privacy}","received_events_url":"https://api.github.com/users/OZhurbenko/received_events","type":"User","site_admin":false},"body":"I think you also have to remove this from the `settings-development.json` and `settings-production.json`","created_at":"2018-02-27T21:15:45Z","updated_at":"2018-02-27T21:16:31Z","html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/5164#discussion_r171068579","pull_request_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/171068579"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/5164#discussion_r171068579"},"pull_request":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164"}}},"pull_request":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164","id":170810181,"html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/5164","diff_url":"https://github.com/bigbluebutton/bigbluebutton/pull/5164.diff","patch_url":"https://github.com/bigbluebutton/bigbluebutton/pull/5164.patch","issue_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/5164","number":5164,"state":"open","locked":false,"title":"[HTML5 Client] Production Logging to Console","user":{"login":"MaximKhlobystov","id":5004762,"avatar_url":"https://avatars0.githubusercontent.com/u/5004762?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKhlobystov","html_url":"https://github.com/MaximKhlobystov","followers_url":"https://api.github.com/users/MaximKhlobystov/followers","following_url":"https://api.github.com/users/MaximKhlobystov/following{/other_user}","gists_url":"https://api.github.com/users/MaximKhlobystov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKhlobystov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKhlobystov/subscriptions","organizations_url":"https://api.github.com/users/MaximKhlobystov/orgs","repos_url":"https://api.github.com/users/MaximKhlobystov/repos","events_url":"https://api.github.com/users/MaximKhlobystov/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKhlobystov/received_events","type":"User","site_admin":false},"body":"This PR adds console logging in production + removes daily rotation logs and logging to file in development.\r\nThe console logs were tested in the package mode and it was confirmed that `systemctl` picks logging from HTML5 client.","created_at":"2018-02-22T17:06:35Z","updated_at":"2018-02-27T21:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02af02f2f910bbc5568a36ed2026e0388b671591","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246901005,"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels/HTML5%20Client","name":"HTML5 Client","color":"035418","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164/commits","review_comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164/comments","review_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/5164/comments","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/a79ca555678925d94ec467d855aa1e14a578de70","head":{"label":"MaximKhlobystov:production-console-logging","ref":"production-console-logging","sha":"a79ca555678925d94ec467d855aa1e14a578de70","user":{"login":"MaximKhlobystov","id":5004762,"avatar_url":"https://avatars0.githubusercontent.com/u/5004762?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKhlobystov","html_url":"https://github.com/MaximKhlobystov","followers_url":"https://api.github.com/users/MaximKhlobystov/followers","following_url":"https://api.github.com/users/MaximKhlobystov/following{/other_user}","gists_url":"https://api.github.com/users/MaximKhlobystov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKhlobystov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKhlobystov/subscriptions","organizations_url":"https://api.github.com/users/MaximKhlobystov/orgs","repos_url":"https://api.github.com/users/MaximKhlobystov/repos","events_url":"https://api.github.com/users/MaximKhlobystov/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKhlobystov/received_events","type":"User","site_admin":false},"repo":{"id":21372519,"name":"bigbluebutton","full_name":"MaximKhlobystov/bigbluebutton","owner":{"login":"MaximKhlobystov","id":5004762,"avatar_url":"https://avatars0.githubusercontent.com/u/5004762?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximKhlobystov","html_url":"https://github.com/MaximKhlobystov","followers_url":"https://api.github.com/users/MaximKhlobystov/followers","following_url":"https://api.github.com/users/MaximKhlobystov/following{/other_user}","gists_url":"https://api.github.com/users/MaximKhlobystov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximKhlobystov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximKhlobystov/subscriptions","organizations_url":"https://api.github.com/users/MaximKhlobystov/orgs","repos_url":"https://api.github.com/users/MaximKhlobystov/repos","events_url":"https://api.github.com/users/MaximKhlobystov/events{/privacy}","received_events_url":"https://api.github.com/users/MaximKhlobystov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximKhlobystov/bigbluebutton","description":"BigBlueButton is an open source web conferencing system for distance education","fork":true,"url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton","forks_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/forks","keys_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/events","assignees_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/merges","archive_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/MaximKhlobystov/bigbluebutton/deployments","created_at":"2014-07-01T02:19:56Z","updated_at":"2014-06-09T16:17:48Z","pushed_at":"2018-02-27T16:34:17Z","git_url":"git://github.com/MaximKhlobystov/bigbluebutton.git","ssh_url":"git@github.com:MaximKhlobystov/bigbluebutton.git","clone_url":"https://github.com/MaximKhlobystov/bigbluebutton.git","svn_url":"https://github.com/MaximKhlobystov/bigbluebutton","homepage":"www.bigbluebutton.org","size":644576,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigbluebutton:v2.0.x-release","ref":"v2.0.x-release","sha":"5190d7670eaaec00bad017e36c5b0790903598d6","user":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars0.githubusercontent.com/u/230228?v=4","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"repo":{"id":684382,"name":"bigbluebutton","full_name":"bigbluebutton/bigbluebutton","owner":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars0.githubusercontent.com/u/230228?v=4","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigbluebutton/bigbluebutton","description":"Complete open source web conferencing system.","fork":false,"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton","forks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/forks","keys_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/events","assignees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/merges","archive_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/deployments","created_at":"2010-05-25T01:42:41Z","updated_at":"2018-02-26T00:43:24Z","pushed_at":"2018-02-27T21:14:57Z","git_url":"git://github.com/bigbluebutton/bigbluebutton.git","ssh_url":"git@github.com:bigbluebutton/bigbluebutton.git","clone_url":"https://github.com/bigbluebutton/bigbluebutton.git","svn_url":"https://github.com/bigbluebutton/bigbluebutton","homepage":"http://www.bigbluebutton.org","size":640660,"stargazers_count":1995,"watchers_count":1995,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3506,"mirror_url":null,"archived":false,"open_issues_count":501,"license":null,"forks":3506,"open_issues":501,"watchers":1995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/5164"},"issue":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/5164"},"comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/5164/comments"},"review_comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164/comments"},"review_comment":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/5164/commits"},"statuses":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/a79ca555678925d94ec467d855aa1e14a578de70"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"OZhurbenko"}}