{"push_id":3021346546,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"21432747adfc294a5519fcbd826dea2cbfa82e3d","before":"20e25f4fd2701703a35253aa990c6c8fa98271fe","commits":[{"sha":"a498bcbb946d8c4afcfa516272fc18f382005b41","author":{"name":"Sorah Fukumori","email":"782099d97a2bed223eefc37e525c8f9a1ece7b9d@cookpad.com"},"message":"fix extension builder failure when verbose\n\nSince #2441 the `command` argument at Builder.run could be an Array.\n\nBut Kernel#.system doesn't accept Array and may raise ArgumentError in such cases.\n\nThe reason behind this bug is having separate codepath to run co-process, just for really_verbose.\nTHis patch changes the method to always use IO.popen, even in verbose.","distinct":false,"url":"https://api.github.com/repos/rubygems/rubygems/commits/a498bcbb946d8c4afcfa516272fc18f382005b41"},{"sha":"21432747adfc294a5519fcbd826dea2cbfa82e3d","author":{"name":"Bundlerbot","email":"c71e7261d37a4f6ae4cfb0cbd79081310a237e67@bundler.io"},"message":"Merge #2457\n\n2457: fix extension builder failure when verbose r=hsbt a=sorah\n\n# Description:\r\n\r\nSince #2441 the `command` argument at Builder.run could be an Array.\r\n\r\nBut Kernel#.system doesn't accept Array and may raise ArgumentError in such cases.\r\n\r\nThe reason behind this bug is having separate codepath to run co-process, just for really_verbose.\r\nThis patch changes the method to always use IO.popen, even in verbose.\r\n\r\n## Steps to reproduce\r\n\r\n```sh\r\necho \"verbose: really\" >> ~/.gemrc\r\ngem i psych\r\n# (or any gems you like, includes extension like nokogiri)\r\n```\r\n\r\n# Tasks:\r\n\r\n- [x] Describe the problem / feature\r\n- [ ] Write tests\r\n- [x] Write code to solve the problem\r\n- [ ] Get code review from coworkers / friends\r\n\r\nI will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).\r\n\n\nCo-authored-by: Sorah Fukumori <sorah@cookpad.com>","distinct":false,"url":"https://api.github.com/repos/rubygems/rubygems/commits/21432747adfc294a5519fcbd826dea2cbfa82e3d"}]}
{"actor":{"display_login":"bundlerbot"}}