{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8080","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8080/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8080/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8080/events","html_url":"https://github.com/RobotLocomotion/drake/pull/8080","id":297502792,"number":8080,"title":"Remove drake_visualizer's dependency on pydrake","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false},"assignees":[{"login":"soonho-tri","id":20779767,"avatar_url":"https://avatars3.githubusercontent.com/u/20779767?v=4","gravatar_id":"","url":"https://api.github.com/users/soonho-tri","html_url":"https://github.com/soonho-tri","followers_url":"https://api.github.com/users/soonho-tri/followers","following_url":"https://api.github.com/users/soonho-tri/following{/other_user}","gists_url":"https://api.github.com/users/soonho-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/soonho-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonho-tri/subscriptions","organizations_url":"https://api.github.com/users/soonho-tri/orgs","repos_url":"https://api.github.com/users/soonho-tri/repos","events_url":"https://api.github.com/users/soonho-tri/events{/privacy}","received_events_url":"https://api.github.com/users/soonho-tri/received_events","type":"User","site_admin":false},{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-02-15T16:09:51Z","updated_at":"2018-02-15T21:23:03Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/8080","html_url":"https://github.com/RobotLocomotion/drake/pull/8080","diff_url":"https://github.com/RobotLocomotion/drake/pull/8080.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/8080.patch"},"body":"Fixes #8010.\r\n\r\nI've tested this locally using:\r\n- the `examples/vakyrie/README.md` instructions;\r\n- the first example from `automotive/README.md` instructions;\r\n- the Anzu demo instructions.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/8080)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/366066052","html_url":"https://github.com/RobotLocomotion/drake/pull/8080#issuecomment-366066052","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8080","id":366066052,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T21:23:03Z","updated_at":"2018-02-15T21:23:03Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 3 of 5 files reviewed at latest revision, all discussions resolved, some commit checks pending.\n\n---\n\n*[tools/workspace/drake_visualizer/drake_visualizer.py, line 22 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/8080#-L5PtZ3DFY_saGIecVTD:-L5QHAbp-R6O3AKK0xY-:b-z6vuqf) ([raw file](https://github.com/robotlocomotion/drake/blob/0f5f0304c8643c9303ca534a5bc5648189ebf3ca/tools/workspace/drake_visualizer/drake_visualizer.py#L22)):*\n> From what I see, it is only hazardous if both stub/pydrake and pydrake are pulled in as dependencies, which is a defect in itself (and should never be done).\n\nI'm not worried about drake_visualizer using the wrong pydrake, I'm worried about some other unrelated target pulling in the stub pydrake without really realizing it, while wanting to use the real pydrake.\n\nThe `stub` module's visibility is to the whole tools package (and cannot be narrowed to just drake_visualizer), and also deps are transitive, so its difficult to enforce in the build system that nothing but the single launcher script should ever use this stub.  Currently no targets are really at risk, but in the future there could be other things, like if the launcher turned into a py_library + py_binary and someone imported the library.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/8080)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}