{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/dom/pulls/comments/174436699","pull_request_review_id":103789697,"id":174436699,"diff_hunk":"@@ -1156,15 +1167,26 @@ for discussion).\n   <p class=\"note\"><var>legacy target override flag</var> is only used by HTML and only when\n   <var>target</var> is a {{Window}} object.\n \n- <li>Let <var>relatedTarget</var> be the result of <a>retargeting</a> <var>event</var>'s\n- <a for=Event>relatedTarget</a> against <var>target</var> if <var>event</var>'s\n- <a for=Event>relatedTarget</a> is non-null, and null otherwise.\n+ <li><p>Let <var>clearTargetsPostDispatch</var> be true if <var>target</var>, <var>event</var>'s\n+ <a for=Event>relatedTarget</a>, or an {{EventTarget}} object in <var>event</var>'s\n+ <a for=Event>touch target list</a> is a <a>node</a> and its <a for=tree>root</a> is a\n+ <a for=/>shadow root</a>, and false otherwise.\n+\n+ <li><p>Let <var>relatedTarget</var> be the result of <a>retargeting</a> <var>event</var>'s\n+ <a for=Event>relatedTarget</a> against <var>target</var>.\n \n  <li><p>If <var>target</var> is <var>relatedTarget</var> and <var>target</var> is not\n  <var>event</var>'s <a for=Event>relatedTarget</a>, then return true.\n+ <!-- XXX Since we return early, we might want to unset more flags here. See #402. -->","path":"dom.bs","position":73,"original_position":73,"commit_id":"5e320f30290d4ad905fd1f0fd98292306b943073","original_commit_id":"5e320f30290d4ad905fd1f0fd98292306b943073","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars0.githubusercontent.com/u/1544111?v=4","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"Should we also unset target et al here if clearTargetsPostDispatch is true? It seems that would be consistent... (If that's the case it seems we should turn this into a short algorithm that we invoke here and later on.)","created_at":"2018-03-14T12:06:09Z","updated_at":"2018-03-14T12:06:09Z","html_url":"https://github.com/whatwg/dom/pull/585#discussion_r174436699","pull_request_url":"https://api.github.com/repos/whatwg/dom/pulls/585","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/whatwg/dom/pulls/comments/174436699"},"html":{"href":"https://github.com/whatwg/dom/pull/585#discussion_r174436699"},"pull_request":{"href":"https://api.github.com/repos/whatwg/dom/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/dom/pulls/585","id":173649473,"html_url":"https://github.com/whatwg/dom/pull/585","diff_url":"https://github.com/whatwg/dom/pull/585.diff","patch_url":"https://github.com/whatwg/dom/pull/585.patch","issue_url":"https://api.github.com/repos/whatwg/dom/issues/585","number":585,"state":"open","locked":false,"title":"Correct setting of target and relatedTargets post-dispatch","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars0.githubusercontent.com/u/1544111?v=4","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"@whatwg/components this fixes the following:\n\n* Replaces relatedTarget with relatedTargets, so it works for touch events. (This will require some special handling for Touch objects, but I think it's workable.)\n* It now resets target/relatedTargets post-dispatch based on pre-dispatch conditions.\n* It makes dispatch account for non-nodes.\n\n(The one thing remaining here is having a good look at event constructors and making sure we can make that work for the relatedTargets design. I think that requires some kind of callback type thing.)\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://whatpr.org/dom/585.html\" title=\"Last updated on Mar 14, 2018, 11:51 AM GMT (5e320f3)\">Preview</a> | <a href=\"https://whatpr.org/dom/585/2bdabb1...5e320f3.html\" title=\"Last updated on Mar 14, 2018, 11:51 AM GMT (5e320f3)\">Diff</a>","created_at":"2018-03-08T05:33:36Z","updated_at":"2018-03-14T12:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afc1bae340f70d0bce111283646181ffec80d9da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":371408695,"url":"https://api.github.com/repos/whatwg/dom/labels/topic:%20shadow","name":"topic: shadow","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/dom/pulls/585/commits","review_comments_url":"https://api.github.com/repos/whatwg/dom/pulls/585/comments","review_comment_url":"https://api.github.com/repos/whatwg/dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/dom/issues/585/comments","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/5e320f30290d4ad905fd1f0fd98292306b943073","head":{"label":"whatwg:annevk/null-at-end-of-dispatch","ref":"annevk/null-at-end-of-dispatch","sha":"5e320f30290d4ad905fd1f0fd98292306b943073","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5581406,"name":"dom","full_name":"whatwg/dom","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/dom","description":"DOM Standard","fork":false,"url":"https://api.github.com/repos/whatwg/dom","forks_url":"https://api.github.com/repos/whatwg/dom/forks","keys_url":"https://api.github.com/repos/whatwg/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/dom/teams","hooks_url":"https://api.github.com/repos/whatwg/dom/hooks","issue_events_url":"https://api.github.com/repos/whatwg/dom/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/dom/events","assignees_url":"https://api.github.com/repos/whatwg/dom/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/dom/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/dom/tags","blobs_url":"https://api.github.com/repos/whatwg/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/dom/languages","stargazers_url":"https://api.github.com/repos/whatwg/dom/stargazers","contributors_url":"https://api.github.com/repos/whatwg/dom/contributors","subscribers_url":"https://api.github.com/repos/whatwg/dom/subscribers","subscription_url":"https://api.github.com/repos/whatwg/dom/subscription","commits_url":"https://api.github.com/repos/whatwg/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/dom/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/dom/merges","archive_url":"https://api.github.com/repos/whatwg/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/dom/downloads","issues_url":"https://api.github.com/repos/whatwg/dom/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/dom/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/dom/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/dom/deployments","created_at":"2012-08-28T05:59:06Z","updated_at":"2018-03-14T08:40:40Z","pushed_at":"2018-03-14T11:51:05Z","git_url":"git://github.com/whatwg/dom.git","ssh_url":"git@github.com:whatwg/dom.git","clone_url":"https://github.com/whatwg/dom.git","svn_url":"https://github.com/whatwg/dom","homepage":"https://dom.spec.whatwg.org/","size":43820,"stargazers_count":629,"watchers_count":629,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":107,"open_issues":90,"watchers":629,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"2bdabb15de8112d9783cf393a3d6c37911149f77","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5581406,"name":"dom","full_name":"whatwg/dom","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/dom","description":"DOM Standard","fork":false,"url":"https://api.github.com/repos/whatwg/dom","forks_url":"https://api.github.com/repos/whatwg/dom/forks","keys_url":"https://api.github.com/repos/whatwg/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/dom/teams","hooks_url":"https://api.github.com/repos/whatwg/dom/hooks","issue_events_url":"https://api.github.com/repos/whatwg/dom/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/dom/events","assignees_url":"https://api.github.com/repos/whatwg/dom/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/dom/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/dom/tags","blobs_url":"https://api.github.com/repos/whatwg/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/dom/languages","stargazers_url":"https://api.github.com/repos/whatwg/dom/stargazers","contributors_url":"https://api.github.com/repos/whatwg/dom/contributors","subscribers_url":"https://api.github.com/repos/whatwg/dom/subscribers","subscription_url":"https://api.github.com/repos/whatwg/dom/subscription","commits_url":"https://api.github.com/repos/whatwg/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/dom/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/dom/merges","archive_url":"https://api.github.com/repos/whatwg/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/dom/downloads","issues_url":"https://api.github.com/repos/whatwg/dom/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/dom/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/dom/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/dom/deployments","created_at":"2012-08-28T05:59:06Z","updated_at":"2018-03-14T08:40:40Z","pushed_at":"2018-03-14T11:51:05Z","git_url":"git://github.com/whatwg/dom.git","ssh_url":"git@github.com:whatwg/dom.git","clone_url":"https://github.com/whatwg/dom.git","svn_url":"https://github.com/whatwg/dom","homepage":"https://dom.spec.whatwg.org/","size":43820,"stargazers_count":629,"watchers_count":629,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":107,"open_issues":90,"watchers":629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/dom/pulls/585"},"html":{"href":"https://github.com/whatwg/dom/pull/585"},"issue":{"href":"https://api.github.com/repos/whatwg/dom/issues/585"},"comments":{"href":"https://api.github.com/repos/whatwg/dom/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/dom/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/dom/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/dom/statuses/5e320f30290d4ad905fd1f0fd98292306b943073"}},"author_association":"OWNER"}}
{"actor":{"display_login":"annevk"}}