{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/220297281","pull_request_review_id":158666380,"id":220297281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI5NzI4MQ==","diff_hunk":"@@ -70,6 +70,53 @@ struct FillWithRandomValuesImpl<Variables<tmpl::list<Tags...>>,\n /// \\endcond\n }  // namespace TestHelpers_detail\n \n+/// \\ingroup TestingFrameworkGroup\n+/// \\brief A uniform distribution functor for which the behavior can be easily\n+/// customized\n+///\n+/// \\details The two constructors take either a low and high bound arguments or\n+/// a similar 2-component array , which can be passed in in any type from which\n+/// the generated type can be constructed. The default generation function\n+/// operates as would be expected for a double\n+template <typename T>\n+struct uniform_custom_distribution {\n+  using result_type = T;","path":"tests/Utilities/MakeWithRandomValues.hpp","position":14,"original_position":14,"commit_id":"173e1bc800dcf5d05200b1475e2c7be1dbaff526","original_commit_id":"1207a06f152f4d24f0c13606b6f6ca5814a671cc","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"`value_type` seems more consistent with the STL, why `result_type`?","created_at":"2018-09-25T18:05:50Z","updated_at":"2018-09-25T18:15:08Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/989#discussion_r220297281","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/220297281"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/989#discussion_r220297281"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989","id":218035700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDM1NzAw","html_url":"https://github.com/sxs-collaboration/spectre/pull/989","diff_url":"https://github.com/sxs-collaboration/spectre/pull/989.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/989.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/989","number":989,"state":"open","locked":false,"title":"add functors for standard and blaze math functions","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nPut into `Utilities/Functional.hpp` are macros for unary, binary, and binary assign operators such\r\nthat functors can easily be generated from a function argument. This is then used to define\r\nfunctors associated with all supported operations on `DataVectors`. For convenience in writing type-generic code, step_function, invsqrt, and invcbrt are defined for primitives.\r\n\r\n### Types of changes:\r\n\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n","created_at":"2018-09-25T16:01:42Z","updated_at":"2018-09-25T18:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5310d537ae7cab592233e9226c27c52935d8d60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/989/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/173e1bc800dcf5d05200b1475e2c7be1dbaff526","head":{"label":"moxcodes:standardfunctionals","ref":"standardfunctionals","sha":"173e1bc800dcf5d05200b1475e2c7be1dbaff526","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"repo":{"id":147872565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzI1NjU=","name":"spectre","full_name":"moxcodes/spectre","private":false,"owner":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moxcodes/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/moxcodes/spectre","forks_url":"https://api.github.com/repos/moxcodes/spectre/forks","keys_url":"https://api.github.com/repos/moxcodes/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moxcodes/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moxcodes/spectre/teams","hooks_url":"https://api.github.com/repos/moxcodes/spectre/hooks","issue_events_url":"https://api.github.com/repos/moxcodes/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/moxcodes/spectre/events","assignees_url":"https://api.github.com/repos/moxcodes/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/moxcodes/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/moxcodes/spectre/tags","blobs_url":"https://api.github.com/repos/moxcodes/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moxcodes/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moxcodes/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/moxcodes/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moxcodes/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/moxcodes/spectre/languages","stargazers_url":"https://api.github.com/repos/moxcodes/spectre/stargazers","contributors_url":"https://api.github.com/repos/moxcodes/spectre/contributors","subscribers_url":"https://api.github.com/repos/moxcodes/spectre/subscribers","subscription_url":"https://api.github.com/repos/moxcodes/spectre/subscription","commits_url":"https://api.github.com/repos/moxcodes/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/moxcodes/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/moxcodes/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/moxcodes/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/moxcodes/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/moxcodes/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moxcodes/spectre/merges","archive_url":"https://api.github.com/repos/moxcodes/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moxcodes/spectre/downloads","issues_url":"https://api.github.com/repos/moxcodes/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/moxcodes/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/moxcodes/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/moxcodes/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moxcodes/spectre/labels{/name}","releases_url":"https://api.github.com/repos/moxcodes/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/moxcodes/spectre/deployments","created_at":"2018-09-07T20:39:07Z","updated_at":"2018-09-21T18:00:43Z","pushed_at":"2018-09-25T18:10:57Z","git_url":"git://github.com/moxcodes/spectre.git","ssh_url":"git@github.com:moxcodes/spectre.git","clone_url":"https://github.com/moxcodes/spectre.git","svn_url":"https://github.com/moxcodes/spectre","homepage":"","size":10784,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"9c296d02c237b1fa7b37e7eef07eb9c14c4373a7","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-09-25T14:57:30Z","pushed_at":"2018-09-25T18:10:59Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":11016,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":133,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/989"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/989"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/989/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/989/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/173e1bc800dcf5d05200b1475e2c7be1dbaff526"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nilsdeppe"}}