{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/199347145","pull_request_review_id":133451876,"id":199347145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTM0NzE0NQ==","diff_hunk":"@@ -0,0 +1,13 @@\n+PROCESSING_SUBSYSTEM_DEF(evac)\n+\tname = \"Evacuation\"\n+\tpriority = SS_PRIORITY_EVAC\n+\tflags = SS_BACKGROUND|SS_POST_FIRE_TIMING //We do init, with default order.\n+\twait = 2 SECONDS\n+\tprocess_proc = /datum/evacuation_controller/proc/process\n+\n+/datum/controller/subsystem/processing/evac/Initialize()","path":"code/controllers/subsystems/processing/evac.dm","position":8,"original_position":8,"commit_id":"4c42abc338897968741eeb8c247cd8621e4390ce","original_commit_id":"4c42abc338897968741eeb8c247cd8621e4390ce","user":{"login":"Zuhayr","id":2468979,"node_id":"MDQ6VXNlcjI0Njg5Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2468979?v=4","gravatar_id":"","url":"https://api.github.com/users/Zuhayr","html_url":"https://github.com/Zuhayr","followers_url":"https://api.github.com/users/Zuhayr/followers","following_url":"https://api.github.com/users/Zuhayr/following{/other_user}","gists_url":"https://api.github.com/users/Zuhayr/gists{/gist_id}","starred_url":"https://api.github.com/users/Zuhayr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zuhayr/subscriptions","organizations_url":"https://api.github.com/users/Zuhayr/orgs","repos_url":"https://api.github.com/users/Zuhayr/repos","events_url":"https://api.github.com/users/Zuhayr/events{/privacy}","received_events_url":"https://api.github.com/users/Zuhayr/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to call the wrapped datum's process from doWork()? That way you could CHECK_TICK even as a simple wrapping subsystem.","created_at":"2018-07-01T11:57:59Z","updated_at":"2018-07-01T11:57:59Z","html_url":"https://github.com/Baystation12/Baystation12/pull/22051#discussion_r199347145","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/199347145"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/22051#discussion_r199347145"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051","id":198246157,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjQ2MTU3","html_url":"https://github.com/Baystation12/Baystation12/pull/22051","diff_url":"https://github.com/Baystation12/Baystation12/pull/22051.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/22051.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/22051","number":22051,"state":"open","locked":false,"title":"More subsystems.","user":{"login":"afterthought2","id":36152617,"node_id":"MDQ6VXNlcjM2MTUyNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/36152617?v=4","gravatar_id":"","url":"https://api.github.com/users/afterthought2","html_url":"https://github.com/afterthought2","followers_url":"https://api.github.com/users/afterthought2/followers","following_url":"https://api.github.com/users/afterthought2/following{/other_user}","gists_url":"https://api.github.com/users/afterthought2/gists{/gist_id}","starred_url":"https://api.github.com/users/afterthought2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afterthought2/subscriptions","organizations_url":"https://api.github.com/users/afterthought2/orgs","repos_url":"https://api.github.com/users/afterthought2/repos","events_url":"https://api.github.com/users/afterthought2/events{/privacy}","received_events_url":"https://api.github.com/users/afterthought2/received_events","type":"User","site_admin":false},"body":"So far:\r\n\r\nSSevent\r\nSSinactivity (idlekick)\r\nSSshuttle\r\nSSradiation\r\nSSsupply\r\nSStrade\r\nSSevac\r\nSStgui\r\n\r\nCredit to Aurora for some of the code.\r\n\r\nAlso moved some landmark init code to SSshuttle. shuttle_landmarks no longer use tags and locate, and overmap sectors no longer loop through world to try and find all existing landmarks. Should fix random ERROR debug messages from appearing as well (these did not actually indicate any errors, just clumsy initialization handling).\r\n\r\nEvac SS is left as a wrapper for the evacuation_controller datum, as the choice of evac controller is map-dependent (and the code seems of good quality).","created_at":"2018-06-29T08:17:34Z","updated_at":"2018-07-01T11:57:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"047d755af2de4e2b5c636c8188fd42855aeff6e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":19402803,"node_id":"MDU6TGFiZWwxOTQwMjgwMw==","url":"https://api.github.com/repos/Baystation12/Baystation12/labels/Map","name":"Map","color":"76428A","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/22051/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/4c42abc338897968741eeb8c247cd8621e4390ce","head":{"label":"afterthought2:kill_the_master","ref":"kill_the_master","sha":"4c42abc338897968741eeb8c247cd8621e4390ce","user":{"login":"afterthought2","id":36152617,"node_id":"MDQ6VXNlcjM2MTUyNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/36152617?v=4","gravatar_id":"","url":"https://api.github.com/users/afterthought2","html_url":"https://github.com/afterthought2","followers_url":"https://api.github.com/users/afterthought2/followers","following_url":"https://api.github.com/users/afterthought2/following{/other_user}","gists_url":"https://api.github.com/users/afterthought2/gists{/gist_id}","starred_url":"https://api.github.com/users/afterthought2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afterthought2/subscriptions","organizations_url":"https://api.github.com/users/afterthought2/orgs","repos_url":"https://api.github.com/users/afterthought2/repos","events_url":"https://api.github.com/users/afterthought2/events{/privacy}","received_events_url":"https://api.github.com/users/afterthought2/received_events","type":"User","site_admin":false},"repo":{"id":124997251,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5OTcyNTE=","name":"Baystation12","full_name":"afterthought2/Baystation12","owner":{"login":"afterthought2","id":36152617,"node_id":"MDQ6VXNlcjM2MTUyNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/36152617?v=4","gravatar_id":"","url":"https://api.github.com/users/afterthought2","html_url":"https://github.com/afterthought2","followers_url":"https://api.github.com/users/afterthought2/followers","following_url":"https://api.github.com/users/afterthought2/following{/other_user}","gists_url":"https://api.github.com/users/afterthought2/gists{/gist_id}","starred_url":"https://api.github.com/users/afterthought2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afterthought2/subscriptions","organizations_url":"https://api.github.com/users/afterthought2/orgs","repos_url":"https://api.github.com/users/afterthought2/repos","events_url":"https://api.github.com/users/afterthought2/events{/privacy}","received_events_url":"https://api.github.com/users/afterthought2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afterthought2/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/afterthought2/Baystation12","forks_url":"https://api.github.com/repos/afterthought2/Baystation12/forks","keys_url":"https://api.github.com/repos/afterthought2/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afterthought2/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afterthought2/Baystation12/teams","hooks_url":"https://api.github.com/repos/afterthought2/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/afterthought2/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/afterthought2/Baystation12/events","assignees_url":"https://api.github.com/repos/afterthought2/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/afterthought2/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/afterthought2/Baystation12/tags","blobs_url":"https://api.github.com/repos/afterthought2/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afterthought2/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afterthought2/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/afterthought2/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afterthought2/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/afterthought2/Baystation12/languages","stargazers_url":"https://api.github.com/repos/afterthought2/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/afterthought2/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/afterthought2/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/afterthought2/Baystation12/subscription","commits_url":"https://api.github.com/repos/afterthought2/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/afterthought2/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/afterthought2/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/afterthought2/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/afterthought2/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/afterthought2/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afterthought2/Baystation12/merges","archive_url":"https://api.github.com/repos/afterthought2/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afterthought2/Baystation12/downloads","issues_url":"https://api.github.com/repos/afterthought2/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/afterthought2/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/afterthought2/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/afterthought2/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afterthought2/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/afterthought2/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/afterthought2/Baystation12/deployments","created_at":"2018-03-13T05:29:21Z","updated_at":"2018-06-30T23:41:09Z","pushed_at":"2018-07-01T01:52:17Z","git_url":"git://github.com/afterthought2/Baystation12.git","ssh_url":"git@github.com:afterthought2/Baystation12.git","clone_url":"https://github.com/afterthought2/Baystation12.git","svn_url":"https://github.com/afterthought2/Baystation12","homepage":"http://baystation12.net/","size":833501,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"a32be4580cfed424a4dc709c9c25acdbbb30ef90","user":{"login":"Baystation12","id":1174322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE1OTMz","name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2018-07-01T02:51:07Z","pushed_at":"2018-07-01T10:50:00Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":833256,"stargazers_count":282,"watchers_count":282,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1000,"mirror_url":null,"archived":false,"open_issues_count":1008,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1000,"open_issues":1008,"watchers":282,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/22051"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/22051"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/22051/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/22051/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/4c42abc338897968741eeb8c247cd8621e4390ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Zuhayr"}}