{"action":"opened","issue":{"url":"https://api.github.com/repos/MichielCuijpers/violet-conversations/issues/4","repository_url":"https://api.github.com/repos/MichielCuijpers/violet-conversations","labels_url":"https://api.github.com/repos/MichielCuijpers/violet-conversations/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/MichielCuijpers/violet-conversations/issues/4/comments","events_url":"https://api.github.com/repos/MichielCuijpers/violet-conversations/issues/4/events","html_url":"https://github.com/MichielCuijpers/violet-conversations/issues/4","id":294386087,"number":4,"title":"Refactor violetList.js:exports","user":{"login":"MichielCuijpers","id":18576001,"avatar_url":"https://avatars0.githubusercontent.com/u/18576001?v=4","gravatar_id":"","url":"https://api.github.com/users/MichielCuijpers","html_url":"https://github.com/MichielCuijpers","followers_url":"https://api.github.com/users/MichielCuijpers/followers","following_url":"https://api.github.com/users/MichielCuijpers/following{/other_user}","gists_url":"https://api.github.com/users/MichielCuijpers/gists{/gist_id}","starred_url":"https://api.github.com/users/MichielCuijpers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichielCuijpers/subscriptions","organizations_url":"https://api.github.com/users/MichielCuijpers/orgs","repos_url":"https://api.github.com/users/MichielCuijpers/repos","events_url":"https://api.github.com/users/MichielCuijpers/events{/privacy}","received_events_url":"https://api.github.com/users/MichielCuijpers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T13:05:36Z","updated_at":"2018-02-05T13:05:36Z","closed_at":null,"author_association":"OWNER","body":"I've selected [**violetList.js:exports**](https://github.com/MichielCuijpers/violet-conversations/blob/df6603383409f2c4f064ed1f72577e754655a1d9/lib/violetList.js#L27-L162) for refactoring, which is a unit of **23** lines of code and **5** parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's **Keep Unit Interfaces Small** guideline rating! 👍 \r\n\r\nHere's the gist of this guideline:\r\n- **Guideline definition** 📖 \r\nLimit the number of parameters per unit to at most 4.\r\n- **Why**❓ \r\nKeeping the number of parameters low makes units easier to understand, test and reuse.\r\n- **How** 🔧 \r\nReduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.\r\n\r\nYou can find more info about this guideline in [Building Maintainable Software](http://shop.oreilly.com/product/0636920049159.do). 📖 \r\n \r\n---- \r\nℹ️ In order to know how many _other_ candidates you have to fix to get a guideline compliant, make a selection of candidates by clicking on the 🔲  next to a proposed refactoring candidate. The risk profile below the candidates list will signal (✅) when it's enough! 🏁 \r\n\r\n\r\n----\r\nGood luck and happy coding! :shipit: :sparkles: :100:"}}
{"actor":{"display_login":"MichielCuijpers"}}