{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/184554616","pull_request_review_id":115402135,"id":184554616,"diff_hunk":"@@ -0,0 +1,32 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE topic\n+  PUBLIC \"-//OASIS//DTD DITA Composite//EN\" \"ditabase.dtd\">\n+<topic id=\"topic1\">\n+  <title id=\"pa137116\">cleanup_plugin_for_restore</title>\n+  <body>\n+    <p>Plugin command to clean up a storage plugin after restore.</p>\n+    <section id=\"section2\">\n+      <title>Synopsis</title>\n+      <codeblock><varname>plugin_executable</varname> <b>cleanup_plugin_for_restore</b> <varname>plugin_config_file</varname> <varname>local_backup_dir</varname></codeblock>\n+    </section>\n+    <section id=\"section3\">\n+      <title>Description</title>\n+      <p><codeph>gprestore</codeph> invokes the <codeph>cleanup_plugin_for_restore</codeph> plugin command on the master and all segment hosts when a <codeph>gprestore</codeph> operation completes, both in success and failure cases.</p>\n+      <p>The <codeph>cleanup_plugin_for_restore</codeph> command should perform the actions necessary to clean up the remote storage system after a restore. Clean up activities may include removing remote directories or temporary files created during the restore, disconnecting from the backup service, etc.</p>","path":"gpdb-doc/dita/admin_guide/managing/plugin_api/cleanup_plugin_for_restore.xml","position":15,"original_position":15,"commit_id":"83176f757fb186f0d70d461e458b4c3713652d62","original_commit_id":"83176f757fb186f0d70d461e458b4c3713652d62","user":{"login":"dyozie","id":5695830,"avatar_url":"https://avatars0.githubusercontent.com/u/5695830?v=4","gravatar_id":"","url":"https://api.github.com/users/dyozie","html_url":"https://github.com/dyozie","followers_url":"https://api.github.com/users/dyozie/followers","following_url":"https://api.github.com/users/dyozie/following{/other_user}","gists_url":"https://api.github.com/users/dyozie/gists{/gist_id}","starred_url":"https://api.github.com/users/dyozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyozie/subscriptions","organizations_url":"https://api.github.com/users/dyozie/orgs","repos_url":"https://api.github.com/users/dyozie/repos","events_url":"https://api.github.com/users/dyozie/events{/privacy}","received_events_url":"https://api.github.com/users/dyozie/received_events","type":"User","site_admin":false},"body":"command -> implementation","created_at":"2018-04-26T23:03:21Z","updated_at":"2018-04-26T23:03:41Z","html_url":"https://github.com/greenplum-db/gpdb/pull/4901#discussion_r184554616","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/184554616"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/4901#discussion_r184554616"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901","id":184189259,"html_url":"https://github.com/greenplum-db/gpdb/pull/4901","diff_url":"https://github.com/greenplum-db/gpdb/pull/4901.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/4901.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/4901","number":4901,"state":"open","locked":false,"title":"docs - add content for backup storage plugin api","user":{"login":"lisakowen","id":19785845,"avatar_url":"https://avatars2.githubusercontent.com/u/19785845?v=4","gravatar_id":"","url":"https://api.github.com/users/lisakowen","html_url":"https://github.com/lisakowen","followers_url":"https://api.github.com/users/lisakowen/followers","following_url":"https://api.github.com/users/lisakowen/following{/other_user}","gists_url":"https://api.github.com/users/lisakowen/gists{/gist_id}","starred_url":"https://api.github.com/users/lisakowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisakowen/subscriptions","organizations_url":"https://api.github.com/users/lisakowen/orgs","repos_url":"https://api.github.com/users/lisakowen/repos","events_url":"https://api.github.com/users/lisakowen/events{/privacy}","received_events_url":"https://api.github.com/users/lisakowen/received_events","type":"User","site_admin":false},"body":"added content for backup plugins to the admin guide \"Parallel Backup with gpbackup and gprestore\" section.  (there is no developer guide...):\r\n- referring to the API as the \"Greenplum Database Backup Storage Plugin API\".  kind of a mouthful, suggestions welcome.\r\n- created man-page-ish pages for each command\r\n- documented the API, providing design/implementation considerations for developing.  could use more info in this section.\r\n- would like to include a diagram - will try to get that in\r\n- audience is plugin developer.  this person may not be the greenplum database administrator.\r\n\r\nquestions:\r\n- did not include the subtopics or commands in the left subnav - should i?\r\n- the gpbackup end user docs do not currently discuss gpbackup_helper ... is this an important topic for the plugin API docs?\r\n\r\nlink to doc review site:\r\n- http://docs-gpdb-review-staging.cfapps.io/review/admin_guide/managing/backup-plugin-api.html\r\n","created_at":"2018-04-25T23:25:08Z","updated_at":"2018-04-26T23:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"872cdcfa5a9d322ac4ff441a65ba393b13e9f495","assignee":null,"assignees":[],"requested_reviewers":[{"login":"oakbarrett","id":1195118,"avatar_url":"https://avatars2.githubusercontent.com/u/1195118?v=4","gravatar_id":"","url":"https://api.github.com/users/oakbarrett","html_url":"https://github.com/oakbarrett","followers_url":"https://api.github.com/users/oakbarrett/followers","following_url":"https://api.github.com/users/oakbarrett/following{/other_user}","gists_url":"https://api.github.com/users/oakbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/oakbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakbarrett/subscriptions","organizations_url":"https://api.github.com/users/oakbarrett/orgs","repos_url":"https://api.github.com/users/oakbarrett/repos","events_url":"https://api.github.com/users/oakbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/oakbarrett/received_events","type":"User","site_admin":false},{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars3.githubusercontent.com/u/1610524?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},{"login":"khuddlefish","id":4099765,"avatar_url":"https://avatars2.githubusercontent.com/u/4099765?v=4","gravatar_id":"","url":"https://api.github.com/users/khuddlefish","html_url":"https://github.com/khuddlefish","followers_url":"https://api.github.com/users/khuddlefish/followers","following_url":"https://api.github.com/users/khuddlefish/following{/other_user}","gists_url":"https://api.github.com/users/khuddlefish/gists{/gist_id}","starred_url":"https://api.github.com/users/khuddlefish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khuddlefish/subscriptions","organizations_url":"https://api.github.com/users/khuddlefish/orgs","repos_url":"https://api.github.com/users/khuddlefish/repos","events_url":"https://api.github.com/users/khuddlefish/events{/privacy}","received_events_url":"https://api.github.com/users/khuddlefish/received_events","type":"User","site_admin":false},{"login":"mkiyama","id":6181658,"avatar_url":"https://avatars0.githubusercontent.com/u/6181658?v=4","gravatar_id":"","url":"https://api.github.com/users/mkiyama","html_url":"https://github.com/mkiyama","followers_url":"https://api.github.com/users/mkiyama/followers","following_url":"https://api.github.com/users/mkiyama/following{/other_user}","gists_url":"https://api.github.com/users/mkiyama/gists{/gist_id}","starred_url":"https://api.github.com/users/mkiyama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkiyama/subscriptions","organizations_url":"https://api.github.com/users/mkiyama/orgs","repos_url":"https://api.github.com/users/mkiyama/repos","events_url":"https://api.github.com/users/mkiyama/events{/privacy}","received_events_url":"https://api.github.com/users/mkiyama/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/4901/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/83176f757fb186f0d70d461e458b4c3713652d62","head":{"label":"lisakowen:feature/backres-pluginapi-work","ref":"feature/backres-pluginapi-work","sha":"83176f757fb186f0d70d461e458b4c3713652d62","user":{"login":"lisakowen","id":19785845,"avatar_url":"https://avatars2.githubusercontent.com/u/19785845?v=4","gravatar_id":"","url":"https://api.github.com/users/lisakowen","html_url":"https://github.com/lisakowen","followers_url":"https://api.github.com/users/lisakowen/followers","following_url":"https://api.github.com/users/lisakowen/following{/other_user}","gists_url":"https://api.github.com/users/lisakowen/gists{/gist_id}","starred_url":"https://api.github.com/users/lisakowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisakowen/subscriptions","organizations_url":"https://api.github.com/users/lisakowen/orgs","repos_url":"https://api.github.com/users/lisakowen/repos","events_url":"https://api.github.com/users/lisakowen/events{/privacy}","received_events_url":"https://api.github.com/users/lisakowen/received_events","type":"User","site_admin":false},"repo":{"id":80570844,"name":"gpdb","full_name":"lisakowen/gpdb","owner":{"login":"lisakowen","id":19785845,"avatar_url":"https://avatars2.githubusercontent.com/u/19785845?v=4","gravatar_id":"","url":"https://api.github.com/users/lisakowen","html_url":"https://github.com/lisakowen","followers_url":"https://api.github.com/users/lisakowen/followers","following_url":"https://api.github.com/users/lisakowen/following{/other_user}","gists_url":"https://api.github.com/users/lisakowen/gists{/gist_id}","starred_url":"https://api.github.com/users/lisakowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisakowen/subscriptions","organizations_url":"https://api.github.com/users/lisakowen/orgs","repos_url":"https://api.github.com/users/lisakowen/repos","events_url":"https://api.github.com/users/lisakowen/events{/privacy}","received_events_url":"https://api.github.com/users/lisakowen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lisakowen/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/lisakowen/gpdb","forks_url":"https://api.github.com/repos/lisakowen/gpdb/forks","keys_url":"https://api.github.com/repos/lisakowen/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lisakowen/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lisakowen/gpdb/teams","hooks_url":"https://api.github.com/repos/lisakowen/gpdb/hooks","issue_events_url":"https://api.github.com/repos/lisakowen/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/lisakowen/gpdb/events","assignees_url":"https://api.github.com/repos/lisakowen/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/lisakowen/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/lisakowen/gpdb/tags","blobs_url":"https://api.github.com/repos/lisakowen/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lisakowen/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lisakowen/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lisakowen/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lisakowen/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/lisakowen/gpdb/languages","stargazers_url":"https://api.github.com/repos/lisakowen/gpdb/stargazers","contributors_url":"https://api.github.com/repos/lisakowen/gpdb/contributors","subscribers_url":"https://api.github.com/repos/lisakowen/gpdb/subscribers","subscription_url":"https://api.github.com/repos/lisakowen/gpdb/subscription","commits_url":"https://api.github.com/repos/lisakowen/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lisakowen/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lisakowen/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lisakowen/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lisakowen/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/lisakowen/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lisakowen/gpdb/merges","archive_url":"https://api.github.com/repos/lisakowen/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lisakowen/gpdb/downloads","issues_url":"https://api.github.com/repos/lisakowen/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/lisakowen/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/lisakowen/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/lisakowen/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lisakowen/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/lisakowen/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/lisakowen/gpdb/deployments","created_at":"2017-01-31T22:56:53Z","updated_at":"2018-04-26T17:46:20Z","pushed_at":"2018-04-26T22:24:34Z","git_url":"git://github.com/lisakowen/gpdb.git","ssh_url":"git@github.com:lisakowen/gpdb.git","clone_url":"https://github.com/lisakowen/gpdb.git","svn_url":"https://github.com/lisakowen/gpdb","homepage":"http://greenplum.org","size":265243,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"b960d9811097f066128ec615b6e320f9a1970c7f","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-04-26T22:00:18Z","pushed_at":"2018-04-26T22:42:55Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":267064,"stargazers_count":2419,"watchers_count":2419,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":750,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":750,"open_issues":218,"watchers":2419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/4901"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/4901"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/4901/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/4901/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/83176f757fb186f0d70d461e458b4c3713652d62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dyozie"}}