{"action":"created","comment":{"url":"https://api.github.com/repos/runelite/runelite/pulls/comments/206021621","pull_request_review_id":141399943,"id":206021621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjAyMTYyMQ==","diff_hunk":"@@ -96,4 +96,9 @@ public boolean cull()\n \t\treturn timeLeft.isZero() || timeLeft.isNegative();\n \t}\n \n+\tpublic long secondsPassed()","path":"runelite-client/src/main/java/net/runelite/client/ui/overlay/infobox/Timer.java","position":4,"original_position":4,"commit_id":"34f6dd1e3f230810fb57968b7d15db435d40e249","original_commit_id":"cbd700e3227d2e3c99da68dfca16b062aedeab18","user":{"login":"deathbeam","id":5115805,"node_id":"MDQ6VXNlcjUxMTU4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5115805?v=4","gravatar_id":"","url":"https://api.github.com/users/deathbeam","html_url":"https://github.com/deathbeam","followers_url":"https://api.github.com/users/deathbeam/followers","following_url":"https://api.github.com/users/deathbeam/following{/other_user}","gists_url":"https://api.github.com/users/deathbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbeam/subscriptions","organizations_url":"https://api.github.com/users/deathbeam/orgs","repos_url":"https://api.github.com/users/deathbeam/repos","events_url":"https://api.github.com/users/deathbeam/events{/privacy}","received_events_url":"https://api.github.com/users/deathbeam/received_events","type":"User","site_admin":false},"body":"Yeah, getter for endTime seems fine","created_at":"2018-07-30T06:00:03Z","updated_at":"2018-07-30T06:00:03Z","html_url":"https://github.com/runelite/runelite/pull/4551#discussion_r206021621","pull_request_url":"https://api.github.com/repos/runelite/runelite/pulls/4551","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments/206021621"},"html":{"href":"https://github.com/runelite/runelite/pull/4551#discussion_r206021621"},"pull_request":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4551"}},"in_reply_to_id":205989967},"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/4551","id":204633295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjMzMjk1","html_url":"https://github.com/runelite/runelite/pull/4551","diff_url":"https://github.com/runelite/runelite/pull/4551.diff","patch_url":"https://github.com/runelite/runelite/pull/4551.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/4551","number":4551,"state":"open","locked":false,"title":"Ancient timers revisited","user":{"login":"devOSRS","id":38792370,"node_id":"MDQ6VXNlcjM4NzkyMzcw","avatar_url":"https://avatars3.githubusercontent.com/u/38792370?v=4","gravatar_id":"","url":"https://api.github.com/users/devOSRS","html_url":"https://github.com/devOSRS","followers_url":"https://api.github.com/users/devOSRS/followers","following_url":"https://api.github.com/users/devOSRS/following{/other_user}","gists_url":"https://api.github.com/users/devOSRS/gists{/gist_id}","starred_url":"https://api.github.com/users/devOSRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devOSRS/subscriptions","organizations_url":"https://api.github.com/users/devOSRS/orgs","repos_url":"https://api.github.com/users/devOSRS/repos","events_url":"https://api.github.com/users/devOSRS/events{/privacy}","received_events_url":"https://api.github.com/users/devOSRS/received_events","type":"User","site_admin":false},"body":"Ancient timers don't reset per https://github.com/runelite/runelite/pull/4300.\r\n\r\nThe following has been added:\r\n\r\n1. All freeze timers are triggered upon \"You have been frozen!\" message, instead of graphic. Two situations where graphic shows up and you have not been frozen are: (1) barrage clumps- people running close by and immune targets that have been recently unfrozen, (2) when someone freezes you off the rendered map (i.e.: opponent runs in the opposite direction).\r\n2. Graphics act as a filter. Upon successful freeze/triggering of timers in (1) above. Then the graphic event is checked and only the matching graphic/timer is kept. If no graphic shows up, **all timers are kept**. This was a design choice to keep all timers running as reference as we don't really know which spell was casted. After this all timers are kept until they run out\r\n3. In the case that you have been frozen and the caster runs off the map (setting you free), we have two options to reset the timer: (1) check if the list of opponents attacking the player in the rendered map is empty, or (2) if the player is able to move. I chose the latter.\r\n\r\n\r\n![timers](https://user-images.githubusercontent.com/38792370/43364718-7a6d18ea-92d4-11e8-915c-725a7da33cc6.gif)\r\n\r\nEDIT: some typos","created_at":"2018-07-29T09:22:42Z","updated_at":"2018-07-30T06:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2236c063b86de8a09f1a769628e5789c40b7c903","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":771846940,"node_id":"MDU6TGFiZWw3NzE4NDY5NDA=","url":"https://api.github.com/repos/runelite/runelite/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/4551/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/4551/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/4551/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/34f6dd1e3f230810fb57968b7d15db435d40e249","head":{"label":"devOSRS:ancient-timers","ref":"ancient-timers","sha":"34f6dd1e3f230810fb57968b7d15db435d40e249","user":{"login":"devOSRS","id":38792370,"node_id":"MDQ6VXNlcjM4NzkyMzcw","avatar_url":"https://avatars3.githubusercontent.com/u/38792370?v=4","gravatar_id":"","url":"https://api.github.com/users/devOSRS","html_url":"https://github.com/devOSRS","followers_url":"https://api.github.com/users/devOSRS/followers","following_url":"https://api.github.com/users/devOSRS/following{/other_user}","gists_url":"https://api.github.com/users/devOSRS/gists{/gist_id}","starred_url":"https://api.github.com/users/devOSRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devOSRS/subscriptions","organizations_url":"https://api.github.com/users/devOSRS/orgs","repos_url":"https://api.github.com/users/devOSRS/repos","events_url":"https://api.github.com/users/devOSRS/events{/privacy}","received_events_url":"https://api.github.com/users/devOSRS/received_events","type":"User","site_admin":false},"repo":{"id":142718289,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MTgyODk=","name":"runelite","full_name":"devOSRS/runelite","owner":{"login":"devOSRS","id":38792370,"node_id":"MDQ6VXNlcjM4NzkyMzcw","avatar_url":"https://avatars3.githubusercontent.com/u/38792370?v=4","gravatar_id":"","url":"https://api.github.com/users/devOSRS","html_url":"https://github.com/devOSRS","followers_url":"https://api.github.com/users/devOSRS/followers","following_url":"https://api.github.com/users/devOSRS/following{/other_user}","gists_url":"https://api.github.com/users/devOSRS/gists{/gist_id}","starred_url":"https://api.github.com/users/devOSRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devOSRS/subscriptions","organizations_url":"https://api.github.com/users/devOSRS/orgs","repos_url":"https://api.github.com/users/devOSRS/repos","events_url":"https://api.github.com/users/devOSRS/events{/privacy}","received_events_url":"https://api.github.com/users/devOSRS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devOSRS/runelite","description":"Open source Old School RuneScape client","fork":true,"url":"https://api.github.com/repos/devOSRS/runelite","forks_url":"https://api.github.com/repos/devOSRS/runelite/forks","keys_url":"https://api.github.com/repos/devOSRS/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devOSRS/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devOSRS/runelite/teams","hooks_url":"https://api.github.com/repos/devOSRS/runelite/hooks","issue_events_url":"https://api.github.com/repos/devOSRS/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/devOSRS/runelite/events","assignees_url":"https://api.github.com/repos/devOSRS/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/devOSRS/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/devOSRS/runelite/tags","blobs_url":"https://api.github.com/repos/devOSRS/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devOSRS/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devOSRS/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/devOSRS/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devOSRS/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/devOSRS/runelite/languages","stargazers_url":"https://api.github.com/repos/devOSRS/runelite/stargazers","contributors_url":"https://api.github.com/repos/devOSRS/runelite/contributors","subscribers_url":"https://api.github.com/repos/devOSRS/runelite/subscribers","subscription_url":"https://api.github.com/repos/devOSRS/runelite/subscription","commits_url":"https://api.github.com/repos/devOSRS/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/devOSRS/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/devOSRS/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/devOSRS/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/devOSRS/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/devOSRS/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devOSRS/runelite/merges","archive_url":"https://api.github.com/repos/devOSRS/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devOSRS/runelite/downloads","issues_url":"https://api.github.com/repos/devOSRS/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/devOSRS/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/devOSRS/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/devOSRS/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devOSRS/runelite/labels{/name}","releases_url":"https://api.github.com/repos/devOSRS/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/devOSRS/runelite/deployments","created_at":"2018-07-29T00:05:23Z","updated_at":"2018-07-29T00:05:29Z","pushed_at":"2018-07-29T23:11:30Z","git_url":"git://github.com/devOSRS/runelite.git","ssh_url":"git@github.com:devOSRS/runelite.git","clone_url":"https://github.com/devOSRS/runelite.git","svn_url":"https://github.com/devOSRS/runelite","homepage":"https://runelite.net","size":17878,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"1d9b1375a298515eba8aa10b7d530eb44e617671","user":{"login":"runelite","id":13814776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODE0Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQ2MTIxMw==","name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODE0Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-07-30T01:45:04Z","pushed_at":"2018-07-30T04:41:22Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":17883,"stargazers_count":1123,"watchers_count":1123,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1451,"mirror_url":null,"archived":false,"open_issues_count":1158,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1451,"open_issues":1158,"watchers":1123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4551"},"html":{"href":"https://github.com/runelite/runelite/pull/4551"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/4551"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/4551/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4551/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4551/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/34f6dd1e3f230810fb57968b7d15db435d40e249"}},"author_association":"NONE"}}
{"actor":{"display_login":"deathbeam"}}