{"action":"closed","issue":{"url":"https://api.github.com/repos/golang/go/issues/25957","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/25957/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/25957/comments","events_url":"https://api.github.com/repos/golang/go/issues/25957/events","html_url":"https://github.com/golang/go/issues/25957","id":333641847,"node_id":"MDU6SXNzdWUzMzM2NDE4NDc=","number":25957,"title":"x/vgo: non Go source files (eg descriptor.proto) and generated code (eg )","user":{"login":"millergarym","id":769330,"node_id":"MDQ6VXNlcjc2OTMzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/769330?v=4","gravatar_id":"","url":"https://api.github.com/users/millergarym","html_url":"https://github.com/millergarym","followers_url":"https://api.github.com/users/millergarym/followers","following_url":"https://api.github.com/users/millergarym/following{/other_user}","gists_url":"https://api.github.com/users/millergarym/gists{/gist_id}","starred_url":"https://api.github.com/users/millergarym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millergarym/subscriptions","organizations_url":"https://api.github.com/users/millergarym/orgs","repos_url":"https://api.github.com/users/millergarym/repos","events_url":"https://api.github.com/users/millergarym/events{/privacy}","received_events_url":"https://api.github.com/users/millergarym/received_events","type":"User","site_admin":false},"labels":[{"id":373399998,"node_id":"MDU6TGFiZWwzNzMzOTk5OTg=","url":"https://api.github.com/repos/golang/go/labels/NeedsFix","name":"NeedsFix","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/71","html_url":"https://github.com/golang/go/milestone/71","labels_url":"https://api.github.com/repos/golang/go/milestones/71/labels","id":3130892,"node_id":"MDk6TWlsZXN0b25lMzEzMDg5Mg==","number":71,"title":"vgo","description":null,"creator":{"login":"rsc","id":104030,"node_id":"MDQ6VXNlcjEwNDAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":220,"state":"open","created_at":"2018-02-20T19:51:55Z","updated_at":"2018-07-06T04:34:45Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-06-19T12:06:19Z","updated_at":"2018-07-06T04:34:45Z","closed_at":"2018-07-06T04:34:45Z","author_association":"NONE","body":"### What version of Go are you using (`go version`)?\r\ngo version go1.10.3 windows/amd64\r\n\r\n### Does this issue reproduce with the latest release?\r\nyes\r\n\r\n### What did you do?\r\n#### Path to non-Go source files\r\nUsing `go generate` or other scripts to run protoc the directory containing protobuf is needed (for includes). This is now dynamic, depending on the version of `github.com/golang/protobuf`. This issue exists for all non Go code, protobufs are being used as a concrete example.\r\n\r\nThe directory has changed from \r\n\r\n`$GOPATH/src/github.com/golang/protobuf/protoc-gen-go/`\r\n\r\nto\r\n\r\n`$GOPATH/src/mod/github.com/golang/protobuf@v1.1.0/protoc-gen-go/`\r\n\r\n#### Generated Go code (not in the top level vendor directory)\r\nAs part of a clean build multiple packages may need to generate code. Restricting generated code to all be in the top level vendor directory is constraining. Eg. protobuf extensions.\r\n\r\n### Discussion\r\n#### Path to non-Go source files\r\n\r\n- The format  rules for `vgo list` might be enough to construct a path to the thirdparty source. \r\n- A simple argument to `vgo` to get the path\r\n- Some environment variable or template expansion by `go generate`\r\n\r\n#### Generated Go code (not in the top level vendor directory)\r\n\r\nAny suggestions?\r\n\r\n\r\n"}}
{"actor":{"display_login":"rsc"}}