{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/197365234","pull_request_review_id":131095617,"id":197365234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzM2NTIzNA==","diff_hunk":"@@ -87,14 +92,14 @@ def wrapper(self, method, args, kwargs):\n     except TypeCheckError as e:\n       error_msg = ('Runtime type violation detected within ParDo(%s): '\n                    '%s' % (self.full_label, e))\n-      six.raise_from(TypeCheckError(error_msg), sys.exc_info()[2])\n+      raise_with_traceback(TypeCheckError(error_msg))\n     else:\n       return self._check_type(result)\n \n   def _check_type(self, output):\n     if output is None:\n       return output\n-    elif isinstance(output, (dict,) + six.string_types):\n+    elif isinstance(output, (dict, str, unicode)):","path":"sdks/python/apache_beam/typehints/typecheck.py","position":41,"original_position":41,"commit_id":"e73d150a9b59f9c8d5ccae898e9e1a7b0fd28115","original_commit_id":"4fc7965ba67fd22a7a7c4a3935ec295aca2811be","user":{"login":"RobbeSneyders","id":20990866,"node_id":"MDQ6VXNlcjIwOTkwODY2","avatar_url":"https://avatars0.githubusercontent.com/u/20990866?v=4","gravatar_id":"","url":"https://api.github.com/users/RobbeSneyders","html_url":"https://github.com/RobbeSneyders","followers_url":"https://api.github.com/users/RobbeSneyders/followers","following_url":"https://api.github.com/users/RobbeSneyders/following{/other_user}","gists_url":"https://api.github.com/users/RobbeSneyders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobbeSneyders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobbeSneyders/subscriptions","organizations_url":"https://api.github.com/users/RobbeSneyders/orgs","repos_url":"https://api.github.com/users/RobbeSneyders/repos","events_url":"https://api.github.com/users/RobbeSneyders/events{/privacy}","received_events_url":"https://api.github.com/users/RobbeSneyders/received_events","type":"User","site_admin":false},"body":"You're right. We also want to trigger this path for `bytes`.\r\nI'll add it.","created_at":"2018-06-22T07:47:47Z","updated_at":"2018-06-22T07:47:48Z","html_url":"https://github.com/apache/beam/pull/5337#discussion_r197365234","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/5337","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/197365234"},"html":{"href":"https://github.com/apache/beam/pull/5337#discussion_r197365234"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/5337"}},"in_reply_to_id":196943031},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/5337","id":187481954,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NDgxOTU0","html_url":"https://github.com/apache/beam/pull/5337","diff_url":"https://github.com/apache/beam/pull/5337.diff","patch_url":"https://github.com/apache/beam/pull/5337.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/5337","number":5337,"state":"open","locked":false,"title":"[BEAM-4007] Futurize typehints subpackage","user":{"login":"RobbeSneyders","id":20990866,"node_id":"MDQ6VXNlcjIwOTkwODY2","avatar_url":"https://avatars0.githubusercontent.com/u/20990866?v=4","gravatar_id":"","url":"https://api.github.com/users/RobbeSneyders","html_url":"https://github.com/RobbeSneyders","followers_url":"https://api.github.com/users/RobbeSneyders/followers","following_url":"https://api.github.com/users/RobbeSneyders/following{/other_user}","gists_url":"https://api.github.com/users/RobbeSneyders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobbeSneyders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobbeSneyders/subscriptions","organizations_url":"https://api.github.com/users/RobbeSneyders/orgs","repos_url":"https://api.github.com/users/RobbeSneyders/repos","events_url":"https://api.github.com/users/RobbeSneyders/events{/privacy}","received_events_url":"https://api.github.com/users/RobbeSneyders/received_events","type":"User","site_admin":false},"body":"This pull request prepares the typehints subpackage for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.\r\nThis approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.\r\n\r\nR: @aaltay @tvalentyn","created_at":"2018-05-11T14:35:31Z","updated_at":"2018-06-22T07:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35134718e4136ab9d3afb25f5471a091cd32917f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/5337/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/5337/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/5337/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/e73d150a9b59f9c8d5ccae898e9e1a7b0fd28115","head":{"label":"RobbeSneyders:typehints","ref":"typehints","sha":"e73d150a9b59f9c8d5ccae898e9e1a7b0fd28115","user":{"login":"RobbeSneyders","id":20990866,"node_id":"MDQ6VXNlcjIwOTkwODY2","avatar_url":"https://avatars0.githubusercontent.com/u/20990866?v=4","gravatar_id":"","url":"https://api.github.com/users/RobbeSneyders","html_url":"https://github.com/RobbeSneyders","followers_url":"https://api.github.com/users/RobbeSneyders/followers","following_url":"https://api.github.com/users/RobbeSneyders/following{/other_user}","gists_url":"https://api.github.com/users/RobbeSneyders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobbeSneyders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobbeSneyders/subscriptions","organizations_url":"https://api.github.com/users/RobbeSneyders/orgs","repos_url":"https://api.github.com/users/RobbeSneyders/repos","events_url":"https://api.github.com/users/RobbeSneyders/events{/privacy}","received_events_url":"https://api.github.com/users/RobbeSneyders/received_events","type":"User","site_admin":false},"repo":{"id":114748525,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDg1MjU=","name":"beam","full_name":"RobbeSneyders/beam","owner":{"login":"RobbeSneyders","id":20990866,"node_id":"MDQ6VXNlcjIwOTkwODY2","avatar_url":"https://avatars0.githubusercontent.com/u/20990866?v=4","gravatar_id":"","url":"https://api.github.com/users/RobbeSneyders","html_url":"https://github.com/RobbeSneyders","followers_url":"https://api.github.com/users/RobbeSneyders/followers","following_url":"https://api.github.com/users/RobbeSneyders/following{/other_user}","gists_url":"https://api.github.com/users/RobbeSneyders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobbeSneyders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobbeSneyders/subscriptions","organizations_url":"https://api.github.com/users/RobbeSneyders/orgs","repos_url":"https://api.github.com/users/RobbeSneyders/repos","events_url":"https://api.github.com/users/RobbeSneyders/events{/privacy}","received_events_url":"https://api.github.com/users/RobbeSneyders/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RobbeSneyders/beam","description":"Apache Beam","fork":true,"url":"https://api.github.com/repos/RobbeSneyders/beam","forks_url":"https://api.github.com/repos/RobbeSneyders/beam/forks","keys_url":"https://api.github.com/repos/RobbeSneyders/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobbeSneyders/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobbeSneyders/beam/teams","hooks_url":"https://api.github.com/repos/RobbeSneyders/beam/hooks","issue_events_url":"https://api.github.com/repos/RobbeSneyders/beam/issues/events{/number}","events_url":"https://api.github.com/repos/RobbeSneyders/beam/events","assignees_url":"https://api.github.com/repos/RobbeSneyders/beam/assignees{/user}","branches_url":"https://api.github.com/repos/RobbeSneyders/beam/branches{/branch}","tags_url":"https://api.github.com/repos/RobbeSneyders/beam/tags","blobs_url":"https://api.github.com/repos/RobbeSneyders/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobbeSneyders/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobbeSneyders/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobbeSneyders/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobbeSneyders/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/RobbeSneyders/beam/languages","stargazers_url":"https://api.github.com/repos/RobbeSneyders/beam/stargazers","contributors_url":"https://api.github.com/repos/RobbeSneyders/beam/contributors","subscribers_url":"https://api.github.com/repos/RobbeSneyders/beam/subscribers","subscription_url":"https://api.github.com/repos/RobbeSneyders/beam/subscription","commits_url":"https://api.github.com/repos/RobbeSneyders/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobbeSneyders/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobbeSneyders/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobbeSneyders/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobbeSneyders/beam/contents/{+path}","compare_url":"https://api.github.com/repos/RobbeSneyders/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobbeSneyders/beam/merges","archive_url":"https://api.github.com/repos/RobbeSneyders/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobbeSneyders/beam/downloads","issues_url":"https://api.github.com/repos/RobbeSneyders/beam/issues{/number}","pulls_url":"https://api.github.com/repos/RobbeSneyders/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/RobbeSneyders/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/RobbeSneyders/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobbeSneyders/beam/labels{/name}","releases_url":"https://api.github.com/repos/RobbeSneyders/beam/releases{/id}","deployments_url":"https://api.github.com/repos/RobbeSneyders/beam/deployments","created_at":"2017-12-19T09:56:51Z","updated_at":"2018-05-11T15:56:43Z","pushed_at":"2018-06-21T21:22:51Z","git_url":"git://github.com/RobbeSneyders/beam.git","ssh_url":"git@github.com:RobbeSneyders/beam.git","clone_url":"https://github.com/RobbeSneyders/beam.git","svn_url":"https://github.com/RobbeSneyders/beam","homepage":"","size":91311,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"00f4e3b763f2dc3d724a31e68478ff7f85d43c70","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-06-22T05:45:39Z","pushed_at":"2018-06-22T07:39:31Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":95917,"stargazers_count":1927,"watchers_count":1927,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1198,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1198,"open_issues":86,"watchers":1927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/5337"},"html":{"href":"https://github.com/apache/beam/pull/5337"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/5337"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/5337/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/5337/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/5337/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/e73d150a9b59f9c8d5ccae898e9e1a7b0fd28115"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RobbeSneyders"}}