{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/245392450","pull_request_review_id":189491944,"id":245392450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTM5MjQ1MA==","diff_hunk":"@@ -404,3 +406,58 @@ func TestNextPowerOf2(t *testing.T) {\n \t\tt.Errorf(\"TestNextPowerOf2: expected %d but returned %d.\", 0, actual)\n \t}\n }\n+\n+func TestCleanTempNginxCfg(t *testing.T) {\n+\terr := cleanTempNginxCfg()\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\ttmpfile, err := ioutil.TempFile(\"\", tempNginxPattern)\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tdefer tmpfile.Close()\n+\n+\tdur, err := time.ParseDuration(\"-10m\")\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\toldTime := time.Now().Add(dur)\n+\terr = os.Chtimes(tmpfile.Name(), oldTime, oldTime)\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\terr = cleanTempNginxCfg()\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\ttmpfile, err = ioutil.TempFile(\"\", tempNginxPattern)","path":"internal/ingress/controller/nginx_test.go","position":null,"original_position":42,"commit_id":"c830a7325523a11211806af4b3328ed8f41ae078","original_commit_id":"4baafe1032e9805f271c45d07547ccc99f39caa3","user":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"oops, fixed","created_at":"2019-01-04T19:11:54Z","updated_at":"2019-01-04T19:11:55Z","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3507#discussion_r245392450","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/245392450"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/3507#discussion_r245392450"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507"}},"in_reply_to_id":245391623},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507","id":235529914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTI5OTE0","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3507","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/3507.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/3507.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3507","number":3507,"state":"open","locked":false,"title":"Remove temporal configuration file after a while","user":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"**Which issue this PR fixes**: fixes #3273\r\n","created_at":"2018-12-03T17:28:24Z","updated_at":"2019-01-04T19:11:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21fb5bc908fc05c154ca7bd6d0b67fd70625c449","assignee":{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},"assignees":[{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"antoineco","id":3299086,"node_id":"MDQ6VXNlcjMyOTkwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/3299086?v=4","gravatar_id":"","url":"https://api.github.com/users/antoineco","html_url":"https://github.com/antoineco","followers_url":"https://api.github.com/users/antoineco/followers","following_url":"https://api.github.com/users/antoineco/following{/other_user}","gists_url":"https://api.github.com/users/antoineco/gists{/gist_id}","starred_url":"https://api.github.com/users/antoineco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoineco/subscriptions","organizations_url":"https://api.github.com/users/antoineco/orgs","repos_url":"https://api.github.com/users/antoineco/repos","events_url":"https://api.github.com/users/antoineco/events{/privacy}","received_events_url":"https://api.github.com/users/antoineco/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764356976,"node_id":"MDU6TGFiZWw3NjQzNTY5NzY=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":486873161,"node_id":"MDU6TGFiZWw0ODY4NzMxNjE=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676097629,"node_id":"MDU6TGFiZWw2NzYwOTc2Mjk=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3507/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/c830a7325523a11211806af4b3328ed8f41ae078","head":{"label":"aledbf:remove-temporal","ref":"remove-temporal","sha":"c830a7325523a11211806af4b3328ed8f41ae078","user":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":72895783,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg5NTc4Mw==","name":"ingress-nginx","full_name":"aledbf/ingress-nginx","private":false,"owner":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aledbf/ingress-nginx","description":"Ingress controllers","fork":true,"url":"https://api.github.com/repos/aledbf/ingress-nginx","forks_url":"https://api.github.com/repos/aledbf/ingress-nginx/forks","keys_url":"https://api.github.com/repos/aledbf/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/aledbf/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/ingress-nginx/events","assignees_url":"https://api.github.com/repos/aledbf/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/aledbf/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/aledbf/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/aledbf/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/aledbf/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/aledbf/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/ingress-nginx/merges","archive_url":"https://api.github.com/repos/aledbf/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/ingress-nginx/deployments","created_at":"2016-11-05T00:39:04Z","updated_at":"2019-01-04T19:01:25Z","pushed_at":"2019-01-04T19:11:49Z","git_url":"git://github.com/aledbf/ingress-nginx.git","ssh_url":"git@github.com:aledbf/ingress-nginx.git","clone_url":"https://github.com/aledbf/ingress-nginx.git","svn_url":"https://github.com/aledbf/ingress-nginx","homepage":null,"size":102632,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"79bdfcbe847bcc35b4e89f355abcb81a36a399e0","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":72891330,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg5MTMzMA==","name":"ingress-nginx","full_name":"kubernetes/ingress-nginx","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-nginx","forks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-nginx/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/deployments","created_at":"2016-11-04T22:54:14Z","updated_at":"2019-01-04T19:10:46Z","pushed_at":"2019-01-04T19:11:51Z","git_url":"git://github.com/kubernetes/ingress-nginx.git","ssh_url":"git@github.com:kubernetes/ingress-nginx.git","clone_url":"https://github.com/kubernetes/ingress-nginx.git","svn_url":"https://github.com/kubernetes/ingress-nginx","homepage":"https://kubernetes.github.io/ingress-nginx/","size":88837,"stargazers_count":3641,"watchers_count":3641,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1815,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1815,"open_issues":149,"watchers":3641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/3507"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3507"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3507/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3507/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/c830a7325523a11211806af4b3328ed8f41ae078"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aledbf"}}