{"push_id":3053474407,"size":2,"distinct_size":1,"ref":"refs/heads/sharon-co-bug","head":"601ee6ee75e787cac59ef63af13afca16fd1de78","before":"e1489eabb546ca421745432bfe719be3cb7b1eab","commits":[{"sha":"b46eed6b7d08a340b3ee8315d8046dcc558dba73","author":{"name":"Kenshiro Nakagawa","email":"0cd5f1043292f3613471226572765685b423de86@gmail.com"},"message":"reset Fakes::VBMSService class ivars before every test (#7862)\n\nConnects #7802 \r\n\r\n### Description\r\n`Fakes::VBMSService` keeps global state and this specific ordering of tests (spec/models/end_product_establishment_spec.rb running before spec/feature/intake/ramp_refiling_spec.rb in the same container) triggered an order-dependent failure in CI: https://circleci.com/gh/department-of-veterans-affairs/caseflow/21276\r\n\r\nInstead of patching the particular testcases to be resilient to global state, I am instead resetting `Fakes::VBMSService` state before each test.\r\n\r\nTo repro this test failure locally and consistently, this is the command the container runs:\r\n\r\n```\r\nbundle exec rspec -- spec/feature/hearings_spec.rb spec/feature/queue/ama_queue_spec.rb spec/feature/queue/task_queue_spec.rb spec/feature/intake/intake_spec.rb spec/controllers/hearings/schedule_periods_controller_spec.rb spec/models/certification_stats_spec.rb spec/models/tasks/colocated_task_spec.rb spec/models/establish_claim_spec.rb spec/models/schedule_period_spec.rb spec/models/appeal_history_spec.rb spec/models/task_spec.rb spec/models/judge_spec.rb spec/models/appeal_series_alerts_spec.rb spec/requests/hearing_day_spec.rb spec/models/end_product_establishment_spec.rb spec/services/document_fetcher_spec.rb spec/models/ramp_closed_appeal_spec.rb spec/models/intake_spec.rb spec/models/user_quota_spec.rb spec/models/document_spec.rb spec/models/higher_level_review_spec.rb spec/models/tasks/mail_task_spec.rb spec/models/reader_user_spec.rb spec/controllers/users_controller_spec.rb spec/models/tasks/judge_task_spec.rb spec/models/docket_tracer_spec.rb spec/models/hearing_docket_spec.rb spec/models/claimant_spec.rb spec/jobs/reassign_old_tasks_job_spec.rb spec/mappers/queue_mapper_spec.rb spec/models/tasks/attorney_task_spec.rb spec/models/concerns/cached_attributes_spec.rb spec/controllers/intakes_controller_spec.rb spec/feature/dispatch/establish_claim_spec.rb spec/feature/intake/ramp_refiling_spec.rb spec/helpers/retry_helper_spec.rb spec/mappers/issue_mapper_spec.rb spec/models/appeal_events_spec.rb spec/models/concerns/round_robin_assigner_concern_spec.rb spec/models/higher_level_review_intake_spec.rb spec/models/rating_issue_spec.rb spec/repositories/hearing_repository_spec.rb spec/services/business_metrics_spec.rb spec/models/supplemental_claim_spec.rb spec/controllers/idt/api/judges_controller_spec.rb spec/jobs/monitor_business_critical_jobs_job_spec.rb spec/models/regional_office_spec.rb spec/jobs/dependencies_report_service_log_job_spec.rb spec/models/legacy_tasks/judge_legacy_task_spec.rb spec/helpers/vacols_helper_spec.rb spec/models/cavc_decision_spec.rb spec/models/legacy_tasks/attorney_legacy_task_spec.rb\r\n```\r\n\r\n### Acceptance Criteria\r\nNo more flaky test failures due to shared fake VBMS state\r\n\r\n### Testing Plan\r\nN/A","distinct":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/commits/b46eed6b7d08a340b3ee8315d8046dcc558dba73"},{"sha":"601ee6ee75e787cac59ef63af13afca16fd1de78","author":{"name":"Sharon Warner","email":"67289158e51f3e79badaa95e8c21a0a72af1ced4@gmail.com"},"message":"Merge branch 'master' into sharon-co-bug","distinct":true,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/commits/601ee6ee75e787cac59ef63af13afca16fd1de78"}]}
{"actor":{"display_login":"sharonwarner"}}