{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/168566357","pull_request_review_id":96956103,"id":168566357,"diff_hunk":"@@ -223,6 +223,12 @@ export interface IButtonProps extends React.AllHTMLAttributes<HTMLAnchorElement\n   getSplitButtonClassNames?: (disabled: boolean,\n     expanded: boolean,\n     checked: boolean) => ISplitButtonClassNames;\n+\n+  /**\n+  * Defines a custom key that opens button menu. If the value is not provided, down arrow key is used.\n+  * If set to null, this will be disabled.","path":"packages/office-ui-fabric-react/src/components/Button/Button.types.ts","position":16,"original_position":16,"commit_id":"7e3d2c75aaa6c0c1022fd87269d41078b6280890","original_commit_id":"7e3d2c75aaa6c0c1022fd87269d41078b6280890","user":{"login":"manishgarg1","id":1950591,"avatar_url":"https://avatars1.githubusercontent.com/u/1950591?v=4","gravatar_id":"","url":"https://api.github.com/users/manishgarg1","html_url":"https://github.com/manishgarg1","followers_url":"https://api.github.com/users/manishgarg1/followers","following_url":"https://api.github.com/users/manishgarg1/following{/other_user}","gists_url":"https://api.github.com/users/manishgarg1/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgarg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgarg1/subscriptions","organizations_url":"https://api.github.com/users/manishgarg1/orgs","repos_url":"https://api.github.com/users/manishgarg1/repos","events_url":"https://api.github.com/users/manishgarg1/events{/privacy}","received_events_url":"https://api.github.com/users/manishgarg1/received_events","type":"User","site_admin":false},"body":"Provides a custom KeyCode that can be used to open the button menu. The default keyCode is the down arrow. A value of null can be provided to disable the key codes for opening the button menu.","created_at":"2018-02-15T18:29:43Z","updated_at":"2018-02-15T18:29:44Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950#discussion_r168566357","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/168566357"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950#discussion_r168566357"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950","id":168688833,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3950","number":3950,"state":"open","locked":false,"title":"Added enum for triggering menu with arrow keys and bool to allow it or not","user":{"login":"ekawatani","id":5345044,"avatar_url":"https://avatars0.githubusercontent.com/u/5345044?v=4","gravatar_id":"","url":"https://api.github.com/users/ekawatani","html_url":"https://github.com/ekawatani","followers_url":"https://api.github.com/users/ekawatani/followers","following_url":"https://api.github.com/users/ekawatani/following{/other_user}","gists_url":"https://api.github.com/users/ekawatani/gists{/gist_id}","starred_url":"https://api.github.com/users/ekawatani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekawatani/subscriptions","organizations_url":"https://api.github.com/users/ekawatani/orgs","repos_url":"https://api.github.com/users/ekawatani/repos","events_url":"https://api.github.com/users/ekawatani/events{/privacy}","received_events_url":"https://api.github.com/users/ekawatani/received_events","type":"User","site_admin":false},"body":"\r\n\r\n#### Pull request checklist\r\n\r\n- [x] Addresses an existing issue: Fixes #3947\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nAdded a enum for specifying which arrow key is used to trigger button menu. Also, added a boolean value indicating whether triggering menu using arrow keys is allowed.\r\n\r\n#### Focus areas to test\r\n\r\nEnsure button menu can open using keyboards. Also, verify split buttons behaviors didn't regress.\r\n","created_at":"2018-02-12T21:10:38Z","updated_at":"2018-02-15T18:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4613d1670d45f9aee9a5b9948dfb9d91e89712ae","assignee":{"login":"manishgarg1","id":1950591,"avatar_url":"https://avatars1.githubusercontent.com/u/1950591?v=4","gravatar_id":"","url":"https://api.github.com/users/manishgarg1","html_url":"https://github.com/manishgarg1","followers_url":"https://api.github.com/users/manishgarg1/followers","following_url":"https://api.github.com/users/manishgarg1/following{/other_user}","gists_url":"https://api.github.com/users/manishgarg1/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgarg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgarg1/subscriptions","organizations_url":"https://api.github.com/users/manishgarg1/orgs","repos_url":"https://api.github.com/users/manishgarg1/repos","events_url":"https://api.github.com/users/manishgarg1/events{/privacy}","received_events_url":"https://api.github.com/users/manishgarg1/received_events","type":"User","site_admin":false},"assignees":[{"login":"manishgarg1","id":1950591,"avatar_url":"https://avatars1.githubusercontent.com/u/1950591?v=4","gravatar_id":"","url":"https://api.github.com/users/manishgarg1","html_url":"https://github.com/manishgarg1","followers_url":"https://api.github.com/users/manishgarg1/followers","following_url":"https://api.github.com/users/manishgarg1/following{/other_user}","gists_url":"https://api.github.com/users/manishgarg1/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgarg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgarg1/subscriptions","organizations_url":"https://api.github.com/users/manishgarg1/orgs","repos_url":"https://api.github.com/users/manishgarg1/repos","events_url":"https://api.github.com/users/manishgarg1/events{/privacy}","received_events_url":"https://api.github.com/users/manishgarg1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3950/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/7e3d2c75aaa6c0c1022fd87269d41078b6280890","head":{"label":"ekawatani:add-menu-trigger-button-configuration","ref":"add-menu-trigger-button-configuration","sha":"7e3d2c75aaa6c0c1022fd87269d41078b6280890","user":{"login":"ekawatani","id":5345044,"avatar_url":"https://avatars0.githubusercontent.com/u/5345044?v=4","gravatar_id":"","url":"https://api.github.com/users/ekawatani","html_url":"https://github.com/ekawatani","followers_url":"https://api.github.com/users/ekawatani/followers","following_url":"https://api.github.com/users/ekawatani/following{/other_user}","gists_url":"https://api.github.com/users/ekawatani/gists{/gist_id}","starred_url":"https://api.github.com/users/ekawatani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekawatani/subscriptions","organizations_url":"https://api.github.com/users/ekawatani/orgs","repos_url":"https://api.github.com/users/ekawatani/repos","events_url":"https://api.github.com/users/ekawatani/events{/privacy}","received_events_url":"https://api.github.com/users/ekawatani/received_events","type":"User","site_admin":false},"repo":{"id":121277940,"name":"office-ui-fabric-react","full_name":"ekawatani/office-ui-fabric-react","owner":{"login":"ekawatani","id":5345044,"avatar_url":"https://avatars0.githubusercontent.com/u/5345044?v=4","gravatar_id":"","url":"https://api.github.com/users/ekawatani","html_url":"https://github.com/ekawatani","followers_url":"https://api.github.com/users/ekawatani/followers","following_url":"https://api.github.com/users/ekawatani/following{/other_user}","gists_url":"https://api.github.com/users/ekawatani/gists{/gist_id}","starred_url":"https://api.github.com/users/ekawatani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekawatani/subscriptions","organizations_url":"https://api.github.com/users/ekawatani/orgs","repos_url":"https://api.github.com/users/ekawatani/repos","events_url":"https://api.github.com/users/ekawatani/events{/privacy}","received_events_url":"https://api.github.com/users/ekawatani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekawatani/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react","forks_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/ekawatani/office-ui-fabric-react/deployments","created_at":"2018-02-12T17:24:00Z","updated_at":"2018-02-12T17:24:06Z","pushed_at":"2018-02-15T09:15:23Z","git_url":"git://github.com/ekawatani/office-ui-fabric-react.git","ssh_url":"git@github.com:ekawatani/office-ui-fabric-react.git","clone_url":"https://github.com/ekawatani/office-ui-fabric-react.git","svn_url":"https://github.com/ekawatani/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":23286,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"7b7abfa12cec76632570dad7c2524901e4580ab1","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-02-15T10:26:41Z","pushed_at":"2018-02-15T18:04:23Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":23316,"stargazers_count":2280,"watchers_count":2280,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":462,"mirror_url":null,"archived":false,"open_issues_count":464,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":462,"open_issues":464,"watchers":2280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3950"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3950"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3950/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3950/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/7e3d2c75aaa6c0c1022fd87269d41078b6280890"}},"author_association":"NONE"}}
{"actor":{"display_login":"manishgarg1"}}