{"action":"created","comment":{"url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/comments/178444564","pull_request_review_id":108505354,"id":178444564,"diff_hunk":"@@ -7,6 +7,8 @@\n #ifndef LINE_EXTRACTOR_IGVC_DBSCAN_H\n #define LINE_EXTRACTOR_IGVC_DBSCAN_H\n \n+#define SEQUENTIAL_CUT_OFF 5000","path":"src/sb_pointcloud_processing/include/DBSCAN.h","position":4,"original_position":4,"commit_id":"e8532458169009fc4985778080746d4e73f3897f","original_commit_id":"e8532458169009fc4985778080746d4e73f3897f","user":{"login":"garethellis0","id":9075711,"avatar_url":"https://avatars0.githubusercontent.com/u/9075711?v=4","gravatar_id":"","url":"https://api.github.com/users/garethellis0","html_url":"https://github.com/garethellis0","followers_url":"https://api.github.com/users/garethellis0/followers","following_url":"https://api.github.com/users/garethellis0/following{/other_user}","gists_url":"https://api.github.com/users/garethellis0/gists{/gist_id}","starred_url":"https://api.github.com/users/garethellis0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethellis0/subscriptions","organizations_url":"https://api.github.com/users/garethellis0/orgs","repos_url":"https://api.github.com/users/garethellis0/repos","events_url":"https://api.github.com/users/garethellis0/events{/privacy}","received_events_url":"https://api.github.com/users/garethellis0/received_events","type":"User","site_admin":false},"body":"A comment explaining what this is used for would also be really helpful.","created_at":"2018-03-31T23:38:48Z","updated_at":"2018-03-31T23:53:06Z","html_url":"https://github.com/UBC-Snowbots/Snowflake/pull/296#discussion_r178444564","pull_request_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/comments/178444564"},"html":{"href":"https://github.com/UBC-Snowbots/Snowflake/pull/296#discussion_r178444564"},"pull_request":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296"}},"in_reply_to_id":178444558},"pull_request":{"url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296","id":177938076,"html_url":"https://github.com/UBC-Snowbots/Snowflake/pull/296","diff_url":"https://github.com/UBC-Snowbots/Snowflake/pull/296.diff","patch_url":"https://github.com/UBC-Snowbots/Snowflake/pull/296.patch","issue_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/296","number":296,"state":"open","locked":false,"title":"Line extractor performance enhancement","user":{"login":"mingyokim","id":21287547,"avatar_url":"https://avatars2.githubusercontent.com/u/21287547?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyokim","html_url":"https://github.com/mingyokim","followers_url":"https://api.github.com/users/mingyokim/followers","following_url":"https://api.github.com/users/mingyokim/following{/other_user}","gists_url":"https://api.github.com/users/mingyokim/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyokim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyokim/subscriptions","organizations_url":"https://api.github.com/users/mingyokim/orgs","repos_url":"https://api.github.com/users/mingyokim/repos","events_url":"https://api.github.com/users/mingyokim/events{/privacy}","received_events_url":"https://api.github.com/users/mingyokim/received_events","type":"User","site_admin":false},"body":"This is an early PR and not finalized. The goal is to get early feedback/ideas on how to enhance performance. Also, this branch is based off of #295 which is not merged yet, so only look at commits starting from \"initial implementation of multithreading\".","created_at":"2018-03-28T06:07:00Z","updated_at":"2018-03-31T23:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4164b7936b43a418907e12bfaf8bd349a87f42e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296/commits","review_comments_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296/comments","review_comment_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/296/comments","statuses_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/statuses/e8532458169009fc4985778080746d4e73f3897f","head":{"label":"mingyokim:line-extractor-performance-enhancement","ref":"line-extractor-performance-enhancement","sha":"e8532458169009fc4985778080746d4e73f3897f","user":{"login":"mingyokim","id":21287547,"avatar_url":"https://avatars2.githubusercontent.com/u/21287547?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyokim","html_url":"https://github.com/mingyokim","followers_url":"https://api.github.com/users/mingyokim/followers","following_url":"https://api.github.com/users/mingyokim/following{/other_user}","gists_url":"https://api.github.com/users/mingyokim/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyokim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyokim/subscriptions","organizations_url":"https://api.github.com/users/mingyokim/orgs","repos_url":"https://api.github.com/users/mingyokim/repos","events_url":"https://api.github.com/users/mingyokim/events{/privacy}","received_events_url":"https://api.github.com/users/mingyokim/received_events","type":"User","site_admin":false},"repo":{"id":116516743,"name":"Snowflake","full_name":"mingyokim/Snowflake","owner":{"login":"mingyokim","id":21287547,"avatar_url":"https://avatars2.githubusercontent.com/u/21287547?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyokim","html_url":"https://github.com/mingyokim","followers_url":"https://api.github.com/users/mingyokim/followers","following_url":"https://api.github.com/users/mingyokim/following{/other_user}","gists_url":"https://api.github.com/users/mingyokim/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyokim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyokim/subscriptions","organizations_url":"https://api.github.com/users/mingyokim/orgs","repos_url":"https://api.github.com/users/mingyokim/repos","events_url":"https://api.github.com/users/mingyokim/events{/privacy}","received_events_url":"https://api.github.com/users/mingyokim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mingyokim/Snowflake","description":"UBC Snowbots Codebase","fork":true,"url":"https://api.github.com/repos/mingyokim/Snowflake","forks_url":"https://api.github.com/repos/mingyokim/Snowflake/forks","keys_url":"https://api.github.com/repos/mingyokim/Snowflake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mingyokim/Snowflake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mingyokim/Snowflake/teams","hooks_url":"https://api.github.com/repos/mingyokim/Snowflake/hooks","issue_events_url":"https://api.github.com/repos/mingyokim/Snowflake/issues/events{/number}","events_url":"https://api.github.com/repos/mingyokim/Snowflake/events","assignees_url":"https://api.github.com/repos/mingyokim/Snowflake/assignees{/user}","branches_url":"https://api.github.com/repos/mingyokim/Snowflake/branches{/branch}","tags_url":"https://api.github.com/repos/mingyokim/Snowflake/tags","blobs_url":"https://api.github.com/repos/mingyokim/Snowflake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mingyokim/Snowflake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mingyokim/Snowflake/git/refs{/sha}","trees_url":"https://api.github.com/repos/mingyokim/Snowflake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mingyokim/Snowflake/statuses/{sha}","languages_url":"https://api.github.com/repos/mingyokim/Snowflake/languages","stargazers_url":"https://api.github.com/repos/mingyokim/Snowflake/stargazers","contributors_url":"https://api.github.com/repos/mingyokim/Snowflake/contributors","subscribers_url":"https://api.github.com/repos/mingyokim/Snowflake/subscribers","subscription_url":"https://api.github.com/repos/mingyokim/Snowflake/subscription","commits_url":"https://api.github.com/repos/mingyokim/Snowflake/commits{/sha}","git_commits_url":"https://api.github.com/repos/mingyokim/Snowflake/git/commits{/sha}","comments_url":"https://api.github.com/repos/mingyokim/Snowflake/comments{/number}","issue_comment_url":"https://api.github.com/repos/mingyokim/Snowflake/issues/comments{/number}","contents_url":"https://api.github.com/repos/mingyokim/Snowflake/contents/{+path}","compare_url":"https://api.github.com/repos/mingyokim/Snowflake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mingyokim/Snowflake/merges","archive_url":"https://api.github.com/repos/mingyokim/Snowflake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mingyokim/Snowflake/downloads","issues_url":"https://api.github.com/repos/mingyokim/Snowflake/issues{/number}","pulls_url":"https://api.github.com/repos/mingyokim/Snowflake/pulls{/number}","milestones_url":"https://api.github.com/repos/mingyokim/Snowflake/milestones{/number}","notifications_url":"https://api.github.com/repos/mingyokim/Snowflake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mingyokim/Snowflake/labels{/name}","releases_url":"https://api.github.com/repos/mingyokim/Snowflake/releases{/id}","deployments_url":"https://api.github.com/repos/mingyokim/Snowflake/deployments","created_at":"2018-01-06T21:26:38Z","updated_at":"2018-01-06T21:26:40Z","pushed_at":"2018-03-31T21:27:51Z","git_url":"git://github.com/mingyokim/Snowflake.git","ssh_url":"git@github.com:mingyokim/Snowflake.git","clone_url":"https://github.com/mingyokim/Snowflake.git","svn_url":"https://github.com/mingyokim/Snowflake","homepage":"","size":20283,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"core"}},"base":{"label":"UBC-Snowbots:master","ref":"master","sha":"eb25af6df5c7a6a01a42d5c6cf95b3fb189736eb","user":{"login":"UBC-Snowbots","id":7613873,"avatar_url":"https://avatars0.githubusercontent.com/u/7613873?v=4","gravatar_id":"","url":"https://api.github.com/users/UBC-Snowbots","html_url":"https://github.com/UBC-Snowbots","followers_url":"https://api.github.com/users/UBC-Snowbots/followers","following_url":"https://api.github.com/users/UBC-Snowbots/following{/other_user}","gists_url":"https://api.github.com/users/UBC-Snowbots/gists{/gist_id}","starred_url":"https://api.github.com/users/UBC-Snowbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UBC-Snowbots/subscriptions","organizations_url":"https://api.github.com/users/UBC-Snowbots/orgs","repos_url":"https://api.github.com/users/UBC-Snowbots/repos","events_url":"https://api.github.com/users/UBC-Snowbots/events{/privacy}","received_events_url":"https://api.github.com/users/UBC-Snowbots/received_events","type":"Organization","site_admin":false},"repo":{"id":62523530,"name":"Snowflake","full_name":"UBC-Snowbots/Snowflake","owner":{"login":"UBC-Snowbots","id":7613873,"avatar_url":"https://avatars0.githubusercontent.com/u/7613873?v=4","gravatar_id":"","url":"https://api.github.com/users/UBC-Snowbots","html_url":"https://github.com/UBC-Snowbots","followers_url":"https://api.github.com/users/UBC-Snowbots/followers","following_url":"https://api.github.com/users/UBC-Snowbots/following{/other_user}","gists_url":"https://api.github.com/users/UBC-Snowbots/gists{/gist_id}","starred_url":"https://api.github.com/users/UBC-Snowbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UBC-Snowbots/subscriptions","organizations_url":"https://api.github.com/users/UBC-Snowbots/orgs","repos_url":"https://api.github.com/users/UBC-Snowbots/repos","events_url":"https://api.github.com/users/UBC-Snowbots/events{/privacy}","received_events_url":"https://api.github.com/users/UBC-Snowbots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UBC-Snowbots/Snowflake","description":"UBC Snowbots Codebase","fork":false,"url":"https://api.github.com/repos/UBC-Snowbots/Snowflake","forks_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/forks","keys_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/teams","hooks_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/hooks","issue_events_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/events{/number}","events_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/events","assignees_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/assignees{/user}","branches_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/branches{/branch}","tags_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/tags","blobs_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/git/refs{/sha}","trees_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/statuses/{sha}","languages_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/languages","stargazers_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/stargazers","contributors_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/contributors","subscribers_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/subscribers","subscription_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/subscription","commits_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/commits{/sha}","git_commits_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/git/commits{/sha}","comments_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/comments{/number}","issue_comment_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/comments{/number}","contents_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/contents/{+path}","compare_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/merges","archive_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/downloads","issues_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues{/number}","pulls_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls{/number}","milestones_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/milestones{/number}","notifications_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/labels{/name}","releases_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/releases{/id}","deployments_url":"https://api.github.com/repos/UBC-Snowbots/Snowflake/deployments","created_at":"2016-07-04T01:39:14Z","updated_at":"2018-03-31T23:26:07Z","pushed_at":"2018-03-31T23:26:04Z","git_url":"git://github.com/UBC-Snowbots/Snowflake.git","ssh_url":"git@github.com:UBC-Snowbots/Snowflake.git","clone_url":"https://github.com/UBC-Snowbots/Snowflake.git","svn_url":"https://github.com/UBC-Snowbots/Snowflake","homepage":"","size":20187,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":13,"open_issues":49,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296"},"html":{"href":"https://github.com/UBC-Snowbots/Snowflake/pull/296"},"issue":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/296"},"comments":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/UBC-Snowbots/Snowflake/statuses/e8532458169009fc4985778080746d4e73f3897f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garethellis0"}}