{"action":"created","comment":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/237325297","pull_request_review_id":179595328,"id":237325297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzMyNTI5Nw==","diff_hunk":"@@ -998,6 +1050,92 @@ func (bc *blockchain) runActions(blk *Block, ws factory.WorkingSet, verify bool)\n \treturn root, nil\n }\n \n+func (bc *blockchain) runActionsWithActionIterator(blk *Block, actionIterator actioniterator.ActionIterator,\n+\tws factory.WorkingSet, verify bool) (hash.Hash32B, error) {\n+\tblk.receipts = make(map[hash.Hash32B]*action.Receipt)\n+\tif bc.sf == nil {\n+\t\treturn hash.ZeroHash32B, errors.New(\"statefactory cannot be nil\")\n+\t}\n+\tgasLimit := GasLimit\n+\n+\t// update state factory\n+\tctx := state.WithRunActionsCtx(context.Background(),\n+\t\tstate.RunActionsCtx{\n+\t\t\tProducerAddr:    blk.ProducerAddress(),\n+\t\t\tGasLimit:        &gasLimit,","path":"blockchain/blockchain.go","position":90,"original_position":90,"commit_id":"abfd5f23272766e9556eeb3b174698576eb17795","original_commit_id":"abfd5f23272766e9556eeb3b174698576eb17795","user":{"login":"xiaxiangzhou","id":7810601,"node_id":"MDQ6VXNlcjc4MTA2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7810601?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaxiangzhou","html_url":"https://github.com/xiaxiangzhou","followers_url":"https://api.github.com/users/xiaxiangzhou/followers","following_url":"https://api.github.com/users/xiaxiangzhou/following{/other_user}","gists_url":"https://api.github.com/users/xiaxiangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaxiangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaxiangzhou/subscriptions","organizations_url":"https://api.github.com/users/xiaxiangzhou/orgs","repos_url":"https://api.github.com/users/xiaxiangzhou/repos","events_url":"https://api.github.com/users/xiaxiangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xiaxiangzhou/received_events","type":"User","site_admin":false},"body":"yes, we did. we still to compare gas limit","created_at":"2018-11-29T01:29:40Z","updated_at":"2018-11-29T01:29:40Z","html_url":"https://github.com/iotexproject/iotex-core/pull/336#discussion_r237325297","pull_request_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/237325297"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/336#discussion_r237325297"},"pull_request":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336"}},"in_reply_to_id":235260199},"pull_request":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336","id":231856716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODU2NzE2","html_url":"https://github.com/iotexproject/iotex-core/pull/336","diff_url":"https://github.com/iotexproject/iotex-core/pull/336.diff","patch_url":"https://github.com/iotexproject/iotex-core/pull/336.patch","issue_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/336","number":336,"state":"open","locked":false,"title":"pick action based on gas limit","user":{"login":"xiaxiangzhou","id":7810601,"node_id":"MDQ6VXNlcjc4MTA2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7810601?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaxiangzhou","html_url":"https://github.com/xiaxiangzhou","followers_url":"https://api.github.com/users/xiaxiangzhou/followers","following_url":"https://api.github.com/users/xiaxiangzhou/following{/other_user}","gists_url":"https://api.github.com/users/xiaxiangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaxiangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaxiangzhou/subscriptions","organizations_url":"https://api.github.com/users/xiaxiangzhou/orgs","repos_url":"https://api.github.com/users/xiaxiangzhou/repos","events_url":"https://api.github.com/users/xiaxiangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xiaxiangzhou/received_events","type":"User","site_admin":false},"body":"pick action based on gas limit","created_at":"2018-11-19T05:22:15Z","updated_at":"2018-11-29T01:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4af04131d423e8a9626b201e269fc5ba59365de3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lizhefeng","id":15241597,"node_id":"MDQ6VXNlcjE1MjQxNTk3","avatar_url":"https://avatars1.githubusercontent.com/u/15241597?v=4","gravatar_id":"","url":"https://api.github.com/users/lizhefeng","html_url":"https://github.com/lizhefeng","followers_url":"https://api.github.com/users/lizhefeng/followers","following_url":"https://api.github.com/users/lizhefeng/following{/other_user}","gists_url":"https://api.github.com/users/lizhefeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhefeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhefeng/subscriptions","organizations_url":"https://api.github.com/users/lizhefeng/orgs","repos_url":"https://api.github.com/users/lizhefeng/repos","events_url":"https://api.github.com/users/lizhefeng/events{/privacy}","received_events_url":"https://api.github.com/users/lizhefeng/received_events","type":"User","site_admin":false},{"login":"CoderZhi","id":35643171,"node_id":"MDQ6VXNlcjM1NjQzMTcx","avatar_url":"https://avatars2.githubusercontent.com/u/35643171?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderZhi","html_url":"https://github.com/CoderZhi","followers_url":"https://api.github.com/users/CoderZhi/followers","following_url":"https://api.github.com/users/CoderZhi/following{/other_user}","gists_url":"https://api.github.com/users/CoderZhi/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderZhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderZhi/subscriptions","organizations_url":"https://api.github.com/users/CoderZhi/orgs","repos_url":"https://api.github.com/users/CoderZhi/repos","events_url":"https://api.github.com/users/CoderZhi/events{/privacy}","received_events_url":"https://api.github.com/users/CoderZhi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336/commits","review_comments_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336/comments","review_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/336/comments","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/abfd5f23272766e9556eeb3b174698576eb17795","head":{"label":"xiaxiangzhou:xiaxiangzhou10","ref":"xiaxiangzhou10","sha":"abfd5f23272766e9556eeb3b174698576eb17795","user":{"login":"xiaxiangzhou","id":7810601,"node_id":"MDQ6VXNlcjc4MTA2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7810601?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaxiangzhou","html_url":"https://github.com/xiaxiangzhou","followers_url":"https://api.github.com/users/xiaxiangzhou/followers","following_url":"https://api.github.com/users/xiaxiangzhou/following{/other_user}","gists_url":"https://api.github.com/users/xiaxiangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaxiangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaxiangzhou/subscriptions","organizations_url":"https://api.github.com/users/xiaxiangzhou/orgs","repos_url":"https://api.github.com/users/xiaxiangzhou/repos","events_url":"https://api.github.com/users/xiaxiangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xiaxiangzhou/received_events","type":"User","site_admin":false},"repo":{"id":148246799,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyNDY3OTk=","name":"iotex-core","full_name":"xiaxiangzhou/iotex-core","private":false,"owner":{"login":"xiaxiangzhou","id":7810601,"node_id":"MDQ6VXNlcjc4MTA2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7810601?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaxiangzhou","html_url":"https://github.com/xiaxiangzhou","followers_url":"https://api.github.com/users/xiaxiangzhou/followers","following_url":"https://api.github.com/users/xiaxiangzhou/following{/other_user}","gists_url":"https://api.github.com/users/xiaxiangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaxiangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaxiangzhou/subscriptions","organizations_url":"https://api.github.com/users/xiaxiangzhou/orgs","repos_url":"https://api.github.com/users/xiaxiangzhou/repos","events_url":"https://api.github.com/users/xiaxiangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xiaxiangzhou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xiaxiangzhou/iotex-core","description":"Connecting the physical world, block by block.","fork":true,"url":"https://api.github.com/repos/xiaxiangzhou/iotex-core","forks_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/forks","keys_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/teams","hooks_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/events","assignees_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/tags","blobs_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/languages","stargazers_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/subscription","commits_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/merges","archive_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/downloads","issues_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/xiaxiangzhou/iotex-core/deployments","created_at":"2018-09-11T02:11:07Z","updated_at":"2018-10-04T06:13:00Z","pushed_at":"2018-11-19T05:24:29Z","git_url":"git://github.com/xiaxiangzhou/iotex-core.git","ssh_url":"git@github.com:xiaxiangzhou/iotex-core.git","clone_url":"https://github.com/xiaxiangzhou/iotex-core.git","svn_url":"https://github.com/xiaxiangzhou/iotex-core","homepage":"https://iotex.io","size":7764,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotexproject:master","ref":"master","sha":"084040307207594bc587bfc4e9a6b34d7919d3e3","user":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":130281002,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyODEwMDI=","name":"iotex-core","full_name":"iotexproject/iotex-core","private":false,"owner":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotexproject/iotex-core","description":"Official Go implementation of the IoTeX protocol","fork":false,"url":"https://api.github.com/repos/iotexproject/iotex-core","forks_url":"https://api.github.com/repos/iotexproject/iotex-core/forks","keys_url":"https://api.github.com/repos/iotexproject/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotexproject/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotexproject/iotex-core/teams","hooks_url":"https://api.github.com/repos/iotexproject/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/iotexproject/iotex-core/events","assignees_url":"https://api.github.com/repos/iotexproject/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/iotexproject/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/iotexproject/iotex-core/tags","blobs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotexproject/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotexproject/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iotexproject/iotex-core/languages","stargazers_url":"https://api.github.com/repos/iotexproject/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/iotexproject/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/iotexproject/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/iotexproject/iotex-core/subscription","commits_url":"https://api.github.com/repos/iotexproject/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotexproject/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotexproject/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/iotexproject/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotexproject/iotex-core/merges","archive_url":"https://api.github.com/repos/iotexproject/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotexproject/iotex-core/downloads","issues_url":"https://api.github.com/repos/iotexproject/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iotexproject/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iotexproject/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotexproject/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/iotexproject/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/iotexproject/iotex-core/deployments","created_at":"2018-04-19T22:56:20Z","updated_at":"2018-11-28T23:37:09Z","pushed_at":"2018-11-29T00:37:29Z","git_url":"git://github.com/iotexproject/iotex-core.git","ssh_url":"git@github.com:iotexproject/iotex-core.git","clone_url":"https://github.com/iotexproject/iotex-core.git","svn_url":"https://github.com/iotexproject/iotex-core","homepage":"https://iotex.io","size":7812,"stargazers_count":810,"watchers_count":810,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":99,"open_issues":20,"watchers":810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/336"},"issue":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/336"},"comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/iotexproject/iotex-core/statuses/abfd5f23272766e9556eeb3b174698576eb17795"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiaxiangzhou"}}