{"action":"created","comment":{"url":"https://api.github.com/repos/Neufund/TypeChain/pulls/comments/165651050","pull_request_review_id":93628187,"id":165651050,"diff_hunk":"@@ -7,13 +7,14 @@ yarn test:unit\n \n echo \"Praparing for integration tests\"\n \n-ABI_DIR=\"./test/integration/abis\"\n+cd ./test/integration/contracts/\n+ABI_DIR=\"../abis\"\n rm -rf $ABI_DIR\n \n echo \"Generating ABIs for sample contracts\"\n-solc --abi ./test/integration/contracts/* --bin -o $ABI_DIR","path":"scripts/test.sh","position":10,"original_position":10,"commit_id":"668daf0ddec52a0aff9847b27703c372cd6a83a3","original_commit_id":"668daf0ddec52a0aff9847b27703c372cd6a83a3","user":{"login":"linusnorton","id":683300,"avatar_url":"https://avatars2.githubusercontent.com/u/683300?v=4","gravatar_id":"","url":"https://api.github.com/users/linusnorton","html_url":"https://github.com/linusnorton","followers_url":"https://api.github.com/users/linusnorton/followers","following_url":"https://api.github.com/users/linusnorton/following{/other_user}","gists_url":"https://api.github.com/users/linusnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/linusnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusnorton/subscriptions","organizations_url":"https://api.github.com/users/linusnorton/orgs","repos_url":"https://api.github.com/users/linusnorton/repos","events_url":"https://api.github.com/users/linusnorton/events{/privacy}","received_events_url":"https://api.github.com/users/linusnorton/received_events","type":"User","site_admin":false},"body":"Added a dev dependency for solc so it now uses the inbuilt solcjs","created_at":"2018-02-02T13:59:58Z","updated_at":"2018-02-02T13:59:59Z","html_url":"https://github.com/Neufund/TypeChain/pull/26#discussion_r165651050","pull_request_url":"https://api.github.com/repos/Neufund/TypeChain/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/comments/165651050"},"html":{"href":"https://github.com/Neufund/TypeChain/pull/26#discussion_r165651050"},"pull_request":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Neufund/TypeChain/pulls/26","id":166808408,"html_url":"https://github.com/Neufund/TypeChain/pull/26","diff_url":"https://github.com/Neufund/TypeChain/pull/26.diff","patch_url":"https://github.com/Neufund/TypeChain/pull/26.patch","issue_url":"https://api.github.com/repos/Neufund/TypeChain/issues/26","number":26,"state":"open","locked":false,"title":"Updated to beta web3","user":{"login":"linusnorton","id":683300,"avatar_url":"https://avatars2.githubusercontent.com/u/683300?v=4","gravatar_id":"","url":"https://api.github.com/users/linusnorton","html_url":"https://github.com/linusnorton","followers_url":"https://api.github.com/users/linusnorton/followers","following_url":"https://api.github.com/users/linusnorton/following{/other_user}","gists_url":"https://api.github.com/users/linusnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/linusnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusnorton/subscriptions","organizations_url":"https://api.github.com/users/linusnorton/orgs","repos_url":"https://api.github.com/users/linusnorton/repos","events_url":"https://api.github.com/users/linusnorton/events{/privacy}","received_events_url":"https://api.github.com/users/linusnorton/received_events","type":"User","site_admin":false},"body":"This PR updates TypeChain to support the web3 1.0 API. It is not yet complete.\r\n\r\nI have patched most of the relevant API changes but I'm not quite sure how to deal with BigNumbers. Web3 1.0 returns them as strings rather encoding them as BigNumber by default. This means the return type on the generated TS code is incorrect. I wasn't sure whether to update it, or add the cast to BigNumber myself.\r\n\r\n","created_at":"2018-02-02T13:56:43Z","updated_at":"2018-02-02T13:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032c87fb1700d9d64cb61777b210823849b29897","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neufund/TypeChain/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Neufund/TypeChain/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Neufund/TypeChain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neufund/TypeChain/issues/26/comments","statuses_url":"https://api.github.com/repos/Neufund/TypeChain/statuses/668daf0ddec52a0aff9847b27703c372cd6a83a3","head":{"label":"linusnorton:master","ref":"master","sha":"668daf0ddec52a0aff9847b27703c372cd6a83a3","user":{"login":"linusnorton","id":683300,"avatar_url":"https://avatars2.githubusercontent.com/u/683300?v=4","gravatar_id":"","url":"https://api.github.com/users/linusnorton","html_url":"https://github.com/linusnorton","followers_url":"https://api.github.com/users/linusnorton/followers","following_url":"https://api.github.com/users/linusnorton/following{/other_user}","gists_url":"https://api.github.com/users/linusnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/linusnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusnorton/subscriptions","organizations_url":"https://api.github.com/users/linusnorton/orgs","repos_url":"https://api.github.com/users/linusnorton/repos","events_url":"https://api.github.com/users/linusnorton/events{/privacy}","received_events_url":"https://api.github.com/users/linusnorton/received_events","type":"User","site_admin":false},"repo":{"id":119959220,"name":"TypeChain","full_name":"linusnorton/TypeChain","owner":{"login":"linusnorton","id":683300,"avatar_url":"https://avatars2.githubusercontent.com/u/683300?v=4","gravatar_id":"","url":"https://api.github.com/users/linusnorton","html_url":"https://github.com/linusnorton","followers_url":"https://api.github.com/users/linusnorton/followers","following_url":"https://api.github.com/users/linusnorton/following{/other_user}","gists_url":"https://api.github.com/users/linusnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/linusnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusnorton/subscriptions","organizations_url":"https://api.github.com/users/linusnorton/orgs","repos_url":"https://api.github.com/users/linusnorton/repos","events_url":"https://api.github.com/users/linusnorton/events{/privacy}","received_events_url":"https://api.github.com/users/linusnorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linusnorton/TypeChain","description":"🔌 Typescript bindings for Ethereum smartcontracts","fork":true,"url":"https://api.github.com/repos/linusnorton/TypeChain","forks_url":"https://api.github.com/repos/linusnorton/TypeChain/forks","keys_url":"https://api.github.com/repos/linusnorton/TypeChain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linusnorton/TypeChain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linusnorton/TypeChain/teams","hooks_url":"https://api.github.com/repos/linusnorton/TypeChain/hooks","issue_events_url":"https://api.github.com/repos/linusnorton/TypeChain/issues/events{/number}","events_url":"https://api.github.com/repos/linusnorton/TypeChain/events","assignees_url":"https://api.github.com/repos/linusnorton/TypeChain/assignees{/user}","branches_url":"https://api.github.com/repos/linusnorton/TypeChain/branches{/branch}","tags_url":"https://api.github.com/repos/linusnorton/TypeChain/tags","blobs_url":"https://api.github.com/repos/linusnorton/TypeChain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linusnorton/TypeChain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linusnorton/TypeChain/git/refs{/sha}","trees_url":"https://api.github.com/repos/linusnorton/TypeChain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linusnorton/TypeChain/statuses/{sha}","languages_url":"https://api.github.com/repos/linusnorton/TypeChain/languages","stargazers_url":"https://api.github.com/repos/linusnorton/TypeChain/stargazers","contributors_url":"https://api.github.com/repos/linusnorton/TypeChain/contributors","subscribers_url":"https://api.github.com/repos/linusnorton/TypeChain/subscribers","subscription_url":"https://api.github.com/repos/linusnorton/TypeChain/subscription","commits_url":"https://api.github.com/repos/linusnorton/TypeChain/commits{/sha}","git_commits_url":"https://api.github.com/repos/linusnorton/TypeChain/git/commits{/sha}","comments_url":"https://api.github.com/repos/linusnorton/TypeChain/comments{/number}","issue_comment_url":"https://api.github.com/repos/linusnorton/TypeChain/issues/comments{/number}","contents_url":"https://api.github.com/repos/linusnorton/TypeChain/contents/{+path}","compare_url":"https://api.github.com/repos/linusnorton/TypeChain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linusnorton/TypeChain/merges","archive_url":"https://api.github.com/repos/linusnorton/TypeChain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linusnorton/TypeChain/downloads","issues_url":"https://api.github.com/repos/linusnorton/TypeChain/issues{/number}","pulls_url":"https://api.github.com/repos/linusnorton/TypeChain/pulls{/number}","milestones_url":"https://api.github.com/repos/linusnorton/TypeChain/milestones{/number}","notifications_url":"https://api.github.com/repos/linusnorton/TypeChain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linusnorton/TypeChain/labels{/name}","releases_url":"https://api.github.com/repos/linusnorton/TypeChain/releases{/id}","deployments_url":"https://api.github.com/repos/linusnorton/TypeChain/deployments","created_at":"2018-02-02T09:09:52Z","updated_at":"2018-02-02T09:09:53Z","pushed_at":"2018-02-02T13:56:00Z","git_url":"git://github.com/linusnorton/TypeChain.git","ssh_url":"git@github.com:linusnorton/TypeChain.git","clone_url":"https://github.com/linusnorton/TypeChain.git","svn_url":"https://github.com/linusnorton/TypeChain","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Neufund:master","ref":"master","sha":"8e9d2d74cbe33b494cc857bdfcc1864036f03d69","user":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"repo":{"id":102210005,"name":"TypeChain","full_name":"Neufund/TypeChain","owner":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neufund/TypeChain","description":"🔌 Typescript bindings for Ethereum smartcontracts","fork":false,"url":"https://api.github.com/repos/Neufund/TypeChain","forks_url":"https://api.github.com/repos/Neufund/TypeChain/forks","keys_url":"https://api.github.com/repos/Neufund/TypeChain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neufund/TypeChain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neufund/TypeChain/teams","hooks_url":"https://api.github.com/repos/Neufund/TypeChain/hooks","issue_events_url":"https://api.github.com/repos/Neufund/TypeChain/issues/events{/number}","events_url":"https://api.github.com/repos/Neufund/TypeChain/events","assignees_url":"https://api.github.com/repos/Neufund/TypeChain/assignees{/user}","branches_url":"https://api.github.com/repos/Neufund/TypeChain/branches{/branch}","tags_url":"https://api.github.com/repos/Neufund/TypeChain/tags","blobs_url":"https://api.github.com/repos/Neufund/TypeChain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neufund/TypeChain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neufund/TypeChain/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neufund/TypeChain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neufund/TypeChain/statuses/{sha}","languages_url":"https://api.github.com/repos/Neufund/TypeChain/languages","stargazers_url":"https://api.github.com/repos/Neufund/TypeChain/stargazers","contributors_url":"https://api.github.com/repos/Neufund/TypeChain/contributors","subscribers_url":"https://api.github.com/repos/Neufund/TypeChain/subscribers","subscription_url":"https://api.github.com/repos/Neufund/TypeChain/subscription","commits_url":"https://api.github.com/repos/Neufund/TypeChain/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neufund/TypeChain/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neufund/TypeChain/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neufund/TypeChain/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neufund/TypeChain/contents/{+path}","compare_url":"https://api.github.com/repos/Neufund/TypeChain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neufund/TypeChain/merges","archive_url":"https://api.github.com/repos/Neufund/TypeChain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neufund/TypeChain/downloads","issues_url":"https://api.github.com/repos/Neufund/TypeChain/issues{/number}","pulls_url":"https://api.github.com/repos/Neufund/TypeChain/pulls{/number}","milestones_url":"https://api.github.com/repos/Neufund/TypeChain/milestones{/number}","notifications_url":"https://api.github.com/repos/Neufund/TypeChain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neufund/TypeChain/labels{/name}","releases_url":"https://api.github.com/repos/Neufund/TypeChain/releases{/id}","deployments_url":"https://api.github.com/repos/Neufund/TypeChain/deployments","created_at":"2017-09-02T16:42:54Z","updated_at":"2018-01-31T11:16:40Z","pushed_at":"2018-02-02T13:56:44Z","git_url":"git://github.com/Neufund/TypeChain.git","ssh_url":"git@github.com:Neufund/TypeChain.git","clone_url":"https://github.com/Neufund/TypeChain.git","svn_url":"https://github.com/Neufund/TypeChain","homepage":null,"size":208,"stargazers_count":134,"watchers_count":134,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":12,"open_issues":4,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/26"},"html":{"href":"https://github.com/Neufund/TypeChain/pull/26"},"issue":{"href":"https://api.github.com/repos/Neufund/TypeChain/issues/26"},"comments":{"href":"https://api.github.com/repos/Neufund/TypeChain/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neufund/TypeChain/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Neufund/TypeChain/statuses/668daf0ddec52a0aff9847b27703c372cd6a83a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"linusnorton"}}