{"action":"created","comment":{"url":"https://api.github.com/repos/bundler/bundler/pulls/comments/173847186","pull_request_review_id":103103511,"id":173847186,"diff_hunk":"@@ -38,40 +36,42 @@ def definition.lock(*); end\n \n     private\n \n-      def install_git(names, version, options)\n-        uri = options.delete(:git)\n-        options[\"uri\"] = uri\n+      def extract_sources_from_options!(options)\n+        sources = {}\n \n+        sources[:git] = options.delete(:git) if options[:git]\n+        sources[:file] = options.delete(:file) if options[:file]\n+        sources[:source] = options.delete(:source) if options[:source]","path":"lib/bundler/plugin/installer.rb","position":29,"original_position":29,"commit_id":"431a51d8e2dc7312b8a0f7c68f878c3efbde1c7b","original_commit_id":"431a51d8e2dc7312b8a0f7c68f878c3efbde1c7b","user":{"login":"kerrizor","id":257689,"avatar_url":"https://avatars2.githubusercontent.com/u/257689?v=4","gravatar_id":"","url":"https://api.github.com/users/kerrizor","html_url":"https://github.com/kerrizor","followers_url":"https://api.github.com/users/kerrizor/followers","following_url":"https://api.github.com/users/kerrizor/following{/other_user}","gists_url":"https://api.github.com/users/kerrizor/gists{/gist_id}","starred_url":"https://api.github.com/users/kerrizor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerrizor/subscriptions","organizations_url":"https://api.github.com/users/kerrizor/orgs","repos_url":"https://api.github.com/users/kerrizor/repos","events_url":"https://api.github.com/users/kerrizor/events{/privacy}","received_events_url":"https://api.github.com/users/kerrizor/received_events","type":"User","site_admin":false},"body":"Do we actually need to remove these from `options`?","created_at":"2018-03-12T15:52:44Z","updated_at":"2018-03-12T16:04:13Z","html_url":"https://github.com/bundler/bundler/pull/6338#discussion_r173847186","pull_request_url":"https://api.github.com/repos/bundler/bundler/pulls/6338","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments/173847186"},"html":{"href":"https://github.com/bundler/bundler/pull/6338#discussion_r173847186"},"pull_request":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6338"}}},"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/6338","id":174234059,"html_url":"https://github.com/bundler/bundler/pull/6338","diff_url":"https://github.com/bundler/bundler/pull/6338.diff","patch_url":"https://github.com/bundler/bundler/pull/6338.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/6338","number":6338,"state":"open","locked":false,"title":"Add file path source option (`--file`) to plugin installation [WIP]","user":{"login":"saveriomiroddi","id":1595356,"avatar_url":"https://avatars2.githubusercontent.com/u/1595356?v=4","gravatar_id":"","url":"https://api.github.com/users/saveriomiroddi","html_url":"https://github.com/saveriomiroddi","followers_url":"https://api.github.com/users/saveriomiroddi/followers","following_url":"https://api.github.com/users/saveriomiroddi/following{/other_user}","gists_url":"https://api.github.com/users/saveriomiroddi/gists{/gist_id}","starred_url":"https://api.github.com/users/saveriomiroddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveriomiroddi/subscriptions","organizations_url":"https://api.github.com/users/saveriomiroddi/orgs","repos_url":"https://api.github.com/users/saveriomiroddi/repos","events_url":"https://api.github.com/users/saveriomiroddi/events{/privacy}","received_events_url":"https://api.github.com/users/saveriomiroddi/received_events","type":"User","site_admin":false},"body":"Convenience option for installing plugins from a local repository, using the local path:\n\n    bundle plugin install --file /path/to/bundler-dependency_graph bundler-dependency_graph\n\nCloses #5445.","created_at":"2018-03-11T18:13:47Z","updated_at":"2018-03-12T16:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74e9c08f38f2d11c135fa1322448c2843ab16f18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/6338/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/6338/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/6338/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/431a51d8e2dc7312b8a0f7c68f878c3efbde1c7b","head":{"label":"saveriomiroddi:sav-install_plugin_from_file_support","ref":"sav-install_plugin_from_file_support","sha":"431a51d8e2dc7312b8a0f7c68f878c3efbde1c7b","user":{"login":"saveriomiroddi","id":1595356,"avatar_url":"https://avatars2.githubusercontent.com/u/1595356?v=4","gravatar_id":"","url":"https://api.github.com/users/saveriomiroddi","html_url":"https://github.com/saveriomiroddi","followers_url":"https://api.github.com/users/saveriomiroddi/followers","following_url":"https://api.github.com/users/saveriomiroddi/following{/other_user}","gists_url":"https://api.github.com/users/saveriomiroddi/gists{/gist_id}","starred_url":"https://api.github.com/users/saveriomiroddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveriomiroddi/subscriptions","organizations_url":"https://api.github.com/users/saveriomiroddi/orgs","repos_url":"https://api.github.com/users/saveriomiroddi/repos","events_url":"https://api.github.com/users/saveriomiroddi/events{/privacy}","received_events_url":"https://api.github.com/users/saveriomiroddi/received_events","type":"User","site_admin":false},"repo":{"id":124768308,"name":"bundler-dev","full_name":"saveriomiroddi/bundler-dev","owner":{"login":"saveriomiroddi","id":1595356,"avatar_url":"https://avatars2.githubusercontent.com/u/1595356?v=4","gravatar_id":"","url":"https://api.github.com/users/saveriomiroddi","html_url":"https://github.com/saveriomiroddi","followers_url":"https://api.github.com/users/saveriomiroddi/followers","following_url":"https://api.github.com/users/saveriomiroddi/following{/other_user}","gists_url":"https://api.github.com/users/saveriomiroddi/gists{/gist_id}","starred_url":"https://api.github.com/users/saveriomiroddi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveriomiroddi/subscriptions","organizations_url":"https://api.github.com/users/saveriomiroddi/orgs","repos_url":"https://api.github.com/users/saveriomiroddi/repos","events_url":"https://api.github.com/users/saveriomiroddi/events{/privacy}","received_events_url":"https://api.github.com/users/saveriomiroddi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saveriomiroddi/bundler-dev","description":"My Bundler development fork","fork":true,"url":"https://api.github.com/repos/saveriomiroddi/bundler-dev","forks_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/forks","keys_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/teams","hooks_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/hooks","issue_events_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/issues/events{/number}","events_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/events","assignees_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/assignees{/user}","branches_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/branches{/branch}","tags_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/tags","blobs_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/languages","stargazers_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/stargazers","contributors_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/contributors","subscribers_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/subscribers","subscription_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/subscription","commits_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/contents/{+path}","compare_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/merges","archive_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/downloads","issues_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/issues{/number}","pulls_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/labels{/name}","releases_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/releases{/id}","deployments_url":"https://api.github.com/repos/saveriomiroddi/bundler-dev/deployments","created_at":"2018-03-11T15:06:29Z","updated_at":"2018-03-11T15:07:04Z","pushed_at":"2018-03-11T22:08:29Z","git_url":"git://github.com/saveriomiroddi/bundler-dev.git","ssh_url":"git@github.com:saveriomiroddi/bundler-dev.git","clone_url":"https://github.com/saveriomiroddi/bundler-dev.git","svn_url":"https://github.com/saveriomiroddi/bundler-dev","homepage":"","size":34120,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"007a1737f3d3ba678bc78d3fa101d61b3d6892db","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your Ruby application's gem dependencies","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/bundler/bundler/deployments","created_at":"2010-01-26T00:46:38Z","updated_at":"2018-03-12T15:52:44Z","pushed_at":"2018-03-12T08:50:29Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"https://bundler.io","size":34117,"stargazers_count":4128,"watchers_count":4128,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1884,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1884,"open_issues":148,"watchers":4128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6338"},"html":{"href":"https://github.com/bundler/bundler/pull/6338"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/6338"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/6338/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6338/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6338/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/431a51d8e2dc7312b8a0f7c68f878c3efbde1c7b"}},"author_association":"NONE"}}
{"actor":{"display_login":"kerrizor"}}