{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/24132","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/24132/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/24132/comments","events_url":"https://api.github.com/repos/angular/angular/issues/24132/events","html_url":"https://github.com/angular/angular/pull/24132","id":326548503,"number":24132,"title":"feat(platform-server): use EventManagerPlugin on the server","user":{"login":"vikerman","id":85066,"avatar_url":"https://avatars3.githubusercontent.com/u/85066?v=4","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-25T14:33:15Z","updated_at":"2018-05-25T14:47:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/24132","html_url":"https://github.com/angular/angular/pull/24132","diff_url":"https://github.com/angular/angular/pull/24132.diff","patch_url":"https://github.com/angular/angular/pull/24132.patch"},"body":"Previously event handlers on the server were setup directly. This change makes it so that the event registration on the server go through EventManagerPlugin just like on client. This allows us to add custom event registration handlers on the server which allows us to hook up preboot event handlers cleanly.\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\nThe server renderer directly sets up DOM event handlers on the server.\r\n\r\n## What is the new behavior?\r\nThe server renderer uses the EventManagerPlugin system to register DOM event handlers. This is useful to hook up a different event registration on the server - for instance add an attribute for every element that has an event handler so that preboot can query and buffers only those elements.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n\r\n## Other information\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/392081504","html_url":"https://github.com/angular/angular/pull/24132#issuecomment-392081504","issue_url":"https://api.github.com/repos/angular/angular/issues/24132","id":392081504,"user":{"login":"mary-poppins","id":4871841,"avatar_url":"https://avatars3.githubusercontent.com/u/4871841?v=4","gravatar_id":"","url":"https://api.github.com/users/mary-poppins","html_url":"https://github.com/mary-poppins","followers_url":"https://api.github.com/users/mary-poppins/followers","following_url":"https://api.github.com/users/mary-poppins/following{/other_user}","gists_url":"https://api.github.com/users/mary-poppins/gists{/gist_id}","starred_url":"https://api.github.com/users/mary-poppins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mary-poppins/subscriptions","organizations_url":"https://api.github.com/users/mary-poppins/orgs","repos_url":"https://api.github.com/users/mary-poppins/repos","events_url":"https://api.github.com/users/mary-poppins/events{/privacy}","received_events_url":"https://api.github.com/users/mary-poppins/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T14:47:45Z","updated_at":"2018-05-25T14:47:45Z","author_association":"NONE","body":"You can preview 4859325 at https://pr24132-4859325.ngbuilds.io/."}}
{"actor":{"display_login":"mary-poppins"}}