{"action":"created","comment":{"url":"https://api.github.com/repos/artefactual/atom/pulls/comments/175605673","pull_request_review_id":105162841,"id":175605673,"diff_hunk":"@@ -103,7 +103,9 @@ public static function nextAvailableIdentifier()\n       $con->beginTransaction();\n \n       // Determine what should be the next identifier\n-      $identifier = Qubit::generateIdentifierFromCounterAndMask(self::nextAccessionNumber(), sfConfig::get('app_accession_mask'));\n+      $setting = QubitSetting::getByName('accession_mask');\n+      $mask = $setting->getValue(array('sourceCulture' => true));\n+      $identifier = Qubit::generateIdentifierFromCounterAndMask(self::nextAccessionNumber(), $mask);","path":"plugins/qtAccessionPlugin/lib/model/QubitAccession.php","position":7,"original_position":7,"commit_id":"6ad917404acd4f2a8c53f90c034b99d4fb2312e1","original_commit_id":"6ad917404acd4f2a8c53f90c034b99d4fb2312e1","user":{"login":"mcantelon","id":49010,"avatar_url":"https://avatars0.githubusercontent.com/u/49010?v=4","gravatar_id":"","url":"https://api.github.com/users/mcantelon","html_url":"https://github.com/mcantelon","followers_url":"https://api.github.com/users/mcantelon/followers","following_url":"https://api.github.com/users/mcantelon/following{/other_user}","gists_url":"https://api.github.com/users/mcantelon/gists{/gist_id}","starred_url":"https://api.github.com/users/mcantelon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcantelon/subscriptions","organizations_url":"https://api.github.com/users/mcantelon/orgs","repos_url":"https://api.github.com/users/mcantelon/repos","events_url":"https://api.github.com/users/mcantelon/events{/privacy}","received_events_url":"https://api.github.com/users/mcantelon/received_events","type":"User","site_admin":false},"body":"Ah! Good to know! I'll change that.","created_at":"2018-03-19T22:26:28Z","updated_at":"2018-03-19T22:26:28Z","html_url":"https://github.com/artefactual/atom/pull/682#discussion_r175605673","pull_request_url":"https://api.github.com/repos/artefactual/atom/pulls/682","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments/175605673"},"html":{"href":"https://github.com/artefactual/atom/pull/682#discussion_r175605673"},"pull_request":{"href":"https://api.github.com/repos/artefactual/atom/pulls/682"}},"in_reply_to_id":175397640},"pull_request":{"url":"https://api.github.com/repos/artefactual/atom/pulls/682","id":175807053,"html_url":"https://github.com/artefactual/atom/pull/682","diff_url":"https://github.com/artefactual/atom/pull/682.diff","patch_url":"https://github.com/artefactual/atom/pull/682.patch","issue_url":"https://api.github.com/repos/artefactual/atom/issues/682","number":682,"state":"open","locked":false,"title":"Accession import identifier handling, refs #12043","user":{"login":"mcantelon","id":49010,"avatar_url":"https://avatars0.githubusercontent.com/u/49010?v=4","gravatar_id":"","url":"https://api.github.com/users/mcantelon","html_url":"https://github.com/mcantelon","followers_url":"https://api.github.com/users/mcantelon/followers","following_url":"https://api.github.com/users/mcantelon/following{/other_user}","gists_url":"https://api.github.com/users/mcantelon/gists{/gist_id}","starred_url":"https://api.github.com/users/mcantelon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcantelon/subscriptions","organizations_url":"https://api.github.com/users/mcantelon/orgs","repos_url":"https://api.github.com/users/mcantelon/repos","events_url":"https://api.github.com/users/mcantelon/events{/privacy}","received_events_url":"https://api.github.com/users/mcantelon/received_events","type":"User","site_admin":false},"body":"Changed CSV accession import so if an accession number isn't specified the row\r\nis skipped, unless the assign-id option is used when running the import task.\r\n\r\nFixed issue with generating identifiers based on masks/counters from the CLI.","created_at":"2018-03-19T05:20:02Z","updated_at":"2018-03-19T22:26:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b68f089e17e3089883bb13ab58c8983f8add710","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artefactual/atom/pulls/682/commits","review_comments_url":"https://api.github.com/repos/artefactual/atom/pulls/682/comments","review_comment_url":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual/atom/issues/682/comments","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/6ad917404acd4f2a8c53f90c034b99d4fb2312e1","head":{"label":"artefactual:dev/issue-12043-csv-accession-import-blank-ids","ref":"dev/issue-12043-csv-accession-import-blank-ids","sha":"6ad917404acd4f2a8c53f90c034b99d4fb2312e1","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars1.githubusercontent.com/u/1163545?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars1.githubusercontent.com/u/1163545?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/atom/deployments","created_at":"2012-09-06T17:35:28Z","updated_at":"2018-03-14T22:46:35Z","pushed_at":"2018-03-19T17:49:39Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":63900,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":58,"open_issues":5,"watchers":86,"default_branch":"qa/2.5.x"}},"base":{"label":"artefactual:qa/2.5.x","ref":"qa/2.5.x","sha":"3221e400bec5ff4fb95fd6952e11eb35843af313","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars1.githubusercontent.com/u/1163545?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars1.githubusercontent.com/u/1163545?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/atom/deployments","created_at":"2012-09-06T17:35:28Z","updated_at":"2018-03-14T22:46:35Z","pushed_at":"2018-03-19T17:49:39Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":63900,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":58,"open_issues":5,"watchers":86,"default_branch":"qa/2.5.x"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/682"},"html":{"href":"https://github.com/artefactual/atom/pull/682"},"issue":{"href":"https://api.github.com/repos/artefactual/atom/issues/682"},"comments":{"href":"https://api.github.com/repos/artefactual/atom/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual/atom/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual/atom/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual/atom/statuses/6ad917404acd4f2a8c53f90c034b99d4fb2312e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcantelon"}}