{"action":"created","issue":{"url":"https://api.github.com/repos/percy/percy-web/issues/660","repository_url":"https://api.github.com/repos/percy/percy-web","labels_url":"https://api.github.com/repos/percy/percy-web/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/percy/percy-web/issues/660/comments","events_url":"https://api.github.com/repos/percy/percy-web/issues/660/events","html_url":"https://github.com/percy/percy-web/pull/660","id":347199608,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODgxMTkz","number":660,"title":"Fix moment warnings","user":{"login":"cadeParade","id":3179218,"node_id":"MDQ6VXNlcjMxNzkyMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3179218?v=4","gravatar_id":"","url":"https://api.github.com/users/cadeParade","html_url":"https://github.com/cadeParade","followers_url":"https://api.github.com/users/cadeParade/followers","following_url":"https://api.github.com/users/cadeParade/following{/other_user}","gists_url":"https://api.github.com/users/cadeParade/gists{/gist_id}","starred_url":"https://api.github.com/users/cadeParade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadeParade/subscriptions","organizations_url":"https://api.github.com/users/cadeParade/orgs","repos_url":"https://api.github.com/users/cadeParade/repos","events_url":"https://api.github.com/users/cadeParade/events{/privacy}","received_events_url":"https://api.github.com/users/cadeParade/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-02T22:41:49Z","updated_at":"2018-08-07T17:02:44Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/percy/percy-web/pulls/660","html_url":"https://github.com/percy/percy-web/pull/660","diff_url":"https://github.com/percy/percy-web/pull/660.diff","patch_url":"https://github.com/percy/percy-web/pull/660.patch"},"body":"## Description\r\nAs a followup to #645, this is a fix for the `moment` warnings that show up in the tests.\r\n\r\nThere were three root causes of these warnings:\r\n- Bar graph on billing page was using `now` as an argument. This seemed to work when printing logs to the console, but it is an undocumented feature. I've changed it to use the `utc` helper which is documented on the `ember-moment` page, and that removes the warnings from the billing page.\r\n\r\n- `build.baseBuild.createdAt`. Most test setups do not have a base build. When rendering certain components that look for the `baseBuild`, the test was trying to render a datetime that didn't exist. I've added a base build to each test case that needs it.\r\n\r\n- `build.approvedAt`. Sometimes we want to render when the build is approved, but in the tests the `approvedAt` date was not set. Now it is.\r\n\r\nQuestions:\r\n- Should we explicitly include `baseBuild` for builds that need it, or in the template check if it exists before displaying?\r\n- Is there a way to get FactoryGuy to recognize a default property that is the same as itself? (ex: for baseBuild to be a default property, it would look something like: `baseBuild: FactoryGuy.belongsTo('build')` but this causes a stack overflow.\r\n"},"comment":{"url":"https://api.github.com/repos/percy/percy-web/issues/comments/411129383","html_url":"https://github.com/percy/percy-web/pull/660#issuecomment-411129383","issue_url":"https://api.github.com/repos/percy/percy-web/issues/660","id":411129383,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTEyOTM4Mw==","user":{"login":"cadeParade","id":3179218,"node_id":"MDQ6VXNlcjMxNzkyMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3179218?v=4","gravatar_id":"","url":"https://api.github.com/users/cadeParade","html_url":"https://github.com/cadeParade","followers_url":"https://api.github.com/users/cadeParade/followers","following_url":"https://api.github.com/users/cadeParade/following{/other_user}","gists_url":"https://api.github.com/users/cadeParade/gists{/gist_id}","starred_url":"https://api.github.com/users/cadeParade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadeParade/subscriptions","organizations_url":"https://api.github.com/users/cadeParade/orgs","repos_url":"https://api.github.com/users/cadeParade/repos","events_url":"https://api.github.com/users/cadeParade/events{/privacy}","received_events_url":"https://api.github.com/users/cadeParade/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T17:02:44Z","updated_at":"2018-08-07T17:02:44Z","author_association":"COLLABORATOR","body":"Thanks both for your review. @maprules1000 setting `allowEmpty` to true in test environment is a great idea, I've done this."}}
{"actor":{"display_login":"cadeParade"}}