{"action":"created","comment":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/244533149","pull_request_review_id":188437996,"id":244533149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUzMzE0OQ==","diff_hunk":"@@ -54,13 +54,9 @@ install:\n   - |\n     set -e\n     export DEPSPREFIX=$TRAVIS_BUILD_DIR/travisdeps\n-    if [ \"$TRAVIS_OS_NAME\" == \"linux\" ]; then\n-      export PREFIX=/usr\n-    else\n-      export PREFIX=$TRAVIS_BUILD_DIR/target\n-    fi\n-    export PATH=$PATH:$DEPSPREFIX/bin:$PREFIX/bin:$TRAVIS_BUILD_DIR/target/$DEPSPREFIX/bin:$TRAVIS_BUILD_DIR/target/$PREFIX/bin\n-    export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$DEPSPREFIX/lib:$PREFIX/lib:$TRAVIS_BUILD_DIR/target/$DEPSPREFIX/lib:$TRAVIS_BUILD_DIR/target/$PREFIX/lib\n+    export PREFIX=$TRAVIS_BUILD_DIR/target","path":".travis.yml","position":null,"original_position":11,"commit_id":"e0b4e126a074bf42789dea273de17271e78282f1","original_commit_id":"e0b4e126a074bf42789dea273de17271e78282f1","user":{"login":"probonopd","id":2480569,"node_id":"MDQ6VXNlcjI0ODA1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/2480569?v=4","gravatar_id":"","url":"https://api.github.com/users/probonopd","html_url":"https://github.com/probonopd","followers_url":"https://api.github.com/users/probonopd/followers","following_url":"https://api.github.com/users/probonopd/following{/other_user}","gists_url":"https://api.github.com/users/probonopd/gists{/gist_id}","starred_url":"https://api.github.com/users/probonopd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probonopd/subscriptions","organizations_url":"https://api.github.com/users/probonopd/orgs","repos_url":"https://api.github.com/users/probonopd/repos","events_url":"https://api.github.com/users/probonopd/events{/privacy}","received_events_url":"https://api.github.com/users/probonopd/received_events","type":"User","site_admin":false},"body":"```\r\nme@host:~$ grep -r /home/travis/build/fontforge /tmp/.mount_FontFoCwNvLZ | wc -l\r\n53\r\n```\r\n\r\ntells me that the string `/home/travis/build/fontforge` is hardcoded in at least 53 places.","created_at":"2018-12-30T12:43:00Z","updated_at":"2018-12-30T12:43:01Z","html_url":"https://github.com/fontforge/fontforge/pull/3374#discussion_r244533149","pull_request_url":"https://api.github.com/repos/fontforge/fontforge/pulls/3374","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/244533149"},"html":{"href":"https://github.com/fontforge/fontforge/pull/3374#discussion_r244533149"},"pull_request":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/3374"}},"in_reply_to_id":244532721},"pull_request":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/3374","id":235200335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjAwMzM1","html_url":"https://github.com/fontforge/fontforge/pull/3374","diff_url":"https://github.com/fontforge/fontforge/pull/3374.diff","patch_url":"https://github.com/fontforge/fontforge/pull/3374.patch","issue_url":"https://api.github.com/repos/fontforge/fontforge/issues/3374","number":3374,"state":"open","locked":false,"title":"Build an AppImage for each git push","user":{"login":"probonopd","id":2480569,"node_id":"MDQ6VXNlcjI0ODA1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/2480569?v=4","gravatar_id":"","url":"https://api.github.com/users/probonopd","html_url":"https://github.com/probonopd","followers_url":"https://api.github.com/users/probonopd/followers","following_url":"https://api.github.com/users/probonopd/following{/other_user}","gists_url":"https://api.github.com/users/probonopd/gists{/gist_id}","starred_url":"https://api.github.com/users/probonopd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probonopd/subscriptions","organizations_url":"https://api.github.com/users/probonopd/orgs","repos_url":"https://api.github.com/users/probonopd/repos","events_url":"https://api.github.com/users/probonopd/events{/privacy}","received_events_url":"https://api.github.com/users/probonopd/received_events","type":"User","site_admin":false},"body":"Screenshot: This is the FontForge AppImage built on Travis CI from `master`, running on Clear Linux (a distribution for which no native FontForge package exists)\r\n\r\n![](https://user-images.githubusercontent.com/2480569/49328019-371bc600-f561-11e8-9d3d-aff9fa6aa1ca.png)\r\n\r\n### Motivation and Context\r\n- [ ] Why is this change required? What problem does it solve?\r\n- [x] Closes #3056\r\n\r\n### Types of changes\r\nWhat types of changes does your code introduce? Check all the boxes that apply:\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Description\r\n- [x] Describe your changes in detail.\r\n\r\nThis PR, when merged, will use the [Travis CI](https://travis-ci.org/) build to create an [AppImage](http://appimage.org/) for each `git push`.\r\n\r\nThe AppImage could then be uploaded to GitHub Releases automatically.\r\n\r\nProviding an [AppImage](http://appimage.org/) would have, among others, these advantages:\r\n\r\n- Applications packaged as an AppImage can run on many distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)\r\n- One app = one file = super simple for users: just download one AppImage file, [make it executable](http://discourse.appimage.org/t/how-to-make-an-appimage-executable/80), and run\r\n- No unpacking or installation necessary\r\n- No root needed\r\n- No system libraries changed\r\n- Works out of the box, no installation of runtimes needed\r\n- Optional desktop integration with `appimaged`\r\n- Optional binary delta updates, e.g., for continuous builds (only download the binary diff) using AppImageUpdate\r\n- Can optionally GPG2-sign your AppImages (inside the file)\r\n- Works on Live ISOs\r\n- Can use the same AppImages when dual-booting multiple distributions\r\n- Can be listed in the [AppImageHub](https://appimage.github.io/apps) central directory of available AppImages\r\n- Can double as a self-extracting compressed archive with the `--appimage-extract` parameter\r\n- No repositories needed. Suitable/optimized for air-gapped (offline) machines\r\n\r\n[Here is an overview](https://appimage.github.io/apps) of projects that are already distributing upstream-provided, official AppImages.\r\n\r\nIf you have questions, AppImage developers are on #AppImage on irc.freenode.net.\r\n\r\n### Final checklist\r\n\r\n- [x] My code follows the code style of this project found [here](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md#coding-style).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**CONTRIBUTING**](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md) guidelines.","created_at":"2018-12-01T15:46:25Z","updated_at":"2018-12-30T12:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e22d1881721f567202b607d730045488fd029fbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fontforge/fontforge/pulls/3374/commits","review_comments_url":"https://api.github.com/repos/fontforge/fontforge/pulls/3374/comments","review_comment_url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fontforge/fontforge/issues/3374/comments","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/e0b4e126a074bf42789dea273de17271e78282f1","head":{"label":"probonopd:master","ref":"master","sha":"e0b4e126a074bf42789dea273de17271e78282f1","user":{"login":"probonopd","id":2480569,"node_id":"MDQ6VXNlcjI0ODA1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/2480569?v=4","gravatar_id":"","url":"https://api.github.com/users/probonopd","html_url":"https://github.com/probonopd","followers_url":"https://api.github.com/users/probonopd/followers","following_url":"https://api.github.com/users/probonopd/following{/other_user}","gists_url":"https://api.github.com/users/probonopd/gists{/gist_id}","starred_url":"https://api.github.com/users/probonopd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probonopd/subscriptions","organizations_url":"https://api.github.com/users/probonopd/orgs","repos_url":"https://api.github.com/users/probonopd/repos","events_url":"https://api.github.com/users/probonopd/events{/privacy}","received_events_url":"https://api.github.com/users/probonopd/received_events","type":"User","site_admin":false},"repo":{"id":159122687,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxMjI2ODc=","name":"fontforge","full_name":"probonopd/fontforge","private":false,"owner":{"login":"probonopd","id":2480569,"node_id":"MDQ6VXNlcjI0ODA1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/2480569?v=4","gravatar_id":"","url":"https://api.github.com/users/probonopd","html_url":"https://github.com/probonopd","followers_url":"https://api.github.com/users/probonopd/followers","following_url":"https://api.github.com/users/probonopd/following{/other_user}","gists_url":"https://api.github.com/users/probonopd/gists{/gist_id}","starred_url":"https://api.github.com/users/probonopd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probonopd/subscriptions","organizations_url":"https://api.github.com/users/probonopd/orgs","repos_url":"https://api.github.com/users/probonopd/repos","events_url":"https://api.github.com/users/probonopd/events{/privacy}","received_events_url":"https://api.github.com/users/probonopd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/probonopd/fontforge","description":"Free (libre) font editor for Windows, Mac OS X and GNU+Linux","fork":true,"url":"https://api.github.com/repos/probonopd/fontforge","forks_url":"https://api.github.com/repos/probonopd/fontforge/forks","keys_url":"https://api.github.com/repos/probonopd/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/probonopd/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/probonopd/fontforge/teams","hooks_url":"https://api.github.com/repos/probonopd/fontforge/hooks","issue_events_url":"https://api.github.com/repos/probonopd/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/probonopd/fontforge/events","assignees_url":"https://api.github.com/repos/probonopd/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/probonopd/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/probonopd/fontforge/tags","blobs_url":"https://api.github.com/repos/probonopd/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/probonopd/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/probonopd/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/probonopd/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/probonopd/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/probonopd/fontforge/languages","stargazers_url":"https://api.github.com/repos/probonopd/fontforge/stargazers","contributors_url":"https://api.github.com/repos/probonopd/fontforge/contributors","subscribers_url":"https://api.github.com/repos/probonopd/fontforge/subscribers","subscription_url":"https://api.github.com/repos/probonopd/fontforge/subscription","commits_url":"https://api.github.com/repos/probonopd/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/probonopd/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/probonopd/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/probonopd/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/probonopd/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/probonopd/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/probonopd/fontforge/merges","archive_url":"https://api.github.com/repos/probonopd/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/probonopd/fontforge/downloads","issues_url":"https://api.github.com/repos/probonopd/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/probonopd/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/probonopd/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/probonopd/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/probonopd/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/probonopd/fontforge/releases{/id}","deployments_url":"https://api.github.com/repos/probonopd/fontforge/deployments","created_at":"2018-11-26T06:39:53Z","updated_at":"2018-12-30T08:37:01Z","pushed_at":"2018-12-30T08:36:58Z","git_url":"git://github.com/probonopd/fontforge.git","ssh_url":"git@github.com:probonopd/fontforge.git","clone_url":"https://github.com/probonopd/fontforge.git","svn_url":"https://github.com/probonopd/fontforge","homepage":"http://fontforge.github.io/","size":83131,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fontforge:master","ref":"master","sha":"2d6b468feed0f9f4dda6930a8b89d5b46ac1f0d6","user":{"login":"fontforge","id":2048660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDg2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2048660?v=4","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"node_id":"MDEwOlJlcG9zaXRvcnk1MzkwMTU2","name":"fontforge","full_name":"fontforge/fontforge","private":false,"owner":{"login":"fontforge","id":2048660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDg2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2048660?v=4","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fontforge/fontforge","description":"Free (libre) font editor for Windows, Mac OS X and GNU+Linux","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","deployments_url":"https://api.github.com/repos/fontforge/fontforge/deployments","created_at":"2012-08-12T17:08:20Z","updated_at":"2018-12-30T00:52:05Z","pushed_at":"2018-12-30T09:51:15Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io/","size":83066,"stargazers_count":2210,"watchers_count":2210,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"archived":false,"open_issues_count":993,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":374,"open_issues":993,"watchers":2210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/3374"},"html":{"href":"https://github.com/fontforge/fontforge/pull/3374"},"issue":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/3374"},"comments":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/3374/comments"},"review_comments":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/3374/comments"},"review_comment":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/3374/commits"},"statuses":{"href":"https://api.github.com/repos/fontforge/fontforge/statuses/e0b4e126a074bf42789dea273de17271e78282f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"probonopd"}}