{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/WhereHows/issues/1361","repository_url":"https://api.github.com/repos/linkedin/WhereHows","labels_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1361/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1361/comments","events_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1361/events","html_url":"https://github.com/linkedin/WhereHows/pull/1361","id":357864872,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzc3NDEx","number":1361,"title":"Change global hotkeys to use native event listener","user":{"login":"cptran777","id":16459843,"node_id":"MDQ6VXNlcjE2NDU5ODQz","avatar_url":"https://avatars3.githubusercontent.com/u/16459843?v=4","gravatar_id":"","url":"https://api.github.com/users/cptran777","html_url":"https://github.com/cptran777","followers_url":"https://api.github.com/users/cptran777/followers","following_url":"https://api.github.com/users/cptran777/following{/other_user}","gists_url":"https://api.github.com/users/cptran777/gists{/gist_id}","starred_url":"https://api.github.com/users/cptran777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptran777/subscriptions","organizations_url":"https://api.github.com/users/cptran777/orgs","repos_url":"https://api.github.com/users/cptran777/repos","events_url":"https://api.github.com/users/cptran777/events{/privacy}","received_events_url":"https://api.github.com/users/cptran777/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-06T23:25:50Z","updated_at":"2018-09-07T17:42:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linkedin/WhereHows/pulls/1361","html_url":"https://github.com/linkedin/WhereHows/pull/1361","diff_url":"https://github.com/linkedin/WhereHows/pull/1361.diff","patch_url":"https://github.com/linkedin/WhereHows/pull/1361.patch"},"body":"Original implementation of global hotkeys used a wrapper ember component to handle all keystrokes that bubbled up to it. However, it seems like this approach isn't perfect as when a user is browsing and enters a new page, the only element that has focus for keystrokes is the `<body>`. Because of this, changing implementation to add an event listener to the body in order to capture all keystrokes. \r\n\r\n`ember test` results:\r\n```\r\n1..520\r\n# tests 520\r\n# pass  513\r\n# skip  7\r\n# fail  0\r\n\r\n# ok\r\n```"},"comment":{"url":"https://api.github.com/repos/linkedin/WhereHows/issues/comments/419514352","html_url":"https://github.com/linkedin/WhereHows/pull/1361#issuecomment-419514352","issue_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1361","id":419514352,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUxNDM1Mg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T17:42:44Z","updated_at":"2018-09-07T17:42:44Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=h1) Report\n> Merging [#1361](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=desc) into [master](https://codecov.io/gh/linkedin/WhereHows/commit/53ad5e3f86c710849c754790cbbf57b0483b50f3?src=pr&el=desc) will **increase** coverage by `0.08%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/linkedin/WhereHows/pull/1361/graphs/tree.svg?width=650&token=jYqDhdjJqw&height=150&src=pr)](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1361      +/-   ##\n==========================================\n+ Coverage   58.38%   58.47%   +0.08%     \n==========================================\n  Files         181      181              \n  Lines        3828     3836       +8     \n  Branches      848      850       +2     \n==========================================\n+ Hits         2235     2243       +8     \n  Misses       1593     1593\n```\n\n\n| [Impacted Files](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...ehows-web/app/components/hotkeys/global-hotkeys.ts](https://codecov.io/gh/linkedin/WhereHows/pull/1361/diff?src=pr&el=tree#diff-d2hlcmVob3dzLXdlYi9hcHAvY29tcG9uZW50cy9ob3RrZXlzL2dsb2JhbC1ob3RrZXlzLnRz) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=footer). Last update [53ad5e3...5c1785b](https://codecov.io/gh/linkedin/WhereHows/pull/1361?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}