{"push_id":2677939906,"size":53,"distinct_size":53,"ref":"refs/heads/unicoded-wildcard-route53","head":"7716784015b23571b9f6ec4119ac243fd330717a","before":"c716df795b486ba204d72df4d348feed376ec6d8","commits":[{"sha":"d9e7e9fa70383b0bacac8f90ee5eea0cd320914a","author":{"name":"Sami J Laine","email":"f628c6c56606b962f7c65848c9df3eb75c90d16b@gmail.com"},"message":"Your code has been rated at 9.67/10 (previous run: 8.96/10, +0.70)","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/d9e7e9fa70383b0bacac8f90ee5eea0cd320914a"},{"sha":"8c76a5aba60484a8248f21f5779c0ea2e993d27b","author":{"name":"Sami J Laine","email":"f628c6c56606b962f7c65848c9df3eb75c90d16b@gmail.com"},"message":"In the defence of grammar.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/8c76a5aba60484a8248f21f5779c0ea2e993d27b"},{"sha":"e10e3d2e2ef675cdb61f284f4311db86b43e01e3","author":{"name":"Mircea Ulinic","email":"f82e4e0433caf7f08329382063977dd4d313e271@cloudflare.com"},"message":"Add Redis SDB modules","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/e10e3d2e2ef675cdb61f284f4311db86b43e01e3"},{"sha":"63ddcd72a696db975b7adbf6e909eeb4ddaf282b","author":{"name":"Mircea Ulinic","email":"f82e4e0433caf7f08329382063977dd4d313e271@cloudflare.com"},"message":"Document the Redis SDB module","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/63ddcd72a696db975b7adbf6e909eeb4ddaf282b"},{"sha":"cca8b2fa3e9cfce28ee43846620b64d16169b227","author":{"name":"Bo Maryniuk","email":"dc45fe023482b3b890b5e574e53c1d051f45b1ef@suse.de"},"message":"Include missing module import for Salt SSH on Python 2.x","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/cca8b2fa3e9cfce28ee43846620b64d16169b227"},{"sha":"7612f4524a9ecb94972699257902faec3f7f5d4e","author":{"name":"Mircea Ulinic","email":"f82e4e0433caf7f08329382063977dd4d313e271@cloudflare.com"},"message":"Enhance the proxy_napalm_wrap decorator to allow proxyless execution\n\nUsually the Salt proxies have been designed using a single methodology: for\neach device you aim to manage, start one Proxy Minion. The NAPALM modules didn't\nmake an exception, however, beginning with https://github.com/saltstack/salt/pull/38339\n(therefore starting with release Nitrogen), the functionality has been enhanced\nin such a way that we can execute the code when we are able to install the\nregular Minion directly on the network hardware.\n\nThere is another use case, for something, let's call it \"proxyless\" when we\ndon't particularly need to start a Proxy process for each device, but rather\nsimply invoke arbitrary functions. These changes make this possible, so with one\nsingle Minion (whether Proxy or regular), one is able to execute Salt commands\ngoing through the NAPALM library to connect to the remote network device by\nspecifying the connection details from the command line and/or opts/pillar, e.g.\n``salt server1 bgp.neighbors driver=junos host=1.2.3.4 username=salt``.\n\nIf the ``server1`` Minion has the following block in the Pillar (for example):\n\n```yaml\nnapalm:\n  driver: junos\n  username: salt\n```\n\nThe user would only need to provide the rest of the credentials (depending on\neach individual case):\n\n``salt server1 bgp.neighbors host=1.2.3.4``.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/7612f4524a9ecb94972699257902faec3f7f5d4e"},{"sha":"50457a5f7602b806b5996f931d642156256ae6fd","author":{"name":"Mircea Ulinic","email":"f82e4e0433caf7f08329382063977dd4d313e271@cloudflare.com"},"message":"Add the possibility to have the credentials for all devices into napalm_inventory\n\nThis is going to ease the CLI usage, so we can reduce everything to simply\nspecifying the host of the device, e.g.,\n\nHaving the following configuration in the opts/pillar:\n\n```yaml\nnapalm:\n  username: salt\n  password: test\n\nnapalm_inventory:\n  1.2.3.4:\n    driver: eos\n  edge01.bzr01:\n    driver: junos\n```\n\nWith the above available in the opts/pillar for a Minion, say ``server1``, the\nuser would be able to execute: ``salt 'server1' bgp.neighbors host=1.2.3.4`` or\n``salt 'server1' net.arp host=edge01.bzr01``, etc.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/50457a5f7602b806b5996f931d642156256ae6fd"},{"sha":"256a1231081b173bcc45b1421fd97b3148dce5c6","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Refactoring virt.get_disks\n\nvirt.get_disks does not need to depend on libvirt:hypervisor value to\ndecice whether to extract data using qemu-img info on a disk image.\nThis needs to be run on all qemu images... and those can be also used\nby a Xen VM nowadays.\n\nThe refactoring removes that dependency on the deprecated configuration\nlibvirt:hypervisor and uses the value for the <driver> type attribute\nin the disk XML configuration.\n\nEnhance the get_disk unit test to make sure that the qemu-img info is\nparsed for a qemu image and not for others","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/256a1231081b173bcc45b1421fd97b3148dce5c6"},{"sha":"489b30c7704f97cf43c2af9054c2c33594479825","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Fix qemu-img infos output parsing\n\nAs mentioned in issue #48085 qemu-img infos parsing is really fragile.\nIn order to fix the weaknesses of that parsing use the --output json\nparameter of qemu-img infos and parse this rather than the human output.\n\nNote that the following properties in virt.get_disks output have a\ndifferent format:\n\n  * disk size, virtual size and snapshot vmsize are now in bytes, rather\n    than in a human-friendly format\n  * date is now complete and in iso format, but that won't bother\n    anybody since that was broken before (only had the time part)\n\nSince the image property was a duplicate of the file one, they have been\nconsolidated into a single file property.\n\nAll format-specific values are simply not provided, but as those were\nin the snapshots list before it's rather likely no one will care.\n\nAlso write the parsed data into a dictionary rather than writing it as\nYAML in a string and parse it later on.\n\nThis commit also adds a unit test for _parse_qemu_img_info() function.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/489b30c7704f97cf43c2af9054c2c33594479825"},{"sha":"6659e7beae158c5d6db03127cb53bcf36ca89e90","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"virt.get_disks provides complete backing chain\n\nAs mentioned in issue #48085, if a disk image has a backing file,\n_parse_qemu_img_info() only returns the path to the backing file.\nFrom a user point of view this is rather limited since there is no way\nto know more on that file.\n\nvirt.get_disks now uses --backing-chain parameter to get the disk data\nfor all disks in the backing chain.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/6659e7beae158c5d6db03127cb53bcf36ca89e90"},{"sha":"34d1b34fedd3b5ccd84874b2248dfba1c17c86a7","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Finish removing the use of libvirt:hypervisor\n\nStoring the hypervisor type in a configuration value doesn't make sense\nsince the libvirt host tells us what it is capable of. Instead use\nthe values from the guest domains provided by the virt.capabilities.\n\nThis is also the occasion to remove the use of the 'esxi' hypervisor in\nas many places as possible since this is a synonym of 'vmware' and\n'vmware' is the value provided by the libvirt esx driver.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/34d1b34fedd3b5ccd84874b2248dfba1c17c86a7"},{"sha":"0ac324acff80aab2b1e917356ec6accf72eea403","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Support more display types in virt.init\n\nvirt.init's enable_vnc is too limiting for the current possibilities of\nthe libvirt stack. Deprecate it in favor of a graphics dictionary to\nallow creating VMs with VNC, Spice, RDP or no graphics. This design\nhelps keeping the structure opened to support new parameters in the\nfuture.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/0ac324acff80aab2b1e917356ec6accf72eea403"},{"sha":"535942ace20817ae0b1e038a6398addcaffadca2","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Allow overriding NICs profile in virt.init\n\nvirt.init just allows the user to pass in a profile name to get the\nlist of network interfaces to create. This is rather good for simple\ncases, but requires the profile to be stored in the minion\nconfiguration.\n\nFrom that commit on, the user can use an interfaces parameter to\ncustomize the NICs from the template or add other ones. This could be\nhandy for the virt.running state for example.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/535942ace20817ae0b1e038a6398addcaffadca2"},{"sha":"7555172e5989de82874dee7dadfcd8ec3e73d147","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Allow overriding disks profile in virt.init\n\nvirt.init just allows the user to pass in a profile name to get the\nlist of disk devices to create. This is rather good for simple\ncases, but requires the profile to be stored in the minion\nconfiguration.\n\nFrom that commit on, the user can use a disks parameter to\ncustomize the disks from the template or add other ones. This could be\nhandy for the virt.running state for example.\n\nThis new parameter makes the image parameter useless: deprecating it.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/7555172e5989de82874dee7dadfcd8ec3e73d147"},{"sha":"b128f019b3813f565f1c1730fa14ed33f871968e","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"virt.init: move enable_qcow to disks parameter\n\nenable_qcow is rather badly named since it doesn't tell the user what\nthat actually does. Thanks to the new disks parameter, this option can\nnow be set on a per-disk basis in the disks structure using a new\noverlay_image property.\n\nenable_qcow is now marked as deprecated","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/b128f019b3813f565f1c1730fa14ed33f871968e"},{"sha":"614a213b3af748ff4e14ace117d3e26925a914d3","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Fix virt images default location in docs\n\nvirt images are not stored in /srv/salt/salt-images, but in\n/srv/salt-images. Fix the documentation to reflect the truth.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/614a213b3af748ff4e14ace117d3e26925a914d3"},{"sha":"5479f8885551d019d36c6dbfb7bac50a8fd49e4f","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"virt: move all disks computations in _disk_profile\n\nDisk profile structure wasn't containing the image filename and path.\nThese were computed in two different places: one in _qemu_create_image()\nand one in _gen_xml.\n\nThis commit moves all disks list computations in _disk_profile to get:\n - default values on both disk profile and user disks definitions\n - one place to compute all values\nThis should reduce error risks in future disk-related changes.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/5479f8885551d019d36c6dbfb7bac50a8fd49e4f"},{"sha":"d6f0c59bc3d010e9dd128ae12fcc63962670aed6","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Don't create subfolders within virt:images\n\nDisk images are currently created at a patch matching this rule:\n\n    <virt:images>/<vmname>/<diskname>\n\nIn the future we want the user to be able to define in which libvirt\npool to create the image, rather than always in the default virt:images\nfolder. As libvirt doesn't allow volume names with a / in them, create\nthe qemu disk images in:\n\n    <virt:images>/<vmname>_<diskname>","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/d6f0c59bc3d010e9dd128ae12fcc63962670aed6"},{"sha":"ac6868a532db205a67efd124bf40209bd5dd5942","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Simplify virt._disk_profile return value\n\nRather than returning a list of {name: dict_of_disk_props}, return\ninclude the name as a property in each disk dictionary and remove one\nlevel. This aligns disks with the structure returned for networks and\nallows usage of list comrehensions to slightly simplify the calling code.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/ac6868a532db205a67efd124bf40209bd5dd5942"},{"sha":"f68d90ef4f0f99e2ff938fe622ec7519ed76ce6e","author":{"name":"Cédric Bosdonnat","email":"5de0be53dc3aabb89d8379dd21cea40e0795c9b1@suse.com"},"message":"Add target path and type to virt.pool_info result\n\nAt times we need to know where the storage pool is pointing to and of\nwhat type it is. virt.pool_info is a nice place for this.","distinct":true,"url":"https://api.github.com/repos/nullify005/salt/commits/f68d90ef4f0f99e2ff938fe622ec7519ed76ce6e"}]}
{"actor":{"display_login":"rallytime"}}