{"action":"created","comment":{"url":"https://api.github.com/repos/openmc-dev/openmc/pulls/comments/239932970","pull_request_review_id":182853078,"id":239932970,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTkzMjk3MA==","diff_hunk":"@@ -191,6 +193,47 @@ Nuclide::Nuclide(hid_t group, const double* temperature, int n)\n   }\n   close_group(rxs_group);\n \n+  // Read unresolved resonance probability tables if present\n+  if (object_exists(group, \"urr\")) {\n+    urr_present_ = true;\n+    urr_data_.resize(temps_to_read.size());","path":"src/nuclide.cpp","position":32,"original_position":32,"commit_id":"999415be6a840200290cff9b5e561670e0c7b1a2","original_commit_id":"999415be6a840200290cff9b5e561670e0c7b1a2","user":{"login":"paulromano","id":743095,"node_id":"MDQ6VXNlcjc0MzA5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/743095?v=4","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"body":"If you use `emplace_back` below, this call should be `urr_data_.reserve(...)` instead of `resize`","created_at":"2018-12-07T20:12:07Z","updated_at":"2018-12-07T20:31:38Z","html_url":"https://github.com/openmc-dev/openmc/pull/1136#discussion_r239932970","pull_request_url":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/comments/239932970"},"html":{"href":"https://github.com/openmc-dev/openmc/pull/1136#discussion_r239932970"},"pull_request":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136"}}},"pull_request":{"url":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136","id":236720117,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzIwMTE3","html_url":"https://github.com/openmc-dev/openmc/pull/1136","diff_url":"https://github.com/openmc-dev/openmc/pull/1136.diff","patch_url":"https://github.com/openmc-dev/openmc/pull/1136.patch","issue_url":"https://api.github.com/repos/openmc-dev/openmc/issues/1136","number":1136,"state":"open","locked":false,"title":"Convert Unresolved Resonance Range code to C++","user":{"login":"nelsonag","id":1037107,"node_id":"MDQ6VXNlcjEwMzcxMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1037107?v=4","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"body":"This PR tackles some now low-hanging fruit in the C++ conversion process: converting the `UrrData` class from Fortran to C++.  \r\n\r\nSince there is no longer any need to pass around `material_xs` in `physics_mg.cpp`, I also removed that passing.","created_at":"2018-12-07T00:42:35Z","updated_at":"2018-12-07T20:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95568130788a7425a18a9bdb9bb0f936733eb008","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136/commits","review_comments_url":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136/comments","review_comment_url":"https://api.github.com/repos/openmc-dev/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmc-dev/openmc/issues/1136/comments","statuses_url":"https://api.github.com/repos/openmc-dev/openmc/statuses/999415be6a840200290cff9b5e561670e0c7b1a2","head":{"label":"nelsonag:urr_cpp","ref":"urr_cpp","sha":"999415be6a840200290cff9b5e561670e0c7b1a2","user":{"login":"nelsonag","id":1037107,"node_id":"MDQ6VXNlcjEwMzcxMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1037107?v=4","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"repo":{"id":18528596,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyODU5Ng==","name":"openmc","full_name":"nelsonag/openmc","private":false,"owner":{"login":"nelsonag","id":1037107,"node_id":"MDQ6VXNlcjEwMzcxMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1037107?v=4","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nelsonag/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/nelsonag/openmc","forks_url":"https://api.github.com/repos/nelsonag/openmc/forks","keys_url":"https://api.github.com/repos/nelsonag/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelsonag/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelsonag/openmc/teams","hooks_url":"https://api.github.com/repos/nelsonag/openmc/hooks","issue_events_url":"https://api.github.com/repos/nelsonag/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/nelsonag/openmc/events","assignees_url":"https://api.github.com/repos/nelsonag/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/nelsonag/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/nelsonag/openmc/tags","blobs_url":"https://api.github.com/repos/nelsonag/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelsonag/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelsonag/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelsonag/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelsonag/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/nelsonag/openmc/languages","stargazers_url":"https://api.github.com/repos/nelsonag/openmc/stargazers","contributors_url":"https://api.github.com/repos/nelsonag/openmc/contributors","subscribers_url":"https://api.github.com/repos/nelsonag/openmc/subscribers","subscription_url":"https://api.github.com/repos/nelsonag/openmc/subscription","commits_url":"https://api.github.com/repos/nelsonag/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelsonag/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelsonag/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelsonag/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelsonag/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/nelsonag/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelsonag/openmc/merges","archive_url":"https://api.github.com/repos/nelsonag/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelsonag/openmc/downloads","issues_url":"https://api.github.com/repos/nelsonag/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/nelsonag/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/nelsonag/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/nelsonag/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelsonag/openmc/labels{/name}","releases_url":"https://api.github.com/repos/nelsonag/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/nelsonag/openmc/deployments","created_at":"2014-04-07T18:40:04Z","updated_at":"2018-10-27T09:49:33Z","pushed_at":"2018-12-07T00:40:16Z","git_url":"git://github.com/nelsonag/openmc.git","ssh_url":"git@github.com:nelsonag/openmc.git","clone_url":"https://github.com/nelsonag/openmc.git","svn_url":"https://github.com/nelsonag/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":46385,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"openmc-dev:develop","ref":"develop","sha":"f7d8d4033db6f3223709ce981e7725593cc558d6","user":{"login":"openmc-dev","id":42039615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDM5NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/42039615?v=4","gravatar_id":"","url":"https://api.github.com/users/openmc-dev","html_url":"https://github.com/openmc-dev","followers_url":"https://api.github.com/users/openmc-dev/followers","following_url":"https://api.github.com/users/openmc-dev/following{/other_user}","gists_url":"https://api.github.com/users/openmc-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/openmc-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmc-dev/subscriptions","organizations_url":"https://api.github.com/users/openmc-dev/orgs","repos_url":"https://api.github.com/users/openmc-dev/repos","events_url":"https://api.github.com/users/openmc-dev/events{/privacy}","received_events_url":"https://api.github.com/users/openmc-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxMTE4","name":"openmc","full_name":"openmc-dev/openmc","private":false,"owner":{"login":"openmc-dev","id":42039615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDM5NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/42039615?v=4","gravatar_id":"","url":"https://api.github.com/users/openmc-dev","html_url":"https://github.com/openmc-dev","followers_url":"https://api.github.com/users/openmc-dev/followers","following_url":"https://api.github.com/users/openmc-dev/following{/other_user}","gists_url":"https://api.github.com/users/openmc-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/openmc-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmc-dev/subscriptions","organizations_url":"https://api.github.com/users/openmc-dev/orgs","repos_url":"https://api.github.com/users/openmc-dev/repos","events_url":"https://api.github.com/users/openmc-dev/events{/privacy}","received_events_url":"https://api.github.com/users/openmc-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openmc-dev/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/openmc-dev/openmc","forks_url":"https://api.github.com/repos/openmc-dev/openmc/forks","keys_url":"https://api.github.com/repos/openmc-dev/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmc-dev/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmc-dev/openmc/teams","hooks_url":"https://api.github.com/repos/openmc-dev/openmc/hooks","issue_events_url":"https://api.github.com/repos/openmc-dev/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/openmc-dev/openmc/events","assignees_url":"https://api.github.com/repos/openmc-dev/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/openmc-dev/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/openmc-dev/openmc/tags","blobs_url":"https://api.github.com/repos/openmc-dev/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmc-dev/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmc-dev/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmc-dev/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmc-dev/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/openmc-dev/openmc/languages","stargazers_url":"https://api.github.com/repos/openmc-dev/openmc/stargazers","contributors_url":"https://api.github.com/repos/openmc-dev/openmc/contributors","subscribers_url":"https://api.github.com/repos/openmc-dev/openmc/subscribers","subscription_url":"https://api.github.com/repos/openmc-dev/openmc/subscription","commits_url":"https://api.github.com/repos/openmc-dev/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmc-dev/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmc-dev/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmc-dev/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmc-dev/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/openmc-dev/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmc-dev/openmc/merges","archive_url":"https://api.github.com/repos/openmc-dev/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmc-dev/openmc/downloads","issues_url":"https://api.github.com/repos/openmc-dev/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/openmc-dev/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/openmc-dev/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/openmc-dev/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmc-dev/openmc/labels{/name}","releases_url":"https://api.github.com/repos/openmc-dev/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/openmc-dev/openmc/deployments","created_at":"2011-07-21T00:33:27Z","updated_at":"2018-12-06T14:34:58Z","pushed_at":"2018-12-07T00:42:36Z","git_url":"git://github.com/openmc-dev/openmc.git","ssh_url":"git@github.com:openmc-dev/openmc.git","clone_url":"https://github.com/openmc-dev/openmc.git","svn_url":"https://github.com/openmc-dev/openmc","homepage":"http://openmc.readthedocs.io/","size":46488,"stargazers_count":173,"watchers_count":173,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":163,"open_issues":76,"watchers":173,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136"},"html":{"href":"https://github.com/openmc-dev/openmc/pull/1136"},"issue":{"href":"https://api.github.com/repos/openmc-dev/openmc/issues/1136"},"comments":{"href":"https://api.github.com/repos/openmc-dev/openmc/issues/1136/comments"},"review_comments":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136/comments"},"review_comment":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmc-dev/openmc/pulls/1136/commits"},"statuses":{"href":"https://api.github.com/repos/openmc-dev/openmc/statuses/999415be6a840200290cff9b5e561670e0c7b1a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paulromano"}}