{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/events","html_url":"https://github.com/StrikeNP/trac_test/issues/786","id":332200569,"node_id":"MDU6SXNzdWUzMzIyMDA1Njk=","number":786,"title":"Tuner broken for RICO (and probably other cases that use microphysics) (Trac #786)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":963997231,"node_id":"MDU6TGFiZWw5NjM5OTcyMzE=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":963997516,"node_id":"MDU6TGFiZWw5NjM5OTc1MTY=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":963997249,"node_id":"MDU6TGFiZWw5NjM5OTcyNDk=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/defect","name":"defect","color":"FFFFFF","default":false},{"id":964076735,"node_id":"MDU6TGFiZWw5NjQwNzY3MzU=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/raut@uwm.edu","name":"raut@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/13","html_url":"https://github.com/StrikeNP/trac_test/milestone/13","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/13/labels","id":3423344,"node_id":"MDk6TWlsZXN0b25lMzQyMzM0NA==","number":13,"title":"4. Fix bugs","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":36,"state":"open","created_at":"2018-06-13T21:36:50Z","updated_at":"2018-06-16T14:10:32Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2018-06-13T23:28:28Z","updated_at":"2018-06-16T14:15:20Z","closed_at":null,"author_association":"OWNER","body":"The tuner is broken for the RICO case.  This is not reflected on the nightly tests because the nightly run is for FIRE, which does not use microphysics.  However, the RICO tuner fails with the following error message:\n\n\n```text\nAt line 757 of file ../src/microphys_init_cleanup.F90\nFortran runtime error: Attempting to allocate already allocated array 'l_hydromet_sed'\n```\n\nI assume that ```l_hydromet_sed``` is not being deallocated, so that during the next tuning set, the attempt to allocate an already allocated variable causes the problem.\n\nHowever, there is code in place that deallocates ```l_hydromet_sed```.  It looks to me like this is normally called.\n\nI put a print statement in the code to see if that piece of code that deallocates ```l_hydromet_sed``` is called.  It normally is, however, at one point during the tuning, a parameter set failed and apparently that code was not called as a result.\n\nThe tuner was working for me recently.  It was only after I svn updated that the problems started.  I don't know if a recent change affected this, or if this is a long standing issue, because I don't think I had a parameter set fail when I was tuning before.  It could be a long standing issue because the nightly tests run a case that doesn't use microphysics, and this is a microphysics-related issue.\n\nAttachments:\n\n[RICO_tuner_diff.diff](https://github.com/larson-group/trac_attachment_archive/blob/master/clubb/RICO_tuner_diff.diff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/786\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2016-04-26T18:27:25\", \n    \"description\": \"The tuner is broken for the RICO case.  This is not reflected on the nightly tests because the nightly run is for FIRE, which does not use microphysics.  However, the RICO tuner fails with the following error message:\\n\\n{{{\\nAt line 757 of file ../src/microphys_init_cleanup.F90\\nFortran runtime error: Attempting to allocate already allocated array 'l_hydromet_sed'\\n}}}\\n\\nI assume that {{{l_hydromet_sed}}} is not being deallocated, so that during the next tuning set, the attempt to allocate an already allocated variable causes the problem.\\n\\nHowever, there is code in place that deallocates {{{l_hydromet_sed}}}.  It looks to me like this is normally called.\\n\\nI put a print statement in the code to see if that piece of code that deallocates {{{l_hydromet_sed}}} is called.  It normally is, however, at one point during the tuning, a parameter set failed and apparently that code was not called as a result.\\n\\nThe tuner was working for me recently.  It was only after I svn updated that the problems started.  I don't know if a recent change affected this, or if this is a long standing issue, because I don't think I had a parameter set fail when I was tuning before.  It could be a long standing issue because the nightly tests run a case that doesn't use microphysics, and this is a microphysics-related issue.\", \n    \"reporter\": \"bmg2@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, raut@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1461695245674668\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Tuner broken for RICO (and probably other cases that use microphysics)\", \n    \"priority\": \"minor\", \n    \"keywords\": \"tuner RICO\", \n    \"time\": \"2016-03-21T18:43:05\", \n    \"milestone\": \"4. Fix bugs\", \n    \"owner\": \"raut@uwm.edu\", \n    \"type\": \"defect\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/397815011","html_url":"https://github.com/StrikeNP/trac_test/issues/786#issuecomment-397815011","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786","id":397815011,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzgxNTAxMQ==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T14:15:20Z","updated_at":"2018-06-16T14:15:20Z","author_association":"OWNER","body":"**Trac update on 2016/04/20 at 23:22**\n**bmg2@uwm.edu commented:**\n\nReplying to [comment:29 raut@…]:\n> Replying to [comment:28 raut@…]:\n> > Replying to [comment:27 bmg2@…]:\n>\n> > > Replying to [comment:26 raut@…]:\n>\n>>\n> > > > \n>\n>>\n>>>\n> > > > Can we use KK upscaled? That would at least provide more code coverage (setup_clubb_pdf_params, corr_varnce_module, etc.)\n>\n>>\n> > > \n>\n> > > That would work.  KK upscaled won't cause any problems with the tuner.  Of course, Morrison has more hydrometeor species, but since hydrometeor arrays are allocated by ```hydromet_dim```, that shouldn't matter.\n>\n>>\n> > \n>\n> > I ran the tuner using KK upscaled. I got a lot of messages like these:\n> > \n>\n\n```text\n> >  Vertical integral of xm is zero;mfl will remove spike at top of domain,but it will not conserve xm.\n>\n> >  xm_adj_coef in mfl less than -0.99, mx_adj_coef set to -0.99\n> >  xm_adj_coef in mfl less than -0.99, mx_adj_coef set to -0.99\n>\n> >  xm_adj_coef in mfl less than -0.99, mx_adj_coef set to -0.99\n> >  Warning: the parameter set has caused CLUBB to crash\n>\n> > ```\n> > \n>\n> > However, the tuner finished, and gave an accuracy increase of 22.099596261978149%. I guess this is an improvement.\n> \n> But... if I run with just Morrison local microphysics, I get no CLUBB crashes, and a 70.374470949172974% increase in accuracy. That's a bigger improvement...\n\n\nIf I understand the tuner correctly, it stops looking for improvement after it beats ftol with whatever parameter set and improvement it had at the time.  What I'm trying to say is that the results don't mean anything.  We want to test as much code as possible.  Actually, blow-ups are good because that forces a code deallocation and return.  It will be easier to catch bugs when blow-ups occur.\n\nDo whatever you think will catch the most problems.\n\n\n"}}
{"actor":{"display_login":"StrikeNP"}}