{"action":"created","comment":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/167454728","pull_request_review_id":95674272,"id":167454728,"diff_hunk":"@@ -55,8 +55,8 @@ public void Same_dummy_type_can_be_created_concurrently_on_different_threads()\n             // the other is still being created.\r\n             // Guards against the concurrent creations being detected as a\r\n             // circular dependency and throwing an exception.\r\n-            var makeOne = Task.Factory.StartNew(A.Dummy<ConcurrentCreationDummy>);\r\n-            var makeTwo = Task.Factory.StartNew(() =>\r\n+            var makeOne = Task.Run(() => A.Dummy<ConcurrentCreationDummy>());\r\n+            var makeTwo = Task.Run(() =>\r","path":"tests/FakeItEasy.IntegrationTests/DummyTests.cs","position":7,"original_position":7,"commit_id":"6a9f8fc6161ebfc56b04e8020e423ae586d28df1","original_commit_id":"6a9f8fc6161ebfc56b04e8020e423ae586d28df1","user":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars3.githubusercontent.com/u/1864281?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"body":"I don't remember the warning number, but basically, when using `Task.Factory.StartNew`, a `TaskScheduler` should be specified. In most cases, it's better to use `Task.Run`, unless you want some very specific behavior.","created_at":"2018-02-11T23:24:44Z","updated_at":"2018-02-11T23:31:54Z","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1312#discussion_r167454728","pull_request_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/167454728"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/1312#discussion_r167454728"},"pull_request":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312"}}},"pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312","id":168480461,"html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1312","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1312.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1312.patch","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1312","number":1312,"state":"open","locked":false,"title":"Enable code analysis","user":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars3.githubusercontent.com/u/1864281?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"body":"Fixes #1144\r\n\r\nThe `Microsoft.CodeAnalysis.FxCopAnalyzers` package now seems sufficiently stable.\r\n\r\nThere are many warnings that weren't previously reported by FxCop, so I had to fix or suppress many of them. I tried to make commits easy to follow, hopefully it won't be to painful to review...","created_at":"2018-02-11T23:12:30Z","updated_at":"2018-02-11T23:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f82e424b700812f04cd24dd546cd13a721226a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312/commits","review_comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312/comments","review_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1312/comments","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/6a9f8fc6161ebfc56b04e8020e423ae586d28df1","head":{"label":"thomaslevesque:enable-code-analysis","ref":"enable-code-analysis","sha":"6a9f8fc6161ebfc56b04e8020e423ae586d28df1","user":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars3.githubusercontent.com/u/1864281?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"repo":{"id":31570944,"name":"FakeItEasy","full_name":"thomaslevesque/FakeItEasy","owner":{"login":"thomaslevesque","id":1864281,"avatar_url":"https://avatars3.githubusercontent.com/u/1864281?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaslevesque/FakeItEasy","description":"The easy mocking library for .NET","fork":true,"url":"https://api.github.com/repos/thomaslevesque/FakeItEasy","forks_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/forks","keys_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/events","assignees_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/merges","archive_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/thomaslevesque/FakeItEasy/deployments","created_at":"2015-03-03T00:22:47Z","updated_at":"2016-01-13T20:13:45Z","pushed_at":"2018-02-11T23:08:19Z","git_url":"git://github.com/thomaslevesque/FakeItEasy.git","ssh_url":"git@github.com:thomaslevesque/FakeItEasy.git","clone_url":"https://github.com/thomaslevesque/FakeItEasy.git","svn_url":"https://github.com/thomaslevesque/FakeItEasy","homepage":"fakeiteasy.github.io","size":21825,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FakeItEasy:develop","ref":"develop","sha":"e96223d576856ed316225627a96008412d033015","user":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars2.githubusercontent.com/u/1713521?v=4","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"repo":{"id":1920133,"name":"FakeItEasy","full_name":"FakeItEasy/FakeItEasy","owner":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars2.githubusercontent.com/u/1713521?v=4","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FakeItEasy/FakeItEasy","description":"The easy mocking library for .NET","fork":false,"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","forks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/forks","keys_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/events","assignees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/merges","archive_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/deployments","created_at":"2011-06-19T17:56:01Z","updated_at":"2018-02-09T18:42:22Z","pushed_at":"2018-02-11T23:12:31Z","git_url":"git://github.com/FakeItEasy/FakeItEasy.git","ssh_url":"git@github.com:FakeItEasy/FakeItEasy.git","clone_url":"https://github.com/FakeItEasy/FakeItEasy.git","svn_url":"https://github.com/FakeItEasy/FakeItEasy","homepage":"fakeiteasy.github.io","size":21858,"stargazers_count":731,"watchers_count":731,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":127,"open_issues":17,"watchers":731,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/1312"},"issue":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1312"},"comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1312/comments"},"review_comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312/comments"},"review_comment":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1312/commits"},"statuses":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/6a9f8fc6161ebfc56b04e8020e423ae586d28df1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"thomaslevesque"}}