{"action":"created","issue":{"url":"https://api.github.com/repos/civilcode/magasin/issues/4","repository_url":"https://api.github.com/repos/civilcode/magasin","labels_url":"https://api.github.com/repos/civilcode/magasin/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/civilcode/magasin/issues/4/comments","events_url":"https://api.github.com/repos/civilcode/magasin/issues/4/events","html_url":"https://github.com/civilcode/magasin/pull/4","id":327103807,"number":4,"title":"Deploy to Heroku using Docker and Distillery","user":{"login":"nicholasjhenry","id":40253,"avatar_url":"https://avatars0.githubusercontent.com/u/40253?v=4","gravatar_id":"","url":"https://api.github.com/users/nicholasjhenry","html_url":"https://github.com/nicholasjhenry","followers_url":"https://api.github.com/users/nicholasjhenry/followers","following_url":"https://api.github.com/users/nicholasjhenry/following{/other_user}","gists_url":"https://api.github.com/users/nicholasjhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholasjhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholasjhenry/subscriptions","organizations_url":"https://api.github.com/users/nicholasjhenry/orgs","repos_url":"https://api.github.com/users/nicholasjhenry/repos","events_url":"https://api.github.com/users/nicholasjhenry/events{/privacy}","received_events_url":"https://api.github.com/users/nicholasjhenry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bokay","id":1242365,"avatar_url":"https://avatars3.githubusercontent.com/u/1242365?v=4","gravatar_id":"","url":"https://api.github.com/users/bokay","html_url":"https://github.com/bokay","followers_url":"https://api.github.com/users/bokay/followers","following_url":"https://api.github.com/users/bokay/following{/other_user}","gists_url":"https://api.github.com/users/bokay/gists{/gist_id}","starred_url":"https://api.github.com/users/bokay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokay/subscriptions","organizations_url":"https://api.github.com/users/bokay/orgs","repos_url":"https://api.github.com/users/bokay/repos","events_url":"https://api.github.com/users/bokay/events{/privacy}","received_events_url":"https://api.github.com/users/bokay/received_events","type":"User","site_admin":false},"assignees":[{"login":"bokay","id":1242365,"avatar_url":"https://avatars3.githubusercontent.com/u/1242365?v=4","gravatar_id":"","url":"https://api.github.com/users/bokay","html_url":"https://github.com/bokay","followers_url":"https://api.github.com/users/bokay/followers","following_url":"https://api.github.com/users/bokay/following{/other_user}","gists_url":"https://api.github.com/users/bokay/gists{/gist_id}","starred_url":"https://api.github.com/users/bokay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokay/subscriptions","organizations_url":"https://api.github.com/users/bokay/orgs","repos_url":"https://api.github.com/users/bokay/repos","events_url":"https://api.github.com/users/bokay/events{/privacy}","received_events_url":"https://api.github.com/users/bokay/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-28T19:35:38Z","updated_at":"2018-05-30T13:36:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/civilcode/magasin/pulls/4","html_url":"https://github.com/civilcode/magasin/pull/4","diff_url":"https://github.com/civilcode/magasin/pull/4.diff","patch_url":"https://github.com/civilcode/magasin/pull/4.patch"},"body":"We would like to have a working example of an application deployed on [Heroku](https://www.heroku.com) using [Docker](https://www.docker.com) and [Distillery](https://github.com/bitwalker/distillery). The application will require a Phoenix application with [Webpack](https://webpack.js.org) integration. \r\n\r\nBeyond using Docker for deployment, we would like to use the same Heroku/Docker setup locally. [+]\r\n\r\nThere are possibly multiple PR's here:\r\n\r\n1. Phoenix application with Webpack\r\n2. Configuration to generate a Release\r\n3. Docker Deployment + Local Deployment\r\n\r\n## References\r\n\r\n- https://cultivatehq.com/posts/elixir-distillery-umbrella-docker/\r\n- https://devcenter.heroku.com/articles/local-development-with-docker-compose [+]"},"comment":{"url":"https://api.github.com/repos/civilcode/magasin/issues/comments/393164142","html_url":"https://github.com/civilcode/magasin/pull/4#issuecomment-393164142","issue_url":"https://api.github.com/repos/civilcode/magasin/issues/4","id":393164142,"user":{"login":"frahugo","id":14030,"avatar_url":"https://avatars1.githubusercontent.com/u/14030?v=4","gravatar_id":"","url":"https://api.github.com/users/frahugo","html_url":"https://github.com/frahugo","followers_url":"https://api.github.com/users/frahugo/followers","following_url":"https://api.github.com/users/frahugo/following{/other_user}","gists_url":"https://api.github.com/users/frahugo/gists{/gist_id}","starred_url":"https://api.github.com/users/frahugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frahugo/subscriptions","organizations_url":"https://api.github.com/users/frahugo/orgs","repos_url":"https://api.github.com/users/frahugo/repos","events_url":"https://api.github.com/users/frahugo/events{/privacy}","received_events_url":"https://api.github.com/users/frahugo/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T13:36:02Z","updated_at":"2018-05-30T13:36:02Z","author_association":"NONE","body":"@bokay this is awesome!  Great job.  I tried it locally.  A few things I found:\r\n\r\n- [ ] I followed the instructions in the readme.  When I run the app in Docker, it do not have CSS files available to the browser.  Maybe we need to cache an additional assets-related folder?\r\n- [ ] This is more of a question for all of us: should we also support a local dev environment as well?  If so, the database config would then be different.  What would happen to the _build folder?  could we have compilation problems between docker architecture and MacOSX?\r\n- [ ] If I do a `docker-compose up`, I cannot use the IEx console.  But I can if I run `docker-compose run application iex -S mix`.  Maybe the `up` command should simply start the Phoenix server instead of the console?\r\n- [ ] `apps/magasin_web/assets/package-lock.json` is missing from the git repo\r\n\r\n"}}
{"actor":{"display_login":"frahugo"}}