{"action":"closed","number":669,"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669","id":179445263,"html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/669","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/669.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/669.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/669","number":669,"state":"closed","locked":false,"title":"Ticket2882: Get genie_python talking to PVs","user":{"login":"jeremyspencer39171","id":21057792,"avatar_url":"https://avatars3.githubusercontent.com/u/21057792?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyspencer39171","html_url":"https://github.com/jeremyspencer39171","followers_url":"https://api.github.com/users/jeremyspencer39171/followers","following_url":"https://api.github.com/users/jeremyspencer39171/following{/other_user}","gists_url":"https://api.github.com/users/jeremyspencer39171/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyspencer39171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyspencer39171/subscriptions","organizations_url":"https://api.github.com/users/jeremyspencer39171/orgs","repos_url":"https://api.github.com/users/jeremyspencer39171/repos","events_url":"https://api.github.com/users/jeremyspencer39171/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyspencer39171/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nHardcoded EPICS_CA_ADDR_LIST, EPICS_CA_AUTO_ADDR_LIST and EPICS_CA_MAX_ARRAY_BYTES.\r\nTom, Dom, and I spent all afternoon trying to get these values from IPreferencesService, In the end we fell back to hardcoding them. If you know how to do this properly, please let us know.\r\n\r\n### Ticket\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/2882\r\n\r\n### Acceptance criteria\r\n\r\nIn IBEX E4 GUI Scripting perspective, try to talk to some PVs. e.g. g.get_pv(\"IN:LARMOR:DAE:RUNSTATE\")\r\n\r\n### Unit tests\r\n\r\nVariables are hardcoded, so unit tests won't help here.\r\n\r\n### System tests\r\n\r\nWe already have system tests which attempt to talk to PVs.\r\n\r\n### Documentation\r\nCreated this page in the wiki to document change:\r\nhttps://github.com/ISISComputingGroup/ibex_developers_manual/wiki/E4-GUI:-Channel-Access-Settings\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Do the changes function as described and is it robust?\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev)?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n\r\n","created_at":"2018-04-04T16:27:29Z","updated_at":"2018-05-09T07:59:35Z","closed_at":"2018-05-09T07:59:35Z","merged_at":null,"merge_commit_sha":"15f3139a2fa2d74a26a6db5d2115dcb7b1aaadd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/669/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/ffab37e353a6e1c758a910e557a988c96b8fa446","head":{"label":"ISISComputingGroup:Ticket2882_get_genie_python_talking_to_pvs","ref":"Ticket2882_get_genie_python_talking_to_pvs","sha":"ffab37e353a6e1c758a910e557a988c96b8fa446","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-05-04T09:48:25Z","pushed_at":"2018-05-08T13:24:24Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29542,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master_E4","ref":"master_E4","sha":"346dee438558b0c1d83b02f64735924bb0427c3a","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-05-04T09:48:25Z","pushed_at":"2018-05-08T13:24:24Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29542,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/669"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/669"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/ffab37e353a6e1c758a910e557a988c96b8fa446"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":104,"changed_files":2}}
{"actor":{"display_login":"Tom-Willemsen"}}