{"action":"created","comment":{"url":"https://api.github.com/repos/open-wc/open-wc/pulls/comments/234451866","pull_request_review_id":176096361,"id":234451866,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ1MTg2Ng==","diff_hunk":"@@ -14,6 +14,7 @@\n     \"test:bs\": \"karma start karma-bs.config.js\"\n   },\n   \"dependencies\": {\n+    \"@bundled-es-modules/chai\": \"^4.2.0-rc.1\",\n     \"@open-wc/chai-dom-equals\": \"^0.3.2\",\n     \"@open-wc/testing-helpers\": \"^0.2.1\",\n     \"chai\": \"^4.0.0\",","path":"packages/testing/package.json","position":null,"original_position":7,"commit_id":"c2f291e3b9c2d23bd7b945b6ede7ea98a3fb820f","original_commit_id":"73b9a5dfe2ff5b222c62adbcdd1d630c0d337653","user":{"login":"daKmoR","id":24378,"node_id":"MDQ6VXNlcjI0Mzc4","avatar_url":"https://avatars2.githubusercontent.com/u/24378?v=4","gravatar_id":"","url":"https://api.github.com/users/daKmoR","html_url":"https://github.com/daKmoR","followers_url":"https://api.github.com/users/daKmoR/followers","following_url":"https://api.github.com/users/daKmoR/following{/other_user}","gists_url":"https://api.github.com/users/daKmoR/gists{/gist_id}","starred_url":"https://api.github.com/users/daKmoR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daKmoR/subscriptions","organizations_url":"https://api.github.com/users/daKmoR/orgs","repos_url":"https://api.github.com/users/daKmoR/repos","events_url":"https://api.github.com/users/daKmoR/events{/privacy}","received_events_url":"https://api.github.com/users/daKmoR/received_events","type":"User","site_admin":false},"body":"we could do it in separate MR but I would rather not have 2 separate releases for that - so then we would need a dev branch* and merge both there and then merge to master to release.\r\nremoval of sinon in package.json and in some index.html files and some wallaby and karma configs... is I think not worth it... (so let's do it in a separate commit but in the same branch) I could do that 👍 \r\n\r\n* we will definitely need that at some point, but I would like to avoid it as long as possible :p","created_at":"2018-11-18T16:30:18Z","updated_at":"2018-11-18T16:30:18Z","html_url":"https://github.com/open-wc/open-wc/pull/54#discussion_r234451866","pull_request_url":"https://api.github.com/repos/open-wc/open-wc/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/comments/234451866"},"html":{"href":"https://github.com/open-wc/open-wc/pull/54#discussion_r234451866"},"pull_request":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/54"}},"in_reply_to_id":234446077},"pull_request":{"url":"https://api.github.com/repos/open-wc/open-wc/pulls/54","id":231789166,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzg5MTY2","html_url":"https://github.com/open-wc/open-wc/pull/54","diff_url":"https://github.com/open-wc/open-wc/pull/54.diff","patch_url":"https://github.com/open-wc/open-wc/pull/54.patch","issue_url":"https://api.github.com/repos/open-wc/open-wc/issues/54","number":54,"state":"open","locked":false,"title":"feat(testing): auto-register side-effects","user":{"login":"LarsDenBakker","id":11994993,"node_id":"MDQ6VXNlcjExOTk0OTkz","avatar_url":"https://avatars3.githubusercontent.com/u/11994993?v=4","gravatar_id":"","url":"https://api.github.com/users/LarsDenBakker","html_url":"https://github.com/LarsDenBakker","followers_url":"https://api.github.com/users/LarsDenBakker/followers","following_url":"https://api.github.com/users/LarsDenBakker/following{/other_user}","gists_url":"https://api.github.com/users/LarsDenBakker/gists{/gist_id}","starred_url":"https://api.github.com/users/LarsDenBakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarsDenBakker/subscriptions","organizations_url":"https://api.github.com/users/LarsDenBakker/orgs","repos_url":"https://api.github.com/users/LarsDenBakker/repos","events_url":"https://api.github.com/users/LarsDenBakker/events{/privacy}","received_events_url":"https://api.github.com/users/LarsDenBakker/received_events","type":"User","site_admin":false},"body":"Turns out we aren't using the testing package in any of the other packages, so it's just one change.\r\n\r\nEDIT: Did have to update docs and generator :)","created_at":"2018-11-18T13:43:44Z","updated_at":"2018-11-18T16:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32088a3a38d517493ae371aa9dcc45c7a0275302","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-wc/open-wc/pulls/54/commits","review_comments_url":"https://api.github.com/repos/open-wc/open-wc/pulls/54/comments","review_comment_url":"https://api.github.com/repos/open-wc/open-wc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-wc/open-wc/issues/54/comments","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/c2f291e3b9c2d23bd7b945b6ede7ea98a3fb820f","head":{"label":"open-wc:feat/refactor-side-effects","ref":"feat/refactor-side-effects","sha":"c2f291e3b9c2d23bd7b945b6ede7ea98a3fb820f","user":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"repo":{"id":149014578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwMTQ1Nzg=","name":"open-wc","full_name":"open-wc/open-wc","private":false,"owner":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-wc/open-wc","description":null,"fork":false,"url":"https://api.github.com/repos/open-wc/open-wc","forks_url":"https://api.github.com/repos/open-wc/open-wc/forks","keys_url":"https://api.github.com/repos/open-wc/open-wc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-wc/open-wc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-wc/open-wc/teams","hooks_url":"https://api.github.com/repos/open-wc/open-wc/hooks","issue_events_url":"https://api.github.com/repos/open-wc/open-wc/issues/events{/number}","events_url":"https://api.github.com/repos/open-wc/open-wc/events","assignees_url":"https://api.github.com/repos/open-wc/open-wc/assignees{/user}","branches_url":"https://api.github.com/repos/open-wc/open-wc/branches{/branch}","tags_url":"https://api.github.com/repos/open-wc/open-wc/tags","blobs_url":"https://api.github.com/repos/open-wc/open-wc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-wc/open-wc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-wc/open-wc/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-wc/open-wc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/{sha}","languages_url":"https://api.github.com/repos/open-wc/open-wc/languages","stargazers_url":"https://api.github.com/repos/open-wc/open-wc/stargazers","contributors_url":"https://api.github.com/repos/open-wc/open-wc/contributors","subscribers_url":"https://api.github.com/repos/open-wc/open-wc/subscribers","subscription_url":"https://api.github.com/repos/open-wc/open-wc/subscription","commits_url":"https://api.github.com/repos/open-wc/open-wc/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-wc/open-wc/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-wc/open-wc/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-wc/open-wc/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-wc/open-wc/contents/{+path}","compare_url":"https://api.github.com/repos/open-wc/open-wc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-wc/open-wc/merges","archive_url":"https://api.github.com/repos/open-wc/open-wc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-wc/open-wc/downloads","issues_url":"https://api.github.com/repos/open-wc/open-wc/issues{/number}","pulls_url":"https://api.github.com/repos/open-wc/open-wc/pulls{/number}","milestones_url":"https://api.github.com/repos/open-wc/open-wc/milestones{/number}","notifications_url":"https://api.github.com/repos/open-wc/open-wc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-wc/open-wc/labels{/name}","releases_url":"https://api.github.com/repos/open-wc/open-wc/releases{/id}","deployments_url":"https://api.github.com/repos/open-wc/open-wc/deployments","created_at":"2018-09-16T16:35:09Z","updated_at":"2018-11-18T11:03:50Z","pushed_at":"2018-11-18T14:31:54Z","git_url":"git://github.com/open-wc/open-wc.git","ssh_url":"git@github.com:open-wc/open-wc.git","clone_url":"https://github.com/open-wc/open-wc.git","svn_url":"https://github.com/open-wc/open-wc","homepage":null,"size":392,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"open-wc:master","ref":"master","sha":"956fd8736776f4932b9eaf77802a9f56d6e2aa3f","user":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"repo":{"id":149014578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwMTQ1Nzg=","name":"open-wc","full_name":"open-wc/open-wc","private":false,"owner":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-wc/open-wc","description":null,"fork":false,"url":"https://api.github.com/repos/open-wc/open-wc","forks_url":"https://api.github.com/repos/open-wc/open-wc/forks","keys_url":"https://api.github.com/repos/open-wc/open-wc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-wc/open-wc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-wc/open-wc/teams","hooks_url":"https://api.github.com/repos/open-wc/open-wc/hooks","issue_events_url":"https://api.github.com/repos/open-wc/open-wc/issues/events{/number}","events_url":"https://api.github.com/repos/open-wc/open-wc/events","assignees_url":"https://api.github.com/repos/open-wc/open-wc/assignees{/user}","branches_url":"https://api.github.com/repos/open-wc/open-wc/branches{/branch}","tags_url":"https://api.github.com/repos/open-wc/open-wc/tags","blobs_url":"https://api.github.com/repos/open-wc/open-wc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-wc/open-wc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-wc/open-wc/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-wc/open-wc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/{sha}","languages_url":"https://api.github.com/repos/open-wc/open-wc/languages","stargazers_url":"https://api.github.com/repos/open-wc/open-wc/stargazers","contributors_url":"https://api.github.com/repos/open-wc/open-wc/contributors","subscribers_url":"https://api.github.com/repos/open-wc/open-wc/subscribers","subscription_url":"https://api.github.com/repos/open-wc/open-wc/subscription","commits_url":"https://api.github.com/repos/open-wc/open-wc/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-wc/open-wc/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-wc/open-wc/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-wc/open-wc/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-wc/open-wc/contents/{+path}","compare_url":"https://api.github.com/repos/open-wc/open-wc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-wc/open-wc/merges","archive_url":"https://api.github.com/repos/open-wc/open-wc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-wc/open-wc/downloads","issues_url":"https://api.github.com/repos/open-wc/open-wc/issues{/number}","pulls_url":"https://api.github.com/repos/open-wc/open-wc/pulls{/number}","milestones_url":"https://api.github.com/repos/open-wc/open-wc/milestones{/number}","notifications_url":"https://api.github.com/repos/open-wc/open-wc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-wc/open-wc/labels{/name}","releases_url":"https://api.github.com/repos/open-wc/open-wc/releases{/id}","deployments_url":"https://api.github.com/repos/open-wc/open-wc/deployments","created_at":"2018-09-16T16:35:09Z","updated_at":"2018-11-18T11:03:50Z","pushed_at":"2018-11-18T14:31:54Z","git_url":"git://github.com/open-wc/open-wc.git","ssh_url":"git@github.com:open-wc/open-wc.git","clone_url":"https://github.com/open-wc/open-wc.git","svn_url":"https://github.com/open-wc/open-wc","homepage":null,"size":392,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/54"},"html":{"href":"https://github.com/open-wc/open-wc/pull/54"},"issue":{"href":"https://api.github.com/repos/open-wc/open-wc/issues/54"},"comments":{"href":"https://api.github.com/repos/open-wc/open-wc/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/open-wc/open-wc/statuses/c2f291e3b9c2d23bd7b945b6ede7ea98a3fb820f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"daKmoR"}}