{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/166479731","pull_request_review_id":94547898,"id":166479731,"diff_hunk":"@@ -0,0 +1,79 @@\n+go-git-http\n+===========\n+\n+[![Build Status](https://travis-ci.org/AaronO/go-git-http.svg)](https://travis-ci.org/AaronO/go-git-http)\n+\n+A Smart Git Http server library in Go (golang)","path":"third_party/go-git-http/README.md","position":6,"original_position":6,"commit_id":"db7861e21beb58b9191e1f6fabdaf0b126b5ac76","original_commit_id":"db7861e21beb58b9191e1f6fabdaf0b126b5ac76","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"Why third_party rather than vendor?","created_at":"2018-02-06T23:47:51Z","updated_at":"2018-02-06T23:48:25Z","html_url":"https://github.com/kubernetes/kubernetes/pull/57795#discussion_r166479731","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/166479731"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/57795#discussion_r166479731"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795","id":160917333,"html_url":"https://github.com/kubernetes/kubernetes/pull/57795","diff_url":"https://github.com/kubernetes/kubernetes/pull/57795.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/57795.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57795","number":57795,"state":"open","locked":false,"title":"EXPERIMENTAL: golang/dep support","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"This is a prototype to use dep's alternative repo source feature to point to a locally proxied git server that serves the staging subdirs as independent repos 😱 \r\n\r\nIt needs dep ~~with https://github.com/golang/dep/pull/1509~~ in the `PATH`.\r\n\r\nIn code the proxy called staginghub works like this from the k/k repo worktree:\r\n\r\n```shell\r\n$ cd $GOPATH/src/k8s.io/kubernetes\r\n$ go run cmd/staginghub/main.go -l localhost -p 12345\r\n$ git clone http://localhost:12345/staging/src/k8s.io/api\r\n```\r\n\r\nA url like http://localhost:12345/staging/src/k8s.io/api can be put into Gopkg.toml as alternative source of k8s.io/api.\r\n\r\nA bit `hack/dep.sh`bash duct tape does this:\r\n\r\n- prepare Gopkg.toml/Glide.yaml before a vendoring run to include these alternative sources,\r\n- start the staginghub\r\n- do the vendoring\r\n- cleanup the artifacts and re-add the staging/ symlinks.\r\n\r\nWith that you can do:\r\n\r\n```\r\n$ cd $GOPATH/src/k8s.io/kubernetes\r\n$ hack/dep.sh ensure -v\r\n49,12s user 62,31s system 57% cpu 3:14,44s total\r\n```\r\n\r\nTODO:\r\n- [x] get dep to accept any URLs, not only import paths as alternative sources https://github.com/golang/dep/issues/411 :cry: https://github.com/golang/dep/pull/1509\r\n- [x] implement `hack/dep.sh`\r\n- [x] ~~cleanup `Gopkg.lock` from the fake staging dir repos (this included updating some checksum in the file)~~ not needed. `hack/dep.sh ensure` is idem-potent.\r\n- [ ] wait for LICENSE file in git server library https://github.com/euforia/go-git-server/pull/2\r\n- [ ] for initial Gopkg.toml creation via `dep init` add fixed revisions for all packages to Gopkg.toml. We do not want to rely on the lock file only\r\n- [ ] add converter from Gopkg.lock to Godeps.json for downstream usage\r\n  \r\n  \r\n  ","created_at":"2018-01-03T14:04:36Z","updated_at":"2018-02-06T23:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"cblecker","id":1431969,"avatar_url":"https://avatars1.githubusercontent.com/u/1431969?v=4","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},"assignees":[{"login":"cblecker","id":1431969,"avatar_url":"https://avatars1.githubusercontent.com/u/1431969?v=4","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57795/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/db7861e21beb58b9191e1f6fabdaf0b126b5ac76","head":{"label":"sttts:sttts-dep","ref":"sttts-dep","sha":"db7861e21beb58b9191e1f6fabdaf0b126b5ac76","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":36099048,"name":"kubernetes","full_name":"sttts/kubernetes","owner":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttts/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sttts/kubernetes","forks_url":"https://api.github.com/repos/sttts/kubernetes/forks","keys_url":"https://api.github.com/repos/sttts/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/kubernetes/teams","hooks_url":"https://api.github.com/repos/sttts/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sttts/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/kubernetes/events","assignees_url":"https://api.github.com/repos/sttts/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/kubernetes/tags","blobs_url":"https://api.github.com/repos/sttts/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sttts/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sttts/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sttts/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sttts/kubernetes/subscription","commits_url":"https://api.github.com/repos/sttts/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/kubernetes/merges","archive_url":"https://api.github.com/repos/sttts/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/kubernetes/downloads","issues_url":"https://api.github.com/repos/sttts/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sttts/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/kubernetes/deployments","created_at":"2015-05-22T23:09:55Z","updated_at":"2017-12-21T16:10:17Z","pushed_at":"2018-02-06T13:21:42Z","git_url":"git://github.com/sttts/kubernetes.git","ssh_url":"git@github.com:sttts/kubernetes.git","clone_url":"https://github.com/sttts/kubernetes.git","svn_url":"https://github.com/sttts/kubernetes","homepage":null,"size":593916,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a5c46303a2ed2c252c69855b3e650103f08a5703","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-06T23:05:35Z","pushed_at":"2018-02-06T23:48:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":750720,"stargazers_count":32233,"watchers_count":32233,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11397,"mirror_url":null,"archived":false,"open_issues_count":5308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11397,"open_issues":5308,"watchers":32233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/57795"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/57795"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/57795/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57795/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/db7861e21beb58b9191e1f6fabdaf0b126b5ac76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thockin"}}