{"action":"opened","issue":{"url":"https://api.github.com/repos/nengo/nengo-loihi/issues/146","repository_url":"https://api.github.com/repos/nengo/nengo-loihi","labels_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/146/comments","events_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/146/events","html_url":"https://github.com/nengo/nengo-loihi/issues/146","id":388342429,"node_id":"MDU6SXNzdWUzODgzNDI0Mjk=","number":146,"title":"nengo_loihi=0.4.0 incompatible with nengo=2.8.1.dev0","user":{"login":"arvoelke","id":5420057,"node_id":"MDQ6VXNlcjU0MjAwNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5420057?v=4","gravatar_id":"","url":"https://api.github.com/users/arvoelke","html_url":"https://github.com/arvoelke","followers_url":"https://api.github.com/users/arvoelke/followers","following_url":"https://api.github.com/users/arvoelke/following{/other_user}","gists_url":"https://api.github.com/users/arvoelke/gists{/gist_id}","starred_url":"https://api.github.com/users/arvoelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvoelke/subscriptions","organizations_url":"https://api.github.com/users/arvoelke/orgs","repos_url":"https://api.github.com/users/arvoelke/repos","events_url":"https://api.github.com/users/arvoelke/events{/privacy}","received_events_url":"https://api.github.com/users/arvoelke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-06T18:33:53Z","updated_at":"2018-12-06T18:33:53Z","closed_at":null,"author_association":"NONE","body":"Note this is being addressed by #142.\r\n\r\nCurrently on the master branch of `nengo` (after https://github.com/nengo/nengo/pull/1481 where `get_samples` was renamed to `get_transform`) and the master branch of `nengo_loihi` (release `0.4.0`).\r\n\r\nImporting `nengo_loihi` raises:\r\n\r\n```python\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 1, in <module>\r\n  File \"/home/arvoelke/CTN/nengo-loihi/nengo_loihi/__init__.py\", line 7, in <module>\r\n    from . import builder\r\n  File \"/home/arvoelke/CTN/nengo-loihi/nengo_loihi/builder.py\", line 18, in <module>\r\n    from nengo_loihi import conv\r\n  File \"/home/arvoelke/CTN/nengo-loihi/nengo_loihi/conv.py\", line 8, in <module>\r\n    from nengo.builder.connection import BuiltConnection, get_samples, slice_signal\r\nImportError: cannot import name 'get_samples'\r\n```\r\n\r\nBut would it be better to do a minor patch that changes `setup.py` to require `nengo<2.8.1` (or exactly `2.8.0`) so that this dependency is somewhat enforced during install? Moreover this dependency could be documented here: https://www.nengo.ai/nengo-loihi/overview.html#software"}}
{"actor":{"display_login":"arvoelke"}}