{"action":"created","comment":{"url":"https://api.github.com/repos/sapcc/helm-charts/pulls/comments/239032179","pull_request_review_id":181714051,"id":239032179,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAzMjE3OQ==","diff_hunk":"@@ -24,17 +24,18 @@ spec:\n   template:\n     metadata:\n       labels:\n-{{ tuple . \"nova\" \"compute\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}\n+{{ tuple . \"nova\" $compute_hypervisor_name | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}","path":"openstack/nova/templates/hypervisors/_ironic-deployment.yaml.tpl","position":5,"original_position":5,"commit_id":"1cfa61ff35a3ce298f0fe9e822fd3d1eda18793f","original_commit_id":"1cfa61ff35a3ce298f0fe9e822fd3d1eda18793f","user":{"login":"notandy","id":2862494,"node_id":"MDQ6VXNlcjI4NjI0OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2862494?v=4","gravatar_id":"","url":"https://api.github.com/users/notandy","html_url":"https://github.com/notandy","followers_url":"https://api.github.com/users/notandy/followers","following_url":"https://api.github.com/users/notandy/following{/other_user}","gists_url":"https://api.github.com/users/notandy/gists{/gist_id}","starred_url":"https://api.github.com/users/notandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notandy/subscriptions","organizations_url":"https://api.github.com/users/notandy/orgs","repos_url":"https://api.github.com/users/notandy/repos","events_url":"https://api.github.com/users/notandy/events{/privacy}","received_events_url":"https://api.github.com/users/notandy/received_events","type":"User","site_admin":false},"body":"This has been introduced by @galkindmitrii, please resolve this\r\n\r\n","created_at":"2018-12-05T11:41:23Z","updated_at":"2018-12-05T11:41:23Z","html_url":"https://github.com/sapcc/helm-charts/pull/500#discussion_r239032179","pull_request_url":"https://api.github.com/repos/sapcc/helm-charts/pulls/500","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/comments/239032179"},"html":{"href":"https://github.com/sapcc/helm-charts/pull/500#discussion_r239032179"},"pull_request":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/500"}},"in_reply_to_id":239025917},"pull_request":{"url":"https://api.github.com/repos/sapcc/helm-charts/pulls/500","id":236130259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTMwMjU5","html_url":"https://github.com/sapcc/helm-charts/pull/500","diff_url":"https://github.com/sapcc/helm-charts/pull/500.diff","patch_url":"https://github.com/sapcc/helm-charts/pull/500.patch","issue_url":"https://api.github.com/repos/sapcc/helm-charts/issues/500","number":500,"state":"open","locked":false,"title":"Nova queens support","user":{"login":"notandy","id":2862494,"node_id":"MDQ6VXNlcjI4NjI0OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2862494?v=4","gravatar_id":"","url":"https://api.github.com/users/notandy","html_url":"https://github.com/notandy","followers_url":"https://api.github.com/users/notandy/followers","following_url":"https://api.github.com/users/notandy/following{/other_user}","gists_url":"https://api.github.com/users/notandy/gists{/gist_id}","starred_url":"https://api.github.com/users/notandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notandy/subscriptions","organizations_url":"https://api.github.com/users/notandy/orgs","repos_url":"https://api.github.com/users/notandy/repos","events_url":"https://api.github.com/users/notandy/events{/privacy}","received_events_url":"https://api.github.com/users/notandy/received_events","type":"User","site_admin":false},"body":"This is the production-ready implementation of nova-queens, including vspc, mks console etc.\r\n\r\nIt runs alongside with mitaka regions.\r\n\r\nIt also incoroprate a queens-upgrade-dry-run job, that clones the database and run all offline-migrations in a dry run to ensure successful upgrade.","created_at":"2018-12-05T10:57:57Z","updated_at":"2018-12-05T11:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae13300cde1611ec873048a144c099b84ac544a9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"galkindmitrii","id":1788175,"node_id":"MDQ6VXNlcjE3ODgxNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1788175?v=4","gravatar_id":"","url":"https://api.github.com/users/galkindmitrii","html_url":"https://github.com/galkindmitrii","followers_url":"https://api.github.com/users/galkindmitrii/followers","following_url":"https://api.github.com/users/galkindmitrii/following{/other_user}","gists_url":"https://api.github.com/users/galkindmitrii/gists{/gist_id}","starred_url":"https://api.github.com/users/galkindmitrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galkindmitrii/subscriptions","organizations_url":"https://api.github.com/users/galkindmitrii/orgs","repos_url":"https://api.github.com/users/galkindmitrii/repos","events_url":"https://api.github.com/users/galkindmitrii/events{/privacy}","received_events_url":"https://api.github.com/users/galkindmitrii/received_events","type":"User","site_admin":false},{"login":"joker-official","id":43781403,"node_id":"MDQ6VXNlcjQzNzgxNDAz","avatar_url":"https://avatars2.githubusercontent.com/u/43781403?v=4","gravatar_id":"","url":"https://api.github.com/users/joker-official","html_url":"https://github.com/joker-official","followers_url":"https://api.github.com/users/joker-official/followers","following_url":"https://api.github.com/users/joker-official/following{/other_user}","gists_url":"https://api.github.com/users/joker-official/gists{/gist_id}","starred_url":"https://api.github.com/users/joker-official/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joker-official/subscriptions","organizations_url":"https://api.github.com/users/joker-official/orgs","repos_url":"https://api.github.com/users/joker-official/repos","events_url":"https://api.github.com/users/joker-official/events{/privacy}","received_events_url":"https://api.github.com/users/joker-official/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sapcc/helm-charts/pulls/500/commits","review_comments_url":"https://api.github.com/repos/sapcc/helm-charts/pulls/500/comments","review_comment_url":"https://api.github.com/repos/sapcc/helm-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sapcc/helm-charts/issues/500/comments","statuses_url":"https://api.github.com/repos/sapcc/helm-charts/statuses/1cfa61ff35a3ce298f0fe9e822fd3d1eda18793f","head":{"label":"sapcc:nova_queens_support","ref":"nova_queens_support","sha":"1cfa61ff35a3ce298f0fe9e822fd3d1eda18793f","user":{"login":"sapcc","id":4242847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDI4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4242847?v=4","gravatar_id":"","url":"https://api.github.com/users/sapcc","html_url":"https://github.com/sapcc","followers_url":"https://api.github.com/users/sapcc/followers","following_url":"https://api.github.com/users/sapcc/following{/other_user}","gists_url":"https://api.github.com/users/sapcc/gists{/gist_id}","starred_url":"https://api.github.com/users/sapcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapcc/subscriptions","organizations_url":"https://api.github.com/users/sapcc/orgs","repos_url":"https://api.github.com/users/sapcc/repos","events_url":"https://api.github.com/users/sapcc/events{/privacy}","received_events_url":"https://api.github.com/users/sapcc/received_events","type":"Organization","site_admin":false},"repo":{"id":72561765,"node_id":"MDEwOlJlcG9zaXRvcnk3MjU2MTc2NQ==","name":"helm-charts","full_name":"sapcc/helm-charts","private":false,"owner":{"login":"sapcc","id":4242847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDI4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4242847?v=4","gravatar_id":"","url":"https://api.github.com/users/sapcc","html_url":"https://github.com/sapcc","followers_url":"https://api.github.com/users/sapcc/followers","following_url":"https://api.github.com/users/sapcc/following{/other_user}","gists_url":"https://api.github.com/users/sapcc/gists{/gist_id}","starred_url":"https://api.github.com/users/sapcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapcc/subscriptions","organizations_url":"https://api.github.com/users/sapcc/orgs","repos_url":"https://api.github.com/users/sapcc/repos","events_url":"https://api.github.com/users/sapcc/events{/privacy}","received_events_url":"https://api.github.com/users/sapcc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sapcc/helm-charts","description":"Helm charts for SAP Converged Cloud managing openstack on kubernetes","fork":false,"url":"https://api.github.com/repos/sapcc/helm-charts","forks_url":"https://api.github.com/repos/sapcc/helm-charts/forks","keys_url":"https://api.github.com/repos/sapcc/helm-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sapcc/helm-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sapcc/helm-charts/teams","hooks_url":"https://api.github.com/repos/sapcc/helm-charts/hooks","issue_events_url":"https://api.github.com/repos/sapcc/helm-charts/issues/events{/number}","events_url":"https://api.github.com/repos/sapcc/helm-charts/events","assignees_url":"https://api.github.com/repos/sapcc/helm-charts/assignees{/user}","branches_url":"https://api.github.com/repos/sapcc/helm-charts/branches{/branch}","tags_url":"https://api.github.com/repos/sapcc/helm-charts/tags","blobs_url":"https://api.github.com/repos/sapcc/helm-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sapcc/helm-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sapcc/helm-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/sapcc/helm-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sapcc/helm-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/sapcc/helm-charts/languages","stargazers_url":"https://api.github.com/repos/sapcc/helm-charts/stargazers","contributors_url":"https://api.github.com/repos/sapcc/helm-charts/contributors","subscribers_url":"https://api.github.com/repos/sapcc/helm-charts/subscribers","subscription_url":"https://api.github.com/repos/sapcc/helm-charts/subscription","commits_url":"https://api.github.com/repos/sapcc/helm-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/sapcc/helm-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/sapcc/helm-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/sapcc/helm-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/sapcc/helm-charts/contents/{+path}","compare_url":"https://api.github.com/repos/sapcc/helm-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sapcc/helm-charts/merges","archive_url":"https://api.github.com/repos/sapcc/helm-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sapcc/helm-charts/downloads","issues_url":"https://api.github.com/repos/sapcc/helm-charts/issues{/number}","pulls_url":"https://api.github.com/repos/sapcc/helm-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/sapcc/helm-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/sapcc/helm-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sapcc/helm-charts/labels{/name}","releases_url":"https://api.github.com/repos/sapcc/helm-charts/releases{/id}","deployments_url":"https://api.github.com/repos/sapcc/helm-charts/deployments","created_at":"2016-11-01T17:54:30Z","updated_at":"2018-12-05T10:39:39Z","pushed_at":"2018-12-05T10:57:58Z","git_url":"git://github.com/sapcc/helm-charts.git","ssh_url":"git@github.com:sapcc/helm-charts.git","clone_url":"https://github.com/sapcc/helm-charts.git","svn_url":"https://github.com/sapcc/helm-charts","homepage":"","size":4935,"stargazers_count":62,"watchers_count":62,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":43,"watchers":62,"default_branch":"master"}},"base":{"label":"sapcc:master","ref":"master","sha":"c859517a6c9a2c48f165f875a43e7f19c8989c0f","user":{"login":"sapcc","id":4242847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDI4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4242847?v=4","gravatar_id":"","url":"https://api.github.com/users/sapcc","html_url":"https://github.com/sapcc","followers_url":"https://api.github.com/users/sapcc/followers","following_url":"https://api.github.com/users/sapcc/following{/other_user}","gists_url":"https://api.github.com/users/sapcc/gists{/gist_id}","starred_url":"https://api.github.com/users/sapcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapcc/subscriptions","organizations_url":"https://api.github.com/users/sapcc/orgs","repos_url":"https://api.github.com/users/sapcc/repos","events_url":"https://api.github.com/users/sapcc/events{/privacy}","received_events_url":"https://api.github.com/users/sapcc/received_events","type":"Organization","site_admin":false},"repo":{"id":72561765,"node_id":"MDEwOlJlcG9zaXRvcnk3MjU2MTc2NQ==","name":"helm-charts","full_name":"sapcc/helm-charts","private":false,"owner":{"login":"sapcc","id":4242847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDI4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4242847?v=4","gravatar_id":"","url":"https://api.github.com/users/sapcc","html_url":"https://github.com/sapcc","followers_url":"https://api.github.com/users/sapcc/followers","following_url":"https://api.github.com/users/sapcc/following{/other_user}","gists_url":"https://api.github.com/users/sapcc/gists{/gist_id}","starred_url":"https://api.github.com/users/sapcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapcc/subscriptions","organizations_url":"https://api.github.com/users/sapcc/orgs","repos_url":"https://api.github.com/users/sapcc/repos","events_url":"https://api.github.com/users/sapcc/events{/privacy}","received_events_url":"https://api.github.com/users/sapcc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sapcc/helm-charts","description":"Helm charts for SAP Converged Cloud managing openstack on kubernetes","fork":false,"url":"https://api.github.com/repos/sapcc/helm-charts","forks_url":"https://api.github.com/repos/sapcc/helm-charts/forks","keys_url":"https://api.github.com/repos/sapcc/helm-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sapcc/helm-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sapcc/helm-charts/teams","hooks_url":"https://api.github.com/repos/sapcc/helm-charts/hooks","issue_events_url":"https://api.github.com/repos/sapcc/helm-charts/issues/events{/number}","events_url":"https://api.github.com/repos/sapcc/helm-charts/events","assignees_url":"https://api.github.com/repos/sapcc/helm-charts/assignees{/user}","branches_url":"https://api.github.com/repos/sapcc/helm-charts/branches{/branch}","tags_url":"https://api.github.com/repos/sapcc/helm-charts/tags","blobs_url":"https://api.github.com/repos/sapcc/helm-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sapcc/helm-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sapcc/helm-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/sapcc/helm-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sapcc/helm-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/sapcc/helm-charts/languages","stargazers_url":"https://api.github.com/repos/sapcc/helm-charts/stargazers","contributors_url":"https://api.github.com/repos/sapcc/helm-charts/contributors","subscribers_url":"https://api.github.com/repos/sapcc/helm-charts/subscribers","subscription_url":"https://api.github.com/repos/sapcc/helm-charts/subscription","commits_url":"https://api.github.com/repos/sapcc/helm-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/sapcc/helm-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/sapcc/helm-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/sapcc/helm-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/sapcc/helm-charts/contents/{+path}","compare_url":"https://api.github.com/repos/sapcc/helm-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sapcc/helm-charts/merges","archive_url":"https://api.github.com/repos/sapcc/helm-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sapcc/helm-charts/downloads","issues_url":"https://api.github.com/repos/sapcc/helm-charts/issues{/number}","pulls_url":"https://api.github.com/repos/sapcc/helm-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/sapcc/helm-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/sapcc/helm-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sapcc/helm-charts/labels{/name}","releases_url":"https://api.github.com/repos/sapcc/helm-charts/releases{/id}","deployments_url":"https://api.github.com/repos/sapcc/helm-charts/deployments","created_at":"2016-11-01T17:54:30Z","updated_at":"2018-12-05T10:39:39Z","pushed_at":"2018-12-05T10:57:58Z","git_url":"git://github.com/sapcc/helm-charts.git","ssh_url":"git@github.com:sapcc/helm-charts.git","clone_url":"https://github.com/sapcc/helm-charts.git","svn_url":"https://github.com/sapcc/helm-charts","homepage":"","size":4935,"stargazers_count":62,"watchers_count":62,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":43,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/500"},"html":{"href":"https://github.com/sapcc/helm-charts/pull/500"},"issue":{"href":"https://api.github.com/repos/sapcc/helm-charts/issues/500"},"comments":{"href":"https://api.github.com/repos/sapcc/helm-charts/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sapcc/helm-charts/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/sapcc/helm-charts/statuses/1cfa61ff35a3ce298f0fe9e822fd3d1eda18793f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"notandy"}}