{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments/190101350","pull_request_review_id":122408095,"id":190101350,"diff_hunk":"@@ -37,14 +38,15 @@ class WorkspaceMethodConfigDetailsPage(namespace: String, name: String, methodCo\n   def clickLaunchAnalysis(): Unit = {\n     openLaunchAnalysisModalButton.doClick()\n     // defensive code to prevents test from failing. after click, expect to find either a Message or Analysis Modal\n-    implicit val patienceConfig: PatienceConfig = PatienceConfig(timeout = scaled(Span(10, Seconds)), interval = scaled(Span(3, Seconds)))\n-    Try[String](eventually[String] {\n-      find(CssSelectorQuery(\"body.broadinstitute-modal-open\")).get.underlying.getTagName\n-    }) match {\n+    Try(\n+      await condition (find(CssSelectorQuery(\".broadinstitute-modal-open\")).nonEmpty, 5)\n+    ) match {\n       case Failure(e) =>\n-        logger.debug(s\"Retrying click [button:${openLaunchAnalysisModalButton.query}]\")\n-        openLaunchAnalysisModalButton.doClick()\n+        logger.warn(s\"clickLaunchAnalysis failed. Retrying click [button:${openLaunchAnalysisModalButton.query}]\")\n+        // try alternative click\n+        new Actions(webDriver).moveToElement(openLaunchAnalysisModalButton.query.webElement).click().build().perform();","path":"automation/src/test/scala/org/broadinstitute/dsde/firecloud/page/workspaces/methodconfigs/WorkspaceMethodConfigDetailsPage.scala","position":24,"original_position":24,"commit_id":"1521eca8b662dae46336c7cd581b9ada583c3f80","original_commit_id":"2f8d29abe93e4b7328eac773648f5ab237370290","user":{"login":"aweng98","id":35533885,"avatar_url":"https://avatars2.githubusercontent.com/u/35533885?v=4","gravatar_id":"","url":"https://api.github.com/users/aweng98","html_url":"https://github.com/aweng98","followers_url":"https://api.github.com/users/aweng98/followers","following_url":"https://api.github.com/users/aweng98/following{/other_user}","gists_url":"https://api.github.com/users/aweng98/gists{/gist_id}","starred_url":"https://api.github.com/users/aweng98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweng98/subscriptions","organizations_url":"https://api.github.com/users/aweng98/orgs","repos_url":"https://api.github.com/users/aweng98/repos","events_url":"https://api.github.com/users/aweng98/events{/privacy}","received_events_url":"https://api.github.com/users/aweng98/received_events","type":"User","site_admin":false},"body":"use `doClick`","created_at":"2018-05-23T01:35:31Z","updated_at":"2018-05-23T01:35:31Z","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1302#discussion_r190101350","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments/190101350"},"html":{"href":"https://github.com/broadinstitute/firecloud-ui/pull/1302#discussion_r190101350"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302"}},"in_reply_to_id":189656344},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302","id":188730363,"html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1302","diff_url":"https://github.com/broadinstitute/firecloud-ui/pull/1302.diff","patch_url":"https://github.com/broadinstitute/firecloud-ui/pull/1302.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1302","number":1302,"state":"open","locked":false,"title":"minor improvements","user":{"login":"aweng98","id":35533885,"avatar_url":"https://avatars2.githubusercontent.com/u/35533885?v=4","gravatar_id":"","url":"https://api.github.com/users/aweng98","html_url":"https://github.com/aweng98","followers_url":"https://api.github.com/users/aweng98/followers","following_url":"https://api.github.com/users/aweng98/following{/other_user}","gists_url":"https://api.github.com/users/aweng98/gists{/gist_id}","starred_url":"https://api.github.com/users/aweng98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweng98/subscriptions","organizations_url":"https://api.github.com/users/aweng98/orgs","repos_url":"https://api.github.com/users/aweng98/repos","events_url":"https://api.github.com/users/aweng98/events{/privacy}","received_events_url":"https://api.github.com/users/aweng98/received_events","type":"User","site_admin":false},"body":"- Update workbench-service-test\r\n- Update Scala to version 2.12.4\r\n- Update dependencies versions\r\n- Rework fix for `Launch Analysis` click button not working sometimes\r\n- Clean up compile errors from Scala version upgrade\r\n\r\n\r\n- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: If you changed a URL that is used elsewhere (e.g. in an email), comment about where it is used and ensure the dependent code is updated.\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * To Demo flag is set\r\n  * Release Summary is filled out, if applicable\r\n  * Add notes on how to QA\r\n- [ ] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [ ] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [ ] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [ ] **Submitter**: If you're adding new automated UI tests, review the test plan with QA\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests and automated UI tests.\r\n- [ ] **Submitter**: Squash commits and merge to develop. If adding test code, merge application code and test code at the same time.\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n","created_at":"2018-05-17T13:05:25Z","updated_at":"2018-05-23T01:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"323d513e3f1ca7c9c52eb1b5825ead2be9217e4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1302/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/1521eca8b662dae46336c7cd581b9ada583c3f80","head":{"label":"broadinstitute:aw-workflow","ref":"aw-workflow","sha":"1521eca8b662dae46336c7cd581b9ada583c3f80","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-ui","description":"FireCloud user interface for web browsers.","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2018-05-17T20:12:24Z","pushed_at":"2018-05-23T01:17:47Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":"https://portal.firecloud.org","size":5318,"stargazers_count":13,"watchers_count":13,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5,"open_issues":11,"watchers":13,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"5863ecc965b92adce8358c11bc1b84869e6c18c5","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-ui","description":"FireCloud user interface for web browsers.","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2018-05-17T20:12:24Z","pushed_at":"2018-05-23T01:17:47Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":"https://portal.firecloud.org","size":5318,"stargazers_count":13,"watchers_count":13,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5,"open_issues":11,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302"},"html":{"href":"https://github.com/broadinstitute/firecloud-ui/pull/1302"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1302"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1302/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1302/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/1521eca8b662dae46336c7cd581b9ada583c3f80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aweng98"}}