{"action":"created","issue":{"url":"https://api.github.com/repos/fabricjs/fabric.js/issues/5185","repository_url":"https://api.github.com/repos/fabricjs/fabric.js","labels_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/5185/labels{/name}","comments_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/5185/comments","events_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/5185/events","html_url":"https://github.com/fabricjs/fabric.js/issues/5185","id":352619845,"node_id":"MDU6SXNzdWUzNTI2MTk4NDU=","number":5185,"title":"Ensure fabric.Image exists","user":{"login":"BradleyHill","id":2738291,"node_id":"MDQ6VXNlcjI3MzgyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2738291?v=4","gravatar_id":"","url":"https://api.github.com/users/BradleyHill","html_url":"https://github.com/BradleyHill","followers_url":"https://api.github.com/users/BradleyHill/followers","following_url":"https://api.github.com/users/BradleyHill/following{/other_user}","gists_url":"https://api.github.com/users/BradleyHill/gists{/gist_id}","starred_url":"https://api.github.com/users/BradleyHill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BradleyHill/subscriptions","organizations_url":"https://api.github.com/users/BradleyHill/orgs","repos_url":"https://api.github.com/users/BradleyHill/repos","events_url":"https://api.github.com/users/BradleyHill/events{/privacy}","received_events_url":"https://api.github.com/users/BradleyHill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-21T16:31:41Z","updated_at":"2018-08-21T17:08:03Z","closed_at":null,"author_association":"NONE","body":"Pretty simple (but pretty specific).\r\n\r\nAngular @angular-devkit/build-angular version 0.6.8 and higher fail to build in aot mode on fabric.js.\r\n```\r\nERROR in ./node_modules/fabric/dist/fabric.js\r\nModule build failed: Error: Debug Failure. False expression.\r\n    at forEachIdentifierInEntityName (./node_modules/typescript/lib/typescript.js:24115:26)\r\n```\r\n\r\nDigger into the bowels of the build, it seems that it does not like that `fabric.Image.filters` is created when no guarantee `fabric.Image` exists. Adding the following line:\r\n`fabric.Image = fabric.Image || { };`\r\nbefore\r\n`fabric.Image.filters = fabric.Image.filters || { };`\r\nremedies this. Shouldn't affect any existing functionality (and seems like best practice).\r\n"},"comment":{"url":"https://api.github.com/repos/fabricjs/fabric.js/issues/comments/414749672","html_url":"https://github.com/fabricjs/fabric.js/issues/5185#issuecomment-414749672","issue_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/5185","id":414749672,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc0OTY3Mg==","user":{"login":"BradleyHill","id":2738291,"node_id":"MDQ6VXNlcjI3MzgyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2738291?v=4","gravatar_id":"","url":"https://api.github.com/users/BradleyHill","html_url":"https://github.com/BradleyHill","followers_url":"https://api.github.com/users/BradleyHill/followers","following_url":"https://api.github.com/users/BradleyHill/following{/other_user}","gists_url":"https://api.github.com/users/BradleyHill/gists{/gist_id}","starred_url":"https://api.github.com/users/BradleyHill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BradleyHill/subscriptions","organizations_url":"https://api.github.com/users/BradleyHill/orgs","repos_url":"https://api.github.com/users/BradleyHill/repos","events_url":"https://api.github.com/users/BradleyHill/events{/privacy}","received_events_url":"https://api.github.com/users/BradleyHill/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T17:08:03Z","updated_at":"2018-08-21T17:08:03Z","author_association":"NONE","body":"Tis a typescript thing and only in `production` mode i.e. strict. Working on PR. Trying to be a contributor and not just taker. Hopefully soon."}}
{"actor":{"display_login":"BradleyHill"}}