{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/207085539","pull_request_review_id":142626101,"id":207085539,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA4NTUzOQ==","diff_hunk":"@@ -2279,32 +2216,6 @@ HRESULT GetImageRuntimeVersionString(PVOID pMetaData, LPCSTR* pString)\n     \n     // Header data starts after signature.\n     *pString = (LPCSTR) pSig->pVersion;\n-    if(*pString) {","path":"src/utilcode/util.cpp","position":90,"original_position":90,"commit_id":"a9ccff3c043b8e94495771a7019c33b2710e701d","original_commit_id":"a9ccff3c043b8e94495771a7019c33b2710e701d","user":{"login":"AaronRobinsonMSFT","id":30635565,"node_id":"MDQ6VXNlcjMwNjM1NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/30635565?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobinsonMSFT","html_url":"https://github.com/AaronRobinsonMSFT","followers_url":"https://api.github.com/users/AaronRobinsonMSFT/followers","following_url":"https://api.github.com/users/AaronRobinsonMSFT/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobinsonMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobinsonMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobinsonMSFT/subscriptions","organizations_url":"https://api.github.com/users/AaronRobinsonMSFT/orgs","repos_url":"https://api.github.com/users/AaronRobinsonMSFT/repos","events_url":"https://api.github.com/users/AaronRobinsonMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobinsonMSFT/received_events","type":"User","site_admin":false},"body":"This branch seems like a very old code path that ensures Version strings in metadata are valid. It seems like a legacy code path for early development of the CLR.\r\n\r\n@jkotas I debugged through this via crossgen and it basically just validates the embedded version string is acceptable and if not replaced it with `v1.0.3705` 😖. Is there anything more I could do to verify this change is okay?","created_at":"2018-08-02T02:25:38Z","updated_at":"2018-08-02T02:25:39Z","html_url":"https://github.com/dotnet/coreclr/pull/19239#discussion_r207085539","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19239","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/207085539"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19239#discussion_r207085539"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19239"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19239","id":205601428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjAxNDI4","html_url":"https://github.com/dotnet/coreclr/pull/19239","diff_url":"https://github.com/dotnet/coreclr/pull/19239.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19239.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19239","number":19239,"state":"open","locked":false,"title":"Remove unused/nop/questionable code","user":{"login":"AaronRobinsonMSFT","id":30635565,"node_id":"MDQ6VXNlcjMwNjM1NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/30635565?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobinsonMSFT","html_url":"https://github.com/AaronRobinsonMSFT","followers_url":"https://api.github.com/users/AaronRobinsonMSFT/followers","following_url":"https://api.github.com/users/AaronRobinsonMSFT/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobinsonMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobinsonMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobinsonMSFT/subscriptions","organizations_url":"https://api.github.com/users/AaronRobinsonMSFT/orgs","repos_url":"https://api.github.com/users/AaronRobinsonMSFT/repos","events_url":"https://api.github.com/users/AaronRobinsonMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobinsonMSFT/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-02T02:22:08Z","updated_at":"2018-08-02T02:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a92e705ccb3a5545eed582a45ec0b794c52d6564","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19239/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19239/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19239/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/a9ccff3c043b8e94495771a7019c33b2710e701d","head":{"label":"AaronRobinsonMSFT:remove_dead_code","ref":"remove_dead_code","sha":"a9ccff3c043b8e94495771a7019c33b2710e701d","user":{"login":"AaronRobinsonMSFT","id":30635565,"node_id":"MDQ6VXNlcjMwNjM1NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/30635565?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobinsonMSFT","html_url":"https://github.com/AaronRobinsonMSFT","followers_url":"https://api.github.com/users/AaronRobinsonMSFT/followers","following_url":"https://api.github.com/users/AaronRobinsonMSFT/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobinsonMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobinsonMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobinsonMSFT/subscriptions","organizations_url":"https://api.github.com/users/AaronRobinsonMSFT/orgs","repos_url":"https://api.github.com/users/AaronRobinsonMSFT/repos","events_url":"https://api.github.com/users/AaronRobinsonMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobinsonMSFT/received_events","type":"User","site_admin":false},"repo":{"id":133579114,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NzkxMTQ=","name":"coreclr","full_name":"AaronRobinsonMSFT/coreclr","owner":{"login":"AaronRobinsonMSFT","id":30635565,"node_id":"MDQ6VXNlcjMwNjM1NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/30635565?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobinsonMSFT","html_url":"https://github.com/AaronRobinsonMSFT","followers_url":"https://api.github.com/users/AaronRobinsonMSFT/followers","following_url":"https://api.github.com/users/AaronRobinsonMSFT/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobinsonMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobinsonMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobinsonMSFT/subscriptions","organizations_url":"https://api.github.com/users/AaronRobinsonMSFT/orgs","repos_url":"https://api.github.com/users/AaronRobinsonMSFT/repos","events_url":"https://api.github.com/users/AaronRobinsonMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobinsonMSFT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AaronRobinsonMSFT/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr","forks_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/forks","keys_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/teams","hooks_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/hooks","issue_events_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/events","assignees_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/tags","blobs_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/languages","stargazers_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/stargazers","contributors_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/contributors","subscribers_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/subscribers","subscription_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/subscription","commits_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/merges","archive_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/downloads","issues_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/AaronRobinsonMSFT/coreclr/deployments","created_at":"2018-05-15T22:16:11Z","updated_at":"2018-06-01T19:23:44Z","pushed_at":"2018-08-02T02:20:01Z","git_url":"git://github.com/AaronRobinsonMSFT/coreclr.git","ssh_url":"git@github.com:AaronRobinsonMSFT/coreclr.git","clone_url":"https://github.com/AaronRobinsonMSFT/coreclr.git","svn_url":"https://github.com/AaronRobinsonMSFT/coreclr","homepage":"https://github.com/dotnet/core","size":231448,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"87e9259abda877c2fb80ff54dc85f782e3c64df0","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-08-02T01:38:37Z","pushed_at":"2018-08-02T02:22:09Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":232237,"stargazers_count":9634,"watchers_count":9634,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2398,"mirror_url":null,"archived":false,"open_issues_count":1742,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2398,"open_issues":1742,"watchers":9634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19239"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19239"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19239"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19239/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19239/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19239/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/a9ccff3c043b8e94495771a7019c33b2710e701d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AaronRobinsonMSFT"}}