{"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/mock/pulls/comments/190828231","pull_request_review_id":123288585,"id":190828231,"diff_hunk":"@@ -0,0 +1,35 @@\n+Summary: test-A\n+Name: test-A\n+Version: 1.1\n+Release: 0\n+License: GPL\n+Group: System Environment/Base\n+BuildRequires: test-B\n+\n+%description\n+Test packge for mockchain building chains\n+\n+\n+\n+\n+%prep\n+\n+%build\n+\n+%install\n+[ \"$RPM_BUILD_ROOT\" != \"/\" ] && rm -rf $RPM_BUILD_ROOT\n+mkdir -p $RPM_BUILD_ROOT/etc\n+touch $RPM_BUILD_ROOT/etc/%{name}-installed","path":"mock/tests/test-A.spec","position":22,"original_position":22,"commit_id":"c36677c1a0a413af1760f6c9c0d5188ed7ed075f","original_commit_id":"c36677c1a0a413af1760f6c9c0d5188ed7ed075f","user":{"login":"xsuchy","id":85769,"avatar_url":"https://avatars0.githubusercontent.com/u/85769?v=4","gravatar_id":"","url":"https://api.github.com/users/xsuchy","html_url":"https://github.com/xsuchy","followers_url":"https://api.github.com/users/xsuchy/followers","following_url":"https://api.github.com/users/xsuchy/following{/other_user}","gists_url":"https://api.github.com/users/xsuchy/gists{/gist_id}","starred_url":"https://api.github.com/users/xsuchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsuchy/subscriptions","organizations_url":"https://api.github.com/users/xsuchy/orgs","repos_url":"https://api.github.com/users/xsuchy/repos","events_url":"https://api.github.com/users/xsuchy/events{/privacy}","received_events_url":"https://api.github.com/users/xsuchy/received_events","type":"User","site_admin":false},"body":"Can you use %{_sysconfdir} instead of /etc/?","created_at":"2018-05-25T08:44:21Z","updated_at":"2018-05-25T08:44:22Z","html_url":"https://github.com/rpm-software-management/mock/pull/187#discussion_r190828231","pull_request_url":"https://api.github.com/repos/rpm-software-management/mock/pulls/187","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/comments/190828231"},"html":{"href":"https://github.com/rpm-software-management/mock/pull/187#discussion_r190828231"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/187"}},"in_reply_to_id":190827993},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/mock/pulls/187","id":190503727,"html_url":"https://github.com/rpm-software-management/mock/pull/187","diff_url":"https://github.com/rpm-software-management/mock/pull/187.diff","patch_url":"https://github.com/rpm-software-management/mock/pull/187.patch","issue_url":"https://api.github.com/repos/rpm-software-management/mock/issues/187","number":187,"state":"open","locked":false,"title":"Allow --spec arg to be used with rebuild option","user":{"login":"sfowl","id":9766446,"avatar_url":"https://avatars3.githubusercontent.com/u/9766446?v=4","gravatar_id":"","url":"https://api.github.com/users/sfowl","html_url":"https://github.com/sfowl","followers_url":"https://api.github.com/users/sfowl/followers","following_url":"https://api.github.com/users/sfowl/following{/other_user}","gists_url":"https://api.github.com/users/sfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/sfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfowl/subscriptions","organizations_url":"https://api.github.com/users/sfowl/orgs","repos_url":"https://api.github.com/users/sfowl/repos","events_url":"https://api.github.com/users/sfowl/events{/privacy}","received_events_url":"https://api.github.com/users/sfowl/received_events","type":"User","site_admin":false},"body":"This is an unsolicited patch to allow for 'mock' to be used with the ```--spec``` option to ```rebuild``` (default) a package.\r\n\r\nThe use case is to support rebuilding a package with compilation options like ASAN (```-fsanitize=address```) to test reproducers for security vulnerabilities.\r\n\r\nE.g.\r\n\r\n```\r\n# dnf download --source foo\r\n# rpm2cpio foo.src.rpm | cpio -dimv\r\n(Add/modify compilation flags in .spec file)\r\n# mock --spec foo.spec foo.src.rpm --postinstall\r\n```\r\n\r\nThen spawn a shell in the chroot and test the newly compiled binaries with reproducer inputs.\r\n\r\nI also considered adding an option like ```--buildbrpm```, but found that the current approach made it easier as a user to get to the 'ready-to-run-commands-stage'.\r\n\r\nFeedback is welcomed! Suggestions on other methods to achieve the above is also welcomed.","created_at":"2018-05-25T07:32:37Z","updated_at":"2018-05-25T08:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a334b2578654e133497836ae06088d57f45357e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/mock/pulls/187/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/mock/pulls/187/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/mock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpm-software-management/mock/issues/187/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/mock/statuses/c36677c1a0a413af1760f6c9c0d5188ed7ed075f","head":{"label":"sfowl:buildbrpm","ref":"buildbrpm","sha":"c36677c1a0a413af1760f6c9c0d5188ed7ed075f","user":{"login":"sfowl","id":9766446,"avatar_url":"https://avatars3.githubusercontent.com/u/9766446?v=4","gravatar_id":"","url":"https://api.github.com/users/sfowl","html_url":"https://github.com/sfowl","followers_url":"https://api.github.com/users/sfowl/followers","following_url":"https://api.github.com/users/sfowl/following{/other_user}","gists_url":"https://api.github.com/users/sfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/sfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfowl/subscriptions","organizations_url":"https://api.github.com/users/sfowl/orgs","repos_url":"https://api.github.com/users/sfowl/repos","events_url":"https://api.github.com/users/sfowl/events{/privacy}","received_events_url":"https://api.github.com/users/sfowl/received_events","type":"User","site_admin":false},"repo":{"id":134808842,"name":"mock","full_name":"sfowl/mock","owner":{"login":"sfowl","id":9766446,"avatar_url":"https://avatars3.githubusercontent.com/u/9766446?v=4","gravatar_id":"","url":"https://api.github.com/users/sfowl","html_url":"https://github.com/sfowl","followers_url":"https://api.github.com/users/sfowl/followers","following_url":"https://api.github.com/users/sfowl/following{/other_user}","gists_url":"https://api.github.com/users/sfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/sfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfowl/subscriptions","organizations_url":"https://api.github.com/users/sfowl/orgs","repos_url":"https://api.github.com/users/sfowl/repos","events_url":"https://api.github.com/users/sfowl/events{/privacy}","received_events_url":"https://api.github.com/users/sfowl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfowl/mock","description":"Mock is a tool for a reproducible build of RPM packages.","fork":true,"url":"https://api.github.com/repos/sfowl/mock","forks_url":"https://api.github.com/repos/sfowl/mock/forks","keys_url":"https://api.github.com/repos/sfowl/mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfowl/mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfowl/mock/teams","hooks_url":"https://api.github.com/repos/sfowl/mock/hooks","issue_events_url":"https://api.github.com/repos/sfowl/mock/issues/events{/number}","events_url":"https://api.github.com/repos/sfowl/mock/events","assignees_url":"https://api.github.com/repos/sfowl/mock/assignees{/user}","branches_url":"https://api.github.com/repos/sfowl/mock/branches{/branch}","tags_url":"https://api.github.com/repos/sfowl/mock/tags","blobs_url":"https://api.github.com/repos/sfowl/mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfowl/mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfowl/mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfowl/mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfowl/mock/statuses/{sha}","languages_url":"https://api.github.com/repos/sfowl/mock/languages","stargazers_url":"https://api.github.com/repos/sfowl/mock/stargazers","contributors_url":"https://api.github.com/repos/sfowl/mock/contributors","subscribers_url":"https://api.github.com/repos/sfowl/mock/subscribers","subscription_url":"https://api.github.com/repos/sfowl/mock/subscription","commits_url":"https://api.github.com/repos/sfowl/mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfowl/mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfowl/mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfowl/mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfowl/mock/contents/{+path}","compare_url":"https://api.github.com/repos/sfowl/mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfowl/mock/merges","archive_url":"https://api.github.com/repos/sfowl/mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfowl/mock/downloads","issues_url":"https://api.github.com/repos/sfowl/mock/issues{/number}","pulls_url":"https://api.github.com/repos/sfowl/mock/pulls{/number}","milestones_url":"https://api.github.com/repos/sfowl/mock/milestones{/number}","notifications_url":"https://api.github.com/repos/sfowl/mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfowl/mock/labels{/name}","releases_url":"https://api.github.com/repos/sfowl/mock/releases{/id}","deployments_url":"https://api.github.com/repos/sfowl/mock/deployments","created_at":"2018-05-25T05:45:22Z","updated_at":"2018-05-25T05:45:25Z","pushed_at":"2018-05-25T06:52:00Z","git_url":"git://github.com/sfowl/mock.git","ssh_url":"git@github.com:sfowl/mock.git","clone_url":"https://github.com/sfowl/mock.git","svn_url":"https://github.com/sfowl/mock","homepage":"","size":2793,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"rpm-software-management:devel","ref":"devel","sha":"be546430c349070c82f0208346f771d2e98f4040","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars3.githubusercontent.com/u/8504469?v=4","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":65797337,"name":"mock","full_name":"rpm-software-management/mock","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars3.githubusercontent.com/u/8504469?v=4","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/mock","description":"Mock is a tool for a reproducible build of RPM packages.","fork":false,"url":"https://api.github.com/repos/rpm-software-management/mock","forks_url":"https://api.github.com/repos/rpm-software-management/mock/forks","keys_url":"https://api.github.com/repos/rpm-software-management/mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/mock/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/mock/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/mock/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/mock/events","assignees_url":"https://api.github.com/repos/rpm-software-management/mock/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/mock/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/mock/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/mock/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/mock/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/mock/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/mock/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/mock/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/mock/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpm-software-management/mock/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/mock/merges","archive_url":"https://api.github.com/repos/rpm-software-management/mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/mock/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/mock/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/mock/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/mock/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/mock/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/mock/releases{/id}","deployments_url":"https://api.github.com/repos/rpm-software-management/mock/deployments","created_at":"2016-08-16T07:24:01Z","updated_at":"2018-05-22T11:13:56Z","pushed_at":"2018-05-25T08:36:29Z","git_url":"git://github.com/rpm-software-management/mock.git","ssh_url":"git@github.com:rpm-software-management/mock.git","clone_url":"https://github.com/rpm-software-management/mock.git","svn_url":"https://github.com/rpm-software-management/mock","homepage":"","size":2777,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":71,"open_issues":30,"watchers":89,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/187"},"html":{"href":"https://github.com/rpm-software-management/mock/pull/187"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/mock/issues/187"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/mock/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/mock/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/mock/statuses/c36677c1a0a413af1760f6c9c0d5188ed7ed075f"}},"author_association":"NONE"}}
{"actor":{"display_login":"xsuchy"}}