{"action":"created","issue":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/15765","repository_url":"https://api.github.com/repos/EFForg/https-everywhere","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/15765/labels{/name}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/15765/comments","events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/15765/events","html_url":"https://github.com/EFForg/https-everywhere/pull/15765","id":332777763,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTc3MDA4","number":15765,"title":"Spring cleaning #3","user":{"login":"RReverser","id":557590,"node_id":"MDQ6VXNlcjU1NzU5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/557590?v=4","gravatar_id":"","url":"https://api.github.com/users/RReverser","html_url":"https://github.com/RReverser","followers_url":"https://api.github.com/users/RReverser/followers","following_url":"https://api.github.com/users/RReverser/following{/other_user}","gists_url":"https://api.github.com/users/RReverser/gists{/gist_id}","starred_url":"https://api.github.com/users/RReverser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RReverser/subscriptions","organizations_url":"https://api.github.com/users/RReverser/orgs","repos_url":"https://api.github.com/users/RReverser/repos","events_url":"https://api.github.com/users/RReverser/events{/privacy}","received_events_url":"https://api.github.com/users/RReverser/received_events","type":"User","site_admin":false},"labels":[{"id":427778319,"node_id":"MDU6TGFiZWw0Mjc3NzgzMTk=","url":"https://api.github.com/repos/EFForg/https-everywhere/labels/top-1k","name":"top-1k","color":"ff4d4d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-06-15T13:41:54Z","updated_at":"2018-06-19T13:51:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/15765","html_url":"https://github.com/EFForg/https-everywhere/pull/15765","diff_url":"https://github.com/EFForg/https-everywhere/pull/15765.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/15765.patch"},"body":"This is yet another follow-up to https://github.com/EFForg/https-everywhere/pull/4400 and https://github.com/EFForg/https-everywhere/pull/12294. This time with fewer changes, just added special case to recognise commonly used generic subdomain patterns in regexps and transform them to `*.example.org` targets as it has the same behaviour per guidelines.\r\n\r\nAs usual, aside from stylistic change, this slightly decreases memory usage as well since such rulesets become \"trivial\".\r\n\r\nBefore:\r\nInitial usage: 41.3 MB\r\nMaximum usage: 79 MB\r\nAfter:\r\nInitial usage: 41.3 MB\r\nMaximum usage: 78.5 MB\r\n\r\nAlso, as usual with previous automated runs, this will require updating `ruleset-whitelist.csv` to avoid CI failures, but looks like the format has changed since I last checked it and I will need help with figuring out how to update it."},"comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments/398406119","html_url":"https://github.com/EFForg/https-everywhere/pull/15765#issuecomment-398406119","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/15765","id":398406119,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQwNjExOQ==","user":{"login":"RReverser","id":557590,"node_id":"MDQ6VXNlcjU1NzU5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/557590?v=4","gravatar_id":"","url":"https://api.github.com/users/RReverser","html_url":"https://github.com/RReverser","followers_url":"https://api.github.com/users/RReverser/followers","following_url":"https://api.github.com/users/RReverser/following{/other_user}","gists_url":"https://api.github.com/users/RReverser/gists{/gist_id}","starred_url":"https://api.github.com/users/RReverser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RReverser/subscriptions","organizations_url":"https://api.github.com/users/RReverser/orgs","repos_url":"https://api.github.com/users/RReverser/repos","events_url":"https://api.github.com/users/RReverser/events{/privacy}","received_events_url":"https://api.github.com/users/RReverser/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T13:51:10Z","updated_at":"2018-06-19T13:51:10Z","author_association":"CONTRIBUTOR","body":"> They are easier to catch with a regex in the rule to avoid huge lists of targets.\r\n\r\nI'd love to see an example of this, just wondering if complexity of regexp in such cases justifies benefits over a list of targets.\r\n\r\n> for this PR you could try to determine if imarandomhostthatshouldnotexist.$TARGETHOST or im.a.random.host.that.should.not.exist.$TARGETHOST are existing HTTP hosts or not\r\n\r\nThat's an option, but I guess simply checking domain existence wouldn't be enough to know whether they support HTTPS on these levels and so such check would have false positives?"}}
{"actor":{"display_login":"RReverser"}}