{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/196140678","pull_request_review_id":129637902,"id":196140678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE0MDY3OA==","diff_hunk":"@@ -1192,3 +1193,25 @@ def test_dtype_match():\n             lr_64.fit(X_64, y_64)\n             assert_equal(lr_64.coef_.dtype, X_64.dtype)\n             assert_almost_equal(lr_32.coef_, lr_64.coef_.astype(np.float32))\n+\n+\n+def test_warm_start_converge_LR():\n+    # Test to see that the logistic regression converges on warm start,\n+    # with multi_class='multinomial'\n+    # Set independent variable values\n+    rng = np.random.RandomState(0)\n+    X = np.concatenate((rng.randn(100, 2) + [1, 1], rng.randn(100, 2)))\n+    y = [1] * 100 + [-1] * 100","path":"sklearn/linear_model/tests/test_logistic.py","position":20,"original_position":20,"commit_id":"69da036ac60220d836bf172840edd3b8651f12e2","original_commit_id":"69da036ac60220d836bf172840edd3b8651f12e2","user":{"login":"glemaitre","id":7454015,"node_id":"MDQ6VXNlcjc0NTQwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"body":"make this a numpy array","created_at":"2018-06-18T16:21:52Z","updated_at":"2018-06-18T16:21:52Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10986#discussion_r196140678","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/196140678"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10986#discussion_r196140678"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986","id":181941953,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxOTQxOTUz","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10986","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10986.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10986.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10986","number":10986,"state":"open","locked":false,"title":"Fix LogisticRegression with warm_start, multinomial and binary data","user":{"login":"aishgrt1","id":31906139,"node_id":"MDQ6VXNlcjMxOTA2MTM5","avatar_url":"https://avatars2.githubusercontent.com/u/31906139?v=4","gravatar_id":"","url":"https://api.github.com/users/aishgrt1","html_url":"https://github.com/aishgrt1","followers_url":"https://api.github.com/users/aishgrt1/followers","following_url":"https://api.github.com/users/aishgrt1/following{/other_user}","gists_url":"https://api.github.com/users/aishgrt1/gists{/gist_id}","starred_url":"https://api.github.com/users/aishgrt1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aishgrt1/subscriptions","organizations_url":"https://api.github.com/users/aishgrt1/orgs","repos_url":"https://api.github.com/users/aishgrt1/repos","events_url":"https://api.github.com/users/aishgrt1/events{/privacy}","received_events_url":"https://api.github.com/users/aishgrt1/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\nFix #10836 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nn_classes==1 added for w0 and coef , broadcasting issue resolved\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-04-16T17:53:06Z","updated_at":"2018-06-18T16:21:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"797f344f6949d72e98f0ce784d3bc7b39e39637c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":12995755,"node_id":"MDU6TGFiZWwxMjk5NTc1NQ==","url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Bug","name":"Bug","color":"e10c02","default":false}],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/24","html_url":"https://github.com/scikit-learn/scikit-learn/milestone/24","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/24/labels","id":2577444,"node_id":"MDk6TWlsZXN0b25lMjU3NzQ0NA==","number":24,"title":"0.20","description":"","creator":{"login":"jnothman","id":78827,"node_id":"MDQ6VXNlcjc4ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":32,"state":"open","created_at":"2017-06-12T11:07:06Z","updated_at":"2018-06-18T13:09:35Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10986/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/69da036ac60220d836bf172840edd3b8651f12e2","head":{"label":"aishgrt1:issue10836","ref":"issue10836","sha":"69da036ac60220d836bf172840edd3b8651f12e2","user":{"login":"aishgrt1","id":31906139,"node_id":"MDQ6VXNlcjMxOTA2MTM5","avatar_url":"https://avatars2.githubusercontent.com/u/31906139?v=4","gravatar_id":"","url":"https://api.github.com/users/aishgrt1","html_url":"https://github.com/aishgrt1","followers_url":"https://api.github.com/users/aishgrt1/followers","following_url":"https://api.github.com/users/aishgrt1/following{/other_user}","gists_url":"https://api.github.com/users/aishgrt1/gists{/gist_id}","starred_url":"https://api.github.com/users/aishgrt1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aishgrt1/subscriptions","organizations_url":"https://api.github.com/users/aishgrt1/orgs","repos_url":"https://api.github.com/users/aishgrt1/repos","events_url":"https://api.github.com/users/aishgrt1/events{/privacy}","received_events_url":"https://api.github.com/users/aishgrt1/received_events","type":"User","site_admin":false},"repo":{"id":129327822,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMjc4MjI=","name":"scikit-learn","full_name":"aishgrt1/scikit-learn","owner":{"login":"aishgrt1","id":31906139,"node_id":"MDQ6VXNlcjMxOTA2MTM5","avatar_url":"https://avatars2.githubusercontent.com/u/31906139?v=4","gravatar_id":"","url":"https://api.github.com/users/aishgrt1","html_url":"https://github.com/aishgrt1","followers_url":"https://api.github.com/users/aishgrt1/followers","following_url":"https://api.github.com/users/aishgrt1/following{/other_user}","gists_url":"https://api.github.com/users/aishgrt1/gists{/gist_id}","starred_url":"https://api.github.com/users/aishgrt1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aishgrt1/subscriptions","organizations_url":"https://api.github.com/users/aishgrt1/orgs","repos_url":"https://api.github.com/users/aishgrt1/repos","events_url":"https://api.github.com/users/aishgrt1/events{/privacy}","received_events_url":"https://api.github.com/users/aishgrt1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aishgrt1/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/aishgrt1/scikit-learn","forks_url":"https://api.github.com/repos/aishgrt1/scikit-learn/forks","keys_url":"https://api.github.com/repos/aishgrt1/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aishgrt1/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aishgrt1/scikit-learn/teams","hooks_url":"https://api.github.com/repos/aishgrt1/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/aishgrt1/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/aishgrt1/scikit-learn/events","assignees_url":"https://api.github.com/repos/aishgrt1/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/aishgrt1/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/aishgrt1/scikit-learn/tags","blobs_url":"https://api.github.com/repos/aishgrt1/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aishgrt1/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aishgrt1/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aishgrt1/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aishgrt1/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/aishgrt1/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/aishgrt1/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/aishgrt1/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/aishgrt1/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/aishgrt1/scikit-learn/subscription","commits_url":"https://api.github.com/repos/aishgrt1/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aishgrt1/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aishgrt1/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aishgrt1/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/aishgrt1/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/aishgrt1/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aishgrt1/scikit-learn/merges","archive_url":"https://api.github.com/repos/aishgrt1/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aishgrt1/scikit-learn/downloads","issues_url":"https://api.github.com/repos/aishgrt1/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/aishgrt1/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/aishgrt1/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/aishgrt1/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aishgrt1/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/aishgrt1/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/aishgrt1/scikit-learn/deployments","created_at":"2018-04-13T00:54:45Z","updated_at":"2018-04-13T07:22:32Z","pushed_at":"2018-06-18T02:15:41Z","git_url":"git://github.com/aishgrt1/scikit-learn.git","ssh_url":"git@github.com:aishgrt1/scikit-learn.git","clone_url":"https://github.com/aishgrt1/scikit-learn.git","svn_url":"https://github.com/aishgrt1/scikit-learn","homepage":"http://scikit-learn.org","size":101319,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"ca436e7017ae069a29de19caf71689e9b9b9c452","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-06-18T16:08:36Z","pushed_at":"2018-06-18T15:35:04Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":90861,"stargazers_count":28848,"watchers_count":28848,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14319,"mirror_url":null,"archived":false,"open_issues_count":1636,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14319,"open_issues":1636,"watchers":28848,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10986"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10986"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10986/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10986/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/69da036ac60220d836bf172840edd3b8651f12e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"glemaitre"}}