{"action":"created","issue":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/8149","repository_url":"https://api.github.com/repos/bokeh/bokeh","labels_url":"https://api.github.com/repos/bokeh/bokeh/issues/8149/labels{/name}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/8149/comments","events_url":"https://api.github.com/repos/bokeh/bokeh/issues/8149/events","html_url":"https://github.com/bokeh/bokeh/pull/8149","id":348851476,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTA1NTc5","number":8149,"title":"Added support for vertex snapping to PolyDrawTool and PolyEditTool","user":{"login":"philippjfr","id":1550771,"node_id":"MDQ6VXNlcjE1NTA3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1550771?v=4","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-08T19:00:17Z","updated_at":"2018-08-08T19:43:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/8149","html_url":"https://github.com/bokeh/bokeh/pull/8149","diff_url":"https://github.com/bokeh/bokeh/pull/8149.diff","patch_url":"https://github.com/bokeh/bokeh/pull/8149.patch"},"body":"This PR will implement vertex snapping for the PolyDrawTool and PolyEditTool (not yet implemented), allowing for more complex draw actions. Here is it in use for the PolyDrawTool:\r\n\r\n![snapping](https://user-images.githubusercontent.com/1550771/43858317-9ddd8f52-9b45-11e8-83f1-0a93ae9e1ee3.gif)\r\n \r\n- [x] issues: fixes https://github.com/bokeh/bokeh/issues/8148\r\n- [ ] tests added / passed\r\n- [ ] release document entry (if new feature or API change)\r\n"},"comment":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/comments/411528381","html_url":"https://github.com/bokeh/bokeh/pull/8149#issuecomment-411528381","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/8149","id":411528381,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTUyODM4MQ==","user":{"login":"bryevdv","id":1078448,"node_id":"MDQ6VXNlcjEwNzg0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1078448?v=4","gravatar_id":"","url":"https://api.github.com/users/bryevdv","html_url":"https://github.com/bryevdv","followers_url":"https://api.github.com/users/bryevdv/followers","following_url":"https://api.github.com/users/bryevdv/following{/other_user}","gists_url":"https://api.github.com/users/bryevdv/gists{/gist_id}","starred_url":"https://api.github.com/users/bryevdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryevdv/subscriptions","organizations_url":"https://api.github.com/users/bryevdv/orgs","repos_url":"https://api.github.com/users/bryevdv/repos","events_url":"https://api.github.com/users/bryevdv/events{/privacy}","received_events_url":"https://api.github.com/users/bryevdv/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T19:43:35Z","updated_at":"2018-08-08T19:43:35Z","author_association":"MEMBER","body":"@philippjfr I am seeing some tslint messages on the codebase build on master, I am not sure why they didn't fail the build, but can you look at cleaning them up in this PR? (some are for edit tools)\r\n\r\n```\r\n+node make scripts:compile --emit-error\r\n[19:41:03] Starting 'scripts:ts'...\r\n[19:41:24] Finished 'scripts:ts' after 20.08 s\r\n[19:41:24] Finished 'scripts:compile'\r\n+node make test:compile --emit-error\r\n[19:41:29] Starting 'test:compile'...\r\n[19:41:45] Finished 'test:compile' after 15.42 s\r\n+node make tslint\r\n[19:41:50] Starting 'tslint:lib'...\r\n[19:41:52] /home/travis/build/bokeh/bokeh/bokehjs/src/lib/models/glyphs/text.ts:29:3\r\n[19:41:52] ERROR: 29:3  return-type  expected '_rotate_point' to have an explicit return type\r\n[19:41:52] ERROR: 35:3  return-type  expected '_text_bounds' to have an explicit return type\r\n[19:41:53] /home/travis/build/bokeh/bokeh/bokehjs/src/lib/models/tools/edit/box_edit_tool.ts:160:32\r\n[19:41:53] ERROR: 160:32  trailing-comma  Missing trailing comma\r\n[19:41:54] Finished 'tslint:lib' after 3.78 s\r\n[19:41:54] Starting 'tslint:test'...\r\n[19:41:54] /home/travis/build/bokeh/bokeh/bokehjs/test/models/tools/edit/box_edit_tool.ts:242:11\r\n[19:41:54] ERROR: 242:11  prefer-const  Identifier 'drag_event' is never reassigned; use 'const' instead of 'let'.\r\n[19:41:54] /home/travis/build/bokeh/bokeh/bokehjs/test/models/tools/edit/poly_draw_tool.ts:265:11\r\n[19:41:54] ERROR: 265:11  prefer-const  Identifier 'drag_event' is never reassigned; use 'const' instead of 'let'.\r\n[19:41:54] Finished 'tslint:test' after 509 ms\r\n[19:41:54] Starting 'tslint:examples'...\r\n[19:41:54] Finished 'tslint:examples' after 80 ms\r\n[19:41:54] Finished 'tslint'\r\n```"}}
{"actor":{"display_login":"bryevdv"}}