{"action":"created","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/6566","repository_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/6566/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/6566/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/6566/events","html_url":"https://github.com/Semantic-Org/Semantic-UI/pull/6566","id":357385088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDEzODg5","number":6566,"title":"[Dependencies] [Security] Upgrade to Gulp4","user":{"login":"acconrad","id":422184,"node_id":"MDQ6VXNlcjQyMjE4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/422184?v=4","gravatar_id":"","url":"https://api.github.com/users/acconrad","html_url":"https://github.com/acconrad","followers_url":"https://api.github.com/users/acconrad/followers","following_url":"https://api.github.com/users/acconrad/following{/other_user}","gists_url":"https://api.github.com/users/acconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/acconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acconrad/subscriptions","organizations_url":"https://api.github.com/users/acconrad/orgs","repos_url":"https://api.github.com/users/acconrad/repos","events_url":"https://api.github.com/users/acconrad/events{/privacy}","received_events_url":"https://api.github.com/users/acconrad/received_events","type":"User","site_admin":false},"labels":[{"id":153535157,"node_id":"MDU6TGFiZWwxNTM1MzUxNTc=","url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/labels/Evaluating%20Bug%20/%20Change","name":"Evaluating Bug / Change","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":{"login":"jlukic","id":23123,"node_id":"MDQ6VXNlcjIzMTIz","avatar_url":"https://avatars0.githubusercontent.com/u/23123?v=4","gravatar_id":"","url":"https://api.github.com/users/jlukic","html_url":"https://github.com/jlukic","followers_url":"https://api.github.com/users/jlukic/followers","following_url":"https://api.github.com/users/jlukic/following{/other_user}","gists_url":"https://api.github.com/users/jlukic/gists{/gist_id}","starred_url":"https://api.github.com/users/jlukic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlukic/subscriptions","organizations_url":"https://api.github.com/users/jlukic/orgs","repos_url":"https://api.github.com/users/jlukic/repos","events_url":"https://api.github.com/users/jlukic/events{/privacy}","received_events_url":"https://api.github.com/users/jlukic/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlukic","id":23123,"node_id":"MDQ6VXNlcjIzMTIz","avatar_url":"https://avatars0.githubusercontent.com/u/23123?v=4","gravatar_id":"","url":"https://api.github.com/users/jlukic","html_url":"https://github.com/jlukic","followers_url":"https://api.github.com/users/jlukic/followers","following_url":"https://api.github.com/users/jlukic/following{/other_user}","gists_url":"https://api.github.com/users/jlukic/gists{/gist_id}","starred_url":"https://api.github.com/users/jlukic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlukic/subscriptions","organizations_url":"https://api.github.com/users/jlukic/orgs","repos_url":"https://api.github.com/users/jlukic/repos","events_url":"https://api.github.com/users/jlukic/events{/privacy}","received_events_url":"https://api.github.com/users/jlukic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2018-09-05T20:13:09Z","updated_at":"2018-11-11T23:34:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/pulls/6566","html_url":"https://github.com/Semantic-Org/Semantic-UI/pull/6566","diff_url":"https://github.com/Semantic-Org/Semantic-UI/pull/6566.diff","patch_url":"https://github.com/Semantic-Org/Semantic-UI/pull/6566.patch"},"body":"This fixes multiple bugs (#6549 #5762 #6214 ) and implements #3793 by upgrading from Gulp `3.9.1` to `4.0.0` which was released a few months ago.\r\n\r\nThe primary goal of this is to incorporate a series of vulnerability fixes (`minimatch`, `hoek`, and `lodash`) that were introduced within the dependencies of `gulp`, and as a result were patched starting in Gulp v4.\r\n\r\nThe basic upgrade flow works like this:\r\n\r\n1. Upgrade Gulp from `3.9.1` to `4.0.0`\r\n2. Upgrade `gulp-help` to the version that specifically supports Gulp4 (`1.6.1` to `chmontgomery/gulp-help#gulp4`)\r\n3. Upgrade additional dependencies that fix additional audit issues (`gulp-concat-css`, `gulp-copy`, `gulp-less`, `gulp-watch`, and `github`)\r\n4. Remove `run-sequence` which is now deprecated and natively replaced with [`gulp.series`](https://github.com/gulpjs/gulp/blob/4.0/docs/API.md#gulpseriestasks)\r\n5. Fix `calc()` errors that arose out of interpolated strings with the latest version of `gulp-less`\r\n\r\nWith those tasks complete, `npm install` works and completes as intended with no errors and 0 security vulnerabilities."},"comment":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/comments/437715992","html_url":"https://github.com/Semantic-Org/Semantic-UI/pull/6566#issuecomment-437715992","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/6566","id":437715992,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzcxNTk5Mg==","user":{"login":"pgobin","id":998044,"node_id":"MDQ6VXNlcjk5ODA0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/998044?v=4","gravatar_id":"","url":"https://api.github.com/users/pgobin","html_url":"https://github.com/pgobin","followers_url":"https://api.github.com/users/pgobin/followers","following_url":"https://api.github.com/users/pgobin/following{/other_user}","gists_url":"https://api.github.com/users/pgobin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgobin/subscriptions","organizations_url":"https://api.github.com/users/pgobin/orgs","repos_url":"https://api.github.com/users/pgobin/repos","events_url":"https://api.github.com/users/pgobin/events{/privacy}","received_events_url":"https://api.github.com/users/pgobin/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T23:34:25Z","updated_at":"2018-11-11T23:34:25Z","author_association":"NONE","body":"@acconrad Have you noticed `file.path` no longer exists in `watch.js`?\r\n\r\nFrom `watch.js`:\r\n\r\n```\r\ngulp\r\n    .watch([\r\n      source.config,\r\n      source.definitions   + '/**/*.less',\r\n      source.site          + '/**/*.{overrides,variables}',\r\n      source.themes        + '/**/*.{overrides,variables}'\r\n    ], function(file) {\r\n\r\n    ...\r\n\r\n    gulp.src(file.path)\r\n              ^\r\n    ...\r\n```\r\n\r\nFor me, `gulp watch` outputs an `undefined` exception after editing `.less` or an override.\r\n\r\nIf it indeed does, a solution might look something like the following:\r\n\r\n```\r\n  const cssWatcher = gulp.watch([\r\n    source.config,\r\n    source.definitions   + '/**/*.less',\r\n    source.site          + '/**/*.{overrides,variables}',\r\n    source.themes        + '/**/*.{overrides,variables}'\r\n  ]);\r\n\r\n  cssWatcher.on('change', (path) => {\r\n\r\n    ...\r\n\r\n    gulp.src(path)\r\n\r\n    ...\r\n\r\n```\r\nFor the CSS watch and the remaining watches also.\r\n"}}
{"actor":{"display_login":"pgobin"}}