{"action":"closed","number":2524,"pull_request":{"url":"https://api.github.com/repos/processing/p5.js/pulls/2524","id":162004788,"html_url":"https://github.com/processing/p5.js/pull/2524","diff_url":"https://github.com/processing/p5.js/pull/2524.diff","patch_url":"https://github.com/processing/p5.js/pull/2524.patch","issue_url":"https://api.github.com/repos/processing/p5.js/issues/2524","number":2524,"state":"closed","locked":false,"title":"p5.Matrix - rework/updated/fixed/...","user":{"login":"diwi","id":743399,"avatar_url":"https://avatars1.githubusercontent.com/u/743399?v=4","gravatar_id":"","url":"https://api.github.com/users/diwi","html_url":"https://github.com/diwi","followers_url":"https://api.github.com/users/diwi/followers","following_url":"https://api.github.com/users/diwi/following{/other_user}","gists_url":"https://api.github.com/users/diwi/gists{/gist_id}","starred_url":"https://api.github.com/users/diwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diwi/subscriptions","organizations_url":"https://api.github.com/users/diwi/orgs","repos_url":"https://api.github.com/users/diwi/repos","events_url":"https://api.github.com/users/diwi/events{/privacy}","received_events_url":"https://api.github.com/users/diwi/received_events","type":"User","site_admin":false},"body":"This PR is around quite a bit of re-implemented/new-implemented matrix functions.\r\n\r\nIt takes care to get same results/behaviour/usage, as with the original Processing PMatrix3D. Also, it doesnt break any existing functionality.\r\n\r\nAltough I labeled some of the 3x3-methods deprecated since the new updated methods handle both mat3 and mat4. In general, It's probably worth discussing a clearer separation between mat3 and mat4, e.g. not merging both into just one class.\r\n\r\nHere is a quick Overview:\r\n\r\n```\r\nidentity()\r\ncopy()\r\nset()\r\nsetColumn(col, vsrc)\r\nsetRow(row, vsrc)\r\ngetArray()\r\nisMat3()\r\nisMat4 ()\r\n\r\nmultVec(vsrc, vdst)\r\nmult(mright, mdst)\r\npremult(mleft)\r\n\r\nrotateX(angle)\r\nrotateY (angle)\r\nrotateZ(angle)\r\nrotate(angle, axis)\r\nscale(vsrc)\r\nshearX(angle)\r\nshearY(angle)\r\ntranslate(vsrc)\r\n\r\ndeterminant()\r\ninvert(msrc, mdst)\r\ntranspose(msrc, mdst)\r\ninverseTranspose (msrc)\r\n\r\ninvert3x3(msrc) // deprecated\r\ntranspose3x3(msrc) // deprecated\r\n\r\nfrustum(left, right, bottom, top, near, far)\r\northo(left, right, bottom, top, near, far)\r\nperspective(fovy, aspect, near, far)\r\n\r\ntoString()\r\nprint()\r\n\r\nassertAngleMode(angle) // angle degree or radians\r\n```\r\n\r\n\r\n\r\n\r\n","created_at":"2018-01-09T23:48:03Z","updated_at":"2018-02-12T17:27:32Z","closed_at":"2018-02-12T17:27:32Z","merged_at":null,"merge_commit_sha":"1ba874d8815a07de1288fa876d98c982562eeea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":218243056,"url":"https://api.github.com/repos/processing/p5.js/labels/area:webgl","name":"area:webgl","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/processing/p5.js/pulls/2524/commits","review_comments_url":"https://api.github.com/repos/processing/p5.js/pulls/2524/comments","review_comment_url":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/processing/p5.js/issues/2524/comments","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/a7a5b6616f85993b8d1ccfbb446b408132251902","head":{"label":"diwi:p5.Matrix-work","ref":"p5.Matrix-work","sha":"a7a5b6616f85993b8d1ccfbb446b408132251902","user":{"login":"diwi","id":743399,"avatar_url":"https://avatars1.githubusercontent.com/u/743399?v=4","gravatar_id":"","url":"https://api.github.com/users/diwi","html_url":"https://github.com/diwi","followers_url":"https://api.github.com/users/diwi/followers","following_url":"https://api.github.com/users/diwi/following{/other_user}","gists_url":"https://api.github.com/users/diwi/gists{/gist_id}","starred_url":"https://api.github.com/users/diwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diwi/subscriptions","organizations_url":"https://api.github.com/users/diwi/orgs","repos_url":"https://api.github.com/users/diwi/repos","events_url":"https://api.github.com/users/diwi/events{/privacy}","received_events_url":"https://api.github.com/users/diwi/received_events","type":"User","site_admin":false},"repo":{"id":116880477,"name":"p5.js","full_name":"diwi/p5.js","owner":{"login":"diwi","id":743399,"avatar_url":"https://avatars1.githubusercontent.com/u/743399?v=4","gravatar_id":"","url":"https://api.github.com/users/diwi","html_url":"https://github.com/diwi","followers_url":"https://api.github.com/users/diwi/followers","following_url":"https://api.github.com/users/diwi/following{/other_user}","gists_url":"https://api.github.com/users/diwi/gists{/gist_id}","starred_url":"https://api.github.com/users/diwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diwi/subscriptions","organizations_url":"https://api.github.com/users/diwi/orgs","repos_url":"https://api.github.com/users/diwi/repos","events_url":"https://api.github.com/users/diwi/events{/privacy}","received_events_url":"https://api.github.com/users/diwi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diwi/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":true,"url":"https://api.github.com/repos/diwi/p5.js","forks_url":"https://api.github.com/repos/diwi/p5.js/forks","keys_url":"https://api.github.com/repos/diwi/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diwi/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diwi/p5.js/teams","hooks_url":"https://api.github.com/repos/diwi/p5.js/hooks","issue_events_url":"https://api.github.com/repos/diwi/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/diwi/p5.js/events","assignees_url":"https://api.github.com/repos/diwi/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/diwi/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/diwi/p5.js/tags","blobs_url":"https://api.github.com/repos/diwi/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diwi/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diwi/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/diwi/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diwi/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/diwi/p5.js/languages","stargazers_url":"https://api.github.com/repos/diwi/p5.js/stargazers","contributors_url":"https://api.github.com/repos/diwi/p5.js/contributors","subscribers_url":"https://api.github.com/repos/diwi/p5.js/subscribers","subscription_url":"https://api.github.com/repos/diwi/p5.js/subscription","commits_url":"https://api.github.com/repos/diwi/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/diwi/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/diwi/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/diwi/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/diwi/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/diwi/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diwi/p5.js/merges","archive_url":"https://api.github.com/repos/diwi/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diwi/p5.js/downloads","issues_url":"https://api.github.com/repos/diwi/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/diwi/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/diwi/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/diwi/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diwi/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/diwi/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/diwi/p5.js/deployments","created_at":"2018-01-09T22:59:44Z","updated_at":"2018-01-09T22:59:47Z","pushed_at":"2018-01-13T15:24:52Z","git_url":"git://github.com/diwi/p5.js.git","ssh_url":"git@github.com:diwi/p5.js.git","clone_url":"https://github.com/diwi/p5.js.git","svn_url":"https://github.com/diwi/p5.js","homepage":"http://p5js.org/","size":64101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"processing:master","ref":"master","sha":"af80bda2bab615175d717f8cc969434e55ae38da","user":{"login":"processing","id":1617169,"avatar_url":"https://avatars2.githubusercontent.com/u/1617169?v=4","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"repo":{"id":8424040,"name":"p5.js","full_name":"processing/p5.js","owner":{"login":"processing","id":1617169,"avatar_url":"https://avatars2.githubusercontent.com/u/1617169?v=4","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/processing/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":false,"url":"https://api.github.com/repos/processing/p5.js","forks_url":"https://api.github.com/repos/processing/p5.js/forks","keys_url":"https://api.github.com/repos/processing/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/processing/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/processing/p5.js/teams","hooks_url":"https://api.github.com/repos/processing/p5.js/hooks","issue_events_url":"https://api.github.com/repos/processing/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/processing/p5.js/events","assignees_url":"https://api.github.com/repos/processing/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/processing/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/processing/p5.js/tags","blobs_url":"https://api.github.com/repos/processing/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/processing/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/processing/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/processing/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/processing/p5.js/languages","stargazers_url":"https://api.github.com/repos/processing/p5.js/stargazers","contributors_url":"https://api.github.com/repos/processing/p5.js/contributors","subscribers_url":"https://api.github.com/repos/processing/p5.js/subscribers","subscription_url":"https://api.github.com/repos/processing/p5.js/subscription","commits_url":"https://api.github.com/repos/processing/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/processing/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/processing/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/processing/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/processing/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/processing/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/processing/p5.js/merges","archive_url":"https://api.github.com/repos/processing/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/processing/p5.js/downloads","issues_url":"https://api.github.com/repos/processing/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/processing/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/processing/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/processing/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/processing/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/processing/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/processing/p5.js/deployments","created_at":"2013-02-26T03:14:47Z","updated_at":"2018-02-12T14:15:28Z","pushed_at":"2018-02-12T03:45:16Z","git_url":"git://github.com/processing/p5.js.git","ssh_url":"git@github.com:processing/p5.js.git","clone_url":"https://github.com/processing/p5.js.git","svn_url":"https://github.com/processing/p5.js","homepage":"http://p5js.org/","size":65427,"stargazers_count":7382,"watchers_count":7382,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1076,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1076,"open_issues":81,"watchers":7382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2524"},"html":{"href":"https://github.com/processing/p5.js/pull/2524"},"issue":{"href":"https://api.github.com/repos/processing/p5.js/issues/2524"},"comments":{"href":"https://api.github.com/repos/processing/p5.js/issues/2524/comments"},"review_comments":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2524/comments"},"review_comment":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2524/commits"},"statuses":{"href":"https://api.github.com/repos/processing/p5.js/statuses/a7a5b6616f85993b8d1ccfbb446b408132251902"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":14,"maintainer_can_modify":false,"commits":14,"additions":1381,"deletions":1534,"changed_files":8}}
{"actor":{"display_login":"lmccart"}}