{"action":"created","comment":{"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments/199442757","pull_request_review_id":133560640,"id":199442757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQ0Mjc1Nw==","diff_hunk":"@@ -93,6 +93,35 @@ <h3 style=\"margin: 0;\">[[ title ]]</h3>\n \t\t\t\treturn new Intl.NumberFormat(locale || undefined, options);\n \t\t\t},\n \n+\t\t\t/**\n+\t\t\t *   Get the comparable value of an item.\n+\t\t\t *\n+\t\t\t * @param  {Object} item       Item to be processed\n+\t\t\t * @param  {String} valuePath  Property path\n+\t\t\t * @returns {Number|void}      Valid value or void\n+\t\t\t */\n+\t\t\tgetComparableValue(item, valuePath) {\n+\t\t\t\tif (item == null) {\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\t\t\t\tlet value = item;\n+\t\t\t\tif (valuePath != null) {\n+\t\t\t\t\tvalue = this.get(valuePath, item);\n+\t\t\t\t}\n+\t\t\t\tvalue = this.toValue(value);\n+\t\t\t\tif (value == null) {\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\n+\t\t\t\tconst decimals = this.minimumFractionDigits;","path":"cosmoz-omnitable-column-number.html","position":24,"original_position":24,"commit_id":"137c4daa2c3058be6e9a18df176b69f84c30d692","original_commit_id":"137c4daa2c3058be6e9a18df176b69f84c30d692","user":{"login":"nomego","id":960553,"node_id":"MDQ6VXNlcjk2MDU1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/960553?v=4","gravatar_id":"","url":"https://api.github.com/users/nomego","html_url":"https://github.com/nomego","followers_url":"https://api.github.com/users/nomego/followers","following_url":"https://api.github.com/users/nomego/following{/other_user}","gists_url":"https://api.github.com/users/nomego/gists{/gist_id}","starred_url":"https://api.github.com/users/nomego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomego/subscriptions","organizations_url":"https://api.github.com/users/nomego/orgs","repos_url":"https://api.github.com/users/nomego/repos","events_url":"https://api.github.com/users/nomego/events{/privacy}","received_events_url":"https://api.github.com/users/nomego/received_events","type":"User","site_admin":false},"body":"This should be `maximumFractionDigits` ? (We need min/max fraction tests obviously)\r\nWhy do we need the pow/parseInt? Aren't we passed this JS float stuff with .toFixed()? :)","created_at":"2018-07-02T09:52:52Z","updated_at":"2018-07-02T09:52:56Z","html_url":"https://github.com/Neovici/cosmoz-omnitable/pull/192#discussion_r199442757","pull_request_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments/199442757"},"html":{"href":"https://github.com/Neovici/cosmoz-omnitable/pull/192#discussion_r199442757"},"pull_request":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192","id":196100397,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTAwMzk3","html_url":"https://github.com/Neovici/cosmoz-omnitable/pull/192","diff_url":"https://github.com/Neovici/cosmoz-omnitable/pull/192.diff","patch_url":"https://github.com/Neovici/cosmoz-omnitable/pull/192.patch","issue_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/192","number":192,"state":"open","locked":false,"title":"getComparableValue with minimumFractionDigits","user":{"login":"programmer4web","id":6841184,"node_id":"MDQ6VXNlcjY4NDExODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6841184?v=4","gravatar_id":"","url":"https://api.github.com/users/programmer4web","html_url":"https://github.com/programmer4web","followers_url":"https://api.github.com/users/programmer4web/followers","following_url":"https://api.github.com/users/programmer4web/following{/other_user}","gists_url":"https://api.github.com/users/programmer4web/gists{/gist_id}","starred_url":"https://api.github.com/users/programmer4web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programmer4web/subscriptions","organizations_url":"https://api.github.com/users/programmer4web/orgs","repos_url":"https://api.github.com/users/programmer4web/repos","events_url":"https://api.github.com/users/programmer4web/events{/privacy}","received_events_url":"https://api.github.com/users/programmer4web/received_events","type":"User","site_admin":false},"body":"fixes: #176\r\n\r\nTest: item with age: 46.768 and amount: 2581 should be in the filtered items when filtering from 46.76 to 46.76\r\nIn cosmoz-omnitable-column-number.html added getComparableValue and added the check for minimumFractionDigits. Value is truncated to the specified decimals (2 in the test).","created_at":"2018-06-20T11:03:32Z","updated_at":"2018-07-02T09:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1e5a1f26b5da553ceb9c0672fec47c70cdb8225","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192/commits","review_comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192/comments","review_comment_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/192/comments","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/137c4daa2c3058be6e9a18df176b69f84c30d692","head":{"label":"plumelo:feature/NEOV-239-filtering-with-decimals","ref":"feature/NEOV-239-filtering-with-decimals","sha":"137c4daa2c3058be6e9a18df176b69f84c30d692","user":{"login":"plumelo","id":15955263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTU1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/15955263?v=4","gravatar_id":"","url":"https://api.github.com/users/plumelo","html_url":"https://github.com/plumelo","followers_url":"https://api.github.com/users/plumelo/followers","following_url":"https://api.github.com/users/plumelo/following{/other_user}","gists_url":"https://api.github.com/users/plumelo/gists{/gist_id}","starred_url":"https://api.github.com/users/plumelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumelo/subscriptions","organizations_url":"https://api.github.com/users/plumelo/orgs","repos_url":"https://api.github.com/users/plumelo/repos","events_url":"https://api.github.com/users/plumelo/events{/privacy}","received_events_url":"https://api.github.com/users/plumelo/received_events","type":"Organization","site_admin":false},"repo":{"id":107093066,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwOTMwNjY=","name":"cosmoz-omnitable","full_name":"plumelo/cosmoz-omnitable","owner":{"login":"plumelo","id":15955263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTU1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/15955263?v=4","gravatar_id":"","url":"https://api.github.com/users/plumelo","html_url":"https://github.com/plumelo","followers_url":"https://api.github.com/users/plumelo/followers","following_url":"https://api.github.com/users/plumelo/following{/other_user}","gists_url":"https://api.github.com/users/plumelo/gists{/gist_id}","starred_url":"https://api.github.com/users/plumelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumelo/subscriptions","organizations_url":"https://api.github.com/users/plumelo/orgs","repos_url":"https://api.github.com/users/plumelo/repos","events_url":"https://api.github.com/users/plumelo/events{/privacy}","received_events_url":"https://api.github.com/users/plumelo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plumelo/cosmoz-omnitable","description":"The Cosmoz Omnitable","fork":true,"url":"https://api.github.com/repos/plumelo/cosmoz-omnitable","forks_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/forks","keys_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/teams","hooks_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/hooks","issue_events_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues/events{/number}","events_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/events","assignees_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/assignees{/user}","branches_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/branches{/branch}","tags_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/tags","blobs_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/refs{/sha}","trees_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/statuses/{sha}","languages_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/languages","stargazers_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/stargazers","contributors_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/contributors","subscribers_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/subscribers","subscription_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/subscription","commits_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/commits{/sha}","git_commits_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/commits{/sha}","comments_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/comments{/number}","issue_comment_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues/comments{/number}","contents_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/contents/{+path}","compare_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/merges","archive_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/downloads","issues_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues{/number}","pulls_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/pulls{/number}","milestones_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/milestones{/number}","notifications_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/labels{/name}","releases_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/releases{/id}","deployments_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/deployments","created_at":"2017-10-16T07:31:26Z","updated_at":"2018-06-27T10:06:36Z","pushed_at":"2018-07-02T09:24:26Z","git_url":"git://github.com/plumelo/cosmoz-omnitable.git","ssh_url":"git@github.com:plumelo/cosmoz-omnitable.git","clone_url":"https://github.com/plumelo/cosmoz-omnitable.git","svn_url":"https://github.com/plumelo/cosmoz-omnitable","homepage":null,"size":4892,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Neovici:master","ref":"master","sha":"c9b8df02367cbd7a6685df22d973c0943ed4eef4","user":{"login":"Neovici","id":10965763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY1NzYz","avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"repo":{"id":45485652,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ4NTY1Mg==","name":"cosmoz-omnitable","full_name":"Neovici/cosmoz-omnitable","owner":{"login":"Neovici","id":10965763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY1NzYz","avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neovici/cosmoz-omnitable","description":"The Cosmoz Omnitable.","fork":false,"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable","forks_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/forks","keys_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/teams","hooks_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/hooks","issue_events_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/events{/number}","events_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/events","assignees_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/assignees{/user}","branches_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/branches{/branch}","tags_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/tags","blobs_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/{sha}","languages_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/languages","stargazers_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/stargazers","contributors_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/contributors","subscribers_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/subscribers","subscription_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/subscription","commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/contents/{+path}","compare_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/merges","archive_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/downloads","issues_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues{/number}","pulls_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls{/number}","milestones_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/milestones{/number}","notifications_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/labels{/name}","releases_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/releases{/id}","deployments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/deployments","created_at":"2015-11-03T18:08:36Z","updated_at":"2018-06-27T09:35:45Z","pushed_at":"2018-07-02T09:24:27Z","git_url":"git://github.com/Neovici/cosmoz-omnitable.git","ssh_url":"git@github.com:Neovici/cosmoz-omnitable.git","clone_url":"https://github.com/Neovici/cosmoz-omnitable.git","svn_url":"https://github.com/Neovici/cosmoz-omnitable","homepage":"","size":4806,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":30,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192"},"html":{"href":"https://github.com/Neovici/cosmoz-omnitable/pull/192"},"issue":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/192"},"comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/137c4daa2c3058be6e9a18df176b69f84c30d692"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nomego"}}