{"action":"created","issue":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/707","repository_url":"https://api.github.com/repos/react-native-community/react-native-video","labels_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/707/labels{/name}","comments_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/707/comments","events_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/707/events","html_url":"https://github.com/react-native-community/react-native-video/pull/707","id":245430190,"number":707,"title":"Feat/ontimedmetadata android","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars0.githubusercontent.com/u/781745?v=4","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-07-25T14:57:03Z","updated_at":"2018-05-17T13:17:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/react-native-community/react-native-video/pulls/707","html_url":"https://github.com/react-native-community/react-native-video/pull/707","diff_url":"https://github.com/react-native-community/react-native-video/pull/707.diff","patch_url":"https://github.com/react-native-community/react-native-video/pull/707.patch"},"body":"This PR adds support for getting the id3 tag (currently support for the single timecode) in android. I have tested it and it functions identical to the other platforms in the projects.\r\n\r\n### Notes\r\n\r\n* Don't merge yet. The min sdk version now is 23. I have to make this optional first, otherwise this is a BC break.\r\n* Any pointers on getting the tags in a \"prettier\" manner than this are welcome. I've spent a full working day on google trying to find a solution that's prettier, and all of them were worse than this one, which is more elegant in terms of performance and readability.\r\n\r\nI'll be forking this module, with this PR merged as I can't wait for your feedback right now. I'll try to keep submitting PRs as long as I don't stray from the current codebase too far."},"comment":{"url":"https://api.github.com/repos/react-native-community/react-native-video/issues/comments/389862729","html_url":"https://github.com/react-native-community/react-native-video/pull/707#issuecomment-389862729","issue_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/707","id":389862729,"user":{"login":"Ziv-Barber","id":3667761,"avatar_url":"https://avatars1.githubusercontent.com/u/3667761?v=4","gravatar_id":"","url":"https://api.github.com/users/Ziv-Barber","html_url":"https://github.com/Ziv-Barber","followers_url":"https://api.github.com/users/Ziv-Barber/followers","following_url":"https://api.github.com/users/Ziv-Barber/following{/other_user}","gists_url":"https://api.github.com/users/Ziv-Barber/gists{/gist_id}","starred_url":"https://api.github.com/users/Ziv-Barber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ziv-Barber/subscriptions","organizations_url":"https://api.github.com/users/Ziv-Barber/orgs","repos_url":"https://api.github.com/users/Ziv-Barber/repos","events_url":"https://api.github.com/users/Ziv-Barber/events{/privacy}","received_events_url":"https://api.github.com/users/Ziv-Barber/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T13:17:33Z","updated_at":"2018-05-17T13:17:33Z","author_association":"NONE","body":"Not working. I'm not getting any metadata in the ontimedmetadata callback.\r\nBut I may not know how to update the code to include this patch.\r\nWhat I did (all guessing since there's no documentation anywhere):\r\nI forked the plugin.\r\nI exported the patch diff using the undocumented .diff url of github.\r\ngit clone ...\r\ngit apply ... (the diff file)\r\ngit add -A\r\ngit commit ...\r\ngit push ...\r\nNow I have patched fork.\r\nI removed node_modules, yarn.lock and I removed react-native-video from package.json\r\nthen I yarn add git+https://github.com/---my clone---.git\r\nthen I tried to react-native link - it do noting so I just tried maybe there's unlink or something.\r\nIt turned out that there's an undocumented unlink command, did that and then link again.\r\nNow after all of this I tried to send metadata and console.log it in ontimedmetadata - noting :(\r\nI guess that I did something wrong when trying to patch the code."}}
{"actor":{"display_login":"Ziv-Barber"}}