{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-management/pulls/comments/197207448","pull_request_review_id":130821696,"id":197207448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzIwNzQ0OA==","diff_hunk":"@@ -521,6 +569,53 @@ Notes:\n \n * If Akka management port tag is not found on service in Consul the implementation defaults to catalog service port.\n \n+## Discovery Method: Aggregate multiple discovery mechanisms\n+\n+Aggregate discovery allows multiple discovery mechanisms to be aggregated e.g. try and resolve\n+via DNS and fall back to configuration.\n+\n+To use aggregate discovery add its dependency as well as all of the discovery mechanisms that you \n+want to aggregate.\n+\n+@@dependency[sbt,Gradle,Maven] {\n+  group=\"com.lightbend.akka.discovery\"\n+  artifact=\"akka-discovery-aggregate_2.12\"\n+  version=\"$version$\"\n+}\n+\n+Configure `akka-aggregate` as `akka.discovery.method` and which discovery mechanisms are tried and in which order.\n+\n+```\n+akka {\n+  discovery {\n+    method = akka-aggregate","path":"docs/src/main/paradox/discovery.md","position":78,"original_position":78,"commit_id":"a0b4145c7f24c46d672c9062b5cc814f27b9ae7d","original_commit_id":"a0b4145c7f24c46d672c9062b5cc814f27b9ae7d","user":{"login":"ktoso","id":120979,"node_id":"MDQ6VXNlcjEyMDk3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/120979?v=4","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"not sure why \"akka\"","created_at":"2018-06-21T17:00:17Z","updated_at":"2018-06-21T17:01:54Z","html_url":"https://github.com/akka/akka-management/pull/218#discussion_r197207448","pull_request_url":"https://api.github.com/repos/akka/akka-management/pulls/218","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-management/pulls/comments/197207448"},"html":{"href":"https://github.com/akka/akka-management/pull/218#discussion_r197207448"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-management/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka-management/pulls/218","id":196358019,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzU4MDE5","html_url":"https://github.com/akka/akka-management/pull/218","diff_url":"https://github.com/akka/akka-management/pull/218.diff","patch_url":"https://github.com/akka/akka-management/pull/218.patch","issue_url":"https://api.github.com/repos/akka/akka-management/issues/218","number":218,"state":"open","locked":false,"title":"Aggregate and config discovery","user":{"login":"chbatey","id":1866779,"node_id":"MDQ6VXNlcjE4NjY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"body":"Refs #176 and #166 \r\n\r\nThis adds a config and aggregate discovery. I haven't updated it to the default yet.","created_at":"2018-06-21T07:23:35Z","updated_at":"2018-06-21T17:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb70ff115f3770e4474284975a949c1037622d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TimMoore","id":44385,"node_id":"MDQ6VXNlcjQ0Mzg1","avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-management/pulls/218/commits","review_comments_url":"https://api.github.com/repos/akka/akka-management/pulls/218/comments","review_comment_url":"https://api.github.com/repos/akka/akka-management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-management/issues/218/comments","statuses_url":"https://api.github.com/repos/akka/akka-management/statuses/a0b4145c7f24c46d672c9062b5cc814f27b9ae7d","head":{"label":"chbatey:config-discovery","ref":"config-discovery","sha":"a0b4145c7f24c46d672c9062b5cc814f27b9ae7d","user":{"login":"chbatey","id":1866779,"node_id":"MDQ6VXNlcjE4NjY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"repo":{"id":106300311,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMDAzMTE=","name":"akka-management","full_name":"chbatey/akka-management","owner":{"login":"chbatey","id":1866779,"node_id":"MDQ6VXNlcjE4NjY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1866779?v=4","gravatar_id":"","url":"https://api.github.com/users/chbatey","html_url":"https://github.com/chbatey","followers_url":"https://api.github.com/users/chbatey/followers","following_url":"https://api.github.com/users/chbatey/following{/other_user}","gists_url":"https://api.github.com/users/chbatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chbatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chbatey/subscriptions","organizations_url":"https://api.github.com/users/chbatey/orgs","repos_url":"https://api.github.com/users/chbatey/repos","events_url":"https://api.github.com/users/chbatey/events{/privacy}","received_events_url":"https://api.github.com/users/chbatey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chbatey/akka-management","description":null,"fork":true,"url":"https://api.github.com/repos/chbatey/akka-management","forks_url":"https://api.github.com/repos/chbatey/akka-management/forks","keys_url":"https://api.github.com/repos/chbatey/akka-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chbatey/akka-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chbatey/akka-management/teams","hooks_url":"https://api.github.com/repos/chbatey/akka-management/hooks","issue_events_url":"https://api.github.com/repos/chbatey/akka-management/issues/events{/number}","events_url":"https://api.github.com/repos/chbatey/akka-management/events","assignees_url":"https://api.github.com/repos/chbatey/akka-management/assignees{/user}","branches_url":"https://api.github.com/repos/chbatey/akka-management/branches{/branch}","tags_url":"https://api.github.com/repos/chbatey/akka-management/tags","blobs_url":"https://api.github.com/repos/chbatey/akka-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chbatey/akka-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chbatey/akka-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/chbatey/akka-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chbatey/akka-management/statuses/{sha}","languages_url":"https://api.github.com/repos/chbatey/akka-management/languages","stargazers_url":"https://api.github.com/repos/chbatey/akka-management/stargazers","contributors_url":"https://api.github.com/repos/chbatey/akka-management/contributors","subscribers_url":"https://api.github.com/repos/chbatey/akka-management/subscribers","subscription_url":"https://api.github.com/repos/chbatey/akka-management/subscription","commits_url":"https://api.github.com/repos/chbatey/akka-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/chbatey/akka-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/chbatey/akka-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/chbatey/akka-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/chbatey/akka-management/contents/{+path}","compare_url":"https://api.github.com/repos/chbatey/akka-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chbatey/akka-management/merges","archive_url":"https://api.github.com/repos/chbatey/akka-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chbatey/akka-management/downloads","issues_url":"https://api.github.com/repos/chbatey/akka-management/issues{/number}","pulls_url":"https://api.github.com/repos/chbatey/akka-management/pulls{/number}","milestones_url":"https://api.github.com/repos/chbatey/akka-management/milestones{/number}","notifications_url":"https://api.github.com/repos/chbatey/akka-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chbatey/akka-management/labels{/name}","releases_url":"https://api.github.com/repos/chbatey/akka-management/releases{/id}","deployments_url":"https://api.github.com/repos/chbatey/akka-management/deployments","created_at":"2017-10-09T15:18:30Z","updated_at":"2018-06-19T06:09:09Z","pushed_at":"2018-06-21T07:44:29Z","git_url":"git://github.com/chbatey/akka-management.git","ssh_url":"git@github.com:chbatey/akka-management.git","clone_url":"https://github.com/chbatey/akka-management.git","svn_url":"https://github.com/chbatey/akka-management","homepage":"http://developer.lightbend.com/docs/akka-management/current/","size":15052,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"a9dc3ab146c8fb34210ba455ab20cd33776f4f50","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":73269683,"node_id":"MDEwOlJlcG9zaXRvcnk3MzI2OTY4Mw==","name":"akka-management","full_name":"akka/akka-management","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-management","description":null,"fork":false,"url":"https://api.github.com/repos/akka/akka-management","forks_url":"https://api.github.com/repos/akka/akka-management/forks","keys_url":"https://api.github.com/repos/akka/akka-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-management/teams","hooks_url":"https://api.github.com/repos/akka/akka-management/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-management/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-management/events","assignees_url":"https://api.github.com/repos/akka/akka-management/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-management/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-management/tags","blobs_url":"https://api.github.com/repos/akka/akka-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-management/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-management/languages","stargazers_url":"https://api.github.com/repos/akka/akka-management/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-management/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-management/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-management/subscription","commits_url":"https://api.github.com/repos/akka/akka-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-management/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-management/merges","archive_url":"https://api.github.com/repos/akka/akka-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-management/downloads","issues_url":"https://api.github.com/repos/akka/akka-management/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-management/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-management/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-management/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-management/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-management/deployments","created_at":"2016-11-09T09:33:12Z","updated_at":"2018-06-21T10:53:13Z","pushed_at":"2018-06-21T07:44:30Z","git_url":"git://github.com/akka/akka-management.git","ssh_url":"git@github.com:akka/akka-management.git","clone_url":"https://github.com/akka/akka-management.git","svn_url":"https://github.com/akka/akka-management","homepage":"http://developer.lightbend.com/docs/akka-management/current/","size":15108,"stargazers_count":91,"watchers_count":91,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":44,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-management/pulls/218"},"html":{"href":"https://github.com/akka/akka-management/pull/218"},"issue":{"href":"https://api.github.com/repos/akka/akka-management/issues/218"},"comments":{"href":"https://api.github.com/repos/akka/akka-management/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-management/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-management/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-management/statuses/a0b4145c7f24c46d672c9062b5cc814f27b9ae7d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ktoso"}}