{"action":"created","comment":{"url":"https://api.github.com/repos/libero/walking-skeleton/pulls/comments/187637353","pull_request_review_id":119462455,"id":187637353,"diff_hunk":"@@ -1,20 +1,32 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n \n-<grammar xmlns=\"http://relaxng.org/ns/structure/1.0\" ns=\"http://libero.pub\">\n+<grammar ns=\"http://libero.pub\" xmlns=\"http://relaxng.org/ns/structure/1.0\"\n+    xmlns:a=\"http://relaxng.org/ns/compatibility/annotations/1.0\">\n \n     <include href=\"../core.rng\"/>\n \n     <start>\n+        <ref name=\"libero.body\"/>\n+    </start>\n \n-        <element name=\"body\">\n-            <ref name=\"libero.body.content\"/>\n-        </element>\n+    <div>\n+        <a:documentation>body element</a:documentation>","path":"api-dummy/public/schemas/libero/article/body.rng","position":17,"original_position":17,"commit_id":"4a67c815b4ecb3fe021c6510ff0d87f4ed3f6ef8","original_commit_id":"58a5ea0c53ceb02c7c895710fc921f511c7f5818","user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"XHTML seems too specific, while this kind of tags allow for introspection by tools (whether it is a build or process validating a schema or something that displays the text of the annotations) in a way that comments probably won't","created_at":"2018-05-11T14:48:31Z","updated_at":"2018-05-11T14:48:31Z","html_url":"https://github.com/libero/walking-skeleton/pull/21#discussion_r187637353","pull_request_url":"https://api.github.com/repos/libero/walking-skeleton/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/comments/187637353"},"html":{"href":"https://github.com/libero/walking-skeleton/pull/21#discussion_r187637353"},"pull_request":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/21"}},"in_reply_to_id":186675690},"pull_request":{"url":"https://api.github.com/repos/libero/walking-skeleton/pulls/21","id":186582870,"html_url":"https://github.com/libero/walking-skeleton/pull/21","diff_url":"https://github.com/libero/walking-skeleton/pull/21.diff","patch_url":"https://github.com/libero/walking-skeleton/pull/21.patch","issue_url":"https://api.github.com/repos/libero/walking-skeleton/issues/21","number":21,"state":"open","locked":false,"title":"Start standardising RELAX NG","user":{"login":"thewilkybarkid","id":1784740,"avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"Looking at tidying up the sample schemas a bit, since they should be looked at closely (even though the actual content is important at the this, the mechanism is).\r\n\r\n- Provide grouping\r\n    - Also add some documentation\r\n- Clear and consistent naming\r\n- More extensible\r\n    - Each element is in a `<define>` has two sub-`<define>`s, one for attributes, one for elements ('content'), even if they're empty (to allow for easy extension).\r\n\r\n---\r\n\r\nUsed the following for inspiration:\r\n\r\n- http://books.xmlschemata.org/relaxng/page2.html\r\n- https://www.oasis-open.org/committees/download.php/51768/proposal-13112-rng-stage-3.html\r\n- https://www.w3.org/MarkUp/2010/xhtml-m12n-relaxng-20101216/\r\n- https://www.tei-c.org/release/xml/tei/custom/schema/relaxng/tei_all.rng","created_at":"2018-05-08T09:56:00Z","updated_at":"2018-05-11T14:48:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b7d8c7250ba88c0ef4181942264876b20253aeb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},{"login":"seanwiseman","id":30619751,"avatar_url":"https://avatars2.githubusercontent.com/u/30619751?v=4","gravatar_id":"","url":"https://api.github.com/users/seanwiseman","html_url":"https://github.com/seanwiseman","followers_url":"https://api.github.com/users/seanwiseman/followers","following_url":"https://api.github.com/users/seanwiseman/following{/other_user}","gists_url":"https://api.github.com/users/seanwiseman/gists{/gist_id}","starred_url":"https://api.github.com/users/seanwiseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanwiseman/subscriptions","organizations_url":"https://api.github.com/users/seanwiseman/orgs","repos_url":"https://api.github.com/users/seanwiseman/repos","events_url":"https://api.github.com/users/seanwiseman/events{/privacy}","received_events_url":"https://api.github.com/users/seanwiseman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libero/walking-skeleton/pulls/21/commits","review_comments_url":"https://api.github.com/repos/libero/walking-skeleton/pulls/21/comments","review_comment_url":"https://api.github.com/repos/libero/walking-skeleton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libero/walking-skeleton/issues/21/comments","statuses_url":"https://api.github.com/repos/libero/walking-skeleton/statuses/4a67c815b4ecb3fe021c6510ff0d87f4ed3f6ef8","head":{"label":"libero:relaxng-standard","ref":"relaxng-standard","sha":"4a67c815b4ecb3fe021c6510ff0d87f4ed3f6ef8","user":{"login":"libero","id":37089447,"avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"repo":{"id":124056128,"name":"walking-skeleton","full_name":"libero/walking-skeleton","owner":{"login":"libero","id":37089447,"avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libero/walking-skeleton","description":"A walking skeleton of the scholarly publishing system","fork":false,"url":"https://api.github.com/repos/libero/walking-skeleton","forks_url":"https://api.github.com/repos/libero/walking-skeleton/forks","keys_url":"https://api.github.com/repos/libero/walking-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libero/walking-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libero/walking-skeleton/teams","hooks_url":"https://api.github.com/repos/libero/walking-skeleton/hooks","issue_events_url":"https://api.github.com/repos/libero/walking-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/libero/walking-skeleton/events","assignees_url":"https://api.github.com/repos/libero/walking-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/libero/walking-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/libero/walking-skeleton/tags","blobs_url":"https://api.github.com/repos/libero/walking-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libero/walking-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libero/walking-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/libero/walking-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libero/walking-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/libero/walking-skeleton/languages","stargazers_url":"https://api.github.com/repos/libero/walking-skeleton/stargazers","contributors_url":"https://api.github.com/repos/libero/walking-skeleton/contributors","subscribers_url":"https://api.github.com/repos/libero/walking-skeleton/subscribers","subscription_url":"https://api.github.com/repos/libero/walking-skeleton/subscription","commits_url":"https://api.github.com/repos/libero/walking-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/libero/walking-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/libero/walking-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/libero/walking-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/libero/walking-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/libero/walking-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libero/walking-skeleton/merges","archive_url":"https://api.github.com/repos/libero/walking-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libero/walking-skeleton/downloads","issues_url":"https://api.github.com/repos/libero/walking-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/libero/walking-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/libero/walking-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/libero/walking-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libero/walking-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/libero/walking-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/libero/walking-skeleton/deployments","created_at":"2018-03-06T09:42:40Z","updated_at":"2018-05-09T13:37:49Z","pushed_at":"2018-05-10T10:53:47Z","git_url":"git://github.com/libero/walking-skeleton.git","ssh_url":"git@github.com:libero/walking-skeleton.git","clone_url":"https://github.com/libero/walking-skeleton.git","svn_url":"https://github.com/libero/walking-skeleton","homepage":null,"size":457,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"libero:master","ref":"master","sha":"9ccd991a66983ea237691e34648756c52eae6065","user":{"login":"libero","id":37089447,"avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"repo":{"id":124056128,"name":"walking-skeleton","full_name":"libero/walking-skeleton","owner":{"login":"libero","id":37089447,"avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libero/walking-skeleton","description":"A walking skeleton of the scholarly publishing system","fork":false,"url":"https://api.github.com/repos/libero/walking-skeleton","forks_url":"https://api.github.com/repos/libero/walking-skeleton/forks","keys_url":"https://api.github.com/repos/libero/walking-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libero/walking-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libero/walking-skeleton/teams","hooks_url":"https://api.github.com/repos/libero/walking-skeleton/hooks","issue_events_url":"https://api.github.com/repos/libero/walking-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/libero/walking-skeleton/events","assignees_url":"https://api.github.com/repos/libero/walking-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/libero/walking-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/libero/walking-skeleton/tags","blobs_url":"https://api.github.com/repos/libero/walking-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libero/walking-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libero/walking-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/libero/walking-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libero/walking-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/libero/walking-skeleton/languages","stargazers_url":"https://api.github.com/repos/libero/walking-skeleton/stargazers","contributors_url":"https://api.github.com/repos/libero/walking-skeleton/contributors","subscribers_url":"https://api.github.com/repos/libero/walking-skeleton/subscribers","subscription_url":"https://api.github.com/repos/libero/walking-skeleton/subscription","commits_url":"https://api.github.com/repos/libero/walking-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/libero/walking-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/libero/walking-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/libero/walking-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/libero/walking-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/libero/walking-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libero/walking-skeleton/merges","archive_url":"https://api.github.com/repos/libero/walking-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libero/walking-skeleton/downloads","issues_url":"https://api.github.com/repos/libero/walking-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/libero/walking-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/libero/walking-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/libero/walking-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libero/walking-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/libero/walking-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/libero/walking-skeleton/deployments","created_at":"2018-03-06T09:42:40Z","updated_at":"2018-05-09T13:37:49Z","pushed_at":"2018-05-10T10:53:47Z","git_url":"git://github.com/libero/walking-skeleton.git","ssh_url":"git@github.com:libero/walking-skeleton.git","clone_url":"https://github.com/libero/walking-skeleton.git","svn_url":"https://github.com/libero/walking-skeleton","homepage":null,"size":457,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/21"},"html":{"href":"https://github.com/libero/walking-skeleton/pull/21"},"issue":{"href":"https://api.github.com/repos/libero/walking-skeleton/issues/21"},"comments":{"href":"https://api.github.com/repos/libero/walking-skeleton/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libero/walking-skeleton/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/libero/walking-skeleton/statuses/4a67c815b4ecb3fe021c6510ff0d87f4ed3f6ef8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giorgiosironi"}}