{"action":"created","issue":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4978","repository_url":"https://api.github.com/repos/Beep6581/RawTherapee","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4978/labels{/name}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4978/comments","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4978/events","html_url":"https://github.com/Beep6581/RawTherapee/issues/4978","id":379600444,"node_id":"MDU6SXNzdWUzNzk2MDA0NDQ=","number":4978,"title":"Need pointer on Mac OS build","user":{"login":"dmccallie","id":12226567,"node_id":"MDQ6VXNlcjEyMjI2NTY3","avatar_url":"https://avatars0.githubusercontent.com/u/12226567?v=4","gravatar_id":"","url":"https://api.github.com/users/dmccallie","html_url":"https://github.com/dmccallie","followers_url":"https://api.github.com/users/dmccallie/followers","following_url":"https://api.github.com/users/dmccallie/following{/other_user}","gists_url":"https://api.github.com/users/dmccallie/gists{/gist_id}","starred_url":"https://api.github.com/users/dmccallie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmccallie/subscriptions","organizations_url":"https://api.github.com/users/dmccallie/orgs","repos_url":"https://api.github.com/users/dmccallie/repos","events_url":"https://api.github.com/users/dmccallie/events{/privacy}","received_events_url":"https://api.github.com/users/dmccallie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-12T02:48:48Z","updated_at":"2018-11-13T04:57:00Z","closed_at":null,"author_association":"NONE","body":"Hello,\r\nNewbie here, who would like to contribute. Figured I'd start by getting a successful Mac OS X build as first step, so tried building the current release (tag = 5.4).  I started with a fresh install of macports, and followed the instructions on RawPedia, to the tee, including the libiconv patch (but not a cairo patch, which was unclear.) Mac OS = 10.13.6.  Used clang-3.9, as per RawPedia instructions.\r\n\r\n(BTW, I got lots of \"warning\" errors during compiles. Is that normal?  (i.e., many warnings were about \"MyExpander::add' hides overloaded virtual function\" but there were others.)\r\n\r\nOther than the warnings, the CMake and subsequent build worked fine, and created a executable.  When I double clicked on the executable (in the build directory,) I get an immediate crash, the head of which is pasted below.\r\n\r\nI'm new to this, and don't know where to start. This is an awesome project, and I hope I can contribute.  I'm new to C++ programming on the mac.  I may be doing something really stupid.  Thanks in advance!\r\n\r\ndavid\r\n------------\r\n```\r\n\r\nProcess:               rawtherapee-bin [52324]\r\nPath:                  /Users/USER/*/RawTherapee.app/Contents/MacOS/rawtherapee-bin\r\nIdentifier:            com.rawtherapee.rawtherapee\r\nVersion:               5.4.0 (5.4.0)\r\nCode Type:             X86-64 (Native)\r\nParent Process:        ??? [1]\r\nResponsible:           rawtherapee-bin [52324]\r\n\r\nUser ID:               501\r\n\r\nDate/Time:             2018-11-11 20:14:16.604 -0600\r\nOS Version:            Mac OS X 10.13.6 (17G3025)\r\nReport Version:        12\r\nAnonymous UUID:        02E5155D-55DA-C9BE-851E-44A5FED047A1\r\n\r\n\r\nTime Awake Since Boot: 170000 seconds\r\n\r\nSystem Integrity Protection: enabled\r\n\r\nCrashed Thread:        0  Dispatch queue: com.apple.main-thread\r\n\r\nException Type:        EXC_BAD_ACCESS (SIGSEGV)\r\nException Codes:       KERN_INVALID_ADDRESS at 0x0000000000000038\r\nException Note:        EXC_CORPSE_NOTIFY\r\n\r\nTermination Signal:    Segmentation fault: 11\r\nTermination Reason:    Namespace SIGNAL, Code 0xb\r\nTerminating Process:   exc handler [0]\r\n\r\nVM Regions Near 0x38:\r\n--> \r\n    __TEXT                 000000010f6d3000-000000010febb000 [ 8096K] r-x/rwx SM=COW  D\u0003 [/Users/david/programs/code-rawtherapee/build/RawTherapee.app/Contents/MacOS/rawtherapee-bin]\r\n\r\nThread 0 Crashed:: Dispatch queue: com.apple.main-thread\r\n0   libsystem_platform.dylib      \t0x00007fff66525f7d _platform_memmove$VARIANT$Haswell + 93\r\n1   libpng16.16.dylib             \t0x00000001116f673c png_combine_row + 319\r\n2   libpng16.16.dylib             \t0x00000001116ea541 png_read_row + 866\r\n3   libpng16.16.dylib             \t0x00000001116ea754 png_read_image + 163\r\n4   libpixbufloader-png.so        \t0x0000000111df5c5f gdk_pixbuf__png_image_load + 387\r\n5   libgdk_pixbuf-2.0.0.dylib     \t0x000000011161f869 gdk_pixbuf_new_from_file + 201\r\n6   libgdkmm-3.0.1.dylib          \t0x0000000110d20571 Gdk::Pixbuf::create_from_file(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 45\r\n7   rawtherapee-bin               \t0x000000010f82167b MyExpander::init() + 75\r\n8   rawtherapee-bin               \t0x000000010f87bc09 (anonymous namespace)::create_rt_window() + 169\r\n9   rawtherapee-bin               \t0x000000010f87b065 main + 5189\r\n10  libdyld.dylib                 \t0x00007fff66214015 start + 1'\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments/438136867","html_url":"https://github.com/Beep6581/RawTherapee/issues/4978#issuecomment-438136867","issue_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4978","id":438136867,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODEzNjg2Nw==","user":{"login":"dmccallie","id":12226567,"node_id":"MDQ6VXNlcjEyMjI2NTY3","avatar_url":"https://avatars0.githubusercontent.com/u/12226567?v=4","gravatar_id":"","url":"https://api.github.com/users/dmccallie","html_url":"https://github.com/dmccallie","followers_url":"https://api.github.com/users/dmccallie/followers","following_url":"https://api.github.com/users/dmccallie/following{/other_user}","gists_url":"https://api.github.com/users/dmccallie/gists{/gist_id}","starred_url":"https://api.github.com/users/dmccallie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmccallie/subscriptions","organizations_url":"https://api.github.com/users/dmccallie/orgs","repos_url":"https://api.github.com/users/dmccallie/repos","events_url":"https://api.github.com/users/dmccallie/events{/privacy}","received_events_url":"https://api.github.com/users/dmccallie/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T04:57:00Z","updated_at":"2018-11-13T04:57:00Z","author_association":"NONE","body":"Thanks for the suggestions.  I got it to successfully build :)\r\n\r\nI found the problem - for some reason, the linking step was pulling in a mix of Homebrew libraries and mac ports libraries, despite the fact that all the necessary mac ports libraries were present.\r\n\r\nI had removed the Homebrew libraries from $PATH, but apparently that's not enough - the linker was finding libraries through some other setting that I don't understand. I ended up with a brute force solution - deleting the entire Homebrew installation - which fixed the crash.\r\n\r\nIn the long run, it would be nice if rt supported builds with Homebrew, as I think it's  more popular than mac ports these days.  Initially, I tried to do the build with pure Homebrew, but was unable to get it to work. \r\n\r\nNow, a new question - I searched around for a \"hello world\" example of how to add a new feature to the code, but couldn't find anything.  Has anyone put together a basic tutorial on the program's logic flow? \r\n\r\nThanks again,\r\n--david\r\n"}}
{"actor":{"display_login":"dmccallie"}}