{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/168916529","pull_request_review_id":97369067,"id":168916529,"diff_hunk":"@@ -62,16 +62,27 @@ mono_hwcap_arch_init (void)\n \t\t\tmono_hwcap_ppc_has_multiple_ls_units = TRUE;\n \t}\n #elif defined(_AIX)\n-\t/*\n-\t * FIXME: ensure these are valid, and we match Linux ones\n-\t */\n-\tmono_hwcap_ppc_is_isa_2x = __power_4_andup() ? TRUE : FALSE;\n-\tmono_hwcap_ppc_is_isa_64 = __cpu64() ? TRUE: FALSE;\n+\tif (__cpu64())\n+\t\tmono_hwcap_ppc_is_isa_64 = TRUE;\n+\tif (__power_4_andup())\n+\t\tmono_hwcap_ppc_is_isa_2x = TRUE;\n+\tif (__power_5_andup())\n+\t\tmono_hwcap_ppc_has_icache_snoop = TRUE;","path":"mono/utils/mono-hwcap-ppc.c","position":14,"original_position":14,"commit_id":"1eaeb8e4d34778dd371d71fcd58202253fb62cfe","original_commit_id":"1eaeb8e4d34778dd371d71fcd58202253fb62cfe","user":{"login":"vargaz","id":186301,"avatar_url":"https://avatars3.githubusercontent.com/u/186301?v=4","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},"body":"The if () is also fine.\r\n","created_at":"2018-02-17T08:38:27Z","updated_at":"2018-02-17T08:38:27Z","html_url":"https://github.com/mono/mono/pull/6934#discussion_r168916529","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/6934","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/168916529"},"html":{"href":"https://github.com/mono/mono/pull/6934#discussion_r168916529"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/6934"}},"in_reply_to_id":168915828},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/6934","id":168379683,"html_url":"https://github.com/mono/mono/pull/6934","diff_url":"https://github.com/mono/mono/pull/6934.diff","patch_url":"https://github.com/mono/mono/pull/6934.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/6934","number":6934,"state":"open","locked":false,"title":"Assorted fixes for AIX and i","user":{"login":"NattyNarwhal","id":3161292,"avatar_url":"https://avatars1.githubusercontent.com/u/3161292?v=4","gravatar_id":"","url":"https://api.github.com/users/NattyNarwhal","html_url":"https://github.com/NattyNarwhal","followers_url":"https://api.github.com/users/NattyNarwhal/followers","following_url":"https://api.github.com/users/NattyNarwhal/following{/other_user}","gists_url":"https://api.github.com/users/NattyNarwhal/gists{/gist_id}","starred_url":"https://api.github.com/users/NattyNarwhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NattyNarwhal/subscriptions","organizations_url":"https://api.github.com/users/NattyNarwhal/orgs","repos_url":"https://api.github.com/users/NattyNarwhal/repos","events_url":"https://api.github.com/users/NattyNarwhal/events{/privacy}","received_events_url":"https://api.github.com/users/NattyNarwhal/received_events","type":"User","site_admin":false},"body":"* Fix a bug I introduced when changing the MonoArray vector\r\n  type; array lengths wouldn't match up to what they\r\n  actually were on AIX/i.\r\n\r\n* Use a custom mkdtemp implementation on Unices without\r\n  mkdtemp - and ones that do but don't necessarily have it,\r\n  like i 7.1, which lacks mkdtemp in its libc. We can't\r\n  determine this at runtime, so AIX will have to suffer\r\n  with i.\r\n\r\n* Enhance PowerPC hwcap on AIX to detect features like\r\n  Linux does.\r\n\r\n* Don't use clock_getres on AIX, because i 7.1 doesn't have\r\n  that syscall - it's in libc, but it'll bomb out with a\r\n  SIGILL; the way unimplemented opcodes are handled on i.\r\n\r\n\r\n\r\n<!--\r\nThank you for your Pull Request!\r\n\r\nIf you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.\r\n\r\nDoes your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number\r\n-->\r\n","created_at":"2018-02-10T01:56:01Z","updated_at":"2018-02-17T08:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1893b76301b83d0abb05bb93964874e4a0b744eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kumpera","id":5738,"avatar_url":"https://avatars0.githubusercontent.com/u/5738?v=4","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},{"login":"alexrp","id":44076,"avatar_url":"https://avatars0.githubusercontent.com/u/44076?v=4","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},{"login":"marek-safar","id":250852,"avatar_url":"https://avatars1.githubusercontent.com/u/250852?v=4","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/6934/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/6934/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/6934/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/1eaeb8e4d34778dd371d71fcd58202253fb62cfe","head":{"label":"NattyNarwhal:more-aix-fixes","ref":"more-aix-fixes","sha":"1eaeb8e4d34778dd371d71fcd58202253fb62cfe","user":{"login":"NattyNarwhal","id":3161292,"avatar_url":"https://avatars1.githubusercontent.com/u/3161292?v=4","gravatar_id":"","url":"https://api.github.com/users/NattyNarwhal","html_url":"https://github.com/NattyNarwhal","followers_url":"https://api.github.com/users/NattyNarwhal/followers","following_url":"https://api.github.com/users/NattyNarwhal/following{/other_user}","gists_url":"https://api.github.com/users/NattyNarwhal/gists{/gist_id}","starred_url":"https://api.github.com/users/NattyNarwhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NattyNarwhal/subscriptions","organizations_url":"https://api.github.com/users/NattyNarwhal/orgs","repos_url":"https://api.github.com/users/NattyNarwhal/repos","events_url":"https://api.github.com/users/NattyNarwhal/events{/privacy}","received_events_url":"https://api.github.com/users/NattyNarwhal/received_events","type":"User","site_admin":false},"repo":{"id":81875136,"name":"mono","full_name":"NattyNarwhal/mono","owner":{"login":"NattyNarwhal","id":3161292,"avatar_url":"https://avatars1.githubusercontent.com/u/3161292?v=4","gravatar_id":"","url":"https://api.github.com/users/NattyNarwhal","html_url":"https://github.com/NattyNarwhal","followers_url":"https://api.github.com/users/NattyNarwhal/followers","following_url":"https://api.github.com/users/NattyNarwhal/following{/other_user}","gists_url":"https://api.github.com/users/NattyNarwhal/gists{/gist_id}","starred_url":"https://api.github.com/users/NattyNarwhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NattyNarwhal/subscriptions","organizations_url":"https://api.github.com/users/NattyNarwhal/orgs","repos_url":"https://api.github.com/users/NattyNarwhal/repos","events_url":"https://api.github.com/users/NattyNarwhal/events{/privacy}","received_events_url":"https://api.github.com/users/NattyNarwhal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NattyNarwhal/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/NattyNarwhal/mono","forks_url":"https://api.github.com/repos/NattyNarwhal/mono/forks","keys_url":"https://api.github.com/repos/NattyNarwhal/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NattyNarwhal/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NattyNarwhal/mono/teams","hooks_url":"https://api.github.com/repos/NattyNarwhal/mono/hooks","issue_events_url":"https://api.github.com/repos/NattyNarwhal/mono/issues/events{/number}","events_url":"https://api.github.com/repos/NattyNarwhal/mono/events","assignees_url":"https://api.github.com/repos/NattyNarwhal/mono/assignees{/user}","branches_url":"https://api.github.com/repos/NattyNarwhal/mono/branches{/branch}","tags_url":"https://api.github.com/repos/NattyNarwhal/mono/tags","blobs_url":"https://api.github.com/repos/NattyNarwhal/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NattyNarwhal/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NattyNarwhal/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/NattyNarwhal/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NattyNarwhal/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/NattyNarwhal/mono/languages","stargazers_url":"https://api.github.com/repos/NattyNarwhal/mono/stargazers","contributors_url":"https://api.github.com/repos/NattyNarwhal/mono/contributors","subscribers_url":"https://api.github.com/repos/NattyNarwhal/mono/subscribers","subscription_url":"https://api.github.com/repos/NattyNarwhal/mono/subscription","commits_url":"https://api.github.com/repos/NattyNarwhal/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/NattyNarwhal/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/NattyNarwhal/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/NattyNarwhal/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/NattyNarwhal/mono/contents/{+path}","compare_url":"https://api.github.com/repos/NattyNarwhal/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NattyNarwhal/mono/merges","archive_url":"https://api.github.com/repos/NattyNarwhal/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NattyNarwhal/mono/downloads","issues_url":"https://api.github.com/repos/NattyNarwhal/mono/issues{/number}","pulls_url":"https://api.github.com/repos/NattyNarwhal/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/NattyNarwhal/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/NattyNarwhal/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NattyNarwhal/mono/labels{/name}","releases_url":"https://api.github.com/repos/NattyNarwhal/mono/releases{/id}","deployments_url":"https://api.github.com/repos/NattyNarwhal/mono/deployments","created_at":"2017-02-13T21:44:49Z","updated_at":"2017-02-13T21:47:01Z","pushed_at":"2018-02-16T20:01:54Z","git_url":"git://github.com/NattyNarwhal/mono.git","ssh_url":"git@github.com:NattyNarwhal/mono.git","clone_url":"https://github.com/NattyNarwhal/mono.git","svn_url":"https://github.com/NattyNarwhal/mono","homepage":"http://www.mono-project.com/","size":462206,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"284c5afdf4363aec956ce370c86fc44458fffe6c","user":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2018-02-17T04:34:39Z","pushed_at":"2018-02-17T07:21:05Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":466451,"stargazers_count":6186,"watchers_count":6186,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2786,"mirror_url":null,"archived":false,"open_issues_count":365,"license":null,"forks":2786,"open_issues":365,"watchers":6186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/6934"},"html":{"href":"https://github.com/mono/mono/pull/6934"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/6934"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/6934/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/6934/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/6934/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/1eaeb8e4d34778dd371d71fcd58202253fb62cfe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vargaz"}}